1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements the visitICmp and visitFCmp functions. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "InstCombineInternal.h" 15 #include "llvm/ADT/APSInt.h" 16 #include "llvm/ADT/SetVector.h" 17 #include "llvm/ADT/Statistic.h" 18 #include "llvm/Analysis/ConstantFolding.h" 19 #include "llvm/Analysis/InstructionSimplify.h" 20 #include "llvm/Analysis/MemoryBuiltins.h" 21 #include "llvm/Analysis/TargetLibraryInfo.h" 22 #include "llvm/Analysis/VectorUtils.h" 23 #include "llvm/IR/ConstantRange.h" 24 #include "llvm/IR/DataLayout.h" 25 #include "llvm/IR/GetElementPtrTypeIterator.h" 26 #include "llvm/IR/IntrinsicInst.h" 27 #include "llvm/IR/PatternMatch.h" 28 #include "llvm/Support/Debug.h" 29 30 using namespace llvm; 31 using namespace PatternMatch; 32 33 #define DEBUG_TYPE "instcombine" 34 35 // How many times is a select replaced by one of its operands? 36 STATISTIC(NumSel, "Number of select opts"); 37 38 39 static ConstantInt *extractElement(Constant *V, Constant *Idx) { 40 return cast<ConstantInt>(ConstantExpr::getExtractElement(V, Idx)); 41 } 42 43 static bool hasAddOverflow(ConstantInt *Result, 44 ConstantInt *In1, ConstantInt *In2, 45 bool IsSigned) { 46 if (!IsSigned) 47 return Result->getValue().ult(In1->getValue()); 48 49 if (In2->isNegative()) 50 return Result->getValue().sgt(In1->getValue()); 51 return Result->getValue().slt(In1->getValue()); 52 } 53 54 /// Compute Result = In1+In2, returning true if the result overflowed for this 55 /// type. 56 static bool addWithOverflow(Constant *&Result, Constant *In1, 57 Constant *In2, bool IsSigned = false) { 58 Result = ConstantExpr::getAdd(In1, In2); 59 60 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) { 61 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) { 62 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i); 63 if (hasAddOverflow(extractElement(Result, Idx), 64 extractElement(In1, Idx), 65 extractElement(In2, Idx), 66 IsSigned)) 67 return true; 68 } 69 return false; 70 } 71 72 return hasAddOverflow(cast<ConstantInt>(Result), 73 cast<ConstantInt>(In1), cast<ConstantInt>(In2), 74 IsSigned); 75 } 76 77 static bool hasSubOverflow(ConstantInt *Result, 78 ConstantInt *In1, ConstantInt *In2, 79 bool IsSigned) { 80 if (!IsSigned) 81 return Result->getValue().ugt(In1->getValue()); 82 83 if (In2->isNegative()) 84 return Result->getValue().slt(In1->getValue()); 85 86 return Result->getValue().sgt(In1->getValue()); 87 } 88 89 /// Compute Result = In1-In2, returning true if the result overflowed for this 90 /// type. 91 static bool subWithOverflow(Constant *&Result, Constant *In1, 92 Constant *In2, bool IsSigned = false) { 93 Result = ConstantExpr::getSub(In1, In2); 94 95 if (VectorType *VTy = dyn_cast<VectorType>(In1->getType())) { 96 for (unsigned i = 0, e = VTy->getNumElements(); i != e; ++i) { 97 Constant *Idx = ConstantInt::get(Type::getInt32Ty(In1->getContext()), i); 98 if (hasSubOverflow(extractElement(Result, Idx), 99 extractElement(In1, Idx), 100 extractElement(In2, Idx), 101 IsSigned)) 102 return true; 103 } 104 return false; 105 } 106 107 return hasSubOverflow(cast<ConstantInt>(Result), 108 cast<ConstantInt>(In1), cast<ConstantInt>(In2), 109 IsSigned); 110 } 111 112 /// Given an icmp instruction, return true if any use of this comparison is a 113 /// branch on sign bit comparison. 114 static bool isBranchOnSignBitCheck(ICmpInst &I, bool isSignBit) { 115 for (auto *U : I.users()) 116 if (isa<BranchInst>(U)) 117 return isSignBit; 118 return false; 119 } 120 121 /// Given an exploded icmp instruction, return true if the comparison only 122 /// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the 123 /// result of the comparison is true when the input value is signed. 124 static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS, 125 bool &TrueIfSigned) { 126 switch (Pred) { 127 case ICmpInst::ICMP_SLT: // True if LHS s< 0 128 TrueIfSigned = true; 129 return RHS == 0; 130 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1 131 TrueIfSigned = true; 132 return RHS.isAllOnesValue(); 133 case ICmpInst::ICMP_SGT: // True if LHS s> -1 134 TrueIfSigned = false; 135 return RHS.isAllOnesValue(); 136 case ICmpInst::ICMP_UGT: 137 // True if LHS u> RHS and RHS == high-bit-mask - 1 138 TrueIfSigned = true; 139 return RHS.isMaxSignedValue(); 140 case ICmpInst::ICMP_UGE: 141 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc) 142 TrueIfSigned = true; 143 return RHS.isSignBit(); 144 default: 145 return false; 146 } 147 } 148 149 /// Returns true if the exploded icmp can be expressed as a signed comparison 150 /// to zero and updates the predicate accordingly. 151 /// The signedness of the comparison is preserved. 152 /// TODO: Refactor with decomposeBitTestICmp()? 153 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 154 if (!ICmpInst::isSigned(Pred)) 155 return false; 156 157 if (C == 0) 158 return ICmpInst::isRelational(Pred); 159 160 if (C == 1) { 161 if (Pred == ICmpInst::ICMP_SLT) { 162 Pred = ICmpInst::ICMP_SLE; 163 return true; 164 } 165 } else if (C.isAllOnesValue()) { 166 if (Pred == ICmpInst::ICMP_SGT) { 167 Pred = ICmpInst::ICMP_SGE; 168 return true; 169 } 170 } 171 172 return false; 173 } 174 175 /// Given a signed integer type and a set of known zero and one bits, compute 176 /// the maximum and minimum values that could have the specified known zero and 177 /// known one bits, returning them in Min/Max. 178 static void computeSignedMinMaxValuesFromKnownBits(const APInt &KnownZero, 179 const APInt &KnownOne, 180 APInt &Min, APInt &Max) { 181 assert(KnownZero.getBitWidth() == KnownOne.getBitWidth() && 182 KnownZero.getBitWidth() == Min.getBitWidth() && 183 KnownZero.getBitWidth() == Max.getBitWidth() && 184 "KnownZero, KnownOne and Min, Max must have equal bitwidth."); 185 APInt UnknownBits = ~(KnownZero|KnownOne); 186 187 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign 188 // bit if it is unknown. 189 Min = KnownOne; 190 Max = KnownOne|UnknownBits; 191 192 if (UnknownBits.isNegative()) { // Sign bit is unknown 193 Min.setBit(Min.getBitWidth()-1); 194 Max.clearBit(Max.getBitWidth()-1); 195 } 196 } 197 198 /// Given an unsigned integer type and a set of known zero and one bits, compute 199 /// the maximum and minimum values that could have the specified known zero and 200 /// known one bits, returning them in Min/Max. 201 static void computeUnsignedMinMaxValuesFromKnownBits(const APInt &KnownZero, 202 const APInt &KnownOne, 203 APInt &Min, APInt &Max) { 204 assert(KnownZero.getBitWidth() == KnownOne.getBitWidth() && 205 KnownZero.getBitWidth() == Min.getBitWidth() && 206 KnownZero.getBitWidth() == Max.getBitWidth() && 207 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth."); 208 APInt UnknownBits = ~(KnownZero|KnownOne); 209 210 // The minimum value is when the unknown bits are all zeros. 211 Min = KnownOne; 212 // The maximum value is when the unknown bits are all ones. 213 Max = KnownOne|UnknownBits; 214 } 215 216 /// This is called when we see this pattern: 217 /// cmp pred (load (gep GV, ...)), cmpcst 218 /// where GV is a global variable with a constant initializer. Try to simplify 219 /// this into some simple computation that does not need the load. For example 220 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 221 /// 222 /// If AndCst is non-null, then the loaded value is masked with that constant 223 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 224 Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 225 GlobalVariable *GV, 226 CmpInst &ICI, 227 ConstantInt *AndCst) { 228 Constant *Init = GV->getInitializer(); 229 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 230 return nullptr; 231 232 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 233 if (ArrayElementCount > 1024) return nullptr; // Don't blow up on huge arrays. 234 235 // There are many forms of this optimization we can handle, for now, just do 236 // the simple index into a single-dimensional array. 237 // 238 // Require: GEP GV, 0, i {{, constant indices}} 239 if (GEP->getNumOperands() < 3 || 240 !isa<ConstantInt>(GEP->getOperand(1)) || 241 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 242 isa<Constant>(GEP->getOperand(2))) 243 return nullptr; 244 245 // Check that indices after the variable are constants and in-range for the 246 // type they index. Collect the indices. This is typically for arrays of 247 // structs. 248 SmallVector<unsigned, 4> LaterIndices; 249 250 Type *EltTy = Init->getType()->getArrayElementType(); 251 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 252 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 253 if (!Idx) return nullptr; // Variable index. 254 255 uint64_t IdxVal = Idx->getZExtValue(); 256 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 257 258 if (StructType *STy = dyn_cast<StructType>(EltTy)) 259 EltTy = STy->getElementType(IdxVal); 260 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 261 if (IdxVal >= ATy->getNumElements()) return nullptr; 262 EltTy = ATy->getElementType(); 263 } else { 264 return nullptr; // Unknown type. 265 } 266 267 LaterIndices.push_back(IdxVal); 268 } 269 270 enum { Overdefined = -3, Undefined = -2 }; 271 272 // Variables for our state machines. 273 274 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 275 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 276 // and 87 is the second (and last) index. FirstTrueElement is -2 when 277 // undefined, otherwise set to the first true element. SecondTrueElement is 278 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 279 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 280 281 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 282 // form "i != 47 & i != 87". Same state transitions as for true elements. 283 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 284 285 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 286 /// define a state machine that triggers for ranges of values that the index 287 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 288 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 289 /// index in the range (inclusive). We use -2 for undefined here because we 290 /// use relative comparisons and don't want 0-1 to match -1. 291 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 292 293 // MagicBitvector - This is a magic bitvector where we set a bit if the 294 // comparison is true for element 'i'. If there are 64 elements or less in 295 // the array, this will fully represent all the comparison results. 296 uint64_t MagicBitvector = 0; 297 298 // Scan the array and see if one of our patterns matches. 299 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 300 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 301 Constant *Elt = Init->getAggregateElement(i); 302 if (!Elt) return nullptr; 303 304 // If this is indexing an array of structures, get the structure element. 305 if (!LaterIndices.empty()) 306 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 307 308 // If the element is masked, handle it. 309 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 310 311 // Find out if the comparison would be true or false for the i'th element. 312 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 313 CompareRHS, DL, &TLI); 314 // If the result is undef for this element, ignore it. 315 if (isa<UndefValue>(C)) { 316 // Extend range state machines to cover this element in case there is an 317 // undef in the middle of the range. 318 if (TrueRangeEnd == (int)i-1) 319 TrueRangeEnd = i; 320 if (FalseRangeEnd == (int)i-1) 321 FalseRangeEnd = i; 322 continue; 323 } 324 325 // If we can't compute the result for any of the elements, we have to give 326 // up evaluating the entire conditional. 327 if (!isa<ConstantInt>(C)) return nullptr; 328 329 // Otherwise, we know if the comparison is true or false for this element, 330 // update our state machines. 331 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 332 333 // State machine for single/double/range index comparison. 334 if (IsTrueForElt) { 335 // Update the TrueElement state machine. 336 if (FirstTrueElement == Undefined) 337 FirstTrueElement = TrueRangeEnd = i; // First true element. 338 else { 339 // Update double-compare state machine. 340 if (SecondTrueElement == Undefined) 341 SecondTrueElement = i; 342 else 343 SecondTrueElement = Overdefined; 344 345 // Update range state machine. 346 if (TrueRangeEnd == (int)i-1) 347 TrueRangeEnd = i; 348 else 349 TrueRangeEnd = Overdefined; 350 } 351 } else { 352 // Update the FalseElement state machine. 353 if (FirstFalseElement == Undefined) 354 FirstFalseElement = FalseRangeEnd = i; // First false element. 355 else { 356 // Update double-compare state machine. 357 if (SecondFalseElement == Undefined) 358 SecondFalseElement = i; 359 else 360 SecondFalseElement = Overdefined; 361 362 // Update range state machine. 363 if (FalseRangeEnd == (int)i-1) 364 FalseRangeEnd = i; 365 else 366 FalseRangeEnd = Overdefined; 367 } 368 } 369 370 // If this element is in range, update our magic bitvector. 371 if (i < 64 && IsTrueForElt) 372 MagicBitvector |= 1ULL << i; 373 374 // If all of our states become overdefined, bail out early. Since the 375 // predicate is expensive, only check it every 8 elements. This is only 376 // really useful for really huge arrays. 377 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 378 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 379 FalseRangeEnd == Overdefined) 380 return nullptr; 381 } 382 383 // Now that we've scanned the entire array, emit our new comparison(s). We 384 // order the state machines in complexity of the generated code. 385 Value *Idx = GEP->getOperand(2); 386 387 // If the index is larger than the pointer size of the target, truncate the 388 // index down like the GEP would do implicitly. We don't have to do this for 389 // an inbounds GEP because the index can't be out of range. 390 if (!GEP->isInBounds()) { 391 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 392 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 393 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize) 394 Idx = Builder->CreateTrunc(Idx, IntPtrTy); 395 } 396 397 // If the comparison is only true for one or two elements, emit direct 398 // comparisons. 399 if (SecondTrueElement != Overdefined) { 400 // None true -> false. 401 if (FirstTrueElement == Undefined) 402 return replaceInstUsesWith(ICI, Builder->getFalse()); 403 404 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 405 406 // True for one element -> 'i == 47'. 407 if (SecondTrueElement == Undefined) 408 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 409 410 // True for two elements -> 'i == 47 | i == 72'. 411 Value *C1 = Builder->CreateICmpEQ(Idx, FirstTrueIdx); 412 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 413 Value *C2 = Builder->CreateICmpEQ(Idx, SecondTrueIdx); 414 return BinaryOperator::CreateOr(C1, C2); 415 } 416 417 // If the comparison is only false for one or two elements, emit direct 418 // comparisons. 419 if (SecondFalseElement != Overdefined) { 420 // None false -> true. 421 if (FirstFalseElement == Undefined) 422 return replaceInstUsesWith(ICI, Builder->getTrue()); 423 424 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 425 426 // False for one element -> 'i != 47'. 427 if (SecondFalseElement == Undefined) 428 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 429 430 // False for two elements -> 'i != 47 & i != 72'. 431 Value *C1 = Builder->CreateICmpNE(Idx, FirstFalseIdx); 432 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 433 Value *C2 = Builder->CreateICmpNE(Idx, SecondFalseIdx); 434 return BinaryOperator::CreateAnd(C1, C2); 435 } 436 437 // If the comparison can be replaced with a range comparison for the elements 438 // where it is true, emit the range check. 439 if (TrueRangeEnd != Overdefined) { 440 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 441 442 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 443 if (FirstTrueElement) { 444 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 445 Idx = Builder->CreateAdd(Idx, Offs); 446 } 447 448 Value *End = ConstantInt::get(Idx->getType(), 449 TrueRangeEnd-FirstTrueElement+1); 450 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 451 } 452 453 // False range check. 454 if (FalseRangeEnd != Overdefined) { 455 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 456 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 457 if (FirstFalseElement) { 458 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 459 Idx = Builder->CreateAdd(Idx, Offs); 460 } 461 462 Value *End = ConstantInt::get(Idx->getType(), 463 FalseRangeEnd-FirstFalseElement); 464 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 465 } 466 467 // If a magic bitvector captures the entire comparison state 468 // of this load, replace it with computation that does: 469 // ((magic_cst >> i) & 1) != 0 470 { 471 Type *Ty = nullptr; 472 473 // Look for an appropriate type: 474 // - The type of Idx if the magic fits 475 // - The smallest fitting legal type if we have a DataLayout 476 // - Default to i32 477 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 478 Ty = Idx->getType(); 479 else 480 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 481 482 if (Ty) { 483 Value *V = Builder->CreateIntCast(Idx, Ty, false); 484 V = Builder->CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 485 V = Builder->CreateAnd(ConstantInt::get(Ty, 1), V); 486 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 487 } 488 } 489 490 return nullptr; 491 } 492 493 /// Return a value that can be used to compare the *offset* implied by a GEP to 494 /// zero. For example, if we have &A[i], we want to return 'i' for 495 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 496 /// are involved. The above expression would also be legal to codegen as 497 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 498 /// This latter form is less amenable to optimization though, and we are allowed 499 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 500 /// 501 /// If we can't emit an optimized form for this expression, this returns null. 502 /// 503 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC, 504 const DataLayout &DL) { 505 gep_type_iterator GTI = gep_type_begin(GEP); 506 507 // Check to see if this gep only has a single variable index. If so, and if 508 // any constant indices are a multiple of its scale, then we can compute this 509 // in terms of the scale of the variable index. For example, if the GEP 510 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 511 // because the expression will cross zero at the same point. 512 unsigned i, e = GEP->getNumOperands(); 513 int64_t Offset = 0; 514 for (i = 1; i != e; ++i, ++GTI) { 515 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 516 // Compute the aggregate offset of constant indices. 517 if (CI->isZero()) continue; 518 519 // Handle a struct index, which adds its field offset to the pointer. 520 if (StructType *STy = GTI.getStructTypeOrNull()) { 521 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 522 } else { 523 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 524 Offset += Size*CI->getSExtValue(); 525 } 526 } else { 527 // Found our variable index. 528 break; 529 } 530 } 531 532 // If there are no variable indices, we must have a constant offset, just 533 // evaluate it the general way. 534 if (i == e) return nullptr; 535 536 Value *VariableIdx = GEP->getOperand(i); 537 // Determine the scale factor of the variable element. For example, this is 538 // 4 if the variable index is into an array of i32. 539 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 540 541 // Verify that there are no other variable indices. If so, emit the hard way. 542 for (++i, ++GTI; i != e; ++i, ++GTI) { 543 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 544 if (!CI) return nullptr; 545 546 // Compute the aggregate offset of constant indices. 547 if (CI->isZero()) continue; 548 549 // Handle a struct index, which adds its field offset to the pointer. 550 if (StructType *STy = GTI.getStructTypeOrNull()) { 551 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 552 } else { 553 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 554 Offset += Size*CI->getSExtValue(); 555 } 556 } 557 558 // Okay, we know we have a single variable index, which must be a 559 // pointer/array/vector index. If there is no offset, life is simple, return 560 // the index. 561 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 562 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 563 if (Offset == 0) { 564 // Cast to intptrty in case a truncation occurs. If an extension is needed, 565 // we don't need to bother extending: the extension won't affect where the 566 // computation crosses zero. 567 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) { 568 VariableIdx = IC.Builder->CreateTrunc(VariableIdx, IntPtrTy); 569 } 570 return VariableIdx; 571 } 572 573 // Otherwise, there is an index. The computation we will do will be modulo 574 // the pointer size, so get it. 575 uint64_t PtrSizeMask = ~0ULL >> (64-IntPtrWidth); 576 577 Offset &= PtrSizeMask; 578 VariableScale &= PtrSizeMask; 579 580 // To do this transformation, any constant index must be a multiple of the 581 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 582 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 583 // multiple of the variable scale. 584 int64_t NewOffs = Offset / (int64_t)VariableScale; 585 if (Offset != NewOffs*(int64_t)VariableScale) 586 return nullptr; 587 588 // Okay, we can do this evaluation. Start by converting the index to intptr. 589 if (VariableIdx->getType() != IntPtrTy) 590 VariableIdx = IC.Builder->CreateIntCast(VariableIdx, IntPtrTy, 591 true /*Signed*/); 592 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 593 return IC.Builder->CreateAdd(VariableIdx, OffsetVal, "offset"); 594 } 595 596 /// Returns true if we can rewrite Start as a GEP with pointer Base 597 /// and some integer offset. The nodes that need to be re-written 598 /// for this transformation will be added to Explored. 599 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 600 const DataLayout &DL, 601 SetVector<Value *> &Explored) { 602 SmallVector<Value *, 16> WorkList(1, Start); 603 Explored.insert(Base); 604 605 // The following traversal gives us an order which can be used 606 // when doing the final transformation. Since in the final 607 // transformation we create the PHI replacement instructions first, 608 // we don't have to get them in any particular order. 609 // 610 // However, for other instructions we will have to traverse the 611 // operands of an instruction first, which means that we have to 612 // do a post-order traversal. 613 while (!WorkList.empty()) { 614 SetVector<PHINode *> PHIs; 615 616 while (!WorkList.empty()) { 617 if (Explored.size() >= 100) 618 return false; 619 620 Value *V = WorkList.back(); 621 622 if (Explored.count(V) != 0) { 623 WorkList.pop_back(); 624 continue; 625 } 626 627 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 628 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 629 // We've found some value that we can't explore which is different from 630 // the base. Therefore we can't do this transformation. 631 return false; 632 633 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 634 auto *CI = dyn_cast<CastInst>(V); 635 if (!CI->isNoopCast(DL)) 636 return false; 637 638 if (Explored.count(CI->getOperand(0)) == 0) 639 WorkList.push_back(CI->getOperand(0)); 640 } 641 642 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 643 // We're limiting the GEP to having one index. This will preserve 644 // the original pointer type. We could handle more cases in the 645 // future. 646 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 647 GEP->getType() != Start->getType()) 648 return false; 649 650 if (Explored.count(GEP->getOperand(0)) == 0) 651 WorkList.push_back(GEP->getOperand(0)); 652 } 653 654 if (WorkList.back() == V) { 655 WorkList.pop_back(); 656 // We've finished visiting this node, mark it as such. 657 Explored.insert(V); 658 } 659 660 if (auto *PN = dyn_cast<PHINode>(V)) { 661 // We cannot transform PHIs on unsplittable basic blocks. 662 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 663 return false; 664 Explored.insert(PN); 665 PHIs.insert(PN); 666 } 667 } 668 669 // Explore the PHI nodes further. 670 for (auto *PN : PHIs) 671 for (Value *Op : PN->incoming_values()) 672 if (Explored.count(Op) == 0) 673 WorkList.push_back(Op); 674 } 675 676 // Make sure that we can do this. Since we can't insert GEPs in a basic 677 // block before a PHI node, we can't easily do this transformation if 678 // we have PHI node users of transformed instructions. 679 for (Value *Val : Explored) { 680 for (Value *Use : Val->uses()) { 681 682 auto *PHI = dyn_cast<PHINode>(Use); 683 auto *Inst = dyn_cast<Instruction>(Val); 684 685 if (Inst == Base || Inst == PHI || !Inst || !PHI || 686 Explored.count(PHI) == 0) 687 continue; 688 689 if (PHI->getParent() == Inst->getParent()) 690 return false; 691 } 692 } 693 return true; 694 } 695 696 // Sets the appropriate insert point on Builder where we can add 697 // a replacement Instruction for V (if that is possible). 698 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 699 bool Before = true) { 700 if (auto *PHI = dyn_cast<PHINode>(V)) { 701 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 702 return; 703 } 704 if (auto *I = dyn_cast<Instruction>(V)) { 705 if (!Before) 706 I = &*std::next(I->getIterator()); 707 Builder.SetInsertPoint(I); 708 return; 709 } 710 if (auto *A = dyn_cast<Argument>(V)) { 711 // Set the insertion point in the entry block. 712 BasicBlock &Entry = A->getParent()->getEntryBlock(); 713 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 714 return; 715 } 716 // Otherwise, this is a constant and we don't need to set a new 717 // insertion point. 718 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 719 } 720 721 /// Returns a re-written value of Start as an indexed GEP using Base as a 722 /// pointer. 723 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 724 const DataLayout &DL, 725 SetVector<Value *> &Explored) { 726 // Perform all the substitutions. This is a bit tricky because we can 727 // have cycles in our use-def chains. 728 // 1. Create the PHI nodes without any incoming values. 729 // 2. Create all the other values. 730 // 3. Add the edges for the PHI nodes. 731 // 4. Emit GEPs to get the original pointers. 732 // 5. Remove the original instructions. 733 Type *IndexType = IntegerType::get( 734 Base->getContext(), DL.getPointerTypeSizeInBits(Start->getType())); 735 736 DenseMap<Value *, Value *> NewInsts; 737 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 738 739 // Create the new PHI nodes, without adding any incoming values. 740 for (Value *Val : Explored) { 741 if (Val == Base) 742 continue; 743 // Create empty phi nodes. This avoids cyclic dependencies when creating 744 // the remaining instructions. 745 if (auto *PHI = dyn_cast<PHINode>(Val)) 746 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 747 PHI->getName() + ".idx", PHI); 748 } 749 IRBuilder<> Builder(Base->getContext()); 750 751 // Create all the other instructions. 752 for (Value *Val : Explored) { 753 754 if (NewInsts.find(Val) != NewInsts.end()) 755 continue; 756 757 if (auto *CI = dyn_cast<CastInst>(Val)) { 758 NewInsts[CI] = NewInsts[CI->getOperand(0)]; 759 continue; 760 } 761 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 762 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 763 : GEP->getOperand(1); 764 setInsertionPoint(Builder, GEP); 765 // Indices might need to be sign extended. GEPs will magically do 766 // this, but we need to do it ourselves here. 767 if (Index->getType()->getScalarSizeInBits() != 768 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 769 Index = Builder.CreateSExtOrTrunc( 770 Index, NewInsts[GEP->getOperand(0)]->getType(), 771 GEP->getOperand(0)->getName() + ".sext"); 772 } 773 774 auto *Op = NewInsts[GEP->getOperand(0)]; 775 if (isa<ConstantInt>(Op) && dyn_cast<ConstantInt>(Op)->isZero()) 776 NewInsts[GEP] = Index; 777 else 778 NewInsts[GEP] = Builder.CreateNSWAdd( 779 Op, Index, GEP->getOperand(0)->getName() + ".add"); 780 continue; 781 } 782 if (isa<PHINode>(Val)) 783 continue; 784 785 llvm_unreachable("Unexpected instruction type"); 786 } 787 788 // Add the incoming values to the PHI nodes. 789 for (Value *Val : Explored) { 790 if (Val == Base) 791 continue; 792 // All the instructions have been created, we can now add edges to the 793 // phi nodes. 794 if (auto *PHI = dyn_cast<PHINode>(Val)) { 795 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 796 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 797 Value *NewIncoming = PHI->getIncomingValue(I); 798 799 if (NewInsts.find(NewIncoming) != NewInsts.end()) 800 NewIncoming = NewInsts[NewIncoming]; 801 802 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 803 } 804 } 805 } 806 807 for (Value *Val : Explored) { 808 if (Val == Base) 809 continue; 810 811 // Depending on the type, for external users we have to emit 812 // a GEP or a GEP + ptrtoint. 813 setInsertionPoint(Builder, Val, false); 814 815 // If required, create an inttoptr instruction for Base. 816 Value *NewBase = Base; 817 if (!Base->getType()->isPointerTy()) 818 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 819 Start->getName() + "to.ptr"); 820 821 Value *GEP = Builder.CreateInBoundsGEP( 822 Start->getType()->getPointerElementType(), NewBase, 823 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 824 825 if (!Val->getType()->isPointerTy()) { 826 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 827 Val->getName() + ".conv"); 828 GEP = Cast; 829 } 830 Val->replaceAllUsesWith(GEP); 831 } 832 833 return NewInsts[Start]; 834 } 835 836 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 837 /// the input Value as a constant indexed GEP. Returns a pair containing 838 /// the GEPs Pointer and Index. 839 static std::pair<Value *, Value *> 840 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 841 Type *IndexType = IntegerType::get(V->getContext(), 842 DL.getPointerTypeSizeInBits(V->getType())); 843 844 Constant *Index = ConstantInt::getNullValue(IndexType); 845 while (true) { 846 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 847 // We accept only inbouds GEPs here to exclude the possibility of 848 // overflow. 849 if (!GEP->isInBounds()) 850 break; 851 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 852 GEP->getType() == V->getType()) { 853 V = GEP->getOperand(0); 854 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 855 Index = ConstantExpr::getAdd( 856 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 857 continue; 858 } 859 break; 860 } 861 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 862 if (!CI->isNoopCast(DL)) 863 break; 864 V = CI->getOperand(0); 865 continue; 866 } 867 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 868 if (!CI->isNoopCast(DL)) 869 break; 870 V = CI->getOperand(0); 871 continue; 872 } 873 break; 874 } 875 return {V, Index}; 876 } 877 878 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 879 /// We can look through PHIs, GEPs and casts in order to determine a common base 880 /// between GEPLHS and RHS. 881 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 882 ICmpInst::Predicate Cond, 883 const DataLayout &DL) { 884 if (!GEPLHS->hasAllConstantIndices()) 885 return nullptr; 886 887 Value *PtrBase, *Index; 888 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 889 890 // The set of nodes that will take part in this transformation. 891 SetVector<Value *> Nodes; 892 893 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 894 return nullptr; 895 896 // We know we can re-write this as 897 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 898 // Since we've only looked through inbouds GEPs we know that we 899 // can't have overflow on either side. We can therefore re-write 900 // this as: 901 // OFFSET1 cmp OFFSET2 902 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 903 904 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 905 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 906 // offset. Since Index is the offset of LHS to the base pointer, we will now 907 // compare the offsets instead of comparing the pointers. 908 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 909 } 910 911 /// Fold comparisons between a GEP instruction and something else. At this point 912 /// we know that the GEP is on the LHS of the comparison. 913 Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 914 ICmpInst::Predicate Cond, 915 Instruction &I) { 916 // Don't transform signed compares of GEPs into index compares. Even if the 917 // GEP is inbounds, the final add of the base pointer can have signed overflow 918 // and would change the result of the icmp. 919 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 920 // the maximum signed value for the pointer type. 921 if (ICmpInst::isSigned(Cond)) 922 return nullptr; 923 924 // Look through bitcasts and addrspacecasts. We do not however want to remove 925 // 0 GEPs. 926 if (!isa<GetElementPtrInst>(RHS)) 927 RHS = RHS->stripPointerCasts(); 928 929 Value *PtrBase = GEPLHS->getOperand(0); 930 if (PtrBase == RHS && GEPLHS->isInBounds()) { 931 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 932 // This transformation (ignoring the base and scales) is valid because we 933 // know pointers can't overflow since the gep is inbounds. See if we can 934 // output an optimized form. 935 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 936 937 // If not, synthesize the offset the hard way. 938 if (!Offset) 939 Offset = EmitGEPOffset(GEPLHS); 940 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 941 Constant::getNullValue(Offset->getType())); 942 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 943 // If the base pointers are different, but the indices are the same, just 944 // compare the base pointer. 945 if (PtrBase != GEPRHS->getOperand(0)) { 946 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 947 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 948 GEPRHS->getOperand(0)->getType(); 949 if (IndicesTheSame) 950 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 951 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 952 IndicesTheSame = false; 953 break; 954 } 955 956 // If all indices are the same, just compare the base pointers. 957 if (IndicesTheSame) 958 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 959 960 // If we're comparing GEPs with two base pointers that only differ in type 961 // and both GEPs have only constant indices or just one use, then fold 962 // the compare with the adjusted indices. 963 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 964 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 965 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 966 PtrBase->stripPointerCasts() == 967 GEPRHS->getOperand(0)->stripPointerCasts()) { 968 Value *LOffset = EmitGEPOffset(GEPLHS); 969 Value *ROffset = EmitGEPOffset(GEPRHS); 970 971 // If we looked through an addrspacecast between different sized address 972 // spaces, the LHS and RHS pointers are different sized 973 // integers. Truncate to the smaller one. 974 Type *LHSIndexTy = LOffset->getType(); 975 Type *RHSIndexTy = ROffset->getType(); 976 if (LHSIndexTy != RHSIndexTy) { 977 if (LHSIndexTy->getPrimitiveSizeInBits() < 978 RHSIndexTy->getPrimitiveSizeInBits()) { 979 ROffset = Builder->CreateTrunc(ROffset, LHSIndexTy); 980 } else 981 LOffset = Builder->CreateTrunc(LOffset, RHSIndexTy); 982 } 983 984 Value *Cmp = Builder->CreateICmp(ICmpInst::getSignedPredicate(Cond), 985 LOffset, ROffset); 986 return replaceInstUsesWith(I, Cmp); 987 } 988 989 // Otherwise, the base pointers are different and the indices are 990 // different. Try convert this to an indexed compare by looking through 991 // PHIs/casts. 992 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 993 } 994 995 // If one of the GEPs has all zero indices, recurse. 996 if (GEPLHS->hasAllZeroIndices()) 997 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 998 ICmpInst::getSwappedPredicate(Cond), I); 999 1000 // If the other GEP has all zero indices, recurse. 1001 if (GEPRHS->hasAllZeroIndices()) 1002 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 1003 1004 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 1005 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 1006 // If the GEPs only differ by one index, compare it. 1007 unsigned NumDifferences = 0; // Keep track of # differences. 1008 unsigned DiffOperand = 0; // The operand that differs. 1009 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 1010 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 1011 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() != 1012 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) { 1013 // Irreconcilable differences. 1014 NumDifferences = 2; 1015 break; 1016 } else { 1017 if (NumDifferences++) break; 1018 DiffOperand = i; 1019 } 1020 } 1021 1022 if (NumDifferences == 0) // SAME GEP? 1023 return replaceInstUsesWith(I, // No comparison is needed here. 1024 Builder->getInt1(ICmpInst::isTrueWhenEqual(Cond))); 1025 1026 else if (NumDifferences == 1 && GEPsInBounds) { 1027 Value *LHSV = GEPLHS->getOperand(DiffOperand); 1028 Value *RHSV = GEPRHS->getOperand(DiffOperand); 1029 // Make sure we do a signed comparison here. 1030 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 1031 } 1032 } 1033 1034 // Only lower this if the icmp is the only user of the GEP or if we expect 1035 // the result to fold to a constant! 1036 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 1037 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 1038 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 1039 Value *L = EmitGEPOffset(GEPLHS); 1040 Value *R = EmitGEPOffset(GEPRHS); 1041 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 1042 } 1043 } 1044 1045 // Try convert this to an indexed compare by looking through PHIs/casts as a 1046 // last resort. 1047 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1048 } 1049 1050 Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI, 1051 const AllocaInst *Alloca, 1052 const Value *Other) { 1053 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1054 1055 // It would be tempting to fold away comparisons between allocas and any 1056 // pointer not based on that alloca (e.g. an argument). However, even 1057 // though such pointers cannot alias, they can still compare equal. 1058 // 1059 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1060 // doesn't escape we can argue that it's impossible to guess its value, and we 1061 // can therefore act as if any such guesses are wrong. 1062 // 1063 // The code below checks that the alloca doesn't escape, and that it's only 1064 // used in a comparison once (the current instruction). The 1065 // single-comparison-use condition ensures that we're trivially folding all 1066 // comparisons against the alloca consistently, and avoids the risk of 1067 // erroneously folding a comparison of the pointer with itself. 1068 1069 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1070 1071 SmallVector<const Use *, 32> Worklist; 1072 for (const Use &U : Alloca->uses()) { 1073 if (Worklist.size() >= MaxIter) 1074 return nullptr; 1075 Worklist.push_back(&U); 1076 } 1077 1078 unsigned NumCmps = 0; 1079 while (!Worklist.empty()) { 1080 assert(Worklist.size() <= MaxIter); 1081 const Use *U = Worklist.pop_back_val(); 1082 const Value *V = U->getUser(); 1083 --MaxIter; 1084 1085 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1086 isa<SelectInst>(V)) { 1087 // Track the uses. 1088 } else if (isa<LoadInst>(V)) { 1089 // Loading from the pointer doesn't escape it. 1090 continue; 1091 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1092 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1093 if (SI->getValueOperand() == U->get()) 1094 return nullptr; 1095 continue; 1096 } else if (isa<ICmpInst>(V)) { 1097 if (NumCmps++) 1098 return nullptr; // Found more than one cmp. 1099 continue; 1100 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1101 switch (Intrin->getIntrinsicID()) { 1102 // These intrinsics don't escape or compare the pointer. Memset is safe 1103 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1104 // we don't allow stores, so src cannot point to V. 1105 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1106 case Intrinsic::dbg_declare: case Intrinsic::dbg_value: 1107 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1108 continue; 1109 default: 1110 return nullptr; 1111 } 1112 } else { 1113 return nullptr; 1114 } 1115 for (const Use &U : V->uses()) { 1116 if (Worklist.size() >= MaxIter) 1117 return nullptr; 1118 Worklist.push_back(&U); 1119 } 1120 } 1121 1122 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1123 return replaceInstUsesWith( 1124 ICI, 1125 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1126 } 1127 1128 /// Fold "icmp pred (X+CI), X". 1129 Instruction *InstCombiner::foldICmpAddOpConst(Instruction &ICI, 1130 Value *X, ConstantInt *CI, 1131 ICmpInst::Predicate Pred) { 1132 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1133 // so the values can never be equal. Similarly for all other "or equals" 1134 // operators. 1135 1136 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1137 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1138 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1139 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1140 Value *R = 1141 ConstantExpr::getSub(ConstantInt::getAllOnesValue(CI->getType()), CI); 1142 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1143 } 1144 1145 // (X+1) >u X --> X <u (0-1) --> X != 255 1146 // (X+2) >u X --> X <u (0-2) --> X <u 254 1147 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1148 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1149 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantExpr::getNeg(CI)); 1150 1151 unsigned BitWidth = CI->getType()->getPrimitiveSizeInBits(); 1152 ConstantInt *SMax = ConstantInt::get(X->getContext(), 1153 APInt::getSignedMaxValue(BitWidth)); 1154 1155 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1156 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1157 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1158 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1159 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1160 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1161 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1162 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantExpr::getSub(SMax, CI)); 1163 1164 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1165 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1166 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1167 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1168 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1169 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1170 1171 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1172 Constant *C = Builder->getInt(CI->getValue()-1); 1173 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantExpr::getSub(SMax, C)); 1174 } 1175 1176 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1177 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1178 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1179 Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A, 1180 const APInt &AP1, 1181 const APInt &AP2) { 1182 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1183 1184 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1185 if (I.getPredicate() == I.ICMP_NE) 1186 Pred = CmpInst::getInversePredicate(Pred); 1187 return new ICmpInst(Pred, LHS, RHS); 1188 }; 1189 1190 // Don't bother doing any work for cases which InstSimplify handles. 1191 if (AP2 == 0) 1192 return nullptr; 1193 1194 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1195 if (IsAShr) { 1196 if (AP2.isAllOnesValue()) 1197 return nullptr; 1198 if (AP2.isNegative() != AP1.isNegative()) 1199 return nullptr; 1200 if (AP2.sgt(AP1)) 1201 return nullptr; 1202 } 1203 1204 if (!AP1) 1205 // 'A' must be large enough to shift out the highest set bit. 1206 return getICmp(I.ICMP_UGT, A, 1207 ConstantInt::get(A->getType(), AP2.logBase2())); 1208 1209 if (AP1 == AP2) 1210 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1211 1212 int Shift; 1213 if (IsAShr && AP1.isNegative()) 1214 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1215 else 1216 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1217 1218 if (Shift > 0) { 1219 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1220 // There are multiple solutions if we are comparing against -1 and the LHS 1221 // of the ashr is not a power of two. 1222 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1223 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1224 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1225 } else if (AP1 == AP2.lshr(Shift)) { 1226 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1227 } 1228 } 1229 1230 // Shifting const2 will never be equal to const1. 1231 // FIXME: This should always be handled by InstSimplify? 1232 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1233 return replaceInstUsesWith(I, TorF); 1234 } 1235 1236 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1237 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1238 Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A, 1239 const APInt &AP1, 1240 const APInt &AP2) { 1241 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1242 1243 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1244 if (I.getPredicate() == I.ICMP_NE) 1245 Pred = CmpInst::getInversePredicate(Pred); 1246 return new ICmpInst(Pred, LHS, RHS); 1247 }; 1248 1249 // Don't bother doing any work for cases which InstSimplify handles. 1250 if (AP2 == 0) 1251 return nullptr; 1252 1253 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1254 1255 if (!AP1 && AP2TrailingZeros != 0) 1256 return getICmp( 1257 I.ICMP_UGE, A, 1258 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1259 1260 if (AP1 == AP2) 1261 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1262 1263 // Get the distance between the lowest bits that are set. 1264 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1265 1266 if (Shift > 0 && AP2.shl(Shift) == AP1) 1267 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1268 1269 // Shifting const2 will never be equal to const1. 1270 // FIXME: This should always be handled by InstSimplify? 1271 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1272 return replaceInstUsesWith(I, TorF); 1273 } 1274 1275 /// The caller has matched a pattern of the form: 1276 /// I = icmp ugt (add (add A, B), CI2), CI1 1277 /// If this is of the form: 1278 /// sum = a + b 1279 /// if (sum+128 >u 255) 1280 /// Then replace it with llvm.sadd.with.overflow.i8. 1281 /// 1282 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1283 ConstantInt *CI2, ConstantInt *CI1, 1284 InstCombiner &IC) { 1285 // The transformation we're trying to do here is to transform this into an 1286 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1287 // with a narrower add, and discard the add-with-constant that is part of the 1288 // range check (if we can't eliminate it, this isn't profitable). 1289 1290 // In order to eliminate the add-with-constant, the compare can be its only 1291 // use. 1292 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1293 if (!AddWithCst->hasOneUse()) 1294 return nullptr; 1295 1296 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1297 if (!CI2->getValue().isPowerOf2()) 1298 return nullptr; 1299 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1300 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1301 return nullptr; 1302 1303 // The width of the new add formed is 1 more than the bias. 1304 ++NewWidth; 1305 1306 // Check to see that CI1 is an all-ones value with NewWidth bits. 1307 if (CI1->getBitWidth() == NewWidth || 1308 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1309 return nullptr; 1310 1311 // This is only really a signed overflow check if the inputs have been 1312 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1313 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1314 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1315 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1316 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1317 return nullptr; 1318 1319 // In order to replace the original add with a narrower 1320 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1321 // and truncates that discard the high bits of the add. Verify that this is 1322 // the case. 1323 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1324 for (User *U : OrigAdd->users()) { 1325 if (U == AddWithCst) 1326 continue; 1327 1328 // Only accept truncates for now. We would really like a nice recursive 1329 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1330 // chain to see which bits of a value are actually demanded. If the 1331 // original add had another add which was then immediately truncated, we 1332 // could still do the transformation. 1333 TruncInst *TI = dyn_cast<TruncInst>(U); 1334 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1335 return nullptr; 1336 } 1337 1338 // If the pattern matches, truncate the inputs to the narrower type and 1339 // use the sadd_with_overflow intrinsic to efficiently compute both the 1340 // result and the overflow bit. 1341 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1342 Value *F = Intrinsic::getDeclaration(I.getModule(), 1343 Intrinsic::sadd_with_overflow, NewType); 1344 1345 InstCombiner::BuilderTy *Builder = IC.Builder; 1346 1347 // Put the new code above the original add, in case there are any uses of the 1348 // add between the add and the compare. 1349 Builder->SetInsertPoint(OrigAdd); 1350 1351 Value *TruncA = Builder->CreateTrunc(A, NewType, A->getName() + ".trunc"); 1352 Value *TruncB = Builder->CreateTrunc(B, NewType, B->getName() + ".trunc"); 1353 CallInst *Call = Builder->CreateCall(F, {TruncA, TruncB}, "sadd"); 1354 Value *Add = Builder->CreateExtractValue(Call, 0, "sadd.result"); 1355 Value *ZExt = Builder->CreateZExt(Add, OrigAdd->getType()); 1356 1357 // The inner add was the result of the narrow add, zero extended to the 1358 // wider type. Replace it with the result computed by the intrinsic. 1359 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1360 1361 // The original icmp gets replaced with the overflow value. 1362 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1363 } 1364 1365 // Fold icmp Pred X, C. 1366 Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) { 1367 CmpInst::Predicate Pred = Cmp.getPredicate(); 1368 Value *X = Cmp.getOperand(0); 1369 1370 const APInt *C; 1371 if (!match(Cmp.getOperand(1), m_APInt(C))) 1372 return nullptr; 1373 1374 Value *A = nullptr, *B = nullptr; 1375 1376 // Match the following pattern, which is a common idiom when writing 1377 // overflow-safe integer arithmetic functions. The source performs an addition 1378 // in wider type and explicitly checks for overflow using comparisons against 1379 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1380 // 1381 // TODO: This could probably be generalized to handle other overflow-safe 1382 // operations if we worked out the formulas to compute the appropriate magic 1383 // constants. 1384 // 1385 // sum = a + b 1386 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1387 { 1388 ConstantInt *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1389 if (Pred == ICmpInst::ICMP_UGT && 1390 match(X, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1391 if (Instruction *Res = processUGT_ADDCST_ADD( 1392 Cmp, A, B, CI2, cast<ConstantInt>(Cmp.getOperand(1)), *this)) 1393 return Res; 1394 } 1395 1396 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1397 if (*C == 0 && Pred == ICmpInst::ICMP_SGT) { 1398 SelectPatternResult SPR = matchSelectPattern(X, A, B); 1399 if (SPR.Flavor == SPF_SMIN) { 1400 if (isKnownPositive(A, DL)) 1401 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1402 if (isKnownPositive(B, DL)) 1403 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1404 } 1405 } 1406 1407 // FIXME: Use m_APInt to allow folds for splat constants. 1408 ConstantInt *CI = dyn_cast<ConstantInt>(Cmp.getOperand(1)); 1409 if (!CI) 1410 return nullptr; 1411 1412 // Canonicalize icmp instructions based on dominating conditions. 1413 BasicBlock *Parent = Cmp.getParent(); 1414 BasicBlock *Dom = Parent->getSinglePredecessor(); 1415 auto *BI = Dom ? dyn_cast<BranchInst>(Dom->getTerminator()) : nullptr; 1416 ICmpInst::Predicate Pred2; 1417 BasicBlock *TrueBB, *FalseBB; 1418 ConstantInt *CI2; 1419 if (BI && match(BI, m_Br(m_ICmp(Pred2, m_Specific(X), m_ConstantInt(CI2)), 1420 TrueBB, FalseBB)) && 1421 TrueBB != FalseBB) { 1422 ConstantRange CR = 1423 ConstantRange::makeAllowedICmpRegion(Pred, CI->getValue()); 1424 ConstantRange DominatingCR = 1425 (Parent == TrueBB) 1426 ? ConstantRange::makeExactICmpRegion(Pred2, CI2->getValue()) 1427 : ConstantRange::makeExactICmpRegion( 1428 CmpInst::getInversePredicate(Pred2), CI2->getValue()); 1429 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1430 ConstantRange Difference = DominatingCR.difference(CR); 1431 if (Intersection.isEmptySet()) 1432 return replaceInstUsesWith(Cmp, Builder->getFalse()); 1433 if (Difference.isEmptySet()) 1434 return replaceInstUsesWith(Cmp, Builder->getTrue()); 1435 1436 // If this is a normal comparison, it demands all bits. If it is a sign 1437 // bit comparison, it only demands the sign bit. 1438 bool UnusedBit; 1439 bool IsSignBit = isSignBitCheck(Pred, CI->getValue(), UnusedBit); 1440 1441 // Canonicalizing a sign bit comparison that gets used in a branch, 1442 // pessimizes codegen by generating branch on zero instruction instead 1443 // of a test and branch. So we avoid canonicalizing in such situations 1444 // because test and branch instruction has better branch displacement 1445 // than compare and branch instruction. 1446 if (!isBranchOnSignBitCheck(Cmp, IsSignBit) && !Cmp.isEquality()) { 1447 if (auto *AI = Intersection.getSingleElement()) 1448 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder->getInt(*AI)); 1449 if (auto *AD = Difference.getSingleElement()) 1450 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder->getInt(*AD)); 1451 } 1452 } 1453 1454 return nullptr; 1455 } 1456 1457 /// Fold icmp (trunc X, Y), C. 1458 Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp, 1459 Instruction *Trunc, 1460 const APInt *C) { 1461 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1462 Value *X = Trunc->getOperand(0); 1463 if (*C == 1 && C->getBitWidth() > 1) { 1464 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1465 Value *V = nullptr; 1466 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1467 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1468 ConstantInt::get(V->getType(), 1)); 1469 } 1470 1471 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1472 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1473 // of the high bits truncated out of x are known. 1474 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1475 SrcBits = X->getType()->getScalarSizeInBits(); 1476 APInt KnownZero(SrcBits, 0), KnownOne(SrcBits, 0); 1477 computeKnownBits(X, KnownZero, KnownOne, 0, &Cmp); 1478 1479 // If all the high bits are known, we can do this xform. 1480 if ((KnownZero | KnownOne).countLeadingOnes() >= SrcBits - DstBits) { 1481 // Pull in the high bits from known-ones set. 1482 APInt NewRHS = C->zext(SrcBits); 1483 NewRHS |= KnownOne & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1484 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1485 } 1486 } 1487 1488 return nullptr; 1489 } 1490 1491 /// Fold icmp (xor X, Y), C. 1492 Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp, 1493 BinaryOperator *Xor, 1494 const APInt *C) { 1495 Value *X = Xor->getOperand(0); 1496 Value *Y = Xor->getOperand(1); 1497 const APInt *XorC; 1498 if (!match(Y, m_APInt(XorC))) 1499 return nullptr; 1500 1501 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1502 // fold the xor. 1503 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1504 if ((Pred == ICmpInst::ICMP_SLT && *C == 0) || 1505 (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue())) { 1506 1507 // If the sign bit of the XorCst is not set, there is no change to 1508 // the operation, just stop using the Xor. 1509 if (!XorC->isNegative()) { 1510 Cmp.setOperand(0, X); 1511 Worklist.Add(Xor); 1512 return &Cmp; 1513 } 1514 1515 // Was the old condition true if the operand is positive? 1516 bool isTrueIfPositive = Pred == ICmpInst::ICMP_SGT; 1517 1518 // If so, the new one isn't. 1519 isTrueIfPositive ^= true; 1520 1521 Constant *CmpConstant = cast<Constant>(Cmp.getOperand(1)); 1522 if (isTrueIfPositive) 1523 return new ICmpInst(ICmpInst::ICMP_SGT, X, SubOne(CmpConstant)); 1524 else 1525 return new ICmpInst(ICmpInst::ICMP_SLT, X, AddOne(CmpConstant)); 1526 } 1527 1528 if (Xor->hasOneUse()) { 1529 // (icmp u/s (xor X SignBit), C) -> (icmp s/u X, (xor C SignBit)) 1530 if (!Cmp.isEquality() && XorC->isSignBit()) { 1531 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1532 : Cmp.getSignedPredicate(); 1533 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC)); 1534 } 1535 1536 // (icmp u/s (xor X ~SignBit), C) -> (icmp s/u X, (xor C ~SignBit)) 1537 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1538 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1539 : Cmp.getSignedPredicate(); 1540 Pred = Cmp.getSwappedPredicate(Pred); 1541 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), *C ^ *XorC)); 1542 } 1543 } 1544 1545 // (icmp ugt (xor X, C), ~C) -> (icmp ult X, C) 1546 // iff -C is a power of 2 1547 if (Pred == ICmpInst::ICMP_UGT && *XorC == ~(*C) && (*C + 1).isPowerOf2()) 1548 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1549 1550 // (icmp ult (xor X, C), -C) -> (icmp uge X, C) 1551 // iff -C is a power of 2 1552 if (Pred == ICmpInst::ICMP_ULT && *XorC == -(*C) && C->isPowerOf2()) 1553 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 1554 1555 return nullptr; 1556 } 1557 1558 /// Fold icmp (and (sh X, Y), C2), C1. 1559 Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And, 1560 const APInt *C1, const APInt *C2) { 1561 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1562 if (!Shift || !Shift->isShift()) 1563 return nullptr; 1564 1565 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1566 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1567 // code produced by the clang front-end, for bitfield access. 1568 // This seemingly simple opportunity to fold away a shift turns out to be 1569 // rather complicated. See PR17827 for details. 1570 unsigned ShiftOpcode = Shift->getOpcode(); 1571 bool IsShl = ShiftOpcode == Instruction::Shl; 1572 const APInt *C3; 1573 if (match(Shift->getOperand(1), m_APInt(C3))) { 1574 bool CanFold = false; 1575 if (ShiftOpcode == Instruction::AShr) { 1576 // There may be some constraints that make this possible, but nothing 1577 // simple has been discovered yet. 1578 CanFold = false; 1579 } else if (ShiftOpcode == Instruction::Shl) { 1580 // For a left shift, we can fold if the comparison is not signed. We can 1581 // also fold a signed comparison if the mask value and comparison value 1582 // are not negative. These constraints may not be obvious, but we can 1583 // prove that they are correct using an SMT solver. 1584 if (!Cmp.isSigned() || (!C2->isNegative() && !C1->isNegative())) 1585 CanFold = true; 1586 } else if (ShiftOpcode == Instruction::LShr) { 1587 // For a logical right shift, we can fold if the comparison is not signed. 1588 // We can also fold a signed comparison if the shifted mask value and the 1589 // shifted comparison value are not negative. These constraints may not be 1590 // obvious, but we can prove that they are correct using an SMT solver. 1591 if (!Cmp.isSigned() || 1592 (!C2->shl(*C3).isNegative() && !C1->shl(*C3).isNegative())) 1593 CanFold = true; 1594 } 1595 1596 if (CanFold) { 1597 APInt NewCst = IsShl ? C1->lshr(*C3) : C1->shl(*C3); 1598 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3); 1599 // Check to see if we are shifting out any of the bits being compared. 1600 if (SameAsC1 != *C1) { 1601 // If we shifted bits out, the fold is not going to work out. As a 1602 // special case, check to see if this means that the result is always 1603 // true or false now. 1604 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1605 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1606 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1607 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1608 } else { 1609 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst)); 1610 APInt NewAndCst = IsShl ? C2->lshr(*C3) : C2->shl(*C3); 1611 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst)); 1612 And->setOperand(0, Shift->getOperand(0)); 1613 Worklist.Add(Shift); // Shift is dead. 1614 return &Cmp; 1615 } 1616 } 1617 } 1618 1619 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1620 // preferable because it allows the C2 << Y expression to be hoisted out of a 1621 // loop if Y is invariant and X is not. 1622 if (Shift->hasOneUse() && *C1 == 0 && Cmp.isEquality() && 1623 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1624 // Compute C2 << Y. 1625 Value *NewShift = 1626 IsShl ? Builder->CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1627 : Builder->CreateShl(And->getOperand(1), Shift->getOperand(1)); 1628 1629 // Compute X & (C2 << Y). 1630 Value *NewAnd = Builder->CreateAnd(Shift->getOperand(0), NewShift); 1631 Cmp.setOperand(0, NewAnd); 1632 return &Cmp; 1633 } 1634 1635 return nullptr; 1636 } 1637 1638 /// Fold icmp (and X, C2), C1. 1639 Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp, 1640 BinaryOperator *And, 1641 const APInt *C1) { 1642 const APInt *C2; 1643 if (!match(And->getOperand(1), m_APInt(C2))) 1644 return nullptr; 1645 1646 if (!And->hasOneUse() || !And->getOperand(0)->hasOneUse()) 1647 return nullptr; 1648 1649 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1650 // the input width without changing the value produced, eliminate the cast: 1651 // 1652 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1653 // 1654 // We can do this transformation if the constants do not have their sign bits 1655 // set or if it is an equality comparison. Extending a relational comparison 1656 // when we're checking the sign bit would not work. 1657 Value *W; 1658 if (match(And->getOperand(0), m_Trunc(m_Value(W))) && 1659 (Cmp.isEquality() || (!C1->isNegative() && !C2->isNegative()))) { 1660 // TODO: Is this a good transform for vectors? Wider types may reduce 1661 // throughput. Should this transform be limited (even for scalars) by using 1662 // ShouldChangeType()? 1663 if (!Cmp.getType()->isVectorTy()) { 1664 Type *WideType = W->getType(); 1665 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1666 Constant *ZextC1 = ConstantInt::get(WideType, C1->zext(WideScalarBits)); 1667 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1668 Value *NewAnd = Builder->CreateAnd(W, ZextC2, And->getName()); 1669 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1670 } 1671 } 1672 1673 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, C2)) 1674 return I; 1675 1676 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1677 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1678 // 1679 // iff pred isn't signed 1680 if (!Cmp.isSigned() && *C1 == 0 && match(And->getOperand(1), m_One())) { 1681 Constant *One = cast<Constant>(And->getOperand(1)); 1682 Value *Or = And->getOperand(0); 1683 Value *A, *B, *LShr; 1684 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1685 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1686 unsigned UsesRemoved = 0; 1687 if (And->hasOneUse()) 1688 ++UsesRemoved; 1689 if (Or->hasOneUse()) 1690 ++UsesRemoved; 1691 if (LShr->hasOneUse()) 1692 ++UsesRemoved; 1693 1694 // Compute A & ((1 << B) | 1) 1695 Value *NewOr = nullptr; 1696 if (auto *C = dyn_cast<Constant>(B)) { 1697 if (UsesRemoved >= 1) 1698 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1699 } else { 1700 if (UsesRemoved >= 3) 1701 NewOr = Builder->CreateOr(Builder->CreateShl(One, B, LShr->getName(), 1702 /*HasNUW=*/true), 1703 One, Or->getName()); 1704 } 1705 if (NewOr) { 1706 Value *NewAnd = Builder->CreateAnd(A, NewOr, And->getName()); 1707 Cmp.setOperand(0, NewAnd); 1708 return &Cmp; 1709 } 1710 } 1711 } 1712 1713 // (X & C2) > C1 --> (X & C2) != 0, if any bit set in (X & C2) will produce a 1714 // result greater than C1. 1715 unsigned NumTZ = C2->countTrailingZeros(); 1716 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && NumTZ < C2->getBitWidth() && 1717 APInt::getOneBitSet(C2->getBitWidth(), NumTZ).ugt(*C1)) { 1718 Constant *Zero = Constant::getNullValue(And->getType()); 1719 return new ICmpInst(ICmpInst::ICMP_NE, And, Zero); 1720 } 1721 1722 return nullptr; 1723 } 1724 1725 /// Fold icmp (and X, Y), C. 1726 Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp, 1727 BinaryOperator *And, 1728 const APInt *C) { 1729 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1730 return I; 1731 1732 // TODO: These all require that Y is constant too, so refactor with the above. 1733 1734 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1735 Value *X = And->getOperand(0); 1736 Value *Y = And->getOperand(1); 1737 if (auto *LI = dyn_cast<LoadInst>(X)) 1738 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1739 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1740 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1741 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1742 ConstantInt *C2 = cast<ConstantInt>(Y); 1743 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1744 return Res; 1745 } 1746 1747 if (!Cmp.isEquality()) 1748 return nullptr; 1749 1750 // X & -C == -C -> X > u ~C 1751 // X & -C != -C -> X <= u ~C 1752 // iff C is a power of 2 1753 if (Cmp.getOperand(1) == Y && (-(*C)).isPowerOf2()) { 1754 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1755 : CmpInst::ICMP_ULE; 1756 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1757 } 1758 1759 // (X & C2) == 0 -> (trunc X) >= 0 1760 // (X & C2) != 0 -> (trunc X) < 0 1761 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1762 const APInt *C2; 1763 if (And->hasOneUse() && *C == 0 && match(Y, m_APInt(C2))) { 1764 int32_t ExactLogBase2 = C2->exactLogBase2(); 1765 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1766 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1767 if (And->getType()->isVectorTy()) 1768 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements()); 1769 Value *Trunc = Builder->CreateTrunc(X, NTy); 1770 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1771 : CmpInst::ICMP_SLT; 1772 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1773 } 1774 } 1775 1776 return nullptr; 1777 } 1778 1779 /// Fold icmp (or X, Y), C. 1780 Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or, 1781 const APInt *C) { 1782 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1783 if (*C == 1) { 1784 // icmp slt signum(V) 1 --> icmp slt V, 1 1785 Value *V = nullptr; 1786 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1787 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1788 ConstantInt::get(V->getType(), 1)); 1789 } 1790 1791 if (!Cmp.isEquality() || *C != 0 || !Or->hasOneUse()) 1792 return nullptr; 1793 1794 Value *P, *Q; 1795 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1796 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1797 // -> and (icmp eq P, null), (icmp eq Q, null). 1798 Value *CmpP = 1799 Builder->CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1800 Value *CmpQ = 1801 Builder->CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1802 auto LogicOpc = Pred == ICmpInst::Predicate::ICMP_EQ ? Instruction::And 1803 : Instruction::Or; 1804 return BinaryOperator::Create(LogicOpc, CmpP, CmpQ); 1805 } 1806 1807 return nullptr; 1808 } 1809 1810 /// Fold icmp (mul X, Y), C. 1811 Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp, 1812 BinaryOperator *Mul, 1813 const APInt *C) { 1814 const APInt *MulC; 1815 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1816 return nullptr; 1817 1818 // If this is a test of the sign bit and the multiply is sign-preserving with 1819 // a constant operand, use the multiply LHS operand instead. 1820 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1821 if (isSignTest(Pred, *C) && Mul->hasNoSignedWrap()) { 1822 if (MulC->isNegative()) 1823 Pred = ICmpInst::getSwappedPredicate(Pred); 1824 return new ICmpInst(Pred, Mul->getOperand(0), 1825 Constant::getNullValue(Mul->getType())); 1826 } 1827 1828 return nullptr; 1829 } 1830 1831 /// Fold icmp (shl 1, Y), C. 1832 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 1833 const APInt *C) { 1834 Value *Y; 1835 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 1836 return nullptr; 1837 1838 Type *ShiftType = Shl->getType(); 1839 uint32_t TypeBits = C->getBitWidth(); 1840 bool CIsPowerOf2 = C->isPowerOf2(); 1841 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1842 if (Cmp.isUnsigned()) { 1843 // (1 << Y) pred C -> Y pred Log2(C) 1844 if (!CIsPowerOf2) { 1845 // (1 << Y) < 30 -> Y <= 4 1846 // (1 << Y) <= 30 -> Y <= 4 1847 // (1 << Y) >= 30 -> Y > 4 1848 // (1 << Y) > 30 -> Y > 4 1849 if (Pred == ICmpInst::ICMP_ULT) 1850 Pred = ICmpInst::ICMP_ULE; 1851 else if (Pred == ICmpInst::ICMP_UGE) 1852 Pred = ICmpInst::ICMP_UGT; 1853 } 1854 1855 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 1856 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 1857 unsigned CLog2 = C->logBase2(); 1858 if (CLog2 == TypeBits - 1) { 1859 if (Pred == ICmpInst::ICMP_UGE) 1860 Pred = ICmpInst::ICMP_EQ; 1861 else if (Pred == ICmpInst::ICMP_ULT) 1862 Pred = ICmpInst::ICMP_NE; 1863 } 1864 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 1865 } else if (Cmp.isSigned()) { 1866 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 1867 if (C->isAllOnesValue()) { 1868 // (1 << Y) <= -1 -> Y == 31 1869 if (Pred == ICmpInst::ICMP_SLE) 1870 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1871 1872 // (1 << Y) > -1 -> Y != 31 1873 if (Pred == ICmpInst::ICMP_SGT) 1874 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1875 } else if (!(*C)) { 1876 // (1 << Y) < 0 -> Y == 31 1877 // (1 << Y) <= 0 -> Y == 31 1878 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1879 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1880 1881 // (1 << Y) >= 0 -> Y != 31 1882 // (1 << Y) > 0 -> Y != 31 1883 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 1884 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1885 } 1886 } else if (Cmp.isEquality() && CIsPowerOf2) { 1887 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C->logBase2())); 1888 } 1889 1890 return nullptr; 1891 } 1892 1893 /// Fold icmp (shl X, Y), C. 1894 Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp, 1895 BinaryOperator *Shl, 1896 const APInt *C) { 1897 const APInt *ShiftVal; 1898 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 1899 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), *C, *ShiftVal); 1900 1901 const APInt *ShiftAmt; 1902 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 1903 return foldICmpShlOne(Cmp, Shl, C); 1904 1905 // Check that the shift amount is in range. If not, don't perform undefined 1906 // shifts. When the shift is visited, it will be simplified. 1907 unsigned TypeBits = C->getBitWidth(); 1908 if (ShiftAmt->uge(TypeBits)) 1909 return nullptr; 1910 1911 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1912 Value *X = Shl->getOperand(0); 1913 Type *ShType = Shl->getType(); 1914 1915 // If this is a signed comparison to 0 and the shift is sign preserving, 1916 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 1917 // do that if we're sure to not continue on in this function. 1918 if (Shl->hasNoSignedWrap() && isSignTest(Pred, *C)) 1919 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 1920 1921 // A 'shl nuw' is just shifting out zeros, so adjust the compare constant 1922 // and eliminate the shift. 1923 if (Shl->hasNoUnsignedWrap()) { 1924 if (Cmp.isEquality() || Pred == ICmpInst::ICMP_UGT) { 1925 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 1926 APInt ShiftedC = C->lshr(*ShiftAmt); 1927 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1928 } 1929 if (Pred == ICmpInst::ICMP_ULT) { 1930 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 1931 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 1932 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 1933 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 1934 assert(C->ugt(0) && "ult 0 should have been eliminated"); 1935 APInt ShiftedC = (*C - 1).lshr(*ShiftAmt) + 1; 1936 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 1937 } 1938 } 1939 1940 if (Cmp.isEquality()) { 1941 Constant *LShrC = ConstantInt::get(ShType, C->lshr(*ShiftAmt)); 1942 if (Shl->hasNoUnsignedWrap()) 1943 return new ICmpInst(Pred, X, LShrC); 1944 1945 // If the shift is NSW and we compare to 0, then it is just shifting out 1946 // sign bits, no need for an AND either. 1947 if (Shl->hasNoSignedWrap() && *C == 0) 1948 return new ICmpInst(Pred, X, LShrC); 1949 1950 if (Shl->hasOneUse()) { 1951 // Otherwise, strength-reduce the shift into an 'and'. 1952 Constant *Mask = ConstantInt::get( 1953 ShType, 1954 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 1955 1956 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask"); 1957 return new ICmpInst(Pred, And, LShrC); 1958 } 1959 } 1960 1961 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 1962 bool TrueIfSigned = false; 1963 if (Shl->hasOneUse() && isSignBitCheck(Pred, *C, TrueIfSigned)) { 1964 // (X << 31) <s 0 --> (X & 1) != 0 1965 Constant *Mask = ConstantInt::get( 1966 ShType, 1967 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 1968 Value *And = Builder->CreateAnd(X, Mask, Shl->getName() + ".mask"); 1969 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 1970 And, Constant::getNullValue(ShType)); 1971 } 1972 1973 // Transform (icmp pred iM (shl iM %v, N), C) 1974 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 1975 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 1976 // This enables us to get rid of the shift in favor of a trunc that may be 1977 // free on the target. It has the additional benefit of comparing to a 1978 // smaller constant that may be more target-friendly. 1979 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 1980 if (Shl->hasOneUse() && Amt != 0 && C->countTrailingZeros() >= Amt && 1981 DL.isLegalInteger(TypeBits - Amt)) { 1982 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 1983 if (ShType->isVectorTy()) 1984 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements()); 1985 Constant *NewC = 1986 ConstantInt::get(TruncTy, C->ashr(*ShiftAmt).trunc(TypeBits - Amt)); 1987 return new ICmpInst(Pred, Builder->CreateTrunc(X, TruncTy), NewC); 1988 } 1989 1990 return nullptr; 1991 } 1992 1993 /// Fold icmp ({al}shr X, Y), C. 1994 Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp, 1995 BinaryOperator *Shr, 1996 const APInt *C) { 1997 // An exact shr only shifts out zero bits, so: 1998 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 1999 Value *X = Shr->getOperand(0); 2000 CmpInst::Predicate Pred = Cmp.getPredicate(); 2001 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && *C == 0) 2002 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2003 2004 const APInt *ShiftVal; 2005 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2006 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), *C, *ShiftVal); 2007 2008 const APInt *ShiftAmt; 2009 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2010 return nullptr; 2011 2012 // Check that the shift amount is in range. If not, don't perform undefined 2013 // shifts. When the shift is visited it will be simplified. 2014 unsigned TypeBits = C->getBitWidth(); 2015 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2016 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2017 return nullptr; 2018 2019 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2020 if (!Cmp.isEquality()) { 2021 // If we have an unsigned comparison and an ashr, we can't simplify this. 2022 // Similarly for signed comparisons with lshr. 2023 if (Cmp.isSigned() != IsAShr) 2024 return nullptr; 2025 2026 // Otherwise, all lshr and most exact ashr's are equivalent to a udiv/sdiv 2027 // by a power of 2. Since we already have logic to simplify these, 2028 // transform to div and then simplify the resultant comparison. 2029 if (IsAShr && (!Shr->isExact() || ShAmtVal == TypeBits - 1)) 2030 return nullptr; 2031 2032 // Revisit the shift (to delete it). 2033 Worklist.Add(Shr); 2034 2035 Constant *DivCst = ConstantInt::get( 2036 Shr->getType(), APInt::getOneBitSet(TypeBits, ShAmtVal)); 2037 2038 Value *Tmp = IsAShr ? Builder->CreateSDiv(X, DivCst, "", Shr->isExact()) 2039 : Builder->CreateUDiv(X, DivCst, "", Shr->isExact()); 2040 2041 Cmp.setOperand(0, Tmp); 2042 2043 // If the builder folded the binop, just return it. 2044 BinaryOperator *TheDiv = dyn_cast<BinaryOperator>(Tmp); 2045 if (!TheDiv) 2046 return &Cmp; 2047 2048 // Otherwise, fold this div/compare. 2049 assert(TheDiv->getOpcode() == Instruction::SDiv || 2050 TheDiv->getOpcode() == Instruction::UDiv); 2051 2052 Instruction *Res = foldICmpDivConstant(Cmp, TheDiv, C); 2053 assert(Res && "This div/cst should have folded!"); 2054 return Res; 2055 } 2056 2057 // Handle equality comparisons of shift-by-constant. 2058 2059 // If the comparison constant changes with the shift, the comparison cannot 2060 // succeed (bits of the comparison constant cannot match the shifted value). 2061 // This should be known by InstSimplify and already be folded to true/false. 2062 assert(((IsAShr && C->shl(ShAmtVal).ashr(ShAmtVal) == *C) || 2063 (!IsAShr && C->shl(ShAmtVal).lshr(ShAmtVal) == *C)) && 2064 "Expected icmp+shr simplify did not occur."); 2065 2066 // Check if the bits shifted out are known to be zero. If so, we can compare 2067 // against the unshifted value: 2068 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2069 Constant *ShiftedCmpRHS = ConstantInt::get(Shr->getType(), *C << ShAmtVal); 2070 if (Shr->hasOneUse()) { 2071 if (Shr->isExact()) 2072 return new ICmpInst(Pred, X, ShiftedCmpRHS); 2073 2074 // Otherwise strength reduce the shift into an 'and'. 2075 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2076 Constant *Mask = ConstantInt::get(Shr->getType(), Val); 2077 Value *And = Builder->CreateAnd(X, Mask, Shr->getName() + ".mask"); 2078 return new ICmpInst(Pred, And, ShiftedCmpRHS); 2079 } 2080 2081 return nullptr; 2082 } 2083 2084 /// Fold icmp (udiv X, Y), C. 2085 Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp, 2086 BinaryOperator *UDiv, 2087 const APInt *C) { 2088 const APInt *C2; 2089 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2090 return nullptr; 2091 2092 assert(C2 != 0 && "udiv 0, X should have been simplified already."); 2093 2094 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2095 Value *Y = UDiv->getOperand(1); 2096 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2097 assert(!C->isMaxValue() && 2098 "icmp ugt X, UINT_MAX should have been simplified already."); 2099 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2100 ConstantInt::get(Y->getType(), C2->udiv(*C + 1))); 2101 } 2102 2103 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2104 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2105 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2106 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2107 ConstantInt::get(Y->getType(), C2->udiv(*C))); 2108 } 2109 2110 return nullptr; 2111 } 2112 2113 /// Fold icmp ({su}div X, Y), C. 2114 Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp, 2115 BinaryOperator *Div, 2116 const APInt *C) { 2117 // Fold: icmp pred ([us]div X, C2), C -> range test 2118 // Fold this div into the comparison, producing a range check. 2119 // Determine, based on the divide type, what the range is being 2120 // checked. If there is an overflow on the low or high side, remember 2121 // it, otherwise compute the range [low, hi) bounding the new value. 2122 // See: InsertRangeTest above for the kinds of replacements possible. 2123 const APInt *C2; 2124 if (!match(Div->getOperand(1), m_APInt(C2))) 2125 return nullptr; 2126 2127 // FIXME: If the operand types don't match the type of the divide 2128 // then don't attempt this transform. The code below doesn't have the 2129 // logic to deal with a signed divide and an unsigned compare (and 2130 // vice versa). This is because (x /s C2) <s C produces different 2131 // results than (x /s C2) <u C or (x /u C2) <s C or even 2132 // (x /u C2) <u C. Simply casting the operands and result won't 2133 // work. :( The if statement below tests that condition and bails 2134 // if it finds it. 2135 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2136 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2137 return nullptr; 2138 2139 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2140 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2141 // division-by-constant cases should be present, we can not assert that they 2142 // have happened before we reach this icmp instruction. 2143 if (*C2 == 0 || *C2 == 1 || (DivIsSigned && C2->isAllOnesValue())) 2144 return nullptr; 2145 2146 // TODO: We could do all of the computations below using APInt. 2147 Constant *CmpRHS = cast<Constant>(Cmp.getOperand(1)); 2148 Constant *DivRHS = cast<Constant>(Div->getOperand(1)); 2149 2150 // Compute Prod = CmpRHS * DivRHS. We are essentially solving an equation of 2151 // form X / C2 = C. We solve for X by multiplying C2 (DivRHS) and C (CmpRHS). 2152 // By solving for X, we can turn this into a range check instead of computing 2153 // a divide. 2154 Constant *Prod = ConstantExpr::getMul(CmpRHS, DivRHS); 2155 2156 // Determine if the product overflows by seeing if the product is not equal to 2157 // the divide. Make sure we do the same kind of divide as in the LHS 2158 // instruction that we're folding. 2159 bool ProdOV = (DivIsSigned ? ConstantExpr::getSDiv(Prod, DivRHS) 2160 : ConstantExpr::getUDiv(Prod, DivRHS)) != CmpRHS; 2161 2162 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2163 2164 // If the division is known to be exact, then there is no remainder from the 2165 // divide, so the covered range size is unit, otherwise it is the divisor. 2166 Constant *RangeSize = 2167 Div->isExact() ? ConstantInt::get(Div->getType(), 1) : DivRHS; 2168 2169 // Figure out the interval that is being checked. For example, a comparison 2170 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2171 // Compute this interval based on the constants involved and the signedness of 2172 // the compare/divide. This computes a half-open interval, keeping track of 2173 // whether either value in the interval overflows. After analysis each 2174 // overflow variable is set to 0 if it's corresponding bound variable is valid 2175 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2176 int LoOverflow = 0, HiOverflow = 0; 2177 Constant *LoBound = nullptr, *HiBound = nullptr; 2178 2179 if (!DivIsSigned) { // udiv 2180 // e.g. X/5 op 3 --> [15, 20) 2181 LoBound = Prod; 2182 HiOverflow = LoOverflow = ProdOV; 2183 if (!HiOverflow) { 2184 // If this is not an exact divide, then many values in the range collapse 2185 // to the same result value. 2186 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2187 } 2188 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2189 if (*C == 0) { // (X / pos) op 0 2190 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2191 LoBound = ConstantExpr::getNeg(SubOne(RangeSize)); 2192 HiBound = RangeSize; 2193 } else if (C->isStrictlyPositive()) { // (X / pos) op pos 2194 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2195 HiOverflow = LoOverflow = ProdOV; 2196 if (!HiOverflow) 2197 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2198 } else { // (X / pos) op neg 2199 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2200 HiBound = AddOne(Prod); 2201 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2202 if (!LoOverflow) { 2203 Constant *DivNeg = ConstantExpr::getNeg(RangeSize); 2204 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2205 } 2206 } 2207 } else if (C2->isNegative()) { // Divisor is < 0. 2208 if (Div->isExact()) 2209 RangeSize = ConstantExpr::getNeg(RangeSize); 2210 if (*C == 0) { // (X / neg) op 0 2211 // e.g. X/-5 op 0 --> [-4, 5) 2212 LoBound = AddOne(RangeSize); 2213 HiBound = ConstantExpr::getNeg(RangeSize); 2214 if (HiBound == DivRHS) { // -INTMIN = INTMIN 2215 HiOverflow = 1; // [INTMIN+1, overflow) 2216 HiBound = nullptr; // e.g. X/INTMIN = 0 --> X > INTMIN 2217 } 2218 } else if (C->isStrictlyPositive()) { // (X / neg) op pos 2219 // e.g. X/-5 op 3 --> [-19, -14) 2220 HiBound = AddOne(Prod); 2221 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2222 if (!LoOverflow) 2223 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2224 } else { // (X / neg) op neg 2225 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2226 LoOverflow = HiOverflow = ProdOV; 2227 if (!HiOverflow) 2228 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2229 } 2230 2231 // Dividing by a negative swaps the condition. LT <-> GT 2232 Pred = ICmpInst::getSwappedPredicate(Pred); 2233 } 2234 2235 Value *X = Div->getOperand(0); 2236 switch (Pred) { 2237 default: llvm_unreachable("Unhandled icmp opcode!"); 2238 case ICmpInst::ICMP_EQ: 2239 if (LoOverflow && HiOverflow) 2240 return replaceInstUsesWith(Cmp, Builder->getFalse()); 2241 if (HiOverflow) 2242 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2243 ICmpInst::ICMP_UGE, X, LoBound); 2244 if (LoOverflow) 2245 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2246 ICmpInst::ICMP_ULT, X, HiBound); 2247 return replaceInstUsesWith( 2248 Cmp, insertRangeTest(X, LoBound->getUniqueInteger(), 2249 HiBound->getUniqueInteger(), DivIsSigned, true)); 2250 case ICmpInst::ICMP_NE: 2251 if (LoOverflow && HiOverflow) 2252 return replaceInstUsesWith(Cmp, Builder->getTrue()); 2253 if (HiOverflow) 2254 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2255 ICmpInst::ICMP_ULT, X, LoBound); 2256 if (LoOverflow) 2257 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2258 ICmpInst::ICMP_UGE, X, HiBound); 2259 return replaceInstUsesWith(Cmp, 2260 insertRangeTest(X, LoBound->getUniqueInteger(), 2261 HiBound->getUniqueInteger(), 2262 DivIsSigned, false)); 2263 case ICmpInst::ICMP_ULT: 2264 case ICmpInst::ICMP_SLT: 2265 if (LoOverflow == +1) // Low bound is greater than input range. 2266 return replaceInstUsesWith(Cmp, Builder->getTrue()); 2267 if (LoOverflow == -1) // Low bound is less than input range. 2268 return replaceInstUsesWith(Cmp, Builder->getFalse()); 2269 return new ICmpInst(Pred, X, LoBound); 2270 case ICmpInst::ICMP_UGT: 2271 case ICmpInst::ICMP_SGT: 2272 if (HiOverflow == +1) // High bound greater than input range. 2273 return replaceInstUsesWith(Cmp, Builder->getFalse()); 2274 if (HiOverflow == -1) // High bound less than input range. 2275 return replaceInstUsesWith(Cmp, Builder->getTrue()); 2276 if (Pred == ICmpInst::ICMP_UGT) 2277 return new ICmpInst(ICmpInst::ICMP_UGE, X, HiBound); 2278 return new ICmpInst(ICmpInst::ICMP_SGE, X, HiBound); 2279 } 2280 2281 return nullptr; 2282 } 2283 2284 /// Fold icmp (sub X, Y), C. 2285 Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp, 2286 BinaryOperator *Sub, 2287 const APInt *C) { 2288 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2289 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2290 2291 // The following transforms are only worth it if the only user of the subtract 2292 // is the icmp. 2293 if (!Sub->hasOneUse()) 2294 return nullptr; 2295 2296 if (Sub->hasNoSignedWrap()) { 2297 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2298 if (Pred == ICmpInst::ICMP_SGT && C->isAllOnesValue()) 2299 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2300 2301 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2302 if (Pred == ICmpInst::ICMP_SGT && *C == 0) 2303 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2304 2305 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2306 if (Pred == ICmpInst::ICMP_SLT && *C == 0) 2307 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2308 2309 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2310 if (Pred == ICmpInst::ICMP_SLT && *C == 1) 2311 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2312 } 2313 2314 const APInt *C2; 2315 if (!match(X, m_APInt(C2))) 2316 return nullptr; 2317 2318 // C2 - Y <u C -> (Y | (C - 1)) == C2 2319 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2320 if (Pred == ICmpInst::ICMP_ULT && C->isPowerOf2() && 2321 (*C2 & (*C - 1)) == (*C - 1)) 2322 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateOr(Y, *C - 1), X); 2323 2324 // C2 - Y >u C -> (Y | C) != C2 2325 // iff C2 & C == C and C + 1 is a power of 2 2326 if (Pred == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && (*C2 & *C) == *C) 2327 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateOr(Y, *C), X); 2328 2329 return nullptr; 2330 } 2331 2332 /// Fold icmp (add X, Y), C. 2333 Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp, 2334 BinaryOperator *Add, 2335 const APInt *C) { 2336 Value *Y = Add->getOperand(1); 2337 const APInt *C2; 2338 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2339 return nullptr; 2340 2341 // Fold icmp pred (add X, C2), C. 2342 Value *X = Add->getOperand(0); 2343 Type *Ty = Add->getType(); 2344 auto CR = 2345 ConstantRange::makeExactICmpRegion(Cmp.getPredicate(), *C).subtract(*C2); 2346 const APInt &Upper = CR.getUpper(); 2347 const APInt &Lower = CR.getLower(); 2348 if (Cmp.isSigned()) { 2349 if (Lower.isSignBit()) 2350 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2351 if (Upper.isSignBit()) 2352 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2353 } else { 2354 if (Lower.isMinValue()) 2355 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2356 if (Upper.isMinValue()) 2357 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2358 } 2359 2360 if (!Add->hasOneUse()) 2361 return nullptr; 2362 2363 // X+C <u C2 -> (X & -C2) == C 2364 // iff C & (C2-1) == 0 2365 // C2 is a power of 2 2366 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && C->isPowerOf2() && 2367 (*C2 & (*C - 1)) == 0) 2368 return new ICmpInst(ICmpInst::ICMP_EQ, Builder->CreateAnd(X, -(*C)), 2369 ConstantExpr::getNeg(cast<Constant>(Y))); 2370 2371 // X+C >u C2 -> (X & ~C2) != C 2372 // iff C & C2 == 0 2373 // C2+1 is a power of 2 2374 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && (*C + 1).isPowerOf2() && 2375 (*C2 & *C) == 0) 2376 return new ICmpInst(ICmpInst::ICMP_NE, Builder->CreateAnd(X, ~(*C)), 2377 ConstantExpr::getNeg(cast<Constant>(Y))); 2378 2379 return nullptr; 2380 } 2381 2382 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2383 /// where X is some kind of instruction. 2384 Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) { 2385 const APInt *C; 2386 if (!match(Cmp.getOperand(1), m_APInt(C))) 2387 return nullptr; 2388 2389 BinaryOperator *BO; 2390 if (match(Cmp.getOperand(0), m_BinOp(BO))) { 2391 switch (BO->getOpcode()) { 2392 case Instruction::Xor: 2393 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C)) 2394 return I; 2395 break; 2396 case Instruction::And: 2397 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C)) 2398 return I; 2399 break; 2400 case Instruction::Or: 2401 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C)) 2402 return I; 2403 break; 2404 case Instruction::Mul: 2405 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C)) 2406 return I; 2407 break; 2408 case Instruction::Shl: 2409 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C)) 2410 return I; 2411 break; 2412 case Instruction::LShr: 2413 case Instruction::AShr: 2414 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C)) 2415 return I; 2416 break; 2417 case Instruction::UDiv: 2418 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C)) 2419 return I; 2420 LLVM_FALLTHROUGH; 2421 case Instruction::SDiv: 2422 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C)) 2423 return I; 2424 break; 2425 case Instruction::Sub: 2426 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C)) 2427 return I; 2428 break; 2429 case Instruction::Add: 2430 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C)) 2431 return I; 2432 break; 2433 default: 2434 break; 2435 } 2436 // TODO: These folds could be refactored to be part of the above calls. 2437 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, C)) 2438 return I; 2439 } 2440 2441 Instruction *LHSI; 2442 if (match(Cmp.getOperand(0), m_Instruction(LHSI)) && 2443 LHSI->getOpcode() == Instruction::Trunc) 2444 if (Instruction *I = foldICmpTruncConstant(Cmp, LHSI, C)) 2445 return I; 2446 2447 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, C)) 2448 return I; 2449 2450 return nullptr; 2451 } 2452 2453 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 2454 /// icmp eq/ne BO, C. 2455 Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp, 2456 BinaryOperator *BO, 2457 const APInt *C) { 2458 // TODO: Some of these folds could work with arbitrary constants, but this 2459 // function is limited to scalar and vector splat constants. 2460 if (!Cmp.isEquality()) 2461 return nullptr; 2462 2463 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2464 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 2465 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 2466 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 2467 2468 switch (BO->getOpcode()) { 2469 case Instruction::SRem: 2470 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 2471 if (*C == 0 && BO->hasOneUse()) { 2472 const APInt *BOC; 2473 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 2474 Value *NewRem = Builder->CreateURem(BOp0, BOp1, BO->getName()); 2475 return new ICmpInst(Pred, NewRem, 2476 Constant::getNullValue(BO->getType())); 2477 } 2478 } 2479 break; 2480 case Instruction::Add: { 2481 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 2482 const APInt *BOC; 2483 if (match(BOp1, m_APInt(BOC))) { 2484 if (BO->hasOneUse()) { 2485 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1)); 2486 return new ICmpInst(Pred, BOp0, SubC); 2487 } 2488 } else if (*C == 0) { 2489 // Replace ((add A, B) != 0) with (A != -B) if A or B is 2490 // efficiently invertible, or if the add has just this one use. 2491 if (Value *NegVal = dyn_castNegVal(BOp1)) 2492 return new ICmpInst(Pred, BOp0, NegVal); 2493 if (Value *NegVal = dyn_castNegVal(BOp0)) 2494 return new ICmpInst(Pred, NegVal, BOp1); 2495 if (BO->hasOneUse()) { 2496 Value *Neg = Builder->CreateNeg(BOp1); 2497 Neg->takeName(BO); 2498 return new ICmpInst(Pred, BOp0, Neg); 2499 } 2500 } 2501 break; 2502 } 2503 case Instruction::Xor: 2504 if (BO->hasOneUse()) { 2505 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2506 // For the xor case, we can xor two constants together, eliminating 2507 // the explicit xor. 2508 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 2509 } else if (*C == 0) { 2510 // Replace ((xor A, B) != 0) with (A != B) 2511 return new ICmpInst(Pred, BOp0, BOp1); 2512 } 2513 } 2514 break; 2515 case Instruction::Sub: 2516 if (BO->hasOneUse()) { 2517 const APInt *BOC; 2518 if (match(BOp0, m_APInt(BOC))) { 2519 // Replace ((sub BOC, B) != C) with (B != BOC-C). 2520 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS); 2521 return new ICmpInst(Pred, BOp1, SubC); 2522 } else if (*C == 0) { 2523 // Replace ((sub A, B) != 0) with (A != B). 2524 return new ICmpInst(Pred, BOp0, BOp1); 2525 } 2526 } 2527 break; 2528 case Instruction::Or: { 2529 const APInt *BOC; 2530 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 2531 // Comparing if all bits outside of a constant mask are set? 2532 // Replace (X | C) == -1 with (X & ~C) == ~C. 2533 // This removes the -1 constant. 2534 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 2535 Value *And = Builder->CreateAnd(BOp0, NotBOC); 2536 return new ICmpInst(Pred, And, NotBOC); 2537 } 2538 break; 2539 } 2540 case Instruction::And: { 2541 const APInt *BOC; 2542 if (match(BOp1, m_APInt(BOC))) { 2543 // If we have ((X & C) == C), turn it into ((X & C) != 0). 2544 if (C == BOC && C->isPowerOf2()) 2545 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 2546 BO, Constant::getNullValue(RHS->getType())); 2547 2548 // Don't perform the following transforms if the AND has multiple uses 2549 if (!BO->hasOneUse()) 2550 break; 2551 2552 // Replace (and X, (1 << size(X)-1) != 0) with x s< 0 2553 if (BOC->isSignBit()) { 2554 Constant *Zero = Constant::getNullValue(BOp0->getType()); 2555 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 2556 return new ICmpInst(NewPred, BOp0, Zero); 2557 } 2558 2559 // ((X & ~7) == 0) --> X < 8 2560 if (*C == 0 && (~(*BOC) + 1).isPowerOf2()) { 2561 Constant *NegBOC = ConstantExpr::getNeg(cast<Constant>(BOp1)); 2562 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 2563 return new ICmpInst(NewPred, BOp0, NegBOC); 2564 } 2565 } 2566 break; 2567 } 2568 case Instruction::Mul: 2569 if (*C == 0 && BO->hasNoSignedWrap()) { 2570 const APInt *BOC; 2571 if (match(BOp1, m_APInt(BOC)) && *BOC != 0) { 2572 // The trivial case (mul X, 0) is handled by InstSimplify. 2573 // General case : (mul X, C) != 0 iff X != 0 2574 // (mul X, C) == 0 iff X == 0 2575 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType())); 2576 } 2577 } 2578 break; 2579 case Instruction::UDiv: 2580 if (*C == 0) { 2581 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 2582 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 2583 return new ICmpInst(NewPred, BOp1, BOp0); 2584 } 2585 break; 2586 default: 2587 break; 2588 } 2589 return nullptr; 2590 } 2591 2592 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 2593 Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 2594 const APInt *C) { 2595 IntrinsicInst *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0)); 2596 if (!II || !Cmp.isEquality()) 2597 return nullptr; 2598 2599 // Handle icmp {eq|ne} <intrinsic>, intcst. 2600 switch (II->getIntrinsicID()) { 2601 case Intrinsic::bswap: 2602 Worklist.Add(II); 2603 Cmp.setOperand(0, II->getArgOperand(0)); 2604 Cmp.setOperand(1, Builder->getInt(C->byteSwap())); 2605 return &Cmp; 2606 case Intrinsic::ctlz: 2607 case Intrinsic::cttz: 2608 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 2609 if (*C == C->getBitWidth()) { 2610 Worklist.Add(II); 2611 Cmp.setOperand(0, II->getArgOperand(0)); 2612 Cmp.setOperand(1, ConstantInt::getNullValue(II->getType())); 2613 return &Cmp; 2614 } 2615 break; 2616 case Intrinsic::ctpop: { 2617 // popcount(A) == 0 -> A == 0 and likewise for != 2618 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 2619 bool IsZero = *C == 0; 2620 if (IsZero || *C == C->getBitWidth()) { 2621 Worklist.Add(II); 2622 Cmp.setOperand(0, II->getArgOperand(0)); 2623 auto *NewOp = IsZero ? Constant::getNullValue(II->getType()) 2624 : Constant::getAllOnesValue(II->getType()); 2625 Cmp.setOperand(1, NewOp); 2626 return &Cmp; 2627 } 2628 break; 2629 } 2630 default: 2631 break; 2632 } 2633 return nullptr; 2634 } 2635 2636 /// Handle icmp with constant (but not simple integer constant) RHS. 2637 Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) { 2638 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 2639 Constant *RHSC = dyn_cast<Constant>(Op1); 2640 Instruction *LHSI = dyn_cast<Instruction>(Op0); 2641 if (!RHSC || !LHSI) 2642 return nullptr; 2643 2644 switch (LHSI->getOpcode()) { 2645 case Instruction::GetElementPtr: 2646 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 2647 if (RHSC->isNullValue() && 2648 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 2649 return new ICmpInst( 2650 I.getPredicate(), LHSI->getOperand(0), 2651 Constant::getNullValue(LHSI->getOperand(0)->getType())); 2652 break; 2653 case Instruction::PHI: 2654 // Only fold icmp into the PHI if the phi and icmp are in the same 2655 // block. If in the same block, we're encouraging jump threading. If 2656 // not, we are just pessimizing the code by making an i1 phi. 2657 if (LHSI->getParent() == I.getParent()) 2658 if (Instruction *NV = FoldOpIntoPhi(I)) 2659 return NV; 2660 break; 2661 case Instruction::Select: { 2662 // If either operand of the select is a constant, we can fold the 2663 // comparison into the select arms, which will cause one to be 2664 // constant folded and the select turned into a bitwise or. 2665 Value *Op1 = nullptr, *Op2 = nullptr; 2666 ConstantInt *CI = nullptr; 2667 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) { 2668 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 2669 CI = dyn_cast<ConstantInt>(Op1); 2670 } 2671 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) { 2672 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 2673 CI = dyn_cast<ConstantInt>(Op2); 2674 } 2675 2676 // We only want to perform this transformation if it will not lead to 2677 // additional code. This is true if either both sides of the select 2678 // fold to a constant (in which case the icmp is replaced with a select 2679 // which will usually simplify) or this is the only user of the 2680 // select (in which case we are trading a select+icmp for a simpler 2681 // select+icmp) or all uses of the select can be replaced based on 2682 // dominance information ("Global cases"). 2683 bool Transform = false; 2684 if (Op1 && Op2) 2685 Transform = true; 2686 else if (Op1 || Op2) { 2687 // Local case 2688 if (LHSI->hasOneUse()) 2689 Transform = true; 2690 // Global cases 2691 else if (CI && !CI->isZero()) 2692 // When Op1 is constant try replacing select with second operand. 2693 // Otherwise Op2 is constant and try replacing select with first 2694 // operand. 2695 Transform = 2696 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 2697 } 2698 if (Transform) { 2699 if (!Op1) 2700 Op1 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 2701 I.getName()); 2702 if (!Op2) 2703 Op2 = Builder->CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 2704 I.getName()); 2705 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 2706 } 2707 break; 2708 } 2709 case Instruction::IntToPtr: 2710 // icmp pred inttoptr(X), null -> icmp pred X, 0 2711 if (RHSC->isNullValue() && 2712 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 2713 return new ICmpInst( 2714 I.getPredicate(), LHSI->getOperand(0), 2715 Constant::getNullValue(LHSI->getOperand(0)->getType())); 2716 break; 2717 2718 case Instruction::Load: 2719 // Try to optimize things like "A[i] > 4" to index computations. 2720 if (GetElementPtrInst *GEP = 2721 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 2722 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 2723 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 2724 !cast<LoadInst>(LHSI)->isVolatile()) 2725 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 2726 return Res; 2727 } 2728 break; 2729 } 2730 2731 return nullptr; 2732 } 2733 2734 /// Try to fold icmp (binop), X or icmp X, (binop). 2735 Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) { 2736 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 2737 2738 // Special logic for binary operators. 2739 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 2740 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 2741 if (!BO0 && !BO1) 2742 return nullptr; 2743 2744 CmpInst::Predicate Pred = I.getPredicate(); 2745 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 2746 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 2747 NoOp0WrapProblem = 2748 ICmpInst::isEquality(Pred) || 2749 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 2750 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 2751 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 2752 NoOp1WrapProblem = 2753 ICmpInst::isEquality(Pred) || 2754 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 2755 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 2756 2757 // Analyze the case when either Op0 or Op1 is an add instruction. 2758 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 2759 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 2760 if (BO0 && BO0->getOpcode() == Instruction::Add) { 2761 A = BO0->getOperand(0); 2762 B = BO0->getOperand(1); 2763 } 2764 if (BO1 && BO1->getOpcode() == Instruction::Add) { 2765 C = BO1->getOperand(0); 2766 D = BO1->getOperand(1); 2767 } 2768 2769 // icmp (X+cst) < 0 --> X < -cst 2770 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred) && match(Op1, m_Zero())) 2771 if (ConstantInt *RHSC = dyn_cast_or_null<ConstantInt>(B)) 2772 if (!RHSC->isMinValue(/*isSigned=*/true)) 2773 return new ICmpInst(Pred, A, ConstantExpr::getNeg(RHSC)); 2774 2775 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow. 2776 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 2777 return new ICmpInst(Pred, A == Op1 ? B : A, 2778 Constant::getNullValue(Op1->getType())); 2779 2780 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow. 2781 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 2782 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 2783 C == Op0 ? D : C); 2784 2785 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow. 2786 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 2787 NoOp1WrapProblem && 2788 // Try not to increase register pressure. 2789 BO0->hasOneUse() && BO1->hasOneUse()) { 2790 // Determine Y and Z in the form icmp (X+Y), (X+Z). 2791 Value *Y, *Z; 2792 if (A == C) { 2793 // C + B == C + D -> B == D 2794 Y = B; 2795 Z = D; 2796 } else if (A == D) { 2797 // D + B == C + D -> B == C 2798 Y = B; 2799 Z = C; 2800 } else if (B == C) { 2801 // A + C == C + D -> A == D 2802 Y = A; 2803 Z = D; 2804 } else { 2805 assert(B == D); 2806 // A + D == C + D -> A == C 2807 Y = A; 2808 Z = C; 2809 } 2810 return new ICmpInst(Pred, Y, Z); 2811 } 2812 2813 // icmp slt (X + -1), Y -> icmp sle X, Y 2814 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 2815 match(B, m_AllOnes())) 2816 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 2817 2818 // icmp sge (X + -1), Y -> icmp sgt X, Y 2819 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 2820 match(B, m_AllOnes())) 2821 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 2822 2823 // icmp sle (X + 1), Y -> icmp slt X, Y 2824 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 2825 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 2826 2827 // icmp sgt (X + 1), Y -> icmp sge X, Y 2828 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 2829 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 2830 2831 // icmp sgt X, (Y + -1) -> icmp sge X, Y 2832 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 2833 match(D, m_AllOnes())) 2834 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 2835 2836 // icmp sle X, (Y + -1) -> icmp slt X, Y 2837 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 2838 match(D, m_AllOnes())) 2839 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 2840 2841 // icmp sge X, (Y + 1) -> icmp sgt X, Y 2842 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 2843 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 2844 2845 // icmp slt X, (Y + 1) -> icmp sle X, Y 2846 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 2847 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 2848 2849 // TODO: The subtraction-related identities shown below also hold, but 2850 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 2851 // wouldn't happen even if they were implemented. 2852 // 2853 // icmp ult (X - 1), Y -> icmp ule X, Y 2854 // icmp uge (X - 1), Y -> icmp ugt X, Y 2855 // icmp ugt X, (Y - 1) -> icmp uge X, Y 2856 // icmp ule X, (Y - 1) -> icmp ult X, Y 2857 2858 // icmp ule (X + 1), Y -> icmp ult X, Y 2859 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 2860 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 2861 2862 // icmp ugt (X + 1), Y -> icmp uge X, Y 2863 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 2864 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 2865 2866 // icmp uge X, (Y + 1) -> icmp ugt X, Y 2867 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 2868 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 2869 2870 // icmp ult X, (Y + 1) -> icmp ule X, Y 2871 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 2872 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 2873 2874 // if C1 has greater magnitude than C2: 2875 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y 2876 // s.t. C3 = C1 - C2 2877 // 2878 // if C2 has greater magnitude than C1: 2879 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3) 2880 // s.t. C3 = C2 - C1 2881 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 2882 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 2883 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 2884 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 2885 const APInt &AP1 = C1->getValue(); 2886 const APInt &AP2 = C2->getValue(); 2887 if (AP1.isNegative() == AP2.isNegative()) { 2888 APInt AP1Abs = C1->getValue().abs(); 2889 APInt AP2Abs = C2->getValue().abs(); 2890 if (AP1Abs.uge(AP2Abs)) { 2891 ConstantInt *C3 = Builder->getInt(AP1 - AP2); 2892 Value *NewAdd = Builder->CreateNSWAdd(A, C3); 2893 return new ICmpInst(Pred, NewAdd, C); 2894 } else { 2895 ConstantInt *C3 = Builder->getInt(AP2 - AP1); 2896 Value *NewAdd = Builder->CreateNSWAdd(C, C3); 2897 return new ICmpInst(Pred, A, NewAdd); 2898 } 2899 } 2900 } 2901 2902 // Analyze the case when either Op0 or Op1 is a sub instruction. 2903 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 2904 A = nullptr; 2905 B = nullptr; 2906 C = nullptr; 2907 D = nullptr; 2908 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 2909 A = BO0->getOperand(0); 2910 B = BO0->getOperand(1); 2911 } 2912 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 2913 C = BO1->getOperand(0); 2914 D = BO1->getOperand(1); 2915 } 2916 2917 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow. 2918 if (A == Op1 && NoOp0WrapProblem) 2919 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 2920 2921 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow. 2922 if (C == Op0 && NoOp1WrapProblem) 2923 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 2924 2925 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow. 2926 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem && 2927 // Try not to increase register pressure. 2928 BO0->hasOneUse() && BO1->hasOneUse()) 2929 return new ICmpInst(Pred, A, C); 2930 2931 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow. 2932 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem && 2933 // Try not to increase register pressure. 2934 BO0->hasOneUse() && BO1->hasOneUse()) 2935 return new ICmpInst(Pred, D, B); 2936 2937 // icmp (0-X) < cst --> x > -cst 2938 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 2939 Value *X; 2940 if (match(BO0, m_Neg(m_Value(X)))) 2941 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1)) 2942 if (!RHSC->isMinValue(/*isSigned=*/true)) 2943 return new ICmpInst(I.getSwappedPredicate(), X, 2944 ConstantExpr::getNeg(RHSC)); 2945 } 2946 2947 BinaryOperator *SRem = nullptr; 2948 // icmp (srem X, Y), Y 2949 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 2950 SRem = BO0; 2951 // icmp Y, (srem X, Y) 2952 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 2953 Op0 == BO1->getOperand(1)) 2954 SRem = BO1; 2955 if (SRem) { 2956 // We don't check hasOneUse to avoid increasing register pressure because 2957 // the value we use is the same value this instruction was already using. 2958 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 2959 default: 2960 break; 2961 case ICmpInst::ICMP_EQ: 2962 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 2963 case ICmpInst::ICMP_NE: 2964 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 2965 case ICmpInst::ICMP_SGT: 2966 case ICmpInst::ICMP_SGE: 2967 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 2968 Constant::getAllOnesValue(SRem->getType())); 2969 case ICmpInst::ICMP_SLT: 2970 case ICmpInst::ICMP_SLE: 2971 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 2972 Constant::getNullValue(SRem->getType())); 2973 } 2974 } 2975 2976 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 2977 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 2978 switch (BO0->getOpcode()) { 2979 default: 2980 break; 2981 case Instruction::Add: 2982 case Instruction::Sub: 2983 case Instruction::Xor: 2984 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 2985 return new ICmpInst(I.getPredicate(), BO0->getOperand(0), 2986 BO1->getOperand(0)); 2987 // icmp u/s (a ^ signbit), (b ^ signbit) --> icmp s/u a, b 2988 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) { 2989 if (CI->getValue().isSignBit()) { 2990 ICmpInst::Predicate Pred = 2991 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 2992 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 2993 } 2994 2995 if (BO0->getOpcode() == Instruction::Xor && CI->isMaxValue(true)) { 2996 ICmpInst::Predicate Pred = 2997 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 2998 Pred = I.getSwappedPredicate(Pred); 2999 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3000 } 3001 } 3002 break; 3003 case Instruction::Mul: 3004 if (!I.isEquality()) 3005 break; 3006 3007 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO0->getOperand(1))) { 3008 // a * Cst icmp eq/ne b * Cst --> a & Mask icmp b & Mask 3009 // Mask = -1 >> count-trailing-zeros(Cst). 3010 if (!CI->isZero() && !CI->isOne()) { 3011 const APInt &AP = CI->getValue(); 3012 ConstantInt *Mask = ConstantInt::get( 3013 I.getContext(), 3014 APInt::getLowBitsSet(AP.getBitWidth(), 3015 AP.getBitWidth() - AP.countTrailingZeros())); 3016 Value *And1 = Builder->CreateAnd(BO0->getOperand(0), Mask); 3017 Value *And2 = Builder->CreateAnd(BO1->getOperand(0), Mask); 3018 return new ICmpInst(I.getPredicate(), And1, And2); 3019 } 3020 } 3021 break; 3022 case Instruction::UDiv: 3023 case Instruction::LShr: 3024 if (I.isSigned()) 3025 break; 3026 LLVM_FALLTHROUGH; 3027 case Instruction::SDiv: 3028 case Instruction::AShr: 3029 if (!BO0->isExact() || !BO1->isExact()) 3030 break; 3031 return new ICmpInst(I.getPredicate(), BO0->getOperand(0), 3032 BO1->getOperand(0)); 3033 case Instruction::Shl: { 3034 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 3035 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 3036 if (!NUW && !NSW) 3037 break; 3038 if (!NSW && I.isSigned()) 3039 break; 3040 return new ICmpInst(I.getPredicate(), BO0->getOperand(0), 3041 BO1->getOperand(0)); 3042 } 3043 } 3044 } 3045 3046 if (BO0) { 3047 // Transform A & (L - 1) `ult` L --> L != 0 3048 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 3049 auto BitwiseAnd = 3050 m_CombineOr(m_And(m_Value(), LSubOne), m_And(LSubOne, m_Value())); 3051 3052 if (match(BO0, BitwiseAnd) && I.getPredicate() == ICmpInst::ICMP_ULT) { 3053 auto *Zero = Constant::getNullValue(BO0->getType()); 3054 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 3055 } 3056 } 3057 3058 return nullptr; 3059 } 3060 3061 /// Fold icmp Pred min|max(X, Y), X. 3062 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 3063 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3064 Value *Op0 = Cmp.getOperand(0); 3065 Value *X = Cmp.getOperand(1); 3066 3067 // Canonicalize minimum or maximum operand to LHS of the icmp. 3068 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 3069 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 3070 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 3071 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 3072 std::swap(Op0, X); 3073 Pred = Cmp.getSwappedPredicate(); 3074 } 3075 3076 Value *Y; 3077 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 3078 // smin(X, Y) == X --> X s<= Y 3079 // smin(X, Y) s>= X --> X s<= Y 3080 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 3081 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 3082 3083 // smin(X, Y) != X --> X s> Y 3084 // smin(X, Y) s< X --> X s> Y 3085 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 3086 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 3087 3088 // These cases should be handled in InstSimplify: 3089 // smin(X, Y) s<= X --> true 3090 // smin(X, Y) s> X --> false 3091 return nullptr; 3092 } 3093 3094 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 3095 // smax(X, Y) == X --> X s>= Y 3096 // smax(X, Y) s<= X --> X s>= Y 3097 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 3098 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 3099 3100 // smax(X, Y) != X --> X s< Y 3101 // smax(X, Y) s> X --> X s< Y 3102 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 3103 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 3104 3105 // These cases should be handled in InstSimplify: 3106 // smax(X, Y) s>= X --> true 3107 // smax(X, Y) s< X --> false 3108 return nullptr; 3109 } 3110 3111 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 3112 // umin(X, Y) == X --> X u<= Y 3113 // umin(X, Y) u>= X --> X u<= Y 3114 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 3115 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 3116 3117 // umin(X, Y) != X --> X u> Y 3118 // umin(X, Y) u< X --> X u> Y 3119 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 3120 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 3121 3122 // These cases should be handled in InstSimplify: 3123 // umin(X, Y) u<= X --> true 3124 // umin(X, Y) u> X --> false 3125 return nullptr; 3126 } 3127 3128 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 3129 // umax(X, Y) == X --> X u>= Y 3130 // umax(X, Y) u<= X --> X u>= Y 3131 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 3132 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 3133 3134 // umax(X, Y) != X --> X u< Y 3135 // umax(X, Y) u> X --> X u< Y 3136 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 3137 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 3138 3139 // These cases should be handled in InstSimplify: 3140 // umax(X, Y) u>= X --> true 3141 // umax(X, Y) u< X --> false 3142 return nullptr; 3143 } 3144 3145 return nullptr; 3146 } 3147 3148 Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) { 3149 if (!I.isEquality()) 3150 return nullptr; 3151 3152 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3153 Value *A, *B, *C, *D; 3154 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 3155 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 3156 Value *OtherVal = A == Op1 ? B : A; 3157 return new ICmpInst(I.getPredicate(), OtherVal, 3158 Constant::getNullValue(A->getType())); 3159 } 3160 3161 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 3162 // A^c1 == C^c2 --> A == C^(c1^c2) 3163 ConstantInt *C1, *C2; 3164 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 3165 Op1->hasOneUse()) { 3166 Constant *NC = Builder->getInt(C1->getValue() ^ C2->getValue()); 3167 Value *Xor = Builder->CreateXor(C, NC); 3168 return new ICmpInst(I.getPredicate(), A, Xor); 3169 } 3170 3171 // A^B == A^D -> B == D 3172 if (A == C) 3173 return new ICmpInst(I.getPredicate(), B, D); 3174 if (A == D) 3175 return new ICmpInst(I.getPredicate(), B, C); 3176 if (B == C) 3177 return new ICmpInst(I.getPredicate(), A, D); 3178 if (B == D) 3179 return new ICmpInst(I.getPredicate(), A, C); 3180 } 3181 } 3182 3183 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 3184 // A == (A^B) -> B == 0 3185 Value *OtherVal = A == Op0 ? B : A; 3186 return new ICmpInst(I.getPredicate(), OtherVal, 3187 Constant::getNullValue(A->getType())); 3188 } 3189 3190 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 3191 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 3192 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 3193 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 3194 3195 if (A == C) { 3196 X = B; 3197 Y = D; 3198 Z = A; 3199 } else if (A == D) { 3200 X = B; 3201 Y = C; 3202 Z = A; 3203 } else if (B == C) { 3204 X = A; 3205 Y = D; 3206 Z = B; 3207 } else if (B == D) { 3208 X = A; 3209 Y = C; 3210 Z = B; 3211 } 3212 3213 if (X) { // Build (X^Y) & Z 3214 Op1 = Builder->CreateXor(X, Y); 3215 Op1 = Builder->CreateAnd(Op1, Z); 3216 I.setOperand(0, Op1); 3217 I.setOperand(1, Constant::getNullValue(Op1->getType())); 3218 return &I; 3219 } 3220 } 3221 3222 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 3223 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 3224 ConstantInt *Cst1; 3225 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 3226 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 3227 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 3228 match(Op1, m_ZExt(m_Value(A))))) { 3229 APInt Pow2 = Cst1->getValue() + 1; 3230 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 3231 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 3232 return new ICmpInst(I.getPredicate(), A, 3233 Builder->CreateTrunc(B, A->getType())); 3234 } 3235 3236 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 3237 // For lshr and ashr pairs. 3238 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 3239 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 3240 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 3241 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 3242 unsigned TypeBits = Cst1->getBitWidth(); 3243 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3244 if (ShAmt < TypeBits && ShAmt != 0) { 3245 ICmpInst::Predicate Pred = I.getPredicate() == ICmpInst::ICMP_NE 3246 ? ICmpInst::ICMP_UGE 3247 : ICmpInst::ICMP_ULT; 3248 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted"); 3249 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 3250 return new ICmpInst(Pred, Xor, Builder->getInt(CmpVal)); 3251 } 3252 } 3253 3254 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 3255 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 3256 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 3257 unsigned TypeBits = Cst1->getBitWidth(); 3258 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3259 if (ShAmt < TypeBits && ShAmt != 0) { 3260 Value *Xor = Builder->CreateXor(A, B, I.getName() + ".unshifted"); 3261 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 3262 Value *And = Builder->CreateAnd(Xor, Builder->getInt(AndVal), 3263 I.getName() + ".mask"); 3264 return new ICmpInst(I.getPredicate(), And, 3265 Constant::getNullValue(Cst1->getType())); 3266 } 3267 } 3268 3269 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 3270 // "icmp (and X, mask), cst" 3271 uint64_t ShAmt = 0; 3272 if (Op0->hasOneUse() && 3273 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 3274 match(Op1, m_ConstantInt(Cst1)) && 3275 // Only do this when A has multiple uses. This is most important to do 3276 // when it exposes other optimizations. 3277 !A->hasOneUse()) { 3278 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 3279 3280 if (ShAmt < ASize) { 3281 APInt MaskV = 3282 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 3283 MaskV <<= ShAmt; 3284 3285 APInt CmpV = Cst1->getValue().zext(ASize); 3286 CmpV <<= ShAmt; 3287 3288 Value *Mask = Builder->CreateAnd(A, Builder->getInt(MaskV)); 3289 return new ICmpInst(I.getPredicate(), Mask, Builder->getInt(CmpV)); 3290 } 3291 } 3292 3293 return nullptr; 3294 } 3295 3296 /// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so 3297 /// far. 3298 Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) { 3299 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0)); 3300 Value *LHSCIOp = LHSCI->getOperand(0); 3301 Type *SrcTy = LHSCIOp->getType(); 3302 Type *DestTy = LHSCI->getType(); 3303 Value *RHSCIOp; 3304 3305 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 3306 // integer type is the same size as the pointer type. 3307 if (LHSCI->getOpcode() == Instruction::PtrToInt && 3308 DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth()) { 3309 Value *RHSOp = nullptr; 3310 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 3311 Value *RHSCIOp = RHSC->getOperand(0); 3312 if (RHSCIOp->getType()->getPointerAddressSpace() == 3313 LHSCIOp->getType()->getPointerAddressSpace()) { 3314 RHSOp = RHSC->getOperand(0); 3315 // If the pointer types don't match, insert a bitcast. 3316 if (LHSCIOp->getType() != RHSOp->getType()) 3317 RHSOp = Builder->CreateBitCast(RHSOp, LHSCIOp->getType()); 3318 } 3319 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 3320 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy); 3321 } 3322 3323 if (RHSOp) 3324 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp); 3325 } 3326 3327 // The code below only handles extension cast instructions, so far. 3328 // Enforce this. 3329 if (LHSCI->getOpcode() != Instruction::ZExt && 3330 LHSCI->getOpcode() != Instruction::SExt) 3331 return nullptr; 3332 3333 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt; 3334 bool isSignedCmp = ICmp.isSigned(); 3335 3336 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) { 3337 // Not an extension from the same type? 3338 RHSCIOp = CI->getOperand(0); 3339 if (RHSCIOp->getType() != LHSCIOp->getType()) 3340 return nullptr; 3341 3342 // If the signedness of the two casts doesn't agree (i.e. one is a sext 3343 // and the other is a zext), then we can't handle this. 3344 if (CI->getOpcode() != LHSCI->getOpcode()) 3345 return nullptr; 3346 3347 // Deal with equality cases early. 3348 if (ICmp.isEquality()) 3349 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 3350 3351 // A signed comparison of sign extended values simplifies into a 3352 // signed comparison. 3353 if (isSignedCmp && isSignedExt) 3354 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 3355 3356 // The other three cases all fold into an unsigned comparison. 3357 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp); 3358 } 3359 3360 // If we aren't dealing with a constant on the RHS, exit early. 3361 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 3362 if (!C) 3363 return nullptr; 3364 3365 // Compute the constant that would happen if we truncated to SrcTy then 3366 // re-extended to DestTy. 3367 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 3368 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy); 3369 3370 // If the re-extended constant didn't change... 3371 if (Res2 == C) { 3372 // Deal with equality cases early. 3373 if (ICmp.isEquality()) 3374 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 3375 3376 // A signed comparison of sign extended values simplifies into a 3377 // signed comparison. 3378 if (isSignedExt && isSignedCmp) 3379 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 3380 3381 // The other three cases all fold into an unsigned comparison. 3382 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1); 3383 } 3384 3385 // The re-extended constant changed, partly changed (in the case of a vector), 3386 // or could not be determined to be equal (in the case of a constant 3387 // expression), so the constant cannot be represented in the shorter type. 3388 // Consequently, we cannot emit a simple comparison. 3389 // All the cases that fold to true or false will have already been handled 3390 // by SimplifyICmpInst, so only deal with the tricky case. 3391 3392 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C)) 3393 return nullptr; 3394 3395 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases 3396 // should have been folded away previously and not enter in here. 3397 3398 // We're performing an unsigned comp with a sign extended value. 3399 // This is true if the input is >= 0. [aka >s -1] 3400 Constant *NegOne = Constant::getAllOnesValue(SrcTy); 3401 Value *Result = Builder->CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName()); 3402 3403 // Finally, return the value computed. 3404 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 3405 return replaceInstUsesWith(ICmp, Result); 3406 3407 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 3408 return BinaryOperator::CreateNot(Result); 3409 } 3410 3411 bool InstCombiner::OptimizeOverflowCheck(OverflowCheckFlavor OCF, Value *LHS, 3412 Value *RHS, Instruction &OrigI, 3413 Value *&Result, Constant *&Overflow) { 3414 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 3415 std::swap(LHS, RHS); 3416 3417 auto SetResult = [&](Value *OpResult, Constant *OverflowVal, bool ReuseName) { 3418 Result = OpResult; 3419 Overflow = OverflowVal; 3420 if (ReuseName) 3421 Result->takeName(&OrigI); 3422 return true; 3423 }; 3424 3425 // If the overflow check was an add followed by a compare, the insertion point 3426 // may be pointing to the compare. We want to insert the new instructions 3427 // before the add in case there are uses of the add between the add and the 3428 // compare. 3429 Builder->SetInsertPoint(&OrigI); 3430 3431 switch (OCF) { 3432 case OCF_INVALID: 3433 llvm_unreachable("bad overflow check kind!"); 3434 3435 case OCF_UNSIGNED_ADD: { 3436 OverflowResult OR = computeOverflowForUnsignedAdd(LHS, RHS, &OrigI); 3437 if (OR == OverflowResult::NeverOverflows) 3438 return SetResult(Builder->CreateNUWAdd(LHS, RHS), Builder->getFalse(), 3439 true); 3440 3441 if (OR == OverflowResult::AlwaysOverflows) 3442 return SetResult(Builder->CreateAdd(LHS, RHS), Builder->getTrue(), true); 3443 3444 // Fall through uadd into sadd 3445 LLVM_FALLTHROUGH; 3446 } 3447 case OCF_SIGNED_ADD: { 3448 // X + 0 -> {X, false} 3449 if (match(RHS, m_Zero())) 3450 return SetResult(LHS, Builder->getFalse(), false); 3451 3452 // We can strength reduce this signed add into a regular add if we can prove 3453 // that it will never overflow. 3454 if (OCF == OCF_SIGNED_ADD) 3455 if (WillNotOverflowSignedAdd(LHS, RHS, OrigI)) 3456 return SetResult(Builder->CreateNSWAdd(LHS, RHS), Builder->getFalse(), 3457 true); 3458 break; 3459 } 3460 3461 case OCF_UNSIGNED_SUB: 3462 case OCF_SIGNED_SUB: { 3463 // X - 0 -> {X, false} 3464 if (match(RHS, m_Zero())) 3465 return SetResult(LHS, Builder->getFalse(), false); 3466 3467 if (OCF == OCF_SIGNED_SUB) { 3468 if (WillNotOverflowSignedSub(LHS, RHS, OrigI)) 3469 return SetResult(Builder->CreateNSWSub(LHS, RHS), Builder->getFalse(), 3470 true); 3471 } else { 3472 if (WillNotOverflowUnsignedSub(LHS, RHS, OrigI)) 3473 return SetResult(Builder->CreateNUWSub(LHS, RHS), Builder->getFalse(), 3474 true); 3475 } 3476 break; 3477 } 3478 3479 case OCF_UNSIGNED_MUL: { 3480 OverflowResult OR = computeOverflowForUnsignedMul(LHS, RHS, &OrigI); 3481 if (OR == OverflowResult::NeverOverflows) 3482 return SetResult(Builder->CreateNUWMul(LHS, RHS), Builder->getFalse(), 3483 true); 3484 if (OR == OverflowResult::AlwaysOverflows) 3485 return SetResult(Builder->CreateMul(LHS, RHS), Builder->getTrue(), true); 3486 LLVM_FALLTHROUGH; 3487 } 3488 case OCF_SIGNED_MUL: 3489 // X * undef -> undef 3490 if (isa<UndefValue>(RHS)) 3491 return SetResult(RHS, UndefValue::get(Builder->getInt1Ty()), false); 3492 3493 // X * 0 -> {0, false} 3494 if (match(RHS, m_Zero())) 3495 return SetResult(RHS, Builder->getFalse(), false); 3496 3497 // X * 1 -> {X, false} 3498 if (match(RHS, m_One())) 3499 return SetResult(LHS, Builder->getFalse(), false); 3500 3501 if (OCF == OCF_SIGNED_MUL) 3502 if (WillNotOverflowSignedMul(LHS, RHS, OrigI)) 3503 return SetResult(Builder->CreateNSWMul(LHS, RHS), Builder->getFalse(), 3504 true); 3505 break; 3506 } 3507 3508 return false; 3509 } 3510 3511 /// \brief Recognize and process idiom involving test for multiplication 3512 /// overflow. 3513 /// 3514 /// The caller has matched a pattern of the form: 3515 /// I = cmp u (mul(zext A, zext B), V 3516 /// The function checks if this is a test for overflow and if so replaces 3517 /// multiplication with call to 'mul.with.overflow' intrinsic. 3518 /// 3519 /// \param I Compare instruction. 3520 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 3521 /// the compare instruction. Must be of integer type. 3522 /// \param OtherVal The other argument of compare instruction. 3523 /// \returns Instruction which must replace the compare instruction, NULL if no 3524 /// replacement required. 3525 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 3526 Value *OtherVal, InstCombiner &IC) { 3527 // Don't bother doing this transformation for pointers, don't do it for 3528 // vectors. 3529 if (!isa<IntegerType>(MulVal->getType())) 3530 return nullptr; 3531 3532 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 3533 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 3534 auto *MulInstr = dyn_cast<Instruction>(MulVal); 3535 if (!MulInstr) 3536 return nullptr; 3537 assert(MulInstr->getOpcode() == Instruction::Mul); 3538 3539 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 3540 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 3541 assert(LHS->getOpcode() == Instruction::ZExt); 3542 assert(RHS->getOpcode() == Instruction::ZExt); 3543 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 3544 3545 // Calculate type and width of the result produced by mul.with.overflow. 3546 Type *TyA = A->getType(), *TyB = B->getType(); 3547 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 3548 WidthB = TyB->getPrimitiveSizeInBits(); 3549 unsigned MulWidth; 3550 Type *MulType; 3551 if (WidthB > WidthA) { 3552 MulWidth = WidthB; 3553 MulType = TyB; 3554 } else { 3555 MulWidth = WidthA; 3556 MulType = TyA; 3557 } 3558 3559 // In order to replace the original mul with a narrower mul.with.overflow, 3560 // all uses must ignore upper bits of the product. The number of used low 3561 // bits must be not greater than the width of mul.with.overflow. 3562 if (MulVal->hasNUsesOrMore(2)) 3563 for (User *U : MulVal->users()) { 3564 if (U == &I) 3565 continue; 3566 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 3567 // Check if truncation ignores bits above MulWidth. 3568 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 3569 if (TruncWidth > MulWidth) 3570 return nullptr; 3571 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 3572 // Check if AND ignores bits above MulWidth. 3573 if (BO->getOpcode() != Instruction::And) 3574 return nullptr; 3575 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 3576 const APInt &CVal = CI->getValue(); 3577 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 3578 return nullptr; 3579 } 3580 } else { 3581 // Other uses prohibit this transformation. 3582 return nullptr; 3583 } 3584 } 3585 3586 // Recognize patterns 3587 switch (I.getPredicate()) { 3588 case ICmpInst::ICMP_EQ: 3589 case ICmpInst::ICMP_NE: 3590 // Recognize pattern: 3591 // mulval = mul(zext A, zext B) 3592 // cmp eq/neq mulval, zext trunc mulval 3593 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal)) 3594 if (Zext->hasOneUse()) { 3595 Value *ZextArg = Zext->getOperand(0); 3596 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg)) 3597 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth) 3598 break; //Recognized 3599 } 3600 3601 // Recognize pattern: 3602 // mulval = mul(zext A, zext B) 3603 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 3604 ConstantInt *CI; 3605 Value *ValToMask; 3606 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 3607 if (ValToMask != MulVal) 3608 return nullptr; 3609 const APInt &CVal = CI->getValue() + 1; 3610 if (CVal.isPowerOf2()) { 3611 unsigned MaskWidth = CVal.logBase2(); 3612 if (MaskWidth == MulWidth) 3613 break; // Recognized 3614 } 3615 } 3616 return nullptr; 3617 3618 case ICmpInst::ICMP_UGT: 3619 // Recognize pattern: 3620 // mulval = mul(zext A, zext B) 3621 // cmp ugt mulval, max 3622 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3623 APInt MaxVal = APInt::getMaxValue(MulWidth); 3624 MaxVal = MaxVal.zext(CI->getBitWidth()); 3625 if (MaxVal.eq(CI->getValue())) 3626 break; // Recognized 3627 } 3628 return nullptr; 3629 3630 case ICmpInst::ICMP_UGE: 3631 // Recognize pattern: 3632 // mulval = mul(zext A, zext B) 3633 // cmp uge mulval, max+1 3634 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3635 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 3636 if (MaxVal.eq(CI->getValue())) 3637 break; // Recognized 3638 } 3639 return nullptr; 3640 3641 case ICmpInst::ICMP_ULE: 3642 // Recognize pattern: 3643 // mulval = mul(zext A, zext B) 3644 // cmp ule mulval, max 3645 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3646 APInt MaxVal = APInt::getMaxValue(MulWidth); 3647 MaxVal = MaxVal.zext(CI->getBitWidth()); 3648 if (MaxVal.eq(CI->getValue())) 3649 break; // Recognized 3650 } 3651 return nullptr; 3652 3653 case ICmpInst::ICMP_ULT: 3654 // Recognize pattern: 3655 // mulval = mul(zext A, zext B) 3656 // cmp ule mulval, max + 1 3657 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 3658 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 3659 if (MaxVal.eq(CI->getValue())) 3660 break; // Recognized 3661 } 3662 return nullptr; 3663 3664 default: 3665 return nullptr; 3666 } 3667 3668 InstCombiner::BuilderTy *Builder = IC.Builder; 3669 Builder->SetInsertPoint(MulInstr); 3670 3671 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 3672 Value *MulA = A, *MulB = B; 3673 if (WidthA < MulWidth) 3674 MulA = Builder->CreateZExt(A, MulType); 3675 if (WidthB < MulWidth) 3676 MulB = Builder->CreateZExt(B, MulType); 3677 Value *F = Intrinsic::getDeclaration(I.getModule(), 3678 Intrinsic::umul_with_overflow, MulType); 3679 CallInst *Call = Builder->CreateCall(F, {MulA, MulB}, "umul"); 3680 IC.Worklist.Add(MulInstr); 3681 3682 // If there are uses of mul result other than the comparison, we know that 3683 // they are truncation or binary AND. Change them to use result of 3684 // mul.with.overflow and adjust properly mask/size. 3685 if (MulVal->hasNUsesOrMore(2)) { 3686 Value *Mul = Builder->CreateExtractValue(Call, 0, "umul.value"); 3687 for (User *U : MulVal->users()) { 3688 if (U == &I || U == OtherVal) 3689 continue; 3690 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 3691 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 3692 IC.replaceInstUsesWith(*TI, Mul); 3693 else 3694 TI->setOperand(0, Mul); 3695 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 3696 assert(BO->getOpcode() == Instruction::And); 3697 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 3698 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 3699 APInt ShortMask = CI->getValue().trunc(MulWidth); 3700 Value *ShortAnd = Builder->CreateAnd(Mul, ShortMask); 3701 Instruction *Zext = 3702 cast<Instruction>(Builder->CreateZExt(ShortAnd, BO->getType())); 3703 IC.Worklist.Add(Zext); 3704 IC.replaceInstUsesWith(*BO, Zext); 3705 } else { 3706 llvm_unreachable("Unexpected Binary operation"); 3707 } 3708 IC.Worklist.Add(cast<Instruction>(U)); 3709 } 3710 } 3711 if (isa<Instruction>(OtherVal)) 3712 IC.Worklist.Add(cast<Instruction>(OtherVal)); 3713 3714 // The original icmp gets replaced with the overflow value, maybe inverted 3715 // depending on predicate. 3716 bool Inverse = false; 3717 switch (I.getPredicate()) { 3718 case ICmpInst::ICMP_NE: 3719 break; 3720 case ICmpInst::ICMP_EQ: 3721 Inverse = true; 3722 break; 3723 case ICmpInst::ICMP_UGT: 3724 case ICmpInst::ICMP_UGE: 3725 if (I.getOperand(0) == MulVal) 3726 break; 3727 Inverse = true; 3728 break; 3729 case ICmpInst::ICMP_ULT: 3730 case ICmpInst::ICMP_ULE: 3731 if (I.getOperand(1) == MulVal) 3732 break; 3733 Inverse = true; 3734 break; 3735 default: 3736 llvm_unreachable("Unexpected predicate"); 3737 } 3738 if (Inverse) { 3739 Value *Res = Builder->CreateExtractValue(Call, 1); 3740 return BinaryOperator::CreateNot(Res); 3741 } 3742 3743 return ExtractValueInst::Create(Call, 1); 3744 } 3745 3746 /// When performing a comparison against a constant, it is possible that not all 3747 /// the bits in the LHS are demanded. This helper method computes the mask that 3748 /// IS demanded. 3749 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth, 3750 bool isSignCheck) { 3751 if (isSignCheck) 3752 return APInt::getSignBit(BitWidth); 3753 3754 ConstantInt *CI = dyn_cast<ConstantInt>(I.getOperand(1)); 3755 if (!CI) return APInt::getAllOnesValue(BitWidth); 3756 const APInt &RHS = CI->getValue(); 3757 3758 switch (I.getPredicate()) { 3759 // For a UGT comparison, we don't care about any bits that 3760 // correspond to the trailing ones of the comparand. The value of these 3761 // bits doesn't impact the outcome of the comparison, because any value 3762 // greater than the RHS must differ in a bit higher than these due to carry. 3763 case ICmpInst::ICMP_UGT: { 3764 unsigned trailingOnes = RHS.countTrailingOnes(); 3765 APInt lowBitsSet = APInt::getLowBitsSet(BitWidth, trailingOnes); 3766 return ~lowBitsSet; 3767 } 3768 3769 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 3770 // Any value less than the RHS must differ in a higher bit because of carries. 3771 case ICmpInst::ICMP_ULT: { 3772 unsigned trailingZeros = RHS.countTrailingZeros(); 3773 APInt lowBitsSet = APInt::getLowBitsSet(BitWidth, trailingZeros); 3774 return ~lowBitsSet; 3775 } 3776 3777 default: 3778 return APInt::getAllOnesValue(BitWidth); 3779 } 3780 } 3781 3782 /// \brief Check if the order of \p Op0 and \p Op1 as operand in an ICmpInst 3783 /// should be swapped. 3784 /// The decision is based on how many times these two operands are reused 3785 /// as subtract operands and their positions in those instructions. 3786 /// The rational is that several architectures use the same instruction for 3787 /// both subtract and cmp, thus it is better if the order of those operands 3788 /// match. 3789 /// \return true if Op0 and Op1 should be swapped. 3790 static bool swapMayExposeCSEOpportunities(const Value * Op0, 3791 const Value * Op1) { 3792 // Filter out pointer value as those cannot appears directly in subtract. 3793 // FIXME: we may want to go through inttoptrs or bitcasts. 3794 if (Op0->getType()->isPointerTy()) 3795 return false; 3796 // Count every uses of both Op0 and Op1 in a subtract. 3797 // Each time Op0 is the first operand, count -1: swapping is bad, the 3798 // subtract has already the same layout as the compare. 3799 // Each time Op0 is the second operand, count +1: swapping is good, the 3800 // subtract has a different layout as the compare. 3801 // At the end, if the benefit is greater than 0, Op0 should come second to 3802 // expose more CSE opportunities. 3803 int GlobalSwapBenefits = 0; 3804 for (const User *U : Op0->users()) { 3805 const BinaryOperator *BinOp = dyn_cast<BinaryOperator>(U); 3806 if (!BinOp || BinOp->getOpcode() != Instruction::Sub) 3807 continue; 3808 // If Op0 is the first argument, this is not beneficial to swap the 3809 // arguments. 3810 int LocalSwapBenefits = -1; 3811 unsigned Op1Idx = 1; 3812 if (BinOp->getOperand(Op1Idx) == Op0) { 3813 Op1Idx = 0; 3814 LocalSwapBenefits = 1; 3815 } 3816 if (BinOp->getOperand(Op1Idx) != Op1) 3817 continue; 3818 GlobalSwapBenefits += LocalSwapBenefits; 3819 } 3820 return GlobalSwapBenefits > 0; 3821 } 3822 3823 /// \brief Check that one use is in the same block as the definition and all 3824 /// other uses are in blocks dominated by a given block. 3825 /// 3826 /// \param DI Definition 3827 /// \param UI Use 3828 /// \param DB Block that must dominate all uses of \p DI outside 3829 /// the parent block 3830 /// \return true when \p UI is the only use of \p DI in the parent block 3831 /// and all other uses of \p DI are in blocks dominated by \p DB. 3832 /// 3833 bool InstCombiner::dominatesAllUses(const Instruction *DI, 3834 const Instruction *UI, 3835 const BasicBlock *DB) const { 3836 assert(DI && UI && "Instruction not defined\n"); 3837 // Ignore incomplete definitions. 3838 if (!DI->getParent()) 3839 return false; 3840 // DI and UI must be in the same block. 3841 if (DI->getParent() != UI->getParent()) 3842 return false; 3843 // Protect from self-referencing blocks. 3844 if (DI->getParent() == DB) 3845 return false; 3846 for (const User *U : DI->users()) { 3847 auto *Usr = cast<Instruction>(U); 3848 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 3849 return false; 3850 } 3851 return true; 3852 } 3853 3854 /// Return true when the instruction sequence within a block is select-cmp-br. 3855 static bool isChainSelectCmpBranch(const SelectInst *SI) { 3856 const BasicBlock *BB = SI->getParent(); 3857 if (!BB) 3858 return false; 3859 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 3860 if (!BI || BI->getNumSuccessors() != 2) 3861 return false; 3862 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 3863 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 3864 return false; 3865 return true; 3866 } 3867 3868 /// \brief True when a select result is replaced by one of its operands 3869 /// in select-icmp sequence. This will eventually result in the elimination 3870 /// of the select. 3871 /// 3872 /// \param SI Select instruction 3873 /// \param Icmp Compare instruction 3874 /// \param SIOpd Operand that replaces the select 3875 /// 3876 /// Notes: 3877 /// - The replacement is global and requires dominator information 3878 /// - The caller is responsible for the actual replacement 3879 /// 3880 /// Example: 3881 /// 3882 /// entry: 3883 /// %4 = select i1 %3, %C* %0, %C* null 3884 /// %5 = icmp eq %C* %4, null 3885 /// br i1 %5, label %9, label %7 3886 /// ... 3887 /// ; <label>:7 ; preds = %entry 3888 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 3889 /// ... 3890 /// 3891 /// can be transformed to 3892 /// 3893 /// %5 = icmp eq %C* %0, null 3894 /// %6 = select i1 %3, i1 %5, i1 true 3895 /// br i1 %6, label %9, label %7 3896 /// ... 3897 /// ; <label>:7 ; preds = %entry 3898 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 3899 /// 3900 /// Similar when the first operand of the select is a constant or/and 3901 /// the compare is for not equal rather than equal. 3902 /// 3903 /// NOTE: The function is only called when the select and compare constants 3904 /// are equal, the optimization can work only for EQ predicates. This is not a 3905 /// major restriction since a NE compare should be 'normalized' to an equal 3906 /// compare, which usually happens in the combiner and test case 3907 /// select-cmp-br.ll checks for it. 3908 bool InstCombiner::replacedSelectWithOperand(SelectInst *SI, 3909 const ICmpInst *Icmp, 3910 const unsigned SIOpd) { 3911 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 3912 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 3913 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 3914 // The check for the unique predecessor is not the best that can be 3915 // done. But it protects efficiently against cases like when SI's 3916 // home block has two successors, Succ and Succ1, and Succ1 predecessor 3917 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 3918 // replaced can be reached on either path. So the uniqueness check 3919 // guarantees that the path all uses of SI (outside SI's parent) are on 3920 // is disjoint from all other paths out of SI. But that information 3921 // is more expensive to compute, and the trade-off here is in favor 3922 // of compile-time. 3923 if (Succ->getUniquePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 3924 NumSel++; 3925 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 3926 return true; 3927 } 3928 } 3929 return false; 3930 } 3931 3932 /// Try to fold the comparison based on range information we can get by checking 3933 /// whether bits are known to be zero or one in the inputs. 3934 Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) { 3935 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3936 Type *Ty = Op0->getType(); 3937 ICmpInst::Predicate Pred = I.getPredicate(); 3938 3939 // Get scalar or pointer size. 3940 unsigned BitWidth = Ty->isIntOrIntVectorTy() 3941 ? Ty->getScalarSizeInBits() 3942 : DL.getTypeSizeInBits(Ty->getScalarType()); 3943 3944 if (!BitWidth) 3945 return nullptr; 3946 3947 // If this is a normal comparison, it demands all bits. If it is a sign bit 3948 // comparison, it only demands the sign bit. 3949 bool IsSignBit = false; 3950 const APInt *CmpC; 3951 if (match(Op1, m_APInt(CmpC))) { 3952 bool UnusedBit; 3953 IsSignBit = isSignBitCheck(Pred, *CmpC, UnusedBit); 3954 } 3955 3956 APInt Op0KnownZero(BitWidth, 0), Op0KnownOne(BitWidth, 0); 3957 APInt Op1KnownZero(BitWidth, 0), Op1KnownOne(BitWidth, 0); 3958 3959 if (SimplifyDemandedBits(I.getOperandUse(0), 3960 getDemandedBitsLHSMask(I, BitWidth, IsSignBit), 3961 Op0KnownZero, Op0KnownOne, 0)) 3962 return &I; 3963 3964 if (SimplifyDemandedBits(I.getOperandUse(1), APInt::getAllOnesValue(BitWidth), 3965 Op1KnownZero, Op1KnownOne, 0)) 3966 return &I; 3967 3968 // Given the known and unknown bits, compute a range that the LHS could be 3969 // in. Compute the Min, Max and RHS values based on the known bits. For the 3970 // EQ and NE we use unsigned values. 3971 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 3972 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 3973 if (I.isSigned()) { 3974 computeSignedMinMaxValuesFromKnownBits(Op0KnownZero, Op0KnownOne, Op0Min, 3975 Op0Max); 3976 computeSignedMinMaxValuesFromKnownBits(Op1KnownZero, Op1KnownOne, Op1Min, 3977 Op1Max); 3978 } else { 3979 computeUnsignedMinMaxValuesFromKnownBits(Op0KnownZero, Op0KnownOne, Op0Min, 3980 Op0Max); 3981 computeUnsignedMinMaxValuesFromKnownBits(Op1KnownZero, Op1KnownOne, Op1Min, 3982 Op1Max); 3983 } 3984 3985 // If Min and Max are known to be the same, then SimplifyDemandedBits 3986 // figured out that the LHS is a constant. Constant fold this now, so that 3987 // code below can assume that Min != Max. 3988 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 3989 return new ICmpInst(Pred, ConstantInt::get(Op0->getType(), Op0Min), Op1); 3990 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 3991 return new ICmpInst(Pred, Op0, ConstantInt::get(Op1->getType(), Op1Min)); 3992 3993 // Based on the range information we know about the LHS, see if we can 3994 // simplify this comparison. For example, (x&4) < 8 is always true. 3995 switch (Pred) { 3996 default: 3997 llvm_unreachable("Unknown icmp opcode!"); 3998 case ICmpInst::ICMP_EQ: 3999 case ICmpInst::ICMP_NE: { 4000 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) { 4001 return Pred == CmpInst::ICMP_EQ 4002 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())) 4003 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4004 } 4005 4006 // If all bits are known zero except for one, then we know at most one bit 4007 // is set. If the comparison is against zero, then this is a check to see if 4008 // *that* bit is set. 4009 APInt Op0KnownZeroInverted = ~Op0KnownZero; 4010 if (~Op1KnownZero == 0) { 4011 // If the LHS is an AND with the same constant, look through it. 4012 Value *LHS = nullptr; 4013 const APInt *LHSC; 4014 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 4015 *LHSC != Op0KnownZeroInverted) 4016 LHS = Op0; 4017 4018 Value *X; 4019 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 4020 APInt ValToCheck = Op0KnownZeroInverted; 4021 Type *XTy = X->getType(); 4022 if (ValToCheck.isPowerOf2()) { 4023 // ((1 << X) & 8) == 0 -> X != 3 4024 // ((1 << X) & 8) != 0 -> X == 3 4025 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4026 auto NewPred = ICmpInst::getInversePredicate(Pred); 4027 return new ICmpInst(NewPred, X, CmpC); 4028 } else if ((++ValToCheck).isPowerOf2()) { 4029 // ((1 << X) & 7) == 0 -> X >= 3 4030 // ((1 << X) & 7) != 0 -> X < 3 4031 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4032 auto NewPred = 4033 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 4034 return new ICmpInst(NewPred, X, CmpC); 4035 } 4036 } 4037 4038 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 4039 const APInt *CI; 4040 if (Op0KnownZeroInverted == 1 && 4041 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 4042 // ((8 >>u X) & 1) == 0 -> X != 3 4043 // ((8 >>u X) & 1) != 0 -> X == 3 4044 unsigned CmpVal = CI->countTrailingZeros(); 4045 auto NewPred = ICmpInst::getInversePredicate(Pred); 4046 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 4047 } 4048 } 4049 break; 4050 } 4051 case ICmpInst::ICMP_ULT: { 4052 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 4053 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4054 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 4055 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4056 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 4057 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4058 4059 const APInt *CmpC; 4060 if (match(Op1, m_APInt(CmpC))) { 4061 // A <u C -> A == C-1 if min(A)+1 == C 4062 if (Op1Max == Op0Min + 1) { 4063 Constant *CMinus1 = ConstantInt::get(Op0->getType(), *CmpC - 1); 4064 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, CMinus1); 4065 } 4066 // (x <u 2147483648) -> (x >s -1) -> true if sign bit clear 4067 if (CmpC->isMinSignedValue()) { 4068 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 4069 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 4070 } 4071 } 4072 break; 4073 } 4074 case ICmpInst::ICMP_UGT: { 4075 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 4076 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4077 4078 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 4079 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4080 4081 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 4082 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4083 4084 const APInt *CmpC; 4085 if (match(Op1, m_APInt(CmpC))) { 4086 // A >u C -> A == C+1 if max(a)-1 == C 4087 if (*CmpC == Op0Max - 1) 4088 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4089 ConstantInt::get(Op1->getType(), *CmpC + 1)); 4090 4091 // (x >u 2147483647) -> (x <s 0) -> true if sign bit set 4092 if (CmpC->isMaxSignedValue()) 4093 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, 4094 Constant::getNullValue(Op0->getType())); 4095 } 4096 break; 4097 } 4098 case ICmpInst::ICMP_SLT: 4099 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 4100 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4101 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 4102 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4103 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 4104 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4105 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) { 4106 if (Op1Max == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 4107 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4108 Builder->getInt(CI->getValue() - 1)); 4109 } 4110 break; 4111 case ICmpInst::ICMP_SGT: 4112 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 4113 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4114 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 4115 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4116 4117 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 4118 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4119 if (ConstantInt *CI = dyn_cast<ConstantInt>(Op1)) { 4120 if (Op1Min == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 4121 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4122 Builder->getInt(CI->getValue() + 1)); 4123 } 4124 break; 4125 case ICmpInst::ICMP_SGE: 4126 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 4127 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 4128 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4129 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 4130 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4131 break; 4132 case ICmpInst::ICMP_SLE: 4133 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 4134 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 4135 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4136 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 4137 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4138 break; 4139 case ICmpInst::ICMP_UGE: 4140 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 4141 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 4142 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4143 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 4144 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4145 break; 4146 case ICmpInst::ICMP_ULE: 4147 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 4148 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 4149 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4150 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 4151 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4152 break; 4153 } 4154 4155 // Turn a signed comparison into an unsigned one if both operands are known to 4156 // have the same sign. 4157 if (I.isSigned() && 4158 ((Op0KnownZero.isNegative() && Op1KnownZero.isNegative()) || 4159 (Op0KnownOne.isNegative() && Op1KnownOne.isNegative()))) 4160 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 4161 4162 return nullptr; 4163 } 4164 4165 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 4166 /// it into the appropriate icmp lt or icmp gt instruction. This transform 4167 /// allows them to be folded in visitICmpInst. 4168 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 4169 ICmpInst::Predicate Pred = I.getPredicate(); 4170 if (Pred != ICmpInst::ICMP_SLE && Pred != ICmpInst::ICMP_SGE && 4171 Pred != ICmpInst::ICMP_ULE && Pred != ICmpInst::ICMP_UGE) 4172 return nullptr; 4173 4174 Value *Op0 = I.getOperand(0); 4175 Value *Op1 = I.getOperand(1); 4176 auto *Op1C = dyn_cast<Constant>(Op1); 4177 if (!Op1C) 4178 return nullptr; 4179 4180 // Check if the constant operand can be safely incremented/decremented without 4181 // overflowing/underflowing. For scalars, SimplifyICmpInst has already handled 4182 // the edge cases for us, so we just assert on them. For vectors, we must 4183 // handle the edge cases. 4184 Type *Op1Type = Op1->getType(); 4185 bool IsSigned = I.isSigned(); 4186 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE); 4187 auto *CI = dyn_cast<ConstantInt>(Op1C); 4188 if (CI) { 4189 // A <= MAX -> TRUE ; A >= MIN -> TRUE 4190 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned)); 4191 } else if (Op1Type->isVectorTy()) { 4192 // TODO? If the edge cases for vectors were guaranteed to be handled as they 4193 // are for scalar, we could remove the min/max checks. However, to do that, 4194 // we would have to use insertelement/shufflevector to replace edge values. 4195 unsigned NumElts = Op1Type->getVectorNumElements(); 4196 for (unsigned i = 0; i != NumElts; ++i) { 4197 Constant *Elt = Op1C->getAggregateElement(i); 4198 if (!Elt) 4199 return nullptr; 4200 4201 if (isa<UndefValue>(Elt)) 4202 continue; 4203 4204 // Bail out if we can't determine if this constant is min/max or if we 4205 // know that this constant is min/max. 4206 auto *CI = dyn_cast<ConstantInt>(Elt); 4207 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned))) 4208 return nullptr; 4209 } 4210 } else { 4211 // ConstantExpr? 4212 return nullptr; 4213 } 4214 4215 // Increment or decrement the constant and set the new comparison predicate: 4216 // ULE -> ULT ; UGE -> UGT ; SLE -> SLT ; SGE -> SGT 4217 Constant *OneOrNegOne = ConstantInt::get(Op1Type, IsLE ? 1 : -1, true); 4218 CmpInst::Predicate NewPred = IsLE ? ICmpInst::ICMP_ULT: ICmpInst::ICMP_UGT; 4219 NewPred = IsSigned ? ICmpInst::getSignedPredicate(NewPred) : NewPred; 4220 return new ICmpInst(NewPred, Op0, ConstantExpr::getAdd(Op1C, OneOrNegOne)); 4221 } 4222 4223 Instruction *InstCombiner::visitICmpInst(ICmpInst &I) { 4224 bool Changed = false; 4225 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4226 unsigned Op0Cplxity = getComplexity(Op0); 4227 unsigned Op1Cplxity = getComplexity(Op1); 4228 4229 /// Orders the operands of the compare so that they are listed from most 4230 /// complex to least complex. This puts constants before unary operators, 4231 /// before binary operators. 4232 if (Op0Cplxity < Op1Cplxity || 4233 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 4234 I.swapOperands(); 4235 std::swap(Op0, Op1); 4236 Changed = true; 4237 } 4238 4239 if (Value *V = 4240 SimplifyICmpInst(I.getPredicate(), Op0, Op1, DL, &TLI, &DT, &AC, &I)) 4241 return replaceInstUsesWith(I, V); 4242 4243 // comparing -val or val with non-zero is the same as just comparing val 4244 // ie, abs(val) != 0 -> val != 0 4245 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 4246 Value *Cond, *SelectTrue, *SelectFalse; 4247 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 4248 m_Value(SelectFalse)))) { 4249 if (Value *V = dyn_castNegVal(SelectTrue)) { 4250 if (V == SelectFalse) 4251 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 4252 } 4253 else if (Value *V = dyn_castNegVal(SelectFalse)) { 4254 if (V == SelectTrue) 4255 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 4256 } 4257 } 4258 } 4259 4260 Type *Ty = Op0->getType(); 4261 4262 // icmp's with boolean values can always be turned into bitwise operations 4263 if (Ty->getScalarType()->isIntegerTy(1)) { 4264 switch (I.getPredicate()) { 4265 default: llvm_unreachable("Invalid icmp instruction!"); 4266 case ICmpInst::ICMP_EQ: { // icmp eq i1 A, B -> ~(A^B) 4267 Value *Xor = Builder->CreateXor(Op0, Op1, I.getName() + "tmp"); 4268 return BinaryOperator::CreateNot(Xor); 4269 } 4270 case ICmpInst::ICMP_NE: // icmp ne i1 A, B -> A^B 4271 return BinaryOperator::CreateXor(Op0, Op1); 4272 4273 case ICmpInst::ICMP_UGT: 4274 std::swap(Op0, Op1); // Change icmp ugt -> icmp ult 4275 LLVM_FALLTHROUGH; 4276 case ICmpInst::ICMP_ULT:{ // icmp ult i1 A, B -> ~A & B 4277 Value *Not = Builder->CreateNot(Op0, I.getName() + "tmp"); 4278 return BinaryOperator::CreateAnd(Not, Op1); 4279 } 4280 case ICmpInst::ICMP_SGT: 4281 std::swap(Op0, Op1); // Change icmp sgt -> icmp slt 4282 LLVM_FALLTHROUGH; 4283 case ICmpInst::ICMP_SLT: { // icmp slt i1 A, B -> A & ~B 4284 Value *Not = Builder->CreateNot(Op1, I.getName() + "tmp"); 4285 return BinaryOperator::CreateAnd(Not, Op0); 4286 } 4287 case ICmpInst::ICMP_UGE: 4288 std::swap(Op0, Op1); // Change icmp uge -> icmp ule 4289 LLVM_FALLTHROUGH; 4290 case ICmpInst::ICMP_ULE: { // icmp ule i1 A, B -> ~A | B 4291 Value *Not = Builder->CreateNot(Op0, I.getName() + "tmp"); 4292 return BinaryOperator::CreateOr(Not, Op1); 4293 } 4294 case ICmpInst::ICMP_SGE: 4295 std::swap(Op0, Op1); // Change icmp sge -> icmp sle 4296 LLVM_FALLTHROUGH; 4297 case ICmpInst::ICMP_SLE: { // icmp sle i1 A, B -> A | ~B 4298 Value *Not = Builder->CreateNot(Op1, I.getName() + "tmp"); 4299 return BinaryOperator::CreateOr(Not, Op0); 4300 } 4301 } 4302 } 4303 4304 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I)) 4305 return NewICmp; 4306 4307 if (Instruction *Res = foldICmpWithConstant(I)) 4308 return Res; 4309 4310 if (Instruction *Res = foldICmpUsingKnownBits(I)) 4311 return Res; 4312 4313 // Test if the ICmpInst instruction is used exclusively by a select as 4314 // part of a minimum or maximum operation. If so, refrain from doing 4315 // any other folding. This helps out other analyses which understand 4316 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 4317 // and CodeGen. And in this case, at least one of the comparison 4318 // operands has at least one user besides the compare (the select), 4319 // which would often largely negate the benefit of folding anyway. 4320 if (I.hasOneUse()) 4321 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin())) 4322 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) || 4323 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1)) 4324 return nullptr; 4325 4326 if (Instruction *Res = foldICmpInstWithConstant(I)) 4327 return Res; 4328 4329 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 4330 return Res; 4331 4332 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 4333 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 4334 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 4335 return NI; 4336 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 4337 if (Instruction *NI = foldGEPICmp(GEP, Op0, 4338 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 4339 return NI; 4340 4341 // Try to optimize equality comparisons against alloca-based pointers. 4342 if (Op0->getType()->isPointerTy() && I.isEquality()) { 4343 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 4344 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL))) 4345 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 4346 return New; 4347 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL))) 4348 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 4349 return New; 4350 } 4351 4352 // Test to see if the operands of the icmp are casted versions of other 4353 // values. If the ptr->ptr cast can be stripped off both arguments, we do so 4354 // now. 4355 if (BitCastInst *CI = dyn_cast<BitCastInst>(Op0)) { 4356 if (Op0->getType()->isPointerTy() && 4357 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 4358 // We keep moving the cast from the left operand over to the right 4359 // operand, where it can often be eliminated completely. 4360 Op0 = CI->getOperand(0); 4361 4362 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 4363 // so eliminate it as well. 4364 if (BitCastInst *CI2 = dyn_cast<BitCastInst>(Op1)) 4365 Op1 = CI2->getOperand(0); 4366 4367 // If Op1 is a constant, we can fold the cast into the constant. 4368 if (Op0->getType() != Op1->getType()) { 4369 if (Constant *Op1C = dyn_cast<Constant>(Op1)) { 4370 Op1 = ConstantExpr::getBitCast(Op1C, Op0->getType()); 4371 } else { 4372 // Otherwise, cast the RHS right before the icmp 4373 Op1 = Builder->CreateBitCast(Op1, Op0->getType()); 4374 } 4375 } 4376 return new ICmpInst(I.getPredicate(), Op0, Op1); 4377 } 4378 } 4379 4380 if (isa<CastInst>(Op0)) { 4381 // Handle the special case of: icmp (cast bool to X), <cst> 4382 // This comes up when you have code like 4383 // int X = A < B; 4384 // if (X) ... 4385 // For generality, we handle any zero-extension of any operand comparison 4386 // with a constant or another cast from the same type. 4387 if (isa<Constant>(Op1) || isa<CastInst>(Op1)) 4388 if (Instruction *R = foldICmpWithCastAndCast(I)) 4389 return R; 4390 } 4391 4392 if (Instruction *Res = foldICmpBinOp(I)) 4393 return Res; 4394 4395 if (Instruction *Res = foldICmpWithMinMax(I)) 4396 return Res; 4397 4398 { 4399 Value *A, *B; 4400 // Transform (A & ~B) == 0 --> (A & B) != 0 4401 // and (A & ~B) != 0 --> (A & B) == 0 4402 // if A is a power of 2. 4403 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 4404 match(Op1, m_Zero()) && 4405 isKnownToBeAPowerOfTwo(A, DL, false, 0, &AC, &I, &DT) && I.isEquality()) 4406 return new ICmpInst(I.getInversePredicate(), 4407 Builder->CreateAnd(A, B), 4408 Op1); 4409 4410 // ~x < ~y --> y < x 4411 // ~x < cst --> ~cst < x 4412 if (match(Op0, m_Not(m_Value(A)))) { 4413 if (match(Op1, m_Not(m_Value(B)))) 4414 return new ICmpInst(I.getPredicate(), B, A); 4415 if (ConstantInt *RHSC = dyn_cast<ConstantInt>(Op1)) 4416 return new ICmpInst(I.getPredicate(), ConstantExpr::getNot(RHSC), A); 4417 } 4418 4419 Instruction *AddI = nullptr; 4420 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 4421 m_Instruction(AddI))) && 4422 isa<IntegerType>(A->getType())) { 4423 Value *Result; 4424 Constant *Overflow; 4425 if (OptimizeOverflowCheck(OCF_UNSIGNED_ADD, A, B, *AddI, Result, 4426 Overflow)) { 4427 replaceInstUsesWith(*AddI, Result); 4428 return replaceInstUsesWith(I, Overflow); 4429 } 4430 } 4431 4432 // (zext a) * (zext b) --> llvm.umul.with.overflow. 4433 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 4434 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 4435 return R; 4436 } 4437 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 4438 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 4439 return R; 4440 } 4441 } 4442 4443 if (Instruction *Res = foldICmpEquality(I)) 4444 return Res; 4445 4446 // The 'cmpxchg' instruction returns an aggregate containing the old value and 4447 // an i1 which indicates whether or not we successfully did the swap. 4448 // 4449 // Replace comparisons between the old value and the expected value with the 4450 // indicator that 'cmpxchg' returns. 4451 // 4452 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 4453 // spuriously fail. In those cases, the old value may equal the expected 4454 // value but it is possible for the swap to not occur. 4455 if (I.getPredicate() == ICmpInst::ICMP_EQ) 4456 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 4457 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 4458 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 4459 !ACXI->isWeak()) 4460 return ExtractValueInst::Create(ACXI, 1); 4461 4462 { 4463 Value *X; ConstantInt *Cst; 4464 // icmp X+Cst, X 4465 if (match(Op0, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op1 == X) 4466 return foldICmpAddOpConst(I, X, Cst, I.getPredicate()); 4467 4468 // icmp X, X+Cst 4469 if (match(Op1, m_Add(m_Value(X), m_ConstantInt(Cst))) && Op0 == X) 4470 return foldICmpAddOpConst(I, X, Cst, I.getSwappedPredicate()); 4471 } 4472 return Changed ? &I : nullptr; 4473 } 4474 4475 /// Fold fcmp ([us]itofp x, cst) if possible. 4476 Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI, 4477 Constant *RHSC) { 4478 if (!isa<ConstantFP>(RHSC)) return nullptr; 4479 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 4480 4481 // Get the width of the mantissa. We don't want to hack on conversions that 4482 // might lose information from the integer, e.g. "i64 -> float" 4483 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 4484 if (MantissaWidth == -1) return nullptr; // Unknown. 4485 4486 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 4487 4488 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 4489 4490 if (I.isEquality()) { 4491 FCmpInst::Predicate P = I.getPredicate(); 4492 bool IsExact = false; 4493 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 4494 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 4495 4496 // If the floating point constant isn't an integer value, we know if we will 4497 // ever compare equal / not equal to it. 4498 if (!IsExact) { 4499 // TODO: Can never be -0.0 and other non-representable values 4500 APFloat RHSRoundInt(RHS); 4501 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 4502 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) { 4503 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 4504 return replaceInstUsesWith(I, Builder->getFalse()); 4505 4506 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 4507 return replaceInstUsesWith(I, Builder->getTrue()); 4508 } 4509 } 4510 4511 // TODO: If the constant is exactly representable, is it always OK to do 4512 // equality compares as integer? 4513 } 4514 4515 // Check to see that the input is converted from an integer type that is small 4516 // enough that preserves all bits. TODO: check here for "known" sign bits. 4517 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 4518 unsigned InputSize = IntTy->getScalarSizeInBits(); 4519 4520 // Following test does NOT adjust InputSize downwards for signed inputs, 4521 // because the most negative value still requires all the mantissa bits 4522 // to distinguish it from one less than that value. 4523 if ((int)InputSize > MantissaWidth) { 4524 // Conversion would lose accuracy. Check if loss can impact comparison. 4525 int Exp = ilogb(RHS); 4526 if (Exp == APFloat::IEK_Inf) { 4527 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 4528 if (MaxExponent < (int)InputSize - !LHSUnsigned) 4529 // Conversion could create infinity. 4530 return nullptr; 4531 } else { 4532 // Note that if RHS is zero or NaN, then Exp is negative 4533 // and first condition is trivially false. 4534 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 4535 // Conversion could affect comparison. 4536 return nullptr; 4537 } 4538 } 4539 4540 // Otherwise, we can potentially simplify the comparison. We know that it 4541 // will always come through as an integer value and we know the constant is 4542 // not a NAN (it would have been previously simplified). 4543 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 4544 4545 ICmpInst::Predicate Pred; 4546 switch (I.getPredicate()) { 4547 default: llvm_unreachable("Unexpected predicate!"); 4548 case FCmpInst::FCMP_UEQ: 4549 case FCmpInst::FCMP_OEQ: 4550 Pred = ICmpInst::ICMP_EQ; 4551 break; 4552 case FCmpInst::FCMP_UGT: 4553 case FCmpInst::FCMP_OGT: 4554 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 4555 break; 4556 case FCmpInst::FCMP_UGE: 4557 case FCmpInst::FCMP_OGE: 4558 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 4559 break; 4560 case FCmpInst::FCMP_ULT: 4561 case FCmpInst::FCMP_OLT: 4562 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 4563 break; 4564 case FCmpInst::FCMP_ULE: 4565 case FCmpInst::FCMP_OLE: 4566 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 4567 break; 4568 case FCmpInst::FCMP_UNE: 4569 case FCmpInst::FCMP_ONE: 4570 Pred = ICmpInst::ICMP_NE; 4571 break; 4572 case FCmpInst::FCMP_ORD: 4573 return replaceInstUsesWith(I, Builder->getTrue()); 4574 case FCmpInst::FCMP_UNO: 4575 return replaceInstUsesWith(I, Builder->getFalse()); 4576 } 4577 4578 // Now we know that the APFloat is a normal number, zero or inf. 4579 4580 // See if the FP constant is too large for the integer. For example, 4581 // comparing an i8 to 300.0. 4582 unsigned IntWidth = IntTy->getScalarSizeInBits(); 4583 4584 if (!LHSUnsigned) { 4585 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 4586 // and large values. 4587 APFloat SMax(RHS.getSemantics()); 4588 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 4589 APFloat::rmNearestTiesToEven); 4590 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0 4591 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 4592 Pred == ICmpInst::ICMP_SLE) 4593 return replaceInstUsesWith(I, Builder->getTrue()); 4594 return replaceInstUsesWith(I, Builder->getFalse()); 4595 } 4596 } else { 4597 // If the RHS value is > UnsignedMax, fold the comparison. This handles 4598 // +INF and large values. 4599 APFloat UMax(RHS.getSemantics()); 4600 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 4601 APFloat::rmNearestTiesToEven); 4602 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0 4603 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 4604 Pred == ICmpInst::ICMP_ULE) 4605 return replaceInstUsesWith(I, Builder->getTrue()); 4606 return replaceInstUsesWith(I, Builder->getFalse()); 4607 } 4608 } 4609 4610 if (!LHSUnsigned) { 4611 // See if the RHS value is < SignedMin. 4612 APFloat SMin(RHS.getSemantics()); 4613 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 4614 APFloat::rmNearestTiesToEven); 4615 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0 4616 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 4617 Pred == ICmpInst::ICMP_SGE) 4618 return replaceInstUsesWith(I, Builder->getTrue()); 4619 return replaceInstUsesWith(I, Builder->getFalse()); 4620 } 4621 } else { 4622 // See if the RHS value is < UnsignedMin. 4623 APFloat SMin(RHS.getSemantics()); 4624 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true, 4625 APFloat::rmNearestTiesToEven); 4626 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0 4627 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 4628 Pred == ICmpInst::ICMP_UGE) 4629 return replaceInstUsesWith(I, Builder->getTrue()); 4630 return replaceInstUsesWith(I, Builder->getFalse()); 4631 } 4632 } 4633 4634 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 4635 // [0, UMAX], but it may still be fractional. See if it is fractional by 4636 // casting the FP value to the integer value and back, checking for equality. 4637 // Don't do this for zero, because -0.0 is not fractional. 4638 Constant *RHSInt = LHSUnsigned 4639 ? ConstantExpr::getFPToUI(RHSC, IntTy) 4640 : ConstantExpr::getFPToSI(RHSC, IntTy); 4641 if (!RHS.isZero()) { 4642 bool Equal = LHSUnsigned 4643 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 4644 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 4645 if (!Equal) { 4646 // If we had a comparison against a fractional value, we have to adjust 4647 // the compare predicate and sometimes the value. RHSC is rounded towards 4648 // zero at this point. 4649 switch (Pred) { 4650 default: llvm_unreachable("Unexpected integer comparison!"); 4651 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 4652 return replaceInstUsesWith(I, Builder->getTrue()); 4653 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 4654 return replaceInstUsesWith(I, Builder->getFalse()); 4655 case ICmpInst::ICMP_ULE: 4656 // (float)int <= 4.4 --> int <= 4 4657 // (float)int <= -4.4 --> false 4658 if (RHS.isNegative()) 4659 return replaceInstUsesWith(I, Builder->getFalse()); 4660 break; 4661 case ICmpInst::ICMP_SLE: 4662 // (float)int <= 4.4 --> int <= 4 4663 // (float)int <= -4.4 --> int < -4 4664 if (RHS.isNegative()) 4665 Pred = ICmpInst::ICMP_SLT; 4666 break; 4667 case ICmpInst::ICMP_ULT: 4668 // (float)int < -4.4 --> false 4669 // (float)int < 4.4 --> int <= 4 4670 if (RHS.isNegative()) 4671 return replaceInstUsesWith(I, Builder->getFalse()); 4672 Pred = ICmpInst::ICMP_ULE; 4673 break; 4674 case ICmpInst::ICMP_SLT: 4675 // (float)int < -4.4 --> int < -4 4676 // (float)int < 4.4 --> int <= 4 4677 if (!RHS.isNegative()) 4678 Pred = ICmpInst::ICMP_SLE; 4679 break; 4680 case ICmpInst::ICMP_UGT: 4681 // (float)int > 4.4 --> int > 4 4682 // (float)int > -4.4 --> true 4683 if (RHS.isNegative()) 4684 return replaceInstUsesWith(I, Builder->getTrue()); 4685 break; 4686 case ICmpInst::ICMP_SGT: 4687 // (float)int > 4.4 --> int > 4 4688 // (float)int > -4.4 --> int >= -4 4689 if (RHS.isNegative()) 4690 Pred = ICmpInst::ICMP_SGE; 4691 break; 4692 case ICmpInst::ICMP_UGE: 4693 // (float)int >= -4.4 --> true 4694 // (float)int >= 4.4 --> int > 4 4695 if (RHS.isNegative()) 4696 return replaceInstUsesWith(I, Builder->getTrue()); 4697 Pred = ICmpInst::ICMP_UGT; 4698 break; 4699 case ICmpInst::ICMP_SGE: 4700 // (float)int >= -4.4 --> int >= -4 4701 // (float)int >= 4.4 --> int > 4 4702 if (!RHS.isNegative()) 4703 Pred = ICmpInst::ICMP_SGT; 4704 break; 4705 } 4706 } 4707 } 4708 4709 // Lower this FP comparison into an appropriate integer version of the 4710 // comparison. 4711 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 4712 } 4713 4714 Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) { 4715 bool Changed = false; 4716 4717 /// Orders the operands of the compare so that they are listed from most 4718 /// complex to least complex. This puts constants before unary operators, 4719 /// before binary operators. 4720 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 4721 I.swapOperands(); 4722 Changed = true; 4723 } 4724 4725 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4726 4727 if (Value *V = SimplifyFCmpInst(I.getPredicate(), Op0, Op1, 4728 I.getFastMathFlags(), DL, &TLI, &DT, &AC, &I)) 4729 return replaceInstUsesWith(I, V); 4730 4731 // Simplify 'fcmp pred X, X' 4732 if (Op0 == Op1) { 4733 switch (I.getPredicate()) { 4734 default: llvm_unreachable("Unknown predicate!"); 4735 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 4736 case FCmpInst::FCMP_ULT: // True if unordered or less than 4737 case FCmpInst::FCMP_UGT: // True if unordered or greater than 4738 case FCmpInst::FCMP_UNE: // True if unordered or not equal 4739 // Canonicalize these to be 'fcmp uno %X, 0.0'. 4740 I.setPredicate(FCmpInst::FCMP_UNO); 4741 I.setOperand(1, Constant::getNullValue(Op0->getType())); 4742 return &I; 4743 4744 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 4745 case FCmpInst::FCMP_OEQ: // True if ordered and equal 4746 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 4747 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 4748 // Canonicalize these to be 'fcmp ord %X, 0.0'. 4749 I.setPredicate(FCmpInst::FCMP_ORD); 4750 I.setOperand(1, Constant::getNullValue(Op0->getType())); 4751 return &I; 4752 } 4753 } 4754 4755 // Test if the FCmpInst instruction is used exclusively by a select as 4756 // part of a minimum or maximum operation. If so, refrain from doing 4757 // any other folding. This helps out other analyses which understand 4758 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 4759 // and CodeGen. And in this case, at least one of the comparison 4760 // operands has at least one user besides the compare (the select), 4761 // which would often largely negate the benefit of folding anyway. 4762 if (I.hasOneUse()) 4763 if (SelectInst *SI = dyn_cast<SelectInst>(*I.user_begin())) 4764 if ((SI->getOperand(1) == Op0 && SI->getOperand(2) == Op1) || 4765 (SI->getOperand(2) == Op0 && SI->getOperand(1) == Op1)) 4766 return nullptr; 4767 4768 // Handle fcmp with constant RHS 4769 if (Constant *RHSC = dyn_cast<Constant>(Op1)) { 4770 if (Instruction *LHSI = dyn_cast<Instruction>(Op0)) 4771 switch (LHSI->getOpcode()) { 4772 case Instruction::FPExt: { 4773 // fcmp (fpext x), C -> fcmp x, (fptrunc C) if fptrunc is lossless 4774 FPExtInst *LHSExt = cast<FPExtInst>(LHSI); 4775 ConstantFP *RHSF = dyn_cast<ConstantFP>(RHSC); 4776 if (!RHSF) 4777 break; 4778 4779 const fltSemantics *Sem; 4780 // FIXME: This shouldn't be here. 4781 if (LHSExt->getSrcTy()->isHalfTy()) 4782 Sem = &APFloat::IEEEhalf(); 4783 else if (LHSExt->getSrcTy()->isFloatTy()) 4784 Sem = &APFloat::IEEEsingle(); 4785 else if (LHSExt->getSrcTy()->isDoubleTy()) 4786 Sem = &APFloat::IEEEdouble(); 4787 else if (LHSExt->getSrcTy()->isFP128Ty()) 4788 Sem = &APFloat::IEEEquad(); 4789 else if (LHSExt->getSrcTy()->isX86_FP80Ty()) 4790 Sem = &APFloat::x87DoubleExtended(); 4791 else if (LHSExt->getSrcTy()->isPPC_FP128Ty()) 4792 Sem = &APFloat::PPCDoubleDouble(); 4793 else 4794 break; 4795 4796 bool Lossy; 4797 APFloat F = RHSF->getValueAPF(); 4798 F.convert(*Sem, APFloat::rmNearestTiesToEven, &Lossy); 4799 4800 // Avoid lossy conversions and denormals. Zero is a special case 4801 // that's OK to convert. 4802 APFloat Fabs = F; 4803 Fabs.clearSign(); 4804 if (!Lossy && 4805 ((Fabs.compare(APFloat::getSmallestNormalized(*Sem)) != 4806 APFloat::cmpLessThan) || Fabs.isZero())) 4807 4808 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0), 4809 ConstantFP::get(RHSC->getContext(), F)); 4810 break; 4811 } 4812 case Instruction::PHI: 4813 // Only fold fcmp into the PHI if the phi and fcmp are in the same 4814 // block. If in the same block, we're encouraging jump threading. If 4815 // not, we are just pessimizing the code by making an i1 phi. 4816 if (LHSI->getParent() == I.getParent()) 4817 if (Instruction *NV = FoldOpIntoPhi(I)) 4818 return NV; 4819 break; 4820 case Instruction::SIToFP: 4821 case Instruction::UIToFP: 4822 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 4823 return NV; 4824 break; 4825 case Instruction::FSub: { 4826 // fcmp pred (fneg x), C -> fcmp swap(pred) x, -C 4827 Value *Op; 4828 if (match(LHSI, m_FNeg(m_Value(Op)))) 4829 return new FCmpInst(I.getSwappedPredicate(), Op, 4830 ConstantExpr::getFNeg(RHSC)); 4831 break; 4832 } 4833 case Instruction::Load: 4834 if (GetElementPtrInst *GEP = 4835 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 4836 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 4837 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 4838 !cast<LoadInst>(LHSI)->isVolatile()) 4839 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 4840 return Res; 4841 } 4842 break; 4843 case Instruction::Call: { 4844 if (!RHSC->isNullValue()) 4845 break; 4846 4847 CallInst *CI = cast<CallInst>(LHSI); 4848 Intrinsic::ID IID = getIntrinsicForCallSite(CI, &TLI); 4849 if (IID != Intrinsic::fabs) 4850 break; 4851 4852 // Various optimization for fabs compared with zero. 4853 switch (I.getPredicate()) { 4854 default: 4855 break; 4856 // fabs(x) < 0 --> false 4857 case FCmpInst::FCMP_OLT: 4858 llvm_unreachable("handled by SimplifyFCmpInst"); 4859 // fabs(x) > 0 --> x != 0 4860 case FCmpInst::FCMP_OGT: 4861 return new FCmpInst(FCmpInst::FCMP_ONE, CI->getArgOperand(0), RHSC); 4862 // fabs(x) <= 0 --> x == 0 4863 case FCmpInst::FCMP_OLE: 4864 return new FCmpInst(FCmpInst::FCMP_OEQ, CI->getArgOperand(0), RHSC); 4865 // fabs(x) >= 0 --> !isnan(x) 4866 case FCmpInst::FCMP_OGE: 4867 return new FCmpInst(FCmpInst::FCMP_ORD, CI->getArgOperand(0), RHSC); 4868 // fabs(x) == 0 --> x == 0 4869 // fabs(x) != 0 --> x != 0 4870 case FCmpInst::FCMP_OEQ: 4871 case FCmpInst::FCMP_UEQ: 4872 case FCmpInst::FCMP_ONE: 4873 case FCmpInst::FCMP_UNE: 4874 return new FCmpInst(I.getPredicate(), CI->getArgOperand(0), RHSC); 4875 } 4876 } 4877 } 4878 } 4879 4880 // fcmp pred (fneg x), (fneg y) -> fcmp swap(pred) x, y 4881 Value *X, *Y; 4882 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 4883 return new FCmpInst(I.getSwappedPredicate(), X, Y); 4884 4885 // fcmp (fpext x), (fpext y) -> fcmp x, y 4886 if (FPExtInst *LHSExt = dyn_cast<FPExtInst>(Op0)) 4887 if (FPExtInst *RHSExt = dyn_cast<FPExtInst>(Op1)) 4888 if (LHSExt->getSrcTy() == RHSExt->getSrcTy()) 4889 return new FCmpInst(I.getPredicate(), LHSExt->getOperand(0), 4890 RHSExt->getOperand(0)); 4891 4892 return Changed ? &I : nullptr; 4893 } 4894