1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/ConstantFolding.h" 18 #include "llvm/Analysis/InstructionSimplify.h" 19 #include "llvm/Analysis/TargetLibraryInfo.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/Debug.h" 26 #include "llvm/Support/KnownBits.h" 27 28 using namespace llvm; 29 using namespace PatternMatch; 30 31 #define DEBUG_TYPE "instcombine" 32 33 // How many times is a select replaced by one of its operands? 34 STATISTIC(NumSel, "Number of select opts"); 35 36 37 /// Compute Result = In1+In2, returning true if the result overflowed for this 38 /// type. 39 static bool addWithOverflow(APInt &Result, const APInt &In1, 40 const APInt &In2, bool IsSigned = false) { 41 bool Overflow; 42 if (IsSigned) 43 Result = In1.sadd_ov(In2, Overflow); 44 else 45 Result = In1.uadd_ov(In2, Overflow); 46 47 return Overflow; 48 } 49 50 /// Compute Result = In1-In2, returning true if the result overflowed for this 51 /// type. 52 static bool subWithOverflow(APInt &Result, const APInt &In1, 53 const APInt &In2, bool IsSigned = false) { 54 bool Overflow; 55 if (IsSigned) 56 Result = In1.ssub_ov(In2, Overflow); 57 else 58 Result = In1.usub_ov(In2, Overflow); 59 60 return Overflow; 61 } 62 63 /// Given an icmp instruction, return true if any use of this comparison is a 64 /// branch on sign bit comparison. 65 static bool hasBranchUse(ICmpInst &I) { 66 for (auto *U : I.users()) 67 if (isa<BranchInst>(U)) 68 return true; 69 return false; 70 } 71 72 /// Given an exploded icmp instruction, return true if the comparison only 73 /// checks the sign bit. If it only checks the sign bit, set TrueIfSigned if the 74 /// result of the comparison is true when the input value is signed. 75 static bool isSignBitCheck(ICmpInst::Predicate Pred, const APInt &RHS, 76 bool &TrueIfSigned) { 77 switch (Pred) { 78 case ICmpInst::ICMP_SLT: // True if LHS s< 0 79 TrueIfSigned = true; 80 return RHS.isNullValue(); 81 case ICmpInst::ICMP_SLE: // True if LHS s<= RHS and RHS == -1 82 TrueIfSigned = true; 83 return RHS.isAllOnesValue(); 84 case ICmpInst::ICMP_SGT: // True if LHS s> -1 85 TrueIfSigned = false; 86 return RHS.isAllOnesValue(); 87 case ICmpInst::ICMP_UGT: 88 // True if LHS u> RHS and RHS == high-bit-mask - 1 89 TrueIfSigned = true; 90 return RHS.isMaxSignedValue(); 91 case ICmpInst::ICMP_UGE: 92 // True if LHS u>= RHS and RHS == high-bit-mask (2^7, 2^15, 2^31, etc) 93 TrueIfSigned = true; 94 return RHS.isSignMask(); 95 default: 96 return false; 97 } 98 } 99 100 /// Returns true if the exploded icmp can be expressed as a signed comparison 101 /// to zero and updates the predicate accordingly. 102 /// The signedness of the comparison is preserved. 103 /// TODO: Refactor with decomposeBitTestICmp()? 104 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 105 if (!ICmpInst::isSigned(Pred)) 106 return false; 107 108 if (C.isNullValue()) 109 return ICmpInst::isRelational(Pred); 110 111 if (C.isOneValue()) { 112 if (Pred == ICmpInst::ICMP_SLT) { 113 Pred = ICmpInst::ICMP_SLE; 114 return true; 115 } 116 } else if (C.isAllOnesValue()) { 117 if (Pred == ICmpInst::ICMP_SGT) { 118 Pred = ICmpInst::ICMP_SGE; 119 return true; 120 } 121 } 122 123 return false; 124 } 125 126 /// Given a signed integer type and a set of known zero and one bits, compute 127 /// the maximum and minimum values that could have the specified known zero and 128 /// known one bits, returning them in Min/Max. 129 /// TODO: Move to method on KnownBits struct? 130 static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known, 131 APInt &Min, APInt &Max) { 132 assert(Known.getBitWidth() == Min.getBitWidth() && 133 Known.getBitWidth() == Max.getBitWidth() && 134 "KnownZero, KnownOne and Min, Max must have equal bitwidth."); 135 APInt UnknownBits = ~(Known.Zero|Known.One); 136 137 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign 138 // bit if it is unknown. 139 Min = Known.One; 140 Max = Known.One|UnknownBits; 141 142 if (UnknownBits.isNegative()) { // Sign bit is unknown 143 Min.setSignBit(); 144 Max.clearSignBit(); 145 } 146 } 147 148 /// Given an unsigned integer type and a set of known zero and one bits, compute 149 /// the maximum and minimum values that could have the specified known zero and 150 /// known one bits, returning them in Min/Max. 151 /// TODO: Move to method on KnownBits struct? 152 static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known, 153 APInt &Min, APInt &Max) { 154 assert(Known.getBitWidth() == Min.getBitWidth() && 155 Known.getBitWidth() == Max.getBitWidth() && 156 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth."); 157 APInt UnknownBits = ~(Known.Zero|Known.One); 158 159 // The minimum value is when the unknown bits are all zeros. 160 Min = Known.One; 161 // The maximum value is when the unknown bits are all ones. 162 Max = Known.One|UnknownBits; 163 } 164 165 /// This is called when we see this pattern: 166 /// cmp pred (load (gep GV, ...)), cmpcst 167 /// where GV is a global variable with a constant initializer. Try to simplify 168 /// this into some simple computation that does not need the load. For example 169 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 170 /// 171 /// If AndCst is non-null, then the loaded value is masked with that constant 172 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 173 Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 174 GlobalVariable *GV, 175 CmpInst &ICI, 176 ConstantInt *AndCst) { 177 Constant *Init = GV->getInitializer(); 178 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 179 return nullptr; 180 181 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 182 // Don't blow up on huge arrays. 183 if (ArrayElementCount > MaxArraySizeForCombine) 184 return nullptr; 185 186 // There are many forms of this optimization we can handle, for now, just do 187 // the simple index into a single-dimensional array. 188 // 189 // Require: GEP GV, 0, i {{, constant indices}} 190 if (GEP->getNumOperands() < 3 || 191 !isa<ConstantInt>(GEP->getOperand(1)) || 192 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 193 isa<Constant>(GEP->getOperand(2))) 194 return nullptr; 195 196 // Check that indices after the variable are constants and in-range for the 197 // type they index. Collect the indices. This is typically for arrays of 198 // structs. 199 SmallVector<unsigned, 4> LaterIndices; 200 201 Type *EltTy = Init->getType()->getArrayElementType(); 202 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 203 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 204 if (!Idx) return nullptr; // Variable index. 205 206 uint64_t IdxVal = Idx->getZExtValue(); 207 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 208 209 if (StructType *STy = dyn_cast<StructType>(EltTy)) 210 EltTy = STy->getElementType(IdxVal); 211 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 212 if (IdxVal >= ATy->getNumElements()) return nullptr; 213 EltTy = ATy->getElementType(); 214 } else { 215 return nullptr; // Unknown type. 216 } 217 218 LaterIndices.push_back(IdxVal); 219 } 220 221 enum { Overdefined = -3, Undefined = -2 }; 222 223 // Variables for our state machines. 224 225 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 226 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 227 // and 87 is the second (and last) index. FirstTrueElement is -2 when 228 // undefined, otherwise set to the first true element. SecondTrueElement is 229 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 230 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 231 232 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 233 // form "i != 47 & i != 87". Same state transitions as for true elements. 234 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 235 236 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 237 /// define a state machine that triggers for ranges of values that the index 238 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 239 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 240 /// index in the range (inclusive). We use -2 for undefined here because we 241 /// use relative comparisons and don't want 0-1 to match -1. 242 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 243 244 // MagicBitvector - This is a magic bitvector where we set a bit if the 245 // comparison is true for element 'i'. If there are 64 elements or less in 246 // the array, this will fully represent all the comparison results. 247 uint64_t MagicBitvector = 0; 248 249 // Scan the array and see if one of our patterns matches. 250 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 251 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 252 Constant *Elt = Init->getAggregateElement(i); 253 if (!Elt) return nullptr; 254 255 // If this is indexing an array of structures, get the structure element. 256 if (!LaterIndices.empty()) 257 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 258 259 // If the element is masked, handle it. 260 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 261 262 // Find out if the comparison would be true or false for the i'th element. 263 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 264 CompareRHS, DL, &TLI); 265 // If the result is undef for this element, ignore it. 266 if (isa<UndefValue>(C)) { 267 // Extend range state machines to cover this element in case there is an 268 // undef in the middle of the range. 269 if (TrueRangeEnd == (int)i-1) 270 TrueRangeEnd = i; 271 if (FalseRangeEnd == (int)i-1) 272 FalseRangeEnd = i; 273 continue; 274 } 275 276 // If we can't compute the result for any of the elements, we have to give 277 // up evaluating the entire conditional. 278 if (!isa<ConstantInt>(C)) return nullptr; 279 280 // Otherwise, we know if the comparison is true or false for this element, 281 // update our state machines. 282 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 283 284 // State machine for single/double/range index comparison. 285 if (IsTrueForElt) { 286 // Update the TrueElement state machine. 287 if (FirstTrueElement == Undefined) 288 FirstTrueElement = TrueRangeEnd = i; // First true element. 289 else { 290 // Update double-compare state machine. 291 if (SecondTrueElement == Undefined) 292 SecondTrueElement = i; 293 else 294 SecondTrueElement = Overdefined; 295 296 // Update range state machine. 297 if (TrueRangeEnd == (int)i-1) 298 TrueRangeEnd = i; 299 else 300 TrueRangeEnd = Overdefined; 301 } 302 } else { 303 // Update the FalseElement state machine. 304 if (FirstFalseElement == Undefined) 305 FirstFalseElement = FalseRangeEnd = i; // First false element. 306 else { 307 // Update double-compare state machine. 308 if (SecondFalseElement == Undefined) 309 SecondFalseElement = i; 310 else 311 SecondFalseElement = Overdefined; 312 313 // Update range state machine. 314 if (FalseRangeEnd == (int)i-1) 315 FalseRangeEnd = i; 316 else 317 FalseRangeEnd = Overdefined; 318 } 319 } 320 321 // If this element is in range, update our magic bitvector. 322 if (i < 64 && IsTrueForElt) 323 MagicBitvector |= 1ULL << i; 324 325 // If all of our states become overdefined, bail out early. Since the 326 // predicate is expensive, only check it every 8 elements. This is only 327 // really useful for really huge arrays. 328 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 329 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 330 FalseRangeEnd == Overdefined) 331 return nullptr; 332 } 333 334 // Now that we've scanned the entire array, emit our new comparison(s). We 335 // order the state machines in complexity of the generated code. 336 Value *Idx = GEP->getOperand(2); 337 338 // If the index is larger than the pointer size of the target, truncate the 339 // index down like the GEP would do implicitly. We don't have to do this for 340 // an inbounds GEP because the index can't be out of range. 341 if (!GEP->isInBounds()) { 342 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 343 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 344 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize) 345 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 346 } 347 348 // If the comparison is only true for one or two elements, emit direct 349 // comparisons. 350 if (SecondTrueElement != Overdefined) { 351 // None true -> false. 352 if (FirstTrueElement == Undefined) 353 return replaceInstUsesWith(ICI, Builder.getFalse()); 354 355 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 356 357 // True for one element -> 'i == 47'. 358 if (SecondTrueElement == Undefined) 359 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 360 361 // True for two elements -> 'i == 47 | i == 72'. 362 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 363 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 364 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 365 return BinaryOperator::CreateOr(C1, C2); 366 } 367 368 // If the comparison is only false for one or two elements, emit direct 369 // comparisons. 370 if (SecondFalseElement != Overdefined) { 371 // None false -> true. 372 if (FirstFalseElement == Undefined) 373 return replaceInstUsesWith(ICI, Builder.getTrue()); 374 375 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 376 377 // False for one element -> 'i != 47'. 378 if (SecondFalseElement == Undefined) 379 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 380 381 // False for two elements -> 'i != 47 & i != 72'. 382 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 383 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 384 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 385 return BinaryOperator::CreateAnd(C1, C2); 386 } 387 388 // If the comparison can be replaced with a range comparison for the elements 389 // where it is true, emit the range check. 390 if (TrueRangeEnd != Overdefined) { 391 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 392 393 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 394 if (FirstTrueElement) { 395 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 396 Idx = Builder.CreateAdd(Idx, Offs); 397 } 398 399 Value *End = ConstantInt::get(Idx->getType(), 400 TrueRangeEnd-FirstTrueElement+1); 401 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 402 } 403 404 // False range check. 405 if (FalseRangeEnd != Overdefined) { 406 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 407 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 408 if (FirstFalseElement) { 409 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 410 Idx = Builder.CreateAdd(Idx, Offs); 411 } 412 413 Value *End = ConstantInt::get(Idx->getType(), 414 FalseRangeEnd-FirstFalseElement); 415 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 416 } 417 418 // If a magic bitvector captures the entire comparison state 419 // of this load, replace it with computation that does: 420 // ((magic_cst >> i) & 1) != 0 421 { 422 Type *Ty = nullptr; 423 424 // Look for an appropriate type: 425 // - The type of Idx if the magic fits 426 // - The smallest fitting legal type 427 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 428 Ty = Idx->getType(); 429 else 430 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 431 432 if (Ty) { 433 Value *V = Builder.CreateIntCast(Idx, Ty, false); 434 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 435 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 436 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 437 } 438 } 439 440 return nullptr; 441 } 442 443 /// Return a value that can be used to compare the *offset* implied by a GEP to 444 /// zero. For example, if we have &A[i], we want to return 'i' for 445 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 446 /// are involved. The above expression would also be legal to codegen as 447 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 448 /// This latter form is less amenable to optimization though, and we are allowed 449 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 450 /// 451 /// If we can't emit an optimized form for this expression, this returns null. 452 /// 453 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC, 454 const DataLayout &DL) { 455 gep_type_iterator GTI = gep_type_begin(GEP); 456 457 // Check to see if this gep only has a single variable index. If so, and if 458 // any constant indices are a multiple of its scale, then we can compute this 459 // in terms of the scale of the variable index. For example, if the GEP 460 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 461 // because the expression will cross zero at the same point. 462 unsigned i, e = GEP->getNumOperands(); 463 int64_t Offset = 0; 464 for (i = 1; i != e; ++i, ++GTI) { 465 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 466 // Compute the aggregate offset of constant indices. 467 if (CI->isZero()) continue; 468 469 // Handle a struct index, which adds its field offset to the pointer. 470 if (StructType *STy = GTI.getStructTypeOrNull()) { 471 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 472 } else { 473 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 474 Offset += Size*CI->getSExtValue(); 475 } 476 } else { 477 // Found our variable index. 478 break; 479 } 480 } 481 482 // If there are no variable indices, we must have a constant offset, just 483 // evaluate it the general way. 484 if (i == e) return nullptr; 485 486 Value *VariableIdx = GEP->getOperand(i); 487 // Determine the scale factor of the variable element. For example, this is 488 // 4 if the variable index is into an array of i32. 489 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 490 491 // Verify that there are no other variable indices. If so, emit the hard way. 492 for (++i, ++GTI; i != e; ++i, ++GTI) { 493 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 494 if (!CI) return nullptr; 495 496 // Compute the aggregate offset of constant indices. 497 if (CI->isZero()) continue; 498 499 // Handle a struct index, which adds its field offset to the pointer. 500 if (StructType *STy = GTI.getStructTypeOrNull()) { 501 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 502 } else { 503 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 504 Offset += Size*CI->getSExtValue(); 505 } 506 } 507 508 // Okay, we know we have a single variable index, which must be a 509 // pointer/array/vector index. If there is no offset, life is simple, return 510 // the index. 511 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 512 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 513 if (Offset == 0) { 514 // Cast to intptrty in case a truncation occurs. If an extension is needed, 515 // we don't need to bother extending: the extension won't affect where the 516 // computation crosses zero. 517 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) { 518 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 519 } 520 return VariableIdx; 521 } 522 523 // Otherwise, there is an index. The computation we will do will be modulo 524 // the pointer size. 525 Offset = SignExtend64(Offset, IntPtrWidth); 526 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 527 528 // To do this transformation, any constant index must be a multiple of the 529 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 530 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 531 // multiple of the variable scale. 532 int64_t NewOffs = Offset / (int64_t)VariableScale; 533 if (Offset != NewOffs*(int64_t)VariableScale) 534 return nullptr; 535 536 // Okay, we can do this evaluation. Start by converting the index to intptr. 537 if (VariableIdx->getType() != IntPtrTy) 538 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 539 true /*Signed*/); 540 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 541 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 542 } 543 544 /// Returns true if we can rewrite Start as a GEP with pointer Base 545 /// and some integer offset. The nodes that need to be re-written 546 /// for this transformation will be added to Explored. 547 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 548 const DataLayout &DL, 549 SetVector<Value *> &Explored) { 550 SmallVector<Value *, 16> WorkList(1, Start); 551 Explored.insert(Base); 552 553 // The following traversal gives us an order which can be used 554 // when doing the final transformation. Since in the final 555 // transformation we create the PHI replacement instructions first, 556 // we don't have to get them in any particular order. 557 // 558 // However, for other instructions we will have to traverse the 559 // operands of an instruction first, which means that we have to 560 // do a post-order traversal. 561 while (!WorkList.empty()) { 562 SetVector<PHINode *> PHIs; 563 564 while (!WorkList.empty()) { 565 if (Explored.size() >= 100) 566 return false; 567 568 Value *V = WorkList.back(); 569 570 if (Explored.count(V) != 0) { 571 WorkList.pop_back(); 572 continue; 573 } 574 575 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 576 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 577 // We've found some value that we can't explore which is different from 578 // the base. Therefore we can't do this transformation. 579 return false; 580 581 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 582 auto *CI = dyn_cast<CastInst>(V); 583 if (!CI->isNoopCast(DL)) 584 return false; 585 586 if (Explored.count(CI->getOperand(0)) == 0) 587 WorkList.push_back(CI->getOperand(0)); 588 } 589 590 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 591 // We're limiting the GEP to having one index. This will preserve 592 // the original pointer type. We could handle more cases in the 593 // future. 594 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 595 GEP->getType() != Start->getType()) 596 return false; 597 598 if (Explored.count(GEP->getOperand(0)) == 0) 599 WorkList.push_back(GEP->getOperand(0)); 600 } 601 602 if (WorkList.back() == V) { 603 WorkList.pop_back(); 604 // We've finished visiting this node, mark it as such. 605 Explored.insert(V); 606 } 607 608 if (auto *PN = dyn_cast<PHINode>(V)) { 609 // We cannot transform PHIs on unsplittable basic blocks. 610 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 611 return false; 612 Explored.insert(PN); 613 PHIs.insert(PN); 614 } 615 } 616 617 // Explore the PHI nodes further. 618 for (auto *PN : PHIs) 619 for (Value *Op : PN->incoming_values()) 620 if (Explored.count(Op) == 0) 621 WorkList.push_back(Op); 622 } 623 624 // Make sure that we can do this. Since we can't insert GEPs in a basic 625 // block before a PHI node, we can't easily do this transformation if 626 // we have PHI node users of transformed instructions. 627 for (Value *Val : Explored) { 628 for (Value *Use : Val->uses()) { 629 630 auto *PHI = dyn_cast<PHINode>(Use); 631 auto *Inst = dyn_cast<Instruction>(Val); 632 633 if (Inst == Base || Inst == PHI || !Inst || !PHI || 634 Explored.count(PHI) == 0) 635 continue; 636 637 if (PHI->getParent() == Inst->getParent()) 638 return false; 639 } 640 } 641 return true; 642 } 643 644 // Sets the appropriate insert point on Builder where we can add 645 // a replacement Instruction for V (if that is possible). 646 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 647 bool Before = true) { 648 if (auto *PHI = dyn_cast<PHINode>(V)) { 649 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 650 return; 651 } 652 if (auto *I = dyn_cast<Instruction>(V)) { 653 if (!Before) 654 I = &*std::next(I->getIterator()); 655 Builder.SetInsertPoint(I); 656 return; 657 } 658 if (auto *A = dyn_cast<Argument>(V)) { 659 // Set the insertion point in the entry block. 660 BasicBlock &Entry = A->getParent()->getEntryBlock(); 661 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 662 return; 663 } 664 // Otherwise, this is a constant and we don't need to set a new 665 // insertion point. 666 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 667 } 668 669 /// Returns a re-written value of Start as an indexed GEP using Base as a 670 /// pointer. 671 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 672 const DataLayout &DL, 673 SetVector<Value *> &Explored) { 674 // Perform all the substitutions. This is a bit tricky because we can 675 // have cycles in our use-def chains. 676 // 1. Create the PHI nodes without any incoming values. 677 // 2. Create all the other values. 678 // 3. Add the edges for the PHI nodes. 679 // 4. Emit GEPs to get the original pointers. 680 // 5. Remove the original instructions. 681 Type *IndexType = IntegerType::get( 682 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 683 684 DenseMap<Value *, Value *> NewInsts; 685 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 686 687 // Create the new PHI nodes, without adding any incoming values. 688 for (Value *Val : Explored) { 689 if (Val == Base) 690 continue; 691 // Create empty phi nodes. This avoids cyclic dependencies when creating 692 // the remaining instructions. 693 if (auto *PHI = dyn_cast<PHINode>(Val)) 694 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 695 PHI->getName() + ".idx", PHI); 696 } 697 IRBuilder<> Builder(Base->getContext()); 698 699 // Create all the other instructions. 700 for (Value *Val : Explored) { 701 702 if (NewInsts.find(Val) != NewInsts.end()) 703 continue; 704 705 if (auto *CI = dyn_cast<CastInst>(Val)) { 706 // Don't get rid of the intermediate variable here; the store can grow 707 // the map which will invalidate the reference to the input value. 708 Value *V = NewInsts[CI->getOperand(0)]; 709 NewInsts[CI] = V; 710 continue; 711 } 712 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 713 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 714 : GEP->getOperand(1); 715 setInsertionPoint(Builder, GEP); 716 // Indices might need to be sign extended. GEPs will magically do 717 // this, but we need to do it ourselves here. 718 if (Index->getType()->getScalarSizeInBits() != 719 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 720 Index = Builder.CreateSExtOrTrunc( 721 Index, NewInsts[GEP->getOperand(0)]->getType(), 722 GEP->getOperand(0)->getName() + ".sext"); 723 } 724 725 auto *Op = NewInsts[GEP->getOperand(0)]; 726 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 727 NewInsts[GEP] = Index; 728 else 729 NewInsts[GEP] = Builder.CreateNSWAdd( 730 Op, Index, GEP->getOperand(0)->getName() + ".add"); 731 continue; 732 } 733 if (isa<PHINode>(Val)) 734 continue; 735 736 llvm_unreachable("Unexpected instruction type"); 737 } 738 739 // Add the incoming values to the PHI nodes. 740 for (Value *Val : Explored) { 741 if (Val == Base) 742 continue; 743 // All the instructions have been created, we can now add edges to the 744 // phi nodes. 745 if (auto *PHI = dyn_cast<PHINode>(Val)) { 746 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 747 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 748 Value *NewIncoming = PHI->getIncomingValue(I); 749 750 if (NewInsts.find(NewIncoming) != NewInsts.end()) 751 NewIncoming = NewInsts[NewIncoming]; 752 753 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 754 } 755 } 756 } 757 758 for (Value *Val : Explored) { 759 if (Val == Base) 760 continue; 761 762 // Depending on the type, for external users we have to emit 763 // a GEP or a GEP + ptrtoint. 764 setInsertionPoint(Builder, Val, false); 765 766 // If required, create an inttoptr instruction for Base. 767 Value *NewBase = Base; 768 if (!Base->getType()->isPointerTy()) 769 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 770 Start->getName() + "to.ptr"); 771 772 Value *GEP = Builder.CreateInBoundsGEP( 773 Start->getType()->getPointerElementType(), NewBase, 774 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 775 776 if (!Val->getType()->isPointerTy()) { 777 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 778 Val->getName() + ".conv"); 779 GEP = Cast; 780 } 781 Val->replaceAllUsesWith(GEP); 782 } 783 784 return NewInsts[Start]; 785 } 786 787 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 788 /// the input Value as a constant indexed GEP. Returns a pair containing 789 /// the GEPs Pointer and Index. 790 static std::pair<Value *, Value *> 791 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 792 Type *IndexType = IntegerType::get(V->getContext(), 793 DL.getIndexTypeSizeInBits(V->getType())); 794 795 Constant *Index = ConstantInt::getNullValue(IndexType); 796 while (true) { 797 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 798 // We accept only inbouds GEPs here to exclude the possibility of 799 // overflow. 800 if (!GEP->isInBounds()) 801 break; 802 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 803 GEP->getType() == V->getType()) { 804 V = GEP->getOperand(0); 805 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 806 Index = ConstantExpr::getAdd( 807 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 808 continue; 809 } 810 break; 811 } 812 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 813 if (!CI->isNoopCast(DL)) 814 break; 815 V = CI->getOperand(0); 816 continue; 817 } 818 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 819 if (!CI->isNoopCast(DL)) 820 break; 821 V = CI->getOperand(0); 822 continue; 823 } 824 break; 825 } 826 return {V, Index}; 827 } 828 829 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 830 /// We can look through PHIs, GEPs and casts in order to determine a common base 831 /// between GEPLHS and RHS. 832 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 833 ICmpInst::Predicate Cond, 834 const DataLayout &DL) { 835 if (!GEPLHS->hasAllConstantIndices()) 836 return nullptr; 837 838 // Make sure the pointers have the same type. 839 if (GEPLHS->getType() != RHS->getType()) 840 return nullptr; 841 842 Value *PtrBase, *Index; 843 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 844 845 // The set of nodes that will take part in this transformation. 846 SetVector<Value *> Nodes; 847 848 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 849 return nullptr; 850 851 // We know we can re-write this as 852 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 853 // Since we've only looked through inbouds GEPs we know that we 854 // can't have overflow on either side. We can therefore re-write 855 // this as: 856 // OFFSET1 cmp OFFSET2 857 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 858 859 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 860 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 861 // offset. Since Index is the offset of LHS to the base pointer, we will now 862 // compare the offsets instead of comparing the pointers. 863 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 864 } 865 866 /// Fold comparisons between a GEP instruction and something else. At this point 867 /// we know that the GEP is on the LHS of the comparison. 868 Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 869 ICmpInst::Predicate Cond, 870 Instruction &I) { 871 // Don't transform signed compares of GEPs into index compares. Even if the 872 // GEP is inbounds, the final add of the base pointer can have signed overflow 873 // and would change the result of the icmp. 874 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 875 // the maximum signed value for the pointer type. 876 if (ICmpInst::isSigned(Cond)) 877 return nullptr; 878 879 // Look through bitcasts and addrspacecasts. We do not however want to remove 880 // 0 GEPs. 881 if (!isa<GetElementPtrInst>(RHS)) 882 RHS = RHS->stripPointerCasts(); 883 884 Value *PtrBase = GEPLHS->getOperand(0); 885 if (PtrBase == RHS && GEPLHS->isInBounds()) { 886 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 887 // This transformation (ignoring the base and scales) is valid because we 888 // know pointers can't overflow since the gep is inbounds. See if we can 889 // output an optimized form. 890 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 891 892 // If not, synthesize the offset the hard way. 893 if (!Offset) 894 Offset = EmitGEPOffset(GEPLHS); 895 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 896 Constant::getNullValue(Offset->getType())); 897 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 898 // If the base pointers are different, but the indices are the same, just 899 // compare the base pointer. 900 if (PtrBase != GEPRHS->getOperand(0)) { 901 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 902 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 903 GEPRHS->getOperand(0)->getType(); 904 if (IndicesTheSame) 905 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 906 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 907 IndicesTheSame = false; 908 break; 909 } 910 911 // If all indices are the same, just compare the base pointers. 912 Type *BaseType = GEPLHS->getOperand(0)->getType(); 913 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 914 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 915 916 // If we're comparing GEPs with two base pointers that only differ in type 917 // and both GEPs have only constant indices or just one use, then fold 918 // the compare with the adjusted indices. 919 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 920 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 921 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 922 PtrBase->stripPointerCasts() == 923 GEPRHS->getOperand(0)->stripPointerCasts()) { 924 Value *LOffset = EmitGEPOffset(GEPLHS); 925 Value *ROffset = EmitGEPOffset(GEPRHS); 926 927 // If we looked through an addrspacecast between different sized address 928 // spaces, the LHS and RHS pointers are different sized 929 // integers. Truncate to the smaller one. 930 Type *LHSIndexTy = LOffset->getType(); 931 Type *RHSIndexTy = ROffset->getType(); 932 if (LHSIndexTy != RHSIndexTy) { 933 if (LHSIndexTy->getPrimitiveSizeInBits() < 934 RHSIndexTy->getPrimitiveSizeInBits()) { 935 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 936 } else 937 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 938 } 939 940 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 941 LOffset, ROffset); 942 return replaceInstUsesWith(I, Cmp); 943 } 944 945 // Otherwise, the base pointers are different and the indices are 946 // different. Try convert this to an indexed compare by looking through 947 // PHIs/casts. 948 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 949 } 950 951 // If one of the GEPs has all zero indices, recurse. 952 if (GEPLHS->hasAllZeroIndices()) 953 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 954 ICmpInst::getSwappedPredicate(Cond), I); 955 956 // If the other GEP has all zero indices, recurse. 957 if (GEPRHS->hasAllZeroIndices()) 958 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 959 960 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 961 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 962 // If the GEPs only differ by one index, compare it. 963 unsigned NumDifferences = 0; // Keep track of # differences. 964 unsigned DiffOperand = 0; // The operand that differs. 965 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 966 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 967 if (GEPLHS->getOperand(i)->getType()->getPrimitiveSizeInBits() != 968 GEPRHS->getOperand(i)->getType()->getPrimitiveSizeInBits()) { 969 // Irreconcilable differences. 970 NumDifferences = 2; 971 break; 972 } else { 973 if (NumDifferences++) break; 974 DiffOperand = i; 975 } 976 } 977 978 if (NumDifferences == 0) // SAME GEP? 979 return replaceInstUsesWith(I, // No comparison is needed here. 980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 981 982 else if (NumDifferences == 1 && GEPsInBounds) { 983 Value *LHSV = GEPLHS->getOperand(DiffOperand); 984 Value *RHSV = GEPRHS->getOperand(DiffOperand); 985 // Make sure we do a signed comparison here. 986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 987 } 988 } 989 990 // Only lower this if the icmp is the only user of the GEP or if we expect 991 // the result to fold to a constant! 992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 995 Value *L = EmitGEPOffset(GEPLHS); 996 Value *R = EmitGEPOffset(GEPRHS); 997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 998 } 999 } 1000 1001 // Try convert this to an indexed compare by looking through PHIs/casts as a 1002 // last resort. 1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1004 } 1005 1006 Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI, 1007 const AllocaInst *Alloca, 1008 const Value *Other) { 1009 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1010 1011 // It would be tempting to fold away comparisons between allocas and any 1012 // pointer not based on that alloca (e.g. an argument). However, even 1013 // though such pointers cannot alias, they can still compare equal. 1014 // 1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1016 // doesn't escape we can argue that it's impossible to guess its value, and we 1017 // can therefore act as if any such guesses are wrong. 1018 // 1019 // The code below checks that the alloca doesn't escape, and that it's only 1020 // used in a comparison once (the current instruction). The 1021 // single-comparison-use condition ensures that we're trivially folding all 1022 // comparisons against the alloca consistently, and avoids the risk of 1023 // erroneously folding a comparison of the pointer with itself. 1024 1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1026 1027 SmallVector<const Use *, 32> Worklist; 1028 for (const Use &U : Alloca->uses()) { 1029 if (Worklist.size() >= MaxIter) 1030 return nullptr; 1031 Worklist.push_back(&U); 1032 } 1033 1034 unsigned NumCmps = 0; 1035 while (!Worklist.empty()) { 1036 assert(Worklist.size() <= MaxIter); 1037 const Use *U = Worklist.pop_back_val(); 1038 const Value *V = U->getUser(); 1039 --MaxIter; 1040 1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1042 isa<SelectInst>(V)) { 1043 // Track the uses. 1044 } else if (isa<LoadInst>(V)) { 1045 // Loading from the pointer doesn't escape it. 1046 continue; 1047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1048 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1049 if (SI->getValueOperand() == U->get()) 1050 return nullptr; 1051 continue; 1052 } else if (isa<ICmpInst>(V)) { 1053 if (NumCmps++) 1054 return nullptr; // Found more than one cmp. 1055 continue; 1056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1057 switch (Intrin->getIntrinsicID()) { 1058 // These intrinsics don't escape or compare the pointer. Memset is safe 1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1060 // we don't allow stores, so src cannot point to V. 1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1063 continue; 1064 default: 1065 return nullptr; 1066 } 1067 } else { 1068 return nullptr; 1069 } 1070 for (const Use &U : V->uses()) { 1071 if (Worklist.size() >= MaxIter) 1072 return nullptr; 1073 Worklist.push_back(&U); 1074 } 1075 } 1076 1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1078 return replaceInstUsesWith( 1079 ICI, 1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1081 } 1082 1083 /// Fold "icmp pred (X+C), X". 1084 Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C, 1085 ICmpInst::Predicate Pred) { 1086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1087 // so the values can never be equal. Similarly for all other "or equals" 1088 // operators. 1089 assert(!!C && "C should not be zero!"); 1090 1091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1095 Constant *R = ConstantInt::get(X->getType(), 1096 APInt::getMaxValue(C.getBitWidth()) - C); 1097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1098 } 1099 1100 // (X+1) >u X --> X <u (0-1) --> X != 255 1101 // (X+2) >u X --> X <u (0-2) --> X <u 254 1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1104 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1105 ConstantInt::get(X->getType(), -C)); 1106 1107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1108 1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1116 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1117 ConstantInt::get(X->getType(), SMax - C)); 1118 1119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1125 1126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1127 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1128 ConstantInt::get(X->getType(), SMax - (C - 1))); 1129 } 1130 1131 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1132 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1133 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1134 Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A, 1135 const APInt &AP1, 1136 const APInt &AP2) { 1137 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1138 1139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1140 if (I.getPredicate() == I.ICMP_NE) 1141 Pred = CmpInst::getInversePredicate(Pred); 1142 return new ICmpInst(Pred, LHS, RHS); 1143 }; 1144 1145 // Don't bother doing any work for cases which InstSimplify handles. 1146 if (AP2.isNullValue()) 1147 return nullptr; 1148 1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1150 if (IsAShr) { 1151 if (AP2.isAllOnesValue()) 1152 return nullptr; 1153 if (AP2.isNegative() != AP1.isNegative()) 1154 return nullptr; 1155 if (AP2.sgt(AP1)) 1156 return nullptr; 1157 } 1158 1159 if (!AP1) 1160 // 'A' must be large enough to shift out the highest set bit. 1161 return getICmp(I.ICMP_UGT, A, 1162 ConstantInt::get(A->getType(), AP2.logBase2())); 1163 1164 if (AP1 == AP2) 1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1166 1167 int Shift; 1168 if (IsAShr && AP1.isNegative()) 1169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1170 else 1171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1172 1173 if (Shift > 0) { 1174 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1175 // There are multiple solutions if we are comparing against -1 and the LHS 1176 // of the ashr is not a power of two. 1177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1180 } else if (AP1 == AP2.lshr(Shift)) { 1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1182 } 1183 } 1184 1185 // Shifting const2 will never be equal to const1. 1186 // FIXME: This should always be handled by InstSimplify? 1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1188 return replaceInstUsesWith(I, TorF); 1189 } 1190 1191 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1192 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1193 Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A, 1194 const APInt &AP1, 1195 const APInt &AP2) { 1196 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1197 1198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1199 if (I.getPredicate() == I.ICMP_NE) 1200 Pred = CmpInst::getInversePredicate(Pred); 1201 return new ICmpInst(Pred, LHS, RHS); 1202 }; 1203 1204 // Don't bother doing any work for cases which InstSimplify handles. 1205 if (AP2.isNullValue()) 1206 return nullptr; 1207 1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1209 1210 if (!AP1 && AP2TrailingZeros != 0) 1211 return getICmp( 1212 I.ICMP_UGE, A, 1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1214 1215 if (AP1 == AP2) 1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1217 1218 // Get the distance between the lowest bits that are set. 1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1220 1221 if (Shift > 0 && AP2.shl(Shift) == AP1) 1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1223 1224 // Shifting const2 will never be equal to const1. 1225 // FIXME: This should always be handled by InstSimplify? 1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1227 return replaceInstUsesWith(I, TorF); 1228 } 1229 1230 /// The caller has matched a pattern of the form: 1231 /// I = icmp ugt (add (add A, B), CI2), CI1 1232 /// If this is of the form: 1233 /// sum = a + b 1234 /// if (sum+128 >u 255) 1235 /// Then replace it with llvm.sadd.with.overflow.i8. 1236 /// 1237 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1238 ConstantInt *CI2, ConstantInt *CI1, 1239 InstCombiner &IC) { 1240 // The transformation we're trying to do here is to transform this into an 1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1242 // with a narrower add, and discard the add-with-constant that is part of the 1243 // range check (if we can't eliminate it, this isn't profitable). 1244 1245 // In order to eliminate the add-with-constant, the compare can be its only 1246 // use. 1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1248 if (!AddWithCst->hasOneUse()) 1249 return nullptr; 1250 1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1252 if (!CI2->getValue().isPowerOf2()) 1253 return nullptr; 1254 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1256 return nullptr; 1257 1258 // The width of the new add formed is 1 more than the bias. 1259 ++NewWidth; 1260 1261 // Check to see that CI1 is an all-ones value with NewWidth bits. 1262 if (CI1->getBitWidth() == NewWidth || 1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1264 return nullptr; 1265 1266 // This is only really a signed overflow check if the inputs have been 1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1272 return nullptr; 1273 1274 // In order to replace the original add with a narrower 1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1276 // and truncates that discard the high bits of the add. Verify that this is 1277 // the case. 1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1279 for (User *U : OrigAdd->users()) { 1280 if (U == AddWithCst) 1281 continue; 1282 1283 // Only accept truncates for now. We would really like a nice recursive 1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1285 // chain to see which bits of a value are actually demanded. If the 1286 // original add had another add which was then immediately truncated, we 1287 // could still do the transformation. 1288 TruncInst *TI = dyn_cast<TruncInst>(U); 1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1290 return nullptr; 1291 } 1292 1293 // If the pattern matches, truncate the inputs to the narrower type and 1294 // use the sadd_with_overflow intrinsic to efficiently compute both the 1295 // result and the overflow bit. 1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1297 Function *F = Intrinsic::getDeclaration( 1298 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1299 1300 InstCombiner::BuilderTy &Builder = IC.Builder; 1301 1302 // Put the new code above the original add, in case there are any uses of the 1303 // add between the add and the compare. 1304 Builder.SetInsertPoint(OrigAdd); 1305 1306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1311 1312 // The inner add was the result of the narrow add, zero extended to the 1313 // wider type. Replace it with the result computed by the intrinsic. 1314 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1315 1316 // The original icmp gets replaced with the overflow value. 1317 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1318 } 1319 1320 /// If we have: 1321 /// icmp eq/ne (urem/srem %x, %y), 0 1322 /// iff %y is a power-of-two, we can replace this with a bit test: 1323 /// icmp eq/ne (and %x, (add %y, -1)), 0 1324 Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1325 // This fold is only valid for equality predicates. 1326 if (!I.isEquality()) 1327 return nullptr; 1328 ICmpInst::Predicate Pred; 1329 Value *X, *Y, *Zero; 1330 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1331 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1332 return nullptr; 1333 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1334 return nullptr; 1335 // This may increase instruction count, we don't enforce that Y is a constant. 1336 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1337 Value *Masked = Builder.CreateAnd(X, Mask); 1338 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1339 } 1340 1341 // Handle icmp pred X, 0 1342 Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) { 1343 CmpInst::Predicate Pred = Cmp.getPredicate(); 1344 if (!match(Cmp.getOperand(1), m_Zero())) 1345 return nullptr; 1346 1347 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1348 if (Pred == ICmpInst::ICMP_SGT) { 1349 Value *A, *B; 1350 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B); 1351 if (SPR.Flavor == SPF_SMIN) { 1352 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1353 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1354 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1355 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1356 } 1357 } 1358 1359 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1360 return New; 1361 1362 // Given: 1363 // icmp eq/ne (urem %x, %y), 0 1364 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1365 // icmp eq/ne %x, 0 1366 Value *X, *Y; 1367 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1368 ICmpInst::isEquality(Pred)) { 1369 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1370 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1371 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1372 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1373 } 1374 1375 return nullptr; 1376 } 1377 1378 /// Fold icmp Pred X, C. 1379 /// TODO: This code structure does not make sense. The saturating add fold 1380 /// should be moved to some other helper and extended as noted below (it is also 1381 /// possible that code has been made unnecessary - do we canonicalize IR to 1382 /// overflow/saturating intrinsics or not?). 1383 Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) { 1384 // Match the following pattern, which is a common idiom when writing 1385 // overflow-safe integer arithmetic functions. The source performs an addition 1386 // in wider type and explicitly checks for overflow using comparisons against 1387 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1388 // 1389 // TODO: This could probably be generalized to handle other overflow-safe 1390 // operations if we worked out the formulas to compute the appropriate magic 1391 // constants. 1392 // 1393 // sum = a + b 1394 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1395 CmpInst::Predicate Pred = Cmp.getPredicate(); 1396 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1397 Value *A, *B; 1398 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1399 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1400 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1401 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1402 return Res; 1403 1404 return nullptr; 1405 } 1406 1407 /// Canonicalize icmp instructions based on dominating conditions. 1408 Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1409 // This is a cheap/incomplete check for dominance - just match a single 1410 // predecessor with a conditional branch. 1411 BasicBlock *CmpBB = Cmp.getParent(); 1412 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1413 if (!DomBB) 1414 return nullptr; 1415 1416 Value *DomCond; 1417 BasicBlock *TrueBB, *FalseBB; 1418 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1419 return nullptr; 1420 1421 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1422 "Predecessor block does not point to successor?"); 1423 1424 // The branch should get simplified. Don't bother simplifying this condition. 1425 if (TrueBB == FalseBB) 1426 return nullptr; 1427 1428 // Try to simplify this compare to T/F based on the dominating condition. 1429 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1430 if (Imp) 1431 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1432 1433 CmpInst::Predicate Pred = Cmp.getPredicate(); 1434 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1435 ICmpInst::Predicate DomPred; 1436 const APInt *C, *DomC; 1437 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1438 match(Y, m_APInt(C))) { 1439 // We have 2 compares of a variable with constants. Calculate the constant 1440 // ranges of those compares to see if we can transform the 2nd compare: 1441 // DomBB: 1442 // DomCond = icmp DomPred X, DomC 1443 // br DomCond, CmpBB, FalseBB 1444 // CmpBB: 1445 // Cmp = icmp Pred X, C 1446 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C); 1447 ConstantRange DominatingCR = 1448 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1449 : ConstantRange::makeExactICmpRegion( 1450 CmpInst::getInversePredicate(DomPred), *DomC); 1451 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1452 ConstantRange Difference = DominatingCR.difference(CR); 1453 if (Intersection.isEmptySet()) 1454 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1455 if (Difference.isEmptySet()) 1456 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1457 1458 // Canonicalizing a sign bit comparison that gets used in a branch, 1459 // pessimizes codegen by generating branch on zero instruction instead 1460 // of a test and branch. So we avoid canonicalizing in such situations 1461 // because test and branch instruction has better branch displacement 1462 // than compare and branch instruction. 1463 bool UnusedBit; 1464 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1465 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1466 return nullptr; 1467 1468 if (const APInt *EqC = Intersection.getSingleElement()) 1469 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1470 if (const APInt *NeC = Difference.getSingleElement()) 1471 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1472 } 1473 1474 return nullptr; 1475 } 1476 1477 /// Fold icmp (trunc X, Y), C. 1478 Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp, 1479 TruncInst *Trunc, 1480 const APInt &C) { 1481 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1482 Value *X = Trunc->getOperand(0); 1483 if (C.isOneValue() && C.getBitWidth() > 1) { 1484 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1485 Value *V = nullptr; 1486 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1487 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1488 ConstantInt::get(V->getType(), 1)); 1489 } 1490 1491 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1492 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1493 // of the high bits truncated out of x are known. 1494 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1495 SrcBits = X->getType()->getScalarSizeInBits(); 1496 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1497 1498 // If all the high bits are known, we can do this xform. 1499 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1500 // Pull in the high bits from known-ones set. 1501 APInt NewRHS = C.zext(SrcBits); 1502 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1503 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1504 } 1505 } 1506 1507 return nullptr; 1508 } 1509 1510 /// Fold icmp (xor X, Y), C. 1511 Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp, 1512 BinaryOperator *Xor, 1513 const APInt &C) { 1514 Value *X = Xor->getOperand(0); 1515 Value *Y = Xor->getOperand(1); 1516 const APInt *XorC; 1517 if (!match(Y, m_APInt(XorC))) 1518 return nullptr; 1519 1520 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1521 // fold the xor. 1522 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1523 bool TrueIfSigned = false; 1524 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1525 1526 // If the sign bit of the XorCst is not set, there is no change to 1527 // the operation, just stop using the Xor. 1528 if (!XorC->isNegative()) { 1529 Cmp.setOperand(0, X); 1530 Worklist.Add(Xor); 1531 return &Cmp; 1532 } 1533 1534 // Emit the opposite comparison. 1535 if (TrueIfSigned) 1536 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1537 ConstantInt::getAllOnesValue(X->getType())); 1538 else 1539 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1540 ConstantInt::getNullValue(X->getType())); 1541 } 1542 1543 if (Xor->hasOneUse()) { 1544 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1545 if (!Cmp.isEquality() && XorC->isSignMask()) { 1546 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1547 : Cmp.getSignedPredicate(); 1548 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1549 } 1550 1551 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1552 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1553 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1554 : Cmp.getSignedPredicate(); 1555 Pred = Cmp.getSwappedPredicate(Pred); 1556 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1557 } 1558 } 1559 1560 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1561 if (Pred == ICmpInst::ICMP_UGT) { 1562 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1563 if (*XorC == ~C && (C + 1).isPowerOf2()) 1564 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1565 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1566 if (*XorC == C && (C + 1).isPowerOf2()) 1567 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1568 } 1569 if (Pred == ICmpInst::ICMP_ULT) { 1570 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1571 if (*XorC == -C && C.isPowerOf2()) 1572 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1573 ConstantInt::get(X->getType(), ~C)); 1574 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1575 if (*XorC == C && (-C).isPowerOf2()) 1576 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1577 ConstantInt::get(X->getType(), ~C)); 1578 } 1579 return nullptr; 1580 } 1581 1582 /// Fold icmp (and (sh X, Y), C2), C1. 1583 Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And, 1584 const APInt &C1, const APInt &C2) { 1585 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1586 if (!Shift || !Shift->isShift()) 1587 return nullptr; 1588 1589 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1590 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1591 // code produced by the clang front-end, for bitfield access. 1592 // This seemingly simple opportunity to fold away a shift turns out to be 1593 // rather complicated. See PR17827 for details. 1594 unsigned ShiftOpcode = Shift->getOpcode(); 1595 bool IsShl = ShiftOpcode == Instruction::Shl; 1596 const APInt *C3; 1597 if (match(Shift->getOperand(1), m_APInt(C3))) { 1598 bool CanFold = false; 1599 if (ShiftOpcode == Instruction::Shl) { 1600 // For a left shift, we can fold if the comparison is not signed. We can 1601 // also fold a signed comparison if the mask value and comparison value 1602 // are not negative. These constraints may not be obvious, but we can 1603 // prove that they are correct using an SMT solver. 1604 if (!Cmp.isSigned() || (!C2.isNegative() && !C1.isNegative())) 1605 CanFold = true; 1606 } else { 1607 bool IsAshr = ShiftOpcode == Instruction::AShr; 1608 // For a logical right shift, we can fold if the comparison is not signed. 1609 // We can also fold a signed comparison if the shifted mask value and the 1610 // shifted comparison value are not negative. These constraints may not be 1611 // obvious, but we can prove that they are correct using an SMT solver. 1612 // For an arithmetic shift right we can do the same, if we ensure 1613 // the And doesn't use any bits being shifted in. Normally these would 1614 // be turned into lshr by SimplifyDemandedBits, but not if there is an 1615 // additional user. 1616 if (!IsAshr || (C2.shl(*C3).lshr(*C3) == C2)) { 1617 if (!Cmp.isSigned() || 1618 (!C2.shl(*C3).isNegative() && !C1.shl(*C3).isNegative())) 1619 CanFold = true; 1620 } 1621 } 1622 1623 if (CanFold) { 1624 APInt NewCst = IsShl ? C1.lshr(*C3) : C1.shl(*C3); 1625 APInt SameAsC1 = IsShl ? NewCst.shl(*C3) : NewCst.lshr(*C3); 1626 // Check to see if we are shifting out any of the bits being compared. 1627 if (SameAsC1 != C1) { 1628 // If we shifted bits out, the fold is not going to work out. As a 1629 // special case, check to see if this means that the result is always 1630 // true or false now. 1631 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1632 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1633 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1634 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1635 } else { 1636 Cmp.setOperand(1, ConstantInt::get(And->getType(), NewCst)); 1637 APInt NewAndCst = IsShl ? C2.lshr(*C3) : C2.shl(*C3); 1638 And->setOperand(1, ConstantInt::get(And->getType(), NewAndCst)); 1639 And->setOperand(0, Shift->getOperand(0)); 1640 Worklist.Add(Shift); // Shift is dead. 1641 return &Cmp; 1642 } 1643 } 1644 } 1645 1646 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1647 // preferable because it allows the C2 << Y expression to be hoisted out of a 1648 // loop if Y is invariant and X is not. 1649 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() && 1650 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1651 // Compute C2 << Y. 1652 Value *NewShift = 1653 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1654 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1655 1656 // Compute X & (C2 << Y). 1657 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1658 Cmp.setOperand(0, NewAnd); 1659 return &Cmp; 1660 } 1661 1662 return nullptr; 1663 } 1664 1665 /// Fold icmp (and X, C2), C1. 1666 Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp, 1667 BinaryOperator *And, 1668 const APInt &C1) { 1669 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1670 1671 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1672 // TODO: We canonicalize to the longer form for scalars because we have 1673 // better analysis/folds for icmp, and codegen may be better with icmp. 1674 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() && 1675 match(And->getOperand(1), m_One())) 1676 return new TruncInst(And->getOperand(0), Cmp.getType()); 1677 1678 const APInt *C2; 1679 Value *X; 1680 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1681 return nullptr; 1682 1683 // Don't perform the following transforms if the AND has multiple uses 1684 if (!And->hasOneUse()) 1685 return nullptr; 1686 1687 if (Cmp.isEquality() && C1.isNullValue()) { 1688 // Restrict this fold to single-use 'and' (PR10267). 1689 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1690 if (C2->isSignMask()) { 1691 Constant *Zero = Constant::getNullValue(X->getType()); 1692 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1693 return new ICmpInst(NewPred, X, Zero); 1694 } 1695 1696 // Restrict this fold only for single-use 'and' (PR10267). 1697 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1698 if ((~(*C2) + 1).isPowerOf2()) { 1699 Constant *NegBOC = 1700 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1701 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1702 return new ICmpInst(NewPred, X, NegBOC); 1703 } 1704 } 1705 1706 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1707 // the input width without changing the value produced, eliminate the cast: 1708 // 1709 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1710 // 1711 // We can do this transformation if the constants do not have their sign bits 1712 // set or if it is an equality comparison. Extending a relational comparison 1713 // when we're checking the sign bit would not work. 1714 Value *W; 1715 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1716 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1717 // TODO: Is this a good transform for vectors? Wider types may reduce 1718 // throughput. Should this transform be limited (even for scalars) by using 1719 // shouldChangeType()? 1720 if (!Cmp.getType()->isVectorTy()) { 1721 Type *WideType = W->getType(); 1722 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1723 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1724 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1725 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1726 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1727 } 1728 } 1729 1730 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1731 return I; 1732 1733 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1734 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1735 // 1736 // iff pred isn't signed 1737 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() && 1738 match(And->getOperand(1), m_One())) { 1739 Constant *One = cast<Constant>(And->getOperand(1)); 1740 Value *Or = And->getOperand(0); 1741 Value *A, *B, *LShr; 1742 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1743 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1744 unsigned UsesRemoved = 0; 1745 if (And->hasOneUse()) 1746 ++UsesRemoved; 1747 if (Or->hasOneUse()) 1748 ++UsesRemoved; 1749 if (LShr->hasOneUse()) 1750 ++UsesRemoved; 1751 1752 // Compute A & ((1 << B) | 1) 1753 Value *NewOr = nullptr; 1754 if (auto *C = dyn_cast<Constant>(B)) { 1755 if (UsesRemoved >= 1) 1756 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1757 } else { 1758 if (UsesRemoved >= 3) 1759 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1760 /*HasNUW=*/true), 1761 One, Or->getName()); 1762 } 1763 if (NewOr) { 1764 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1765 Cmp.setOperand(0, NewAnd); 1766 return &Cmp; 1767 } 1768 } 1769 } 1770 1771 return nullptr; 1772 } 1773 1774 /// Fold icmp (and X, Y), C. 1775 Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp, 1776 BinaryOperator *And, 1777 const APInt &C) { 1778 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1779 return I; 1780 1781 // TODO: These all require that Y is constant too, so refactor with the above. 1782 1783 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1784 Value *X = And->getOperand(0); 1785 Value *Y = And->getOperand(1); 1786 if (auto *LI = dyn_cast<LoadInst>(X)) 1787 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1788 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1789 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1790 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1791 ConstantInt *C2 = cast<ConstantInt>(Y); 1792 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1793 return Res; 1794 } 1795 1796 if (!Cmp.isEquality()) 1797 return nullptr; 1798 1799 // X & -C == -C -> X > u ~C 1800 // X & -C != -C -> X <= u ~C 1801 // iff C is a power of 2 1802 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) { 1803 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1804 : CmpInst::ICMP_ULE; 1805 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1806 } 1807 1808 // (X & C2) == 0 -> (trunc X) >= 0 1809 // (X & C2) != 0 -> (trunc X) < 0 1810 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1811 const APInt *C2; 1812 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) { 1813 int32_t ExactLogBase2 = C2->exactLogBase2(); 1814 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1815 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1816 if (And->getType()->isVectorTy()) 1817 NTy = VectorType::get(NTy, And->getType()->getVectorNumElements()); 1818 Value *Trunc = Builder.CreateTrunc(X, NTy); 1819 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1820 : CmpInst::ICMP_SLT; 1821 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1822 } 1823 } 1824 1825 return nullptr; 1826 } 1827 1828 /// Fold icmp (or X, Y), C. 1829 Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or, 1830 const APInt &C) { 1831 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1832 if (C.isOneValue()) { 1833 // icmp slt signum(V) 1 --> icmp slt V, 1 1834 Value *V = nullptr; 1835 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1836 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1837 ConstantInt::get(V->getType(), 1)); 1838 } 1839 1840 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1841 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) { 1842 // X | C == C --> X <=u C 1843 // X | C != C --> X >u C 1844 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1845 if ((C + 1).isPowerOf2()) { 1846 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1847 return new ICmpInst(Pred, OrOp0, OrOp1); 1848 } 1849 // More general: are all bits outside of a mask constant set or not set? 1850 // X | C == C --> (X & ~C) == 0 1851 // X | C != C --> (X & ~C) != 0 1852 if (Or->hasOneUse()) { 1853 Value *A = Builder.CreateAnd(OrOp0, ~C); 1854 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType())); 1855 } 1856 } 1857 1858 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse()) 1859 return nullptr; 1860 1861 Value *P, *Q; 1862 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1863 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1864 // -> and (icmp eq P, null), (icmp eq Q, null). 1865 Value *CmpP = 1866 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1867 Value *CmpQ = 1868 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1869 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1870 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1871 } 1872 1873 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1874 // a shorter form that has more potential to be folded even further. 1875 Value *X1, *X2, *X3, *X4; 1876 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1877 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1878 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1879 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1880 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1881 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1882 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1883 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1884 } 1885 1886 return nullptr; 1887 } 1888 1889 /// Fold icmp (mul X, Y), C. 1890 Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp, 1891 BinaryOperator *Mul, 1892 const APInt &C) { 1893 const APInt *MulC; 1894 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1895 return nullptr; 1896 1897 // If this is a test of the sign bit and the multiply is sign-preserving with 1898 // a constant operand, use the multiply LHS operand instead. 1899 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1900 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1901 if (MulC->isNegative()) 1902 Pred = ICmpInst::getSwappedPredicate(Pred); 1903 return new ICmpInst(Pred, Mul->getOperand(0), 1904 Constant::getNullValue(Mul->getType())); 1905 } 1906 1907 return nullptr; 1908 } 1909 1910 /// Fold icmp (shl 1, Y), C. 1911 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 1912 const APInt &C) { 1913 Value *Y; 1914 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 1915 return nullptr; 1916 1917 Type *ShiftType = Shl->getType(); 1918 unsigned TypeBits = C.getBitWidth(); 1919 bool CIsPowerOf2 = C.isPowerOf2(); 1920 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1921 if (Cmp.isUnsigned()) { 1922 // (1 << Y) pred C -> Y pred Log2(C) 1923 if (!CIsPowerOf2) { 1924 // (1 << Y) < 30 -> Y <= 4 1925 // (1 << Y) <= 30 -> Y <= 4 1926 // (1 << Y) >= 30 -> Y > 4 1927 // (1 << Y) > 30 -> Y > 4 1928 if (Pred == ICmpInst::ICMP_ULT) 1929 Pred = ICmpInst::ICMP_ULE; 1930 else if (Pred == ICmpInst::ICMP_UGE) 1931 Pred = ICmpInst::ICMP_UGT; 1932 } 1933 1934 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 1935 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 1936 unsigned CLog2 = C.logBase2(); 1937 if (CLog2 == TypeBits - 1) { 1938 if (Pred == ICmpInst::ICMP_UGE) 1939 Pred = ICmpInst::ICMP_EQ; 1940 else if (Pred == ICmpInst::ICMP_ULT) 1941 Pred = ICmpInst::ICMP_NE; 1942 } 1943 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 1944 } else if (Cmp.isSigned()) { 1945 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 1946 if (C.isAllOnesValue()) { 1947 // (1 << Y) <= -1 -> Y == 31 1948 if (Pred == ICmpInst::ICMP_SLE) 1949 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1950 1951 // (1 << Y) > -1 -> Y != 31 1952 if (Pred == ICmpInst::ICMP_SGT) 1953 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1954 } else if (!C) { 1955 // (1 << Y) < 0 -> Y == 31 1956 // (1 << Y) <= 0 -> Y == 31 1957 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1958 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1959 1960 // (1 << Y) >= 0 -> Y != 31 1961 // (1 << Y) > 0 -> Y != 31 1962 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 1963 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 1964 } 1965 } else if (Cmp.isEquality() && CIsPowerOf2) { 1966 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 1967 } 1968 1969 return nullptr; 1970 } 1971 1972 /// Fold icmp (shl X, Y), C. 1973 Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp, 1974 BinaryOperator *Shl, 1975 const APInt &C) { 1976 const APInt *ShiftVal; 1977 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 1978 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 1979 1980 const APInt *ShiftAmt; 1981 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 1982 return foldICmpShlOne(Cmp, Shl, C); 1983 1984 // Check that the shift amount is in range. If not, don't perform undefined 1985 // shifts. When the shift is visited, it will be simplified. 1986 unsigned TypeBits = C.getBitWidth(); 1987 if (ShiftAmt->uge(TypeBits)) 1988 return nullptr; 1989 1990 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1991 Value *X = Shl->getOperand(0); 1992 Type *ShType = Shl->getType(); 1993 1994 // NSW guarantees that we are only shifting out sign bits from the high bits, 1995 // so we can ASHR the compare constant without needing a mask and eliminate 1996 // the shift. 1997 if (Shl->hasNoSignedWrap()) { 1998 if (Pred == ICmpInst::ICMP_SGT) { 1999 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2000 APInt ShiftedC = C.ashr(*ShiftAmt); 2001 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2002 } 2003 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2004 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2005 APInt ShiftedC = C.ashr(*ShiftAmt); 2006 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2007 } 2008 if (Pred == ICmpInst::ICMP_SLT) { 2009 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2010 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2011 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2012 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2013 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2014 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2015 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2016 } 2017 // If this is a signed comparison to 0 and the shift is sign preserving, 2018 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2019 // do that if we're sure to not continue on in this function. 2020 if (isSignTest(Pred, C)) 2021 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2022 } 2023 2024 // NUW guarantees that we are only shifting out zero bits from the high bits, 2025 // so we can LSHR the compare constant without needing a mask and eliminate 2026 // the shift. 2027 if (Shl->hasNoUnsignedWrap()) { 2028 if (Pred == ICmpInst::ICMP_UGT) { 2029 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2030 APInt ShiftedC = C.lshr(*ShiftAmt); 2031 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2032 } 2033 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2034 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2035 APInt ShiftedC = C.lshr(*ShiftAmt); 2036 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2037 } 2038 if (Pred == ICmpInst::ICMP_ULT) { 2039 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2040 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2041 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2042 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2043 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2044 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2045 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2046 } 2047 } 2048 2049 if (Cmp.isEquality() && Shl->hasOneUse()) { 2050 // Strength-reduce the shift into an 'and'. 2051 Constant *Mask = ConstantInt::get( 2052 ShType, 2053 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2054 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2055 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2056 return new ICmpInst(Pred, And, LShrC); 2057 } 2058 2059 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2060 bool TrueIfSigned = false; 2061 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2062 // (X << 31) <s 0 --> (X & 1) != 0 2063 Constant *Mask = ConstantInt::get( 2064 ShType, 2065 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2066 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2067 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2068 And, Constant::getNullValue(ShType)); 2069 } 2070 2071 // Simplify 'shl' inequality test into 'and' equality test. 2072 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2073 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2074 if ((C + 1).isPowerOf2() && 2075 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2076 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2077 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2078 : ICmpInst::ICMP_NE, 2079 And, Constant::getNullValue(ShType)); 2080 } 2081 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2082 if (C.isPowerOf2() && 2083 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2084 Value *And = 2085 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2086 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2087 : ICmpInst::ICMP_NE, 2088 And, Constant::getNullValue(ShType)); 2089 } 2090 } 2091 2092 // Transform (icmp pred iM (shl iM %v, N), C) 2093 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2094 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2095 // This enables us to get rid of the shift in favor of a trunc that may be 2096 // free on the target. It has the additional benefit of comparing to a 2097 // smaller constant that may be more target-friendly. 2098 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2099 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2100 DL.isLegalInteger(TypeBits - Amt)) { 2101 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2102 if (ShType->isVectorTy()) 2103 TruncTy = VectorType::get(TruncTy, ShType->getVectorNumElements()); 2104 Constant *NewC = 2105 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2106 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2107 } 2108 2109 return nullptr; 2110 } 2111 2112 /// Fold icmp ({al}shr X, Y), C. 2113 Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp, 2114 BinaryOperator *Shr, 2115 const APInt &C) { 2116 // An exact shr only shifts out zero bits, so: 2117 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2118 Value *X = Shr->getOperand(0); 2119 CmpInst::Predicate Pred = Cmp.getPredicate(); 2120 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && 2121 C.isNullValue()) 2122 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2123 2124 const APInt *ShiftVal; 2125 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2126 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2127 2128 const APInt *ShiftAmt; 2129 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2130 return nullptr; 2131 2132 // Check that the shift amount is in range. If not, don't perform undefined 2133 // shifts. When the shift is visited it will be simplified. 2134 unsigned TypeBits = C.getBitWidth(); 2135 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2136 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2137 return nullptr; 2138 2139 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2140 bool IsExact = Shr->isExact(); 2141 Type *ShrTy = Shr->getType(); 2142 // TODO: If we could guarantee that InstSimplify would handle all of the 2143 // constant-value-based preconditions in the folds below, then we could assert 2144 // those conditions rather than checking them. This is difficult because of 2145 // undef/poison (PR34838). 2146 if (IsAShr) { 2147 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) { 2148 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC) 2149 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC) 2150 APInt ShiftedC = C.shl(ShAmtVal); 2151 if (ShiftedC.ashr(ShAmtVal) == C) 2152 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2153 } 2154 if (Pred == CmpInst::ICMP_SGT) { 2155 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2156 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2157 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2158 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2159 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2160 } 2161 } else { 2162 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2163 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2164 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2165 APInt ShiftedC = C.shl(ShAmtVal); 2166 if (ShiftedC.lshr(ShAmtVal) == C) 2167 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2168 } 2169 if (Pred == CmpInst::ICMP_UGT) { 2170 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2171 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2172 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2173 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2174 } 2175 } 2176 2177 if (!Cmp.isEquality()) 2178 return nullptr; 2179 2180 // Handle equality comparisons of shift-by-constant. 2181 2182 // If the comparison constant changes with the shift, the comparison cannot 2183 // succeed (bits of the comparison constant cannot match the shifted value). 2184 // This should be known by InstSimplify and already be folded to true/false. 2185 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2186 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2187 "Expected icmp+shr simplify did not occur."); 2188 2189 // If the bits shifted out are known zero, compare the unshifted value: 2190 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2191 if (Shr->isExact()) 2192 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2193 2194 if (Shr->hasOneUse()) { 2195 // Canonicalize the shift into an 'and': 2196 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2197 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2198 Constant *Mask = ConstantInt::get(ShrTy, Val); 2199 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2200 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2201 } 2202 2203 return nullptr; 2204 } 2205 2206 /// Fold icmp (udiv X, Y), C. 2207 Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp, 2208 BinaryOperator *UDiv, 2209 const APInt &C) { 2210 const APInt *C2; 2211 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2212 return nullptr; 2213 2214 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2215 2216 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2217 Value *Y = UDiv->getOperand(1); 2218 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2219 assert(!C.isMaxValue() && 2220 "icmp ugt X, UINT_MAX should have been simplified already."); 2221 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2222 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2223 } 2224 2225 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2226 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2227 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2228 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2229 ConstantInt::get(Y->getType(), C2->udiv(C))); 2230 } 2231 2232 return nullptr; 2233 } 2234 2235 /// Fold icmp ({su}div X, Y), C. 2236 Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp, 2237 BinaryOperator *Div, 2238 const APInt &C) { 2239 // Fold: icmp pred ([us]div X, C2), C -> range test 2240 // Fold this div into the comparison, producing a range check. 2241 // Determine, based on the divide type, what the range is being 2242 // checked. If there is an overflow on the low or high side, remember 2243 // it, otherwise compute the range [low, hi) bounding the new value. 2244 // See: InsertRangeTest above for the kinds of replacements possible. 2245 const APInt *C2; 2246 if (!match(Div->getOperand(1), m_APInt(C2))) 2247 return nullptr; 2248 2249 // FIXME: If the operand types don't match the type of the divide 2250 // then don't attempt this transform. The code below doesn't have the 2251 // logic to deal with a signed divide and an unsigned compare (and 2252 // vice versa). This is because (x /s C2) <s C produces different 2253 // results than (x /s C2) <u C or (x /u C2) <s C or even 2254 // (x /u C2) <u C. Simply casting the operands and result won't 2255 // work. :( The if statement below tests that condition and bails 2256 // if it finds it. 2257 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2258 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2259 return nullptr; 2260 2261 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2262 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2263 // division-by-constant cases should be present, we can not assert that they 2264 // have happened before we reach this icmp instruction. 2265 if (C2->isNullValue() || C2->isOneValue() || 2266 (DivIsSigned && C2->isAllOnesValue())) 2267 return nullptr; 2268 2269 // Compute Prod = C * C2. We are essentially solving an equation of 2270 // form X / C2 = C. We solve for X by multiplying C2 and C. 2271 // By solving for X, we can turn this into a range check instead of computing 2272 // a divide. 2273 APInt Prod = C * *C2; 2274 2275 // Determine if the product overflows by seeing if the product is not equal to 2276 // the divide. Make sure we do the same kind of divide as in the LHS 2277 // instruction that we're folding. 2278 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2279 2280 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2281 2282 // If the division is known to be exact, then there is no remainder from the 2283 // divide, so the covered range size is unit, otherwise it is the divisor. 2284 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2285 2286 // Figure out the interval that is being checked. For example, a comparison 2287 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2288 // Compute this interval based on the constants involved and the signedness of 2289 // the compare/divide. This computes a half-open interval, keeping track of 2290 // whether either value in the interval overflows. After analysis each 2291 // overflow variable is set to 0 if it's corresponding bound variable is valid 2292 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2293 int LoOverflow = 0, HiOverflow = 0; 2294 APInt LoBound, HiBound; 2295 2296 if (!DivIsSigned) { // udiv 2297 // e.g. X/5 op 3 --> [15, 20) 2298 LoBound = Prod; 2299 HiOverflow = LoOverflow = ProdOV; 2300 if (!HiOverflow) { 2301 // If this is not an exact divide, then many values in the range collapse 2302 // to the same result value. 2303 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2304 } 2305 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2306 if (C.isNullValue()) { // (X / pos) op 0 2307 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2308 LoBound = -(RangeSize - 1); 2309 HiBound = RangeSize; 2310 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2311 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2312 HiOverflow = LoOverflow = ProdOV; 2313 if (!HiOverflow) 2314 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2315 } else { // (X / pos) op neg 2316 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2317 HiBound = Prod + 1; 2318 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2319 if (!LoOverflow) { 2320 APInt DivNeg = -RangeSize; 2321 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2322 } 2323 } 2324 } else if (C2->isNegative()) { // Divisor is < 0. 2325 if (Div->isExact()) 2326 RangeSize.negate(); 2327 if (C.isNullValue()) { // (X / neg) op 0 2328 // e.g. X/-5 op 0 --> [-4, 5) 2329 LoBound = RangeSize + 1; 2330 HiBound = -RangeSize; 2331 if (HiBound == *C2) { // -INTMIN = INTMIN 2332 HiOverflow = 1; // [INTMIN+1, overflow) 2333 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2334 } 2335 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2336 // e.g. X/-5 op 3 --> [-19, -14) 2337 HiBound = Prod + 1; 2338 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2339 if (!LoOverflow) 2340 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2341 } else { // (X / neg) op neg 2342 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2343 LoOverflow = HiOverflow = ProdOV; 2344 if (!HiOverflow) 2345 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2346 } 2347 2348 // Dividing by a negative swaps the condition. LT <-> GT 2349 Pred = ICmpInst::getSwappedPredicate(Pred); 2350 } 2351 2352 Value *X = Div->getOperand(0); 2353 switch (Pred) { 2354 default: llvm_unreachable("Unhandled icmp opcode!"); 2355 case ICmpInst::ICMP_EQ: 2356 if (LoOverflow && HiOverflow) 2357 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2358 if (HiOverflow) 2359 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2360 ICmpInst::ICMP_UGE, X, 2361 ConstantInt::get(Div->getType(), LoBound)); 2362 if (LoOverflow) 2363 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2364 ICmpInst::ICMP_ULT, X, 2365 ConstantInt::get(Div->getType(), HiBound)); 2366 return replaceInstUsesWith( 2367 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2368 case ICmpInst::ICMP_NE: 2369 if (LoOverflow && HiOverflow) 2370 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2371 if (HiOverflow) 2372 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2373 ICmpInst::ICMP_ULT, X, 2374 ConstantInt::get(Div->getType(), LoBound)); 2375 if (LoOverflow) 2376 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2377 ICmpInst::ICMP_UGE, X, 2378 ConstantInt::get(Div->getType(), HiBound)); 2379 return replaceInstUsesWith(Cmp, 2380 insertRangeTest(X, LoBound, HiBound, 2381 DivIsSigned, false)); 2382 case ICmpInst::ICMP_ULT: 2383 case ICmpInst::ICMP_SLT: 2384 if (LoOverflow == +1) // Low bound is greater than input range. 2385 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2386 if (LoOverflow == -1) // Low bound is less than input range. 2387 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2388 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2389 case ICmpInst::ICMP_UGT: 2390 case ICmpInst::ICMP_SGT: 2391 if (HiOverflow == +1) // High bound greater than input range. 2392 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2393 if (HiOverflow == -1) // High bound less than input range. 2394 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2395 if (Pred == ICmpInst::ICMP_UGT) 2396 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2397 ConstantInt::get(Div->getType(), HiBound)); 2398 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2399 ConstantInt::get(Div->getType(), HiBound)); 2400 } 2401 2402 return nullptr; 2403 } 2404 2405 /// Fold icmp (sub X, Y), C. 2406 Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp, 2407 BinaryOperator *Sub, 2408 const APInt &C) { 2409 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2410 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2411 const APInt *C2; 2412 APInt SubResult; 2413 2414 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2415 if (match(X, m_APInt(C2)) && 2416 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) || 2417 (Cmp.isSigned() && Sub->hasNoSignedWrap())) && 2418 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2419 return new ICmpInst(Cmp.getSwappedPredicate(), Y, 2420 ConstantInt::get(Y->getType(), SubResult)); 2421 2422 // The following transforms are only worth it if the only user of the subtract 2423 // is the icmp. 2424 if (!Sub->hasOneUse()) 2425 return nullptr; 2426 2427 if (Sub->hasNoSignedWrap()) { 2428 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2429 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue()) 2430 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2431 2432 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2433 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue()) 2434 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2435 2436 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2437 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue()) 2438 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2439 2440 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2441 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue()) 2442 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2443 } 2444 2445 if (!match(X, m_APInt(C2))) 2446 return nullptr; 2447 2448 // C2 - Y <u C -> (Y | (C - 1)) == C2 2449 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2450 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2451 (*C2 & (C - 1)) == (C - 1)) 2452 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2453 2454 // C2 - Y >u C -> (Y | C) != C2 2455 // iff C2 & C == C and C + 1 is a power of 2 2456 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2457 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2458 2459 return nullptr; 2460 } 2461 2462 /// Fold icmp (add X, Y), C. 2463 Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp, 2464 BinaryOperator *Add, 2465 const APInt &C) { 2466 Value *Y = Add->getOperand(1); 2467 const APInt *C2; 2468 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2469 return nullptr; 2470 2471 // Fold icmp pred (add X, C2), C. 2472 Value *X = Add->getOperand(0); 2473 Type *Ty = Add->getType(); 2474 CmpInst::Predicate Pred = Cmp.getPredicate(); 2475 2476 if (!Add->hasOneUse()) 2477 return nullptr; 2478 2479 // If the add does not wrap, we can always adjust the compare by subtracting 2480 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2481 // are canonicalized to SGT/SLT/UGT/ULT. 2482 if ((Add->hasNoSignedWrap() && 2483 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2484 (Add->hasNoUnsignedWrap() && 2485 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2486 bool Overflow; 2487 APInt NewC = 2488 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2489 // If there is overflow, the result must be true or false. 2490 // TODO: Can we assert there is no overflow because InstSimplify always 2491 // handles those cases? 2492 if (!Overflow) 2493 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2494 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2495 } 2496 2497 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2498 const APInt &Upper = CR.getUpper(); 2499 const APInt &Lower = CR.getLower(); 2500 if (Cmp.isSigned()) { 2501 if (Lower.isSignMask()) 2502 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2503 if (Upper.isSignMask()) 2504 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2505 } else { 2506 if (Lower.isMinValue()) 2507 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2508 if (Upper.isMinValue()) 2509 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2510 } 2511 2512 // X+C <u C2 -> (X & -C2) == C 2513 // iff C & (C2-1) == 0 2514 // C2 is a power of 2 2515 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2516 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2517 ConstantExpr::getNeg(cast<Constant>(Y))); 2518 2519 // X+C >u C2 -> (X & ~C2) != C 2520 // iff C & C2 == 0 2521 // C2+1 is a power of 2 2522 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2523 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2524 ConstantExpr::getNeg(cast<Constant>(Y))); 2525 2526 return nullptr; 2527 } 2528 2529 bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2530 Value *&RHS, ConstantInt *&Less, 2531 ConstantInt *&Equal, 2532 ConstantInt *&Greater) { 2533 // TODO: Generalize this to work with other comparison idioms or ensure 2534 // they get canonicalized into this form. 2535 2536 // select i1 (a == b), i32 Equal, i32 (select i1 (a < b), i32 Less, i32 2537 // Greater), where Equal, Less and Greater are placeholders for any three 2538 // constants. 2539 ICmpInst::Predicate PredA, PredB; 2540 if (match(SI->getTrueValue(), m_ConstantInt(Equal)) && 2541 match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) && 2542 PredA == ICmpInst::ICMP_EQ && 2543 match(SI->getFalseValue(), 2544 m_Select(m_ICmp(PredB, m_Specific(LHS), m_Specific(RHS)), 2545 m_ConstantInt(Less), m_ConstantInt(Greater))) && 2546 PredB == ICmpInst::ICMP_SLT) { 2547 return true; 2548 } 2549 return false; 2550 } 2551 2552 Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp, 2553 SelectInst *Select, 2554 ConstantInt *C) { 2555 2556 assert(C && "Cmp RHS should be a constant int!"); 2557 // If we're testing a constant value against the result of a three way 2558 // comparison, the result can be expressed directly in terms of the 2559 // original values being compared. Note: We could possibly be more 2560 // aggressive here and remove the hasOneUse test. The original select is 2561 // really likely to simplify or sink when we remove a test of the result. 2562 Value *OrigLHS, *OrigRHS; 2563 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2564 if (Cmp.hasOneUse() && 2565 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2566 C3GreaterThan)) { 2567 assert(C1LessThan && C2Equal && C3GreaterThan); 2568 2569 bool TrueWhenLessThan = 2570 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2571 ->isAllOnesValue(); 2572 bool TrueWhenEqual = 2573 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2574 ->isAllOnesValue(); 2575 bool TrueWhenGreaterThan = 2576 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2577 ->isAllOnesValue(); 2578 2579 // This generates the new instruction that will replace the original Cmp 2580 // Instruction. Instead of enumerating the various combinations when 2581 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2582 // false, we rely on chaining of ORs and future passes of InstCombine to 2583 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2584 2585 // When none of the three constants satisfy the predicate for the RHS (C), 2586 // the entire original Cmp can be simplified to a false. 2587 Value *Cond = Builder.getFalse(); 2588 if (TrueWhenLessThan) 2589 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2590 OrigLHS, OrigRHS)); 2591 if (TrueWhenEqual) 2592 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2593 OrigLHS, OrigRHS)); 2594 if (TrueWhenGreaterThan) 2595 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2596 OrigLHS, OrigRHS)); 2597 2598 return replaceInstUsesWith(Cmp, Cond); 2599 } 2600 return nullptr; 2601 } 2602 2603 static Instruction *foldICmpBitCast(ICmpInst &Cmp, 2604 InstCombiner::BuilderTy &Builder) { 2605 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2606 if (!Bitcast) 2607 return nullptr; 2608 2609 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2610 Value *Op1 = Cmp.getOperand(1); 2611 Value *BCSrcOp = Bitcast->getOperand(0); 2612 2613 // Make sure the bitcast doesn't change the number of vector elements. 2614 if (Bitcast->getSrcTy()->getScalarSizeInBits() == 2615 Bitcast->getDestTy()->getScalarSizeInBits()) { 2616 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2617 Value *X; 2618 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2619 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2620 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2621 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2622 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2623 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2624 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2625 match(Op1, m_Zero())) 2626 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2627 2628 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2629 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2630 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2631 2632 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2633 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2634 return new ICmpInst(Pred, X, 2635 ConstantInt::getAllOnesValue(X->getType())); 2636 } 2637 2638 // Zero-equality checks are preserved through unsigned floating-point casts: 2639 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2640 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2641 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2642 if (Cmp.isEquality() && match(Op1, m_Zero())) 2643 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2644 } 2645 2646 // Test to see if the operands of the icmp are casted versions of other 2647 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2648 if (Bitcast->getType()->isPointerTy() && 2649 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2650 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2651 // so eliminate it as well. 2652 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2653 Op1 = BC2->getOperand(0); 2654 2655 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType()); 2656 return new ICmpInst(Pred, BCSrcOp, Op1); 2657 } 2658 2659 // Folding: icmp <pred> iN X, C 2660 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 2661 // and C is a splat of a K-bit pattern 2662 // and SC is a constant vector = <C', C', C', ..., C'> 2663 // Into: 2664 // %E = extractelement <M x iK> %vec, i32 C' 2665 // icmp <pred> iK %E, trunc(C) 2666 const APInt *C; 2667 if (!match(Cmp.getOperand(1), m_APInt(C)) || 2668 !Bitcast->getType()->isIntegerTy() || 2669 !Bitcast->getSrcTy()->isIntOrIntVectorTy()) 2670 return nullptr; 2671 2672 Value *Vec; 2673 Constant *Mask; 2674 if (match(BCSrcOp, 2675 m_ShuffleVector(m_Value(Vec), m_Undef(), m_Constant(Mask)))) { 2676 // Check whether every element of Mask is the same constant 2677 if (auto *Elem = dyn_cast_or_null<ConstantInt>(Mask->getSplatValue())) { 2678 auto *VecTy = cast<VectorType>(BCSrcOp->getType()); 2679 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 2680 if (C->isSplat(EltTy->getBitWidth())) { 2681 // Fold the icmp based on the value of C 2682 // If C is M copies of an iK sized bit pattern, 2683 // then: 2684 // => %E = extractelement <N x iK> %vec, i32 Elem 2685 // icmp <pred> iK %SplatVal, <pattern> 2686 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 2687 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 2688 return new ICmpInst(Pred, Extract, NewC); 2689 } 2690 } 2691 } 2692 return nullptr; 2693 } 2694 2695 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2696 /// where X is some kind of instruction. 2697 Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) { 2698 const APInt *C; 2699 if (!match(Cmp.getOperand(1), m_APInt(C))) 2700 return nullptr; 2701 2702 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 2703 switch (BO->getOpcode()) { 2704 case Instruction::Xor: 2705 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C)) 2706 return I; 2707 break; 2708 case Instruction::And: 2709 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C)) 2710 return I; 2711 break; 2712 case Instruction::Or: 2713 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C)) 2714 return I; 2715 break; 2716 case Instruction::Mul: 2717 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C)) 2718 return I; 2719 break; 2720 case Instruction::Shl: 2721 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C)) 2722 return I; 2723 break; 2724 case Instruction::LShr: 2725 case Instruction::AShr: 2726 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C)) 2727 return I; 2728 break; 2729 case Instruction::UDiv: 2730 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C)) 2731 return I; 2732 LLVM_FALLTHROUGH; 2733 case Instruction::SDiv: 2734 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C)) 2735 return I; 2736 break; 2737 case Instruction::Sub: 2738 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C)) 2739 return I; 2740 break; 2741 case Instruction::Add: 2742 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C)) 2743 return I; 2744 break; 2745 default: 2746 break; 2747 } 2748 // TODO: These folds could be refactored to be part of the above calls. 2749 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C)) 2750 return I; 2751 } 2752 2753 // Match against CmpInst LHS being instructions other than binary operators. 2754 2755 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 2756 // For now, we only support constant integers while folding the 2757 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 2758 // similar to the cases handled by binary ops above. 2759 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 2760 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 2761 return I; 2762 } 2763 2764 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 2765 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 2766 return I; 2767 } 2768 2769 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 2770 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 2771 return I; 2772 2773 return nullptr; 2774 } 2775 2776 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 2777 /// icmp eq/ne BO, C. 2778 Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp, 2779 BinaryOperator *BO, 2780 const APInt &C) { 2781 // TODO: Some of these folds could work with arbitrary constants, but this 2782 // function is limited to scalar and vector splat constants. 2783 if (!Cmp.isEquality()) 2784 return nullptr; 2785 2786 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2787 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 2788 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 2789 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 2790 2791 switch (BO->getOpcode()) { 2792 case Instruction::SRem: 2793 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 2794 if (C.isNullValue() && BO->hasOneUse()) { 2795 const APInt *BOC; 2796 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 2797 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 2798 return new ICmpInst(Pred, NewRem, 2799 Constant::getNullValue(BO->getType())); 2800 } 2801 } 2802 break; 2803 case Instruction::Add: { 2804 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 2805 const APInt *BOC; 2806 if (match(BOp1, m_APInt(BOC))) { 2807 if (BO->hasOneUse()) { 2808 Constant *SubC = ConstantExpr::getSub(RHS, cast<Constant>(BOp1)); 2809 return new ICmpInst(Pred, BOp0, SubC); 2810 } 2811 } else if (C.isNullValue()) { 2812 // Replace ((add A, B) != 0) with (A != -B) if A or B is 2813 // efficiently invertible, or if the add has just this one use. 2814 if (Value *NegVal = dyn_castNegVal(BOp1)) 2815 return new ICmpInst(Pred, BOp0, NegVal); 2816 if (Value *NegVal = dyn_castNegVal(BOp0)) 2817 return new ICmpInst(Pred, NegVal, BOp1); 2818 if (BO->hasOneUse()) { 2819 Value *Neg = Builder.CreateNeg(BOp1); 2820 Neg->takeName(BO); 2821 return new ICmpInst(Pred, BOp0, Neg); 2822 } 2823 } 2824 break; 2825 } 2826 case Instruction::Xor: 2827 if (BO->hasOneUse()) { 2828 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2829 // For the xor case, we can xor two constants together, eliminating 2830 // the explicit xor. 2831 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 2832 } else if (C.isNullValue()) { 2833 // Replace ((xor A, B) != 0) with (A != B) 2834 return new ICmpInst(Pred, BOp0, BOp1); 2835 } 2836 } 2837 break; 2838 case Instruction::Sub: 2839 if (BO->hasOneUse()) { 2840 const APInt *BOC; 2841 if (match(BOp0, m_APInt(BOC))) { 2842 // Replace ((sub BOC, B) != C) with (B != BOC-C). 2843 Constant *SubC = ConstantExpr::getSub(cast<Constant>(BOp0), RHS); 2844 return new ICmpInst(Pred, BOp1, SubC); 2845 } else if (C.isNullValue()) { 2846 // Replace ((sub A, B) != 0) with (A != B). 2847 return new ICmpInst(Pred, BOp0, BOp1); 2848 } 2849 } 2850 break; 2851 case Instruction::Or: { 2852 const APInt *BOC; 2853 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 2854 // Comparing if all bits outside of a constant mask are set? 2855 // Replace (X | C) == -1 with (X & ~C) == ~C. 2856 // This removes the -1 constant. 2857 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 2858 Value *And = Builder.CreateAnd(BOp0, NotBOC); 2859 return new ICmpInst(Pred, And, NotBOC); 2860 } 2861 break; 2862 } 2863 case Instruction::And: { 2864 const APInt *BOC; 2865 if (match(BOp1, m_APInt(BOC))) { 2866 // If we have ((X & C) == C), turn it into ((X & C) != 0). 2867 if (C == *BOC && C.isPowerOf2()) 2868 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 2869 BO, Constant::getNullValue(RHS->getType())); 2870 } 2871 break; 2872 } 2873 case Instruction::Mul: 2874 if (C.isNullValue() && BO->hasNoSignedWrap()) { 2875 const APInt *BOC; 2876 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) { 2877 // The trivial case (mul X, 0) is handled by InstSimplify. 2878 // General case : (mul X, C) != 0 iff X != 0 2879 // (mul X, C) == 0 iff X == 0 2880 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType())); 2881 } 2882 } 2883 break; 2884 case Instruction::UDiv: 2885 if (C.isNullValue()) { 2886 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 2887 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 2888 return new ICmpInst(NewPred, BOp1, BOp0); 2889 } 2890 break; 2891 default: 2892 break; 2893 } 2894 return nullptr; 2895 } 2896 2897 /// Fold an equality icmp with LLVM intrinsic and constant operand. 2898 Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp, 2899 IntrinsicInst *II, 2900 const APInt &C) { 2901 Type *Ty = II->getType(); 2902 unsigned BitWidth = C.getBitWidth(); 2903 switch (II->getIntrinsicID()) { 2904 case Intrinsic::bswap: 2905 Worklist.Add(II); 2906 Cmp.setOperand(0, II->getArgOperand(0)); 2907 Cmp.setOperand(1, ConstantInt::get(Ty, C.byteSwap())); 2908 return &Cmp; 2909 2910 case Intrinsic::ctlz: 2911 case Intrinsic::cttz: { 2912 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 2913 if (C == BitWidth) { 2914 Worklist.Add(II); 2915 Cmp.setOperand(0, II->getArgOperand(0)); 2916 Cmp.setOperand(1, ConstantInt::getNullValue(Ty)); 2917 return &Cmp; 2918 } 2919 2920 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 2921 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 2922 // Limit to one use to ensure we don't increase instruction count. 2923 unsigned Num = C.getLimitedValue(BitWidth); 2924 if (Num != BitWidth && II->hasOneUse()) { 2925 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 2926 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 2927 : APInt::getHighBitsSet(BitWidth, Num + 1); 2928 APInt Mask2 = IsTrailing 2929 ? APInt::getOneBitSet(BitWidth, Num) 2930 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 2931 Cmp.setOperand(0, Builder.CreateAnd(II->getArgOperand(0), Mask1)); 2932 Cmp.setOperand(1, ConstantInt::get(Ty, Mask2)); 2933 Worklist.Add(II); 2934 return &Cmp; 2935 } 2936 break; 2937 } 2938 2939 case Intrinsic::ctpop: { 2940 // popcount(A) == 0 -> A == 0 and likewise for != 2941 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 2942 bool IsZero = C.isNullValue(); 2943 if (IsZero || C == BitWidth) { 2944 Worklist.Add(II); 2945 Cmp.setOperand(0, II->getArgOperand(0)); 2946 auto *NewOp = 2947 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty); 2948 Cmp.setOperand(1, NewOp); 2949 return &Cmp; 2950 } 2951 break; 2952 } 2953 default: 2954 break; 2955 } 2956 2957 return nullptr; 2958 } 2959 2960 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 2961 Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 2962 IntrinsicInst *II, 2963 const APInt &C) { 2964 if (Cmp.isEquality()) 2965 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 2966 2967 Type *Ty = II->getType(); 2968 unsigned BitWidth = C.getBitWidth(); 2969 switch (II->getIntrinsicID()) { 2970 case Intrinsic::ctlz: { 2971 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 2972 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 2973 unsigned Num = C.getLimitedValue(); 2974 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 2975 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 2976 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 2977 } 2978 2979 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 2980 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && 2981 C.uge(1) && C.ule(BitWidth)) { 2982 unsigned Num = C.getLimitedValue(); 2983 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 2984 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 2985 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 2986 } 2987 break; 2988 } 2989 case Intrinsic::cttz: { 2990 // Limit to one use to ensure we don't increase instruction count. 2991 if (!II->hasOneUse()) 2992 return nullptr; 2993 2994 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 2995 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 2996 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 2997 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 2998 Builder.CreateAnd(II->getArgOperand(0), Mask), 2999 ConstantInt::getNullValue(Ty)); 3000 } 3001 3002 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3003 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && 3004 C.uge(1) && C.ule(BitWidth)) { 3005 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3006 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3007 Builder.CreateAnd(II->getArgOperand(0), Mask), 3008 ConstantInt::getNullValue(Ty)); 3009 } 3010 break; 3011 } 3012 default: 3013 break; 3014 } 3015 3016 return nullptr; 3017 } 3018 3019 /// Handle icmp with constant (but not simple integer constant) RHS. 3020 Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3021 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3022 Constant *RHSC = dyn_cast<Constant>(Op1); 3023 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3024 if (!RHSC || !LHSI) 3025 return nullptr; 3026 3027 switch (LHSI->getOpcode()) { 3028 case Instruction::GetElementPtr: 3029 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3030 if (RHSC->isNullValue() && 3031 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3032 return new ICmpInst( 3033 I.getPredicate(), LHSI->getOperand(0), 3034 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3035 break; 3036 case Instruction::PHI: 3037 // Only fold icmp into the PHI if the phi and icmp are in the same 3038 // block. If in the same block, we're encouraging jump threading. If 3039 // not, we are just pessimizing the code by making an i1 phi. 3040 if (LHSI->getParent() == I.getParent()) 3041 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3042 return NV; 3043 break; 3044 case Instruction::Select: { 3045 // If either operand of the select is a constant, we can fold the 3046 // comparison into the select arms, which will cause one to be 3047 // constant folded and the select turned into a bitwise or. 3048 Value *Op1 = nullptr, *Op2 = nullptr; 3049 ConstantInt *CI = nullptr; 3050 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) { 3051 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3052 CI = dyn_cast<ConstantInt>(Op1); 3053 } 3054 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) { 3055 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3056 CI = dyn_cast<ConstantInt>(Op2); 3057 } 3058 3059 // We only want to perform this transformation if it will not lead to 3060 // additional code. This is true if either both sides of the select 3061 // fold to a constant (in which case the icmp is replaced with a select 3062 // which will usually simplify) or this is the only user of the 3063 // select (in which case we are trading a select+icmp for a simpler 3064 // select+icmp) or all uses of the select can be replaced based on 3065 // dominance information ("Global cases"). 3066 bool Transform = false; 3067 if (Op1 && Op2) 3068 Transform = true; 3069 else if (Op1 || Op2) { 3070 // Local case 3071 if (LHSI->hasOneUse()) 3072 Transform = true; 3073 // Global cases 3074 else if (CI && !CI->isZero()) 3075 // When Op1 is constant try replacing select with second operand. 3076 // Otherwise Op2 is constant and try replacing select with first 3077 // operand. 3078 Transform = 3079 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 3080 } 3081 if (Transform) { 3082 if (!Op1) 3083 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 3084 I.getName()); 3085 if (!Op2) 3086 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 3087 I.getName()); 3088 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 3089 } 3090 break; 3091 } 3092 case Instruction::IntToPtr: 3093 // icmp pred inttoptr(X), null -> icmp pred X, 0 3094 if (RHSC->isNullValue() && 3095 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3096 return new ICmpInst( 3097 I.getPredicate(), LHSI->getOperand(0), 3098 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3099 break; 3100 3101 case Instruction::Load: 3102 // Try to optimize things like "A[i] > 4" to index computations. 3103 if (GetElementPtrInst *GEP = 3104 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 3105 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3106 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 3107 !cast<LoadInst>(LHSI)->isVolatile()) 3108 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 3109 return Res; 3110 } 3111 break; 3112 } 3113 3114 return nullptr; 3115 } 3116 3117 /// Some comparisons can be simplified. 3118 /// In this case, we are looking for comparisons that look like 3119 /// a check for a lossy truncation. 3120 /// Folds: 3121 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3122 /// Where Mask is some pattern that produces all-ones in low bits: 3123 /// (-1 >> y) 3124 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3125 /// ~(-1 << y) 3126 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3127 /// The Mask can be a constant, too. 3128 /// For some predicates, the operands are commutative. 3129 /// For others, x can only be on a specific side. 3130 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3131 InstCombiner::BuilderTy &Builder) { 3132 ICmpInst::Predicate SrcPred; 3133 Value *X, *M, *Y; 3134 auto m_VariableMask = m_CombineOr( 3135 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3136 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3137 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3138 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3139 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3140 if (!match(&I, m_c_ICmp(SrcPred, 3141 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3142 m_Deferred(X)))) 3143 return nullptr; 3144 3145 ICmpInst::Predicate DstPred; 3146 switch (SrcPred) { 3147 case ICmpInst::Predicate::ICMP_EQ: 3148 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3149 DstPred = ICmpInst::Predicate::ICMP_ULE; 3150 break; 3151 case ICmpInst::Predicate::ICMP_NE: 3152 // x & (-1 >> y) != x -> x u> (-1 >> y) 3153 DstPred = ICmpInst::Predicate::ICMP_UGT; 3154 break; 3155 case ICmpInst::Predicate::ICMP_UGT: 3156 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3157 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant"); 3158 DstPred = ICmpInst::Predicate::ICMP_UGT; 3159 break; 3160 case ICmpInst::Predicate::ICMP_UGE: 3161 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3162 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant"); 3163 DstPred = ICmpInst::Predicate::ICMP_ULE; 3164 break; 3165 case ICmpInst::Predicate::ICMP_ULT: 3166 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3167 assert(X == I.getOperand(1) && "instsimplify took care of commut. variant"); 3168 DstPred = ICmpInst::Predicate::ICMP_UGT; 3169 break; 3170 case ICmpInst::Predicate::ICMP_ULE: 3171 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3172 assert(X == I.getOperand(0) && "instsimplify took care of commut. variant"); 3173 DstPred = ICmpInst::Predicate::ICMP_ULE; 3174 break; 3175 case ICmpInst::Predicate::ICMP_SGT: 3176 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3177 if (X != I.getOperand(0)) // X must be on LHS of comparison! 3178 return nullptr; // Ignore the other case. 3179 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3180 return nullptr; 3181 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3182 return nullptr; 3183 DstPred = ICmpInst::Predicate::ICMP_SGT; 3184 break; 3185 case ICmpInst::Predicate::ICMP_SGE: 3186 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3187 if (X != I.getOperand(1)) // X must be on RHS of comparison! 3188 return nullptr; // Ignore the other case. 3189 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3190 return nullptr; 3191 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3192 return nullptr; 3193 DstPred = ICmpInst::Predicate::ICMP_SLE; 3194 break; 3195 case ICmpInst::Predicate::ICMP_SLT: 3196 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3197 if (X != I.getOperand(1)) // X must be on RHS of comparison! 3198 return nullptr; // Ignore the other case. 3199 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3200 return nullptr; 3201 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3202 return nullptr; 3203 DstPred = ICmpInst::Predicate::ICMP_SGT; 3204 break; 3205 case ICmpInst::Predicate::ICMP_SLE: 3206 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3207 if (X != I.getOperand(0)) // X must be on LHS of comparison! 3208 return nullptr; // Ignore the other case. 3209 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3210 return nullptr; 3211 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3212 return nullptr; 3213 DstPred = ICmpInst::Predicate::ICMP_SLE; 3214 break; 3215 default: 3216 llvm_unreachable("All possible folds are handled."); 3217 } 3218 3219 return Builder.CreateICmp(DstPred, X, M); 3220 } 3221 3222 /// Some comparisons can be simplified. 3223 /// In this case, we are looking for comparisons that look like 3224 /// a check for a lossy signed truncation. 3225 /// Folds: (MaskedBits is a constant.) 3226 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3227 /// Into: 3228 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3229 /// Where KeptBits = bitwidth(%x) - MaskedBits 3230 static Value * 3231 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3232 InstCombiner::BuilderTy &Builder) { 3233 ICmpInst::Predicate SrcPred; 3234 Value *X; 3235 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3236 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3237 if (!match(&I, m_c_ICmp(SrcPred, 3238 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3239 m_APInt(C1))), 3240 m_Deferred(X)))) 3241 return nullptr; 3242 3243 // Potential handling of non-splats: for each element: 3244 // * if both are undef, replace with constant 0. 3245 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3246 // * if both are not undef, and are different, bailout. 3247 // * else, only one is undef, then pick the non-undef one. 3248 3249 // The shift amount must be equal. 3250 if (*C0 != *C1) 3251 return nullptr; 3252 const APInt &MaskedBits = *C0; 3253 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3254 3255 ICmpInst::Predicate DstPred; 3256 switch (SrcPred) { 3257 case ICmpInst::Predicate::ICMP_EQ: 3258 // ((%x << MaskedBits) a>> MaskedBits) == %x 3259 // => 3260 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3261 DstPred = ICmpInst::Predicate::ICMP_ULT; 3262 break; 3263 case ICmpInst::Predicate::ICMP_NE: 3264 // ((%x << MaskedBits) a>> MaskedBits) != %x 3265 // => 3266 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3267 DstPred = ICmpInst::Predicate::ICMP_UGE; 3268 break; 3269 // FIXME: are more folds possible? 3270 default: 3271 return nullptr; 3272 } 3273 3274 auto *XType = X->getType(); 3275 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3276 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3277 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3278 3279 // KeptBits = bitwidth(%x) - MaskedBits 3280 const APInt KeptBits = BitWidth - MaskedBits; 3281 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3282 // ICmpCst = (1 << KeptBits) 3283 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3284 assert(ICmpCst.isPowerOf2()); 3285 // AddCst = (1 << (KeptBits-1)) 3286 const APInt AddCst = ICmpCst.lshr(1); 3287 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3288 3289 // T0 = add %x, AddCst 3290 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3291 // T1 = T0 DstPred ICmpCst 3292 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3293 3294 return T1; 3295 } 3296 3297 // Given pattern: 3298 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3299 // we should move shifts to the same hand of 'and', i.e. rewrite as 3300 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3301 // We are only interested in opposite logical shifts here. 3302 // One of the shifts can be truncated. For now, it can only be 'shl'. 3303 // If we can, we want to end up creating 'lshr' shift. 3304 static Value * 3305 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3306 InstCombiner::BuilderTy &Builder) { 3307 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3308 !I.getOperand(0)->hasOneUse()) 3309 return nullptr; 3310 3311 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3312 3313 // Look for an 'and' of two logical shifts, one of which may be truncated. 3314 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3315 Instruction *XShift, *MaybeTruncation, *YShift; 3316 if (!match( 3317 I.getOperand(0), 3318 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3319 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3320 m_AnyLogicalShift, m_Instruction(YShift))), 3321 m_Instruction(MaybeTruncation))))) 3322 return nullptr; 3323 3324 // We potentially looked past 'trunc', but only when matching YShift, 3325 // therefore YShift must have the widest type. 3326 Instruction *WidestShift = YShift; 3327 // Therefore XShift must have the shallowest type. 3328 // Or they both have identical types if there was no truncation. 3329 Instruction *NarrowestShift = XShift; 3330 3331 Type *WidestTy = WidestShift->getType(); 3332 assert(NarrowestShift->getType() == I.getOperand(0)->getType() && 3333 "We did not look past any shifts while matching XShift though."); 3334 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3335 3336 if (HadTrunc) { 3337 // We did indeed have a truncation. For now, let's only proceed if the 'shl' 3338 // was truncated, since that does not require any extra legality checks. 3339 // FIXME: trunc-of-lshr. 3340 if (!match(YShift, m_Shl(m_Value(), m_Value()))) 3341 return nullptr; 3342 } 3343 3344 // If YShift is a 'lshr', swap the shifts around. 3345 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3346 std::swap(XShift, YShift); 3347 3348 // The shifts must be in opposite directions. 3349 auto XShiftOpcode = XShift->getOpcode(); 3350 if (XShiftOpcode == YShift->getOpcode()) 3351 return nullptr; // Do not care about same-direction shifts here. 3352 3353 Value *X, *XShAmt, *Y, *YShAmt; 3354 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3355 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3356 3357 // If one of the values being shifted is a constant, then we will end with 3358 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3359 // however, we will need to ensure that we won't increase instruction count. 3360 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3361 // At least one of the hands of the 'and' should be one-use shift. 3362 if (!match(I.getOperand(0), 3363 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3364 return nullptr; 3365 if (HadTrunc) { 3366 // Due to the 'trunc', we will need to widen X. For that either the old 3367 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3368 if (!MaybeTruncation->hasOneUse() && 3369 !NarrowestShift->getOperand(1)->hasOneUse()) 3370 return nullptr; 3371 } 3372 } 3373 3374 // We have two shift amounts from two different shifts. The types of those 3375 // shift amounts may not match. If that's the case let's bailout now. 3376 if (XShAmt->getType() != YShAmt->getType()) 3377 return nullptr; 3378 3379 // Can we fold (XShAmt+YShAmt) ? 3380 auto *NewShAmt = dyn_cast_or_null<Constant>( 3381 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3382 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3383 if (!NewShAmt) 3384 return nullptr; 3385 // Is the new shift amount smaller than the bit width? 3386 // FIXME: could also rely on ConstantRange. 3387 if (!match(NewShAmt, m_SpecificInt_ICMP( 3388 ICmpInst::Predicate::ICMP_ULT, 3389 APInt(NewShAmt->getType()->getScalarSizeInBits(), 3390 WidestTy->getScalarSizeInBits())))) 3391 return nullptr; 3392 // All good, we can do this fold. 3393 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3394 X = Builder.CreateZExt(X, WidestTy); 3395 // The shift is the same that was for X. 3396 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3397 ? Builder.CreateLShr(X, NewShAmt) 3398 : Builder.CreateShl(X, NewShAmt); 3399 Value *T1 = Builder.CreateAnd(T0, Y); 3400 return Builder.CreateICmp(I.getPredicate(), T1, 3401 Constant::getNullValue(WidestTy)); 3402 } 3403 3404 /// Try to fold icmp (binop), X or icmp X, (binop). 3405 /// TODO: A large part of this logic is duplicated in InstSimplify's 3406 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3407 /// duplication. 3408 Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I) { 3409 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3410 3411 // Special logic for binary operators. 3412 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3413 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3414 if (!BO0 && !BO1) 3415 return nullptr; 3416 3417 const CmpInst::Predicate Pred = I.getPredicate(); 3418 Value *X; 3419 3420 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 3421 // (Op1 + X) <u Op1 --> ~Op1 <u X 3422 // Op0 >u (Op0 + X) --> X >u ~Op0 3423 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 3424 Pred == ICmpInst::ICMP_ULT) 3425 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 3426 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 3427 Pred == ICmpInst::ICMP_UGT) 3428 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 3429 3430 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 3431 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 3432 NoOp0WrapProblem = 3433 ICmpInst::isEquality(Pred) || 3434 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 3435 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 3436 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 3437 NoOp1WrapProblem = 3438 ICmpInst::isEquality(Pred) || 3439 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 3440 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 3441 3442 // Analyze the case when either Op0 or Op1 is an add instruction. 3443 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 3444 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 3445 if (BO0 && BO0->getOpcode() == Instruction::Add) { 3446 A = BO0->getOperand(0); 3447 B = BO0->getOperand(1); 3448 } 3449 if (BO1 && BO1->getOpcode() == Instruction::Add) { 3450 C = BO1->getOperand(0); 3451 D = BO1->getOperand(1); 3452 } 3453 3454 // icmp (X+Y), X -> icmp Y, 0 for equalities or if there is no overflow. 3455 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 3456 return new ICmpInst(Pred, A == Op1 ? B : A, 3457 Constant::getNullValue(Op1->getType())); 3458 3459 // icmp X, (X+Y) -> icmp 0, Y for equalities or if there is no overflow. 3460 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 3461 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 3462 C == Op0 ? D : C); 3463 3464 // icmp (X+Y), (X+Z) -> icmp Y, Z for equalities or if there is no overflow. 3465 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 3466 NoOp1WrapProblem && 3467 // Try not to increase register pressure. 3468 BO0->hasOneUse() && BO1->hasOneUse()) { 3469 // Determine Y and Z in the form icmp (X+Y), (X+Z). 3470 Value *Y, *Z; 3471 if (A == C) { 3472 // C + B == C + D -> B == D 3473 Y = B; 3474 Z = D; 3475 } else if (A == D) { 3476 // D + B == C + D -> B == C 3477 Y = B; 3478 Z = C; 3479 } else if (B == C) { 3480 // A + C == C + D -> A == D 3481 Y = A; 3482 Z = D; 3483 } else { 3484 assert(B == D); 3485 // A + D == C + D -> A == C 3486 Y = A; 3487 Z = C; 3488 } 3489 return new ICmpInst(Pred, Y, Z); 3490 } 3491 3492 // icmp slt (X + -1), Y -> icmp sle X, Y 3493 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 3494 match(B, m_AllOnes())) 3495 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 3496 3497 // icmp sge (X + -1), Y -> icmp sgt X, Y 3498 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 3499 match(B, m_AllOnes())) 3500 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 3501 3502 // icmp sle (X + 1), Y -> icmp slt X, Y 3503 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 3504 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 3505 3506 // icmp sgt (X + 1), Y -> icmp sge X, Y 3507 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 3508 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 3509 3510 // icmp sgt X, (Y + -1) -> icmp sge X, Y 3511 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 3512 match(D, m_AllOnes())) 3513 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 3514 3515 // icmp sle X, (Y + -1) -> icmp slt X, Y 3516 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 3517 match(D, m_AllOnes())) 3518 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 3519 3520 // icmp sge X, (Y + 1) -> icmp sgt X, Y 3521 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 3522 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 3523 3524 // icmp slt X, (Y + 1) -> icmp sle X, Y 3525 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 3526 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 3527 3528 // TODO: The subtraction-related identities shown below also hold, but 3529 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 3530 // wouldn't happen even if they were implemented. 3531 // 3532 // icmp ult (X - 1), Y -> icmp ule X, Y 3533 // icmp uge (X - 1), Y -> icmp ugt X, Y 3534 // icmp ugt X, (Y - 1) -> icmp uge X, Y 3535 // icmp ule X, (Y - 1) -> icmp ult X, Y 3536 3537 // icmp ule (X + 1), Y -> icmp ult X, Y 3538 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 3539 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 3540 3541 // icmp ugt (X + 1), Y -> icmp uge X, Y 3542 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 3543 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 3544 3545 // icmp uge X, (Y + 1) -> icmp ugt X, Y 3546 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 3547 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 3548 3549 // icmp ult X, (Y + 1) -> icmp ule X, Y 3550 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 3551 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 3552 3553 // if C1 has greater magnitude than C2: 3554 // icmp (X + C1), (Y + C2) -> icmp (X + C3), Y 3555 // s.t. C3 = C1 - C2 3556 // 3557 // if C2 has greater magnitude than C1: 3558 // icmp (X + C1), (Y + C2) -> icmp X, (Y + C3) 3559 // s.t. C3 = C2 - C1 3560 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 3561 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 3562 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 3563 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 3564 const APInt &AP1 = C1->getValue(); 3565 const APInt &AP2 = C2->getValue(); 3566 if (AP1.isNegative() == AP2.isNegative()) { 3567 APInt AP1Abs = C1->getValue().abs(); 3568 APInt AP2Abs = C2->getValue().abs(); 3569 if (AP1Abs.uge(AP2Abs)) { 3570 ConstantInt *C3 = Builder.getInt(AP1 - AP2); 3571 Value *NewAdd = Builder.CreateNSWAdd(A, C3); 3572 return new ICmpInst(Pred, NewAdd, C); 3573 } else { 3574 ConstantInt *C3 = Builder.getInt(AP2 - AP1); 3575 Value *NewAdd = Builder.CreateNSWAdd(C, C3); 3576 return new ICmpInst(Pred, A, NewAdd); 3577 } 3578 } 3579 } 3580 3581 // Analyze the case when either Op0 or Op1 is a sub instruction. 3582 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 3583 A = nullptr; 3584 B = nullptr; 3585 C = nullptr; 3586 D = nullptr; 3587 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 3588 A = BO0->getOperand(0); 3589 B = BO0->getOperand(1); 3590 } 3591 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 3592 C = BO1->getOperand(0); 3593 D = BO1->getOperand(1); 3594 } 3595 3596 // icmp (X-Y), X -> icmp 0, Y for equalities or if there is no overflow. 3597 if (A == Op1 && NoOp0WrapProblem) 3598 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 3599 // icmp X, (X-Y) -> icmp Y, 0 for equalities or if there is no overflow. 3600 if (C == Op0 && NoOp1WrapProblem) 3601 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 3602 3603 // (A - B) >u A --> A <u B 3604 if (A == Op1 && Pred == ICmpInst::ICMP_UGT) 3605 return new ICmpInst(ICmpInst::ICMP_ULT, A, B); 3606 // C <u (C - D) --> C <u D 3607 if (C == Op0 && Pred == ICmpInst::ICMP_ULT) 3608 return new ICmpInst(ICmpInst::ICMP_ULT, C, D); 3609 3610 // icmp (Y-X), (Z-X) -> icmp Y, Z for equalities or if there is no overflow. 3611 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem && 3612 // Try not to increase register pressure. 3613 BO0->hasOneUse() && BO1->hasOneUse()) 3614 return new ICmpInst(Pred, A, C); 3615 // icmp (X-Y), (X-Z) -> icmp Z, Y for equalities or if there is no overflow. 3616 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem && 3617 // Try not to increase register pressure. 3618 BO0->hasOneUse() && BO1->hasOneUse()) 3619 return new ICmpInst(Pred, D, B); 3620 3621 // icmp (0-X) < cst --> x > -cst 3622 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 3623 Value *X; 3624 if (match(BO0, m_Neg(m_Value(X)))) 3625 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 3626 if (RHSC->isNotMinSignedValue()) 3627 return new ICmpInst(I.getSwappedPredicate(), X, 3628 ConstantExpr::getNeg(RHSC)); 3629 } 3630 3631 BinaryOperator *SRem = nullptr; 3632 // icmp (srem X, Y), Y 3633 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 3634 SRem = BO0; 3635 // icmp Y, (srem X, Y) 3636 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 3637 Op0 == BO1->getOperand(1)) 3638 SRem = BO1; 3639 if (SRem) { 3640 // We don't check hasOneUse to avoid increasing register pressure because 3641 // the value we use is the same value this instruction was already using. 3642 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 3643 default: 3644 break; 3645 case ICmpInst::ICMP_EQ: 3646 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3647 case ICmpInst::ICMP_NE: 3648 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3649 case ICmpInst::ICMP_SGT: 3650 case ICmpInst::ICMP_SGE: 3651 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 3652 Constant::getAllOnesValue(SRem->getType())); 3653 case ICmpInst::ICMP_SLT: 3654 case ICmpInst::ICMP_SLE: 3655 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 3656 Constant::getNullValue(SRem->getType())); 3657 } 3658 } 3659 3660 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 3661 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 3662 switch (BO0->getOpcode()) { 3663 default: 3664 break; 3665 case Instruction::Add: 3666 case Instruction::Sub: 3667 case Instruction::Xor: { 3668 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 3669 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3670 3671 const APInt *C; 3672 if (match(BO0->getOperand(1), m_APInt(C))) { 3673 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 3674 if (C->isSignMask()) { 3675 ICmpInst::Predicate NewPred = 3676 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3677 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3678 } 3679 3680 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 3681 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 3682 ICmpInst::Predicate NewPred = 3683 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3684 NewPred = I.getSwappedPredicate(NewPred); 3685 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3686 } 3687 } 3688 break; 3689 } 3690 case Instruction::Mul: { 3691 if (!I.isEquality()) 3692 break; 3693 3694 const APInt *C; 3695 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() && 3696 !C->isOneValue()) { 3697 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 3698 // Mask = -1 >> count-trailing-zeros(C). 3699 if (unsigned TZs = C->countTrailingZeros()) { 3700 Constant *Mask = ConstantInt::get( 3701 BO0->getType(), 3702 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 3703 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 3704 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 3705 return new ICmpInst(Pred, And1, And2); 3706 } 3707 // If there are no trailing zeros in the multiplier, just eliminate 3708 // the multiplies (no masking is needed): 3709 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y 3710 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3711 } 3712 break; 3713 } 3714 case Instruction::UDiv: 3715 case Instruction::LShr: 3716 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 3717 break; 3718 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3719 3720 case Instruction::SDiv: 3721 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 3722 break; 3723 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3724 3725 case Instruction::AShr: 3726 if (!BO0->isExact() || !BO1->isExact()) 3727 break; 3728 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3729 3730 case Instruction::Shl: { 3731 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 3732 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 3733 if (!NUW && !NSW) 3734 break; 3735 if (!NSW && I.isSigned()) 3736 break; 3737 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3738 } 3739 } 3740 } 3741 3742 if (BO0) { 3743 // Transform A & (L - 1) `ult` L --> L != 0 3744 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 3745 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 3746 3747 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 3748 auto *Zero = Constant::getNullValue(BO0->getType()); 3749 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 3750 } 3751 } 3752 3753 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 3754 return replaceInstUsesWith(I, V); 3755 3756 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 3757 return replaceInstUsesWith(I, V); 3758 3759 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 3760 return replaceInstUsesWith(I, V); 3761 3762 return nullptr; 3763 } 3764 3765 /// Fold icmp Pred min|max(X, Y), X. 3766 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 3767 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3768 Value *Op0 = Cmp.getOperand(0); 3769 Value *X = Cmp.getOperand(1); 3770 3771 // Canonicalize minimum or maximum operand to LHS of the icmp. 3772 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 3773 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 3774 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 3775 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 3776 std::swap(Op0, X); 3777 Pred = Cmp.getSwappedPredicate(); 3778 } 3779 3780 Value *Y; 3781 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 3782 // smin(X, Y) == X --> X s<= Y 3783 // smin(X, Y) s>= X --> X s<= Y 3784 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 3785 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 3786 3787 // smin(X, Y) != X --> X s> Y 3788 // smin(X, Y) s< X --> X s> Y 3789 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 3790 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 3791 3792 // These cases should be handled in InstSimplify: 3793 // smin(X, Y) s<= X --> true 3794 // smin(X, Y) s> X --> false 3795 return nullptr; 3796 } 3797 3798 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 3799 // smax(X, Y) == X --> X s>= Y 3800 // smax(X, Y) s<= X --> X s>= Y 3801 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 3802 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 3803 3804 // smax(X, Y) != X --> X s< Y 3805 // smax(X, Y) s> X --> X s< Y 3806 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 3807 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 3808 3809 // These cases should be handled in InstSimplify: 3810 // smax(X, Y) s>= X --> true 3811 // smax(X, Y) s< X --> false 3812 return nullptr; 3813 } 3814 3815 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 3816 // umin(X, Y) == X --> X u<= Y 3817 // umin(X, Y) u>= X --> X u<= Y 3818 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 3819 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 3820 3821 // umin(X, Y) != X --> X u> Y 3822 // umin(X, Y) u< X --> X u> Y 3823 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 3824 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 3825 3826 // These cases should be handled in InstSimplify: 3827 // umin(X, Y) u<= X --> true 3828 // umin(X, Y) u> X --> false 3829 return nullptr; 3830 } 3831 3832 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 3833 // umax(X, Y) == X --> X u>= Y 3834 // umax(X, Y) u<= X --> X u>= Y 3835 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 3836 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 3837 3838 // umax(X, Y) != X --> X u< Y 3839 // umax(X, Y) u> X --> X u< Y 3840 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 3841 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 3842 3843 // These cases should be handled in InstSimplify: 3844 // umax(X, Y) u>= X --> true 3845 // umax(X, Y) u< X --> false 3846 return nullptr; 3847 } 3848 3849 return nullptr; 3850 } 3851 3852 Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) { 3853 if (!I.isEquality()) 3854 return nullptr; 3855 3856 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3857 const CmpInst::Predicate Pred = I.getPredicate(); 3858 Value *A, *B, *C, *D; 3859 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 3860 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 3861 Value *OtherVal = A == Op1 ? B : A; 3862 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 3863 } 3864 3865 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 3866 // A^c1 == C^c2 --> A == C^(c1^c2) 3867 ConstantInt *C1, *C2; 3868 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 3869 Op1->hasOneUse()) { 3870 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 3871 Value *Xor = Builder.CreateXor(C, NC); 3872 return new ICmpInst(Pred, A, Xor); 3873 } 3874 3875 // A^B == A^D -> B == D 3876 if (A == C) 3877 return new ICmpInst(Pred, B, D); 3878 if (A == D) 3879 return new ICmpInst(Pred, B, C); 3880 if (B == C) 3881 return new ICmpInst(Pred, A, D); 3882 if (B == D) 3883 return new ICmpInst(Pred, A, C); 3884 } 3885 } 3886 3887 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 3888 // A == (A^B) -> B == 0 3889 Value *OtherVal = A == Op0 ? B : A; 3890 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 3891 } 3892 3893 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 3894 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 3895 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 3896 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 3897 3898 if (A == C) { 3899 X = B; 3900 Y = D; 3901 Z = A; 3902 } else if (A == D) { 3903 X = B; 3904 Y = C; 3905 Z = A; 3906 } else if (B == C) { 3907 X = A; 3908 Y = D; 3909 Z = B; 3910 } else if (B == D) { 3911 X = A; 3912 Y = C; 3913 Z = B; 3914 } 3915 3916 if (X) { // Build (X^Y) & Z 3917 Op1 = Builder.CreateXor(X, Y); 3918 Op1 = Builder.CreateAnd(Op1, Z); 3919 I.setOperand(0, Op1); 3920 I.setOperand(1, Constant::getNullValue(Op1->getType())); 3921 return &I; 3922 } 3923 } 3924 3925 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 3926 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 3927 ConstantInt *Cst1; 3928 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 3929 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 3930 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 3931 match(Op1, m_ZExt(m_Value(A))))) { 3932 APInt Pow2 = Cst1->getValue() + 1; 3933 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 3934 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 3935 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 3936 } 3937 3938 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 3939 // For lshr and ashr pairs. 3940 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 3941 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 3942 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 3943 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 3944 unsigned TypeBits = Cst1->getBitWidth(); 3945 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3946 if (ShAmt < TypeBits && ShAmt != 0) { 3947 ICmpInst::Predicate NewPred = 3948 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 3949 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 3950 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 3951 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 3952 } 3953 } 3954 3955 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 3956 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 3957 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 3958 unsigned TypeBits = Cst1->getBitWidth(); 3959 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 3960 if (ShAmt < TypeBits && ShAmt != 0) { 3961 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 3962 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 3963 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 3964 I.getName() + ".mask"); 3965 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 3966 } 3967 } 3968 3969 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 3970 // "icmp (and X, mask), cst" 3971 uint64_t ShAmt = 0; 3972 if (Op0->hasOneUse() && 3973 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 3974 match(Op1, m_ConstantInt(Cst1)) && 3975 // Only do this when A has multiple uses. This is most important to do 3976 // when it exposes other optimizations. 3977 !A->hasOneUse()) { 3978 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 3979 3980 if (ShAmt < ASize) { 3981 APInt MaskV = 3982 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 3983 MaskV <<= ShAmt; 3984 3985 APInt CmpV = Cst1->getValue().zext(ASize); 3986 CmpV <<= ShAmt; 3987 3988 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 3989 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 3990 } 3991 } 3992 3993 // If both operands are byte-swapped or bit-reversed, just compare the 3994 // original values. 3995 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant() 3996 // and handle more intrinsics. 3997 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) || 3998 (match(Op0, m_BitReverse(m_Value(A))) && 3999 match(Op1, m_BitReverse(m_Value(B))))) 4000 return new ICmpInst(Pred, A, B); 4001 4002 // Canonicalize checking for a power-of-2-or-zero value: 4003 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4004 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4005 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4006 m_Deferred(A)))) || 4007 !match(Op1, m_ZeroInt())) 4008 A = nullptr; 4009 4010 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4011 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4012 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4013 A = Op1; 4014 else if (match(Op1, 4015 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4016 A = Op0; 4017 4018 if (A) { 4019 Type *Ty = A->getType(); 4020 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4021 return Pred == ICmpInst::ICMP_EQ 4022 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4023 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4024 } 4025 4026 return nullptr; 4027 } 4028 4029 /// Handle icmp (cast x to y), (cast/cst). We only handle extending casts so 4030 /// far. 4031 Instruction *InstCombiner::foldICmpWithCastAndCast(ICmpInst &ICmp) { 4032 const CastInst *LHSCI = cast<CastInst>(ICmp.getOperand(0)); 4033 Value *LHSCIOp = LHSCI->getOperand(0); 4034 Type *SrcTy = LHSCIOp->getType(); 4035 Type *DestTy = LHSCI->getType(); 4036 4037 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4038 // integer type is the same size as the pointer type. 4039 const auto& CompatibleSizes = [&](Type* SrcTy, Type* DestTy) -> bool { 4040 if (isa<VectorType>(SrcTy)) { 4041 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4042 DestTy = cast<VectorType>(DestTy)->getElementType(); 4043 } 4044 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4045 }; 4046 if (LHSCI->getOpcode() == Instruction::PtrToInt && 4047 CompatibleSizes(SrcTy, DestTy)) { 4048 Value *RHSOp = nullptr; 4049 if (auto *RHSC = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4050 Value *RHSCIOp = RHSC->getOperand(0); 4051 if (RHSCIOp->getType()->getPointerAddressSpace() == 4052 LHSCIOp->getType()->getPointerAddressSpace()) { 4053 RHSOp = RHSC->getOperand(0); 4054 // If the pointer types don't match, insert a bitcast. 4055 if (LHSCIOp->getType() != RHSOp->getType()) 4056 RHSOp = Builder.CreateBitCast(RHSOp, LHSCIOp->getType()); 4057 } 4058 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4059 RHSOp = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4060 } 4061 4062 if (RHSOp) 4063 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSOp); 4064 } 4065 4066 // The code below only handles extension cast instructions, so far. 4067 // Enforce this. 4068 if (LHSCI->getOpcode() != Instruction::ZExt && 4069 LHSCI->getOpcode() != Instruction::SExt) 4070 return nullptr; 4071 4072 bool isSignedExt = LHSCI->getOpcode() == Instruction::SExt; 4073 bool isSignedCmp = ICmp.isSigned(); 4074 4075 if (auto *CI = dyn_cast<CastInst>(ICmp.getOperand(1))) { 4076 // Not an extension from the same type? 4077 Value *RHSCIOp = CI->getOperand(0); 4078 if (RHSCIOp->getType() != LHSCIOp->getType()) 4079 return nullptr; 4080 4081 // If the signedness of the two casts doesn't agree (i.e. one is a sext 4082 // and the other is a zext), then we can't handle this. 4083 if (CI->getOpcode() != LHSCI->getOpcode()) 4084 return nullptr; 4085 4086 // Deal with equality cases early. 4087 if (ICmp.isEquality()) 4088 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 4089 4090 // A signed comparison of sign extended values simplifies into a 4091 // signed comparison. 4092 if (isSignedCmp && isSignedExt) 4093 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, RHSCIOp); 4094 4095 // The other three cases all fold into an unsigned comparison. 4096 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, RHSCIOp); 4097 } 4098 4099 // If we aren't dealing with a constant on the RHS, exit early. 4100 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4101 if (!C) 4102 return nullptr; 4103 4104 // Compute the constant that would happen if we truncated to SrcTy then 4105 // re-extended to DestTy. 4106 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4107 Constant *Res2 = ConstantExpr::getCast(LHSCI->getOpcode(), Res1, DestTy); 4108 4109 // If the re-extended constant didn't change... 4110 if (Res2 == C) { 4111 // Deal with equality cases early. 4112 if (ICmp.isEquality()) 4113 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 4114 4115 // A signed comparison of sign extended values simplifies into a 4116 // signed comparison. 4117 if (isSignedExt && isSignedCmp) 4118 return new ICmpInst(ICmp.getPredicate(), LHSCIOp, Res1); 4119 4120 // The other three cases all fold into an unsigned comparison. 4121 return new ICmpInst(ICmp.getUnsignedPredicate(), LHSCIOp, Res1); 4122 } 4123 4124 // The re-extended constant changed, partly changed (in the case of a vector), 4125 // or could not be determined to be equal (in the case of a constant 4126 // expression), so the constant cannot be represented in the shorter type. 4127 // Consequently, we cannot emit a simple comparison. 4128 // All the cases that fold to true or false will have already been handled 4129 // by SimplifyICmpInst, so only deal with the tricky case. 4130 4131 if (isSignedCmp || !isSignedExt || !isa<ConstantInt>(C)) 4132 return nullptr; 4133 4134 // Evaluate the comparison for LT (we invert for GT below). LE and GE cases 4135 // should have been folded away previously and not enter in here. 4136 4137 // We're performing an unsigned comp with a sign extended value. 4138 // This is true if the input is >= 0. [aka >s -1] 4139 Constant *NegOne = Constant::getAllOnesValue(SrcTy); 4140 Value *Result = Builder.CreateICmpSGT(LHSCIOp, NegOne, ICmp.getName()); 4141 4142 // Finally, return the value computed. 4143 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4144 return replaceInstUsesWith(ICmp, Result); 4145 4146 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4147 return BinaryOperator::CreateNot(Result); 4148 } 4149 4150 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4151 switch (BinaryOp) { 4152 default: 4153 llvm_unreachable("Unsupported binary op"); 4154 case Instruction::Add: 4155 case Instruction::Sub: 4156 return match(RHS, m_Zero()); 4157 case Instruction::Mul: 4158 return match(RHS, m_One()); 4159 } 4160 } 4161 4162 OverflowResult InstCombiner::computeOverflow( 4163 Instruction::BinaryOps BinaryOp, bool IsSigned, 4164 Value *LHS, Value *RHS, Instruction *CxtI) const { 4165 switch (BinaryOp) { 4166 default: 4167 llvm_unreachable("Unsupported binary op"); 4168 case Instruction::Add: 4169 if (IsSigned) 4170 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4171 else 4172 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4173 case Instruction::Sub: 4174 if (IsSigned) 4175 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4176 else 4177 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4178 case Instruction::Mul: 4179 if (IsSigned) 4180 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4181 else 4182 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4183 } 4184 } 4185 4186 bool InstCombiner::OptimizeOverflowCheck( 4187 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS, 4188 Instruction &OrigI, Value *&Result, Constant *&Overflow) { 4189 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4190 std::swap(LHS, RHS); 4191 4192 // If the overflow check was an add followed by a compare, the insertion point 4193 // may be pointing to the compare. We want to insert the new instructions 4194 // before the add in case there are uses of the add between the add and the 4195 // compare. 4196 Builder.SetInsertPoint(&OrigI); 4197 4198 if (isNeutralValue(BinaryOp, RHS)) { 4199 Result = LHS; 4200 Overflow = Builder.getFalse(); 4201 return true; 4202 } 4203 4204 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4205 case OverflowResult::MayOverflow: 4206 return false; 4207 case OverflowResult::AlwaysOverflowsLow: 4208 case OverflowResult::AlwaysOverflowsHigh: 4209 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4210 Result->takeName(&OrigI); 4211 Overflow = Builder.getTrue(); 4212 return true; 4213 case OverflowResult::NeverOverflows: 4214 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4215 Result->takeName(&OrigI); 4216 Overflow = Builder.getFalse(); 4217 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4218 if (IsSigned) 4219 Inst->setHasNoSignedWrap(); 4220 else 4221 Inst->setHasNoUnsignedWrap(); 4222 } 4223 return true; 4224 } 4225 4226 llvm_unreachable("Unexpected overflow result"); 4227 } 4228 4229 /// Recognize and process idiom involving test for multiplication 4230 /// overflow. 4231 /// 4232 /// The caller has matched a pattern of the form: 4233 /// I = cmp u (mul(zext A, zext B), V 4234 /// The function checks if this is a test for overflow and if so replaces 4235 /// multiplication with call to 'mul.with.overflow' intrinsic. 4236 /// 4237 /// \param I Compare instruction. 4238 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 4239 /// the compare instruction. Must be of integer type. 4240 /// \param OtherVal The other argument of compare instruction. 4241 /// \returns Instruction which must replace the compare instruction, NULL if no 4242 /// replacement required. 4243 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 4244 Value *OtherVal, InstCombiner &IC) { 4245 // Don't bother doing this transformation for pointers, don't do it for 4246 // vectors. 4247 if (!isa<IntegerType>(MulVal->getType())) 4248 return nullptr; 4249 4250 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 4251 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 4252 auto *MulInstr = dyn_cast<Instruction>(MulVal); 4253 if (!MulInstr) 4254 return nullptr; 4255 assert(MulInstr->getOpcode() == Instruction::Mul); 4256 4257 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 4258 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 4259 assert(LHS->getOpcode() == Instruction::ZExt); 4260 assert(RHS->getOpcode() == Instruction::ZExt); 4261 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 4262 4263 // Calculate type and width of the result produced by mul.with.overflow. 4264 Type *TyA = A->getType(), *TyB = B->getType(); 4265 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 4266 WidthB = TyB->getPrimitiveSizeInBits(); 4267 unsigned MulWidth; 4268 Type *MulType; 4269 if (WidthB > WidthA) { 4270 MulWidth = WidthB; 4271 MulType = TyB; 4272 } else { 4273 MulWidth = WidthA; 4274 MulType = TyA; 4275 } 4276 4277 // In order to replace the original mul with a narrower mul.with.overflow, 4278 // all uses must ignore upper bits of the product. The number of used low 4279 // bits must be not greater than the width of mul.with.overflow. 4280 if (MulVal->hasNUsesOrMore(2)) 4281 for (User *U : MulVal->users()) { 4282 if (U == &I) 4283 continue; 4284 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4285 // Check if truncation ignores bits above MulWidth. 4286 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 4287 if (TruncWidth > MulWidth) 4288 return nullptr; 4289 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4290 // Check if AND ignores bits above MulWidth. 4291 if (BO->getOpcode() != Instruction::And) 4292 return nullptr; 4293 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 4294 const APInt &CVal = CI->getValue(); 4295 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 4296 return nullptr; 4297 } else { 4298 // In this case we could have the operand of the binary operation 4299 // being defined in another block, and performing the replacement 4300 // could break the dominance relation. 4301 return nullptr; 4302 } 4303 } else { 4304 // Other uses prohibit this transformation. 4305 return nullptr; 4306 } 4307 } 4308 4309 // Recognize patterns 4310 switch (I.getPredicate()) { 4311 case ICmpInst::ICMP_EQ: 4312 case ICmpInst::ICMP_NE: 4313 // Recognize pattern: 4314 // mulval = mul(zext A, zext B) 4315 // cmp eq/neq mulval, zext trunc mulval 4316 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal)) 4317 if (Zext->hasOneUse()) { 4318 Value *ZextArg = Zext->getOperand(0); 4319 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg)) 4320 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth) 4321 break; //Recognized 4322 } 4323 4324 // Recognize pattern: 4325 // mulval = mul(zext A, zext B) 4326 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 4327 ConstantInt *CI; 4328 Value *ValToMask; 4329 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 4330 if (ValToMask != MulVal) 4331 return nullptr; 4332 const APInt &CVal = CI->getValue() + 1; 4333 if (CVal.isPowerOf2()) { 4334 unsigned MaskWidth = CVal.logBase2(); 4335 if (MaskWidth == MulWidth) 4336 break; // Recognized 4337 } 4338 } 4339 return nullptr; 4340 4341 case ICmpInst::ICMP_UGT: 4342 // Recognize pattern: 4343 // mulval = mul(zext A, zext B) 4344 // cmp ugt mulval, max 4345 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4346 APInt MaxVal = APInt::getMaxValue(MulWidth); 4347 MaxVal = MaxVal.zext(CI->getBitWidth()); 4348 if (MaxVal.eq(CI->getValue())) 4349 break; // Recognized 4350 } 4351 return nullptr; 4352 4353 case ICmpInst::ICMP_UGE: 4354 // Recognize pattern: 4355 // mulval = mul(zext A, zext B) 4356 // cmp uge mulval, max+1 4357 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4358 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4359 if (MaxVal.eq(CI->getValue())) 4360 break; // Recognized 4361 } 4362 return nullptr; 4363 4364 case ICmpInst::ICMP_ULE: 4365 // Recognize pattern: 4366 // mulval = mul(zext A, zext B) 4367 // cmp ule mulval, max 4368 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4369 APInt MaxVal = APInt::getMaxValue(MulWidth); 4370 MaxVal = MaxVal.zext(CI->getBitWidth()); 4371 if (MaxVal.eq(CI->getValue())) 4372 break; // Recognized 4373 } 4374 return nullptr; 4375 4376 case ICmpInst::ICMP_ULT: 4377 // Recognize pattern: 4378 // mulval = mul(zext A, zext B) 4379 // cmp ule mulval, max + 1 4380 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4381 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4382 if (MaxVal.eq(CI->getValue())) 4383 break; // Recognized 4384 } 4385 return nullptr; 4386 4387 default: 4388 return nullptr; 4389 } 4390 4391 InstCombiner::BuilderTy &Builder = IC.Builder; 4392 Builder.SetInsertPoint(MulInstr); 4393 4394 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 4395 Value *MulA = A, *MulB = B; 4396 if (WidthA < MulWidth) 4397 MulA = Builder.CreateZExt(A, MulType); 4398 if (WidthB < MulWidth) 4399 MulB = Builder.CreateZExt(B, MulType); 4400 Function *F = Intrinsic::getDeclaration( 4401 I.getModule(), Intrinsic::umul_with_overflow, MulType); 4402 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 4403 IC.Worklist.Add(MulInstr); 4404 4405 // If there are uses of mul result other than the comparison, we know that 4406 // they are truncation or binary AND. Change them to use result of 4407 // mul.with.overflow and adjust properly mask/size. 4408 if (MulVal->hasNUsesOrMore(2)) { 4409 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 4410 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) { 4411 User *U = *UI++; 4412 if (U == &I || U == OtherVal) 4413 continue; 4414 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4415 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 4416 IC.replaceInstUsesWith(*TI, Mul); 4417 else 4418 TI->setOperand(0, Mul); 4419 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4420 assert(BO->getOpcode() == Instruction::And); 4421 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 4422 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 4423 APInt ShortMask = CI->getValue().trunc(MulWidth); 4424 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 4425 Instruction *Zext = 4426 cast<Instruction>(Builder.CreateZExt(ShortAnd, BO->getType())); 4427 IC.Worklist.Add(Zext); 4428 IC.replaceInstUsesWith(*BO, Zext); 4429 } else { 4430 llvm_unreachable("Unexpected Binary operation"); 4431 } 4432 IC.Worklist.Add(cast<Instruction>(U)); 4433 } 4434 } 4435 if (isa<Instruction>(OtherVal)) 4436 IC.Worklist.Add(cast<Instruction>(OtherVal)); 4437 4438 // The original icmp gets replaced with the overflow value, maybe inverted 4439 // depending on predicate. 4440 bool Inverse = false; 4441 switch (I.getPredicate()) { 4442 case ICmpInst::ICMP_NE: 4443 break; 4444 case ICmpInst::ICMP_EQ: 4445 Inverse = true; 4446 break; 4447 case ICmpInst::ICMP_UGT: 4448 case ICmpInst::ICMP_UGE: 4449 if (I.getOperand(0) == MulVal) 4450 break; 4451 Inverse = true; 4452 break; 4453 case ICmpInst::ICMP_ULT: 4454 case ICmpInst::ICMP_ULE: 4455 if (I.getOperand(1) == MulVal) 4456 break; 4457 Inverse = true; 4458 break; 4459 default: 4460 llvm_unreachable("Unexpected predicate"); 4461 } 4462 if (Inverse) { 4463 Value *Res = Builder.CreateExtractValue(Call, 1); 4464 return BinaryOperator::CreateNot(Res); 4465 } 4466 4467 return ExtractValueInst::Create(Call, 1); 4468 } 4469 4470 /// When performing a comparison against a constant, it is possible that not all 4471 /// the bits in the LHS are demanded. This helper method computes the mask that 4472 /// IS demanded. 4473 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 4474 const APInt *RHS; 4475 if (!match(I.getOperand(1), m_APInt(RHS))) 4476 return APInt::getAllOnesValue(BitWidth); 4477 4478 // If this is a normal comparison, it demands all bits. If it is a sign bit 4479 // comparison, it only demands the sign bit. 4480 bool UnusedBit; 4481 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 4482 return APInt::getSignMask(BitWidth); 4483 4484 switch (I.getPredicate()) { 4485 // For a UGT comparison, we don't care about any bits that 4486 // correspond to the trailing ones of the comparand. The value of these 4487 // bits doesn't impact the outcome of the comparison, because any value 4488 // greater than the RHS must differ in a bit higher than these due to carry. 4489 case ICmpInst::ICMP_UGT: 4490 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 4491 4492 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 4493 // Any value less than the RHS must differ in a higher bit because of carries. 4494 case ICmpInst::ICMP_ULT: 4495 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 4496 4497 default: 4498 return APInt::getAllOnesValue(BitWidth); 4499 } 4500 } 4501 4502 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 4503 /// should be swapped. 4504 /// The decision is based on how many times these two operands are reused 4505 /// as subtract operands and their positions in those instructions. 4506 /// The rationale is that several architectures use the same instruction for 4507 /// both subtract and cmp. Thus, it is better if the order of those operands 4508 /// match. 4509 /// \return true if Op0 and Op1 should be swapped. 4510 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 4511 // Filter out pointer values as those cannot appear directly in subtract. 4512 // FIXME: we may want to go through inttoptrs or bitcasts. 4513 if (Op0->getType()->isPointerTy()) 4514 return false; 4515 // If a subtract already has the same operands as a compare, swapping would be 4516 // bad. If a subtract has the same operands as a compare but in reverse order, 4517 // then swapping is good. 4518 int GoodToSwap = 0; 4519 for (const User *U : Op0->users()) { 4520 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 4521 GoodToSwap++; 4522 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 4523 GoodToSwap--; 4524 } 4525 return GoodToSwap > 0; 4526 } 4527 4528 /// Check that one use is in the same block as the definition and all 4529 /// other uses are in blocks dominated by a given block. 4530 /// 4531 /// \param DI Definition 4532 /// \param UI Use 4533 /// \param DB Block that must dominate all uses of \p DI outside 4534 /// the parent block 4535 /// \return true when \p UI is the only use of \p DI in the parent block 4536 /// and all other uses of \p DI are in blocks dominated by \p DB. 4537 /// 4538 bool InstCombiner::dominatesAllUses(const Instruction *DI, 4539 const Instruction *UI, 4540 const BasicBlock *DB) const { 4541 assert(DI && UI && "Instruction not defined\n"); 4542 // Ignore incomplete definitions. 4543 if (!DI->getParent()) 4544 return false; 4545 // DI and UI must be in the same block. 4546 if (DI->getParent() != UI->getParent()) 4547 return false; 4548 // Protect from self-referencing blocks. 4549 if (DI->getParent() == DB) 4550 return false; 4551 for (const User *U : DI->users()) { 4552 auto *Usr = cast<Instruction>(U); 4553 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 4554 return false; 4555 } 4556 return true; 4557 } 4558 4559 /// Return true when the instruction sequence within a block is select-cmp-br. 4560 static bool isChainSelectCmpBranch(const SelectInst *SI) { 4561 const BasicBlock *BB = SI->getParent(); 4562 if (!BB) 4563 return false; 4564 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 4565 if (!BI || BI->getNumSuccessors() != 2) 4566 return false; 4567 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 4568 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 4569 return false; 4570 return true; 4571 } 4572 4573 /// True when a select result is replaced by one of its operands 4574 /// in select-icmp sequence. This will eventually result in the elimination 4575 /// of the select. 4576 /// 4577 /// \param SI Select instruction 4578 /// \param Icmp Compare instruction 4579 /// \param SIOpd Operand that replaces the select 4580 /// 4581 /// Notes: 4582 /// - The replacement is global and requires dominator information 4583 /// - The caller is responsible for the actual replacement 4584 /// 4585 /// Example: 4586 /// 4587 /// entry: 4588 /// %4 = select i1 %3, %C* %0, %C* null 4589 /// %5 = icmp eq %C* %4, null 4590 /// br i1 %5, label %9, label %7 4591 /// ... 4592 /// ; <label>:7 ; preds = %entry 4593 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 4594 /// ... 4595 /// 4596 /// can be transformed to 4597 /// 4598 /// %5 = icmp eq %C* %0, null 4599 /// %6 = select i1 %3, i1 %5, i1 true 4600 /// br i1 %6, label %9, label %7 4601 /// ... 4602 /// ; <label>:7 ; preds = %entry 4603 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 4604 /// 4605 /// Similar when the first operand of the select is a constant or/and 4606 /// the compare is for not equal rather than equal. 4607 /// 4608 /// NOTE: The function is only called when the select and compare constants 4609 /// are equal, the optimization can work only for EQ predicates. This is not a 4610 /// major restriction since a NE compare should be 'normalized' to an equal 4611 /// compare, which usually happens in the combiner and test case 4612 /// select-cmp-br.ll checks for it. 4613 bool InstCombiner::replacedSelectWithOperand(SelectInst *SI, 4614 const ICmpInst *Icmp, 4615 const unsigned SIOpd) { 4616 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 4617 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 4618 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 4619 // The check for the single predecessor is not the best that can be 4620 // done. But it protects efficiently against cases like when SI's 4621 // home block has two successors, Succ and Succ1, and Succ1 predecessor 4622 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 4623 // replaced can be reached on either path. So the uniqueness check 4624 // guarantees that the path all uses of SI (outside SI's parent) are on 4625 // is disjoint from all other paths out of SI. But that information 4626 // is more expensive to compute, and the trade-off here is in favor 4627 // of compile-time. It should also be noticed that we check for a single 4628 // predecessor and not only uniqueness. This to handle the situation when 4629 // Succ and Succ1 points to the same basic block. 4630 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 4631 NumSel++; 4632 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 4633 return true; 4634 } 4635 } 4636 return false; 4637 } 4638 4639 /// Try to fold the comparison based on range information we can get by checking 4640 /// whether bits are known to be zero or one in the inputs. 4641 Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) { 4642 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4643 Type *Ty = Op0->getType(); 4644 ICmpInst::Predicate Pred = I.getPredicate(); 4645 4646 // Get scalar or pointer size. 4647 unsigned BitWidth = Ty->isIntOrIntVectorTy() 4648 ? Ty->getScalarSizeInBits() 4649 : DL.getIndexTypeSizeInBits(Ty->getScalarType()); 4650 4651 if (!BitWidth) 4652 return nullptr; 4653 4654 KnownBits Op0Known(BitWidth); 4655 KnownBits Op1Known(BitWidth); 4656 4657 if (SimplifyDemandedBits(&I, 0, 4658 getDemandedBitsLHSMask(I, BitWidth), 4659 Op0Known, 0)) 4660 return &I; 4661 4662 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth), 4663 Op1Known, 0)) 4664 return &I; 4665 4666 // Given the known and unknown bits, compute a range that the LHS could be 4667 // in. Compute the Min, Max and RHS values based on the known bits. For the 4668 // EQ and NE we use unsigned values. 4669 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 4670 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 4671 if (I.isSigned()) { 4672 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4673 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4674 } else { 4675 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4676 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4677 } 4678 4679 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 4680 // out that the LHS or RHS is a constant. Constant fold this now, so that 4681 // code below can assume that Min != Max. 4682 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 4683 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 4684 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 4685 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 4686 4687 // Based on the range information we know about the LHS, see if we can 4688 // simplify this comparison. For example, (x&4) < 8 is always true. 4689 switch (Pred) { 4690 default: 4691 llvm_unreachable("Unknown icmp opcode!"); 4692 case ICmpInst::ICMP_EQ: 4693 case ICmpInst::ICMP_NE: { 4694 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) { 4695 return Pred == CmpInst::ICMP_EQ 4696 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())) 4697 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4698 } 4699 4700 // If all bits are known zero except for one, then we know at most one bit 4701 // is set. If the comparison is against zero, then this is a check to see if 4702 // *that* bit is set. 4703 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 4704 if (Op1Known.isZero()) { 4705 // If the LHS is an AND with the same constant, look through it. 4706 Value *LHS = nullptr; 4707 const APInt *LHSC; 4708 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 4709 *LHSC != Op0KnownZeroInverted) 4710 LHS = Op0; 4711 4712 Value *X; 4713 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 4714 APInt ValToCheck = Op0KnownZeroInverted; 4715 Type *XTy = X->getType(); 4716 if (ValToCheck.isPowerOf2()) { 4717 // ((1 << X) & 8) == 0 -> X != 3 4718 // ((1 << X) & 8) != 0 -> X == 3 4719 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4720 auto NewPred = ICmpInst::getInversePredicate(Pred); 4721 return new ICmpInst(NewPred, X, CmpC); 4722 } else if ((++ValToCheck).isPowerOf2()) { 4723 // ((1 << X) & 7) == 0 -> X >= 3 4724 // ((1 << X) & 7) != 0 -> X < 3 4725 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 4726 auto NewPred = 4727 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 4728 return new ICmpInst(NewPred, X, CmpC); 4729 } 4730 } 4731 4732 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 4733 const APInt *CI; 4734 if (Op0KnownZeroInverted.isOneValue() && 4735 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 4736 // ((8 >>u X) & 1) == 0 -> X != 3 4737 // ((8 >>u X) & 1) != 0 -> X == 3 4738 unsigned CmpVal = CI->countTrailingZeros(); 4739 auto NewPred = ICmpInst::getInversePredicate(Pred); 4740 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 4741 } 4742 } 4743 break; 4744 } 4745 case ICmpInst::ICMP_ULT: { 4746 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 4747 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4748 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 4749 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4750 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 4751 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4752 4753 const APInt *CmpC; 4754 if (match(Op1, m_APInt(CmpC))) { 4755 // A <u C -> A == C-1 if min(A)+1 == C 4756 if (*CmpC == Op0Min + 1) 4757 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4758 ConstantInt::get(Op1->getType(), *CmpC - 1)); 4759 // X <u C --> X == 0, if the number of zero bits in the bottom of X 4760 // exceeds the log2 of C. 4761 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 4762 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4763 Constant::getNullValue(Op1->getType())); 4764 } 4765 break; 4766 } 4767 case ICmpInst::ICMP_UGT: { 4768 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 4769 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4770 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 4771 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4772 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 4773 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4774 4775 const APInt *CmpC; 4776 if (match(Op1, m_APInt(CmpC))) { 4777 // A >u C -> A == C+1 if max(a)-1 == C 4778 if (*CmpC == Op0Max - 1) 4779 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4780 ConstantInt::get(Op1->getType(), *CmpC + 1)); 4781 // X >u C --> X != 0, if the number of zero bits in the bottom of X 4782 // exceeds the log2 of C. 4783 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 4784 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 4785 Constant::getNullValue(Op1->getType())); 4786 } 4787 break; 4788 } 4789 case ICmpInst::ICMP_SLT: { 4790 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 4791 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4792 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 4793 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4794 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 4795 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4796 const APInt *CmpC; 4797 if (match(Op1, m_APInt(CmpC))) { 4798 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 4799 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4800 ConstantInt::get(Op1->getType(), *CmpC - 1)); 4801 } 4802 break; 4803 } 4804 case ICmpInst::ICMP_SGT: { 4805 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 4806 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4807 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 4808 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4809 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 4810 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 4811 const APInt *CmpC; 4812 if (match(Op1, m_APInt(CmpC))) { 4813 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 4814 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 4815 ConstantInt::get(Op1->getType(), *CmpC + 1)); 4816 } 4817 break; 4818 } 4819 case ICmpInst::ICMP_SGE: 4820 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 4821 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 4822 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4823 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 4824 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4825 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 4826 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4827 break; 4828 case ICmpInst::ICMP_SLE: 4829 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 4830 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 4831 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4832 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 4833 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4834 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 4835 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4836 break; 4837 case ICmpInst::ICMP_UGE: 4838 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 4839 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 4840 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4841 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 4842 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4843 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 4844 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4845 break; 4846 case ICmpInst::ICMP_ULE: 4847 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 4848 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 4849 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4850 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 4851 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4852 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 4853 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 4854 break; 4855 } 4856 4857 // Turn a signed comparison into an unsigned one if both operands are known to 4858 // have the same sign. 4859 if (I.isSigned() && 4860 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 4861 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 4862 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 4863 4864 return nullptr; 4865 } 4866 4867 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 4868 llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 4869 Constant *C) { 4870 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 4871 !isCanonicalPredicate(Pred) && 4872 "Only for non-canonical relational integer predicates."); 4873 4874 // Check if the constant operand can be safely incremented/decremented without 4875 // overflowing/underflowing. For scalars, SimplifyICmpInst should have already 4876 // handled the edge cases for us, so we just assert on them. 4877 // For vectors, we must handle the edge cases. 4878 Type *Type = C->getType(); 4879 bool IsSigned = ICmpInst::isSigned(Pred); 4880 bool IsLE = (Pred == ICmpInst::ICMP_SLE || Pred == ICmpInst::ICMP_ULE); 4881 auto *CI = dyn_cast<ConstantInt>(C); 4882 if (CI) { 4883 // A <= MAX -> TRUE ; A >= MIN -> TRUE 4884 assert(IsLE ? !CI->isMaxValue(IsSigned) : !CI->isMinValue(IsSigned)); 4885 } else if (Type->isVectorTy()) { 4886 // TODO? If the edge cases for vectors were guaranteed to be handled as they 4887 // are for scalar, we could remove the min/max checks. However, to do that, 4888 // we would have to use insertelement/shufflevector to replace edge values. 4889 unsigned NumElts = Type->getVectorNumElements(); 4890 for (unsigned i = 0; i != NumElts; ++i) { 4891 Constant *Elt = C->getAggregateElement(i); 4892 if (!Elt) 4893 return llvm::None; 4894 4895 if (isa<UndefValue>(Elt)) 4896 continue; 4897 4898 // Bail out if we can't determine if this constant is min/max or if we 4899 // know that this constant is min/max. 4900 auto *CI = dyn_cast<ConstantInt>(Elt); 4901 if (!CI || (IsLE ? CI->isMaxValue(IsSigned) : CI->isMinValue(IsSigned))) 4902 return llvm::None; 4903 } 4904 } else { 4905 // ConstantExpr? 4906 return llvm::None; 4907 } 4908 4909 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 4910 4911 // Increment or decrement the constant. 4912 Constant *OneOrNegOne = ConstantInt::get(Type, IsLE ? 1 : -1, true); 4913 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 4914 4915 return std::make_pair(NewPred, NewC); 4916 } 4917 4918 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 4919 /// it into the appropriate icmp lt or icmp gt instruction. This transform 4920 /// allows them to be folded in visitICmpInst. 4921 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 4922 ICmpInst::Predicate Pred = I.getPredicate(); 4923 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 4924 isCanonicalPredicate(Pred)) 4925 return nullptr; 4926 4927 Value *Op0 = I.getOperand(0); 4928 Value *Op1 = I.getOperand(1); 4929 auto *Op1C = dyn_cast<Constant>(Op1); 4930 if (!Op1C) 4931 return nullptr; 4932 4933 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 4934 if (!FlippedStrictness) 4935 return nullptr; 4936 4937 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 4938 } 4939 4940 /// Integer compare with boolean values can always be turned into bitwise ops. 4941 static Instruction *canonicalizeICmpBool(ICmpInst &I, 4942 InstCombiner::BuilderTy &Builder) { 4943 Value *A = I.getOperand(0), *B = I.getOperand(1); 4944 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 4945 4946 // A boolean compared to true/false can be simplified to Op0/true/false in 4947 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 4948 // Cases not handled by InstSimplify are always 'not' of Op0. 4949 if (match(B, m_Zero())) { 4950 switch (I.getPredicate()) { 4951 case CmpInst::ICMP_EQ: // A == 0 -> !A 4952 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 4953 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 4954 return BinaryOperator::CreateNot(A); 4955 default: 4956 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 4957 } 4958 } else if (match(B, m_One())) { 4959 switch (I.getPredicate()) { 4960 case CmpInst::ICMP_NE: // A != 1 -> !A 4961 case CmpInst::ICMP_ULT: // A <u 1 -> !A 4962 case CmpInst::ICMP_SGT: // A >s -1 -> !A 4963 return BinaryOperator::CreateNot(A); 4964 default: 4965 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 4966 } 4967 } 4968 4969 switch (I.getPredicate()) { 4970 default: 4971 llvm_unreachable("Invalid icmp instruction!"); 4972 case ICmpInst::ICMP_EQ: 4973 // icmp eq i1 A, B -> ~(A ^ B) 4974 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 4975 4976 case ICmpInst::ICMP_NE: 4977 // icmp ne i1 A, B -> A ^ B 4978 return BinaryOperator::CreateXor(A, B); 4979 4980 case ICmpInst::ICMP_UGT: 4981 // icmp ugt -> icmp ult 4982 std::swap(A, B); 4983 LLVM_FALLTHROUGH; 4984 case ICmpInst::ICMP_ULT: 4985 // icmp ult i1 A, B -> ~A & B 4986 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 4987 4988 case ICmpInst::ICMP_SGT: 4989 // icmp sgt -> icmp slt 4990 std::swap(A, B); 4991 LLVM_FALLTHROUGH; 4992 case ICmpInst::ICMP_SLT: 4993 // icmp slt i1 A, B -> A & ~B 4994 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 4995 4996 case ICmpInst::ICMP_UGE: 4997 // icmp uge -> icmp ule 4998 std::swap(A, B); 4999 LLVM_FALLTHROUGH; 5000 case ICmpInst::ICMP_ULE: 5001 // icmp ule i1 A, B -> ~A | B 5002 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5003 5004 case ICmpInst::ICMP_SGE: 5005 // icmp sge -> icmp sle 5006 std::swap(A, B); 5007 LLVM_FALLTHROUGH; 5008 case ICmpInst::ICMP_SLE: 5009 // icmp sle i1 A, B -> A | ~B 5010 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5011 } 5012 } 5013 5014 // Transform pattern like: 5015 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5016 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5017 // Into: 5018 // (X l>> Y) != 0 5019 // (X l>> Y) == 0 5020 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5021 InstCombiner::BuilderTy &Builder) { 5022 ICmpInst::Predicate Pred, NewPred; 5023 Value *X, *Y; 5024 if (match(&Cmp, 5025 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5026 // We want X to be the icmp's second operand, so swap predicate if it isn't. 5027 if (Cmp.getOperand(0) == X) 5028 Pred = Cmp.getSwappedPredicate(); 5029 5030 switch (Pred) { 5031 case ICmpInst::ICMP_ULE: 5032 NewPred = ICmpInst::ICMP_NE; 5033 break; 5034 case ICmpInst::ICMP_UGT: 5035 NewPred = ICmpInst::ICMP_EQ; 5036 break; 5037 default: 5038 return nullptr; 5039 } 5040 } else if (match(&Cmp, m_c_ICmp(Pred, 5041 m_OneUse(m_CombineOr( 5042 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5043 m_Add(m_Shl(m_One(), m_Value(Y)), 5044 m_AllOnes()))), 5045 m_Value(X)))) { 5046 // The variant with 'add' is not canonical, (the variant with 'not' is) 5047 // we only get it because it has extra uses, and can't be canonicalized, 5048 5049 // We want X to be the icmp's second operand, so swap predicate if it isn't. 5050 if (Cmp.getOperand(0) == X) 5051 Pred = Cmp.getSwappedPredicate(); 5052 5053 switch (Pred) { 5054 case ICmpInst::ICMP_ULT: 5055 NewPred = ICmpInst::ICMP_NE; 5056 break; 5057 case ICmpInst::ICMP_UGE: 5058 NewPred = ICmpInst::ICMP_EQ; 5059 break; 5060 default: 5061 return nullptr; 5062 } 5063 } else 5064 return nullptr; 5065 5066 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5067 Constant *Zero = Constant::getNullValue(NewX->getType()); 5068 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5069 } 5070 5071 static Instruction *foldVectorCmp(CmpInst &Cmp, 5072 InstCombiner::BuilderTy &Builder) { 5073 // If both arguments of the cmp are shuffles that use the same mask and 5074 // shuffle within a single vector, move the shuffle after the cmp. 5075 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5076 Value *V1, *V2; 5077 Constant *M; 5078 if (match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Constant(M))) && 5079 match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_Specific(M))) && 5080 V1->getType() == V2->getType() && 5081 (LHS->hasOneUse() || RHS->hasOneUse())) { 5082 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5083 CmpInst::Predicate P = Cmp.getPredicate(); 5084 Value *NewCmp = isa<ICmpInst>(Cmp) ? Builder.CreateICmp(P, V1, V2) 5085 : Builder.CreateFCmp(P, V1, V2); 5086 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M); 5087 } 5088 return nullptr; 5089 } 5090 5091 Instruction *InstCombiner::visitICmpInst(ICmpInst &I) { 5092 bool Changed = false; 5093 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5094 unsigned Op0Cplxity = getComplexity(Op0); 5095 unsigned Op1Cplxity = getComplexity(Op1); 5096 5097 /// Orders the operands of the compare so that they are listed from most 5098 /// complex to least complex. This puts constants before unary operators, 5099 /// before binary operators. 5100 if (Op0Cplxity < Op1Cplxity || 5101 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 5102 I.swapOperands(); 5103 std::swap(Op0, Op1); 5104 Changed = true; 5105 } 5106 5107 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, 5108 SQ.getWithInstruction(&I))) 5109 return replaceInstUsesWith(I, V); 5110 5111 // Comparing -val or val with non-zero is the same as just comparing val 5112 // ie, abs(val) != 0 -> val != 0 5113 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 5114 Value *Cond, *SelectTrue, *SelectFalse; 5115 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 5116 m_Value(SelectFalse)))) { 5117 if (Value *V = dyn_castNegVal(SelectTrue)) { 5118 if (V == SelectFalse) 5119 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5120 } 5121 else if (Value *V = dyn_castNegVal(SelectFalse)) { 5122 if (V == SelectTrue) 5123 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5124 } 5125 } 5126 } 5127 5128 if (Op0->getType()->isIntOrIntVectorTy(1)) 5129 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 5130 return Res; 5131 5132 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I)) 5133 return NewICmp; 5134 5135 if (Instruction *Res = foldICmpWithConstant(I)) 5136 return Res; 5137 5138 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 5139 return Res; 5140 5141 if (Instruction *Res = foldICmpUsingKnownBits(I)) 5142 return Res; 5143 5144 // Test if the ICmpInst instruction is used exclusively by a select as 5145 // part of a minimum or maximum operation. If so, refrain from doing 5146 // any other folding. This helps out other analyses which understand 5147 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 5148 // and CodeGen. And in this case, at least one of the comparison 5149 // operands has at least one user besides the compare (the select), 5150 // which would often largely negate the benefit of folding anyway. 5151 // 5152 // Do the same for the other patterns recognized by matchSelectPattern. 5153 if (I.hasOneUse()) 5154 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 5155 Value *A, *B; 5156 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 5157 if (SPR.Flavor != SPF_UNKNOWN) 5158 return nullptr; 5159 } 5160 5161 // Do this after checking for min/max to prevent infinite looping. 5162 if (Instruction *Res = foldICmpWithZero(I)) 5163 return Res; 5164 5165 // FIXME: We only do this after checking for min/max to prevent infinite 5166 // looping caused by a reverse canonicalization of these patterns for min/max. 5167 // FIXME: The organization of folds is a mess. These would naturally go into 5168 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 5169 // down here after the min/max restriction. 5170 ICmpInst::Predicate Pred = I.getPredicate(); 5171 const APInt *C; 5172 if (match(Op1, m_APInt(C))) { 5173 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 5174 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 5175 Constant *Zero = Constant::getNullValue(Op0->getType()); 5176 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 5177 } 5178 5179 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 5180 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 5181 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 5182 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 5183 } 5184 } 5185 5186 if (Instruction *Res = foldICmpInstWithConstant(I)) 5187 return Res; 5188 5189 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 5190 return Res; 5191 5192 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 5193 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 5194 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 5195 return NI; 5196 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 5197 if (Instruction *NI = foldGEPICmp(GEP, Op0, 5198 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 5199 return NI; 5200 5201 // Try to optimize equality comparisons against alloca-based pointers. 5202 if (Op0->getType()->isPointerTy() && I.isEquality()) { 5203 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 5204 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL))) 5205 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 5206 return New; 5207 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL))) 5208 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 5209 return New; 5210 } 5211 5212 if (Instruction *Res = foldICmpBitCast(I, Builder)) 5213 return Res; 5214 5215 if (isa<CastInst>(Op0)) { 5216 // Handle the special case of: icmp (cast bool to X), <cst> 5217 // This comes up when you have code like 5218 // int X = A < B; 5219 // if (X) ... 5220 // For generality, we handle any zero-extension of any operand comparison 5221 // with a constant or another cast from the same type. 5222 if (isa<Constant>(Op1) || isa<CastInst>(Op1)) 5223 if (Instruction *R = foldICmpWithCastAndCast(I)) 5224 return R; 5225 } 5226 5227 if (Instruction *Res = foldICmpBinOp(I)) 5228 return Res; 5229 5230 if (Instruction *Res = foldICmpWithMinMax(I)) 5231 return Res; 5232 5233 { 5234 Value *A, *B; 5235 // Transform (A & ~B) == 0 --> (A & B) != 0 5236 // and (A & ~B) != 0 --> (A & B) == 0 5237 // if A is a power of 2. 5238 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 5239 match(Op1, m_Zero()) && 5240 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 5241 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 5242 Op1); 5243 5244 // ~X < ~Y --> Y < X 5245 // ~X < C --> X > ~C 5246 if (match(Op0, m_Not(m_Value(A)))) { 5247 if (match(Op1, m_Not(m_Value(B)))) 5248 return new ICmpInst(I.getPredicate(), B, A); 5249 5250 const APInt *C; 5251 if (match(Op1, m_APInt(C))) 5252 return new ICmpInst(I.getSwappedPredicate(), A, 5253 ConstantInt::get(Op1->getType(), ~(*C))); 5254 } 5255 5256 Instruction *AddI = nullptr; 5257 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 5258 m_Instruction(AddI))) && 5259 isa<IntegerType>(A->getType())) { 5260 Value *Result; 5261 Constant *Overflow; 5262 if (OptimizeOverflowCheck(Instruction::Add, /*Signed*/false, A, B, 5263 *AddI, Result, Overflow)) { 5264 replaceInstUsesWith(*AddI, Result); 5265 return replaceInstUsesWith(I, Overflow); 5266 } 5267 } 5268 5269 // (zext a) * (zext b) --> llvm.umul.with.overflow. 5270 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5271 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 5272 return R; 5273 } 5274 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5275 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 5276 return R; 5277 } 5278 } 5279 5280 if (Instruction *Res = foldICmpEquality(I)) 5281 return Res; 5282 5283 // The 'cmpxchg' instruction returns an aggregate containing the old value and 5284 // an i1 which indicates whether or not we successfully did the swap. 5285 // 5286 // Replace comparisons between the old value and the expected value with the 5287 // indicator that 'cmpxchg' returns. 5288 // 5289 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 5290 // spuriously fail. In those cases, the old value may equal the expected 5291 // value but it is possible for the swap to not occur. 5292 if (I.getPredicate() == ICmpInst::ICMP_EQ) 5293 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 5294 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 5295 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 5296 !ACXI->isWeak()) 5297 return ExtractValueInst::Create(ACXI, 1); 5298 5299 { 5300 Value *X; 5301 const APInt *C; 5302 // icmp X+Cst, X 5303 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 5304 return foldICmpAddOpConst(X, *C, I.getPredicate()); 5305 5306 // icmp X, X+Cst 5307 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 5308 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 5309 } 5310 5311 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 5312 return Res; 5313 5314 if (I.getType()->isVectorTy()) 5315 if (Instruction *Res = foldVectorCmp(I, Builder)) 5316 return Res; 5317 5318 return Changed ? &I : nullptr; 5319 } 5320 5321 /// Fold fcmp ([us]itofp x, cst) if possible. 5322 Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI, 5323 Constant *RHSC) { 5324 if (!isa<ConstantFP>(RHSC)) return nullptr; 5325 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 5326 5327 // Get the width of the mantissa. We don't want to hack on conversions that 5328 // might lose information from the integer, e.g. "i64 -> float" 5329 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 5330 if (MantissaWidth == -1) return nullptr; // Unknown. 5331 5332 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 5333 5334 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 5335 5336 if (I.isEquality()) { 5337 FCmpInst::Predicate P = I.getPredicate(); 5338 bool IsExact = false; 5339 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 5340 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 5341 5342 // If the floating point constant isn't an integer value, we know if we will 5343 // ever compare equal / not equal to it. 5344 if (!IsExact) { 5345 // TODO: Can never be -0.0 and other non-representable values 5346 APFloat RHSRoundInt(RHS); 5347 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 5348 if (RHS.compare(RHSRoundInt) != APFloat::cmpEqual) { 5349 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 5350 return replaceInstUsesWith(I, Builder.getFalse()); 5351 5352 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 5353 return replaceInstUsesWith(I, Builder.getTrue()); 5354 } 5355 } 5356 5357 // TODO: If the constant is exactly representable, is it always OK to do 5358 // equality compares as integer? 5359 } 5360 5361 // Check to see that the input is converted from an integer type that is small 5362 // enough that preserves all bits. TODO: check here for "known" sign bits. 5363 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 5364 unsigned InputSize = IntTy->getScalarSizeInBits(); 5365 5366 // Following test does NOT adjust InputSize downwards for signed inputs, 5367 // because the most negative value still requires all the mantissa bits 5368 // to distinguish it from one less than that value. 5369 if ((int)InputSize > MantissaWidth) { 5370 // Conversion would lose accuracy. Check if loss can impact comparison. 5371 int Exp = ilogb(RHS); 5372 if (Exp == APFloat::IEK_Inf) { 5373 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 5374 if (MaxExponent < (int)InputSize - !LHSUnsigned) 5375 // Conversion could create infinity. 5376 return nullptr; 5377 } else { 5378 // Note that if RHS is zero or NaN, then Exp is negative 5379 // and first condition is trivially false. 5380 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 5381 // Conversion could affect comparison. 5382 return nullptr; 5383 } 5384 } 5385 5386 // Otherwise, we can potentially simplify the comparison. We know that it 5387 // will always come through as an integer value and we know the constant is 5388 // not a NAN (it would have been previously simplified). 5389 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 5390 5391 ICmpInst::Predicate Pred; 5392 switch (I.getPredicate()) { 5393 default: llvm_unreachable("Unexpected predicate!"); 5394 case FCmpInst::FCMP_UEQ: 5395 case FCmpInst::FCMP_OEQ: 5396 Pred = ICmpInst::ICMP_EQ; 5397 break; 5398 case FCmpInst::FCMP_UGT: 5399 case FCmpInst::FCMP_OGT: 5400 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 5401 break; 5402 case FCmpInst::FCMP_UGE: 5403 case FCmpInst::FCMP_OGE: 5404 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 5405 break; 5406 case FCmpInst::FCMP_ULT: 5407 case FCmpInst::FCMP_OLT: 5408 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 5409 break; 5410 case FCmpInst::FCMP_ULE: 5411 case FCmpInst::FCMP_OLE: 5412 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 5413 break; 5414 case FCmpInst::FCMP_UNE: 5415 case FCmpInst::FCMP_ONE: 5416 Pred = ICmpInst::ICMP_NE; 5417 break; 5418 case FCmpInst::FCMP_ORD: 5419 return replaceInstUsesWith(I, Builder.getTrue()); 5420 case FCmpInst::FCMP_UNO: 5421 return replaceInstUsesWith(I, Builder.getFalse()); 5422 } 5423 5424 // Now we know that the APFloat is a normal number, zero or inf. 5425 5426 // See if the FP constant is too large for the integer. For example, 5427 // comparing an i8 to 300.0. 5428 unsigned IntWidth = IntTy->getScalarSizeInBits(); 5429 5430 if (!LHSUnsigned) { 5431 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 5432 // and large values. 5433 APFloat SMax(RHS.getSemantics()); 5434 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 5435 APFloat::rmNearestTiesToEven); 5436 if (SMax.compare(RHS) == APFloat::cmpLessThan) { // smax < 13123.0 5437 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 5438 Pred == ICmpInst::ICMP_SLE) 5439 return replaceInstUsesWith(I, Builder.getTrue()); 5440 return replaceInstUsesWith(I, Builder.getFalse()); 5441 } 5442 } else { 5443 // If the RHS value is > UnsignedMax, fold the comparison. This handles 5444 // +INF and large values. 5445 APFloat UMax(RHS.getSemantics()); 5446 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 5447 APFloat::rmNearestTiesToEven); 5448 if (UMax.compare(RHS) == APFloat::cmpLessThan) { // umax < 13123.0 5449 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 5450 Pred == ICmpInst::ICMP_ULE) 5451 return replaceInstUsesWith(I, Builder.getTrue()); 5452 return replaceInstUsesWith(I, Builder.getFalse()); 5453 } 5454 } 5455 5456 if (!LHSUnsigned) { 5457 // See if the RHS value is < SignedMin. 5458 APFloat SMin(RHS.getSemantics()); 5459 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 5460 APFloat::rmNearestTiesToEven); 5461 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // smin > 12312.0 5462 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 5463 Pred == ICmpInst::ICMP_SGE) 5464 return replaceInstUsesWith(I, Builder.getTrue()); 5465 return replaceInstUsesWith(I, Builder.getFalse()); 5466 } 5467 } else { 5468 // See if the RHS value is < UnsignedMin. 5469 APFloat SMin(RHS.getSemantics()); 5470 SMin.convertFromAPInt(APInt::getMinValue(IntWidth), true, 5471 APFloat::rmNearestTiesToEven); 5472 if (SMin.compare(RHS) == APFloat::cmpGreaterThan) { // umin > 12312.0 5473 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 5474 Pred == ICmpInst::ICMP_UGE) 5475 return replaceInstUsesWith(I, Builder.getTrue()); 5476 return replaceInstUsesWith(I, Builder.getFalse()); 5477 } 5478 } 5479 5480 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 5481 // [0, UMAX], but it may still be fractional. See if it is fractional by 5482 // casting the FP value to the integer value and back, checking for equality. 5483 // Don't do this for zero, because -0.0 is not fractional. 5484 Constant *RHSInt = LHSUnsigned 5485 ? ConstantExpr::getFPToUI(RHSC, IntTy) 5486 : ConstantExpr::getFPToSI(RHSC, IntTy); 5487 if (!RHS.isZero()) { 5488 bool Equal = LHSUnsigned 5489 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 5490 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 5491 if (!Equal) { 5492 // If we had a comparison against a fractional value, we have to adjust 5493 // the compare predicate and sometimes the value. RHSC is rounded towards 5494 // zero at this point. 5495 switch (Pred) { 5496 default: llvm_unreachable("Unexpected integer comparison!"); 5497 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 5498 return replaceInstUsesWith(I, Builder.getTrue()); 5499 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 5500 return replaceInstUsesWith(I, Builder.getFalse()); 5501 case ICmpInst::ICMP_ULE: 5502 // (float)int <= 4.4 --> int <= 4 5503 // (float)int <= -4.4 --> false 5504 if (RHS.isNegative()) 5505 return replaceInstUsesWith(I, Builder.getFalse()); 5506 break; 5507 case ICmpInst::ICMP_SLE: 5508 // (float)int <= 4.4 --> int <= 4 5509 // (float)int <= -4.4 --> int < -4 5510 if (RHS.isNegative()) 5511 Pred = ICmpInst::ICMP_SLT; 5512 break; 5513 case ICmpInst::ICMP_ULT: 5514 // (float)int < -4.4 --> false 5515 // (float)int < 4.4 --> int <= 4 5516 if (RHS.isNegative()) 5517 return replaceInstUsesWith(I, Builder.getFalse()); 5518 Pred = ICmpInst::ICMP_ULE; 5519 break; 5520 case ICmpInst::ICMP_SLT: 5521 // (float)int < -4.4 --> int < -4 5522 // (float)int < 4.4 --> int <= 4 5523 if (!RHS.isNegative()) 5524 Pred = ICmpInst::ICMP_SLE; 5525 break; 5526 case ICmpInst::ICMP_UGT: 5527 // (float)int > 4.4 --> int > 4 5528 // (float)int > -4.4 --> true 5529 if (RHS.isNegative()) 5530 return replaceInstUsesWith(I, Builder.getTrue()); 5531 break; 5532 case ICmpInst::ICMP_SGT: 5533 // (float)int > 4.4 --> int > 4 5534 // (float)int > -4.4 --> int >= -4 5535 if (RHS.isNegative()) 5536 Pred = ICmpInst::ICMP_SGE; 5537 break; 5538 case ICmpInst::ICMP_UGE: 5539 // (float)int >= -4.4 --> true 5540 // (float)int >= 4.4 --> int > 4 5541 if (RHS.isNegative()) 5542 return replaceInstUsesWith(I, Builder.getTrue()); 5543 Pred = ICmpInst::ICMP_UGT; 5544 break; 5545 case ICmpInst::ICMP_SGE: 5546 // (float)int >= -4.4 --> int >= -4 5547 // (float)int >= 4.4 --> int > 4 5548 if (!RHS.isNegative()) 5549 Pred = ICmpInst::ICMP_SGT; 5550 break; 5551 } 5552 } 5553 } 5554 5555 // Lower this FP comparison into an appropriate integer version of the 5556 // comparison. 5557 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 5558 } 5559 5560 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 5561 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 5562 Constant *RHSC) { 5563 // When C is not 0.0 and infinities are not allowed: 5564 // (C / X) < 0.0 is a sign-bit test of X 5565 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 5566 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 5567 // 5568 // Proof: 5569 // Multiply (C / X) < 0.0 by X * X / C. 5570 // - X is non zero, if it is the flag 'ninf' is violated. 5571 // - C defines the sign of X * X * C. Thus it also defines whether to swap 5572 // the predicate. C is also non zero by definition. 5573 // 5574 // Thus X * X / C is non zero and the transformation is valid. [qed] 5575 5576 FCmpInst::Predicate Pred = I.getPredicate(); 5577 5578 // Check that predicates are valid. 5579 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 5580 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 5581 return nullptr; 5582 5583 // Check that RHS operand is zero. 5584 if (!match(RHSC, m_AnyZeroFP())) 5585 return nullptr; 5586 5587 // Check fastmath flags ('ninf'). 5588 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 5589 return nullptr; 5590 5591 // Check the properties of the dividend. It must not be zero to avoid a 5592 // division by zero (see Proof). 5593 const APFloat *C; 5594 if (!match(LHSI->getOperand(0), m_APFloat(C))) 5595 return nullptr; 5596 5597 if (C->isZero()) 5598 return nullptr; 5599 5600 // Get swapped predicate if necessary. 5601 if (C->isNegative()) 5602 Pred = I.getSwappedPredicate(); 5603 5604 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 5605 } 5606 5607 /// Optimize fabs(X) compared with zero. 5608 static Instruction *foldFabsWithFcmpZero(FCmpInst &I) { 5609 Value *X; 5610 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) || 5611 !match(I.getOperand(1), m_PosZeroFP())) 5612 return nullptr; 5613 5614 auto replacePredAndOp0 = [](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 5615 I->setPredicate(P); 5616 I->setOperand(0, X); 5617 return I; 5618 }; 5619 5620 switch (I.getPredicate()) { 5621 case FCmpInst::FCMP_UGE: 5622 case FCmpInst::FCMP_OLT: 5623 // fabs(X) >= 0.0 --> true 5624 // fabs(X) < 0.0 --> false 5625 llvm_unreachable("fcmp should have simplified"); 5626 5627 case FCmpInst::FCMP_OGT: 5628 // fabs(X) > 0.0 --> X != 0.0 5629 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 5630 5631 case FCmpInst::FCMP_UGT: 5632 // fabs(X) u> 0.0 --> X u!= 0.0 5633 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 5634 5635 case FCmpInst::FCMP_OLE: 5636 // fabs(X) <= 0.0 --> X == 0.0 5637 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 5638 5639 case FCmpInst::FCMP_ULE: 5640 // fabs(X) u<= 0.0 --> X u== 0.0 5641 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 5642 5643 case FCmpInst::FCMP_OGE: 5644 // fabs(X) >= 0.0 --> !isnan(X) 5645 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 5646 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 5647 5648 case FCmpInst::FCMP_ULT: 5649 // fabs(X) u< 0.0 --> isnan(X) 5650 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 5651 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 5652 5653 case FCmpInst::FCMP_OEQ: 5654 case FCmpInst::FCMP_UEQ: 5655 case FCmpInst::FCMP_ONE: 5656 case FCmpInst::FCMP_UNE: 5657 case FCmpInst::FCMP_ORD: 5658 case FCmpInst::FCMP_UNO: 5659 // Look through the fabs() because it doesn't change anything but the sign. 5660 // fabs(X) == 0.0 --> X == 0.0, 5661 // fabs(X) != 0.0 --> X != 0.0 5662 // isnan(fabs(X)) --> isnan(X) 5663 // !isnan(fabs(X) --> !isnan(X) 5664 return replacePredAndOp0(&I, I.getPredicate(), X); 5665 5666 default: 5667 return nullptr; 5668 } 5669 } 5670 5671 Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) { 5672 bool Changed = false; 5673 5674 /// Orders the operands of the compare so that they are listed from most 5675 /// complex to least complex. This puts constants before unary operators, 5676 /// before binary operators. 5677 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 5678 I.swapOperands(); 5679 Changed = true; 5680 } 5681 5682 const CmpInst::Predicate Pred = I.getPredicate(); 5683 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5684 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 5685 SQ.getWithInstruction(&I))) 5686 return replaceInstUsesWith(I, V); 5687 5688 // Simplify 'fcmp pred X, X' 5689 Type *OpType = Op0->getType(); 5690 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 5691 if (Op0 == Op1) { 5692 switch (Pred) { 5693 default: break; 5694 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 5695 case FCmpInst::FCMP_ULT: // True if unordered or less than 5696 case FCmpInst::FCMP_UGT: // True if unordered or greater than 5697 case FCmpInst::FCMP_UNE: // True if unordered or not equal 5698 // Canonicalize these to be 'fcmp uno %X, 0.0'. 5699 I.setPredicate(FCmpInst::FCMP_UNO); 5700 I.setOperand(1, Constant::getNullValue(OpType)); 5701 return &I; 5702 5703 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 5704 case FCmpInst::FCMP_OEQ: // True if ordered and equal 5705 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 5706 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 5707 // Canonicalize these to be 'fcmp ord %X, 0.0'. 5708 I.setPredicate(FCmpInst::FCMP_ORD); 5709 I.setOperand(1, Constant::getNullValue(OpType)); 5710 return &I; 5711 } 5712 } 5713 5714 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 5715 // then canonicalize the operand to 0.0. 5716 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 5717 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) { 5718 I.setOperand(0, ConstantFP::getNullValue(OpType)); 5719 return &I; 5720 } 5721 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) { 5722 I.setOperand(1, ConstantFP::getNullValue(OpType)); 5723 return &I; 5724 } 5725 } 5726 5727 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 5728 Value *X, *Y; 5729 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 5730 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 5731 5732 // Test if the FCmpInst instruction is used exclusively by a select as 5733 // part of a minimum or maximum operation. If so, refrain from doing 5734 // any other folding. This helps out other analyses which understand 5735 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 5736 // and CodeGen. And in this case, at least one of the comparison 5737 // operands has at least one user besides the compare (the select), 5738 // which would often largely negate the benefit of folding anyway. 5739 if (I.hasOneUse()) 5740 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 5741 Value *A, *B; 5742 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 5743 if (SPR.Flavor != SPF_UNKNOWN) 5744 return nullptr; 5745 } 5746 5747 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 5748 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 5749 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) { 5750 I.setOperand(1, ConstantFP::getNullValue(OpType)); 5751 return &I; 5752 } 5753 5754 // Handle fcmp with instruction LHS and constant RHS. 5755 Instruction *LHSI; 5756 Constant *RHSC; 5757 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 5758 switch (LHSI->getOpcode()) { 5759 case Instruction::PHI: 5760 // Only fold fcmp into the PHI if the phi and fcmp are in the same 5761 // block. If in the same block, we're encouraging jump threading. If 5762 // not, we are just pessimizing the code by making an i1 phi. 5763 if (LHSI->getParent() == I.getParent()) 5764 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 5765 return NV; 5766 break; 5767 case Instruction::SIToFP: 5768 case Instruction::UIToFP: 5769 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 5770 return NV; 5771 break; 5772 case Instruction::FDiv: 5773 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 5774 return NV; 5775 break; 5776 case Instruction::Load: 5777 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 5778 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 5779 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 5780 !cast<LoadInst>(LHSI)->isVolatile()) 5781 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 5782 return Res; 5783 break; 5784 } 5785 } 5786 5787 if (Instruction *R = foldFabsWithFcmpZero(I)) 5788 return R; 5789 5790 if (match(Op0, m_FNeg(m_Value(X)))) { 5791 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 5792 Constant *C; 5793 if (match(Op1, m_Constant(C))) { 5794 Constant *NegC = ConstantExpr::getFNeg(C); 5795 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 5796 } 5797 } 5798 5799 if (match(Op0, m_FPExt(m_Value(X)))) { 5800 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 5801 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 5802 return new FCmpInst(Pred, X, Y, "", &I); 5803 5804 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 5805 const APFloat *C; 5806 if (match(Op1, m_APFloat(C))) { 5807 const fltSemantics &FPSem = 5808 X->getType()->getScalarType()->getFltSemantics(); 5809 bool Lossy; 5810 APFloat TruncC = *C; 5811 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 5812 5813 // Avoid lossy conversions and denormals. 5814 // Zero is a special case that's OK to convert. 5815 APFloat Fabs = TruncC; 5816 Fabs.clearSign(); 5817 if (!Lossy && 5818 ((Fabs.compare(APFloat::getSmallestNormalized(FPSem)) != 5819 APFloat::cmpLessThan) || Fabs.isZero())) { 5820 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 5821 return new FCmpInst(Pred, X, NewC, "", &I); 5822 } 5823 } 5824 } 5825 5826 if (I.getType()->isVectorTy()) 5827 if (Instruction *Res = foldVectorCmp(I, Builder)) 5828 return Res; 5829 5830 return Changed ? &I : nullptr; 5831 } 5832