1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/ConstantFolding.h" 18 #include "llvm/Analysis/InstructionSimplify.h" 19 #include "llvm/Analysis/TargetLibraryInfo.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/Debug.h" 26 #include "llvm/Support/KnownBits.h" 27 28 using namespace llvm; 29 using namespace PatternMatch; 30 31 #define DEBUG_TYPE "instcombine" 32 33 // How many times is a select replaced by one of its operands? 34 STATISTIC(NumSel, "Number of select opts"); 35 36 37 /// Compute Result = In1+In2, returning true if the result overflowed for this 38 /// type. 39 static bool addWithOverflow(APInt &Result, const APInt &In1, 40 const APInt &In2, bool IsSigned = false) { 41 bool Overflow; 42 if (IsSigned) 43 Result = In1.sadd_ov(In2, Overflow); 44 else 45 Result = In1.uadd_ov(In2, Overflow); 46 47 return Overflow; 48 } 49 50 /// Compute Result = In1-In2, returning true if the result overflowed for this 51 /// type. 52 static bool subWithOverflow(APInt &Result, const APInt &In1, 53 const APInt &In2, bool IsSigned = false) { 54 bool Overflow; 55 if (IsSigned) 56 Result = In1.ssub_ov(In2, Overflow); 57 else 58 Result = In1.usub_ov(In2, Overflow); 59 60 return Overflow; 61 } 62 63 /// Given an icmp instruction, return true if any use of this comparison is a 64 /// branch on sign bit comparison. 65 static bool hasBranchUse(ICmpInst &I) { 66 for (auto *U : I.users()) 67 if (isa<BranchInst>(U)) 68 return true; 69 return false; 70 } 71 72 /// Returns true if the exploded icmp can be expressed as a signed comparison 73 /// to zero and updates the predicate accordingly. 74 /// The signedness of the comparison is preserved. 75 /// TODO: Refactor with decomposeBitTestICmp()? 76 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 77 if (!ICmpInst::isSigned(Pred)) 78 return false; 79 80 if (C.isNullValue()) 81 return ICmpInst::isRelational(Pred); 82 83 if (C.isOneValue()) { 84 if (Pred == ICmpInst::ICMP_SLT) { 85 Pred = ICmpInst::ICMP_SLE; 86 return true; 87 } 88 } else if (C.isAllOnesValue()) { 89 if (Pred == ICmpInst::ICMP_SGT) { 90 Pred = ICmpInst::ICMP_SGE; 91 return true; 92 } 93 } 94 95 return false; 96 } 97 98 /// Given a signed integer type and a set of known zero and one bits, compute 99 /// the maximum and minimum values that could have the specified known zero and 100 /// known one bits, returning them in Min/Max. 101 /// TODO: Move to method on KnownBits struct? 102 static void computeSignedMinMaxValuesFromKnownBits(const KnownBits &Known, 103 APInt &Min, APInt &Max) { 104 assert(Known.getBitWidth() == Min.getBitWidth() && 105 Known.getBitWidth() == Max.getBitWidth() && 106 "KnownZero, KnownOne and Min, Max must have equal bitwidth."); 107 APInt UnknownBits = ~(Known.Zero|Known.One); 108 109 // The minimum value is when all unknown bits are zeros, EXCEPT for the sign 110 // bit if it is unknown. 111 Min = Known.One; 112 Max = Known.One|UnknownBits; 113 114 if (UnknownBits.isNegative()) { // Sign bit is unknown 115 Min.setSignBit(); 116 Max.clearSignBit(); 117 } 118 } 119 120 /// Given an unsigned integer type and a set of known zero and one bits, compute 121 /// the maximum and minimum values that could have the specified known zero and 122 /// known one bits, returning them in Min/Max. 123 /// TODO: Move to method on KnownBits struct? 124 static void computeUnsignedMinMaxValuesFromKnownBits(const KnownBits &Known, 125 APInt &Min, APInt &Max) { 126 assert(Known.getBitWidth() == Min.getBitWidth() && 127 Known.getBitWidth() == Max.getBitWidth() && 128 "Ty, KnownZero, KnownOne and Min, Max must have equal bitwidth."); 129 APInt UnknownBits = ~(Known.Zero|Known.One); 130 131 // The minimum value is when the unknown bits are all zeros. 132 Min = Known.One; 133 // The maximum value is when the unknown bits are all ones. 134 Max = Known.One|UnknownBits; 135 } 136 137 /// This is called when we see this pattern: 138 /// cmp pred (load (gep GV, ...)), cmpcst 139 /// where GV is a global variable with a constant initializer. Try to simplify 140 /// this into some simple computation that does not need the load. For example 141 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 142 /// 143 /// If AndCst is non-null, then the loaded value is masked with that constant 144 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 145 Instruction *InstCombiner::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 146 GlobalVariable *GV, 147 CmpInst &ICI, 148 ConstantInt *AndCst) { 149 Constant *Init = GV->getInitializer(); 150 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 151 return nullptr; 152 153 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 154 // Don't blow up on huge arrays. 155 if (ArrayElementCount > MaxArraySizeForCombine) 156 return nullptr; 157 158 // There are many forms of this optimization we can handle, for now, just do 159 // the simple index into a single-dimensional array. 160 // 161 // Require: GEP GV, 0, i {{, constant indices}} 162 if (GEP->getNumOperands() < 3 || 163 !isa<ConstantInt>(GEP->getOperand(1)) || 164 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 165 isa<Constant>(GEP->getOperand(2))) 166 return nullptr; 167 168 // Check that indices after the variable are constants and in-range for the 169 // type they index. Collect the indices. This is typically for arrays of 170 // structs. 171 SmallVector<unsigned, 4> LaterIndices; 172 173 Type *EltTy = Init->getType()->getArrayElementType(); 174 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 175 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 176 if (!Idx) return nullptr; // Variable index. 177 178 uint64_t IdxVal = Idx->getZExtValue(); 179 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 180 181 if (StructType *STy = dyn_cast<StructType>(EltTy)) 182 EltTy = STy->getElementType(IdxVal); 183 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 184 if (IdxVal >= ATy->getNumElements()) return nullptr; 185 EltTy = ATy->getElementType(); 186 } else { 187 return nullptr; // Unknown type. 188 } 189 190 LaterIndices.push_back(IdxVal); 191 } 192 193 enum { Overdefined = -3, Undefined = -2 }; 194 195 // Variables for our state machines. 196 197 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 198 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 199 // and 87 is the second (and last) index. FirstTrueElement is -2 when 200 // undefined, otherwise set to the first true element. SecondTrueElement is 201 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 202 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 203 204 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 205 // form "i != 47 & i != 87". Same state transitions as for true elements. 206 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 207 208 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 209 /// define a state machine that triggers for ranges of values that the index 210 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 211 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 212 /// index in the range (inclusive). We use -2 for undefined here because we 213 /// use relative comparisons and don't want 0-1 to match -1. 214 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 215 216 // MagicBitvector - This is a magic bitvector where we set a bit if the 217 // comparison is true for element 'i'. If there are 64 elements or less in 218 // the array, this will fully represent all the comparison results. 219 uint64_t MagicBitvector = 0; 220 221 // Scan the array and see if one of our patterns matches. 222 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 223 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 224 Constant *Elt = Init->getAggregateElement(i); 225 if (!Elt) return nullptr; 226 227 // If this is indexing an array of structures, get the structure element. 228 if (!LaterIndices.empty()) 229 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 230 231 // If the element is masked, handle it. 232 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 233 234 // Find out if the comparison would be true or false for the i'th element. 235 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 236 CompareRHS, DL, &TLI); 237 // If the result is undef for this element, ignore it. 238 if (isa<UndefValue>(C)) { 239 // Extend range state machines to cover this element in case there is an 240 // undef in the middle of the range. 241 if (TrueRangeEnd == (int)i-1) 242 TrueRangeEnd = i; 243 if (FalseRangeEnd == (int)i-1) 244 FalseRangeEnd = i; 245 continue; 246 } 247 248 // If we can't compute the result for any of the elements, we have to give 249 // up evaluating the entire conditional. 250 if (!isa<ConstantInt>(C)) return nullptr; 251 252 // Otherwise, we know if the comparison is true or false for this element, 253 // update our state machines. 254 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 255 256 // State machine for single/double/range index comparison. 257 if (IsTrueForElt) { 258 // Update the TrueElement state machine. 259 if (FirstTrueElement == Undefined) 260 FirstTrueElement = TrueRangeEnd = i; // First true element. 261 else { 262 // Update double-compare state machine. 263 if (SecondTrueElement == Undefined) 264 SecondTrueElement = i; 265 else 266 SecondTrueElement = Overdefined; 267 268 // Update range state machine. 269 if (TrueRangeEnd == (int)i-1) 270 TrueRangeEnd = i; 271 else 272 TrueRangeEnd = Overdefined; 273 } 274 } else { 275 // Update the FalseElement state machine. 276 if (FirstFalseElement == Undefined) 277 FirstFalseElement = FalseRangeEnd = i; // First false element. 278 else { 279 // Update double-compare state machine. 280 if (SecondFalseElement == Undefined) 281 SecondFalseElement = i; 282 else 283 SecondFalseElement = Overdefined; 284 285 // Update range state machine. 286 if (FalseRangeEnd == (int)i-1) 287 FalseRangeEnd = i; 288 else 289 FalseRangeEnd = Overdefined; 290 } 291 } 292 293 // If this element is in range, update our magic bitvector. 294 if (i < 64 && IsTrueForElt) 295 MagicBitvector |= 1ULL << i; 296 297 // If all of our states become overdefined, bail out early. Since the 298 // predicate is expensive, only check it every 8 elements. This is only 299 // really useful for really huge arrays. 300 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 301 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 302 FalseRangeEnd == Overdefined) 303 return nullptr; 304 } 305 306 // Now that we've scanned the entire array, emit our new comparison(s). We 307 // order the state machines in complexity of the generated code. 308 Value *Idx = GEP->getOperand(2); 309 310 // If the index is larger than the pointer size of the target, truncate the 311 // index down like the GEP would do implicitly. We don't have to do this for 312 // an inbounds GEP because the index can't be out of range. 313 if (!GEP->isInBounds()) { 314 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 315 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 316 if (Idx->getType()->getPrimitiveSizeInBits() > PtrSize) 317 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 318 } 319 320 // If the comparison is only true for one or two elements, emit direct 321 // comparisons. 322 if (SecondTrueElement != Overdefined) { 323 // None true -> false. 324 if (FirstTrueElement == Undefined) 325 return replaceInstUsesWith(ICI, Builder.getFalse()); 326 327 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 328 329 // True for one element -> 'i == 47'. 330 if (SecondTrueElement == Undefined) 331 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 332 333 // True for two elements -> 'i == 47 | i == 72'. 334 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 335 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 336 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 337 return BinaryOperator::CreateOr(C1, C2); 338 } 339 340 // If the comparison is only false for one or two elements, emit direct 341 // comparisons. 342 if (SecondFalseElement != Overdefined) { 343 // None false -> true. 344 if (FirstFalseElement == Undefined) 345 return replaceInstUsesWith(ICI, Builder.getTrue()); 346 347 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 348 349 // False for one element -> 'i != 47'. 350 if (SecondFalseElement == Undefined) 351 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 352 353 // False for two elements -> 'i != 47 & i != 72'. 354 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 355 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 356 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 357 return BinaryOperator::CreateAnd(C1, C2); 358 } 359 360 // If the comparison can be replaced with a range comparison for the elements 361 // where it is true, emit the range check. 362 if (TrueRangeEnd != Overdefined) { 363 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 364 365 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 366 if (FirstTrueElement) { 367 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 368 Idx = Builder.CreateAdd(Idx, Offs); 369 } 370 371 Value *End = ConstantInt::get(Idx->getType(), 372 TrueRangeEnd-FirstTrueElement+1); 373 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 374 } 375 376 // False range check. 377 if (FalseRangeEnd != Overdefined) { 378 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 379 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 380 if (FirstFalseElement) { 381 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 382 Idx = Builder.CreateAdd(Idx, Offs); 383 } 384 385 Value *End = ConstantInt::get(Idx->getType(), 386 FalseRangeEnd-FirstFalseElement); 387 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 388 } 389 390 // If a magic bitvector captures the entire comparison state 391 // of this load, replace it with computation that does: 392 // ((magic_cst >> i) & 1) != 0 393 { 394 Type *Ty = nullptr; 395 396 // Look for an appropriate type: 397 // - The type of Idx if the magic fits 398 // - The smallest fitting legal type 399 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 400 Ty = Idx->getType(); 401 else 402 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 403 404 if (Ty) { 405 Value *V = Builder.CreateIntCast(Idx, Ty, false); 406 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 407 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 408 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 409 } 410 } 411 412 return nullptr; 413 } 414 415 /// Return a value that can be used to compare the *offset* implied by a GEP to 416 /// zero. For example, if we have &A[i], we want to return 'i' for 417 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 418 /// are involved. The above expression would also be legal to codegen as 419 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 420 /// This latter form is less amenable to optimization though, and we are allowed 421 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 422 /// 423 /// If we can't emit an optimized form for this expression, this returns null. 424 /// 425 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombiner &IC, 426 const DataLayout &DL) { 427 gep_type_iterator GTI = gep_type_begin(GEP); 428 429 // Check to see if this gep only has a single variable index. If so, and if 430 // any constant indices are a multiple of its scale, then we can compute this 431 // in terms of the scale of the variable index. For example, if the GEP 432 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 433 // because the expression will cross zero at the same point. 434 unsigned i, e = GEP->getNumOperands(); 435 int64_t Offset = 0; 436 for (i = 1; i != e; ++i, ++GTI) { 437 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 438 // Compute the aggregate offset of constant indices. 439 if (CI->isZero()) continue; 440 441 // Handle a struct index, which adds its field offset to the pointer. 442 if (StructType *STy = GTI.getStructTypeOrNull()) { 443 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 444 } else { 445 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 446 Offset += Size*CI->getSExtValue(); 447 } 448 } else { 449 // Found our variable index. 450 break; 451 } 452 } 453 454 // If there are no variable indices, we must have a constant offset, just 455 // evaluate it the general way. 456 if (i == e) return nullptr; 457 458 Value *VariableIdx = GEP->getOperand(i); 459 // Determine the scale factor of the variable element. For example, this is 460 // 4 if the variable index is into an array of i32. 461 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 462 463 // Verify that there are no other variable indices. If so, emit the hard way. 464 for (++i, ++GTI; i != e; ++i, ++GTI) { 465 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 466 if (!CI) return nullptr; 467 468 // Compute the aggregate offset of constant indices. 469 if (CI->isZero()) continue; 470 471 // Handle a struct index, which adds its field offset to the pointer. 472 if (StructType *STy = GTI.getStructTypeOrNull()) { 473 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 474 } else { 475 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 476 Offset += Size*CI->getSExtValue(); 477 } 478 } 479 480 // Okay, we know we have a single variable index, which must be a 481 // pointer/array/vector index. If there is no offset, life is simple, return 482 // the index. 483 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 484 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 485 if (Offset == 0) { 486 // Cast to intptrty in case a truncation occurs. If an extension is needed, 487 // we don't need to bother extending: the extension won't affect where the 488 // computation crosses zero. 489 if (VariableIdx->getType()->getPrimitiveSizeInBits() > IntPtrWidth) { 490 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 491 } 492 return VariableIdx; 493 } 494 495 // Otherwise, there is an index. The computation we will do will be modulo 496 // the pointer size. 497 Offset = SignExtend64(Offset, IntPtrWidth); 498 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 499 500 // To do this transformation, any constant index must be a multiple of the 501 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 502 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 503 // multiple of the variable scale. 504 int64_t NewOffs = Offset / (int64_t)VariableScale; 505 if (Offset != NewOffs*(int64_t)VariableScale) 506 return nullptr; 507 508 // Okay, we can do this evaluation. Start by converting the index to intptr. 509 if (VariableIdx->getType() != IntPtrTy) 510 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 511 true /*Signed*/); 512 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 513 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 514 } 515 516 /// Returns true if we can rewrite Start as a GEP with pointer Base 517 /// and some integer offset. The nodes that need to be re-written 518 /// for this transformation will be added to Explored. 519 static bool canRewriteGEPAsOffset(Value *Start, Value *Base, 520 const DataLayout &DL, 521 SetVector<Value *> &Explored) { 522 SmallVector<Value *, 16> WorkList(1, Start); 523 Explored.insert(Base); 524 525 // The following traversal gives us an order which can be used 526 // when doing the final transformation. Since in the final 527 // transformation we create the PHI replacement instructions first, 528 // we don't have to get them in any particular order. 529 // 530 // However, for other instructions we will have to traverse the 531 // operands of an instruction first, which means that we have to 532 // do a post-order traversal. 533 while (!WorkList.empty()) { 534 SetVector<PHINode *> PHIs; 535 536 while (!WorkList.empty()) { 537 if (Explored.size() >= 100) 538 return false; 539 540 Value *V = WorkList.back(); 541 542 if (Explored.count(V) != 0) { 543 WorkList.pop_back(); 544 continue; 545 } 546 547 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 548 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 549 // We've found some value that we can't explore which is different from 550 // the base. Therefore we can't do this transformation. 551 return false; 552 553 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 554 auto *CI = dyn_cast<CastInst>(V); 555 if (!CI->isNoopCast(DL)) 556 return false; 557 558 if (Explored.count(CI->getOperand(0)) == 0) 559 WorkList.push_back(CI->getOperand(0)); 560 } 561 562 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 563 // We're limiting the GEP to having one index. This will preserve 564 // the original pointer type. We could handle more cases in the 565 // future. 566 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 567 GEP->getType() != Start->getType()) 568 return false; 569 570 if (Explored.count(GEP->getOperand(0)) == 0) 571 WorkList.push_back(GEP->getOperand(0)); 572 } 573 574 if (WorkList.back() == V) { 575 WorkList.pop_back(); 576 // We've finished visiting this node, mark it as such. 577 Explored.insert(V); 578 } 579 580 if (auto *PN = dyn_cast<PHINode>(V)) { 581 // We cannot transform PHIs on unsplittable basic blocks. 582 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 583 return false; 584 Explored.insert(PN); 585 PHIs.insert(PN); 586 } 587 } 588 589 // Explore the PHI nodes further. 590 for (auto *PN : PHIs) 591 for (Value *Op : PN->incoming_values()) 592 if (Explored.count(Op) == 0) 593 WorkList.push_back(Op); 594 } 595 596 // Make sure that we can do this. Since we can't insert GEPs in a basic 597 // block before a PHI node, we can't easily do this transformation if 598 // we have PHI node users of transformed instructions. 599 for (Value *Val : Explored) { 600 for (Value *Use : Val->uses()) { 601 602 auto *PHI = dyn_cast<PHINode>(Use); 603 auto *Inst = dyn_cast<Instruction>(Val); 604 605 if (Inst == Base || Inst == PHI || !Inst || !PHI || 606 Explored.count(PHI) == 0) 607 continue; 608 609 if (PHI->getParent() == Inst->getParent()) 610 return false; 611 } 612 } 613 return true; 614 } 615 616 // Sets the appropriate insert point on Builder where we can add 617 // a replacement Instruction for V (if that is possible). 618 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 619 bool Before = true) { 620 if (auto *PHI = dyn_cast<PHINode>(V)) { 621 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 622 return; 623 } 624 if (auto *I = dyn_cast<Instruction>(V)) { 625 if (!Before) 626 I = &*std::next(I->getIterator()); 627 Builder.SetInsertPoint(I); 628 return; 629 } 630 if (auto *A = dyn_cast<Argument>(V)) { 631 // Set the insertion point in the entry block. 632 BasicBlock &Entry = A->getParent()->getEntryBlock(); 633 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 634 return; 635 } 636 // Otherwise, this is a constant and we don't need to set a new 637 // insertion point. 638 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 639 } 640 641 /// Returns a re-written value of Start as an indexed GEP using Base as a 642 /// pointer. 643 static Value *rewriteGEPAsOffset(Value *Start, Value *Base, 644 const DataLayout &DL, 645 SetVector<Value *> &Explored) { 646 // Perform all the substitutions. This is a bit tricky because we can 647 // have cycles in our use-def chains. 648 // 1. Create the PHI nodes without any incoming values. 649 // 2. Create all the other values. 650 // 3. Add the edges for the PHI nodes. 651 // 4. Emit GEPs to get the original pointers. 652 // 5. Remove the original instructions. 653 Type *IndexType = IntegerType::get( 654 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 655 656 DenseMap<Value *, Value *> NewInsts; 657 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 658 659 // Create the new PHI nodes, without adding any incoming values. 660 for (Value *Val : Explored) { 661 if (Val == Base) 662 continue; 663 // Create empty phi nodes. This avoids cyclic dependencies when creating 664 // the remaining instructions. 665 if (auto *PHI = dyn_cast<PHINode>(Val)) 666 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 667 PHI->getName() + ".idx", PHI); 668 } 669 IRBuilder<> Builder(Base->getContext()); 670 671 // Create all the other instructions. 672 for (Value *Val : Explored) { 673 674 if (NewInsts.find(Val) != NewInsts.end()) 675 continue; 676 677 if (auto *CI = dyn_cast<CastInst>(Val)) { 678 // Don't get rid of the intermediate variable here; the store can grow 679 // the map which will invalidate the reference to the input value. 680 Value *V = NewInsts[CI->getOperand(0)]; 681 NewInsts[CI] = V; 682 continue; 683 } 684 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 685 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 686 : GEP->getOperand(1); 687 setInsertionPoint(Builder, GEP); 688 // Indices might need to be sign extended. GEPs will magically do 689 // this, but we need to do it ourselves here. 690 if (Index->getType()->getScalarSizeInBits() != 691 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 692 Index = Builder.CreateSExtOrTrunc( 693 Index, NewInsts[GEP->getOperand(0)]->getType(), 694 GEP->getOperand(0)->getName() + ".sext"); 695 } 696 697 auto *Op = NewInsts[GEP->getOperand(0)]; 698 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 699 NewInsts[GEP] = Index; 700 else 701 NewInsts[GEP] = Builder.CreateNSWAdd( 702 Op, Index, GEP->getOperand(0)->getName() + ".add"); 703 continue; 704 } 705 if (isa<PHINode>(Val)) 706 continue; 707 708 llvm_unreachable("Unexpected instruction type"); 709 } 710 711 // Add the incoming values to the PHI nodes. 712 for (Value *Val : Explored) { 713 if (Val == Base) 714 continue; 715 // All the instructions have been created, we can now add edges to the 716 // phi nodes. 717 if (auto *PHI = dyn_cast<PHINode>(Val)) { 718 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 719 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 720 Value *NewIncoming = PHI->getIncomingValue(I); 721 722 if (NewInsts.find(NewIncoming) != NewInsts.end()) 723 NewIncoming = NewInsts[NewIncoming]; 724 725 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 726 } 727 } 728 } 729 730 for (Value *Val : Explored) { 731 if (Val == Base) 732 continue; 733 734 // Depending on the type, for external users we have to emit 735 // a GEP or a GEP + ptrtoint. 736 setInsertionPoint(Builder, Val, false); 737 738 // If required, create an inttoptr instruction for Base. 739 Value *NewBase = Base; 740 if (!Base->getType()->isPointerTy()) 741 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 742 Start->getName() + "to.ptr"); 743 744 Value *GEP = Builder.CreateInBoundsGEP( 745 Start->getType()->getPointerElementType(), NewBase, 746 makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 747 748 if (!Val->getType()->isPointerTy()) { 749 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 750 Val->getName() + ".conv"); 751 GEP = Cast; 752 } 753 Val->replaceAllUsesWith(GEP); 754 } 755 756 return NewInsts[Start]; 757 } 758 759 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 760 /// the input Value as a constant indexed GEP. Returns a pair containing 761 /// the GEPs Pointer and Index. 762 static std::pair<Value *, Value *> 763 getAsConstantIndexedAddress(Value *V, const DataLayout &DL) { 764 Type *IndexType = IntegerType::get(V->getContext(), 765 DL.getIndexTypeSizeInBits(V->getType())); 766 767 Constant *Index = ConstantInt::getNullValue(IndexType); 768 while (true) { 769 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 770 // We accept only inbouds GEPs here to exclude the possibility of 771 // overflow. 772 if (!GEP->isInBounds()) 773 break; 774 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 775 GEP->getType() == V->getType()) { 776 V = GEP->getOperand(0); 777 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 778 Index = ConstantExpr::getAdd( 779 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 780 continue; 781 } 782 break; 783 } 784 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 785 if (!CI->isNoopCast(DL)) 786 break; 787 V = CI->getOperand(0); 788 continue; 789 } 790 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 791 if (!CI->isNoopCast(DL)) 792 break; 793 V = CI->getOperand(0); 794 continue; 795 } 796 break; 797 } 798 return {V, Index}; 799 } 800 801 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 802 /// We can look through PHIs, GEPs and casts in order to determine a common base 803 /// between GEPLHS and RHS. 804 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 805 ICmpInst::Predicate Cond, 806 const DataLayout &DL) { 807 // FIXME: Support vector of pointers. 808 if (GEPLHS->getType()->isVectorTy()) 809 return nullptr; 810 811 if (!GEPLHS->hasAllConstantIndices()) 812 return nullptr; 813 814 // Make sure the pointers have the same type. 815 if (GEPLHS->getType() != RHS->getType()) 816 return nullptr; 817 818 Value *PtrBase, *Index; 819 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(GEPLHS, DL); 820 821 // The set of nodes that will take part in this transformation. 822 SetVector<Value *> Nodes; 823 824 if (!canRewriteGEPAsOffset(RHS, PtrBase, DL, Nodes)) 825 return nullptr; 826 827 // We know we can re-write this as 828 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 829 // Since we've only looked through inbouds GEPs we know that we 830 // can't have overflow on either side. We can therefore re-write 831 // this as: 832 // OFFSET1 cmp OFFSET2 833 Value *NewRHS = rewriteGEPAsOffset(RHS, PtrBase, DL, Nodes); 834 835 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 836 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 837 // offset. Since Index is the offset of LHS to the base pointer, we will now 838 // compare the offsets instead of comparing the pointers. 839 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 840 } 841 842 /// Fold comparisons between a GEP instruction and something else. At this point 843 /// we know that the GEP is on the LHS of the comparison. 844 Instruction *InstCombiner::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 845 ICmpInst::Predicate Cond, 846 Instruction &I) { 847 // Don't transform signed compares of GEPs into index compares. Even if the 848 // GEP is inbounds, the final add of the base pointer can have signed overflow 849 // and would change the result of the icmp. 850 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 851 // the maximum signed value for the pointer type. 852 if (ICmpInst::isSigned(Cond)) 853 return nullptr; 854 855 // Look through bitcasts and addrspacecasts. We do not however want to remove 856 // 0 GEPs. 857 if (!isa<GetElementPtrInst>(RHS)) 858 RHS = RHS->stripPointerCasts(); 859 860 Value *PtrBase = GEPLHS->getOperand(0); 861 // FIXME: Support vector pointer GEPs. 862 if (PtrBase == RHS && GEPLHS->isInBounds() && 863 !GEPLHS->getType()->isVectorTy()) { 864 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 865 // This transformation (ignoring the base and scales) is valid because we 866 // know pointers can't overflow since the gep is inbounds. See if we can 867 // output an optimized form. 868 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 869 870 // If not, synthesize the offset the hard way. 871 if (!Offset) 872 Offset = EmitGEPOffset(GEPLHS); 873 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 874 Constant::getNullValue(Offset->getType())); 875 } 876 877 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) && 878 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() && 879 !NullPointerIsDefined(I.getFunction(), 880 RHS->getType()->getPointerAddressSpace())) { 881 // For most address spaces, an allocation can't be placed at null, but null 882 // itself is treated as a 0 size allocation in the in bounds rules. Thus, 883 // the only valid inbounds address derived from null, is null itself. 884 // Thus, we have four cases to consider: 885 // 1) Base == nullptr, Offset == 0 -> inbounds, null 886 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds 887 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations) 888 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison) 889 // 890 // (Note if we're indexing a type of size 0, that simply collapses into one 891 // of the buckets above.) 892 // 893 // In general, we're allowed to make values less poison (i.e. remove 894 // sources of full UB), so in this case, we just select between the two 895 // non-poison cases (1 and 4 above). 896 // 897 // For vectors, we apply the same reasoning on a per-lane basis. 898 auto *Base = GEPLHS->getPointerOperand(); 899 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) { 900 int NumElts = cast<VectorType>(GEPLHS->getType())->getNumElements(); 901 Base = Builder.CreateVectorSplat(NumElts, Base); 902 } 903 return new ICmpInst(Cond, Base, 904 ConstantExpr::getPointerBitCastOrAddrSpaceCast( 905 cast<Constant>(RHS), Base->getType())); 906 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 907 // If the base pointers are different, but the indices are the same, just 908 // compare the base pointer. 909 if (PtrBase != GEPRHS->getOperand(0)) { 910 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 911 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 912 GEPRHS->getOperand(0)->getType(); 913 if (IndicesTheSame) 914 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 915 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 916 IndicesTheSame = false; 917 break; 918 } 919 920 // If all indices are the same, just compare the base pointers. 921 Type *BaseType = GEPLHS->getOperand(0)->getType(); 922 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 923 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 924 925 // If we're comparing GEPs with two base pointers that only differ in type 926 // and both GEPs have only constant indices or just one use, then fold 927 // the compare with the adjusted indices. 928 // FIXME: Support vector of pointers. 929 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 930 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 931 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 932 PtrBase->stripPointerCasts() == 933 GEPRHS->getOperand(0)->stripPointerCasts() && 934 !GEPLHS->getType()->isVectorTy()) { 935 Value *LOffset = EmitGEPOffset(GEPLHS); 936 Value *ROffset = EmitGEPOffset(GEPRHS); 937 938 // If we looked through an addrspacecast between different sized address 939 // spaces, the LHS and RHS pointers are different sized 940 // integers. Truncate to the smaller one. 941 Type *LHSIndexTy = LOffset->getType(); 942 Type *RHSIndexTy = ROffset->getType(); 943 if (LHSIndexTy != RHSIndexTy) { 944 if (LHSIndexTy->getPrimitiveSizeInBits() < 945 RHSIndexTy->getPrimitiveSizeInBits()) { 946 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 947 } else 948 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 949 } 950 951 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 952 LOffset, ROffset); 953 return replaceInstUsesWith(I, Cmp); 954 } 955 956 // Otherwise, the base pointers are different and the indices are 957 // different. Try convert this to an indexed compare by looking through 958 // PHIs/casts. 959 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 960 } 961 962 // If one of the GEPs has all zero indices, recurse. 963 // FIXME: Handle vector of pointers. 964 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices()) 965 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 966 ICmpInst::getSwappedPredicate(Cond), I); 967 968 // If the other GEP has all zero indices, recurse. 969 // FIXME: Handle vector of pointers. 970 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices()) 971 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 972 973 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 974 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 975 // If the GEPs only differ by one index, compare it. 976 unsigned NumDifferences = 0; // Keep track of # differences. 977 unsigned DiffOperand = 0; // The operand that differs. 978 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 979 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 980 Type *LHSType = GEPLHS->getOperand(i)->getType(); 981 Type *RHSType = GEPRHS->getOperand(i)->getType(); 982 // FIXME: Better support for vector of pointers. 983 if (LHSType->getPrimitiveSizeInBits() != 984 RHSType->getPrimitiveSizeInBits() || 985 (GEPLHS->getType()->isVectorTy() && 986 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) { 987 // Irreconcilable differences. 988 NumDifferences = 2; 989 break; 990 } 991 992 if (NumDifferences++) break; 993 DiffOperand = i; 994 } 995 996 if (NumDifferences == 0) // SAME GEP? 997 return replaceInstUsesWith(I, // No comparison is needed here. 998 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 999 1000 else if (NumDifferences == 1 && GEPsInBounds) { 1001 Value *LHSV = GEPLHS->getOperand(DiffOperand); 1002 Value *RHSV = GEPRHS->getOperand(DiffOperand); 1003 // Make sure we do a signed comparison here. 1004 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 1005 } 1006 } 1007 1008 // Only lower this if the icmp is the only user of the GEP or if we expect 1009 // the result to fold to a constant! 1010 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 1011 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 1012 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 1013 Value *L = EmitGEPOffset(GEPLHS); 1014 Value *R = EmitGEPOffset(GEPRHS); 1015 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 1016 } 1017 } 1018 1019 // Try convert this to an indexed compare by looking through PHIs/casts as a 1020 // last resort. 1021 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1022 } 1023 1024 Instruction *InstCombiner::foldAllocaCmp(ICmpInst &ICI, 1025 const AllocaInst *Alloca, 1026 const Value *Other) { 1027 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1028 1029 // It would be tempting to fold away comparisons between allocas and any 1030 // pointer not based on that alloca (e.g. an argument). However, even 1031 // though such pointers cannot alias, they can still compare equal. 1032 // 1033 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1034 // doesn't escape we can argue that it's impossible to guess its value, and we 1035 // can therefore act as if any such guesses are wrong. 1036 // 1037 // The code below checks that the alloca doesn't escape, and that it's only 1038 // used in a comparison once (the current instruction). The 1039 // single-comparison-use condition ensures that we're trivially folding all 1040 // comparisons against the alloca consistently, and avoids the risk of 1041 // erroneously folding a comparison of the pointer with itself. 1042 1043 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1044 1045 SmallVector<const Use *, 32> Worklist; 1046 for (const Use &U : Alloca->uses()) { 1047 if (Worklist.size() >= MaxIter) 1048 return nullptr; 1049 Worklist.push_back(&U); 1050 } 1051 1052 unsigned NumCmps = 0; 1053 while (!Worklist.empty()) { 1054 assert(Worklist.size() <= MaxIter); 1055 const Use *U = Worklist.pop_back_val(); 1056 const Value *V = U->getUser(); 1057 --MaxIter; 1058 1059 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1060 isa<SelectInst>(V)) { 1061 // Track the uses. 1062 } else if (isa<LoadInst>(V)) { 1063 // Loading from the pointer doesn't escape it. 1064 continue; 1065 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1066 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1067 if (SI->getValueOperand() == U->get()) 1068 return nullptr; 1069 continue; 1070 } else if (isa<ICmpInst>(V)) { 1071 if (NumCmps++) 1072 return nullptr; // Found more than one cmp. 1073 continue; 1074 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1075 switch (Intrin->getIntrinsicID()) { 1076 // These intrinsics don't escape or compare the pointer. Memset is safe 1077 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1078 // we don't allow stores, so src cannot point to V. 1079 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1080 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1081 continue; 1082 default: 1083 return nullptr; 1084 } 1085 } else { 1086 return nullptr; 1087 } 1088 for (const Use &U : V->uses()) { 1089 if (Worklist.size() >= MaxIter) 1090 return nullptr; 1091 Worklist.push_back(&U); 1092 } 1093 } 1094 1095 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1096 return replaceInstUsesWith( 1097 ICI, 1098 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1099 } 1100 1101 /// Fold "icmp pred (X+C), X". 1102 Instruction *InstCombiner::foldICmpAddOpConst(Value *X, const APInt &C, 1103 ICmpInst::Predicate Pred) { 1104 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1105 // so the values can never be equal. Similarly for all other "or equals" 1106 // operators. 1107 assert(!!C && "C should not be zero!"); 1108 1109 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1110 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1111 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1112 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1113 Constant *R = ConstantInt::get(X->getType(), 1114 APInt::getMaxValue(C.getBitWidth()) - C); 1115 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1116 } 1117 1118 // (X+1) >u X --> X <u (0-1) --> X != 255 1119 // (X+2) >u X --> X <u (0-2) --> X <u 254 1120 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1121 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1122 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1123 ConstantInt::get(X->getType(), -C)); 1124 1125 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1126 1127 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1128 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1129 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1130 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1131 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1132 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1133 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1134 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1135 ConstantInt::get(X->getType(), SMax - C)); 1136 1137 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1138 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1139 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1140 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1141 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1142 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1143 1144 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1145 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1146 ConstantInt::get(X->getType(), SMax - (C - 1))); 1147 } 1148 1149 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1150 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1151 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1152 Instruction *InstCombiner::foldICmpShrConstConst(ICmpInst &I, Value *A, 1153 const APInt &AP1, 1154 const APInt &AP2) { 1155 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1156 1157 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1158 if (I.getPredicate() == I.ICMP_NE) 1159 Pred = CmpInst::getInversePredicate(Pred); 1160 return new ICmpInst(Pred, LHS, RHS); 1161 }; 1162 1163 // Don't bother doing any work for cases which InstSimplify handles. 1164 if (AP2.isNullValue()) 1165 return nullptr; 1166 1167 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1168 if (IsAShr) { 1169 if (AP2.isAllOnesValue()) 1170 return nullptr; 1171 if (AP2.isNegative() != AP1.isNegative()) 1172 return nullptr; 1173 if (AP2.sgt(AP1)) 1174 return nullptr; 1175 } 1176 1177 if (!AP1) 1178 // 'A' must be large enough to shift out the highest set bit. 1179 return getICmp(I.ICMP_UGT, A, 1180 ConstantInt::get(A->getType(), AP2.logBase2())); 1181 1182 if (AP1 == AP2) 1183 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1184 1185 int Shift; 1186 if (IsAShr && AP1.isNegative()) 1187 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1188 else 1189 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1190 1191 if (Shift > 0) { 1192 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1193 // There are multiple solutions if we are comparing against -1 and the LHS 1194 // of the ashr is not a power of two. 1195 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1196 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1197 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1198 } else if (AP1 == AP2.lshr(Shift)) { 1199 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1200 } 1201 } 1202 1203 // Shifting const2 will never be equal to const1. 1204 // FIXME: This should always be handled by InstSimplify? 1205 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1206 return replaceInstUsesWith(I, TorF); 1207 } 1208 1209 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1210 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1211 Instruction *InstCombiner::foldICmpShlConstConst(ICmpInst &I, Value *A, 1212 const APInt &AP1, 1213 const APInt &AP2) { 1214 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1215 1216 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1217 if (I.getPredicate() == I.ICMP_NE) 1218 Pred = CmpInst::getInversePredicate(Pred); 1219 return new ICmpInst(Pred, LHS, RHS); 1220 }; 1221 1222 // Don't bother doing any work for cases which InstSimplify handles. 1223 if (AP2.isNullValue()) 1224 return nullptr; 1225 1226 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1227 1228 if (!AP1 && AP2TrailingZeros != 0) 1229 return getICmp( 1230 I.ICMP_UGE, A, 1231 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1232 1233 if (AP1 == AP2) 1234 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1235 1236 // Get the distance between the lowest bits that are set. 1237 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1238 1239 if (Shift > 0 && AP2.shl(Shift) == AP1) 1240 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1241 1242 // Shifting const2 will never be equal to const1. 1243 // FIXME: This should always be handled by InstSimplify? 1244 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1245 return replaceInstUsesWith(I, TorF); 1246 } 1247 1248 /// The caller has matched a pattern of the form: 1249 /// I = icmp ugt (add (add A, B), CI2), CI1 1250 /// If this is of the form: 1251 /// sum = a + b 1252 /// if (sum+128 >u 255) 1253 /// Then replace it with llvm.sadd.with.overflow.i8. 1254 /// 1255 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1256 ConstantInt *CI2, ConstantInt *CI1, 1257 InstCombiner &IC) { 1258 // The transformation we're trying to do here is to transform this into an 1259 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1260 // with a narrower add, and discard the add-with-constant that is part of the 1261 // range check (if we can't eliminate it, this isn't profitable). 1262 1263 // In order to eliminate the add-with-constant, the compare can be its only 1264 // use. 1265 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1266 if (!AddWithCst->hasOneUse()) 1267 return nullptr; 1268 1269 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1270 if (!CI2->getValue().isPowerOf2()) 1271 return nullptr; 1272 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1273 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1274 return nullptr; 1275 1276 // The width of the new add formed is 1 more than the bias. 1277 ++NewWidth; 1278 1279 // Check to see that CI1 is an all-ones value with NewWidth bits. 1280 if (CI1->getBitWidth() == NewWidth || 1281 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1282 return nullptr; 1283 1284 // This is only really a signed overflow check if the inputs have been 1285 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1286 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1287 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1288 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1289 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1290 return nullptr; 1291 1292 // In order to replace the original add with a narrower 1293 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1294 // and truncates that discard the high bits of the add. Verify that this is 1295 // the case. 1296 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1297 for (User *U : OrigAdd->users()) { 1298 if (U == AddWithCst) 1299 continue; 1300 1301 // Only accept truncates for now. We would really like a nice recursive 1302 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1303 // chain to see which bits of a value are actually demanded. If the 1304 // original add had another add which was then immediately truncated, we 1305 // could still do the transformation. 1306 TruncInst *TI = dyn_cast<TruncInst>(U); 1307 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1308 return nullptr; 1309 } 1310 1311 // If the pattern matches, truncate the inputs to the narrower type and 1312 // use the sadd_with_overflow intrinsic to efficiently compute both the 1313 // result and the overflow bit. 1314 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1315 Function *F = Intrinsic::getDeclaration( 1316 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1317 1318 InstCombiner::BuilderTy &Builder = IC.Builder; 1319 1320 // Put the new code above the original add, in case there are any uses of the 1321 // add between the add and the compare. 1322 Builder.SetInsertPoint(OrigAdd); 1323 1324 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1325 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1326 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1327 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1328 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1329 1330 // The inner add was the result of the narrow add, zero extended to the 1331 // wider type. Replace it with the result computed by the intrinsic. 1332 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1333 IC.eraseInstFromFunction(*OrigAdd); 1334 1335 // The original icmp gets replaced with the overflow value. 1336 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1337 } 1338 1339 /// If we have: 1340 /// icmp eq/ne (urem/srem %x, %y), 0 1341 /// iff %y is a power-of-two, we can replace this with a bit test: 1342 /// icmp eq/ne (and %x, (add %y, -1)), 0 1343 Instruction *InstCombiner::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1344 // This fold is only valid for equality predicates. 1345 if (!I.isEquality()) 1346 return nullptr; 1347 ICmpInst::Predicate Pred; 1348 Value *X, *Y, *Zero; 1349 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1350 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1351 return nullptr; 1352 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1353 return nullptr; 1354 // This may increase instruction count, we don't enforce that Y is a constant. 1355 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1356 Value *Masked = Builder.CreateAnd(X, Mask); 1357 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1358 } 1359 1360 /// Fold equality-comparison between zero and any (maybe truncated) right-shift 1361 /// by one-less-than-bitwidth into a sign test on the original value. 1362 Instruction *InstCombiner::foldSignBitTest(ICmpInst &I) { 1363 Instruction *Val; 1364 ICmpInst::Predicate Pred; 1365 if (!I.isEquality() || !match(&I, m_ICmp(Pred, m_Instruction(Val), m_Zero()))) 1366 return nullptr; 1367 1368 Value *X; 1369 Type *XTy; 1370 1371 Constant *C; 1372 if (match(Val, m_TruncOrSelf(m_Shr(m_Value(X), m_Constant(C))))) { 1373 XTy = X->getType(); 1374 unsigned XBitWidth = XTy->getScalarSizeInBits(); 1375 if (!match(C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1376 APInt(XBitWidth, XBitWidth - 1)))) 1377 return nullptr; 1378 } else if (isa<BinaryOperator>(Val) && 1379 (X = reassociateShiftAmtsOfTwoSameDirectionShifts( 1380 cast<BinaryOperator>(Val), SQ.getWithInstruction(Val), 1381 /*AnalyzeForSignBitExtraction=*/true))) { 1382 XTy = X->getType(); 1383 } else 1384 return nullptr; 1385 1386 return ICmpInst::Create(Instruction::ICmp, 1387 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_SGE 1388 : ICmpInst::ICMP_SLT, 1389 X, ConstantInt::getNullValue(XTy)); 1390 } 1391 1392 // Handle icmp pred X, 0 1393 Instruction *InstCombiner::foldICmpWithZero(ICmpInst &Cmp) { 1394 CmpInst::Predicate Pred = Cmp.getPredicate(); 1395 if (!match(Cmp.getOperand(1), m_Zero())) 1396 return nullptr; 1397 1398 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1399 if (Pred == ICmpInst::ICMP_SGT) { 1400 Value *A, *B; 1401 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B); 1402 if (SPR.Flavor == SPF_SMIN) { 1403 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1404 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1405 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1406 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1407 } 1408 } 1409 1410 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1411 return New; 1412 1413 // Given: 1414 // icmp eq/ne (urem %x, %y), 0 1415 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1416 // icmp eq/ne %x, 0 1417 Value *X, *Y; 1418 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1419 ICmpInst::isEquality(Pred)) { 1420 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1421 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1422 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1423 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1424 } 1425 1426 return nullptr; 1427 } 1428 1429 /// Fold icmp Pred X, C. 1430 /// TODO: This code structure does not make sense. The saturating add fold 1431 /// should be moved to some other helper and extended as noted below (it is also 1432 /// possible that code has been made unnecessary - do we canonicalize IR to 1433 /// overflow/saturating intrinsics or not?). 1434 Instruction *InstCombiner::foldICmpWithConstant(ICmpInst &Cmp) { 1435 // Match the following pattern, which is a common idiom when writing 1436 // overflow-safe integer arithmetic functions. The source performs an addition 1437 // in wider type and explicitly checks for overflow using comparisons against 1438 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1439 // 1440 // TODO: This could probably be generalized to handle other overflow-safe 1441 // operations if we worked out the formulas to compute the appropriate magic 1442 // constants. 1443 // 1444 // sum = a + b 1445 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1446 CmpInst::Predicate Pred = Cmp.getPredicate(); 1447 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1448 Value *A, *B; 1449 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1450 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1451 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1452 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1453 return Res; 1454 1455 return nullptr; 1456 } 1457 1458 /// Canonicalize icmp instructions based on dominating conditions. 1459 Instruction *InstCombiner::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1460 // This is a cheap/incomplete check for dominance - just match a single 1461 // predecessor with a conditional branch. 1462 BasicBlock *CmpBB = Cmp.getParent(); 1463 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1464 if (!DomBB) 1465 return nullptr; 1466 1467 Value *DomCond; 1468 BasicBlock *TrueBB, *FalseBB; 1469 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1470 return nullptr; 1471 1472 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1473 "Predecessor block does not point to successor?"); 1474 1475 // The branch should get simplified. Don't bother simplifying this condition. 1476 if (TrueBB == FalseBB) 1477 return nullptr; 1478 1479 // Try to simplify this compare to T/F based on the dominating condition. 1480 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1481 if (Imp) 1482 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1483 1484 CmpInst::Predicate Pred = Cmp.getPredicate(); 1485 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1486 ICmpInst::Predicate DomPred; 1487 const APInt *C, *DomC; 1488 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1489 match(Y, m_APInt(C))) { 1490 // We have 2 compares of a variable with constants. Calculate the constant 1491 // ranges of those compares to see if we can transform the 2nd compare: 1492 // DomBB: 1493 // DomCond = icmp DomPred X, DomC 1494 // br DomCond, CmpBB, FalseBB 1495 // CmpBB: 1496 // Cmp = icmp Pred X, C 1497 ConstantRange CR = ConstantRange::makeAllowedICmpRegion(Pred, *C); 1498 ConstantRange DominatingCR = 1499 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1500 : ConstantRange::makeExactICmpRegion( 1501 CmpInst::getInversePredicate(DomPred), *DomC); 1502 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1503 ConstantRange Difference = DominatingCR.difference(CR); 1504 if (Intersection.isEmptySet()) 1505 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1506 if (Difference.isEmptySet()) 1507 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1508 1509 // Canonicalizing a sign bit comparison that gets used in a branch, 1510 // pessimizes codegen by generating branch on zero instruction instead 1511 // of a test and branch. So we avoid canonicalizing in such situations 1512 // because test and branch instruction has better branch displacement 1513 // than compare and branch instruction. 1514 bool UnusedBit; 1515 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1516 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1517 return nullptr; 1518 1519 if (const APInt *EqC = Intersection.getSingleElement()) 1520 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1521 if (const APInt *NeC = Difference.getSingleElement()) 1522 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1523 } 1524 1525 return nullptr; 1526 } 1527 1528 /// Fold icmp (trunc X, Y), C. 1529 Instruction *InstCombiner::foldICmpTruncConstant(ICmpInst &Cmp, 1530 TruncInst *Trunc, 1531 const APInt &C) { 1532 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1533 Value *X = Trunc->getOperand(0); 1534 if (C.isOneValue() && C.getBitWidth() > 1) { 1535 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1536 Value *V = nullptr; 1537 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1538 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1539 ConstantInt::get(V->getType(), 1)); 1540 } 1541 1542 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1543 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1544 // of the high bits truncated out of x are known. 1545 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1546 SrcBits = X->getType()->getScalarSizeInBits(); 1547 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1548 1549 // If all the high bits are known, we can do this xform. 1550 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1551 // Pull in the high bits from known-ones set. 1552 APInt NewRHS = C.zext(SrcBits); 1553 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1554 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1555 } 1556 } 1557 1558 return nullptr; 1559 } 1560 1561 /// Fold icmp (xor X, Y), C. 1562 Instruction *InstCombiner::foldICmpXorConstant(ICmpInst &Cmp, 1563 BinaryOperator *Xor, 1564 const APInt &C) { 1565 Value *X = Xor->getOperand(0); 1566 Value *Y = Xor->getOperand(1); 1567 const APInt *XorC; 1568 if (!match(Y, m_APInt(XorC))) 1569 return nullptr; 1570 1571 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1572 // fold the xor. 1573 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1574 bool TrueIfSigned = false; 1575 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1576 1577 // If the sign bit of the XorCst is not set, there is no change to 1578 // the operation, just stop using the Xor. 1579 if (!XorC->isNegative()) 1580 return replaceOperand(Cmp, 0, X); 1581 1582 // Emit the opposite comparison. 1583 if (TrueIfSigned) 1584 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1585 ConstantInt::getAllOnesValue(X->getType())); 1586 else 1587 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1588 ConstantInt::getNullValue(X->getType())); 1589 } 1590 1591 if (Xor->hasOneUse()) { 1592 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1593 if (!Cmp.isEquality() && XorC->isSignMask()) { 1594 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1595 : Cmp.getSignedPredicate(); 1596 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1597 } 1598 1599 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1600 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1601 Pred = Cmp.isSigned() ? Cmp.getUnsignedPredicate() 1602 : Cmp.getSignedPredicate(); 1603 Pred = Cmp.getSwappedPredicate(Pred); 1604 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1605 } 1606 } 1607 1608 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1609 if (Pred == ICmpInst::ICMP_UGT) { 1610 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1611 if (*XorC == ~C && (C + 1).isPowerOf2()) 1612 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1613 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1614 if (*XorC == C && (C + 1).isPowerOf2()) 1615 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1616 } 1617 if (Pred == ICmpInst::ICMP_ULT) { 1618 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1619 if (*XorC == -C && C.isPowerOf2()) 1620 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1621 ConstantInt::get(X->getType(), ~C)); 1622 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1623 if (*XorC == C && (-C).isPowerOf2()) 1624 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1625 ConstantInt::get(X->getType(), ~C)); 1626 } 1627 return nullptr; 1628 } 1629 1630 /// Fold icmp (and (sh X, Y), C2), C1. 1631 Instruction *InstCombiner::foldICmpAndShift(ICmpInst &Cmp, BinaryOperator *And, 1632 const APInt &C1, const APInt &C2) { 1633 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1634 if (!Shift || !Shift->isShift()) 1635 return nullptr; 1636 1637 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1638 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1639 // code produced by the clang front-end, for bitfield access. 1640 // This seemingly simple opportunity to fold away a shift turns out to be 1641 // rather complicated. See PR17827 for details. 1642 unsigned ShiftOpcode = Shift->getOpcode(); 1643 bool IsShl = ShiftOpcode == Instruction::Shl; 1644 const APInt *C3; 1645 if (match(Shift->getOperand(1), m_APInt(C3))) { 1646 APInt NewAndCst, NewCmpCst; 1647 bool AnyCmpCstBitsShiftedOut; 1648 if (ShiftOpcode == Instruction::Shl) { 1649 // For a left shift, we can fold if the comparison is not signed. We can 1650 // also fold a signed comparison if the mask value and comparison value 1651 // are not negative. These constraints may not be obvious, but we can 1652 // prove that they are correct using an SMT solver. 1653 if (Cmp.isSigned() && (C2.isNegative() || C1.isNegative())) 1654 return nullptr; 1655 1656 NewCmpCst = C1.lshr(*C3); 1657 NewAndCst = C2.lshr(*C3); 1658 AnyCmpCstBitsShiftedOut = NewCmpCst.shl(*C3) != C1; 1659 } else if (ShiftOpcode == Instruction::LShr) { 1660 // For a logical right shift, we can fold if the comparison is not signed. 1661 // We can also fold a signed comparison if the shifted mask value and the 1662 // shifted comparison value are not negative. These constraints may not be 1663 // obvious, but we can prove that they are correct using an SMT solver. 1664 NewCmpCst = C1.shl(*C3); 1665 NewAndCst = C2.shl(*C3); 1666 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1667 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1668 return nullptr; 1669 } else { 1670 // For an arithmetic shift, check that both constants don't use (in a 1671 // signed sense) the top bits being shifted out. 1672 assert(ShiftOpcode == Instruction::AShr && "Unknown shift opcode"); 1673 NewCmpCst = C1.shl(*C3); 1674 NewAndCst = C2.shl(*C3); 1675 AnyCmpCstBitsShiftedOut = NewCmpCst.ashr(*C3) != C1; 1676 if (NewAndCst.ashr(*C3) != C2) 1677 return nullptr; 1678 } 1679 1680 if (AnyCmpCstBitsShiftedOut) { 1681 // If we shifted bits out, the fold is not going to work out. As a 1682 // special case, check to see if this means that the result is always 1683 // true or false now. 1684 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1685 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1686 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1687 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1688 } else { 1689 Value *NewAnd = Builder.CreateAnd( 1690 Shift->getOperand(0), ConstantInt::get(And->getType(), NewAndCst)); 1691 return new ICmpInst(Cmp.getPredicate(), 1692 NewAnd, ConstantInt::get(And->getType(), NewCmpCst)); 1693 } 1694 } 1695 1696 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1697 // preferable because it allows the C2 << Y expression to be hoisted out of a 1698 // loop if Y is invariant and X is not. 1699 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() && 1700 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1701 // Compute C2 << Y. 1702 Value *NewShift = 1703 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1704 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1705 1706 // Compute X & (C2 << Y). 1707 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1708 return replaceOperand(Cmp, 0, NewAnd); 1709 } 1710 1711 return nullptr; 1712 } 1713 1714 /// Fold icmp (and X, C2), C1. 1715 Instruction *InstCombiner::foldICmpAndConstConst(ICmpInst &Cmp, 1716 BinaryOperator *And, 1717 const APInt &C1) { 1718 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1719 1720 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1721 // TODO: We canonicalize to the longer form for scalars because we have 1722 // better analysis/folds for icmp, and codegen may be better with icmp. 1723 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() && 1724 match(And->getOperand(1), m_One())) 1725 return new TruncInst(And->getOperand(0), Cmp.getType()); 1726 1727 const APInt *C2; 1728 Value *X; 1729 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1730 return nullptr; 1731 1732 // Don't perform the following transforms if the AND has multiple uses 1733 if (!And->hasOneUse()) 1734 return nullptr; 1735 1736 if (Cmp.isEquality() && C1.isNullValue()) { 1737 // Restrict this fold to single-use 'and' (PR10267). 1738 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1739 if (C2->isSignMask()) { 1740 Constant *Zero = Constant::getNullValue(X->getType()); 1741 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1742 return new ICmpInst(NewPred, X, Zero); 1743 } 1744 1745 // Restrict this fold only for single-use 'and' (PR10267). 1746 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1747 if ((~(*C2) + 1).isPowerOf2()) { 1748 Constant *NegBOC = 1749 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1750 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1751 return new ICmpInst(NewPred, X, NegBOC); 1752 } 1753 } 1754 1755 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1756 // the input width without changing the value produced, eliminate the cast: 1757 // 1758 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1759 // 1760 // We can do this transformation if the constants do not have their sign bits 1761 // set or if it is an equality comparison. Extending a relational comparison 1762 // when we're checking the sign bit would not work. 1763 Value *W; 1764 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1765 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1766 // TODO: Is this a good transform for vectors? Wider types may reduce 1767 // throughput. Should this transform be limited (even for scalars) by using 1768 // shouldChangeType()? 1769 if (!Cmp.getType()->isVectorTy()) { 1770 Type *WideType = W->getType(); 1771 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1772 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1773 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1774 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1775 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1776 } 1777 } 1778 1779 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1780 return I; 1781 1782 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1783 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1784 // 1785 // iff pred isn't signed 1786 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() && 1787 match(And->getOperand(1), m_One())) { 1788 Constant *One = cast<Constant>(And->getOperand(1)); 1789 Value *Or = And->getOperand(0); 1790 Value *A, *B, *LShr; 1791 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1792 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1793 unsigned UsesRemoved = 0; 1794 if (And->hasOneUse()) 1795 ++UsesRemoved; 1796 if (Or->hasOneUse()) 1797 ++UsesRemoved; 1798 if (LShr->hasOneUse()) 1799 ++UsesRemoved; 1800 1801 // Compute A & ((1 << B) | 1) 1802 Value *NewOr = nullptr; 1803 if (auto *C = dyn_cast<Constant>(B)) { 1804 if (UsesRemoved >= 1) 1805 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1806 } else { 1807 if (UsesRemoved >= 3) 1808 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1809 /*HasNUW=*/true), 1810 One, Or->getName()); 1811 } 1812 if (NewOr) { 1813 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1814 return replaceOperand(Cmp, 0, NewAnd); 1815 } 1816 } 1817 } 1818 1819 return nullptr; 1820 } 1821 1822 /// Fold icmp (and X, Y), C. 1823 Instruction *InstCombiner::foldICmpAndConstant(ICmpInst &Cmp, 1824 BinaryOperator *And, 1825 const APInt &C) { 1826 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1827 return I; 1828 1829 // TODO: These all require that Y is constant too, so refactor with the above. 1830 1831 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1832 Value *X = And->getOperand(0); 1833 Value *Y = And->getOperand(1); 1834 if (auto *LI = dyn_cast<LoadInst>(X)) 1835 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1836 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1837 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1838 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1839 ConstantInt *C2 = cast<ConstantInt>(Y); 1840 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1841 return Res; 1842 } 1843 1844 if (!Cmp.isEquality()) 1845 return nullptr; 1846 1847 // X & -C == -C -> X > u ~C 1848 // X & -C != -C -> X <= u ~C 1849 // iff C is a power of 2 1850 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) { 1851 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1852 : CmpInst::ICMP_ULE; 1853 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1854 } 1855 1856 // (X & C2) == 0 -> (trunc X) >= 0 1857 // (X & C2) != 0 -> (trunc X) < 0 1858 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1859 const APInt *C2; 1860 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) { 1861 int32_t ExactLogBase2 = C2->exactLogBase2(); 1862 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1863 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1864 if (auto *AndVTy = dyn_cast<VectorType>(And->getType())) 1865 NTy = VectorType::get(NTy, AndVTy->getNumElements()); 1866 Value *Trunc = Builder.CreateTrunc(X, NTy); 1867 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1868 : CmpInst::ICMP_SLT; 1869 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1870 } 1871 } 1872 1873 return nullptr; 1874 } 1875 1876 /// Fold icmp (or X, Y), C. 1877 Instruction *InstCombiner::foldICmpOrConstant(ICmpInst &Cmp, BinaryOperator *Or, 1878 const APInt &C) { 1879 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1880 if (C.isOneValue()) { 1881 // icmp slt signum(V) 1 --> icmp slt V, 1 1882 Value *V = nullptr; 1883 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1884 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1885 ConstantInt::get(V->getType(), 1)); 1886 } 1887 1888 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1889 if (Cmp.isEquality() && Cmp.getOperand(1) == OrOp1) { 1890 // X | C == C --> X <=u C 1891 // X | C != C --> X >u C 1892 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1893 if ((C + 1).isPowerOf2()) { 1894 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1895 return new ICmpInst(Pred, OrOp0, OrOp1); 1896 } 1897 // More general: are all bits outside of a mask constant set or not set? 1898 // X | C == C --> (X & ~C) == 0 1899 // X | C != C --> (X & ~C) != 0 1900 if (Or->hasOneUse()) { 1901 Value *A = Builder.CreateAnd(OrOp0, ~C); 1902 return new ICmpInst(Pred, A, ConstantInt::getNullValue(OrOp0->getType())); 1903 } 1904 } 1905 1906 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse()) 1907 return nullptr; 1908 1909 Value *P, *Q; 1910 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1911 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1912 // -> and (icmp eq P, null), (icmp eq Q, null). 1913 Value *CmpP = 1914 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1915 Value *CmpQ = 1916 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1917 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1918 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1919 } 1920 1921 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1922 // a shorter form that has more potential to be folded even further. 1923 Value *X1, *X2, *X3, *X4; 1924 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1925 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1926 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1927 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1928 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1929 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1930 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1931 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1932 } 1933 1934 return nullptr; 1935 } 1936 1937 /// Fold icmp (mul X, Y), C. 1938 Instruction *InstCombiner::foldICmpMulConstant(ICmpInst &Cmp, 1939 BinaryOperator *Mul, 1940 const APInt &C) { 1941 const APInt *MulC; 1942 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1943 return nullptr; 1944 1945 // If this is a test of the sign bit and the multiply is sign-preserving with 1946 // a constant operand, use the multiply LHS operand instead. 1947 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1948 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1949 if (MulC->isNegative()) 1950 Pred = ICmpInst::getSwappedPredicate(Pred); 1951 return new ICmpInst(Pred, Mul->getOperand(0), 1952 Constant::getNullValue(Mul->getType())); 1953 } 1954 1955 return nullptr; 1956 } 1957 1958 /// Fold icmp (shl 1, Y), C. 1959 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 1960 const APInt &C) { 1961 Value *Y; 1962 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 1963 return nullptr; 1964 1965 Type *ShiftType = Shl->getType(); 1966 unsigned TypeBits = C.getBitWidth(); 1967 bool CIsPowerOf2 = C.isPowerOf2(); 1968 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1969 if (Cmp.isUnsigned()) { 1970 // (1 << Y) pred C -> Y pred Log2(C) 1971 if (!CIsPowerOf2) { 1972 // (1 << Y) < 30 -> Y <= 4 1973 // (1 << Y) <= 30 -> Y <= 4 1974 // (1 << Y) >= 30 -> Y > 4 1975 // (1 << Y) > 30 -> Y > 4 1976 if (Pred == ICmpInst::ICMP_ULT) 1977 Pred = ICmpInst::ICMP_ULE; 1978 else if (Pred == ICmpInst::ICMP_UGE) 1979 Pred = ICmpInst::ICMP_UGT; 1980 } 1981 1982 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 1983 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 1984 unsigned CLog2 = C.logBase2(); 1985 if (CLog2 == TypeBits - 1) { 1986 if (Pred == ICmpInst::ICMP_UGE) 1987 Pred = ICmpInst::ICMP_EQ; 1988 else if (Pred == ICmpInst::ICMP_ULT) 1989 Pred = ICmpInst::ICMP_NE; 1990 } 1991 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 1992 } else if (Cmp.isSigned()) { 1993 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 1994 if (C.isAllOnesValue()) { 1995 // (1 << Y) <= -1 -> Y == 31 1996 if (Pred == ICmpInst::ICMP_SLE) 1997 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 1998 1999 // (1 << Y) > -1 -> Y != 31 2000 if (Pred == ICmpInst::ICMP_SGT) 2001 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2002 } else if (!C) { 2003 // (1 << Y) < 0 -> Y == 31 2004 // (1 << Y) <= 0 -> Y == 31 2005 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 2006 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2007 2008 // (1 << Y) >= 0 -> Y != 31 2009 // (1 << Y) > 0 -> Y != 31 2010 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 2011 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2012 } 2013 } else if (Cmp.isEquality() && CIsPowerOf2) { 2014 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 2015 } 2016 2017 return nullptr; 2018 } 2019 2020 /// Fold icmp (shl X, Y), C. 2021 Instruction *InstCombiner::foldICmpShlConstant(ICmpInst &Cmp, 2022 BinaryOperator *Shl, 2023 const APInt &C) { 2024 const APInt *ShiftVal; 2025 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 2026 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 2027 2028 const APInt *ShiftAmt; 2029 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 2030 return foldICmpShlOne(Cmp, Shl, C); 2031 2032 // Check that the shift amount is in range. If not, don't perform undefined 2033 // shifts. When the shift is visited, it will be simplified. 2034 unsigned TypeBits = C.getBitWidth(); 2035 if (ShiftAmt->uge(TypeBits)) 2036 return nullptr; 2037 2038 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2039 Value *X = Shl->getOperand(0); 2040 Type *ShType = Shl->getType(); 2041 2042 // NSW guarantees that we are only shifting out sign bits from the high bits, 2043 // so we can ASHR the compare constant without needing a mask and eliminate 2044 // the shift. 2045 if (Shl->hasNoSignedWrap()) { 2046 if (Pred == ICmpInst::ICMP_SGT) { 2047 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2048 APInt ShiftedC = C.ashr(*ShiftAmt); 2049 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2050 } 2051 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2052 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2053 APInt ShiftedC = C.ashr(*ShiftAmt); 2054 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2055 } 2056 if (Pred == ICmpInst::ICMP_SLT) { 2057 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2058 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2059 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2060 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2061 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2062 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2063 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2064 } 2065 // If this is a signed comparison to 0 and the shift is sign preserving, 2066 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2067 // do that if we're sure to not continue on in this function. 2068 if (isSignTest(Pred, C)) 2069 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2070 } 2071 2072 // NUW guarantees that we are only shifting out zero bits from the high bits, 2073 // so we can LSHR the compare constant without needing a mask and eliminate 2074 // the shift. 2075 if (Shl->hasNoUnsignedWrap()) { 2076 if (Pred == ICmpInst::ICMP_UGT) { 2077 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2078 APInt ShiftedC = C.lshr(*ShiftAmt); 2079 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2080 } 2081 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2082 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2083 APInt ShiftedC = C.lshr(*ShiftAmt); 2084 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2085 } 2086 if (Pred == ICmpInst::ICMP_ULT) { 2087 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2088 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2089 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2090 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2091 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2092 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2093 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2094 } 2095 } 2096 2097 if (Cmp.isEquality() && Shl->hasOneUse()) { 2098 // Strength-reduce the shift into an 'and'. 2099 Constant *Mask = ConstantInt::get( 2100 ShType, 2101 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2102 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2103 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2104 return new ICmpInst(Pred, And, LShrC); 2105 } 2106 2107 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2108 bool TrueIfSigned = false; 2109 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2110 // (X << 31) <s 0 --> (X & 1) != 0 2111 Constant *Mask = ConstantInt::get( 2112 ShType, 2113 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2114 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2115 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2116 And, Constant::getNullValue(ShType)); 2117 } 2118 2119 // Simplify 'shl' inequality test into 'and' equality test. 2120 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2121 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2122 if ((C + 1).isPowerOf2() && 2123 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2124 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2125 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2126 : ICmpInst::ICMP_NE, 2127 And, Constant::getNullValue(ShType)); 2128 } 2129 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2130 if (C.isPowerOf2() && 2131 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2132 Value *And = 2133 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2134 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2135 : ICmpInst::ICMP_NE, 2136 And, Constant::getNullValue(ShType)); 2137 } 2138 } 2139 2140 // Transform (icmp pred iM (shl iM %v, N), C) 2141 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2142 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2143 // This enables us to get rid of the shift in favor of a trunc that may be 2144 // free on the target. It has the additional benefit of comparing to a 2145 // smaller constant that may be more target-friendly. 2146 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2147 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2148 DL.isLegalInteger(TypeBits - Amt)) { 2149 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2150 if (auto *ShVTy = dyn_cast<VectorType>(ShType)) 2151 TruncTy = VectorType::get(TruncTy, ShVTy->getNumElements()); 2152 Constant *NewC = 2153 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2154 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2155 } 2156 2157 return nullptr; 2158 } 2159 2160 /// Fold icmp ({al}shr X, Y), C. 2161 Instruction *InstCombiner::foldICmpShrConstant(ICmpInst &Cmp, 2162 BinaryOperator *Shr, 2163 const APInt &C) { 2164 // An exact shr only shifts out zero bits, so: 2165 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2166 Value *X = Shr->getOperand(0); 2167 CmpInst::Predicate Pred = Cmp.getPredicate(); 2168 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && 2169 C.isNullValue()) 2170 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2171 2172 const APInt *ShiftVal; 2173 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2174 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2175 2176 const APInt *ShiftAmt; 2177 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2178 return nullptr; 2179 2180 // Check that the shift amount is in range. If not, don't perform undefined 2181 // shifts. When the shift is visited it will be simplified. 2182 unsigned TypeBits = C.getBitWidth(); 2183 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2184 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2185 return nullptr; 2186 2187 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2188 bool IsExact = Shr->isExact(); 2189 Type *ShrTy = Shr->getType(); 2190 // TODO: If we could guarantee that InstSimplify would handle all of the 2191 // constant-value-based preconditions in the folds below, then we could assert 2192 // those conditions rather than checking them. This is difficult because of 2193 // undef/poison (PR34838). 2194 if (IsAShr) { 2195 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) { 2196 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC) 2197 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC) 2198 APInt ShiftedC = C.shl(ShAmtVal); 2199 if (ShiftedC.ashr(ShAmtVal) == C) 2200 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2201 } 2202 if (Pred == CmpInst::ICMP_SGT) { 2203 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2204 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2205 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2206 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2207 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2208 } 2209 } else { 2210 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2211 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2212 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2213 APInt ShiftedC = C.shl(ShAmtVal); 2214 if (ShiftedC.lshr(ShAmtVal) == C) 2215 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2216 } 2217 if (Pred == CmpInst::ICMP_UGT) { 2218 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2219 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2220 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2221 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2222 } 2223 } 2224 2225 if (!Cmp.isEquality()) 2226 return nullptr; 2227 2228 // Handle equality comparisons of shift-by-constant. 2229 2230 // If the comparison constant changes with the shift, the comparison cannot 2231 // succeed (bits of the comparison constant cannot match the shifted value). 2232 // This should be known by InstSimplify and already be folded to true/false. 2233 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2234 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2235 "Expected icmp+shr simplify did not occur."); 2236 2237 // If the bits shifted out are known zero, compare the unshifted value: 2238 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2239 if (Shr->isExact()) 2240 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2241 2242 if (Shr->hasOneUse()) { 2243 // Canonicalize the shift into an 'and': 2244 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2245 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2246 Constant *Mask = ConstantInt::get(ShrTy, Val); 2247 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2248 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2249 } 2250 2251 return nullptr; 2252 } 2253 2254 Instruction *InstCombiner::foldICmpSRemConstant(ICmpInst &Cmp, 2255 BinaryOperator *SRem, 2256 const APInt &C) { 2257 // Match an 'is positive' or 'is negative' comparison of remainder by a 2258 // constant power-of-2 value: 2259 // (X % pow2C) sgt/slt 0 2260 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 2261 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT) 2262 return nullptr; 2263 2264 // TODO: The one-use check is standard because we do not typically want to 2265 // create longer instruction sequences, but this might be a special-case 2266 // because srem is not good for analysis or codegen. 2267 if (!SRem->hasOneUse()) 2268 return nullptr; 2269 2270 const APInt *DivisorC; 2271 if (!C.isNullValue() || !match(SRem->getOperand(1), m_Power2(DivisorC))) 2272 return nullptr; 2273 2274 // Mask off the sign bit and the modulo bits (low-bits). 2275 Type *Ty = SRem->getType(); 2276 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits()); 2277 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1)); 2278 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC); 2279 2280 // For 'is positive?' check that the sign-bit is clear and at least 1 masked 2281 // bit is set. Example: 2282 // (i8 X % 32) s> 0 --> (X & 159) s> 0 2283 if (Pred == ICmpInst::ICMP_SGT) 2284 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty)); 2285 2286 // For 'is negative?' check that the sign-bit is set and at least 1 masked 2287 // bit is set. Example: 2288 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768 2289 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask)); 2290 } 2291 2292 /// Fold icmp (udiv X, Y), C. 2293 Instruction *InstCombiner::foldICmpUDivConstant(ICmpInst &Cmp, 2294 BinaryOperator *UDiv, 2295 const APInt &C) { 2296 const APInt *C2; 2297 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2298 return nullptr; 2299 2300 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2301 2302 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2303 Value *Y = UDiv->getOperand(1); 2304 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2305 assert(!C.isMaxValue() && 2306 "icmp ugt X, UINT_MAX should have been simplified already."); 2307 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2308 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2309 } 2310 2311 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2312 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2313 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2314 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2315 ConstantInt::get(Y->getType(), C2->udiv(C))); 2316 } 2317 2318 return nullptr; 2319 } 2320 2321 /// Fold icmp ({su}div X, Y), C. 2322 Instruction *InstCombiner::foldICmpDivConstant(ICmpInst &Cmp, 2323 BinaryOperator *Div, 2324 const APInt &C) { 2325 // Fold: icmp pred ([us]div X, C2), C -> range test 2326 // Fold this div into the comparison, producing a range check. 2327 // Determine, based on the divide type, what the range is being 2328 // checked. If there is an overflow on the low or high side, remember 2329 // it, otherwise compute the range [low, hi) bounding the new value. 2330 // See: InsertRangeTest above for the kinds of replacements possible. 2331 const APInt *C2; 2332 if (!match(Div->getOperand(1), m_APInt(C2))) 2333 return nullptr; 2334 2335 // FIXME: If the operand types don't match the type of the divide 2336 // then don't attempt this transform. The code below doesn't have the 2337 // logic to deal with a signed divide and an unsigned compare (and 2338 // vice versa). This is because (x /s C2) <s C produces different 2339 // results than (x /s C2) <u C or (x /u C2) <s C or even 2340 // (x /u C2) <u C. Simply casting the operands and result won't 2341 // work. :( The if statement below tests that condition and bails 2342 // if it finds it. 2343 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2344 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2345 return nullptr; 2346 2347 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2348 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2349 // division-by-constant cases should be present, we can not assert that they 2350 // have happened before we reach this icmp instruction. 2351 if (C2->isNullValue() || C2->isOneValue() || 2352 (DivIsSigned && C2->isAllOnesValue())) 2353 return nullptr; 2354 2355 // Compute Prod = C * C2. We are essentially solving an equation of 2356 // form X / C2 = C. We solve for X by multiplying C2 and C. 2357 // By solving for X, we can turn this into a range check instead of computing 2358 // a divide. 2359 APInt Prod = C * *C2; 2360 2361 // Determine if the product overflows by seeing if the product is not equal to 2362 // the divide. Make sure we do the same kind of divide as in the LHS 2363 // instruction that we're folding. 2364 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2365 2366 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2367 2368 // If the division is known to be exact, then there is no remainder from the 2369 // divide, so the covered range size is unit, otherwise it is the divisor. 2370 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2371 2372 // Figure out the interval that is being checked. For example, a comparison 2373 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2374 // Compute this interval based on the constants involved and the signedness of 2375 // the compare/divide. This computes a half-open interval, keeping track of 2376 // whether either value in the interval overflows. After analysis each 2377 // overflow variable is set to 0 if it's corresponding bound variable is valid 2378 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2379 int LoOverflow = 0, HiOverflow = 0; 2380 APInt LoBound, HiBound; 2381 2382 if (!DivIsSigned) { // udiv 2383 // e.g. X/5 op 3 --> [15, 20) 2384 LoBound = Prod; 2385 HiOverflow = LoOverflow = ProdOV; 2386 if (!HiOverflow) { 2387 // If this is not an exact divide, then many values in the range collapse 2388 // to the same result value. 2389 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2390 } 2391 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2392 if (C.isNullValue()) { // (X / pos) op 0 2393 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2394 LoBound = -(RangeSize - 1); 2395 HiBound = RangeSize; 2396 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2397 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2398 HiOverflow = LoOverflow = ProdOV; 2399 if (!HiOverflow) 2400 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2401 } else { // (X / pos) op neg 2402 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2403 HiBound = Prod + 1; 2404 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2405 if (!LoOverflow) { 2406 APInt DivNeg = -RangeSize; 2407 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2408 } 2409 } 2410 } else if (C2->isNegative()) { // Divisor is < 0. 2411 if (Div->isExact()) 2412 RangeSize.negate(); 2413 if (C.isNullValue()) { // (X / neg) op 0 2414 // e.g. X/-5 op 0 --> [-4, 5) 2415 LoBound = RangeSize + 1; 2416 HiBound = -RangeSize; 2417 if (HiBound == *C2) { // -INTMIN = INTMIN 2418 HiOverflow = 1; // [INTMIN+1, overflow) 2419 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2420 } 2421 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2422 // e.g. X/-5 op 3 --> [-19, -14) 2423 HiBound = Prod + 1; 2424 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2425 if (!LoOverflow) 2426 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2427 } else { // (X / neg) op neg 2428 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2429 LoOverflow = HiOverflow = ProdOV; 2430 if (!HiOverflow) 2431 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2432 } 2433 2434 // Dividing by a negative swaps the condition. LT <-> GT 2435 Pred = ICmpInst::getSwappedPredicate(Pred); 2436 } 2437 2438 Value *X = Div->getOperand(0); 2439 switch (Pred) { 2440 default: llvm_unreachable("Unhandled icmp opcode!"); 2441 case ICmpInst::ICMP_EQ: 2442 if (LoOverflow && HiOverflow) 2443 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2444 if (HiOverflow) 2445 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2446 ICmpInst::ICMP_UGE, X, 2447 ConstantInt::get(Div->getType(), LoBound)); 2448 if (LoOverflow) 2449 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2450 ICmpInst::ICMP_ULT, X, 2451 ConstantInt::get(Div->getType(), HiBound)); 2452 return replaceInstUsesWith( 2453 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2454 case ICmpInst::ICMP_NE: 2455 if (LoOverflow && HiOverflow) 2456 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2457 if (HiOverflow) 2458 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2459 ICmpInst::ICMP_ULT, X, 2460 ConstantInt::get(Div->getType(), LoBound)); 2461 if (LoOverflow) 2462 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2463 ICmpInst::ICMP_UGE, X, 2464 ConstantInt::get(Div->getType(), HiBound)); 2465 return replaceInstUsesWith(Cmp, 2466 insertRangeTest(X, LoBound, HiBound, 2467 DivIsSigned, false)); 2468 case ICmpInst::ICMP_ULT: 2469 case ICmpInst::ICMP_SLT: 2470 if (LoOverflow == +1) // Low bound is greater than input range. 2471 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2472 if (LoOverflow == -1) // Low bound is less than input range. 2473 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2474 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2475 case ICmpInst::ICMP_UGT: 2476 case ICmpInst::ICMP_SGT: 2477 if (HiOverflow == +1) // High bound greater than input range. 2478 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2479 if (HiOverflow == -1) // High bound less than input range. 2480 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2481 if (Pred == ICmpInst::ICMP_UGT) 2482 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2483 ConstantInt::get(Div->getType(), HiBound)); 2484 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2485 ConstantInt::get(Div->getType(), HiBound)); 2486 } 2487 2488 return nullptr; 2489 } 2490 2491 /// Fold icmp (sub X, Y), C. 2492 Instruction *InstCombiner::foldICmpSubConstant(ICmpInst &Cmp, 2493 BinaryOperator *Sub, 2494 const APInt &C) { 2495 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2496 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2497 const APInt *C2; 2498 APInt SubResult; 2499 2500 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0 2501 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality()) 2502 return new ICmpInst(Cmp.getPredicate(), Y, 2503 ConstantInt::get(Y->getType(), 0)); 2504 2505 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2506 if (match(X, m_APInt(C2)) && 2507 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) || 2508 (Cmp.isSigned() && Sub->hasNoSignedWrap())) && 2509 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2510 return new ICmpInst(Cmp.getSwappedPredicate(), Y, 2511 ConstantInt::get(Y->getType(), SubResult)); 2512 2513 // The following transforms are only worth it if the only user of the subtract 2514 // is the icmp. 2515 if (!Sub->hasOneUse()) 2516 return nullptr; 2517 2518 if (Sub->hasNoSignedWrap()) { 2519 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2520 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue()) 2521 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2522 2523 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2524 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue()) 2525 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2526 2527 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2528 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue()) 2529 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2530 2531 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2532 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue()) 2533 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2534 } 2535 2536 if (!match(X, m_APInt(C2))) 2537 return nullptr; 2538 2539 // C2 - Y <u C -> (Y | (C - 1)) == C2 2540 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2541 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2542 (*C2 & (C - 1)) == (C - 1)) 2543 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2544 2545 // C2 - Y >u C -> (Y | C) != C2 2546 // iff C2 & C == C and C + 1 is a power of 2 2547 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2548 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2549 2550 return nullptr; 2551 } 2552 2553 /// Fold icmp (add X, Y), C. 2554 Instruction *InstCombiner::foldICmpAddConstant(ICmpInst &Cmp, 2555 BinaryOperator *Add, 2556 const APInt &C) { 2557 Value *Y = Add->getOperand(1); 2558 const APInt *C2; 2559 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2560 return nullptr; 2561 2562 // Fold icmp pred (add X, C2), C. 2563 Value *X = Add->getOperand(0); 2564 Type *Ty = Add->getType(); 2565 CmpInst::Predicate Pred = Cmp.getPredicate(); 2566 2567 // If the add does not wrap, we can always adjust the compare by subtracting 2568 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2569 // are canonicalized to SGT/SLT/UGT/ULT. 2570 if ((Add->hasNoSignedWrap() && 2571 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2572 (Add->hasNoUnsignedWrap() && 2573 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2574 bool Overflow; 2575 APInt NewC = 2576 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2577 // If there is overflow, the result must be true or false. 2578 // TODO: Can we assert there is no overflow because InstSimplify always 2579 // handles those cases? 2580 if (!Overflow) 2581 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2582 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2583 } 2584 2585 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2586 const APInt &Upper = CR.getUpper(); 2587 const APInt &Lower = CR.getLower(); 2588 if (Cmp.isSigned()) { 2589 if (Lower.isSignMask()) 2590 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2591 if (Upper.isSignMask()) 2592 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2593 } else { 2594 if (Lower.isMinValue()) 2595 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2596 if (Upper.isMinValue()) 2597 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2598 } 2599 2600 if (!Add->hasOneUse()) 2601 return nullptr; 2602 2603 // X+C <u C2 -> (X & -C2) == C 2604 // iff C & (C2-1) == 0 2605 // C2 is a power of 2 2606 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2607 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2608 ConstantExpr::getNeg(cast<Constant>(Y))); 2609 2610 // X+C >u C2 -> (X & ~C2) != C 2611 // iff C & C2 == 0 2612 // C2+1 is a power of 2 2613 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2614 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2615 ConstantExpr::getNeg(cast<Constant>(Y))); 2616 2617 return nullptr; 2618 } 2619 2620 bool InstCombiner::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2621 Value *&RHS, ConstantInt *&Less, 2622 ConstantInt *&Equal, 2623 ConstantInt *&Greater) { 2624 // TODO: Generalize this to work with other comparison idioms or ensure 2625 // they get canonicalized into this form. 2626 2627 // select i1 (a == b), 2628 // i32 Equal, 2629 // i32 (select i1 (a < b), i32 Less, i32 Greater) 2630 // where Equal, Less and Greater are placeholders for any three constants. 2631 ICmpInst::Predicate PredA; 2632 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) || 2633 !ICmpInst::isEquality(PredA)) 2634 return false; 2635 Value *EqualVal = SI->getTrueValue(); 2636 Value *UnequalVal = SI->getFalseValue(); 2637 // We still can get non-canonical predicate here, so canonicalize. 2638 if (PredA == ICmpInst::ICMP_NE) 2639 std::swap(EqualVal, UnequalVal); 2640 if (!match(EqualVal, m_ConstantInt(Equal))) 2641 return false; 2642 ICmpInst::Predicate PredB; 2643 Value *LHS2, *RHS2; 2644 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)), 2645 m_ConstantInt(Less), m_ConstantInt(Greater)))) 2646 return false; 2647 // We can get predicate mismatch here, so canonicalize if possible: 2648 // First, ensure that 'LHS' match. 2649 if (LHS2 != LHS) { 2650 // x sgt y <--> y slt x 2651 std::swap(LHS2, RHS2); 2652 PredB = ICmpInst::getSwappedPredicate(PredB); 2653 } 2654 if (LHS2 != LHS) 2655 return false; 2656 // We also need to canonicalize 'RHS'. 2657 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) { 2658 // x sgt C-1 <--> x sge C <--> not(x slt C) 2659 auto FlippedStrictness = 2660 getFlippedStrictnessPredicateAndConstant(PredB, cast<Constant>(RHS2)); 2661 if (!FlippedStrictness) 2662 return false; 2663 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && "Sanity check"); 2664 RHS2 = FlippedStrictness->second; 2665 // And kind-of perform the result swap. 2666 std::swap(Less, Greater); 2667 PredB = ICmpInst::ICMP_SLT; 2668 } 2669 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2; 2670 } 2671 2672 Instruction *InstCombiner::foldICmpSelectConstant(ICmpInst &Cmp, 2673 SelectInst *Select, 2674 ConstantInt *C) { 2675 2676 assert(C && "Cmp RHS should be a constant int!"); 2677 // If we're testing a constant value against the result of a three way 2678 // comparison, the result can be expressed directly in terms of the 2679 // original values being compared. Note: We could possibly be more 2680 // aggressive here and remove the hasOneUse test. The original select is 2681 // really likely to simplify or sink when we remove a test of the result. 2682 Value *OrigLHS, *OrigRHS; 2683 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2684 if (Cmp.hasOneUse() && 2685 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2686 C3GreaterThan)) { 2687 assert(C1LessThan && C2Equal && C3GreaterThan); 2688 2689 bool TrueWhenLessThan = 2690 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2691 ->isAllOnesValue(); 2692 bool TrueWhenEqual = 2693 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2694 ->isAllOnesValue(); 2695 bool TrueWhenGreaterThan = 2696 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2697 ->isAllOnesValue(); 2698 2699 // This generates the new instruction that will replace the original Cmp 2700 // Instruction. Instead of enumerating the various combinations when 2701 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2702 // false, we rely on chaining of ORs and future passes of InstCombine to 2703 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2704 2705 // When none of the three constants satisfy the predicate for the RHS (C), 2706 // the entire original Cmp can be simplified to a false. 2707 Value *Cond = Builder.getFalse(); 2708 if (TrueWhenLessThan) 2709 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2710 OrigLHS, OrigRHS)); 2711 if (TrueWhenEqual) 2712 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2713 OrigLHS, OrigRHS)); 2714 if (TrueWhenGreaterThan) 2715 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2716 OrigLHS, OrigRHS)); 2717 2718 return replaceInstUsesWith(Cmp, Cond); 2719 } 2720 return nullptr; 2721 } 2722 2723 static Instruction *foldICmpBitCast(ICmpInst &Cmp, 2724 InstCombiner::BuilderTy &Builder) { 2725 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2726 if (!Bitcast) 2727 return nullptr; 2728 2729 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2730 Value *Op1 = Cmp.getOperand(1); 2731 Value *BCSrcOp = Bitcast->getOperand(0); 2732 2733 // Make sure the bitcast doesn't change the number of vector elements. 2734 if (Bitcast->getSrcTy()->getScalarSizeInBits() == 2735 Bitcast->getDestTy()->getScalarSizeInBits()) { 2736 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2737 Value *X; 2738 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2739 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2740 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2741 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2742 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2743 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2744 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2745 match(Op1, m_Zero())) 2746 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2747 2748 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2749 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2750 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2751 2752 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2753 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2754 return new ICmpInst(Pred, X, 2755 ConstantInt::getAllOnesValue(X->getType())); 2756 } 2757 2758 // Zero-equality checks are preserved through unsigned floating-point casts: 2759 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2760 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2761 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2762 if (Cmp.isEquality() && match(Op1, m_Zero())) 2763 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2764 2765 // If this is a sign-bit test of a bitcast of a casted FP value, eliminate 2766 // the FP extend/truncate because that cast does not change the sign-bit. 2767 // This is true for all standard IEEE-754 types and the X86 80-bit type. 2768 // The sign-bit is always the most significant bit in those types. 2769 const APInt *C; 2770 bool TrueIfSigned; 2771 if (match(Op1, m_APInt(C)) && Bitcast->hasOneUse() && 2772 isSignBitCheck(Pred, *C, TrueIfSigned)) { 2773 if (match(BCSrcOp, m_FPExt(m_Value(X))) || 2774 match(BCSrcOp, m_FPTrunc(m_Value(X)))) { 2775 // (bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0 2776 // (bitcast (fpext/fptrunc X)) to iX) > -1 --> (bitcast X to iY) > -1 2777 Type *XType = X->getType(); 2778 2779 // We can't currently handle Power style floating point operations here. 2780 if (!(XType->isPPC_FP128Ty() || BCSrcOp->getType()->isPPC_FP128Ty())) { 2781 2782 Type *NewType = Builder.getIntNTy(XType->getScalarSizeInBits()); 2783 if (auto *XVTy = dyn_cast<VectorType>(XType)) 2784 NewType = VectorType::get(NewType, XVTy->getNumElements()); 2785 Value *NewBitcast = Builder.CreateBitCast(X, NewType); 2786 if (TrueIfSigned) 2787 return new ICmpInst(ICmpInst::ICMP_SLT, NewBitcast, 2788 ConstantInt::getNullValue(NewType)); 2789 else 2790 return new ICmpInst(ICmpInst::ICMP_SGT, NewBitcast, 2791 ConstantInt::getAllOnesValue(NewType)); 2792 } 2793 } 2794 } 2795 } 2796 2797 // Test to see if the operands of the icmp are casted versions of other 2798 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2799 if (Bitcast->getType()->isPointerTy() && 2800 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2801 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2802 // so eliminate it as well. 2803 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2804 Op1 = BC2->getOperand(0); 2805 2806 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType()); 2807 return new ICmpInst(Pred, BCSrcOp, Op1); 2808 } 2809 2810 // Folding: icmp <pred> iN X, C 2811 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 2812 // and C is a splat of a K-bit pattern 2813 // and SC is a constant vector = <C', C', C', ..., C'> 2814 // Into: 2815 // %E = extractelement <M x iK> %vec, i32 C' 2816 // icmp <pred> iK %E, trunc(C) 2817 const APInt *C; 2818 if (!match(Cmp.getOperand(1), m_APInt(C)) || 2819 !Bitcast->getType()->isIntegerTy() || 2820 !Bitcast->getSrcTy()->isIntOrIntVectorTy()) 2821 return nullptr; 2822 2823 Value *Vec; 2824 ArrayRef<int> Mask; 2825 if (match(BCSrcOp, m_ShuffleVector(m_Value(Vec), m_Undef(), m_Mask(Mask)))) { 2826 // Check whether every element of Mask is the same constant 2827 if (is_splat(Mask)) { 2828 auto *VecTy = cast<VectorType>(BCSrcOp->getType()); 2829 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 2830 if (C->isSplat(EltTy->getBitWidth())) { 2831 // Fold the icmp based on the value of C 2832 // If C is M copies of an iK sized bit pattern, 2833 // then: 2834 // => %E = extractelement <N x iK> %vec, i32 Elem 2835 // icmp <pred> iK %SplatVal, <pattern> 2836 Value *Elem = Builder.getInt32(Mask[0]); 2837 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 2838 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 2839 return new ICmpInst(Pred, Extract, NewC); 2840 } 2841 } 2842 } 2843 return nullptr; 2844 } 2845 2846 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2847 /// where X is some kind of instruction. 2848 Instruction *InstCombiner::foldICmpInstWithConstant(ICmpInst &Cmp) { 2849 const APInt *C; 2850 if (!match(Cmp.getOperand(1), m_APInt(C))) 2851 return nullptr; 2852 2853 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 2854 switch (BO->getOpcode()) { 2855 case Instruction::Xor: 2856 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C)) 2857 return I; 2858 break; 2859 case Instruction::And: 2860 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C)) 2861 return I; 2862 break; 2863 case Instruction::Or: 2864 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C)) 2865 return I; 2866 break; 2867 case Instruction::Mul: 2868 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C)) 2869 return I; 2870 break; 2871 case Instruction::Shl: 2872 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C)) 2873 return I; 2874 break; 2875 case Instruction::LShr: 2876 case Instruction::AShr: 2877 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C)) 2878 return I; 2879 break; 2880 case Instruction::SRem: 2881 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, *C)) 2882 return I; 2883 break; 2884 case Instruction::UDiv: 2885 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C)) 2886 return I; 2887 LLVM_FALLTHROUGH; 2888 case Instruction::SDiv: 2889 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C)) 2890 return I; 2891 break; 2892 case Instruction::Sub: 2893 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C)) 2894 return I; 2895 break; 2896 case Instruction::Add: 2897 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C)) 2898 return I; 2899 break; 2900 default: 2901 break; 2902 } 2903 // TODO: These folds could be refactored to be part of the above calls. 2904 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C)) 2905 return I; 2906 } 2907 2908 // Match against CmpInst LHS being instructions other than binary operators. 2909 2910 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 2911 // For now, we only support constant integers while folding the 2912 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 2913 // similar to the cases handled by binary ops above. 2914 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 2915 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 2916 return I; 2917 } 2918 2919 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 2920 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 2921 return I; 2922 } 2923 2924 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 2925 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 2926 return I; 2927 2928 return nullptr; 2929 } 2930 2931 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 2932 /// icmp eq/ne BO, C. 2933 Instruction *InstCombiner::foldICmpBinOpEqualityWithConstant(ICmpInst &Cmp, 2934 BinaryOperator *BO, 2935 const APInt &C) { 2936 // TODO: Some of these folds could work with arbitrary constants, but this 2937 // function is limited to scalar and vector splat constants. 2938 if (!Cmp.isEquality()) 2939 return nullptr; 2940 2941 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2942 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 2943 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 2944 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 2945 2946 switch (BO->getOpcode()) { 2947 case Instruction::SRem: 2948 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 2949 if (C.isNullValue() && BO->hasOneUse()) { 2950 const APInt *BOC; 2951 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 2952 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 2953 return new ICmpInst(Pred, NewRem, 2954 Constant::getNullValue(BO->getType())); 2955 } 2956 } 2957 break; 2958 case Instruction::Add: { 2959 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 2960 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2961 if (BO->hasOneUse()) 2962 return new ICmpInst(Pred, BOp0, ConstantExpr::getSub(RHS, BOC)); 2963 } else if (C.isNullValue()) { 2964 // Replace ((add A, B) != 0) with (A != -B) if A or B is 2965 // efficiently invertible, or if the add has just this one use. 2966 if (Value *NegVal = dyn_castNegVal(BOp1)) 2967 return new ICmpInst(Pred, BOp0, NegVal); 2968 if (Value *NegVal = dyn_castNegVal(BOp0)) 2969 return new ICmpInst(Pred, NegVal, BOp1); 2970 if (BO->hasOneUse()) { 2971 Value *Neg = Builder.CreateNeg(BOp1); 2972 Neg->takeName(BO); 2973 return new ICmpInst(Pred, BOp0, Neg); 2974 } 2975 } 2976 break; 2977 } 2978 case Instruction::Xor: 2979 if (BO->hasOneUse()) { 2980 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 2981 // For the xor case, we can xor two constants together, eliminating 2982 // the explicit xor. 2983 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 2984 } else if (C.isNullValue()) { 2985 // Replace ((xor A, B) != 0) with (A != B) 2986 return new ICmpInst(Pred, BOp0, BOp1); 2987 } 2988 } 2989 break; 2990 case Instruction::Sub: 2991 if (BO->hasOneUse()) { 2992 // Only check for constant LHS here, as constant RHS will be canonicalized 2993 // to add and use the fold above. 2994 if (Constant *BOC = dyn_cast<Constant>(BOp0)) { 2995 // Replace ((sub BOC, B) != C) with (B != BOC-C). 2996 return new ICmpInst(Pred, BOp1, ConstantExpr::getSub(BOC, RHS)); 2997 } else if (C.isNullValue()) { 2998 // Replace ((sub A, B) != 0) with (A != B). 2999 return new ICmpInst(Pred, BOp0, BOp1); 3000 } 3001 } 3002 break; 3003 case Instruction::Or: { 3004 const APInt *BOC; 3005 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 3006 // Comparing if all bits outside of a constant mask are set? 3007 // Replace (X | C) == -1 with (X & ~C) == ~C. 3008 // This removes the -1 constant. 3009 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 3010 Value *And = Builder.CreateAnd(BOp0, NotBOC); 3011 return new ICmpInst(Pred, And, NotBOC); 3012 } 3013 break; 3014 } 3015 case Instruction::And: { 3016 const APInt *BOC; 3017 if (match(BOp1, m_APInt(BOC))) { 3018 // If we have ((X & C) == C), turn it into ((X & C) != 0). 3019 if (C == *BOC && C.isPowerOf2()) 3020 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 3021 BO, Constant::getNullValue(RHS->getType())); 3022 } 3023 break; 3024 } 3025 case Instruction::Mul: 3026 if (C.isNullValue() && BO->hasNoSignedWrap()) { 3027 const APInt *BOC; 3028 if (match(BOp1, m_APInt(BOC)) && !BOC->isNullValue()) { 3029 // The trivial case (mul X, 0) is handled by InstSimplify. 3030 // General case : (mul X, C) != 0 iff X != 0 3031 // (mul X, C) == 0 iff X == 0 3032 return new ICmpInst(Pred, BOp0, Constant::getNullValue(RHS->getType())); 3033 } 3034 } 3035 break; 3036 case Instruction::UDiv: 3037 if (C.isNullValue()) { 3038 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 3039 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3040 return new ICmpInst(NewPred, BOp1, BOp0); 3041 } 3042 break; 3043 default: 3044 break; 3045 } 3046 return nullptr; 3047 } 3048 3049 /// Fold an equality icmp with LLVM intrinsic and constant operand. 3050 Instruction *InstCombiner::foldICmpEqIntrinsicWithConstant(ICmpInst &Cmp, 3051 IntrinsicInst *II, 3052 const APInt &C) { 3053 Type *Ty = II->getType(); 3054 unsigned BitWidth = C.getBitWidth(); 3055 switch (II->getIntrinsicID()) { 3056 case Intrinsic::bswap: 3057 // bswap(A) == C -> A == bswap(C) 3058 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3059 ConstantInt::get(Ty, C.byteSwap())); 3060 3061 case Intrinsic::ctlz: 3062 case Intrinsic::cttz: { 3063 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 3064 if (C == BitWidth) 3065 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3066 ConstantInt::getNullValue(Ty)); 3067 3068 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 3069 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 3070 // Limit to one use to ensure we don't increase instruction count. 3071 unsigned Num = C.getLimitedValue(BitWidth); 3072 if (Num != BitWidth && II->hasOneUse()) { 3073 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 3074 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 3075 : APInt::getHighBitsSet(BitWidth, Num + 1); 3076 APInt Mask2 = IsTrailing 3077 ? APInt::getOneBitSet(BitWidth, Num) 3078 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3079 return new ICmpInst(Cmp.getPredicate(), 3080 Builder.CreateAnd(II->getArgOperand(0), Mask1), 3081 ConstantInt::get(Ty, Mask2)); 3082 } 3083 break; 3084 } 3085 3086 case Intrinsic::ctpop: { 3087 // popcount(A) == 0 -> A == 0 and likewise for != 3088 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 3089 bool IsZero = C.isNullValue(); 3090 if (IsZero || C == BitWidth) 3091 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3092 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty)); 3093 3094 break; 3095 } 3096 3097 case Intrinsic::uadd_sat: { 3098 // uadd.sat(a, b) == 0 -> (a | b) == 0 3099 if (C.isNullValue()) { 3100 Value *Or = Builder.CreateOr(II->getArgOperand(0), II->getArgOperand(1)); 3101 return new ICmpInst(Cmp.getPredicate(), Or, Constant::getNullValue(Ty)); 3102 } 3103 break; 3104 } 3105 3106 case Intrinsic::usub_sat: { 3107 // usub.sat(a, b) == 0 -> a <= b 3108 if (C.isNullValue()) { 3109 ICmpInst::Predicate NewPred = Cmp.getPredicate() == ICmpInst::ICMP_EQ 3110 ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3111 return new ICmpInst(NewPred, II->getArgOperand(0), II->getArgOperand(1)); 3112 } 3113 break; 3114 } 3115 default: 3116 break; 3117 } 3118 3119 return nullptr; 3120 } 3121 3122 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 3123 Instruction *InstCombiner::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 3124 IntrinsicInst *II, 3125 const APInt &C) { 3126 if (Cmp.isEquality()) 3127 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 3128 3129 Type *Ty = II->getType(); 3130 unsigned BitWidth = C.getBitWidth(); 3131 switch (II->getIntrinsicID()) { 3132 case Intrinsic::ctlz: { 3133 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 3134 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3135 unsigned Num = C.getLimitedValue(); 3136 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3137 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 3138 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3139 } 3140 3141 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 3142 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && 3143 C.uge(1) && C.ule(BitWidth)) { 3144 unsigned Num = C.getLimitedValue(); 3145 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 3146 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 3147 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3148 } 3149 break; 3150 } 3151 case Intrinsic::cttz: { 3152 // Limit to one use to ensure we don't increase instruction count. 3153 if (!II->hasOneUse()) 3154 return nullptr; 3155 3156 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 3157 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3158 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 3159 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 3160 Builder.CreateAnd(II->getArgOperand(0), Mask), 3161 ConstantInt::getNullValue(Ty)); 3162 } 3163 3164 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3165 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT && 3166 C.uge(1) && C.ule(BitWidth)) { 3167 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3168 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3169 Builder.CreateAnd(II->getArgOperand(0), Mask), 3170 ConstantInt::getNullValue(Ty)); 3171 } 3172 break; 3173 } 3174 default: 3175 break; 3176 } 3177 3178 return nullptr; 3179 } 3180 3181 /// Handle icmp with constant (but not simple integer constant) RHS. 3182 Instruction *InstCombiner::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3183 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3184 Constant *RHSC = dyn_cast<Constant>(Op1); 3185 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3186 if (!RHSC || !LHSI) 3187 return nullptr; 3188 3189 switch (LHSI->getOpcode()) { 3190 case Instruction::GetElementPtr: 3191 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3192 if (RHSC->isNullValue() && 3193 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3194 return new ICmpInst( 3195 I.getPredicate(), LHSI->getOperand(0), 3196 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3197 break; 3198 case Instruction::PHI: 3199 // Only fold icmp into the PHI if the phi and icmp are in the same 3200 // block. If in the same block, we're encouraging jump threading. If 3201 // not, we are just pessimizing the code by making an i1 phi. 3202 if (LHSI->getParent() == I.getParent()) 3203 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3204 return NV; 3205 break; 3206 case Instruction::Select: { 3207 // If either operand of the select is a constant, we can fold the 3208 // comparison into the select arms, which will cause one to be 3209 // constant folded and the select turned into a bitwise or. 3210 Value *Op1 = nullptr, *Op2 = nullptr; 3211 ConstantInt *CI = nullptr; 3212 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(1))) { 3213 Op1 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3214 CI = dyn_cast<ConstantInt>(Op1); 3215 } 3216 if (Constant *C = dyn_cast<Constant>(LHSI->getOperand(2))) { 3217 Op2 = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3218 CI = dyn_cast<ConstantInt>(Op2); 3219 } 3220 3221 // We only want to perform this transformation if it will not lead to 3222 // additional code. This is true if either both sides of the select 3223 // fold to a constant (in which case the icmp is replaced with a select 3224 // which will usually simplify) or this is the only user of the 3225 // select (in which case we are trading a select+icmp for a simpler 3226 // select+icmp) or all uses of the select can be replaced based on 3227 // dominance information ("Global cases"). 3228 bool Transform = false; 3229 if (Op1 && Op2) 3230 Transform = true; 3231 else if (Op1 || Op2) { 3232 // Local case 3233 if (LHSI->hasOneUse()) 3234 Transform = true; 3235 // Global cases 3236 else if (CI && !CI->isZero()) 3237 // When Op1 is constant try replacing select with second operand. 3238 // Otherwise Op2 is constant and try replacing select with first 3239 // operand. 3240 Transform = 3241 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 3242 } 3243 if (Transform) { 3244 if (!Op1) 3245 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 3246 I.getName()); 3247 if (!Op2) 3248 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 3249 I.getName()); 3250 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 3251 } 3252 break; 3253 } 3254 case Instruction::IntToPtr: 3255 // icmp pred inttoptr(X), null -> icmp pred X, 0 3256 if (RHSC->isNullValue() && 3257 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3258 return new ICmpInst( 3259 I.getPredicate(), LHSI->getOperand(0), 3260 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3261 break; 3262 3263 case Instruction::Load: 3264 // Try to optimize things like "A[i] > 4" to index computations. 3265 if (GetElementPtrInst *GEP = 3266 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 3267 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3268 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 3269 !cast<LoadInst>(LHSI)->isVolatile()) 3270 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 3271 return Res; 3272 } 3273 break; 3274 } 3275 3276 return nullptr; 3277 } 3278 3279 /// Some comparisons can be simplified. 3280 /// In this case, we are looking for comparisons that look like 3281 /// a check for a lossy truncation. 3282 /// Folds: 3283 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3284 /// Where Mask is some pattern that produces all-ones in low bits: 3285 /// (-1 >> y) 3286 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3287 /// ~(-1 << y) 3288 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3289 /// The Mask can be a constant, too. 3290 /// For some predicates, the operands are commutative. 3291 /// For others, x can only be on a specific side. 3292 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3293 InstCombiner::BuilderTy &Builder) { 3294 ICmpInst::Predicate SrcPred; 3295 Value *X, *M, *Y; 3296 auto m_VariableMask = m_CombineOr( 3297 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3298 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3299 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3300 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3301 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3302 if (!match(&I, m_c_ICmp(SrcPred, 3303 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3304 m_Deferred(X)))) 3305 return nullptr; 3306 3307 ICmpInst::Predicate DstPred; 3308 switch (SrcPred) { 3309 case ICmpInst::Predicate::ICMP_EQ: 3310 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3311 DstPred = ICmpInst::Predicate::ICMP_ULE; 3312 break; 3313 case ICmpInst::Predicate::ICMP_NE: 3314 // x & (-1 >> y) != x -> x u> (-1 >> y) 3315 DstPred = ICmpInst::Predicate::ICMP_UGT; 3316 break; 3317 case ICmpInst::Predicate::ICMP_ULT: 3318 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3319 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3320 DstPred = ICmpInst::Predicate::ICMP_UGT; 3321 break; 3322 case ICmpInst::Predicate::ICMP_UGE: 3323 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3324 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3325 DstPred = ICmpInst::Predicate::ICMP_ULE; 3326 break; 3327 case ICmpInst::Predicate::ICMP_SLT: 3328 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3329 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3330 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3331 return nullptr; 3332 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3333 return nullptr; 3334 DstPred = ICmpInst::Predicate::ICMP_SGT; 3335 break; 3336 case ICmpInst::Predicate::ICMP_SGE: 3337 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3338 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3339 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3340 return nullptr; 3341 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3342 return nullptr; 3343 DstPred = ICmpInst::Predicate::ICMP_SLE; 3344 break; 3345 case ICmpInst::Predicate::ICMP_SGT: 3346 case ICmpInst::Predicate::ICMP_SLE: 3347 return nullptr; 3348 case ICmpInst::Predicate::ICMP_UGT: 3349 case ICmpInst::Predicate::ICMP_ULE: 3350 llvm_unreachable("Instsimplify took care of commut. variant"); 3351 break; 3352 default: 3353 llvm_unreachable("All possible folds are handled."); 3354 } 3355 3356 // The mask value may be a vector constant that has undefined elements. But it 3357 // may not be safe to propagate those undefs into the new compare, so replace 3358 // those elements by copying an existing, defined, and safe scalar constant. 3359 Type *OpTy = M->getType(); 3360 auto *VecC = dyn_cast<Constant>(M); 3361 if (OpTy->isVectorTy() && VecC && VecC->containsUndefElement()) { 3362 auto *OpVTy = cast<VectorType>(OpTy); 3363 Constant *SafeReplacementConstant = nullptr; 3364 for (unsigned i = 0, e = OpVTy->getNumElements(); i != e; ++i) { 3365 if (!isa<UndefValue>(VecC->getAggregateElement(i))) { 3366 SafeReplacementConstant = VecC->getAggregateElement(i); 3367 break; 3368 } 3369 } 3370 assert(SafeReplacementConstant && "Failed to find undef replacement"); 3371 M = Constant::replaceUndefsWith(VecC, SafeReplacementConstant); 3372 } 3373 3374 return Builder.CreateICmp(DstPred, X, M); 3375 } 3376 3377 /// Some comparisons can be simplified. 3378 /// In this case, we are looking for comparisons that look like 3379 /// a check for a lossy signed truncation. 3380 /// Folds: (MaskedBits is a constant.) 3381 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3382 /// Into: 3383 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3384 /// Where KeptBits = bitwidth(%x) - MaskedBits 3385 static Value * 3386 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3387 InstCombiner::BuilderTy &Builder) { 3388 ICmpInst::Predicate SrcPred; 3389 Value *X; 3390 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3391 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3392 if (!match(&I, m_c_ICmp(SrcPred, 3393 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3394 m_APInt(C1))), 3395 m_Deferred(X)))) 3396 return nullptr; 3397 3398 // Potential handling of non-splats: for each element: 3399 // * if both are undef, replace with constant 0. 3400 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3401 // * if both are not undef, and are different, bailout. 3402 // * else, only one is undef, then pick the non-undef one. 3403 3404 // The shift amount must be equal. 3405 if (*C0 != *C1) 3406 return nullptr; 3407 const APInt &MaskedBits = *C0; 3408 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3409 3410 ICmpInst::Predicate DstPred; 3411 switch (SrcPred) { 3412 case ICmpInst::Predicate::ICMP_EQ: 3413 // ((%x << MaskedBits) a>> MaskedBits) == %x 3414 // => 3415 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3416 DstPred = ICmpInst::Predicate::ICMP_ULT; 3417 break; 3418 case ICmpInst::Predicate::ICMP_NE: 3419 // ((%x << MaskedBits) a>> MaskedBits) != %x 3420 // => 3421 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3422 DstPred = ICmpInst::Predicate::ICMP_UGE; 3423 break; 3424 // FIXME: are more folds possible? 3425 default: 3426 return nullptr; 3427 } 3428 3429 auto *XType = X->getType(); 3430 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3431 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3432 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3433 3434 // KeptBits = bitwidth(%x) - MaskedBits 3435 const APInt KeptBits = BitWidth - MaskedBits; 3436 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3437 // ICmpCst = (1 << KeptBits) 3438 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3439 assert(ICmpCst.isPowerOf2()); 3440 // AddCst = (1 << (KeptBits-1)) 3441 const APInt AddCst = ICmpCst.lshr(1); 3442 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3443 3444 // T0 = add %x, AddCst 3445 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3446 // T1 = T0 DstPred ICmpCst 3447 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3448 3449 return T1; 3450 } 3451 3452 // Given pattern: 3453 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3454 // we should move shifts to the same hand of 'and', i.e. rewrite as 3455 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3456 // We are only interested in opposite logical shifts here. 3457 // One of the shifts can be truncated. 3458 // If we can, we want to end up creating 'lshr' shift. 3459 static Value * 3460 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3461 InstCombiner::BuilderTy &Builder) { 3462 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3463 !I.getOperand(0)->hasOneUse()) 3464 return nullptr; 3465 3466 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3467 3468 // Look for an 'and' of two logical shifts, one of which may be truncated. 3469 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3470 Instruction *XShift, *MaybeTruncation, *YShift; 3471 if (!match( 3472 I.getOperand(0), 3473 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3474 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3475 m_AnyLogicalShift, m_Instruction(YShift))), 3476 m_Instruction(MaybeTruncation))))) 3477 return nullptr; 3478 3479 // We potentially looked past 'trunc', but only when matching YShift, 3480 // therefore YShift must have the widest type. 3481 Instruction *WidestShift = YShift; 3482 // Therefore XShift must have the shallowest type. 3483 // Or they both have identical types if there was no truncation. 3484 Instruction *NarrowestShift = XShift; 3485 3486 Type *WidestTy = WidestShift->getType(); 3487 Type *NarrowestTy = NarrowestShift->getType(); 3488 assert(NarrowestTy == I.getOperand(0)->getType() && 3489 "We did not look past any shifts while matching XShift though."); 3490 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3491 3492 // If YShift is a 'lshr', swap the shifts around. 3493 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3494 std::swap(XShift, YShift); 3495 3496 // The shifts must be in opposite directions. 3497 auto XShiftOpcode = XShift->getOpcode(); 3498 if (XShiftOpcode == YShift->getOpcode()) 3499 return nullptr; // Do not care about same-direction shifts here. 3500 3501 Value *X, *XShAmt, *Y, *YShAmt; 3502 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3503 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3504 3505 // If one of the values being shifted is a constant, then we will end with 3506 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3507 // however, we will need to ensure that we won't increase instruction count. 3508 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3509 // At least one of the hands of the 'and' should be one-use shift. 3510 if (!match(I.getOperand(0), 3511 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3512 return nullptr; 3513 if (HadTrunc) { 3514 // Due to the 'trunc', we will need to widen X. For that either the old 3515 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3516 if (!MaybeTruncation->hasOneUse() && 3517 !NarrowestShift->getOperand(1)->hasOneUse()) 3518 return nullptr; 3519 } 3520 } 3521 3522 // We have two shift amounts from two different shifts. The types of those 3523 // shift amounts may not match. If that's the case let's bailout now. 3524 if (XShAmt->getType() != YShAmt->getType()) 3525 return nullptr; 3526 3527 // As input, we have the following pattern: 3528 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3529 // We want to rewrite that as: 3530 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3531 // While we know that originally (Q+K) would not overflow 3532 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 3533 // shift amounts. so it may now overflow in smaller bitwidth. 3534 // To ensure that does not happen, we need to ensure that the total maximal 3535 // shift amount is still representable in that smaller bit width. 3536 unsigned MaximalPossibleTotalShiftAmount = 3537 (WidestTy->getScalarSizeInBits() - 1) + 3538 (NarrowestTy->getScalarSizeInBits() - 1); 3539 APInt MaximalRepresentableShiftAmount = 3540 APInt::getAllOnesValue(XShAmt->getType()->getScalarSizeInBits()); 3541 if (MaximalRepresentableShiftAmount.ult(MaximalPossibleTotalShiftAmount)) 3542 return nullptr; 3543 3544 // Can we fold (XShAmt+YShAmt) ? 3545 auto *NewShAmt = dyn_cast_or_null<Constant>( 3546 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3547 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3548 if (!NewShAmt) 3549 return nullptr; 3550 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3551 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits(); 3552 3553 // Is the new shift amount smaller than the bit width? 3554 // FIXME: could also rely on ConstantRange. 3555 if (!match(NewShAmt, 3556 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 3557 APInt(WidestBitWidth, WidestBitWidth)))) 3558 return nullptr; 3559 3560 // An extra legality check is needed if we had trunc-of-lshr. 3561 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) { 3562 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ, 3563 WidestShift]() { 3564 // It isn't obvious whether it's worth it to analyze non-constants here. 3565 // Also, let's basically give up on non-splat cases, pessimizing vectors. 3566 // If *any* of these preconditions matches we can perform the fold. 3567 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy() 3568 ? NewShAmt->getSplatValue() 3569 : NewShAmt; 3570 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold. 3571 if (NewShAmtSplat && 3572 (NewShAmtSplat->isNullValue() || 3573 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1)) 3574 return true; 3575 // We consider *min* leading zeros so a single outlier 3576 // blocks the transform as opposed to allowing it. 3577 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) { 3578 KnownBits Known = computeKnownBits(C, SQ.DL); 3579 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3580 // If the value being shifted has at most lowest bit set we can fold. 3581 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3582 if (MaxActiveBits <= 1) 3583 return true; 3584 // Precondition: NewShAmt u<= countLeadingZeros(C) 3585 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero)) 3586 return true; 3587 } 3588 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) { 3589 KnownBits Known = computeKnownBits(C, SQ.DL); 3590 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3591 // If the value being shifted has at most lowest bit set we can fold. 3592 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3593 if (MaxActiveBits <= 1) 3594 return true; 3595 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C) 3596 if (NewShAmtSplat) { 3597 APInt AdjNewShAmt = 3598 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger(); 3599 if (AdjNewShAmt.ule(MinLeadZero)) 3600 return true; 3601 } 3602 } 3603 return false; // Can't tell if it's ok. 3604 }; 3605 if (!CanFold()) 3606 return nullptr; 3607 } 3608 3609 // All good, we can do this fold. 3610 X = Builder.CreateZExt(X, WidestTy); 3611 Y = Builder.CreateZExt(Y, WidestTy); 3612 // The shift is the same that was for X. 3613 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3614 ? Builder.CreateLShr(X, NewShAmt) 3615 : Builder.CreateShl(X, NewShAmt); 3616 Value *T1 = Builder.CreateAnd(T0, Y); 3617 return Builder.CreateICmp(I.getPredicate(), T1, 3618 Constant::getNullValue(WidestTy)); 3619 } 3620 3621 /// Fold 3622 /// (-1 u/ x) u< y 3623 /// ((x * y) u/ x) != y 3624 /// to 3625 /// @llvm.umul.with.overflow(x, y) plus extraction of overflow bit 3626 /// Note that the comparison is commutative, while inverted (u>=, ==) predicate 3627 /// will mean that we are looking for the opposite answer. 3628 Value *InstCombiner::foldUnsignedMultiplicationOverflowCheck(ICmpInst &I) { 3629 ICmpInst::Predicate Pred; 3630 Value *X, *Y; 3631 Instruction *Mul; 3632 bool NeedNegation; 3633 // Look for: (-1 u/ x) u</u>= y 3634 if (!I.isEquality() && 3635 match(&I, m_c_ICmp(Pred, m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))), 3636 m_Value(Y)))) { 3637 Mul = nullptr; 3638 3639 // Are we checking that overflow does not happen, or does happen? 3640 switch (Pred) { 3641 case ICmpInst::Predicate::ICMP_ULT: 3642 NeedNegation = false; 3643 break; // OK 3644 case ICmpInst::Predicate::ICMP_UGE: 3645 NeedNegation = true; 3646 break; // OK 3647 default: 3648 return nullptr; // Wrong predicate. 3649 } 3650 } else // Look for: ((x * y) u/ x) !=/== y 3651 if (I.isEquality() && 3652 match(&I, m_c_ICmp(Pred, m_Value(Y), 3653 m_OneUse(m_UDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y), 3654 m_Value(X)), 3655 m_Instruction(Mul)), 3656 m_Deferred(X)))))) { 3657 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ; 3658 } else 3659 return nullptr; 3660 3661 BuilderTy::InsertPointGuard Guard(Builder); 3662 // If the pattern included (x * y), we'll want to insert new instructions 3663 // right before that original multiplication so that we can replace it. 3664 bool MulHadOtherUses = Mul && !Mul->hasOneUse(); 3665 if (MulHadOtherUses) 3666 Builder.SetInsertPoint(Mul); 3667 3668 Function *F = Intrinsic::getDeclaration( 3669 I.getModule(), Intrinsic::umul_with_overflow, X->getType()); 3670 CallInst *Call = Builder.CreateCall(F, {X, Y}, "umul"); 3671 3672 // If the multiplication was used elsewhere, to ensure that we don't leave 3673 // "duplicate" instructions, replace uses of that original multiplication 3674 // with the multiplication result from the with.overflow intrinsic. 3675 if (MulHadOtherUses) 3676 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "umul.val")); 3677 3678 Value *Res = Builder.CreateExtractValue(Call, 1, "umul.ov"); 3679 if (NeedNegation) // This technically increases instruction count. 3680 Res = Builder.CreateNot(Res, "umul.not.ov"); 3681 3682 // If we replaced the mul, erase it. Do this after all uses of Builder, 3683 // as the mul is used as insertion point. 3684 if (MulHadOtherUses) 3685 eraseInstFromFunction(*Mul); 3686 3687 return Res; 3688 } 3689 3690 /// Try to fold icmp (binop), X or icmp X, (binop). 3691 /// TODO: A large part of this logic is duplicated in InstSimplify's 3692 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3693 /// duplication. 3694 Instruction *InstCombiner::foldICmpBinOp(ICmpInst &I, const SimplifyQuery &SQ) { 3695 const SimplifyQuery Q = SQ.getWithInstruction(&I); 3696 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3697 3698 // Special logic for binary operators. 3699 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3700 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3701 if (!BO0 && !BO1) 3702 return nullptr; 3703 3704 const CmpInst::Predicate Pred = I.getPredicate(); 3705 Value *X; 3706 3707 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 3708 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X 3709 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 3710 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3711 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 3712 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0 3713 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 3714 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3715 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 3716 3717 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 3718 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 3719 NoOp0WrapProblem = 3720 ICmpInst::isEquality(Pred) || 3721 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 3722 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 3723 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 3724 NoOp1WrapProblem = 3725 ICmpInst::isEquality(Pred) || 3726 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 3727 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 3728 3729 // Analyze the case when either Op0 or Op1 is an add instruction. 3730 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 3731 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 3732 if (BO0 && BO0->getOpcode() == Instruction::Add) { 3733 A = BO0->getOperand(0); 3734 B = BO0->getOperand(1); 3735 } 3736 if (BO1 && BO1->getOpcode() == Instruction::Add) { 3737 C = BO1->getOperand(0); 3738 D = BO1->getOperand(1); 3739 } 3740 3741 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow. 3742 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow. 3743 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 3744 return new ICmpInst(Pred, A == Op1 ? B : A, 3745 Constant::getNullValue(Op1->getType())); 3746 3747 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow. 3748 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow. 3749 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 3750 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 3751 C == Op0 ? D : C); 3752 3753 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow. 3754 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 3755 NoOp1WrapProblem) { 3756 // Determine Y and Z in the form icmp (X+Y), (X+Z). 3757 Value *Y, *Z; 3758 if (A == C) { 3759 // C + B == C + D -> B == D 3760 Y = B; 3761 Z = D; 3762 } else if (A == D) { 3763 // D + B == C + D -> B == C 3764 Y = B; 3765 Z = C; 3766 } else if (B == C) { 3767 // A + C == C + D -> A == D 3768 Y = A; 3769 Z = D; 3770 } else { 3771 assert(B == D); 3772 // A + D == C + D -> A == C 3773 Y = A; 3774 Z = C; 3775 } 3776 return new ICmpInst(Pred, Y, Z); 3777 } 3778 3779 // icmp slt (A + -1), Op1 -> icmp sle A, Op1 3780 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 3781 match(B, m_AllOnes())) 3782 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 3783 3784 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1 3785 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 3786 match(B, m_AllOnes())) 3787 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 3788 3789 // icmp sle (A + 1), Op1 -> icmp slt A, Op1 3790 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 3791 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 3792 3793 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1 3794 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 3795 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 3796 3797 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C 3798 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 3799 match(D, m_AllOnes())) 3800 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 3801 3802 // icmp sle Op0, (C + -1) -> icmp slt Op0, C 3803 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 3804 match(D, m_AllOnes())) 3805 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 3806 3807 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C 3808 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 3809 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 3810 3811 // icmp slt Op0, (C + 1) -> icmp sle Op0, C 3812 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 3813 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 3814 3815 // TODO: The subtraction-related identities shown below also hold, but 3816 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 3817 // wouldn't happen even if they were implemented. 3818 // 3819 // icmp ult (A - 1), Op1 -> icmp ule A, Op1 3820 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1 3821 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C 3822 // icmp ule Op0, (C - 1) -> icmp ult Op0, C 3823 3824 // icmp ule (A + 1), Op0 -> icmp ult A, Op1 3825 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 3826 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 3827 3828 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1 3829 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 3830 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 3831 3832 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C 3833 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 3834 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 3835 3836 // icmp ult Op0, (C + 1) -> icmp ule Op0, C 3837 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 3838 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 3839 3840 // if C1 has greater magnitude than C2: 3841 // icmp (A + C1), (C + C2) -> icmp (A + C3), C 3842 // s.t. C3 = C1 - C2 3843 // 3844 // if C2 has greater magnitude than C1: 3845 // icmp (A + C1), (C + C2) -> icmp A, (C + C3) 3846 // s.t. C3 = C2 - C1 3847 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 3848 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 3849 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 3850 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 3851 const APInt &AP1 = C1->getValue(); 3852 const APInt &AP2 = C2->getValue(); 3853 if (AP1.isNegative() == AP2.isNegative()) { 3854 APInt AP1Abs = C1->getValue().abs(); 3855 APInt AP2Abs = C2->getValue().abs(); 3856 if (AP1Abs.uge(AP2Abs)) { 3857 ConstantInt *C3 = Builder.getInt(AP1 - AP2); 3858 Value *NewAdd = Builder.CreateNSWAdd(A, C3); 3859 return new ICmpInst(Pred, NewAdd, C); 3860 } else { 3861 ConstantInt *C3 = Builder.getInt(AP2 - AP1); 3862 Value *NewAdd = Builder.CreateNSWAdd(C, C3); 3863 return new ICmpInst(Pred, A, NewAdd); 3864 } 3865 } 3866 } 3867 3868 // Analyze the case when either Op0 or Op1 is a sub instruction. 3869 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 3870 A = nullptr; 3871 B = nullptr; 3872 C = nullptr; 3873 D = nullptr; 3874 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 3875 A = BO0->getOperand(0); 3876 B = BO0->getOperand(1); 3877 } 3878 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 3879 C = BO1->getOperand(0); 3880 D = BO1->getOperand(1); 3881 } 3882 3883 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow. 3884 if (A == Op1 && NoOp0WrapProblem) 3885 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 3886 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow. 3887 if (C == Op0 && NoOp1WrapProblem) 3888 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 3889 3890 // Convert sub-with-unsigned-overflow comparisons into a comparison of args. 3891 // (A - B) u>/u<= A --> B u>/u<= A 3892 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3893 return new ICmpInst(Pred, B, A); 3894 // C u</u>= (C - D) --> C u</u>= D 3895 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3896 return new ICmpInst(Pred, C, D); 3897 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0 3898 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) && 3899 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 3900 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A); 3901 // C u<=/u> (C - D) --> C u</u>= D iff B != 0 3902 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) && 3903 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 3904 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D); 3905 3906 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow. 3907 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem) 3908 return new ICmpInst(Pred, A, C); 3909 3910 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow. 3911 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem) 3912 return new ICmpInst(Pred, D, B); 3913 3914 // icmp (0-X) < cst --> x > -cst 3915 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 3916 Value *X; 3917 if (match(BO0, m_Neg(m_Value(X)))) 3918 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 3919 if (RHSC->isNotMinSignedValue()) 3920 return new ICmpInst(I.getSwappedPredicate(), X, 3921 ConstantExpr::getNeg(RHSC)); 3922 } 3923 3924 BinaryOperator *SRem = nullptr; 3925 // icmp (srem X, Y), Y 3926 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 3927 SRem = BO0; 3928 // icmp Y, (srem X, Y) 3929 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 3930 Op0 == BO1->getOperand(1)) 3931 SRem = BO1; 3932 if (SRem) { 3933 // We don't check hasOneUse to avoid increasing register pressure because 3934 // the value we use is the same value this instruction was already using. 3935 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 3936 default: 3937 break; 3938 case ICmpInst::ICMP_EQ: 3939 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 3940 case ICmpInst::ICMP_NE: 3941 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 3942 case ICmpInst::ICMP_SGT: 3943 case ICmpInst::ICMP_SGE: 3944 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 3945 Constant::getAllOnesValue(SRem->getType())); 3946 case ICmpInst::ICMP_SLT: 3947 case ICmpInst::ICMP_SLE: 3948 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 3949 Constant::getNullValue(SRem->getType())); 3950 } 3951 } 3952 3953 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 3954 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 3955 switch (BO0->getOpcode()) { 3956 default: 3957 break; 3958 case Instruction::Add: 3959 case Instruction::Sub: 3960 case Instruction::Xor: { 3961 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 3962 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 3963 3964 const APInt *C; 3965 if (match(BO0->getOperand(1), m_APInt(C))) { 3966 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 3967 if (C->isSignMask()) { 3968 ICmpInst::Predicate NewPred = 3969 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3970 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3971 } 3972 3973 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 3974 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 3975 ICmpInst::Predicate NewPred = 3976 I.isSigned() ? I.getUnsignedPredicate() : I.getSignedPredicate(); 3977 NewPred = I.getSwappedPredicate(NewPred); 3978 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 3979 } 3980 } 3981 break; 3982 } 3983 case Instruction::Mul: { 3984 if (!I.isEquality()) 3985 break; 3986 3987 const APInt *C; 3988 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() && 3989 !C->isOneValue()) { 3990 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 3991 // Mask = -1 >> count-trailing-zeros(C). 3992 if (unsigned TZs = C->countTrailingZeros()) { 3993 Constant *Mask = ConstantInt::get( 3994 BO0->getType(), 3995 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 3996 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 3997 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 3998 return new ICmpInst(Pred, And1, And2); 3999 } 4000 // If there are no trailing zeros in the multiplier, just eliminate 4001 // the multiplies (no masking is needed): 4002 // icmp eq/ne (X * C), (Y * C) --> icmp eq/ne X, Y 4003 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4004 } 4005 break; 4006 } 4007 case Instruction::UDiv: 4008 case Instruction::LShr: 4009 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 4010 break; 4011 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4012 4013 case Instruction::SDiv: 4014 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 4015 break; 4016 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4017 4018 case Instruction::AShr: 4019 if (!BO0->isExact() || !BO1->isExact()) 4020 break; 4021 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4022 4023 case Instruction::Shl: { 4024 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 4025 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 4026 if (!NUW && !NSW) 4027 break; 4028 if (!NSW && I.isSigned()) 4029 break; 4030 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4031 } 4032 } 4033 } 4034 4035 if (BO0) { 4036 // Transform A & (L - 1) `ult` L --> L != 0 4037 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 4038 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 4039 4040 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 4041 auto *Zero = Constant::getNullValue(BO0->getType()); 4042 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 4043 } 4044 } 4045 4046 if (Value *V = foldUnsignedMultiplicationOverflowCheck(I)) 4047 return replaceInstUsesWith(I, V); 4048 4049 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 4050 return replaceInstUsesWith(I, V); 4051 4052 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 4053 return replaceInstUsesWith(I, V); 4054 4055 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 4056 return replaceInstUsesWith(I, V); 4057 4058 return nullptr; 4059 } 4060 4061 /// Fold icmp Pred min|max(X, Y), X. 4062 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 4063 ICmpInst::Predicate Pred = Cmp.getPredicate(); 4064 Value *Op0 = Cmp.getOperand(0); 4065 Value *X = Cmp.getOperand(1); 4066 4067 // Canonicalize minimum or maximum operand to LHS of the icmp. 4068 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 4069 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 4070 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 4071 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 4072 std::swap(Op0, X); 4073 Pred = Cmp.getSwappedPredicate(); 4074 } 4075 4076 Value *Y; 4077 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 4078 // smin(X, Y) == X --> X s<= Y 4079 // smin(X, Y) s>= X --> X s<= Y 4080 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 4081 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 4082 4083 // smin(X, Y) != X --> X s> Y 4084 // smin(X, Y) s< X --> X s> Y 4085 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 4086 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 4087 4088 // These cases should be handled in InstSimplify: 4089 // smin(X, Y) s<= X --> true 4090 // smin(X, Y) s> X --> false 4091 return nullptr; 4092 } 4093 4094 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 4095 // smax(X, Y) == X --> X s>= Y 4096 // smax(X, Y) s<= X --> X s>= Y 4097 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 4098 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 4099 4100 // smax(X, Y) != X --> X s< Y 4101 // smax(X, Y) s> X --> X s< Y 4102 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 4103 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 4104 4105 // These cases should be handled in InstSimplify: 4106 // smax(X, Y) s>= X --> true 4107 // smax(X, Y) s< X --> false 4108 return nullptr; 4109 } 4110 4111 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 4112 // umin(X, Y) == X --> X u<= Y 4113 // umin(X, Y) u>= X --> X u<= Y 4114 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 4115 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 4116 4117 // umin(X, Y) != X --> X u> Y 4118 // umin(X, Y) u< X --> X u> Y 4119 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 4120 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 4121 4122 // These cases should be handled in InstSimplify: 4123 // umin(X, Y) u<= X --> true 4124 // umin(X, Y) u> X --> false 4125 return nullptr; 4126 } 4127 4128 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 4129 // umax(X, Y) == X --> X u>= Y 4130 // umax(X, Y) u<= X --> X u>= Y 4131 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 4132 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 4133 4134 // umax(X, Y) != X --> X u< Y 4135 // umax(X, Y) u> X --> X u< Y 4136 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 4137 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 4138 4139 // These cases should be handled in InstSimplify: 4140 // umax(X, Y) u>= X --> true 4141 // umax(X, Y) u< X --> false 4142 return nullptr; 4143 } 4144 4145 return nullptr; 4146 } 4147 4148 Instruction *InstCombiner::foldICmpEquality(ICmpInst &I) { 4149 if (!I.isEquality()) 4150 return nullptr; 4151 4152 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4153 const CmpInst::Predicate Pred = I.getPredicate(); 4154 Value *A, *B, *C, *D; 4155 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 4156 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 4157 Value *OtherVal = A == Op1 ? B : A; 4158 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4159 } 4160 4161 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 4162 // A^c1 == C^c2 --> A == C^(c1^c2) 4163 ConstantInt *C1, *C2; 4164 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 4165 Op1->hasOneUse()) { 4166 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 4167 Value *Xor = Builder.CreateXor(C, NC); 4168 return new ICmpInst(Pred, A, Xor); 4169 } 4170 4171 // A^B == A^D -> B == D 4172 if (A == C) 4173 return new ICmpInst(Pred, B, D); 4174 if (A == D) 4175 return new ICmpInst(Pred, B, C); 4176 if (B == C) 4177 return new ICmpInst(Pred, A, D); 4178 if (B == D) 4179 return new ICmpInst(Pred, A, C); 4180 } 4181 } 4182 4183 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 4184 // A == (A^B) -> B == 0 4185 Value *OtherVal = A == Op0 ? B : A; 4186 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4187 } 4188 4189 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 4190 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 4191 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 4192 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 4193 4194 if (A == C) { 4195 X = B; 4196 Y = D; 4197 Z = A; 4198 } else if (A == D) { 4199 X = B; 4200 Y = C; 4201 Z = A; 4202 } else if (B == C) { 4203 X = A; 4204 Y = D; 4205 Z = B; 4206 } else if (B == D) { 4207 X = A; 4208 Y = C; 4209 Z = B; 4210 } 4211 4212 if (X) { // Build (X^Y) & Z 4213 Op1 = Builder.CreateXor(X, Y); 4214 Op1 = Builder.CreateAnd(Op1, Z); 4215 return new ICmpInst(Pred, Op1, Constant::getNullValue(Op1->getType())); 4216 } 4217 } 4218 4219 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 4220 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 4221 ConstantInt *Cst1; 4222 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 4223 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 4224 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 4225 match(Op1, m_ZExt(m_Value(A))))) { 4226 APInt Pow2 = Cst1->getValue() + 1; 4227 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 4228 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 4229 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 4230 } 4231 4232 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 4233 // For lshr and ashr pairs. 4234 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 4235 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 4236 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 4237 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 4238 unsigned TypeBits = Cst1->getBitWidth(); 4239 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4240 if (ShAmt < TypeBits && ShAmt != 0) { 4241 ICmpInst::Predicate NewPred = 4242 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 4243 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4244 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 4245 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 4246 } 4247 } 4248 4249 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 4250 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 4251 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 4252 unsigned TypeBits = Cst1->getBitWidth(); 4253 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4254 if (ShAmt < TypeBits && ShAmt != 0) { 4255 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4256 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 4257 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 4258 I.getName() + ".mask"); 4259 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 4260 } 4261 } 4262 4263 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 4264 // "icmp (and X, mask), cst" 4265 uint64_t ShAmt = 0; 4266 if (Op0->hasOneUse() && 4267 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 4268 match(Op1, m_ConstantInt(Cst1)) && 4269 // Only do this when A has multiple uses. This is most important to do 4270 // when it exposes other optimizations. 4271 !A->hasOneUse()) { 4272 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 4273 4274 if (ShAmt < ASize) { 4275 APInt MaskV = 4276 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 4277 MaskV <<= ShAmt; 4278 4279 APInt CmpV = Cst1->getValue().zext(ASize); 4280 CmpV <<= ShAmt; 4281 4282 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 4283 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 4284 } 4285 } 4286 4287 // If both operands are byte-swapped or bit-reversed, just compare the 4288 // original values. 4289 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant() 4290 // and handle more intrinsics. 4291 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) || 4292 (match(Op0, m_BitReverse(m_Value(A))) && 4293 match(Op1, m_BitReverse(m_Value(B))))) 4294 return new ICmpInst(Pred, A, B); 4295 4296 // Canonicalize checking for a power-of-2-or-zero value: 4297 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4298 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4299 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4300 m_Deferred(A)))) || 4301 !match(Op1, m_ZeroInt())) 4302 A = nullptr; 4303 4304 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4305 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4306 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4307 A = Op1; 4308 else if (match(Op1, 4309 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4310 A = Op0; 4311 4312 if (A) { 4313 Type *Ty = A->getType(); 4314 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4315 return Pred == ICmpInst::ICMP_EQ 4316 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4317 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4318 } 4319 4320 return nullptr; 4321 } 4322 4323 static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp, 4324 InstCombiner::BuilderTy &Builder) { 4325 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0"); 4326 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0)); 4327 Value *X; 4328 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X)))) 4329 return nullptr; 4330 4331 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt; 4332 bool IsSignedCmp = ICmp.isSigned(); 4333 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) { 4334 // If the signedness of the two casts doesn't agree (i.e. one is a sext 4335 // and the other is a zext), then we can't handle this. 4336 // TODO: This is too strict. We can handle some predicates (equality?). 4337 if (CastOp0->getOpcode() != CastOp1->getOpcode()) 4338 return nullptr; 4339 4340 // Not an extension from the same type? 4341 Value *Y = CastOp1->getOperand(0); 4342 Type *XTy = X->getType(), *YTy = Y->getType(); 4343 if (XTy != YTy) { 4344 // One of the casts must have one use because we are creating a new cast. 4345 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse()) 4346 return nullptr; 4347 // Extend the narrower operand to the type of the wider operand. 4348 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits()) 4349 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy); 4350 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits()) 4351 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy); 4352 else 4353 return nullptr; 4354 } 4355 4356 // (zext X) == (zext Y) --> X == Y 4357 // (sext X) == (sext Y) --> X == Y 4358 if (ICmp.isEquality()) 4359 return new ICmpInst(ICmp.getPredicate(), X, Y); 4360 4361 // A signed comparison of sign extended values simplifies into a 4362 // signed comparison. 4363 if (IsSignedCmp && IsSignedExt) 4364 return new ICmpInst(ICmp.getPredicate(), X, Y); 4365 4366 // The other three cases all fold into an unsigned comparison. 4367 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y); 4368 } 4369 4370 // Below here, we are only folding a compare with constant. 4371 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4372 if (!C) 4373 return nullptr; 4374 4375 // Compute the constant that would happen if we truncated to SrcTy then 4376 // re-extended to DestTy. 4377 Type *SrcTy = CastOp0->getSrcTy(); 4378 Type *DestTy = CastOp0->getDestTy(); 4379 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4380 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy); 4381 4382 // If the re-extended constant didn't change... 4383 if (Res2 == C) { 4384 if (ICmp.isEquality()) 4385 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4386 4387 // A signed comparison of sign extended values simplifies into a 4388 // signed comparison. 4389 if (IsSignedExt && IsSignedCmp) 4390 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4391 4392 // The other three cases all fold into an unsigned comparison. 4393 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1); 4394 } 4395 4396 // The re-extended constant changed, partly changed (in the case of a vector), 4397 // or could not be determined to be equal (in the case of a constant 4398 // expression), so the constant cannot be represented in the shorter type. 4399 // All the cases that fold to true or false will have already been handled 4400 // by SimplifyICmpInst, so only deal with the tricky case. 4401 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C)) 4402 return nullptr; 4403 4404 // Is source op positive? 4405 // icmp ult (sext X), C --> icmp sgt X, -1 4406 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4407 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy)); 4408 4409 // Is source op negative? 4410 // icmp ugt (sext X), C --> icmp slt X, 0 4411 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4412 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy)); 4413 } 4414 4415 /// Handle icmp (cast x), (cast or constant). 4416 Instruction *InstCombiner::foldICmpWithCastOp(ICmpInst &ICmp) { 4417 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0)); 4418 if (!CastOp0) 4419 return nullptr; 4420 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1))) 4421 return nullptr; 4422 4423 Value *Op0Src = CastOp0->getOperand(0); 4424 Type *SrcTy = CastOp0->getSrcTy(); 4425 Type *DestTy = CastOp0->getDestTy(); 4426 4427 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4428 // integer type is the same size as the pointer type. 4429 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) { 4430 if (isa<VectorType>(SrcTy)) { 4431 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4432 DestTy = cast<VectorType>(DestTy)->getElementType(); 4433 } 4434 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4435 }; 4436 if (CastOp0->getOpcode() == Instruction::PtrToInt && 4437 CompatibleSizes(SrcTy, DestTy)) { 4438 Value *NewOp1 = nullptr; 4439 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4440 Value *PtrSrc = PtrToIntOp1->getOperand(0); 4441 if (PtrSrc->getType()->getPointerAddressSpace() == 4442 Op0Src->getType()->getPointerAddressSpace()) { 4443 NewOp1 = PtrToIntOp1->getOperand(0); 4444 // If the pointer types don't match, insert a bitcast. 4445 if (Op0Src->getType() != NewOp1->getType()) 4446 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType()); 4447 } 4448 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4449 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4450 } 4451 4452 if (NewOp1) 4453 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1); 4454 } 4455 4456 return foldICmpWithZextOrSext(ICmp, Builder); 4457 } 4458 4459 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4460 switch (BinaryOp) { 4461 default: 4462 llvm_unreachable("Unsupported binary op"); 4463 case Instruction::Add: 4464 case Instruction::Sub: 4465 return match(RHS, m_Zero()); 4466 case Instruction::Mul: 4467 return match(RHS, m_One()); 4468 } 4469 } 4470 4471 OverflowResult InstCombiner::computeOverflow( 4472 Instruction::BinaryOps BinaryOp, bool IsSigned, 4473 Value *LHS, Value *RHS, Instruction *CxtI) const { 4474 switch (BinaryOp) { 4475 default: 4476 llvm_unreachable("Unsupported binary op"); 4477 case Instruction::Add: 4478 if (IsSigned) 4479 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4480 else 4481 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4482 case Instruction::Sub: 4483 if (IsSigned) 4484 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4485 else 4486 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4487 case Instruction::Mul: 4488 if (IsSigned) 4489 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4490 else 4491 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4492 } 4493 } 4494 4495 bool InstCombiner::OptimizeOverflowCheck( 4496 Instruction::BinaryOps BinaryOp, bool IsSigned, Value *LHS, Value *RHS, 4497 Instruction &OrigI, Value *&Result, Constant *&Overflow) { 4498 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4499 std::swap(LHS, RHS); 4500 4501 // If the overflow check was an add followed by a compare, the insertion point 4502 // may be pointing to the compare. We want to insert the new instructions 4503 // before the add in case there are uses of the add between the add and the 4504 // compare. 4505 Builder.SetInsertPoint(&OrigI); 4506 4507 if (isNeutralValue(BinaryOp, RHS)) { 4508 Result = LHS; 4509 Overflow = Builder.getFalse(); 4510 return true; 4511 } 4512 4513 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4514 case OverflowResult::MayOverflow: 4515 return false; 4516 case OverflowResult::AlwaysOverflowsLow: 4517 case OverflowResult::AlwaysOverflowsHigh: 4518 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4519 Result->takeName(&OrigI); 4520 Overflow = Builder.getTrue(); 4521 return true; 4522 case OverflowResult::NeverOverflows: 4523 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4524 Result->takeName(&OrigI); 4525 Overflow = Builder.getFalse(); 4526 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4527 if (IsSigned) 4528 Inst->setHasNoSignedWrap(); 4529 else 4530 Inst->setHasNoUnsignedWrap(); 4531 } 4532 return true; 4533 } 4534 4535 llvm_unreachable("Unexpected overflow result"); 4536 } 4537 4538 /// Recognize and process idiom involving test for multiplication 4539 /// overflow. 4540 /// 4541 /// The caller has matched a pattern of the form: 4542 /// I = cmp u (mul(zext A, zext B), V 4543 /// The function checks if this is a test for overflow and if so replaces 4544 /// multiplication with call to 'mul.with.overflow' intrinsic. 4545 /// 4546 /// \param I Compare instruction. 4547 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 4548 /// the compare instruction. Must be of integer type. 4549 /// \param OtherVal The other argument of compare instruction. 4550 /// \returns Instruction which must replace the compare instruction, NULL if no 4551 /// replacement required. 4552 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 4553 Value *OtherVal, InstCombiner &IC) { 4554 // Don't bother doing this transformation for pointers, don't do it for 4555 // vectors. 4556 if (!isa<IntegerType>(MulVal->getType())) 4557 return nullptr; 4558 4559 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 4560 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 4561 auto *MulInstr = dyn_cast<Instruction>(MulVal); 4562 if (!MulInstr) 4563 return nullptr; 4564 assert(MulInstr->getOpcode() == Instruction::Mul); 4565 4566 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 4567 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 4568 assert(LHS->getOpcode() == Instruction::ZExt); 4569 assert(RHS->getOpcode() == Instruction::ZExt); 4570 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 4571 4572 // Calculate type and width of the result produced by mul.with.overflow. 4573 Type *TyA = A->getType(), *TyB = B->getType(); 4574 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 4575 WidthB = TyB->getPrimitiveSizeInBits(); 4576 unsigned MulWidth; 4577 Type *MulType; 4578 if (WidthB > WidthA) { 4579 MulWidth = WidthB; 4580 MulType = TyB; 4581 } else { 4582 MulWidth = WidthA; 4583 MulType = TyA; 4584 } 4585 4586 // In order to replace the original mul with a narrower mul.with.overflow, 4587 // all uses must ignore upper bits of the product. The number of used low 4588 // bits must be not greater than the width of mul.with.overflow. 4589 if (MulVal->hasNUsesOrMore(2)) 4590 for (User *U : MulVal->users()) { 4591 if (U == &I) 4592 continue; 4593 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4594 // Check if truncation ignores bits above MulWidth. 4595 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 4596 if (TruncWidth > MulWidth) 4597 return nullptr; 4598 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4599 // Check if AND ignores bits above MulWidth. 4600 if (BO->getOpcode() != Instruction::And) 4601 return nullptr; 4602 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 4603 const APInt &CVal = CI->getValue(); 4604 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 4605 return nullptr; 4606 } else { 4607 // In this case we could have the operand of the binary operation 4608 // being defined in another block, and performing the replacement 4609 // could break the dominance relation. 4610 return nullptr; 4611 } 4612 } else { 4613 // Other uses prohibit this transformation. 4614 return nullptr; 4615 } 4616 } 4617 4618 // Recognize patterns 4619 switch (I.getPredicate()) { 4620 case ICmpInst::ICMP_EQ: 4621 case ICmpInst::ICMP_NE: 4622 // Recognize pattern: 4623 // mulval = mul(zext A, zext B) 4624 // cmp eq/neq mulval, zext trunc mulval 4625 if (ZExtInst *Zext = dyn_cast<ZExtInst>(OtherVal)) 4626 if (Zext->hasOneUse()) { 4627 Value *ZextArg = Zext->getOperand(0); 4628 if (TruncInst *Trunc = dyn_cast<TruncInst>(ZextArg)) 4629 if (Trunc->getType()->getPrimitiveSizeInBits() == MulWidth) 4630 break; //Recognized 4631 } 4632 4633 // Recognize pattern: 4634 // mulval = mul(zext A, zext B) 4635 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 4636 ConstantInt *CI; 4637 Value *ValToMask; 4638 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 4639 if (ValToMask != MulVal) 4640 return nullptr; 4641 const APInt &CVal = CI->getValue() + 1; 4642 if (CVal.isPowerOf2()) { 4643 unsigned MaskWidth = CVal.logBase2(); 4644 if (MaskWidth == MulWidth) 4645 break; // Recognized 4646 } 4647 } 4648 return nullptr; 4649 4650 case ICmpInst::ICMP_UGT: 4651 // Recognize pattern: 4652 // mulval = mul(zext A, zext B) 4653 // cmp ugt mulval, max 4654 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4655 APInt MaxVal = APInt::getMaxValue(MulWidth); 4656 MaxVal = MaxVal.zext(CI->getBitWidth()); 4657 if (MaxVal.eq(CI->getValue())) 4658 break; // Recognized 4659 } 4660 return nullptr; 4661 4662 case ICmpInst::ICMP_UGE: 4663 // Recognize pattern: 4664 // mulval = mul(zext A, zext B) 4665 // cmp uge mulval, max+1 4666 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4667 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4668 if (MaxVal.eq(CI->getValue())) 4669 break; // Recognized 4670 } 4671 return nullptr; 4672 4673 case ICmpInst::ICMP_ULE: 4674 // Recognize pattern: 4675 // mulval = mul(zext A, zext B) 4676 // cmp ule mulval, max 4677 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4678 APInt MaxVal = APInt::getMaxValue(MulWidth); 4679 MaxVal = MaxVal.zext(CI->getBitWidth()); 4680 if (MaxVal.eq(CI->getValue())) 4681 break; // Recognized 4682 } 4683 return nullptr; 4684 4685 case ICmpInst::ICMP_ULT: 4686 // Recognize pattern: 4687 // mulval = mul(zext A, zext B) 4688 // cmp ule mulval, max + 1 4689 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4690 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4691 if (MaxVal.eq(CI->getValue())) 4692 break; // Recognized 4693 } 4694 return nullptr; 4695 4696 default: 4697 return nullptr; 4698 } 4699 4700 InstCombiner::BuilderTy &Builder = IC.Builder; 4701 Builder.SetInsertPoint(MulInstr); 4702 4703 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 4704 Value *MulA = A, *MulB = B; 4705 if (WidthA < MulWidth) 4706 MulA = Builder.CreateZExt(A, MulType); 4707 if (WidthB < MulWidth) 4708 MulB = Builder.CreateZExt(B, MulType); 4709 Function *F = Intrinsic::getDeclaration( 4710 I.getModule(), Intrinsic::umul_with_overflow, MulType); 4711 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 4712 IC.Worklist.push(MulInstr); 4713 4714 // If there are uses of mul result other than the comparison, we know that 4715 // they are truncation or binary AND. Change them to use result of 4716 // mul.with.overflow and adjust properly mask/size. 4717 if (MulVal->hasNUsesOrMore(2)) { 4718 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 4719 for (auto UI = MulVal->user_begin(), UE = MulVal->user_end(); UI != UE;) { 4720 User *U = *UI++; 4721 if (U == &I || U == OtherVal) 4722 continue; 4723 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4724 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 4725 IC.replaceInstUsesWith(*TI, Mul); 4726 else 4727 TI->setOperand(0, Mul); 4728 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4729 assert(BO->getOpcode() == Instruction::And); 4730 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 4731 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 4732 APInt ShortMask = CI->getValue().trunc(MulWidth); 4733 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 4734 Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType()); 4735 IC.replaceInstUsesWith(*BO, Zext); 4736 } else { 4737 llvm_unreachable("Unexpected Binary operation"); 4738 } 4739 IC.Worklist.push(cast<Instruction>(U)); 4740 } 4741 } 4742 if (isa<Instruction>(OtherVal)) 4743 IC.Worklist.push(cast<Instruction>(OtherVal)); 4744 4745 // The original icmp gets replaced with the overflow value, maybe inverted 4746 // depending on predicate. 4747 bool Inverse = false; 4748 switch (I.getPredicate()) { 4749 case ICmpInst::ICMP_NE: 4750 break; 4751 case ICmpInst::ICMP_EQ: 4752 Inverse = true; 4753 break; 4754 case ICmpInst::ICMP_UGT: 4755 case ICmpInst::ICMP_UGE: 4756 if (I.getOperand(0) == MulVal) 4757 break; 4758 Inverse = true; 4759 break; 4760 case ICmpInst::ICMP_ULT: 4761 case ICmpInst::ICMP_ULE: 4762 if (I.getOperand(1) == MulVal) 4763 break; 4764 Inverse = true; 4765 break; 4766 default: 4767 llvm_unreachable("Unexpected predicate"); 4768 } 4769 if (Inverse) { 4770 Value *Res = Builder.CreateExtractValue(Call, 1); 4771 return BinaryOperator::CreateNot(Res); 4772 } 4773 4774 return ExtractValueInst::Create(Call, 1); 4775 } 4776 4777 /// When performing a comparison against a constant, it is possible that not all 4778 /// the bits in the LHS are demanded. This helper method computes the mask that 4779 /// IS demanded. 4780 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 4781 const APInt *RHS; 4782 if (!match(I.getOperand(1), m_APInt(RHS))) 4783 return APInt::getAllOnesValue(BitWidth); 4784 4785 // If this is a normal comparison, it demands all bits. If it is a sign bit 4786 // comparison, it only demands the sign bit. 4787 bool UnusedBit; 4788 if (isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 4789 return APInt::getSignMask(BitWidth); 4790 4791 switch (I.getPredicate()) { 4792 // For a UGT comparison, we don't care about any bits that 4793 // correspond to the trailing ones of the comparand. The value of these 4794 // bits doesn't impact the outcome of the comparison, because any value 4795 // greater than the RHS must differ in a bit higher than these due to carry. 4796 case ICmpInst::ICMP_UGT: 4797 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 4798 4799 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 4800 // Any value less than the RHS must differ in a higher bit because of carries. 4801 case ICmpInst::ICMP_ULT: 4802 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 4803 4804 default: 4805 return APInt::getAllOnesValue(BitWidth); 4806 } 4807 } 4808 4809 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 4810 /// should be swapped. 4811 /// The decision is based on how many times these two operands are reused 4812 /// as subtract operands and their positions in those instructions. 4813 /// The rationale is that several architectures use the same instruction for 4814 /// both subtract and cmp. Thus, it is better if the order of those operands 4815 /// match. 4816 /// \return true if Op0 and Op1 should be swapped. 4817 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 4818 // Filter out pointer values as those cannot appear directly in subtract. 4819 // FIXME: we may want to go through inttoptrs or bitcasts. 4820 if (Op0->getType()->isPointerTy()) 4821 return false; 4822 // If a subtract already has the same operands as a compare, swapping would be 4823 // bad. If a subtract has the same operands as a compare but in reverse order, 4824 // then swapping is good. 4825 int GoodToSwap = 0; 4826 for (const User *U : Op0->users()) { 4827 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 4828 GoodToSwap++; 4829 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 4830 GoodToSwap--; 4831 } 4832 return GoodToSwap > 0; 4833 } 4834 4835 /// Check that one use is in the same block as the definition and all 4836 /// other uses are in blocks dominated by a given block. 4837 /// 4838 /// \param DI Definition 4839 /// \param UI Use 4840 /// \param DB Block that must dominate all uses of \p DI outside 4841 /// the parent block 4842 /// \return true when \p UI is the only use of \p DI in the parent block 4843 /// and all other uses of \p DI are in blocks dominated by \p DB. 4844 /// 4845 bool InstCombiner::dominatesAllUses(const Instruction *DI, 4846 const Instruction *UI, 4847 const BasicBlock *DB) const { 4848 assert(DI && UI && "Instruction not defined\n"); 4849 // Ignore incomplete definitions. 4850 if (!DI->getParent()) 4851 return false; 4852 // DI and UI must be in the same block. 4853 if (DI->getParent() != UI->getParent()) 4854 return false; 4855 // Protect from self-referencing blocks. 4856 if (DI->getParent() == DB) 4857 return false; 4858 for (const User *U : DI->users()) { 4859 auto *Usr = cast<Instruction>(U); 4860 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 4861 return false; 4862 } 4863 return true; 4864 } 4865 4866 /// Return true when the instruction sequence within a block is select-cmp-br. 4867 static bool isChainSelectCmpBranch(const SelectInst *SI) { 4868 const BasicBlock *BB = SI->getParent(); 4869 if (!BB) 4870 return false; 4871 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 4872 if (!BI || BI->getNumSuccessors() != 2) 4873 return false; 4874 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 4875 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 4876 return false; 4877 return true; 4878 } 4879 4880 /// True when a select result is replaced by one of its operands 4881 /// in select-icmp sequence. This will eventually result in the elimination 4882 /// of the select. 4883 /// 4884 /// \param SI Select instruction 4885 /// \param Icmp Compare instruction 4886 /// \param SIOpd Operand that replaces the select 4887 /// 4888 /// Notes: 4889 /// - The replacement is global and requires dominator information 4890 /// - The caller is responsible for the actual replacement 4891 /// 4892 /// Example: 4893 /// 4894 /// entry: 4895 /// %4 = select i1 %3, %C* %0, %C* null 4896 /// %5 = icmp eq %C* %4, null 4897 /// br i1 %5, label %9, label %7 4898 /// ... 4899 /// ; <label>:7 ; preds = %entry 4900 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 4901 /// ... 4902 /// 4903 /// can be transformed to 4904 /// 4905 /// %5 = icmp eq %C* %0, null 4906 /// %6 = select i1 %3, i1 %5, i1 true 4907 /// br i1 %6, label %9, label %7 4908 /// ... 4909 /// ; <label>:7 ; preds = %entry 4910 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 4911 /// 4912 /// Similar when the first operand of the select is a constant or/and 4913 /// the compare is for not equal rather than equal. 4914 /// 4915 /// NOTE: The function is only called when the select and compare constants 4916 /// are equal, the optimization can work only for EQ predicates. This is not a 4917 /// major restriction since a NE compare should be 'normalized' to an equal 4918 /// compare, which usually happens in the combiner and test case 4919 /// select-cmp-br.ll checks for it. 4920 bool InstCombiner::replacedSelectWithOperand(SelectInst *SI, 4921 const ICmpInst *Icmp, 4922 const unsigned SIOpd) { 4923 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 4924 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 4925 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 4926 // The check for the single predecessor is not the best that can be 4927 // done. But it protects efficiently against cases like when SI's 4928 // home block has two successors, Succ and Succ1, and Succ1 predecessor 4929 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 4930 // replaced can be reached on either path. So the uniqueness check 4931 // guarantees that the path all uses of SI (outside SI's parent) are on 4932 // is disjoint from all other paths out of SI. But that information 4933 // is more expensive to compute, and the trade-off here is in favor 4934 // of compile-time. It should also be noticed that we check for a single 4935 // predecessor and not only uniqueness. This to handle the situation when 4936 // Succ and Succ1 points to the same basic block. 4937 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 4938 NumSel++; 4939 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 4940 return true; 4941 } 4942 } 4943 return false; 4944 } 4945 4946 /// Try to fold the comparison based on range information we can get by checking 4947 /// whether bits are known to be zero or one in the inputs. 4948 Instruction *InstCombiner::foldICmpUsingKnownBits(ICmpInst &I) { 4949 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4950 Type *Ty = Op0->getType(); 4951 ICmpInst::Predicate Pred = I.getPredicate(); 4952 4953 // Get scalar or pointer size. 4954 unsigned BitWidth = Ty->isIntOrIntVectorTy() 4955 ? Ty->getScalarSizeInBits() 4956 : DL.getPointerTypeSizeInBits(Ty->getScalarType()); 4957 4958 if (!BitWidth) 4959 return nullptr; 4960 4961 KnownBits Op0Known(BitWidth); 4962 KnownBits Op1Known(BitWidth); 4963 4964 if (SimplifyDemandedBits(&I, 0, 4965 getDemandedBitsLHSMask(I, BitWidth), 4966 Op0Known, 0)) 4967 return &I; 4968 4969 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth), 4970 Op1Known, 0)) 4971 return &I; 4972 4973 // Given the known and unknown bits, compute a range that the LHS could be 4974 // in. Compute the Min, Max and RHS values based on the known bits. For the 4975 // EQ and NE we use unsigned values. 4976 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 4977 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 4978 if (I.isSigned()) { 4979 computeSignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4980 computeSignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4981 } else { 4982 computeUnsignedMinMaxValuesFromKnownBits(Op0Known, Op0Min, Op0Max); 4983 computeUnsignedMinMaxValuesFromKnownBits(Op1Known, Op1Min, Op1Max); 4984 } 4985 4986 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 4987 // out that the LHS or RHS is a constant. Constant fold this now, so that 4988 // code below can assume that Min != Max. 4989 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 4990 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 4991 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 4992 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 4993 4994 // Based on the range information we know about the LHS, see if we can 4995 // simplify this comparison. For example, (x&4) < 8 is always true. 4996 switch (Pred) { 4997 default: 4998 llvm_unreachable("Unknown icmp opcode!"); 4999 case ICmpInst::ICMP_EQ: 5000 case ICmpInst::ICMP_NE: { 5001 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) { 5002 return Pred == CmpInst::ICMP_EQ 5003 ? replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())) 5004 : replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5005 } 5006 5007 // If all bits are known zero except for one, then we know at most one bit 5008 // is set. If the comparison is against zero, then this is a check to see if 5009 // *that* bit is set. 5010 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 5011 if (Op1Known.isZero()) { 5012 // If the LHS is an AND with the same constant, look through it. 5013 Value *LHS = nullptr; 5014 const APInt *LHSC; 5015 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 5016 *LHSC != Op0KnownZeroInverted) 5017 LHS = Op0; 5018 5019 Value *X; 5020 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 5021 APInt ValToCheck = Op0KnownZeroInverted; 5022 Type *XTy = X->getType(); 5023 if (ValToCheck.isPowerOf2()) { 5024 // ((1 << X) & 8) == 0 -> X != 3 5025 // ((1 << X) & 8) != 0 -> X == 3 5026 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5027 auto NewPred = ICmpInst::getInversePredicate(Pred); 5028 return new ICmpInst(NewPred, X, CmpC); 5029 } else if ((++ValToCheck).isPowerOf2()) { 5030 // ((1 << X) & 7) == 0 -> X >= 3 5031 // ((1 << X) & 7) != 0 -> X < 3 5032 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5033 auto NewPred = 5034 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 5035 return new ICmpInst(NewPred, X, CmpC); 5036 } 5037 } 5038 5039 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 5040 const APInt *CI; 5041 if (Op0KnownZeroInverted.isOneValue() && 5042 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 5043 // ((8 >>u X) & 1) == 0 -> X != 3 5044 // ((8 >>u X) & 1) != 0 -> X == 3 5045 unsigned CmpVal = CI->countTrailingZeros(); 5046 auto NewPred = ICmpInst::getInversePredicate(Pred); 5047 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 5048 } 5049 } 5050 break; 5051 } 5052 case ICmpInst::ICMP_ULT: { 5053 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 5054 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5055 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 5056 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5057 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 5058 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5059 5060 const APInt *CmpC; 5061 if (match(Op1, m_APInt(CmpC))) { 5062 // A <u C -> A == C-1 if min(A)+1 == C 5063 if (*CmpC == Op0Min + 1) 5064 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5065 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5066 // X <u C --> X == 0, if the number of zero bits in the bottom of X 5067 // exceeds the log2 of C. 5068 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 5069 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5070 Constant::getNullValue(Op1->getType())); 5071 } 5072 break; 5073 } 5074 case ICmpInst::ICMP_UGT: { 5075 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 5076 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5077 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 5078 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5079 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 5080 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5081 5082 const APInt *CmpC; 5083 if (match(Op1, m_APInt(CmpC))) { 5084 // A >u C -> A == C+1 if max(a)-1 == C 5085 if (*CmpC == Op0Max - 1) 5086 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5087 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5088 // X >u C --> X != 0, if the number of zero bits in the bottom of X 5089 // exceeds the log2 of C. 5090 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 5091 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 5092 Constant::getNullValue(Op1->getType())); 5093 } 5094 break; 5095 } 5096 case ICmpInst::ICMP_SLT: { 5097 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 5098 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5099 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 5100 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5101 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 5102 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5103 const APInt *CmpC; 5104 if (match(Op1, m_APInt(CmpC))) { 5105 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 5106 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5107 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5108 } 5109 break; 5110 } 5111 case ICmpInst::ICMP_SGT: { 5112 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 5113 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5114 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 5115 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5116 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 5117 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5118 const APInt *CmpC; 5119 if (match(Op1, m_APInt(CmpC))) { 5120 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 5121 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5122 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5123 } 5124 break; 5125 } 5126 case ICmpInst::ICMP_SGE: 5127 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 5128 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 5129 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5130 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 5131 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5132 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 5133 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5134 break; 5135 case ICmpInst::ICMP_SLE: 5136 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 5137 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 5138 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5139 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 5140 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5141 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 5142 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5143 break; 5144 case ICmpInst::ICMP_UGE: 5145 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 5146 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 5147 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5148 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 5149 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5150 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 5151 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5152 break; 5153 case ICmpInst::ICMP_ULE: 5154 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 5155 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 5156 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5157 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 5158 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5159 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 5160 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5161 break; 5162 } 5163 5164 // Turn a signed comparison into an unsigned one if both operands are known to 5165 // have the same sign. 5166 if (I.isSigned() && 5167 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 5168 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 5169 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 5170 5171 return nullptr; 5172 } 5173 5174 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 5175 llvm::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 5176 Constant *C) { 5177 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 5178 "Only for relational integer predicates."); 5179 5180 Type *Type = C->getType(); 5181 bool IsSigned = ICmpInst::isSigned(Pred); 5182 5183 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred); 5184 bool WillIncrement = 5185 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT; 5186 5187 // Check if the constant operand can be safely incremented/decremented 5188 // without overflowing/underflowing. 5189 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) { 5190 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned); 5191 }; 5192 5193 Constant *SafeReplacementConstant = nullptr; 5194 if (auto *CI = dyn_cast<ConstantInt>(C)) { 5195 // Bail out if the constant can't be safely incremented/decremented. 5196 if (!ConstantIsOk(CI)) 5197 return llvm::None; 5198 } else if (auto *VTy = dyn_cast<VectorType>(Type)) { 5199 unsigned NumElts = VTy->getNumElements(); 5200 for (unsigned i = 0; i != NumElts; ++i) { 5201 Constant *Elt = C->getAggregateElement(i); 5202 if (!Elt) 5203 return llvm::None; 5204 5205 if (isa<UndefValue>(Elt)) 5206 continue; 5207 5208 // Bail out if we can't determine if this constant is min/max or if we 5209 // know that this constant is min/max. 5210 auto *CI = dyn_cast<ConstantInt>(Elt); 5211 if (!CI || !ConstantIsOk(CI)) 5212 return llvm::None; 5213 5214 if (!SafeReplacementConstant) 5215 SafeReplacementConstant = CI; 5216 } 5217 } else { 5218 // ConstantExpr? 5219 return llvm::None; 5220 } 5221 5222 // It may not be safe to change a compare predicate in the presence of 5223 // undefined elements, so replace those elements with the first safe constant 5224 // that we found. 5225 if (C->containsUndefElement()) { 5226 assert(SafeReplacementConstant && "Replacement constant not set"); 5227 C = Constant::replaceUndefsWith(C, SafeReplacementConstant); 5228 } 5229 5230 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 5231 5232 // Increment or decrement the constant. 5233 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true); 5234 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 5235 5236 return std::make_pair(NewPred, NewC); 5237 } 5238 5239 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 5240 /// it into the appropriate icmp lt or icmp gt instruction. This transform 5241 /// allows them to be folded in visitICmpInst. 5242 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 5243 ICmpInst::Predicate Pred = I.getPredicate(); 5244 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 5245 isCanonicalPredicate(Pred)) 5246 return nullptr; 5247 5248 Value *Op0 = I.getOperand(0); 5249 Value *Op1 = I.getOperand(1); 5250 auto *Op1C = dyn_cast<Constant>(Op1); 5251 if (!Op1C) 5252 return nullptr; 5253 5254 auto FlippedStrictness = getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 5255 if (!FlippedStrictness) 5256 return nullptr; 5257 5258 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 5259 } 5260 5261 /// Integer compare with boolean values can always be turned into bitwise ops. 5262 static Instruction *canonicalizeICmpBool(ICmpInst &I, 5263 InstCombiner::BuilderTy &Builder) { 5264 Value *A = I.getOperand(0), *B = I.getOperand(1); 5265 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 5266 5267 // A boolean compared to true/false can be simplified to Op0/true/false in 5268 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 5269 // Cases not handled by InstSimplify are always 'not' of Op0. 5270 if (match(B, m_Zero())) { 5271 switch (I.getPredicate()) { 5272 case CmpInst::ICMP_EQ: // A == 0 -> !A 5273 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 5274 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 5275 return BinaryOperator::CreateNot(A); 5276 default: 5277 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5278 } 5279 } else if (match(B, m_One())) { 5280 switch (I.getPredicate()) { 5281 case CmpInst::ICMP_NE: // A != 1 -> !A 5282 case CmpInst::ICMP_ULT: // A <u 1 -> !A 5283 case CmpInst::ICMP_SGT: // A >s -1 -> !A 5284 return BinaryOperator::CreateNot(A); 5285 default: 5286 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5287 } 5288 } 5289 5290 switch (I.getPredicate()) { 5291 default: 5292 llvm_unreachable("Invalid icmp instruction!"); 5293 case ICmpInst::ICMP_EQ: 5294 // icmp eq i1 A, B -> ~(A ^ B) 5295 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 5296 5297 case ICmpInst::ICMP_NE: 5298 // icmp ne i1 A, B -> A ^ B 5299 return BinaryOperator::CreateXor(A, B); 5300 5301 case ICmpInst::ICMP_UGT: 5302 // icmp ugt -> icmp ult 5303 std::swap(A, B); 5304 LLVM_FALLTHROUGH; 5305 case ICmpInst::ICMP_ULT: 5306 // icmp ult i1 A, B -> ~A & B 5307 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 5308 5309 case ICmpInst::ICMP_SGT: 5310 // icmp sgt -> icmp slt 5311 std::swap(A, B); 5312 LLVM_FALLTHROUGH; 5313 case ICmpInst::ICMP_SLT: 5314 // icmp slt i1 A, B -> A & ~B 5315 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 5316 5317 case ICmpInst::ICMP_UGE: 5318 // icmp uge -> icmp ule 5319 std::swap(A, B); 5320 LLVM_FALLTHROUGH; 5321 case ICmpInst::ICMP_ULE: 5322 // icmp ule i1 A, B -> ~A | B 5323 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5324 5325 case ICmpInst::ICMP_SGE: 5326 // icmp sge -> icmp sle 5327 std::swap(A, B); 5328 LLVM_FALLTHROUGH; 5329 case ICmpInst::ICMP_SLE: 5330 // icmp sle i1 A, B -> A | ~B 5331 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5332 } 5333 } 5334 5335 // Transform pattern like: 5336 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5337 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5338 // Into: 5339 // (X l>> Y) != 0 5340 // (X l>> Y) == 0 5341 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5342 InstCombiner::BuilderTy &Builder) { 5343 ICmpInst::Predicate Pred, NewPred; 5344 Value *X, *Y; 5345 if (match(&Cmp, 5346 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5347 switch (Pred) { 5348 case ICmpInst::ICMP_ULE: 5349 NewPred = ICmpInst::ICMP_NE; 5350 break; 5351 case ICmpInst::ICMP_UGT: 5352 NewPred = ICmpInst::ICMP_EQ; 5353 break; 5354 default: 5355 return nullptr; 5356 } 5357 } else if (match(&Cmp, m_c_ICmp(Pred, 5358 m_OneUse(m_CombineOr( 5359 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5360 m_Add(m_Shl(m_One(), m_Value(Y)), 5361 m_AllOnes()))), 5362 m_Value(X)))) { 5363 // The variant with 'add' is not canonical, (the variant with 'not' is) 5364 // we only get it because it has extra uses, and can't be canonicalized, 5365 5366 switch (Pred) { 5367 case ICmpInst::ICMP_ULT: 5368 NewPred = ICmpInst::ICMP_NE; 5369 break; 5370 case ICmpInst::ICMP_UGE: 5371 NewPred = ICmpInst::ICMP_EQ; 5372 break; 5373 default: 5374 return nullptr; 5375 } 5376 } else 5377 return nullptr; 5378 5379 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5380 Constant *Zero = Constant::getNullValue(NewX->getType()); 5381 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5382 } 5383 5384 static Instruction *foldVectorCmp(CmpInst &Cmp, 5385 InstCombiner::BuilderTy &Builder) { 5386 const CmpInst::Predicate Pred = Cmp.getPredicate(); 5387 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5388 bool IsFP = isa<FCmpInst>(Cmp); 5389 5390 Value *V1, *V2; 5391 ArrayRef<int> M; 5392 if (!match(LHS, m_ShuffleVector(m_Value(V1), m_Undef(), m_Mask(M)))) 5393 return nullptr; 5394 5395 // If both arguments of the cmp are shuffles that use the same mask and 5396 // shuffle within a single vector, move the shuffle after the cmp: 5397 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5398 Type *V1Ty = V1->getType(); 5399 if (match(RHS, m_ShuffleVector(m_Value(V2), m_Undef(), m_SpecificMask(M))) && 5400 V1Ty == V2->getType() && (LHS->hasOneUse() || RHS->hasOneUse())) { 5401 Value *NewCmp = IsFP ? Builder.CreateFCmp(Pred, V1, V2) 5402 : Builder.CreateICmp(Pred, V1, V2); 5403 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M); 5404 } 5405 5406 // Try to canonicalize compare with splatted operand and splat constant. 5407 // TODO: We could generalize this for more than splats. See/use the code in 5408 // InstCombiner::foldVectorBinop(). 5409 Constant *C; 5410 if (!LHS->hasOneUse() || !match(RHS, m_Constant(C))) 5411 return nullptr; 5412 5413 // Length-changing splats are ok, so adjust the constants as needed: 5414 // cmp (shuffle V1, M), C --> shuffle (cmp V1, C'), M 5415 Constant *ScalarC = C->getSplatValue(/* AllowUndefs */ true); 5416 int MaskSplatIndex; 5417 if (ScalarC && match(M, m_SplatOrUndefMask(MaskSplatIndex))) { 5418 // We allow undefs in matching, but this transform removes those for safety. 5419 // Demanded elements analysis should be able to recover some/all of that. 5420 C = ConstantVector::getSplat(cast<VectorType>(V1Ty)->getElementCount(), 5421 ScalarC); 5422 SmallVector<int, 8> NewM(M.size(), MaskSplatIndex); 5423 Value *NewCmp = IsFP ? Builder.CreateFCmp(Pred, V1, C) 5424 : Builder.CreateICmp(Pred, V1, C); 5425 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), 5426 NewM); 5427 } 5428 5429 return nullptr; 5430 } 5431 5432 // extract(uadd.with.overflow(A, B), 0) ult A 5433 // -> extract(uadd.with.overflow(A, B), 1) 5434 static Instruction *foldICmpOfUAddOv(ICmpInst &I) { 5435 CmpInst::Predicate Pred = I.getPredicate(); 5436 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5437 5438 Value *UAddOv; 5439 Value *A, *B; 5440 auto UAddOvResultPat = m_ExtractValue<0>( 5441 m_Intrinsic<Intrinsic::uadd_with_overflow>(m_Value(A), m_Value(B))); 5442 if (match(Op0, UAddOvResultPat) && 5443 ((Pred == ICmpInst::ICMP_ULT && (Op1 == A || Op1 == B)) || 5444 (Pred == ICmpInst::ICMP_EQ && match(Op1, m_ZeroInt()) && 5445 (match(A, m_One()) || match(B, m_One()))) || 5446 (Pred == ICmpInst::ICMP_NE && match(Op1, m_AllOnes()) && 5447 (match(A, m_AllOnes()) || match(B, m_AllOnes()))))) 5448 // extract(uadd.with.overflow(A, B), 0) < A 5449 // extract(uadd.with.overflow(A, 1), 0) == 0 5450 // extract(uadd.with.overflow(A, -1), 0) != -1 5451 UAddOv = cast<ExtractValueInst>(Op0)->getAggregateOperand(); 5452 else if (match(Op1, UAddOvResultPat) && 5453 Pred == ICmpInst::ICMP_UGT && (Op0 == A || Op0 == B)) 5454 // A > extract(uadd.with.overflow(A, B), 0) 5455 UAddOv = cast<ExtractValueInst>(Op1)->getAggregateOperand(); 5456 else 5457 return nullptr; 5458 5459 return ExtractValueInst::Create(UAddOv, 1); 5460 } 5461 5462 Instruction *InstCombiner::visitICmpInst(ICmpInst &I) { 5463 bool Changed = false; 5464 const SimplifyQuery Q = SQ.getWithInstruction(&I); 5465 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5466 unsigned Op0Cplxity = getComplexity(Op0); 5467 unsigned Op1Cplxity = getComplexity(Op1); 5468 5469 /// Orders the operands of the compare so that they are listed from most 5470 /// complex to least complex. This puts constants before unary operators, 5471 /// before binary operators. 5472 if (Op0Cplxity < Op1Cplxity || 5473 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 5474 I.swapOperands(); 5475 std::swap(Op0, Op1); 5476 Changed = true; 5477 } 5478 5479 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q)) 5480 return replaceInstUsesWith(I, V); 5481 5482 // Comparing -val or val with non-zero is the same as just comparing val 5483 // ie, abs(val) != 0 -> val != 0 5484 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 5485 Value *Cond, *SelectTrue, *SelectFalse; 5486 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 5487 m_Value(SelectFalse)))) { 5488 if (Value *V = dyn_castNegVal(SelectTrue)) { 5489 if (V == SelectFalse) 5490 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5491 } 5492 else if (Value *V = dyn_castNegVal(SelectFalse)) { 5493 if (V == SelectTrue) 5494 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5495 } 5496 } 5497 } 5498 5499 if (Op0->getType()->isIntOrIntVectorTy(1)) 5500 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 5501 return Res; 5502 5503 if (ICmpInst *NewICmp = canonicalizeCmpWithConstant(I)) 5504 return NewICmp; 5505 5506 if (Instruction *Res = foldICmpWithConstant(I)) 5507 return Res; 5508 5509 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 5510 return Res; 5511 5512 if (Instruction *Res = foldICmpBinOp(I, Q)) 5513 return Res; 5514 5515 if (Instruction *Res = foldICmpUsingKnownBits(I)) 5516 return Res; 5517 5518 // Test if the ICmpInst instruction is used exclusively by a select as 5519 // part of a minimum or maximum operation. If so, refrain from doing 5520 // any other folding. This helps out other analyses which understand 5521 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 5522 // and CodeGen. And in this case, at least one of the comparison 5523 // operands has at least one user besides the compare (the select), 5524 // which would often largely negate the benefit of folding anyway. 5525 // 5526 // Do the same for the other patterns recognized by matchSelectPattern. 5527 if (I.hasOneUse()) 5528 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 5529 Value *A, *B; 5530 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 5531 if (SPR.Flavor != SPF_UNKNOWN) 5532 return nullptr; 5533 } 5534 5535 // Do this after checking for min/max to prevent infinite looping. 5536 if (Instruction *Res = foldICmpWithZero(I)) 5537 return Res; 5538 5539 // FIXME: We only do this after checking for min/max to prevent infinite 5540 // looping caused by a reverse canonicalization of these patterns for min/max. 5541 // FIXME: The organization of folds is a mess. These would naturally go into 5542 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 5543 // down here after the min/max restriction. 5544 ICmpInst::Predicate Pred = I.getPredicate(); 5545 const APInt *C; 5546 if (match(Op1, m_APInt(C))) { 5547 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 5548 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 5549 Constant *Zero = Constant::getNullValue(Op0->getType()); 5550 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 5551 } 5552 5553 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 5554 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 5555 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 5556 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 5557 } 5558 } 5559 5560 if (Instruction *Res = foldICmpInstWithConstant(I)) 5561 return Res; 5562 5563 // Try to match comparison as a sign bit test. Intentionally do this after 5564 // foldICmpInstWithConstant() to potentially let other folds to happen first. 5565 if (Instruction *New = foldSignBitTest(I)) 5566 return New; 5567 5568 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 5569 return Res; 5570 5571 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 5572 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 5573 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 5574 return NI; 5575 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 5576 if (Instruction *NI = foldGEPICmp(GEP, Op0, 5577 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 5578 return NI; 5579 5580 // Try to optimize equality comparisons against alloca-based pointers. 5581 if (Op0->getType()->isPointerTy() && I.isEquality()) { 5582 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 5583 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op0, DL))) 5584 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 5585 return New; 5586 if (auto *Alloca = dyn_cast<AllocaInst>(GetUnderlyingObject(Op1, DL))) 5587 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 5588 return New; 5589 } 5590 5591 if (Instruction *Res = foldICmpBitCast(I, Builder)) 5592 return Res; 5593 5594 // TODO: Hoist this above the min/max bailout. 5595 if (Instruction *R = foldICmpWithCastOp(I)) 5596 return R; 5597 5598 if (Instruction *Res = foldICmpWithMinMax(I)) 5599 return Res; 5600 5601 { 5602 Value *A, *B; 5603 // Transform (A & ~B) == 0 --> (A & B) != 0 5604 // and (A & ~B) != 0 --> (A & B) == 0 5605 // if A is a power of 2. 5606 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 5607 match(Op1, m_Zero()) && 5608 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 5609 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 5610 Op1); 5611 5612 // ~X < ~Y --> Y < X 5613 // ~X < C --> X > ~C 5614 if (match(Op0, m_Not(m_Value(A)))) { 5615 if (match(Op1, m_Not(m_Value(B)))) 5616 return new ICmpInst(I.getPredicate(), B, A); 5617 5618 const APInt *C; 5619 if (match(Op1, m_APInt(C))) 5620 return new ICmpInst(I.getSwappedPredicate(), A, 5621 ConstantInt::get(Op1->getType(), ~(*C))); 5622 } 5623 5624 Instruction *AddI = nullptr; 5625 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 5626 m_Instruction(AddI))) && 5627 isa<IntegerType>(A->getType())) { 5628 Value *Result; 5629 Constant *Overflow; 5630 // m_UAddWithOverflow can match patterns that do not include an explicit 5631 // "add" instruction, so check the opcode of the matched op. 5632 if (AddI->getOpcode() == Instruction::Add && 5633 OptimizeOverflowCheck(Instruction::Add, /*Signed*/ false, A, B, *AddI, 5634 Result, Overflow)) { 5635 replaceInstUsesWith(*AddI, Result); 5636 eraseInstFromFunction(*AddI); 5637 return replaceInstUsesWith(I, Overflow); 5638 } 5639 } 5640 5641 // (zext a) * (zext b) --> llvm.umul.with.overflow. 5642 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5643 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 5644 return R; 5645 } 5646 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5647 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 5648 return R; 5649 } 5650 } 5651 5652 if (Instruction *Res = foldICmpEquality(I)) 5653 return Res; 5654 5655 if (Instruction *Res = foldICmpOfUAddOv(I)) 5656 return Res; 5657 5658 // The 'cmpxchg' instruction returns an aggregate containing the old value and 5659 // an i1 which indicates whether or not we successfully did the swap. 5660 // 5661 // Replace comparisons between the old value and the expected value with the 5662 // indicator that 'cmpxchg' returns. 5663 // 5664 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 5665 // spuriously fail. In those cases, the old value may equal the expected 5666 // value but it is possible for the swap to not occur. 5667 if (I.getPredicate() == ICmpInst::ICMP_EQ) 5668 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 5669 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 5670 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 5671 !ACXI->isWeak()) 5672 return ExtractValueInst::Create(ACXI, 1); 5673 5674 { 5675 Value *X; 5676 const APInt *C; 5677 // icmp X+Cst, X 5678 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 5679 return foldICmpAddOpConst(X, *C, I.getPredicate()); 5680 5681 // icmp X, X+Cst 5682 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 5683 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 5684 } 5685 5686 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 5687 return Res; 5688 5689 if (I.getType()->isVectorTy()) 5690 if (Instruction *Res = foldVectorCmp(I, Builder)) 5691 return Res; 5692 5693 return Changed ? &I : nullptr; 5694 } 5695 5696 /// Fold fcmp ([us]itofp x, cst) if possible. 5697 Instruction *InstCombiner::foldFCmpIntToFPConst(FCmpInst &I, Instruction *LHSI, 5698 Constant *RHSC) { 5699 if (!isa<ConstantFP>(RHSC)) return nullptr; 5700 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 5701 5702 // Get the width of the mantissa. We don't want to hack on conversions that 5703 // might lose information from the integer, e.g. "i64 -> float" 5704 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 5705 if (MantissaWidth == -1) return nullptr; // Unknown. 5706 5707 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 5708 5709 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 5710 5711 if (I.isEquality()) { 5712 FCmpInst::Predicate P = I.getPredicate(); 5713 bool IsExact = false; 5714 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 5715 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 5716 5717 // If the floating point constant isn't an integer value, we know if we will 5718 // ever compare equal / not equal to it. 5719 if (!IsExact) { 5720 // TODO: Can never be -0.0 and other non-representable values 5721 APFloat RHSRoundInt(RHS); 5722 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 5723 if (RHS != RHSRoundInt) { 5724 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 5725 return replaceInstUsesWith(I, Builder.getFalse()); 5726 5727 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 5728 return replaceInstUsesWith(I, Builder.getTrue()); 5729 } 5730 } 5731 5732 // TODO: If the constant is exactly representable, is it always OK to do 5733 // equality compares as integer? 5734 } 5735 5736 // Check to see that the input is converted from an integer type that is small 5737 // enough that preserves all bits. TODO: check here for "known" sign bits. 5738 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 5739 unsigned InputSize = IntTy->getScalarSizeInBits(); 5740 5741 // Following test does NOT adjust InputSize downwards for signed inputs, 5742 // because the most negative value still requires all the mantissa bits 5743 // to distinguish it from one less than that value. 5744 if ((int)InputSize > MantissaWidth) { 5745 // Conversion would lose accuracy. Check if loss can impact comparison. 5746 int Exp = ilogb(RHS); 5747 if (Exp == APFloat::IEK_Inf) { 5748 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 5749 if (MaxExponent < (int)InputSize - !LHSUnsigned) 5750 // Conversion could create infinity. 5751 return nullptr; 5752 } else { 5753 // Note that if RHS is zero or NaN, then Exp is negative 5754 // and first condition is trivially false. 5755 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 5756 // Conversion could affect comparison. 5757 return nullptr; 5758 } 5759 } 5760 5761 // Otherwise, we can potentially simplify the comparison. We know that it 5762 // will always come through as an integer value and we know the constant is 5763 // not a NAN (it would have been previously simplified). 5764 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 5765 5766 ICmpInst::Predicate Pred; 5767 switch (I.getPredicate()) { 5768 default: llvm_unreachable("Unexpected predicate!"); 5769 case FCmpInst::FCMP_UEQ: 5770 case FCmpInst::FCMP_OEQ: 5771 Pred = ICmpInst::ICMP_EQ; 5772 break; 5773 case FCmpInst::FCMP_UGT: 5774 case FCmpInst::FCMP_OGT: 5775 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 5776 break; 5777 case FCmpInst::FCMP_UGE: 5778 case FCmpInst::FCMP_OGE: 5779 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 5780 break; 5781 case FCmpInst::FCMP_ULT: 5782 case FCmpInst::FCMP_OLT: 5783 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 5784 break; 5785 case FCmpInst::FCMP_ULE: 5786 case FCmpInst::FCMP_OLE: 5787 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 5788 break; 5789 case FCmpInst::FCMP_UNE: 5790 case FCmpInst::FCMP_ONE: 5791 Pred = ICmpInst::ICMP_NE; 5792 break; 5793 case FCmpInst::FCMP_ORD: 5794 return replaceInstUsesWith(I, Builder.getTrue()); 5795 case FCmpInst::FCMP_UNO: 5796 return replaceInstUsesWith(I, Builder.getFalse()); 5797 } 5798 5799 // Now we know that the APFloat is a normal number, zero or inf. 5800 5801 // See if the FP constant is too large for the integer. For example, 5802 // comparing an i8 to 300.0. 5803 unsigned IntWidth = IntTy->getScalarSizeInBits(); 5804 5805 if (!LHSUnsigned) { 5806 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 5807 // and large values. 5808 APFloat SMax(RHS.getSemantics()); 5809 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 5810 APFloat::rmNearestTiesToEven); 5811 if (SMax < RHS) { // smax < 13123.0 5812 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 5813 Pred == ICmpInst::ICMP_SLE) 5814 return replaceInstUsesWith(I, Builder.getTrue()); 5815 return replaceInstUsesWith(I, Builder.getFalse()); 5816 } 5817 } else { 5818 // If the RHS value is > UnsignedMax, fold the comparison. This handles 5819 // +INF and large values. 5820 APFloat UMax(RHS.getSemantics()); 5821 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 5822 APFloat::rmNearestTiesToEven); 5823 if (UMax < RHS) { // umax < 13123.0 5824 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 5825 Pred == ICmpInst::ICMP_ULE) 5826 return replaceInstUsesWith(I, Builder.getTrue()); 5827 return replaceInstUsesWith(I, Builder.getFalse()); 5828 } 5829 } 5830 5831 if (!LHSUnsigned) { 5832 // See if the RHS value is < SignedMin. 5833 APFloat SMin(RHS.getSemantics()); 5834 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 5835 APFloat::rmNearestTiesToEven); 5836 if (SMin > RHS) { // smin > 12312.0 5837 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 5838 Pred == ICmpInst::ICMP_SGE) 5839 return replaceInstUsesWith(I, Builder.getTrue()); 5840 return replaceInstUsesWith(I, Builder.getFalse()); 5841 } 5842 } else { 5843 // See if the RHS value is < UnsignedMin. 5844 APFloat UMin(RHS.getSemantics()); 5845 UMin.convertFromAPInt(APInt::getMinValue(IntWidth), false, 5846 APFloat::rmNearestTiesToEven); 5847 if (UMin > RHS) { // umin > 12312.0 5848 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 5849 Pred == ICmpInst::ICMP_UGE) 5850 return replaceInstUsesWith(I, Builder.getTrue()); 5851 return replaceInstUsesWith(I, Builder.getFalse()); 5852 } 5853 } 5854 5855 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 5856 // [0, UMAX], but it may still be fractional. See if it is fractional by 5857 // casting the FP value to the integer value and back, checking for equality. 5858 // Don't do this for zero, because -0.0 is not fractional. 5859 Constant *RHSInt = LHSUnsigned 5860 ? ConstantExpr::getFPToUI(RHSC, IntTy) 5861 : ConstantExpr::getFPToSI(RHSC, IntTy); 5862 if (!RHS.isZero()) { 5863 bool Equal = LHSUnsigned 5864 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 5865 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 5866 if (!Equal) { 5867 // If we had a comparison against a fractional value, we have to adjust 5868 // the compare predicate and sometimes the value. RHSC is rounded towards 5869 // zero at this point. 5870 switch (Pred) { 5871 default: llvm_unreachable("Unexpected integer comparison!"); 5872 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 5873 return replaceInstUsesWith(I, Builder.getTrue()); 5874 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 5875 return replaceInstUsesWith(I, Builder.getFalse()); 5876 case ICmpInst::ICMP_ULE: 5877 // (float)int <= 4.4 --> int <= 4 5878 // (float)int <= -4.4 --> false 5879 if (RHS.isNegative()) 5880 return replaceInstUsesWith(I, Builder.getFalse()); 5881 break; 5882 case ICmpInst::ICMP_SLE: 5883 // (float)int <= 4.4 --> int <= 4 5884 // (float)int <= -4.4 --> int < -4 5885 if (RHS.isNegative()) 5886 Pred = ICmpInst::ICMP_SLT; 5887 break; 5888 case ICmpInst::ICMP_ULT: 5889 // (float)int < -4.4 --> false 5890 // (float)int < 4.4 --> int <= 4 5891 if (RHS.isNegative()) 5892 return replaceInstUsesWith(I, Builder.getFalse()); 5893 Pred = ICmpInst::ICMP_ULE; 5894 break; 5895 case ICmpInst::ICMP_SLT: 5896 // (float)int < -4.4 --> int < -4 5897 // (float)int < 4.4 --> int <= 4 5898 if (!RHS.isNegative()) 5899 Pred = ICmpInst::ICMP_SLE; 5900 break; 5901 case ICmpInst::ICMP_UGT: 5902 // (float)int > 4.4 --> int > 4 5903 // (float)int > -4.4 --> true 5904 if (RHS.isNegative()) 5905 return replaceInstUsesWith(I, Builder.getTrue()); 5906 break; 5907 case ICmpInst::ICMP_SGT: 5908 // (float)int > 4.4 --> int > 4 5909 // (float)int > -4.4 --> int >= -4 5910 if (RHS.isNegative()) 5911 Pred = ICmpInst::ICMP_SGE; 5912 break; 5913 case ICmpInst::ICMP_UGE: 5914 // (float)int >= -4.4 --> true 5915 // (float)int >= 4.4 --> int > 4 5916 if (RHS.isNegative()) 5917 return replaceInstUsesWith(I, Builder.getTrue()); 5918 Pred = ICmpInst::ICMP_UGT; 5919 break; 5920 case ICmpInst::ICMP_SGE: 5921 // (float)int >= -4.4 --> int >= -4 5922 // (float)int >= 4.4 --> int > 4 5923 if (!RHS.isNegative()) 5924 Pred = ICmpInst::ICMP_SGT; 5925 break; 5926 } 5927 } 5928 } 5929 5930 // Lower this FP comparison into an appropriate integer version of the 5931 // comparison. 5932 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 5933 } 5934 5935 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 5936 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 5937 Constant *RHSC) { 5938 // When C is not 0.0 and infinities are not allowed: 5939 // (C / X) < 0.0 is a sign-bit test of X 5940 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 5941 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 5942 // 5943 // Proof: 5944 // Multiply (C / X) < 0.0 by X * X / C. 5945 // - X is non zero, if it is the flag 'ninf' is violated. 5946 // - C defines the sign of X * X * C. Thus it also defines whether to swap 5947 // the predicate. C is also non zero by definition. 5948 // 5949 // Thus X * X / C is non zero and the transformation is valid. [qed] 5950 5951 FCmpInst::Predicate Pred = I.getPredicate(); 5952 5953 // Check that predicates are valid. 5954 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 5955 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 5956 return nullptr; 5957 5958 // Check that RHS operand is zero. 5959 if (!match(RHSC, m_AnyZeroFP())) 5960 return nullptr; 5961 5962 // Check fastmath flags ('ninf'). 5963 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 5964 return nullptr; 5965 5966 // Check the properties of the dividend. It must not be zero to avoid a 5967 // division by zero (see Proof). 5968 const APFloat *C; 5969 if (!match(LHSI->getOperand(0), m_APFloat(C))) 5970 return nullptr; 5971 5972 if (C->isZero()) 5973 return nullptr; 5974 5975 // Get swapped predicate if necessary. 5976 if (C->isNegative()) 5977 Pred = I.getSwappedPredicate(); 5978 5979 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 5980 } 5981 5982 /// Optimize fabs(X) compared with zero. 5983 static Instruction *foldFabsWithFcmpZero(FCmpInst &I, InstCombiner &IC) { 5984 Value *X; 5985 if (!match(I.getOperand(0), m_Intrinsic<Intrinsic::fabs>(m_Value(X))) || 5986 !match(I.getOperand(1), m_PosZeroFP())) 5987 return nullptr; 5988 5989 auto replacePredAndOp0 = [&IC](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 5990 I->setPredicate(P); 5991 return IC.replaceOperand(*I, 0, X); 5992 }; 5993 5994 switch (I.getPredicate()) { 5995 case FCmpInst::FCMP_UGE: 5996 case FCmpInst::FCMP_OLT: 5997 // fabs(X) >= 0.0 --> true 5998 // fabs(X) < 0.0 --> false 5999 llvm_unreachable("fcmp should have simplified"); 6000 6001 case FCmpInst::FCMP_OGT: 6002 // fabs(X) > 0.0 --> X != 0.0 6003 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 6004 6005 case FCmpInst::FCMP_UGT: 6006 // fabs(X) u> 0.0 --> X u!= 0.0 6007 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 6008 6009 case FCmpInst::FCMP_OLE: 6010 // fabs(X) <= 0.0 --> X == 0.0 6011 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 6012 6013 case FCmpInst::FCMP_ULE: 6014 // fabs(X) u<= 0.0 --> X u== 0.0 6015 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 6016 6017 case FCmpInst::FCMP_OGE: 6018 // fabs(X) >= 0.0 --> !isnan(X) 6019 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6020 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 6021 6022 case FCmpInst::FCMP_ULT: 6023 // fabs(X) u< 0.0 --> isnan(X) 6024 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6025 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 6026 6027 case FCmpInst::FCMP_OEQ: 6028 case FCmpInst::FCMP_UEQ: 6029 case FCmpInst::FCMP_ONE: 6030 case FCmpInst::FCMP_UNE: 6031 case FCmpInst::FCMP_ORD: 6032 case FCmpInst::FCMP_UNO: 6033 // Look through the fabs() because it doesn't change anything but the sign. 6034 // fabs(X) == 0.0 --> X == 0.0, 6035 // fabs(X) != 0.0 --> X != 0.0 6036 // isnan(fabs(X)) --> isnan(X) 6037 // !isnan(fabs(X) --> !isnan(X) 6038 return replacePredAndOp0(&I, I.getPredicate(), X); 6039 6040 default: 6041 return nullptr; 6042 } 6043 } 6044 6045 Instruction *InstCombiner::visitFCmpInst(FCmpInst &I) { 6046 bool Changed = false; 6047 6048 /// Orders the operands of the compare so that they are listed from most 6049 /// complex to least complex. This puts constants before unary operators, 6050 /// before binary operators. 6051 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 6052 I.swapOperands(); 6053 Changed = true; 6054 } 6055 6056 const CmpInst::Predicate Pred = I.getPredicate(); 6057 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6058 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 6059 SQ.getWithInstruction(&I))) 6060 return replaceInstUsesWith(I, V); 6061 6062 // Simplify 'fcmp pred X, X' 6063 Type *OpType = Op0->getType(); 6064 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 6065 if (Op0 == Op1) { 6066 switch (Pred) { 6067 default: break; 6068 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 6069 case FCmpInst::FCMP_ULT: // True if unordered or less than 6070 case FCmpInst::FCMP_UGT: // True if unordered or greater than 6071 case FCmpInst::FCMP_UNE: // True if unordered or not equal 6072 // Canonicalize these to be 'fcmp uno %X, 0.0'. 6073 I.setPredicate(FCmpInst::FCMP_UNO); 6074 I.setOperand(1, Constant::getNullValue(OpType)); 6075 return &I; 6076 6077 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 6078 case FCmpInst::FCMP_OEQ: // True if ordered and equal 6079 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 6080 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 6081 // Canonicalize these to be 'fcmp ord %X, 0.0'. 6082 I.setPredicate(FCmpInst::FCMP_ORD); 6083 I.setOperand(1, Constant::getNullValue(OpType)); 6084 return &I; 6085 } 6086 } 6087 6088 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 6089 // then canonicalize the operand to 0.0. 6090 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 6091 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) 6092 return replaceOperand(I, 0, ConstantFP::getNullValue(OpType)); 6093 6094 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) 6095 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6096 } 6097 6098 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 6099 Value *X, *Y; 6100 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 6101 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 6102 6103 // Test if the FCmpInst instruction is used exclusively by a select as 6104 // part of a minimum or maximum operation. If so, refrain from doing 6105 // any other folding. This helps out other analyses which understand 6106 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6107 // and CodeGen. And in this case, at least one of the comparison 6108 // operands has at least one user besides the compare (the select), 6109 // which would often largely negate the benefit of folding anyway. 6110 if (I.hasOneUse()) 6111 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6112 Value *A, *B; 6113 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6114 if (SPR.Flavor != SPF_UNKNOWN) 6115 return nullptr; 6116 } 6117 6118 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 6119 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 6120 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) 6121 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6122 6123 // Handle fcmp with instruction LHS and constant RHS. 6124 Instruction *LHSI; 6125 Constant *RHSC; 6126 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 6127 switch (LHSI->getOpcode()) { 6128 case Instruction::PHI: 6129 // Only fold fcmp into the PHI if the phi and fcmp are in the same 6130 // block. If in the same block, we're encouraging jump threading. If 6131 // not, we are just pessimizing the code by making an i1 phi. 6132 if (LHSI->getParent() == I.getParent()) 6133 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 6134 return NV; 6135 break; 6136 case Instruction::SIToFP: 6137 case Instruction::UIToFP: 6138 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 6139 return NV; 6140 break; 6141 case Instruction::FDiv: 6142 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 6143 return NV; 6144 break; 6145 case Instruction::Load: 6146 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 6147 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 6148 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 6149 !cast<LoadInst>(LHSI)->isVolatile()) 6150 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 6151 return Res; 6152 break; 6153 } 6154 } 6155 6156 if (Instruction *R = foldFabsWithFcmpZero(I, *this)) 6157 return R; 6158 6159 if (match(Op0, m_FNeg(m_Value(X)))) { 6160 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 6161 Constant *C; 6162 if (match(Op1, m_Constant(C))) { 6163 Constant *NegC = ConstantExpr::getFNeg(C); 6164 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 6165 } 6166 } 6167 6168 if (match(Op0, m_FPExt(m_Value(X)))) { 6169 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 6170 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 6171 return new FCmpInst(Pred, X, Y, "", &I); 6172 6173 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 6174 const APFloat *C; 6175 if (match(Op1, m_APFloat(C))) { 6176 const fltSemantics &FPSem = 6177 X->getType()->getScalarType()->getFltSemantics(); 6178 bool Lossy; 6179 APFloat TruncC = *C; 6180 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 6181 6182 // Avoid lossy conversions and denormals. 6183 // Zero is a special case that's OK to convert. 6184 APFloat Fabs = TruncC; 6185 Fabs.clearSign(); 6186 if (!Lossy && 6187 (!(Fabs < APFloat::getSmallestNormalized(FPSem)) || Fabs.isZero())) { 6188 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 6189 return new FCmpInst(Pred, X, NewC, "", &I); 6190 } 6191 } 6192 } 6193 6194 if (I.getType()->isVectorTy()) 6195 if (Instruction *Res = foldVectorCmp(I, Builder)) 6196 return Res; 6197 6198 return Changed ? &I : nullptr; 6199 } 6200