1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/CmpInstAnalysis.h" 18 #include "llvm/Analysis/ConstantFolding.h" 19 #include "llvm/Analysis/InstructionSimplify.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/KnownBits.h" 26 #include "llvm/Transforms/InstCombine/InstCombiner.h" 27 28 using namespace llvm; 29 using namespace PatternMatch; 30 31 #define DEBUG_TYPE "instcombine" 32 33 // How many times is a select replaced by one of its operands? 34 STATISTIC(NumSel, "Number of select opts"); 35 36 37 /// Compute Result = In1+In2, returning true if the result overflowed for this 38 /// type. 39 static bool addWithOverflow(APInt &Result, const APInt &In1, 40 const APInt &In2, bool IsSigned = false) { 41 bool Overflow; 42 if (IsSigned) 43 Result = In1.sadd_ov(In2, Overflow); 44 else 45 Result = In1.uadd_ov(In2, Overflow); 46 47 return Overflow; 48 } 49 50 /// Compute Result = In1-In2, returning true if the result overflowed for this 51 /// type. 52 static bool subWithOverflow(APInt &Result, const APInt &In1, 53 const APInt &In2, bool IsSigned = false) { 54 bool Overflow; 55 if (IsSigned) 56 Result = In1.ssub_ov(In2, Overflow); 57 else 58 Result = In1.usub_ov(In2, Overflow); 59 60 return Overflow; 61 } 62 63 /// Given an icmp instruction, return true if any use of this comparison is a 64 /// branch on sign bit comparison. 65 static bool hasBranchUse(ICmpInst &I) { 66 for (auto *U : I.users()) 67 if (isa<BranchInst>(U)) 68 return true; 69 return false; 70 } 71 72 /// Returns true if the exploded icmp can be expressed as a signed comparison 73 /// to zero and updates the predicate accordingly. 74 /// The signedness of the comparison is preserved. 75 /// TODO: Refactor with decomposeBitTestICmp()? 76 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 77 if (!ICmpInst::isSigned(Pred)) 78 return false; 79 80 if (C.isZero()) 81 return ICmpInst::isRelational(Pred); 82 83 if (C.isOne()) { 84 if (Pred == ICmpInst::ICMP_SLT) { 85 Pred = ICmpInst::ICMP_SLE; 86 return true; 87 } 88 } else if (C.isAllOnes()) { 89 if (Pred == ICmpInst::ICMP_SGT) { 90 Pred = ICmpInst::ICMP_SGE; 91 return true; 92 } 93 } 94 95 return false; 96 } 97 98 /// This is called when we see this pattern: 99 /// cmp pred (load (gep GV, ...)), cmpcst 100 /// where GV is a global variable with a constant initializer. Try to simplify 101 /// this into some simple computation that does not need the load. For example 102 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 103 /// 104 /// If AndCst is non-null, then the loaded value is masked with that constant 105 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 106 Instruction *InstCombinerImpl::foldCmpLoadFromIndexedGlobal( 107 LoadInst *LI, GetElementPtrInst *GEP, GlobalVariable *GV, CmpInst &ICI, 108 ConstantInt *AndCst) { 109 if (LI->isVolatile() || LI->getType() != GEP->getResultElementType() || 110 GV->getValueType() != GEP->getSourceElementType() || 111 !GV->isConstant() || !GV->hasDefinitiveInitializer()) 112 return nullptr; 113 114 Constant *Init = GV->getInitializer(); 115 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 116 return nullptr; 117 118 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 119 // Don't blow up on huge arrays. 120 if (ArrayElementCount > MaxArraySizeForCombine) 121 return nullptr; 122 123 // There are many forms of this optimization we can handle, for now, just do 124 // the simple index into a single-dimensional array. 125 // 126 // Require: GEP GV, 0, i {{, constant indices}} 127 if (GEP->getNumOperands() < 3 || 128 !isa<ConstantInt>(GEP->getOperand(1)) || 129 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 130 isa<Constant>(GEP->getOperand(2))) 131 return nullptr; 132 133 // Check that indices after the variable are constants and in-range for the 134 // type they index. Collect the indices. This is typically for arrays of 135 // structs. 136 SmallVector<unsigned, 4> LaterIndices; 137 138 Type *EltTy = Init->getType()->getArrayElementType(); 139 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 140 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 141 if (!Idx) return nullptr; // Variable index. 142 143 uint64_t IdxVal = Idx->getZExtValue(); 144 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 145 146 if (StructType *STy = dyn_cast<StructType>(EltTy)) 147 EltTy = STy->getElementType(IdxVal); 148 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 149 if (IdxVal >= ATy->getNumElements()) return nullptr; 150 EltTy = ATy->getElementType(); 151 } else { 152 return nullptr; // Unknown type. 153 } 154 155 LaterIndices.push_back(IdxVal); 156 } 157 158 enum { Overdefined = -3, Undefined = -2 }; 159 160 // Variables for our state machines. 161 162 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 163 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 164 // and 87 is the second (and last) index. FirstTrueElement is -2 when 165 // undefined, otherwise set to the first true element. SecondTrueElement is 166 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 167 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 168 169 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 170 // form "i != 47 & i != 87". Same state transitions as for true elements. 171 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 172 173 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 174 /// define a state machine that triggers for ranges of values that the index 175 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 176 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 177 /// index in the range (inclusive). We use -2 for undefined here because we 178 /// use relative comparisons and don't want 0-1 to match -1. 179 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 180 181 // MagicBitvector - This is a magic bitvector where we set a bit if the 182 // comparison is true for element 'i'. If there are 64 elements or less in 183 // the array, this will fully represent all the comparison results. 184 uint64_t MagicBitvector = 0; 185 186 // Scan the array and see if one of our patterns matches. 187 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 188 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 189 Constant *Elt = Init->getAggregateElement(i); 190 if (!Elt) return nullptr; 191 192 // If this is indexing an array of structures, get the structure element. 193 if (!LaterIndices.empty()) 194 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 195 196 // If the element is masked, handle it. 197 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 198 199 // Find out if the comparison would be true or false for the i'th element. 200 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 201 CompareRHS, DL, &TLI); 202 // If the result is undef for this element, ignore it. 203 if (isa<UndefValue>(C)) { 204 // Extend range state machines to cover this element in case there is an 205 // undef in the middle of the range. 206 if (TrueRangeEnd == (int)i-1) 207 TrueRangeEnd = i; 208 if (FalseRangeEnd == (int)i-1) 209 FalseRangeEnd = i; 210 continue; 211 } 212 213 // If we can't compute the result for any of the elements, we have to give 214 // up evaluating the entire conditional. 215 if (!isa<ConstantInt>(C)) return nullptr; 216 217 // Otherwise, we know if the comparison is true or false for this element, 218 // update our state machines. 219 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 220 221 // State machine for single/double/range index comparison. 222 if (IsTrueForElt) { 223 // Update the TrueElement state machine. 224 if (FirstTrueElement == Undefined) 225 FirstTrueElement = TrueRangeEnd = i; // First true element. 226 else { 227 // Update double-compare state machine. 228 if (SecondTrueElement == Undefined) 229 SecondTrueElement = i; 230 else 231 SecondTrueElement = Overdefined; 232 233 // Update range state machine. 234 if (TrueRangeEnd == (int)i-1) 235 TrueRangeEnd = i; 236 else 237 TrueRangeEnd = Overdefined; 238 } 239 } else { 240 // Update the FalseElement state machine. 241 if (FirstFalseElement == Undefined) 242 FirstFalseElement = FalseRangeEnd = i; // First false element. 243 else { 244 // Update double-compare state machine. 245 if (SecondFalseElement == Undefined) 246 SecondFalseElement = i; 247 else 248 SecondFalseElement = Overdefined; 249 250 // Update range state machine. 251 if (FalseRangeEnd == (int)i-1) 252 FalseRangeEnd = i; 253 else 254 FalseRangeEnd = Overdefined; 255 } 256 } 257 258 // If this element is in range, update our magic bitvector. 259 if (i < 64 && IsTrueForElt) 260 MagicBitvector |= 1ULL << i; 261 262 // If all of our states become overdefined, bail out early. Since the 263 // predicate is expensive, only check it every 8 elements. This is only 264 // really useful for really huge arrays. 265 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 266 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 267 FalseRangeEnd == Overdefined) 268 return nullptr; 269 } 270 271 // Now that we've scanned the entire array, emit our new comparison(s). We 272 // order the state machines in complexity of the generated code. 273 Value *Idx = GEP->getOperand(2); 274 275 // If the index is larger than the pointer size of the target, truncate the 276 // index down like the GEP would do implicitly. We don't have to do this for 277 // an inbounds GEP because the index can't be out of range. 278 if (!GEP->isInBounds()) { 279 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 280 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 281 if (Idx->getType()->getPrimitiveSizeInBits().getFixedSize() > PtrSize) 282 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 283 } 284 285 // If inbounds keyword is not present, Idx * ElementSize can overflow. 286 // Let's assume that ElementSize is 2 and the wanted value is at offset 0. 287 // Then, there are two possible values for Idx to match offset 0: 288 // 0x00..00, 0x80..00. 289 // Emitting 'icmp eq Idx, 0' isn't correct in this case because the 290 // comparison is false if Idx was 0x80..00. 291 // We need to erase the highest countTrailingZeros(ElementSize) bits of Idx. 292 unsigned ElementSize = 293 DL.getTypeAllocSize(Init->getType()->getArrayElementType()); 294 auto MaskIdx = [&](Value* Idx){ 295 if (!GEP->isInBounds() && countTrailingZeros(ElementSize) != 0) { 296 Value *Mask = ConstantInt::get(Idx->getType(), -1); 297 Mask = Builder.CreateLShr(Mask, countTrailingZeros(ElementSize)); 298 Idx = Builder.CreateAnd(Idx, Mask); 299 } 300 return Idx; 301 }; 302 303 // If the comparison is only true for one or two elements, emit direct 304 // comparisons. 305 if (SecondTrueElement != Overdefined) { 306 Idx = MaskIdx(Idx); 307 // None true -> false. 308 if (FirstTrueElement == Undefined) 309 return replaceInstUsesWith(ICI, Builder.getFalse()); 310 311 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 312 313 // True for one element -> 'i == 47'. 314 if (SecondTrueElement == Undefined) 315 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 316 317 // True for two elements -> 'i == 47 | i == 72'. 318 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 319 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 320 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 321 return BinaryOperator::CreateOr(C1, C2); 322 } 323 324 // If the comparison is only false for one or two elements, emit direct 325 // comparisons. 326 if (SecondFalseElement != Overdefined) { 327 Idx = MaskIdx(Idx); 328 // None false -> true. 329 if (FirstFalseElement == Undefined) 330 return replaceInstUsesWith(ICI, Builder.getTrue()); 331 332 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 333 334 // False for one element -> 'i != 47'. 335 if (SecondFalseElement == Undefined) 336 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 337 338 // False for two elements -> 'i != 47 & i != 72'. 339 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 340 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 341 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 342 return BinaryOperator::CreateAnd(C1, C2); 343 } 344 345 // If the comparison can be replaced with a range comparison for the elements 346 // where it is true, emit the range check. 347 if (TrueRangeEnd != Overdefined) { 348 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 349 Idx = MaskIdx(Idx); 350 351 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 352 if (FirstTrueElement) { 353 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 354 Idx = Builder.CreateAdd(Idx, Offs); 355 } 356 357 Value *End = ConstantInt::get(Idx->getType(), 358 TrueRangeEnd-FirstTrueElement+1); 359 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 360 } 361 362 // False range check. 363 if (FalseRangeEnd != Overdefined) { 364 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 365 Idx = MaskIdx(Idx); 366 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 367 if (FirstFalseElement) { 368 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 369 Idx = Builder.CreateAdd(Idx, Offs); 370 } 371 372 Value *End = ConstantInt::get(Idx->getType(), 373 FalseRangeEnd-FirstFalseElement); 374 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 375 } 376 377 // If a magic bitvector captures the entire comparison state 378 // of this load, replace it with computation that does: 379 // ((magic_cst >> i) & 1) != 0 380 { 381 Type *Ty = nullptr; 382 383 // Look for an appropriate type: 384 // - The type of Idx if the magic fits 385 // - The smallest fitting legal type 386 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 387 Ty = Idx->getType(); 388 else 389 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 390 391 if (Ty) { 392 Idx = MaskIdx(Idx); 393 Value *V = Builder.CreateIntCast(Idx, Ty, false); 394 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 395 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 396 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 397 } 398 } 399 400 return nullptr; 401 } 402 403 /// Return a value that can be used to compare the *offset* implied by a GEP to 404 /// zero. For example, if we have &A[i], we want to return 'i' for 405 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 406 /// are involved. The above expression would also be legal to codegen as 407 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 408 /// This latter form is less amenable to optimization though, and we are allowed 409 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 410 /// 411 /// If we can't emit an optimized form for this expression, this returns null. 412 /// 413 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombinerImpl &IC, 414 const DataLayout &DL) { 415 gep_type_iterator GTI = gep_type_begin(GEP); 416 417 // Check to see if this gep only has a single variable index. If so, and if 418 // any constant indices are a multiple of its scale, then we can compute this 419 // in terms of the scale of the variable index. For example, if the GEP 420 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 421 // because the expression will cross zero at the same point. 422 unsigned i, e = GEP->getNumOperands(); 423 int64_t Offset = 0; 424 for (i = 1; i != e; ++i, ++GTI) { 425 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 426 // Compute the aggregate offset of constant indices. 427 if (CI->isZero()) continue; 428 429 // Handle a struct index, which adds its field offset to the pointer. 430 if (StructType *STy = GTI.getStructTypeOrNull()) { 431 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 432 } else { 433 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 434 Offset += Size*CI->getSExtValue(); 435 } 436 } else { 437 // Found our variable index. 438 break; 439 } 440 } 441 442 // If there are no variable indices, we must have a constant offset, just 443 // evaluate it the general way. 444 if (i == e) return nullptr; 445 446 Value *VariableIdx = GEP->getOperand(i); 447 // Determine the scale factor of the variable element. For example, this is 448 // 4 if the variable index is into an array of i32. 449 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 450 451 // Verify that there are no other variable indices. If so, emit the hard way. 452 for (++i, ++GTI; i != e; ++i, ++GTI) { 453 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 454 if (!CI) return nullptr; 455 456 // Compute the aggregate offset of constant indices. 457 if (CI->isZero()) continue; 458 459 // Handle a struct index, which adds its field offset to the pointer. 460 if (StructType *STy = GTI.getStructTypeOrNull()) { 461 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 462 } else { 463 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 464 Offset += Size*CI->getSExtValue(); 465 } 466 } 467 468 // Okay, we know we have a single variable index, which must be a 469 // pointer/array/vector index. If there is no offset, life is simple, return 470 // the index. 471 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 472 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 473 if (Offset == 0) { 474 // Cast to intptrty in case a truncation occurs. If an extension is needed, 475 // we don't need to bother extending: the extension won't affect where the 476 // computation crosses zero. 477 if (VariableIdx->getType()->getPrimitiveSizeInBits().getFixedSize() > 478 IntPtrWidth) { 479 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 480 } 481 return VariableIdx; 482 } 483 484 // Otherwise, there is an index. The computation we will do will be modulo 485 // the pointer size. 486 Offset = SignExtend64(Offset, IntPtrWidth); 487 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 488 489 // To do this transformation, any constant index must be a multiple of the 490 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 491 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 492 // multiple of the variable scale. 493 int64_t NewOffs = Offset / (int64_t)VariableScale; 494 if (Offset != NewOffs*(int64_t)VariableScale) 495 return nullptr; 496 497 // Okay, we can do this evaluation. Start by converting the index to intptr. 498 if (VariableIdx->getType() != IntPtrTy) 499 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 500 true /*Signed*/); 501 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 502 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 503 } 504 505 /// Returns true if we can rewrite Start as a GEP with pointer Base 506 /// and some integer offset. The nodes that need to be re-written 507 /// for this transformation will be added to Explored. 508 static bool canRewriteGEPAsOffset(Type *ElemTy, Value *Start, Value *Base, 509 const DataLayout &DL, 510 SetVector<Value *> &Explored) { 511 SmallVector<Value *, 16> WorkList(1, Start); 512 Explored.insert(Base); 513 514 // The following traversal gives us an order which can be used 515 // when doing the final transformation. Since in the final 516 // transformation we create the PHI replacement instructions first, 517 // we don't have to get them in any particular order. 518 // 519 // However, for other instructions we will have to traverse the 520 // operands of an instruction first, which means that we have to 521 // do a post-order traversal. 522 while (!WorkList.empty()) { 523 SetVector<PHINode *> PHIs; 524 525 while (!WorkList.empty()) { 526 if (Explored.size() >= 100) 527 return false; 528 529 Value *V = WorkList.back(); 530 531 if (Explored.contains(V)) { 532 WorkList.pop_back(); 533 continue; 534 } 535 536 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 537 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 538 // We've found some value that we can't explore which is different from 539 // the base. Therefore we can't do this transformation. 540 return false; 541 542 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 543 auto *CI = cast<CastInst>(V); 544 if (!CI->isNoopCast(DL)) 545 return false; 546 547 if (!Explored.contains(CI->getOperand(0))) 548 WorkList.push_back(CI->getOperand(0)); 549 } 550 551 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 552 // We're limiting the GEP to having one index. This will preserve 553 // the original pointer type. We could handle more cases in the 554 // future. 555 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 556 GEP->getSourceElementType() != ElemTy) 557 return false; 558 559 if (!Explored.contains(GEP->getOperand(0))) 560 WorkList.push_back(GEP->getOperand(0)); 561 } 562 563 if (WorkList.back() == V) { 564 WorkList.pop_back(); 565 // We've finished visiting this node, mark it as such. 566 Explored.insert(V); 567 } 568 569 if (auto *PN = dyn_cast<PHINode>(V)) { 570 // We cannot transform PHIs on unsplittable basic blocks. 571 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 572 return false; 573 Explored.insert(PN); 574 PHIs.insert(PN); 575 } 576 } 577 578 // Explore the PHI nodes further. 579 for (auto *PN : PHIs) 580 for (Value *Op : PN->incoming_values()) 581 if (!Explored.contains(Op)) 582 WorkList.push_back(Op); 583 } 584 585 // Make sure that we can do this. Since we can't insert GEPs in a basic 586 // block before a PHI node, we can't easily do this transformation if 587 // we have PHI node users of transformed instructions. 588 for (Value *Val : Explored) { 589 for (Value *Use : Val->uses()) { 590 591 auto *PHI = dyn_cast<PHINode>(Use); 592 auto *Inst = dyn_cast<Instruction>(Val); 593 594 if (Inst == Base || Inst == PHI || !Inst || !PHI || 595 !Explored.contains(PHI)) 596 continue; 597 598 if (PHI->getParent() == Inst->getParent()) 599 return false; 600 } 601 } 602 return true; 603 } 604 605 // Sets the appropriate insert point on Builder where we can add 606 // a replacement Instruction for V (if that is possible). 607 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 608 bool Before = true) { 609 if (auto *PHI = dyn_cast<PHINode>(V)) { 610 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 611 return; 612 } 613 if (auto *I = dyn_cast<Instruction>(V)) { 614 if (!Before) 615 I = &*std::next(I->getIterator()); 616 Builder.SetInsertPoint(I); 617 return; 618 } 619 if (auto *A = dyn_cast<Argument>(V)) { 620 // Set the insertion point in the entry block. 621 BasicBlock &Entry = A->getParent()->getEntryBlock(); 622 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 623 return; 624 } 625 // Otherwise, this is a constant and we don't need to set a new 626 // insertion point. 627 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 628 } 629 630 /// Returns a re-written value of Start as an indexed GEP using Base as a 631 /// pointer. 632 static Value *rewriteGEPAsOffset(Type *ElemTy, Value *Start, Value *Base, 633 const DataLayout &DL, 634 SetVector<Value *> &Explored) { 635 // Perform all the substitutions. This is a bit tricky because we can 636 // have cycles in our use-def chains. 637 // 1. Create the PHI nodes without any incoming values. 638 // 2. Create all the other values. 639 // 3. Add the edges for the PHI nodes. 640 // 4. Emit GEPs to get the original pointers. 641 // 5. Remove the original instructions. 642 Type *IndexType = IntegerType::get( 643 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 644 645 DenseMap<Value *, Value *> NewInsts; 646 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 647 648 // Create the new PHI nodes, without adding any incoming values. 649 for (Value *Val : Explored) { 650 if (Val == Base) 651 continue; 652 // Create empty phi nodes. This avoids cyclic dependencies when creating 653 // the remaining instructions. 654 if (auto *PHI = dyn_cast<PHINode>(Val)) 655 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 656 PHI->getName() + ".idx", PHI); 657 } 658 IRBuilder<> Builder(Base->getContext()); 659 660 // Create all the other instructions. 661 for (Value *Val : Explored) { 662 663 if (NewInsts.find(Val) != NewInsts.end()) 664 continue; 665 666 if (auto *CI = dyn_cast<CastInst>(Val)) { 667 // Don't get rid of the intermediate variable here; the store can grow 668 // the map which will invalidate the reference to the input value. 669 Value *V = NewInsts[CI->getOperand(0)]; 670 NewInsts[CI] = V; 671 continue; 672 } 673 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 674 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 675 : GEP->getOperand(1); 676 setInsertionPoint(Builder, GEP); 677 // Indices might need to be sign extended. GEPs will magically do 678 // this, but we need to do it ourselves here. 679 if (Index->getType()->getScalarSizeInBits() != 680 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 681 Index = Builder.CreateSExtOrTrunc( 682 Index, NewInsts[GEP->getOperand(0)]->getType(), 683 GEP->getOperand(0)->getName() + ".sext"); 684 } 685 686 auto *Op = NewInsts[GEP->getOperand(0)]; 687 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 688 NewInsts[GEP] = Index; 689 else 690 NewInsts[GEP] = Builder.CreateNSWAdd( 691 Op, Index, GEP->getOperand(0)->getName() + ".add"); 692 continue; 693 } 694 if (isa<PHINode>(Val)) 695 continue; 696 697 llvm_unreachable("Unexpected instruction type"); 698 } 699 700 // Add the incoming values to the PHI nodes. 701 for (Value *Val : Explored) { 702 if (Val == Base) 703 continue; 704 // All the instructions have been created, we can now add edges to the 705 // phi nodes. 706 if (auto *PHI = dyn_cast<PHINode>(Val)) { 707 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 708 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 709 Value *NewIncoming = PHI->getIncomingValue(I); 710 711 if (NewInsts.find(NewIncoming) != NewInsts.end()) 712 NewIncoming = NewInsts[NewIncoming]; 713 714 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 715 } 716 } 717 } 718 719 PointerType *PtrTy = 720 ElemTy->getPointerTo(Start->getType()->getPointerAddressSpace()); 721 for (Value *Val : Explored) { 722 if (Val == Base) 723 continue; 724 725 // Depending on the type, for external users we have to emit 726 // a GEP or a GEP + ptrtoint. 727 setInsertionPoint(Builder, Val, false); 728 729 // Cast base to the expected type. 730 Value *NewVal = Builder.CreateBitOrPointerCast( 731 Base, PtrTy, Start->getName() + "to.ptr"); 732 NewVal = Builder.CreateInBoundsGEP( 733 ElemTy, NewVal, makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 734 NewVal = Builder.CreateBitOrPointerCast( 735 NewVal, Val->getType(), Val->getName() + ".conv"); 736 Val->replaceAllUsesWith(NewVal); 737 } 738 739 return NewInsts[Start]; 740 } 741 742 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 743 /// the input Value as a constant indexed GEP. Returns a pair containing 744 /// the GEPs Pointer and Index. 745 static std::pair<Value *, Value *> 746 getAsConstantIndexedAddress(Type *ElemTy, Value *V, const DataLayout &DL) { 747 Type *IndexType = IntegerType::get(V->getContext(), 748 DL.getIndexTypeSizeInBits(V->getType())); 749 750 Constant *Index = ConstantInt::getNullValue(IndexType); 751 while (true) { 752 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 753 // We accept only inbouds GEPs here to exclude the possibility of 754 // overflow. 755 if (!GEP->isInBounds()) 756 break; 757 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 758 GEP->getSourceElementType() == ElemTy) { 759 V = GEP->getOperand(0); 760 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 761 Index = ConstantExpr::getAdd( 762 Index, ConstantExpr::getSExtOrTrunc(GEPIndex, IndexType)); 763 continue; 764 } 765 break; 766 } 767 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 768 if (!CI->isNoopCast(DL)) 769 break; 770 V = CI->getOperand(0); 771 continue; 772 } 773 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 774 if (!CI->isNoopCast(DL)) 775 break; 776 V = CI->getOperand(0); 777 continue; 778 } 779 break; 780 } 781 return {V, Index}; 782 } 783 784 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 785 /// We can look through PHIs, GEPs and casts in order to determine a common base 786 /// between GEPLHS and RHS. 787 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 788 ICmpInst::Predicate Cond, 789 const DataLayout &DL) { 790 // FIXME: Support vector of pointers. 791 if (GEPLHS->getType()->isVectorTy()) 792 return nullptr; 793 794 if (!GEPLHS->hasAllConstantIndices()) 795 return nullptr; 796 797 Type *ElemTy = GEPLHS->getSourceElementType(); 798 Value *PtrBase, *Index; 799 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(ElemTy, GEPLHS, DL); 800 801 // The set of nodes that will take part in this transformation. 802 SetVector<Value *> Nodes; 803 804 if (!canRewriteGEPAsOffset(ElemTy, RHS, PtrBase, DL, Nodes)) 805 return nullptr; 806 807 // We know we can re-write this as 808 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 809 // Since we've only looked through inbouds GEPs we know that we 810 // can't have overflow on either side. We can therefore re-write 811 // this as: 812 // OFFSET1 cmp OFFSET2 813 Value *NewRHS = rewriteGEPAsOffset(ElemTy, RHS, PtrBase, DL, Nodes); 814 815 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 816 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 817 // offset. Since Index is the offset of LHS to the base pointer, we will now 818 // compare the offsets instead of comparing the pointers. 819 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 820 } 821 822 /// Fold comparisons between a GEP instruction and something else. At this point 823 /// we know that the GEP is on the LHS of the comparison. 824 Instruction *InstCombinerImpl::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 825 ICmpInst::Predicate Cond, 826 Instruction &I) { 827 // Don't transform signed compares of GEPs into index compares. Even if the 828 // GEP is inbounds, the final add of the base pointer can have signed overflow 829 // and would change the result of the icmp. 830 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 831 // the maximum signed value for the pointer type. 832 if (ICmpInst::isSigned(Cond)) 833 return nullptr; 834 835 // Look through bitcasts and addrspacecasts. We do not however want to remove 836 // 0 GEPs. 837 if (!isa<GetElementPtrInst>(RHS)) 838 RHS = RHS->stripPointerCasts(); 839 840 Value *PtrBase = GEPLHS->getOperand(0); 841 // FIXME: Support vector pointer GEPs. 842 if (PtrBase == RHS && GEPLHS->isInBounds() && 843 !GEPLHS->getType()->isVectorTy()) { 844 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 845 // This transformation (ignoring the base and scales) is valid because we 846 // know pointers can't overflow since the gep is inbounds. See if we can 847 // output an optimized form. 848 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 849 850 // If not, synthesize the offset the hard way. 851 if (!Offset) 852 Offset = EmitGEPOffset(GEPLHS); 853 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 854 Constant::getNullValue(Offset->getType())); 855 } 856 857 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) && 858 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() && 859 !NullPointerIsDefined(I.getFunction(), 860 RHS->getType()->getPointerAddressSpace())) { 861 // For most address spaces, an allocation can't be placed at null, but null 862 // itself is treated as a 0 size allocation in the in bounds rules. Thus, 863 // the only valid inbounds address derived from null, is null itself. 864 // Thus, we have four cases to consider: 865 // 1) Base == nullptr, Offset == 0 -> inbounds, null 866 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds 867 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations) 868 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison) 869 // 870 // (Note if we're indexing a type of size 0, that simply collapses into one 871 // of the buckets above.) 872 // 873 // In general, we're allowed to make values less poison (i.e. remove 874 // sources of full UB), so in this case, we just select between the two 875 // non-poison cases (1 and 4 above). 876 // 877 // For vectors, we apply the same reasoning on a per-lane basis. 878 auto *Base = GEPLHS->getPointerOperand(); 879 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) { 880 auto EC = cast<VectorType>(GEPLHS->getType())->getElementCount(); 881 Base = Builder.CreateVectorSplat(EC, Base); 882 } 883 return new ICmpInst(Cond, Base, 884 ConstantExpr::getPointerBitCastOrAddrSpaceCast( 885 cast<Constant>(RHS), Base->getType())); 886 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 887 // If the base pointers are different, but the indices are the same, just 888 // compare the base pointer. 889 if (PtrBase != GEPRHS->getOperand(0)) { 890 bool IndicesTheSame = 891 GEPLHS->getNumOperands() == GEPRHS->getNumOperands() && 892 GEPLHS->getPointerOperand()->getType() == 893 GEPRHS->getPointerOperand()->getType() && 894 GEPLHS->getSourceElementType() == GEPRHS->getSourceElementType(); 895 if (IndicesTheSame) 896 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 897 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 898 IndicesTheSame = false; 899 break; 900 } 901 902 // If all indices are the same, just compare the base pointers. 903 Type *BaseType = GEPLHS->getOperand(0)->getType(); 904 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 905 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 906 907 // If we're comparing GEPs with two base pointers that only differ in type 908 // and both GEPs have only constant indices or just one use, then fold 909 // the compare with the adjusted indices. 910 // FIXME: Support vector of pointers. 911 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 912 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 913 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 914 PtrBase->stripPointerCasts() == 915 GEPRHS->getOperand(0)->stripPointerCasts() && 916 !GEPLHS->getType()->isVectorTy()) { 917 Value *LOffset = EmitGEPOffset(GEPLHS); 918 Value *ROffset = EmitGEPOffset(GEPRHS); 919 920 // If we looked through an addrspacecast between different sized address 921 // spaces, the LHS and RHS pointers are different sized 922 // integers. Truncate to the smaller one. 923 Type *LHSIndexTy = LOffset->getType(); 924 Type *RHSIndexTy = ROffset->getType(); 925 if (LHSIndexTy != RHSIndexTy) { 926 if (LHSIndexTy->getPrimitiveSizeInBits().getFixedSize() < 927 RHSIndexTy->getPrimitiveSizeInBits().getFixedSize()) { 928 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 929 } else 930 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 931 } 932 933 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 934 LOffset, ROffset); 935 return replaceInstUsesWith(I, Cmp); 936 } 937 938 // Otherwise, the base pointers are different and the indices are 939 // different. Try convert this to an indexed compare by looking through 940 // PHIs/casts. 941 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 942 } 943 944 // If one of the GEPs has all zero indices, recurse. 945 // FIXME: Handle vector of pointers. 946 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices()) 947 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 948 ICmpInst::getSwappedPredicate(Cond), I); 949 950 // If the other GEP has all zero indices, recurse. 951 // FIXME: Handle vector of pointers. 952 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices()) 953 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 954 955 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 956 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands() && 957 GEPLHS->getSourceElementType() == GEPRHS->getSourceElementType()) { 958 // If the GEPs only differ by one index, compare it. 959 unsigned NumDifferences = 0; // Keep track of # differences. 960 unsigned DiffOperand = 0; // The operand that differs. 961 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 962 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 963 Type *LHSType = GEPLHS->getOperand(i)->getType(); 964 Type *RHSType = GEPRHS->getOperand(i)->getType(); 965 // FIXME: Better support for vector of pointers. 966 if (LHSType->getPrimitiveSizeInBits() != 967 RHSType->getPrimitiveSizeInBits() || 968 (GEPLHS->getType()->isVectorTy() && 969 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) { 970 // Irreconcilable differences. 971 NumDifferences = 2; 972 break; 973 } 974 975 if (NumDifferences++) break; 976 DiffOperand = i; 977 } 978 979 if (NumDifferences == 0) // SAME GEP? 980 return replaceInstUsesWith(I, // No comparison is needed here. 981 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 982 983 else if (NumDifferences == 1 && GEPsInBounds) { 984 Value *LHSV = GEPLHS->getOperand(DiffOperand); 985 Value *RHSV = GEPRHS->getOperand(DiffOperand); 986 // Make sure we do a signed comparison here. 987 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 988 } 989 } 990 991 // Only lower this if the icmp is the only user of the GEP or if we expect 992 // the result to fold to a constant! 993 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 994 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 995 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 996 Value *L = EmitGEPOffset(GEPLHS); 997 Value *R = EmitGEPOffset(GEPRHS); 998 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 999 } 1000 } 1001 1002 // Try convert this to an indexed compare by looking through PHIs/casts as a 1003 // last resort. 1004 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1005 } 1006 1007 Instruction *InstCombinerImpl::foldAllocaCmp(ICmpInst &ICI, 1008 const AllocaInst *Alloca) { 1009 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1010 1011 // It would be tempting to fold away comparisons between allocas and any 1012 // pointer not based on that alloca (e.g. an argument). However, even 1013 // though such pointers cannot alias, they can still compare equal. 1014 // 1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1016 // doesn't escape we can argue that it's impossible to guess its value, and we 1017 // can therefore act as if any such guesses are wrong. 1018 // 1019 // The code below checks that the alloca doesn't escape, and that it's only 1020 // used in a comparison once (the current instruction). The 1021 // single-comparison-use condition ensures that we're trivially folding all 1022 // comparisons against the alloca consistently, and avoids the risk of 1023 // erroneously folding a comparison of the pointer with itself. 1024 1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1026 1027 SmallVector<const Use *, 32> Worklist; 1028 for (const Use &U : Alloca->uses()) { 1029 if (Worklist.size() >= MaxIter) 1030 return nullptr; 1031 Worklist.push_back(&U); 1032 } 1033 1034 unsigned NumCmps = 0; 1035 while (!Worklist.empty()) { 1036 assert(Worklist.size() <= MaxIter); 1037 const Use *U = Worklist.pop_back_val(); 1038 const Value *V = U->getUser(); 1039 --MaxIter; 1040 1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1042 isa<SelectInst>(V)) { 1043 // Track the uses. 1044 } else if (isa<LoadInst>(V)) { 1045 // Loading from the pointer doesn't escape it. 1046 continue; 1047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1048 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1049 if (SI->getValueOperand() == U->get()) 1050 return nullptr; 1051 continue; 1052 } else if (isa<ICmpInst>(V)) { 1053 if (NumCmps++) 1054 return nullptr; // Found more than one cmp. 1055 continue; 1056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1057 switch (Intrin->getIntrinsicID()) { 1058 // These intrinsics don't escape or compare the pointer. Memset is safe 1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1060 // we don't allow stores, so src cannot point to V. 1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1063 continue; 1064 default: 1065 return nullptr; 1066 } 1067 } else { 1068 return nullptr; 1069 } 1070 for (const Use &U : V->uses()) { 1071 if (Worklist.size() >= MaxIter) 1072 return nullptr; 1073 Worklist.push_back(&U); 1074 } 1075 } 1076 1077 auto *Res = ConstantInt::get(ICI.getType(), 1078 !CmpInst::isTrueWhenEqual(ICI.getPredicate())); 1079 return replaceInstUsesWith(ICI, Res); 1080 } 1081 1082 /// Fold "icmp pred (X+C), X". 1083 Instruction *InstCombinerImpl::foldICmpAddOpConst(Value *X, const APInt &C, 1084 ICmpInst::Predicate Pred) { 1085 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1086 // so the values can never be equal. Similarly for all other "or equals" 1087 // operators. 1088 assert(!!C && "C should not be zero!"); 1089 1090 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1091 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1092 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1093 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1094 Constant *R = ConstantInt::get(X->getType(), 1095 APInt::getMaxValue(C.getBitWidth()) - C); 1096 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1097 } 1098 1099 // (X+1) >u X --> X <u (0-1) --> X != 255 1100 // (X+2) >u X --> X <u (0-2) --> X <u 254 1101 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1102 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1103 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1104 ConstantInt::get(X->getType(), -C)); 1105 1106 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1107 1108 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1109 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1110 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1111 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1112 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1113 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1114 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1115 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1116 ConstantInt::get(X->getType(), SMax - C)); 1117 1118 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1119 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1120 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1121 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1122 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1123 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1124 1125 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1126 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1127 ConstantInt::get(X->getType(), SMax - (C - 1))); 1128 } 1129 1130 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1131 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1132 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1133 Instruction *InstCombinerImpl::foldICmpShrConstConst(ICmpInst &I, Value *A, 1134 const APInt &AP1, 1135 const APInt &AP2) { 1136 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1137 1138 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1139 if (I.getPredicate() == I.ICMP_NE) 1140 Pred = CmpInst::getInversePredicate(Pred); 1141 return new ICmpInst(Pred, LHS, RHS); 1142 }; 1143 1144 // Don't bother doing any work for cases which InstSimplify handles. 1145 if (AP2.isZero()) 1146 return nullptr; 1147 1148 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1149 if (IsAShr) { 1150 if (AP2.isAllOnes()) 1151 return nullptr; 1152 if (AP2.isNegative() != AP1.isNegative()) 1153 return nullptr; 1154 if (AP2.sgt(AP1)) 1155 return nullptr; 1156 } 1157 1158 if (!AP1) 1159 // 'A' must be large enough to shift out the highest set bit. 1160 return getICmp(I.ICMP_UGT, A, 1161 ConstantInt::get(A->getType(), AP2.logBase2())); 1162 1163 if (AP1 == AP2) 1164 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1165 1166 int Shift; 1167 if (IsAShr && AP1.isNegative()) 1168 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1169 else 1170 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1171 1172 if (Shift > 0) { 1173 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1174 // There are multiple solutions if we are comparing against -1 and the LHS 1175 // of the ashr is not a power of two. 1176 if (AP1.isAllOnes() && !AP2.isPowerOf2()) 1177 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1178 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1179 } else if (AP1 == AP2.lshr(Shift)) { 1180 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1181 } 1182 } 1183 1184 // Shifting const2 will never be equal to const1. 1185 // FIXME: This should always be handled by InstSimplify? 1186 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1187 return replaceInstUsesWith(I, TorF); 1188 } 1189 1190 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1191 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1192 Instruction *InstCombinerImpl::foldICmpShlConstConst(ICmpInst &I, Value *A, 1193 const APInt &AP1, 1194 const APInt &AP2) { 1195 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1196 1197 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1198 if (I.getPredicate() == I.ICMP_NE) 1199 Pred = CmpInst::getInversePredicate(Pred); 1200 return new ICmpInst(Pred, LHS, RHS); 1201 }; 1202 1203 // Don't bother doing any work for cases which InstSimplify handles. 1204 if (AP2.isZero()) 1205 return nullptr; 1206 1207 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1208 1209 if (!AP1 && AP2TrailingZeros != 0) 1210 return getICmp( 1211 I.ICMP_UGE, A, 1212 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1213 1214 if (AP1 == AP2) 1215 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1216 1217 // Get the distance between the lowest bits that are set. 1218 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1219 1220 if (Shift > 0 && AP2.shl(Shift) == AP1) 1221 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1222 1223 // Shifting const2 will never be equal to const1. 1224 // FIXME: This should always be handled by InstSimplify? 1225 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1226 return replaceInstUsesWith(I, TorF); 1227 } 1228 1229 /// The caller has matched a pattern of the form: 1230 /// I = icmp ugt (add (add A, B), CI2), CI1 1231 /// If this is of the form: 1232 /// sum = a + b 1233 /// if (sum+128 >u 255) 1234 /// Then replace it with llvm.sadd.with.overflow.i8. 1235 /// 1236 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1237 ConstantInt *CI2, ConstantInt *CI1, 1238 InstCombinerImpl &IC) { 1239 // The transformation we're trying to do here is to transform this into an 1240 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1241 // with a narrower add, and discard the add-with-constant that is part of the 1242 // range check (if we can't eliminate it, this isn't profitable). 1243 1244 // In order to eliminate the add-with-constant, the compare can be its only 1245 // use. 1246 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1247 if (!AddWithCst->hasOneUse()) 1248 return nullptr; 1249 1250 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1251 if (!CI2->getValue().isPowerOf2()) 1252 return nullptr; 1253 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1254 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1255 return nullptr; 1256 1257 // The width of the new add formed is 1 more than the bias. 1258 ++NewWidth; 1259 1260 // Check to see that CI1 is an all-ones value with NewWidth bits. 1261 if (CI1->getBitWidth() == NewWidth || 1262 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1263 return nullptr; 1264 1265 // This is only really a signed overflow check if the inputs have been 1266 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1267 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1268 if (IC.ComputeMaxSignificantBits(A, 0, &I) > NewWidth || 1269 IC.ComputeMaxSignificantBits(B, 0, &I) > NewWidth) 1270 return nullptr; 1271 1272 // In order to replace the original add with a narrower 1273 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1274 // and truncates that discard the high bits of the add. Verify that this is 1275 // the case. 1276 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1277 for (User *U : OrigAdd->users()) { 1278 if (U == AddWithCst) 1279 continue; 1280 1281 // Only accept truncates for now. We would really like a nice recursive 1282 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1283 // chain to see which bits of a value are actually demanded. If the 1284 // original add had another add which was then immediately truncated, we 1285 // could still do the transformation. 1286 TruncInst *TI = dyn_cast<TruncInst>(U); 1287 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1288 return nullptr; 1289 } 1290 1291 // If the pattern matches, truncate the inputs to the narrower type and 1292 // use the sadd_with_overflow intrinsic to efficiently compute both the 1293 // result and the overflow bit. 1294 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1295 Function *F = Intrinsic::getDeclaration( 1296 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1297 1298 InstCombiner::BuilderTy &Builder = IC.Builder; 1299 1300 // Put the new code above the original add, in case there are any uses of the 1301 // add between the add and the compare. 1302 Builder.SetInsertPoint(OrigAdd); 1303 1304 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1305 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1306 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1307 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1308 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1309 1310 // The inner add was the result of the narrow add, zero extended to the 1311 // wider type. Replace it with the result computed by the intrinsic. 1312 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1313 IC.eraseInstFromFunction(*OrigAdd); 1314 1315 // The original icmp gets replaced with the overflow value. 1316 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1317 } 1318 1319 /// If we have: 1320 /// icmp eq/ne (urem/srem %x, %y), 0 1321 /// iff %y is a power-of-two, we can replace this with a bit test: 1322 /// icmp eq/ne (and %x, (add %y, -1)), 0 1323 Instruction *InstCombinerImpl::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1324 // This fold is only valid for equality predicates. 1325 if (!I.isEquality()) 1326 return nullptr; 1327 ICmpInst::Predicate Pred; 1328 Value *X, *Y, *Zero; 1329 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1330 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1331 return nullptr; 1332 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1333 return nullptr; 1334 // This may increase instruction count, we don't enforce that Y is a constant. 1335 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1336 Value *Masked = Builder.CreateAnd(X, Mask); 1337 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1338 } 1339 1340 /// Fold equality-comparison between zero and any (maybe truncated) right-shift 1341 /// by one-less-than-bitwidth into a sign test on the original value. 1342 Instruction *InstCombinerImpl::foldSignBitTest(ICmpInst &I) { 1343 Instruction *Val; 1344 ICmpInst::Predicate Pred; 1345 if (!I.isEquality() || !match(&I, m_ICmp(Pred, m_Instruction(Val), m_Zero()))) 1346 return nullptr; 1347 1348 Value *X; 1349 Type *XTy; 1350 1351 Constant *C; 1352 if (match(Val, m_TruncOrSelf(m_Shr(m_Value(X), m_Constant(C))))) { 1353 XTy = X->getType(); 1354 unsigned XBitWidth = XTy->getScalarSizeInBits(); 1355 if (!match(C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1356 APInt(XBitWidth, XBitWidth - 1)))) 1357 return nullptr; 1358 } else if (isa<BinaryOperator>(Val) && 1359 (X = reassociateShiftAmtsOfTwoSameDirectionShifts( 1360 cast<BinaryOperator>(Val), SQ.getWithInstruction(Val), 1361 /*AnalyzeForSignBitExtraction=*/true))) { 1362 XTy = X->getType(); 1363 } else 1364 return nullptr; 1365 1366 return ICmpInst::Create(Instruction::ICmp, 1367 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_SGE 1368 : ICmpInst::ICMP_SLT, 1369 X, ConstantInt::getNullValue(XTy)); 1370 } 1371 1372 // Handle icmp pred X, 0 1373 Instruction *InstCombinerImpl::foldICmpWithZero(ICmpInst &Cmp) { 1374 CmpInst::Predicate Pred = Cmp.getPredicate(); 1375 if (!match(Cmp.getOperand(1), m_Zero())) 1376 return nullptr; 1377 1378 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1379 if (Pred == ICmpInst::ICMP_SGT) { 1380 Value *A, *B; 1381 if (match(Cmp.getOperand(0), m_SMin(m_Value(A), m_Value(B)))) { 1382 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1383 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1384 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1385 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1386 } 1387 } 1388 1389 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1390 return New; 1391 1392 // Given: 1393 // icmp eq/ne (urem %x, %y), 0 1394 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1395 // icmp eq/ne %x, 0 1396 Value *X, *Y; 1397 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1398 ICmpInst::isEquality(Pred)) { 1399 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1400 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1401 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1402 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1403 } 1404 1405 return nullptr; 1406 } 1407 1408 /// Fold icmp Pred X, C. 1409 /// TODO: This code structure does not make sense. The saturating add fold 1410 /// should be moved to some other helper and extended as noted below (it is also 1411 /// possible that code has been made unnecessary - do we canonicalize IR to 1412 /// overflow/saturating intrinsics or not?). 1413 Instruction *InstCombinerImpl::foldICmpWithConstant(ICmpInst &Cmp) { 1414 // Match the following pattern, which is a common idiom when writing 1415 // overflow-safe integer arithmetic functions. The source performs an addition 1416 // in wider type and explicitly checks for overflow using comparisons against 1417 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1418 // 1419 // TODO: This could probably be generalized to handle other overflow-safe 1420 // operations if we worked out the formulas to compute the appropriate magic 1421 // constants. 1422 // 1423 // sum = a + b 1424 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1425 CmpInst::Predicate Pred = Cmp.getPredicate(); 1426 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1427 Value *A, *B; 1428 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1429 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1430 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1431 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1432 return Res; 1433 1434 // icmp(phi(C1, C2, ...), C) -> phi(icmp(C1, C), icmp(C2, C), ...). 1435 Constant *C = dyn_cast<Constant>(Op1); 1436 if (!C || C->canTrap()) 1437 return nullptr; 1438 1439 if (auto *Phi = dyn_cast<PHINode>(Op0)) 1440 if (all_of(Phi->operands(), [](Value *V) { return isa<Constant>(V); })) { 1441 Type *Ty = Cmp.getType(); 1442 Builder.SetInsertPoint(Phi); 1443 PHINode *NewPhi = 1444 Builder.CreatePHI(Ty, Phi->getNumOperands()); 1445 for (BasicBlock *Predecessor : predecessors(Phi->getParent())) { 1446 auto *Input = 1447 cast<Constant>(Phi->getIncomingValueForBlock(Predecessor)); 1448 auto *BoolInput = ConstantExpr::getCompare(Pred, Input, C); 1449 NewPhi->addIncoming(BoolInput, Predecessor); 1450 } 1451 NewPhi->takeName(&Cmp); 1452 return replaceInstUsesWith(Cmp, NewPhi); 1453 } 1454 1455 return nullptr; 1456 } 1457 1458 /// Canonicalize icmp instructions based on dominating conditions. 1459 Instruction *InstCombinerImpl::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1460 // This is a cheap/incomplete check for dominance - just match a single 1461 // predecessor with a conditional branch. 1462 BasicBlock *CmpBB = Cmp.getParent(); 1463 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1464 if (!DomBB) 1465 return nullptr; 1466 1467 Value *DomCond; 1468 BasicBlock *TrueBB, *FalseBB; 1469 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1470 return nullptr; 1471 1472 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1473 "Predecessor block does not point to successor?"); 1474 1475 // The branch should get simplified. Don't bother simplifying this condition. 1476 if (TrueBB == FalseBB) 1477 return nullptr; 1478 1479 // Try to simplify this compare to T/F based on the dominating condition. 1480 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1481 if (Imp) 1482 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1483 1484 CmpInst::Predicate Pred = Cmp.getPredicate(); 1485 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1486 ICmpInst::Predicate DomPred; 1487 const APInt *C, *DomC; 1488 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1489 match(Y, m_APInt(C))) { 1490 // We have 2 compares of a variable with constants. Calculate the constant 1491 // ranges of those compares to see if we can transform the 2nd compare: 1492 // DomBB: 1493 // DomCond = icmp DomPred X, DomC 1494 // br DomCond, CmpBB, FalseBB 1495 // CmpBB: 1496 // Cmp = icmp Pred X, C 1497 ConstantRange CR = ConstantRange::makeExactICmpRegion(Pred, *C); 1498 ConstantRange DominatingCR = 1499 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1500 : ConstantRange::makeExactICmpRegion( 1501 CmpInst::getInversePredicate(DomPred), *DomC); 1502 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1503 ConstantRange Difference = DominatingCR.difference(CR); 1504 if (Intersection.isEmptySet()) 1505 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1506 if (Difference.isEmptySet()) 1507 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1508 1509 // Canonicalizing a sign bit comparison that gets used in a branch, 1510 // pessimizes codegen by generating branch on zero instruction instead 1511 // of a test and branch. So we avoid canonicalizing in such situations 1512 // because test and branch instruction has better branch displacement 1513 // than compare and branch instruction. 1514 bool UnusedBit; 1515 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1516 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1517 return nullptr; 1518 1519 // Avoid an infinite loop with min/max canonicalization. 1520 // TODO: This will be unnecessary if we canonicalize to min/max intrinsics. 1521 if (Cmp.hasOneUse() && 1522 match(Cmp.user_back(), m_MaxOrMin(m_Value(), m_Value()))) 1523 return nullptr; 1524 1525 if (const APInt *EqC = Intersection.getSingleElement()) 1526 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1527 if (const APInt *NeC = Difference.getSingleElement()) 1528 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1529 } 1530 1531 return nullptr; 1532 } 1533 1534 /// Fold icmp (trunc X, Y), C. 1535 Instruction *InstCombinerImpl::foldICmpTruncConstant(ICmpInst &Cmp, 1536 TruncInst *Trunc, 1537 const APInt &C) { 1538 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1539 Value *X = Trunc->getOperand(0); 1540 if (C.isOne() && C.getBitWidth() > 1) { 1541 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1542 Value *V = nullptr; 1543 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1544 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1545 ConstantInt::get(V->getType(), 1)); 1546 } 1547 1548 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1549 SrcBits = X->getType()->getScalarSizeInBits(); 1550 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1551 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1552 // of the high bits truncated out of x are known. 1553 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1554 1555 // If all the high bits are known, we can do this xform. 1556 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1557 // Pull in the high bits from known-ones set. 1558 APInt NewRHS = C.zext(SrcBits); 1559 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1560 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1561 } 1562 } 1563 1564 // Look through truncated right-shift of the sign-bit for a sign-bit check: 1565 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] < 0 --> ShOp < 0 1566 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] > -1 --> ShOp > -1 1567 Value *ShOp; 1568 const APInt *ShAmtC; 1569 bool TrueIfSigned; 1570 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1571 match(X, m_Shr(m_Value(ShOp), m_APInt(ShAmtC))) && 1572 DstBits == SrcBits - ShAmtC->getZExtValue()) { 1573 return TrueIfSigned 1574 ? new ICmpInst(ICmpInst::ICMP_SLT, ShOp, 1575 ConstantInt::getNullValue(X->getType())) 1576 : new ICmpInst(ICmpInst::ICMP_SGT, ShOp, 1577 ConstantInt::getAllOnesValue(X->getType())); 1578 } 1579 1580 return nullptr; 1581 } 1582 1583 /// Fold icmp (xor X, Y), C. 1584 Instruction *InstCombinerImpl::foldICmpXorConstant(ICmpInst &Cmp, 1585 BinaryOperator *Xor, 1586 const APInt &C) { 1587 Value *X = Xor->getOperand(0); 1588 Value *Y = Xor->getOperand(1); 1589 const APInt *XorC; 1590 if (!match(Y, m_APInt(XorC))) 1591 return nullptr; 1592 1593 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1594 // fold the xor. 1595 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1596 bool TrueIfSigned = false; 1597 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1598 1599 // If the sign bit of the XorCst is not set, there is no change to 1600 // the operation, just stop using the Xor. 1601 if (!XorC->isNegative()) 1602 return replaceOperand(Cmp, 0, X); 1603 1604 // Emit the opposite comparison. 1605 if (TrueIfSigned) 1606 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1607 ConstantInt::getAllOnesValue(X->getType())); 1608 else 1609 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1610 ConstantInt::getNullValue(X->getType())); 1611 } 1612 1613 if (Xor->hasOneUse()) { 1614 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1615 if (!Cmp.isEquality() && XorC->isSignMask()) { 1616 Pred = Cmp.getFlippedSignednessPredicate(); 1617 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1618 } 1619 1620 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1621 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1622 Pred = Cmp.getFlippedSignednessPredicate(); 1623 Pred = Cmp.getSwappedPredicate(Pred); 1624 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1625 } 1626 } 1627 1628 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1629 if (Pred == ICmpInst::ICMP_UGT) { 1630 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1631 if (*XorC == ~C && (C + 1).isPowerOf2()) 1632 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1633 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1634 if (*XorC == C && (C + 1).isPowerOf2()) 1635 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1636 } 1637 if (Pred == ICmpInst::ICMP_ULT) { 1638 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1639 if (*XorC == -C && C.isPowerOf2()) 1640 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1641 ConstantInt::get(X->getType(), ~C)); 1642 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1643 if (*XorC == C && (-C).isPowerOf2()) 1644 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1645 ConstantInt::get(X->getType(), ~C)); 1646 } 1647 return nullptr; 1648 } 1649 1650 /// Fold icmp (and (sh X, Y), C2), C1. 1651 Instruction *InstCombinerImpl::foldICmpAndShift(ICmpInst &Cmp, 1652 BinaryOperator *And, 1653 const APInt &C1, 1654 const APInt &C2) { 1655 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1656 if (!Shift || !Shift->isShift()) 1657 return nullptr; 1658 1659 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1660 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1661 // code produced by the clang front-end, for bitfield access. 1662 // This seemingly simple opportunity to fold away a shift turns out to be 1663 // rather complicated. See PR17827 for details. 1664 unsigned ShiftOpcode = Shift->getOpcode(); 1665 bool IsShl = ShiftOpcode == Instruction::Shl; 1666 const APInt *C3; 1667 if (match(Shift->getOperand(1), m_APInt(C3))) { 1668 APInt NewAndCst, NewCmpCst; 1669 bool AnyCmpCstBitsShiftedOut; 1670 if (ShiftOpcode == Instruction::Shl) { 1671 // For a left shift, we can fold if the comparison is not signed. We can 1672 // also fold a signed comparison if the mask value and comparison value 1673 // are not negative. These constraints may not be obvious, but we can 1674 // prove that they are correct using an SMT solver. 1675 if (Cmp.isSigned() && (C2.isNegative() || C1.isNegative())) 1676 return nullptr; 1677 1678 NewCmpCst = C1.lshr(*C3); 1679 NewAndCst = C2.lshr(*C3); 1680 AnyCmpCstBitsShiftedOut = NewCmpCst.shl(*C3) != C1; 1681 } else if (ShiftOpcode == Instruction::LShr) { 1682 // For a logical right shift, we can fold if the comparison is not signed. 1683 // We can also fold a signed comparison if the shifted mask value and the 1684 // shifted comparison value are not negative. These constraints may not be 1685 // obvious, but we can prove that they are correct using an SMT solver. 1686 NewCmpCst = C1.shl(*C3); 1687 NewAndCst = C2.shl(*C3); 1688 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1689 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1690 return nullptr; 1691 } else { 1692 // For an arithmetic shift, check that both constants don't use (in a 1693 // signed sense) the top bits being shifted out. 1694 assert(ShiftOpcode == Instruction::AShr && "Unknown shift opcode"); 1695 NewCmpCst = C1.shl(*C3); 1696 NewAndCst = C2.shl(*C3); 1697 AnyCmpCstBitsShiftedOut = NewCmpCst.ashr(*C3) != C1; 1698 if (NewAndCst.ashr(*C3) != C2) 1699 return nullptr; 1700 } 1701 1702 if (AnyCmpCstBitsShiftedOut) { 1703 // If we shifted bits out, the fold is not going to work out. As a 1704 // special case, check to see if this means that the result is always 1705 // true or false now. 1706 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1707 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1708 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1709 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1710 } else { 1711 Value *NewAnd = Builder.CreateAnd( 1712 Shift->getOperand(0), ConstantInt::get(And->getType(), NewAndCst)); 1713 return new ICmpInst(Cmp.getPredicate(), 1714 NewAnd, ConstantInt::get(And->getType(), NewCmpCst)); 1715 } 1716 } 1717 1718 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1719 // preferable because it allows the C2 << Y expression to be hoisted out of a 1720 // loop if Y is invariant and X is not. 1721 if (Shift->hasOneUse() && C1.isZero() && Cmp.isEquality() && 1722 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1723 // Compute C2 << Y. 1724 Value *NewShift = 1725 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1726 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1727 1728 // Compute X & (C2 << Y). 1729 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1730 return replaceOperand(Cmp, 0, NewAnd); 1731 } 1732 1733 return nullptr; 1734 } 1735 1736 /// Fold icmp (and X, C2), C1. 1737 Instruction *InstCombinerImpl::foldICmpAndConstConst(ICmpInst &Cmp, 1738 BinaryOperator *And, 1739 const APInt &C1) { 1740 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1741 1742 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1743 // TODO: We canonicalize to the longer form for scalars because we have 1744 // better analysis/folds for icmp, and codegen may be better with icmp. 1745 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isZero() && 1746 match(And->getOperand(1), m_One())) 1747 return new TruncInst(And->getOperand(0), Cmp.getType()); 1748 1749 const APInt *C2; 1750 Value *X; 1751 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1752 return nullptr; 1753 1754 // Don't perform the following transforms if the AND has multiple uses 1755 if (!And->hasOneUse()) 1756 return nullptr; 1757 1758 if (Cmp.isEquality() && C1.isZero()) { 1759 // Restrict this fold to single-use 'and' (PR10267). 1760 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1761 if (C2->isSignMask()) { 1762 Constant *Zero = Constant::getNullValue(X->getType()); 1763 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1764 return new ICmpInst(NewPred, X, Zero); 1765 } 1766 1767 // Restrict this fold only for single-use 'and' (PR10267). 1768 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1769 if ((~(*C2) + 1).isPowerOf2()) { 1770 Constant *NegBOC = 1771 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1772 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1773 return new ICmpInst(NewPred, X, NegBOC); 1774 } 1775 } 1776 1777 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1778 // the input width without changing the value produced, eliminate the cast: 1779 // 1780 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1781 // 1782 // We can do this transformation if the constants do not have their sign bits 1783 // set or if it is an equality comparison. Extending a relational comparison 1784 // when we're checking the sign bit would not work. 1785 Value *W; 1786 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1787 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1788 // TODO: Is this a good transform for vectors? Wider types may reduce 1789 // throughput. Should this transform be limited (even for scalars) by using 1790 // shouldChangeType()? 1791 if (!Cmp.getType()->isVectorTy()) { 1792 Type *WideType = W->getType(); 1793 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1794 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1795 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1796 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1797 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1798 } 1799 } 1800 1801 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1802 return I; 1803 1804 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1805 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1806 // 1807 // iff pred isn't signed 1808 if (!Cmp.isSigned() && C1.isZero() && And->getOperand(0)->hasOneUse() && 1809 match(And->getOperand(1), m_One())) { 1810 Constant *One = cast<Constant>(And->getOperand(1)); 1811 Value *Or = And->getOperand(0); 1812 Value *A, *B, *LShr; 1813 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1814 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1815 unsigned UsesRemoved = 0; 1816 if (And->hasOneUse()) 1817 ++UsesRemoved; 1818 if (Or->hasOneUse()) 1819 ++UsesRemoved; 1820 if (LShr->hasOneUse()) 1821 ++UsesRemoved; 1822 1823 // Compute A & ((1 << B) | 1) 1824 Value *NewOr = nullptr; 1825 if (auto *C = dyn_cast<Constant>(B)) { 1826 if (UsesRemoved >= 1) 1827 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1828 } else { 1829 if (UsesRemoved >= 3) 1830 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1831 /*HasNUW=*/true), 1832 One, Or->getName()); 1833 } 1834 if (NewOr) { 1835 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1836 return replaceOperand(Cmp, 0, NewAnd); 1837 } 1838 } 1839 } 1840 1841 return nullptr; 1842 } 1843 1844 /// Fold icmp (and X, Y), C. 1845 Instruction *InstCombinerImpl::foldICmpAndConstant(ICmpInst &Cmp, 1846 BinaryOperator *And, 1847 const APInt &C) { 1848 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1849 return I; 1850 1851 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 1852 bool TrueIfNeg; 1853 if (isSignBitCheck(Pred, C, TrueIfNeg)) { 1854 // ((X - 1) & ~X) < 0 --> X == 0 1855 // ((X - 1) & ~X) >= 0 --> X != 0 1856 Value *X; 1857 if (match(And->getOperand(0), m_Add(m_Value(X), m_AllOnes())) && 1858 match(And->getOperand(1), m_Not(m_Specific(X)))) { 1859 auto NewPred = TrueIfNeg ? CmpInst::ICMP_EQ : CmpInst::ICMP_NE; 1860 return new ICmpInst(NewPred, X, ConstantInt::getNullValue(X->getType())); 1861 } 1862 } 1863 1864 // TODO: These all require that Y is constant too, so refactor with the above. 1865 1866 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1867 Value *X = And->getOperand(0); 1868 Value *Y = And->getOperand(1); 1869 if (auto *C2 = dyn_cast<ConstantInt>(Y)) 1870 if (auto *LI = dyn_cast<LoadInst>(X)) 1871 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1872 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1873 if (Instruction *Res = 1874 foldCmpLoadFromIndexedGlobal(LI, GEP, GV, Cmp, C2)) 1875 return Res; 1876 1877 if (!Cmp.isEquality()) 1878 return nullptr; 1879 1880 // X & -C == -C -> X > u ~C 1881 // X & -C != -C -> X <= u ~C 1882 // iff C is a power of 2 1883 if (Cmp.getOperand(1) == Y && C.isNegatedPowerOf2()) { 1884 auto NewPred = 1885 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT : CmpInst::ICMP_ULE; 1886 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1887 } 1888 1889 return nullptr; 1890 } 1891 1892 /// Fold icmp (or X, Y), C. 1893 Instruction *InstCombinerImpl::foldICmpOrConstant(ICmpInst &Cmp, 1894 BinaryOperator *Or, 1895 const APInt &C) { 1896 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1897 if (C.isOne()) { 1898 // icmp slt signum(V) 1 --> icmp slt V, 1 1899 Value *V = nullptr; 1900 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1901 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1902 ConstantInt::get(V->getType(), 1)); 1903 } 1904 1905 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1906 const APInt *MaskC; 1907 if (match(OrOp1, m_APInt(MaskC)) && Cmp.isEquality()) { 1908 if (*MaskC == C && (C + 1).isPowerOf2()) { 1909 // X | C == C --> X <=u C 1910 // X | C != C --> X >u C 1911 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1912 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1913 return new ICmpInst(Pred, OrOp0, OrOp1); 1914 } 1915 1916 // More general: canonicalize 'equality with set bits mask' to 1917 // 'equality with clear bits mask'. 1918 // (X | MaskC) == C --> (X & ~MaskC) == C ^ MaskC 1919 // (X | MaskC) != C --> (X & ~MaskC) != C ^ MaskC 1920 if (Or->hasOneUse()) { 1921 Value *And = Builder.CreateAnd(OrOp0, ~(*MaskC)); 1922 Constant *NewC = ConstantInt::get(Or->getType(), C ^ (*MaskC)); 1923 return new ICmpInst(Pred, And, NewC); 1924 } 1925 } 1926 1927 // (X | (X-1)) s< 0 --> X s< 1 1928 // (X | (X-1)) s> -1 --> X s> 0 1929 Value *X; 1930 bool TrueIfSigned; 1931 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1932 match(Or, m_c_Or(m_Add(m_Value(X), m_AllOnes()), m_Deferred(X)))) { 1933 auto NewPred = TrueIfSigned ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGT; 1934 Constant *NewC = ConstantInt::get(X->getType(), TrueIfSigned ? 1 : 0); 1935 return new ICmpInst(NewPred, X, NewC); 1936 } 1937 1938 if (!Cmp.isEquality() || !C.isZero() || !Or->hasOneUse()) 1939 return nullptr; 1940 1941 Value *P, *Q; 1942 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1943 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1944 // -> and (icmp eq P, null), (icmp eq Q, null). 1945 Value *CmpP = 1946 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1947 Value *CmpQ = 1948 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1949 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1950 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1951 } 1952 1953 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1954 // a shorter form that has more potential to be folded even further. 1955 Value *X1, *X2, *X3, *X4; 1956 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1957 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1958 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1959 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1960 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1961 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1962 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1963 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1964 } 1965 1966 return nullptr; 1967 } 1968 1969 /// Fold icmp (mul X, Y), C. 1970 Instruction *InstCombinerImpl::foldICmpMulConstant(ICmpInst &Cmp, 1971 BinaryOperator *Mul, 1972 const APInt &C) { 1973 const APInt *MulC; 1974 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1975 return nullptr; 1976 1977 // If this is a test of the sign bit and the multiply is sign-preserving with 1978 // a constant operand, use the multiply LHS operand instead. 1979 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1980 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1981 if (MulC->isNegative()) 1982 Pred = ICmpInst::getSwappedPredicate(Pred); 1983 return new ICmpInst(Pred, Mul->getOperand(0), 1984 Constant::getNullValue(Mul->getType())); 1985 } 1986 1987 // If the multiply does not wrap, try to divide the compare constant by the 1988 // multiplication factor. 1989 if (Cmp.isEquality() && !MulC->isZero()) { 1990 // (mul nsw X, MulC) == C --> X == C /s MulC 1991 if (Mul->hasNoSignedWrap() && C.srem(*MulC).isZero()) { 1992 Constant *NewC = ConstantInt::get(Mul->getType(), C.sdiv(*MulC)); 1993 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 1994 } 1995 // (mul nuw X, MulC) == C --> X == C /u MulC 1996 if (Mul->hasNoUnsignedWrap() && C.urem(*MulC).isZero()) { 1997 Constant *NewC = ConstantInt::get(Mul->getType(), C.udiv(*MulC)); 1998 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 1999 } 2000 } 2001 2002 return nullptr; 2003 } 2004 2005 /// Fold icmp (shl 1, Y), C. 2006 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 2007 const APInt &C) { 2008 Value *Y; 2009 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 2010 return nullptr; 2011 2012 Type *ShiftType = Shl->getType(); 2013 unsigned TypeBits = C.getBitWidth(); 2014 bool CIsPowerOf2 = C.isPowerOf2(); 2015 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2016 if (Cmp.isUnsigned()) { 2017 // (1 << Y) pred C -> Y pred Log2(C) 2018 if (!CIsPowerOf2) { 2019 // (1 << Y) < 30 -> Y <= 4 2020 // (1 << Y) <= 30 -> Y <= 4 2021 // (1 << Y) >= 30 -> Y > 4 2022 // (1 << Y) > 30 -> Y > 4 2023 if (Pred == ICmpInst::ICMP_ULT) 2024 Pred = ICmpInst::ICMP_ULE; 2025 else if (Pred == ICmpInst::ICMP_UGE) 2026 Pred = ICmpInst::ICMP_UGT; 2027 } 2028 2029 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 2030 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 2031 unsigned CLog2 = C.logBase2(); 2032 if (CLog2 == TypeBits - 1) { 2033 if (Pred == ICmpInst::ICMP_UGE) 2034 Pred = ICmpInst::ICMP_EQ; 2035 else if (Pred == ICmpInst::ICMP_ULT) 2036 Pred = ICmpInst::ICMP_NE; 2037 } 2038 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 2039 } else if (Cmp.isSigned()) { 2040 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 2041 if (C.isAllOnes()) { 2042 // (1 << Y) <= -1 -> Y == 31 2043 if (Pred == ICmpInst::ICMP_SLE) 2044 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2045 2046 // (1 << Y) > -1 -> Y != 31 2047 if (Pred == ICmpInst::ICMP_SGT) 2048 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2049 } else if (!C) { 2050 // (1 << Y) < 0 -> Y == 31 2051 // (1 << Y) <= 0 -> Y == 31 2052 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 2053 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2054 2055 // (1 << Y) >= 0 -> Y != 31 2056 // (1 << Y) > 0 -> Y != 31 2057 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 2058 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2059 } 2060 } else if (Cmp.isEquality() && CIsPowerOf2) { 2061 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 2062 } 2063 2064 return nullptr; 2065 } 2066 2067 /// Fold icmp (shl X, Y), C. 2068 Instruction *InstCombinerImpl::foldICmpShlConstant(ICmpInst &Cmp, 2069 BinaryOperator *Shl, 2070 const APInt &C) { 2071 const APInt *ShiftVal; 2072 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 2073 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 2074 2075 const APInt *ShiftAmt; 2076 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 2077 return foldICmpShlOne(Cmp, Shl, C); 2078 2079 // Check that the shift amount is in range. If not, don't perform undefined 2080 // shifts. When the shift is visited, it will be simplified. 2081 unsigned TypeBits = C.getBitWidth(); 2082 if (ShiftAmt->uge(TypeBits)) 2083 return nullptr; 2084 2085 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2086 Value *X = Shl->getOperand(0); 2087 Type *ShType = Shl->getType(); 2088 2089 // NSW guarantees that we are only shifting out sign bits from the high bits, 2090 // so we can ASHR the compare constant without needing a mask and eliminate 2091 // the shift. 2092 if (Shl->hasNoSignedWrap()) { 2093 if (Pred == ICmpInst::ICMP_SGT) { 2094 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2095 APInt ShiftedC = C.ashr(*ShiftAmt); 2096 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2097 } 2098 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2099 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2100 APInt ShiftedC = C.ashr(*ShiftAmt); 2101 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2102 } 2103 if (Pred == ICmpInst::ICMP_SLT) { 2104 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2105 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2106 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2107 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2108 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2109 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2110 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2111 } 2112 // If this is a signed comparison to 0 and the shift is sign preserving, 2113 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2114 // do that if we're sure to not continue on in this function. 2115 if (isSignTest(Pred, C)) 2116 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2117 } 2118 2119 // NUW guarantees that we are only shifting out zero bits from the high bits, 2120 // so we can LSHR the compare constant without needing a mask and eliminate 2121 // the shift. 2122 if (Shl->hasNoUnsignedWrap()) { 2123 if (Pred == ICmpInst::ICMP_UGT) { 2124 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2125 APInt ShiftedC = C.lshr(*ShiftAmt); 2126 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2127 } 2128 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2129 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2130 APInt ShiftedC = C.lshr(*ShiftAmt); 2131 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2132 } 2133 if (Pred == ICmpInst::ICMP_ULT) { 2134 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2135 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2136 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2137 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2138 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2139 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2140 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2141 } 2142 } 2143 2144 if (Cmp.isEquality() && Shl->hasOneUse()) { 2145 // Strength-reduce the shift into an 'and'. 2146 Constant *Mask = ConstantInt::get( 2147 ShType, 2148 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2149 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2150 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2151 return new ICmpInst(Pred, And, LShrC); 2152 } 2153 2154 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2155 bool TrueIfSigned = false; 2156 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2157 // (X << 31) <s 0 --> (X & 1) != 0 2158 Constant *Mask = ConstantInt::get( 2159 ShType, 2160 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2161 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2162 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2163 And, Constant::getNullValue(ShType)); 2164 } 2165 2166 // Simplify 'shl' inequality test into 'and' equality test. 2167 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2168 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2169 if ((C + 1).isPowerOf2() && 2170 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2171 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2172 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2173 : ICmpInst::ICMP_NE, 2174 And, Constant::getNullValue(ShType)); 2175 } 2176 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2177 if (C.isPowerOf2() && 2178 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2179 Value *And = 2180 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2181 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2182 : ICmpInst::ICMP_NE, 2183 And, Constant::getNullValue(ShType)); 2184 } 2185 } 2186 2187 // Transform (icmp pred iM (shl iM %v, N), C) 2188 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2189 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2190 // This enables us to get rid of the shift in favor of a trunc that may be 2191 // free on the target. It has the additional benefit of comparing to a 2192 // smaller constant that may be more target-friendly. 2193 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2194 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2195 DL.isLegalInteger(TypeBits - Amt)) { 2196 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2197 if (auto *ShVTy = dyn_cast<VectorType>(ShType)) 2198 TruncTy = VectorType::get(TruncTy, ShVTy->getElementCount()); 2199 Constant *NewC = 2200 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2201 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2202 } 2203 2204 return nullptr; 2205 } 2206 2207 /// Fold icmp ({al}shr X, Y), C. 2208 Instruction *InstCombinerImpl::foldICmpShrConstant(ICmpInst &Cmp, 2209 BinaryOperator *Shr, 2210 const APInt &C) { 2211 // An exact shr only shifts out zero bits, so: 2212 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2213 Value *X = Shr->getOperand(0); 2214 CmpInst::Predicate Pred = Cmp.getPredicate(); 2215 if (Cmp.isEquality() && Shr->isExact() && C.isZero()) 2216 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2217 2218 const APInt *ShiftVal; 2219 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2220 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2221 2222 const APInt *ShiftAmt; 2223 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2224 return nullptr; 2225 2226 // Check that the shift amount is in range. If not, don't perform undefined 2227 // shifts. When the shift is visited it will be simplified. 2228 unsigned TypeBits = C.getBitWidth(); 2229 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2230 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2231 return nullptr; 2232 2233 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2234 bool IsExact = Shr->isExact(); 2235 Type *ShrTy = Shr->getType(); 2236 // TODO: If we could guarantee that InstSimplify would handle all of the 2237 // constant-value-based preconditions in the folds below, then we could assert 2238 // those conditions rather than checking them. This is difficult because of 2239 // undef/poison (PR34838). 2240 if (IsAShr) { 2241 if (IsExact || Pred == CmpInst::ICMP_SLT || Pred == CmpInst::ICMP_ULT) { 2242 // When ShAmtC can be shifted losslessly: 2243 // icmp PRED (ashr exact X, ShAmtC), C --> icmp PRED X, (C << ShAmtC) 2244 // icmp slt/ult (ashr X, ShAmtC), C --> icmp slt/ult X, (C << ShAmtC) 2245 APInt ShiftedC = C.shl(ShAmtVal); 2246 if (ShiftedC.ashr(ShAmtVal) == C) 2247 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2248 } 2249 if (Pred == CmpInst::ICMP_SGT) { 2250 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2251 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2252 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2253 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2254 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2255 } 2256 if (Pred == CmpInst::ICMP_UGT) { 2257 // icmp ugt (ashr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2258 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2259 if ((ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2260 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2261 } 2262 2263 // If the compare constant has significant bits above the lowest sign-bit, 2264 // then convert an unsigned cmp to a test of the sign-bit: 2265 // (ashr X, ShiftC) u> C --> X s< 0 2266 // (ashr X, ShiftC) u< C --> X s> -1 2267 if (C.getBitWidth() > 2 && C.getNumSignBits() <= ShAmtVal) { 2268 if (Pred == CmpInst::ICMP_UGT) { 2269 return new ICmpInst(CmpInst::ICMP_SLT, X, 2270 ConstantInt::getNullValue(ShrTy)); 2271 } 2272 if (Pred == CmpInst::ICMP_ULT) { 2273 return new ICmpInst(CmpInst::ICMP_SGT, X, 2274 ConstantInt::getAllOnesValue(ShrTy)); 2275 } 2276 } 2277 } else { 2278 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2279 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2280 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2281 APInt ShiftedC = C.shl(ShAmtVal); 2282 if (ShiftedC.lshr(ShAmtVal) == C) 2283 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2284 } 2285 if (Pred == CmpInst::ICMP_UGT) { 2286 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2287 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2288 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2289 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2290 } 2291 } 2292 2293 if (!Cmp.isEquality()) 2294 return nullptr; 2295 2296 // Handle equality comparisons of shift-by-constant. 2297 2298 // If the comparison constant changes with the shift, the comparison cannot 2299 // succeed (bits of the comparison constant cannot match the shifted value). 2300 // This should be known by InstSimplify and already be folded to true/false. 2301 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2302 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2303 "Expected icmp+shr simplify did not occur."); 2304 2305 // If the bits shifted out are known zero, compare the unshifted value: 2306 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2307 if (Shr->isExact()) 2308 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2309 2310 if (C.isZero()) { 2311 // == 0 is u< 1. 2312 if (Pred == CmpInst::ICMP_EQ) 2313 return new ICmpInst(CmpInst::ICMP_ULT, X, 2314 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal))); 2315 else 2316 return new ICmpInst(CmpInst::ICMP_UGT, X, 2317 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal) - 1)); 2318 } 2319 2320 if (Shr->hasOneUse()) { 2321 // Canonicalize the shift into an 'and': 2322 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2323 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2324 Constant *Mask = ConstantInt::get(ShrTy, Val); 2325 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2326 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2327 } 2328 2329 return nullptr; 2330 } 2331 2332 Instruction *InstCombinerImpl::foldICmpSRemConstant(ICmpInst &Cmp, 2333 BinaryOperator *SRem, 2334 const APInt &C) { 2335 // Match an 'is positive' or 'is negative' comparison of remainder by a 2336 // constant power-of-2 value: 2337 // (X % pow2C) sgt/slt 0 2338 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 2339 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT && 2340 Pred != ICmpInst::ICMP_EQ && Pred != ICmpInst::ICMP_NE) 2341 return nullptr; 2342 2343 // TODO: The one-use check is standard because we do not typically want to 2344 // create longer instruction sequences, but this might be a special-case 2345 // because srem is not good for analysis or codegen. 2346 if (!SRem->hasOneUse()) 2347 return nullptr; 2348 2349 const APInt *DivisorC; 2350 if (!match(SRem->getOperand(1), m_Power2(DivisorC))) 2351 return nullptr; 2352 2353 // For cmp_sgt/cmp_slt only zero valued C is handled. 2354 // For cmp_eq/cmp_ne only positive valued C is handled. 2355 if (((Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT) && 2356 !C.isZero()) || 2357 ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2358 !C.isStrictlyPositive())) 2359 return nullptr; 2360 2361 // Mask off the sign bit and the modulo bits (low-bits). 2362 Type *Ty = SRem->getType(); 2363 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits()); 2364 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1)); 2365 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC); 2366 2367 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) 2368 return new ICmpInst(Pred, And, ConstantInt::get(Ty, C)); 2369 2370 // For 'is positive?' check that the sign-bit is clear and at least 1 masked 2371 // bit is set. Example: 2372 // (i8 X % 32) s> 0 --> (X & 159) s> 0 2373 if (Pred == ICmpInst::ICMP_SGT) 2374 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty)); 2375 2376 // For 'is negative?' check that the sign-bit is set and at least 1 masked 2377 // bit is set. Example: 2378 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768 2379 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask)); 2380 } 2381 2382 /// Fold icmp (udiv X, Y), C. 2383 Instruction *InstCombinerImpl::foldICmpUDivConstant(ICmpInst &Cmp, 2384 BinaryOperator *UDiv, 2385 const APInt &C) { 2386 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2387 Value *X = UDiv->getOperand(0); 2388 Value *Y = UDiv->getOperand(1); 2389 Type *Ty = UDiv->getType(); 2390 2391 // If the compare constant is bigger than UMAX/2 (negative), there's only one 2392 // pair of values that satisfies an equality check, so eliminate the division: 2393 // (X u/ Y) == C --> (X == C) && (Y == 1) 2394 // (X u/ Y) != C --> (X != C) || (Y != 1) 2395 if (Cmp.isEquality() && UDiv->hasOneUse() && C.isSignBitSet()) { 2396 Value *XBig = Builder.CreateICmp(Pred, X, ConstantInt::get(Ty, C)); 2397 Value *YOne = Builder.CreateICmp(Pred, Y, ConstantInt::get(Ty, 1)); 2398 auto Logic = Pred == ICmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 2399 return BinaryOperator::Create(Logic, XBig, YOne); 2400 } 2401 2402 const APInt *C2; 2403 if (!match(X, m_APInt(C2))) 2404 return nullptr; 2405 2406 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2407 2408 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2409 if (Pred == ICmpInst::ICMP_UGT) { 2410 assert(!C.isMaxValue() && 2411 "icmp ugt X, UINT_MAX should have been simplified already."); 2412 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2413 ConstantInt::get(Ty, C2->udiv(C + 1))); 2414 } 2415 2416 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2417 if (Pred == ICmpInst::ICMP_ULT) { 2418 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2419 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2420 ConstantInt::get(Ty, C2->udiv(C))); 2421 } 2422 2423 return nullptr; 2424 } 2425 2426 /// Fold icmp ({su}div X, Y), C. 2427 Instruction *InstCombinerImpl::foldICmpDivConstant(ICmpInst &Cmp, 2428 BinaryOperator *Div, 2429 const APInt &C) { 2430 // Fold: icmp pred ([us]div X, C2), C -> range test 2431 // Fold this div into the comparison, producing a range check. 2432 // Determine, based on the divide type, what the range is being 2433 // checked. If there is an overflow on the low or high side, remember 2434 // it, otherwise compute the range [low, hi) bounding the new value. 2435 // See: InsertRangeTest above for the kinds of replacements possible. 2436 const APInt *C2; 2437 if (!match(Div->getOperand(1), m_APInt(C2))) 2438 return nullptr; 2439 2440 // FIXME: If the operand types don't match the type of the divide 2441 // then don't attempt this transform. The code below doesn't have the 2442 // logic to deal with a signed divide and an unsigned compare (and 2443 // vice versa). This is because (x /s C2) <s C produces different 2444 // results than (x /s C2) <u C or (x /u C2) <s C or even 2445 // (x /u C2) <u C. Simply casting the operands and result won't 2446 // work. :( The if statement below tests that condition and bails 2447 // if it finds it. 2448 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2449 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2450 return nullptr; 2451 2452 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2453 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2454 // division-by-constant cases should be present, we can not assert that they 2455 // have happened before we reach this icmp instruction. 2456 if (C2->isZero() || C2->isOne() || (DivIsSigned && C2->isAllOnes())) 2457 return nullptr; 2458 2459 // Compute Prod = C * C2. We are essentially solving an equation of 2460 // form X / C2 = C. We solve for X by multiplying C2 and C. 2461 // By solving for X, we can turn this into a range check instead of computing 2462 // a divide. 2463 APInt Prod = C * *C2; 2464 2465 // Determine if the product overflows by seeing if the product is not equal to 2466 // the divide. Make sure we do the same kind of divide as in the LHS 2467 // instruction that we're folding. 2468 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2469 2470 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2471 2472 // If the division is known to be exact, then there is no remainder from the 2473 // divide, so the covered range size is unit, otherwise it is the divisor. 2474 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2475 2476 // Figure out the interval that is being checked. For example, a comparison 2477 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2478 // Compute this interval based on the constants involved and the signedness of 2479 // the compare/divide. This computes a half-open interval, keeping track of 2480 // whether either value in the interval overflows. After analysis each 2481 // overflow variable is set to 0 if it's corresponding bound variable is valid 2482 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2483 int LoOverflow = 0, HiOverflow = 0; 2484 APInt LoBound, HiBound; 2485 2486 if (!DivIsSigned) { // udiv 2487 // e.g. X/5 op 3 --> [15, 20) 2488 LoBound = Prod; 2489 HiOverflow = LoOverflow = ProdOV; 2490 if (!HiOverflow) { 2491 // If this is not an exact divide, then many values in the range collapse 2492 // to the same result value. 2493 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2494 } 2495 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2496 if (C.isZero()) { // (X / pos) op 0 2497 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2498 LoBound = -(RangeSize - 1); 2499 HiBound = RangeSize; 2500 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2501 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2502 HiOverflow = LoOverflow = ProdOV; 2503 if (!HiOverflow) 2504 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2505 } else { // (X / pos) op neg 2506 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2507 HiBound = Prod + 1; 2508 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2509 if (!LoOverflow) { 2510 APInt DivNeg = -RangeSize; 2511 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2512 } 2513 } 2514 } else if (C2->isNegative()) { // Divisor is < 0. 2515 if (Div->isExact()) 2516 RangeSize.negate(); 2517 if (C.isZero()) { // (X / neg) op 0 2518 // e.g. X/-5 op 0 --> [-4, 5) 2519 LoBound = RangeSize + 1; 2520 HiBound = -RangeSize; 2521 if (HiBound == *C2) { // -INTMIN = INTMIN 2522 HiOverflow = 1; // [INTMIN+1, overflow) 2523 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2524 } 2525 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2526 // e.g. X/-5 op 3 --> [-19, -14) 2527 HiBound = Prod + 1; 2528 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2529 if (!LoOverflow) 2530 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2531 } else { // (X / neg) op neg 2532 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2533 LoOverflow = HiOverflow = ProdOV; 2534 if (!HiOverflow) 2535 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2536 } 2537 2538 // Dividing by a negative swaps the condition. LT <-> GT 2539 Pred = ICmpInst::getSwappedPredicate(Pred); 2540 } 2541 2542 Value *X = Div->getOperand(0); 2543 switch (Pred) { 2544 default: llvm_unreachable("Unhandled icmp opcode!"); 2545 case ICmpInst::ICMP_EQ: 2546 if (LoOverflow && HiOverflow) 2547 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2548 if (HiOverflow) 2549 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2550 ICmpInst::ICMP_UGE, X, 2551 ConstantInt::get(Div->getType(), LoBound)); 2552 if (LoOverflow) 2553 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2554 ICmpInst::ICMP_ULT, X, 2555 ConstantInt::get(Div->getType(), HiBound)); 2556 return replaceInstUsesWith( 2557 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2558 case ICmpInst::ICMP_NE: 2559 if (LoOverflow && HiOverflow) 2560 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2561 if (HiOverflow) 2562 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2563 ICmpInst::ICMP_ULT, X, 2564 ConstantInt::get(Div->getType(), LoBound)); 2565 if (LoOverflow) 2566 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2567 ICmpInst::ICMP_UGE, X, 2568 ConstantInt::get(Div->getType(), HiBound)); 2569 return replaceInstUsesWith(Cmp, 2570 insertRangeTest(X, LoBound, HiBound, 2571 DivIsSigned, false)); 2572 case ICmpInst::ICMP_ULT: 2573 case ICmpInst::ICMP_SLT: 2574 if (LoOverflow == +1) // Low bound is greater than input range. 2575 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2576 if (LoOverflow == -1) // Low bound is less than input range. 2577 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2578 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2579 case ICmpInst::ICMP_UGT: 2580 case ICmpInst::ICMP_SGT: 2581 if (HiOverflow == +1) // High bound greater than input range. 2582 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2583 if (HiOverflow == -1) // High bound less than input range. 2584 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2585 if (Pred == ICmpInst::ICMP_UGT) 2586 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2587 ConstantInt::get(Div->getType(), HiBound)); 2588 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2589 ConstantInt::get(Div->getType(), HiBound)); 2590 } 2591 2592 return nullptr; 2593 } 2594 2595 /// Fold icmp (sub X, Y), C. 2596 Instruction *InstCombinerImpl::foldICmpSubConstant(ICmpInst &Cmp, 2597 BinaryOperator *Sub, 2598 const APInt &C) { 2599 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2600 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2601 Type *Ty = Sub->getType(); 2602 2603 // (SubC - Y) == C) --> Y == (SubC - C) 2604 // (SubC - Y) != C) --> Y != (SubC - C) 2605 Constant *SubC; 2606 if (Cmp.isEquality() && match(X, m_ImmConstant(SubC))) { 2607 return new ICmpInst(Pred, Y, 2608 ConstantExpr::getSub(SubC, ConstantInt::get(Ty, C))); 2609 } 2610 2611 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2612 const APInt *C2; 2613 APInt SubResult; 2614 ICmpInst::Predicate SwappedPred = Cmp.getSwappedPredicate(); 2615 bool HasNSW = Sub->hasNoSignedWrap(); 2616 bool HasNUW = Sub->hasNoUnsignedWrap(); 2617 if (match(X, m_APInt(C2)) && 2618 ((Cmp.isUnsigned() && HasNUW) || (Cmp.isSigned() && HasNSW)) && 2619 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2620 return new ICmpInst(SwappedPred, Y, ConstantInt::get(Ty, SubResult)); 2621 2622 // X - Y == 0 --> X == Y. 2623 // X - Y != 0 --> X != Y. 2624 // TODO: We allow this with multiple uses as long as the other uses are not 2625 // in phis. The phi use check is guarding against a codegen regression 2626 // for a loop test. If the backend could undo this (and possibly 2627 // subsequent transforms), we would not need this hack. 2628 if (Cmp.isEquality() && C.isZero() && 2629 none_of((Sub->users()), [](const User *U) { return isa<PHINode>(U); })) 2630 return new ICmpInst(Pred, X, Y); 2631 2632 // The following transforms are only worth it if the only user of the subtract 2633 // is the icmp. 2634 // TODO: This is an artificial restriction for all of the transforms below 2635 // that only need a single replacement icmp. Can these use the phi test 2636 // like the transform above here? 2637 if (!Sub->hasOneUse()) 2638 return nullptr; 2639 2640 if (Sub->hasNoSignedWrap()) { 2641 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2642 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnes()) 2643 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2644 2645 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2646 if (Pred == ICmpInst::ICMP_SGT && C.isZero()) 2647 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2648 2649 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2650 if (Pred == ICmpInst::ICMP_SLT && C.isZero()) 2651 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2652 2653 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2654 if (Pred == ICmpInst::ICMP_SLT && C.isOne()) 2655 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2656 } 2657 2658 if (!match(X, m_APInt(C2))) 2659 return nullptr; 2660 2661 // C2 - Y <u C -> (Y | (C - 1)) == C2 2662 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2663 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2664 (*C2 & (C - 1)) == (C - 1)) 2665 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2666 2667 // C2 - Y >u C -> (Y | C) != C2 2668 // iff C2 & C == C and C + 1 is a power of 2 2669 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2670 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2671 2672 // We have handled special cases that reduce. 2673 // Canonicalize any remaining sub to add as: 2674 // (C2 - Y) > C --> (Y + ~C2) < ~C 2675 Value *Add = Builder.CreateAdd(Y, ConstantInt::get(Ty, ~(*C2)), "notsub", 2676 HasNUW, HasNSW); 2677 return new ICmpInst(SwappedPred, Add, ConstantInt::get(Ty, ~C)); 2678 } 2679 2680 /// Fold icmp (add X, Y), C. 2681 Instruction *InstCombinerImpl::foldICmpAddConstant(ICmpInst &Cmp, 2682 BinaryOperator *Add, 2683 const APInt &C) { 2684 Value *Y = Add->getOperand(1); 2685 const APInt *C2; 2686 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2687 return nullptr; 2688 2689 // Fold icmp pred (add X, C2), C. 2690 Value *X = Add->getOperand(0); 2691 Type *Ty = Add->getType(); 2692 const CmpInst::Predicate Pred = Cmp.getPredicate(); 2693 2694 // If the add does not wrap, we can always adjust the compare by subtracting 2695 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2696 // are canonicalized to SGT/SLT/UGT/ULT. 2697 if ((Add->hasNoSignedWrap() && 2698 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2699 (Add->hasNoUnsignedWrap() && 2700 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2701 bool Overflow; 2702 APInt NewC = 2703 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2704 // If there is overflow, the result must be true or false. 2705 // TODO: Can we assert there is no overflow because InstSimplify always 2706 // handles those cases? 2707 if (!Overflow) 2708 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2709 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2710 } 2711 2712 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2713 const APInt &Upper = CR.getUpper(); 2714 const APInt &Lower = CR.getLower(); 2715 if (Cmp.isSigned()) { 2716 if (Lower.isSignMask()) 2717 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2718 if (Upper.isSignMask()) 2719 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2720 } else { 2721 if (Lower.isMinValue()) 2722 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2723 if (Upper.isMinValue()) 2724 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2725 } 2726 2727 // This set of folds is intentionally placed after folds that use no-wrapping 2728 // flags because those folds are likely better for later analysis/codegen. 2729 const APInt SMax = APInt::getSignedMaxValue(Ty->getScalarSizeInBits()); 2730 const APInt SMin = APInt::getSignedMinValue(Ty->getScalarSizeInBits()); 2731 2732 // Fold compare with offset to opposite sign compare if it eliminates offset: 2733 // (X + C2) >u C --> X <s -C2 (if C == C2 + SMAX) 2734 if (Pred == CmpInst::ICMP_UGT && C == *C2 + SMax) 2735 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, -(*C2))); 2736 2737 // (X + C2) <u C --> X >s ~C2 (if C == C2 + SMIN) 2738 if (Pred == CmpInst::ICMP_ULT && C == *C2 + SMin) 2739 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantInt::get(Ty, ~(*C2))); 2740 2741 // (X + C2) >s C --> X <u (SMAX - C) (if C == C2 - 1) 2742 if (Pred == CmpInst::ICMP_SGT && C == *C2 - 1) 2743 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, SMax - C)); 2744 2745 // (X + C2) <s C --> X >u (C ^ SMAX) (if C == C2) 2746 if (Pred == CmpInst::ICMP_SLT && C == *C2) 2747 return new ICmpInst(ICmpInst::ICMP_UGT, X, ConstantInt::get(Ty, C ^ SMax)); 2748 2749 if (!Add->hasOneUse()) 2750 return nullptr; 2751 2752 // X+C <u C2 -> (X & -C2) == C 2753 // iff C & (C2-1) == 0 2754 // C2 is a power of 2 2755 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2756 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2757 ConstantExpr::getNeg(cast<Constant>(Y))); 2758 2759 // X+C >u C2 -> (X & ~C2) != C 2760 // iff C & C2 == 0 2761 // C2+1 is a power of 2 2762 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2763 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2764 ConstantExpr::getNeg(cast<Constant>(Y))); 2765 2766 // The range test idiom can use either ult or ugt. Arbitrarily canonicalize 2767 // to the ult form. 2768 // X+C2 >u C -> X+(C2-C-1) <u ~C 2769 if (Pred == ICmpInst::ICMP_UGT) 2770 return new ICmpInst(ICmpInst::ICMP_ULT, 2771 Builder.CreateAdd(X, ConstantInt::get(Ty, *C2 - C - 1)), 2772 ConstantInt::get(Ty, ~C)); 2773 2774 return nullptr; 2775 } 2776 2777 bool InstCombinerImpl::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2778 Value *&RHS, ConstantInt *&Less, 2779 ConstantInt *&Equal, 2780 ConstantInt *&Greater) { 2781 // TODO: Generalize this to work with other comparison idioms or ensure 2782 // they get canonicalized into this form. 2783 2784 // select i1 (a == b), 2785 // i32 Equal, 2786 // i32 (select i1 (a < b), i32 Less, i32 Greater) 2787 // where Equal, Less and Greater are placeholders for any three constants. 2788 ICmpInst::Predicate PredA; 2789 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) || 2790 !ICmpInst::isEquality(PredA)) 2791 return false; 2792 Value *EqualVal = SI->getTrueValue(); 2793 Value *UnequalVal = SI->getFalseValue(); 2794 // We still can get non-canonical predicate here, so canonicalize. 2795 if (PredA == ICmpInst::ICMP_NE) 2796 std::swap(EqualVal, UnequalVal); 2797 if (!match(EqualVal, m_ConstantInt(Equal))) 2798 return false; 2799 ICmpInst::Predicate PredB; 2800 Value *LHS2, *RHS2; 2801 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)), 2802 m_ConstantInt(Less), m_ConstantInt(Greater)))) 2803 return false; 2804 // We can get predicate mismatch here, so canonicalize if possible: 2805 // First, ensure that 'LHS' match. 2806 if (LHS2 != LHS) { 2807 // x sgt y <--> y slt x 2808 std::swap(LHS2, RHS2); 2809 PredB = ICmpInst::getSwappedPredicate(PredB); 2810 } 2811 if (LHS2 != LHS) 2812 return false; 2813 // We also need to canonicalize 'RHS'. 2814 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) { 2815 // x sgt C-1 <--> x sge C <--> not(x slt C) 2816 auto FlippedStrictness = 2817 InstCombiner::getFlippedStrictnessPredicateAndConstant( 2818 PredB, cast<Constant>(RHS2)); 2819 if (!FlippedStrictness) 2820 return false; 2821 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && 2822 "basic correctness failure"); 2823 RHS2 = FlippedStrictness->second; 2824 // And kind-of perform the result swap. 2825 std::swap(Less, Greater); 2826 PredB = ICmpInst::ICMP_SLT; 2827 } 2828 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2; 2829 } 2830 2831 Instruction *InstCombinerImpl::foldICmpSelectConstant(ICmpInst &Cmp, 2832 SelectInst *Select, 2833 ConstantInt *C) { 2834 2835 assert(C && "Cmp RHS should be a constant int!"); 2836 // If we're testing a constant value against the result of a three way 2837 // comparison, the result can be expressed directly in terms of the 2838 // original values being compared. Note: We could possibly be more 2839 // aggressive here and remove the hasOneUse test. The original select is 2840 // really likely to simplify or sink when we remove a test of the result. 2841 Value *OrigLHS, *OrigRHS; 2842 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2843 if (Cmp.hasOneUse() && 2844 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2845 C3GreaterThan)) { 2846 assert(C1LessThan && C2Equal && C3GreaterThan); 2847 2848 bool TrueWhenLessThan = 2849 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2850 ->isAllOnesValue(); 2851 bool TrueWhenEqual = 2852 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2853 ->isAllOnesValue(); 2854 bool TrueWhenGreaterThan = 2855 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2856 ->isAllOnesValue(); 2857 2858 // This generates the new instruction that will replace the original Cmp 2859 // Instruction. Instead of enumerating the various combinations when 2860 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2861 // false, we rely on chaining of ORs and future passes of InstCombine to 2862 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2863 2864 // When none of the three constants satisfy the predicate for the RHS (C), 2865 // the entire original Cmp can be simplified to a false. 2866 Value *Cond = Builder.getFalse(); 2867 if (TrueWhenLessThan) 2868 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2869 OrigLHS, OrigRHS)); 2870 if (TrueWhenEqual) 2871 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2872 OrigLHS, OrigRHS)); 2873 if (TrueWhenGreaterThan) 2874 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2875 OrigLHS, OrigRHS)); 2876 2877 return replaceInstUsesWith(Cmp, Cond); 2878 } 2879 return nullptr; 2880 } 2881 2882 Instruction *InstCombinerImpl::foldICmpBitCast(ICmpInst &Cmp) { 2883 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2884 if (!Bitcast) 2885 return nullptr; 2886 2887 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2888 Value *Op1 = Cmp.getOperand(1); 2889 Value *BCSrcOp = Bitcast->getOperand(0); 2890 Type *SrcType = Bitcast->getSrcTy(); 2891 Type *DstType = Bitcast->getType(); 2892 2893 // Make sure the bitcast doesn't change between scalar and vector and 2894 // doesn't change the number of vector elements. 2895 if (SrcType->isVectorTy() == DstType->isVectorTy() && 2896 SrcType->getScalarSizeInBits() == DstType->getScalarSizeInBits()) { 2897 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2898 Value *X; 2899 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2900 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2901 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2902 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2903 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2904 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2905 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2906 match(Op1, m_Zero())) 2907 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2908 2909 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2910 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2911 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2912 2913 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2914 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2915 return new ICmpInst(Pred, X, 2916 ConstantInt::getAllOnesValue(X->getType())); 2917 } 2918 2919 // Zero-equality checks are preserved through unsigned floating-point casts: 2920 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2921 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2922 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2923 if (Cmp.isEquality() && match(Op1, m_Zero())) 2924 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2925 2926 // If this is a sign-bit test of a bitcast of a casted FP value, eliminate 2927 // the FP extend/truncate because that cast does not change the sign-bit. 2928 // This is true for all standard IEEE-754 types and the X86 80-bit type. 2929 // The sign-bit is always the most significant bit in those types. 2930 const APInt *C; 2931 bool TrueIfSigned; 2932 if (match(Op1, m_APInt(C)) && Bitcast->hasOneUse() && 2933 InstCombiner::isSignBitCheck(Pred, *C, TrueIfSigned)) { 2934 if (match(BCSrcOp, m_FPExt(m_Value(X))) || 2935 match(BCSrcOp, m_FPTrunc(m_Value(X)))) { 2936 // (bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0 2937 // (bitcast (fpext/fptrunc X)) to iX) > -1 --> (bitcast X to iY) > -1 2938 Type *XType = X->getType(); 2939 2940 // We can't currently handle Power style floating point operations here. 2941 if (!(XType->isPPC_FP128Ty() || SrcType->isPPC_FP128Ty())) { 2942 Type *NewType = Builder.getIntNTy(XType->getScalarSizeInBits()); 2943 if (auto *XVTy = dyn_cast<VectorType>(XType)) 2944 NewType = VectorType::get(NewType, XVTy->getElementCount()); 2945 Value *NewBitcast = Builder.CreateBitCast(X, NewType); 2946 if (TrueIfSigned) 2947 return new ICmpInst(ICmpInst::ICMP_SLT, NewBitcast, 2948 ConstantInt::getNullValue(NewType)); 2949 else 2950 return new ICmpInst(ICmpInst::ICMP_SGT, NewBitcast, 2951 ConstantInt::getAllOnesValue(NewType)); 2952 } 2953 } 2954 } 2955 } 2956 2957 // Test to see if the operands of the icmp are casted versions of other 2958 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2959 if (DstType->isPointerTy() && (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2960 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2961 // so eliminate it as well. 2962 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2963 Op1 = BC2->getOperand(0); 2964 2965 Op1 = Builder.CreateBitCast(Op1, SrcType); 2966 return new ICmpInst(Pred, BCSrcOp, Op1); 2967 } 2968 2969 const APInt *C; 2970 if (!match(Cmp.getOperand(1), m_APInt(C)) || !DstType->isIntegerTy() || 2971 !SrcType->isIntOrIntVectorTy()) 2972 return nullptr; 2973 2974 // If this is checking if all elements of a vector compare are set or not, 2975 // invert the casted vector equality compare and test if all compare 2976 // elements are clear or not. Compare against zero is generally easier for 2977 // analysis and codegen. 2978 // icmp eq/ne (bitcast (not X) to iN), -1 --> icmp eq/ne (bitcast X to iN), 0 2979 // Example: are all elements equal? --> are zero elements not equal? 2980 // TODO: Try harder to reduce compare of 2 freely invertible operands? 2981 if (Cmp.isEquality() && C->isAllOnes() && Bitcast->hasOneUse() && 2982 isFreeToInvert(BCSrcOp, BCSrcOp->hasOneUse())) { 2983 Value *Cast = Builder.CreateBitCast(Builder.CreateNot(BCSrcOp), DstType); 2984 return new ICmpInst(Pred, Cast, ConstantInt::getNullValue(DstType)); 2985 } 2986 2987 // If this is checking if all elements of an extended vector are clear or not, 2988 // compare in a narrow type to eliminate the extend: 2989 // icmp eq/ne (bitcast (ext X) to iN), 0 --> icmp eq/ne (bitcast X to iM), 0 2990 Value *X; 2991 if (Cmp.isEquality() && C->isZero() && Bitcast->hasOneUse() && 2992 match(BCSrcOp, m_ZExtOrSExt(m_Value(X)))) { 2993 if (auto *VecTy = dyn_cast<FixedVectorType>(X->getType())) { 2994 Type *NewType = Builder.getIntNTy(VecTy->getPrimitiveSizeInBits()); 2995 Value *NewCast = Builder.CreateBitCast(X, NewType); 2996 return new ICmpInst(Pred, NewCast, ConstantInt::getNullValue(NewType)); 2997 } 2998 } 2999 3000 // Folding: icmp <pred> iN X, C 3001 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 3002 // and C is a splat of a K-bit pattern 3003 // and SC is a constant vector = <C', C', C', ..., C'> 3004 // Into: 3005 // %E = extractelement <M x iK> %vec, i32 C' 3006 // icmp <pred> iK %E, trunc(C) 3007 Value *Vec; 3008 ArrayRef<int> Mask; 3009 if (match(BCSrcOp, m_Shuffle(m_Value(Vec), m_Undef(), m_Mask(Mask)))) { 3010 // Check whether every element of Mask is the same constant 3011 if (is_splat(Mask)) { 3012 auto *VecTy = cast<VectorType>(SrcType); 3013 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 3014 if (C->isSplat(EltTy->getBitWidth())) { 3015 // Fold the icmp based on the value of C 3016 // If C is M copies of an iK sized bit pattern, 3017 // then: 3018 // => %E = extractelement <N x iK> %vec, i32 Elem 3019 // icmp <pred> iK %SplatVal, <pattern> 3020 Value *Elem = Builder.getInt32(Mask[0]); 3021 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 3022 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 3023 return new ICmpInst(Pred, Extract, NewC); 3024 } 3025 } 3026 } 3027 return nullptr; 3028 } 3029 3030 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 3031 /// where X is some kind of instruction. 3032 Instruction *InstCombinerImpl::foldICmpInstWithConstant(ICmpInst &Cmp) { 3033 const APInt *C; 3034 3035 if (match(Cmp.getOperand(1), m_APInt(C))) { 3036 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) 3037 if (Instruction *I = foldICmpBinOpWithConstant(Cmp, BO, *C)) 3038 return I; 3039 3040 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) 3041 // For now, we only support constant integers while folding the 3042 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 3043 // similar to the cases handled by binary ops above. 3044 if (auto *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 3045 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 3046 return I; 3047 3048 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) 3049 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 3050 return I; 3051 3052 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 3053 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 3054 return I; 3055 } 3056 3057 if (match(Cmp.getOperand(1), m_APIntAllowUndef(C))) 3058 return foldICmpInstWithConstantAllowUndef(Cmp, *C); 3059 3060 return nullptr; 3061 } 3062 3063 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 3064 /// icmp eq/ne BO, C. 3065 Instruction *InstCombinerImpl::foldICmpBinOpEqualityWithConstant( 3066 ICmpInst &Cmp, BinaryOperator *BO, const APInt &C) { 3067 // TODO: Some of these folds could work with arbitrary constants, but this 3068 // function is limited to scalar and vector splat constants. 3069 if (!Cmp.isEquality()) 3070 return nullptr; 3071 3072 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3073 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 3074 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 3075 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 3076 3077 switch (BO->getOpcode()) { 3078 case Instruction::SRem: 3079 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 3080 if (C.isZero() && BO->hasOneUse()) { 3081 const APInt *BOC; 3082 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 3083 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 3084 return new ICmpInst(Pred, NewRem, 3085 Constant::getNullValue(BO->getType())); 3086 } 3087 } 3088 break; 3089 case Instruction::Add: { 3090 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 3091 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3092 if (BO->hasOneUse()) 3093 return new ICmpInst(Pred, BOp0, ConstantExpr::getSub(RHS, BOC)); 3094 } else if (C.isZero()) { 3095 // Replace ((add A, B) != 0) with (A != -B) if A or B is 3096 // efficiently invertible, or if the add has just this one use. 3097 if (Value *NegVal = dyn_castNegVal(BOp1)) 3098 return new ICmpInst(Pred, BOp0, NegVal); 3099 if (Value *NegVal = dyn_castNegVal(BOp0)) 3100 return new ICmpInst(Pred, NegVal, BOp1); 3101 if (BO->hasOneUse()) { 3102 Value *Neg = Builder.CreateNeg(BOp1); 3103 Neg->takeName(BO); 3104 return new ICmpInst(Pred, BOp0, Neg); 3105 } 3106 } 3107 break; 3108 } 3109 case Instruction::Xor: 3110 if (BO->hasOneUse()) { 3111 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3112 // For the xor case, we can xor two constants together, eliminating 3113 // the explicit xor. 3114 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 3115 } else if (C.isZero()) { 3116 // Replace ((xor A, B) != 0) with (A != B) 3117 return new ICmpInst(Pred, BOp0, BOp1); 3118 } 3119 } 3120 break; 3121 case Instruction::Or: { 3122 const APInt *BOC; 3123 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 3124 // Comparing if all bits outside of a constant mask are set? 3125 // Replace (X | C) == -1 with (X & ~C) == ~C. 3126 // This removes the -1 constant. 3127 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 3128 Value *And = Builder.CreateAnd(BOp0, NotBOC); 3129 return new ICmpInst(Pred, And, NotBOC); 3130 } 3131 break; 3132 } 3133 case Instruction::And: { 3134 const APInt *BOC; 3135 if (match(BOp1, m_APInt(BOC))) { 3136 // If we have ((X & C) == C), turn it into ((X & C) != 0). 3137 if (C == *BOC && C.isPowerOf2()) 3138 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 3139 BO, Constant::getNullValue(RHS->getType())); 3140 } 3141 break; 3142 } 3143 case Instruction::UDiv: 3144 if (C.isZero()) { 3145 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 3146 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3147 return new ICmpInst(NewPred, BOp1, BOp0); 3148 } 3149 break; 3150 default: 3151 break; 3152 } 3153 return nullptr; 3154 } 3155 3156 /// Fold an equality icmp with LLVM intrinsic and constant operand. 3157 Instruction *InstCombinerImpl::foldICmpEqIntrinsicWithConstant( 3158 ICmpInst &Cmp, IntrinsicInst *II, const APInt &C) { 3159 Type *Ty = II->getType(); 3160 unsigned BitWidth = C.getBitWidth(); 3161 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 3162 3163 switch (II->getIntrinsicID()) { 3164 case Intrinsic::abs: 3165 // abs(A) == 0 -> A == 0 3166 // abs(A) == INT_MIN -> A == INT_MIN 3167 if (C.isZero() || C.isMinSignedValue()) 3168 return new ICmpInst(Pred, II->getArgOperand(0), ConstantInt::get(Ty, C)); 3169 break; 3170 3171 case Intrinsic::bswap: 3172 // bswap(A) == C -> A == bswap(C) 3173 return new ICmpInst(Pred, II->getArgOperand(0), 3174 ConstantInt::get(Ty, C.byteSwap())); 3175 3176 case Intrinsic::ctlz: 3177 case Intrinsic::cttz: { 3178 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 3179 if (C == BitWidth) 3180 return new ICmpInst(Pred, II->getArgOperand(0), 3181 ConstantInt::getNullValue(Ty)); 3182 3183 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 3184 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 3185 // Limit to one use to ensure we don't increase instruction count. 3186 unsigned Num = C.getLimitedValue(BitWidth); 3187 if (Num != BitWidth && II->hasOneUse()) { 3188 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 3189 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 3190 : APInt::getHighBitsSet(BitWidth, Num + 1); 3191 APInt Mask2 = IsTrailing 3192 ? APInt::getOneBitSet(BitWidth, Num) 3193 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3194 return new ICmpInst(Pred, Builder.CreateAnd(II->getArgOperand(0), Mask1), 3195 ConstantInt::get(Ty, Mask2)); 3196 } 3197 break; 3198 } 3199 3200 case Intrinsic::ctpop: { 3201 // popcount(A) == 0 -> A == 0 and likewise for != 3202 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 3203 bool IsZero = C.isZero(); 3204 if (IsZero || C == BitWidth) 3205 return new ICmpInst(Pred, II->getArgOperand(0), 3206 IsZero ? Constant::getNullValue(Ty) 3207 : Constant::getAllOnesValue(Ty)); 3208 3209 break; 3210 } 3211 3212 case Intrinsic::fshl: 3213 case Intrinsic::fshr: 3214 if (II->getArgOperand(0) == II->getArgOperand(1)) { 3215 const APInt *RotAmtC; 3216 // ror(X, RotAmtC) == C --> X == rol(C, RotAmtC) 3217 // rol(X, RotAmtC) == C --> X == ror(C, RotAmtC) 3218 if (match(II->getArgOperand(2), m_APInt(RotAmtC))) 3219 return new ICmpInst(Pred, II->getArgOperand(0), 3220 II->getIntrinsicID() == Intrinsic::fshl 3221 ? ConstantInt::get(Ty, C.rotr(*RotAmtC)) 3222 : ConstantInt::get(Ty, C.rotl(*RotAmtC))); 3223 } 3224 break; 3225 3226 case Intrinsic::uadd_sat: { 3227 // uadd.sat(a, b) == 0 -> (a | b) == 0 3228 if (C.isZero()) { 3229 Value *Or = Builder.CreateOr(II->getArgOperand(0), II->getArgOperand(1)); 3230 return new ICmpInst(Pred, Or, Constant::getNullValue(Ty)); 3231 } 3232 break; 3233 } 3234 3235 case Intrinsic::usub_sat: { 3236 // usub.sat(a, b) == 0 -> a <= b 3237 if (C.isZero()) { 3238 ICmpInst::Predicate NewPred = 3239 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3240 return new ICmpInst(NewPred, II->getArgOperand(0), II->getArgOperand(1)); 3241 } 3242 break; 3243 } 3244 default: 3245 break; 3246 } 3247 3248 return nullptr; 3249 } 3250 3251 /// Fold an icmp with LLVM intrinsics 3252 static Instruction *foldICmpIntrinsicWithIntrinsic(ICmpInst &Cmp) { 3253 assert(Cmp.isEquality()); 3254 3255 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3256 Value *Op0 = Cmp.getOperand(0); 3257 Value *Op1 = Cmp.getOperand(1); 3258 const auto *IIOp0 = dyn_cast<IntrinsicInst>(Op0); 3259 const auto *IIOp1 = dyn_cast<IntrinsicInst>(Op1); 3260 if (!IIOp0 || !IIOp1 || IIOp0->getIntrinsicID() != IIOp1->getIntrinsicID()) 3261 return nullptr; 3262 3263 switch (IIOp0->getIntrinsicID()) { 3264 case Intrinsic::bswap: 3265 case Intrinsic::bitreverse: 3266 // If both operands are byte-swapped or bit-reversed, just compare the 3267 // original values. 3268 return new ICmpInst(Pred, IIOp0->getOperand(0), IIOp1->getOperand(0)); 3269 case Intrinsic::fshl: 3270 case Intrinsic::fshr: 3271 // If both operands are rotated by same amount, just compare the 3272 // original values. 3273 if (IIOp0->getOperand(0) != IIOp0->getOperand(1)) 3274 break; 3275 if (IIOp1->getOperand(0) != IIOp1->getOperand(1)) 3276 break; 3277 if (IIOp0->getOperand(2) != IIOp1->getOperand(2)) 3278 break; 3279 return new ICmpInst(Pred, IIOp0->getOperand(0), IIOp1->getOperand(0)); 3280 default: 3281 break; 3282 } 3283 3284 return nullptr; 3285 } 3286 3287 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 3288 /// where X is some kind of instruction and C is AllowUndef. 3289 /// TODO: Move more folds which allow undef to this function. 3290 Instruction * 3291 InstCombinerImpl::foldICmpInstWithConstantAllowUndef(ICmpInst &Cmp, 3292 const APInt &C) { 3293 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 3294 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) { 3295 switch (II->getIntrinsicID()) { 3296 default: 3297 break; 3298 case Intrinsic::fshl: 3299 case Intrinsic::fshr: 3300 if (Cmp.isEquality() && II->getArgOperand(0) == II->getArgOperand(1)) { 3301 // (rot X, ?) == 0/-1 --> X == 0/-1 3302 if (C.isZero() || C.isAllOnes()) 3303 return new ICmpInst(Pred, II->getArgOperand(0), Cmp.getOperand(1)); 3304 } 3305 break; 3306 } 3307 } 3308 3309 return nullptr; 3310 } 3311 3312 /// Fold an icmp with BinaryOp and constant operand: icmp Pred BO, C. 3313 Instruction *InstCombinerImpl::foldICmpBinOpWithConstant(ICmpInst &Cmp, 3314 BinaryOperator *BO, 3315 const APInt &C) { 3316 switch (BO->getOpcode()) { 3317 case Instruction::Xor: 3318 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C)) 3319 return I; 3320 break; 3321 case Instruction::And: 3322 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C)) 3323 return I; 3324 break; 3325 case Instruction::Or: 3326 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C)) 3327 return I; 3328 break; 3329 case Instruction::Mul: 3330 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C)) 3331 return I; 3332 break; 3333 case Instruction::Shl: 3334 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C)) 3335 return I; 3336 break; 3337 case Instruction::LShr: 3338 case Instruction::AShr: 3339 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C)) 3340 return I; 3341 break; 3342 case Instruction::SRem: 3343 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, C)) 3344 return I; 3345 break; 3346 case Instruction::UDiv: 3347 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C)) 3348 return I; 3349 LLVM_FALLTHROUGH; 3350 case Instruction::SDiv: 3351 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C)) 3352 return I; 3353 break; 3354 case Instruction::Sub: 3355 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C)) 3356 return I; 3357 break; 3358 case Instruction::Add: 3359 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C)) 3360 return I; 3361 break; 3362 default: 3363 break; 3364 } 3365 3366 // TODO: These folds could be refactored to be part of the above calls. 3367 return foldICmpBinOpEqualityWithConstant(Cmp, BO, C); 3368 } 3369 3370 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 3371 Instruction *InstCombinerImpl::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 3372 IntrinsicInst *II, 3373 const APInt &C) { 3374 if (Cmp.isEquality()) 3375 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 3376 3377 Type *Ty = II->getType(); 3378 unsigned BitWidth = C.getBitWidth(); 3379 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3380 switch (II->getIntrinsicID()) { 3381 case Intrinsic::ctpop: { 3382 // (ctpop X > BitWidth - 1) --> X == -1 3383 Value *X = II->getArgOperand(0); 3384 if (C == BitWidth - 1 && Pred == ICmpInst::ICMP_UGT) 3385 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, X, 3386 ConstantInt::getAllOnesValue(Ty)); 3387 // (ctpop X < BitWidth) --> X != -1 3388 if (C == BitWidth && Pred == ICmpInst::ICMP_ULT) 3389 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, X, 3390 ConstantInt::getAllOnesValue(Ty)); 3391 break; 3392 } 3393 case Intrinsic::ctlz: { 3394 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 3395 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3396 unsigned Num = C.getLimitedValue(); 3397 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3398 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 3399 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3400 } 3401 3402 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 3403 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3404 unsigned Num = C.getLimitedValue(); 3405 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 3406 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 3407 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3408 } 3409 break; 3410 } 3411 case Intrinsic::cttz: { 3412 // Limit to one use to ensure we don't increase instruction count. 3413 if (!II->hasOneUse()) 3414 return nullptr; 3415 3416 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 3417 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3418 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 3419 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 3420 Builder.CreateAnd(II->getArgOperand(0), Mask), 3421 ConstantInt::getNullValue(Ty)); 3422 } 3423 3424 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3425 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3426 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3427 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3428 Builder.CreateAnd(II->getArgOperand(0), Mask), 3429 ConstantInt::getNullValue(Ty)); 3430 } 3431 break; 3432 } 3433 default: 3434 break; 3435 } 3436 3437 return nullptr; 3438 } 3439 3440 /// Handle icmp with constant (but not simple integer constant) RHS. 3441 Instruction *InstCombinerImpl::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3442 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3443 Constant *RHSC = dyn_cast<Constant>(Op1); 3444 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3445 if (!RHSC || !LHSI) 3446 return nullptr; 3447 3448 switch (LHSI->getOpcode()) { 3449 case Instruction::GetElementPtr: 3450 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3451 if (RHSC->isNullValue() && 3452 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3453 return new ICmpInst( 3454 I.getPredicate(), LHSI->getOperand(0), 3455 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3456 break; 3457 case Instruction::PHI: 3458 // Only fold icmp into the PHI if the phi and icmp are in the same 3459 // block. If in the same block, we're encouraging jump threading. If 3460 // not, we are just pessimizing the code by making an i1 phi. 3461 if (LHSI->getParent() == I.getParent()) 3462 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3463 return NV; 3464 break; 3465 case Instruction::IntToPtr: 3466 // icmp pred inttoptr(X), null -> icmp pred X, 0 3467 if (RHSC->isNullValue() && 3468 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3469 return new ICmpInst( 3470 I.getPredicate(), LHSI->getOperand(0), 3471 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3472 break; 3473 3474 case Instruction::Load: 3475 // Try to optimize things like "A[i] > 4" to index computations. 3476 if (GetElementPtrInst *GEP = 3477 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 3478 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3479 if (Instruction *Res = 3480 foldCmpLoadFromIndexedGlobal(cast<LoadInst>(LHSI), GEP, GV, I)) 3481 return Res; 3482 break; 3483 } 3484 3485 return nullptr; 3486 } 3487 3488 Instruction *InstCombinerImpl::foldSelectICmp(ICmpInst::Predicate Pred, 3489 SelectInst *SI, Value *RHS, 3490 const ICmpInst &I) { 3491 // Try to fold the comparison into the select arms, which will cause the 3492 // select to be converted into a logical and/or. 3493 auto SimplifyOp = [&](Value *Op, bool SelectCondIsTrue) -> Value * { 3494 if (Value *Res = SimplifyICmpInst(Pred, Op, RHS, SQ)) 3495 return Res; 3496 if (Optional<bool> Impl = isImpliedCondition(SI->getCondition(), Pred, Op, 3497 RHS, DL, SelectCondIsTrue)) 3498 return ConstantInt::get(I.getType(), *Impl); 3499 return nullptr; 3500 }; 3501 3502 ConstantInt *CI = nullptr; 3503 Value *Op1 = SimplifyOp(SI->getOperand(1), true); 3504 if (Op1) 3505 CI = dyn_cast<ConstantInt>(Op1); 3506 3507 Value *Op2 = SimplifyOp(SI->getOperand(2), false); 3508 if (Op2) 3509 CI = dyn_cast<ConstantInt>(Op2); 3510 3511 // We only want to perform this transformation if it will not lead to 3512 // additional code. This is true if either both sides of the select 3513 // fold to a constant (in which case the icmp is replaced with a select 3514 // which will usually simplify) or this is the only user of the 3515 // select (in which case we are trading a select+icmp for a simpler 3516 // select+icmp) or all uses of the select can be replaced based on 3517 // dominance information ("Global cases"). 3518 bool Transform = false; 3519 if (Op1 && Op2) 3520 Transform = true; 3521 else if (Op1 || Op2) { 3522 // Local case 3523 if (SI->hasOneUse()) 3524 Transform = true; 3525 // Global cases 3526 else if (CI && !CI->isZero()) 3527 // When Op1 is constant try replacing select with second operand. 3528 // Otherwise Op2 is constant and try replacing select with first 3529 // operand. 3530 Transform = replacedSelectWithOperand(SI, &I, Op1 ? 2 : 1); 3531 } 3532 if (Transform) { 3533 if (!Op1) 3534 Op1 = Builder.CreateICmp(Pred, SI->getOperand(1), RHS, I.getName()); 3535 if (!Op2) 3536 Op2 = Builder.CreateICmp(Pred, SI->getOperand(2), RHS, I.getName()); 3537 return SelectInst::Create(SI->getOperand(0), Op1, Op2); 3538 } 3539 3540 return nullptr; 3541 } 3542 3543 /// Some comparisons can be simplified. 3544 /// In this case, we are looking for comparisons that look like 3545 /// a check for a lossy truncation. 3546 /// Folds: 3547 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3548 /// Where Mask is some pattern that produces all-ones in low bits: 3549 /// (-1 >> y) 3550 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3551 /// ~(-1 << y) 3552 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3553 /// The Mask can be a constant, too. 3554 /// For some predicates, the operands are commutative. 3555 /// For others, x can only be on a specific side. 3556 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3557 InstCombiner::BuilderTy &Builder) { 3558 ICmpInst::Predicate SrcPred; 3559 Value *X, *M, *Y; 3560 auto m_VariableMask = m_CombineOr( 3561 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3562 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3563 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3564 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3565 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3566 if (!match(&I, m_c_ICmp(SrcPred, 3567 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3568 m_Deferred(X)))) 3569 return nullptr; 3570 3571 ICmpInst::Predicate DstPred; 3572 switch (SrcPred) { 3573 case ICmpInst::Predicate::ICMP_EQ: 3574 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3575 DstPred = ICmpInst::Predicate::ICMP_ULE; 3576 break; 3577 case ICmpInst::Predicate::ICMP_NE: 3578 // x & (-1 >> y) != x -> x u> (-1 >> y) 3579 DstPred = ICmpInst::Predicate::ICMP_UGT; 3580 break; 3581 case ICmpInst::Predicate::ICMP_ULT: 3582 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3583 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3584 DstPred = ICmpInst::Predicate::ICMP_UGT; 3585 break; 3586 case ICmpInst::Predicate::ICMP_UGE: 3587 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3588 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3589 DstPred = ICmpInst::Predicate::ICMP_ULE; 3590 break; 3591 case ICmpInst::Predicate::ICMP_SLT: 3592 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3593 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3594 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3595 return nullptr; 3596 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3597 return nullptr; 3598 DstPred = ICmpInst::Predicate::ICMP_SGT; 3599 break; 3600 case ICmpInst::Predicate::ICMP_SGE: 3601 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3602 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3603 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3604 return nullptr; 3605 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3606 return nullptr; 3607 DstPred = ICmpInst::Predicate::ICMP_SLE; 3608 break; 3609 case ICmpInst::Predicate::ICMP_SGT: 3610 case ICmpInst::Predicate::ICMP_SLE: 3611 return nullptr; 3612 case ICmpInst::Predicate::ICMP_UGT: 3613 case ICmpInst::Predicate::ICMP_ULE: 3614 llvm_unreachable("Instsimplify took care of commut. variant"); 3615 break; 3616 default: 3617 llvm_unreachable("All possible folds are handled."); 3618 } 3619 3620 // The mask value may be a vector constant that has undefined elements. But it 3621 // may not be safe to propagate those undefs into the new compare, so replace 3622 // those elements by copying an existing, defined, and safe scalar constant. 3623 Type *OpTy = M->getType(); 3624 auto *VecC = dyn_cast<Constant>(M); 3625 auto *OpVTy = dyn_cast<FixedVectorType>(OpTy); 3626 if (OpVTy && VecC && VecC->containsUndefOrPoisonElement()) { 3627 Constant *SafeReplacementConstant = nullptr; 3628 for (unsigned i = 0, e = OpVTy->getNumElements(); i != e; ++i) { 3629 if (!isa<UndefValue>(VecC->getAggregateElement(i))) { 3630 SafeReplacementConstant = VecC->getAggregateElement(i); 3631 break; 3632 } 3633 } 3634 assert(SafeReplacementConstant && "Failed to find undef replacement"); 3635 M = Constant::replaceUndefsWith(VecC, SafeReplacementConstant); 3636 } 3637 3638 return Builder.CreateICmp(DstPred, X, M); 3639 } 3640 3641 /// Some comparisons can be simplified. 3642 /// In this case, we are looking for comparisons that look like 3643 /// a check for a lossy signed truncation. 3644 /// Folds: (MaskedBits is a constant.) 3645 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3646 /// Into: 3647 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3648 /// Where KeptBits = bitwidth(%x) - MaskedBits 3649 static Value * 3650 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3651 InstCombiner::BuilderTy &Builder) { 3652 ICmpInst::Predicate SrcPred; 3653 Value *X; 3654 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3655 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3656 if (!match(&I, m_c_ICmp(SrcPred, 3657 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3658 m_APInt(C1))), 3659 m_Deferred(X)))) 3660 return nullptr; 3661 3662 // Potential handling of non-splats: for each element: 3663 // * if both are undef, replace with constant 0. 3664 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3665 // * if both are not undef, and are different, bailout. 3666 // * else, only one is undef, then pick the non-undef one. 3667 3668 // The shift amount must be equal. 3669 if (*C0 != *C1) 3670 return nullptr; 3671 const APInt &MaskedBits = *C0; 3672 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3673 3674 ICmpInst::Predicate DstPred; 3675 switch (SrcPred) { 3676 case ICmpInst::Predicate::ICMP_EQ: 3677 // ((%x << MaskedBits) a>> MaskedBits) == %x 3678 // => 3679 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3680 DstPred = ICmpInst::Predicate::ICMP_ULT; 3681 break; 3682 case ICmpInst::Predicate::ICMP_NE: 3683 // ((%x << MaskedBits) a>> MaskedBits) != %x 3684 // => 3685 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3686 DstPred = ICmpInst::Predicate::ICMP_UGE; 3687 break; 3688 // FIXME: are more folds possible? 3689 default: 3690 return nullptr; 3691 } 3692 3693 auto *XType = X->getType(); 3694 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3695 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3696 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3697 3698 // KeptBits = bitwidth(%x) - MaskedBits 3699 const APInt KeptBits = BitWidth - MaskedBits; 3700 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3701 // ICmpCst = (1 << KeptBits) 3702 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3703 assert(ICmpCst.isPowerOf2()); 3704 // AddCst = (1 << (KeptBits-1)) 3705 const APInt AddCst = ICmpCst.lshr(1); 3706 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3707 3708 // T0 = add %x, AddCst 3709 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3710 // T1 = T0 DstPred ICmpCst 3711 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3712 3713 return T1; 3714 } 3715 3716 // Given pattern: 3717 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3718 // we should move shifts to the same hand of 'and', i.e. rewrite as 3719 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3720 // We are only interested in opposite logical shifts here. 3721 // One of the shifts can be truncated. 3722 // If we can, we want to end up creating 'lshr' shift. 3723 static Value * 3724 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3725 InstCombiner::BuilderTy &Builder) { 3726 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3727 !I.getOperand(0)->hasOneUse()) 3728 return nullptr; 3729 3730 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3731 3732 // Look for an 'and' of two logical shifts, one of which may be truncated. 3733 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3734 Instruction *XShift, *MaybeTruncation, *YShift; 3735 if (!match( 3736 I.getOperand(0), 3737 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3738 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3739 m_AnyLogicalShift, m_Instruction(YShift))), 3740 m_Instruction(MaybeTruncation))))) 3741 return nullptr; 3742 3743 // We potentially looked past 'trunc', but only when matching YShift, 3744 // therefore YShift must have the widest type. 3745 Instruction *WidestShift = YShift; 3746 // Therefore XShift must have the shallowest type. 3747 // Or they both have identical types if there was no truncation. 3748 Instruction *NarrowestShift = XShift; 3749 3750 Type *WidestTy = WidestShift->getType(); 3751 Type *NarrowestTy = NarrowestShift->getType(); 3752 assert(NarrowestTy == I.getOperand(0)->getType() && 3753 "We did not look past any shifts while matching XShift though."); 3754 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3755 3756 // If YShift is a 'lshr', swap the shifts around. 3757 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3758 std::swap(XShift, YShift); 3759 3760 // The shifts must be in opposite directions. 3761 auto XShiftOpcode = XShift->getOpcode(); 3762 if (XShiftOpcode == YShift->getOpcode()) 3763 return nullptr; // Do not care about same-direction shifts here. 3764 3765 Value *X, *XShAmt, *Y, *YShAmt; 3766 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3767 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3768 3769 // If one of the values being shifted is a constant, then we will end with 3770 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3771 // however, we will need to ensure that we won't increase instruction count. 3772 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3773 // At least one of the hands of the 'and' should be one-use shift. 3774 if (!match(I.getOperand(0), 3775 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3776 return nullptr; 3777 if (HadTrunc) { 3778 // Due to the 'trunc', we will need to widen X. For that either the old 3779 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3780 if (!MaybeTruncation->hasOneUse() && 3781 !NarrowestShift->getOperand(1)->hasOneUse()) 3782 return nullptr; 3783 } 3784 } 3785 3786 // We have two shift amounts from two different shifts. The types of those 3787 // shift amounts may not match. If that's the case let's bailout now. 3788 if (XShAmt->getType() != YShAmt->getType()) 3789 return nullptr; 3790 3791 // As input, we have the following pattern: 3792 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3793 // We want to rewrite that as: 3794 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3795 // While we know that originally (Q+K) would not overflow 3796 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 3797 // shift amounts. so it may now overflow in smaller bitwidth. 3798 // To ensure that does not happen, we need to ensure that the total maximal 3799 // shift amount is still representable in that smaller bit width. 3800 unsigned MaximalPossibleTotalShiftAmount = 3801 (WidestTy->getScalarSizeInBits() - 1) + 3802 (NarrowestTy->getScalarSizeInBits() - 1); 3803 APInt MaximalRepresentableShiftAmount = 3804 APInt::getAllOnes(XShAmt->getType()->getScalarSizeInBits()); 3805 if (MaximalRepresentableShiftAmount.ult(MaximalPossibleTotalShiftAmount)) 3806 return nullptr; 3807 3808 // Can we fold (XShAmt+YShAmt) ? 3809 auto *NewShAmt = dyn_cast_or_null<Constant>( 3810 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3811 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3812 if (!NewShAmt) 3813 return nullptr; 3814 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3815 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits(); 3816 3817 // Is the new shift amount smaller than the bit width? 3818 // FIXME: could also rely on ConstantRange. 3819 if (!match(NewShAmt, 3820 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 3821 APInt(WidestBitWidth, WidestBitWidth)))) 3822 return nullptr; 3823 3824 // An extra legality check is needed if we had trunc-of-lshr. 3825 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) { 3826 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ, 3827 WidestShift]() { 3828 // It isn't obvious whether it's worth it to analyze non-constants here. 3829 // Also, let's basically give up on non-splat cases, pessimizing vectors. 3830 // If *any* of these preconditions matches we can perform the fold. 3831 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy() 3832 ? NewShAmt->getSplatValue() 3833 : NewShAmt; 3834 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold. 3835 if (NewShAmtSplat && 3836 (NewShAmtSplat->isNullValue() || 3837 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1)) 3838 return true; 3839 // We consider *min* leading zeros so a single outlier 3840 // blocks the transform as opposed to allowing it. 3841 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) { 3842 KnownBits Known = computeKnownBits(C, SQ.DL); 3843 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3844 // If the value being shifted has at most lowest bit set we can fold. 3845 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3846 if (MaxActiveBits <= 1) 3847 return true; 3848 // Precondition: NewShAmt u<= countLeadingZeros(C) 3849 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero)) 3850 return true; 3851 } 3852 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) { 3853 KnownBits Known = computeKnownBits(C, SQ.DL); 3854 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3855 // If the value being shifted has at most lowest bit set we can fold. 3856 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3857 if (MaxActiveBits <= 1) 3858 return true; 3859 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C) 3860 if (NewShAmtSplat) { 3861 APInt AdjNewShAmt = 3862 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger(); 3863 if (AdjNewShAmt.ule(MinLeadZero)) 3864 return true; 3865 } 3866 } 3867 return false; // Can't tell if it's ok. 3868 }; 3869 if (!CanFold()) 3870 return nullptr; 3871 } 3872 3873 // All good, we can do this fold. 3874 X = Builder.CreateZExt(X, WidestTy); 3875 Y = Builder.CreateZExt(Y, WidestTy); 3876 // The shift is the same that was for X. 3877 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3878 ? Builder.CreateLShr(X, NewShAmt) 3879 : Builder.CreateShl(X, NewShAmt); 3880 Value *T1 = Builder.CreateAnd(T0, Y); 3881 return Builder.CreateICmp(I.getPredicate(), T1, 3882 Constant::getNullValue(WidestTy)); 3883 } 3884 3885 /// Fold 3886 /// (-1 u/ x) u< y 3887 /// ((x * y) ?/ x) != y 3888 /// to 3889 /// @llvm.?mul.with.overflow(x, y) plus extraction of overflow bit 3890 /// Note that the comparison is commutative, while inverted (u>=, ==) predicate 3891 /// will mean that we are looking for the opposite answer. 3892 Value *InstCombinerImpl::foldMultiplicationOverflowCheck(ICmpInst &I) { 3893 ICmpInst::Predicate Pred; 3894 Value *X, *Y; 3895 Instruction *Mul; 3896 Instruction *Div; 3897 bool NeedNegation; 3898 // Look for: (-1 u/ x) u</u>= y 3899 if (!I.isEquality() && 3900 match(&I, m_c_ICmp(Pred, 3901 m_CombineAnd(m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))), 3902 m_Instruction(Div)), 3903 m_Value(Y)))) { 3904 Mul = nullptr; 3905 3906 // Are we checking that overflow does not happen, or does happen? 3907 switch (Pred) { 3908 case ICmpInst::Predicate::ICMP_ULT: 3909 NeedNegation = false; 3910 break; // OK 3911 case ICmpInst::Predicate::ICMP_UGE: 3912 NeedNegation = true; 3913 break; // OK 3914 default: 3915 return nullptr; // Wrong predicate. 3916 } 3917 } else // Look for: ((x * y) / x) !=/== y 3918 if (I.isEquality() && 3919 match(&I, 3920 m_c_ICmp(Pred, m_Value(Y), 3921 m_CombineAnd( 3922 m_OneUse(m_IDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y), 3923 m_Value(X)), 3924 m_Instruction(Mul)), 3925 m_Deferred(X))), 3926 m_Instruction(Div))))) { 3927 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ; 3928 } else 3929 return nullptr; 3930 3931 BuilderTy::InsertPointGuard Guard(Builder); 3932 // If the pattern included (x * y), we'll want to insert new instructions 3933 // right before that original multiplication so that we can replace it. 3934 bool MulHadOtherUses = Mul && !Mul->hasOneUse(); 3935 if (MulHadOtherUses) 3936 Builder.SetInsertPoint(Mul); 3937 3938 Function *F = Intrinsic::getDeclaration(I.getModule(), 3939 Div->getOpcode() == Instruction::UDiv 3940 ? Intrinsic::umul_with_overflow 3941 : Intrinsic::smul_with_overflow, 3942 X->getType()); 3943 CallInst *Call = Builder.CreateCall(F, {X, Y}, "mul"); 3944 3945 // If the multiplication was used elsewhere, to ensure that we don't leave 3946 // "duplicate" instructions, replace uses of that original multiplication 3947 // with the multiplication result from the with.overflow intrinsic. 3948 if (MulHadOtherUses) 3949 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "mul.val")); 3950 3951 Value *Res = Builder.CreateExtractValue(Call, 1, "mul.ov"); 3952 if (NeedNegation) // This technically increases instruction count. 3953 Res = Builder.CreateNot(Res, "mul.not.ov"); 3954 3955 // If we replaced the mul, erase it. Do this after all uses of Builder, 3956 // as the mul is used as insertion point. 3957 if (MulHadOtherUses) 3958 eraseInstFromFunction(*Mul); 3959 3960 return Res; 3961 } 3962 3963 static Instruction *foldICmpXNegX(ICmpInst &I) { 3964 CmpInst::Predicate Pred; 3965 Value *X; 3966 if (!match(&I, m_c_ICmp(Pred, m_NSWNeg(m_Value(X)), m_Deferred(X)))) 3967 return nullptr; 3968 3969 if (ICmpInst::isSigned(Pred)) 3970 Pred = ICmpInst::getSwappedPredicate(Pred); 3971 else if (ICmpInst::isUnsigned(Pred)) 3972 Pred = ICmpInst::getSignedPredicate(Pred); 3973 // else for equality-comparisons just keep the predicate. 3974 3975 return ICmpInst::Create(Instruction::ICmp, Pred, X, 3976 Constant::getNullValue(X->getType()), I.getName()); 3977 } 3978 3979 /// Try to fold icmp (binop), X or icmp X, (binop). 3980 /// TODO: A large part of this logic is duplicated in InstSimplify's 3981 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3982 /// duplication. 3983 Instruction *InstCombinerImpl::foldICmpBinOp(ICmpInst &I, 3984 const SimplifyQuery &SQ) { 3985 const SimplifyQuery Q = SQ.getWithInstruction(&I); 3986 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3987 3988 // Special logic for binary operators. 3989 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3990 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3991 if (!BO0 && !BO1) 3992 return nullptr; 3993 3994 if (Instruction *NewICmp = foldICmpXNegX(I)) 3995 return NewICmp; 3996 3997 const CmpInst::Predicate Pred = I.getPredicate(); 3998 Value *X; 3999 4000 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 4001 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X 4002 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 4003 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 4004 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 4005 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0 4006 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 4007 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 4008 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 4009 4010 { 4011 // (Op1 + X) + C u</u>= Op1 --> ~C - X u</u>= Op1 4012 Constant *C; 4013 if (match(Op0, m_OneUse(m_Add(m_c_Add(m_Specific(Op1), m_Value(X)), 4014 m_ImmConstant(C)))) && 4015 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 4016 Constant *C2 = ConstantExpr::getNot(C); 4017 return new ICmpInst(Pred, Builder.CreateSub(C2, X), Op1); 4018 } 4019 // Op0 u>/u<= (Op0 + X) + C --> Op0 u>/u<= ~C - X 4020 if (match(Op1, m_OneUse(m_Add(m_c_Add(m_Specific(Op0), m_Value(X)), 4021 m_ImmConstant(C)))) && 4022 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) { 4023 Constant *C2 = ConstantExpr::getNot(C); 4024 return new ICmpInst(Pred, Op0, Builder.CreateSub(C2, X)); 4025 } 4026 } 4027 4028 { 4029 // Similar to above: an unsigned overflow comparison may use offset + mask: 4030 // ((Op1 + C) & C) u< Op1 --> Op1 != 0 4031 // ((Op1 + C) & C) u>= Op1 --> Op1 == 0 4032 // Op0 u> ((Op0 + C) & C) --> Op0 != 0 4033 // Op0 u<= ((Op0 + C) & C) --> Op0 == 0 4034 BinaryOperator *BO; 4035 const APInt *C; 4036 if ((Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE) && 4037 match(Op0, m_And(m_BinOp(BO), m_LowBitMask(C))) && 4038 match(BO, m_Add(m_Specific(Op1), m_SpecificIntAllowUndef(*C)))) { 4039 CmpInst::Predicate NewPred = 4040 Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ; 4041 Constant *Zero = ConstantInt::getNullValue(Op1->getType()); 4042 return new ICmpInst(NewPred, Op1, Zero); 4043 } 4044 4045 if ((Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE) && 4046 match(Op1, m_And(m_BinOp(BO), m_LowBitMask(C))) && 4047 match(BO, m_Add(m_Specific(Op0), m_SpecificIntAllowUndef(*C)))) { 4048 CmpInst::Predicate NewPred = 4049 Pred == ICmpInst::ICMP_UGT ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ; 4050 Constant *Zero = ConstantInt::getNullValue(Op1->getType()); 4051 return new ICmpInst(NewPred, Op0, Zero); 4052 } 4053 } 4054 4055 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 4056 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 4057 NoOp0WrapProblem = 4058 ICmpInst::isEquality(Pred) || 4059 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 4060 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 4061 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 4062 NoOp1WrapProblem = 4063 ICmpInst::isEquality(Pred) || 4064 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 4065 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 4066 4067 // Analyze the case when either Op0 or Op1 is an add instruction. 4068 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 4069 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 4070 if (BO0 && BO0->getOpcode() == Instruction::Add) { 4071 A = BO0->getOperand(0); 4072 B = BO0->getOperand(1); 4073 } 4074 if (BO1 && BO1->getOpcode() == Instruction::Add) { 4075 C = BO1->getOperand(0); 4076 D = BO1->getOperand(1); 4077 } 4078 4079 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow. 4080 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow. 4081 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 4082 return new ICmpInst(Pred, A == Op1 ? B : A, 4083 Constant::getNullValue(Op1->getType())); 4084 4085 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow. 4086 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow. 4087 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 4088 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 4089 C == Op0 ? D : C); 4090 4091 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow. 4092 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 4093 NoOp1WrapProblem) { 4094 // Determine Y and Z in the form icmp (X+Y), (X+Z). 4095 Value *Y, *Z; 4096 if (A == C) { 4097 // C + B == C + D -> B == D 4098 Y = B; 4099 Z = D; 4100 } else if (A == D) { 4101 // D + B == C + D -> B == C 4102 Y = B; 4103 Z = C; 4104 } else if (B == C) { 4105 // A + C == C + D -> A == D 4106 Y = A; 4107 Z = D; 4108 } else { 4109 assert(B == D); 4110 // A + D == C + D -> A == C 4111 Y = A; 4112 Z = C; 4113 } 4114 return new ICmpInst(Pred, Y, Z); 4115 } 4116 4117 // icmp slt (A + -1), Op1 -> icmp sle A, Op1 4118 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 4119 match(B, m_AllOnes())) 4120 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 4121 4122 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1 4123 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 4124 match(B, m_AllOnes())) 4125 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 4126 4127 // icmp sle (A + 1), Op1 -> icmp slt A, Op1 4128 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 4129 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 4130 4131 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1 4132 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 4133 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 4134 4135 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C 4136 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 4137 match(D, m_AllOnes())) 4138 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 4139 4140 // icmp sle Op0, (C + -1) -> icmp slt Op0, C 4141 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 4142 match(D, m_AllOnes())) 4143 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 4144 4145 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C 4146 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 4147 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 4148 4149 // icmp slt Op0, (C + 1) -> icmp sle Op0, C 4150 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 4151 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 4152 4153 // TODO: The subtraction-related identities shown below also hold, but 4154 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 4155 // wouldn't happen even if they were implemented. 4156 // 4157 // icmp ult (A - 1), Op1 -> icmp ule A, Op1 4158 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1 4159 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C 4160 // icmp ule Op0, (C - 1) -> icmp ult Op0, C 4161 4162 // icmp ule (A + 1), Op0 -> icmp ult A, Op1 4163 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 4164 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 4165 4166 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1 4167 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 4168 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 4169 4170 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C 4171 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 4172 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 4173 4174 // icmp ult Op0, (C + 1) -> icmp ule Op0, C 4175 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 4176 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 4177 4178 // if C1 has greater magnitude than C2: 4179 // icmp (A + C1), (C + C2) -> icmp (A + C3), C 4180 // s.t. C3 = C1 - C2 4181 // 4182 // if C2 has greater magnitude than C1: 4183 // icmp (A + C1), (C + C2) -> icmp A, (C + C3) 4184 // s.t. C3 = C2 - C1 4185 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 4186 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) { 4187 const APInt *AP1, *AP2; 4188 // TODO: Support non-uniform vectors. 4189 // TODO: Allow undef passthrough if B AND D's element is undef. 4190 if (match(B, m_APIntAllowUndef(AP1)) && match(D, m_APIntAllowUndef(AP2)) && 4191 AP1->isNegative() == AP2->isNegative()) { 4192 APInt AP1Abs = AP1->abs(); 4193 APInt AP2Abs = AP2->abs(); 4194 if (AP1Abs.uge(AP2Abs)) { 4195 APInt Diff = *AP1 - *AP2; 4196 bool HasNUW = BO0->hasNoUnsignedWrap() && Diff.ule(*AP1); 4197 bool HasNSW = BO0->hasNoSignedWrap(); 4198 Constant *C3 = Constant::getIntegerValue(BO0->getType(), Diff); 4199 Value *NewAdd = Builder.CreateAdd(A, C3, "", HasNUW, HasNSW); 4200 return new ICmpInst(Pred, NewAdd, C); 4201 } else { 4202 APInt Diff = *AP2 - *AP1; 4203 bool HasNUW = BO1->hasNoUnsignedWrap() && Diff.ule(*AP2); 4204 bool HasNSW = BO1->hasNoSignedWrap(); 4205 Constant *C3 = Constant::getIntegerValue(BO0->getType(), Diff); 4206 Value *NewAdd = Builder.CreateAdd(C, C3, "", HasNUW, HasNSW); 4207 return new ICmpInst(Pred, A, NewAdd); 4208 } 4209 } 4210 Constant *Cst1, *Cst2; 4211 if (match(B, m_ImmConstant(Cst1)) && match(D, m_ImmConstant(Cst2)) && 4212 ICmpInst::isEquality(Pred)) { 4213 Constant *Diff = ConstantExpr::getSub(Cst2, Cst1); 4214 Value *NewAdd = Builder.CreateAdd(C, Diff); 4215 return new ICmpInst(Pred, A, NewAdd); 4216 } 4217 } 4218 4219 // Analyze the case when either Op0 or Op1 is a sub instruction. 4220 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 4221 A = nullptr; 4222 B = nullptr; 4223 C = nullptr; 4224 D = nullptr; 4225 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 4226 A = BO0->getOperand(0); 4227 B = BO0->getOperand(1); 4228 } 4229 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 4230 C = BO1->getOperand(0); 4231 D = BO1->getOperand(1); 4232 } 4233 4234 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow. 4235 if (A == Op1 && NoOp0WrapProblem) 4236 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 4237 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow. 4238 if (C == Op0 && NoOp1WrapProblem) 4239 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 4240 4241 // Convert sub-with-unsigned-overflow comparisons into a comparison of args. 4242 // (A - B) u>/u<= A --> B u>/u<= A 4243 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 4244 return new ICmpInst(Pred, B, A); 4245 // C u</u>= (C - D) --> C u</u>= D 4246 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 4247 return new ICmpInst(Pred, C, D); 4248 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0 4249 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) && 4250 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4251 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A); 4252 // C u<=/u> (C - D) --> C u</u>= D iff B != 0 4253 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) && 4254 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4255 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D); 4256 4257 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow. 4258 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem) 4259 return new ICmpInst(Pred, A, C); 4260 4261 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow. 4262 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem) 4263 return new ICmpInst(Pred, D, B); 4264 4265 // icmp (0-X) < cst --> x > -cst 4266 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 4267 Value *X; 4268 if (match(BO0, m_Neg(m_Value(X)))) 4269 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 4270 if (RHSC->isNotMinSignedValue()) 4271 return new ICmpInst(I.getSwappedPredicate(), X, 4272 ConstantExpr::getNeg(RHSC)); 4273 } 4274 4275 { 4276 // Try to remove shared constant multiplier from equality comparison: 4277 // X * C == Y * C (with no overflowing/aliasing) --> X == Y 4278 Value *X, *Y; 4279 const APInt *C; 4280 if (match(Op0, m_Mul(m_Value(X), m_APInt(C))) && *C != 0 && 4281 match(Op1, m_Mul(m_Value(Y), m_SpecificInt(*C))) && I.isEquality()) 4282 if (!C->countTrailingZeros() || 4283 (BO0 && BO1 && BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap()) || 4284 (BO0 && BO1 && BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap())) 4285 return new ICmpInst(Pred, X, Y); 4286 } 4287 4288 BinaryOperator *SRem = nullptr; 4289 // icmp (srem X, Y), Y 4290 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 4291 SRem = BO0; 4292 // icmp Y, (srem X, Y) 4293 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 4294 Op0 == BO1->getOperand(1)) 4295 SRem = BO1; 4296 if (SRem) { 4297 // We don't check hasOneUse to avoid increasing register pressure because 4298 // the value we use is the same value this instruction was already using. 4299 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 4300 default: 4301 break; 4302 case ICmpInst::ICMP_EQ: 4303 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4304 case ICmpInst::ICMP_NE: 4305 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4306 case ICmpInst::ICMP_SGT: 4307 case ICmpInst::ICMP_SGE: 4308 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 4309 Constant::getAllOnesValue(SRem->getType())); 4310 case ICmpInst::ICMP_SLT: 4311 case ICmpInst::ICMP_SLE: 4312 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 4313 Constant::getNullValue(SRem->getType())); 4314 } 4315 } 4316 4317 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 4318 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 4319 switch (BO0->getOpcode()) { 4320 default: 4321 break; 4322 case Instruction::Add: 4323 case Instruction::Sub: 4324 case Instruction::Xor: { 4325 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 4326 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4327 4328 const APInt *C; 4329 if (match(BO0->getOperand(1), m_APInt(C))) { 4330 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 4331 if (C->isSignMask()) { 4332 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4333 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4334 } 4335 4336 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 4337 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 4338 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4339 NewPred = I.getSwappedPredicate(NewPred); 4340 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4341 } 4342 } 4343 break; 4344 } 4345 case Instruction::Mul: { 4346 if (!I.isEquality()) 4347 break; 4348 4349 const APInt *C; 4350 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isZero() && 4351 !C->isOne()) { 4352 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 4353 // Mask = -1 >> count-trailing-zeros(C). 4354 if (unsigned TZs = C->countTrailingZeros()) { 4355 Constant *Mask = ConstantInt::get( 4356 BO0->getType(), 4357 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 4358 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 4359 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 4360 return new ICmpInst(Pred, And1, And2); 4361 } 4362 } 4363 break; 4364 } 4365 case Instruction::UDiv: 4366 case Instruction::LShr: 4367 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 4368 break; 4369 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4370 4371 case Instruction::SDiv: 4372 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 4373 break; 4374 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4375 4376 case Instruction::AShr: 4377 if (!BO0->isExact() || !BO1->isExact()) 4378 break; 4379 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4380 4381 case Instruction::Shl: { 4382 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 4383 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 4384 if (!NUW && !NSW) 4385 break; 4386 if (!NSW && I.isSigned()) 4387 break; 4388 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4389 } 4390 } 4391 } 4392 4393 if (BO0) { 4394 // Transform A & (L - 1) `ult` L --> L != 0 4395 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 4396 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 4397 4398 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 4399 auto *Zero = Constant::getNullValue(BO0->getType()); 4400 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 4401 } 4402 } 4403 4404 if (Value *V = foldMultiplicationOverflowCheck(I)) 4405 return replaceInstUsesWith(I, V); 4406 4407 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 4408 return replaceInstUsesWith(I, V); 4409 4410 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 4411 return replaceInstUsesWith(I, V); 4412 4413 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 4414 return replaceInstUsesWith(I, V); 4415 4416 return nullptr; 4417 } 4418 4419 /// Fold icmp Pred min|max(X, Y), X. 4420 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 4421 ICmpInst::Predicate Pred = Cmp.getPredicate(); 4422 Value *Op0 = Cmp.getOperand(0); 4423 Value *X = Cmp.getOperand(1); 4424 4425 // Canonicalize minimum or maximum operand to LHS of the icmp. 4426 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 4427 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 4428 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 4429 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 4430 std::swap(Op0, X); 4431 Pred = Cmp.getSwappedPredicate(); 4432 } 4433 4434 Value *Y; 4435 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 4436 // smin(X, Y) == X --> X s<= Y 4437 // smin(X, Y) s>= X --> X s<= Y 4438 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 4439 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 4440 4441 // smin(X, Y) != X --> X s> Y 4442 // smin(X, Y) s< X --> X s> Y 4443 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 4444 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 4445 4446 // These cases should be handled in InstSimplify: 4447 // smin(X, Y) s<= X --> true 4448 // smin(X, Y) s> X --> false 4449 return nullptr; 4450 } 4451 4452 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 4453 // smax(X, Y) == X --> X s>= Y 4454 // smax(X, Y) s<= X --> X s>= Y 4455 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 4456 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 4457 4458 // smax(X, Y) != X --> X s< Y 4459 // smax(X, Y) s> X --> X s< Y 4460 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 4461 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 4462 4463 // These cases should be handled in InstSimplify: 4464 // smax(X, Y) s>= X --> true 4465 // smax(X, Y) s< X --> false 4466 return nullptr; 4467 } 4468 4469 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 4470 // umin(X, Y) == X --> X u<= Y 4471 // umin(X, Y) u>= X --> X u<= Y 4472 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 4473 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 4474 4475 // umin(X, Y) != X --> X u> Y 4476 // umin(X, Y) u< X --> X u> Y 4477 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 4478 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 4479 4480 // These cases should be handled in InstSimplify: 4481 // umin(X, Y) u<= X --> true 4482 // umin(X, Y) u> X --> false 4483 return nullptr; 4484 } 4485 4486 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 4487 // umax(X, Y) == X --> X u>= Y 4488 // umax(X, Y) u<= X --> X u>= Y 4489 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 4490 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 4491 4492 // umax(X, Y) != X --> X u< Y 4493 // umax(X, Y) u> X --> X u< Y 4494 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 4495 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 4496 4497 // These cases should be handled in InstSimplify: 4498 // umax(X, Y) u>= X --> true 4499 // umax(X, Y) u< X --> false 4500 return nullptr; 4501 } 4502 4503 return nullptr; 4504 } 4505 4506 Instruction *InstCombinerImpl::foldICmpEquality(ICmpInst &I) { 4507 if (!I.isEquality()) 4508 return nullptr; 4509 4510 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4511 const CmpInst::Predicate Pred = I.getPredicate(); 4512 Value *A, *B, *C, *D; 4513 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 4514 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 4515 Value *OtherVal = A == Op1 ? B : A; 4516 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4517 } 4518 4519 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 4520 // A^c1 == C^c2 --> A == C^(c1^c2) 4521 ConstantInt *C1, *C2; 4522 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 4523 Op1->hasOneUse()) { 4524 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 4525 Value *Xor = Builder.CreateXor(C, NC); 4526 return new ICmpInst(Pred, A, Xor); 4527 } 4528 4529 // A^B == A^D -> B == D 4530 if (A == C) 4531 return new ICmpInst(Pred, B, D); 4532 if (A == D) 4533 return new ICmpInst(Pred, B, C); 4534 if (B == C) 4535 return new ICmpInst(Pred, A, D); 4536 if (B == D) 4537 return new ICmpInst(Pred, A, C); 4538 } 4539 } 4540 4541 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 4542 // A == (A^B) -> B == 0 4543 Value *OtherVal = A == Op0 ? B : A; 4544 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4545 } 4546 4547 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 4548 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 4549 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 4550 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 4551 4552 if (A == C) { 4553 X = B; 4554 Y = D; 4555 Z = A; 4556 } else if (A == D) { 4557 X = B; 4558 Y = C; 4559 Z = A; 4560 } else if (B == C) { 4561 X = A; 4562 Y = D; 4563 Z = B; 4564 } else if (B == D) { 4565 X = A; 4566 Y = C; 4567 Z = B; 4568 } 4569 4570 if (X) { // Build (X^Y) & Z 4571 Op1 = Builder.CreateXor(X, Y); 4572 Op1 = Builder.CreateAnd(Op1, Z); 4573 return new ICmpInst(Pred, Op1, Constant::getNullValue(Op1->getType())); 4574 } 4575 } 4576 4577 { 4578 // Similar to above, but specialized for constant because invert is needed: 4579 // (X | C) == (Y | C) --> (X ^ Y) & ~C == 0 4580 Value *X, *Y; 4581 Constant *C; 4582 if (match(Op0, m_OneUse(m_Or(m_Value(X), m_Constant(C)))) && 4583 match(Op1, m_OneUse(m_Or(m_Value(Y), m_Specific(C))))) { 4584 Value *Xor = Builder.CreateXor(X, Y); 4585 Value *And = Builder.CreateAnd(Xor, ConstantExpr::getNot(C)); 4586 return new ICmpInst(Pred, And, Constant::getNullValue(And->getType())); 4587 } 4588 } 4589 4590 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 4591 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 4592 ConstantInt *Cst1; 4593 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 4594 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 4595 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 4596 match(Op1, m_ZExt(m_Value(A))))) { 4597 APInt Pow2 = Cst1->getValue() + 1; 4598 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 4599 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 4600 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 4601 } 4602 4603 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 4604 // For lshr and ashr pairs. 4605 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 4606 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 4607 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 4608 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 4609 unsigned TypeBits = Cst1->getBitWidth(); 4610 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4611 if (ShAmt < TypeBits && ShAmt != 0) { 4612 ICmpInst::Predicate NewPred = 4613 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 4614 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4615 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 4616 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 4617 } 4618 } 4619 4620 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 4621 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 4622 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 4623 unsigned TypeBits = Cst1->getBitWidth(); 4624 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4625 if (ShAmt < TypeBits && ShAmt != 0) { 4626 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4627 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 4628 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 4629 I.getName() + ".mask"); 4630 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 4631 } 4632 } 4633 4634 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 4635 // "icmp (and X, mask), cst" 4636 uint64_t ShAmt = 0; 4637 if (Op0->hasOneUse() && 4638 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 4639 match(Op1, m_ConstantInt(Cst1)) && 4640 // Only do this when A has multiple uses. This is most important to do 4641 // when it exposes other optimizations. 4642 !A->hasOneUse()) { 4643 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 4644 4645 if (ShAmt < ASize) { 4646 APInt MaskV = 4647 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 4648 MaskV <<= ShAmt; 4649 4650 APInt CmpV = Cst1->getValue().zext(ASize); 4651 CmpV <<= ShAmt; 4652 4653 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 4654 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 4655 } 4656 } 4657 4658 if (Instruction *ICmp = foldICmpIntrinsicWithIntrinsic(I)) 4659 return ICmp; 4660 4661 // Canonicalize checking for a power-of-2-or-zero value: 4662 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4663 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4664 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4665 m_Deferred(A)))) || 4666 !match(Op1, m_ZeroInt())) 4667 A = nullptr; 4668 4669 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4670 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4671 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4672 A = Op1; 4673 else if (match(Op1, 4674 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4675 A = Op0; 4676 4677 if (A) { 4678 Type *Ty = A->getType(); 4679 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4680 return Pred == ICmpInst::ICMP_EQ 4681 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4682 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4683 } 4684 4685 // Match icmp eq (trunc (lshr A, BW), (ashr (trunc A), BW-1)), which checks the 4686 // top BW/2 + 1 bits are all the same. Create "A >=s INT_MIN && A <=s INT_MAX", 4687 // which we generate as "icmp ult (add A, 2^(BW-1)), 2^BW" to skip a few steps 4688 // of instcombine. 4689 unsigned BitWidth = Op0->getType()->getScalarSizeInBits(); 4690 if (match(Op0, m_AShr(m_Trunc(m_Value(A)), m_SpecificInt(BitWidth - 1))) && 4691 match(Op1, m_Trunc(m_LShr(m_Specific(A), m_SpecificInt(BitWidth)))) && 4692 A->getType()->getScalarSizeInBits() == BitWidth * 2 && 4693 (I.getOperand(0)->hasOneUse() || I.getOperand(1)->hasOneUse())) { 4694 APInt C = APInt::getOneBitSet(BitWidth * 2, BitWidth - 1); 4695 Value *Add = Builder.CreateAdd(A, ConstantInt::get(A->getType(), C)); 4696 return new ICmpInst(Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_ULT 4697 : ICmpInst::ICMP_UGE, 4698 Add, ConstantInt::get(A->getType(), C.shl(1))); 4699 } 4700 4701 return nullptr; 4702 } 4703 4704 static Instruction *foldICmpWithTrunc(ICmpInst &ICmp, 4705 InstCombiner::BuilderTy &Builder) { 4706 ICmpInst::Predicate Pred = ICmp.getPredicate(); 4707 Value *Op0 = ICmp.getOperand(0), *Op1 = ICmp.getOperand(1); 4708 4709 // Try to canonicalize trunc + compare-to-constant into a mask + cmp. 4710 // The trunc masks high bits while the compare may effectively mask low bits. 4711 Value *X; 4712 const APInt *C; 4713 if (!match(Op0, m_OneUse(m_Trunc(m_Value(X)))) || !match(Op1, m_APInt(C))) 4714 return nullptr; 4715 4716 // This matches patterns corresponding to tests of the signbit as well as: 4717 // (trunc X) u< C --> (X & -C) == 0 (are all masked-high-bits clear?) 4718 // (trunc X) u> C --> (X & ~C) != 0 (are any masked-high-bits set?) 4719 APInt Mask; 4720 if (decomposeBitTestICmp(Op0, Op1, Pred, X, Mask, true /* WithTrunc */)) { 4721 Value *And = Builder.CreateAnd(X, Mask); 4722 Constant *Zero = ConstantInt::getNullValue(X->getType()); 4723 return new ICmpInst(Pred, And, Zero); 4724 } 4725 4726 unsigned SrcBits = X->getType()->getScalarSizeInBits(); 4727 if (Pred == ICmpInst::ICMP_ULT && C->isNegatedPowerOf2()) { 4728 // If C is a negative power-of-2 (high-bit mask): 4729 // (trunc X) u< C --> (X & C) != C (are any masked-high-bits clear?) 4730 Constant *MaskC = ConstantInt::get(X->getType(), C->zext(SrcBits)); 4731 Value *And = Builder.CreateAnd(X, MaskC); 4732 return new ICmpInst(ICmpInst::ICMP_NE, And, MaskC); 4733 } 4734 4735 if (Pred == ICmpInst::ICMP_UGT && (~*C).isPowerOf2()) { 4736 // If C is not-of-power-of-2 (one clear bit): 4737 // (trunc X) u> C --> (X & (C+1)) == C+1 (are all masked-high-bits set?) 4738 Constant *MaskC = ConstantInt::get(X->getType(), (*C + 1).zext(SrcBits)); 4739 Value *And = Builder.CreateAnd(X, MaskC); 4740 return new ICmpInst(ICmpInst::ICMP_EQ, And, MaskC); 4741 } 4742 4743 return nullptr; 4744 } 4745 4746 Instruction *InstCombinerImpl::foldICmpWithZextOrSext(ICmpInst &ICmp) { 4747 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0"); 4748 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0)); 4749 Value *X; 4750 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X)))) 4751 return nullptr; 4752 4753 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt; 4754 bool IsSignedCmp = ICmp.isSigned(); 4755 4756 // icmp Pred (ext X), (ext Y) 4757 Value *Y; 4758 if (match(ICmp.getOperand(1), m_ZExtOrSExt(m_Value(Y)))) { 4759 bool IsZext0 = isa<ZExtOperator>(ICmp.getOperand(0)); 4760 bool IsZext1 = isa<ZExtOperator>(ICmp.getOperand(1)); 4761 4762 // If we have mismatched casts, treat the zext of a non-negative source as 4763 // a sext to simulate matching casts. Otherwise, we are done. 4764 // TODO: Can we handle some predicates (equality) without non-negative? 4765 if (IsZext0 != IsZext1) { 4766 if ((IsZext0 && isKnownNonNegative(X, DL, 0, &AC, &ICmp, &DT)) || 4767 (IsZext1 && isKnownNonNegative(Y, DL, 0, &AC, &ICmp, &DT))) 4768 IsSignedExt = true; 4769 else 4770 return nullptr; 4771 } 4772 4773 // Not an extension from the same type? 4774 Type *XTy = X->getType(), *YTy = Y->getType(); 4775 if (XTy != YTy) { 4776 // One of the casts must have one use because we are creating a new cast. 4777 if (!ICmp.getOperand(0)->hasOneUse() && !ICmp.getOperand(1)->hasOneUse()) 4778 return nullptr; 4779 // Extend the narrower operand to the type of the wider operand. 4780 CastInst::CastOps CastOpcode = 4781 IsSignedExt ? Instruction::SExt : Instruction::ZExt; 4782 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits()) 4783 X = Builder.CreateCast(CastOpcode, X, YTy); 4784 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits()) 4785 Y = Builder.CreateCast(CastOpcode, Y, XTy); 4786 else 4787 return nullptr; 4788 } 4789 4790 // (zext X) == (zext Y) --> X == Y 4791 // (sext X) == (sext Y) --> X == Y 4792 if (ICmp.isEquality()) 4793 return new ICmpInst(ICmp.getPredicate(), X, Y); 4794 4795 // A signed comparison of sign extended values simplifies into a 4796 // signed comparison. 4797 if (IsSignedCmp && IsSignedExt) 4798 return new ICmpInst(ICmp.getPredicate(), X, Y); 4799 4800 // The other three cases all fold into an unsigned comparison. 4801 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y); 4802 } 4803 4804 // Below here, we are only folding a compare with constant. 4805 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4806 if (!C) 4807 return nullptr; 4808 4809 // Compute the constant that would happen if we truncated to SrcTy then 4810 // re-extended to DestTy. 4811 Type *SrcTy = CastOp0->getSrcTy(); 4812 Type *DestTy = CastOp0->getDestTy(); 4813 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4814 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy); 4815 4816 // If the re-extended constant didn't change... 4817 if (Res2 == C) { 4818 if (ICmp.isEquality()) 4819 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4820 4821 // A signed comparison of sign extended values simplifies into a 4822 // signed comparison. 4823 if (IsSignedExt && IsSignedCmp) 4824 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4825 4826 // The other three cases all fold into an unsigned comparison. 4827 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1); 4828 } 4829 4830 // The re-extended constant changed, partly changed (in the case of a vector), 4831 // or could not be determined to be equal (in the case of a constant 4832 // expression), so the constant cannot be represented in the shorter type. 4833 // All the cases that fold to true or false will have already been handled 4834 // by SimplifyICmpInst, so only deal with the tricky case. 4835 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C)) 4836 return nullptr; 4837 4838 // Is source op positive? 4839 // icmp ult (sext X), C --> icmp sgt X, -1 4840 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4841 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy)); 4842 4843 // Is source op negative? 4844 // icmp ugt (sext X), C --> icmp slt X, 0 4845 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4846 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy)); 4847 } 4848 4849 /// Handle icmp (cast x), (cast or constant). 4850 Instruction *InstCombinerImpl::foldICmpWithCastOp(ICmpInst &ICmp) { 4851 // If any operand of ICmp is a inttoptr roundtrip cast then remove it as 4852 // icmp compares only pointer's value. 4853 // icmp (inttoptr (ptrtoint p1)), p2 --> icmp p1, p2. 4854 Value *SimplifiedOp0 = simplifyIntToPtrRoundTripCast(ICmp.getOperand(0)); 4855 Value *SimplifiedOp1 = simplifyIntToPtrRoundTripCast(ICmp.getOperand(1)); 4856 if (SimplifiedOp0 || SimplifiedOp1) 4857 return new ICmpInst(ICmp.getPredicate(), 4858 SimplifiedOp0 ? SimplifiedOp0 : ICmp.getOperand(0), 4859 SimplifiedOp1 ? SimplifiedOp1 : ICmp.getOperand(1)); 4860 4861 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0)); 4862 if (!CastOp0) 4863 return nullptr; 4864 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1))) 4865 return nullptr; 4866 4867 Value *Op0Src = CastOp0->getOperand(0); 4868 Type *SrcTy = CastOp0->getSrcTy(); 4869 Type *DestTy = CastOp0->getDestTy(); 4870 4871 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4872 // integer type is the same size as the pointer type. 4873 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) { 4874 if (isa<VectorType>(SrcTy)) { 4875 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4876 DestTy = cast<VectorType>(DestTy)->getElementType(); 4877 } 4878 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4879 }; 4880 if (CastOp0->getOpcode() == Instruction::PtrToInt && 4881 CompatibleSizes(SrcTy, DestTy)) { 4882 Value *NewOp1 = nullptr; 4883 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4884 Value *PtrSrc = PtrToIntOp1->getOperand(0); 4885 if (PtrSrc->getType()->getPointerAddressSpace() == 4886 Op0Src->getType()->getPointerAddressSpace()) { 4887 NewOp1 = PtrToIntOp1->getOperand(0); 4888 // If the pointer types don't match, insert a bitcast. 4889 if (Op0Src->getType() != NewOp1->getType()) 4890 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType()); 4891 } 4892 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4893 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4894 } 4895 4896 if (NewOp1) 4897 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1); 4898 } 4899 4900 if (Instruction *R = foldICmpWithTrunc(ICmp, Builder)) 4901 return R; 4902 4903 return foldICmpWithZextOrSext(ICmp); 4904 } 4905 4906 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4907 switch (BinaryOp) { 4908 default: 4909 llvm_unreachable("Unsupported binary op"); 4910 case Instruction::Add: 4911 case Instruction::Sub: 4912 return match(RHS, m_Zero()); 4913 case Instruction::Mul: 4914 return match(RHS, m_One()); 4915 } 4916 } 4917 4918 OverflowResult 4919 InstCombinerImpl::computeOverflow(Instruction::BinaryOps BinaryOp, 4920 bool IsSigned, Value *LHS, Value *RHS, 4921 Instruction *CxtI) const { 4922 switch (BinaryOp) { 4923 default: 4924 llvm_unreachable("Unsupported binary op"); 4925 case Instruction::Add: 4926 if (IsSigned) 4927 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4928 else 4929 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4930 case Instruction::Sub: 4931 if (IsSigned) 4932 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4933 else 4934 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4935 case Instruction::Mul: 4936 if (IsSigned) 4937 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4938 else 4939 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4940 } 4941 } 4942 4943 bool InstCombinerImpl::OptimizeOverflowCheck(Instruction::BinaryOps BinaryOp, 4944 bool IsSigned, Value *LHS, 4945 Value *RHS, Instruction &OrigI, 4946 Value *&Result, 4947 Constant *&Overflow) { 4948 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4949 std::swap(LHS, RHS); 4950 4951 // If the overflow check was an add followed by a compare, the insertion point 4952 // may be pointing to the compare. We want to insert the new instructions 4953 // before the add in case there are uses of the add between the add and the 4954 // compare. 4955 Builder.SetInsertPoint(&OrigI); 4956 4957 Type *OverflowTy = Type::getInt1Ty(LHS->getContext()); 4958 if (auto *LHSTy = dyn_cast<VectorType>(LHS->getType())) 4959 OverflowTy = VectorType::get(OverflowTy, LHSTy->getElementCount()); 4960 4961 if (isNeutralValue(BinaryOp, RHS)) { 4962 Result = LHS; 4963 Overflow = ConstantInt::getFalse(OverflowTy); 4964 return true; 4965 } 4966 4967 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4968 case OverflowResult::MayOverflow: 4969 return false; 4970 case OverflowResult::AlwaysOverflowsLow: 4971 case OverflowResult::AlwaysOverflowsHigh: 4972 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4973 Result->takeName(&OrigI); 4974 Overflow = ConstantInt::getTrue(OverflowTy); 4975 return true; 4976 case OverflowResult::NeverOverflows: 4977 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4978 Result->takeName(&OrigI); 4979 Overflow = ConstantInt::getFalse(OverflowTy); 4980 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4981 if (IsSigned) 4982 Inst->setHasNoSignedWrap(); 4983 else 4984 Inst->setHasNoUnsignedWrap(); 4985 } 4986 return true; 4987 } 4988 4989 llvm_unreachable("Unexpected overflow result"); 4990 } 4991 4992 /// Recognize and process idiom involving test for multiplication 4993 /// overflow. 4994 /// 4995 /// The caller has matched a pattern of the form: 4996 /// I = cmp u (mul(zext A, zext B), V 4997 /// The function checks if this is a test for overflow and if so replaces 4998 /// multiplication with call to 'mul.with.overflow' intrinsic. 4999 /// 5000 /// \param I Compare instruction. 5001 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 5002 /// the compare instruction. Must be of integer type. 5003 /// \param OtherVal The other argument of compare instruction. 5004 /// \returns Instruction which must replace the compare instruction, NULL if no 5005 /// replacement required. 5006 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 5007 Value *OtherVal, 5008 InstCombinerImpl &IC) { 5009 // Don't bother doing this transformation for pointers, don't do it for 5010 // vectors. 5011 if (!isa<IntegerType>(MulVal->getType())) 5012 return nullptr; 5013 5014 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 5015 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 5016 auto *MulInstr = dyn_cast<Instruction>(MulVal); 5017 if (!MulInstr) 5018 return nullptr; 5019 assert(MulInstr->getOpcode() == Instruction::Mul); 5020 5021 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 5022 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 5023 assert(LHS->getOpcode() == Instruction::ZExt); 5024 assert(RHS->getOpcode() == Instruction::ZExt); 5025 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 5026 5027 // Calculate type and width of the result produced by mul.with.overflow. 5028 Type *TyA = A->getType(), *TyB = B->getType(); 5029 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 5030 WidthB = TyB->getPrimitiveSizeInBits(); 5031 unsigned MulWidth; 5032 Type *MulType; 5033 if (WidthB > WidthA) { 5034 MulWidth = WidthB; 5035 MulType = TyB; 5036 } else { 5037 MulWidth = WidthA; 5038 MulType = TyA; 5039 } 5040 5041 // In order to replace the original mul with a narrower mul.with.overflow, 5042 // all uses must ignore upper bits of the product. The number of used low 5043 // bits must be not greater than the width of mul.with.overflow. 5044 if (MulVal->hasNUsesOrMore(2)) 5045 for (User *U : MulVal->users()) { 5046 if (U == &I) 5047 continue; 5048 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 5049 // Check if truncation ignores bits above MulWidth. 5050 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 5051 if (TruncWidth > MulWidth) 5052 return nullptr; 5053 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 5054 // Check if AND ignores bits above MulWidth. 5055 if (BO->getOpcode() != Instruction::And) 5056 return nullptr; 5057 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 5058 const APInt &CVal = CI->getValue(); 5059 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 5060 return nullptr; 5061 } else { 5062 // In this case we could have the operand of the binary operation 5063 // being defined in another block, and performing the replacement 5064 // could break the dominance relation. 5065 return nullptr; 5066 } 5067 } else { 5068 // Other uses prohibit this transformation. 5069 return nullptr; 5070 } 5071 } 5072 5073 // Recognize patterns 5074 switch (I.getPredicate()) { 5075 case ICmpInst::ICMP_EQ: 5076 case ICmpInst::ICMP_NE: 5077 // Recognize pattern: 5078 // mulval = mul(zext A, zext B) 5079 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 5080 ConstantInt *CI; 5081 Value *ValToMask; 5082 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 5083 if (ValToMask != MulVal) 5084 return nullptr; 5085 const APInt &CVal = CI->getValue() + 1; 5086 if (CVal.isPowerOf2()) { 5087 unsigned MaskWidth = CVal.logBase2(); 5088 if (MaskWidth == MulWidth) 5089 break; // Recognized 5090 } 5091 } 5092 return nullptr; 5093 5094 case ICmpInst::ICMP_UGT: 5095 // Recognize pattern: 5096 // mulval = mul(zext A, zext B) 5097 // cmp ugt mulval, max 5098 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5099 APInt MaxVal = APInt::getMaxValue(MulWidth); 5100 MaxVal = MaxVal.zext(CI->getBitWidth()); 5101 if (MaxVal.eq(CI->getValue())) 5102 break; // Recognized 5103 } 5104 return nullptr; 5105 5106 case ICmpInst::ICMP_UGE: 5107 // Recognize pattern: 5108 // mulval = mul(zext A, zext B) 5109 // cmp uge mulval, max+1 5110 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5111 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 5112 if (MaxVal.eq(CI->getValue())) 5113 break; // Recognized 5114 } 5115 return nullptr; 5116 5117 case ICmpInst::ICMP_ULE: 5118 // Recognize pattern: 5119 // mulval = mul(zext A, zext B) 5120 // cmp ule mulval, max 5121 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5122 APInt MaxVal = APInt::getMaxValue(MulWidth); 5123 MaxVal = MaxVal.zext(CI->getBitWidth()); 5124 if (MaxVal.eq(CI->getValue())) 5125 break; // Recognized 5126 } 5127 return nullptr; 5128 5129 case ICmpInst::ICMP_ULT: 5130 // Recognize pattern: 5131 // mulval = mul(zext A, zext B) 5132 // cmp ule mulval, max + 1 5133 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5134 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 5135 if (MaxVal.eq(CI->getValue())) 5136 break; // Recognized 5137 } 5138 return nullptr; 5139 5140 default: 5141 return nullptr; 5142 } 5143 5144 InstCombiner::BuilderTy &Builder = IC.Builder; 5145 Builder.SetInsertPoint(MulInstr); 5146 5147 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 5148 Value *MulA = A, *MulB = B; 5149 if (WidthA < MulWidth) 5150 MulA = Builder.CreateZExt(A, MulType); 5151 if (WidthB < MulWidth) 5152 MulB = Builder.CreateZExt(B, MulType); 5153 Function *F = Intrinsic::getDeclaration( 5154 I.getModule(), Intrinsic::umul_with_overflow, MulType); 5155 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 5156 IC.addToWorklist(MulInstr); 5157 5158 // If there are uses of mul result other than the comparison, we know that 5159 // they are truncation or binary AND. Change them to use result of 5160 // mul.with.overflow and adjust properly mask/size. 5161 if (MulVal->hasNUsesOrMore(2)) { 5162 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 5163 for (User *U : make_early_inc_range(MulVal->users())) { 5164 if (U == &I || U == OtherVal) 5165 continue; 5166 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 5167 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 5168 IC.replaceInstUsesWith(*TI, Mul); 5169 else 5170 TI->setOperand(0, Mul); 5171 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 5172 assert(BO->getOpcode() == Instruction::And); 5173 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 5174 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 5175 APInt ShortMask = CI->getValue().trunc(MulWidth); 5176 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 5177 Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType()); 5178 IC.replaceInstUsesWith(*BO, Zext); 5179 } else { 5180 llvm_unreachable("Unexpected Binary operation"); 5181 } 5182 IC.addToWorklist(cast<Instruction>(U)); 5183 } 5184 } 5185 if (isa<Instruction>(OtherVal)) 5186 IC.addToWorklist(cast<Instruction>(OtherVal)); 5187 5188 // The original icmp gets replaced with the overflow value, maybe inverted 5189 // depending on predicate. 5190 bool Inverse = false; 5191 switch (I.getPredicate()) { 5192 case ICmpInst::ICMP_NE: 5193 break; 5194 case ICmpInst::ICMP_EQ: 5195 Inverse = true; 5196 break; 5197 case ICmpInst::ICMP_UGT: 5198 case ICmpInst::ICMP_UGE: 5199 if (I.getOperand(0) == MulVal) 5200 break; 5201 Inverse = true; 5202 break; 5203 case ICmpInst::ICMP_ULT: 5204 case ICmpInst::ICMP_ULE: 5205 if (I.getOperand(1) == MulVal) 5206 break; 5207 Inverse = true; 5208 break; 5209 default: 5210 llvm_unreachable("Unexpected predicate"); 5211 } 5212 if (Inverse) { 5213 Value *Res = Builder.CreateExtractValue(Call, 1); 5214 return BinaryOperator::CreateNot(Res); 5215 } 5216 5217 return ExtractValueInst::Create(Call, 1); 5218 } 5219 5220 /// When performing a comparison against a constant, it is possible that not all 5221 /// the bits in the LHS are demanded. This helper method computes the mask that 5222 /// IS demanded. 5223 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 5224 const APInt *RHS; 5225 if (!match(I.getOperand(1), m_APInt(RHS))) 5226 return APInt::getAllOnes(BitWidth); 5227 5228 // If this is a normal comparison, it demands all bits. If it is a sign bit 5229 // comparison, it only demands the sign bit. 5230 bool UnusedBit; 5231 if (InstCombiner::isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 5232 return APInt::getSignMask(BitWidth); 5233 5234 switch (I.getPredicate()) { 5235 // For a UGT comparison, we don't care about any bits that 5236 // correspond to the trailing ones of the comparand. The value of these 5237 // bits doesn't impact the outcome of the comparison, because any value 5238 // greater than the RHS must differ in a bit higher than these due to carry. 5239 case ICmpInst::ICMP_UGT: 5240 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 5241 5242 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 5243 // Any value less than the RHS must differ in a higher bit because of carries. 5244 case ICmpInst::ICMP_ULT: 5245 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 5246 5247 default: 5248 return APInt::getAllOnes(BitWidth); 5249 } 5250 } 5251 5252 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 5253 /// should be swapped. 5254 /// The decision is based on how many times these two operands are reused 5255 /// as subtract operands and their positions in those instructions. 5256 /// The rationale is that several architectures use the same instruction for 5257 /// both subtract and cmp. Thus, it is better if the order of those operands 5258 /// match. 5259 /// \return true if Op0 and Op1 should be swapped. 5260 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 5261 // Filter out pointer values as those cannot appear directly in subtract. 5262 // FIXME: we may want to go through inttoptrs or bitcasts. 5263 if (Op0->getType()->isPointerTy()) 5264 return false; 5265 // If a subtract already has the same operands as a compare, swapping would be 5266 // bad. If a subtract has the same operands as a compare but in reverse order, 5267 // then swapping is good. 5268 int GoodToSwap = 0; 5269 for (const User *U : Op0->users()) { 5270 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 5271 GoodToSwap++; 5272 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 5273 GoodToSwap--; 5274 } 5275 return GoodToSwap > 0; 5276 } 5277 5278 /// Check that one use is in the same block as the definition and all 5279 /// other uses are in blocks dominated by a given block. 5280 /// 5281 /// \param DI Definition 5282 /// \param UI Use 5283 /// \param DB Block that must dominate all uses of \p DI outside 5284 /// the parent block 5285 /// \return true when \p UI is the only use of \p DI in the parent block 5286 /// and all other uses of \p DI are in blocks dominated by \p DB. 5287 /// 5288 bool InstCombinerImpl::dominatesAllUses(const Instruction *DI, 5289 const Instruction *UI, 5290 const BasicBlock *DB) const { 5291 assert(DI && UI && "Instruction not defined\n"); 5292 // Ignore incomplete definitions. 5293 if (!DI->getParent()) 5294 return false; 5295 // DI and UI must be in the same block. 5296 if (DI->getParent() != UI->getParent()) 5297 return false; 5298 // Protect from self-referencing blocks. 5299 if (DI->getParent() == DB) 5300 return false; 5301 for (const User *U : DI->users()) { 5302 auto *Usr = cast<Instruction>(U); 5303 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 5304 return false; 5305 } 5306 return true; 5307 } 5308 5309 /// Return true when the instruction sequence within a block is select-cmp-br. 5310 static bool isChainSelectCmpBranch(const SelectInst *SI) { 5311 const BasicBlock *BB = SI->getParent(); 5312 if (!BB) 5313 return false; 5314 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 5315 if (!BI || BI->getNumSuccessors() != 2) 5316 return false; 5317 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 5318 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 5319 return false; 5320 return true; 5321 } 5322 5323 /// True when a select result is replaced by one of its operands 5324 /// in select-icmp sequence. This will eventually result in the elimination 5325 /// of the select. 5326 /// 5327 /// \param SI Select instruction 5328 /// \param Icmp Compare instruction 5329 /// \param SIOpd Operand that replaces the select 5330 /// 5331 /// Notes: 5332 /// - The replacement is global and requires dominator information 5333 /// - The caller is responsible for the actual replacement 5334 /// 5335 /// Example: 5336 /// 5337 /// entry: 5338 /// %4 = select i1 %3, %C* %0, %C* null 5339 /// %5 = icmp eq %C* %4, null 5340 /// br i1 %5, label %9, label %7 5341 /// ... 5342 /// ; <label>:7 ; preds = %entry 5343 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 5344 /// ... 5345 /// 5346 /// can be transformed to 5347 /// 5348 /// %5 = icmp eq %C* %0, null 5349 /// %6 = select i1 %3, i1 %5, i1 true 5350 /// br i1 %6, label %9, label %7 5351 /// ... 5352 /// ; <label>:7 ; preds = %entry 5353 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 5354 /// 5355 /// Similar when the first operand of the select is a constant or/and 5356 /// the compare is for not equal rather than equal. 5357 /// 5358 /// NOTE: The function is only called when the select and compare constants 5359 /// are equal, the optimization can work only for EQ predicates. This is not a 5360 /// major restriction since a NE compare should be 'normalized' to an equal 5361 /// compare, which usually happens in the combiner and test case 5362 /// select-cmp-br.ll checks for it. 5363 bool InstCombinerImpl::replacedSelectWithOperand(SelectInst *SI, 5364 const ICmpInst *Icmp, 5365 const unsigned SIOpd) { 5366 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 5367 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 5368 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 5369 // The check for the single predecessor is not the best that can be 5370 // done. But it protects efficiently against cases like when SI's 5371 // home block has two successors, Succ and Succ1, and Succ1 predecessor 5372 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 5373 // replaced can be reached on either path. So the uniqueness check 5374 // guarantees that the path all uses of SI (outside SI's parent) are on 5375 // is disjoint from all other paths out of SI. But that information 5376 // is more expensive to compute, and the trade-off here is in favor 5377 // of compile-time. It should also be noticed that we check for a single 5378 // predecessor and not only uniqueness. This to handle the situation when 5379 // Succ and Succ1 points to the same basic block. 5380 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 5381 NumSel++; 5382 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 5383 return true; 5384 } 5385 } 5386 return false; 5387 } 5388 5389 /// Try to fold the comparison based on range information we can get by checking 5390 /// whether bits are known to be zero or one in the inputs. 5391 Instruction *InstCombinerImpl::foldICmpUsingKnownBits(ICmpInst &I) { 5392 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5393 Type *Ty = Op0->getType(); 5394 ICmpInst::Predicate Pred = I.getPredicate(); 5395 5396 // Get scalar or pointer size. 5397 unsigned BitWidth = Ty->isIntOrIntVectorTy() 5398 ? Ty->getScalarSizeInBits() 5399 : DL.getPointerTypeSizeInBits(Ty->getScalarType()); 5400 5401 if (!BitWidth) 5402 return nullptr; 5403 5404 KnownBits Op0Known(BitWidth); 5405 KnownBits Op1Known(BitWidth); 5406 5407 if (SimplifyDemandedBits(&I, 0, 5408 getDemandedBitsLHSMask(I, BitWidth), 5409 Op0Known, 0)) 5410 return &I; 5411 5412 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnes(BitWidth), Op1Known, 0)) 5413 return &I; 5414 5415 // Given the known and unknown bits, compute a range that the LHS could be 5416 // in. Compute the Min, Max and RHS values based on the known bits. For the 5417 // EQ and NE we use unsigned values. 5418 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 5419 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 5420 if (I.isSigned()) { 5421 Op0Min = Op0Known.getSignedMinValue(); 5422 Op0Max = Op0Known.getSignedMaxValue(); 5423 Op1Min = Op1Known.getSignedMinValue(); 5424 Op1Max = Op1Known.getSignedMaxValue(); 5425 } else { 5426 Op0Min = Op0Known.getMinValue(); 5427 Op0Max = Op0Known.getMaxValue(); 5428 Op1Min = Op1Known.getMinValue(); 5429 Op1Max = Op1Known.getMaxValue(); 5430 } 5431 5432 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 5433 // out that the LHS or RHS is a constant. Constant fold this now, so that 5434 // code below can assume that Min != Max. 5435 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 5436 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 5437 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 5438 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 5439 5440 // Don't break up a clamp pattern -- (min(max X, Y), Z) -- by replacing a 5441 // min/max canonical compare with some other compare. That could lead to 5442 // conflict with select canonicalization and infinite looping. 5443 // FIXME: This constraint may go away if min/max intrinsics are canonical. 5444 auto isMinMaxCmp = [&](Instruction &Cmp) { 5445 if (!Cmp.hasOneUse()) 5446 return false; 5447 Value *A, *B; 5448 SelectPatternFlavor SPF = matchSelectPattern(Cmp.user_back(), A, B).Flavor; 5449 if (!SelectPatternResult::isMinOrMax(SPF)) 5450 return false; 5451 return match(Op0, m_MaxOrMin(m_Value(), m_Value())) || 5452 match(Op1, m_MaxOrMin(m_Value(), m_Value())); 5453 }; 5454 if (!isMinMaxCmp(I)) { 5455 switch (Pred) { 5456 default: 5457 break; 5458 case ICmpInst::ICMP_ULT: { 5459 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 5460 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5461 const APInt *CmpC; 5462 if (match(Op1, m_APInt(CmpC))) { 5463 // A <u C -> A == C-1 if min(A)+1 == C 5464 if (*CmpC == Op0Min + 1) 5465 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5466 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5467 // X <u C --> X == 0, if the number of zero bits in the bottom of X 5468 // exceeds the log2 of C. 5469 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 5470 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5471 Constant::getNullValue(Op1->getType())); 5472 } 5473 break; 5474 } 5475 case ICmpInst::ICMP_UGT: { 5476 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 5477 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5478 const APInt *CmpC; 5479 if (match(Op1, m_APInt(CmpC))) { 5480 // A >u C -> A == C+1 if max(a)-1 == C 5481 if (*CmpC == Op0Max - 1) 5482 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5483 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5484 // X >u C --> X != 0, if the number of zero bits in the bottom of X 5485 // exceeds the log2 of C. 5486 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 5487 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 5488 Constant::getNullValue(Op1->getType())); 5489 } 5490 break; 5491 } 5492 case ICmpInst::ICMP_SLT: { 5493 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 5494 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5495 const APInt *CmpC; 5496 if (match(Op1, m_APInt(CmpC))) { 5497 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 5498 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5499 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5500 } 5501 break; 5502 } 5503 case ICmpInst::ICMP_SGT: { 5504 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 5505 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5506 const APInt *CmpC; 5507 if (match(Op1, m_APInt(CmpC))) { 5508 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 5509 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5510 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5511 } 5512 break; 5513 } 5514 } 5515 } 5516 5517 // Based on the range information we know about the LHS, see if we can 5518 // simplify this comparison. For example, (x&4) < 8 is always true. 5519 switch (Pred) { 5520 default: 5521 llvm_unreachable("Unknown icmp opcode!"); 5522 case ICmpInst::ICMP_EQ: 5523 case ICmpInst::ICMP_NE: { 5524 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) 5525 return replaceInstUsesWith( 5526 I, ConstantInt::getBool(I.getType(), Pred == CmpInst::ICMP_NE)); 5527 5528 // If all bits are known zero except for one, then we know at most one bit 5529 // is set. If the comparison is against zero, then this is a check to see if 5530 // *that* bit is set. 5531 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 5532 if (Op1Known.isZero()) { 5533 // If the LHS is an AND with the same constant, look through it. 5534 Value *LHS = nullptr; 5535 const APInt *LHSC; 5536 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 5537 *LHSC != Op0KnownZeroInverted) 5538 LHS = Op0; 5539 5540 Value *X; 5541 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 5542 APInt ValToCheck = Op0KnownZeroInverted; 5543 Type *XTy = X->getType(); 5544 if (ValToCheck.isPowerOf2()) { 5545 // ((1 << X) & 8) == 0 -> X != 3 5546 // ((1 << X) & 8) != 0 -> X == 3 5547 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5548 auto NewPred = ICmpInst::getInversePredicate(Pred); 5549 return new ICmpInst(NewPred, X, CmpC); 5550 } else if ((++ValToCheck).isPowerOf2()) { 5551 // ((1 << X) & 7) == 0 -> X >= 3 5552 // ((1 << X) & 7) != 0 -> X < 3 5553 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5554 auto NewPred = 5555 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 5556 return new ICmpInst(NewPred, X, CmpC); 5557 } 5558 } 5559 5560 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 5561 const APInt *CI; 5562 if (Op0KnownZeroInverted.isOne() && 5563 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 5564 // ((8 >>u X) & 1) == 0 -> X != 3 5565 // ((8 >>u X) & 1) != 0 -> X == 3 5566 unsigned CmpVal = CI->countTrailingZeros(); 5567 auto NewPred = ICmpInst::getInversePredicate(Pred); 5568 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 5569 } 5570 } 5571 break; 5572 } 5573 case ICmpInst::ICMP_ULT: { 5574 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 5575 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5576 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 5577 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5578 break; 5579 } 5580 case ICmpInst::ICMP_UGT: { 5581 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 5582 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5583 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 5584 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5585 break; 5586 } 5587 case ICmpInst::ICMP_SLT: { 5588 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 5589 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5590 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 5591 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5592 break; 5593 } 5594 case ICmpInst::ICMP_SGT: { 5595 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 5596 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5597 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 5598 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5599 break; 5600 } 5601 case ICmpInst::ICMP_SGE: 5602 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 5603 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 5604 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5605 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 5606 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5607 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 5608 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5609 break; 5610 case ICmpInst::ICMP_SLE: 5611 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 5612 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 5613 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5614 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 5615 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5616 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 5617 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5618 break; 5619 case ICmpInst::ICMP_UGE: 5620 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 5621 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 5622 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5623 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 5624 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5625 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 5626 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5627 break; 5628 case ICmpInst::ICMP_ULE: 5629 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 5630 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 5631 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5632 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 5633 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5634 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 5635 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5636 break; 5637 } 5638 5639 // Turn a signed comparison into an unsigned one if both operands are known to 5640 // have the same sign. 5641 if (I.isSigned() && 5642 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 5643 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 5644 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 5645 5646 return nullptr; 5647 } 5648 5649 /// If one operand of an icmp is effectively a bool (value range of {0,1}), 5650 /// then try to reduce patterns based on that limit. 5651 static Instruction *foldICmpUsingBoolRange(ICmpInst &I, 5652 InstCombiner::BuilderTy &Builder) { 5653 Value *X, *Y; 5654 ICmpInst::Predicate Pred; 5655 5656 // X must be 0 and bool must be true for "ULT": 5657 // X <u (zext i1 Y) --> (X == 0) && Y 5658 if (match(&I, m_c_ICmp(Pred, m_Value(X), m_OneUse(m_ZExt(m_Value(Y))))) && 5659 Y->getType()->isIntOrIntVectorTy(1) && Pred == ICmpInst::ICMP_ULT) 5660 return BinaryOperator::CreateAnd(Builder.CreateIsNull(X), Y); 5661 5662 // TODO: Handle the related pattern with UGE/sext. 5663 5664 return nullptr; 5665 } 5666 5667 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 5668 InstCombiner::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 5669 Constant *C) { 5670 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 5671 "Only for relational integer predicates."); 5672 5673 Type *Type = C->getType(); 5674 bool IsSigned = ICmpInst::isSigned(Pred); 5675 5676 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred); 5677 bool WillIncrement = 5678 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT; 5679 5680 // Check if the constant operand can be safely incremented/decremented 5681 // without overflowing/underflowing. 5682 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) { 5683 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned); 5684 }; 5685 5686 Constant *SafeReplacementConstant = nullptr; 5687 if (auto *CI = dyn_cast<ConstantInt>(C)) { 5688 // Bail out if the constant can't be safely incremented/decremented. 5689 if (!ConstantIsOk(CI)) 5690 return llvm::None; 5691 } else if (auto *FVTy = dyn_cast<FixedVectorType>(Type)) { 5692 unsigned NumElts = FVTy->getNumElements(); 5693 for (unsigned i = 0; i != NumElts; ++i) { 5694 Constant *Elt = C->getAggregateElement(i); 5695 if (!Elt) 5696 return llvm::None; 5697 5698 if (isa<UndefValue>(Elt)) 5699 continue; 5700 5701 // Bail out if we can't determine if this constant is min/max or if we 5702 // know that this constant is min/max. 5703 auto *CI = dyn_cast<ConstantInt>(Elt); 5704 if (!CI || !ConstantIsOk(CI)) 5705 return llvm::None; 5706 5707 if (!SafeReplacementConstant) 5708 SafeReplacementConstant = CI; 5709 } 5710 } else { 5711 // ConstantExpr? 5712 return llvm::None; 5713 } 5714 5715 // It may not be safe to change a compare predicate in the presence of 5716 // undefined elements, so replace those elements with the first safe constant 5717 // that we found. 5718 // TODO: in case of poison, it is safe; let's replace undefs only. 5719 if (C->containsUndefOrPoisonElement()) { 5720 assert(SafeReplacementConstant && "Replacement constant not set"); 5721 C = Constant::replaceUndefsWith(C, SafeReplacementConstant); 5722 } 5723 5724 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 5725 5726 // Increment or decrement the constant. 5727 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true); 5728 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 5729 5730 return std::make_pair(NewPred, NewC); 5731 } 5732 5733 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 5734 /// it into the appropriate icmp lt or icmp gt instruction. This transform 5735 /// allows them to be folded in visitICmpInst. 5736 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 5737 ICmpInst::Predicate Pred = I.getPredicate(); 5738 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 5739 InstCombiner::isCanonicalPredicate(Pred)) 5740 return nullptr; 5741 5742 Value *Op0 = I.getOperand(0); 5743 Value *Op1 = I.getOperand(1); 5744 auto *Op1C = dyn_cast<Constant>(Op1); 5745 if (!Op1C) 5746 return nullptr; 5747 5748 auto FlippedStrictness = 5749 InstCombiner::getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 5750 if (!FlippedStrictness) 5751 return nullptr; 5752 5753 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 5754 } 5755 5756 /// If we have a comparison with a non-canonical predicate, if we can update 5757 /// all the users, invert the predicate and adjust all the users. 5758 CmpInst *InstCombinerImpl::canonicalizeICmpPredicate(CmpInst &I) { 5759 // Is the predicate already canonical? 5760 CmpInst::Predicate Pred = I.getPredicate(); 5761 if (InstCombiner::isCanonicalPredicate(Pred)) 5762 return nullptr; 5763 5764 // Can all users be adjusted to predicate inversion? 5765 if (!InstCombiner::canFreelyInvertAllUsersOf(&I, /*IgnoredUser=*/nullptr)) 5766 return nullptr; 5767 5768 // Ok, we can canonicalize comparison! 5769 // Let's first invert the comparison's predicate. 5770 I.setPredicate(CmpInst::getInversePredicate(Pred)); 5771 I.setName(I.getName() + ".not"); 5772 5773 // And, adapt users. 5774 freelyInvertAllUsersOf(&I); 5775 5776 return &I; 5777 } 5778 5779 /// Integer compare with boolean values can always be turned into bitwise ops. 5780 static Instruction *canonicalizeICmpBool(ICmpInst &I, 5781 InstCombiner::BuilderTy &Builder) { 5782 Value *A = I.getOperand(0), *B = I.getOperand(1); 5783 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 5784 5785 // A boolean compared to true/false can be simplified to Op0/true/false in 5786 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 5787 // Cases not handled by InstSimplify are always 'not' of Op0. 5788 if (match(B, m_Zero())) { 5789 switch (I.getPredicate()) { 5790 case CmpInst::ICMP_EQ: // A == 0 -> !A 5791 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 5792 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 5793 return BinaryOperator::CreateNot(A); 5794 default: 5795 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5796 } 5797 } else if (match(B, m_One())) { 5798 switch (I.getPredicate()) { 5799 case CmpInst::ICMP_NE: // A != 1 -> !A 5800 case CmpInst::ICMP_ULT: // A <u 1 -> !A 5801 case CmpInst::ICMP_SGT: // A >s -1 -> !A 5802 return BinaryOperator::CreateNot(A); 5803 default: 5804 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5805 } 5806 } 5807 5808 switch (I.getPredicate()) { 5809 default: 5810 llvm_unreachable("Invalid icmp instruction!"); 5811 case ICmpInst::ICMP_EQ: 5812 // icmp eq i1 A, B -> ~(A ^ B) 5813 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 5814 5815 case ICmpInst::ICMP_NE: 5816 // icmp ne i1 A, B -> A ^ B 5817 return BinaryOperator::CreateXor(A, B); 5818 5819 case ICmpInst::ICMP_UGT: 5820 // icmp ugt -> icmp ult 5821 std::swap(A, B); 5822 LLVM_FALLTHROUGH; 5823 case ICmpInst::ICMP_ULT: 5824 // icmp ult i1 A, B -> ~A & B 5825 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 5826 5827 case ICmpInst::ICMP_SGT: 5828 // icmp sgt -> icmp slt 5829 std::swap(A, B); 5830 LLVM_FALLTHROUGH; 5831 case ICmpInst::ICMP_SLT: 5832 // icmp slt i1 A, B -> A & ~B 5833 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 5834 5835 case ICmpInst::ICMP_UGE: 5836 // icmp uge -> icmp ule 5837 std::swap(A, B); 5838 LLVM_FALLTHROUGH; 5839 case ICmpInst::ICMP_ULE: 5840 // icmp ule i1 A, B -> ~A | B 5841 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5842 5843 case ICmpInst::ICMP_SGE: 5844 // icmp sge -> icmp sle 5845 std::swap(A, B); 5846 LLVM_FALLTHROUGH; 5847 case ICmpInst::ICMP_SLE: 5848 // icmp sle i1 A, B -> A | ~B 5849 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5850 } 5851 } 5852 5853 // Transform pattern like: 5854 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5855 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5856 // Into: 5857 // (X l>> Y) != 0 5858 // (X l>> Y) == 0 5859 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5860 InstCombiner::BuilderTy &Builder) { 5861 ICmpInst::Predicate Pred, NewPred; 5862 Value *X, *Y; 5863 if (match(&Cmp, 5864 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5865 switch (Pred) { 5866 case ICmpInst::ICMP_ULE: 5867 NewPred = ICmpInst::ICMP_NE; 5868 break; 5869 case ICmpInst::ICMP_UGT: 5870 NewPred = ICmpInst::ICMP_EQ; 5871 break; 5872 default: 5873 return nullptr; 5874 } 5875 } else if (match(&Cmp, m_c_ICmp(Pred, 5876 m_OneUse(m_CombineOr( 5877 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5878 m_Add(m_Shl(m_One(), m_Value(Y)), 5879 m_AllOnes()))), 5880 m_Value(X)))) { 5881 // The variant with 'add' is not canonical, (the variant with 'not' is) 5882 // we only get it because it has extra uses, and can't be canonicalized, 5883 5884 switch (Pred) { 5885 case ICmpInst::ICMP_ULT: 5886 NewPred = ICmpInst::ICMP_NE; 5887 break; 5888 case ICmpInst::ICMP_UGE: 5889 NewPred = ICmpInst::ICMP_EQ; 5890 break; 5891 default: 5892 return nullptr; 5893 } 5894 } else 5895 return nullptr; 5896 5897 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5898 Constant *Zero = Constant::getNullValue(NewX->getType()); 5899 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5900 } 5901 5902 static Instruction *foldVectorCmp(CmpInst &Cmp, 5903 InstCombiner::BuilderTy &Builder) { 5904 const CmpInst::Predicate Pred = Cmp.getPredicate(); 5905 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5906 Value *V1, *V2; 5907 ArrayRef<int> M; 5908 if (!match(LHS, m_Shuffle(m_Value(V1), m_Undef(), m_Mask(M)))) 5909 return nullptr; 5910 5911 // If both arguments of the cmp are shuffles that use the same mask and 5912 // shuffle within a single vector, move the shuffle after the cmp: 5913 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5914 Type *V1Ty = V1->getType(); 5915 if (match(RHS, m_Shuffle(m_Value(V2), m_Undef(), m_SpecificMask(M))) && 5916 V1Ty == V2->getType() && (LHS->hasOneUse() || RHS->hasOneUse())) { 5917 Value *NewCmp = Builder.CreateCmp(Pred, V1, V2); 5918 return new ShuffleVectorInst(NewCmp, M); 5919 } 5920 5921 // Try to canonicalize compare with splatted operand and splat constant. 5922 // TODO: We could generalize this for more than splats. See/use the code in 5923 // InstCombiner::foldVectorBinop(). 5924 Constant *C; 5925 if (!LHS->hasOneUse() || !match(RHS, m_Constant(C))) 5926 return nullptr; 5927 5928 // Length-changing splats are ok, so adjust the constants as needed: 5929 // cmp (shuffle V1, M), C --> shuffle (cmp V1, C'), M 5930 Constant *ScalarC = C->getSplatValue(/* AllowUndefs */ true); 5931 int MaskSplatIndex; 5932 if (ScalarC && match(M, m_SplatOrUndefMask(MaskSplatIndex))) { 5933 // We allow undefs in matching, but this transform removes those for safety. 5934 // Demanded elements analysis should be able to recover some/all of that. 5935 C = ConstantVector::getSplat(cast<VectorType>(V1Ty)->getElementCount(), 5936 ScalarC); 5937 SmallVector<int, 8> NewM(M.size(), MaskSplatIndex); 5938 Value *NewCmp = Builder.CreateCmp(Pred, V1, C); 5939 return new ShuffleVectorInst(NewCmp, NewM); 5940 } 5941 5942 return nullptr; 5943 } 5944 5945 // extract(uadd.with.overflow(A, B), 0) ult A 5946 // -> extract(uadd.with.overflow(A, B), 1) 5947 static Instruction *foldICmpOfUAddOv(ICmpInst &I) { 5948 CmpInst::Predicate Pred = I.getPredicate(); 5949 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5950 5951 Value *UAddOv; 5952 Value *A, *B; 5953 auto UAddOvResultPat = m_ExtractValue<0>( 5954 m_Intrinsic<Intrinsic::uadd_with_overflow>(m_Value(A), m_Value(B))); 5955 if (match(Op0, UAddOvResultPat) && 5956 ((Pred == ICmpInst::ICMP_ULT && (Op1 == A || Op1 == B)) || 5957 (Pred == ICmpInst::ICMP_EQ && match(Op1, m_ZeroInt()) && 5958 (match(A, m_One()) || match(B, m_One()))) || 5959 (Pred == ICmpInst::ICMP_NE && match(Op1, m_AllOnes()) && 5960 (match(A, m_AllOnes()) || match(B, m_AllOnes()))))) 5961 // extract(uadd.with.overflow(A, B), 0) < A 5962 // extract(uadd.with.overflow(A, 1), 0) == 0 5963 // extract(uadd.with.overflow(A, -1), 0) != -1 5964 UAddOv = cast<ExtractValueInst>(Op0)->getAggregateOperand(); 5965 else if (match(Op1, UAddOvResultPat) && 5966 Pred == ICmpInst::ICMP_UGT && (Op0 == A || Op0 == B)) 5967 // A > extract(uadd.with.overflow(A, B), 0) 5968 UAddOv = cast<ExtractValueInst>(Op1)->getAggregateOperand(); 5969 else 5970 return nullptr; 5971 5972 return ExtractValueInst::Create(UAddOv, 1); 5973 } 5974 5975 static Instruction *foldICmpInvariantGroup(ICmpInst &I) { 5976 if (!I.getOperand(0)->getType()->isPointerTy() || 5977 NullPointerIsDefined( 5978 I.getParent()->getParent(), 5979 I.getOperand(0)->getType()->getPointerAddressSpace())) { 5980 return nullptr; 5981 } 5982 Instruction *Op; 5983 if (match(I.getOperand(0), m_Instruction(Op)) && 5984 match(I.getOperand(1), m_Zero()) && 5985 Op->isLaunderOrStripInvariantGroup()) { 5986 return ICmpInst::Create(Instruction::ICmp, I.getPredicate(), 5987 Op->getOperand(0), I.getOperand(1)); 5988 } 5989 return nullptr; 5990 } 5991 5992 /// This function folds patterns produced by lowering of reduce idioms, such as 5993 /// llvm.vector.reduce.and which are lowered into instruction chains. This code 5994 /// attempts to generate fewer number of scalar comparisons instead of vector 5995 /// comparisons when possible. 5996 static Instruction *foldReductionIdiom(ICmpInst &I, 5997 InstCombiner::BuilderTy &Builder, 5998 const DataLayout &DL) { 5999 if (I.getType()->isVectorTy()) 6000 return nullptr; 6001 ICmpInst::Predicate OuterPred, InnerPred; 6002 Value *LHS, *RHS; 6003 6004 // Match lowering of @llvm.vector.reduce.and. Turn 6005 /// %vec_ne = icmp ne <8 x i8> %lhs, %rhs 6006 /// %scalar_ne = bitcast <8 x i1> %vec_ne to i8 6007 /// %res = icmp <pred> i8 %scalar_ne, 0 6008 /// 6009 /// into 6010 /// 6011 /// %lhs.scalar = bitcast <8 x i8> %lhs to i64 6012 /// %rhs.scalar = bitcast <8 x i8> %rhs to i64 6013 /// %res = icmp <pred> i64 %lhs.scalar, %rhs.scalar 6014 /// 6015 /// for <pred> in {ne, eq}. 6016 if (!match(&I, m_ICmp(OuterPred, 6017 m_OneUse(m_BitCast(m_OneUse( 6018 m_ICmp(InnerPred, m_Value(LHS), m_Value(RHS))))), 6019 m_Zero()))) 6020 return nullptr; 6021 auto *LHSTy = dyn_cast<FixedVectorType>(LHS->getType()); 6022 if (!LHSTy || !LHSTy->getElementType()->isIntegerTy()) 6023 return nullptr; 6024 unsigned NumBits = 6025 LHSTy->getNumElements() * LHSTy->getElementType()->getIntegerBitWidth(); 6026 // TODO: Relax this to "not wider than max legal integer type"? 6027 if (!DL.isLegalInteger(NumBits)) 6028 return nullptr; 6029 6030 if (ICmpInst::isEquality(OuterPred) && InnerPred == ICmpInst::ICMP_NE) { 6031 auto *ScalarTy = Builder.getIntNTy(NumBits); 6032 LHS = Builder.CreateBitCast(LHS, ScalarTy, LHS->getName() + ".scalar"); 6033 RHS = Builder.CreateBitCast(RHS, ScalarTy, RHS->getName() + ".scalar"); 6034 return ICmpInst::Create(Instruction::ICmp, OuterPred, LHS, RHS, 6035 I.getName()); 6036 } 6037 6038 return nullptr; 6039 } 6040 6041 Instruction *InstCombinerImpl::visitICmpInst(ICmpInst &I) { 6042 bool Changed = false; 6043 const SimplifyQuery Q = SQ.getWithInstruction(&I); 6044 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6045 unsigned Op0Cplxity = getComplexity(Op0); 6046 unsigned Op1Cplxity = getComplexity(Op1); 6047 6048 /// Orders the operands of the compare so that they are listed from most 6049 /// complex to least complex. This puts constants before unary operators, 6050 /// before binary operators. 6051 if (Op0Cplxity < Op1Cplxity || 6052 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 6053 I.swapOperands(); 6054 std::swap(Op0, Op1); 6055 Changed = true; 6056 } 6057 6058 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q)) 6059 return replaceInstUsesWith(I, V); 6060 6061 // Comparing -val or val with non-zero is the same as just comparing val 6062 // ie, abs(val) != 0 -> val != 0 6063 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 6064 Value *Cond, *SelectTrue, *SelectFalse; 6065 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 6066 m_Value(SelectFalse)))) { 6067 if (Value *V = dyn_castNegVal(SelectTrue)) { 6068 if (V == SelectFalse) 6069 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 6070 } 6071 else if (Value *V = dyn_castNegVal(SelectFalse)) { 6072 if (V == SelectTrue) 6073 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 6074 } 6075 } 6076 } 6077 6078 if (Op0->getType()->isIntOrIntVectorTy(1)) 6079 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 6080 return Res; 6081 6082 if (Instruction *Res = canonicalizeCmpWithConstant(I)) 6083 return Res; 6084 6085 if (Instruction *Res = canonicalizeICmpPredicate(I)) 6086 return Res; 6087 6088 if (Instruction *Res = foldICmpWithConstant(I)) 6089 return Res; 6090 6091 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 6092 return Res; 6093 6094 if (Instruction *Res = foldICmpUsingBoolRange(I, Builder)) 6095 return Res; 6096 6097 if (Instruction *Res = foldICmpUsingKnownBits(I)) 6098 return Res; 6099 6100 // Test if the ICmpInst instruction is used exclusively by a select as 6101 // part of a minimum or maximum operation. If so, refrain from doing 6102 // any other folding. This helps out other analyses which understand 6103 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6104 // and CodeGen. And in this case, at least one of the comparison 6105 // operands has at least one user besides the compare (the select), 6106 // which would often largely negate the benefit of folding anyway. 6107 // 6108 // Do the same for the other patterns recognized by matchSelectPattern. 6109 if (I.hasOneUse()) 6110 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6111 Value *A, *B; 6112 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6113 if (SPR.Flavor != SPF_UNKNOWN) 6114 return nullptr; 6115 } 6116 6117 // Do this after checking for min/max to prevent infinite looping. 6118 if (Instruction *Res = foldICmpWithZero(I)) 6119 return Res; 6120 6121 // FIXME: We only do this after checking for min/max to prevent infinite 6122 // looping caused by a reverse canonicalization of these patterns for min/max. 6123 // FIXME: The organization of folds is a mess. These would naturally go into 6124 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 6125 // down here after the min/max restriction. 6126 ICmpInst::Predicate Pred = I.getPredicate(); 6127 const APInt *C; 6128 if (match(Op1, m_APInt(C))) { 6129 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 6130 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 6131 Constant *Zero = Constant::getNullValue(Op0->getType()); 6132 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 6133 } 6134 6135 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 6136 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 6137 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 6138 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 6139 } 6140 } 6141 6142 // The folds in here may rely on wrapping flags and special constants, so 6143 // they can break up min/max idioms in some cases but not seemingly similar 6144 // patterns. 6145 // FIXME: It may be possible to enhance select folding to make this 6146 // unnecessary. It may also be moot if we canonicalize to min/max 6147 // intrinsics. 6148 if (Instruction *Res = foldICmpBinOp(I, Q)) 6149 return Res; 6150 6151 if (Instruction *Res = foldICmpInstWithConstant(I)) 6152 return Res; 6153 6154 // Try to match comparison as a sign bit test. Intentionally do this after 6155 // foldICmpInstWithConstant() to potentially let other folds to happen first. 6156 if (Instruction *New = foldSignBitTest(I)) 6157 return New; 6158 6159 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 6160 return Res; 6161 6162 // Try to optimize 'icmp GEP, P' or 'icmp P, GEP'. 6163 if (auto *GEP = dyn_cast<GEPOperator>(Op0)) 6164 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 6165 return NI; 6166 if (auto *GEP = dyn_cast<GEPOperator>(Op1)) 6167 if (Instruction *NI = foldGEPICmp(GEP, Op0, I.getSwappedPredicate(), I)) 6168 return NI; 6169 6170 if (auto *SI = dyn_cast<SelectInst>(Op0)) 6171 if (Instruction *NI = foldSelectICmp(I.getPredicate(), SI, Op1, I)) 6172 return NI; 6173 if (auto *SI = dyn_cast<SelectInst>(Op1)) 6174 if (Instruction *NI = foldSelectICmp(I.getSwappedPredicate(), SI, Op0, I)) 6175 return NI; 6176 6177 // Try to optimize equality comparisons against alloca-based pointers. 6178 if (Op0->getType()->isPointerTy() && I.isEquality()) { 6179 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 6180 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op0))) 6181 if (Instruction *New = foldAllocaCmp(I, Alloca)) 6182 return New; 6183 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op1))) 6184 if (Instruction *New = foldAllocaCmp(I, Alloca)) 6185 return New; 6186 } 6187 6188 if (Instruction *Res = foldICmpBitCast(I)) 6189 return Res; 6190 6191 // TODO: Hoist this above the min/max bailout. 6192 if (Instruction *R = foldICmpWithCastOp(I)) 6193 return R; 6194 6195 if (Instruction *Res = foldICmpWithMinMax(I)) 6196 return Res; 6197 6198 { 6199 Value *A, *B; 6200 // Transform (A & ~B) == 0 --> (A & B) != 0 6201 // and (A & ~B) != 0 --> (A & B) == 0 6202 // if A is a power of 2. 6203 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 6204 match(Op1, m_Zero()) && 6205 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 6206 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 6207 Op1); 6208 6209 // ~X < ~Y --> Y < X 6210 // ~X < C --> X > ~C 6211 if (match(Op0, m_Not(m_Value(A)))) { 6212 if (match(Op1, m_Not(m_Value(B)))) 6213 return new ICmpInst(I.getPredicate(), B, A); 6214 6215 const APInt *C; 6216 if (match(Op1, m_APInt(C))) 6217 return new ICmpInst(I.getSwappedPredicate(), A, 6218 ConstantInt::get(Op1->getType(), ~(*C))); 6219 } 6220 6221 Instruction *AddI = nullptr; 6222 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 6223 m_Instruction(AddI))) && 6224 isa<IntegerType>(A->getType())) { 6225 Value *Result; 6226 Constant *Overflow; 6227 // m_UAddWithOverflow can match patterns that do not include an explicit 6228 // "add" instruction, so check the opcode of the matched op. 6229 if (AddI->getOpcode() == Instruction::Add && 6230 OptimizeOverflowCheck(Instruction::Add, /*Signed*/ false, A, B, *AddI, 6231 Result, Overflow)) { 6232 replaceInstUsesWith(*AddI, Result); 6233 eraseInstFromFunction(*AddI); 6234 return replaceInstUsesWith(I, Overflow); 6235 } 6236 } 6237 6238 // (zext a) * (zext b) --> llvm.umul.with.overflow. 6239 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 6240 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 6241 return R; 6242 } 6243 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 6244 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 6245 return R; 6246 } 6247 } 6248 6249 if (Instruction *Res = foldICmpEquality(I)) 6250 return Res; 6251 6252 if (Instruction *Res = foldICmpOfUAddOv(I)) 6253 return Res; 6254 6255 // The 'cmpxchg' instruction returns an aggregate containing the old value and 6256 // an i1 which indicates whether or not we successfully did the swap. 6257 // 6258 // Replace comparisons between the old value and the expected value with the 6259 // indicator that 'cmpxchg' returns. 6260 // 6261 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 6262 // spuriously fail. In those cases, the old value may equal the expected 6263 // value but it is possible for the swap to not occur. 6264 if (I.getPredicate() == ICmpInst::ICMP_EQ) 6265 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 6266 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 6267 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 6268 !ACXI->isWeak()) 6269 return ExtractValueInst::Create(ACXI, 1); 6270 6271 { 6272 Value *X; 6273 const APInt *C; 6274 // icmp X+Cst, X 6275 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 6276 return foldICmpAddOpConst(X, *C, I.getPredicate()); 6277 6278 // icmp X, X+Cst 6279 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 6280 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 6281 } 6282 6283 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 6284 return Res; 6285 6286 if (I.getType()->isVectorTy()) 6287 if (Instruction *Res = foldVectorCmp(I, Builder)) 6288 return Res; 6289 6290 if (Instruction *Res = foldICmpInvariantGroup(I)) 6291 return Res; 6292 6293 if (Instruction *Res = foldReductionIdiom(I, Builder, DL)) 6294 return Res; 6295 6296 return Changed ? &I : nullptr; 6297 } 6298 6299 /// Fold fcmp ([us]itofp x, cst) if possible. 6300 Instruction *InstCombinerImpl::foldFCmpIntToFPConst(FCmpInst &I, 6301 Instruction *LHSI, 6302 Constant *RHSC) { 6303 if (!isa<ConstantFP>(RHSC)) return nullptr; 6304 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 6305 6306 // Get the width of the mantissa. We don't want to hack on conversions that 6307 // might lose information from the integer, e.g. "i64 -> float" 6308 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 6309 if (MantissaWidth == -1) return nullptr; // Unknown. 6310 6311 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 6312 6313 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 6314 6315 if (I.isEquality()) { 6316 FCmpInst::Predicate P = I.getPredicate(); 6317 bool IsExact = false; 6318 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 6319 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 6320 6321 // If the floating point constant isn't an integer value, we know if we will 6322 // ever compare equal / not equal to it. 6323 if (!IsExact) { 6324 // TODO: Can never be -0.0 and other non-representable values 6325 APFloat RHSRoundInt(RHS); 6326 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 6327 if (RHS != RHSRoundInt) { 6328 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 6329 return replaceInstUsesWith(I, Builder.getFalse()); 6330 6331 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 6332 return replaceInstUsesWith(I, Builder.getTrue()); 6333 } 6334 } 6335 6336 // TODO: If the constant is exactly representable, is it always OK to do 6337 // equality compares as integer? 6338 } 6339 6340 // Check to see that the input is converted from an integer type that is small 6341 // enough that preserves all bits. TODO: check here for "known" sign bits. 6342 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 6343 unsigned InputSize = IntTy->getScalarSizeInBits(); 6344 6345 // Following test does NOT adjust InputSize downwards for signed inputs, 6346 // because the most negative value still requires all the mantissa bits 6347 // to distinguish it from one less than that value. 6348 if ((int)InputSize > MantissaWidth) { 6349 // Conversion would lose accuracy. Check if loss can impact comparison. 6350 int Exp = ilogb(RHS); 6351 if (Exp == APFloat::IEK_Inf) { 6352 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 6353 if (MaxExponent < (int)InputSize - !LHSUnsigned) 6354 // Conversion could create infinity. 6355 return nullptr; 6356 } else { 6357 // Note that if RHS is zero or NaN, then Exp is negative 6358 // and first condition is trivially false. 6359 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 6360 // Conversion could affect comparison. 6361 return nullptr; 6362 } 6363 } 6364 6365 // Otherwise, we can potentially simplify the comparison. We know that it 6366 // will always come through as an integer value and we know the constant is 6367 // not a NAN (it would have been previously simplified). 6368 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 6369 6370 ICmpInst::Predicate Pred; 6371 switch (I.getPredicate()) { 6372 default: llvm_unreachable("Unexpected predicate!"); 6373 case FCmpInst::FCMP_UEQ: 6374 case FCmpInst::FCMP_OEQ: 6375 Pred = ICmpInst::ICMP_EQ; 6376 break; 6377 case FCmpInst::FCMP_UGT: 6378 case FCmpInst::FCMP_OGT: 6379 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 6380 break; 6381 case FCmpInst::FCMP_UGE: 6382 case FCmpInst::FCMP_OGE: 6383 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 6384 break; 6385 case FCmpInst::FCMP_ULT: 6386 case FCmpInst::FCMP_OLT: 6387 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 6388 break; 6389 case FCmpInst::FCMP_ULE: 6390 case FCmpInst::FCMP_OLE: 6391 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 6392 break; 6393 case FCmpInst::FCMP_UNE: 6394 case FCmpInst::FCMP_ONE: 6395 Pred = ICmpInst::ICMP_NE; 6396 break; 6397 case FCmpInst::FCMP_ORD: 6398 return replaceInstUsesWith(I, Builder.getTrue()); 6399 case FCmpInst::FCMP_UNO: 6400 return replaceInstUsesWith(I, Builder.getFalse()); 6401 } 6402 6403 // Now we know that the APFloat is a normal number, zero or inf. 6404 6405 // See if the FP constant is too large for the integer. For example, 6406 // comparing an i8 to 300.0. 6407 unsigned IntWidth = IntTy->getScalarSizeInBits(); 6408 6409 if (!LHSUnsigned) { 6410 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 6411 // and large values. 6412 APFloat SMax(RHS.getSemantics()); 6413 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 6414 APFloat::rmNearestTiesToEven); 6415 if (SMax < RHS) { // smax < 13123.0 6416 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 6417 Pred == ICmpInst::ICMP_SLE) 6418 return replaceInstUsesWith(I, Builder.getTrue()); 6419 return replaceInstUsesWith(I, Builder.getFalse()); 6420 } 6421 } else { 6422 // If the RHS value is > UnsignedMax, fold the comparison. This handles 6423 // +INF and large values. 6424 APFloat UMax(RHS.getSemantics()); 6425 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 6426 APFloat::rmNearestTiesToEven); 6427 if (UMax < RHS) { // umax < 13123.0 6428 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 6429 Pred == ICmpInst::ICMP_ULE) 6430 return replaceInstUsesWith(I, Builder.getTrue()); 6431 return replaceInstUsesWith(I, Builder.getFalse()); 6432 } 6433 } 6434 6435 if (!LHSUnsigned) { 6436 // See if the RHS value is < SignedMin. 6437 APFloat SMin(RHS.getSemantics()); 6438 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 6439 APFloat::rmNearestTiesToEven); 6440 if (SMin > RHS) { // smin > 12312.0 6441 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 6442 Pred == ICmpInst::ICMP_SGE) 6443 return replaceInstUsesWith(I, Builder.getTrue()); 6444 return replaceInstUsesWith(I, Builder.getFalse()); 6445 } 6446 } else { 6447 // See if the RHS value is < UnsignedMin. 6448 APFloat UMin(RHS.getSemantics()); 6449 UMin.convertFromAPInt(APInt::getMinValue(IntWidth), false, 6450 APFloat::rmNearestTiesToEven); 6451 if (UMin > RHS) { // umin > 12312.0 6452 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 6453 Pred == ICmpInst::ICMP_UGE) 6454 return replaceInstUsesWith(I, Builder.getTrue()); 6455 return replaceInstUsesWith(I, Builder.getFalse()); 6456 } 6457 } 6458 6459 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 6460 // [0, UMAX], but it may still be fractional. See if it is fractional by 6461 // casting the FP value to the integer value and back, checking for equality. 6462 // Don't do this for zero, because -0.0 is not fractional. 6463 Constant *RHSInt = LHSUnsigned 6464 ? ConstantExpr::getFPToUI(RHSC, IntTy) 6465 : ConstantExpr::getFPToSI(RHSC, IntTy); 6466 if (!RHS.isZero()) { 6467 bool Equal = LHSUnsigned 6468 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 6469 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 6470 if (!Equal) { 6471 // If we had a comparison against a fractional value, we have to adjust 6472 // the compare predicate and sometimes the value. RHSC is rounded towards 6473 // zero at this point. 6474 switch (Pred) { 6475 default: llvm_unreachable("Unexpected integer comparison!"); 6476 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 6477 return replaceInstUsesWith(I, Builder.getTrue()); 6478 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 6479 return replaceInstUsesWith(I, Builder.getFalse()); 6480 case ICmpInst::ICMP_ULE: 6481 // (float)int <= 4.4 --> int <= 4 6482 // (float)int <= -4.4 --> false 6483 if (RHS.isNegative()) 6484 return replaceInstUsesWith(I, Builder.getFalse()); 6485 break; 6486 case ICmpInst::ICMP_SLE: 6487 // (float)int <= 4.4 --> int <= 4 6488 // (float)int <= -4.4 --> int < -4 6489 if (RHS.isNegative()) 6490 Pred = ICmpInst::ICMP_SLT; 6491 break; 6492 case ICmpInst::ICMP_ULT: 6493 // (float)int < -4.4 --> false 6494 // (float)int < 4.4 --> int <= 4 6495 if (RHS.isNegative()) 6496 return replaceInstUsesWith(I, Builder.getFalse()); 6497 Pred = ICmpInst::ICMP_ULE; 6498 break; 6499 case ICmpInst::ICMP_SLT: 6500 // (float)int < -4.4 --> int < -4 6501 // (float)int < 4.4 --> int <= 4 6502 if (!RHS.isNegative()) 6503 Pred = ICmpInst::ICMP_SLE; 6504 break; 6505 case ICmpInst::ICMP_UGT: 6506 // (float)int > 4.4 --> int > 4 6507 // (float)int > -4.4 --> true 6508 if (RHS.isNegative()) 6509 return replaceInstUsesWith(I, Builder.getTrue()); 6510 break; 6511 case ICmpInst::ICMP_SGT: 6512 // (float)int > 4.4 --> int > 4 6513 // (float)int > -4.4 --> int >= -4 6514 if (RHS.isNegative()) 6515 Pred = ICmpInst::ICMP_SGE; 6516 break; 6517 case ICmpInst::ICMP_UGE: 6518 // (float)int >= -4.4 --> true 6519 // (float)int >= 4.4 --> int > 4 6520 if (RHS.isNegative()) 6521 return replaceInstUsesWith(I, Builder.getTrue()); 6522 Pred = ICmpInst::ICMP_UGT; 6523 break; 6524 case ICmpInst::ICMP_SGE: 6525 // (float)int >= -4.4 --> int >= -4 6526 // (float)int >= 4.4 --> int > 4 6527 if (!RHS.isNegative()) 6528 Pred = ICmpInst::ICMP_SGT; 6529 break; 6530 } 6531 } 6532 } 6533 6534 // Lower this FP comparison into an appropriate integer version of the 6535 // comparison. 6536 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 6537 } 6538 6539 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 6540 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 6541 Constant *RHSC) { 6542 // When C is not 0.0 and infinities are not allowed: 6543 // (C / X) < 0.0 is a sign-bit test of X 6544 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 6545 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 6546 // 6547 // Proof: 6548 // Multiply (C / X) < 0.0 by X * X / C. 6549 // - X is non zero, if it is the flag 'ninf' is violated. 6550 // - C defines the sign of X * X * C. Thus it also defines whether to swap 6551 // the predicate. C is also non zero by definition. 6552 // 6553 // Thus X * X / C is non zero and the transformation is valid. [qed] 6554 6555 FCmpInst::Predicate Pred = I.getPredicate(); 6556 6557 // Check that predicates are valid. 6558 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 6559 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 6560 return nullptr; 6561 6562 // Check that RHS operand is zero. 6563 if (!match(RHSC, m_AnyZeroFP())) 6564 return nullptr; 6565 6566 // Check fastmath flags ('ninf'). 6567 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 6568 return nullptr; 6569 6570 // Check the properties of the dividend. It must not be zero to avoid a 6571 // division by zero (see Proof). 6572 const APFloat *C; 6573 if (!match(LHSI->getOperand(0), m_APFloat(C))) 6574 return nullptr; 6575 6576 if (C->isZero()) 6577 return nullptr; 6578 6579 // Get swapped predicate if necessary. 6580 if (C->isNegative()) 6581 Pred = I.getSwappedPredicate(); 6582 6583 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 6584 } 6585 6586 /// Optimize fabs(X) compared with zero. 6587 static Instruction *foldFabsWithFcmpZero(FCmpInst &I, InstCombinerImpl &IC) { 6588 Value *X; 6589 if (!match(I.getOperand(0), m_FAbs(m_Value(X))) || 6590 !match(I.getOperand(1), m_PosZeroFP())) 6591 return nullptr; 6592 6593 auto replacePredAndOp0 = [&IC](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 6594 I->setPredicate(P); 6595 return IC.replaceOperand(*I, 0, X); 6596 }; 6597 6598 switch (I.getPredicate()) { 6599 case FCmpInst::FCMP_UGE: 6600 case FCmpInst::FCMP_OLT: 6601 // fabs(X) >= 0.0 --> true 6602 // fabs(X) < 0.0 --> false 6603 llvm_unreachable("fcmp should have simplified"); 6604 6605 case FCmpInst::FCMP_OGT: 6606 // fabs(X) > 0.0 --> X != 0.0 6607 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 6608 6609 case FCmpInst::FCMP_UGT: 6610 // fabs(X) u> 0.0 --> X u!= 0.0 6611 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 6612 6613 case FCmpInst::FCMP_OLE: 6614 // fabs(X) <= 0.0 --> X == 0.0 6615 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 6616 6617 case FCmpInst::FCMP_ULE: 6618 // fabs(X) u<= 0.0 --> X u== 0.0 6619 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 6620 6621 case FCmpInst::FCMP_OGE: 6622 // fabs(X) >= 0.0 --> !isnan(X) 6623 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6624 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 6625 6626 case FCmpInst::FCMP_ULT: 6627 // fabs(X) u< 0.0 --> isnan(X) 6628 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6629 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 6630 6631 case FCmpInst::FCMP_OEQ: 6632 case FCmpInst::FCMP_UEQ: 6633 case FCmpInst::FCMP_ONE: 6634 case FCmpInst::FCMP_UNE: 6635 case FCmpInst::FCMP_ORD: 6636 case FCmpInst::FCMP_UNO: 6637 // Look through the fabs() because it doesn't change anything but the sign. 6638 // fabs(X) == 0.0 --> X == 0.0, 6639 // fabs(X) != 0.0 --> X != 0.0 6640 // isnan(fabs(X)) --> isnan(X) 6641 // !isnan(fabs(X) --> !isnan(X) 6642 return replacePredAndOp0(&I, I.getPredicate(), X); 6643 6644 default: 6645 return nullptr; 6646 } 6647 } 6648 6649 static Instruction *foldFCmpFNegCommonOp(FCmpInst &I) { 6650 CmpInst::Predicate Pred = I.getPredicate(); 6651 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6652 6653 // Canonicalize fneg as Op1. 6654 if (match(Op0, m_FNeg(m_Value())) && !match(Op1, m_FNeg(m_Value()))) { 6655 std::swap(Op0, Op1); 6656 Pred = I.getSwappedPredicate(); 6657 } 6658 6659 if (!match(Op1, m_FNeg(m_Specific(Op0)))) 6660 return nullptr; 6661 6662 // Replace the negated operand with 0.0: 6663 // fcmp Pred Op0, -Op0 --> fcmp Pred Op0, 0.0 6664 Constant *Zero = ConstantFP::getNullValue(Op0->getType()); 6665 return new FCmpInst(Pred, Op0, Zero, "", &I); 6666 } 6667 6668 Instruction *InstCombinerImpl::visitFCmpInst(FCmpInst &I) { 6669 bool Changed = false; 6670 6671 /// Orders the operands of the compare so that they are listed from most 6672 /// complex to least complex. This puts constants before unary operators, 6673 /// before binary operators. 6674 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 6675 I.swapOperands(); 6676 Changed = true; 6677 } 6678 6679 const CmpInst::Predicate Pred = I.getPredicate(); 6680 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6681 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 6682 SQ.getWithInstruction(&I))) 6683 return replaceInstUsesWith(I, V); 6684 6685 // Simplify 'fcmp pred X, X' 6686 Type *OpType = Op0->getType(); 6687 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 6688 if (Op0 == Op1) { 6689 switch (Pred) { 6690 default: break; 6691 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 6692 case FCmpInst::FCMP_ULT: // True if unordered or less than 6693 case FCmpInst::FCMP_UGT: // True if unordered or greater than 6694 case FCmpInst::FCMP_UNE: // True if unordered or not equal 6695 // Canonicalize these to be 'fcmp uno %X, 0.0'. 6696 I.setPredicate(FCmpInst::FCMP_UNO); 6697 I.setOperand(1, Constant::getNullValue(OpType)); 6698 return &I; 6699 6700 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 6701 case FCmpInst::FCMP_OEQ: // True if ordered and equal 6702 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 6703 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 6704 // Canonicalize these to be 'fcmp ord %X, 0.0'. 6705 I.setPredicate(FCmpInst::FCMP_ORD); 6706 I.setOperand(1, Constant::getNullValue(OpType)); 6707 return &I; 6708 } 6709 } 6710 6711 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 6712 // then canonicalize the operand to 0.0. 6713 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 6714 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) 6715 return replaceOperand(I, 0, ConstantFP::getNullValue(OpType)); 6716 6717 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) 6718 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6719 } 6720 6721 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 6722 Value *X, *Y; 6723 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 6724 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 6725 6726 if (Instruction *R = foldFCmpFNegCommonOp(I)) 6727 return R; 6728 6729 // Test if the FCmpInst instruction is used exclusively by a select as 6730 // part of a minimum or maximum operation. If so, refrain from doing 6731 // any other folding. This helps out other analyses which understand 6732 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6733 // and CodeGen. And in this case, at least one of the comparison 6734 // operands has at least one user besides the compare (the select), 6735 // which would often largely negate the benefit of folding anyway. 6736 if (I.hasOneUse()) 6737 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6738 Value *A, *B; 6739 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6740 if (SPR.Flavor != SPF_UNKNOWN) 6741 return nullptr; 6742 } 6743 6744 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 6745 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 6746 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) 6747 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6748 6749 // Handle fcmp with instruction LHS and constant RHS. 6750 Instruction *LHSI; 6751 Constant *RHSC; 6752 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 6753 switch (LHSI->getOpcode()) { 6754 case Instruction::PHI: 6755 // Only fold fcmp into the PHI if the phi and fcmp are in the same 6756 // block. If in the same block, we're encouraging jump threading. If 6757 // not, we are just pessimizing the code by making an i1 phi. 6758 if (LHSI->getParent() == I.getParent()) 6759 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 6760 return NV; 6761 break; 6762 case Instruction::SIToFP: 6763 case Instruction::UIToFP: 6764 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 6765 return NV; 6766 break; 6767 case Instruction::FDiv: 6768 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 6769 return NV; 6770 break; 6771 case Instruction::Load: 6772 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 6773 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 6774 if (Instruction *Res = foldCmpLoadFromIndexedGlobal( 6775 cast<LoadInst>(LHSI), GEP, GV, I)) 6776 return Res; 6777 break; 6778 } 6779 } 6780 6781 if (Instruction *R = foldFabsWithFcmpZero(I, *this)) 6782 return R; 6783 6784 if (match(Op0, m_FNeg(m_Value(X)))) { 6785 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 6786 Constant *C; 6787 if (match(Op1, m_Constant(C))) { 6788 Constant *NegC = ConstantExpr::getFNeg(C); 6789 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 6790 } 6791 } 6792 6793 if (match(Op0, m_FPExt(m_Value(X)))) { 6794 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 6795 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 6796 return new FCmpInst(Pred, X, Y, "", &I); 6797 6798 const APFloat *C; 6799 if (match(Op1, m_APFloat(C))) { 6800 const fltSemantics &FPSem = 6801 X->getType()->getScalarType()->getFltSemantics(); 6802 bool Lossy; 6803 APFloat TruncC = *C; 6804 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 6805 6806 if (Lossy) { 6807 // X can't possibly equal the higher-precision constant, so reduce any 6808 // equality comparison. 6809 // TODO: Other predicates can be handled via getFCmpCode(). 6810 switch (Pred) { 6811 case FCmpInst::FCMP_OEQ: 6812 // X is ordered and equal to an impossible constant --> false 6813 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 6814 case FCmpInst::FCMP_ONE: 6815 // X is ordered and not equal to an impossible constant --> ordered 6816 return new FCmpInst(FCmpInst::FCMP_ORD, X, 6817 ConstantFP::getNullValue(X->getType())); 6818 case FCmpInst::FCMP_UEQ: 6819 // X is unordered or equal to an impossible constant --> unordered 6820 return new FCmpInst(FCmpInst::FCMP_UNO, X, 6821 ConstantFP::getNullValue(X->getType())); 6822 case FCmpInst::FCMP_UNE: 6823 // X is unordered or not equal to an impossible constant --> true 6824 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 6825 default: 6826 break; 6827 } 6828 } 6829 6830 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 6831 // Avoid lossy conversions and denormals. 6832 // Zero is a special case that's OK to convert. 6833 APFloat Fabs = TruncC; 6834 Fabs.clearSign(); 6835 if (!Lossy && 6836 (!(Fabs < APFloat::getSmallestNormalized(FPSem)) || Fabs.isZero())) { 6837 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 6838 return new FCmpInst(Pred, X, NewC, "", &I); 6839 } 6840 } 6841 } 6842 6843 // Convert a sign-bit test of an FP value into a cast and integer compare. 6844 // TODO: Simplify if the copysign constant is 0.0 or NaN. 6845 // TODO: Handle non-zero compare constants. 6846 // TODO: Handle other predicates. 6847 const APFloat *C; 6848 if (match(Op0, m_OneUse(m_Intrinsic<Intrinsic::copysign>(m_APFloat(C), 6849 m_Value(X)))) && 6850 match(Op1, m_AnyZeroFP()) && !C->isZero() && !C->isNaN()) { 6851 Type *IntType = Builder.getIntNTy(X->getType()->getScalarSizeInBits()); 6852 if (auto *VecTy = dyn_cast<VectorType>(OpType)) 6853 IntType = VectorType::get(IntType, VecTy->getElementCount()); 6854 6855 // copysign(non-zero constant, X) < 0.0 --> (bitcast X) < 0 6856 if (Pred == FCmpInst::FCMP_OLT) { 6857 Value *IntX = Builder.CreateBitCast(X, IntType); 6858 return new ICmpInst(ICmpInst::ICMP_SLT, IntX, 6859 ConstantInt::getNullValue(IntType)); 6860 } 6861 } 6862 6863 if (I.getType()->isVectorTy()) 6864 if (Instruction *Res = foldVectorCmp(I, Builder)) 6865 return Res; 6866 6867 return Changed ? &I : nullptr; 6868 } 6869