1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/ConstantFolding.h" 18 #include "llvm/Analysis/InstructionSimplify.h" 19 #include "llvm/Analysis/TargetLibraryInfo.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/Debug.h" 26 #include "llvm/Support/KnownBits.h" 27 #include "llvm/Transforms/InstCombine/InstCombiner.h" 28 29 using namespace llvm; 30 using namespace PatternMatch; 31 32 #define DEBUG_TYPE "instcombine" 33 34 // How many times is a select replaced by one of its operands? 35 STATISTIC(NumSel, "Number of select opts"); 36 37 38 /// Compute Result = In1+In2, returning true if the result overflowed for this 39 /// type. 40 static bool addWithOverflow(APInt &Result, const APInt &In1, 41 const APInt &In2, bool IsSigned = false) { 42 bool Overflow; 43 if (IsSigned) 44 Result = In1.sadd_ov(In2, Overflow); 45 else 46 Result = In1.uadd_ov(In2, Overflow); 47 48 return Overflow; 49 } 50 51 /// Compute Result = In1-In2, returning true if the result overflowed for this 52 /// type. 53 static bool subWithOverflow(APInt &Result, const APInt &In1, 54 const APInt &In2, bool IsSigned = false) { 55 bool Overflow; 56 if (IsSigned) 57 Result = In1.ssub_ov(In2, Overflow); 58 else 59 Result = In1.usub_ov(In2, Overflow); 60 61 return Overflow; 62 } 63 64 /// Given an icmp instruction, return true if any use of this comparison is a 65 /// branch on sign bit comparison. 66 static bool hasBranchUse(ICmpInst &I) { 67 for (auto *U : I.users()) 68 if (isa<BranchInst>(U)) 69 return true; 70 return false; 71 } 72 73 /// Returns true if the exploded icmp can be expressed as a signed comparison 74 /// to zero and updates the predicate accordingly. 75 /// The signedness of the comparison is preserved. 76 /// TODO: Refactor with decomposeBitTestICmp()? 77 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 78 if (!ICmpInst::isSigned(Pred)) 79 return false; 80 81 if (C.isNullValue()) 82 return ICmpInst::isRelational(Pred); 83 84 if (C.isOneValue()) { 85 if (Pred == ICmpInst::ICMP_SLT) { 86 Pred = ICmpInst::ICMP_SLE; 87 return true; 88 } 89 } else if (C.isAllOnesValue()) { 90 if (Pred == ICmpInst::ICMP_SGT) { 91 Pred = ICmpInst::ICMP_SGE; 92 return true; 93 } 94 } 95 96 return false; 97 } 98 99 /// This is called when we see this pattern: 100 /// cmp pred (load (gep GV, ...)), cmpcst 101 /// where GV is a global variable with a constant initializer. Try to simplify 102 /// this into some simple computation that does not need the load. For example 103 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 104 /// 105 /// If AndCst is non-null, then the loaded value is masked with that constant 106 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 107 Instruction * 108 InstCombinerImpl::foldCmpLoadFromIndexedGlobal(GetElementPtrInst *GEP, 109 GlobalVariable *GV, CmpInst &ICI, 110 ConstantInt *AndCst) { 111 Constant *Init = GV->getInitializer(); 112 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 113 return nullptr; 114 115 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 116 // Don't blow up on huge arrays. 117 if (ArrayElementCount > MaxArraySizeForCombine) 118 return nullptr; 119 120 // There are many forms of this optimization we can handle, for now, just do 121 // the simple index into a single-dimensional array. 122 // 123 // Require: GEP GV, 0, i {{, constant indices}} 124 if (GEP->getNumOperands() < 3 || 125 !isa<ConstantInt>(GEP->getOperand(1)) || 126 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 127 isa<Constant>(GEP->getOperand(2))) 128 return nullptr; 129 130 // Check that indices after the variable are constants and in-range for the 131 // type they index. Collect the indices. This is typically for arrays of 132 // structs. 133 SmallVector<unsigned, 4> LaterIndices; 134 135 Type *EltTy = Init->getType()->getArrayElementType(); 136 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 137 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 138 if (!Idx) return nullptr; // Variable index. 139 140 uint64_t IdxVal = Idx->getZExtValue(); 141 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 142 143 if (StructType *STy = dyn_cast<StructType>(EltTy)) 144 EltTy = STy->getElementType(IdxVal); 145 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 146 if (IdxVal >= ATy->getNumElements()) return nullptr; 147 EltTy = ATy->getElementType(); 148 } else { 149 return nullptr; // Unknown type. 150 } 151 152 LaterIndices.push_back(IdxVal); 153 } 154 155 enum { Overdefined = -3, Undefined = -2 }; 156 157 // Variables for our state machines. 158 159 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 160 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 161 // and 87 is the second (and last) index. FirstTrueElement is -2 when 162 // undefined, otherwise set to the first true element. SecondTrueElement is 163 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 164 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 165 166 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 167 // form "i != 47 & i != 87". Same state transitions as for true elements. 168 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 169 170 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 171 /// define a state machine that triggers for ranges of values that the index 172 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 173 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 174 /// index in the range (inclusive). We use -2 for undefined here because we 175 /// use relative comparisons and don't want 0-1 to match -1. 176 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 177 178 // MagicBitvector - This is a magic bitvector where we set a bit if the 179 // comparison is true for element 'i'. If there are 64 elements or less in 180 // the array, this will fully represent all the comparison results. 181 uint64_t MagicBitvector = 0; 182 183 // Scan the array and see if one of our patterns matches. 184 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 185 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 186 Constant *Elt = Init->getAggregateElement(i); 187 if (!Elt) return nullptr; 188 189 // If this is indexing an array of structures, get the structure element. 190 if (!LaterIndices.empty()) 191 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 192 193 // If the element is masked, handle it. 194 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 195 196 // Find out if the comparison would be true or false for the i'th element. 197 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 198 CompareRHS, DL, &TLI); 199 // If the result is undef for this element, ignore it. 200 if (isa<UndefValue>(C)) { 201 // Extend range state machines to cover this element in case there is an 202 // undef in the middle of the range. 203 if (TrueRangeEnd == (int)i-1) 204 TrueRangeEnd = i; 205 if (FalseRangeEnd == (int)i-1) 206 FalseRangeEnd = i; 207 continue; 208 } 209 210 // If we can't compute the result for any of the elements, we have to give 211 // up evaluating the entire conditional. 212 if (!isa<ConstantInt>(C)) return nullptr; 213 214 // Otherwise, we know if the comparison is true or false for this element, 215 // update our state machines. 216 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 217 218 // State machine for single/double/range index comparison. 219 if (IsTrueForElt) { 220 // Update the TrueElement state machine. 221 if (FirstTrueElement == Undefined) 222 FirstTrueElement = TrueRangeEnd = i; // First true element. 223 else { 224 // Update double-compare state machine. 225 if (SecondTrueElement == Undefined) 226 SecondTrueElement = i; 227 else 228 SecondTrueElement = Overdefined; 229 230 // Update range state machine. 231 if (TrueRangeEnd == (int)i-1) 232 TrueRangeEnd = i; 233 else 234 TrueRangeEnd = Overdefined; 235 } 236 } else { 237 // Update the FalseElement state machine. 238 if (FirstFalseElement == Undefined) 239 FirstFalseElement = FalseRangeEnd = i; // First false element. 240 else { 241 // Update double-compare state machine. 242 if (SecondFalseElement == Undefined) 243 SecondFalseElement = i; 244 else 245 SecondFalseElement = Overdefined; 246 247 // Update range state machine. 248 if (FalseRangeEnd == (int)i-1) 249 FalseRangeEnd = i; 250 else 251 FalseRangeEnd = Overdefined; 252 } 253 } 254 255 // If this element is in range, update our magic bitvector. 256 if (i < 64 && IsTrueForElt) 257 MagicBitvector |= 1ULL << i; 258 259 // If all of our states become overdefined, bail out early. Since the 260 // predicate is expensive, only check it every 8 elements. This is only 261 // really useful for really huge arrays. 262 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 263 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 264 FalseRangeEnd == Overdefined) 265 return nullptr; 266 } 267 268 // Now that we've scanned the entire array, emit our new comparison(s). We 269 // order the state machines in complexity of the generated code. 270 Value *Idx = GEP->getOperand(2); 271 272 // If the index is larger than the pointer size of the target, truncate the 273 // index down like the GEP would do implicitly. We don't have to do this for 274 // an inbounds GEP because the index can't be out of range. 275 if (!GEP->isInBounds()) { 276 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 277 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 278 if (Idx->getType()->getPrimitiveSizeInBits().getFixedSize() > PtrSize) 279 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 280 } 281 282 // If inbounds keyword is not present, Idx * ElementSize can overflow. 283 // Let's assume that ElementSize is 2 and the wanted value is at offset 0. 284 // Then, there are two possible values for Idx to match offset 0: 285 // 0x00..00, 0x80..00. 286 // Emitting 'icmp eq Idx, 0' isn't correct in this case because the 287 // comparison is false if Idx was 0x80..00. 288 // We need to erase the highest countTrailingZeros(ElementSize) bits of Idx. 289 unsigned ElementSize = 290 DL.getTypeAllocSize(Init->getType()->getArrayElementType()); 291 auto MaskIdx = [&](Value* Idx){ 292 if (!GEP->isInBounds() && countTrailingZeros(ElementSize) != 0) { 293 Value *Mask = ConstantInt::get(Idx->getType(), -1); 294 Mask = Builder.CreateLShr(Mask, countTrailingZeros(ElementSize)); 295 Idx = Builder.CreateAnd(Idx, Mask); 296 } 297 return Idx; 298 }; 299 300 // If the comparison is only true for one or two elements, emit direct 301 // comparisons. 302 if (SecondTrueElement != Overdefined) { 303 Idx = MaskIdx(Idx); 304 // None true -> false. 305 if (FirstTrueElement == Undefined) 306 return replaceInstUsesWith(ICI, Builder.getFalse()); 307 308 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 309 310 // True for one element -> 'i == 47'. 311 if (SecondTrueElement == Undefined) 312 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 313 314 // True for two elements -> 'i == 47 | i == 72'. 315 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 316 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 317 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 318 return BinaryOperator::CreateOr(C1, C2); 319 } 320 321 // If the comparison is only false for one or two elements, emit direct 322 // comparisons. 323 if (SecondFalseElement != Overdefined) { 324 Idx = MaskIdx(Idx); 325 // None false -> true. 326 if (FirstFalseElement == Undefined) 327 return replaceInstUsesWith(ICI, Builder.getTrue()); 328 329 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 330 331 // False for one element -> 'i != 47'. 332 if (SecondFalseElement == Undefined) 333 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 334 335 // False for two elements -> 'i != 47 & i != 72'. 336 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 337 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 338 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 339 return BinaryOperator::CreateAnd(C1, C2); 340 } 341 342 // If the comparison can be replaced with a range comparison for the elements 343 // where it is true, emit the range check. 344 if (TrueRangeEnd != Overdefined) { 345 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 346 Idx = MaskIdx(Idx); 347 348 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 349 if (FirstTrueElement) { 350 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 351 Idx = Builder.CreateAdd(Idx, Offs); 352 } 353 354 Value *End = ConstantInt::get(Idx->getType(), 355 TrueRangeEnd-FirstTrueElement+1); 356 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 357 } 358 359 // False range check. 360 if (FalseRangeEnd != Overdefined) { 361 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 362 Idx = MaskIdx(Idx); 363 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 364 if (FirstFalseElement) { 365 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 366 Idx = Builder.CreateAdd(Idx, Offs); 367 } 368 369 Value *End = ConstantInt::get(Idx->getType(), 370 FalseRangeEnd-FirstFalseElement); 371 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 372 } 373 374 // If a magic bitvector captures the entire comparison state 375 // of this load, replace it with computation that does: 376 // ((magic_cst >> i) & 1) != 0 377 { 378 Type *Ty = nullptr; 379 380 // Look for an appropriate type: 381 // - The type of Idx if the magic fits 382 // - The smallest fitting legal type 383 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 384 Ty = Idx->getType(); 385 else 386 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 387 388 if (Ty) { 389 Idx = MaskIdx(Idx); 390 Value *V = Builder.CreateIntCast(Idx, Ty, false); 391 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 392 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 393 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 394 } 395 } 396 397 return nullptr; 398 } 399 400 /// Return a value that can be used to compare the *offset* implied by a GEP to 401 /// zero. For example, if we have &A[i], we want to return 'i' for 402 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 403 /// are involved. The above expression would also be legal to codegen as 404 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 405 /// This latter form is less amenable to optimization though, and we are allowed 406 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 407 /// 408 /// If we can't emit an optimized form for this expression, this returns null. 409 /// 410 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombinerImpl &IC, 411 const DataLayout &DL) { 412 gep_type_iterator GTI = gep_type_begin(GEP); 413 414 // Check to see if this gep only has a single variable index. If so, and if 415 // any constant indices are a multiple of its scale, then we can compute this 416 // in terms of the scale of the variable index. For example, if the GEP 417 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 418 // because the expression will cross zero at the same point. 419 unsigned i, e = GEP->getNumOperands(); 420 int64_t Offset = 0; 421 for (i = 1; i != e; ++i, ++GTI) { 422 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 423 // Compute the aggregate offset of constant indices. 424 if (CI->isZero()) continue; 425 426 // Handle a struct index, which adds its field offset to the pointer. 427 if (StructType *STy = GTI.getStructTypeOrNull()) { 428 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 429 } else { 430 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 431 Offset += Size*CI->getSExtValue(); 432 } 433 } else { 434 // Found our variable index. 435 break; 436 } 437 } 438 439 // If there are no variable indices, we must have a constant offset, just 440 // evaluate it the general way. 441 if (i == e) return nullptr; 442 443 Value *VariableIdx = GEP->getOperand(i); 444 // Determine the scale factor of the variable element. For example, this is 445 // 4 if the variable index is into an array of i32. 446 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 447 448 // Verify that there are no other variable indices. If so, emit the hard way. 449 for (++i, ++GTI; i != e; ++i, ++GTI) { 450 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 451 if (!CI) return nullptr; 452 453 // Compute the aggregate offset of constant indices. 454 if (CI->isZero()) continue; 455 456 // Handle a struct index, which adds its field offset to the pointer. 457 if (StructType *STy = GTI.getStructTypeOrNull()) { 458 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 459 } else { 460 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 461 Offset += Size*CI->getSExtValue(); 462 } 463 } 464 465 // Okay, we know we have a single variable index, which must be a 466 // pointer/array/vector index. If there is no offset, life is simple, return 467 // the index. 468 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 469 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 470 if (Offset == 0) { 471 // Cast to intptrty in case a truncation occurs. If an extension is needed, 472 // we don't need to bother extending: the extension won't affect where the 473 // computation crosses zero. 474 if (VariableIdx->getType()->getPrimitiveSizeInBits().getFixedSize() > 475 IntPtrWidth) { 476 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 477 } 478 return VariableIdx; 479 } 480 481 // Otherwise, there is an index. The computation we will do will be modulo 482 // the pointer size. 483 Offset = SignExtend64(Offset, IntPtrWidth); 484 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 485 486 // To do this transformation, any constant index must be a multiple of the 487 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 488 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 489 // multiple of the variable scale. 490 int64_t NewOffs = Offset / (int64_t)VariableScale; 491 if (Offset != NewOffs*(int64_t)VariableScale) 492 return nullptr; 493 494 // Okay, we can do this evaluation. Start by converting the index to intptr. 495 if (VariableIdx->getType() != IntPtrTy) 496 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 497 true /*Signed*/); 498 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 499 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 500 } 501 502 /// Returns true if we can rewrite Start as a GEP with pointer Base 503 /// and some integer offset. The nodes that need to be re-written 504 /// for this transformation will be added to Explored. 505 static bool canRewriteGEPAsOffset(Type *ElemTy, Value *Start, Value *Base, 506 const DataLayout &DL, 507 SetVector<Value *> &Explored) { 508 SmallVector<Value *, 16> WorkList(1, Start); 509 Explored.insert(Base); 510 511 // The following traversal gives us an order which can be used 512 // when doing the final transformation. Since in the final 513 // transformation we create the PHI replacement instructions first, 514 // we don't have to get them in any particular order. 515 // 516 // However, for other instructions we will have to traverse the 517 // operands of an instruction first, which means that we have to 518 // do a post-order traversal. 519 while (!WorkList.empty()) { 520 SetVector<PHINode *> PHIs; 521 522 while (!WorkList.empty()) { 523 if (Explored.size() >= 100) 524 return false; 525 526 Value *V = WorkList.back(); 527 528 if (Explored.contains(V)) { 529 WorkList.pop_back(); 530 continue; 531 } 532 533 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 534 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 535 // We've found some value that we can't explore which is different from 536 // the base. Therefore we can't do this transformation. 537 return false; 538 539 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 540 auto *CI = cast<CastInst>(V); 541 if (!CI->isNoopCast(DL)) 542 return false; 543 544 if (Explored.count(CI->getOperand(0)) == 0) 545 WorkList.push_back(CI->getOperand(0)); 546 } 547 548 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 549 // We're limiting the GEP to having one index. This will preserve 550 // the original pointer type. We could handle more cases in the 551 // future. 552 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 553 GEP->getSourceElementType() != ElemTy) 554 return false; 555 556 if (Explored.count(GEP->getOperand(0)) == 0) 557 WorkList.push_back(GEP->getOperand(0)); 558 } 559 560 if (WorkList.back() == V) { 561 WorkList.pop_back(); 562 // We've finished visiting this node, mark it as such. 563 Explored.insert(V); 564 } 565 566 if (auto *PN = dyn_cast<PHINode>(V)) { 567 // We cannot transform PHIs on unsplittable basic blocks. 568 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 569 return false; 570 Explored.insert(PN); 571 PHIs.insert(PN); 572 } 573 } 574 575 // Explore the PHI nodes further. 576 for (auto *PN : PHIs) 577 for (Value *Op : PN->incoming_values()) 578 if (Explored.count(Op) == 0) 579 WorkList.push_back(Op); 580 } 581 582 // Make sure that we can do this. Since we can't insert GEPs in a basic 583 // block before a PHI node, we can't easily do this transformation if 584 // we have PHI node users of transformed instructions. 585 for (Value *Val : Explored) { 586 for (Value *Use : Val->uses()) { 587 588 auto *PHI = dyn_cast<PHINode>(Use); 589 auto *Inst = dyn_cast<Instruction>(Val); 590 591 if (Inst == Base || Inst == PHI || !Inst || !PHI || 592 Explored.count(PHI) == 0) 593 continue; 594 595 if (PHI->getParent() == Inst->getParent()) 596 return false; 597 } 598 } 599 return true; 600 } 601 602 // Sets the appropriate insert point on Builder where we can add 603 // a replacement Instruction for V (if that is possible). 604 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 605 bool Before = true) { 606 if (auto *PHI = dyn_cast<PHINode>(V)) { 607 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 608 return; 609 } 610 if (auto *I = dyn_cast<Instruction>(V)) { 611 if (!Before) 612 I = &*std::next(I->getIterator()); 613 Builder.SetInsertPoint(I); 614 return; 615 } 616 if (auto *A = dyn_cast<Argument>(V)) { 617 // Set the insertion point in the entry block. 618 BasicBlock &Entry = A->getParent()->getEntryBlock(); 619 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 620 return; 621 } 622 // Otherwise, this is a constant and we don't need to set a new 623 // insertion point. 624 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 625 } 626 627 /// Returns a re-written value of Start as an indexed GEP using Base as a 628 /// pointer. 629 static Value *rewriteGEPAsOffset(Type *ElemTy, Value *Start, Value *Base, 630 const DataLayout &DL, 631 SetVector<Value *> &Explored) { 632 // Perform all the substitutions. This is a bit tricky because we can 633 // have cycles in our use-def chains. 634 // 1. Create the PHI nodes without any incoming values. 635 // 2. Create all the other values. 636 // 3. Add the edges for the PHI nodes. 637 // 4. Emit GEPs to get the original pointers. 638 // 5. Remove the original instructions. 639 Type *IndexType = IntegerType::get( 640 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 641 642 DenseMap<Value *, Value *> NewInsts; 643 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 644 645 // Create the new PHI nodes, without adding any incoming values. 646 for (Value *Val : Explored) { 647 if (Val == Base) 648 continue; 649 // Create empty phi nodes. This avoids cyclic dependencies when creating 650 // the remaining instructions. 651 if (auto *PHI = dyn_cast<PHINode>(Val)) 652 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 653 PHI->getName() + ".idx", PHI); 654 } 655 IRBuilder<> Builder(Base->getContext()); 656 657 // Create all the other instructions. 658 for (Value *Val : Explored) { 659 660 if (NewInsts.find(Val) != NewInsts.end()) 661 continue; 662 663 if (auto *CI = dyn_cast<CastInst>(Val)) { 664 // Don't get rid of the intermediate variable here; the store can grow 665 // the map which will invalidate the reference to the input value. 666 Value *V = NewInsts[CI->getOperand(0)]; 667 NewInsts[CI] = V; 668 continue; 669 } 670 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 671 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 672 : GEP->getOperand(1); 673 setInsertionPoint(Builder, GEP); 674 // Indices might need to be sign extended. GEPs will magically do 675 // this, but we need to do it ourselves here. 676 if (Index->getType()->getScalarSizeInBits() != 677 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 678 Index = Builder.CreateSExtOrTrunc( 679 Index, NewInsts[GEP->getOperand(0)]->getType(), 680 GEP->getOperand(0)->getName() + ".sext"); 681 } 682 683 auto *Op = NewInsts[GEP->getOperand(0)]; 684 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 685 NewInsts[GEP] = Index; 686 else 687 NewInsts[GEP] = Builder.CreateNSWAdd( 688 Op, Index, GEP->getOperand(0)->getName() + ".add"); 689 continue; 690 } 691 if (isa<PHINode>(Val)) 692 continue; 693 694 llvm_unreachable("Unexpected instruction type"); 695 } 696 697 // Add the incoming values to the PHI nodes. 698 for (Value *Val : Explored) { 699 if (Val == Base) 700 continue; 701 // All the instructions have been created, we can now add edges to the 702 // phi nodes. 703 if (auto *PHI = dyn_cast<PHINode>(Val)) { 704 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 705 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 706 Value *NewIncoming = PHI->getIncomingValue(I); 707 708 if (NewInsts.find(NewIncoming) != NewInsts.end()) 709 NewIncoming = NewInsts[NewIncoming]; 710 711 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 712 } 713 } 714 } 715 716 for (Value *Val : Explored) { 717 if (Val == Base) 718 continue; 719 720 // Depending on the type, for external users we have to emit 721 // a GEP or a GEP + ptrtoint. 722 setInsertionPoint(Builder, Val, false); 723 724 // If required, create an inttoptr instruction for Base. 725 Value *NewBase = Base; 726 if (!Base->getType()->isPointerTy()) 727 NewBase = Builder.CreateBitOrPointerCast(Base, Start->getType(), 728 Start->getName() + "to.ptr"); 729 730 Value *GEP = Builder.CreateInBoundsGEP( 731 ElemTy, NewBase, makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 732 733 if (!Val->getType()->isPointerTy()) { 734 Value *Cast = Builder.CreatePointerCast(GEP, Val->getType(), 735 Val->getName() + ".conv"); 736 GEP = Cast; 737 } 738 Val->replaceAllUsesWith(GEP); 739 } 740 741 return NewInsts[Start]; 742 } 743 744 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 745 /// the input Value as a constant indexed GEP. Returns a pair containing 746 /// the GEPs Pointer and Index. 747 static std::pair<Value *, Value *> 748 getAsConstantIndexedAddress(Type *ElemTy, Value *V, const DataLayout &DL) { 749 Type *IndexType = IntegerType::get(V->getContext(), 750 DL.getIndexTypeSizeInBits(V->getType())); 751 752 Constant *Index = ConstantInt::getNullValue(IndexType); 753 while (true) { 754 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 755 // We accept only inbouds GEPs here to exclude the possibility of 756 // overflow. 757 if (!GEP->isInBounds()) 758 break; 759 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 760 GEP->getSourceElementType() == ElemTy) { 761 V = GEP->getOperand(0); 762 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 763 Index = ConstantExpr::getAdd( 764 Index, ConstantExpr::getSExtOrBitCast(GEPIndex, IndexType)); 765 continue; 766 } 767 break; 768 } 769 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 770 if (!CI->isNoopCast(DL)) 771 break; 772 V = CI->getOperand(0); 773 continue; 774 } 775 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 776 if (!CI->isNoopCast(DL)) 777 break; 778 V = CI->getOperand(0); 779 continue; 780 } 781 break; 782 } 783 return {V, Index}; 784 } 785 786 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 787 /// We can look through PHIs, GEPs and casts in order to determine a common base 788 /// between GEPLHS and RHS. 789 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 790 ICmpInst::Predicate Cond, 791 const DataLayout &DL) { 792 // FIXME: Support vector of pointers. 793 if (GEPLHS->getType()->isVectorTy()) 794 return nullptr; 795 796 if (!GEPLHS->hasAllConstantIndices()) 797 return nullptr; 798 799 Type *ElemTy = GEPLHS->getSourceElementType(); 800 Value *PtrBase, *Index; 801 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(ElemTy, GEPLHS, DL); 802 803 // The set of nodes that will take part in this transformation. 804 SetVector<Value *> Nodes; 805 806 if (!canRewriteGEPAsOffset(ElemTy, RHS, PtrBase, DL, Nodes)) 807 return nullptr; 808 809 // We know we can re-write this as 810 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 811 // Since we've only looked through inbouds GEPs we know that we 812 // can't have overflow on either side. We can therefore re-write 813 // this as: 814 // OFFSET1 cmp OFFSET2 815 Value *NewRHS = rewriteGEPAsOffset(ElemTy, RHS, PtrBase, DL, Nodes); 816 817 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 818 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 819 // offset. Since Index is the offset of LHS to the base pointer, we will now 820 // compare the offsets instead of comparing the pointers. 821 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 822 } 823 824 /// Fold comparisons between a GEP instruction and something else. At this point 825 /// we know that the GEP is on the LHS of the comparison. 826 Instruction *InstCombinerImpl::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 827 ICmpInst::Predicate Cond, 828 Instruction &I) { 829 // Don't transform signed compares of GEPs into index compares. Even if the 830 // GEP is inbounds, the final add of the base pointer can have signed overflow 831 // and would change the result of the icmp. 832 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 833 // the maximum signed value for the pointer type. 834 if (ICmpInst::isSigned(Cond)) 835 return nullptr; 836 837 // Look through bitcasts and addrspacecasts. We do not however want to remove 838 // 0 GEPs. 839 if (!isa<GetElementPtrInst>(RHS)) 840 RHS = RHS->stripPointerCasts(); 841 842 Value *PtrBase = GEPLHS->getOperand(0); 843 // FIXME: Support vector pointer GEPs. 844 if (PtrBase == RHS && GEPLHS->isInBounds() && 845 !GEPLHS->getType()->isVectorTy()) { 846 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 847 // This transformation (ignoring the base and scales) is valid because we 848 // know pointers can't overflow since the gep is inbounds. See if we can 849 // output an optimized form. 850 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 851 852 // If not, synthesize the offset the hard way. 853 if (!Offset) 854 Offset = EmitGEPOffset(GEPLHS); 855 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 856 Constant::getNullValue(Offset->getType())); 857 } 858 859 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) && 860 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() && 861 !NullPointerIsDefined(I.getFunction(), 862 RHS->getType()->getPointerAddressSpace())) { 863 // For most address spaces, an allocation can't be placed at null, but null 864 // itself is treated as a 0 size allocation in the in bounds rules. Thus, 865 // the only valid inbounds address derived from null, is null itself. 866 // Thus, we have four cases to consider: 867 // 1) Base == nullptr, Offset == 0 -> inbounds, null 868 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds 869 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations) 870 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison) 871 // 872 // (Note if we're indexing a type of size 0, that simply collapses into one 873 // of the buckets above.) 874 // 875 // In general, we're allowed to make values less poison (i.e. remove 876 // sources of full UB), so in this case, we just select between the two 877 // non-poison cases (1 and 4 above). 878 // 879 // For vectors, we apply the same reasoning on a per-lane basis. 880 auto *Base = GEPLHS->getPointerOperand(); 881 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) { 882 auto EC = cast<VectorType>(GEPLHS->getType())->getElementCount(); 883 Base = Builder.CreateVectorSplat(EC, Base); 884 } 885 return new ICmpInst(Cond, Base, 886 ConstantExpr::getPointerBitCastOrAddrSpaceCast( 887 cast<Constant>(RHS), Base->getType())); 888 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 889 // If the base pointers are different, but the indices are the same, just 890 // compare the base pointer. 891 if (PtrBase != GEPRHS->getOperand(0)) { 892 bool IndicesTheSame = GEPLHS->getNumOperands()==GEPRHS->getNumOperands(); 893 IndicesTheSame &= GEPLHS->getOperand(0)->getType() == 894 GEPRHS->getOperand(0)->getType(); 895 if (IndicesTheSame) 896 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 897 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 898 IndicesTheSame = false; 899 break; 900 } 901 902 // If all indices are the same, just compare the base pointers. 903 Type *BaseType = GEPLHS->getOperand(0)->getType(); 904 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 905 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 906 907 // If we're comparing GEPs with two base pointers that only differ in type 908 // and both GEPs have only constant indices or just one use, then fold 909 // the compare with the adjusted indices. 910 // FIXME: Support vector of pointers. 911 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 912 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 913 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 914 PtrBase->stripPointerCasts() == 915 GEPRHS->getOperand(0)->stripPointerCasts() && 916 !GEPLHS->getType()->isVectorTy()) { 917 Value *LOffset = EmitGEPOffset(GEPLHS); 918 Value *ROffset = EmitGEPOffset(GEPRHS); 919 920 // If we looked through an addrspacecast between different sized address 921 // spaces, the LHS and RHS pointers are different sized 922 // integers. Truncate to the smaller one. 923 Type *LHSIndexTy = LOffset->getType(); 924 Type *RHSIndexTy = ROffset->getType(); 925 if (LHSIndexTy != RHSIndexTy) { 926 if (LHSIndexTy->getPrimitiveSizeInBits().getFixedSize() < 927 RHSIndexTy->getPrimitiveSizeInBits().getFixedSize()) { 928 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 929 } else 930 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 931 } 932 933 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 934 LOffset, ROffset); 935 return replaceInstUsesWith(I, Cmp); 936 } 937 938 // Otherwise, the base pointers are different and the indices are 939 // different. Try convert this to an indexed compare by looking through 940 // PHIs/casts. 941 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 942 } 943 944 // If one of the GEPs has all zero indices, recurse. 945 // FIXME: Handle vector of pointers. 946 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices()) 947 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 948 ICmpInst::getSwappedPredicate(Cond), I); 949 950 // If the other GEP has all zero indices, recurse. 951 // FIXME: Handle vector of pointers. 952 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices()) 953 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 954 955 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 956 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands()) { 957 // If the GEPs only differ by one index, compare it. 958 unsigned NumDifferences = 0; // Keep track of # differences. 959 unsigned DiffOperand = 0; // The operand that differs. 960 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 961 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 962 Type *LHSType = GEPLHS->getOperand(i)->getType(); 963 Type *RHSType = GEPRHS->getOperand(i)->getType(); 964 // FIXME: Better support for vector of pointers. 965 if (LHSType->getPrimitiveSizeInBits() != 966 RHSType->getPrimitiveSizeInBits() || 967 (GEPLHS->getType()->isVectorTy() && 968 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) { 969 // Irreconcilable differences. 970 NumDifferences = 2; 971 break; 972 } 973 974 if (NumDifferences++) break; 975 DiffOperand = i; 976 } 977 978 if (NumDifferences == 0) // SAME GEP? 979 return replaceInstUsesWith(I, // No comparison is needed here. 980 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 981 982 else if (NumDifferences == 1 && GEPsInBounds) { 983 Value *LHSV = GEPLHS->getOperand(DiffOperand); 984 Value *RHSV = GEPRHS->getOperand(DiffOperand); 985 // Make sure we do a signed comparison here. 986 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 987 } 988 } 989 990 // Only lower this if the icmp is the only user of the GEP or if we expect 991 // the result to fold to a constant! 992 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 993 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 994 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 995 Value *L = EmitGEPOffset(GEPLHS); 996 Value *R = EmitGEPOffset(GEPRHS); 997 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 998 } 999 } 1000 1001 // Try convert this to an indexed compare by looking through PHIs/casts as a 1002 // last resort. 1003 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1004 } 1005 1006 Instruction *InstCombinerImpl::foldAllocaCmp(ICmpInst &ICI, 1007 const AllocaInst *Alloca, 1008 const Value *Other) { 1009 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1010 1011 // It would be tempting to fold away comparisons between allocas and any 1012 // pointer not based on that alloca (e.g. an argument). However, even 1013 // though such pointers cannot alias, they can still compare equal. 1014 // 1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1016 // doesn't escape we can argue that it's impossible to guess its value, and we 1017 // can therefore act as if any such guesses are wrong. 1018 // 1019 // The code below checks that the alloca doesn't escape, and that it's only 1020 // used in a comparison once (the current instruction). The 1021 // single-comparison-use condition ensures that we're trivially folding all 1022 // comparisons against the alloca consistently, and avoids the risk of 1023 // erroneously folding a comparison of the pointer with itself. 1024 1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1026 1027 SmallVector<const Use *, 32> Worklist; 1028 for (const Use &U : Alloca->uses()) { 1029 if (Worklist.size() >= MaxIter) 1030 return nullptr; 1031 Worklist.push_back(&U); 1032 } 1033 1034 unsigned NumCmps = 0; 1035 while (!Worklist.empty()) { 1036 assert(Worklist.size() <= MaxIter); 1037 const Use *U = Worklist.pop_back_val(); 1038 const Value *V = U->getUser(); 1039 --MaxIter; 1040 1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1042 isa<SelectInst>(V)) { 1043 // Track the uses. 1044 } else if (isa<LoadInst>(V)) { 1045 // Loading from the pointer doesn't escape it. 1046 continue; 1047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1048 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1049 if (SI->getValueOperand() == U->get()) 1050 return nullptr; 1051 continue; 1052 } else if (isa<ICmpInst>(V)) { 1053 if (NumCmps++) 1054 return nullptr; // Found more than one cmp. 1055 continue; 1056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1057 switch (Intrin->getIntrinsicID()) { 1058 // These intrinsics don't escape or compare the pointer. Memset is safe 1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1060 // we don't allow stores, so src cannot point to V. 1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1063 continue; 1064 default: 1065 return nullptr; 1066 } 1067 } else { 1068 return nullptr; 1069 } 1070 for (const Use &U : V->uses()) { 1071 if (Worklist.size() >= MaxIter) 1072 return nullptr; 1073 Worklist.push_back(&U); 1074 } 1075 } 1076 1077 Type *CmpTy = CmpInst::makeCmpResultType(Other->getType()); 1078 return replaceInstUsesWith( 1079 ICI, 1080 ConstantInt::get(CmpTy, !CmpInst::isTrueWhenEqual(ICI.getPredicate()))); 1081 } 1082 1083 /// Fold "icmp pred (X+C), X". 1084 Instruction *InstCombinerImpl::foldICmpAddOpConst(Value *X, const APInt &C, 1085 ICmpInst::Predicate Pred) { 1086 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1087 // so the values can never be equal. Similarly for all other "or equals" 1088 // operators. 1089 assert(!!C && "C should not be zero!"); 1090 1091 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1092 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1093 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1094 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1095 Constant *R = ConstantInt::get(X->getType(), 1096 APInt::getMaxValue(C.getBitWidth()) - C); 1097 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1098 } 1099 1100 // (X+1) >u X --> X <u (0-1) --> X != 255 1101 // (X+2) >u X --> X <u (0-2) --> X <u 254 1102 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1103 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1104 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1105 ConstantInt::get(X->getType(), -C)); 1106 1107 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1108 1109 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1110 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1111 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1112 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1113 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1114 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1115 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1116 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1117 ConstantInt::get(X->getType(), SMax - C)); 1118 1119 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1120 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1121 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1122 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1123 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1124 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1125 1126 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1127 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1128 ConstantInt::get(X->getType(), SMax - (C - 1))); 1129 } 1130 1131 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1132 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1133 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1134 Instruction *InstCombinerImpl::foldICmpShrConstConst(ICmpInst &I, Value *A, 1135 const APInt &AP1, 1136 const APInt &AP2) { 1137 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1138 1139 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1140 if (I.getPredicate() == I.ICMP_NE) 1141 Pred = CmpInst::getInversePredicate(Pred); 1142 return new ICmpInst(Pred, LHS, RHS); 1143 }; 1144 1145 // Don't bother doing any work for cases which InstSimplify handles. 1146 if (AP2.isNullValue()) 1147 return nullptr; 1148 1149 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1150 if (IsAShr) { 1151 if (AP2.isAllOnesValue()) 1152 return nullptr; 1153 if (AP2.isNegative() != AP1.isNegative()) 1154 return nullptr; 1155 if (AP2.sgt(AP1)) 1156 return nullptr; 1157 } 1158 1159 if (!AP1) 1160 // 'A' must be large enough to shift out the highest set bit. 1161 return getICmp(I.ICMP_UGT, A, 1162 ConstantInt::get(A->getType(), AP2.logBase2())); 1163 1164 if (AP1 == AP2) 1165 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1166 1167 int Shift; 1168 if (IsAShr && AP1.isNegative()) 1169 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1170 else 1171 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1172 1173 if (Shift > 0) { 1174 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1175 // There are multiple solutions if we are comparing against -1 and the LHS 1176 // of the ashr is not a power of two. 1177 if (AP1.isAllOnesValue() && !AP2.isPowerOf2()) 1178 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1179 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1180 } else if (AP1 == AP2.lshr(Shift)) { 1181 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1182 } 1183 } 1184 1185 // Shifting const2 will never be equal to const1. 1186 // FIXME: This should always be handled by InstSimplify? 1187 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1188 return replaceInstUsesWith(I, TorF); 1189 } 1190 1191 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1192 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1193 Instruction *InstCombinerImpl::foldICmpShlConstConst(ICmpInst &I, Value *A, 1194 const APInt &AP1, 1195 const APInt &AP2) { 1196 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1197 1198 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1199 if (I.getPredicate() == I.ICMP_NE) 1200 Pred = CmpInst::getInversePredicate(Pred); 1201 return new ICmpInst(Pred, LHS, RHS); 1202 }; 1203 1204 // Don't bother doing any work for cases which InstSimplify handles. 1205 if (AP2.isNullValue()) 1206 return nullptr; 1207 1208 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1209 1210 if (!AP1 && AP2TrailingZeros != 0) 1211 return getICmp( 1212 I.ICMP_UGE, A, 1213 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1214 1215 if (AP1 == AP2) 1216 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1217 1218 // Get the distance between the lowest bits that are set. 1219 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1220 1221 if (Shift > 0 && AP2.shl(Shift) == AP1) 1222 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1223 1224 // Shifting const2 will never be equal to const1. 1225 // FIXME: This should always be handled by InstSimplify? 1226 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1227 return replaceInstUsesWith(I, TorF); 1228 } 1229 1230 /// The caller has matched a pattern of the form: 1231 /// I = icmp ugt (add (add A, B), CI2), CI1 1232 /// If this is of the form: 1233 /// sum = a + b 1234 /// if (sum+128 >u 255) 1235 /// Then replace it with llvm.sadd.with.overflow.i8. 1236 /// 1237 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1238 ConstantInt *CI2, ConstantInt *CI1, 1239 InstCombinerImpl &IC) { 1240 // The transformation we're trying to do here is to transform this into an 1241 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1242 // with a narrower add, and discard the add-with-constant that is part of the 1243 // range check (if we can't eliminate it, this isn't profitable). 1244 1245 // In order to eliminate the add-with-constant, the compare can be its only 1246 // use. 1247 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1248 if (!AddWithCst->hasOneUse()) 1249 return nullptr; 1250 1251 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1252 if (!CI2->getValue().isPowerOf2()) 1253 return nullptr; 1254 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1255 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1256 return nullptr; 1257 1258 // The width of the new add formed is 1 more than the bias. 1259 ++NewWidth; 1260 1261 // Check to see that CI1 is an all-ones value with NewWidth bits. 1262 if (CI1->getBitWidth() == NewWidth || 1263 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1264 return nullptr; 1265 1266 // This is only really a signed overflow check if the inputs have been 1267 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1268 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1269 unsigned NeededSignBits = CI1->getBitWidth() - NewWidth + 1; 1270 if (IC.ComputeNumSignBits(A, 0, &I) < NeededSignBits || 1271 IC.ComputeNumSignBits(B, 0, &I) < NeededSignBits) 1272 return nullptr; 1273 1274 // In order to replace the original add with a narrower 1275 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1276 // and truncates that discard the high bits of the add. Verify that this is 1277 // the case. 1278 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1279 for (User *U : OrigAdd->users()) { 1280 if (U == AddWithCst) 1281 continue; 1282 1283 // Only accept truncates for now. We would really like a nice recursive 1284 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1285 // chain to see which bits of a value are actually demanded. If the 1286 // original add had another add which was then immediately truncated, we 1287 // could still do the transformation. 1288 TruncInst *TI = dyn_cast<TruncInst>(U); 1289 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1290 return nullptr; 1291 } 1292 1293 // If the pattern matches, truncate the inputs to the narrower type and 1294 // use the sadd_with_overflow intrinsic to efficiently compute both the 1295 // result and the overflow bit. 1296 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1297 Function *F = Intrinsic::getDeclaration( 1298 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1299 1300 InstCombiner::BuilderTy &Builder = IC.Builder; 1301 1302 // Put the new code above the original add, in case there are any uses of the 1303 // add between the add and the compare. 1304 Builder.SetInsertPoint(OrigAdd); 1305 1306 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1307 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1308 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1309 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1310 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1311 1312 // The inner add was the result of the narrow add, zero extended to the 1313 // wider type. Replace it with the result computed by the intrinsic. 1314 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1315 IC.eraseInstFromFunction(*OrigAdd); 1316 1317 // The original icmp gets replaced with the overflow value. 1318 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1319 } 1320 1321 /// If we have: 1322 /// icmp eq/ne (urem/srem %x, %y), 0 1323 /// iff %y is a power-of-two, we can replace this with a bit test: 1324 /// icmp eq/ne (and %x, (add %y, -1)), 0 1325 Instruction *InstCombinerImpl::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1326 // This fold is only valid for equality predicates. 1327 if (!I.isEquality()) 1328 return nullptr; 1329 ICmpInst::Predicate Pred; 1330 Value *X, *Y, *Zero; 1331 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1332 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1333 return nullptr; 1334 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1335 return nullptr; 1336 // This may increase instruction count, we don't enforce that Y is a constant. 1337 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1338 Value *Masked = Builder.CreateAnd(X, Mask); 1339 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1340 } 1341 1342 /// Fold equality-comparison between zero and any (maybe truncated) right-shift 1343 /// by one-less-than-bitwidth into a sign test on the original value. 1344 Instruction *InstCombinerImpl::foldSignBitTest(ICmpInst &I) { 1345 Instruction *Val; 1346 ICmpInst::Predicate Pred; 1347 if (!I.isEquality() || !match(&I, m_ICmp(Pred, m_Instruction(Val), m_Zero()))) 1348 return nullptr; 1349 1350 Value *X; 1351 Type *XTy; 1352 1353 Constant *C; 1354 if (match(Val, m_TruncOrSelf(m_Shr(m_Value(X), m_Constant(C))))) { 1355 XTy = X->getType(); 1356 unsigned XBitWidth = XTy->getScalarSizeInBits(); 1357 if (!match(C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1358 APInt(XBitWidth, XBitWidth - 1)))) 1359 return nullptr; 1360 } else if (isa<BinaryOperator>(Val) && 1361 (X = reassociateShiftAmtsOfTwoSameDirectionShifts( 1362 cast<BinaryOperator>(Val), SQ.getWithInstruction(Val), 1363 /*AnalyzeForSignBitExtraction=*/true))) { 1364 XTy = X->getType(); 1365 } else 1366 return nullptr; 1367 1368 return ICmpInst::Create(Instruction::ICmp, 1369 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_SGE 1370 : ICmpInst::ICMP_SLT, 1371 X, ConstantInt::getNullValue(XTy)); 1372 } 1373 1374 // Handle icmp pred X, 0 1375 Instruction *InstCombinerImpl::foldICmpWithZero(ICmpInst &Cmp) { 1376 CmpInst::Predicate Pred = Cmp.getPredicate(); 1377 if (!match(Cmp.getOperand(1), m_Zero())) 1378 return nullptr; 1379 1380 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1381 if (Pred == ICmpInst::ICMP_SGT) { 1382 Value *A, *B; 1383 SelectPatternResult SPR = matchSelectPattern(Cmp.getOperand(0), A, B); 1384 if (SPR.Flavor == SPF_SMIN) { 1385 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1386 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1387 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1388 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1389 } 1390 } 1391 1392 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1393 return New; 1394 1395 // Given: 1396 // icmp eq/ne (urem %x, %y), 0 1397 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1398 // icmp eq/ne %x, 0 1399 Value *X, *Y; 1400 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1401 ICmpInst::isEquality(Pred)) { 1402 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1403 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1404 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1405 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1406 } 1407 1408 return nullptr; 1409 } 1410 1411 /// Fold icmp Pred X, C. 1412 /// TODO: This code structure does not make sense. The saturating add fold 1413 /// should be moved to some other helper and extended as noted below (it is also 1414 /// possible that code has been made unnecessary - do we canonicalize IR to 1415 /// overflow/saturating intrinsics or not?). 1416 Instruction *InstCombinerImpl::foldICmpWithConstant(ICmpInst &Cmp) { 1417 // Match the following pattern, which is a common idiom when writing 1418 // overflow-safe integer arithmetic functions. The source performs an addition 1419 // in wider type and explicitly checks for overflow using comparisons against 1420 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1421 // 1422 // TODO: This could probably be generalized to handle other overflow-safe 1423 // operations if we worked out the formulas to compute the appropriate magic 1424 // constants. 1425 // 1426 // sum = a + b 1427 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1428 CmpInst::Predicate Pred = Cmp.getPredicate(); 1429 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1430 Value *A, *B; 1431 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1432 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1433 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1434 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1435 return Res; 1436 1437 // icmp(phi(C1, C2, ...), C) -> phi(icmp(C1, C), icmp(C2, C), ...). 1438 Constant *C = dyn_cast<Constant>(Op1); 1439 if (!C) 1440 return nullptr; 1441 1442 if (auto *Phi = dyn_cast<PHINode>(Op0)) 1443 if (all_of(Phi->operands(), [](Value *V) { return isa<Constant>(V); })) { 1444 Type *Ty = Cmp.getType(); 1445 Builder.SetInsertPoint(Phi); 1446 PHINode *NewPhi = 1447 Builder.CreatePHI(Ty, Phi->getNumOperands()); 1448 for (BasicBlock *Predecessor : predecessors(Phi->getParent())) { 1449 auto *Input = 1450 cast<Constant>(Phi->getIncomingValueForBlock(Predecessor)); 1451 auto *BoolInput = ConstantExpr::getCompare(Pred, Input, C); 1452 NewPhi->addIncoming(BoolInput, Predecessor); 1453 } 1454 NewPhi->takeName(&Cmp); 1455 return replaceInstUsesWith(Cmp, NewPhi); 1456 } 1457 1458 return nullptr; 1459 } 1460 1461 /// Canonicalize icmp instructions based on dominating conditions. 1462 Instruction *InstCombinerImpl::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1463 // This is a cheap/incomplete check for dominance - just match a single 1464 // predecessor with a conditional branch. 1465 BasicBlock *CmpBB = Cmp.getParent(); 1466 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1467 if (!DomBB) 1468 return nullptr; 1469 1470 Value *DomCond; 1471 BasicBlock *TrueBB, *FalseBB; 1472 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1473 return nullptr; 1474 1475 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1476 "Predecessor block does not point to successor?"); 1477 1478 // The branch should get simplified. Don't bother simplifying this condition. 1479 if (TrueBB == FalseBB) 1480 return nullptr; 1481 1482 // Try to simplify this compare to T/F based on the dominating condition. 1483 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1484 if (Imp) 1485 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1486 1487 CmpInst::Predicate Pred = Cmp.getPredicate(); 1488 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1489 ICmpInst::Predicate DomPred; 1490 const APInt *C, *DomC; 1491 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1492 match(Y, m_APInt(C))) { 1493 // We have 2 compares of a variable with constants. Calculate the constant 1494 // ranges of those compares to see if we can transform the 2nd compare: 1495 // DomBB: 1496 // DomCond = icmp DomPred X, DomC 1497 // br DomCond, CmpBB, FalseBB 1498 // CmpBB: 1499 // Cmp = icmp Pred X, C 1500 ConstantRange CR = ConstantRange::makeExactICmpRegion(Pred, *C); 1501 ConstantRange DominatingCR = 1502 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1503 : ConstantRange::makeExactICmpRegion( 1504 CmpInst::getInversePredicate(DomPred), *DomC); 1505 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1506 ConstantRange Difference = DominatingCR.difference(CR); 1507 if (Intersection.isEmptySet()) 1508 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1509 if (Difference.isEmptySet()) 1510 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1511 1512 // Canonicalizing a sign bit comparison that gets used in a branch, 1513 // pessimizes codegen by generating branch on zero instruction instead 1514 // of a test and branch. So we avoid canonicalizing in such situations 1515 // because test and branch instruction has better branch displacement 1516 // than compare and branch instruction. 1517 bool UnusedBit; 1518 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1519 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1520 return nullptr; 1521 1522 // Avoid an infinite loop with min/max canonicalization. 1523 // TODO: This will be unnecessary if we canonicalize to min/max intrinsics. 1524 if (Cmp.hasOneUse() && 1525 match(Cmp.user_back(), m_MaxOrMin(m_Value(), m_Value()))) 1526 return nullptr; 1527 1528 if (const APInt *EqC = Intersection.getSingleElement()) 1529 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1530 if (const APInt *NeC = Difference.getSingleElement()) 1531 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1532 } 1533 1534 return nullptr; 1535 } 1536 1537 /// Fold icmp (trunc X, Y), C. 1538 Instruction *InstCombinerImpl::foldICmpTruncConstant(ICmpInst &Cmp, 1539 TruncInst *Trunc, 1540 const APInt &C) { 1541 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1542 Value *X = Trunc->getOperand(0); 1543 if (C.isOneValue() && C.getBitWidth() > 1) { 1544 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1545 Value *V = nullptr; 1546 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1547 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1548 ConstantInt::get(V->getType(), 1)); 1549 } 1550 1551 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1552 SrcBits = X->getType()->getScalarSizeInBits(); 1553 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1554 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1555 // of the high bits truncated out of x are known. 1556 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1557 1558 // If all the high bits are known, we can do this xform. 1559 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1560 // Pull in the high bits from known-ones set. 1561 APInt NewRHS = C.zext(SrcBits); 1562 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1563 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1564 } 1565 } 1566 1567 // Look through truncated right-shift of the sign-bit for a sign-bit check: 1568 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] < 0 --> ShOp < 0 1569 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] > -1 --> ShOp > -1 1570 Value *ShOp; 1571 const APInt *ShAmtC; 1572 bool TrueIfSigned; 1573 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1574 match(X, m_Shr(m_Value(ShOp), m_APInt(ShAmtC))) && 1575 DstBits == SrcBits - ShAmtC->getZExtValue()) { 1576 return TrueIfSigned 1577 ? new ICmpInst(ICmpInst::ICMP_SLT, ShOp, 1578 ConstantInt::getNullValue(X->getType())) 1579 : new ICmpInst(ICmpInst::ICMP_SGT, ShOp, 1580 ConstantInt::getAllOnesValue(X->getType())); 1581 } 1582 1583 return nullptr; 1584 } 1585 1586 /// Fold icmp (xor X, Y), C. 1587 Instruction *InstCombinerImpl::foldICmpXorConstant(ICmpInst &Cmp, 1588 BinaryOperator *Xor, 1589 const APInt &C) { 1590 Value *X = Xor->getOperand(0); 1591 Value *Y = Xor->getOperand(1); 1592 const APInt *XorC; 1593 if (!match(Y, m_APInt(XorC))) 1594 return nullptr; 1595 1596 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1597 // fold the xor. 1598 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1599 bool TrueIfSigned = false; 1600 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1601 1602 // If the sign bit of the XorCst is not set, there is no change to 1603 // the operation, just stop using the Xor. 1604 if (!XorC->isNegative()) 1605 return replaceOperand(Cmp, 0, X); 1606 1607 // Emit the opposite comparison. 1608 if (TrueIfSigned) 1609 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1610 ConstantInt::getAllOnesValue(X->getType())); 1611 else 1612 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1613 ConstantInt::getNullValue(X->getType())); 1614 } 1615 1616 if (Xor->hasOneUse()) { 1617 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1618 if (!Cmp.isEquality() && XorC->isSignMask()) { 1619 Pred = Cmp.getFlippedSignednessPredicate(); 1620 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1621 } 1622 1623 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1624 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1625 Pred = Cmp.getFlippedSignednessPredicate(); 1626 Pred = Cmp.getSwappedPredicate(Pred); 1627 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1628 } 1629 } 1630 1631 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1632 if (Pred == ICmpInst::ICMP_UGT) { 1633 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1634 if (*XorC == ~C && (C + 1).isPowerOf2()) 1635 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1636 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1637 if (*XorC == C && (C + 1).isPowerOf2()) 1638 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1639 } 1640 if (Pred == ICmpInst::ICMP_ULT) { 1641 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1642 if (*XorC == -C && C.isPowerOf2()) 1643 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1644 ConstantInt::get(X->getType(), ~C)); 1645 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1646 if (*XorC == C && (-C).isPowerOf2()) 1647 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1648 ConstantInt::get(X->getType(), ~C)); 1649 } 1650 return nullptr; 1651 } 1652 1653 /// Fold icmp (and (sh X, Y), C2), C1. 1654 Instruction *InstCombinerImpl::foldICmpAndShift(ICmpInst &Cmp, 1655 BinaryOperator *And, 1656 const APInt &C1, 1657 const APInt &C2) { 1658 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1659 if (!Shift || !Shift->isShift()) 1660 return nullptr; 1661 1662 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1663 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1664 // code produced by the clang front-end, for bitfield access. 1665 // This seemingly simple opportunity to fold away a shift turns out to be 1666 // rather complicated. See PR17827 for details. 1667 unsigned ShiftOpcode = Shift->getOpcode(); 1668 bool IsShl = ShiftOpcode == Instruction::Shl; 1669 const APInt *C3; 1670 if (match(Shift->getOperand(1), m_APInt(C3))) { 1671 APInt NewAndCst, NewCmpCst; 1672 bool AnyCmpCstBitsShiftedOut; 1673 if (ShiftOpcode == Instruction::Shl) { 1674 // For a left shift, we can fold if the comparison is not signed. We can 1675 // also fold a signed comparison if the mask value and comparison value 1676 // are not negative. These constraints may not be obvious, but we can 1677 // prove that they are correct using an SMT solver. 1678 if (Cmp.isSigned() && (C2.isNegative() || C1.isNegative())) 1679 return nullptr; 1680 1681 NewCmpCst = C1.lshr(*C3); 1682 NewAndCst = C2.lshr(*C3); 1683 AnyCmpCstBitsShiftedOut = NewCmpCst.shl(*C3) != C1; 1684 } else if (ShiftOpcode == Instruction::LShr) { 1685 // For a logical right shift, we can fold if the comparison is not signed. 1686 // We can also fold a signed comparison if the shifted mask value and the 1687 // shifted comparison value are not negative. These constraints may not be 1688 // obvious, but we can prove that they are correct using an SMT solver. 1689 NewCmpCst = C1.shl(*C3); 1690 NewAndCst = C2.shl(*C3); 1691 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1692 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1693 return nullptr; 1694 } else { 1695 // For an arithmetic shift, check that both constants don't use (in a 1696 // signed sense) the top bits being shifted out. 1697 assert(ShiftOpcode == Instruction::AShr && "Unknown shift opcode"); 1698 NewCmpCst = C1.shl(*C3); 1699 NewAndCst = C2.shl(*C3); 1700 AnyCmpCstBitsShiftedOut = NewCmpCst.ashr(*C3) != C1; 1701 if (NewAndCst.ashr(*C3) != C2) 1702 return nullptr; 1703 } 1704 1705 if (AnyCmpCstBitsShiftedOut) { 1706 // If we shifted bits out, the fold is not going to work out. As a 1707 // special case, check to see if this means that the result is always 1708 // true or false now. 1709 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1710 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1711 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1712 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1713 } else { 1714 Value *NewAnd = Builder.CreateAnd( 1715 Shift->getOperand(0), ConstantInt::get(And->getType(), NewAndCst)); 1716 return new ICmpInst(Cmp.getPredicate(), 1717 NewAnd, ConstantInt::get(And->getType(), NewCmpCst)); 1718 } 1719 } 1720 1721 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1722 // preferable because it allows the C2 << Y expression to be hoisted out of a 1723 // loop if Y is invariant and X is not. 1724 if (Shift->hasOneUse() && C1.isNullValue() && Cmp.isEquality() && 1725 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1726 // Compute C2 << Y. 1727 Value *NewShift = 1728 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1729 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1730 1731 // Compute X & (C2 << Y). 1732 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1733 return replaceOperand(Cmp, 0, NewAnd); 1734 } 1735 1736 return nullptr; 1737 } 1738 1739 /// Fold icmp (and X, C2), C1. 1740 Instruction *InstCombinerImpl::foldICmpAndConstConst(ICmpInst &Cmp, 1741 BinaryOperator *And, 1742 const APInt &C1) { 1743 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1744 1745 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1746 // TODO: We canonicalize to the longer form for scalars because we have 1747 // better analysis/folds for icmp, and codegen may be better with icmp. 1748 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isNullValue() && 1749 match(And->getOperand(1), m_One())) 1750 return new TruncInst(And->getOperand(0), Cmp.getType()); 1751 1752 const APInt *C2; 1753 Value *X; 1754 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1755 return nullptr; 1756 1757 // Don't perform the following transforms if the AND has multiple uses 1758 if (!And->hasOneUse()) 1759 return nullptr; 1760 1761 if (Cmp.isEquality() && C1.isNullValue()) { 1762 // Restrict this fold to single-use 'and' (PR10267). 1763 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1764 if (C2->isSignMask()) { 1765 Constant *Zero = Constant::getNullValue(X->getType()); 1766 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1767 return new ICmpInst(NewPred, X, Zero); 1768 } 1769 1770 // Restrict this fold only for single-use 'and' (PR10267). 1771 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1772 if ((~(*C2) + 1).isPowerOf2()) { 1773 Constant *NegBOC = 1774 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1775 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1776 return new ICmpInst(NewPred, X, NegBOC); 1777 } 1778 } 1779 1780 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1781 // the input width without changing the value produced, eliminate the cast: 1782 // 1783 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1784 // 1785 // We can do this transformation if the constants do not have their sign bits 1786 // set or if it is an equality comparison. Extending a relational comparison 1787 // when we're checking the sign bit would not work. 1788 Value *W; 1789 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1790 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1791 // TODO: Is this a good transform for vectors? Wider types may reduce 1792 // throughput. Should this transform be limited (even for scalars) by using 1793 // shouldChangeType()? 1794 if (!Cmp.getType()->isVectorTy()) { 1795 Type *WideType = W->getType(); 1796 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1797 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1798 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1799 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1800 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1801 } 1802 } 1803 1804 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1805 return I; 1806 1807 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1808 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1809 // 1810 // iff pred isn't signed 1811 if (!Cmp.isSigned() && C1.isNullValue() && And->getOperand(0)->hasOneUse() && 1812 match(And->getOperand(1), m_One())) { 1813 Constant *One = cast<Constant>(And->getOperand(1)); 1814 Value *Or = And->getOperand(0); 1815 Value *A, *B, *LShr; 1816 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1817 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1818 unsigned UsesRemoved = 0; 1819 if (And->hasOneUse()) 1820 ++UsesRemoved; 1821 if (Or->hasOneUse()) 1822 ++UsesRemoved; 1823 if (LShr->hasOneUse()) 1824 ++UsesRemoved; 1825 1826 // Compute A & ((1 << B) | 1) 1827 Value *NewOr = nullptr; 1828 if (auto *C = dyn_cast<Constant>(B)) { 1829 if (UsesRemoved >= 1) 1830 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1831 } else { 1832 if (UsesRemoved >= 3) 1833 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1834 /*HasNUW=*/true), 1835 One, Or->getName()); 1836 } 1837 if (NewOr) { 1838 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1839 return replaceOperand(Cmp, 0, NewAnd); 1840 } 1841 } 1842 } 1843 1844 return nullptr; 1845 } 1846 1847 /// Fold icmp (and X, Y), C. 1848 Instruction *InstCombinerImpl::foldICmpAndConstant(ICmpInst &Cmp, 1849 BinaryOperator *And, 1850 const APInt &C) { 1851 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1852 return I; 1853 1854 // TODO: These all require that Y is constant too, so refactor with the above. 1855 1856 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1857 Value *X = And->getOperand(0); 1858 Value *Y = And->getOperand(1); 1859 if (auto *LI = dyn_cast<LoadInst>(X)) 1860 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1861 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1862 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 1863 !LI->isVolatile() && isa<ConstantInt>(Y)) { 1864 ConstantInt *C2 = cast<ConstantInt>(Y); 1865 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, Cmp, C2)) 1866 return Res; 1867 } 1868 1869 if (!Cmp.isEquality()) 1870 return nullptr; 1871 1872 // X & -C == -C -> X > u ~C 1873 // X & -C != -C -> X <= u ~C 1874 // iff C is a power of 2 1875 if (Cmp.getOperand(1) == Y && (-C).isPowerOf2()) { 1876 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT 1877 : CmpInst::ICMP_ULE; 1878 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1879 } 1880 1881 // (X & C2) == 0 -> (trunc X) >= 0 1882 // (X & C2) != 0 -> (trunc X) < 0 1883 // iff C2 is a power of 2 and it masks the sign bit of a legal integer type. 1884 const APInt *C2; 1885 if (And->hasOneUse() && C.isNullValue() && match(Y, m_APInt(C2))) { 1886 int32_t ExactLogBase2 = C2->exactLogBase2(); 1887 if (ExactLogBase2 != -1 && DL.isLegalInteger(ExactLogBase2 + 1)) { 1888 Type *NTy = IntegerType::get(Cmp.getContext(), ExactLogBase2 + 1); 1889 if (auto *AndVTy = dyn_cast<VectorType>(And->getType())) 1890 NTy = VectorType::get(NTy, AndVTy->getElementCount()); 1891 Value *Trunc = Builder.CreateTrunc(X, NTy); 1892 auto NewPred = Cmp.getPredicate() == CmpInst::ICMP_EQ ? CmpInst::ICMP_SGE 1893 : CmpInst::ICMP_SLT; 1894 return new ICmpInst(NewPred, Trunc, Constant::getNullValue(NTy)); 1895 } 1896 } 1897 1898 return nullptr; 1899 } 1900 1901 /// Fold icmp (or X, Y), C. 1902 Instruction *InstCombinerImpl::foldICmpOrConstant(ICmpInst &Cmp, 1903 BinaryOperator *Or, 1904 const APInt &C) { 1905 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1906 if (C.isOneValue()) { 1907 // icmp slt signum(V) 1 --> icmp slt V, 1 1908 Value *V = nullptr; 1909 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1910 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1911 ConstantInt::get(V->getType(), 1)); 1912 } 1913 1914 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1915 const APInt *MaskC; 1916 if (match(OrOp1, m_APInt(MaskC)) && Cmp.isEquality()) { 1917 if (*MaskC == C && (C + 1).isPowerOf2()) { 1918 // X | C == C --> X <=u C 1919 // X | C != C --> X >u C 1920 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1921 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1922 return new ICmpInst(Pred, OrOp0, OrOp1); 1923 } 1924 1925 // More general: canonicalize 'equality with set bits mask' to 1926 // 'equality with clear bits mask'. 1927 // (X | MaskC) == C --> (X & ~MaskC) == C ^ MaskC 1928 // (X | MaskC) != C --> (X & ~MaskC) != C ^ MaskC 1929 if (Or->hasOneUse()) { 1930 Value *And = Builder.CreateAnd(OrOp0, ~(*MaskC)); 1931 Constant *NewC = ConstantInt::get(Or->getType(), C ^ (*MaskC)); 1932 return new ICmpInst(Pred, And, NewC); 1933 } 1934 } 1935 1936 if (!Cmp.isEquality() || !C.isNullValue() || !Or->hasOneUse()) 1937 return nullptr; 1938 1939 Value *P, *Q; 1940 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1941 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1942 // -> and (icmp eq P, null), (icmp eq Q, null). 1943 Value *CmpP = 1944 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1945 Value *CmpQ = 1946 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1947 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1948 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1949 } 1950 1951 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1952 // a shorter form that has more potential to be folded even further. 1953 Value *X1, *X2, *X3, *X4; 1954 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1955 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1956 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1957 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1958 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1959 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1960 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1961 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1962 } 1963 1964 return nullptr; 1965 } 1966 1967 /// Fold icmp (mul X, Y), C. 1968 Instruction *InstCombinerImpl::foldICmpMulConstant(ICmpInst &Cmp, 1969 BinaryOperator *Mul, 1970 const APInt &C) { 1971 const APInt *MulC; 1972 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1973 return nullptr; 1974 1975 // If this is a test of the sign bit and the multiply is sign-preserving with 1976 // a constant operand, use the multiply LHS operand instead. 1977 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1978 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1979 if (MulC->isNegative()) 1980 Pred = ICmpInst::getSwappedPredicate(Pred); 1981 return new ICmpInst(Pred, Mul->getOperand(0), 1982 Constant::getNullValue(Mul->getType())); 1983 } 1984 1985 // If the multiply does not wrap, try to divide the compare constant by the 1986 // multiplication factor. 1987 if (Cmp.isEquality() && !MulC->isNullValue()) { 1988 // (mul nsw X, MulC) == C --> X == C /s MulC 1989 if (Mul->hasNoSignedWrap() && C.srem(*MulC).isNullValue()) { 1990 Constant *NewC = ConstantInt::get(Mul->getType(), C.sdiv(*MulC)); 1991 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 1992 } 1993 // (mul nuw X, MulC) == C --> X == C /u MulC 1994 if (Mul->hasNoUnsignedWrap() && C.urem(*MulC).isNullValue()) { 1995 Constant *NewC = ConstantInt::get(Mul->getType(), C.udiv(*MulC)); 1996 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 1997 } 1998 } 1999 2000 return nullptr; 2001 } 2002 2003 /// Fold icmp (shl 1, Y), C. 2004 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 2005 const APInt &C) { 2006 Value *Y; 2007 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 2008 return nullptr; 2009 2010 Type *ShiftType = Shl->getType(); 2011 unsigned TypeBits = C.getBitWidth(); 2012 bool CIsPowerOf2 = C.isPowerOf2(); 2013 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2014 if (Cmp.isUnsigned()) { 2015 // (1 << Y) pred C -> Y pred Log2(C) 2016 if (!CIsPowerOf2) { 2017 // (1 << Y) < 30 -> Y <= 4 2018 // (1 << Y) <= 30 -> Y <= 4 2019 // (1 << Y) >= 30 -> Y > 4 2020 // (1 << Y) > 30 -> Y > 4 2021 if (Pred == ICmpInst::ICMP_ULT) 2022 Pred = ICmpInst::ICMP_ULE; 2023 else if (Pred == ICmpInst::ICMP_UGE) 2024 Pred = ICmpInst::ICMP_UGT; 2025 } 2026 2027 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 2028 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 2029 unsigned CLog2 = C.logBase2(); 2030 if (CLog2 == TypeBits - 1) { 2031 if (Pred == ICmpInst::ICMP_UGE) 2032 Pred = ICmpInst::ICMP_EQ; 2033 else if (Pred == ICmpInst::ICMP_ULT) 2034 Pred = ICmpInst::ICMP_NE; 2035 } 2036 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 2037 } else if (Cmp.isSigned()) { 2038 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 2039 if (C.isAllOnesValue()) { 2040 // (1 << Y) <= -1 -> Y == 31 2041 if (Pred == ICmpInst::ICMP_SLE) 2042 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2043 2044 // (1 << Y) > -1 -> Y != 31 2045 if (Pred == ICmpInst::ICMP_SGT) 2046 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2047 } else if (!C) { 2048 // (1 << Y) < 0 -> Y == 31 2049 // (1 << Y) <= 0 -> Y == 31 2050 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 2051 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2052 2053 // (1 << Y) >= 0 -> Y != 31 2054 // (1 << Y) > 0 -> Y != 31 2055 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 2056 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2057 } 2058 } else if (Cmp.isEquality() && CIsPowerOf2) { 2059 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 2060 } 2061 2062 return nullptr; 2063 } 2064 2065 /// Fold icmp (shl X, Y), C. 2066 Instruction *InstCombinerImpl::foldICmpShlConstant(ICmpInst &Cmp, 2067 BinaryOperator *Shl, 2068 const APInt &C) { 2069 const APInt *ShiftVal; 2070 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 2071 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 2072 2073 const APInt *ShiftAmt; 2074 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 2075 return foldICmpShlOne(Cmp, Shl, C); 2076 2077 // Check that the shift amount is in range. If not, don't perform undefined 2078 // shifts. When the shift is visited, it will be simplified. 2079 unsigned TypeBits = C.getBitWidth(); 2080 if (ShiftAmt->uge(TypeBits)) 2081 return nullptr; 2082 2083 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2084 Value *X = Shl->getOperand(0); 2085 Type *ShType = Shl->getType(); 2086 2087 // NSW guarantees that we are only shifting out sign bits from the high bits, 2088 // so we can ASHR the compare constant without needing a mask and eliminate 2089 // the shift. 2090 if (Shl->hasNoSignedWrap()) { 2091 if (Pred == ICmpInst::ICMP_SGT) { 2092 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2093 APInt ShiftedC = C.ashr(*ShiftAmt); 2094 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2095 } 2096 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2097 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2098 APInt ShiftedC = C.ashr(*ShiftAmt); 2099 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2100 } 2101 if (Pred == ICmpInst::ICMP_SLT) { 2102 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2103 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2104 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2105 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2106 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2107 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2108 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2109 } 2110 // If this is a signed comparison to 0 and the shift is sign preserving, 2111 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2112 // do that if we're sure to not continue on in this function. 2113 if (isSignTest(Pred, C)) 2114 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2115 } 2116 2117 // NUW guarantees that we are only shifting out zero bits from the high bits, 2118 // so we can LSHR the compare constant without needing a mask and eliminate 2119 // the shift. 2120 if (Shl->hasNoUnsignedWrap()) { 2121 if (Pred == ICmpInst::ICMP_UGT) { 2122 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2123 APInt ShiftedC = C.lshr(*ShiftAmt); 2124 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2125 } 2126 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2127 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2128 APInt ShiftedC = C.lshr(*ShiftAmt); 2129 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2130 } 2131 if (Pred == ICmpInst::ICMP_ULT) { 2132 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2133 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2134 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2135 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2136 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2137 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2138 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2139 } 2140 } 2141 2142 if (Cmp.isEquality() && Shl->hasOneUse()) { 2143 // Strength-reduce the shift into an 'and'. 2144 Constant *Mask = ConstantInt::get( 2145 ShType, 2146 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2147 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2148 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2149 return new ICmpInst(Pred, And, LShrC); 2150 } 2151 2152 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2153 bool TrueIfSigned = false; 2154 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2155 // (X << 31) <s 0 --> (X & 1) != 0 2156 Constant *Mask = ConstantInt::get( 2157 ShType, 2158 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2159 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2160 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2161 And, Constant::getNullValue(ShType)); 2162 } 2163 2164 // Simplify 'shl' inequality test into 'and' equality test. 2165 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2166 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2167 if ((C + 1).isPowerOf2() && 2168 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2169 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2170 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2171 : ICmpInst::ICMP_NE, 2172 And, Constant::getNullValue(ShType)); 2173 } 2174 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2175 if (C.isPowerOf2() && 2176 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2177 Value *And = 2178 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2179 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2180 : ICmpInst::ICMP_NE, 2181 And, Constant::getNullValue(ShType)); 2182 } 2183 } 2184 2185 // Transform (icmp pred iM (shl iM %v, N), C) 2186 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2187 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2188 // This enables us to get rid of the shift in favor of a trunc that may be 2189 // free on the target. It has the additional benefit of comparing to a 2190 // smaller constant that may be more target-friendly. 2191 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2192 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2193 DL.isLegalInteger(TypeBits - Amt)) { 2194 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2195 if (auto *ShVTy = dyn_cast<VectorType>(ShType)) 2196 TruncTy = VectorType::get(TruncTy, ShVTy->getElementCount()); 2197 Constant *NewC = 2198 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2199 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2200 } 2201 2202 return nullptr; 2203 } 2204 2205 /// Fold icmp ({al}shr X, Y), C. 2206 Instruction *InstCombinerImpl::foldICmpShrConstant(ICmpInst &Cmp, 2207 BinaryOperator *Shr, 2208 const APInt &C) { 2209 // An exact shr only shifts out zero bits, so: 2210 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2211 Value *X = Shr->getOperand(0); 2212 CmpInst::Predicate Pred = Cmp.getPredicate(); 2213 if (Cmp.isEquality() && Shr->isExact() && Shr->hasOneUse() && 2214 C.isNullValue()) 2215 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2216 2217 const APInt *ShiftVal; 2218 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2219 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2220 2221 const APInt *ShiftAmt; 2222 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2223 return nullptr; 2224 2225 // Check that the shift amount is in range. If not, don't perform undefined 2226 // shifts. When the shift is visited it will be simplified. 2227 unsigned TypeBits = C.getBitWidth(); 2228 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2229 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2230 return nullptr; 2231 2232 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2233 bool IsExact = Shr->isExact(); 2234 Type *ShrTy = Shr->getType(); 2235 // TODO: If we could guarantee that InstSimplify would handle all of the 2236 // constant-value-based preconditions in the folds below, then we could assert 2237 // those conditions rather than checking them. This is difficult because of 2238 // undef/poison (PR34838). 2239 if (IsAShr) { 2240 if (Pred == CmpInst::ICMP_SLT || (Pred == CmpInst::ICMP_SGT && IsExact)) { 2241 // icmp slt (ashr X, ShAmtC), C --> icmp slt X, (C << ShAmtC) 2242 // icmp sgt (ashr exact X, ShAmtC), C --> icmp sgt X, (C << ShAmtC) 2243 APInt ShiftedC = C.shl(ShAmtVal); 2244 if (ShiftedC.ashr(ShAmtVal) == C) 2245 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2246 } 2247 if (Pred == CmpInst::ICMP_SGT) { 2248 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2249 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2250 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2251 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2252 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2253 } 2254 2255 // If the compare constant has significant bits above the lowest sign-bit, 2256 // then convert an unsigned cmp to a test of the sign-bit: 2257 // (ashr X, ShiftC) u> C --> X s< 0 2258 // (ashr X, ShiftC) u< C --> X s> -1 2259 if (C.getBitWidth() > 2 && C.getNumSignBits() <= ShAmtVal) { 2260 if (Pred == CmpInst::ICMP_UGT) { 2261 return new ICmpInst(CmpInst::ICMP_SLT, X, 2262 ConstantInt::getNullValue(ShrTy)); 2263 } 2264 if (Pred == CmpInst::ICMP_ULT) { 2265 return new ICmpInst(CmpInst::ICMP_SGT, X, 2266 ConstantInt::getAllOnesValue(ShrTy)); 2267 } 2268 } 2269 } else { 2270 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2271 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2272 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2273 APInt ShiftedC = C.shl(ShAmtVal); 2274 if (ShiftedC.lshr(ShAmtVal) == C) 2275 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2276 } 2277 if (Pred == CmpInst::ICMP_UGT) { 2278 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2279 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2280 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2281 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2282 } 2283 } 2284 2285 if (!Cmp.isEquality()) 2286 return nullptr; 2287 2288 // Handle equality comparisons of shift-by-constant. 2289 2290 // If the comparison constant changes with the shift, the comparison cannot 2291 // succeed (bits of the comparison constant cannot match the shifted value). 2292 // This should be known by InstSimplify and already be folded to true/false. 2293 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2294 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2295 "Expected icmp+shr simplify did not occur."); 2296 2297 // If the bits shifted out are known zero, compare the unshifted value: 2298 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2299 if (Shr->isExact()) 2300 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2301 2302 if (C.isNullValue()) { 2303 // == 0 is u< 1. 2304 if (Pred == CmpInst::ICMP_EQ) 2305 return new ICmpInst(CmpInst::ICMP_ULT, X, 2306 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal))); 2307 else 2308 return new ICmpInst(CmpInst::ICMP_UGT, X, 2309 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal) - 1)); 2310 } 2311 2312 if (Shr->hasOneUse()) { 2313 // Canonicalize the shift into an 'and': 2314 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2315 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2316 Constant *Mask = ConstantInt::get(ShrTy, Val); 2317 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2318 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2319 } 2320 2321 return nullptr; 2322 } 2323 2324 Instruction *InstCombinerImpl::foldICmpSRemConstant(ICmpInst &Cmp, 2325 BinaryOperator *SRem, 2326 const APInt &C) { 2327 // Match an 'is positive' or 'is negative' comparison of remainder by a 2328 // constant power-of-2 value: 2329 // (X % pow2C) sgt/slt 0 2330 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 2331 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT) 2332 return nullptr; 2333 2334 // TODO: The one-use check is standard because we do not typically want to 2335 // create longer instruction sequences, but this might be a special-case 2336 // because srem is not good for analysis or codegen. 2337 if (!SRem->hasOneUse()) 2338 return nullptr; 2339 2340 const APInt *DivisorC; 2341 if (!C.isNullValue() || !match(SRem->getOperand(1), m_Power2(DivisorC))) 2342 return nullptr; 2343 2344 // Mask off the sign bit and the modulo bits (low-bits). 2345 Type *Ty = SRem->getType(); 2346 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits()); 2347 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1)); 2348 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC); 2349 2350 // For 'is positive?' check that the sign-bit is clear and at least 1 masked 2351 // bit is set. Example: 2352 // (i8 X % 32) s> 0 --> (X & 159) s> 0 2353 if (Pred == ICmpInst::ICMP_SGT) 2354 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty)); 2355 2356 // For 'is negative?' check that the sign-bit is set and at least 1 masked 2357 // bit is set. Example: 2358 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768 2359 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask)); 2360 } 2361 2362 /// Fold icmp (udiv X, Y), C. 2363 Instruction *InstCombinerImpl::foldICmpUDivConstant(ICmpInst &Cmp, 2364 BinaryOperator *UDiv, 2365 const APInt &C) { 2366 const APInt *C2; 2367 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2368 return nullptr; 2369 2370 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2371 2372 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2373 Value *Y = UDiv->getOperand(1); 2374 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2375 assert(!C.isMaxValue() && 2376 "icmp ugt X, UINT_MAX should have been simplified already."); 2377 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2378 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2379 } 2380 2381 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2382 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2383 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2384 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2385 ConstantInt::get(Y->getType(), C2->udiv(C))); 2386 } 2387 2388 return nullptr; 2389 } 2390 2391 /// Fold icmp ({su}div X, Y), C. 2392 Instruction *InstCombinerImpl::foldICmpDivConstant(ICmpInst &Cmp, 2393 BinaryOperator *Div, 2394 const APInt &C) { 2395 // Fold: icmp pred ([us]div X, C2), C -> range test 2396 // Fold this div into the comparison, producing a range check. 2397 // Determine, based on the divide type, what the range is being 2398 // checked. If there is an overflow on the low or high side, remember 2399 // it, otherwise compute the range [low, hi) bounding the new value. 2400 // See: InsertRangeTest above for the kinds of replacements possible. 2401 const APInt *C2; 2402 if (!match(Div->getOperand(1), m_APInt(C2))) 2403 return nullptr; 2404 2405 // FIXME: If the operand types don't match the type of the divide 2406 // then don't attempt this transform. The code below doesn't have the 2407 // logic to deal with a signed divide and an unsigned compare (and 2408 // vice versa). This is because (x /s C2) <s C produces different 2409 // results than (x /s C2) <u C or (x /u C2) <s C or even 2410 // (x /u C2) <u C. Simply casting the operands and result won't 2411 // work. :( The if statement below tests that condition and bails 2412 // if it finds it. 2413 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2414 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2415 return nullptr; 2416 2417 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2418 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2419 // division-by-constant cases should be present, we can not assert that they 2420 // have happened before we reach this icmp instruction. 2421 if (C2->isNullValue() || C2->isOneValue() || 2422 (DivIsSigned && C2->isAllOnesValue())) 2423 return nullptr; 2424 2425 // Compute Prod = C * C2. We are essentially solving an equation of 2426 // form X / C2 = C. We solve for X by multiplying C2 and C. 2427 // By solving for X, we can turn this into a range check instead of computing 2428 // a divide. 2429 APInt Prod = C * *C2; 2430 2431 // Determine if the product overflows by seeing if the product is not equal to 2432 // the divide. Make sure we do the same kind of divide as in the LHS 2433 // instruction that we're folding. 2434 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2435 2436 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2437 2438 // If the division is known to be exact, then there is no remainder from the 2439 // divide, so the covered range size is unit, otherwise it is the divisor. 2440 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2441 2442 // Figure out the interval that is being checked. For example, a comparison 2443 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2444 // Compute this interval based on the constants involved and the signedness of 2445 // the compare/divide. This computes a half-open interval, keeping track of 2446 // whether either value in the interval overflows. After analysis each 2447 // overflow variable is set to 0 if it's corresponding bound variable is valid 2448 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2449 int LoOverflow = 0, HiOverflow = 0; 2450 APInt LoBound, HiBound; 2451 2452 if (!DivIsSigned) { // udiv 2453 // e.g. X/5 op 3 --> [15, 20) 2454 LoBound = Prod; 2455 HiOverflow = LoOverflow = ProdOV; 2456 if (!HiOverflow) { 2457 // If this is not an exact divide, then many values in the range collapse 2458 // to the same result value. 2459 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2460 } 2461 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2462 if (C.isNullValue()) { // (X / pos) op 0 2463 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2464 LoBound = -(RangeSize - 1); 2465 HiBound = RangeSize; 2466 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2467 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2468 HiOverflow = LoOverflow = ProdOV; 2469 if (!HiOverflow) 2470 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2471 } else { // (X / pos) op neg 2472 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2473 HiBound = Prod + 1; 2474 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2475 if (!LoOverflow) { 2476 APInt DivNeg = -RangeSize; 2477 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2478 } 2479 } 2480 } else if (C2->isNegative()) { // Divisor is < 0. 2481 if (Div->isExact()) 2482 RangeSize.negate(); 2483 if (C.isNullValue()) { // (X / neg) op 0 2484 // e.g. X/-5 op 0 --> [-4, 5) 2485 LoBound = RangeSize + 1; 2486 HiBound = -RangeSize; 2487 if (HiBound == *C2) { // -INTMIN = INTMIN 2488 HiOverflow = 1; // [INTMIN+1, overflow) 2489 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2490 } 2491 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2492 // e.g. X/-5 op 3 --> [-19, -14) 2493 HiBound = Prod + 1; 2494 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2495 if (!LoOverflow) 2496 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2497 } else { // (X / neg) op neg 2498 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2499 LoOverflow = HiOverflow = ProdOV; 2500 if (!HiOverflow) 2501 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2502 } 2503 2504 // Dividing by a negative swaps the condition. LT <-> GT 2505 Pred = ICmpInst::getSwappedPredicate(Pred); 2506 } 2507 2508 Value *X = Div->getOperand(0); 2509 switch (Pred) { 2510 default: llvm_unreachable("Unhandled icmp opcode!"); 2511 case ICmpInst::ICMP_EQ: 2512 if (LoOverflow && HiOverflow) 2513 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2514 if (HiOverflow) 2515 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2516 ICmpInst::ICMP_UGE, X, 2517 ConstantInt::get(Div->getType(), LoBound)); 2518 if (LoOverflow) 2519 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2520 ICmpInst::ICMP_ULT, X, 2521 ConstantInt::get(Div->getType(), HiBound)); 2522 return replaceInstUsesWith( 2523 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2524 case ICmpInst::ICMP_NE: 2525 if (LoOverflow && HiOverflow) 2526 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2527 if (HiOverflow) 2528 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2529 ICmpInst::ICMP_ULT, X, 2530 ConstantInt::get(Div->getType(), LoBound)); 2531 if (LoOverflow) 2532 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2533 ICmpInst::ICMP_UGE, X, 2534 ConstantInt::get(Div->getType(), HiBound)); 2535 return replaceInstUsesWith(Cmp, 2536 insertRangeTest(X, LoBound, HiBound, 2537 DivIsSigned, false)); 2538 case ICmpInst::ICMP_ULT: 2539 case ICmpInst::ICMP_SLT: 2540 if (LoOverflow == +1) // Low bound is greater than input range. 2541 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2542 if (LoOverflow == -1) // Low bound is less than input range. 2543 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2544 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2545 case ICmpInst::ICMP_UGT: 2546 case ICmpInst::ICMP_SGT: 2547 if (HiOverflow == +1) // High bound greater than input range. 2548 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2549 if (HiOverflow == -1) // High bound less than input range. 2550 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2551 if (Pred == ICmpInst::ICMP_UGT) 2552 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2553 ConstantInt::get(Div->getType(), HiBound)); 2554 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2555 ConstantInt::get(Div->getType(), HiBound)); 2556 } 2557 2558 return nullptr; 2559 } 2560 2561 /// Fold icmp (sub X, Y), C. 2562 Instruction *InstCombinerImpl::foldICmpSubConstant(ICmpInst &Cmp, 2563 BinaryOperator *Sub, 2564 const APInt &C) { 2565 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2566 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2567 const APInt *C2; 2568 APInt SubResult; 2569 2570 // icmp eq/ne (sub C, Y), C -> icmp eq/ne Y, 0 2571 if (match(X, m_APInt(C2)) && *C2 == C && Cmp.isEquality()) 2572 return new ICmpInst(Cmp.getPredicate(), Y, 2573 ConstantInt::get(Y->getType(), 0)); 2574 2575 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2576 if (match(X, m_APInt(C2)) && 2577 ((Cmp.isUnsigned() && Sub->hasNoUnsignedWrap()) || 2578 (Cmp.isSigned() && Sub->hasNoSignedWrap())) && 2579 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2580 return new ICmpInst(Cmp.getSwappedPredicate(), Y, 2581 ConstantInt::get(Y->getType(), SubResult)); 2582 2583 // The following transforms are only worth it if the only user of the subtract 2584 // is the icmp. 2585 if (!Sub->hasOneUse()) 2586 return nullptr; 2587 2588 if (Sub->hasNoSignedWrap()) { 2589 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2590 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnesValue()) 2591 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2592 2593 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2594 if (Pred == ICmpInst::ICMP_SGT && C.isNullValue()) 2595 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2596 2597 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2598 if (Pred == ICmpInst::ICMP_SLT && C.isNullValue()) 2599 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2600 2601 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2602 if (Pred == ICmpInst::ICMP_SLT && C.isOneValue()) 2603 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2604 } 2605 2606 if (!match(X, m_APInt(C2))) 2607 return nullptr; 2608 2609 // C2 - Y <u C -> (Y | (C - 1)) == C2 2610 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2611 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2612 (*C2 & (C - 1)) == (C - 1)) 2613 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2614 2615 // C2 - Y >u C -> (Y | C) != C2 2616 // iff C2 & C == C and C + 1 is a power of 2 2617 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2618 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2619 2620 return nullptr; 2621 } 2622 2623 /// Fold icmp (add X, Y), C. 2624 Instruction *InstCombinerImpl::foldICmpAddConstant(ICmpInst &Cmp, 2625 BinaryOperator *Add, 2626 const APInt &C) { 2627 Value *Y = Add->getOperand(1); 2628 const APInt *C2; 2629 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2630 return nullptr; 2631 2632 // Fold icmp pred (add X, C2), C. 2633 Value *X = Add->getOperand(0); 2634 Type *Ty = Add->getType(); 2635 CmpInst::Predicate Pred = Cmp.getPredicate(); 2636 2637 // If the add does not wrap, we can always adjust the compare by subtracting 2638 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2639 // are canonicalized to SGT/SLT/UGT/ULT. 2640 if ((Add->hasNoSignedWrap() && 2641 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2642 (Add->hasNoUnsignedWrap() && 2643 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2644 bool Overflow; 2645 APInt NewC = 2646 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2647 // If there is overflow, the result must be true or false. 2648 // TODO: Can we assert there is no overflow because InstSimplify always 2649 // handles those cases? 2650 if (!Overflow) 2651 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2652 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2653 } 2654 2655 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2656 const APInt &Upper = CR.getUpper(); 2657 const APInt &Lower = CR.getLower(); 2658 if (Cmp.isSigned()) { 2659 if (Lower.isSignMask()) 2660 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2661 if (Upper.isSignMask()) 2662 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2663 } else { 2664 if (Lower.isMinValue()) 2665 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2666 if (Upper.isMinValue()) 2667 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2668 } 2669 2670 if (!Add->hasOneUse()) 2671 return nullptr; 2672 2673 // X+C <u C2 -> (X & -C2) == C 2674 // iff C & (C2-1) == 0 2675 // C2 is a power of 2 2676 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2677 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2678 ConstantExpr::getNeg(cast<Constant>(Y))); 2679 2680 // X+C >u C2 -> (X & ~C2) != C 2681 // iff C & C2 == 0 2682 // C2+1 is a power of 2 2683 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2684 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2685 ConstantExpr::getNeg(cast<Constant>(Y))); 2686 2687 return nullptr; 2688 } 2689 2690 bool InstCombinerImpl::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2691 Value *&RHS, ConstantInt *&Less, 2692 ConstantInt *&Equal, 2693 ConstantInt *&Greater) { 2694 // TODO: Generalize this to work with other comparison idioms or ensure 2695 // they get canonicalized into this form. 2696 2697 // select i1 (a == b), 2698 // i32 Equal, 2699 // i32 (select i1 (a < b), i32 Less, i32 Greater) 2700 // where Equal, Less and Greater are placeholders for any three constants. 2701 ICmpInst::Predicate PredA; 2702 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) || 2703 !ICmpInst::isEquality(PredA)) 2704 return false; 2705 Value *EqualVal = SI->getTrueValue(); 2706 Value *UnequalVal = SI->getFalseValue(); 2707 // We still can get non-canonical predicate here, so canonicalize. 2708 if (PredA == ICmpInst::ICMP_NE) 2709 std::swap(EqualVal, UnequalVal); 2710 if (!match(EqualVal, m_ConstantInt(Equal))) 2711 return false; 2712 ICmpInst::Predicate PredB; 2713 Value *LHS2, *RHS2; 2714 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)), 2715 m_ConstantInt(Less), m_ConstantInt(Greater)))) 2716 return false; 2717 // We can get predicate mismatch here, so canonicalize if possible: 2718 // First, ensure that 'LHS' match. 2719 if (LHS2 != LHS) { 2720 // x sgt y <--> y slt x 2721 std::swap(LHS2, RHS2); 2722 PredB = ICmpInst::getSwappedPredicate(PredB); 2723 } 2724 if (LHS2 != LHS) 2725 return false; 2726 // We also need to canonicalize 'RHS'. 2727 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) { 2728 // x sgt C-1 <--> x sge C <--> not(x slt C) 2729 auto FlippedStrictness = 2730 InstCombiner::getFlippedStrictnessPredicateAndConstant( 2731 PredB, cast<Constant>(RHS2)); 2732 if (!FlippedStrictness) 2733 return false; 2734 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && "Sanity check"); 2735 RHS2 = FlippedStrictness->second; 2736 // And kind-of perform the result swap. 2737 std::swap(Less, Greater); 2738 PredB = ICmpInst::ICMP_SLT; 2739 } 2740 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2; 2741 } 2742 2743 Instruction *InstCombinerImpl::foldICmpSelectConstant(ICmpInst &Cmp, 2744 SelectInst *Select, 2745 ConstantInt *C) { 2746 2747 assert(C && "Cmp RHS should be a constant int!"); 2748 // If we're testing a constant value against the result of a three way 2749 // comparison, the result can be expressed directly in terms of the 2750 // original values being compared. Note: We could possibly be more 2751 // aggressive here and remove the hasOneUse test. The original select is 2752 // really likely to simplify or sink when we remove a test of the result. 2753 Value *OrigLHS, *OrigRHS; 2754 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2755 if (Cmp.hasOneUse() && 2756 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2757 C3GreaterThan)) { 2758 assert(C1LessThan && C2Equal && C3GreaterThan); 2759 2760 bool TrueWhenLessThan = 2761 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2762 ->isAllOnesValue(); 2763 bool TrueWhenEqual = 2764 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2765 ->isAllOnesValue(); 2766 bool TrueWhenGreaterThan = 2767 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2768 ->isAllOnesValue(); 2769 2770 // This generates the new instruction that will replace the original Cmp 2771 // Instruction. Instead of enumerating the various combinations when 2772 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2773 // false, we rely on chaining of ORs and future passes of InstCombine to 2774 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2775 2776 // When none of the three constants satisfy the predicate for the RHS (C), 2777 // the entire original Cmp can be simplified to a false. 2778 Value *Cond = Builder.getFalse(); 2779 if (TrueWhenLessThan) 2780 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2781 OrigLHS, OrigRHS)); 2782 if (TrueWhenEqual) 2783 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2784 OrigLHS, OrigRHS)); 2785 if (TrueWhenGreaterThan) 2786 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2787 OrigLHS, OrigRHS)); 2788 2789 return replaceInstUsesWith(Cmp, Cond); 2790 } 2791 return nullptr; 2792 } 2793 2794 static Instruction *foldICmpBitCast(ICmpInst &Cmp, 2795 InstCombiner::BuilderTy &Builder) { 2796 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2797 if (!Bitcast) 2798 return nullptr; 2799 2800 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2801 Value *Op1 = Cmp.getOperand(1); 2802 Value *BCSrcOp = Bitcast->getOperand(0); 2803 2804 // Make sure the bitcast doesn't change the number of vector elements. 2805 if (Bitcast->getSrcTy()->getScalarSizeInBits() == 2806 Bitcast->getDestTy()->getScalarSizeInBits()) { 2807 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2808 Value *X; 2809 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2810 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2811 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2812 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2813 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2814 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2815 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2816 match(Op1, m_Zero())) 2817 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2818 2819 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2820 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2821 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2822 2823 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2824 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2825 return new ICmpInst(Pred, X, 2826 ConstantInt::getAllOnesValue(X->getType())); 2827 } 2828 2829 // Zero-equality checks are preserved through unsigned floating-point casts: 2830 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2831 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2832 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2833 if (Cmp.isEquality() && match(Op1, m_Zero())) 2834 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2835 2836 // If this is a sign-bit test of a bitcast of a casted FP value, eliminate 2837 // the FP extend/truncate because that cast does not change the sign-bit. 2838 // This is true for all standard IEEE-754 types and the X86 80-bit type. 2839 // The sign-bit is always the most significant bit in those types. 2840 const APInt *C; 2841 bool TrueIfSigned; 2842 if (match(Op1, m_APInt(C)) && Bitcast->hasOneUse() && 2843 InstCombiner::isSignBitCheck(Pred, *C, TrueIfSigned)) { 2844 if (match(BCSrcOp, m_FPExt(m_Value(X))) || 2845 match(BCSrcOp, m_FPTrunc(m_Value(X)))) { 2846 // (bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0 2847 // (bitcast (fpext/fptrunc X)) to iX) > -1 --> (bitcast X to iY) > -1 2848 Type *XType = X->getType(); 2849 2850 // We can't currently handle Power style floating point operations here. 2851 if (!(XType->isPPC_FP128Ty() || BCSrcOp->getType()->isPPC_FP128Ty())) { 2852 2853 Type *NewType = Builder.getIntNTy(XType->getScalarSizeInBits()); 2854 if (auto *XVTy = dyn_cast<VectorType>(XType)) 2855 NewType = VectorType::get(NewType, XVTy->getElementCount()); 2856 Value *NewBitcast = Builder.CreateBitCast(X, NewType); 2857 if (TrueIfSigned) 2858 return new ICmpInst(ICmpInst::ICMP_SLT, NewBitcast, 2859 ConstantInt::getNullValue(NewType)); 2860 else 2861 return new ICmpInst(ICmpInst::ICMP_SGT, NewBitcast, 2862 ConstantInt::getAllOnesValue(NewType)); 2863 } 2864 } 2865 } 2866 } 2867 2868 // Test to see if the operands of the icmp are casted versions of other 2869 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2870 if (Bitcast->getType()->isPointerTy() && 2871 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2872 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2873 // so eliminate it as well. 2874 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2875 Op1 = BC2->getOperand(0); 2876 2877 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType()); 2878 return new ICmpInst(Pred, BCSrcOp, Op1); 2879 } 2880 2881 // Folding: icmp <pred> iN X, C 2882 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 2883 // and C is a splat of a K-bit pattern 2884 // and SC is a constant vector = <C', C', C', ..., C'> 2885 // Into: 2886 // %E = extractelement <M x iK> %vec, i32 C' 2887 // icmp <pred> iK %E, trunc(C) 2888 const APInt *C; 2889 if (!match(Cmp.getOperand(1), m_APInt(C)) || 2890 !Bitcast->getType()->isIntegerTy() || 2891 !Bitcast->getSrcTy()->isIntOrIntVectorTy()) 2892 return nullptr; 2893 2894 Value *Vec; 2895 ArrayRef<int> Mask; 2896 if (match(BCSrcOp, m_Shuffle(m_Value(Vec), m_Undef(), m_Mask(Mask)))) { 2897 // Check whether every element of Mask is the same constant 2898 if (is_splat(Mask)) { 2899 auto *VecTy = cast<VectorType>(BCSrcOp->getType()); 2900 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 2901 if (C->isSplat(EltTy->getBitWidth())) { 2902 // Fold the icmp based on the value of C 2903 // If C is M copies of an iK sized bit pattern, 2904 // then: 2905 // => %E = extractelement <N x iK> %vec, i32 Elem 2906 // icmp <pred> iK %SplatVal, <pattern> 2907 Value *Elem = Builder.getInt32(Mask[0]); 2908 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 2909 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 2910 return new ICmpInst(Pred, Extract, NewC); 2911 } 2912 } 2913 } 2914 return nullptr; 2915 } 2916 2917 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 2918 /// where X is some kind of instruction. 2919 Instruction *InstCombinerImpl::foldICmpInstWithConstant(ICmpInst &Cmp) { 2920 const APInt *C; 2921 if (!match(Cmp.getOperand(1), m_APInt(C))) 2922 return nullptr; 2923 2924 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 2925 switch (BO->getOpcode()) { 2926 case Instruction::Xor: 2927 if (Instruction *I = foldICmpXorConstant(Cmp, BO, *C)) 2928 return I; 2929 break; 2930 case Instruction::And: 2931 if (Instruction *I = foldICmpAndConstant(Cmp, BO, *C)) 2932 return I; 2933 break; 2934 case Instruction::Or: 2935 if (Instruction *I = foldICmpOrConstant(Cmp, BO, *C)) 2936 return I; 2937 break; 2938 case Instruction::Mul: 2939 if (Instruction *I = foldICmpMulConstant(Cmp, BO, *C)) 2940 return I; 2941 break; 2942 case Instruction::Shl: 2943 if (Instruction *I = foldICmpShlConstant(Cmp, BO, *C)) 2944 return I; 2945 break; 2946 case Instruction::LShr: 2947 case Instruction::AShr: 2948 if (Instruction *I = foldICmpShrConstant(Cmp, BO, *C)) 2949 return I; 2950 break; 2951 case Instruction::SRem: 2952 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, *C)) 2953 return I; 2954 break; 2955 case Instruction::UDiv: 2956 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, *C)) 2957 return I; 2958 LLVM_FALLTHROUGH; 2959 case Instruction::SDiv: 2960 if (Instruction *I = foldICmpDivConstant(Cmp, BO, *C)) 2961 return I; 2962 break; 2963 case Instruction::Sub: 2964 if (Instruction *I = foldICmpSubConstant(Cmp, BO, *C)) 2965 return I; 2966 break; 2967 case Instruction::Add: 2968 if (Instruction *I = foldICmpAddConstant(Cmp, BO, *C)) 2969 return I; 2970 break; 2971 default: 2972 break; 2973 } 2974 // TODO: These folds could be refactored to be part of the above calls. 2975 if (Instruction *I = foldICmpBinOpEqualityWithConstant(Cmp, BO, *C)) 2976 return I; 2977 } 2978 2979 // Match against CmpInst LHS being instructions other than binary operators. 2980 2981 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 2982 // For now, we only support constant integers while folding the 2983 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 2984 // similar to the cases handled by binary ops above. 2985 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 2986 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 2987 return I; 2988 } 2989 2990 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 2991 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 2992 return I; 2993 } 2994 2995 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 2996 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 2997 return I; 2998 2999 return nullptr; 3000 } 3001 3002 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 3003 /// icmp eq/ne BO, C. 3004 Instruction *InstCombinerImpl::foldICmpBinOpEqualityWithConstant( 3005 ICmpInst &Cmp, BinaryOperator *BO, const APInt &C) { 3006 // TODO: Some of these folds could work with arbitrary constants, but this 3007 // function is limited to scalar and vector splat constants. 3008 if (!Cmp.isEquality()) 3009 return nullptr; 3010 3011 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3012 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 3013 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 3014 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 3015 3016 switch (BO->getOpcode()) { 3017 case Instruction::SRem: 3018 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 3019 if (C.isNullValue() && BO->hasOneUse()) { 3020 const APInt *BOC; 3021 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 3022 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 3023 return new ICmpInst(Pred, NewRem, 3024 Constant::getNullValue(BO->getType())); 3025 } 3026 } 3027 break; 3028 case Instruction::Add: { 3029 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 3030 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3031 if (BO->hasOneUse()) 3032 return new ICmpInst(Pred, BOp0, ConstantExpr::getSub(RHS, BOC)); 3033 } else if (C.isNullValue()) { 3034 // Replace ((add A, B) != 0) with (A != -B) if A or B is 3035 // efficiently invertible, or if the add has just this one use. 3036 if (Value *NegVal = dyn_castNegVal(BOp1)) 3037 return new ICmpInst(Pred, BOp0, NegVal); 3038 if (Value *NegVal = dyn_castNegVal(BOp0)) 3039 return new ICmpInst(Pred, NegVal, BOp1); 3040 if (BO->hasOneUse()) { 3041 Value *Neg = Builder.CreateNeg(BOp1); 3042 Neg->takeName(BO); 3043 return new ICmpInst(Pred, BOp0, Neg); 3044 } 3045 } 3046 break; 3047 } 3048 case Instruction::Xor: 3049 if (BO->hasOneUse()) { 3050 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3051 // For the xor case, we can xor two constants together, eliminating 3052 // the explicit xor. 3053 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 3054 } else if (C.isNullValue()) { 3055 // Replace ((xor A, B) != 0) with (A != B) 3056 return new ICmpInst(Pred, BOp0, BOp1); 3057 } 3058 } 3059 break; 3060 case Instruction::Sub: 3061 if (BO->hasOneUse()) { 3062 // Only check for constant LHS here, as constant RHS will be canonicalized 3063 // to add and use the fold above. 3064 if (Constant *BOC = dyn_cast<Constant>(BOp0)) { 3065 // Replace ((sub BOC, B) != C) with (B != BOC-C). 3066 return new ICmpInst(Pred, BOp1, ConstantExpr::getSub(BOC, RHS)); 3067 } else if (C.isNullValue()) { 3068 // Replace ((sub A, B) != 0) with (A != B). 3069 return new ICmpInst(Pred, BOp0, BOp1); 3070 } 3071 } 3072 break; 3073 case Instruction::Or: { 3074 const APInt *BOC; 3075 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 3076 // Comparing if all bits outside of a constant mask are set? 3077 // Replace (X | C) == -1 with (X & ~C) == ~C. 3078 // This removes the -1 constant. 3079 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 3080 Value *And = Builder.CreateAnd(BOp0, NotBOC); 3081 return new ICmpInst(Pred, And, NotBOC); 3082 } 3083 break; 3084 } 3085 case Instruction::And: { 3086 const APInt *BOC; 3087 if (match(BOp1, m_APInt(BOC))) { 3088 // If we have ((X & C) == C), turn it into ((X & C) != 0). 3089 if (C == *BOC && C.isPowerOf2()) 3090 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 3091 BO, Constant::getNullValue(RHS->getType())); 3092 } 3093 break; 3094 } 3095 case Instruction::UDiv: 3096 if (C.isNullValue()) { 3097 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 3098 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3099 return new ICmpInst(NewPred, BOp1, BOp0); 3100 } 3101 break; 3102 default: 3103 break; 3104 } 3105 return nullptr; 3106 } 3107 3108 /// Fold an equality icmp with LLVM intrinsic and constant operand. 3109 Instruction *InstCombinerImpl::foldICmpEqIntrinsicWithConstant( 3110 ICmpInst &Cmp, IntrinsicInst *II, const APInt &C) { 3111 Type *Ty = II->getType(); 3112 unsigned BitWidth = C.getBitWidth(); 3113 switch (II->getIntrinsicID()) { 3114 case Intrinsic::abs: 3115 // abs(A) == 0 -> A == 0 3116 // abs(A) == INT_MIN -> A == INT_MIN 3117 if (C.isNullValue() || C.isMinSignedValue()) 3118 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3119 ConstantInt::get(Ty, C)); 3120 break; 3121 3122 case Intrinsic::bswap: 3123 // bswap(A) == C -> A == bswap(C) 3124 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3125 ConstantInt::get(Ty, C.byteSwap())); 3126 3127 case Intrinsic::ctlz: 3128 case Intrinsic::cttz: { 3129 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 3130 if (C == BitWidth) 3131 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3132 ConstantInt::getNullValue(Ty)); 3133 3134 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 3135 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 3136 // Limit to one use to ensure we don't increase instruction count. 3137 unsigned Num = C.getLimitedValue(BitWidth); 3138 if (Num != BitWidth && II->hasOneUse()) { 3139 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 3140 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 3141 : APInt::getHighBitsSet(BitWidth, Num + 1); 3142 APInt Mask2 = IsTrailing 3143 ? APInt::getOneBitSet(BitWidth, Num) 3144 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3145 return new ICmpInst(Cmp.getPredicate(), 3146 Builder.CreateAnd(II->getArgOperand(0), Mask1), 3147 ConstantInt::get(Ty, Mask2)); 3148 } 3149 break; 3150 } 3151 3152 case Intrinsic::ctpop: { 3153 // popcount(A) == 0 -> A == 0 and likewise for != 3154 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 3155 bool IsZero = C.isNullValue(); 3156 if (IsZero || C == BitWidth) 3157 return new ICmpInst(Cmp.getPredicate(), II->getArgOperand(0), 3158 IsZero ? Constant::getNullValue(Ty) : Constant::getAllOnesValue(Ty)); 3159 3160 break; 3161 } 3162 3163 case Intrinsic::uadd_sat: { 3164 // uadd.sat(a, b) == 0 -> (a | b) == 0 3165 if (C.isNullValue()) { 3166 Value *Or = Builder.CreateOr(II->getArgOperand(0), II->getArgOperand(1)); 3167 return new ICmpInst(Cmp.getPredicate(), Or, Constant::getNullValue(Ty)); 3168 } 3169 break; 3170 } 3171 3172 case Intrinsic::usub_sat: { 3173 // usub.sat(a, b) == 0 -> a <= b 3174 if (C.isNullValue()) { 3175 ICmpInst::Predicate NewPred = Cmp.getPredicate() == ICmpInst::ICMP_EQ 3176 ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3177 return new ICmpInst(NewPred, II->getArgOperand(0), II->getArgOperand(1)); 3178 } 3179 break; 3180 } 3181 default: 3182 break; 3183 } 3184 3185 return nullptr; 3186 } 3187 3188 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 3189 Instruction *InstCombinerImpl::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 3190 IntrinsicInst *II, 3191 const APInt &C) { 3192 if (Cmp.isEquality()) 3193 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 3194 3195 Type *Ty = II->getType(); 3196 unsigned BitWidth = C.getBitWidth(); 3197 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3198 switch (II->getIntrinsicID()) { 3199 case Intrinsic::ctpop: { 3200 // (ctpop X > BitWidth - 1) --> X == -1 3201 Value *X = II->getArgOperand(0); 3202 if (C == BitWidth - 1 && Pred == ICmpInst::ICMP_UGT) 3203 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, X, 3204 ConstantInt::getAllOnesValue(Ty)); 3205 // (ctpop X < BitWidth) --> X != -1 3206 if (C == BitWidth && Pred == ICmpInst::ICMP_ULT) 3207 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, X, 3208 ConstantInt::getAllOnesValue(Ty)); 3209 break; 3210 } 3211 case Intrinsic::ctlz: { 3212 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 3213 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3214 unsigned Num = C.getLimitedValue(); 3215 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3216 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 3217 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3218 } 3219 3220 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 3221 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3222 unsigned Num = C.getLimitedValue(); 3223 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 3224 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 3225 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3226 } 3227 break; 3228 } 3229 case Intrinsic::cttz: { 3230 // Limit to one use to ensure we don't increase instruction count. 3231 if (!II->hasOneUse()) 3232 return nullptr; 3233 3234 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 3235 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3236 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 3237 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 3238 Builder.CreateAnd(II->getArgOperand(0), Mask), 3239 ConstantInt::getNullValue(Ty)); 3240 } 3241 3242 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3243 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3244 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3245 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3246 Builder.CreateAnd(II->getArgOperand(0), Mask), 3247 ConstantInt::getNullValue(Ty)); 3248 } 3249 break; 3250 } 3251 default: 3252 break; 3253 } 3254 3255 return nullptr; 3256 } 3257 3258 /// Handle icmp with constant (but not simple integer constant) RHS. 3259 Instruction *InstCombinerImpl::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3260 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3261 Constant *RHSC = dyn_cast<Constant>(Op1); 3262 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3263 if (!RHSC || !LHSI) 3264 return nullptr; 3265 3266 switch (LHSI->getOpcode()) { 3267 case Instruction::GetElementPtr: 3268 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3269 if (RHSC->isNullValue() && 3270 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3271 return new ICmpInst( 3272 I.getPredicate(), LHSI->getOperand(0), 3273 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3274 break; 3275 case Instruction::PHI: 3276 // Only fold icmp into the PHI if the phi and icmp are in the same 3277 // block. If in the same block, we're encouraging jump threading. If 3278 // not, we are just pessimizing the code by making an i1 phi. 3279 if (LHSI->getParent() == I.getParent()) 3280 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3281 return NV; 3282 break; 3283 case Instruction::Select: { 3284 // If either operand of the select is a constant, we can fold the 3285 // comparison into the select arms, which will cause one to be 3286 // constant folded and the select turned into a bitwise or. 3287 Value *Op1 = nullptr, *Op2 = nullptr; 3288 ConstantInt *CI = nullptr; 3289 3290 auto SimplifyOp = [&](Value *V) { 3291 Value *Op = nullptr; 3292 if (Constant *C = dyn_cast<Constant>(V)) { 3293 Op = ConstantExpr::getICmp(I.getPredicate(), C, RHSC); 3294 } else if (RHSC->isNullValue()) { 3295 // If null is being compared, check if it can be further simplified. 3296 Op = SimplifyICmpInst(I.getPredicate(), V, RHSC, SQ); 3297 } 3298 return Op; 3299 }; 3300 Op1 = SimplifyOp(LHSI->getOperand(1)); 3301 if (Op1) 3302 CI = dyn_cast<ConstantInt>(Op1); 3303 3304 Op2 = SimplifyOp(LHSI->getOperand(2)); 3305 if (Op2) 3306 CI = dyn_cast<ConstantInt>(Op2); 3307 3308 // We only want to perform this transformation if it will not lead to 3309 // additional code. This is true if either both sides of the select 3310 // fold to a constant (in which case the icmp is replaced with a select 3311 // which will usually simplify) or this is the only user of the 3312 // select (in which case we are trading a select+icmp for a simpler 3313 // select+icmp) or all uses of the select can be replaced based on 3314 // dominance information ("Global cases"). 3315 bool Transform = false; 3316 if (Op1 && Op2) 3317 Transform = true; 3318 else if (Op1 || Op2) { 3319 // Local case 3320 if (LHSI->hasOneUse()) 3321 Transform = true; 3322 // Global cases 3323 else if (CI && !CI->isZero()) 3324 // When Op1 is constant try replacing select with second operand. 3325 // Otherwise Op2 is constant and try replacing select with first 3326 // operand. 3327 Transform = 3328 replacedSelectWithOperand(cast<SelectInst>(LHSI), &I, Op1 ? 2 : 1); 3329 } 3330 if (Transform) { 3331 if (!Op1) 3332 Op1 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(1), RHSC, 3333 I.getName()); 3334 if (!Op2) 3335 Op2 = Builder.CreateICmp(I.getPredicate(), LHSI->getOperand(2), RHSC, 3336 I.getName()); 3337 return SelectInst::Create(LHSI->getOperand(0), Op1, Op2); 3338 } 3339 break; 3340 } 3341 case Instruction::IntToPtr: 3342 // icmp pred inttoptr(X), null -> icmp pred X, 0 3343 if (RHSC->isNullValue() && 3344 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3345 return new ICmpInst( 3346 I.getPredicate(), LHSI->getOperand(0), 3347 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3348 break; 3349 3350 case Instruction::Load: 3351 // Try to optimize things like "A[i] > 4" to index computations. 3352 if (GetElementPtrInst *GEP = 3353 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) { 3354 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3355 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 3356 !cast<LoadInst>(LHSI)->isVolatile()) 3357 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 3358 return Res; 3359 } 3360 break; 3361 } 3362 3363 return nullptr; 3364 } 3365 3366 /// Some comparisons can be simplified. 3367 /// In this case, we are looking for comparisons that look like 3368 /// a check for a lossy truncation. 3369 /// Folds: 3370 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3371 /// Where Mask is some pattern that produces all-ones in low bits: 3372 /// (-1 >> y) 3373 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3374 /// ~(-1 << y) 3375 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3376 /// The Mask can be a constant, too. 3377 /// For some predicates, the operands are commutative. 3378 /// For others, x can only be on a specific side. 3379 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3380 InstCombiner::BuilderTy &Builder) { 3381 ICmpInst::Predicate SrcPred; 3382 Value *X, *M, *Y; 3383 auto m_VariableMask = m_CombineOr( 3384 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3385 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3386 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3387 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3388 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3389 if (!match(&I, m_c_ICmp(SrcPred, 3390 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3391 m_Deferred(X)))) 3392 return nullptr; 3393 3394 ICmpInst::Predicate DstPred; 3395 switch (SrcPred) { 3396 case ICmpInst::Predicate::ICMP_EQ: 3397 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3398 DstPred = ICmpInst::Predicate::ICMP_ULE; 3399 break; 3400 case ICmpInst::Predicate::ICMP_NE: 3401 // x & (-1 >> y) != x -> x u> (-1 >> y) 3402 DstPred = ICmpInst::Predicate::ICMP_UGT; 3403 break; 3404 case ICmpInst::Predicate::ICMP_ULT: 3405 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3406 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3407 DstPred = ICmpInst::Predicate::ICMP_UGT; 3408 break; 3409 case ICmpInst::Predicate::ICMP_UGE: 3410 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3411 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3412 DstPred = ICmpInst::Predicate::ICMP_ULE; 3413 break; 3414 case ICmpInst::Predicate::ICMP_SLT: 3415 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3416 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3417 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3418 return nullptr; 3419 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3420 return nullptr; 3421 DstPred = ICmpInst::Predicate::ICMP_SGT; 3422 break; 3423 case ICmpInst::Predicate::ICMP_SGE: 3424 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3425 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3426 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3427 return nullptr; 3428 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3429 return nullptr; 3430 DstPred = ICmpInst::Predicate::ICMP_SLE; 3431 break; 3432 case ICmpInst::Predicate::ICMP_SGT: 3433 case ICmpInst::Predicate::ICMP_SLE: 3434 return nullptr; 3435 case ICmpInst::Predicate::ICMP_UGT: 3436 case ICmpInst::Predicate::ICMP_ULE: 3437 llvm_unreachable("Instsimplify took care of commut. variant"); 3438 break; 3439 default: 3440 llvm_unreachable("All possible folds are handled."); 3441 } 3442 3443 // The mask value may be a vector constant that has undefined elements. But it 3444 // may not be safe to propagate those undefs into the new compare, so replace 3445 // those elements by copying an existing, defined, and safe scalar constant. 3446 Type *OpTy = M->getType(); 3447 auto *VecC = dyn_cast<Constant>(M); 3448 auto *OpVTy = dyn_cast<FixedVectorType>(OpTy); 3449 if (OpVTy && VecC && VecC->containsUndefOrPoisonElement()) { 3450 Constant *SafeReplacementConstant = nullptr; 3451 for (unsigned i = 0, e = OpVTy->getNumElements(); i != e; ++i) { 3452 if (!isa<UndefValue>(VecC->getAggregateElement(i))) { 3453 SafeReplacementConstant = VecC->getAggregateElement(i); 3454 break; 3455 } 3456 } 3457 assert(SafeReplacementConstant && "Failed to find undef replacement"); 3458 M = Constant::replaceUndefsWith(VecC, SafeReplacementConstant); 3459 } 3460 3461 return Builder.CreateICmp(DstPred, X, M); 3462 } 3463 3464 /// Some comparisons can be simplified. 3465 /// In this case, we are looking for comparisons that look like 3466 /// a check for a lossy signed truncation. 3467 /// Folds: (MaskedBits is a constant.) 3468 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3469 /// Into: 3470 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3471 /// Where KeptBits = bitwidth(%x) - MaskedBits 3472 static Value * 3473 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3474 InstCombiner::BuilderTy &Builder) { 3475 ICmpInst::Predicate SrcPred; 3476 Value *X; 3477 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3478 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3479 if (!match(&I, m_c_ICmp(SrcPred, 3480 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3481 m_APInt(C1))), 3482 m_Deferred(X)))) 3483 return nullptr; 3484 3485 // Potential handling of non-splats: for each element: 3486 // * if both are undef, replace with constant 0. 3487 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3488 // * if both are not undef, and are different, bailout. 3489 // * else, only one is undef, then pick the non-undef one. 3490 3491 // The shift amount must be equal. 3492 if (*C0 != *C1) 3493 return nullptr; 3494 const APInt &MaskedBits = *C0; 3495 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3496 3497 ICmpInst::Predicate DstPred; 3498 switch (SrcPred) { 3499 case ICmpInst::Predicate::ICMP_EQ: 3500 // ((%x << MaskedBits) a>> MaskedBits) == %x 3501 // => 3502 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3503 DstPred = ICmpInst::Predicate::ICMP_ULT; 3504 break; 3505 case ICmpInst::Predicate::ICMP_NE: 3506 // ((%x << MaskedBits) a>> MaskedBits) != %x 3507 // => 3508 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3509 DstPred = ICmpInst::Predicate::ICMP_UGE; 3510 break; 3511 // FIXME: are more folds possible? 3512 default: 3513 return nullptr; 3514 } 3515 3516 auto *XType = X->getType(); 3517 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3518 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3519 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3520 3521 // KeptBits = bitwidth(%x) - MaskedBits 3522 const APInt KeptBits = BitWidth - MaskedBits; 3523 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3524 // ICmpCst = (1 << KeptBits) 3525 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3526 assert(ICmpCst.isPowerOf2()); 3527 // AddCst = (1 << (KeptBits-1)) 3528 const APInt AddCst = ICmpCst.lshr(1); 3529 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3530 3531 // T0 = add %x, AddCst 3532 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3533 // T1 = T0 DstPred ICmpCst 3534 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3535 3536 return T1; 3537 } 3538 3539 // Given pattern: 3540 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3541 // we should move shifts to the same hand of 'and', i.e. rewrite as 3542 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3543 // We are only interested in opposite logical shifts here. 3544 // One of the shifts can be truncated. 3545 // If we can, we want to end up creating 'lshr' shift. 3546 static Value * 3547 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3548 InstCombiner::BuilderTy &Builder) { 3549 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3550 !I.getOperand(0)->hasOneUse()) 3551 return nullptr; 3552 3553 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3554 3555 // Look for an 'and' of two logical shifts, one of which may be truncated. 3556 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3557 Instruction *XShift, *MaybeTruncation, *YShift; 3558 if (!match( 3559 I.getOperand(0), 3560 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3561 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3562 m_AnyLogicalShift, m_Instruction(YShift))), 3563 m_Instruction(MaybeTruncation))))) 3564 return nullptr; 3565 3566 // We potentially looked past 'trunc', but only when matching YShift, 3567 // therefore YShift must have the widest type. 3568 Instruction *WidestShift = YShift; 3569 // Therefore XShift must have the shallowest type. 3570 // Or they both have identical types if there was no truncation. 3571 Instruction *NarrowestShift = XShift; 3572 3573 Type *WidestTy = WidestShift->getType(); 3574 Type *NarrowestTy = NarrowestShift->getType(); 3575 assert(NarrowestTy == I.getOperand(0)->getType() && 3576 "We did not look past any shifts while matching XShift though."); 3577 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3578 3579 // If YShift is a 'lshr', swap the shifts around. 3580 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3581 std::swap(XShift, YShift); 3582 3583 // The shifts must be in opposite directions. 3584 auto XShiftOpcode = XShift->getOpcode(); 3585 if (XShiftOpcode == YShift->getOpcode()) 3586 return nullptr; // Do not care about same-direction shifts here. 3587 3588 Value *X, *XShAmt, *Y, *YShAmt; 3589 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3590 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3591 3592 // If one of the values being shifted is a constant, then we will end with 3593 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3594 // however, we will need to ensure that we won't increase instruction count. 3595 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3596 // At least one of the hands of the 'and' should be one-use shift. 3597 if (!match(I.getOperand(0), 3598 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3599 return nullptr; 3600 if (HadTrunc) { 3601 // Due to the 'trunc', we will need to widen X. For that either the old 3602 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3603 if (!MaybeTruncation->hasOneUse() && 3604 !NarrowestShift->getOperand(1)->hasOneUse()) 3605 return nullptr; 3606 } 3607 } 3608 3609 // We have two shift amounts from two different shifts. The types of those 3610 // shift amounts may not match. If that's the case let's bailout now. 3611 if (XShAmt->getType() != YShAmt->getType()) 3612 return nullptr; 3613 3614 // As input, we have the following pattern: 3615 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3616 // We want to rewrite that as: 3617 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3618 // While we know that originally (Q+K) would not overflow 3619 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 3620 // shift amounts. so it may now overflow in smaller bitwidth. 3621 // To ensure that does not happen, we need to ensure that the total maximal 3622 // shift amount is still representable in that smaller bit width. 3623 unsigned MaximalPossibleTotalShiftAmount = 3624 (WidestTy->getScalarSizeInBits() - 1) + 3625 (NarrowestTy->getScalarSizeInBits() - 1); 3626 APInt MaximalRepresentableShiftAmount = 3627 APInt::getAllOnesValue(XShAmt->getType()->getScalarSizeInBits()); 3628 if (MaximalRepresentableShiftAmount.ult(MaximalPossibleTotalShiftAmount)) 3629 return nullptr; 3630 3631 // Can we fold (XShAmt+YShAmt) ? 3632 auto *NewShAmt = dyn_cast_or_null<Constant>( 3633 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3634 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3635 if (!NewShAmt) 3636 return nullptr; 3637 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3638 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits(); 3639 3640 // Is the new shift amount smaller than the bit width? 3641 // FIXME: could also rely on ConstantRange. 3642 if (!match(NewShAmt, 3643 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 3644 APInt(WidestBitWidth, WidestBitWidth)))) 3645 return nullptr; 3646 3647 // An extra legality check is needed if we had trunc-of-lshr. 3648 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) { 3649 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ, 3650 WidestShift]() { 3651 // It isn't obvious whether it's worth it to analyze non-constants here. 3652 // Also, let's basically give up on non-splat cases, pessimizing vectors. 3653 // If *any* of these preconditions matches we can perform the fold. 3654 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy() 3655 ? NewShAmt->getSplatValue() 3656 : NewShAmt; 3657 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold. 3658 if (NewShAmtSplat && 3659 (NewShAmtSplat->isNullValue() || 3660 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1)) 3661 return true; 3662 // We consider *min* leading zeros so a single outlier 3663 // blocks the transform as opposed to allowing it. 3664 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) { 3665 KnownBits Known = computeKnownBits(C, SQ.DL); 3666 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3667 // If the value being shifted has at most lowest bit set we can fold. 3668 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3669 if (MaxActiveBits <= 1) 3670 return true; 3671 // Precondition: NewShAmt u<= countLeadingZeros(C) 3672 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero)) 3673 return true; 3674 } 3675 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) { 3676 KnownBits Known = computeKnownBits(C, SQ.DL); 3677 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3678 // If the value being shifted has at most lowest bit set we can fold. 3679 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3680 if (MaxActiveBits <= 1) 3681 return true; 3682 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C) 3683 if (NewShAmtSplat) { 3684 APInt AdjNewShAmt = 3685 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger(); 3686 if (AdjNewShAmt.ule(MinLeadZero)) 3687 return true; 3688 } 3689 } 3690 return false; // Can't tell if it's ok. 3691 }; 3692 if (!CanFold()) 3693 return nullptr; 3694 } 3695 3696 // All good, we can do this fold. 3697 X = Builder.CreateZExt(X, WidestTy); 3698 Y = Builder.CreateZExt(Y, WidestTy); 3699 // The shift is the same that was for X. 3700 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3701 ? Builder.CreateLShr(X, NewShAmt) 3702 : Builder.CreateShl(X, NewShAmt); 3703 Value *T1 = Builder.CreateAnd(T0, Y); 3704 return Builder.CreateICmp(I.getPredicate(), T1, 3705 Constant::getNullValue(WidestTy)); 3706 } 3707 3708 /// Fold 3709 /// (-1 u/ x) u< y 3710 /// ((x * y) u/ x) != y 3711 /// to 3712 /// @llvm.umul.with.overflow(x, y) plus extraction of overflow bit 3713 /// Note that the comparison is commutative, while inverted (u>=, ==) predicate 3714 /// will mean that we are looking for the opposite answer. 3715 Value *InstCombinerImpl::foldUnsignedMultiplicationOverflowCheck(ICmpInst &I) { 3716 ICmpInst::Predicate Pred; 3717 Value *X, *Y; 3718 Instruction *Mul; 3719 bool NeedNegation; 3720 // Look for: (-1 u/ x) u</u>= y 3721 if (!I.isEquality() && 3722 match(&I, m_c_ICmp(Pred, m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))), 3723 m_Value(Y)))) { 3724 Mul = nullptr; 3725 3726 // Are we checking that overflow does not happen, or does happen? 3727 switch (Pred) { 3728 case ICmpInst::Predicate::ICMP_ULT: 3729 NeedNegation = false; 3730 break; // OK 3731 case ICmpInst::Predicate::ICMP_UGE: 3732 NeedNegation = true; 3733 break; // OK 3734 default: 3735 return nullptr; // Wrong predicate. 3736 } 3737 } else // Look for: ((x * y) u/ x) !=/== y 3738 if (I.isEquality() && 3739 match(&I, m_c_ICmp(Pred, m_Value(Y), 3740 m_OneUse(m_UDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y), 3741 m_Value(X)), 3742 m_Instruction(Mul)), 3743 m_Deferred(X)))))) { 3744 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ; 3745 } else 3746 return nullptr; 3747 3748 BuilderTy::InsertPointGuard Guard(Builder); 3749 // If the pattern included (x * y), we'll want to insert new instructions 3750 // right before that original multiplication so that we can replace it. 3751 bool MulHadOtherUses = Mul && !Mul->hasOneUse(); 3752 if (MulHadOtherUses) 3753 Builder.SetInsertPoint(Mul); 3754 3755 Function *F = Intrinsic::getDeclaration( 3756 I.getModule(), Intrinsic::umul_with_overflow, X->getType()); 3757 CallInst *Call = Builder.CreateCall(F, {X, Y}, "umul"); 3758 3759 // If the multiplication was used elsewhere, to ensure that we don't leave 3760 // "duplicate" instructions, replace uses of that original multiplication 3761 // with the multiplication result from the with.overflow intrinsic. 3762 if (MulHadOtherUses) 3763 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "umul.val")); 3764 3765 Value *Res = Builder.CreateExtractValue(Call, 1, "umul.ov"); 3766 if (NeedNegation) // This technically increases instruction count. 3767 Res = Builder.CreateNot(Res, "umul.not.ov"); 3768 3769 // If we replaced the mul, erase it. Do this after all uses of Builder, 3770 // as the mul is used as insertion point. 3771 if (MulHadOtherUses) 3772 eraseInstFromFunction(*Mul); 3773 3774 return Res; 3775 } 3776 3777 static Instruction *foldICmpXNegX(ICmpInst &I) { 3778 CmpInst::Predicate Pred; 3779 Value *X; 3780 if (!match(&I, m_c_ICmp(Pred, m_NSWNeg(m_Value(X)), m_Deferred(X)))) 3781 return nullptr; 3782 3783 if (ICmpInst::isSigned(Pred)) 3784 Pred = ICmpInst::getSwappedPredicate(Pred); 3785 else if (ICmpInst::isUnsigned(Pred)) 3786 Pred = ICmpInst::getSignedPredicate(Pred); 3787 // else for equality-comparisons just keep the predicate. 3788 3789 return ICmpInst::Create(Instruction::ICmp, Pred, X, 3790 Constant::getNullValue(X->getType()), I.getName()); 3791 } 3792 3793 /// Try to fold icmp (binop), X or icmp X, (binop). 3794 /// TODO: A large part of this logic is duplicated in InstSimplify's 3795 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3796 /// duplication. 3797 Instruction *InstCombinerImpl::foldICmpBinOp(ICmpInst &I, 3798 const SimplifyQuery &SQ) { 3799 const SimplifyQuery Q = SQ.getWithInstruction(&I); 3800 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3801 3802 // Special logic for binary operators. 3803 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3804 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3805 if (!BO0 && !BO1) 3806 return nullptr; 3807 3808 if (Instruction *NewICmp = foldICmpXNegX(I)) 3809 return NewICmp; 3810 3811 const CmpInst::Predicate Pred = I.getPredicate(); 3812 Value *X; 3813 3814 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 3815 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X 3816 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 3817 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3818 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 3819 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0 3820 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 3821 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3822 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 3823 3824 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 3825 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 3826 NoOp0WrapProblem = 3827 ICmpInst::isEquality(Pred) || 3828 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 3829 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 3830 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 3831 NoOp1WrapProblem = 3832 ICmpInst::isEquality(Pred) || 3833 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 3834 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 3835 3836 // Analyze the case when either Op0 or Op1 is an add instruction. 3837 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 3838 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 3839 if (BO0 && BO0->getOpcode() == Instruction::Add) { 3840 A = BO0->getOperand(0); 3841 B = BO0->getOperand(1); 3842 } 3843 if (BO1 && BO1->getOpcode() == Instruction::Add) { 3844 C = BO1->getOperand(0); 3845 D = BO1->getOperand(1); 3846 } 3847 3848 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow. 3849 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow. 3850 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 3851 return new ICmpInst(Pred, A == Op1 ? B : A, 3852 Constant::getNullValue(Op1->getType())); 3853 3854 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow. 3855 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow. 3856 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 3857 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 3858 C == Op0 ? D : C); 3859 3860 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow. 3861 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 3862 NoOp1WrapProblem) { 3863 // Determine Y and Z in the form icmp (X+Y), (X+Z). 3864 Value *Y, *Z; 3865 if (A == C) { 3866 // C + B == C + D -> B == D 3867 Y = B; 3868 Z = D; 3869 } else if (A == D) { 3870 // D + B == C + D -> B == C 3871 Y = B; 3872 Z = C; 3873 } else if (B == C) { 3874 // A + C == C + D -> A == D 3875 Y = A; 3876 Z = D; 3877 } else { 3878 assert(B == D); 3879 // A + D == C + D -> A == C 3880 Y = A; 3881 Z = C; 3882 } 3883 return new ICmpInst(Pred, Y, Z); 3884 } 3885 3886 // icmp slt (A + -1), Op1 -> icmp sle A, Op1 3887 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 3888 match(B, m_AllOnes())) 3889 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 3890 3891 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1 3892 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 3893 match(B, m_AllOnes())) 3894 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 3895 3896 // icmp sle (A + 1), Op1 -> icmp slt A, Op1 3897 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 3898 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 3899 3900 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1 3901 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 3902 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 3903 3904 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C 3905 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 3906 match(D, m_AllOnes())) 3907 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 3908 3909 // icmp sle Op0, (C + -1) -> icmp slt Op0, C 3910 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 3911 match(D, m_AllOnes())) 3912 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 3913 3914 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C 3915 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 3916 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 3917 3918 // icmp slt Op0, (C + 1) -> icmp sle Op0, C 3919 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 3920 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 3921 3922 // TODO: The subtraction-related identities shown below also hold, but 3923 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 3924 // wouldn't happen even if they were implemented. 3925 // 3926 // icmp ult (A - 1), Op1 -> icmp ule A, Op1 3927 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1 3928 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C 3929 // icmp ule Op0, (C - 1) -> icmp ult Op0, C 3930 3931 // icmp ule (A + 1), Op0 -> icmp ult A, Op1 3932 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 3933 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 3934 3935 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1 3936 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 3937 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 3938 3939 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C 3940 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 3941 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 3942 3943 // icmp ult Op0, (C + 1) -> icmp ule Op0, C 3944 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 3945 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 3946 3947 // if C1 has greater magnitude than C2: 3948 // icmp (A + C1), (C + C2) -> icmp (A + C3), C 3949 // s.t. C3 = C1 - C2 3950 // 3951 // if C2 has greater magnitude than C1: 3952 // icmp (A + C1), (C + C2) -> icmp A, (C + C3) 3953 // s.t. C3 = C2 - C1 3954 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 3955 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) 3956 if (ConstantInt *C1 = dyn_cast<ConstantInt>(B)) 3957 if (ConstantInt *C2 = dyn_cast<ConstantInt>(D)) { 3958 const APInt &AP1 = C1->getValue(); 3959 const APInt &AP2 = C2->getValue(); 3960 if (AP1.isNegative() == AP2.isNegative()) { 3961 APInt AP1Abs = C1->getValue().abs(); 3962 APInt AP2Abs = C2->getValue().abs(); 3963 if (AP1Abs.uge(AP2Abs)) { 3964 ConstantInt *C3 = Builder.getInt(AP1 - AP2); 3965 bool HasNUW = BO0->hasNoUnsignedWrap() && C3->getValue().ule(AP1); 3966 bool HasNSW = BO0->hasNoSignedWrap(); 3967 Value *NewAdd = Builder.CreateAdd(A, C3, "", HasNUW, HasNSW); 3968 return new ICmpInst(Pred, NewAdd, C); 3969 } else { 3970 ConstantInt *C3 = Builder.getInt(AP2 - AP1); 3971 bool HasNUW = BO1->hasNoUnsignedWrap() && C3->getValue().ule(AP2); 3972 bool HasNSW = BO1->hasNoSignedWrap(); 3973 Value *NewAdd = Builder.CreateAdd(C, C3, "", HasNUW, HasNSW); 3974 return new ICmpInst(Pred, A, NewAdd); 3975 } 3976 } 3977 } 3978 3979 // Analyze the case when either Op0 or Op1 is a sub instruction. 3980 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 3981 A = nullptr; 3982 B = nullptr; 3983 C = nullptr; 3984 D = nullptr; 3985 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 3986 A = BO0->getOperand(0); 3987 B = BO0->getOperand(1); 3988 } 3989 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 3990 C = BO1->getOperand(0); 3991 D = BO1->getOperand(1); 3992 } 3993 3994 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow. 3995 if (A == Op1 && NoOp0WrapProblem) 3996 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 3997 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow. 3998 if (C == Op0 && NoOp1WrapProblem) 3999 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 4000 4001 // Convert sub-with-unsigned-overflow comparisons into a comparison of args. 4002 // (A - B) u>/u<= A --> B u>/u<= A 4003 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 4004 return new ICmpInst(Pred, B, A); 4005 // C u</u>= (C - D) --> C u</u>= D 4006 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 4007 return new ICmpInst(Pred, C, D); 4008 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0 4009 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) && 4010 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4011 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A); 4012 // C u<=/u> (C - D) --> C u</u>= D iff B != 0 4013 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) && 4014 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4015 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D); 4016 4017 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow. 4018 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem) 4019 return new ICmpInst(Pred, A, C); 4020 4021 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow. 4022 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem) 4023 return new ICmpInst(Pred, D, B); 4024 4025 // icmp (0-X) < cst --> x > -cst 4026 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 4027 Value *X; 4028 if (match(BO0, m_Neg(m_Value(X)))) 4029 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 4030 if (RHSC->isNotMinSignedValue()) 4031 return new ICmpInst(I.getSwappedPredicate(), X, 4032 ConstantExpr::getNeg(RHSC)); 4033 } 4034 4035 { 4036 // Try to remove shared constant multiplier from equality comparison: 4037 // X * C == Y * C (with no overflowing/aliasing) --> X == Y 4038 Value *X, *Y; 4039 const APInt *C; 4040 if (match(Op0, m_Mul(m_Value(X), m_APInt(C))) && *C != 0 && 4041 match(Op1, m_Mul(m_Value(Y), m_SpecificInt(*C))) && I.isEquality()) 4042 if (!C->countTrailingZeros() || 4043 (BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap()) || 4044 (BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap())) 4045 return new ICmpInst(Pred, X, Y); 4046 } 4047 4048 BinaryOperator *SRem = nullptr; 4049 // icmp (srem X, Y), Y 4050 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 4051 SRem = BO0; 4052 // icmp Y, (srem X, Y) 4053 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 4054 Op0 == BO1->getOperand(1)) 4055 SRem = BO1; 4056 if (SRem) { 4057 // We don't check hasOneUse to avoid increasing register pressure because 4058 // the value we use is the same value this instruction was already using. 4059 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 4060 default: 4061 break; 4062 case ICmpInst::ICMP_EQ: 4063 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4064 case ICmpInst::ICMP_NE: 4065 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4066 case ICmpInst::ICMP_SGT: 4067 case ICmpInst::ICMP_SGE: 4068 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 4069 Constant::getAllOnesValue(SRem->getType())); 4070 case ICmpInst::ICMP_SLT: 4071 case ICmpInst::ICMP_SLE: 4072 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 4073 Constant::getNullValue(SRem->getType())); 4074 } 4075 } 4076 4077 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 4078 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 4079 switch (BO0->getOpcode()) { 4080 default: 4081 break; 4082 case Instruction::Add: 4083 case Instruction::Sub: 4084 case Instruction::Xor: { 4085 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 4086 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4087 4088 const APInt *C; 4089 if (match(BO0->getOperand(1), m_APInt(C))) { 4090 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 4091 if (C->isSignMask()) { 4092 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4093 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4094 } 4095 4096 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 4097 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 4098 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4099 NewPred = I.getSwappedPredicate(NewPred); 4100 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4101 } 4102 } 4103 break; 4104 } 4105 case Instruction::Mul: { 4106 if (!I.isEquality()) 4107 break; 4108 4109 const APInt *C; 4110 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isNullValue() && 4111 !C->isOneValue()) { 4112 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 4113 // Mask = -1 >> count-trailing-zeros(C). 4114 if (unsigned TZs = C->countTrailingZeros()) { 4115 Constant *Mask = ConstantInt::get( 4116 BO0->getType(), 4117 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 4118 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 4119 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 4120 return new ICmpInst(Pred, And1, And2); 4121 } 4122 } 4123 break; 4124 } 4125 case Instruction::UDiv: 4126 case Instruction::LShr: 4127 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 4128 break; 4129 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4130 4131 case Instruction::SDiv: 4132 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 4133 break; 4134 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4135 4136 case Instruction::AShr: 4137 if (!BO0->isExact() || !BO1->isExact()) 4138 break; 4139 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4140 4141 case Instruction::Shl: { 4142 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 4143 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 4144 if (!NUW && !NSW) 4145 break; 4146 if (!NSW && I.isSigned()) 4147 break; 4148 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4149 } 4150 } 4151 } 4152 4153 if (BO0) { 4154 // Transform A & (L - 1) `ult` L --> L != 0 4155 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 4156 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 4157 4158 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 4159 auto *Zero = Constant::getNullValue(BO0->getType()); 4160 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 4161 } 4162 } 4163 4164 if (Value *V = foldUnsignedMultiplicationOverflowCheck(I)) 4165 return replaceInstUsesWith(I, V); 4166 4167 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 4168 return replaceInstUsesWith(I, V); 4169 4170 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 4171 return replaceInstUsesWith(I, V); 4172 4173 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 4174 return replaceInstUsesWith(I, V); 4175 4176 return nullptr; 4177 } 4178 4179 /// Fold icmp Pred min|max(X, Y), X. 4180 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 4181 ICmpInst::Predicate Pred = Cmp.getPredicate(); 4182 Value *Op0 = Cmp.getOperand(0); 4183 Value *X = Cmp.getOperand(1); 4184 4185 // Canonicalize minimum or maximum operand to LHS of the icmp. 4186 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 4187 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 4188 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 4189 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 4190 std::swap(Op0, X); 4191 Pred = Cmp.getSwappedPredicate(); 4192 } 4193 4194 Value *Y; 4195 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 4196 // smin(X, Y) == X --> X s<= Y 4197 // smin(X, Y) s>= X --> X s<= Y 4198 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 4199 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 4200 4201 // smin(X, Y) != X --> X s> Y 4202 // smin(X, Y) s< X --> X s> Y 4203 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 4204 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 4205 4206 // These cases should be handled in InstSimplify: 4207 // smin(X, Y) s<= X --> true 4208 // smin(X, Y) s> X --> false 4209 return nullptr; 4210 } 4211 4212 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 4213 // smax(X, Y) == X --> X s>= Y 4214 // smax(X, Y) s<= X --> X s>= Y 4215 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 4216 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 4217 4218 // smax(X, Y) != X --> X s< Y 4219 // smax(X, Y) s> X --> X s< Y 4220 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 4221 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 4222 4223 // These cases should be handled in InstSimplify: 4224 // smax(X, Y) s>= X --> true 4225 // smax(X, Y) s< X --> false 4226 return nullptr; 4227 } 4228 4229 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 4230 // umin(X, Y) == X --> X u<= Y 4231 // umin(X, Y) u>= X --> X u<= Y 4232 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 4233 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 4234 4235 // umin(X, Y) != X --> X u> Y 4236 // umin(X, Y) u< X --> X u> Y 4237 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 4238 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 4239 4240 // These cases should be handled in InstSimplify: 4241 // umin(X, Y) u<= X --> true 4242 // umin(X, Y) u> X --> false 4243 return nullptr; 4244 } 4245 4246 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 4247 // umax(X, Y) == X --> X u>= Y 4248 // umax(X, Y) u<= X --> X u>= Y 4249 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 4250 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 4251 4252 // umax(X, Y) != X --> X u< Y 4253 // umax(X, Y) u> X --> X u< Y 4254 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 4255 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 4256 4257 // These cases should be handled in InstSimplify: 4258 // umax(X, Y) u>= X --> true 4259 // umax(X, Y) u< X --> false 4260 return nullptr; 4261 } 4262 4263 return nullptr; 4264 } 4265 4266 Instruction *InstCombinerImpl::foldICmpEquality(ICmpInst &I) { 4267 if (!I.isEquality()) 4268 return nullptr; 4269 4270 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4271 const CmpInst::Predicate Pred = I.getPredicate(); 4272 Value *A, *B, *C, *D; 4273 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 4274 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 4275 Value *OtherVal = A == Op1 ? B : A; 4276 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4277 } 4278 4279 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 4280 // A^c1 == C^c2 --> A == C^(c1^c2) 4281 ConstantInt *C1, *C2; 4282 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 4283 Op1->hasOneUse()) { 4284 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 4285 Value *Xor = Builder.CreateXor(C, NC); 4286 return new ICmpInst(Pred, A, Xor); 4287 } 4288 4289 // A^B == A^D -> B == D 4290 if (A == C) 4291 return new ICmpInst(Pred, B, D); 4292 if (A == D) 4293 return new ICmpInst(Pred, B, C); 4294 if (B == C) 4295 return new ICmpInst(Pred, A, D); 4296 if (B == D) 4297 return new ICmpInst(Pred, A, C); 4298 } 4299 } 4300 4301 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 4302 // A == (A^B) -> B == 0 4303 Value *OtherVal = A == Op0 ? B : A; 4304 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4305 } 4306 4307 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 4308 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 4309 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 4310 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 4311 4312 if (A == C) { 4313 X = B; 4314 Y = D; 4315 Z = A; 4316 } else if (A == D) { 4317 X = B; 4318 Y = C; 4319 Z = A; 4320 } else if (B == C) { 4321 X = A; 4322 Y = D; 4323 Z = B; 4324 } else if (B == D) { 4325 X = A; 4326 Y = C; 4327 Z = B; 4328 } 4329 4330 if (X) { // Build (X^Y) & Z 4331 Op1 = Builder.CreateXor(X, Y); 4332 Op1 = Builder.CreateAnd(Op1, Z); 4333 return new ICmpInst(Pred, Op1, Constant::getNullValue(Op1->getType())); 4334 } 4335 } 4336 4337 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 4338 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 4339 ConstantInt *Cst1; 4340 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 4341 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 4342 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 4343 match(Op1, m_ZExt(m_Value(A))))) { 4344 APInt Pow2 = Cst1->getValue() + 1; 4345 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 4346 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 4347 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 4348 } 4349 4350 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 4351 // For lshr and ashr pairs. 4352 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 4353 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 4354 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 4355 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 4356 unsigned TypeBits = Cst1->getBitWidth(); 4357 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4358 if (ShAmt < TypeBits && ShAmt != 0) { 4359 ICmpInst::Predicate NewPred = 4360 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 4361 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4362 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 4363 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 4364 } 4365 } 4366 4367 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 4368 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 4369 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 4370 unsigned TypeBits = Cst1->getBitWidth(); 4371 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4372 if (ShAmt < TypeBits && ShAmt != 0) { 4373 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4374 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 4375 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 4376 I.getName() + ".mask"); 4377 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 4378 } 4379 } 4380 4381 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 4382 // "icmp (and X, mask), cst" 4383 uint64_t ShAmt = 0; 4384 if (Op0->hasOneUse() && 4385 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 4386 match(Op1, m_ConstantInt(Cst1)) && 4387 // Only do this when A has multiple uses. This is most important to do 4388 // when it exposes other optimizations. 4389 !A->hasOneUse()) { 4390 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 4391 4392 if (ShAmt < ASize) { 4393 APInt MaskV = 4394 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 4395 MaskV <<= ShAmt; 4396 4397 APInt CmpV = Cst1->getValue().zext(ASize); 4398 CmpV <<= ShAmt; 4399 4400 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 4401 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 4402 } 4403 } 4404 4405 // If both operands are byte-swapped or bit-reversed, just compare the 4406 // original values. 4407 // TODO: Move this to a function similar to foldICmpIntrinsicWithConstant() 4408 // and handle more intrinsics. 4409 if ((match(Op0, m_BSwap(m_Value(A))) && match(Op1, m_BSwap(m_Value(B)))) || 4410 (match(Op0, m_BitReverse(m_Value(A))) && 4411 match(Op1, m_BitReverse(m_Value(B))))) 4412 return new ICmpInst(Pred, A, B); 4413 4414 // Canonicalize checking for a power-of-2-or-zero value: 4415 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4416 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4417 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4418 m_Deferred(A)))) || 4419 !match(Op1, m_ZeroInt())) 4420 A = nullptr; 4421 4422 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4423 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4424 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4425 A = Op1; 4426 else if (match(Op1, 4427 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4428 A = Op0; 4429 4430 if (A) { 4431 Type *Ty = A->getType(); 4432 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4433 return Pred == ICmpInst::ICMP_EQ 4434 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4435 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4436 } 4437 4438 return nullptr; 4439 } 4440 4441 static Instruction *foldICmpWithZextOrSext(ICmpInst &ICmp, 4442 InstCombiner::BuilderTy &Builder) { 4443 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0"); 4444 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0)); 4445 Value *X; 4446 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X)))) 4447 return nullptr; 4448 4449 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt; 4450 bool IsSignedCmp = ICmp.isSigned(); 4451 if (auto *CastOp1 = dyn_cast<CastInst>(ICmp.getOperand(1))) { 4452 // If the signedness of the two casts doesn't agree (i.e. one is a sext 4453 // and the other is a zext), then we can't handle this. 4454 // TODO: This is too strict. We can handle some predicates (equality?). 4455 if (CastOp0->getOpcode() != CastOp1->getOpcode()) 4456 return nullptr; 4457 4458 // Not an extension from the same type? 4459 Value *Y = CastOp1->getOperand(0); 4460 Type *XTy = X->getType(), *YTy = Y->getType(); 4461 if (XTy != YTy) { 4462 // One of the casts must have one use because we are creating a new cast. 4463 if (!CastOp0->hasOneUse() && !CastOp1->hasOneUse()) 4464 return nullptr; 4465 // Extend the narrower operand to the type of the wider operand. 4466 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits()) 4467 X = Builder.CreateCast(CastOp0->getOpcode(), X, YTy); 4468 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits()) 4469 Y = Builder.CreateCast(CastOp0->getOpcode(), Y, XTy); 4470 else 4471 return nullptr; 4472 } 4473 4474 // (zext X) == (zext Y) --> X == Y 4475 // (sext X) == (sext Y) --> X == Y 4476 if (ICmp.isEquality()) 4477 return new ICmpInst(ICmp.getPredicate(), X, Y); 4478 4479 // A signed comparison of sign extended values simplifies into a 4480 // signed comparison. 4481 if (IsSignedCmp && IsSignedExt) 4482 return new ICmpInst(ICmp.getPredicate(), X, Y); 4483 4484 // The other three cases all fold into an unsigned comparison. 4485 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y); 4486 } 4487 4488 // Below here, we are only folding a compare with constant. 4489 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4490 if (!C) 4491 return nullptr; 4492 4493 // Compute the constant that would happen if we truncated to SrcTy then 4494 // re-extended to DestTy. 4495 Type *SrcTy = CastOp0->getSrcTy(); 4496 Type *DestTy = CastOp0->getDestTy(); 4497 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4498 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy); 4499 4500 // If the re-extended constant didn't change... 4501 if (Res2 == C) { 4502 if (ICmp.isEquality()) 4503 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4504 4505 // A signed comparison of sign extended values simplifies into a 4506 // signed comparison. 4507 if (IsSignedExt && IsSignedCmp) 4508 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4509 4510 // The other three cases all fold into an unsigned comparison. 4511 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1); 4512 } 4513 4514 // The re-extended constant changed, partly changed (in the case of a vector), 4515 // or could not be determined to be equal (in the case of a constant 4516 // expression), so the constant cannot be represented in the shorter type. 4517 // All the cases that fold to true or false will have already been handled 4518 // by SimplifyICmpInst, so only deal with the tricky case. 4519 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C)) 4520 return nullptr; 4521 4522 // Is source op positive? 4523 // icmp ult (sext X), C --> icmp sgt X, -1 4524 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4525 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy)); 4526 4527 // Is source op negative? 4528 // icmp ugt (sext X), C --> icmp slt X, 0 4529 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4530 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy)); 4531 } 4532 4533 /// Handle icmp (cast x), (cast or constant). 4534 Instruction *InstCombinerImpl::foldICmpWithCastOp(ICmpInst &ICmp) { 4535 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0)); 4536 if (!CastOp0) 4537 return nullptr; 4538 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1))) 4539 return nullptr; 4540 4541 Value *Op0Src = CastOp0->getOperand(0); 4542 Type *SrcTy = CastOp0->getSrcTy(); 4543 Type *DestTy = CastOp0->getDestTy(); 4544 4545 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4546 // integer type is the same size as the pointer type. 4547 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) { 4548 if (isa<VectorType>(SrcTy)) { 4549 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4550 DestTy = cast<VectorType>(DestTy)->getElementType(); 4551 } 4552 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4553 }; 4554 if (CastOp0->getOpcode() == Instruction::PtrToInt && 4555 CompatibleSizes(SrcTy, DestTy)) { 4556 Value *NewOp1 = nullptr; 4557 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4558 Value *PtrSrc = PtrToIntOp1->getOperand(0); 4559 if (PtrSrc->getType()->getPointerAddressSpace() == 4560 Op0Src->getType()->getPointerAddressSpace()) { 4561 NewOp1 = PtrToIntOp1->getOperand(0); 4562 // If the pointer types don't match, insert a bitcast. 4563 if (Op0Src->getType() != NewOp1->getType()) 4564 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType()); 4565 } 4566 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4567 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4568 } 4569 4570 if (NewOp1) 4571 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1); 4572 } 4573 4574 return foldICmpWithZextOrSext(ICmp, Builder); 4575 } 4576 4577 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4578 switch (BinaryOp) { 4579 default: 4580 llvm_unreachable("Unsupported binary op"); 4581 case Instruction::Add: 4582 case Instruction::Sub: 4583 return match(RHS, m_Zero()); 4584 case Instruction::Mul: 4585 return match(RHS, m_One()); 4586 } 4587 } 4588 4589 OverflowResult 4590 InstCombinerImpl::computeOverflow(Instruction::BinaryOps BinaryOp, 4591 bool IsSigned, Value *LHS, Value *RHS, 4592 Instruction *CxtI) const { 4593 switch (BinaryOp) { 4594 default: 4595 llvm_unreachable("Unsupported binary op"); 4596 case Instruction::Add: 4597 if (IsSigned) 4598 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4599 else 4600 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4601 case Instruction::Sub: 4602 if (IsSigned) 4603 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4604 else 4605 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4606 case Instruction::Mul: 4607 if (IsSigned) 4608 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4609 else 4610 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4611 } 4612 } 4613 4614 bool InstCombinerImpl::OptimizeOverflowCheck(Instruction::BinaryOps BinaryOp, 4615 bool IsSigned, Value *LHS, 4616 Value *RHS, Instruction &OrigI, 4617 Value *&Result, 4618 Constant *&Overflow) { 4619 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4620 std::swap(LHS, RHS); 4621 4622 // If the overflow check was an add followed by a compare, the insertion point 4623 // may be pointing to the compare. We want to insert the new instructions 4624 // before the add in case there are uses of the add between the add and the 4625 // compare. 4626 Builder.SetInsertPoint(&OrigI); 4627 4628 Type *OverflowTy = Type::getInt1Ty(LHS->getContext()); 4629 if (auto *LHSTy = dyn_cast<VectorType>(LHS->getType())) 4630 OverflowTy = VectorType::get(OverflowTy, LHSTy->getElementCount()); 4631 4632 if (isNeutralValue(BinaryOp, RHS)) { 4633 Result = LHS; 4634 Overflow = ConstantInt::getFalse(OverflowTy); 4635 return true; 4636 } 4637 4638 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4639 case OverflowResult::MayOverflow: 4640 return false; 4641 case OverflowResult::AlwaysOverflowsLow: 4642 case OverflowResult::AlwaysOverflowsHigh: 4643 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4644 Result->takeName(&OrigI); 4645 Overflow = ConstantInt::getTrue(OverflowTy); 4646 return true; 4647 case OverflowResult::NeverOverflows: 4648 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4649 Result->takeName(&OrigI); 4650 Overflow = ConstantInt::getFalse(OverflowTy); 4651 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4652 if (IsSigned) 4653 Inst->setHasNoSignedWrap(); 4654 else 4655 Inst->setHasNoUnsignedWrap(); 4656 } 4657 return true; 4658 } 4659 4660 llvm_unreachable("Unexpected overflow result"); 4661 } 4662 4663 /// Recognize and process idiom involving test for multiplication 4664 /// overflow. 4665 /// 4666 /// The caller has matched a pattern of the form: 4667 /// I = cmp u (mul(zext A, zext B), V 4668 /// The function checks if this is a test for overflow and if so replaces 4669 /// multiplication with call to 'mul.with.overflow' intrinsic. 4670 /// 4671 /// \param I Compare instruction. 4672 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 4673 /// the compare instruction. Must be of integer type. 4674 /// \param OtherVal The other argument of compare instruction. 4675 /// \returns Instruction which must replace the compare instruction, NULL if no 4676 /// replacement required. 4677 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 4678 Value *OtherVal, 4679 InstCombinerImpl &IC) { 4680 // Don't bother doing this transformation for pointers, don't do it for 4681 // vectors. 4682 if (!isa<IntegerType>(MulVal->getType())) 4683 return nullptr; 4684 4685 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 4686 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 4687 auto *MulInstr = dyn_cast<Instruction>(MulVal); 4688 if (!MulInstr) 4689 return nullptr; 4690 assert(MulInstr->getOpcode() == Instruction::Mul); 4691 4692 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 4693 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 4694 assert(LHS->getOpcode() == Instruction::ZExt); 4695 assert(RHS->getOpcode() == Instruction::ZExt); 4696 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 4697 4698 // Calculate type and width of the result produced by mul.with.overflow. 4699 Type *TyA = A->getType(), *TyB = B->getType(); 4700 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 4701 WidthB = TyB->getPrimitiveSizeInBits(); 4702 unsigned MulWidth; 4703 Type *MulType; 4704 if (WidthB > WidthA) { 4705 MulWidth = WidthB; 4706 MulType = TyB; 4707 } else { 4708 MulWidth = WidthA; 4709 MulType = TyA; 4710 } 4711 4712 // In order to replace the original mul with a narrower mul.with.overflow, 4713 // all uses must ignore upper bits of the product. The number of used low 4714 // bits must be not greater than the width of mul.with.overflow. 4715 if (MulVal->hasNUsesOrMore(2)) 4716 for (User *U : MulVal->users()) { 4717 if (U == &I) 4718 continue; 4719 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4720 // Check if truncation ignores bits above MulWidth. 4721 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 4722 if (TruncWidth > MulWidth) 4723 return nullptr; 4724 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4725 // Check if AND ignores bits above MulWidth. 4726 if (BO->getOpcode() != Instruction::And) 4727 return nullptr; 4728 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 4729 const APInt &CVal = CI->getValue(); 4730 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 4731 return nullptr; 4732 } else { 4733 // In this case we could have the operand of the binary operation 4734 // being defined in another block, and performing the replacement 4735 // could break the dominance relation. 4736 return nullptr; 4737 } 4738 } else { 4739 // Other uses prohibit this transformation. 4740 return nullptr; 4741 } 4742 } 4743 4744 // Recognize patterns 4745 switch (I.getPredicate()) { 4746 case ICmpInst::ICMP_EQ: 4747 case ICmpInst::ICMP_NE: 4748 // Recognize pattern: 4749 // mulval = mul(zext A, zext B) 4750 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 4751 ConstantInt *CI; 4752 Value *ValToMask; 4753 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 4754 if (ValToMask != MulVal) 4755 return nullptr; 4756 const APInt &CVal = CI->getValue() + 1; 4757 if (CVal.isPowerOf2()) { 4758 unsigned MaskWidth = CVal.logBase2(); 4759 if (MaskWidth == MulWidth) 4760 break; // Recognized 4761 } 4762 } 4763 return nullptr; 4764 4765 case ICmpInst::ICMP_UGT: 4766 // Recognize pattern: 4767 // mulval = mul(zext A, zext B) 4768 // cmp ugt mulval, max 4769 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4770 APInt MaxVal = APInt::getMaxValue(MulWidth); 4771 MaxVal = MaxVal.zext(CI->getBitWidth()); 4772 if (MaxVal.eq(CI->getValue())) 4773 break; // Recognized 4774 } 4775 return nullptr; 4776 4777 case ICmpInst::ICMP_UGE: 4778 // Recognize pattern: 4779 // mulval = mul(zext A, zext B) 4780 // cmp uge mulval, max+1 4781 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4782 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4783 if (MaxVal.eq(CI->getValue())) 4784 break; // Recognized 4785 } 4786 return nullptr; 4787 4788 case ICmpInst::ICMP_ULE: 4789 // Recognize pattern: 4790 // mulval = mul(zext A, zext B) 4791 // cmp ule mulval, max 4792 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4793 APInt MaxVal = APInt::getMaxValue(MulWidth); 4794 MaxVal = MaxVal.zext(CI->getBitWidth()); 4795 if (MaxVal.eq(CI->getValue())) 4796 break; // Recognized 4797 } 4798 return nullptr; 4799 4800 case ICmpInst::ICMP_ULT: 4801 // Recognize pattern: 4802 // mulval = mul(zext A, zext B) 4803 // cmp ule mulval, max + 1 4804 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 4805 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 4806 if (MaxVal.eq(CI->getValue())) 4807 break; // Recognized 4808 } 4809 return nullptr; 4810 4811 default: 4812 return nullptr; 4813 } 4814 4815 InstCombiner::BuilderTy &Builder = IC.Builder; 4816 Builder.SetInsertPoint(MulInstr); 4817 4818 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 4819 Value *MulA = A, *MulB = B; 4820 if (WidthA < MulWidth) 4821 MulA = Builder.CreateZExt(A, MulType); 4822 if (WidthB < MulWidth) 4823 MulB = Builder.CreateZExt(B, MulType); 4824 Function *F = Intrinsic::getDeclaration( 4825 I.getModule(), Intrinsic::umul_with_overflow, MulType); 4826 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 4827 IC.addToWorklist(MulInstr); 4828 4829 // If there are uses of mul result other than the comparison, we know that 4830 // they are truncation or binary AND. Change them to use result of 4831 // mul.with.overflow and adjust properly mask/size. 4832 if (MulVal->hasNUsesOrMore(2)) { 4833 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 4834 for (User *U : make_early_inc_range(MulVal->users())) { 4835 if (U == &I || U == OtherVal) 4836 continue; 4837 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 4838 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 4839 IC.replaceInstUsesWith(*TI, Mul); 4840 else 4841 TI->setOperand(0, Mul); 4842 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 4843 assert(BO->getOpcode() == Instruction::And); 4844 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 4845 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 4846 APInt ShortMask = CI->getValue().trunc(MulWidth); 4847 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 4848 Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType()); 4849 IC.replaceInstUsesWith(*BO, Zext); 4850 } else { 4851 llvm_unreachable("Unexpected Binary operation"); 4852 } 4853 IC.addToWorklist(cast<Instruction>(U)); 4854 } 4855 } 4856 if (isa<Instruction>(OtherVal)) 4857 IC.addToWorklist(cast<Instruction>(OtherVal)); 4858 4859 // The original icmp gets replaced with the overflow value, maybe inverted 4860 // depending on predicate. 4861 bool Inverse = false; 4862 switch (I.getPredicate()) { 4863 case ICmpInst::ICMP_NE: 4864 break; 4865 case ICmpInst::ICMP_EQ: 4866 Inverse = true; 4867 break; 4868 case ICmpInst::ICMP_UGT: 4869 case ICmpInst::ICMP_UGE: 4870 if (I.getOperand(0) == MulVal) 4871 break; 4872 Inverse = true; 4873 break; 4874 case ICmpInst::ICMP_ULT: 4875 case ICmpInst::ICMP_ULE: 4876 if (I.getOperand(1) == MulVal) 4877 break; 4878 Inverse = true; 4879 break; 4880 default: 4881 llvm_unreachable("Unexpected predicate"); 4882 } 4883 if (Inverse) { 4884 Value *Res = Builder.CreateExtractValue(Call, 1); 4885 return BinaryOperator::CreateNot(Res); 4886 } 4887 4888 return ExtractValueInst::Create(Call, 1); 4889 } 4890 4891 /// When performing a comparison against a constant, it is possible that not all 4892 /// the bits in the LHS are demanded. This helper method computes the mask that 4893 /// IS demanded. 4894 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 4895 const APInt *RHS; 4896 if (!match(I.getOperand(1), m_APInt(RHS))) 4897 return APInt::getAllOnesValue(BitWidth); 4898 4899 // If this is a normal comparison, it demands all bits. If it is a sign bit 4900 // comparison, it only demands the sign bit. 4901 bool UnusedBit; 4902 if (InstCombiner::isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 4903 return APInt::getSignMask(BitWidth); 4904 4905 switch (I.getPredicate()) { 4906 // For a UGT comparison, we don't care about any bits that 4907 // correspond to the trailing ones of the comparand. The value of these 4908 // bits doesn't impact the outcome of the comparison, because any value 4909 // greater than the RHS must differ in a bit higher than these due to carry. 4910 case ICmpInst::ICMP_UGT: 4911 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 4912 4913 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 4914 // Any value less than the RHS must differ in a higher bit because of carries. 4915 case ICmpInst::ICMP_ULT: 4916 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 4917 4918 default: 4919 return APInt::getAllOnesValue(BitWidth); 4920 } 4921 } 4922 4923 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 4924 /// should be swapped. 4925 /// The decision is based on how many times these two operands are reused 4926 /// as subtract operands and their positions in those instructions. 4927 /// The rationale is that several architectures use the same instruction for 4928 /// both subtract and cmp. Thus, it is better if the order of those operands 4929 /// match. 4930 /// \return true if Op0 and Op1 should be swapped. 4931 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 4932 // Filter out pointer values as those cannot appear directly in subtract. 4933 // FIXME: we may want to go through inttoptrs or bitcasts. 4934 if (Op0->getType()->isPointerTy()) 4935 return false; 4936 // If a subtract already has the same operands as a compare, swapping would be 4937 // bad. If a subtract has the same operands as a compare but in reverse order, 4938 // then swapping is good. 4939 int GoodToSwap = 0; 4940 for (const User *U : Op0->users()) { 4941 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 4942 GoodToSwap++; 4943 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 4944 GoodToSwap--; 4945 } 4946 return GoodToSwap > 0; 4947 } 4948 4949 /// Check that one use is in the same block as the definition and all 4950 /// other uses are in blocks dominated by a given block. 4951 /// 4952 /// \param DI Definition 4953 /// \param UI Use 4954 /// \param DB Block that must dominate all uses of \p DI outside 4955 /// the parent block 4956 /// \return true when \p UI is the only use of \p DI in the parent block 4957 /// and all other uses of \p DI are in blocks dominated by \p DB. 4958 /// 4959 bool InstCombinerImpl::dominatesAllUses(const Instruction *DI, 4960 const Instruction *UI, 4961 const BasicBlock *DB) const { 4962 assert(DI && UI && "Instruction not defined\n"); 4963 // Ignore incomplete definitions. 4964 if (!DI->getParent()) 4965 return false; 4966 // DI and UI must be in the same block. 4967 if (DI->getParent() != UI->getParent()) 4968 return false; 4969 // Protect from self-referencing blocks. 4970 if (DI->getParent() == DB) 4971 return false; 4972 for (const User *U : DI->users()) { 4973 auto *Usr = cast<Instruction>(U); 4974 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 4975 return false; 4976 } 4977 return true; 4978 } 4979 4980 /// Return true when the instruction sequence within a block is select-cmp-br. 4981 static bool isChainSelectCmpBranch(const SelectInst *SI) { 4982 const BasicBlock *BB = SI->getParent(); 4983 if (!BB) 4984 return false; 4985 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 4986 if (!BI || BI->getNumSuccessors() != 2) 4987 return false; 4988 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 4989 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 4990 return false; 4991 return true; 4992 } 4993 4994 /// True when a select result is replaced by one of its operands 4995 /// in select-icmp sequence. This will eventually result in the elimination 4996 /// of the select. 4997 /// 4998 /// \param SI Select instruction 4999 /// \param Icmp Compare instruction 5000 /// \param SIOpd Operand that replaces the select 5001 /// 5002 /// Notes: 5003 /// - The replacement is global and requires dominator information 5004 /// - The caller is responsible for the actual replacement 5005 /// 5006 /// Example: 5007 /// 5008 /// entry: 5009 /// %4 = select i1 %3, %C* %0, %C* null 5010 /// %5 = icmp eq %C* %4, null 5011 /// br i1 %5, label %9, label %7 5012 /// ... 5013 /// ; <label>:7 ; preds = %entry 5014 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 5015 /// ... 5016 /// 5017 /// can be transformed to 5018 /// 5019 /// %5 = icmp eq %C* %0, null 5020 /// %6 = select i1 %3, i1 %5, i1 true 5021 /// br i1 %6, label %9, label %7 5022 /// ... 5023 /// ; <label>:7 ; preds = %entry 5024 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 5025 /// 5026 /// Similar when the first operand of the select is a constant or/and 5027 /// the compare is for not equal rather than equal. 5028 /// 5029 /// NOTE: The function is only called when the select and compare constants 5030 /// are equal, the optimization can work only for EQ predicates. This is not a 5031 /// major restriction since a NE compare should be 'normalized' to an equal 5032 /// compare, which usually happens in the combiner and test case 5033 /// select-cmp-br.ll checks for it. 5034 bool InstCombinerImpl::replacedSelectWithOperand(SelectInst *SI, 5035 const ICmpInst *Icmp, 5036 const unsigned SIOpd) { 5037 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 5038 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 5039 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 5040 // The check for the single predecessor is not the best that can be 5041 // done. But it protects efficiently against cases like when SI's 5042 // home block has two successors, Succ and Succ1, and Succ1 predecessor 5043 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 5044 // replaced can be reached on either path. So the uniqueness check 5045 // guarantees that the path all uses of SI (outside SI's parent) are on 5046 // is disjoint from all other paths out of SI. But that information 5047 // is more expensive to compute, and the trade-off here is in favor 5048 // of compile-time. It should also be noticed that we check for a single 5049 // predecessor and not only uniqueness. This to handle the situation when 5050 // Succ and Succ1 points to the same basic block. 5051 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 5052 NumSel++; 5053 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 5054 return true; 5055 } 5056 } 5057 return false; 5058 } 5059 5060 /// Try to fold the comparison based on range information we can get by checking 5061 /// whether bits are known to be zero or one in the inputs. 5062 Instruction *InstCombinerImpl::foldICmpUsingKnownBits(ICmpInst &I) { 5063 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5064 Type *Ty = Op0->getType(); 5065 ICmpInst::Predicate Pred = I.getPredicate(); 5066 5067 // Get scalar or pointer size. 5068 unsigned BitWidth = Ty->isIntOrIntVectorTy() 5069 ? Ty->getScalarSizeInBits() 5070 : DL.getPointerTypeSizeInBits(Ty->getScalarType()); 5071 5072 if (!BitWidth) 5073 return nullptr; 5074 5075 KnownBits Op0Known(BitWidth); 5076 KnownBits Op1Known(BitWidth); 5077 5078 if (SimplifyDemandedBits(&I, 0, 5079 getDemandedBitsLHSMask(I, BitWidth), 5080 Op0Known, 0)) 5081 return &I; 5082 5083 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnesValue(BitWidth), 5084 Op1Known, 0)) 5085 return &I; 5086 5087 // Given the known and unknown bits, compute a range that the LHS could be 5088 // in. Compute the Min, Max and RHS values based on the known bits. For the 5089 // EQ and NE we use unsigned values. 5090 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 5091 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 5092 if (I.isSigned()) { 5093 Op0Min = Op0Known.getSignedMinValue(); 5094 Op0Max = Op0Known.getSignedMaxValue(); 5095 Op1Min = Op1Known.getSignedMinValue(); 5096 Op1Max = Op1Known.getSignedMaxValue(); 5097 } else { 5098 Op0Min = Op0Known.getMinValue(); 5099 Op0Max = Op0Known.getMaxValue(); 5100 Op1Min = Op1Known.getMinValue(); 5101 Op1Max = Op1Known.getMaxValue(); 5102 } 5103 5104 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 5105 // out that the LHS or RHS is a constant. Constant fold this now, so that 5106 // code below can assume that Min != Max. 5107 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 5108 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 5109 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 5110 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 5111 5112 // Based on the range information we know about the LHS, see if we can 5113 // simplify this comparison. For example, (x&4) < 8 is always true. 5114 switch (Pred) { 5115 default: 5116 llvm_unreachable("Unknown icmp opcode!"); 5117 case ICmpInst::ICMP_EQ: 5118 case ICmpInst::ICMP_NE: { 5119 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) 5120 return replaceInstUsesWith( 5121 I, ConstantInt::getBool(I.getType(), Pred == CmpInst::ICMP_NE)); 5122 5123 // If all bits are known zero except for one, then we know at most one bit 5124 // is set. If the comparison is against zero, then this is a check to see if 5125 // *that* bit is set. 5126 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 5127 if (Op1Known.isZero()) { 5128 // If the LHS is an AND with the same constant, look through it. 5129 Value *LHS = nullptr; 5130 const APInt *LHSC; 5131 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 5132 *LHSC != Op0KnownZeroInverted) 5133 LHS = Op0; 5134 5135 Value *X; 5136 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 5137 APInt ValToCheck = Op0KnownZeroInverted; 5138 Type *XTy = X->getType(); 5139 if (ValToCheck.isPowerOf2()) { 5140 // ((1 << X) & 8) == 0 -> X != 3 5141 // ((1 << X) & 8) != 0 -> X == 3 5142 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5143 auto NewPred = ICmpInst::getInversePredicate(Pred); 5144 return new ICmpInst(NewPred, X, CmpC); 5145 } else if ((++ValToCheck).isPowerOf2()) { 5146 // ((1 << X) & 7) == 0 -> X >= 3 5147 // ((1 << X) & 7) != 0 -> X < 3 5148 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5149 auto NewPred = 5150 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 5151 return new ICmpInst(NewPred, X, CmpC); 5152 } 5153 } 5154 5155 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 5156 const APInt *CI; 5157 if (Op0KnownZeroInverted.isOneValue() && 5158 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 5159 // ((8 >>u X) & 1) == 0 -> X != 3 5160 // ((8 >>u X) & 1) != 0 -> X == 3 5161 unsigned CmpVal = CI->countTrailingZeros(); 5162 auto NewPred = ICmpInst::getInversePredicate(Pred); 5163 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 5164 } 5165 } 5166 break; 5167 } 5168 case ICmpInst::ICMP_ULT: { 5169 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 5170 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5171 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 5172 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5173 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 5174 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5175 5176 const APInt *CmpC; 5177 if (match(Op1, m_APInt(CmpC))) { 5178 // A <u C -> A == C-1 if min(A)+1 == C 5179 if (*CmpC == Op0Min + 1) 5180 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5181 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5182 // X <u C --> X == 0, if the number of zero bits in the bottom of X 5183 // exceeds the log2 of C. 5184 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 5185 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5186 Constant::getNullValue(Op1->getType())); 5187 } 5188 break; 5189 } 5190 case ICmpInst::ICMP_UGT: { 5191 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 5192 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5193 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 5194 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5195 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 5196 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5197 5198 const APInt *CmpC; 5199 if (match(Op1, m_APInt(CmpC))) { 5200 // A >u C -> A == C+1 if max(a)-1 == C 5201 if (*CmpC == Op0Max - 1) 5202 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5203 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5204 // X >u C --> X != 0, if the number of zero bits in the bottom of X 5205 // exceeds the log2 of C. 5206 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 5207 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 5208 Constant::getNullValue(Op1->getType())); 5209 } 5210 break; 5211 } 5212 case ICmpInst::ICMP_SLT: { 5213 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 5214 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5215 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 5216 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5217 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 5218 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5219 const APInt *CmpC; 5220 if (match(Op1, m_APInt(CmpC))) { 5221 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 5222 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5223 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5224 } 5225 break; 5226 } 5227 case ICmpInst::ICMP_SGT: { 5228 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 5229 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5230 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 5231 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5232 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 5233 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5234 const APInt *CmpC; 5235 if (match(Op1, m_APInt(CmpC))) { 5236 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 5237 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5238 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5239 } 5240 break; 5241 } 5242 case ICmpInst::ICMP_SGE: 5243 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 5244 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 5245 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5246 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 5247 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5248 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 5249 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5250 break; 5251 case ICmpInst::ICMP_SLE: 5252 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 5253 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 5254 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5255 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 5256 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5257 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 5258 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5259 break; 5260 case ICmpInst::ICMP_UGE: 5261 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 5262 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 5263 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5264 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 5265 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5266 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 5267 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5268 break; 5269 case ICmpInst::ICMP_ULE: 5270 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 5271 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 5272 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5273 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 5274 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5275 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 5276 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5277 break; 5278 } 5279 5280 // Turn a signed comparison into an unsigned one if both operands are known to 5281 // have the same sign. 5282 if (I.isSigned() && 5283 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 5284 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 5285 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 5286 5287 return nullptr; 5288 } 5289 5290 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 5291 InstCombiner::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 5292 Constant *C) { 5293 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 5294 "Only for relational integer predicates."); 5295 5296 Type *Type = C->getType(); 5297 bool IsSigned = ICmpInst::isSigned(Pred); 5298 5299 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred); 5300 bool WillIncrement = 5301 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT; 5302 5303 // Check if the constant operand can be safely incremented/decremented 5304 // without overflowing/underflowing. 5305 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) { 5306 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned); 5307 }; 5308 5309 Constant *SafeReplacementConstant = nullptr; 5310 if (auto *CI = dyn_cast<ConstantInt>(C)) { 5311 // Bail out if the constant can't be safely incremented/decremented. 5312 if (!ConstantIsOk(CI)) 5313 return llvm::None; 5314 } else if (auto *FVTy = dyn_cast<FixedVectorType>(Type)) { 5315 unsigned NumElts = FVTy->getNumElements(); 5316 for (unsigned i = 0; i != NumElts; ++i) { 5317 Constant *Elt = C->getAggregateElement(i); 5318 if (!Elt) 5319 return llvm::None; 5320 5321 if (isa<UndefValue>(Elt)) 5322 continue; 5323 5324 // Bail out if we can't determine if this constant is min/max or if we 5325 // know that this constant is min/max. 5326 auto *CI = dyn_cast<ConstantInt>(Elt); 5327 if (!CI || !ConstantIsOk(CI)) 5328 return llvm::None; 5329 5330 if (!SafeReplacementConstant) 5331 SafeReplacementConstant = CI; 5332 } 5333 } else { 5334 // ConstantExpr? 5335 return llvm::None; 5336 } 5337 5338 // It may not be safe to change a compare predicate in the presence of 5339 // undefined elements, so replace those elements with the first safe constant 5340 // that we found. 5341 // TODO: in case of poison, it is safe; let's replace undefs only. 5342 if (C->containsUndefOrPoisonElement()) { 5343 assert(SafeReplacementConstant && "Replacement constant not set"); 5344 C = Constant::replaceUndefsWith(C, SafeReplacementConstant); 5345 } 5346 5347 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 5348 5349 // Increment or decrement the constant. 5350 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true); 5351 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 5352 5353 return std::make_pair(NewPred, NewC); 5354 } 5355 5356 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 5357 /// it into the appropriate icmp lt or icmp gt instruction. This transform 5358 /// allows them to be folded in visitICmpInst. 5359 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 5360 ICmpInst::Predicate Pred = I.getPredicate(); 5361 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 5362 InstCombiner::isCanonicalPredicate(Pred)) 5363 return nullptr; 5364 5365 Value *Op0 = I.getOperand(0); 5366 Value *Op1 = I.getOperand(1); 5367 auto *Op1C = dyn_cast<Constant>(Op1); 5368 if (!Op1C) 5369 return nullptr; 5370 5371 auto FlippedStrictness = 5372 InstCombiner::getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 5373 if (!FlippedStrictness) 5374 return nullptr; 5375 5376 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 5377 } 5378 5379 /// If we have a comparison with a non-canonical predicate, if we can update 5380 /// all the users, invert the predicate and adjust all the users. 5381 CmpInst *InstCombinerImpl::canonicalizeICmpPredicate(CmpInst &I) { 5382 // Is the predicate already canonical? 5383 CmpInst::Predicate Pred = I.getPredicate(); 5384 if (InstCombiner::isCanonicalPredicate(Pred)) 5385 return nullptr; 5386 5387 // Can all users be adjusted to predicate inversion? 5388 if (!InstCombiner::canFreelyInvertAllUsersOf(&I, /*IgnoredUser=*/nullptr)) 5389 return nullptr; 5390 5391 // Ok, we can canonicalize comparison! 5392 // Let's first invert the comparison's predicate. 5393 I.setPredicate(CmpInst::getInversePredicate(Pred)); 5394 I.setName(I.getName() + ".not"); 5395 5396 // And, adapt users. 5397 freelyInvertAllUsersOf(&I); 5398 5399 return &I; 5400 } 5401 5402 /// Integer compare with boolean values can always be turned into bitwise ops. 5403 static Instruction *canonicalizeICmpBool(ICmpInst &I, 5404 InstCombiner::BuilderTy &Builder) { 5405 Value *A = I.getOperand(0), *B = I.getOperand(1); 5406 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 5407 5408 // A boolean compared to true/false can be simplified to Op0/true/false in 5409 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 5410 // Cases not handled by InstSimplify are always 'not' of Op0. 5411 if (match(B, m_Zero())) { 5412 switch (I.getPredicate()) { 5413 case CmpInst::ICMP_EQ: // A == 0 -> !A 5414 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 5415 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 5416 return BinaryOperator::CreateNot(A); 5417 default: 5418 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5419 } 5420 } else if (match(B, m_One())) { 5421 switch (I.getPredicate()) { 5422 case CmpInst::ICMP_NE: // A != 1 -> !A 5423 case CmpInst::ICMP_ULT: // A <u 1 -> !A 5424 case CmpInst::ICMP_SGT: // A >s -1 -> !A 5425 return BinaryOperator::CreateNot(A); 5426 default: 5427 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5428 } 5429 } 5430 5431 switch (I.getPredicate()) { 5432 default: 5433 llvm_unreachable("Invalid icmp instruction!"); 5434 case ICmpInst::ICMP_EQ: 5435 // icmp eq i1 A, B -> ~(A ^ B) 5436 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 5437 5438 case ICmpInst::ICMP_NE: 5439 // icmp ne i1 A, B -> A ^ B 5440 return BinaryOperator::CreateXor(A, B); 5441 5442 case ICmpInst::ICMP_UGT: 5443 // icmp ugt -> icmp ult 5444 std::swap(A, B); 5445 LLVM_FALLTHROUGH; 5446 case ICmpInst::ICMP_ULT: 5447 // icmp ult i1 A, B -> ~A & B 5448 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 5449 5450 case ICmpInst::ICMP_SGT: 5451 // icmp sgt -> icmp slt 5452 std::swap(A, B); 5453 LLVM_FALLTHROUGH; 5454 case ICmpInst::ICMP_SLT: 5455 // icmp slt i1 A, B -> A & ~B 5456 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 5457 5458 case ICmpInst::ICMP_UGE: 5459 // icmp uge -> icmp ule 5460 std::swap(A, B); 5461 LLVM_FALLTHROUGH; 5462 case ICmpInst::ICMP_ULE: 5463 // icmp ule i1 A, B -> ~A | B 5464 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5465 5466 case ICmpInst::ICMP_SGE: 5467 // icmp sge -> icmp sle 5468 std::swap(A, B); 5469 LLVM_FALLTHROUGH; 5470 case ICmpInst::ICMP_SLE: 5471 // icmp sle i1 A, B -> A | ~B 5472 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5473 } 5474 } 5475 5476 // Transform pattern like: 5477 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5478 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5479 // Into: 5480 // (X l>> Y) != 0 5481 // (X l>> Y) == 0 5482 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5483 InstCombiner::BuilderTy &Builder) { 5484 ICmpInst::Predicate Pred, NewPred; 5485 Value *X, *Y; 5486 if (match(&Cmp, 5487 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5488 switch (Pred) { 5489 case ICmpInst::ICMP_ULE: 5490 NewPred = ICmpInst::ICMP_NE; 5491 break; 5492 case ICmpInst::ICMP_UGT: 5493 NewPred = ICmpInst::ICMP_EQ; 5494 break; 5495 default: 5496 return nullptr; 5497 } 5498 } else if (match(&Cmp, m_c_ICmp(Pred, 5499 m_OneUse(m_CombineOr( 5500 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5501 m_Add(m_Shl(m_One(), m_Value(Y)), 5502 m_AllOnes()))), 5503 m_Value(X)))) { 5504 // The variant with 'add' is not canonical, (the variant with 'not' is) 5505 // we only get it because it has extra uses, and can't be canonicalized, 5506 5507 switch (Pred) { 5508 case ICmpInst::ICMP_ULT: 5509 NewPred = ICmpInst::ICMP_NE; 5510 break; 5511 case ICmpInst::ICMP_UGE: 5512 NewPred = ICmpInst::ICMP_EQ; 5513 break; 5514 default: 5515 return nullptr; 5516 } 5517 } else 5518 return nullptr; 5519 5520 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5521 Constant *Zero = Constant::getNullValue(NewX->getType()); 5522 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5523 } 5524 5525 static Instruction *foldVectorCmp(CmpInst &Cmp, 5526 InstCombiner::BuilderTy &Builder) { 5527 const CmpInst::Predicate Pred = Cmp.getPredicate(); 5528 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5529 Value *V1, *V2; 5530 ArrayRef<int> M; 5531 if (!match(LHS, m_Shuffle(m_Value(V1), m_Undef(), m_Mask(M)))) 5532 return nullptr; 5533 5534 // If both arguments of the cmp are shuffles that use the same mask and 5535 // shuffle within a single vector, move the shuffle after the cmp: 5536 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5537 Type *V1Ty = V1->getType(); 5538 if (match(RHS, m_Shuffle(m_Value(V2), m_Undef(), m_SpecificMask(M))) && 5539 V1Ty == V2->getType() && (LHS->hasOneUse() || RHS->hasOneUse())) { 5540 Value *NewCmp = Builder.CreateCmp(Pred, V1, V2); 5541 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), M); 5542 } 5543 5544 // Try to canonicalize compare with splatted operand and splat constant. 5545 // TODO: We could generalize this for more than splats. See/use the code in 5546 // InstCombiner::foldVectorBinop(). 5547 Constant *C; 5548 if (!LHS->hasOneUse() || !match(RHS, m_Constant(C))) 5549 return nullptr; 5550 5551 // Length-changing splats are ok, so adjust the constants as needed: 5552 // cmp (shuffle V1, M), C --> shuffle (cmp V1, C'), M 5553 Constant *ScalarC = C->getSplatValue(/* AllowUndefs */ true); 5554 int MaskSplatIndex; 5555 if (ScalarC && match(M, m_SplatOrUndefMask(MaskSplatIndex))) { 5556 // We allow undefs in matching, but this transform removes those for safety. 5557 // Demanded elements analysis should be able to recover some/all of that. 5558 C = ConstantVector::getSplat(cast<VectorType>(V1Ty)->getElementCount(), 5559 ScalarC); 5560 SmallVector<int, 8> NewM(M.size(), MaskSplatIndex); 5561 Value *NewCmp = Builder.CreateCmp(Pred, V1, C); 5562 return new ShuffleVectorInst(NewCmp, UndefValue::get(NewCmp->getType()), 5563 NewM); 5564 } 5565 5566 return nullptr; 5567 } 5568 5569 // extract(uadd.with.overflow(A, B), 0) ult A 5570 // -> extract(uadd.with.overflow(A, B), 1) 5571 static Instruction *foldICmpOfUAddOv(ICmpInst &I) { 5572 CmpInst::Predicate Pred = I.getPredicate(); 5573 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5574 5575 Value *UAddOv; 5576 Value *A, *B; 5577 auto UAddOvResultPat = m_ExtractValue<0>( 5578 m_Intrinsic<Intrinsic::uadd_with_overflow>(m_Value(A), m_Value(B))); 5579 if (match(Op0, UAddOvResultPat) && 5580 ((Pred == ICmpInst::ICMP_ULT && (Op1 == A || Op1 == B)) || 5581 (Pred == ICmpInst::ICMP_EQ && match(Op1, m_ZeroInt()) && 5582 (match(A, m_One()) || match(B, m_One()))) || 5583 (Pred == ICmpInst::ICMP_NE && match(Op1, m_AllOnes()) && 5584 (match(A, m_AllOnes()) || match(B, m_AllOnes()))))) 5585 // extract(uadd.with.overflow(A, B), 0) < A 5586 // extract(uadd.with.overflow(A, 1), 0) == 0 5587 // extract(uadd.with.overflow(A, -1), 0) != -1 5588 UAddOv = cast<ExtractValueInst>(Op0)->getAggregateOperand(); 5589 else if (match(Op1, UAddOvResultPat) && 5590 Pred == ICmpInst::ICMP_UGT && (Op0 == A || Op0 == B)) 5591 // A > extract(uadd.with.overflow(A, B), 0) 5592 UAddOv = cast<ExtractValueInst>(Op1)->getAggregateOperand(); 5593 else 5594 return nullptr; 5595 5596 return ExtractValueInst::Create(UAddOv, 1); 5597 } 5598 5599 Instruction *InstCombinerImpl::visitICmpInst(ICmpInst &I) { 5600 bool Changed = false; 5601 const SimplifyQuery Q = SQ.getWithInstruction(&I); 5602 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5603 unsigned Op0Cplxity = getComplexity(Op0); 5604 unsigned Op1Cplxity = getComplexity(Op1); 5605 5606 /// Orders the operands of the compare so that they are listed from most 5607 /// complex to least complex. This puts constants before unary operators, 5608 /// before binary operators. 5609 if (Op0Cplxity < Op1Cplxity || 5610 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 5611 I.swapOperands(); 5612 std::swap(Op0, Op1); 5613 Changed = true; 5614 } 5615 5616 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q)) 5617 return replaceInstUsesWith(I, V); 5618 5619 // Comparing -val or val with non-zero is the same as just comparing val 5620 // ie, abs(val) != 0 -> val != 0 5621 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 5622 Value *Cond, *SelectTrue, *SelectFalse; 5623 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 5624 m_Value(SelectFalse)))) { 5625 if (Value *V = dyn_castNegVal(SelectTrue)) { 5626 if (V == SelectFalse) 5627 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5628 } 5629 else if (Value *V = dyn_castNegVal(SelectFalse)) { 5630 if (V == SelectTrue) 5631 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 5632 } 5633 } 5634 } 5635 5636 if (Op0->getType()->isIntOrIntVectorTy(1)) 5637 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 5638 return Res; 5639 5640 if (Instruction *Res = canonicalizeCmpWithConstant(I)) 5641 return Res; 5642 5643 if (Instruction *Res = canonicalizeICmpPredicate(I)) 5644 return Res; 5645 5646 if (Instruction *Res = foldICmpWithConstant(I)) 5647 return Res; 5648 5649 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 5650 return Res; 5651 5652 if (Instruction *Res = foldICmpBinOp(I, Q)) 5653 return Res; 5654 5655 if (Instruction *Res = foldICmpUsingKnownBits(I)) 5656 return Res; 5657 5658 // Test if the ICmpInst instruction is used exclusively by a select as 5659 // part of a minimum or maximum operation. If so, refrain from doing 5660 // any other folding. This helps out other analyses which understand 5661 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 5662 // and CodeGen. And in this case, at least one of the comparison 5663 // operands has at least one user besides the compare (the select), 5664 // which would often largely negate the benefit of folding anyway. 5665 // 5666 // Do the same for the other patterns recognized by matchSelectPattern. 5667 if (I.hasOneUse()) 5668 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 5669 Value *A, *B; 5670 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 5671 if (SPR.Flavor != SPF_UNKNOWN) 5672 return nullptr; 5673 } 5674 5675 // Do this after checking for min/max to prevent infinite looping. 5676 if (Instruction *Res = foldICmpWithZero(I)) 5677 return Res; 5678 5679 // FIXME: We only do this after checking for min/max to prevent infinite 5680 // looping caused by a reverse canonicalization of these patterns for min/max. 5681 // FIXME: The organization of folds is a mess. These would naturally go into 5682 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 5683 // down here after the min/max restriction. 5684 ICmpInst::Predicate Pred = I.getPredicate(); 5685 const APInt *C; 5686 if (match(Op1, m_APInt(C))) { 5687 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 5688 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 5689 Constant *Zero = Constant::getNullValue(Op0->getType()); 5690 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 5691 } 5692 5693 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 5694 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 5695 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 5696 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 5697 } 5698 } 5699 5700 if (Instruction *Res = foldICmpInstWithConstant(I)) 5701 return Res; 5702 5703 // Try to match comparison as a sign bit test. Intentionally do this after 5704 // foldICmpInstWithConstant() to potentially let other folds to happen first. 5705 if (Instruction *New = foldSignBitTest(I)) 5706 return New; 5707 5708 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 5709 return Res; 5710 5711 // If we can optimize a 'icmp GEP, P' or 'icmp P, GEP', do so now. 5712 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op0)) 5713 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 5714 return NI; 5715 if (GEPOperator *GEP = dyn_cast<GEPOperator>(Op1)) 5716 if (Instruction *NI = foldGEPICmp(GEP, Op0, 5717 ICmpInst::getSwappedPredicate(I.getPredicate()), I)) 5718 return NI; 5719 5720 // Try to optimize equality comparisons against alloca-based pointers. 5721 if (Op0->getType()->isPointerTy() && I.isEquality()) { 5722 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 5723 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op0))) 5724 if (Instruction *New = foldAllocaCmp(I, Alloca, Op1)) 5725 return New; 5726 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op1))) 5727 if (Instruction *New = foldAllocaCmp(I, Alloca, Op0)) 5728 return New; 5729 } 5730 5731 if (Instruction *Res = foldICmpBitCast(I, Builder)) 5732 return Res; 5733 5734 // TODO: Hoist this above the min/max bailout. 5735 if (Instruction *R = foldICmpWithCastOp(I)) 5736 return R; 5737 5738 if (Instruction *Res = foldICmpWithMinMax(I)) 5739 return Res; 5740 5741 { 5742 Value *A, *B; 5743 // Transform (A & ~B) == 0 --> (A & B) != 0 5744 // and (A & ~B) != 0 --> (A & B) == 0 5745 // if A is a power of 2. 5746 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 5747 match(Op1, m_Zero()) && 5748 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 5749 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 5750 Op1); 5751 5752 // ~X < ~Y --> Y < X 5753 // ~X < C --> X > ~C 5754 if (match(Op0, m_Not(m_Value(A)))) { 5755 if (match(Op1, m_Not(m_Value(B)))) 5756 return new ICmpInst(I.getPredicate(), B, A); 5757 5758 const APInt *C; 5759 if (match(Op1, m_APInt(C))) 5760 return new ICmpInst(I.getSwappedPredicate(), A, 5761 ConstantInt::get(Op1->getType(), ~(*C))); 5762 } 5763 5764 Instruction *AddI = nullptr; 5765 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 5766 m_Instruction(AddI))) && 5767 isa<IntegerType>(A->getType())) { 5768 Value *Result; 5769 Constant *Overflow; 5770 // m_UAddWithOverflow can match patterns that do not include an explicit 5771 // "add" instruction, so check the opcode of the matched op. 5772 if (AddI->getOpcode() == Instruction::Add && 5773 OptimizeOverflowCheck(Instruction::Add, /*Signed*/ false, A, B, *AddI, 5774 Result, Overflow)) { 5775 replaceInstUsesWith(*AddI, Result); 5776 eraseInstFromFunction(*AddI); 5777 return replaceInstUsesWith(I, Overflow); 5778 } 5779 } 5780 5781 // (zext a) * (zext b) --> llvm.umul.with.overflow. 5782 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5783 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 5784 return R; 5785 } 5786 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 5787 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 5788 return R; 5789 } 5790 } 5791 5792 if (Instruction *Res = foldICmpEquality(I)) 5793 return Res; 5794 5795 if (Instruction *Res = foldICmpOfUAddOv(I)) 5796 return Res; 5797 5798 // The 'cmpxchg' instruction returns an aggregate containing the old value and 5799 // an i1 which indicates whether or not we successfully did the swap. 5800 // 5801 // Replace comparisons between the old value and the expected value with the 5802 // indicator that 'cmpxchg' returns. 5803 // 5804 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 5805 // spuriously fail. In those cases, the old value may equal the expected 5806 // value but it is possible for the swap to not occur. 5807 if (I.getPredicate() == ICmpInst::ICMP_EQ) 5808 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 5809 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 5810 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 5811 !ACXI->isWeak()) 5812 return ExtractValueInst::Create(ACXI, 1); 5813 5814 { 5815 Value *X; 5816 const APInt *C; 5817 // icmp X+Cst, X 5818 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 5819 return foldICmpAddOpConst(X, *C, I.getPredicate()); 5820 5821 // icmp X, X+Cst 5822 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 5823 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 5824 } 5825 5826 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 5827 return Res; 5828 5829 if (I.getType()->isVectorTy()) 5830 if (Instruction *Res = foldVectorCmp(I, Builder)) 5831 return Res; 5832 5833 return Changed ? &I : nullptr; 5834 } 5835 5836 /// Fold fcmp ([us]itofp x, cst) if possible. 5837 Instruction *InstCombinerImpl::foldFCmpIntToFPConst(FCmpInst &I, 5838 Instruction *LHSI, 5839 Constant *RHSC) { 5840 if (!isa<ConstantFP>(RHSC)) return nullptr; 5841 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 5842 5843 // Get the width of the mantissa. We don't want to hack on conversions that 5844 // might lose information from the integer, e.g. "i64 -> float" 5845 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 5846 if (MantissaWidth == -1) return nullptr; // Unknown. 5847 5848 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 5849 5850 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 5851 5852 if (I.isEquality()) { 5853 FCmpInst::Predicate P = I.getPredicate(); 5854 bool IsExact = false; 5855 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 5856 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 5857 5858 // If the floating point constant isn't an integer value, we know if we will 5859 // ever compare equal / not equal to it. 5860 if (!IsExact) { 5861 // TODO: Can never be -0.0 and other non-representable values 5862 APFloat RHSRoundInt(RHS); 5863 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 5864 if (RHS != RHSRoundInt) { 5865 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 5866 return replaceInstUsesWith(I, Builder.getFalse()); 5867 5868 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 5869 return replaceInstUsesWith(I, Builder.getTrue()); 5870 } 5871 } 5872 5873 // TODO: If the constant is exactly representable, is it always OK to do 5874 // equality compares as integer? 5875 } 5876 5877 // Check to see that the input is converted from an integer type that is small 5878 // enough that preserves all bits. TODO: check here for "known" sign bits. 5879 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 5880 unsigned InputSize = IntTy->getScalarSizeInBits(); 5881 5882 // Following test does NOT adjust InputSize downwards for signed inputs, 5883 // because the most negative value still requires all the mantissa bits 5884 // to distinguish it from one less than that value. 5885 if ((int)InputSize > MantissaWidth) { 5886 // Conversion would lose accuracy. Check if loss can impact comparison. 5887 int Exp = ilogb(RHS); 5888 if (Exp == APFloat::IEK_Inf) { 5889 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 5890 if (MaxExponent < (int)InputSize - !LHSUnsigned) 5891 // Conversion could create infinity. 5892 return nullptr; 5893 } else { 5894 // Note that if RHS is zero or NaN, then Exp is negative 5895 // and first condition is trivially false. 5896 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 5897 // Conversion could affect comparison. 5898 return nullptr; 5899 } 5900 } 5901 5902 // Otherwise, we can potentially simplify the comparison. We know that it 5903 // will always come through as an integer value and we know the constant is 5904 // not a NAN (it would have been previously simplified). 5905 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 5906 5907 ICmpInst::Predicate Pred; 5908 switch (I.getPredicate()) { 5909 default: llvm_unreachable("Unexpected predicate!"); 5910 case FCmpInst::FCMP_UEQ: 5911 case FCmpInst::FCMP_OEQ: 5912 Pred = ICmpInst::ICMP_EQ; 5913 break; 5914 case FCmpInst::FCMP_UGT: 5915 case FCmpInst::FCMP_OGT: 5916 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 5917 break; 5918 case FCmpInst::FCMP_UGE: 5919 case FCmpInst::FCMP_OGE: 5920 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 5921 break; 5922 case FCmpInst::FCMP_ULT: 5923 case FCmpInst::FCMP_OLT: 5924 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 5925 break; 5926 case FCmpInst::FCMP_ULE: 5927 case FCmpInst::FCMP_OLE: 5928 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 5929 break; 5930 case FCmpInst::FCMP_UNE: 5931 case FCmpInst::FCMP_ONE: 5932 Pred = ICmpInst::ICMP_NE; 5933 break; 5934 case FCmpInst::FCMP_ORD: 5935 return replaceInstUsesWith(I, Builder.getTrue()); 5936 case FCmpInst::FCMP_UNO: 5937 return replaceInstUsesWith(I, Builder.getFalse()); 5938 } 5939 5940 // Now we know that the APFloat is a normal number, zero or inf. 5941 5942 // See if the FP constant is too large for the integer. For example, 5943 // comparing an i8 to 300.0. 5944 unsigned IntWidth = IntTy->getScalarSizeInBits(); 5945 5946 if (!LHSUnsigned) { 5947 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 5948 // and large values. 5949 APFloat SMax(RHS.getSemantics()); 5950 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 5951 APFloat::rmNearestTiesToEven); 5952 if (SMax < RHS) { // smax < 13123.0 5953 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 5954 Pred == ICmpInst::ICMP_SLE) 5955 return replaceInstUsesWith(I, Builder.getTrue()); 5956 return replaceInstUsesWith(I, Builder.getFalse()); 5957 } 5958 } else { 5959 // If the RHS value is > UnsignedMax, fold the comparison. This handles 5960 // +INF and large values. 5961 APFloat UMax(RHS.getSemantics()); 5962 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 5963 APFloat::rmNearestTiesToEven); 5964 if (UMax < RHS) { // umax < 13123.0 5965 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 5966 Pred == ICmpInst::ICMP_ULE) 5967 return replaceInstUsesWith(I, Builder.getTrue()); 5968 return replaceInstUsesWith(I, Builder.getFalse()); 5969 } 5970 } 5971 5972 if (!LHSUnsigned) { 5973 // See if the RHS value is < SignedMin. 5974 APFloat SMin(RHS.getSemantics()); 5975 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 5976 APFloat::rmNearestTiesToEven); 5977 if (SMin > RHS) { // smin > 12312.0 5978 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 5979 Pred == ICmpInst::ICMP_SGE) 5980 return replaceInstUsesWith(I, Builder.getTrue()); 5981 return replaceInstUsesWith(I, Builder.getFalse()); 5982 } 5983 } else { 5984 // See if the RHS value is < UnsignedMin. 5985 APFloat UMin(RHS.getSemantics()); 5986 UMin.convertFromAPInt(APInt::getMinValue(IntWidth), false, 5987 APFloat::rmNearestTiesToEven); 5988 if (UMin > RHS) { // umin > 12312.0 5989 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 5990 Pred == ICmpInst::ICMP_UGE) 5991 return replaceInstUsesWith(I, Builder.getTrue()); 5992 return replaceInstUsesWith(I, Builder.getFalse()); 5993 } 5994 } 5995 5996 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 5997 // [0, UMAX], but it may still be fractional. See if it is fractional by 5998 // casting the FP value to the integer value and back, checking for equality. 5999 // Don't do this for zero, because -0.0 is not fractional. 6000 Constant *RHSInt = LHSUnsigned 6001 ? ConstantExpr::getFPToUI(RHSC, IntTy) 6002 : ConstantExpr::getFPToSI(RHSC, IntTy); 6003 if (!RHS.isZero()) { 6004 bool Equal = LHSUnsigned 6005 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 6006 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 6007 if (!Equal) { 6008 // If we had a comparison against a fractional value, we have to adjust 6009 // the compare predicate and sometimes the value. RHSC is rounded towards 6010 // zero at this point. 6011 switch (Pred) { 6012 default: llvm_unreachable("Unexpected integer comparison!"); 6013 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 6014 return replaceInstUsesWith(I, Builder.getTrue()); 6015 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 6016 return replaceInstUsesWith(I, Builder.getFalse()); 6017 case ICmpInst::ICMP_ULE: 6018 // (float)int <= 4.4 --> int <= 4 6019 // (float)int <= -4.4 --> false 6020 if (RHS.isNegative()) 6021 return replaceInstUsesWith(I, Builder.getFalse()); 6022 break; 6023 case ICmpInst::ICMP_SLE: 6024 // (float)int <= 4.4 --> int <= 4 6025 // (float)int <= -4.4 --> int < -4 6026 if (RHS.isNegative()) 6027 Pred = ICmpInst::ICMP_SLT; 6028 break; 6029 case ICmpInst::ICMP_ULT: 6030 // (float)int < -4.4 --> false 6031 // (float)int < 4.4 --> int <= 4 6032 if (RHS.isNegative()) 6033 return replaceInstUsesWith(I, Builder.getFalse()); 6034 Pred = ICmpInst::ICMP_ULE; 6035 break; 6036 case ICmpInst::ICMP_SLT: 6037 // (float)int < -4.4 --> int < -4 6038 // (float)int < 4.4 --> int <= 4 6039 if (!RHS.isNegative()) 6040 Pred = ICmpInst::ICMP_SLE; 6041 break; 6042 case ICmpInst::ICMP_UGT: 6043 // (float)int > 4.4 --> int > 4 6044 // (float)int > -4.4 --> true 6045 if (RHS.isNegative()) 6046 return replaceInstUsesWith(I, Builder.getTrue()); 6047 break; 6048 case ICmpInst::ICMP_SGT: 6049 // (float)int > 4.4 --> int > 4 6050 // (float)int > -4.4 --> int >= -4 6051 if (RHS.isNegative()) 6052 Pred = ICmpInst::ICMP_SGE; 6053 break; 6054 case ICmpInst::ICMP_UGE: 6055 // (float)int >= -4.4 --> true 6056 // (float)int >= 4.4 --> int > 4 6057 if (RHS.isNegative()) 6058 return replaceInstUsesWith(I, Builder.getTrue()); 6059 Pred = ICmpInst::ICMP_UGT; 6060 break; 6061 case ICmpInst::ICMP_SGE: 6062 // (float)int >= -4.4 --> int >= -4 6063 // (float)int >= 4.4 --> int > 4 6064 if (!RHS.isNegative()) 6065 Pred = ICmpInst::ICMP_SGT; 6066 break; 6067 } 6068 } 6069 } 6070 6071 // Lower this FP comparison into an appropriate integer version of the 6072 // comparison. 6073 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 6074 } 6075 6076 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 6077 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 6078 Constant *RHSC) { 6079 // When C is not 0.0 and infinities are not allowed: 6080 // (C / X) < 0.0 is a sign-bit test of X 6081 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 6082 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 6083 // 6084 // Proof: 6085 // Multiply (C / X) < 0.0 by X * X / C. 6086 // - X is non zero, if it is the flag 'ninf' is violated. 6087 // - C defines the sign of X * X * C. Thus it also defines whether to swap 6088 // the predicate. C is also non zero by definition. 6089 // 6090 // Thus X * X / C is non zero and the transformation is valid. [qed] 6091 6092 FCmpInst::Predicate Pred = I.getPredicate(); 6093 6094 // Check that predicates are valid. 6095 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 6096 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 6097 return nullptr; 6098 6099 // Check that RHS operand is zero. 6100 if (!match(RHSC, m_AnyZeroFP())) 6101 return nullptr; 6102 6103 // Check fastmath flags ('ninf'). 6104 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 6105 return nullptr; 6106 6107 // Check the properties of the dividend. It must not be zero to avoid a 6108 // division by zero (see Proof). 6109 const APFloat *C; 6110 if (!match(LHSI->getOperand(0), m_APFloat(C))) 6111 return nullptr; 6112 6113 if (C->isZero()) 6114 return nullptr; 6115 6116 // Get swapped predicate if necessary. 6117 if (C->isNegative()) 6118 Pred = I.getSwappedPredicate(); 6119 6120 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 6121 } 6122 6123 /// Optimize fabs(X) compared with zero. 6124 static Instruction *foldFabsWithFcmpZero(FCmpInst &I, InstCombinerImpl &IC) { 6125 Value *X; 6126 if (!match(I.getOperand(0), m_FAbs(m_Value(X))) || 6127 !match(I.getOperand(1), m_PosZeroFP())) 6128 return nullptr; 6129 6130 auto replacePredAndOp0 = [&IC](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 6131 I->setPredicate(P); 6132 return IC.replaceOperand(*I, 0, X); 6133 }; 6134 6135 switch (I.getPredicate()) { 6136 case FCmpInst::FCMP_UGE: 6137 case FCmpInst::FCMP_OLT: 6138 // fabs(X) >= 0.0 --> true 6139 // fabs(X) < 0.0 --> false 6140 llvm_unreachable("fcmp should have simplified"); 6141 6142 case FCmpInst::FCMP_OGT: 6143 // fabs(X) > 0.0 --> X != 0.0 6144 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 6145 6146 case FCmpInst::FCMP_UGT: 6147 // fabs(X) u> 0.0 --> X u!= 0.0 6148 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 6149 6150 case FCmpInst::FCMP_OLE: 6151 // fabs(X) <= 0.0 --> X == 0.0 6152 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 6153 6154 case FCmpInst::FCMP_ULE: 6155 // fabs(X) u<= 0.0 --> X u== 0.0 6156 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 6157 6158 case FCmpInst::FCMP_OGE: 6159 // fabs(X) >= 0.0 --> !isnan(X) 6160 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6161 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 6162 6163 case FCmpInst::FCMP_ULT: 6164 // fabs(X) u< 0.0 --> isnan(X) 6165 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6166 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 6167 6168 case FCmpInst::FCMP_OEQ: 6169 case FCmpInst::FCMP_UEQ: 6170 case FCmpInst::FCMP_ONE: 6171 case FCmpInst::FCMP_UNE: 6172 case FCmpInst::FCMP_ORD: 6173 case FCmpInst::FCMP_UNO: 6174 // Look through the fabs() because it doesn't change anything but the sign. 6175 // fabs(X) == 0.0 --> X == 0.0, 6176 // fabs(X) != 0.0 --> X != 0.0 6177 // isnan(fabs(X)) --> isnan(X) 6178 // !isnan(fabs(X) --> !isnan(X) 6179 return replacePredAndOp0(&I, I.getPredicate(), X); 6180 6181 default: 6182 return nullptr; 6183 } 6184 } 6185 6186 Instruction *InstCombinerImpl::visitFCmpInst(FCmpInst &I) { 6187 bool Changed = false; 6188 6189 /// Orders the operands of the compare so that they are listed from most 6190 /// complex to least complex. This puts constants before unary operators, 6191 /// before binary operators. 6192 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 6193 I.swapOperands(); 6194 Changed = true; 6195 } 6196 6197 const CmpInst::Predicate Pred = I.getPredicate(); 6198 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6199 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 6200 SQ.getWithInstruction(&I))) 6201 return replaceInstUsesWith(I, V); 6202 6203 // Simplify 'fcmp pred X, X' 6204 Type *OpType = Op0->getType(); 6205 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 6206 if (Op0 == Op1) { 6207 switch (Pred) { 6208 default: break; 6209 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 6210 case FCmpInst::FCMP_ULT: // True if unordered or less than 6211 case FCmpInst::FCMP_UGT: // True if unordered or greater than 6212 case FCmpInst::FCMP_UNE: // True if unordered or not equal 6213 // Canonicalize these to be 'fcmp uno %X, 0.0'. 6214 I.setPredicate(FCmpInst::FCMP_UNO); 6215 I.setOperand(1, Constant::getNullValue(OpType)); 6216 return &I; 6217 6218 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 6219 case FCmpInst::FCMP_OEQ: // True if ordered and equal 6220 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 6221 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 6222 // Canonicalize these to be 'fcmp ord %X, 0.0'. 6223 I.setPredicate(FCmpInst::FCMP_ORD); 6224 I.setOperand(1, Constant::getNullValue(OpType)); 6225 return &I; 6226 } 6227 } 6228 6229 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 6230 // then canonicalize the operand to 0.0. 6231 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 6232 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) 6233 return replaceOperand(I, 0, ConstantFP::getNullValue(OpType)); 6234 6235 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) 6236 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6237 } 6238 6239 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 6240 Value *X, *Y; 6241 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 6242 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 6243 6244 // Test if the FCmpInst instruction is used exclusively by a select as 6245 // part of a minimum or maximum operation. If so, refrain from doing 6246 // any other folding. This helps out other analyses which understand 6247 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6248 // and CodeGen. And in this case, at least one of the comparison 6249 // operands has at least one user besides the compare (the select), 6250 // which would often largely negate the benefit of folding anyway. 6251 if (I.hasOneUse()) 6252 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6253 Value *A, *B; 6254 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6255 if (SPR.Flavor != SPF_UNKNOWN) 6256 return nullptr; 6257 } 6258 6259 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 6260 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 6261 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) 6262 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6263 6264 // Handle fcmp with instruction LHS and constant RHS. 6265 Instruction *LHSI; 6266 Constant *RHSC; 6267 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 6268 switch (LHSI->getOpcode()) { 6269 case Instruction::PHI: 6270 // Only fold fcmp into the PHI if the phi and fcmp are in the same 6271 // block. If in the same block, we're encouraging jump threading. If 6272 // not, we are just pessimizing the code by making an i1 phi. 6273 if (LHSI->getParent() == I.getParent()) 6274 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 6275 return NV; 6276 break; 6277 case Instruction::SIToFP: 6278 case Instruction::UIToFP: 6279 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 6280 return NV; 6281 break; 6282 case Instruction::FDiv: 6283 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 6284 return NV; 6285 break; 6286 case Instruction::Load: 6287 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 6288 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 6289 if (GV->isConstant() && GV->hasDefinitiveInitializer() && 6290 !cast<LoadInst>(LHSI)->isVolatile()) 6291 if (Instruction *Res = foldCmpLoadFromIndexedGlobal(GEP, GV, I)) 6292 return Res; 6293 break; 6294 } 6295 } 6296 6297 if (Instruction *R = foldFabsWithFcmpZero(I, *this)) 6298 return R; 6299 6300 if (match(Op0, m_FNeg(m_Value(X)))) { 6301 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 6302 Constant *C; 6303 if (match(Op1, m_Constant(C))) { 6304 Constant *NegC = ConstantExpr::getFNeg(C); 6305 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 6306 } 6307 } 6308 6309 if (match(Op0, m_FPExt(m_Value(X)))) { 6310 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 6311 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 6312 return new FCmpInst(Pred, X, Y, "", &I); 6313 6314 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 6315 const APFloat *C; 6316 if (match(Op1, m_APFloat(C))) { 6317 const fltSemantics &FPSem = 6318 X->getType()->getScalarType()->getFltSemantics(); 6319 bool Lossy; 6320 APFloat TruncC = *C; 6321 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 6322 6323 // Avoid lossy conversions and denormals. 6324 // Zero is a special case that's OK to convert. 6325 APFloat Fabs = TruncC; 6326 Fabs.clearSign(); 6327 if (!Lossy && 6328 (!(Fabs < APFloat::getSmallestNormalized(FPSem)) || Fabs.isZero())) { 6329 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 6330 return new FCmpInst(Pred, X, NewC, "", &I); 6331 } 6332 } 6333 } 6334 6335 // Convert a sign-bit test of an FP value into a cast and integer compare. 6336 // TODO: Simplify if the copysign constant is 0.0 or NaN. 6337 // TODO: Handle non-zero compare constants. 6338 // TODO: Handle other predicates. 6339 const APFloat *C; 6340 if (match(Op0, m_OneUse(m_Intrinsic<Intrinsic::copysign>(m_APFloat(C), 6341 m_Value(X)))) && 6342 match(Op1, m_AnyZeroFP()) && !C->isZero() && !C->isNaN()) { 6343 Type *IntType = Builder.getIntNTy(X->getType()->getScalarSizeInBits()); 6344 if (auto *VecTy = dyn_cast<VectorType>(OpType)) 6345 IntType = VectorType::get(IntType, VecTy->getElementCount()); 6346 6347 // copysign(non-zero constant, X) < 0.0 --> (bitcast X) < 0 6348 if (Pred == FCmpInst::FCMP_OLT) { 6349 Value *IntX = Builder.CreateBitCast(X, IntType); 6350 return new ICmpInst(ICmpInst::ICMP_SLT, IntX, 6351 ConstantInt::getNullValue(IntType)); 6352 } 6353 } 6354 6355 if (I.getType()->isVectorTy()) 6356 if (Instruction *Res = foldVectorCmp(I, Builder)) 6357 return Res; 6358 6359 return Changed ? &I : nullptr; 6360 } 6361