1 //===- InstCombineCompares.cpp --------------------------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file implements the visitICmp and visitFCmp functions. 10 // 11 //===----------------------------------------------------------------------===// 12 13 #include "InstCombineInternal.h" 14 #include "llvm/ADT/APSInt.h" 15 #include "llvm/ADT/SetVector.h" 16 #include "llvm/ADT/Statistic.h" 17 #include "llvm/Analysis/CmpInstAnalysis.h" 18 #include "llvm/Analysis/ConstantFolding.h" 19 #include "llvm/Analysis/InstructionSimplify.h" 20 #include "llvm/IR/ConstantRange.h" 21 #include "llvm/IR/DataLayout.h" 22 #include "llvm/IR/GetElementPtrTypeIterator.h" 23 #include "llvm/IR/IntrinsicInst.h" 24 #include "llvm/IR/PatternMatch.h" 25 #include "llvm/Support/KnownBits.h" 26 #include "llvm/Transforms/InstCombine/InstCombiner.h" 27 28 using namespace llvm; 29 using namespace PatternMatch; 30 31 #define DEBUG_TYPE "instcombine" 32 33 // How many times is a select replaced by one of its operands? 34 STATISTIC(NumSel, "Number of select opts"); 35 36 37 /// Compute Result = In1+In2, returning true if the result overflowed for this 38 /// type. 39 static bool addWithOverflow(APInt &Result, const APInt &In1, 40 const APInt &In2, bool IsSigned = false) { 41 bool Overflow; 42 if (IsSigned) 43 Result = In1.sadd_ov(In2, Overflow); 44 else 45 Result = In1.uadd_ov(In2, Overflow); 46 47 return Overflow; 48 } 49 50 /// Compute Result = In1-In2, returning true if the result overflowed for this 51 /// type. 52 static bool subWithOverflow(APInt &Result, const APInt &In1, 53 const APInt &In2, bool IsSigned = false) { 54 bool Overflow; 55 if (IsSigned) 56 Result = In1.ssub_ov(In2, Overflow); 57 else 58 Result = In1.usub_ov(In2, Overflow); 59 60 return Overflow; 61 } 62 63 /// Given an icmp instruction, return true if any use of this comparison is a 64 /// branch on sign bit comparison. 65 static bool hasBranchUse(ICmpInst &I) { 66 for (auto *U : I.users()) 67 if (isa<BranchInst>(U)) 68 return true; 69 return false; 70 } 71 72 /// Returns true if the exploded icmp can be expressed as a signed comparison 73 /// to zero and updates the predicate accordingly. 74 /// The signedness of the comparison is preserved. 75 /// TODO: Refactor with decomposeBitTestICmp()? 76 static bool isSignTest(ICmpInst::Predicate &Pred, const APInt &C) { 77 if (!ICmpInst::isSigned(Pred)) 78 return false; 79 80 if (C.isZero()) 81 return ICmpInst::isRelational(Pred); 82 83 if (C.isOne()) { 84 if (Pred == ICmpInst::ICMP_SLT) { 85 Pred = ICmpInst::ICMP_SLE; 86 return true; 87 } 88 } else if (C.isAllOnes()) { 89 if (Pred == ICmpInst::ICMP_SGT) { 90 Pred = ICmpInst::ICMP_SGE; 91 return true; 92 } 93 } 94 95 return false; 96 } 97 98 /// This is called when we see this pattern: 99 /// cmp pred (load (gep GV, ...)), cmpcst 100 /// where GV is a global variable with a constant initializer. Try to simplify 101 /// this into some simple computation that does not need the load. For example 102 /// we can optimize "icmp eq (load (gep "foo", 0, i)), 0" into "icmp eq i, 3". 103 /// 104 /// If AndCst is non-null, then the loaded value is masked with that constant 105 /// before doing the comparison. This handles cases like "A[i]&4 == 0". 106 Instruction *InstCombinerImpl::foldCmpLoadFromIndexedGlobal( 107 LoadInst *LI, GetElementPtrInst *GEP, GlobalVariable *GV, CmpInst &ICI, 108 ConstantInt *AndCst) { 109 if (LI->isVolatile() || LI->getType() != GEP->getResultElementType() || 110 GV->getValueType() != GEP->getSourceElementType() || 111 !GV->isConstant() || !GV->hasDefinitiveInitializer()) 112 return nullptr; 113 114 Constant *Init = GV->getInitializer(); 115 if (!isa<ConstantArray>(Init) && !isa<ConstantDataArray>(Init)) 116 return nullptr; 117 118 uint64_t ArrayElementCount = Init->getType()->getArrayNumElements(); 119 // Don't blow up on huge arrays. 120 if (ArrayElementCount > MaxArraySizeForCombine) 121 return nullptr; 122 123 // There are many forms of this optimization we can handle, for now, just do 124 // the simple index into a single-dimensional array. 125 // 126 // Require: GEP GV, 0, i {{, constant indices}} 127 if (GEP->getNumOperands() < 3 || 128 !isa<ConstantInt>(GEP->getOperand(1)) || 129 !cast<ConstantInt>(GEP->getOperand(1))->isZero() || 130 isa<Constant>(GEP->getOperand(2))) 131 return nullptr; 132 133 // Check that indices after the variable are constants and in-range for the 134 // type they index. Collect the indices. This is typically for arrays of 135 // structs. 136 SmallVector<unsigned, 4> LaterIndices; 137 138 Type *EltTy = Init->getType()->getArrayElementType(); 139 for (unsigned i = 3, e = GEP->getNumOperands(); i != e; ++i) { 140 ConstantInt *Idx = dyn_cast<ConstantInt>(GEP->getOperand(i)); 141 if (!Idx) return nullptr; // Variable index. 142 143 uint64_t IdxVal = Idx->getZExtValue(); 144 if ((unsigned)IdxVal != IdxVal) return nullptr; // Too large array index. 145 146 if (StructType *STy = dyn_cast<StructType>(EltTy)) 147 EltTy = STy->getElementType(IdxVal); 148 else if (ArrayType *ATy = dyn_cast<ArrayType>(EltTy)) { 149 if (IdxVal >= ATy->getNumElements()) return nullptr; 150 EltTy = ATy->getElementType(); 151 } else { 152 return nullptr; // Unknown type. 153 } 154 155 LaterIndices.push_back(IdxVal); 156 } 157 158 enum { Overdefined = -3, Undefined = -2 }; 159 160 // Variables for our state machines. 161 162 // FirstTrueElement/SecondTrueElement - Used to emit a comparison of the form 163 // "i == 47 | i == 87", where 47 is the first index the condition is true for, 164 // and 87 is the second (and last) index. FirstTrueElement is -2 when 165 // undefined, otherwise set to the first true element. SecondTrueElement is 166 // -2 when undefined, -3 when overdefined and >= 0 when that index is true. 167 int FirstTrueElement = Undefined, SecondTrueElement = Undefined; 168 169 // FirstFalseElement/SecondFalseElement - Used to emit a comparison of the 170 // form "i != 47 & i != 87". Same state transitions as for true elements. 171 int FirstFalseElement = Undefined, SecondFalseElement = Undefined; 172 173 /// TrueRangeEnd/FalseRangeEnd - In conjunction with First*Element, these 174 /// define a state machine that triggers for ranges of values that the index 175 /// is true or false for. This triggers on things like "abbbbc"[i] == 'b'. 176 /// This is -2 when undefined, -3 when overdefined, and otherwise the last 177 /// index in the range (inclusive). We use -2 for undefined here because we 178 /// use relative comparisons and don't want 0-1 to match -1. 179 int TrueRangeEnd = Undefined, FalseRangeEnd = Undefined; 180 181 // MagicBitvector - This is a magic bitvector where we set a bit if the 182 // comparison is true for element 'i'. If there are 64 elements or less in 183 // the array, this will fully represent all the comparison results. 184 uint64_t MagicBitvector = 0; 185 186 // Scan the array and see if one of our patterns matches. 187 Constant *CompareRHS = cast<Constant>(ICI.getOperand(1)); 188 for (unsigned i = 0, e = ArrayElementCount; i != e; ++i) { 189 Constant *Elt = Init->getAggregateElement(i); 190 if (!Elt) return nullptr; 191 192 // If this is indexing an array of structures, get the structure element. 193 if (!LaterIndices.empty()) 194 Elt = ConstantExpr::getExtractValue(Elt, LaterIndices); 195 196 // If the element is masked, handle it. 197 if (AndCst) Elt = ConstantExpr::getAnd(Elt, AndCst); 198 199 // Find out if the comparison would be true or false for the i'th element. 200 Constant *C = ConstantFoldCompareInstOperands(ICI.getPredicate(), Elt, 201 CompareRHS, DL, &TLI); 202 // If the result is undef for this element, ignore it. 203 if (isa<UndefValue>(C)) { 204 // Extend range state machines to cover this element in case there is an 205 // undef in the middle of the range. 206 if (TrueRangeEnd == (int)i-1) 207 TrueRangeEnd = i; 208 if (FalseRangeEnd == (int)i-1) 209 FalseRangeEnd = i; 210 continue; 211 } 212 213 // If we can't compute the result for any of the elements, we have to give 214 // up evaluating the entire conditional. 215 if (!isa<ConstantInt>(C)) return nullptr; 216 217 // Otherwise, we know if the comparison is true or false for this element, 218 // update our state machines. 219 bool IsTrueForElt = !cast<ConstantInt>(C)->isZero(); 220 221 // State machine for single/double/range index comparison. 222 if (IsTrueForElt) { 223 // Update the TrueElement state machine. 224 if (FirstTrueElement == Undefined) 225 FirstTrueElement = TrueRangeEnd = i; // First true element. 226 else { 227 // Update double-compare state machine. 228 if (SecondTrueElement == Undefined) 229 SecondTrueElement = i; 230 else 231 SecondTrueElement = Overdefined; 232 233 // Update range state machine. 234 if (TrueRangeEnd == (int)i-1) 235 TrueRangeEnd = i; 236 else 237 TrueRangeEnd = Overdefined; 238 } 239 } else { 240 // Update the FalseElement state machine. 241 if (FirstFalseElement == Undefined) 242 FirstFalseElement = FalseRangeEnd = i; // First false element. 243 else { 244 // Update double-compare state machine. 245 if (SecondFalseElement == Undefined) 246 SecondFalseElement = i; 247 else 248 SecondFalseElement = Overdefined; 249 250 // Update range state machine. 251 if (FalseRangeEnd == (int)i-1) 252 FalseRangeEnd = i; 253 else 254 FalseRangeEnd = Overdefined; 255 } 256 } 257 258 // If this element is in range, update our magic bitvector. 259 if (i < 64 && IsTrueForElt) 260 MagicBitvector |= 1ULL << i; 261 262 // If all of our states become overdefined, bail out early. Since the 263 // predicate is expensive, only check it every 8 elements. This is only 264 // really useful for really huge arrays. 265 if ((i & 8) == 0 && i >= 64 && SecondTrueElement == Overdefined && 266 SecondFalseElement == Overdefined && TrueRangeEnd == Overdefined && 267 FalseRangeEnd == Overdefined) 268 return nullptr; 269 } 270 271 // Now that we've scanned the entire array, emit our new comparison(s). We 272 // order the state machines in complexity of the generated code. 273 Value *Idx = GEP->getOperand(2); 274 275 // If the index is larger than the pointer size of the target, truncate the 276 // index down like the GEP would do implicitly. We don't have to do this for 277 // an inbounds GEP because the index can't be out of range. 278 if (!GEP->isInBounds()) { 279 Type *IntPtrTy = DL.getIntPtrType(GEP->getType()); 280 unsigned PtrSize = IntPtrTy->getIntegerBitWidth(); 281 if (Idx->getType()->getPrimitiveSizeInBits().getFixedSize() > PtrSize) 282 Idx = Builder.CreateTrunc(Idx, IntPtrTy); 283 } 284 285 // If inbounds keyword is not present, Idx * ElementSize can overflow. 286 // Let's assume that ElementSize is 2 and the wanted value is at offset 0. 287 // Then, there are two possible values for Idx to match offset 0: 288 // 0x00..00, 0x80..00. 289 // Emitting 'icmp eq Idx, 0' isn't correct in this case because the 290 // comparison is false if Idx was 0x80..00. 291 // We need to erase the highest countTrailingZeros(ElementSize) bits of Idx. 292 unsigned ElementSize = 293 DL.getTypeAllocSize(Init->getType()->getArrayElementType()); 294 auto MaskIdx = [&](Value* Idx){ 295 if (!GEP->isInBounds() && countTrailingZeros(ElementSize) != 0) { 296 Value *Mask = ConstantInt::get(Idx->getType(), -1); 297 Mask = Builder.CreateLShr(Mask, countTrailingZeros(ElementSize)); 298 Idx = Builder.CreateAnd(Idx, Mask); 299 } 300 return Idx; 301 }; 302 303 // If the comparison is only true for one or two elements, emit direct 304 // comparisons. 305 if (SecondTrueElement != Overdefined) { 306 Idx = MaskIdx(Idx); 307 // None true -> false. 308 if (FirstTrueElement == Undefined) 309 return replaceInstUsesWith(ICI, Builder.getFalse()); 310 311 Value *FirstTrueIdx = ConstantInt::get(Idx->getType(), FirstTrueElement); 312 313 // True for one element -> 'i == 47'. 314 if (SecondTrueElement == Undefined) 315 return new ICmpInst(ICmpInst::ICMP_EQ, Idx, FirstTrueIdx); 316 317 // True for two elements -> 'i == 47 | i == 72'. 318 Value *C1 = Builder.CreateICmpEQ(Idx, FirstTrueIdx); 319 Value *SecondTrueIdx = ConstantInt::get(Idx->getType(), SecondTrueElement); 320 Value *C2 = Builder.CreateICmpEQ(Idx, SecondTrueIdx); 321 return BinaryOperator::CreateOr(C1, C2); 322 } 323 324 // If the comparison is only false for one or two elements, emit direct 325 // comparisons. 326 if (SecondFalseElement != Overdefined) { 327 Idx = MaskIdx(Idx); 328 // None false -> true. 329 if (FirstFalseElement == Undefined) 330 return replaceInstUsesWith(ICI, Builder.getTrue()); 331 332 Value *FirstFalseIdx = ConstantInt::get(Idx->getType(), FirstFalseElement); 333 334 // False for one element -> 'i != 47'. 335 if (SecondFalseElement == Undefined) 336 return new ICmpInst(ICmpInst::ICMP_NE, Idx, FirstFalseIdx); 337 338 // False for two elements -> 'i != 47 & i != 72'. 339 Value *C1 = Builder.CreateICmpNE(Idx, FirstFalseIdx); 340 Value *SecondFalseIdx = ConstantInt::get(Idx->getType(),SecondFalseElement); 341 Value *C2 = Builder.CreateICmpNE(Idx, SecondFalseIdx); 342 return BinaryOperator::CreateAnd(C1, C2); 343 } 344 345 // If the comparison can be replaced with a range comparison for the elements 346 // where it is true, emit the range check. 347 if (TrueRangeEnd != Overdefined) { 348 assert(TrueRangeEnd != FirstTrueElement && "Should emit single compare"); 349 Idx = MaskIdx(Idx); 350 351 // Generate (i-FirstTrue) <u (TrueRangeEnd-FirstTrue+1). 352 if (FirstTrueElement) { 353 Value *Offs = ConstantInt::get(Idx->getType(), -FirstTrueElement); 354 Idx = Builder.CreateAdd(Idx, Offs); 355 } 356 357 Value *End = ConstantInt::get(Idx->getType(), 358 TrueRangeEnd-FirstTrueElement+1); 359 return new ICmpInst(ICmpInst::ICMP_ULT, Idx, End); 360 } 361 362 // False range check. 363 if (FalseRangeEnd != Overdefined) { 364 assert(FalseRangeEnd != FirstFalseElement && "Should emit single compare"); 365 Idx = MaskIdx(Idx); 366 // Generate (i-FirstFalse) >u (FalseRangeEnd-FirstFalse). 367 if (FirstFalseElement) { 368 Value *Offs = ConstantInt::get(Idx->getType(), -FirstFalseElement); 369 Idx = Builder.CreateAdd(Idx, Offs); 370 } 371 372 Value *End = ConstantInt::get(Idx->getType(), 373 FalseRangeEnd-FirstFalseElement); 374 return new ICmpInst(ICmpInst::ICMP_UGT, Idx, End); 375 } 376 377 // If a magic bitvector captures the entire comparison state 378 // of this load, replace it with computation that does: 379 // ((magic_cst >> i) & 1) != 0 380 { 381 Type *Ty = nullptr; 382 383 // Look for an appropriate type: 384 // - The type of Idx if the magic fits 385 // - The smallest fitting legal type 386 if (ArrayElementCount <= Idx->getType()->getIntegerBitWidth()) 387 Ty = Idx->getType(); 388 else 389 Ty = DL.getSmallestLegalIntType(Init->getContext(), ArrayElementCount); 390 391 if (Ty) { 392 Idx = MaskIdx(Idx); 393 Value *V = Builder.CreateIntCast(Idx, Ty, false); 394 V = Builder.CreateLShr(ConstantInt::get(Ty, MagicBitvector), V); 395 V = Builder.CreateAnd(ConstantInt::get(Ty, 1), V); 396 return new ICmpInst(ICmpInst::ICMP_NE, V, ConstantInt::get(Ty, 0)); 397 } 398 } 399 400 return nullptr; 401 } 402 403 /// Return a value that can be used to compare the *offset* implied by a GEP to 404 /// zero. For example, if we have &A[i], we want to return 'i' for 405 /// "icmp ne i, 0". Note that, in general, indices can be complex, and scales 406 /// are involved. The above expression would also be legal to codegen as 407 /// "icmp ne (i*4), 0" (assuming A is a pointer to i32). 408 /// This latter form is less amenable to optimization though, and we are allowed 409 /// to generate the first by knowing that pointer arithmetic doesn't overflow. 410 /// 411 /// If we can't emit an optimized form for this expression, this returns null. 412 /// 413 static Value *evaluateGEPOffsetExpression(User *GEP, InstCombinerImpl &IC, 414 const DataLayout &DL) { 415 gep_type_iterator GTI = gep_type_begin(GEP); 416 417 // Check to see if this gep only has a single variable index. If so, and if 418 // any constant indices are a multiple of its scale, then we can compute this 419 // in terms of the scale of the variable index. For example, if the GEP 420 // implies an offset of "12 + i*4", then we can codegen this as "3 + i", 421 // because the expression will cross zero at the same point. 422 unsigned i, e = GEP->getNumOperands(); 423 int64_t Offset = 0; 424 for (i = 1; i != e; ++i, ++GTI) { 425 if (ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i))) { 426 // Compute the aggregate offset of constant indices. 427 if (CI->isZero()) continue; 428 429 // Handle a struct index, which adds its field offset to the pointer. 430 if (StructType *STy = GTI.getStructTypeOrNull()) { 431 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 432 } else { 433 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 434 Offset += Size*CI->getSExtValue(); 435 } 436 } else { 437 // Found our variable index. 438 break; 439 } 440 } 441 442 // If there are no variable indices, we must have a constant offset, just 443 // evaluate it the general way. 444 if (i == e) return nullptr; 445 446 Value *VariableIdx = GEP->getOperand(i); 447 // Determine the scale factor of the variable element. For example, this is 448 // 4 if the variable index is into an array of i32. 449 uint64_t VariableScale = DL.getTypeAllocSize(GTI.getIndexedType()); 450 451 // Verify that there are no other variable indices. If so, emit the hard way. 452 for (++i, ++GTI; i != e; ++i, ++GTI) { 453 ConstantInt *CI = dyn_cast<ConstantInt>(GEP->getOperand(i)); 454 if (!CI) return nullptr; 455 456 // Compute the aggregate offset of constant indices. 457 if (CI->isZero()) continue; 458 459 // Handle a struct index, which adds its field offset to the pointer. 460 if (StructType *STy = GTI.getStructTypeOrNull()) { 461 Offset += DL.getStructLayout(STy)->getElementOffset(CI->getZExtValue()); 462 } else { 463 uint64_t Size = DL.getTypeAllocSize(GTI.getIndexedType()); 464 Offset += Size*CI->getSExtValue(); 465 } 466 } 467 468 // Okay, we know we have a single variable index, which must be a 469 // pointer/array/vector index. If there is no offset, life is simple, return 470 // the index. 471 Type *IntPtrTy = DL.getIntPtrType(GEP->getOperand(0)->getType()); 472 unsigned IntPtrWidth = IntPtrTy->getIntegerBitWidth(); 473 if (Offset == 0) { 474 // Cast to intptrty in case a truncation occurs. If an extension is needed, 475 // we don't need to bother extending: the extension won't affect where the 476 // computation crosses zero. 477 if (VariableIdx->getType()->getPrimitiveSizeInBits().getFixedSize() > 478 IntPtrWidth) { 479 VariableIdx = IC.Builder.CreateTrunc(VariableIdx, IntPtrTy); 480 } 481 return VariableIdx; 482 } 483 484 // Otherwise, there is an index. The computation we will do will be modulo 485 // the pointer size. 486 Offset = SignExtend64(Offset, IntPtrWidth); 487 VariableScale = SignExtend64(VariableScale, IntPtrWidth); 488 489 // To do this transformation, any constant index must be a multiple of the 490 // variable scale factor. For example, we can evaluate "12 + 4*i" as "3 + i", 491 // but we can't evaluate "10 + 3*i" in terms of i. Check that the offset is a 492 // multiple of the variable scale. 493 int64_t NewOffs = Offset / (int64_t)VariableScale; 494 if (Offset != NewOffs*(int64_t)VariableScale) 495 return nullptr; 496 497 // Okay, we can do this evaluation. Start by converting the index to intptr. 498 if (VariableIdx->getType() != IntPtrTy) 499 VariableIdx = IC.Builder.CreateIntCast(VariableIdx, IntPtrTy, 500 true /*Signed*/); 501 Constant *OffsetVal = ConstantInt::get(IntPtrTy, NewOffs); 502 return IC.Builder.CreateAdd(VariableIdx, OffsetVal, "offset"); 503 } 504 505 /// Returns true if we can rewrite Start as a GEP with pointer Base 506 /// and some integer offset. The nodes that need to be re-written 507 /// for this transformation will be added to Explored. 508 static bool canRewriteGEPAsOffset(Type *ElemTy, Value *Start, Value *Base, 509 const DataLayout &DL, 510 SetVector<Value *> &Explored) { 511 SmallVector<Value *, 16> WorkList(1, Start); 512 Explored.insert(Base); 513 514 // The following traversal gives us an order which can be used 515 // when doing the final transformation. Since in the final 516 // transformation we create the PHI replacement instructions first, 517 // we don't have to get them in any particular order. 518 // 519 // However, for other instructions we will have to traverse the 520 // operands of an instruction first, which means that we have to 521 // do a post-order traversal. 522 while (!WorkList.empty()) { 523 SetVector<PHINode *> PHIs; 524 525 while (!WorkList.empty()) { 526 if (Explored.size() >= 100) 527 return false; 528 529 Value *V = WorkList.back(); 530 531 if (Explored.contains(V)) { 532 WorkList.pop_back(); 533 continue; 534 } 535 536 if (!isa<IntToPtrInst>(V) && !isa<PtrToIntInst>(V) && 537 !isa<GetElementPtrInst>(V) && !isa<PHINode>(V)) 538 // We've found some value that we can't explore which is different from 539 // the base. Therefore we can't do this transformation. 540 return false; 541 542 if (isa<IntToPtrInst>(V) || isa<PtrToIntInst>(V)) { 543 auto *CI = cast<CastInst>(V); 544 if (!CI->isNoopCast(DL)) 545 return false; 546 547 if (!Explored.contains(CI->getOperand(0))) 548 WorkList.push_back(CI->getOperand(0)); 549 } 550 551 if (auto *GEP = dyn_cast<GEPOperator>(V)) { 552 // We're limiting the GEP to having one index. This will preserve 553 // the original pointer type. We could handle more cases in the 554 // future. 555 if (GEP->getNumIndices() != 1 || !GEP->isInBounds() || 556 GEP->getSourceElementType() != ElemTy) 557 return false; 558 559 if (!Explored.contains(GEP->getOperand(0))) 560 WorkList.push_back(GEP->getOperand(0)); 561 } 562 563 if (WorkList.back() == V) { 564 WorkList.pop_back(); 565 // We've finished visiting this node, mark it as such. 566 Explored.insert(V); 567 } 568 569 if (auto *PN = dyn_cast<PHINode>(V)) { 570 // We cannot transform PHIs on unsplittable basic blocks. 571 if (isa<CatchSwitchInst>(PN->getParent()->getTerminator())) 572 return false; 573 Explored.insert(PN); 574 PHIs.insert(PN); 575 } 576 } 577 578 // Explore the PHI nodes further. 579 for (auto *PN : PHIs) 580 for (Value *Op : PN->incoming_values()) 581 if (!Explored.contains(Op)) 582 WorkList.push_back(Op); 583 } 584 585 // Make sure that we can do this. Since we can't insert GEPs in a basic 586 // block before a PHI node, we can't easily do this transformation if 587 // we have PHI node users of transformed instructions. 588 for (Value *Val : Explored) { 589 for (Value *Use : Val->uses()) { 590 591 auto *PHI = dyn_cast<PHINode>(Use); 592 auto *Inst = dyn_cast<Instruction>(Val); 593 594 if (Inst == Base || Inst == PHI || !Inst || !PHI || 595 !Explored.contains(PHI)) 596 continue; 597 598 if (PHI->getParent() == Inst->getParent()) 599 return false; 600 } 601 } 602 return true; 603 } 604 605 // Sets the appropriate insert point on Builder where we can add 606 // a replacement Instruction for V (if that is possible). 607 static void setInsertionPoint(IRBuilder<> &Builder, Value *V, 608 bool Before = true) { 609 if (auto *PHI = dyn_cast<PHINode>(V)) { 610 Builder.SetInsertPoint(&*PHI->getParent()->getFirstInsertionPt()); 611 return; 612 } 613 if (auto *I = dyn_cast<Instruction>(V)) { 614 if (!Before) 615 I = &*std::next(I->getIterator()); 616 Builder.SetInsertPoint(I); 617 return; 618 } 619 if (auto *A = dyn_cast<Argument>(V)) { 620 // Set the insertion point in the entry block. 621 BasicBlock &Entry = A->getParent()->getEntryBlock(); 622 Builder.SetInsertPoint(&*Entry.getFirstInsertionPt()); 623 return; 624 } 625 // Otherwise, this is a constant and we don't need to set a new 626 // insertion point. 627 assert(isa<Constant>(V) && "Setting insertion point for unknown value!"); 628 } 629 630 /// Returns a re-written value of Start as an indexed GEP using Base as a 631 /// pointer. 632 static Value *rewriteGEPAsOffset(Type *ElemTy, Value *Start, Value *Base, 633 const DataLayout &DL, 634 SetVector<Value *> &Explored) { 635 // Perform all the substitutions. This is a bit tricky because we can 636 // have cycles in our use-def chains. 637 // 1. Create the PHI nodes without any incoming values. 638 // 2. Create all the other values. 639 // 3. Add the edges for the PHI nodes. 640 // 4. Emit GEPs to get the original pointers. 641 // 5. Remove the original instructions. 642 Type *IndexType = IntegerType::get( 643 Base->getContext(), DL.getIndexTypeSizeInBits(Start->getType())); 644 645 DenseMap<Value *, Value *> NewInsts; 646 NewInsts[Base] = ConstantInt::getNullValue(IndexType); 647 648 // Create the new PHI nodes, without adding any incoming values. 649 for (Value *Val : Explored) { 650 if (Val == Base) 651 continue; 652 // Create empty phi nodes. This avoids cyclic dependencies when creating 653 // the remaining instructions. 654 if (auto *PHI = dyn_cast<PHINode>(Val)) 655 NewInsts[PHI] = PHINode::Create(IndexType, PHI->getNumIncomingValues(), 656 PHI->getName() + ".idx", PHI); 657 } 658 IRBuilder<> Builder(Base->getContext()); 659 660 // Create all the other instructions. 661 for (Value *Val : Explored) { 662 663 if (NewInsts.find(Val) != NewInsts.end()) 664 continue; 665 666 if (auto *CI = dyn_cast<CastInst>(Val)) { 667 // Don't get rid of the intermediate variable here; the store can grow 668 // the map which will invalidate the reference to the input value. 669 Value *V = NewInsts[CI->getOperand(0)]; 670 NewInsts[CI] = V; 671 continue; 672 } 673 if (auto *GEP = dyn_cast<GEPOperator>(Val)) { 674 Value *Index = NewInsts[GEP->getOperand(1)] ? NewInsts[GEP->getOperand(1)] 675 : GEP->getOperand(1); 676 setInsertionPoint(Builder, GEP); 677 // Indices might need to be sign extended. GEPs will magically do 678 // this, but we need to do it ourselves here. 679 if (Index->getType()->getScalarSizeInBits() != 680 NewInsts[GEP->getOperand(0)]->getType()->getScalarSizeInBits()) { 681 Index = Builder.CreateSExtOrTrunc( 682 Index, NewInsts[GEP->getOperand(0)]->getType(), 683 GEP->getOperand(0)->getName() + ".sext"); 684 } 685 686 auto *Op = NewInsts[GEP->getOperand(0)]; 687 if (isa<ConstantInt>(Op) && cast<ConstantInt>(Op)->isZero()) 688 NewInsts[GEP] = Index; 689 else 690 NewInsts[GEP] = Builder.CreateNSWAdd( 691 Op, Index, GEP->getOperand(0)->getName() + ".add"); 692 continue; 693 } 694 if (isa<PHINode>(Val)) 695 continue; 696 697 llvm_unreachable("Unexpected instruction type"); 698 } 699 700 // Add the incoming values to the PHI nodes. 701 for (Value *Val : Explored) { 702 if (Val == Base) 703 continue; 704 // All the instructions have been created, we can now add edges to the 705 // phi nodes. 706 if (auto *PHI = dyn_cast<PHINode>(Val)) { 707 PHINode *NewPhi = static_cast<PHINode *>(NewInsts[PHI]); 708 for (unsigned I = 0, E = PHI->getNumIncomingValues(); I < E; ++I) { 709 Value *NewIncoming = PHI->getIncomingValue(I); 710 711 if (NewInsts.find(NewIncoming) != NewInsts.end()) 712 NewIncoming = NewInsts[NewIncoming]; 713 714 NewPhi->addIncoming(NewIncoming, PHI->getIncomingBlock(I)); 715 } 716 } 717 } 718 719 PointerType *PtrTy = 720 ElemTy->getPointerTo(Start->getType()->getPointerAddressSpace()); 721 for (Value *Val : Explored) { 722 if (Val == Base) 723 continue; 724 725 // Depending on the type, for external users we have to emit 726 // a GEP or a GEP + ptrtoint. 727 setInsertionPoint(Builder, Val, false); 728 729 // Cast base to the expected type. 730 Value *NewVal = Builder.CreateBitOrPointerCast( 731 Base, PtrTy, Start->getName() + "to.ptr"); 732 NewVal = Builder.CreateInBoundsGEP( 733 ElemTy, NewVal, makeArrayRef(NewInsts[Val]), Val->getName() + ".ptr"); 734 NewVal = Builder.CreateBitOrPointerCast( 735 NewVal, Val->getType(), Val->getName() + ".conv"); 736 Val->replaceAllUsesWith(NewVal); 737 } 738 739 return NewInsts[Start]; 740 } 741 742 /// Looks through GEPs, IntToPtrInsts and PtrToIntInsts in order to express 743 /// the input Value as a constant indexed GEP. Returns a pair containing 744 /// the GEPs Pointer and Index. 745 static std::pair<Value *, Value *> 746 getAsConstantIndexedAddress(Type *ElemTy, Value *V, const DataLayout &DL) { 747 Type *IndexType = IntegerType::get(V->getContext(), 748 DL.getIndexTypeSizeInBits(V->getType())); 749 750 Constant *Index = ConstantInt::getNullValue(IndexType); 751 while (true) { 752 if (GEPOperator *GEP = dyn_cast<GEPOperator>(V)) { 753 // We accept only inbouds GEPs here to exclude the possibility of 754 // overflow. 755 if (!GEP->isInBounds()) 756 break; 757 if (GEP->hasAllConstantIndices() && GEP->getNumIndices() == 1 && 758 GEP->getSourceElementType() == ElemTy) { 759 V = GEP->getOperand(0); 760 Constant *GEPIndex = static_cast<Constant *>(GEP->getOperand(1)); 761 Index = ConstantExpr::getAdd( 762 Index, ConstantExpr::getSExtOrTrunc(GEPIndex, IndexType)); 763 continue; 764 } 765 break; 766 } 767 if (auto *CI = dyn_cast<IntToPtrInst>(V)) { 768 if (!CI->isNoopCast(DL)) 769 break; 770 V = CI->getOperand(0); 771 continue; 772 } 773 if (auto *CI = dyn_cast<PtrToIntInst>(V)) { 774 if (!CI->isNoopCast(DL)) 775 break; 776 V = CI->getOperand(0); 777 continue; 778 } 779 break; 780 } 781 return {V, Index}; 782 } 783 784 /// Converts (CMP GEPLHS, RHS) if this change would make RHS a constant. 785 /// We can look through PHIs, GEPs and casts in order to determine a common base 786 /// between GEPLHS and RHS. 787 static Instruction *transformToIndexedCompare(GEPOperator *GEPLHS, Value *RHS, 788 ICmpInst::Predicate Cond, 789 const DataLayout &DL) { 790 // FIXME: Support vector of pointers. 791 if (GEPLHS->getType()->isVectorTy()) 792 return nullptr; 793 794 if (!GEPLHS->hasAllConstantIndices()) 795 return nullptr; 796 797 Type *ElemTy = GEPLHS->getSourceElementType(); 798 Value *PtrBase, *Index; 799 std::tie(PtrBase, Index) = getAsConstantIndexedAddress(ElemTy, GEPLHS, DL); 800 801 // The set of nodes that will take part in this transformation. 802 SetVector<Value *> Nodes; 803 804 if (!canRewriteGEPAsOffset(ElemTy, RHS, PtrBase, DL, Nodes)) 805 return nullptr; 806 807 // We know we can re-write this as 808 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) 809 // Since we've only looked through inbouds GEPs we know that we 810 // can't have overflow on either side. We can therefore re-write 811 // this as: 812 // OFFSET1 cmp OFFSET2 813 Value *NewRHS = rewriteGEPAsOffset(ElemTy, RHS, PtrBase, DL, Nodes); 814 815 // RewriteGEPAsOffset has replaced RHS and all of its uses with a re-written 816 // GEP having PtrBase as the pointer base, and has returned in NewRHS the 817 // offset. Since Index is the offset of LHS to the base pointer, we will now 818 // compare the offsets instead of comparing the pointers. 819 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Index, NewRHS); 820 } 821 822 /// Fold comparisons between a GEP instruction and something else. At this point 823 /// we know that the GEP is on the LHS of the comparison. 824 Instruction *InstCombinerImpl::foldGEPICmp(GEPOperator *GEPLHS, Value *RHS, 825 ICmpInst::Predicate Cond, 826 Instruction &I) { 827 // Don't transform signed compares of GEPs into index compares. Even if the 828 // GEP is inbounds, the final add of the base pointer can have signed overflow 829 // and would change the result of the icmp. 830 // e.g. "&foo[0] <s &foo[1]" can't be folded to "true" because "foo" could be 831 // the maximum signed value for the pointer type. 832 if (ICmpInst::isSigned(Cond)) 833 return nullptr; 834 835 // Look through bitcasts and addrspacecasts. We do not however want to remove 836 // 0 GEPs. 837 if (!isa<GetElementPtrInst>(RHS)) 838 RHS = RHS->stripPointerCasts(); 839 840 Value *PtrBase = GEPLHS->getOperand(0); 841 // FIXME: Support vector pointer GEPs. 842 if (PtrBase == RHS && GEPLHS->isInBounds() && 843 !GEPLHS->getType()->isVectorTy()) { 844 // ((gep Ptr, OFFSET) cmp Ptr) ---> (OFFSET cmp 0). 845 // This transformation (ignoring the base and scales) is valid because we 846 // know pointers can't overflow since the gep is inbounds. See if we can 847 // output an optimized form. 848 Value *Offset = evaluateGEPOffsetExpression(GEPLHS, *this, DL); 849 850 // If not, synthesize the offset the hard way. 851 if (!Offset) 852 Offset = EmitGEPOffset(GEPLHS); 853 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), Offset, 854 Constant::getNullValue(Offset->getType())); 855 } 856 857 if (GEPLHS->isInBounds() && ICmpInst::isEquality(Cond) && 858 isa<Constant>(RHS) && cast<Constant>(RHS)->isNullValue() && 859 !NullPointerIsDefined(I.getFunction(), 860 RHS->getType()->getPointerAddressSpace())) { 861 // For most address spaces, an allocation can't be placed at null, but null 862 // itself is treated as a 0 size allocation in the in bounds rules. Thus, 863 // the only valid inbounds address derived from null, is null itself. 864 // Thus, we have four cases to consider: 865 // 1) Base == nullptr, Offset == 0 -> inbounds, null 866 // 2) Base == nullptr, Offset != 0 -> poison as the result is out of bounds 867 // 3) Base != nullptr, Offset == (-base) -> poison (crossing allocations) 868 // 4) Base != nullptr, Offset != (-base) -> nonnull (and possibly poison) 869 // 870 // (Note if we're indexing a type of size 0, that simply collapses into one 871 // of the buckets above.) 872 // 873 // In general, we're allowed to make values less poison (i.e. remove 874 // sources of full UB), so in this case, we just select between the two 875 // non-poison cases (1 and 4 above). 876 // 877 // For vectors, we apply the same reasoning on a per-lane basis. 878 auto *Base = GEPLHS->getPointerOperand(); 879 if (GEPLHS->getType()->isVectorTy() && Base->getType()->isPointerTy()) { 880 auto EC = cast<VectorType>(GEPLHS->getType())->getElementCount(); 881 Base = Builder.CreateVectorSplat(EC, Base); 882 } 883 return new ICmpInst(Cond, Base, 884 ConstantExpr::getPointerBitCastOrAddrSpaceCast( 885 cast<Constant>(RHS), Base->getType())); 886 } else if (GEPOperator *GEPRHS = dyn_cast<GEPOperator>(RHS)) { 887 // If the base pointers are different, but the indices are the same, just 888 // compare the base pointer. 889 if (PtrBase != GEPRHS->getOperand(0)) { 890 bool IndicesTheSame = 891 GEPLHS->getNumOperands() == GEPRHS->getNumOperands() && 892 GEPLHS->getPointerOperand()->getType() == 893 GEPRHS->getPointerOperand()->getType() && 894 GEPLHS->getSourceElementType() == GEPRHS->getSourceElementType(); 895 if (IndicesTheSame) 896 for (unsigned i = 1, e = GEPLHS->getNumOperands(); i != e; ++i) 897 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 898 IndicesTheSame = false; 899 break; 900 } 901 902 // If all indices are the same, just compare the base pointers. 903 Type *BaseType = GEPLHS->getOperand(0)->getType(); 904 if (IndicesTheSame && CmpInst::makeCmpResultType(BaseType) == I.getType()) 905 return new ICmpInst(Cond, GEPLHS->getOperand(0), GEPRHS->getOperand(0)); 906 907 // If we're comparing GEPs with two base pointers that only differ in type 908 // and both GEPs have only constant indices or just one use, then fold 909 // the compare with the adjusted indices. 910 // FIXME: Support vector of pointers. 911 if (GEPLHS->isInBounds() && GEPRHS->isInBounds() && 912 (GEPLHS->hasAllConstantIndices() || GEPLHS->hasOneUse()) && 913 (GEPRHS->hasAllConstantIndices() || GEPRHS->hasOneUse()) && 914 PtrBase->stripPointerCasts() == 915 GEPRHS->getOperand(0)->stripPointerCasts() && 916 !GEPLHS->getType()->isVectorTy()) { 917 Value *LOffset = EmitGEPOffset(GEPLHS); 918 Value *ROffset = EmitGEPOffset(GEPRHS); 919 920 // If we looked through an addrspacecast between different sized address 921 // spaces, the LHS and RHS pointers are different sized 922 // integers. Truncate to the smaller one. 923 Type *LHSIndexTy = LOffset->getType(); 924 Type *RHSIndexTy = ROffset->getType(); 925 if (LHSIndexTy != RHSIndexTy) { 926 if (LHSIndexTy->getPrimitiveSizeInBits().getFixedSize() < 927 RHSIndexTy->getPrimitiveSizeInBits().getFixedSize()) { 928 ROffset = Builder.CreateTrunc(ROffset, LHSIndexTy); 929 } else 930 LOffset = Builder.CreateTrunc(LOffset, RHSIndexTy); 931 } 932 933 Value *Cmp = Builder.CreateICmp(ICmpInst::getSignedPredicate(Cond), 934 LOffset, ROffset); 935 return replaceInstUsesWith(I, Cmp); 936 } 937 938 // Otherwise, the base pointers are different and the indices are 939 // different. Try convert this to an indexed compare by looking through 940 // PHIs/casts. 941 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 942 } 943 944 // If one of the GEPs has all zero indices, recurse. 945 // FIXME: Handle vector of pointers. 946 if (!GEPLHS->getType()->isVectorTy() && GEPLHS->hasAllZeroIndices()) 947 return foldGEPICmp(GEPRHS, GEPLHS->getOperand(0), 948 ICmpInst::getSwappedPredicate(Cond), I); 949 950 // If the other GEP has all zero indices, recurse. 951 // FIXME: Handle vector of pointers. 952 if (!GEPRHS->getType()->isVectorTy() && GEPRHS->hasAllZeroIndices()) 953 return foldGEPICmp(GEPLHS, GEPRHS->getOperand(0), Cond, I); 954 955 bool GEPsInBounds = GEPLHS->isInBounds() && GEPRHS->isInBounds(); 956 if (GEPLHS->getNumOperands() == GEPRHS->getNumOperands() && 957 GEPLHS->getSourceElementType() == GEPRHS->getSourceElementType()) { 958 // If the GEPs only differ by one index, compare it. 959 unsigned NumDifferences = 0; // Keep track of # differences. 960 unsigned DiffOperand = 0; // The operand that differs. 961 for (unsigned i = 1, e = GEPRHS->getNumOperands(); i != e; ++i) 962 if (GEPLHS->getOperand(i) != GEPRHS->getOperand(i)) { 963 Type *LHSType = GEPLHS->getOperand(i)->getType(); 964 Type *RHSType = GEPRHS->getOperand(i)->getType(); 965 // FIXME: Better support for vector of pointers. 966 if (LHSType->getPrimitiveSizeInBits() != 967 RHSType->getPrimitiveSizeInBits() || 968 (GEPLHS->getType()->isVectorTy() && 969 (!LHSType->isVectorTy() || !RHSType->isVectorTy()))) { 970 // Irreconcilable differences. 971 NumDifferences = 2; 972 break; 973 } 974 975 if (NumDifferences++) break; 976 DiffOperand = i; 977 } 978 979 if (NumDifferences == 0) // SAME GEP? 980 return replaceInstUsesWith(I, // No comparison is needed here. 981 ConstantInt::get(I.getType(), ICmpInst::isTrueWhenEqual(Cond))); 982 983 else if (NumDifferences == 1 && GEPsInBounds) { 984 Value *LHSV = GEPLHS->getOperand(DiffOperand); 985 Value *RHSV = GEPRHS->getOperand(DiffOperand); 986 // Make sure we do a signed comparison here. 987 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), LHSV, RHSV); 988 } 989 } 990 991 // Only lower this if the icmp is the only user of the GEP or if we expect 992 // the result to fold to a constant! 993 if (GEPsInBounds && (isa<ConstantExpr>(GEPLHS) || GEPLHS->hasOneUse()) && 994 (isa<ConstantExpr>(GEPRHS) || GEPRHS->hasOneUse())) { 995 // ((gep Ptr, OFFSET1) cmp (gep Ptr, OFFSET2) ---> (OFFSET1 cmp OFFSET2) 996 Value *L = EmitGEPOffset(GEPLHS); 997 Value *R = EmitGEPOffset(GEPRHS); 998 return new ICmpInst(ICmpInst::getSignedPredicate(Cond), L, R); 999 } 1000 } 1001 1002 // Try convert this to an indexed compare by looking through PHIs/casts as a 1003 // last resort. 1004 return transformToIndexedCompare(GEPLHS, RHS, Cond, DL); 1005 } 1006 1007 Instruction *InstCombinerImpl::foldAllocaCmp(ICmpInst &ICI, 1008 const AllocaInst *Alloca) { 1009 assert(ICI.isEquality() && "Cannot fold non-equality comparison."); 1010 1011 // It would be tempting to fold away comparisons between allocas and any 1012 // pointer not based on that alloca (e.g. an argument). However, even 1013 // though such pointers cannot alias, they can still compare equal. 1014 // 1015 // But LLVM doesn't specify where allocas get their memory, so if the alloca 1016 // doesn't escape we can argue that it's impossible to guess its value, and we 1017 // can therefore act as if any such guesses are wrong. 1018 // 1019 // The code below checks that the alloca doesn't escape, and that it's only 1020 // used in a comparison once (the current instruction). The 1021 // single-comparison-use condition ensures that we're trivially folding all 1022 // comparisons against the alloca consistently, and avoids the risk of 1023 // erroneously folding a comparison of the pointer with itself. 1024 1025 unsigned MaxIter = 32; // Break cycles and bound to constant-time. 1026 1027 SmallVector<const Use *, 32> Worklist; 1028 for (const Use &U : Alloca->uses()) { 1029 if (Worklist.size() >= MaxIter) 1030 return nullptr; 1031 Worklist.push_back(&U); 1032 } 1033 1034 unsigned NumCmps = 0; 1035 while (!Worklist.empty()) { 1036 assert(Worklist.size() <= MaxIter); 1037 const Use *U = Worklist.pop_back_val(); 1038 const Value *V = U->getUser(); 1039 --MaxIter; 1040 1041 if (isa<BitCastInst>(V) || isa<GetElementPtrInst>(V) || isa<PHINode>(V) || 1042 isa<SelectInst>(V)) { 1043 // Track the uses. 1044 } else if (isa<LoadInst>(V)) { 1045 // Loading from the pointer doesn't escape it. 1046 continue; 1047 } else if (const auto *SI = dyn_cast<StoreInst>(V)) { 1048 // Storing *to* the pointer is fine, but storing the pointer escapes it. 1049 if (SI->getValueOperand() == U->get()) 1050 return nullptr; 1051 continue; 1052 } else if (isa<ICmpInst>(V)) { 1053 if (NumCmps++) 1054 return nullptr; // Found more than one cmp. 1055 continue; 1056 } else if (const auto *Intrin = dyn_cast<IntrinsicInst>(V)) { 1057 switch (Intrin->getIntrinsicID()) { 1058 // These intrinsics don't escape or compare the pointer. Memset is safe 1059 // because we don't allow ptrtoint. Memcpy and memmove are safe because 1060 // we don't allow stores, so src cannot point to V. 1061 case Intrinsic::lifetime_start: case Intrinsic::lifetime_end: 1062 case Intrinsic::memcpy: case Intrinsic::memmove: case Intrinsic::memset: 1063 continue; 1064 default: 1065 return nullptr; 1066 } 1067 } else { 1068 return nullptr; 1069 } 1070 for (const Use &U : V->uses()) { 1071 if (Worklist.size() >= MaxIter) 1072 return nullptr; 1073 Worklist.push_back(&U); 1074 } 1075 } 1076 1077 auto *Res = ConstantInt::get(ICI.getType(), 1078 !CmpInst::isTrueWhenEqual(ICI.getPredicate())); 1079 return replaceInstUsesWith(ICI, Res); 1080 } 1081 1082 /// Fold "icmp pred (X+C), X". 1083 Instruction *InstCombinerImpl::foldICmpAddOpConst(Value *X, const APInt &C, 1084 ICmpInst::Predicate Pred) { 1085 // From this point on, we know that (X+C <= X) --> (X+C < X) because C != 0, 1086 // so the values can never be equal. Similarly for all other "or equals" 1087 // operators. 1088 assert(!!C && "C should not be zero!"); 1089 1090 // (X+1) <u X --> X >u (MAXUINT-1) --> X == 255 1091 // (X+2) <u X --> X >u (MAXUINT-2) --> X > 253 1092 // (X+MAXUINT) <u X --> X >u (MAXUINT-MAXUINT) --> X != 0 1093 if (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_ULE) { 1094 Constant *R = ConstantInt::get(X->getType(), 1095 APInt::getMaxValue(C.getBitWidth()) - C); 1096 return new ICmpInst(ICmpInst::ICMP_UGT, X, R); 1097 } 1098 1099 // (X+1) >u X --> X <u (0-1) --> X != 255 1100 // (X+2) >u X --> X <u (0-2) --> X <u 254 1101 // (X+MAXUINT) >u X --> X <u (0-MAXUINT) --> X <u 1 --> X == 0 1102 if (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_UGE) 1103 return new ICmpInst(ICmpInst::ICMP_ULT, X, 1104 ConstantInt::get(X->getType(), -C)); 1105 1106 APInt SMax = APInt::getSignedMaxValue(C.getBitWidth()); 1107 1108 // (X+ 1) <s X --> X >s (MAXSINT-1) --> X == 127 1109 // (X+ 2) <s X --> X >s (MAXSINT-2) --> X >s 125 1110 // (X+MAXSINT) <s X --> X >s (MAXSINT-MAXSINT) --> X >s 0 1111 // (X+MINSINT) <s X --> X >s (MAXSINT-MINSINT) --> X >s -1 1112 // (X+ -2) <s X --> X >s (MAXSINT- -2) --> X >s 126 1113 // (X+ -1) <s X --> X >s (MAXSINT- -1) --> X != 127 1114 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 1115 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1116 ConstantInt::get(X->getType(), SMax - C)); 1117 1118 // (X+ 1) >s X --> X <s (MAXSINT-(1-1)) --> X != 127 1119 // (X+ 2) >s X --> X <s (MAXSINT-(2-1)) --> X <s 126 1120 // (X+MAXSINT) >s X --> X <s (MAXSINT-(MAXSINT-1)) --> X <s 1 1121 // (X+MINSINT) >s X --> X <s (MAXSINT-(MINSINT-1)) --> X <s -2 1122 // (X+ -2) >s X --> X <s (MAXSINT-(-2-1)) --> X <s -126 1123 // (X+ -1) >s X --> X <s (MAXSINT-(-1-1)) --> X == -128 1124 1125 assert(Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE); 1126 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1127 ConstantInt::get(X->getType(), SMax - (C - 1))); 1128 } 1129 1130 /// Handle "(icmp eq/ne (ashr/lshr AP2, A), AP1)" -> 1131 /// (icmp eq/ne A, Log2(AP2/AP1)) -> 1132 /// (icmp eq/ne A, Log2(AP2) - Log2(AP1)). 1133 Instruction *InstCombinerImpl::foldICmpShrConstConst(ICmpInst &I, Value *A, 1134 const APInt &AP1, 1135 const APInt &AP2) { 1136 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1137 1138 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1139 if (I.getPredicate() == I.ICMP_NE) 1140 Pred = CmpInst::getInversePredicate(Pred); 1141 return new ICmpInst(Pred, LHS, RHS); 1142 }; 1143 1144 // Don't bother doing any work for cases which InstSimplify handles. 1145 if (AP2.isZero()) 1146 return nullptr; 1147 1148 bool IsAShr = isa<AShrOperator>(I.getOperand(0)); 1149 if (IsAShr) { 1150 if (AP2.isAllOnes()) 1151 return nullptr; 1152 if (AP2.isNegative() != AP1.isNegative()) 1153 return nullptr; 1154 if (AP2.sgt(AP1)) 1155 return nullptr; 1156 } 1157 1158 if (!AP1) 1159 // 'A' must be large enough to shift out the highest set bit. 1160 return getICmp(I.ICMP_UGT, A, 1161 ConstantInt::get(A->getType(), AP2.logBase2())); 1162 1163 if (AP1 == AP2) 1164 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1165 1166 int Shift; 1167 if (IsAShr && AP1.isNegative()) 1168 Shift = AP1.countLeadingOnes() - AP2.countLeadingOnes(); 1169 else 1170 Shift = AP1.countLeadingZeros() - AP2.countLeadingZeros(); 1171 1172 if (Shift > 0) { 1173 if (IsAShr && AP1 == AP2.ashr(Shift)) { 1174 // There are multiple solutions if we are comparing against -1 and the LHS 1175 // of the ashr is not a power of two. 1176 if (AP1.isAllOnes() && !AP2.isPowerOf2()) 1177 return getICmp(I.ICMP_UGE, A, ConstantInt::get(A->getType(), Shift)); 1178 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1179 } else if (AP1 == AP2.lshr(Shift)) { 1180 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1181 } 1182 } 1183 1184 // Shifting const2 will never be equal to const1. 1185 // FIXME: This should always be handled by InstSimplify? 1186 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1187 return replaceInstUsesWith(I, TorF); 1188 } 1189 1190 /// Handle "(icmp eq/ne (shl AP2, A), AP1)" -> 1191 /// (icmp eq/ne A, TrailingZeros(AP1) - TrailingZeros(AP2)). 1192 Instruction *InstCombinerImpl::foldICmpShlConstConst(ICmpInst &I, Value *A, 1193 const APInt &AP1, 1194 const APInt &AP2) { 1195 assert(I.isEquality() && "Cannot fold icmp gt/lt"); 1196 1197 auto getICmp = [&I](CmpInst::Predicate Pred, Value *LHS, Value *RHS) { 1198 if (I.getPredicate() == I.ICMP_NE) 1199 Pred = CmpInst::getInversePredicate(Pred); 1200 return new ICmpInst(Pred, LHS, RHS); 1201 }; 1202 1203 // Don't bother doing any work for cases which InstSimplify handles. 1204 if (AP2.isZero()) 1205 return nullptr; 1206 1207 unsigned AP2TrailingZeros = AP2.countTrailingZeros(); 1208 1209 if (!AP1 && AP2TrailingZeros != 0) 1210 return getICmp( 1211 I.ICMP_UGE, A, 1212 ConstantInt::get(A->getType(), AP2.getBitWidth() - AP2TrailingZeros)); 1213 1214 if (AP1 == AP2) 1215 return getICmp(I.ICMP_EQ, A, ConstantInt::getNullValue(A->getType())); 1216 1217 // Get the distance between the lowest bits that are set. 1218 int Shift = AP1.countTrailingZeros() - AP2TrailingZeros; 1219 1220 if (Shift > 0 && AP2.shl(Shift) == AP1) 1221 return getICmp(I.ICMP_EQ, A, ConstantInt::get(A->getType(), Shift)); 1222 1223 // Shifting const2 will never be equal to const1. 1224 // FIXME: This should always be handled by InstSimplify? 1225 auto *TorF = ConstantInt::get(I.getType(), I.getPredicate() == I.ICMP_NE); 1226 return replaceInstUsesWith(I, TorF); 1227 } 1228 1229 /// The caller has matched a pattern of the form: 1230 /// I = icmp ugt (add (add A, B), CI2), CI1 1231 /// If this is of the form: 1232 /// sum = a + b 1233 /// if (sum+128 >u 255) 1234 /// Then replace it with llvm.sadd.with.overflow.i8. 1235 /// 1236 static Instruction *processUGT_ADDCST_ADD(ICmpInst &I, Value *A, Value *B, 1237 ConstantInt *CI2, ConstantInt *CI1, 1238 InstCombinerImpl &IC) { 1239 // The transformation we're trying to do here is to transform this into an 1240 // llvm.sadd.with.overflow. To do this, we have to replace the original add 1241 // with a narrower add, and discard the add-with-constant that is part of the 1242 // range check (if we can't eliminate it, this isn't profitable). 1243 1244 // In order to eliminate the add-with-constant, the compare can be its only 1245 // use. 1246 Instruction *AddWithCst = cast<Instruction>(I.getOperand(0)); 1247 if (!AddWithCst->hasOneUse()) 1248 return nullptr; 1249 1250 // If CI2 is 2^7, 2^15, 2^31, then it might be an sadd.with.overflow. 1251 if (!CI2->getValue().isPowerOf2()) 1252 return nullptr; 1253 unsigned NewWidth = CI2->getValue().countTrailingZeros(); 1254 if (NewWidth != 7 && NewWidth != 15 && NewWidth != 31) 1255 return nullptr; 1256 1257 // The width of the new add formed is 1 more than the bias. 1258 ++NewWidth; 1259 1260 // Check to see that CI1 is an all-ones value with NewWidth bits. 1261 if (CI1->getBitWidth() == NewWidth || 1262 CI1->getValue() != APInt::getLowBitsSet(CI1->getBitWidth(), NewWidth)) 1263 return nullptr; 1264 1265 // This is only really a signed overflow check if the inputs have been 1266 // sign-extended; check for that condition. For example, if CI2 is 2^31 and 1267 // the operands of the add are 64 bits wide, we need at least 33 sign bits. 1268 if (IC.ComputeMaxSignificantBits(A, 0, &I) > NewWidth || 1269 IC.ComputeMaxSignificantBits(B, 0, &I) > NewWidth) 1270 return nullptr; 1271 1272 // In order to replace the original add with a narrower 1273 // llvm.sadd.with.overflow, the only uses allowed are the add-with-constant 1274 // and truncates that discard the high bits of the add. Verify that this is 1275 // the case. 1276 Instruction *OrigAdd = cast<Instruction>(AddWithCst->getOperand(0)); 1277 for (User *U : OrigAdd->users()) { 1278 if (U == AddWithCst) 1279 continue; 1280 1281 // Only accept truncates for now. We would really like a nice recursive 1282 // predicate like SimplifyDemandedBits, but which goes downwards the use-def 1283 // chain to see which bits of a value are actually demanded. If the 1284 // original add had another add which was then immediately truncated, we 1285 // could still do the transformation. 1286 TruncInst *TI = dyn_cast<TruncInst>(U); 1287 if (!TI || TI->getType()->getPrimitiveSizeInBits() > NewWidth) 1288 return nullptr; 1289 } 1290 1291 // If the pattern matches, truncate the inputs to the narrower type and 1292 // use the sadd_with_overflow intrinsic to efficiently compute both the 1293 // result and the overflow bit. 1294 Type *NewType = IntegerType::get(OrigAdd->getContext(), NewWidth); 1295 Function *F = Intrinsic::getDeclaration( 1296 I.getModule(), Intrinsic::sadd_with_overflow, NewType); 1297 1298 InstCombiner::BuilderTy &Builder = IC.Builder; 1299 1300 // Put the new code above the original add, in case there are any uses of the 1301 // add between the add and the compare. 1302 Builder.SetInsertPoint(OrigAdd); 1303 1304 Value *TruncA = Builder.CreateTrunc(A, NewType, A->getName() + ".trunc"); 1305 Value *TruncB = Builder.CreateTrunc(B, NewType, B->getName() + ".trunc"); 1306 CallInst *Call = Builder.CreateCall(F, {TruncA, TruncB}, "sadd"); 1307 Value *Add = Builder.CreateExtractValue(Call, 0, "sadd.result"); 1308 Value *ZExt = Builder.CreateZExt(Add, OrigAdd->getType()); 1309 1310 // The inner add was the result of the narrow add, zero extended to the 1311 // wider type. Replace it with the result computed by the intrinsic. 1312 IC.replaceInstUsesWith(*OrigAdd, ZExt); 1313 IC.eraseInstFromFunction(*OrigAdd); 1314 1315 // The original icmp gets replaced with the overflow value. 1316 return ExtractValueInst::Create(Call, 1, "sadd.overflow"); 1317 } 1318 1319 /// If we have: 1320 /// icmp eq/ne (urem/srem %x, %y), 0 1321 /// iff %y is a power-of-two, we can replace this with a bit test: 1322 /// icmp eq/ne (and %x, (add %y, -1)), 0 1323 Instruction *InstCombinerImpl::foldIRemByPowerOfTwoToBitTest(ICmpInst &I) { 1324 // This fold is only valid for equality predicates. 1325 if (!I.isEquality()) 1326 return nullptr; 1327 ICmpInst::Predicate Pred; 1328 Value *X, *Y, *Zero; 1329 if (!match(&I, m_ICmp(Pred, m_OneUse(m_IRem(m_Value(X), m_Value(Y))), 1330 m_CombineAnd(m_Zero(), m_Value(Zero))))) 1331 return nullptr; 1332 if (!isKnownToBeAPowerOfTwo(Y, /*OrZero*/ true, 0, &I)) 1333 return nullptr; 1334 // This may increase instruction count, we don't enforce that Y is a constant. 1335 Value *Mask = Builder.CreateAdd(Y, Constant::getAllOnesValue(Y->getType())); 1336 Value *Masked = Builder.CreateAnd(X, Mask); 1337 return ICmpInst::Create(Instruction::ICmp, Pred, Masked, Zero); 1338 } 1339 1340 /// Fold equality-comparison between zero and any (maybe truncated) right-shift 1341 /// by one-less-than-bitwidth into a sign test on the original value. 1342 Instruction *InstCombinerImpl::foldSignBitTest(ICmpInst &I) { 1343 Instruction *Val; 1344 ICmpInst::Predicate Pred; 1345 if (!I.isEquality() || !match(&I, m_ICmp(Pred, m_Instruction(Val), m_Zero()))) 1346 return nullptr; 1347 1348 Value *X; 1349 Type *XTy; 1350 1351 Constant *C; 1352 if (match(Val, m_TruncOrSelf(m_Shr(m_Value(X), m_Constant(C))))) { 1353 XTy = X->getType(); 1354 unsigned XBitWidth = XTy->getScalarSizeInBits(); 1355 if (!match(C, m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_EQ, 1356 APInt(XBitWidth, XBitWidth - 1)))) 1357 return nullptr; 1358 } else if (isa<BinaryOperator>(Val) && 1359 (X = reassociateShiftAmtsOfTwoSameDirectionShifts( 1360 cast<BinaryOperator>(Val), SQ.getWithInstruction(Val), 1361 /*AnalyzeForSignBitExtraction=*/true))) { 1362 XTy = X->getType(); 1363 } else 1364 return nullptr; 1365 1366 return ICmpInst::Create(Instruction::ICmp, 1367 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_SGE 1368 : ICmpInst::ICMP_SLT, 1369 X, ConstantInt::getNullValue(XTy)); 1370 } 1371 1372 // Handle icmp pred X, 0 1373 Instruction *InstCombinerImpl::foldICmpWithZero(ICmpInst &Cmp) { 1374 CmpInst::Predicate Pred = Cmp.getPredicate(); 1375 if (!match(Cmp.getOperand(1), m_Zero())) 1376 return nullptr; 1377 1378 // (icmp sgt smin(PosA, B) 0) -> (icmp sgt B 0) 1379 if (Pred == ICmpInst::ICMP_SGT) { 1380 Value *A, *B; 1381 if (match(Cmp.getOperand(0), m_SMin(m_Value(A), m_Value(B)))) { 1382 if (isKnownPositive(A, DL, 0, &AC, &Cmp, &DT)) 1383 return new ICmpInst(Pred, B, Cmp.getOperand(1)); 1384 if (isKnownPositive(B, DL, 0, &AC, &Cmp, &DT)) 1385 return new ICmpInst(Pred, A, Cmp.getOperand(1)); 1386 } 1387 } 1388 1389 if (Instruction *New = foldIRemByPowerOfTwoToBitTest(Cmp)) 1390 return New; 1391 1392 // Given: 1393 // icmp eq/ne (urem %x, %y), 0 1394 // Iff %x has 0 or 1 bits set, and %y has at least 2 bits set, omit 'urem': 1395 // icmp eq/ne %x, 0 1396 Value *X, *Y; 1397 if (match(Cmp.getOperand(0), m_URem(m_Value(X), m_Value(Y))) && 1398 ICmpInst::isEquality(Pred)) { 1399 KnownBits XKnown = computeKnownBits(X, 0, &Cmp); 1400 KnownBits YKnown = computeKnownBits(Y, 0, &Cmp); 1401 if (XKnown.countMaxPopulation() == 1 && YKnown.countMinPopulation() >= 2) 1402 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 1403 } 1404 1405 return nullptr; 1406 } 1407 1408 /// Fold icmp Pred X, C. 1409 /// TODO: This code structure does not make sense. The saturating add fold 1410 /// should be moved to some other helper and extended as noted below (it is also 1411 /// possible that code has been made unnecessary - do we canonicalize IR to 1412 /// overflow/saturating intrinsics or not?). 1413 Instruction *InstCombinerImpl::foldICmpWithConstant(ICmpInst &Cmp) { 1414 // Match the following pattern, which is a common idiom when writing 1415 // overflow-safe integer arithmetic functions. The source performs an addition 1416 // in wider type and explicitly checks for overflow using comparisons against 1417 // INT_MIN and INT_MAX. Simplify by using the sadd_with_overflow intrinsic. 1418 // 1419 // TODO: This could probably be generalized to handle other overflow-safe 1420 // operations if we worked out the formulas to compute the appropriate magic 1421 // constants. 1422 // 1423 // sum = a + b 1424 // if (sum+128 >u 255) ... -> llvm.sadd.with.overflow.i8 1425 CmpInst::Predicate Pred = Cmp.getPredicate(); 1426 Value *Op0 = Cmp.getOperand(0), *Op1 = Cmp.getOperand(1); 1427 Value *A, *B; 1428 ConstantInt *CI, *CI2; // I = icmp ugt (add (add A, B), CI2), CI 1429 if (Pred == ICmpInst::ICMP_UGT && match(Op1, m_ConstantInt(CI)) && 1430 match(Op0, m_Add(m_Add(m_Value(A), m_Value(B)), m_ConstantInt(CI2)))) 1431 if (Instruction *Res = processUGT_ADDCST_ADD(Cmp, A, B, CI2, CI, *this)) 1432 return Res; 1433 1434 // icmp(phi(C1, C2, ...), C) -> phi(icmp(C1, C), icmp(C2, C), ...). 1435 Constant *C = dyn_cast<Constant>(Op1); 1436 if (!C || C->canTrap()) 1437 return nullptr; 1438 1439 if (auto *Phi = dyn_cast<PHINode>(Op0)) 1440 if (all_of(Phi->operands(), [](Value *V) { return isa<Constant>(V); })) { 1441 Type *Ty = Cmp.getType(); 1442 Builder.SetInsertPoint(Phi); 1443 PHINode *NewPhi = 1444 Builder.CreatePHI(Ty, Phi->getNumOperands()); 1445 for (BasicBlock *Predecessor : predecessors(Phi->getParent())) { 1446 auto *Input = 1447 cast<Constant>(Phi->getIncomingValueForBlock(Predecessor)); 1448 auto *BoolInput = ConstantExpr::getCompare(Pred, Input, C); 1449 NewPhi->addIncoming(BoolInput, Predecessor); 1450 } 1451 NewPhi->takeName(&Cmp); 1452 return replaceInstUsesWith(Cmp, NewPhi); 1453 } 1454 1455 return nullptr; 1456 } 1457 1458 /// Canonicalize icmp instructions based on dominating conditions. 1459 Instruction *InstCombinerImpl::foldICmpWithDominatingICmp(ICmpInst &Cmp) { 1460 // This is a cheap/incomplete check for dominance - just match a single 1461 // predecessor with a conditional branch. 1462 BasicBlock *CmpBB = Cmp.getParent(); 1463 BasicBlock *DomBB = CmpBB->getSinglePredecessor(); 1464 if (!DomBB) 1465 return nullptr; 1466 1467 Value *DomCond; 1468 BasicBlock *TrueBB, *FalseBB; 1469 if (!match(DomBB->getTerminator(), m_Br(m_Value(DomCond), TrueBB, FalseBB))) 1470 return nullptr; 1471 1472 assert((TrueBB == CmpBB || FalseBB == CmpBB) && 1473 "Predecessor block does not point to successor?"); 1474 1475 // The branch should get simplified. Don't bother simplifying this condition. 1476 if (TrueBB == FalseBB) 1477 return nullptr; 1478 1479 // Try to simplify this compare to T/F based on the dominating condition. 1480 Optional<bool> Imp = isImpliedCondition(DomCond, &Cmp, DL, TrueBB == CmpBB); 1481 if (Imp) 1482 return replaceInstUsesWith(Cmp, ConstantInt::get(Cmp.getType(), *Imp)); 1483 1484 CmpInst::Predicate Pred = Cmp.getPredicate(); 1485 Value *X = Cmp.getOperand(0), *Y = Cmp.getOperand(1); 1486 ICmpInst::Predicate DomPred; 1487 const APInt *C, *DomC; 1488 if (match(DomCond, m_ICmp(DomPred, m_Specific(X), m_APInt(DomC))) && 1489 match(Y, m_APInt(C))) { 1490 // We have 2 compares of a variable with constants. Calculate the constant 1491 // ranges of those compares to see if we can transform the 2nd compare: 1492 // DomBB: 1493 // DomCond = icmp DomPred X, DomC 1494 // br DomCond, CmpBB, FalseBB 1495 // CmpBB: 1496 // Cmp = icmp Pred X, C 1497 ConstantRange CR = ConstantRange::makeExactICmpRegion(Pred, *C); 1498 ConstantRange DominatingCR = 1499 (CmpBB == TrueBB) ? ConstantRange::makeExactICmpRegion(DomPred, *DomC) 1500 : ConstantRange::makeExactICmpRegion( 1501 CmpInst::getInversePredicate(DomPred), *DomC); 1502 ConstantRange Intersection = DominatingCR.intersectWith(CR); 1503 ConstantRange Difference = DominatingCR.difference(CR); 1504 if (Intersection.isEmptySet()) 1505 return replaceInstUsesWith(Cmp, Builder.getFalse()); 1506 if (Difference.isEmptySet()) 1507 return replaceInstUsesWith(Cmp, Builder.getTrue()); 1508 1509 // Canonicalizing a sign bit comparison that gets used in a branch, 1510 // pessimizes codegen by generating branch on zero instruction instead 1511 // of a test and branch. So we avoid canonicalizing in such situations 1512 // because test and branch instruction has better branch displacement 1513 // than compare and branch instruction. 1514 bool UnusedBit; 1515 bool IsSignBit = isSignBitCheck(Pred, *C, UnusedBit); 1516 if (Cmp.isEquality() || (IsSignBit && hasBranchUse(Cmp))) 1517 return nullptr; 1518 1519 // Avoid an infinite loop with min/max canonicalization. 1520 // TODO: This will be unnecessary if we canonicalize to min/max intrinsics. 1521 if (Cmp.hasOneUse() && 1522 match(Cmp.user_back(), m_MaxOrMin(m_Value(), m_Value()))) 1523 return nullptr; 1524 1525 if (const APInt *EqC = Intersection.getSingleElement()) 1526 return new ICmpInst(ICmpInst::ICMP_EQ, X, Builder.getInt(*EqC)); 1527 if (const APInt *NeC = Difference.getSingleElement()) 1528 return new ICmpInst(ICmpInst::ICMP_NE, X, Builder.getInt(*NeC)); 1529 } 1530 1531 return nullptr; 1532 } 1533 1534 /// Fold icmp (trunc X, Y), C. 1535 Instruction *InstCombinerImpl::foldICmpTruncConstant(ICmpInst &Cmp, 1536 TruncInst *Trunc, 1537 const APInt &C) { 1538 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1539 Value *X = Trunc->getOperand(0); 1540 if (C.isOne() && C.getBitWidth() > 1) { 1541 // icmp slt trunc(signum(V)) 1 --> icmp slt V, 1 1542 Value *V = nullptr; 1543 if (Pred == ICmpInst::ICMP_SLT && match(X, m_Signum(m_Value(V)))) 1544 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1545 ConstantInt::get(V->getType(), 1)); 1546 } 1547 1548 unsigned DstBits = Trunc->getType()->getScalarSizeInBits(), 1549 SrcBits = X->getType()->getScalarSizeInBits(); 1550 if (Cmp.isEquality() && Trunc->hasOneUse()) { 1551 // Simplify icmp eq (trunc x to i8), 42 -> icmp eq x, 42|highbits if all 1552 // of the high bits truncated out of x are known. 1553 KnownBits Known = computeKnownBits(X, 0, &Cmp); 1554 1555 // If all the high bits are known, we can do this xform. 1556 if ((Known.Zero | Known.One).countLeadingOnes() >= SrcBits - DstBits) { 1557 // Pull in the high bits from known-ones set. 1558 APInt NewRHS = C.zext(SrcBits); 1559 NewRHS |= Known.One & APInt::getHighBitsSet(SrcBits, SrcBits - DstBits); 1560 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), NewRHS)); 1561 } 1562 } 1563 1564 // Look through truncated right-shift of the sign-bit for a sign-bit check: 1565 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] < 0 --> ShOp < 0 1566 // trunc iN (ShOp >> ShAmtC) to i[N - ShAmtC] > -1 --> ShOp > -1 1567 Value *ShOp; 1568 const APInt *ShAmtC; 1569 bool TrueIfSigned; 1570 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1571 match(X, m_Shr(m_Value(ShOp), m_APInt(ShAmtC))) && 1572 DstBits == SrcBits - ShAmtC->getZExtValue()) { 1573 return TrueIfSigned 1574 ? new ICmpInst(ICmpInst::ICMP_SLT, ShOp, 1575 ConstantInt::getNullValue(X->getType())) 1576 : new ICmpInst(ICmpInst::ICMP_SGT, ShOp, 1577 ConstantInt::getAllOnesValue(X->getType())); 1578 } 1579 1580 return nullptr; 1581 } 1582 1583 /// Fold icmp (xor X, Y), C. 1584 Instruction *InstCombinerImpl::foldICmpXorConstant(ICmpInst &Cmp, 1585 BinaryOperator *Xor, 1586 const APInt &C) { 1587 Value *X = Xor->getOperand(0); 1588 Value *Y = Xor->getOperand(1); 1589 const APInt *XorC; 1590 if (!match(Y, m_APInt(XorC))) 1591 return nullptr; 1592 1593 // If this is a comparison that tests the signbit (X < 0) or (x > -1), 1594 // fold the xor. 1595 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1596 bool TrueIfSigned = false; 1597 if (isSignBitCheck(Cmp.getPredicate(), C, TrueIfSigned)) { 1598 1599 // If the sign bit of the XorCst is not set, there is no change to 1600 // the operation, just stop using the Xor. 1601 if (!XorC->isNegative()) 1602 return replaceOperand(Cmp, 0, X); 1603 1604 // Emit the opposite comparison. 1605 if (TrueIfSigned) 1606 return new ICmpInst(ICmpInst::ICMP_SGT, X, 1607 ConstantInt::getAllOnesValue(X->getType())); 1608 else 1609 return new ICmpInst(ICmpInst::ICMP_SLT, X, 1610 ConstantInt::getNullValue(X->getType())); 1611 } 1612 1613 if (Xor->hasOneUse()) { 1614 // (icmp u/s (xor X SignMask), C) -> (icmp s/u X, (xor C SignMask)) 1615 if (!Cmp.isEquality() && XorC->isSignMask()) { 1616 Pred = Cmp.getFlippedSignednessPredicate(); 1617 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1618 } 1619 1620 // (icmp u/s (xor X ~SignMask), C) -> (icmp s/u X, (xor C ~SignMask)) 1621 if (!Cmp.isEquality() && XorC->isMaxSignedValue()) { 1622 Pred = Cmp.getFlippedSignednessPredicate(); 1623 Pred = Cmp.getSwappedPredicate(Pred); 1624 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), C ^ *XorC)); 1625 } 1626 } 1627 1628 // Mask constant magic can eliminate an 'xor' with unsigned compares. 1629 if (Pred == ICmpInst::ICMP_UGT) { 1630 // (xor X, ~C) >u C --> X <u ~C (when C+1 is a power of 2) 1631 if (*XorC == ~C && (C + 1).isPowerOf2()) 1632 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 1633 // (xor X, C) >u C --> X >u C (when C+1 is a power of 2) 1634 if (*XorC == C && (C + 1).isPowerOf2()) 1635 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 1636 } 1637 if (Pred == ICmpInst::ICMP_ULT) { 1638 // (xor X, -C) <u C --> X >u ~C (when C is a power of 2) 1639 if (*XorC == -C && C.isPowerOf2()) 1640 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1641 ConstantInt::get(X->getType(), ~C)); 1642 // (xor X, C) <u C --> X >u ~C (when -C is a power of 2) 1643 if (*XorC == C && (-C).isPowerOf2()) 1644 return new ICmpInst(ICmpInst::ICMP_UGT, X, 1645 ConstantInt::get(X->getType(), ~C)); 1646 } 1647 return nullptr; 1648 } 1649 1650 /// Fold icmp (and (sh X, Y), C2), C1. 1651 Instruction *InstCombinerImpl::foldICmpAndShift(ICmpInst &Cmp, 1652 BinaryOperator *And, 1653 const APInt &C1, 1654 const APInt &C2) { 1655 BinaryOperator *Shift = dyn_cast<BinaryOperator>(And->getOperand(0)); 1656 if (!Shift || !Shift->isShift()) 1657 return nullptr; 1658 1659 // If this is: (X >> C3) & C2 != C1 (where any shift and any compare could 1660 // exist), turn it into (X & (C2 << C3)) != (C1 << C3). This happens a LOT in 1661 // code produced by the clang front-end, for bitfield access. 1662 // This seemingly simple opportunity to fold away a shift turns out to be 1663 // rather complicated. See PR17827 for details. 1664 unsigned ShiftOpcode = Shift->getOpcode(); 1665 bool IsShl = ShiftOpcode == Instruction::Shl; 1666 const APInt *C3; 1667 if (match(Shift->getOperand(1), m_APInt(C3))) { 1668 APInt NewAndCst, NewCmpCst; 1669 bool AnyCmpCstBitsShiftedOut; 1670 if (ShiftOpcode == Instruction::Shl) { 1671 // For a left shift, we can fold if the comparison is not signed. We can 1672 // also fold a signed comparison if the mask value and comparison value 1673 // are not negative. These constraints may not be obvious, but we can 1674 // prove that they are correct using an SMT solver. 1675 if (Cmp.isSigned() && (C2.isNegative() || C1.isNegative())) 1676 return nullptr; 1677 1678 NewCmpCst = C1.lshr(*C3); 1679 NewAndCst = C2.lshr(*C3); 1680 AnyCmpCstBitsShiftedOut = NewCmpCst.shl(*C3) != C1; 1681 } else if (ShiftOpcode == Instruction::LShr) { 1682 // For a logical right shift, we can fold if the comparison is not signed. 1683 // We can also fold a signed comparison if the shifted mask value and the 1684 // shifted comparison value are not negative. These constraints may not be 1685 // obvious, but we can prove that they are correct using an SMT solver. 1686 NewCmpCst = C1.shl(*C3); 1687 NewAndCst = C2.shl(*C3); 1688 AnyCmpCstBitsShiftedOut = NewCmpCst.lshr(*C3) != C1; 1689 if (Cmp.isSigned() && (NewAndCst.isNegative() || NewCmpCst.isNegative())) 1690 return nullptr; 1691 } else { 1692 // For an arithmetic shift, check that both constants don't use (in a 1693 // signed sense) the top bits being shifted out. 1694 assert(ShiftOpcode == Instruction::AShr && "Unknown shift opcode"); 1695 NewCmpCst = C1.shl(*C3); 1696 NewAndCst = C2.shl(*C3); 1697 AnyCmpCstBitsShiftedOut = NewCmpCst.ashr(*C3) != C1; 1698 if (NewAndCst.ashr(*C3) != C2) 1699 return nullptr; 1700 } 1701 1702 if (AnyCmpCstBitsShiftedOut) { 1703 // If we shifted bits out, the fold is not going to work out. As a 1704 // special case, check to see if this means that the result is always 1705 // true or false now. 1706 if (Cmp.getPredicate() == ICmpInst::ICMP_EQ) 1707 return replaceInstUsesWith(Cmp, ConstantInt::getFalse(Cmp.getType())); 1708 if (Cmp.getPredicate() == ICmpInst::ICMP_NE) 1709 return replaceInstUsesWith(Cmp, ConstantInt::getTrue(Cmp.getType())); 1710 } else { 1711 Value *NewAnd = Builder.CreateAnd( 1712 Shift->getOperand(0), ConstantInt::get(And->getType(), NewAndCst)); 1713 return new ICmpInst(Cmp.getPredicate(), 1714 NewAnd, ConstantInt::get(And->getType(), NewCmpCst)); 1715 } 1716 } 1717 1718 // Turn ((X >> Y) & C2) == 0 into (X & (C2 << Y)) == 0. The latter is 1719 // preferable because it allows the C2 << Y expression to be hoisted out of a 1720 // loop if Y is invariant and X is not. 1721 if (Shift->hasOneUse() && C1.isZero() && Cmp.isEquality() && 1722 !Shift->isArithmeticShift() && !isa<Constant>(Shift->getOperand(0))) { 1723 // Compute C2 << Y. 1724 Value *NewShift = 1725 IsShl ? Builder.CreateLShr(And->getOperand(1), Shift->getOperand(1)) 1726 : Builder.CreateShl(And->getOperand(1), Shift->getOperand(1)); 1727 1728 // Compute X & (C2 << Y). 1729 Value *NewAnd = Builder.CreateAnd(Shift->getOperand(0), NewShift); 1730 return replaceOperand(Cmp, 0, NewAnd); 1731 } 1732 1733 return nullptr; 1734 } 1735 1736 /// Fold icmp (and X, C2), C1. 1737 Instruction *InstCombinerImpl::foldICmpAndConstConst(ICmpInst &Cmp, 1738 BinaryOperator *And, 1739 const APInt &C1) { 1740 bool isICMP_NE = Cmp.getPredicate() == ICmpInst::ICMP_NE; 1741 1742 // For vectors: icmp ne (and X, 1), 0 --> trunc X to N x i1 1743 // TODO: We canonicalize to the longer form for scalars because we have 1744 // better analysis/folds for icmp, and codegen may be better with icmp. 1745 if (isICMP_NE && Cmp.getType()->isVectorTy() && C1.isZero() && 1746 match(And->getOperand(1), m_One())) 1747 return new TruncInst(And->getOperand(0), Cmp.getType()); 1748 1749 const APInt *C2; 1750 Value *X; 1751 if (!match(And, m_And(m_Value(X), m_APInt(C2)))) 1752 return nullptr; 1753 1754 // Don't perform the following transforms if the AND has multiple uses 1755 if (!And->hasOneUse()) 1756 return nullptr; 1757 1758 if (Cmp.isEquality() && C1.isZero()) { 1759 // Restrict this fold to single-use 'and' (PR10267). 1760 // Replace (and X, (1 << size(X)-1) != 0) with X s< 0 1761 if (C2->isSignMask()) { 1762 Constant *Zero = Constant::getNullValue(X->getType()); 1763 auto NewPred = isICMP_NE ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGE; 1764 return new ICmpInst(NewPred, X, Zero); 1765 } 1766 1767 // Restrict this fold only for single-use 'and' (PR10267). 1768 // ((%x & C) == 0) --> %x u< (-C) iff (-C) is power of two. 1769 if ((~(*C2) + 1).isPowerOf2()) { 1770 Constant *NegBOC = 1771 ConstantExpr::getNeg(cast<Constant>(And->getOperand(1))); 1772 auto NewPred = isICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 1773 return new ICmpInst(NewPred, X, NegBOC); 1774 } 1775 } 1776 1777 // If the LHS is an 'and' of a truncate and we can widen the and/compare to 1778 // the input width without changing the value produced, eliminate the cast: 1779 // 1780 // icmp (and (trunc W), C2), C1 -> icmp (and W, C2'), C1' 1781 // 1782 // We can do this transformation if the constants do not have their sign bits 1783 // set or if it is an equality comparison. Extending a relational comparison 1784 // when we're checking the sign bit would not work. 1785 Value *W; 1786 if (match(And->getOperand(0), m_OneUse(m_Trunc(m_Value(W)))) && 1787 (Cmp.isEquality() || (!C1.isNegative() && !C2->isNegative()))) { 1788 // TODO: Is this a good transform for vectors? Wider types may reduce 1789 // throughput. Should this transform be limited (even for scalars) by using 1790 // shouldChangeType()? 1791 if (!Cmp.getType()->isVectorTy()) { 1792 Type *WideType = W->getType(); 1793 unsigned WideScalarBits = WideType->getScalarSizeInBits(); 1794 Constant *ZextC1 = ConstantInt::get(WideType, C1.zext(WideScalarBits)); 1795 Constant *ZextC2 = ConstantInt::get(WideType, C2->zext(WideScalarBits)); 1796 Value *NewAnd = Builder.CreateAnd(W, ZextC2, And->getName()); 1797 return new ICmpInst(Cmp.getPredicate(), NewAnd, ZextC1); 1798 } 1799 } 1800 1801 if (Instruction *I = foldICmpAndShift(Cmp, And, C1, *C2)) 1802 return I; 1803 1804 // (icmp pred (and (or (lshr A, B), A), 1), 0) --> 1805 // (icmp pred (and A, (or (shl 1, B), 1), 0)) 1806 // 1807 // iff pred isn't signed 1808 if (!Cmp.isSigned() && C1.isZero() && And->getOperand(0)->hasOneUse() && 1809 match(And->getOperand(1), m_One())) { 1810 Constant *One = cast<Constant>(And->getOperand(1)); 1811 Value *Or = And->getOperand(0); 1812 Value *A, *B, *LShr; 1813 if (match(Or, m_Or(m_Value(LShr), m_Value(A))) && 1814 match(LShr, m_LShr(m_Specific(A), m_Value(B)))) { 1815 unsigned UsesRemoved = 0; 1816 if (And->hasOneUse()) 1817 ++UsesRemoved; 1818 if (Or->hasOneUse()) 1819 ++UsesRemoved; 1820 if (LShr->hasOneUse()) 1821 ++UsesRemoved; 1822 1823 // Compute A & ((1 << B) | 1) 1824 Value *NewOr = nullptr; 1825 if (auto *C = dyn_cast<Constant>(B)) { 1826 if (UsesRemoved >= 1) 1827 NewOr = ConstantExpr::getOr(ConstantExpr::getNUWShl(One, C), One); 1828 } else { 1829 if (UsesRemoved >= 3) 1830 NewOr = Builder.CreateOr(Builder.CreateShl(One, B, LShr->getName(), 1831 /*HasNUW=*/true), 1832 One, Or->getName()); 1833 } 1834 if (NewOr) { 1835 Value *NewAnd = Builder.CreateAnd(A, NewOr, And->getName()); 1836 return replaceOperand(Cmp, 0, NewAnd); 1837 } 1838 } 1839 } 1840 1841 return nullptr; 1842 } 1843 1844 /// Fold icmp (and X, Y), C. 1845 Instruction *InstCombinerImpl::foldICmpAndConstant(ICmpInst &Cmp, 1846 BinaryOperator *And, 1847 const APInt &C) { 1848 if (Instruction *I = foldICmpAndConstConst(Cmp, And, C)) 1849 return I; 1850 1851 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 1852 bool TrueIfNeg; 1853 if (isSignBitCheck(Pred, C, TrueIfNeg)) { 1854 // ((X - 1) & ~X) < 0 --> X == 0 1855 // ((X - 1) & ~X) >= 0 --> X != 0 1856 Value *X; 1857 if (match(And->getOperand(0), m_Add(m_Value(X), m_AllOnes())) && 1858 match(And->getOperand(1), m_Not(m_Specific(X)))) { 1859 auto NewPred = TrueIfNeg ? CmpInst::ICMP_EQ : CmpInst::ICMP_NE; 1860 return new ICmpInst(NewPred, X, ConstantInt::getNullValue(X->getType())); 1861 } 1862 } 1863 1864 // TODO: These all require that Y is constant too, so refactor with the above. 1865 1866 // Try to optimize things like "A[i] & 42 == 0" to index computations. 1867 Value *X = And->getOperand(0); 1868 Value *Y = And->getOperand(1); 1869 if (auto *C2 = dyn_cast<ConstantInt>(Y)) 1870 if (auto *LI = dyn_cast<LoadInst>(X)) 1871 if (auto *GEP = dyn_cast<GetElementPtrInst>(LI->getOperand(0))) 1872 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 1873 if (Instruction *Res = 1874 foldCmpLoadFromIndexedGlobal(LI, GEP, GV, Cmp, C2)) 1875 return Res; 1876 1877 if (!Cmp.isEquality()) 1878 return nullptr; 1879 1880 // X & -C == -C -> X > u ~C 1881 // X & -C != -C -> X <= u ~C 1882 // iff C is a power of 2 1883 if (Cmp.getOperand(1) == Y && C.isNegatedPowerOf2()) { 1884 auto NewPred = 1885 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGT : CmpInst::ICMP_ULE; 1886 return new ICmpInst(NewPred, X, SubOne(cast<Constant>(Cmp.getOperand(1)))); 1887 } 1888 1889 return nullptr; 1890 } 1891 1892 /// Fold icmp (or X, Y), C. 1893 Instruction *InstCombinerImpl::foldICmpOrConstant(ICmpInst &Cmp, 1894 BinaryOperator *Or, 1895 const APInt &C) { 1896 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1897 if (C.isOne()) { 1898 // icmp slt signum(V) 1 --> icmp slt V, 1 1899 Value *V = nullptr; 1900 if (Pred == ICmpInst::ICMP_SLT && match(Or, m_Signum(m_Value(V)))) 1901 return new ICmpInst(ICmpInst::ICMP_SLT, V, 1902 ConstantInt::get(V->getType(), 1)); 1903 } 1904 1905 Value *OrOp0 = Or->getOperand(0), *OrOp1 = Or->getOperand(1); 1906 const APInt *MaskC; 1907 if (match(OrOp1, m_APInt(MaskC)) && Cmp.isEquality()) { 1908 if (*MaskC == C && (C + 1).isPowerOf2()) { 1909 // X | C == C --> X <=u C 1910 // X | C != C --> X >u C 1911 // iff C+1 is a power of 2 (C is a bitmask of the low bits) 1912 Pred = (Pred == CmpInst::ICMP_EQ) ? CmpInst::ICMP_ULE : CmpInst::ICMP_UGT; 1913 return new ICmpInst(Pred, OrOp0, OrOp1); 1914 } 1915 1916 // More general: canonicalize 'equality with set bits mask' to 1917 // 'equality with clear bits mask'. 1918 // (X | MaskC) == C --> (X & ~MaskC) == C ^ MaskC 1919 // (X | MaskC) != C --> (X & ~MaskC) != C ^ MaskC 1920 if (Or->hasOneUse()) { 1921 Value *And = Builder.CreateAnd(OrOp0, ~(*MaskC)); 1922 Constant *NewC = ConstantInt::get(Or->getType(), C ^ (*MaskC)); 1923 return new ICmpInst(Pred, And, NewC); 1924 } 1925 } 1926 1927 // (X | (X-1)) s< 0 --> X s< 1 1928 // (X | (X-1)) s> -1 --> X s> 0 1929 Value *X; 1930 bool TrueIfSigned; 1931 if (isSignBitCheck(Pred, C, TrueIfSigned) && 1932 match(Or, m_c_Or(m_Add(m_Value(X), m_AllOnes()), m_Deferred(X)))) { 1933 auto NewPred = TrueIfSigned ? ICmpInst::ICMP_SLT : ICmpInst::ICMP_SGT; 1934 Constant *NewC = ConstantInt::get(X->getType(), TrueIfSigned ? 1 : 0); 1935 return new ICmpInst(NewPred, X, NewC); 1936 } 1937 1938 if (!Cmp.isEquality() || !C.isZero() || !Or->hasOneUse()) 1939 return nullptr; 1940 1941 Value *P, *Q; 1942 if (match(Or, m_Or(m_PtrToInt(m_Value(P)), m_PtrToInt(m_Value(Q))))) { 1943 // Simplify icmp eq (or (ptrtoint P), (ptrtoint Q)), 0 1944 // -> and (icmp eq P, null), (icmp eq Q, null). 1945 Value *CmpP = 1946 Builder.CreateICmp(Pred, P, ConstantInt::getNullValue(P->getType())); 1947 Value *CmpQ = 1948 Builder.CreateICmp(Pred, Q, ConstantInt::getNullValue(Q->getType())); 1949 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1950 return BinaryOperator::Create(BOpc, CmpP, CmpQ); 1951 } 1952 1953 // Are we using xors to bitwise check for a pair of (in)equalities? Convert to 1954 // a shorter form that has more potential to be folded even further. 1955 Value *X1, *X2, *X3, *X4; 1956 if (match(OrOp0, m_OneUse(m_Xor(m_Value(X1), m_Value(X2)))) && 1957 match(OrOp1, m_OneUse(m_Xor(m_Value(X3), m_Value(X4))))) { 1958 // ((X1 ^ X2) || (X3 ^ X4)) == 0 --> (X1 == X2) && (X3 == X4) 1959 // ((X1 ^ X2) || (X3 ^ X4)) != 0 --> (X1 != X2) || (X3 != X4) 1960 Value *Cmp12 = Builder.CreateICmp(Pred, X1, X2); 1961 Value *Cmp34 = Builder.CreateICmp(Pred, X3, X4); 1962 auto BOpc = Pred == CmpInst::ICMP_EQ ? Instruction::And : Instruction::Or; 1963 return BinaryOperator::Create(BOpc, Cmp12, Cmp34); 1964 } 1965 1966 return nullptr; 1967 } 1968 1969 /// Fold icmp (mul X, Y), C. 1970 Instruction *InstCombinerImpl::foldICmpMulConstant(ICmpInst &Cmp, 1971 BinaryOperator *Mul, 1972 const APInt &C) { 1973 const APInt *MulC; 1974 if (!match(Mul->getOperand(1), m_APInt(MulC))) 1975 return nullptr; 1976 1977 // If this is a test of the sign bit and the multiply is sign-preserving with 1978 // a constant operand, use the multiply LHS operand instead. 1979 ICmpInst::Predicate Pred = Cmp.getPredicate(); 1980 if (isSignTest(Pred, C) && Mul->hasNoSignedWrap()) { 1981 if (MulC->isNegative()) 1982 Pred = ICmpInst::getSwappedPredicate(Pred); 1983 return new ICmpInst(Pred, Mul->getOperand(0), 1984 Constant::getNullValue(Mul->getType())); 1985 } 1986 1987 // If the multiply does not wrap, try to divide the compare constant by the 1988 // multiplication factor. 1989 if (Cmp.isEquality() && !MulC->isZero()) { 1990 // (mul nsw X, MulC) == C --> X == C /s MulC 1991 if (Mul->hasNoSignedWrap() && C.srem(*MulC).isZero()) { 1992 Constant *NewC = ConstantInt::get(Mul->getType(), C.sdiv(*MulC)); 1993 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 1994 } 1995 // (mul nuw X, MulC) == C --> X == C /u MulC 1996 if (Mul->hasNoUnsignedWrap() && C.urem(*MulC).isZero()) { 1997 Constant *NewC = ConstantInt::get(Mul->getType(), C.udiv(*MulC)); 1998 return new ICmpInst(Pred, Mul->getOperand(0), NewC); 1999 } 2000 } 2001 2002 return nullptr; 2003 } 2004 2005 /// Fold icmp (shl 1, Y), C. 2006 static Instruction *foldICmpShlOne(ICmpInst &Cmp, Instruction *Shl, 2007 const APInt &C) { 2008 Value *Y; 2009 if (!match(Shl, m_Shl(m_One(), m_Value(Y)))) 2010 return nullptr; 2011 2012 Type *ShiftType = Shl->getType(); 2013 unsigned TypeBits = C.getBitWidth(); 2014 bool CIsPowerOf2 = C.isPowerOf2(); 2015 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2016 if (Cmp.isUnsigned()) { 2017 // (1 << Y) pred C -> Y pred Log2(C) 2018 if (!CIsPowerOf2) { 2019 // (1 << Y) < 30 -> Y <= 4 2020 // (1 << Y) <= 30 -> Y <= 4 2021 // (1 << Y) >= 30 -> Y > 4 2022 // (1 << Y) > 30 -> Y > 4 2023 if (Pred == ICmpInst::ICMP_ULT) 2024 Pred = ICmpInst::ICMP_ULE; 2025 else if (Pred == ICmpInst::ICMP_UGE) 2026 Pred = ICmpInst::ICMP_UGT; 2027 } 2028 2029 // (1 << Y) >= 2147483648 -> Y >= 31 -> Y == 31 2030 // (1 << Y) < 2147483648 -> Y < 31 -> Y != 31 2031 unsigned CLog2 = C.logBase2(); 2032 if (CLog2 == TypeBits - 1) { 2033 if (Pred == ICmpInst::ICMP_UGE) 2034 Pred = ICmpInst::ICMP_EQ; 2035 else if (Pred == ICmpInst::ICMP_ULT) 2036 Pred = ICmpInst::ICMP_NE; 2037 } 2038 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, CLog2)); 2039 } else if (Cmp.isSigned()) { 2040 Constant *BitWidthMinusOne = ConstantInt::get(ShiftType, TypeBits - 1); 2041 if (C.isAllOnes()) { 2042 // (1 << Y) <= -1 -> Y == 31 2043 if (Pred == ICmpInst::ICMP_SLE) 2044 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2045 2046 // (1 << Y) > -1 -> Y != 31 2047 if (Pred == ICmpInst::ICMP_SGT) 2048 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2049 } else if (!C) { 2050 // (1 << Y) < 0 -> Y == 31 2051 // (1 << Y) <= 0 -> Y == 31 2052 if (Pred == ICmpInst::ICMP_SLT || Pred == ICmpInst::ICMP_SLE) 2053 return new ICmpInst(ICmpInst::ICMP_EQ, Y, BitWidthMinusOne); 2054 2055 // (1 << Y) >= 0 -> Y != 31 2056 // (1 << Y) > 0 -> Y != 31 2057 if (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SGE) 2058 return new ICmpInst(ICmpInst::ICMP_NE, Y, BitWidthMinusOne); 2059 } 2060 } else if (Cmp.isEquality() && CIsPowerOf2) { 2061 return new ICmpInst(Pred, Y, ConstantInt::get(ShiftType, C.logBase2())); 2062 } 2063 2064 return nullptr; 2065 } 2066 2067 /// Fold icmp (shl X, Y), C. 2068 Instruction *InstCombinerImpl::foldICmpShlConstant(ICmpInst &Cmp, 2069 BinaryOperator *Shl, 2070 const APInt &C) { 2071 const APInt *ShiftVal; 2072 if (Cmp.isEquality() && match(Shl->getOperand(0), m_APInt(ShiftVal))) 2073 return foldICmpShlConstConst(Cmp, Shl->getOperand(1), C, *ShiftVal); 2074 2075 const APInt *ShiftAmt; 2076 if (!match(Shl->getOperand(1), m_APInt(ShiftAmt))) 2077 return foldICmpShlOne(Cmp, Shl, C); 2078 2079 // Check that the shift amount is in range. If not, don't perform undefined 2080 // shifts. When the shift is visited, it will be simplified. 2081 unsigned TypeBits = C.getBitWidth(); 2082 if (ShiftAmt->uge(TypeBits)) 2083 return nullptr; 2084 2085 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2086 Value *X = Shl->getOperand(0); 2087 Type *ShType = Shl->getType(); 2088 2089 // NSW guarantees that we are only shifting out sign bits from the high bits, 2090 // so we can ASHR the compare constant without needing a mask and eliminate 2091 // the shift. 2092 if (Shl->hasNoSignedWrap()) { 2093 if (Pred == ICmpInst::ICMP_SGT) { 2094 // icmp Pred (shl nsw X, ShiftAmt), C --> icmp Pred X, (C >>s ShiftAmt) 2095 APInt ShiftedC = C.ashr(*ShiftAmt); 2096 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2097 } 2098 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2099 C.ashr(*ShiftAmt).shl(*ShiftAmt) == C) { 2100 APInt ShiftedC = C.ashr(*ShiftAmt); 2101 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2102 } 2103 if (Pred == ICmpInst::ICMP_SLT) { 2104 // SLE is the same as above, but SLE is canonicalized to SLT, so convert: 2105 // (X << S) <=s C is equiv to X <=s (C >> S) for all C 2106 // (X << S) <s (C + 1) is equiv to X <s (C >> S) + 1 if C <s SMAX 2107 // (X << S) <s C is equiv to X <s ((C - 1) >> S) + 1 if C >s SMIN 2108 assert(!C.isMinSignedValue() && "Unexpected icmp slt"); 2109 APInt ShiftedC = (C - 1).ashr(*ShiftAmt) + 1; 2110 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2111 } 2112 // If this is a signed comparison to 0 and the shift is sign preserving, 2113 // use the shift LHS operand instead; isSignTest may change 'Pred', so only 2114 // do that if we're sure to not continue on in this function. 2115 if (isSignTest(Pred, C)) 2116 return new ICmpInst(Pred, X, Constant::getNullValue(ShType)); 2117 } 2118 2119 // NUW guarantees that we are only shifting out zero bits from the high bits, 2120 // so we can LSHR the compare constant without needing a mask and eliminate 2121 // the shift. 2122 if (Shl->hasNoUnsignedWrap()) { 2123 if (Pred == ICmpInst::ICMP_UGT) { 2124 // icmp Pred (shl nuw X, ShiftAmt), C --> icmp Pred X, (C >>u ShiftAmt) 2125 APInt ShiftedC = C.lshr(*ShiftAmt); 2126 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2127 } 2128 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2129 C.lshr(*ShiftAmt).shl(*ShiftAmt) == C) { 2130 APInt ShiftedC = C.lshr(*ShiftAmt); 2131 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2132 } 2133 if (Pred == ICmpInst::ICMP_ULT) { 2134 // ULE is the same as above, but ULE is canonicalized to ULT, so convert: 2135 // (X << S) <=u C is equiv to X <=u (C >> S) for all C 2136 // (X << S) <u (C + 1) is equiv to X <u (C >> S) + 1 if C <u ~0u 2137 // (X << S) <u C is equiv to X <u ((C - 1) >> S) + 1 if C >u 0 2138 assert(C.ugt(0) && "ult 0 should have been eliminated"); 2139 APInt ShiftedC = (C - 1).lshr(*ShiftAmt) + 1; 2140 return new ICmpInst(Pred, X, ConstantInt::get(ShType, ShiftedC)); 2141 } 2142 } 2143 2144 if (Cmp.isEquality() && Shl->hasOneUse()) { 2145 // Strength-reduce the shift into an 'and'. 2146 Constant *Mask = ConstantInt::get( 2147 ShType, 2148 APInt::getLowBitsSet(TypeBits, TypeBits - ShiftAmt->getZExtValue())); 2149 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2150 Constant *LShrC = ConstantInt::get(ShType, C.lshr(*ShiftAmt)); 2151 return new ICmpInst(Pred, And, LShrC); 2152 } 2153 2154 // Otherwise, if this is a comparison of the sign bit, simplify to and/test. 2155 bool TrueIfSigned = false; 2156 if (Shl->hasOneUse() && isSignBitCheck(Pred, C, TrueIfSigned)) { 2157 // (X << 31) <s 0 --> (X & 1) != 0 2158 Constant *Mask = ConstantInt::get( 2159 ShType, 2160 APInt::getOneBitSet(TypeBits, TypeBits - ShiftAmt->getZExtValue() - 1)); 2161 Value *And = Builder.CreateAnd(X, Mask, Shl->getName() + ".mask"); 2162 return new ICmpInst(TrueIfSigned ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ, 2163 And, Constant::getNullValue(ShType)); 2164 } 2165 2166 // Simplify 'shl' inequality test into 'and' equality test. 2167 if (Cmp.isUnsigned() && Shl->hasOneUse()) { 2168 // (X l<< C2) u<=/u> C1 iff C1+1 is power of two -> X & (~C1 l>> C2) ==/!= 0 2169 if ((C + 1).isPowerOf2() && 2170 (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT)) { 2171 Value *And = Builder.CreateAnd(X, (~C).lshr(ShiftAmt->getZExtValue())); 2172 return new ICmpInst(Pred == ICmpInst::ICMP_ULE ? ICmpInst::ICMP_EQ 2173 : ICmpInst::ICMP_NE, 2174 And, Constant::getNullValue(ShType)); 2175 } 2176 // (X l<< C2) u</u>= C1 iff C1 is power of two -> X & (-C1 l>> C2) ==/!= 0 2177 if (C.isPowerOf2() && 2178 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 2179 Value *And = 2180 Builder.CreateAnd(X, (~(C - 1)).lshr(ShiftAmt->getZExtValue())); 2181 return new ICmpInst(Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_EQ 2182 : ICmpInst::ICMP_NE, 2183 And, Constant::getNullValue(ShType)); 2184 } 2185 } 2186 2187 // Transform (icmp pred iM (shl iM %v, N), C) 2188 // -> (icmp pred i(M-N) (trunc %v iM to i(M-N)), (trunc (C>>N)) 2189 // Transform the shl to a trunc if (trunc (C>>N)) has no loss and M-N. 2190 // This enables us to get rid of the shift in favor of a trunc that may be 2191 // free on the target. It has the additional benefit of comparing to a 2192 // smaller constant that may be more target-friendly. 2193 unsigned Amt = ShiftAmt->getLimitedValue(TypeBits - 1); 2194 if (Shl->hasOneUse() && Amt != 0 && C.countTrailingZeros() >= Amt && 2195 DL.isLegalInteger(TypeBits - Amt)) { 2196 Type *TruncTy = IntegerType::get(Cmp.getContext(), TypeBits - Amt); 2197 if (auto *ShVTy = dyn_cast<VectorType>(ShType)) 2198 TruncTy = VectorType::get(TruncTy, ShVTy->getElementCount()); 2199 Constant *NewC = 2200 ConstantInt::get(TruncTy, C.ashr(*ShiftAmt).trunc(TypeBits - Amt)); 2201 return new ICmpInst(Pred, Builder.CreateTrunc(X, TruncTy), NewC); 2202 } 2203 2204 return nullptr; 2205 } 2206 2207 /// Fold icmp ({al}shr X, Y), C. 2208 Instruction *InstCombinerImpl::foldICmpShrConstant(ICmpInst &Cmp, 2209 BinaryOperator *Shr, 2210 const APInt &C) { 2211 // An exact shr only shifts out zero bits, so: 2212 // icmp eq/ne (shr X, Y), 0 --> icmp eq/ne X, 0 2213 Value *X = Shr->getOperand(0); 2214 CmpInst::Predicate Pred = Cmp.getPredicate(); 2215 if (Cmp.isEquality() && Shr->isExact() && C.isZero()) 2216 return new ICmpInst(Pred, X, Cmp.getOperand(1)); 2217 2218 const APInt *ShiftVal; 2219 if (Cmp.isEquality() && match(Shr->getOperand(0), m_APInt(ShiftVal))) 2220 return foldICmpShrConstConst(Cmp, Shr->getOperand(1), C, *ShiftVal); 2221 2222 const APInt *ShiftAmt; 2223 if (!match(Shr->getOperand(1), m_APInt(ShiftAmt))) 2224 return nullptr; 2225 2226 // Check that the shift amount is in range. If not, don't perform undefined 2227 // shifts. When the shift is visited it will be simplified. 2228 unsigned TypeBits = C.getBitWidth(); 2229 unsigned ShAmtVal = ShiftAmt->getLimitedValue(TypeBits); 2230 if (ShAmtVal >= TypeBits || ShAmtVal == 0) 2231 return nullptr; 2232 2233 bool IsAShr = Shr->getOpcode() == Instruction::AShr; 2234 bool IsExact = Shr->isExact(); 2235 Type *ShrTy = Shr->getType(); 2236 // TODO: If we could guarantee that InstSimplify would handle all of the 2237 // constant-value-based preconditions in the folds below, then we could assert 2238 // those conditions rather than checking them. This is difficult because of 2239 // undef/poison (PR34838). 2240 if (IsAShr) { 2241 if (IsExact || Pred == CmpInst::ICMP_SLT || Pred == CmpInst::ICMP_ULT) { 2242 // When ShAmtC can be shifted losslessly: 2243 // icmp PRED (ashr exact X, ShAmtC), C --> icmp PRED X, (C << ShAmtC) 2244 // icmp slt/ult (ashr X, ShAmtC), C --> icmp slt/ult X, (C << ShAmtC) 2245 APInt ShiftedC = C.shl(ShAmtVal); 2246 if (ShiftedC.ashr(ShAmtVal) == C) 2247 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2248 } 2249 if (Pred == CmpInst::ICMP_SGT) { 2250 // icmp sgt (ashr X, ShAmtC), C --> icmp sgt X, ((C + 1) << ShAmtC) - 1 2251 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2252 if (!C.isMaxSignedValue() && !(C + 1).shl(ShAmtVal).isMinSignedValue() && 2253 (ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2254 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2255 } 2256 if (Pred == CmpInst::ICMP_UGT) { 2257 // icmp ugt (ashr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2258 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2259 if ((ShiftedC + 1).ashr(ShAmtVal) == (C + 1)) 2260 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2261 } 2262 2263 // If the compare constant has significant bits above the lowest sign-bit, 2264 // then convert an unsigned cmp to a test of the sign-bit: 2265 // (ashr X, ShiftC) u> C --> X s< 0 2266 // (ashr X, ShiftC) u< C --> X s> -1 2267 if (C.getBitWidth() > 2 && C.getNumSignBits() <= ShAmtVal) { 2268 if (Pred == CmpInst::ICMP_UGT) { 2269 return new ICmpInst(CmpInst::ICMP_SLT, X, 2270 ConstantInt::getNullValue(ShrTy)); 2271 } 2272 if (Pred == CmpInst::ICMP_ULT) { 2273 return new ICmpInst(CmpInst::ICMP_SGT, X, 2274 ConstantInt::getAllOnesValue(ShrTy)); 2275 } 2276 } 2277 } else { 2278 if (Pred == CmpInst::ICMP_ULT || (Pred == CmpInst::ICMP_UGT && IsExact)) { 2279 // icmp ult (lshr X, ShAmtC), C --> icmp ult X, (C << ShAmtC) 2280 // icmp ugt (lshr exact X, ShAmtC), C --> icmp ugt X, (C << ShAmtC) 2281 APInt ShiftedC = C.shl(ShAmtVal); 2282 if (ShiftedC.lshr(ShAmtVal) == C) 2283 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2284 } 2285 if (Pred == CmpInst::ICMP_UGT) { 2286 // icmp ugt (lshr X, ShAmtC), C --> icmp ugt X, ((C + 1) << ShAmtC) - 1 2287 APInt ShiftedC = (C + 1).shl(ShAmtVal) - 1; 2288 if ((ShiftedC + 1).lshr(ShAmtVal) == (C + 1)) 2289 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, ShiftedC)); 2290 } 2291 } 2292 2293 if (!Cmp.isEquality()) 2294 return nullptr; 2295 2296 // Handle equality comparisons of shift-by-constant. 2297 2298 // If the comparison constant changes with the shift, the comparison cannot 2299 // succeed (bits of the comparison constant cannot match the shifted value). 2300 // This should be known by InstSimplify and already be folded to true/false. 2301 assert(((IsAShr && C.shl(ShAmtVal).ashr(ShAmtVal) == C) || 2302 (!IsAShr && C.shl(ShAmtVal).lshr(ShAmtVal) == C)) && 2303 "Expected icmp+shr simplify did not occur."); 2304 2305 // If the bits shifted out are known zero, compare the unshifted value: 2306 // (X & 4) >> 1 == 2 --> (X & 4) == 4. 2307 if (Shr->isExact()) 2308 return new ICmpInst(Pred, X, ConstantInt::get(ShrTy, C << ShAmtVal)); 2309 2310 if (C.isZero()) { 2311 // == 0 is u< 1. 2312 if (Pred == CmpInst::ICMP_EQ) 2313 return new ICmpInst(CmpInst::ICMP_ULT, X, 2314 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal))); 2315 else 2316 return new ICmpInst(CmpInst::ICMP_UGT, X, 2317 ConstantInt::get(ShrTy, (C + 1).shl(ShAmtVal) - 1)); 2318 } 2319 2320 if (Shr->hasOneUse()) { 2321 // Canonicalize the shift into an 'and': 2322 // icmp eq/ne (shr X, ShAmt), C --> icmp eq/ne (and X, HiMask), (C << ShAmt) 2323 APInt Val(APInt::getHighBitsSet(TypeBits, TypeBits - ShAmtVal)); 2324 Constant *Mask = ConstantInt::get(ShrTy, Val); 2325 Value *And = Builder.CreateAnd(X, Mask, Shr->getName() + ".mask"); 2326 return new ICmpInst(Pred, And, ConstantInt::get(ShrTy, C << ShAmtVal)); 2327 } 2328 2329 return nullptr; 2330 } 2331 2332 Instruction *InstCombinerImpl::foldICmpSRemConstant(ICmpInst &Cmp, 2333 BinaryOperator *SRem, 2334 const APInt &C) { 2335 // Match an 'is positive' or 'is negative' comparison of remainder by a 2336 // constant power-of-2 value: 2337 // (X % pow2C) sgt/slt 0 2338 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 2339 if (Pred != ICmpInst::ICMP_SGT && Pred != ICmpInst::ICMP_SLT && 2340 Pred != ICmpInst::ICMP_EQ && Pred != ICmpInst::ICMP_NE) 2341 return nullptr; 2342 2343 // TODO: The one-use check is standard because we do not typically want to 2344 // create longer instruction sequences, but this might be a special-case 2345 // because srem is not good for analysis or codegen. 2346 if (!SRem->hasOneUse()) 2347 return nullptr; 2348 2349 const APInt *DivisorC; 2350 if (!match(SRem->getOperand(1), m_Power2(DivisorC))) 2351 return nullptr; 2352 2353 // For cmp_sgt/cmp_slt only zero valued C is handled. 2354 // For cmp_eq/cmp_ne only positive valued C is handled. 2355 if (((Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT) && 2356 !C.isZero()) || 2357 ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) && 2358 !C.isStrictlyPositive())) 2359 return nullptr; 2360 2361 // Mask off the sign bit and the modulo bits (low-bits). 2362 Type *Ty = SRem->getType(); 2363 APInt SignMask = APInt::getSignMask(Ty->getScalarSizeInBits()); 2364 Constant *MaskC = ConstantInt::get(Ty, SignMask | (*DivisorC - 1)); 2365 Value *And = Builder.CreateAnd(SRem->getOperand(0), MaskC); 2366 2367 if (Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_NE) 2368 return new ICmpInst(Pred, And, ConstantInt::get(Ty, C)); 2369 2370 // For 'is positive?' check that the sign-bit is clear and at least 1 masked 2371 // bit is set. Example: 2372 // (i8 X % 32) s> 0 --> (X & 159) s> 0 2373 if (Pred == ICmpInst::ICMP_SGT) 2374 return new ICmpInst(ICmpInst::ICMP_SGT, And, ConstantInt::getNullValue(Ty)); 2375 2376 // For 'is negative?' check that the sign-bit is set and at least 1 masked 2377 // bit is set. Example: 2378 // (i16 X % 4) s< 0 --> (X & 32771) u> 32768 2379 return new ICmpInst(ICmpInst::ICMP_UGT, And, ConstantInt::get(Ty, SignMask)); 2380 } 2381 2382 /// Fold icmp (udiv X, Y), C. 2383 Instruction *InstCombinerImpl::foldICmpUDivConstant(ICmpInst &Cmp, 2384 BinaryOperator *UDiv, 2385 const APInt &C) { 2386 const APInt *C2; 2387 if (!match(UDiv->getOperand(0), m_APInt(C2))) 2388 return nullptr; 2389 2390 assert(*C2 != 0 && "udiv 0, X should have been simplified already."); 2391 2392 // (icmp ugt (udiv C2, Y), C) -> (icmp ule Y, C2/(C+1)) 2393 Value *Y = UDiv->getOperand(1); 2394 if (Cmp.getPredicate() == ICmpInst::ICMP_UGT) { 2395 assert(!C.isMaxValue() && 2396 "icmp ugt X, UINT_MAX should have been simplified already."); 2397 return new ICmpInst(ICmpInst::ICMP_ULE, Y, 2398 ConstantInt::get(Y->getType(), C2->udiv(C + 1))); 2399 } 2400 2401 // (icmp ult (udiv C2, Y), C) -> (icmp ugt Y, C2/C) 2402 if (Cmp.getPredicate() == ICmpInst::ICMP_ULT) { 2403 assert(C != 0 && "icmp ult X, 0 should have been simplified already."); 2404 return new ICmpInst(ICmpInst::ICMP_UGT, Y, 2405 ConstantInt::get(Y->getType(), C2->udiv(C))); 2406 } 2407 2408 return nullptr; 2409 } 2410 2411 /// Fold icmp ({su}div X, Y), C. 2412 Instruction *InstCombinerImpl::foldICmpDivConstant(ICmpInst &Cmp, 2413 BinaryOperator *Div, 2414 const APInt &C) { 2415 // Fold: icmp pred ([us]div X, C2), C -> range test 2416 // Fold this div into the comparison, producing a range check. 2417 // Determine, based on the divide type, what the range is being 2418 // checked. If there is an overflow on the low or high side, remember 2419 // it, otherwise compute the range [low, hi) bounding the new value. 2420 // See: InsertRangeTest above for the kinds of replacements possible. 2421 const APInt *C2; 2422 if (!match(Div->getOperand(1), m_APInt(C2))) 2423 return nullptr; 2424 2425 // FIXME: If the operand types don't match the type of the divide 2426 // then don't attempt this transform. The code below doesn't have the 2427 // logic to deal with a signed divide and an unsigned compare (and 2428 // vice versa). This is because (x /s C2) <s C produces different 2429 // results than (x /s C2) <u C or (x /u C2) <s C or even 2430 // (x /u C2) <u C. Simply casting the operands and result won't 2431 // work. :( The if statement below tests that condition and bails 2432 // if it finds it. 2433 bool DivIsSigned = Div->getOpcode() == Instruction::SDiv; 2434 if (!Cmp.isEquality() && DivIsSigned != Cmp.isSigned()) 2435 return nullptr; 2436 2437 // The ProdOV computation fails on divide by 0 and divide by -1. Cases with 2438 // INT_MIN will also fail if the divisor is 1. Although folds of all these 2439 // division-by-constant cases should be present, we can not assert that they 2440 // have happened before we reach this icmp instruction. 2441 if (C2->isZero() || C2->isOne() || (DivIsSigned && C2->isAllOnes())) 2442 return nullptr; 2443 2444 // Compute Prod = C * C2. We are essentially solving an equation of 2445 // form X / C2 = C. We solve for X by multiplying C2 and C. 2446 // By solving for X, we can turn this into a range check instead of computing 2447 // a divide. 2448 APInt Prod = C * *C2; 2449 2450 // Determine if the product overflows by seeing if the product is not equal to 2451 // the divide. Make sure we do the same kind of divide as in the LHS 2452 // instruction that we're folding. 2453 bool ProdOV = (DivIsSigned ? Prod.sdiv(*C2) : Prod.udiv(*C2)) != C; 2454 2455 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2456 2457 // If the division is known to be exact, then there is no remainder from the 2458 // divide, so the covered range size is unit, otherwise it is the divisor. 2459 APInt RangeSize = Div->isExact() ? APInt(C2->getBitWidth(), 1) : *C2; 2460 2461 // Figure out the interval that is being checked. For example, a comparison 2462 // like "X /u 5 == 0" is really checking that X is in the interval [0, 5). 2463 // Compute this interval based on the constants involved and the signedness of 2464 // the compare/divide. This computes a half-open interval, keeping track of 2465 // whether either value in the interval overflows. After analysis each 2466 // overflow variable is set to 0 if it's corresponding bound variable is valid 2467 // -1 if overflowed off the bottom end, or +1 if overflowed off the top end. 2468 int LoOverflow = 0, HiOverflow = 0; 2469 APInt LoBound, HiBound; 2470 2471 if (!DivIsSigned) { // udiv 2472 // e.g. X/5 op 3 --> [15, 20) 2473 LoBound = Prod; 2474 HiOverflow = LoOverflow = ProdOV; 2475 if (!HiOverflow) { 2476 // If this is not an exact divide, then many values in the range collapse 2477 // to the same result value. 2478 HiOverflow = addWithOverflow(HiBound, LoBound, RangeSize, false); 2479 } 2480 } else if (C2->isStrictlyPositive()) { // Divisor is > 0. 2481 if (C.isZero()) { // (X / pos) op 0 2482 // Can't overflow. e.g. X/2 op 0 --> [-1, 2) 2483 LoBound = -(RangeSize - 1); 2484 HiBound = RangeSize; 2485 } else if (C.isStrictlyPositive()) { // (X / pos) op pos 2486 LoBound = Prod; // e.g. X/5 op 3 --> [15, 20) 2487 HiOverflow = LoOverflow = ProdOV; 2488 if (!HiOverflow) 2489 HiOverflow = addWithOverflow(HiBound, Prod, RangeSize, true); 2490 } else { // (X / pos) op neg 2491 // e.g. X/5 op -3 --> [-15-4, -15+1) --> [-19, -14) 2492 HiBound = Prod + 1; 2493 LoOverflow = HiOverflow = ProdOV ? -1 : 0; 2494 if (!LoOverflow) { 2495 APInt DivNeg = -RangeSize; 2496 LoOverflow = addWithOverflow(LoBound, HiBound, DivNeg, true) ? -1 : 0; 2497 } 2498 } 2499 } else if (C2->isNegative()) { // Divisor is < 0. 2500 if (Div->isExact()) 2501 RangeSize.negate(); 2502 if (C.isZero()) { // (X / neg) op 0 2503 // e.g. X/-5 op 0 --> [-4, 5) 2504 LoBound = RangeSize + 1; 2505 HiBound = -RangeSize; 2506 if (HiBound == *C2) { // -INTMIN = INTMIN 2507 HiOverflow = 1; // [INTMIN+1, overflow) 2508 HiBound = APInt(); // e.g. X/INTMIN = 0 --> X > INTMIN 2509 } 2510 } else if (C.isStrictlyPositive()) { // (X / neg) op pos 2511 // e.g. X/-5 op 3 --> [-19, -14) 2512 HiBound = Prod + 1; 2513 HiOverflow = LoOverflow = ProdOV ? -1 : 0; 2514 if (!LoOverflow) 2515 LoOverflow = addWithOverflow(LoBound, HiBound, RangeSize, true) ? -1:0; 2516 } else { // (X / neg) op neg 2517 LoBound = Prod; // e.g. X/-5 op -3 --> [15, 20) 2518 LoOverflow = HiOverflow = ProdOV; 2519 if (!HiOverflow) 2520 HiOverflow = subWithOverflow(HiBound, Prod, RangeSize, true); 2521 } 2522 2523 // Dividing by a negative swaps the condition. LT <-> GT 2524 Pred = ICmpInst::getSwappedPredicate(Pred); 2525 } 2526 2527 Value *X = Div->getOperand(0); 2528 switch (Pred) { 2529 default: llvm_unreachable("Unhandled icmp opcode!"); 2530 case ICmpInst::ICMP_EQ: 2531 if (LoOverflow && HiOverflow) 2532 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2533 if (HiOverflow) 2534 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2535 ICmpInst::ICMP_UGE, X, 2536 ConstantInt::get(Div->getType(), LoBound)); 2537 if (LoOverflow) 2538 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2539 ICmpInst::ICMP_ULT, X, 2540 ConstantInt::get(Div->getType(), HiBound)); 2541 return replaceInstUsesWith( 2542 Cmp, insertRangeTest(X, LoBound, HiBound, DivIsSigned, true)); 2543 case ICmpInst::ICMP_NE: 2544 if (LoOverflow && HiOverflow) 2545 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2546 if (HiOverflow) 2547 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SLT : 2548 ICmpInst::ICMP_ULT, X, 2549 ConstantInt::get(Div->getType(), LoBound)); 2550 if (LoOverflow) 2551 return new ICmpInst(DivIsSigned ? ICmpInst::ICMP_SGE : 2552 ICmpInst::ICMP_UGE, X, 2553 ConstantInt::get(Div->getType(), HiBound)); 2554 return replaceInstUsesWith(Cmp, 2555 insertRangeTest(X, LoBound, HiBound, 2556 DivIsSigned, false)); 2557 case ICmpInst::ICMP_ULT: 2558 case ICmpInst::ICMP_SLT: 2559 if (LoOverflow == +1) // Low bound is greater than input range. 2560 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2561 if (LoOverflow == -1) // Low bound is less than input range. 2562 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2563 return new ICmpInst(Pred, X, ConstantInt::get(Div->getType(), LoBound)); 2564 case ICmpInst::ICMP_UGT: 2565 case ICmpInst::ICMP_SGT: 2566 if (HiOverflow == +1) // High bound greater than input range. 2567 return replaceInstUsesWith(Cmp, Builder.getFalse()); 2568 if (HiOverflow == -1) // High bound less than input range. 2569 return replaceInstUsesWith(Cmp, Builder.getTrue()); 2570 if (Pred == ICmpInst::ICMP_UGT) 2571 return new ICmpInst(ICmpInst::ICMP_UGE, X, 2572 ConstantInt::get(Div->getType(), HiBound)); 2573 return new ICmpInst(ICmpInst::ICMP_SGE, X, 2574 ConstantInt::get(Div->getType(), HiBound)); 2575 } 2576 2577 return nullptr; 2578 } 2579 2580 /// Fold icmp (sub X, Y), C. 2581 Instruction *InstCombinerImpl::foldICmpSubConstant(ICmpInst &Cmp, 2582 BinaryOperator *Sub, 2583 const APInt &C) { 2584 Value *X = Sub->getOperand(0), *Y = Sub->getOperand(1); 2585 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2586 Type *Ty = Sub->getType(); 2587 2588 // (SubC - Y) == C) --> Y == (SubC - C) 2589 // (SubC - Y) != C) --> Y != (SubC - C) 2590 Constant *SubC; 2591 if (Cmp.isEquality() && match(X, m_ImmConstant(SubC))) { 2592 return new ICmpInst(Pred, Y, 2593 ConstantExpr::getSub(SubC, ConstantInt::get(Ty, C))); 2594 } 2595 2596 // (icmp P (sub nuw|nsw C2, Y), C) -> (icmp swap(P) Y, C2-C) 2597 const APInt *C2; 2598 APInt SubResult; 2599 ICmpInst::Predicate SwappedPred = Cmp.getSwappedPredicate(); 2600 bool HasNSW = Sub->hasNoSignedWrap(); 2601 bool HasNUW = Sub->hasNoUnsignedWrap(); 2602 if (match(X, m_APInt(C2)) && 2603 ((Cmp.isUnsigned() && HasNUW) || (Cmp.isSigned() && HasNSW)) && 2604 !subWithOverflow(SubResult, *C2, C, Cmp.isSigned())) 2605 return new ICmpInst(SwappedPred, Y, ConstantInt::get(Ty, SubResult)); 2606 2607 // X - Y == 0 --> X == Y. 2608 // X - Y != 0 --> X != Y. 2609 // TODO: We allow this with multiple uses as long as the other uses are not 2610 // in phis. The phi use check is guarding against a codegen regression 2611 // for a loop test. If the backend could undo this (and possibly 2612 // subsequent transforms), we would not need this hack. 2613 if (Cmp.isEquality() && C.isZero() && 2614 none_of((Sub->users()), [](const User *U) { return isa<PHINode>(U); })) 2615 return new ICmpInst(Pred, X, Y); 2616 2617 // The following transforms are only worth it if the only user of the subtract 2618 // is the icmp. 2619 // TODO: This is an artificial restriction for all of the transforms below 2620 // that only need a single replacement icmp. Can these use the phi test 2621 // like the transform above here? 2622 if (!Sub->hasOneUse()) 2623 return nullptr; 2624 2625 if (Sub->hasNoSignedWrap()) { 2626 // (icmp sgt (sub nsw X, Y), -1) -> (icmp sge X, Y) 2627 if (Pred == ICmpInst::ICMP_SGT && C.isAllOnes()) 2628 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 2629 2630 // (icmp sgt (sub nsw X, Y), 0) -> (icmp sgt X, Y) 2631 if (Pred == ICmpInst::ICMP_SGT && C.isZero()) 2632 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 2633 2634 // (icmp slt (sub nsw X, Y), 0) -> (icmp slt X, Y) 2635 if (Pred == ICmpInst::ICMP_SLT && C.isZero()) 2636 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 2637 2638 // (icmp slt (sub nsw X, Y), 1) -> (icmp sle X, Y) 2639 if (Pred == ICmpInst::ICMP_SLT && C.isOne()) 2640 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 2641 } 2642 2643 if (!match(X, m_APInt(C2))) 2644 return nullptr; 2645 2646 // C2 - Y <u C -> (Y | (C - 1)) == C2 2647 // iff (C2 & (C - 1)) == C - 1 and C is a power of 2 2648 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && 2649 (*C2 & (C - 1)) == (C - 1)) 2650 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateOr(Y, C - 1), X); 2651 2652 // C2 - Y >u C -> (Y | C) != C2 2653 // iff C2 & C == C and C + 1 is a power of 2 2654 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == C) 2655 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateOr(Y, C), X); 2656 2657 // We have handled special cases that reduce. 2658 // Canonicalize any remaining sub to add as: 2659 // (C2 - Y) > C --> (Y + ~C2) < ~C 2660 Value *Add = Builder.CreateAdd(Y, ConstantInt::get(Ty, ~(*C2)), "notsub", 2661 HasNUW, HasNSW); 2662 return new ICmpInst(SwappedPred, Add, ConstantInt::get(Ty, ~C)); 2663 } 2664 2665 /// Fold icmp (add X, Y), C. 2666 Instruction *InstCombinerImpl::foldICmpAddConstant(ICmpInst &Cmp, 2667 BinaryOperator *Add, 2668 const APInt &C) { 2669 Value *Y = Add->getOperand(1); 2670 const APInt *C2; 2671 if (Cmp.isEquality() || !match(Y, m_APInt(C2))) 2672 return nullptr; 2673 2674 // Fold icmp pred (add X, C2), C. 2675 Value *X = Add->getOperand(0); 2676 Type *Ty = Add->getType(); 2677 const CmpInst::Predicate Pred = Cmp.getPredicate(); 2678 2679 // If the add does not wrap, we can always adjust the compare by subtracting 2680 // the constants. Equality comparisons are handled elsewhere. SGE/SLE/UGE/ULE 2681 // are canonicalized to SGT/SLT/UGT/ULT. 2682 if ((Add->hasNoSignedWrap() && 2683 (Pred == ICmpInst::ICMP_SGT || Pred == ICmpInst::ICMP_SLT)) || 2684 (Add->hasNoUnsignedWrap() && 2685 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULT))) { 2686 bool Overflow; 2687 APInt NewC = 2688 Cmp.isSigned() ? C.ssub_ov(*C2, Overflow) : C.usub_ov(*C2, Overflow); 2689 // If there is overflow, the result must be true or false. 2690 // TODO: Can we assert there is no overflow because InstSimplify always 2691 // handles those cases? 2692 if (!Overflow) 2693 // icmp Pred (add nsw X, C2), C --> icmp Pred X, (C - C2) 2694 return new ICmpInst(Pred, X, ConstantInt::get(Ty, NewC)); 2695 } 2696 2697 auto CR = ConstantRange::makeExactICmpRegion(Pred, C).subtract(*C2); 2698 const APInt &Upper = CR.getUpper(); 2699 const APInt &Lower = CR.getLower(); 2700 if (Cmp.isSigned()) { 2701 if (Lower.isSignMask()) 2702 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, Upper)); 2703 if (Upper.isSignMask()) 2704 return new ICmpInst(ICmpInst::ICMP_SGE, X, ConstantInt::get(Ty, Lower)); 2705 } else { 2706 if (Lower.isMinValue()) 2707 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, Upper)); 2708 if (Upper.isMinValue()) 2709 return new ICmpInst(ICmpInst::ICMP_UGE, X, ConstantInt::get(Ty, Lower)); 2710 } 2711 2712 // This set of folds is intentionally placed after folds that use no-wrapping 2713 // flags because those folds are likely better for later analysis/codegen. 2714 const APInt SMax = APInt::getSignedMaxValue(Ty->getScalarSizeInBits()); 2715 const APInt SMin = APInt::getSignedMinValue(Ty->getScalarSizeInBits()); 2716 2717 // Fold compare with offset to opposite sign compare if it eliminates offset: 2718 // (X + C2) >u C --> X <s -C2 (if C == C2 + SMAX) 2719 if (Pred == CmpInst::ICMP_UGT && C == *C2 + SMax) 2720 return new ICmpInst(ICmpInst::ICMP_SLT, X, ConstantInt::get(Ty, -(*C2))); 2721 2722 // (X + C2) <u C --> X >s ~C2 (if C == C2 + SMIN) 2723 if (Pred == CmpInst::ICMP_ULT && C == *C2 + SMin) 2724 return new ICmpInst(ICmpInst::ICMP_SGT, X, ConstantInt::get(Ty, ~(*C2))); 2725 2726 // (X + C2) >s C --> X <u (SMAX - C) (if C == C2 - 1) 2727 if (Pred == CmpInst::ICMP_SGT && C == *C2 - 1) 2728 return new ICmpInst(ICmpInst::ICMP_ULT, X, ConstantInt::get(Ty, SMax - C)); 2729 2730 // (X + C2) <s C --> X >u (C ^ SMAX) (if C == C2) 2731 if (Pred == CmpInst::ICMP_SLT && C == *C2) 2732 return new ICmpInst(ICmpInst::ICMP_UGT, X, ConstantInt::get(Ty, C ^ SMax)); 2733 2734 if (!Add->hasOneUse()) 2735 return nullptr; 2736 2737 // X+C <u C2 -> (X & -C2) == C 2738 // iff C & (C2-1) == 0 2739 // C2 is a power of 2 2740 if (Pred == ICmpInst::ICMP_ULT && C.isPowerOf2() && (*C2 & (C - 1)) == 0) 2741 return new ICmpInst(ICmpInst::ICMP_EQ, Builder.CreateAnd(X, -C), 2742 ConstantExpr::getNeg(cast<Constant>(Y))); 2743 2744 // X+C >u C2 -> (X & ~C2) != C 2745 // iff C & C2 == 0 2746 // C2+1 is a power of 2 2747 if (Pred == ICmpInst::ICMP_UGT && (C + 1).isPowerOf2() && (*C2 & C) == 0) 2748 return new ICmpInst(ICmpInst::ICMP_NE, Builder.CreateAnd(X, ~C), 2749 ConstantExpr::getNeg(cast<Constant>(Y))); 2750 2751 // The range test idiom can use either ult or ugt. Arbitrarily canonicalize 2752 // to the ult form. 2753 // X+C2 >u C -> X+(C2-C-1) <u ~C 2754 if (Pred == ICmpInst::ICMP_UGT) 2755 return new ICmpInst(ICmpInst::ICMP_ULT, 2756 Builder.CreateAdd(X, ConstantInt::get(Ty, *C2 - C - 1)), 2757 ConstantInt::get(Ty, ~C)); 2758 2759 return nullptr; 2760 } 2761 2762 bool InstCombinerImpl::matchThreeWayIntCompare(SelectInst *SI, Value *&LHS, 2763 Value *&RHS, ConstantInt *&Less, 2764 ConstantInt *&Equal, 2765 ConstantInt *&Greater) { 2766 // TODO: Generalize this to work with other comparison idioms or ensure 2767 // they get canonicalized into this form. 2768 2769 // select i1 (a == b), 2770 // i32 Equal, 2771 // i32 (select i1 (a < b), i32 Less, i32 Greater) 2772 // where Equal, Less and Greater are placeholders for any three constants. 2773 ICmpInst::Predicate PredA; 2774 if (!match(SI->getCondition(), m_ICmp(PredA, m_Value(LHS), m_Value(RHS))) || 2775 !ICmpInst::isEquality(PredA)) 2776 return false; 2777 Value *EqualVal = SI->getTrueValue(); 2778 Value *UnequalVal = SI->getFalseValue(); 2779 // We still can get non-canonical predicate here, so canonicalize. 2780 if (PredA == ICmpInst::ICMP_NE) 2781 std::swap(EqualVal, UnequalVal); 2782 if (!match(EqualVal, m_ConstantInt(Equal))) 2783 return false; 2784 ICmpInst::Predicate PredB; 2785 Value *LHS2, *RHS2; 2786 if (!match(UnequalVal, m_Select(m_ICmp(PredB, m_Value(LHS2), m_Value(RHS2)), 2787 m_ConstantInt(Less), m_ConstantInt(Greater)))) 2788 return false; 2789 // We can get predicate mismatch here, so canonicalize if possible: 2790 // First, ensure that 'LHS' match. 2791 if (LHS2 != LHS) { 2792 // x sgt y <--> y slt x 2793 std::swap(LHS2, RHS2); 2794 PredB = ICmpInst::getSwappedPredicate(PredB); 2795 } 2796 if (LHS2 != LHS) 2797 return false; 2798 // We also need to canonicalize 'RHS'. 2799 if (PredB == ICmpInst::ICMP_SGT && isa<Constant>(RHS2)) { 2800 // x sgt C-1 <--> x sge C <--> not(x slt C) 2801 auto FlippedStrictness = 2802 InstCombiner::getFlippedStrictnessPredicateAndConstant( 2803 PredB, cast<Constant>(RHS2)); 2804 if (!FlippedStrictness) 2805 return false; 2806 assert(FlippedStrictness->first == ICmpInst::ICMP_SGE && 2807 "basic correctness failure"); 2808 RHS2 = FlippedStrictness->second; 2809 // And kind-of perform the result swap. 2810 std::swap(Less, Greater); 2811 PredB = ICmpInst::ICMP_SLT; 2812 } 2813 return PredB == ICmpInst::ICMP_SLT && RHS == RHS2; 2814 } 2815 2816 Instruction *InstCombinerImpl::foldICmpSelectConstant(ICmpInst &Cmp, 2817 SelectInst *Select, 2818 ConstantInt *C) { 2819 2820 assert(C && "Cmp RHS should be a constant int!"); 2821 // If we're testing a constant value against the result of a three way 2822 // comparison, the result can be expressed directly in terms of the 2823 // original values being compared. Note: We could possibly be more 2824 // aggressive here and remove the hasOneUse test. The original select is 2825 // really likely to simplify or sink when we remove a test of the result. 2826 Value *OrigLHS, *OrigRHS; 2827 ConstantInt *C1LessThan, *C2Equal, *C3GreaterThan; 2828 if (Cmp.hasOneUse() && 2829 matchThreeWayIntCompare(Select, OrigLHS, OrigRHS, C1LessThan, C2Equal, 2830 C3GreaterThan)) { 2831 assert(C1LessThan && C2Equal && C3GreaterThan); 2832 2833 bool TrueWhenLessThan = 2834 ConstantExpr::getCompare(Cmp.getPredicate(), C1LessThan, C) 2835 ->isAllOnesValue(); 2836 bool TrueWhenEqual = 2837 ConstantExpr::getCompare(Cmp.getPredicate(), C2Equal, C) 2838 ->isAllOnesValue(); 2839 bool TrueWhenGreaterThan = 2840 ConstantExpr::getCompare(Cmp.getPredicate(), C3GreaterThan, C) 2841 ->isAllOnesValue(); 2842 2843 // This generates the new instruction that will replace the original Cmp 2844 // Instruction. Instead of enumerating the various combinations when 2845 // TrueWhenLessThan, TrueWhenEqual and TrueWhenGreaterThan are true versus 2846 // false, we rely on chaining of ORs and future passes of InstCombine to 2847 // simplify the OR further (i.e. a s< b || a == b becomes a s<= b). 2848 2849 // When none of the three constants satisfy the predicate for the RHS (C), 2850 // the entire original Cmp can be simplified to a false. 2851 Value *Cond = Builder.getFalse(); 2852 if (TrueWhenLessThan) 2853 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SLT, 2854 OrigLHS, OrigRHS)); 2855 if (TrueWhenEqual) 2856 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_EQ, 2857 OrigLHS, OrigRHS)); 2858 if (TrueWhenGreaterThan) 2859 Cond = Builder.CreateOr(Cond, Builder.CreateICmp(ICmpInst::ICMP_SGT, 2860 OrigLHS, OrigRHS)); 2861 2862 return replaceInstUsesWith(Cmp, Cond); 2863 } 2864 return nullptr; 2865 } 2866 2867 Instruction *InstCombinerImpl::foldICmpBitCast(ICmpInst &Cmp) { 2868 auto *Bitcast = dyn_cast<BitCastInst>(Cmp.getOperand(0)); 2869 if (!Bitcast) 2870 return nullptr; 2871 2872 ICmpInst::Predicate Pred = Cmp.getPredicate(); 2873 Value *Op1 = Cmp.getOperand(1); 2874 Value *BCSrcOp = Bitcast->getOperand(0); 2875 2876 // Make sure the bitcast doesn't change the number of vector elements. 2877 if (Bitcast->getSrcTy()->getScalarSizeInBits() == 2878 Bitcast->getDestTy()->getScalarSizeInBits()) { 2879 // Zero-equality and sign-bit checks are preserved through sitofp + bitcast. 2880 Value *X; 2881 if (match(BCSrcOp, m_SIToFP(m_Value(X)))) { 2882 // icmp eq (bitcast (sitofp X)), 0 --> icmp eq X, 0 2883 // icmp ne (bitcast (sitofp X)), 0 --> icmp ne X, 0 2884 // icmp slt (bitcast (sitofp X)), 0 --> icmp slt X, 0 2885 // icmp sgt (bitcast (sitofp X)), 0 --> icmp sgt X, 0 2886 if ((Pred == ICmpInst::ICMP_EQ || Pred == ICmpInst::ICMP_SLT || 2887 Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT) && 2888 match(Op1, m_Zero())) 2889 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2890 2891 // icmp slt (bitcast (sitofp X)), 1 --> icmp slt X, 1 2892 if (Pred == ICmpInst::ICMP_SLT && match(Op1, m_One())) 2893 return new ICmpInst(Pred, X, ConstantInt::get(X->getType(), 1)); 2894 2895 // icmp sgt (bitcast (sitofp X)), -1 --> icmp sgt X, -1 2896 if (Pred == ICmpInst::ICMP_SGT && match(Op1, m_AllOnes())) 2897 return new ICmpInst(Pred, X, 2898 ConstantInt::getAllOnesValue(X->getType())); 2899 } 2900 2901 // Zero-equality checks are preserved through unsigned floating-point casts: 2902 // icmp eq (bitcast (uitofp X)), 0 --> icmp eq X, 0 2903 // icmp ne (bitcast (uitofp X)), 0 --> icmp ne X, 0 2904 if (match(BCSrcOp, m_UIToFP(m_Value(X)))) 2905 if (Cmp.isEquality() && match(Op1, m_Zero())) 2906 return new ICmpInst(Pred, X, ConstantInt::getNullValue(X->getType())); 2907 2908 // If this is a sign-bit test of a bitcast of a casted FP value, eliminate 2909 // the FP extend/truncate because that cast does not change the sign-bit. 2910 // This is true for all standard IEEE-754 types and the X86 80-bit type. 2911 // The sign-bit is always the most significant bit in those types. 2912 const APInt *C; 2913 bool TrueIfSigned; 2914 if (match(Op1, m_APInt(C)) && Bitcast->hasOneUse() && 2915 InstCombiner::isSignBitCheck(Pred, *C, TrueIfSigned)) { 2916 if (match(BCSrcOp, m_FPExt(m_Value(X))) || 2917 match(BCSrcOp, m_FPTrunc(m_Value(X)))) { 2918 // (bitcast (fpext/fptrunc X)) to iX) < 0 --> (bitcast X to iY) < 0 2919 // (bitcast (fpext/fptrunc X)) to iX) > -1 --> (bitcast X to iY) > -1 2920 Type *XType = X->getType(); 2921 2922 // We can't currently handle Power style floating point operations here. 2923 if (!(XType->isPPC_FP128Ty() || BCSrcOp->getType()->isPPC_FP128Ty())) { 2924 2925 Type *NewType = Builder.getIntNTy(XType->getScalarSizeInBits()); 2926 if (auto *XVTy = dyn_cast<VectorType>(XType)) 2927 NewType = VectorType::get(NewType, XVTy->getElementCount()); 2928 Value *NewBitcast = Builder.CreateBitCast(X, NewType); 2929 if (TrueIfSigned) 2930 return new ICmpInst(ICmpInst::ICMP_SLT, NewBitcast, 2931 ConstantInt::getNullValue(NewType)); 2932 else 2933 return new ICmpInst(ICmpInst::ICMP_SGT, NewBitcast, 2934 ConstantInt::getAllOnesValue(NewType)); 2935 } 2936 } 2937 } 2938 } 2939 2940 // Test to see if the operands of the icmp are casted versions of other 2941 // values. If the ptr->ptr cast can be stripped off both arguments, do so. 2942 if (Bitcast->getType()->isPointerTy() && 2943 (isa<Constant>(Op1) || isa<BitCastInst>(Op1))) { 2944 // If operand #1 is a bitcast instruction, it must also be a ptr->ptr cast 2945 // so eliminate it as well. 2946 if (auto *BC2 = dyn_cast<BitCastInst>(Op1)) 2947 Op1 = BC2->getOperand(0); 2948 2949 Op1 = Builder.CreateBitCast(Op1, BCSrcOp->getType()); 2950 return new ICmpInst(Pred, BCSrcOp, Op1); 2951 } 2952 2953 const APInt *C; 2954 if (!match(Cmp.getOperand(1), m_APInt(C)) || 2955 !Bitcast->getType()->isIntegerTy() || 2956 !Bitcast->getSrcTy()->isIntOrIntVectorTy()) 2957 return nullptr; 2958 2959 // If this is checking if all elements of a vector compare are set or not, 2960 // invert the casted vector equality compare and test if all compare 2961 // elements are clear or not. Compare against zero is generally easier for 2962 // analysis and codegen. 2963 // icmp eq/ne (bitcast (not X) to iN), -1 --> icmp eq/ne (bitcast X to iN), 0 2964 // Example: are all elements equal? --> are zero elements not equal? 2965 // TODO: Try harder to reduce compare of 2 freely invertible operands? 2966 if (Cmp.isEquality() && C->isAllOnes() && Bitcast->hasOneUse() && 2967 isFreeToInvert(BCSrcOp, BCSrcOp->hasOneUse())) { 2968 Type *ScalarTy = Bitcast->getType(); 2969 Value *Cast = Builder.CreateBitCast(Builder.CreateNot(BCSrcOp), ScalarTy); 2970 return new ICmpInst(Pred, Cast, ConstantInt::getNullValue(ScalarTy)); 2971 } 2972 2973 // If this is checking if all elements of an extended vector are clear or not, 2974 // compare in a narrow type to eliminate the extend: 2975 // icmp eq/ne (bitcast (ext X) to iN), 0 --> icmp eq/ne (bitcast X to iM), 0 2976 Value *X; 2977 if (Cmp.isEquality() && C->isZero() && Bitcast->hasOneUse() && 2978 match(BCSrcOp, m_ZExtOrSExt(m_Value(X)))) { 2979 if (auto *VecTy = dyn_cast<FixedVectorType>(X->getType())) { 2980 Type *NewType = Builder.getIntNTy(VecTy->getPrimitiveSizeInBits()); 2981 Value *NewCast = Builder.CreateBitCast(X, NewType); 2982 return new ICmpInst(Pred, NewCast, ConstantInt::getNullValue(NewType)); 2983 } 2984 } 2985 2986 // Folding: icmp <pred> iN X, C 2987 // where X = bitcast <M x iK> (shufflevector <M x iK> %vec, undef, SC)) to iN 2988 // and C is a splat of a K-bit pattern 2989 // and SC is a constant vector = <C', C', C', ..., C'> 2990 // Into: 2991 // %E = extractelement <M x iK> %vec, i32 C' 2992 // icmp <pred> iK %E, trunc(C) 2993 Value *Vec; 2994 ArrayRef<int> Mask; 2995 if (match(BCSrcOp, m_Shuffle(m_Value(Vec), m_Undef(), m_Mask(Mask)))) { 2996 // Check whether every element of Mask is the same constant 2997 if (is_splat(Mask)) { 2998 auto *VecTy = cast<VectorType>(BCSrcOp->getType()); 2999 auto *EltTy = cast<IntegerType>(VecTy->getElementType()); 3000 if (C->isSplat(EltTy->getBitWidth())) { 3001 // Fold the icmp based on the value of C 3002 // If C is M copies of an iK sized bit pattern, 3003 // then: 3004 // => %E = extractelement <N x iK> %vec, i32 Elem 3005 // icmp <pred> iK %SplatVal, <pattern> 3006 Value *Elem = Builder.getInt32(Mask[0]); 3007 Value *Extract = Builder.CreateExtractElement(Vec, Elem); 3008 Value *NewC = ConstantInt::get(EltTy, C->trunc(EltTy->getBitWidth())); 3009 return new ICmpInst(Pred, Extract, NewC); 3010 } 3011 } 3012 } 3013 return nullptr; 3014 } 3015 3016 /// Try to fold integer comparisons with a constant operand: icmp Pred X, C 3017 /// where X is some kind of instruction. 3018 Instruction *InstCombinerImpl::foldICmpInstWithConstant(ICmpInst &Cmp) { 3019 const APInt *C; 3020 if (!match(Cmp.getOperand(1), m_APInt(C))) 3021 return nullptr; 3022 3023 if (auto *BO = dyn_cast<BinaryOperator>(Cmp.getOperand(0))) { 3024 if (Instruction *I = foldICmpBinOpWithConstant(Cmp, BO, *C)) 3025 return I; 3026 } 3027 3028 // Match against CmpInst LHS being instructions other than binary operators. 3029 3030 if (auto *SI = dyn_cast<SelectInst>(Cmp.getOperand(0))) { 3031 // For now, we only support constant integers while folding the 3032 // ICMP(SELECT)) pattern. We can extend this to support vector of integers 3033 // similar to the cases handled by binary ops above. 3034 if (ConstantInt *ConstRHS = dyn_cast<ConstantInt>(Cmp.getOperand(1))) 3035 if (Instruction *I = foldICmpSelectConstant(Cmp, SI, ConstRHS)) 3036 return I; 3037 } 3038 3039 if (auto *TI = dyn_cast<TruncInst>(Cmp.getOperand(0))) { 3040 if (Instruction *I = foldICmpTruncConstant(Cmp, TI, *C)) 3041 return I; 3042 } 3043 3044 if (auto *II = dyn_cast<IntrinsicInst>(Cmp.getOperand(0))) 3045 if (Instruction *I = foldICmpIntrinsicWithConstant(Cmp, II, *C)) 3046 return I; 3047 3048 return nullptr; 3049 } 3050 3051 /// Fold an icmp equality instruction with binary operator LHS and constant RHS: 3052 /// icmp eq/ne BO, C. 3053 Instruction *InstCombinerImpl::foldICmpBinOpEqualityWithConstant( 3054 ICmpInst &Cmp, BinaryOperator *BO, const APInt &C) { 3055 // TODO: Some of these folds could work with arbitrary constants, but this 3056 // function is limited to scalar and vector splat constants. 3057 if (!Cmp.isEquality()) 3058 return nullptr; 3059 3060 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3061 bool isICMP_NE = Pred == ICmpInst::ICMP_NE; 3062 Constant *RHS = cast<Constant>(Cmp.getOperand(1)); 3063 Value *BOp0 = BO->getOperand(0), *BOp1 = BO->getOperand(1); 3064 3065 switch (BO->getOpcode()) { 3066 case Instruction::SRem: 3067 // If we have a signed (X % (2^c)) == 0, turn it into an unsigned one. 3068 if (C.isZero() && BO->hasOneUse()) { 3069 const APInt *BOC; 3070 if (match(BOp1, m_APInt(BOC)) && BOC->sgt(1) && BOC->isPowerOf2()) { 3071 Value *NewRem = Builder.CreateURem(BOp0, BOp1, BO->getName()); 3072 return new ICmpInst(Pred, NewRem, 3073 Constant::getNullValue(BO->getType())); 3074 } 3075 } 3076 break; 3077 case Instruction::Add: { 3078 // Replace ((add A, B) != C) with (A != C-B) if B & C are constants. 3079 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3080 if (BO->hasOneUse()) 3081 return new ICmpInst(Pred, BOp0, ConstantExpr::getSub(RHS, BOC)); 3082 } else if (C.isZero()) { 3083 // Replace ((add A, B) != 0) with (A != -B) if A or B is 3084 // efficiently invertible, or if the add has just this one use. 3085 if (Value *NegVal = dyn_castNegVal(BOp1)) 3086 return new ICmpInst(Pred, BOp0, NegVal); 3087 if (Value *NegVal = dyn_castNegVal(BOp0)) 3088 return new ICmpInst(Pred, NegVal, BOp1); 3089 if (BO->hasOneUse()) { 3090 Value *Neg = Builder.CreateNeg(BOp1); 3091 Neg->takeName(BO); 3092 return new ICmpInst(Pred, BOp0, Neg); 3093 } 3094 } 3095 break; 3096 } 3097 case Instruction::Xor: 3098 if (BO->hasOneUse()) { 3099 if (Constant *BOC = dyn_cast<Constant>(BOp1)) { 3100 // For the xor case, we can xor two constants together, eliminating 3101 // the explicit xor. 3102 return new ICmpInst(Pred, BOp0, ConstantExpr::getXor(RHS, BOC)); 3103 } else if (C.isZero()) { 3104 // Replace ((xor A, B) != 0) with (A != B) 3105 return new ICmpInst(Pred, BOp0, BOp1); 3106 } 3107 } 3108 break; 3109 case Instruction::Or: { 3110 const APInt *BOC; 3111 if (match(BOp1, m_APInt(BOC)) && BO->hasOneUse() && RHS->isAllOnesValue()) { 3112 // Comparing if all bits outside of a constant mask are set? 3113 // Replace (X | C) == -1 with (X & ~C) == ~C. 3114 // This removes the -1 constant. 3115 Constant *NotBOC = ConstantExpr::getNot(cast<Constant>(BOp1)); 3116 Value *And = Builder.CreateAnd(BOp0, NotBOC); 3117 return new ICmpInst(Pred, And, NotBOC); 3118 } 3119 break; 3120 } 3121 case Instruction::And: { 3122 const APInt *BOC; 3123 if (match(BOp1, m_APInt(BOC))) { 3124 // If we have ((X & C) == C), turn it into ((X & C) != 0). 3125 if (C == *BOC && C.isPowerOf2()) 3126 return new ICmpInst(isICMP_NE ? ICmpInst::ICMP_EQ : ICmpInst::ICMP_NE, 3127 BO, Constant::getNullValue(RHS->getType())); 3128 } 3129 break; 3130 } 3131 case Instruction::UDiv: 3132 if (C.isZero()) { 3133 // (icmp eq/ne (udiv A, B), 0) -> (icmp ugt/ule i32 B, A) 3134 auto NewPred = isICMP_NE ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3135 return new ICmpInst(NewPred, BOp1, BOp0); 3136 } 3137 break; 3138 default: 3139 break; 3140 } 3141 return nullptr; 3142 } 3143 3144 /// Fold an equality icmp with LLVM intrinsic and constant operand. 3145 Instruction *InstCombinerImpl::foldICmpEqIntrinsicWithConstant( 3146 ICmpInst &Cmp, IntrinsicInst *II, const APInt &C) { 3147 Type *Ty = II->getType(); 3148 unsigned BitWidth = C.getBitWidth(); 3149 const ICmpInst::Predicate Pred = Cmp.getPredicate(); 3150 3151 switch (II->getIntrinsicID()) { 3152 case Intrinsic::abs: 3153 // abs(A) == 0 -> A == 0 3154 // abs(A) == INT_MIN -> A == INT_MIN 3155 if (C.isZero() || C.isMinSignedValue()) 3156 return new ICmpInst(Pred, II->getArgOperand(0), ConstantInt::get(Ty, C)); 3157 break; 3158 3159 case Intrinsic::bswap: 3160 // bswap(A) == C -> A == bswap(C) 3161 return new ICmpInst(Pred, II->getArgOperand(0), 3162 ConstantInt::get(Ty, C.byteSwap())); 3163 3164 case Intrinsic::ctlz: 3165 case Intrinsic::cttz: { 3166 // ctz(A) == bitwidth(A) -> A == 0 and likewise for != 3167 if (C == BitWidth) 3168 return new ICmpInst(Pred, II->getArgOperand(0), 3169 ConstantInt::getNullValue(Ty)); 3170 3171 // ctz(A) == C -> A & Mask1 == Mask2, where Mask2 only has bit C set 3172 // and Mask1 has bits 0..C+1 set. Similar for ctl, but for high bits. 3173 // Limit to one use to ensure we don't increase instruction count. 3174 unsigned Num = C.getLimitedValue(BitWidth); 3175 if (Num != BitWidth && II->hasOneUse()) { 3176 bool IsTrailing = II->getIntrinsicID() == Intrinsic::cttz; 3177 APInt Mask1 = IsTrailing ? APInt::getLowBitsSet(BitWidth, Num + 1) 3178 : APInt::getHighBitsSet(BitWidth, Num + 1); 3179 APInt Mask2 = IsTrailing 3180 ? APInt::getOneBitSet(BitWidth, Num) 3181 : APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3182 return new ICmpInst(Pred, Builder.CreateAnd(II->getArgOperand(0), Mask1), 3183 ConstantInt::get(Ty, Mask2)); 3184 } 3185 break; 3186 } 3187 3188 case Intrinsic::ctpop: { 3189 // popcount(A) == 0 -> A == 0 and likewise for != 3190 // popcount(A) == bitwidth(A) -> A == -1 and likewise for != 3191 bool IsZero = C.isZero(); 3192 if (IsZero || C == BitWidth) 3193 return new ICmpInst(Pred, II->getArgOperand(0), 3194 IsZero ? Constant::getNullValue(Ty) 3195 : Constant::getAllOnesValue(Ty)); 3196 3197 break; 3198 } 3199 3200 case Intrinsic::fshl: 3201 case Intrinsic::fshr: 3202 if (II->getArgOperand(0) == II->getArgOperand(1)) { 3203 // (rot X, ?) == 0/-1 --> X == 0/-1 3204 // TODO: This transform is safe to re-use undef elts in a vector, but 3205 // the constant value passed in by the caller doesn't allow that. 3206 if (C.isZero() || C.isAllOnes()) 3207 return new ICmpInst(Pred, II->getArgOperand(0), Cmp.getOperand(1)); 3208 3209 const APInt *RotAmtC; 3210 // ror(X, RotAmtC) == C --> X == rol(C, RotAmtC) 3211 // rol(X, RotAmtC) == C --> X == ror(C, RotAmtC) 3212 if (match(II->getArgOperand(2), m_APInt(RotAmtC))) 3213 return new ICmpInst(Pred, II->getArgOperand(0), 3214 II->getIntrinsicID() == Intrinsic::fshl 3215 ? ConstantInt::get(Ty, C.rotr(*RotAmtC)) 3216 : ConstantInt::get(Ty, C.rotl(*RotAmtC))); 3217 } 3218 break; 3219 3220 case Intrinsic::uadd_sat: { 3221 // uadd.sat(a, b) == 0 -> (a | b) == 0 3222 if (C.isZero()) { 3223 Value *Or = Builder.CreateOr(II->getArgOperand(0), II->getArgOperand(1)); 3224 return new ICmpInst(Pred, Or, Constant::getNullValue(Ty)); 3225 } 3226 break; 3227 } 3228 3229 case Intrinsic::usub_sat: { 3230 // usub.sat(a, b) == 0 -> a <= b 3231 if (C.isZero()) { 3232 ICmpInst::Predicate NewPred = 3233 Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_UGT; 3234 return new ICmpInst(NewPred, II->getArgOperand(0), II->getArgOperand(1)); 3235 } 3236 break; 3237 } 3238 default: 3239 break; 3240 } 3241 3242 return nullptr; 3243 } 3244 3245 /// Fold an icmp with LLVM intrinsics 3246 static Instruction *foldICmpIntrinsicWithIntrinsic(ICmpInst &Cmp) { 3247 assert(Cmp.isEquality()); 3248 3249 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3250 Value *Op0 = Cmp.getOperand(0); 3251 Value *Op1 = Cmp.getOperand(1); 3252 const auto *IIOp0 = dyn_cast<IntrinsicInst>(Op0); 3253 const auto *IIOp1 = dyn_cast<IntrinsicInst>(Op1); 3254 if (!IIOp0 || !IIOp1 || IIOp0->getIntrinsicID() != IIOp1->getIntrinsicID()) 3255 return nullptr; 3256 3257 switch (IIOp0->getIntrinsicID()) { 3258 case Intrinsic::bswap: 3259 case Intrinsic::bitreverse: 3260 // If both operands are byte-swapped or bit-reversed, just compare the 3261 // original values. 3262 return new ICmpInst(Pred, IIOp0->getOperand(0), IIOp1->getOperand(0)); 3263 case Intrinsic::fshl: 3264 case Intrinsic::fshr: 3265 // If both operands are rotated by same amount, just compare the 3266 // original values. 3267 if (IIOp0->getOperand(0) != IIOp0->getOperand(1)) 3268 break; 3269 if (IIOp1->getOperand(0) != IIOp1->getOperand(1)) 3270 break; 3271 if (IIOp0->getOperand(2) != IIOp1->getOperand(2)) 3272 break; 3273 return new ICmpInst(Pred, IIOp0->getOperand(0), IIOp1->getOperand(0)); 3274 default: 3275 break; 3276 } 3277 3278 return nullptr; 3279 } 3280 3281 /// Fold an icmp with BinaryOp and constant operand: icmp Pred BO, C. 3282 Instruction *InstCombinerImpl::foldICmpBinOpWithConstant(ICmpInst &Cmp, 3283 BinaryOperator *BO, 3284 const APInt &C) { 3285 switch (BO->getOpcode()) { 3286 case Instruction::Xor: 3287 if (Instruction *I = foldICmpXorConstant(Cmp, BO, C)) 3288 return I; 3289 break; 3290 case Instruction::And: 3291 if (Instruction *I = foldICmpAndConstant(Cmp, BO, C)) 3292 return I; 3293 break; 3294 case Instruction::Or: 3295 if (Instruction *I = foldICmpOrConstant(Cmp, BO, C)) 3296 return I; 3297 break; 3298 case Instruction::Mul: 3299 if (Instruction *I = foldICmpMulConstant(Cmp, BO, C)) 3300 return I; 3301 break; 3302 case Instruction::Shl: 3303 if (Instruction *I = foldICmpShlConstant(Cmp, BO, C)) 3304 return I; 3305 break; 3306 case Instruction::LShr: 3307 case Instruction::AShr: 3308 if (Instruction *I = foldICmpShrConstant(Cmp, BO, C)) 3309 return I; 3310 break; 3311 case Instruction::SRem: 3312 if (Instruction *I = foldICmpSRemConstant(Cmp, BO, C)) 3313 return I; 3314 break; 3315 case Instruction::UDiv: 3316 if (Instruction *I = foldICmpUDivConstant(Cmp, BO, C)) 3317 return I; 3318 LLVM_FALLTHROUGH; 3319 case Instruction::SDiv: 3320 if (Instruction *I = foldICmpDivConstant(Cmp, BO, C)) 3321 return I; 3322 break; 3323 case Instruction::Sub: 3324 if (Instruction *I = foldICmpSubConstant(Cmp, BO, C)) 3325 return I; 3326 break; 3327 case Instruction::Add: 3328 if (Instruction *I = foldICmpAddConstant(Cmp, BO, C)) 3329 return I; 3330 break; 3331 default: 3332 break; 3333 } 3334 3335 // TODO: These folds could be refactored to be part of the above calls. 3336 return foldICmpBinOpEqualityWithConstant(Cmp, BO, C); 3337 } 3338 3339 /// Fold an icmp with LLVM intrinsic and constant operand: icmp Pred II, C. 3340 Instruction *InstCombinerImpl::foldICmpIntrinsicWithConstant(ICmpInst &Cmp, 3341 IntrinsicInst *II, 3342 const APInt &C) { 3343 if (Cmp.isEquality()) 3344 return foldICmpEqIntrinsicWithConstant(Cmp, II, C); 3345 3346 Type *Ty = II->getType(); 3347 unsigned BitWidth = C.getBitWidth(); 3348 ICmpInst::Predicate Pred = Cmp.getPredicate(); 3349 switch (II->getIntrinsicID()) { 3350 case Intrinsic::ctpop: { 3351 // (ctpop X > BitWidth - 1) --> X == -1 3352 Value *X = II->getArgOperand(0); 3353 if (C == BitWidth - 1 && Pred == ICmpInst::ICMP_UGT) 3354 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, X, 3355 ConstantInt::getAllOnesValue(Ty)); 3356 // (ctpop X < BitWidth) --> X != -1 3357 if (C == BitWidth && Pred == ICmpInst::ICMP_ULT) 3358 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, X, 3359 ConstantInt::getAllOnesValue(Ty)); 3360 break; 3361 } 3362 case Intrinsic::ctlz: { 3363 // ctlz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX < 0b00010000 3364 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3365 unsigned Num = C.getLimitedValue(); 3366 APInt Limit = APInt::getOneBitSet(BitWidth, BitWidth - Num - 1); 3367 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_ULT, 3368 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3369 } 3370 3371 // ctlz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX > 0b00011111 3372 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3373 unsigned Num = C.getLimitedValue(); 3374 APInt Limit = APInt::getLowBitsSet(BitWidth, BitWidth - Num); 3375 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_UGT, 3376 II->getArgOperand(0), ConstantInt::get(Ty, Limit)); 3377 } 3378 break; 3379 } 3380 case Intrinsic::cttz: { 3381 // Limit to one use to ensure we don't increase instruction count. 3382 if (!II->hasOneUse()) 3383 return nullptr; 3384 3385 // cttz(0bXXXXXXXX) > 3 -> 0bXXXXXXXX & 0b00001111 == 0 3386 if (Pred == ICmpInst::ICMP_UGT && C.ult(BitWidth)) { 3387 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue() + 1); 3388 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_EQ, 3389 Builder.CreateAnd(II->getArgOperand(0), Mask), 3390 ConstantInt::getNullValue(Ty)); 3391 } 3392 3393 // cttz(0bXXXXXXXX) < 3 -> 0bXXXXXXXX & 0b00000111 != 0 3394 if (Pred == ICmpInst::ICMP_ULT && C.uge(1) && C.ule(BitWidth)) { 3395 APInt Mask = APInt::getLowBitsSet(BitWidth, C.getLimitedValue()); 3396 return CmpInst::Create(Instruction::ICmp, ICmpInst::ICMP_NE, 3397 Builder.CreateAnd(II->getArgOperand(0), Mask), 3398 ConstantInt::getNullValue(Ty)); 3399 } 3400 break; 3401 } 3402 default: 3403 break; 3404 } 3405 3406 return nullptr; 3407 } 3408 3409 /// Handle icmp with constant (but not simple integer constant) RHS. 3410 Instruction *InstCombinerImpl::foldICmpInstWithConstantNotInt(ICmpInst &I) { 3411 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3412 Constant *RHSC = dyn_cast<Constant>(Op1); 3413 Instruction *LHSI = dyn_cast<Instruction>(Op0); 3414 if (!RHSC || !LHSI) 3415 return nullptr; 3416 3417 switch (LHSI->getOpcode()) { 3418 case Instruction::GetElementPtr: 3419 // icmp pred GEP (P, int 0, int 0, int 0), null -> icmp pred P, null 3420 if (RHSC->isNullValue() && 3421 cast<GetElementPtrInst>(LHSI)->hasAllZeroIndices()) 3422 return new ICmpInst( 3423 I.getPredicate(), LHSI->getOperand(0), 3424 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3425 break; 3426 case Instruction::PHI: 3427 // Only fold icmp into the PHI if the phi and icmp are in the same 3428 // block. If in the same block, we're encouraging jump threading. If 3429 // not, we are just pessimizing the code by making an i1 phi. 3430 if (LHSI->getParent() == I.getParent()) 3431 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 3432 return NV; 3433 break; 3434 case Instruction::IntToPtr: 3435 // icmp pred inttoptr(X), null -> icmp pred X, 0 3436 if (RHSC->isNullValue() && 3437 DL.getIntPtrType(RHSC->getType()) == LHSI->getOperand(0)->getType()) 3438 return new ICmpInst( 3439 I.getPredicate(), LHSI->getOperand(0), 3440 Constant::getNullValue(LHSI->getOperand(0)->getType())); 3441 break; 3442 3443 case Instruction::Load: 3444 // Try to optimize things like "A[i] > 4" to index computations. 3445 if (GetElementPtrInst *GEP = 3446 dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 3447 if (GlobalVariable *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 3448 if (Instruction *Res = 3449 foldCmpLoadFromIndexedGlobal(cast<LoadInst>(LHSI), GEP, GV, I)) 3450 return Res; 3451 break; 3452 } 3453 3454 return nullptr; 3455 } 3456 3457 Instruction *InstCombinerImpl::foldSelectICmp(ICmpInst::Predicate Pred, 3458 SelectInst *SI, Value *RHS, 3459 const ICmpInst &I) { 3460 // Try to fold the comparison into the select arms, which will cause the 3461 // select to be converted into a logical and/or. 3462 auto SimplifyOp = [&](Value *Op, bool SelectCondIsTrue) -> Value * { 3463 if (Value *Res = SimplifyICmpInst(Pred, Op, RHS, SQ)) 3464 return Res; 3465 if (Optional<bool> Impl = isImpliedCondition(SI->getCondition(), Pred, Op, 3466 RHS, DL, SelectCondIsTrue)) 3467 return ConstantInt::get(I.getType(), *Impl); 3468 return nullptr; 3469 }; 3470 3471 ConstantInt *CI = nullptr; 3472 Value *Op1 = SimplifyOp(SI->getOperand(1), true); 3473 if (Op1) 3474 CI = dyn_cast<ConstantInt>(Op1); 3475 3476 Value *Op2 = SimplifyOp(SI->getOperand(2), false); 3477 if (Op2) 3478 CI = dyn_cast<ConstantInt>(Op2); 3479 3480 // We only want to perform this transformation if it will not lead to 3481 // additional code. This is true if either both sides of the select 3482 // fold to a constant (in which case the icmp is replaced with a select 3483 // which will usually simplify) or this is the only user of the 3484 // select (in which case we are trading a select+icmp for a simpler 3485 // select+icmp) or all uses of the select can be replaced based on 3486 // dominance information ("Global cases"). 3487 bool Transform = false; 3488 if (Op1 && Op2) 3489 Transform = true; 3490 else if (Op1 || Op2) { 3491 // Local case 3492 if (SI->hasOneUse()) 3493 Transform = true; 3494 // Global cases 3495 else if (CI && !CI->isZero()) 3496 // When Op1 is constant try replacing select with second operand. 3497 // Otherwise Op2 is constant and try replacing select with first 3498 // operand. 3499 Transform = replacedSelectWithOperand(SI, &I, Op1 ? 2 : 1); 3500 } 3501 if (Transform) { 3502 if (!Op1) 3503 Op1 = Builder.CreateICmp(Pred, SI->getOperand(1), RHS, I.getName()); 3504 if (!Op2) 3505 Op2 = Builder.CreateICmp(Pred, SI->getOperand(2), RHS, I.getName()); 3506 return SelectInst::Create(SI->getOperand(0), Op1, Op2); 3507 } 3508 3509 return nullptr; 3510 } 3511 3512 /// Some comparisons can be simplified. 3513 /// In this case, we are looking for comparisons that look like 3514 /// a check for a lossy truncation. 3515 /// Folds: 3516 /// icmp SrcPred (x & Mask), x to icmp DstPred x, Mask 3517 /// Where Mask is some pattern that produces all-ones in low bits: 3518 /// (-1 >> y) 3519 /// ((-1 << y) >> y) <- non-canonical, has extra uses 3520 /// ~(-1 << y) 3521 /// ((1 << y) + (-1)) <- non-canonical, has extra uses 3522 /// The Mask can be a constant, too. 3523 /// For some predicates, the operands are commutative. 3524 /// For others, x can only be on a specific side. 3525 static Value *foldICmpWithLowBitMaskedVal(ICmpInst &I, 3526 InstCombiner::BuilderTy &Builder) { 3527 ICmpInst::Predicate SrcPred; 3528 Value *X, *M, *Y; 3529 auto m_VariableMask = m_CombineOr( 3530 m_CombineOr(m_Not(m_Shl(m_AllOnes(), m_Value())), 3531 m_Add(m_Shl(m_One(), m_Value()), m_AllOnes())), 3532 m_CombineOr(m_LShr(m_AllOnes(), m_Value()), 3533 m_LShr(m_Shl(m_AllOnes(), m_Value(Y)), m_Deferred(Y)))); 3534 auto m_Mask = m_CombineOr(m_VariableMask, m_LowBitMask()); 3535 if (!match(&I, m_c_ICmp(SrcPred, 3536 m_c_And(m_CombineAnd(m_Mask, m_Value(M)), m_Value(X)), 3537 m_Deferred(X)))) 3538 return nullptr; 3539 3540 ICmpInst::Predicate DstPred; 3541 switch (SrcPred) { 3542 case ICmpInst::Predicate::ICMP_EQ: 3543 // x & (-1 >> y) == x -> x u<= (-1 >> y) 3544 DstPred = ICmpInst::Predicate::ICMP_ULE; 3545 break; 3546 case ICmpInst::Predicate::ICMP_NE: 3547 // x & (-1 >> y) != x -> x u> (-1 >> y) 3548 DstPred = ICmpInst::Predicate::ICMP_UGT; 3549 break; 3550 case ICmpInst::Predicate::ICMP_ULT: 3551 // x & (-1 >> y) u< x -> x u> (-1 >> y) 3552 // x u> x & (-1 >> y) -> x u> (-1 >> y) 3553 DstPred = ICmpInst::Predicate::ICMP_UGT; 3554 break; 3555 case ICmpInst::Predicate::ICMP_UGE: 3556 // x & (-1 >> y) u>= x -> x u<= (-1 >> y) 3557 // x u<= x & (-1 >> y) -> x u<= (-1 >> y) 3558 DstPred = ICmpInst::Predicate::ICMP_ULE; 3559 break; 3560 case ICmpInst::Predicate::ICMP_SLT: 3561 // x & (-1 >> y) s< x -> x s> (-1 >> y) 3562 // x s> x & (-1 >> y) -> x s> (-1 >> y) 3563 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3564 return nullptr; 3565 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3566 return nullptr; 3567 DstPred = ICmpInst::Predicate::ICMP_SGT; 3568 break; 3569 case ICmpInst::Predicate::ICMP_SGE: 3570 // x & (-1 >> y) s>= x -> x s<= (-1 >> y) 3571 // x s<= x & (-1 >> y) -> x s<= (-1 >> y) 3572 if (!match(M, m_Constant())) // Can not do this fold with non-constant. 3573 return nullptr; 3574 if (!match(M, m_NonNegative())) // Must not have any -1 vector elements. 3575 return nullptr; 3576 DstPred = ICmpInst::Predicate::ICMP_SLE; 3577 break; 3578 case ICmpInst::Predicate::ICMP_SGT: 3579 case ICmpInst::Predicate::ICMP_SLE: 3580 return nullptr; 3581 case ICmpInst::Predicate::ICMP_UGT: 3582 case ICmpInst::Predicate::ICMP_ULE: 3583 llvm_unreachable("Instsimplify took care of commut. variant"); 3584 break; 3585 default: 3586 llvm_unreachable("All possible folds are handled."); 3587 } 3588 3589 // The mask value may be a vector constant that has undefined elements. But it 3590 // may not be safe to propagate those undefs into the new compare, so replace 3591 // those elements by copying an existing, defined, and safe scalar constant. 3592 Type *OpTy = M->getType(); 3593 auto *VecC = dyn_cast<Constant>(M); 3594 auto *OpVTy = dyn_cast<FixedVectorType>(OpTy); 3595 if (OpVTy && VecC && VecC->containsUndefOrPoisonElement()) { 3596 Constant *SafeReplacementConstant = nullptr; 3597 for (unsigned i = 0, e = OpVTy->getNumElements(); i != e; ++i) { 3598 if (!isa<UndefValue>(VecC->getAggregateElement(i))) { 3599 SafeReplacementConstant = VecC->getAggregateElement(i); 3600 break; 3601 } 3602 } 3603 assert(SafeReplacementConstant && "Failed to find undef replacement"); 3604 M = Constant::replaceUndefsWith(VecC, SafeReplacementConstant); 3605 } 3606 3607 return Builder.CreateICmp(DstPred, X, M); 3608 } 3609 3610 /// Some comparisons can be simplified. 3611 /// In this case, we are looking for comparisons that look like 3612 /// a check for a lossy signed truncation. 3613 /// Folds: (MaskedBits is a constant.) 3614 /// ((%x << MaskedBits) a>> MaskedBits) SrcPred %x 3615 /// Into: 3616 /// (add %x, (1 << (KeptBits-1))) DstPred (1 << KeptBits) 3617 /// Where KeptBits = bitwidth(%x) - MaskedBits 3618 static Value * 3619 foldICmpWithTruncSignExtendedVal(ICmpInst &I, 3620 InstCombiner::BuilderTy &Builder) { 3621 ICmpInst::Predicate SrcPred; 3622 Value *X; 3623 const APInt *C0, *C1; // FIXME: non-splats, potentially with undef. 3624 // We are ok with 'shl' having multiple uses, but 'ashr' must be one-use. 3625 if (!match(&I, m_c_ICmp(SrcPred, 3626 m_OneUse(m_AShr(m_Shl(m_Value(X), m_APInt(C0)), 3627 m_APInt(C1))), 3628 m_Deferred(X)))) 3629 return nullptr; 3630 3631 // Potential handling of non-splats: for each element: 3632 // * if both are undef, replace with constant 0. 3633 // Because (1<<0) is OK and is 1, and ((1<<0)>>1) is also OK and is 0. 3634 // * if both are not undef, and are different, bailout. 3635 // * else, only one is undef, then pick the non-undef one. 3636 3637 // The shift amount must be equal. 3638 if (*C0 != *C1) 3639 return nullptr; 3640 const APInt &MaskedBits = *C0; 3641 assert(MaskedBits != 0 && "shift by zero should be folded away already."); 3642 3643 ICmpInst::Predicate DstPred; 3644 switch (SrcPred) { 3645 case ICmpInst::Predicate::ICMP_EQ: 3646 // ((%x << MaskedBits) a>> MaskedBits) == %x 3647 // => 3648 // (add %x, (1 << (KeptBits-1))) u< (1 << KeptBits) 3649 DstPred = ICmpInst::Predicate::ICMP_ULT; 3650 break; 3651 case ICmpInst::Predicate::ICMP_NE: 3652 // ((%x << MaskedBits) a>> MaskedBits) != %x 3653 // => 3654 // (add %x, (1 << (KeptBits-1))) u>= (1 << KeptBits) 3655 DstPred = ICmpInst::Predicate::ICMP_UGE; 3656 break; 3657 // FIXME: are more folds possible? 3658 default: 3659 return nullptr; 3660 } 3661 3662 auto *XType = X->getType(); 3663 const unsigned XBitWidth = XType->getScalarSizeInBits(); 3664 const APInt BitWidth = APInt(XBitWidth, XBitWidth); 3665 assert(BitWidth.ugt(MaskedBits) && "shifts should leave some bits untouched"); 3666 3667 // KeptBits = bitwidth(%x) - MaskedBits 3668 const APInt KeptBits = BitWidth - MaskedBits; 3669 assert(KeptBits.ugt(0) && KeptBits.ult(BitWidth) && "unreachable"); 3670 // ICmpCst = (1 << KeptBits) 3671 const APInt ICmpCst = APInt(XBitWidth, 1).shl(KeptBits); 3672 assert(ICmpCst.isPowerOf2()); 3673 // AddCst = (1 << (KeptBits-1)) 3674 const APInt AddCst = ICmpCst.lshr(1); 3675 assert(AddCst.ult(ICmpCst) && AddCst.isPowerOf2()); 3676 3677 // T0 = add %x, AddCst 3678 Value *T0 = Builder.CreateAdd(X, ConstantInt::get(XType, AddCst)); 3679 // T1 = T0 DstPred ICmpCst 3680 Value *T1 = Builder.CreateICmp(DstPred, T0, ConstantInt::get(XType, ICmpCst)); 3681 3682 return T1; 3683 } 3684 3685 // Given pattern: 3686 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3687 // we should move shifts to the same hand of 'and', i.e. rewrite as 3688 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3689 // We are only interested in opposite logical shifts here. 3690 // One of the shifts can be truncated. 3691 // If we can, we want to end up creating 'lshr' shift. 3692 static Value * 3693 foldShiftIntoShiftInAnotherHandOfAndInICmp(ICmpInst &I, const SimplifyQuery SQ, 3694 InstCombiner::BuilderTy &Builder) { 3695 if (!I.isEquality() || !match(I.getOperand(1), m_Zero()) || 3696 !I.getOperand(0)->hasOneUse()) 3697 return nullptr; 3698 3699 auto m_AnyLogicalShift = m_LogicalShift(m_Value(), m_Value()); 3700 3701 // Look for an 'and' of two logical shifts, one of which may be truncated. 3702 // We use m_TruncOrSelf() on the RHS to correctly handle commutative case. 3703 Instruction *XShift, *MaybeTruncation, *YShift; 3704 if (!match( 3705 I.getOperand(0), 3706 m_c_And(m_CombineAnd(m_AnyLogicalShift, m_Instruction(XShift)), 3707 m_CombineAnd(m_TruncOrSelf(m_CombineAnd( 3708 m_AnyLogicalShift, m_Instruction(YShift))), 3709 m_Instruction(MaybeTruncation))))) 3710 return nullptr; 3711 3712 // We potentially looked past 'trunc', but only when matching YShift, 3713 // therefore YShift must have the widest type. 3714 Instruction *WidestShift = YShift; 3715 // Therefore XShift must have the shallowest type. 3716 // Or they both have identical types if there was no truncation. 3717 Instruction *NarrowestShift = XShift; 3718 3719 Type *WidestTy = WidestShift->getType(); 3720 Type *NarrowestTy = NarrowestShift->getType(); 3721 assert(NarrowestTy == I.getOperand(0)->getType() && 3722 "We did not look past any shifts while matching XShift though."); 3723 bool HadTrunc = WidestTy != I.getOperand(0)->getType(); 3724 3725 // If YShift is a 'lshr', swap the shifts around. 3726 if (match(YShift, m_LShr(m_Value(), m_Value()))) 3727 std::swap(XShift, YShift); 3728 3729 // The shifts must be in opposite directions. 3730 auto XShiftOpcode = XShift->getOpcode(); 3731 if (XShiftOpcode == YShift->getOpcode()) 3732 return nullptr; // Do not care about same-direction shifts here. 3733 3734 Value *X, *XShAmt, *Y, *YShAmt; 3735 match(XShift, m_BinOp(m_Value(X), m_ZExtOrSelf(m_Value(XShAmt)))); 3736 match(YShift, m_BinOp(m_Value(Y), m_ZExtOrSelf(m_Value(YShAmt)))); 3737 3738 // If one of the values being shifted is a constant, then we will end with 3739 // and+icmp, and [zext+]shift instrs will be constant-folded. If they are not, 3740 // however, we will need to ensure that we won't increase instruction count. 3741 if (!isa<Constant>(X) && !isa<Constant>(Y)) { 3742 // At least one of the hands of the 'and' should be one-use shift. 3743 if (!match(I.getOperand(0), 3744 m_c_And(m_OneUse(m_AnyLogicalShift), m_Value()))) 3745 return nullptr; 3746 if (HadTrunc) { 3747 // Due to the 'trunc', we will need to widen X. For that either the old 3748 // 'trunc' or the shift amt in the non-truncated shift should be one-use. 3749 if (!MaybeTruncation->hasOneUse() && 3750 !NarrowestShift->getOperand(1)->hasOneUse()) 3751 return nullptr; 3752 } 3753 } 3754 3755 // We have two shift amounts from two different shifts. The types of those 3756 // shift amounts may not match. If that's the case let's bailout now. 3757 if (XShAmt->getType() != YShAmt->getType()) 3758 return nullptr; 3759 3760 // As input, we have the following pattern: 3761 // icmp eq/ne (and ((x shift Q), (y oppositeshift K))), 0 3762 // We want to rewrite that as: 3763 // icmp eq/ne (and (x shift (Q+K)), y), 0 iff (Q+K) u< bitwidth(x) 3764 // While we know that originally (Q+K) would not overflow 3765 // (because 2 * (N-1) u<= iN -1), we have looked past extensions of 3766 // shift amounts. so it may now overflow in smaller bitwidth. 3767 // To ensure that does not happen, we need to ensure that the total maximal 3768 // shift amount is still representable in that smaller bit width. 3769 unsigned MaximalPossibleTotalShiftAmount = 3770 (WidestTy->getScalarSizeInBits() - 1) + 3771 (NarrowestTy->getScalarSizeInBits() - 1); 3772 APInt MaximalRepresentableShiftAmount = 3773 APInt::getAllOnes(XShAmt->getType()->getScalarSizeInBits()); 3774 if (MaximalRepresentableShiftAmount.ult(MaximalPossibleTotalShiftAmount)) 3775 return nullptr; 3776 3777 // Can we fold (XShAmt+YShAmt) ? 3778 auto *NewShAmt = dyn_cast_or_null<Constant>( 3779 SimplifyAddInst(XShAmt, YShAmt, /*isNSW=*/false, 3780 /*isNUW=*/false, SQ.getWithInstruction(&I))); 3781 if (!NewShAmt) 3782 return nullptr; 3783 NewShAmt = ConstantExpr::getZExtOrBitCast(NewShAmt, WidestTy); 3784 unsigned WidestBitWidth = WidestTy->getScalarSizeInBits(); 3785 3786 // Is the new shift amount smaller than the bit width? 3787 // FIXME: could also rely on ConstantRange. 3788 if (!match(NewShAmt, 3789 m_SpecificInt_ICMP(ICmpInst::Predicate::ICMP_ULT, 3790 APInt(WidestBitWidth, WidestBitWidth)))) 3791 return nullptr; 3792 3793 // An extra legality check is needed if we had trunc-of-lshr. 3794 if (HadTrunc && match(WidestShift, m_LShr(m_Value(), m_Value()))) { 3795 auto CanFold = [NewShAmt, WidestBitWidth, NarrowestShift, SQ, 3796 WidestShift]() { 3797 // It isn't obvious whether it's worth it to analyze non-constants here. 3798 // Also, let's basically give up on non-splat cases, pessimizing vectors. 3799 // If *any* of these preconditions matches we can perform the fold. 3800 Constant *NewShAmtSplat = NewShAmt->getType()->isVectorTy() 3801 ? NewShAmt->getSplatValue() 3802 : NewShAmt; 3803 // If it's edge-case shift (by 0 or by WidestBitWidth-1) we can fold. 3804 if (NewShAmtSplat && 3805 (NewShAmtSplat->isNullValue() || 3806 NewShAmtSplat->getUniqueInteger() == WidestBitWidth - 1)) 3807 return true; 3808 // We consider *min* leading zeros so a single outlier 3809 // blocks the transform as opposed to allowing it. 3810 if (auto *C = dyn_cast<Constant>(NarrowestShift->getOperand(0))) { 3811 KnownBits Known = computeKnownBits(C, SQ.DL); 3812 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3813 // If the value being shifted has at most lowest bit set we can fold. 3814 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3815 if (MaxActiveBits <= 1) 3816 return true; 3817 // Precondition: NewShAmt u<= countLeadingZeros(C) 3818 if (NewShAmtSplat && NewShAmtSplat->getUniqueInteger().ule(MinLeadZero)) 3819 return true; 3820 } 3821 if (auto *C = dyn_cast<Constant>(WidestShift->getOperand(0))) { 3822 KnownBits Known = computeKnownBits(C, SQ.DL); 3823 unsigned MinLeadZero = Known.countMinLeadingZeros(); 3824 // If the value being shifted has at most lowest bit set we can fold. 3825 unsigned MaxActiveBits = Known.getBitWidth() - MinLeadZero; 3826 if (MaxActiveBits <= 1) 3827 return true; 3828 // Precondition: ((WidestBitWidth-1)-NewShAmt) u<= countLeadingZeros(C) 3829 if (NewShAmtSplat) { 3830 APInt AdjNewShAmt = 3831 (WidestBitWidth - 1) - NewShAmtSplat->getUniqueInteger(); 3832 if (AdjNewShAmt.ule(MinLeadZero)) 3833 return true; 3834 } 3835 } 3836 return false; // Can't tell if it's ok. 3837 }; 3838 if (!CanFold()) 3839 return nullptr; 3840 } 3841 3842 // All good, we can do this fold. 3843 X = Builder.CreateZExt(X, WidestTy); 3844 Y = Builder.CreateZExt(Y, WidestTy); 3845 // The shift is the same that was for X. 3846 Value *T0 = XShiftOpcode == Instruction::BinaryOps::LShr 3847 ? Builder.CreateLShr(X, NewShAmt) 3848 : Builder.CreateShl(X, NewShAmt); 3849 Value *T1 = Builder.CreateAnd(T0, Y); 3850 return Builder.CreateICmp(I.getPredicate(), T1, 3851 Constant::getNullValue(WidestTy)); 3852 } 3853 3854 /// Fold 3855 /// (-1 u/ x) u< y 3856 /// ((x * y) ?/ x) != y 3857 /// to 3858 /// @llvm.?mul.with.overflow(x, y) plus extraction of overflow bit 3859 /// Note that the comparison is commutative, while inverted (u>=, ==) predicate 3860 /// will mean that we are looking for the opposite answer. 3861 Value *InstCombinerImpl::foldMultiplicationOverflowCheck(ICmpInst &I) { 3862 ICmpInst::Predicate Pred; 3863 Value *X, *Y; 3864 Instruction *Mul; 3865 Instruction *Div; 3866 bool NeedNegation; 3867 // Look for: (-1 u/ x) u</u>= y 3868 if (!I.isEquality() && 3869 match(&I, m_c_ICmp(Pred, 3870 m_CombineAnd(m_OneUse(m_UDiv(m_AllOnes(), m_Value(X))), 3871 m_Instruction(Div)), 3872 m_Value(Y)))) { 3873 Mul = nullptr; 3874 3875 // Are we checking that overflow does not happen, or does happen? 3876 switch (Pred) { 3877 case ICmpInst::Predicate::ICMP_ULT: 3878 NeedNegation = false; 3879 break; // OK 3880 case ICmpInst::Predicate::ICMP_UGE: 3881 NeedNegation = true; 3882 break; // OK 3883 default: 3884 return nullptr; // Wrong predicate. 3885 } 3886 } else // Look for: ((x * y) / x) !=/== y 3887 if (I.isEquality() && 3888 match(&I, 3889 m_c_ICmp(Pred, m_Value(Y), 3890 m_CombineAnd( 3891 m_OneUse(m_IDiv(m_CombineAnd(m_c_Mul(m_Deferred(Y), 3892 m_Value(X)), 3893 m_Instruction(Mul)), 3894 m_Deferred(X))), 3895 m_Instruction(Div))))) { 3896 NeedNegation = Pred == ICmpInst::Predicate::ICMP_EQ; 3897 } else 3898 return nullptr; 3899 3900 BuilderTy::InsertPointGuard Guard(Builder); 3901 // If the pattern included (x * y), we'll want to insert new instructions 3902 // right before that original multiplication so that we can replace it. 3903 bool MulHadOtherUses = Mul && !Mul->hasOneUse(); 3904 if (MulHadOtherUses) 3905 Builder.SetInsertPoint(Mul); 3906 3907 Function *F = Intrinsic::getDeclaration(I.getModule(), 3908 Div->getOpcode() == Instruction::UDiv 3909 ? Intrinsic::umul_with_overflow 3910 : Intrinsic::smul_with_overflow, 3911 X->getType()); 3912 CallInst *Call = Builder.CreateCall(F, {X, Y}, "mul"); 3913 3914 // If the multiplication was used elsewhere, to ensure that we don't leave 3915 // "duplicate" instructions, replace uses of that original multiplication 3916 // with the multiplication result from the with.overflow intrinsic. 3917 if (MulHadOtherUses) 3918 replaceInstUsesWith(*Mul, Builder.CreateExtractValue(Call, 0, "mul.val")); 3919 3920 Value *Res = Builder.CreateExtractValue(Call, 1, "mul.ov"); 3921 if (NeedNegation) // This technically increases instruction count. 3922 Res = Builder.CreateNot(Res, "mul.not.ov"); 3923 3924 // If we replaced the mul, erase it. Do this after all uses of Builder, 3925 // as the mul is used as insertion point. 3926 if (MulHadOtherUses) 3927 eraseInstFromFunction(*Mul); 3928 3929 return Res; 3930 } 3931 3932 static Instruction *foldICmpXNegX(ICmpInst &I) { 3933 CmpInst::Predicate Pred; 3934 Value *X; 3935 if (!match(&I, m_c_ICmp(Pred, m_NSWNeg(m_Value(X)), m_Deferred(X)))) 3936 return nullptr; 3937 3938 if (ICmpInst::isSigned(Pred)) 3939 Pred = ICmpInst::getSwappedPredicate(Pred); 3940 else if (ICmpInst::isUnsigned(Pred)) 3941 Pred = ICmpInst::getSignedPredicate(Pred); 3942 // else for equality-comparisons just keep the predicate. 3943 3944 return ICmpInst::Create(Instruction::ICmp, Pred, X, 3945 Constant::getNullValue(X->getType()), I.getName()); 3946 } 3947 3948 /// Try to fold icmp (binop), X or icmp X, (binop). 3949 /// TODO: A large part of this logic is duplicated in InstSimplify's 3950 /// simplifyICmpWithBinOp(). We should be able to share that and avoid the code 3951 /// duplication. 3952 Instruction *InstCombinerImpl::foldICmpBinOp(ICmpInst &I, 3953 const SimplifyQuery &SQ) { 3954 const SimplifyQuery Q = SQ.getWithInstruction(&I); 3955 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 3956 3957 // Special logic for binary operators. 3958 BinaryOperator *BO0 = dyn_cast<BinaryOperator>(Op0); 3959 BinaryOperator *BO1 = dyn_cast<BinaryOperator>(Op1); 3960 if (!BO0 && !BO1) 3961 return nullptr; 3962 3963 if (Instruction *NewICmp = foldICmpXNegX(I)) 3964 return NewICmp; 3965 3966 const CmpInst::Predicate Pred = I.getPredicate(); 3967 Value *X; 3968 3969 // Convert add-with-unsigned-overflow comparisons into a 'not' with compare. 3970 // (Op1 + X) u</u>= Op1 --> ~Op1 u</u>= X 3971 if (match(Op0, m_OneUse(m_c_Add(m_Specific(Op1), m_Value(X)))) && 3972 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 3973 return new ICmpInst(Pred, Builder.CreateNot(Op1), X); 3974 // Op0 u>/u<= (Op0 + X) --> X u>/u<= ~Op0 3975 if (match(Op1, m_OneUse(m_c_Add(m_Specific(Op0), m_Value(X)))) && 3976 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 3977 return new ICmpInst(Pred, X, Builder.CreateNot(Op0)); 3978 3979 { 3980 // (Op1 + X) + C u</u>= Op1 --> ~C - X u</u>= Op1 3981 Constant *C; 3982 if (match(Op0, m_OneUse(m_Add(m_c_Add(m_Specific(Op1), m_Value(X)), 3983 m_ImmConstant(C)))) && 3984 (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) { 3985 Constant *C2 = ConstantExpr::getNot(C); 3986 return new ICmpInst(Pred, Builder.CreateSub(C2, X), Op1); 3987 } 3988 // Op0 u>/u<= (Op0 + X) + C --> Op0 u>/u<= ~C - X 3989 if (match(Op1, m_OneUse(m_Add(m_c_Add(m_Specific(Op0), m_Value(X)), 3990 m_ImmConstant(C)))) && 3991 (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) { 3992 Constant *C2 = ConstantExpr::getNot(C); 3993 return new ICmpInst(Pred, Op0, Builder.CreateSub(C2, X)); 3994 } 3995 } 3996 3997 { 3998 // Similar to above: an unsigned overflow comparison may use offset + mask: 3999 // ((Op1 + C) & C) u< Op1 --> Op1 != 0 4000 // ((Op1 + C) & C) u>= Op1 --> Op1 == 0 4001 // Op0 u> ((Op0 + C) & C) --> Op0 != 0 4002 // Op0 u<= ((Op0 + C) & C) --> Op0 == 0 4003 BinaryOperator *BO; 4004 const APInt *C; 4005 if ((Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE) && 4006 match(Op0, m_And(m_BinOp(BO), m_LowBitMask(C))) && 4007 match(BO, m_Add(m_Specific(Op1), m_SpecificIntAllowUndef(*C)))) { 4008 CmpInst::Predicate NewPred = 4009 Pred == ICmpInst::ICMP_ULT ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ; 4010 Constant *Zero = ConstantInt::getNullValue(Op1->getType()); 4011 return new ICmpInst(NewPred, Op1, Zero); 4012 } 4013 4014 if ((Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE) && 4015 match(Op1, m_And(m_BinOp(BO), m_LowBitMask(C))) && 4016 match(BO, m_Add(m_Specific(Op0), m_SpecificIntAllowUndef(*C)))) { 4017 CmpInst::Predicate NewPred = 4018 Pred == ICmpInst::ICMP_UGT ? ICmpInst::ICMP_NE : ICmpInst::ICMP_EQ; 4019 Constant *Zero = ConstantInt::getNullValue(Op1->getType()); 4020 return new ICmpInst(NewPred, Op0, Zero); 4021 } 4022 } 4023 4024 bool NoOp0WrapProblem = false, NoOp1WrapProblem = false; 4025 if (BO0 && isa<OverflowingBinaryOperator>(BO0)) 4026 NoOp0WrapProblem = 4027 ICmpInst::isEquality(Pred) || 4028 (CmpInst::isUnsigned(Pred) && BO0->hasNoUnsignedWrap()) || 4029 (CmpInst::isSigned(Pred) && BO0->hasNoSignedWrap()); 4030 if (BO1 && isa<OverflowingBinaryOperator>(BO1)) 4031 NoOp1WrapProblem = 4032 ICmpInst::isEquality(Pred) || 4033 (CmpInst::isUnsigned(Pred) && BO1->hasNoUnsignedWrap()) || 4034 (CmpInst::isSigned(Pred) && BO1->hasNoSignedWrap()); 4035 4036 // Analyze the case when either Op0 or Op1 is an add instruction. 4037 // Op0 = A + B (or A and B are null); Op1 = C + D (or C and D are null). 4038 Value *A = nullptr, *B = nullptr, *C = nullptr, *D = nullptr; 4039 if (BO0 && BO0->getOpcode() == Instruction::Add) { 4040 A = BO0->getOperand(0); 4041 B = BO0->getOperand(1); 4042 } 4043 if (BO1 && BO1->getOpcode() == Instruction::Add) { 4044 C = BO1->getOperand(0); 4045 D = BO1->getOperand(1); 4046 } 4047 4048 // icmp (A+B), A -> icmp B, 0 for equalities or if there is no overflow. 4049 // icmp (A+B), B -> icmp A, 0 for equalities or if there is no overflow. 4050 if ((A == Op1 || B == Op1) && NoOp0WrapProblem) 4051 return new ICmpInst(Pred, A == Op1 ? B : A, 4052 Constant::getNullValue(Op1->getType())); 4053 4054 // icmp C, (C+D) -> icmp 0, D for equalities or if there is no overflow. 4055 // icmp D, (C+D) -> icmp 0, C for equalities or if there is no overflow. 4056 if ((C == Op0 || D == Op0) && NoOp1WrapProblem) 4057 return new ICmpInst(Pred, Constant::getNullValue(Op0->getType()), 4058 C == Op0 ? D : C); 4059 4060 // icmp (A+B), (A+D) -> icmp B, D for equalities or if there is no overflow. 4061 if (A && C && (A == C || A == D || B == C || B == D) && NoOp0WrapProblem && 4062 NoOp1WrapProblem) { 4063 // Determine Y and Z in the form icmp (X+Y), (X+Z). 4064 Value *Y, *Z; 4065 if (A == C) { 4066 // C + B == C + D -> B == D 4067 Y = B; 4068 Z = D; 4069 } else if (A == D) { 4070 // D + B == C + D -> B == C 4071 Y = B; 4072 Z = C; 4073 } else if (B == C) { 4074 // A + C == C + D -> A == D 4075 Y = A; 4076 Z = D; 4077 } else { 4078 assert(B == D); 4079 // A + D == C + D -> A == C 4080 Y = A; 4081 Z = C; 4082 } 4083 return new ICmpInst(Pred, Y, Z); 4084 } 4085 4086 // icmp slt (A + -1), Op1 -> icmp sle A, Op1 4087 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLT && 4088 match(B, m_AllOnes())) 4089 return new ICmpInst(CmpInst::ICMP_SLE, A, Op1); 4090 4091 // icmp sge (A + -1), Op1 -> icmp sgt A, Op1 4092 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGE && 4093 match(B, m_AllOnes())) 4094 return new ICmpInst(CmpInst::ICMP_SGT, A, Op1); 4095 4096 // icmp sle (A + 1), Op1 -> icmp slt A, Op1 4097 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SLE && match(B, m_One())) 4098 return new ICmpInst(CmpInst::ICMP_SLT, A, Op1); 4099 4100 // icmp sgt (A + 1), Op1 -> icmp sge A, Op1 4101 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_SGT && match(B, m_One())) 4102 return new ICmpInst(CmpInst::ICMP_SGE, A, Op1); 4103 4104 // icmp sgt Op0, (C + -1) -> icmp sge Op0, C 4105 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGT && 4106 match(D, m_AllOnes())) 4107 return new ICmpInst(CmpInst::ICMP_SGE, Op0, C); 4108 4109 // icmp sle Op0, (C + -1) -> icmp slt Op0, C 4110 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLE && 4111 match(D, m_AllOnes())) 4112 return new ICmpInst(CmpInst::ICMP_SLT, Op0, C); 4113 4114 // icmp sge Op0, (C + 1) -> icmp sgt Op0, C 4115 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SGE && match(D, m_One())) 4116 return new ICmpInst(CmpInst::ICMP_SGT, Op0, C); 4117 4118 // icmp slt Op0, (C + 1) -> icmp sle Op0, C 4119 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_SLT && match(D, m_One())) 4120 return new ICmpInst(CmpInst::ICMP_SLE, Op0, C); 4121 4122 // TODO: The subtraction-related identities shown below also hold, but 4123 // canonicalization from (X -nuw 1) to (X + -1) means that the combinations 4124 // wouldn't happen even if they were implemented. 4125 // 4126 // icmp ult (A - 1), Op1 -> icmp ule A, Op1 4127 // icmp uge (A - 1), Op1 -> icmp ugt A, Op1 4128 // icmp ugt Op0, (C - 1) -> icmp uge Op0, C 4129 // icmp ule Op0, (C - 1) -> icmp ult Op0, C 4130 4131 // icmp ule (A + 1), Op0 -> icmp ult A, Op1 4132 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_ULE && match(B, m_One())) 4133 return new ICmpInst(CmpInst::ICMP_ULT, A, Op1); 4134 4135 // icmp ugt (A + 1), Op0 -> icmp uge A, Op1 4136 if (A && NoOp0WrapProblem && Pred == CmpInst::ICMP_UGT && match(B, m_One())) 4137 return new ICmpInst(CmpInst::ICMP_UGE, A, Op1); 4138 4139 // icmp uge Op0, (C + 1) -> icmp ugt Op0, C 4140 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_UGE && match(D, m_One())) 4141 return new ICmpInst(CmpInst::ICMP_UGT, Op0, C); 4142 4143 // icmp ult Op0, (C + 1) -> icmp ule Op0, C 4144 if (C && NoOp1WrapProblem && Pred == CmpInst::ICMP_ULT && match(D, m_One())) 4145 return new ICmpInst(CmpInst::ICMP_ULE, Op0, C); 4146 4147 // if C1 has greater magnitude than C2: 4148 // icmp (A + C1), (C + C2) -> icmp (A + C3), C 4149 // s.t. C3 = C1 - C2 4150 // 4151 // if C2 has greater magnitude than C1: 4152 // icmp (A + C1), (C + C2) -> icmp A, (C + C3) 4153 // s.t. C3 = C2 - C1 4154 if (A && C && NoOp0WrapProblem && NoOp1WrapProblem && 4155 (BO0->hasOneUse() || BO1->hasOneUse()) && !I.isUnsigned()) { 4156 const APInt *AP1, *AP2; 4157 // TODO: Support non-uniform vectors. 4158 // TODO: Allow undef passthrough if B AND D's element is undef. 4159 if (match(B, m_APIntAllowUndef(AP1)) && match(D, m_APIntAllowUndef(AP2)) && 4160 AP1->isNegative() == AP2->isNegative()) { 4161 APInt AP1Abs = AP1->abs(); 4162 APInt AP2Abs = AP2->abs(); 4163 if (AP1Abs.uge(AP2Abs)) { 4164 APInt Diff = *AP1 - *AP2; 4165 bool HasNUW = BO0->hasNoUnsignedWrap() && Diff.ule(*AP1); 4166 bool HasNSW = BO0->hasNoSignedWrap(); 4167 Constant *C3 = Constant::getIntegerValue(BO0->getType(), Diff); 4168 Value *NewAdd = Builder.CreateAdd(A, C3, "", HasNUW, HasNSW); 4169 return new ICmpInst(Pred, NewAdd, C); 4170 } else { 4171 APInt Diff = *AP2 - *AP1; 4172 bool HasNUW = BO1->hasNoUnsignedWrap() && Diff.ule(*AP2); 4173 bool HasNSW = BO1->hasNoSignedWrap(); 4174 Constant *C3 = Constant::getIntegerValue(BO0->getType(), Diff); 4175 Value *NewAdd = Builder.CreateAdd(C, C3, "", HasNUW, HasNSW); 4176 return new ICmpInst(Pred, A, NewAdd); 4177 } 4178 } 4179 Constant *Cst1, *Cst2; 4180 if (match(B, m_ImmConstant(Cst1)) && match(D, m_ImmConstant(Cst2)) && 4181 ICmpInst::isEquality(Pred)) { 4182 Constant *Diff = ConstantExpr::getSub(Cst2, Cst1); 4183 Value *NewAdd = Builder.CreateAdd(C, Diff); 4184 return new ICmpInst(Pred, A, NewAdd); 4185 } 4186 } 4187 4188 // Analyze the case when either Op0 or Op1 is a sub instruction. 4189 // Op0 = A - B (or A and B are null); Op1 = C - D (or C and D are null). 4190 A = nullptr; 4191 B = nullptr; 4192 C = nullptr; 4193 D = nullptr; 4194 if (BO0 && BO0->getOpcode() == Instruction::Sub) { 4195 A = BO0->getOperand(0); 4196 B = BO0->getOperand(1); 4197 } 4198 if (BO1 && BO1->getOpcode() == Instruction::Sub) { 4199 C = BO1->getOperand(0); 4200 D = BO1->getOperand(1); 4201 } 4202 4203 // icmp (A-B), A -> icmp 0, B for equalities or if there is no overflow. 4204 if (A == Op1 && NoOp0WrapProblem) 4205 return new ICmpInst(Pred, Constant::getNullValue(Op1->getType()), B); 4206 // icmp C, (C-D) -> icmp D, 0 for equalities or if there is no overflow. 4207 if (C == Op0 && NoOp1WrapProblem) 4208 return new ICmpInst(Pred, D, Constant::getNullValue(Op0->getType())); 4209 4210 // Convert sub-with-unsigned-overflow comparisons into a comparison of args. 4211 // (A - B) u>/u<= A --> B u>/u<= A 4212 if (A == Op1 && (Pred == ICmpInst::ICMP_UGT || Pred == ICmpInst::ICMP_ULE)) 4213 return new ICmpInst(Pred, B, A); 4214 // C u</u>= (C - D) --> C u</u>= D 4215 if (C == Op0 && (Pred == ICmpInst::ICMP_ULT || Pred == ICmpInst::ICMP_UGE)) 4216 return new ICmpInst(Pred, C, D); 4217 // (A - B) u>=/u< A --> B u>/u<= A iff B != 0 4218 if (A == Op1 && (Pred == ICmpInst::ICMP_UGE || Pred == ICmpInst::ICMP_ULT) && 4219 isKnownNonZero(B, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4220 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), B, A); 4221 // C u<=/u> (C - D) --> C u</u>= D iff B != 0 4222 if (C == Op0 && (Pred == ICmpInst::ICMP_ULE || Pred == ICmpInst::ICMP_UGT) && 4223 isKnownNonZero(D, Q.DL, /*Depth=*/0, Q.AC, Q.CxtI, Q.DT)) 4224 return new ICmpInst(CmpInst::getFlippedStrictnessPredicate(Pred), C, D); 4225 4226 // icmp (A-B), (C-B) -> icmp A, C for equalities or if there is no overflow. 4227 if (B && D && B == D && NoOp0WrapProblem && NoOp1WrapProblem) 4228 return new ICmpInst(Pred, A, C); 4229 4230 // icmp (A-B), (A-D) -> icmp D, B for equalities or if there is no overflow. 4231 if (A && C && A == C && NoOp0WrapProblem && NoOp1WrapProblem) 4232 return new ICmpInst(Pred, D, B); 4233 4234 // icmp (0-X) < cst --> x > -cst 4235 if (NoOp0WrapProblem && ICmpInst::isSigned(Pred)) { 4236 Value *X; 4237 if (match(BO0, m_Neg(m_Value(X)))) 4238 if (Constant *RHSC = dyn_cast<Constant>(Op1)) 4239 if (RHSC->isNotMinSignedValue()) 4240 return new ICmpInst(I.getSwappedPredicate(), X, 4241 ConstantExpr::getNeg(RHSC)); 4242 } 4243 4244 { 4245 // Try to remove shared constant multiplier from equality comparison: 4246 // X * C == Y * C (with no overflowing/aliasing) --> X == Y 4247 Value *X, *Y; 4248 const APInt *C; 4249 if (match(Op0, m_Mul(m_Value(X), m_APInt(C))) && *C != 0 && 4250 match(Op1, m_Mul(m_Value(Y), m_SpecificInt(*C))) && I.isEquality()) 4251 if (!C->countTrailingZeros() || 4252 (BO0 && BO1 && BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap()) || 4253 (BO0 && BO1 && BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap())) 4254 return new ICmpInst(Pred, X, Y); 4255 } 4256 4257 BinaryOperator *SRem = nullptr; 4258 // icmp (srem X, Y), Y 4259 if (BO0 && BO0->getOpcode() == Instruction::SRem && Op1 == BO0->getOperand(1)) 4260 SRem = BO0; 4261 // icmp Y, (srem X, Y) 4262 else if (BO1 && BO1->getOpcode() == Instruction::SRem && 4263 Op0 == BO1->getOperand(1)) 4264 SRem = BO1; 4265 if (SRem) { 4266 // We don't check hasOneUse to avoid increasing register pressure because 4267 // the value we use is the same value this instruction was already using. 4268 switch (SRem == BO0 ? ICmpInst::getSwappedPredicate(Pred) : Pred) { 4269 default: 4270 break; 4271 case ICmpInst::ICMP_EQ: 4272 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 4273 case ICmpInst::ICMP_NE: 4274 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 4275 case ICmpInst::ICMP_SGT: 4276 case ICmpInst::ICMP_SGE: 4277 return new ICmpInst(ICmpInst::ICMP_SGT, SRem->getOperand(1), 4278 Constant::getAllOnesValue(SRem->getType())); 4279 case ICmpInst::ICMP_SLT: 4280 case ICmpInst::ICMP_SLE: 4281 return new ICmpInst(ICmpInst::ICMP_SLT, SRem->getOperand(1), 4282 Constant::getNullValue(SRem->getType())); 4283 } 4284 } 4285 4286 if (BO0 && BO1 && BO0->getOpcode() == BO1->getOpcode() && BO0->hasOneUse() && 4287 BO1->hasOneUse() && BO0->getOperand(1) == BO1->getOperand(1)) { 4288 switch (BO0->getOpcode()) { 4289 default: 4290 break; 4291 case Instruction::Add: 4292 case Instruction::Sub: 4293 case Instruction::Xor: { 4294 if (I.isEquality()) // a+x icmp eq/ne b+x --> a icmp b 4295 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4296 4297 const APInt *C; 4298 if (match(BO0->getOperand(1), m_APInt(C))) { 4299 // icmp u/s (a ^ signmask), (b ^ signmask) --> icmp s/u a, b 4300 if (C->isSignMask()) { 4301 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4302 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4303 } 4304 4305 // icmp u/s (a ^ maxsignval), (b ^ maxsignval) --> icmp s/u' a, b 4306 if (BO0->getOpcode() == Instruction::Xor && C->isMaxSignedValue()) { 4307 ICmpInst::Predicate NewPred = I.getFlippedSignednessPredicate(); 4308 NewPred = I.getSwappedPredicate(NewPred); 4309 return new ICmpInst(NewPred, BO0->getOperand(0), BO1->getOperand(0)); 4310 } 4311 } 4312 break; 4313 } 4314 case Instruction::Mul: { 4315 if (!I.isEquality()) 4316 break; 4317 4318 const APInt *C; 4319 if (match(BO0->getOperand(1), m_APInt(C)) && !C->isZero() && 4320 !C->isOne()) { 4321 // icmp eq/ne (X * C), (Y * C) --> icmp (X & Mask), (Y & Mask) 4322 // Mask = -1 >> count-trailing-zeros(C). 4323 if (unsigned TZs = C->countTrailingZeros()) { 4324 Constant *Mask = ConstantInt::get( 4325 BO0->getType(), 4326 APInt::getLowBitsSet(C->getBitWidth(), C->getBitWidth() - TZs)); 4327 Value *And1 = Builder.CreateAnd(BO0->getOperand(0), Mask); 4328 Value *And2 = Builder.CreateAnd(BO1->getOperand(0), Mask); 4329 return new ICmpInst(Pred, And1, And2); 4330 } 4331 } 4332 break; 4333 } 4334 case Instruction::UDiv: 4335 case Instruction::LShr: 4336 if (I.isSigned() || !BO0->isExact() || !BO1->isExact()) 4337 break; 4338 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4339 4340 case Instruction::SDiv: 4341 if (!I.isEquality() || !BO0->isExact() || !BO1->isExact()) 4342 break; 4343 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4344 4345 case Instruction::AShr: 4346 if (!BO0->isExact() || !BO1->isExact()) 4347 break; 4348 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4349 4350 case Instruction::Shl: { 4351 bool NUW = BO0->hasNoUnsignedWrap() && BO1->hasNoUnsignedWrap(); 4352 bool NSW = BO0->hasNoSignedWrap() && BO1->hasNoSignedWrap(); 4353 if (!NUW && !NSW) 4354 break; 4355 if (!NSW && I.isSigned()) 4356 break; 4357 return new ICmpInst(Pred, BO0->getOperand(0), BO1->getOperand(0)); 4358 } 4359 } 4360 } 4361 4362 if (BO0) { 4363 // Transform A & (L - 1) `ult` L --> L != 0 4364 auto LSubOne = m_Add(m_Specific(Op1), m_AllOnes()); 4365 auto BitwiseAnd = m_c_And(m_Value(), LSubOne); 4366 4367 if (match(BO0, BitwiseAnd) && Pred == ICmpInst::ICMP_ULT) { 4368 auto *Zero = Constant::getNullValue(BO0->getType()); 4369 return new ICmpInst(ICmpInst::ICMP_NE, Op1, Zero); 4370 } 4371 } 4372 4373 if (Value *V = foldMultiplicationOverflowCheck(I)) 4374 return replaceInstUsesWith(I, V); 4375 4376 if (Value *V = foldICmpWithLowBitMaskedVal(I, Builder)) 4377 return replaceInstUsesWith(I, V); 4378 4379 if (Value *V = foldICmpWithTruncSignExtendedVal(I, Builder)) 4380 return replaceInstUsesWith(I, V); 4381 4382 if (Value *V = foldShiftIntoShiftInAnotherHandOfAndInICmp(I, SQ, Builder)) 4383 return replaceInstUsesWith(I, V); 4384 4385 return nullptr; 4386 } 4387 4388 /// Fold icmp Pred min|max(X, Y), X. 4389 static Instruction *foldICmpWithMinMax(ICmpInst &Cmp) { 4390 ICmpInst::Predicate Pred = Cmp.getPredicate(); 4391 Value *Op0 = Cmp.getOperand(0); 4392 Value *X = Cmp.getOperand(1); 4393 4394 // Canonicalize minimum or maximum operand to LHS of the icmp. 4395 if (match(X, m_c_SMin(m_Specific(Op0), m_Value())) || 4396 match(X, m_c_SMax(m_Specific(Op0), m_Value())) || 4397 match(X, m_c_UMin(m_Specific(Op0), m_Value())) || 4398 match(X, m_c_UMax(m_Specific(Op0), m_Value()))) { 4399 std::swap(Op0, X); 4400 Pred = Cmp.getSwappedPredicate(); 4401 } 4402 4403 Value *Y; 4404 if (match(Op0, m_c_SMin(m_Specific(X), m_Value(Y)))) { 4405 // smin(X, Y) == X --> X s<= Y 4406 // smin(X, Y) s>= X --> X s<= Y 4407 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SGE) 4408 return new ICmpInst(ICmpInst::ICMP_SLE, X, Y); 4409 4410 // smin(X, Y) != X --> X s> Y 4411 // smin(X, Y) s< X --> X s> Y 4412 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SLT) 4413 return new ICmpInst(ICmpInst::ICMP_SGT, X, Y); 4414 4415 // These cases should be handled in InstSimplify: 4416 // smin(X, Y) s<= X --> true 4417 // smin(X, Y) s> X --> false 4418 return nullptr; 4419 } 4420 4421 if (match(Op0, m_c_SMax(m_Specific(X), m_Value(Y)))) { 4422 // smax(X, Y) == X --> X s>= Y 4423 // smax(X, Y) s<= X --> X s>= Y 4424 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_SLE) 4425 return new ICmpInst(ICmpInst::ICMP_SGE, X, Y); 4426 4427 // smax(X, Y) != X --> X s< Y 4428 // smax(X, Y) s> X --> X s< Y 4429 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_SGT) 4430 return new ICmpInst(ICmpInst::ICMP_SLT, X, Y); 4431 4432 // These cases should be handled in InstSimplify: 4433 // smax(X, Y) s>= X --> true 4434 // smax(X, Y) s< X --> false 4435 return nullptr; 4436 } 4437 4438 if (match(Op0, m_c_UMin(m_Specific(X), m_Value(Y)))) { 4439 // umin(X, Y) == X --> X u<= Y 4440 // umin(X, Y) u>= X --> X u<= Y 4441 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_UGE) 4442 return new ICmpInst(ICmpInst::ICMP_ULE, X, Y); 4443 4444 // umin(X, Y) != X --> X u> Y 4445 // umin(X, Y) u< X --> X u> Y 4446 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_ULT) 4447 return new ICmpInst(ICmpInst::ICMP_UGT, X, Y); 4448 4449 // These cases should be handled in InstSimplify: 4450 // umin(X, Y) u<= X --> true 4451 // umin(X, Y) u> X --> false 4452 return nullptr; 4453 } 4454 4455 if (match(Op0, m_c_UMax(m_Specific(X), m_Value(Y)))) { 4456 // umax(X, Y) == X --> X u>= Y 4457 // umax(X, Y) u<= X --> X u>= Y 4458 if (Pred == CmpInst::ICMP_EQ || Pred == CmpInst::ICMP_ULE) 4459 return new ICmpInst(ICmpInst::ICMP_UGE, X, Y); 4460 4461 // umax(X, Y) != X --> X u< Y 4462 // umax(X, Y) u> X --> X u< Y 4463 if (Pred == CmpInst::ICMP_NE || Pred == CmpInst::ICMP_UGT) 4464 return new ICmpInst(ICmpInst::ICMP_ULT, X, Y); 4465 4466 // These cases should be handled in InstSimplify: 4467 // umax(X, Y) u>= X --> true 4468 // umax(X, Y) u< X --> false 4469 return nullptr; 4470 } 4471 4472 return nullptr; 4473 } 4474 4475 Instruction *InstCombinerImpl::foldICmpEquality(ICmpInst &I) { 4476 if (!I.isEquality()) 4477 return nullptr; 4478 4479 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 4480 const CmpInst::Predicate Pred = I.getPredicate(); 4481 Value *A, *B, *C, *D; 4482 if (match(Op0, m_Xor(m_Value(A), m_Value(B)))) { 4483 if (A == Op1 || B == Op1) { // (A^B) == A -> B == 0 4484 Value *OtherVal = A == Op1 ? B : A; 4485 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4486 } 4487 4488 if (match(Op1, m_Xor(m_Value(C), m_Value(D)))) { 4489 // A^c1 == C^c2 --> A == C^(c1^c2) 4490 ConstantInt *C1, *C2; 4491 if (match(B, m_ConstantInt(C1)) && match(D, m_ConstantInt(C2)) && 4492 Op1->hasOneUse()) { 4493 Constant *NC = Builder.getInt(C1->getValue() ^ C2->getValue()); 4494 Value *Xor = Builder.CreateXor(C, NC); 4495 return new ICmpInst(Pred, A, Xor); 4496 } 4497 4498 // A^B == A^D -> B == D 4499 if (A == C) 4500 return new ICmpInst(Pred, B, D); 4501 if (A == D) 4502 return new ICmpInst(Pred, B, C); 4503 if (B == C) 4504 return new ICmpInst(Pred, A, D); 4505 if (B == D) 4506 return new ICmpInst(Pred, A, C); 4507 } 4508 } 4509 4510 if (match(Op1, m_Xor(m_Value(A), m_Value(B))) && (A == Op0 || B == Op0)) { 4511 // A == (A^B) -> B == 0 4512 Value *OtherVal = A == Op0 ? B : A; 4513 return new ICmpInst(Pred, OtherVal, Constant::getNullValue(A->getType())); 4514 } 4515 4516 // (X&Z) == (Y&Z) -> (X^Y) & Z == 0 4517 if (match(Op0, m_OneUse(m_And(m_Value(A), m_Value(B)))) && 4518 match(Op1, m_OneUse(m_And(m_Value(C), m_Value(D))))) { 4519 Value *X = nullptr, *Y = nullptr, *Z = nullptr; 4520 4521 if (A == C) { 4522 X = B; 4523 Y = D; 4524 Z = A; 4525 } else if (A == D) { 4526 X = B; 4527 Y = C; 4528 Z = A; 4529 } else if (B == C) { 4530 X = A; 4531 Y = D; 4532 Z = B; 4533 } else if (B == D) { 4534 X = A; 4535 Y = C; 4536 Z = B; 4537 } 4538 4539 if (X) { // Build (X^Y) & Z 4540 Op1 = Builder.CreateXor(X, Y); 4541 Op1 = Builder.CreateAnd(Op1, Z); 4542 return new ICmpInst(Pred, Op1, Constant::getNullValue(Op1->getType())); 4543 } 4544 } 4545 4546 { 4547 // Similar to above, but specialized for constant because invert is needed: 4548 // (X | C) == (Y | C) --> (X ^ Y) & ~C == 0 4549 Value *X, *Y; 4550 Constant *C; 4551 if (match(Op0, m_OneUse(m_Or(m_Value(X), m_Constant(C)))) && 4552 match(Op1, m_OneUse(m_Or(m_Value(Y), m_Specific(C))))) { 4553 Value *Xor = Builder.CreateXor(X, Y); 4554 Value *And = Builder.CreateAnd(Xor, ConstantExpr::getNot(C)); 4555 return new ICmpInst(Pred, And, Constant::getNullValue(And->getType())); 4556 } 4557 } 4558 4559 // Transform (zext A) == (B & (1<<X)-1) --> A == (trunc B) 4560 // and (B & (1<<X)-1) == (zext A) --> A == (trunc B) 4561 ConstantInt *Cst1; 4562 if ((Op0->hasOneUse() && match(Op0, m_ZExt(m_Value(A))) && 4563 match(Op1, m_And(m_Value(B), m_ConstantInt(Cst1)))) || 4564 (Op1->hasOneUse() && match(Op0, m_And(m_Value(B), m_ConstantInt(Cst1))) && 4565 match(Op1, m_ZExt(m_Value(A))))) { 4566 APInt Pow2 = Cst1->getValue() + 1; 4567 if (Pow2.isPowerOf2() && isa<IntegerType>(A->getType()) && 4568 Pow2.logBase2() == cast<IntegerType>(A->getType())->getBitWidth()) 4569 return new ICmpInst(Pred, A, Builder.CreateTrunc(B, A->getType())); 4570 } 4571 4572 // (A >> C) == (B >> C) --> (A^B) u< (1 << C) 4573 // For lshr and ashr pairs. 4574 if ((match(Op0, m_OneUse(m_LShr(m_Value(A), m_ConstantInt(Cst1)))) && 4575 match(Op1, m_OneUse(m_LShr(m_Value(B), m_Specific(Cst1))))) || 4576 (match(Op0, m_OneUse(m_AShr(m_Value(A), m_ConstantInt(Cst1)))) && 4577 match(Op1, m_OneUse(m_AShr(m_Value(B), m_Specific(Cst1)))))) { 4578 unsigned TypeBits = Cst1->getBitWidth(); 4579 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4580 if (ShAmt < TypeBits && ShAmt != 0) { 4581 ICmpInst::Predicate NewPred = 4582 Pred == ICmpInst::ICMP_NE ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_ULT; 4583 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4584 APInt CmpVal = APInt::getOneBitSet(TypeBits, ShAmt); 4585 return new ICmpInst(NewPred, Xor, Builder.getInt(CmpVal)); 4586 } 4587 } 4588 4589 // (A << C) == (B << C) --> ((A^B) & (~0U >> C)) == 0 4590 if (match(Op0, m_OneUse(m_Shl(m_Value(A), m_ConstantInt(Cst1)))) && 4591 match(Op1, m_OneUse(m_Shl(m_Value(B), m_Specific(Cst1))))) { 4592 unsigned TypeBits = Cst1->getBitWidth(); 4593 unsigned ShAmt = (unsigned)Cst1->getLimitedValue(TypeBits); 4594 if (ShAmt < TypeBits && ShAmt != 0) { 4595 Value *Xor = Builder.CreateXor(A, B, I.getName() + ".unshifted"); 4596 APInt AndVal = APInt::getLowBitsSet(TypeBits, TypeBits - ShAmt); 4597 Value *And = Builder.CreateAnd(Xor, Builder.getInt(AndVal), 4598 I.getName() + ".mask"); 4599 return new ICmpInst(Pred, And, Constant::getNullValue(Cst1->getType())); 4600 } 4601 } 4602 4603 // Transform "icmp eq (trunc (lshr(X, cst1)), cst" to 4604 // "icmp (and X, mask), cst" 4605 uint64_t ShAmt = 0; 4606 if (Op0->hasOneUse() && 4607 match(Op0, m_Trunc(m_OneUse(m_LShr(m_Value(A), m_ConstantInt(ShAmt))))) && 4608 match(Op1, m_ConstantInt(Cst1)) && 4609 // Only do this when A has multiple uses. This is most important to do 4610 // when it exposes other optimizations. 4611 !A->hasOneUse()) { 4612 unsigned ASize = cast<IntegerType>(A->getType())->getPrimitiveSizeInBits(); 4613 4614 if (ShAmt < ASize) { 4615 APInt MaskV = 4616 APInt::getLowBitsSet(ASize, Op0->getType()->getPrimitiveSizeInBits()); 4617 MaskV <<= ShAmt; 4618 4619 APInt CmpV = Cst1->getValue().zext(ASize); 4620 CmpV <<= ShAmt; 4621 4622 Value *Mask = Builder.CreateAnd(A, Builder.getInt(MaskV)); 4623 return new ICmpInst(Pred, Mask, Builder.getInt(CmpV)); 4624 } 4625 } 4626 4627 if (Instruction *ICmp = foldICmpIntrinsicWithIntrinsic(I)) 4628 return ICmp; 4629 4630 // Canonicalize checking for a power-of-2-or-zero value: 4631 // (A & (A-1)) == 0 --> ctpop(A) < 2 (two commuted variants) 4632 // ((A-1) & A) != 0 --> ctpop(A) > 1 (two commuted variants) 4633 if (!match(Op0, m_OneUse(m_c_And(m_Add(m_Value(A), m_AllOnes()), 4634 m_Deferred(A)))) || 4635 !match(Op1, m_ZeroInt())) 4636 A = nullptr; 4637 4638 // (A & -A) == A --> ctpop(A) < 2 (four commuted variants) 4639 // (-A & A) != A --> ctpop(A) > 1 (four commuted variants) 4640 if (match(Op0, m_OneUse(m_c_And(m_Neg(m_Specific(Op1)), m_Specific(Op1))))) 4641 A = Op1; 4642 else if (match(Op1, 4643 m_OneUse(m_c_And(m_Neg(m_Specific(Op0)), m_Specific(Op0))))) 4644 A = Op0; 4645 4646 if (A) { 4647 Type *Ty = A->getType(); 4648 CallInst *CtPop = Builder.CreateUnaryIntrinsic(Intrinsic::ctpop, A); 4649 return Pred == ICmpInst::ICMP_EQ 4650 ? new ICmpInst(ICmpInst::ICMP_ULT, CtPop, ConstantInt::get(Ty, 2)) 4651 : new ICmpInst(ICmpInst::ICMP_UGT, CtPop, ConstantInt::get(Ty, 1)); 4652 } 4653 4654 // Match icmp eq (trunc (lshr A, BW), (ashr (trunc A), BW-1)), which checks the 4655 // top BW/2 + 1 bits are all the same. Create "A >=s INT_MIN && A <=s INT_MAX", 4656 // which we generate as "icmp ult (add A, 2^(BW-1)), 2^BW" to skip a few steps 4657 // of instcombine. 4658 unsigned BitWidth = Op0->getType()->getScalarSizeInBits(); 4659 if (match(Op0, m_AShr(m_Trunc(m_Value(A)), m_SpecificInt(BitWidth - 1))) && 4660 match(Op1, m_Trunc(m_LShr(m_Specific(A), m_SpecificInt(BitWidth)))) && 4661 A->getType()->getScalarSizeInBits() == BitWidth * 2 && 4662 (I.getOperand(0)->hasOneUse() || I.getOperand(1)->hasOneUse())) { 4663 APInt C = APInt::getOneBitSet(BitWidth * 2, BitWidth - 1); 4664 Value *Add = Builder.CreateAdd(A, ConstantInt::get(A->getType(), C)); 4665 return new ICmpInst(Pred == ICmpInst::ICMP_EQ ? ICmpInst::ICMP_ULT 4666 : ICmpInst::ICMP_UGE, 4667 Add, ConstantInt::get(A->getType(), C.shl(1))); 4668 } 4669 4670 return nullptr; 4671 } 4672 4673 static Instruction *foldICmpWithTrunc(ICmpInst &ICmp, 4674 InstCombiner::BuilderTy &Builder) { 4675 ICmpInst::Predicate Pred = ICmp.getPredicate(); 4676 Value *Op0 = ICmp.getOperand(0), *Op1 = ICmp.getOperand(1); 4677 4678 // Try to canonicalize trunc + compare-to-constant into a mask + cmp. 4679 // The trunc masks high bits while the compare may effectively mask low bits. 4680 Value *X; 4681 const APInt *C; 4682 if (!match(Op0, m_OneUse(m_Trunc(m_Value(X)))) || !match(Op1, m_APInt(C))) 4683 return nullptr; 4684 4685 // This matches patterns corresponding to tests of the signbit as well as: 4686 // (trunc X) u< C --> (X & -C) == 0 (are all masked-high-bits clear?) 4687 // (trunc X) u> C --> (X & ~C) != 0 (are any masked-high-bits set?) 4688 APInt Mask; 4689 if (decomposeBitTestICmp(Op0, Op1, Pred, X, Mask, true /* WithTrunc */)) { 4690 Value *And = Builder.CreateAnd(X, Mask); 4691 Constant *Zero = ConstantInt::getNullValue(X->getType()); 4692 return new ICmpInst(Pred, And, Zero); 4693 } 4694 4695 unsigned SrcBits = X->getType()->getScalarSizeInBits(); 4696 if (Pred == ICmpInst::ICMP_ULT && C->isNegatedPowerOf2()) { 4697 // If C is a negative power-of-2 (high-bit mask): 4698 // (trunc X) u< C --> (X & C) != C (are any masked-high-bits clear?) 4699 Constant *MaskC = ConstantInt::get(X->getType(), C->zext(SrcBits)); 4700 Value *And = Builder.CreateAnd(X, MaskC); 4701 return new ICmpInst(ICmpInst::ICMP_NE, And, MaskC); 4702 } 4703 4704 if (Pred == ICmpInst::ICMP_UGT && (~*C).isPowerOf2()) { 4705 // If C is not-of-power-of-2 (one clear bit): 4706 // (trunc X) u> C --> (X & (C+1)) == C+1 (are all masked-high-bits set?) 4707 Constant *MaskC = ConstantInt::get(X->getType(), (*C + 1).zext(SrcBits)); 4708 Value *And = Builder.CreateAnd(X, MaskC); 4709 return new ICmpInst(ICmpInst::ICMP_EQ, And, MaskC); 4710 } 4711 4712 return nullptr; 4713 } 4714 4715 Instruction *InstCombinerImpl::foldICmpWithZextOrSext(ICmpInst &ICmp) { 4716 assert(isa<CastInst>(ICmp.getOperand(0)) && "Expected cast for operand 0"); 4717 auto *CastOp0 = cast<CastInst>(ICmp.getOperand(0)); 4718 Value *X; 4719 if (!match(CastOp0, m_ZExtOrSExt(m_Value(X)))) 4720 return nullptr; 4721 4722 bool IsSignedExt = CastOp0->getOpcode() == Instruction::SExt; 4723 bool IsSignedCmp = ICmp.isSigned(); 4724 4725 // icmp Pred (ext X), (ext Y) 4726 Value *Y; 4727 if (match(ICmp.getOperand(1), m_ZExtOrSExt(m_Value(Y)))) { 4728 bool IsZext0 = isa<ZExtOperator>(ICmp.getOperand(0)); 4729 bool IsZext1 = isa<ZExtOperator>(ICmp.getOperand(1)); 4730 4731 // If we have mismatched casts, treat the zext of a non-negative source as 4732 // a sext to simulate matching casts. Otherwise, we are done. 4733 // TODO: Can we handle some predicates (equality) without non-negative? 4734 if (IsZext0 != IsZext1) { 4735 if ((IsZext0 && isKnownNonNegative(X, DL, 0, &AC, &ICmp, &DT)) || 4736 (IsZext1 && isKnownNonNegative(Y, DL, 0, &AC, &ICmp, &DT))) 4737 IsSignedExt = true; 4738 else 4739 return nullptr; 4740 } 4741 4742 // Not an extension from the same type? 4743 Type *XTy = X->getType(), *YTy = Y->getType(); 4744 if (XTy != YTy) { 4745 // One of the casts must have one use because we are creating a new cast. 4746 if (!ICmp.getOperand(0)->hasOneUse() && !ICmp.getOperand(1)->hasOneUse()) 4747 return nullptr; 4748 // Extend the narrower operand to the type of the wider operand. 4749 CastInst::CastOps CastOpcode = 4750 IsSignedExt ? Instruction::SExt : Instruction::ZExt; 4751 if (XTy->getScalarSizeInBits() < YTy->getScalarSizeInBits()) 4752 X = Builder.CreateCast(CastOpcode, X, YTy); 4753 else if (YTy->getScalarSizeInBits() < XTy->getScalarSizeInBits()) 4754 Y = Builder.CreateCast(CastOpcode, Y, XTy); 4755 else 4756 return nullptr; 4757 } 4758 4759 // (zext X) == (zext Y) --> X == Y 4760 // (sext X) == (sext Y) --> X == Y 4761 if (ICmp.isEquality()) 4762 return new ICmpInst(ICmp.getPredicate(), X, Y); 4763 4764 // A signed comparison of sign extended values simplifies into a 4765 // signed comparison. 4766 if (IsSignedCmp && IsSignedExt) 4767 return new ICmpInst(ICmp.getPredicate(), X, Y); 4768 4769 // The other three cases all fold into an unsigned comparison. 4770 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Y); 4771 } 4772 4773 // Below here, we are only folding a compare with constant. 4774 auto *C = dyn_cast<Constant>(ICmp.getOperand(1)); 4775 if (!C) 4776 return nullptr; 4777 4778 // Compute the constant that would happen if we truncated to SrcTy then 4779 // re-extended to DestTy. 4780 Type *SrcTy = CastOp0->getSrcTy(); 4781 Type *DestTy = CastOp0->getDestTy(); 4782 Constant *Res1 = ConstantExpr::getTrunc(C, SrcTy); 4783 Constant *Res2 = ConstantExpr::getCast(CastOp0->getOpcode(), Res1, DestTy); 4784 4785 // If the re-extended constant didn't change... 4786 if (Res2 == C) { 4787 if (ICmp.isEquality()) 4788 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4789 4790 // A signed comparison of sign extended values simplifies into a 4791 // signed comparison. 4792 if (IsSignedExt && IsSignedCmp) 4793 return new ICmpInst(ICmp.getPredicate(), X, Res1); 4794 4795 // The other three cases all fold into an unsigned comparison. 4796 return new ICmpInst(ICmp.getUnsignedPredicate(), X, Res1); 4797 } 4798 4799 // The re-extended constant changed, partly changed (in the case of a vector), 4800 // or could not be determined to be equal (in the case of a constant 4801 // expression), so the constant cannot be represented in the shorter type. 4802 // All the cases that fold to true or false will have already been handled 4803 // by SimplifyICmpInst, so only deal with the tricky case. 4804 if (IsSignedCmp || !IsSignedExt || !isa<ConstantInt>(C)) 4805 return nullptr; 4806 4807 // Is source op positive? 4808 // icmp ult (sext X), C --> icmp sgt X, -1 4809 if (ICmp.getPredicate() == ICmpInst::ICMP_ULT) 4810 return new ICmpInst(CmpInst::ICMP_SGT, X, Constant::getAllOnesValue(SrcTy)); 4811 4812 // Is source op negative? 4813 // icmp ugt (sext X), C --> icmp slt X, 0 4814 assert(ICmp.getPredicate() == ICmpInst::ICMP_UGT && "ICmp should be folded!"); 4815 return new ICmpInst(CmpInst::ICMP_SLT, X, Constant::getNullValue(SrcTy)); 4816 } 4817 4818 /// Handle icmp (cast x), (cast or constant). 4819 Instruction *InstCombinerImpl::foldICmpWithCastOp(ICmpInst &ICmp) { 4820 // If any operand of ICmp is a inttoptr roundtrip cast then remove it as 4821 // icmp compares only pointer's value. 4822 // icmp (inttoptr (ptrtoint p1)), p2 --> icmp p1, p2. 4823 Value *SimplifiedOp0 = simplifyIntToPtrRoundTripCast(ICmp.getOperand(0)); 4824 Value *SimplifiedOp1 = simplifyIntToPtrRoundTripCast(ICmp.getOperand(1)); 4825 if (SimplifiedOp0 || SimplifiedOp1) 4826 return new ICmpInst(ICmp.getPredicate(), 4827 SimplifiedOp0 ? SimplifiedOp0 : ICmp.getOperand(0), 4828 SimplifiedOp1 ? SimplifiedOp1 : ICmp.getOperand(1)); 4829 4830 auto *CastOp0 = dyn_cast<CastInst>(ICmp.getOperand(0)); 4831 if (!CastOp0) 4832 return nullptr; 4833 if (!isa<Constant>(ICmp.getOperand(1)) && !isa<CastInst>(ICmp.getOperand(1))) 4834 return nullptr; 4835 4836 Value *Op0Src = CastOp0->getOperand(0); 4837 Type *SrcTy = CastOp0->getSrcTy(); 4838 Type *DestTy = CastOp0->getDestTy(); 4839 4840 // Turn icmp (ptrtoint x), (ptrtoint/c) into a compare of the input if the 4841 // integer type is the same size as the pointer type. 4842 auto CompatibleSizes = [&](Type *SrcTy, Type *DestTy) { 4843 if (isa<VectorType>(SrcTy)) { 4844 SrcTy = cast<VectorType>(SrcTy)->getElementType(); 4845 DestTy = cast<VectorType>(DestTy)->getElementType(); 4846 } 4847 return DL.getPointerTypeSizeInBits(SrcTy) == DestTy->getIntegerBitWidth(); 4848 }; 4849 if (CastOp0->getOpcode() == Instruction::PtrToInt && 4850 CompatibleSizes(SrcTy, DestTy)) { 4851 Value *NewOp1 = nullptr; 4852 if (auto *PtrToIntOp1 = dyn_cast<PtrToIntOperator>(ICmp.getOperand(1))) { 4853 Value *PtrSrc = PtrToIntOp1->getOperand(0); 4854 if (PtrSrc->getType()->getPointerAddressSpace() == 4855 Op0Src->getType()->getPointerAddressSpace()) { 4856 NewOp1 = PtrToIntOp1->getOperand(0); 4857 // If the pointer types don't match, insert a bitcast. 4858 if (Op0Src->getType() != NewOp1->getType()) 4859 NewOp1 = Builder.CreateBitCast(NewOp1, Op0Src->getType()); 4860 } 4861 } else if (auto *RHSC = dyn_cast<Constant>(ICmp.getOperand(1))) { 4862 NewOp1 = ConstantExpr::getIntToPtr(RHSC, SrcTy); 4863 } 4864 4865 if (NewOp1) 4866 return new ICmpInst(ICmp.getPredicate(), Op0Src, NewOp1); 4867 } 4868 4869 if (Instruction *R = foldICmpWithTrunc(ICmp, Builder)) 4870 return R; 4871 4872 return foldICmpWithZextOrSext(ICmp); 4873 } 4874 4875 static bool isNeutralValue(Instruction::BinaryOps BinaryOp, Value *RHS) { 4876 switch (BinaryOp) { 4877 default: 4878 llvm_unreachable("Unsupported binary op"); 4879 case Instruction::Add: 4880 case Instruction::Sub: 4881 return match(RHS, m_Zero()); 4882 case Instruction::Mul: 4883 return match(RHS, m_One()); 4884 } 4885 } 4886 4887 OverflowResult 4888 InstCombinerImpl::computeOverflow(Instruction::BinaryOps BinaryOp, 4889 bool IsSigned, Value *LHS, Value *RHS, 4890 Instruction *CxtI) const { 4891 switch (BinaryOp) { 4892 default: 4893 llvm_unreachable("Unsupported binary op"); 4894 case Instruction::Add: 4895 if (IsSigned) 4896 return computeOverflowForSignedAdd(LHS, RHS, CxtI); 4897 else 4898 return computeOverflowForUnsignedAdd(LHS, RHS, CxtI); 4899 case Instruction::Sub: 4900 if (IsSigned) 4901 return computeOverflowForSignedSub(LHS, RHS, CxtI); 4902 else 4903 return computeOverflowForUnsignedSub(LHS, RHS, CxtI); 4904 case Instruction::Mul: 4905 if (IsSigned) 4906 return computeOverflowForSignedMul(LHS, RHS, CxtI); 4907 else 4908 return computeOverflowForUnsignedMul(LHS, RHS, CxtI); 4909 } 4910 } 4911 4912 bool InstCombinerImpl::OptimizeOverflowCheck(Instruction::BinaryOps BinaryOp, 4913 bool IsSigned, Value *LHS, 4914 Value *RHS, Instruction &OrigI, 4915 Value *&Result, 4916 Constant *&Overflow) { 4917 if (OrigI.isCommutative() && isa<Constant>(LHS) && !isa<Constant>(RHS)) 4918 std::swap(LHS, RHS); 4919 4920 // If the overflow check was an add followed by a compare, the insertion point 4921 // may be pointing to the compare. We want to insert the new instructions 4922 // before the add in case there are uses of the add between the add and the 4923 // compare. 4924 Builder.SetInsertPoint(&OrigI); 4925 4926 Type *OverflowTy = Type::getInt1Ty(LHS->getContext()); 4927 if (auto *LHSTy = dyn_cast<VectorType>(LHS->getType())) 4928 OverflowTy = VectorType::get(OverflowTy, LHSTy->getElementCount()); 4929 4930 if (isNeutralValue(BinaryOp, RHS)) { 4931 Result = LHS; 4932 Overflow = ConstantInt::getFalse(OverflowTy); 4933 return true; 4934 } 4935 4936 switch (computeOverflow(BinaryOp, IsSigned, LHS, RHS, &OrigI)) { 4937 case OverflowResult::MayOverflow: 4938 return false; 4939 case OverflowResult::AlwaysOverflowsLow: 4940 case OverflowResult::AlwaysOverflowsHigh: 4941 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4942 Result->takeName(&OrigI); 4943 Overflow = ConstantInt::getTrue(OverflowTy); 4944 return true; 4945 case OverflowResult::NeverOverflows: 4946 Result = Builder.CreateBinOp(BinaryOp, LHS, RHS); 4947 Result->takeName(&OrigI); 4948 Overflow = ConstantInt::getFalse(OverflowTy); 4949 if (auto *Inst = dyn_cast<Instruction>(Result)) { 4950 if (IsSigned) 4951 Inst->setHasNoSignedWrap(); 4952 else 4953 Inst->setHasNoUnsignedWrap(); 4954 } 4955 return true; 4956 } 4957 4958 llvm_unreachable("Unexpected overflow result"); 4959 } 4960 4961 /// Recognize and process idiom involving test for multiplication 4962 /// overflow. 4963 /// 4964 /// The caller has matched a pattern of the form: 4965 /// I = cmp u (mul(zext A, zext B), V 4966 /// The function checks if this is a test for overflow and if so replaces 4967 /// multiplication with call to 'mul.with.overflow' intrinsic. 4968 /// 4969 /// \param I Compare instruction. 4970 /// \param MulVal Result of 'mult' instruction. It is one of the arguments of 4971 /// the compare instruction. Must be of integer type. 4972 /// \param OtherVal The other argument of compare instruction. 4973 /// \returns Instruction which must replace the compare instruction, NULL if no 4974 /// replacement required. 4975 static Instruction *processUMulZExtIdiom(ICmpInst &I, Value *MulVal, 4976 Value *OtherVal, 4977 InstCombinerImpl &IC) { 4978 // Don't bother doing this transformation for pointers, don't do it for 4979 // vectors. 4980 if (!isa<IntegerType>(MulVal->getType())) 4981 return nullptr; 4982 4983 assert(I.getOperand(0) == MulVal || I.getOperand(1) == MulVal); 4984 assert(I.getOperand(0) == OtherVal || I.getOperand(1) == OtherVal); 4985 auto *MulInstr = dyn_cast<Instruction>(MulVal); 4986 if (!MulInstr) 4987 return nullptr; 4988 assert(MulInstr->getOpcode() == Instruction::Mul); 4989 4990 auto *LHS = cast<ZExtOperator>(MulInstr->getOperand(0)), 4991 *RHS = cast<ZExtOperator>(MulInstr->getOperand(1)); 4992 assert(LHS->getOpcode() == Instruction::ZExt); 4993 assert(RHS->getOpcode() == Instruction::ZExt); 4994 Value *A = LHS->getOperand(0), *B = RHS->getOperand(0); 4995 4996 // Calculate type and width of the result produced by mul.with.overflow. 4997 Type *TyA = A->getType(), *TyB = B->getType(); 4998 unsigned WidthA = TyA->getPrimitiveSizeInBits(), 4999 WidthB = TyB->getPrimitiveSizeInBits(); 5000 unsigned MulWidth; 5001 Type *MulType; 5002 if (WidthB > WidthA) { 5003 MulWidth = WidthB; 5004 MulType = TyB; 5005 } else { 5006 MulWidth = WidthA; 5007 MulType = TyA; 5008 } 5009 5010 // In order to replace the original mul with a narrower mul.with.overflow, 5011 // all uses must ignore upper bits of the product. The number of used low 5012 // bits must be not greater than the width of mul.with.overflow. 5013 if (MulVal->hasNUsesOrMore(2)) 5014 for (User *U : MulVal->users()) { 5015 if (U == &I) 5016 continue; 5017 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 5018 // Check if truncation ignores bits above MulWidth. 5019 unsigned TruncWidth = TI->getType()->getPrimitiveSizeInBits(); 5020 if (TruncWidth > MulWidth) 5021 return nullptr; 5022 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 5023 // Check if AND ignores bits above MulWidth. 5024 if (BO->getOpcode() != Instruction::And) 5025 return nullptr; 5026 if (ConstantInt *CI = dyn_cast<ConstantInt>(BO->getOperand(1))) { 5027 const APInt &CVal = CI->getValue(); 5028 if (CVal.getBitWidth() - CVal.countLeadingZeros() > MulWidth) 5029 return nullptr; 5030 } else { 5031 // In this case we could have the operand of the binary operation 5032 // being defined in another block, and performing the replacement 5033 // could break the dominance relation. 5034 return nullptr; 5035 } 5036 } else { 5037 // Other uses prohibit this transformation. 5038 return nullptr; 5039 } 5040 } 5041 5042 // Recognize patterns 5043 switch (I.getPredicate()) { 5044 case ICmpInst::ICMP_EQ: 5045 case ICmpInst::ICMP_NE: 5046 // Recognize pattern: 5047 // mulval = mul(zext A, zext B) 5048 // cmp eq/neq mulval, and(mulval, mask), mask selects low MulWidth bits. 5049 ConstantInt *CI; 5050 Value *ValToMask; 5051 if (match(OtherVal, m_And(m_Value(ValToMask), m_ConstantInt(CI)))) { 5052 if (ValToMask != MulVal) 5053 return nullptr; 5054 const APInt &CVal = CI->getValue() + 1; 5055 if (CVal.isPowerOf2()) { 5056 unsigned MaskWidth = CVal.logBase2(); 5057 if (MaskWidth == MulWidth) 5058 break; // Recognized 5059 } 5060 } 5061 return nullptr; 5062 5063 case ICmpInst::ICMP_UGT: 5064 // Recognize pattern: 5065 // mulval = mul(zext A, zext B) 5066 // cmp ugt mulval, max 5067 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5068 APInt MaxVal = APInt::getMaxValue(MulWidth); 5069 MaxVal = MaxVal.zext(CI->getBitWidth()); 5070 if (MaxVal.eq(CI->getValue())) 5071 break; // Recognized 5072 } 5073 return nullptr; 5074 5075 case ICmpInst::ICMP_UGE: 5076 // Recognize pattern: 5077 // mulval = mul(zext A, zext B) 5078 // cmp uge mulval, max+1 5079 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5080 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 5081 if (MaxVal.eq(CI->getValue())) 5082 break; // Recognized 5083 } 5084 return nullptr; 5085 5086 case ICmpInst::ICMP_ULE: 5087 // Recognize pattern: 5088 // mulval = mul(zext A, zext B) 5089 // cmp ule mulval, max 5090 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5091 APInt MaxVal = APInt::getMaxValue(MulWidth); 5092 MaxVal = MaxVal.zext(CI->getBitWidth()); 5093 if (MaxVal.eq(CI->getValue())) 5094 break; // Recognized 5095 } 5096 return nullptr; 5097 5098 case ICmpInst::ICMP_ULT: 5099 // Recognize pattern: 5100 // mulval = mul(zext A, zext B) 5101 // cmp ule mulval, max + 1 5102 if (ConstantInt *CI = dyn_cast<ConstantInt>(OtherVal)) { 5103 APInt MaxVal = APInt::getOneBitSet(CI->getBitWidth(), MulWidth); 5104 if (MaxVal.eq(CI->getValue())) 5105 break; // Recognized 5106 } 5107 return nullptr; 5108 5109 default: 5110 return nullptr; 5111 } 5112 5113 InstCombiner::BuilderTy &Builder = IC.Builder; 5114 Builder.SetInsertPoint(MulInstr); 5115 5116 // Replace: mul(zext A, zext B) --> mul.with.overflow(A, B) 5117 Value *MulA = A, *MulB = B; 5118 if (WidthA < MulWidth) 5119 MulA = Builder.CreateZExt(A, MulType); 5120 if (WidthB < MulWidth) 5121 MulB = Builder.CreateZExt(B, MulType); 5122 Function *F = Intrinsic::getDeclaration( 5123 I.getModule(), Intrinsic::umul_with_overflow, MulType); 5124 CallInst *Call = Builder.CreateCall(F, {MulA, MulB}, "umul"); 5125 IC.addToWorklist(MulInstr); 5126 5127 // If there are uses of mul result other than the comparison, we know that 5128 // they are truncation or binary AND. Change them to use result of 5129 // mul.with.overflow and adjust properly mask/size. 5130 if (MulVal->hasNUsesOrMore(2)) { 5131 Value *Mul = Builder.CreateExtractValue(Call, 0, "umul.value"); 5132 for (User *U : make_early_inc_range(MulVal->users())) { 5133 if (U == &I || U == OtherVal) 5134 continue; 5135 if (TruncInst *TI = dyn_cast<TruncInst>(U)) { 5136 if (TI->getType()->getPrimitiveSizeInBits() == MulWidth) 5137 IC.replaceInstUsesWith(*TI, Mul); 5138 else 5139 TI->setOperand(0, Mul); 5140 } else if (BinaryOperator *BO = dyn_cast<BinaryOperator>(U)) { 5141 assert(BO->getOpcode() == Instruction::And); 5142 // Replace (mul & mask) --> zext (mul.with.overflow & short_mask) 5143 ConstantInt *CI = cast<ConstantInt>(BO->getOperand(1)); 5144 APInt ShortMask = CI->getValue().trunc(MulWidth); 5145 Value *ShortAnd = Builder.CreateAnd(Mul, ShortMask); 5146 Value *Zext = Builder.CreateZExt(ShortAnd, BO->getType()); 5147 IC.replaceInstUsesWith(*BO, Zext); 5148 } else { 5149 llvm_unreachable("Unexpected Binary operation"); 5150 } 5151 IC.addToWorklist(cast<Instruction>(U)); 5152 } 5153 } 5154 if (isa<Instruction>(OtherVal)) 5155 IC.addToWorklist(cast<Instruction>(OtherVal)); 5156 5157 // The original icmp gets replaced with the overflow value, maybe inverted 5158 // depending on predicate. 5159 bool Inverse = false; 5160 switch (I.getPredicate()) { 5161 case ICmpInst::ICMP_NE: 5162 break; 5163 case ICmpInst::ICMP_EQ: 5164 Inverse = true; 5165 break; 5166 case ICmpInst::ICMP_UGT: 5167 case ICmpInst::ICMP_UGE: 5168 if (I.getOperand(0) == MulVal) 5169 break; 5170 Inverse = true; 5171 break; 5172 case ICmpInst::ICMP_ULT: 5173 case ICmpInst::ICMP_ULE: 5174 if (I.getOperand(1) == MulVal) 5175 break; 5176 Inverse = true; 5177 break; 5178 default: 5179 llvm_unreachable("Unexpected predicate"); 5180 } 5181 if (Inverse) { 5182 Value *Res = Builder.CreateExtractValue(Call, 1); 5183 return BinaryOperator::CreateNot(Res); 5184 } 5185 5186 return ExtractValueInst::Create(Call, 1); 5187 } 5188 5189 /// When performing a comparison against a constant, it is possible that not all 5190 /// the bits in the LHS are demanded. This helper method computes the mask that 5191 /// IS demanded. 5192 static APInt getDemandedBitsLHSMask(ICmpInst &I, unsigned BitWidth) { 5193 const APInt *RHS; 5194 if (!match(I.getOperand(1), m_APInt(RHS))) 5195 return APInt::getAllOnes(BitWidth); 5196 5197 // If this is a normal comparison, it demands all bits. If it is a sign bit 5198 // comparison, it only demands the sign bit. 5199 bool UnusedBit; 5200 if (InstCombiner::isSignBitCheck(I.getPredicate(), *RHS, UnusedBit)) 5201 return APInt::getSignMask(BitWidth); 5202 5203 switch (I.getPredicate()) { 5204 // For a UGT comparison, we don't care about any bits that 5205 // correspond to the trailing ones of the comparand. The value of these 5206 // bits doesn't impact the outcome of the comparison, because any value 5207 // greater than the RHS must differ in a bit higher than these due to carry. 5208 case ICmpInst::ICMP_UGT: 5209 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingOnes()); 5210 5211 // Similarly, for a ULT comparison, we don't care about the trailing zeros. 5212 // Any value less than the RHS must differ in a higher bit because of carries. 5213 case ICmpInst::ICMP_ULT: 5214 return APInt::getBitsSetFrom(BitWidth, RHS->countTrailingZeros()); 5215 5216 default: 5217 return APInt::getAllOnes(BitWidth); 5218 } 5219 } 5220 5221 /// Check if the order of \p Op0 and \p Op1 as operands in an ICmpInst 5222 /// should be swapped. 5223 /// The decision is based on how many times these two operands are reused 5224 /// as subtract operands and their positions in those instructions. 5225 /// The rationale is that several architectures use the same instruction for 5226 /// both subtract and cmp. Thus, it is better if the order of those operands 5227 /// match. 5228 /// \return true if Op0 and Op1 should be swapped. 5229 static bool swapMayExposeCSEOpportunities(const Value *Op0, const Value *Op1) { 5230 // Filter out pointer values as those cannot appear directly in subtract. 5231 // FIXME: we may want to go through inttoptrs or bitcasts. 5232 if (Op0->getType()->isPointerTy()) 5233 return false; 5234 // If a subtract already has the same operands as a compare, swapping would be 5235 // bad. If a subtract has the same operands as a compare but in reverse order, 5236 // then swapping is good. 5237 int GoodToSwap = 0; 5238 for (const User *U : Op0->users()) { 5239 if (match(U, m_Sub(m_Specific(Op1), m_Specific(Op0)))) 5240 GoodToSwap++; 5241 else if (match(U, m_Sub(m_Specific(Op0), m_Specific(Op1)))) 5242 GoodToSwap--; 5243 } 5244 return GoodToSwap > 0; 5245 } 5246 5247 /// Check that one use is in the same block as the definition and all 5248 /// other uses are in blocks dominated by a given block. 5249 /// 5250 /// \param DI Definition 5251 /// \param UI Use 5252 /// \param DB Block that must dominate all uses of \p DI outside 5253 /// the parent block 5254 /// \return true when \p UI is the only use of \p DI in the parent block 5255 /// and all other uses of \p DI are in blocks dominated by \p DB. 5256 /// 5257 bool InstCombinerImpl::dominatesAllUses(const Instruction *DI, 5258 const Instruction *UI, 5259 const BasicBlock *DB) const { 5260 assert(DI && UI && "Instruction not defined\n"); 5261 // Ignore incomplete definitions. 5262 if (!DI->getParent()) 5263 return false; 5264 // DI and UI must be in the same block. 5265 if (DI->getParent() != UI->getParent()) 5266 return false; 5267 // Protect from self-referencing blocks. 5268 if (DI->getParent() == DB) 5269 return false; 5270 for (const User *U : DI->users()) { 5271 auto *Usr = cast<Instruction>(U); 5272 if (Usr != UI && !DT.dominates(DB, Usr->getParent())) 5273 return false; 5274 } 5275 return true; 5276 } 5277 5278 /// Return true when the instruction sequence within a block is select-cmp-br. 5279 static bool isChainSelectCmpBranch(const SelectInst *SI) { 5280 const BasicBlock *BB = SI->getParent(); 5281 if (!BB) 5282 return false; 5283 auto *BI = dyn_cast_or_null<BranchInst>(BB->getTerminator()); 5284 if (!BI || BI->getNumSuccessors() != 2) 5285 return false; 5286 auto *IC = dyn_cast<ICmpInst>(BI->getCondition()); 5287 if (!IC || (IC->getOperand(0) != SI && IC->getOperand(1) != SI)) 5288 return false; 5289 return true; 5290 } 5291 5292 /// True when a select result is replaced by one of its operands 5293 /// in select-icmp sequence. This will eventually result in the elimination 5294 /// of the select. 5295 /// 5296 /// \param SI Select instruction 5297 /// \param Icmp Compare instruction 5298 /// \param SIOpd Operand that replaces the select 5299 /// 5300 /// Notes: 5301 /// - The replacement is global and requires dominator information 5302 /// - The caller is responsible for the actual replacement 5303 /// 5304 /// Example: 5305 /// 5306 /// entry: 5307 /// %4 = select i1 %3, %C* %0, %C* null 5308 /// %5 = icmp eq %C* %4, null 5309 /// br i1 %5, label %9, label %7 5310 /// ... 5311 /// ; <label>:7 ; preds = %entry 5312 /// %8 = getelementptr inbounds %C* %4, i64 0, i32 0 5313 /// ... 5314 /// 5315 /// can be transformed to 5316 /// 5317 /// %5 = icmp eq %C* %0, null 5318 /// %6 = select i1 %3, i1 %5, i1 true 5319 /// br i1 %6, label %9, label %7 5320 /// ... 5321 /// ; <label>:7 ; preds = %entry 5322 /// %8 = getelementptr inbounds %C* %0, i64 0, i32 0 // replace by %0! 5323 /// 5324 /// Similar when the first operand of the select is a constant or/and 5325 /// the compare is for not equal rather than equal. 5326 /// 5327 /// NOTE: The function is only called when the select and compare constants 5328 /// are equal, the optimization can work only for EQ predicates. This is not a 5329 /// major restriction since a NE compare should be 'normalized' to an equal 5330 /// compare, which usually happens in the combiner and test case 5331 /// select-cmp-br.ll checks for it. 5332 bool InstCombinerImpl::replacedSelectWithOperand(SelectInst *SI, 5333 const ICmpInst *Icmp, 5334 const unsigned SIOpd) { 5335 assert((SIOpd == 1 || SIOpd == 2) && "Invalid select operand!"); 5336 if (isChainSelectCmpBranch(SI) && Icmp->getPredicate() == ICmpInst::ICMP_EQ) { 5337 BasicBlock *Succ = SI->getParent()->getTerminator()->getSuccessor(1); 5338 // The check for the single predecessor is not the best that can be 5339 // done. But it protects efficiently against cases like when SI's 5340 // home block has two successors, Succ and Succ1, and Succ1 predecessor 5341 // of Succ. Then SI can't be replaced by SIOpd because the use that gets 5342 // replaced can be reached on either path. So the uniqueness check 5343 // guarantees that the path all uses of SI (outside SI's parent) are on 5344 // is disjoint from all other paths out of SI. But that information 5345 // is more expensive to compute, and the trade-off here is in favor 5346 // of compile-time. It should also be noticed that we check for a single 5347 // predecessor and not only uniqueness. This to handle the situation when 5348 // Succ and Succ1 points to the same basic block. 5349 if (Succ->getSinglePredecessor() && dominatesAllUses(SI, Icmp, Succ)) { 5350 NumSel++; 5351 SI->replaceUsesOutsideBlock(SI->getOperand(SIOpd), SI->getParent()); 5352 return true; 5353 } 5354 } 5355 return false; 5356 } 5357 5358 /// Try to fold the comparison based on range information we can get by checking 5359 /// whether bits are known to be zero or one in the inputs. 5360 Instruction *InstCombinerImpl::foldICmpUsingKnownBits(ICmpInst &I) { 5361 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5362 Type *Ty = Op0->getType(); 5363 ICmpInst::Predicate Pred = I.getPredicate(); 5364 5365 // Get scalar or pointer size. 5366 unsigned BitWidth = Ty->isIntOrIntVectorTy() 5367 ? Ty->getScalarSizeInBits() 5368 : DL.getPointerTypeSizeInBits(Ty->getScalarType()); 5369 5370 if (!BitWidth) 5371 return nullptr; 5372 5373 KnownBits Op0Known(BitWidth); 5374 KnownBits Op1Known(BitWidth); 5375 5376 if (SimplifyDemandedBits(&I, 0, 5377 getDemandedBitsLHSMask(I, BitWidth), 5378 Op0Known, 0)) 5379 return &I; 5380 5381 if (SimplifyDemandedBits(&I, 1, APInt::getAllOnes(BitWidth), Op1Known, 0)) 5382 return &I; 5383 5384 // Given the known and unknown bits, compute a range that the LHS could be 5385 // in. Compute the Min, Max and RHS values based on the known bits. For the 5386 // EQ and NE we use unsigned values. 5387 APInt Op0Min(BitWidth, 0), Op0Max(BitWidth, 0); 5388 APInt Op1Min(BitWidth, 0), Op1Max(BitWidth, 0); 5389 if (I.isSigned()) { 5390 Op0Min = Op0Known.getSignedMinValue(); 5391 Op0Max = Op0Known.getSignedMaxValue(); 5392 Op1Min = Op1Known.getSignedMinValue(); 5393 Op1Max = Op1Known.getSignedMaxValue(); 5394 } else { 5395 Op0Min = Op0Known.getMinValue(); 5396 Op0Max = Op0Known.getMaxValue(); 5397 Op1Min = Op1Known.getMinValue(); 5398 Op1Max = Op1Known.getMaxValue(); 5399 } 5400 5401 // If Min and Max are known to be the same, then SimplifyDemandedBits figured 5402 // out that the LHS or RHS is a constant. Constant fold this now, so that 5403 // code below can assume that Min != Max. 5404 if (!isa<Constant>(Op0) && Op0Min == Op0Max) 5405 return new ICmpInst(Pred, ConstantExpr::getIntegerValue(Ty, Op0Min), Op1); 5406 if (!isa<Constant>(Op1) && Op1Min == Op1Max) 5407 return new ICmpInst(Pred, Op0, ConstantExpr::getIntegerValue(Ty, Op1Min)); 5408 5409 // Don't break up a clamp pattern -- (min(max X, Y), Z) -- by replacing a 5410 // min/max canonical compare with some other compare. That could lead to 5411 // conflict with select canonicalization and infinite looping. 5412 // FIXME: This constraint may go away if min/max intrinsics are canonical. 5413 auto isMinMaxCmp = [&](Instruction &Cmp) { 5414 if (!Cmp.hasOneUse()) 5415 return false; 5416 Value *A, *B; 5417 SelectPatternFlavor SPF = matchSelectPattern(Cmp.user_back(), A, B).Flavor; 5418 if (!SelectPatternResult::isMinOrMax(SPF)) 5419 return false; 5420 return match(Op0, m_MaxOrMin(m_Value(), m_Value())) || 5421 match(Op1, m_MaxOrMin(m_Value(), m_Value())); 5422 }; 5423 if (!isMinMaxCmp(I)) { 5424 switch (Pred) { 5425 default: 5426 break; 5427 case ICmpInst::ICMP_ULT: { 5428 if (Op1Min == Op0Max) // A <u B -> A != B if max(A) == min(B) 5429 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5430 const APInt *CmpC; 5431 if (match(Op1, m_APInt(CmpC))) { 5432 // A <u C -> A == C-1 if min(A)+1 == C 5433 if (*CmpC == Op0Min + 1) 5434 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5435 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5436 // X <u C --> X == 0, if the number of zero bits in the bottom of X 5437 // exceeds the log2 of C. 5438 if (Op0Known.countMinTrailingZeros() >= CmpC->ceilLogBase2()) 5439 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5440 Constant::getNullValue(Op1->getType())); 5441 } 5442 break; 5443 } 5444 case ICmpInst::ICMP_UGT: { 5445 if (Op1Max == Op0Min) // A >u B -> A != B if min(A) == max(B) 5446 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5447 const APInt *CmpC; 5448 if (match(Op1, m_APInt(CmpC))) { 5449 // A >u C -> A == C+1 if max(a)-1 == C 5450 if (*CmpC == Op0Max - 1) 5451 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5452 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5453 // X >u C --> X != 0, if the number of zero bits in the bottom of X 5454 // exceeds the log2 of C. 5455 if (Op0Known.countMinTrailingZeros() >= CmpC->getActiveBits()) 5456 return new ICmpInst(ICmpInst::ICMP_NE, Op0, 5457 Constant::getNullValue(Op1->getType())); 5458 } 5459 break; 5460 } 5461 case ICmpInst::ICMP_SLT: { 5462 if (Op1Min == Op0Max) // A <s B -> A != B if max(A) == min(B) 5463 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5464 const APInt *CmpC; 5465 if (match(Op1, m_APInt(CmpC))) { 5466 if (*CmpC == Op0Min + 1) // A <s C -> A == C-1 if min(A)+1 == C 5467 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5468 ConstantInt::get(Op1->getType(), *CmpC - 1)); 5469 } 5470 break; 5471 } 5472 case ICmpInst::ICMP_SGT: { 5473 if (Op1Max == Op0Min) // A >s B -> A != B if min(A) == max(B) 5474 return new ICmpInst(ICmpInst::ICMP_NE, Op0, Op1); 5475 const APInt *CmpC; 5476 if (match(Op1, m_APInt(CmpC))) { 5477 if (*CmpC == Op0Max - 1) // A >s C -> A == C+1 if max(A)-1 == C 5478 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, 5479 ConstantInt::get(Op1->getType(), *CmpC + 1)); 5480 } 5481 break; 5482 } 5483 } 5484 } 5485 5486 // Based on the range information we know about the LHS, see if we can 5487 // simplify this comparison. For example, (x&4) < 8 is always true. 5488 switch (Pred) { 5489 default: 5490 llvm_unreachable("Unknown icmp opcode!"); 5491 case ICmpInst::ICMP_EQ: 5492 case ICmpInst::ICMP_NE: { 5493 if (Op0Max.ult(Op1Min) || Op0Min.ugt(Op1Max)) 5494 return replaceInstUsesWith( 5495 I, ConstantInt::getBool(I.getType(), Pred == CmpInst::ICMP_NE)); 5496 5497 // If all bits are known zero except for one, then we know at most one bit 5498 // is set. If the comparison is against zero, then this is a check to see if 5499 // *that* bit is set. 5500 APInt Op0KnownZeroInverted = ~Op0Known.Zero; 5501 if (Op1Known.isZero()) { 5502 // If the LHS is an AND with the same constant, look through it. 5503 Value *LHS = nullptr; 5504 const APInt *LHSC; 5505 if (!match(Op0, m_And(m_Value(LHS), m_APInt(LHSC))) || 5506 *LHSC != Op0KnownZeroInverted) 5507 LHS = Op0; 5508 5509 Value *X; 5510 if (match(LHS, m_Shl(m_One(), m_Value(X)))) { 5511 APInt ValToCheck = Op0KnownZeroInverted; 5512 Type *XTy = X->getType(); 5513 if (ValToCheck.isPowerOf2()) { 5514 // ((1 << X) & 8) == 0 -> X != 3 5515 // ((1 << X) & 8) != 0 -> X == 3 5516 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5517 auto NewPred = ICmpInst::getInversePredicate(Pred); 5518 return new ICmpInst(NewPred, X, CmpC); 5519 } else if ((++ValToCheck).isPowerOf2()) { 5520 // ((1 << X) & 7) == 0 -> X >= 3 5521 // ((1 << X) & 7) != 0 -> X < 3 5522 auto *CmpC = ConstantInt::get(XTy, ValToCheck.countTrailingZeros()); 5523 auto NewPred = 5524 Pred == CmpInst::ICMP_EQ ? CmpInst::ICMP_UGE : CmpInst::ICMP_ULT; 5525 return new ICmpInst(NewPred, X, CmpC); 5526 } 5527 } 5528 5529 // Check if the LHS is 8 >>u x and the result is a power of 2 like 1. 5530 const APInt *CI; 5531 if (Op0KnownZeroInverted.isOne() && 5532 match(LHS, m_LShr(m_Power2(CI), m_Value(X)))) { 5533 // ((8 >>u X) & 1) == 0 -> X != 3 5534 // ((8 >>u X) & 1) != 0 -> X == 3 5535 unsigned CmpVal = CI->countTrailingZeros(); 5536 auto NewPred = ICmpInst::getInversePredicate(Pred); 5537 return new ICmpInst(NewPred, X, ConstantInt::get(X->getType(), CmpVal)); 5538 } 5539 } 5540 break; 5541 } 5542 case ICmpInst::ICMP_ULT: { 5543 if (Op0Max.ult(Op1Min)) // A <u B -> true if max(A) < min(B) 5544 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5545 if (Op0Min.uge(Op1Max)) // A <u B -> false if min(A) >= max(B) 5546 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5547 break; 5548 } 5549 case ICmpInst::ICMP_UGT: { 5550 if (Op0Min.ugt(Op1Max)) // A >u B -> true if min(A) > max(B) 5551 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5552 if (Op0Max.ule(Op1Min)) // A >u B -> false if max(A) <= max(B) 5553 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5554 break; 5555 } 5556 case ICmpInst::ICMP_SLT: { 5557 if (Op0Max.slt(Op1Min)) // A <s B -> true if max(A) < min(C) 5558 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5559 if (Op0Min.sge(Op1Max)) // A <s B -> false if min(A) >= max(C) 5560 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5561 break; 5562 } 5563 case ICmpInst::ICMP_SGT: { 5564 if (Op0Min.sgt(Op1Max)) // A >s B -> true if min(A) > max(B) 5565 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5566 if (Op0Max.sle(Op1Min)) // A >s B -> false if max(A) <= min(B) 5567 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5568 break; 5569 } 5570 case ICmpInst::ICMP_SGE: 5571 assert(!isa<ConstantInt>(Op1) && "ICMP_SGE with ConstantInt not folded!"); 5572 if (Op0Min.sge(Op1Max)) // A >=s B -> true if min(A) >= max(B) 5573 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5574 if (Op0Max.slt(Op1Min)) // A >=s B -> false if max(A) < min(B) 5575 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5576 if (Op1Min == Op0Max) // A >=s B -> A == B if max(A) == min(B) 5577 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5578 break; 5579 case ICmpInst::ICMP_SLE: 5580 assert(!isa<ConstantInt>(Op1) && "ICMP_SLE with ConstantInt not folded!"); 5581 if (Op0Max.sle(Op1Min)) // A <=s B -> true if max(A) <= min(B) 5582 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5583 if (Op0Min.sgt(Op1Max)) // A <=s B -> false if min(A) > max(B) 5584 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5585 if (Op1Max == Op0Min) // A <=s B -> A == B if min(A) == max(B) 5586 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5587 break; 5588 case ICmpInst::ICMP_UGE: 5589 assert(!isa<ConstantInt>(Op1) && "ICMP_UGE with ConstantInt not folded!"); 5590 if (Op0Min.uge(Op1Max)) // A >=u B -> true if min(A) >= max(B) 5591 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5592 if (Op0Max.ult(Op1Min)) // A >=u B -> false if max(A) < min(B) 5593 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5594 if (Op1Min == Op0Max) // A >=u B -> A == B if max(A) == min(B) 5595 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5596 break; 5597 case ICmpInst::ICMP_ULE: 5598 assert(!isa<ConstantInt>(Op1) && "ICMP_ULE with ConstantInt not folded!"); 5599 if (Op0Max.ule(Op1Min)) // A <=u B -> true if max(A) <= min(B) 5600 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 5601 if (Op0Min.ugt(Op1Max)) // A <=u B -> false if min(A) > max(B) 5602 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 5603 if (Op1Max == Op0Min) // A <=u B -> A == B if min(A) == max(B) 5604 return new ICmpInst(ICmpInst::ICMP_EQ, Op0, Op1); 5605 break; 5606 } 5607 5608 // Turn a signed comparison into an unsigned one if both operands are known to 5609 // have the same sign. 5610 if (I.isSigned() && 5611 ((Op0Known.Zero.isNegative() && Op1Known.Zero.isNegative()) || 5612 (Op0Known.One.isNegative() && Op1Known.One.isNegative()))) 5613 return new ICmpInst(I.getUnsignedPredicate(), Op0, Op1); 5614 5615 return nullptr; 5616 } 5617 5618 llvm::Optional<std::pair<CmpInst::Predicate, Constant *>> 5619 InstCombiner::getFlippedStrictnessPredicateAndConstant(CmpInst::Predicate Pred, 5620 Constant *C) { 5621 assert(ICmpInst::isRelational(Pred) && ICmpInst::isIntPredicate(Pred) && 5622 "Only for relational integer predicates."); 5623 5624 Type *Type = C->getType(); 5625 bool IsSigned = ICmpInst::isSigned(Pred); 5626 5627 CmpInst::Predicate UnsignedPred = ICmpInst::getUnsignedPredicate(Pred); 5628 bool WillIncrement = 5629 UnsignedPred == ICmpInst::ICMP_ULE || UnsignedPred == ICmpInst::ICMP_UGT; 5630 5631 // Check if the constant operand can be safely incremented/decremented 5632 // without overflowing/underflowing. 5633 auto ConstantIsOk = [WillIncrement, IsSigned](ConstantInt *C) { 5634 return WillIncrement ? !C->isMaxValue(IsSigned) : !C->isMinValue(IsSigned); 5635 }; 5636 5637 Constant *SafeReplacementConstant = nullptr; 5638 if (auto *CI = dyn_cast<ConstantInt>(C)) { 5639 // Bail out if the constant can't be safely incremented/decremented. 5640 if (!ConstantIsOk(CI)) 5641 return llvm::None; 5642 } else if (auto *FVTy = dyn_cast<FixedVectorType>(Type)) { 5643 unsigned NumElts = FVTy->getNumElements(); 5644 for (unsigned i = 0; i != NumElts; ++i) { 5645 Constant *Elt = C->getAggregateElement(i); 5646 if (!Elt) 5647 return llvm::None; 5648 5649 if (isa<UndefValue>(Elt)) 5650 continue; 5651 5652 // Bail out if we can't determine if this constant is min/max or if we 5653 // know that this constant is min/max. 5654 auto *CI = dyn_cast<ConstantInt>(Elt); 5655 if (!CI || !ConstantIsOk(CI)) 5656 return llvm::None; 5657 5658 if (!SafeReplacementConstant) 5659 SafeReplacementConstant = CI; 5660 } 5661 } else { 5662 // ConstantExpr? 5663 return llvm::None; 5664 } 5665 5666 // It may not be safe to change a compare predicate in the presence of 5667 // undefined elements, so replace those elements with the first safe constant 5668 // that we found. 5669 // TODO: in case of poison, it is safe; let's replace undefs only. 5670 if (C->containsUndefOrPoisonElement()) { 5671 assert(SafeReplacementConstant && "Replacement constant not set"); 5672 C = Constant::replaceUndefsWith(C, SafeReplacementConstant); 5673 } 5674 5675 CmpInst::Predicate NewPred = CmpInst::getFlippedStrictnessPredicate(Pred); 5676 5677 // Increment or decrement the constant. 5678 Constant *OneOrNegOne = ConstantInt::get(Type, WillIncrement ? 1 : -1, true); 5679 Constant *NewC = ConstantExpr::getAdd(C, OneOrNegOne); 5680 5681 return std::make_pair(NewPred, NewC); 5682 } 5683 5684 /// If we have an icmp le or icmp ge instruction with a constant operand, turn 5685 /// it into the appropriate icmp lt or icmp gt instruction. This transform 5686 /// allows them to be folded in visitICmpInst. 5687 static ICmpInst *canonicalizeCmpWithConstant(ICmpInst &I) { 5688 ICmpInst::Predicate Pred = I.getPredicate(); 5689 if (ICmpInst::isEquality(Pred) || !ICmpInst::isIntPredicate(Pred) || 5690 InstCombiner::isCanonicalPredicate(Pred)) 5691 return nullptr; 5692 5693 Value *Op0 = I.getOperand(0); 5694 Value *Op1 = I.getOperand(1); 5695 auto *Op1C = dyn_cast<Constant>(Op1); 5696 if (!Op1C) 5697 return nullptr; 5698 5699 auto FlippedStrictness = 5700 InstCombiner::getFlippedStrictnessPredicateAndConstant(Pred, Op1C); 5701 if (!FlippedStrictness) 5702 return nullptr; 5703 5704 return new ICmpInst(FlippedStrictness->first, Op0, FlippedStrictness->second); 5705 } 5706 5707 /// If we have a comparison with a non-canonical predicate, if we can update 5708 /// all the users, invert the predicate and adjust all the users. 5709 CmpInst *InstCombinerImpl::canonicalizeICmpPredicate(CmpInst &I) { 5710 // Is the predicate already canonical? 5711 CmpInst::Predicate Pred = I.getPredicate(); 5712 if (InstCombiner::isCanonicalPredicate(Pred)) 5713 return nullptr; 5714 5715 // Can all users be adjusted to predicate inversion? 5716 if (!InstCombiner::canFreelyInvertAllUsersOf(&I, /*IgnoredUser=*/nullptr)) 5717 return nullptr; 5718 5719 // Ok, we can canonicalize comparison! 5720 // Let's first invert the comparison's predicate. 5721 I.setPredicate(CmpInst::getInversePredicate(Pred)); 5722 I.setName(I.getName() + ".not"); 5723 5724 // And, adapt users. 5725 freelyInvertAllUsersOf(&I); 5726 5727 return &I; 5728 } 5729 5730 /// Integer compare with boolean values can always be turned into bitwise ops. 5731 static Instruction *canonicalizeICmpBool(ICmpInst &I, 5732 InstCombiner::BuilderTy &Builder) { 5733 Value *A = I.getOperand(0), *B = I.getOperand(1); 5734 assert(A->getType()->isIntOrIntVectorTy(1) && "Bools only"); 5735 5736 // A boolean compared to true/false can be simplified to Op0/true/false in 5737 // 14 out of the 20 (10 predicates * 2 constants) possible combinations. 5738 // Cases not handled by InstSimplify are always 'not' of Op0. 5739 if (match(B, m_Zero())) { 5740 switch (I.getPredicate()) { 5741 case CmpInst::ICMP_EQ: // A == 0 -> !A 5742 case CmpInst::ICMP_ULE: // A <=u 0 -> !A 5743 case CmpInst::ICMP_SGE: // A >=s 0 -> !A 5744 return BinaryOperator::CreateNot(A); 5745 default: 5746 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5747 } 5748 } else if (match(B, m_One())) { 5749 switch (I.getPredicate()) { 5750 case CmpInst::ICMP_NE: // A != 1 -> !A 5751 case CmpInst::ICMP_ULT: // A <u 1 -> !A 5752 case CmpInst::ICMP_SGT: // A >s -1 -> !A 5753 return BinaryOperator::CreateNot(A); 5754 default: 5755 llvm_unreachable("ICmp i1 X, C not simplified as expected."); 5756 } 5757 } 5758 5759 switch (I.getPredicate()) { 5760 default: 5761 llvm_unreachable("Invalid icmp instruction!"); 5762 case ICmpInst::ICMP_EQ: 5763 // icmp eq i1 A, B -> ~(A ^ B) 5764 return BinaryOperator::CreateNot(Builder.CreateXor(A, B)); 5765 5766 case ICmpInst::ICMP_NE: 5767 // icmp ne i1 A, B -> A ^ B 5768 return BinaryOperator::CreateXor(A, B); 5769 5770 case ICmpInst::ICMP_UGT: 5771 // icmp ugt -> icmp ult 5772 std::swap(A, B); 5773 LLVM_FALLTHROUGH; 5774 case ICmpInst::ICMP_ULT: 5775 // icmp ult i1 A, B -> ~A & B 5776 return BinaryOperator::CreateAnd(Builder.CreateNot(A), B); 5777 5778 case ICmpInst::ICMP_SGT: 5779 // icmp sgt -> icmp slt 5780 std::swap(A, B); 5781 LLVM_FALLTHROUGH; 5782 case ICmpInst::ICMP_SLT: 5783 // icmp slt i1 A, B -> A & ~B 5784 return BinaryOperator::CreateAnd(Builder.CreateNot(B), A); 5785 5786 case ICmpInst::ICMP_UGE: 5787 // icmp uge -> icmp ule 5788 std::swap(A, B); 5789 LLVM_FALLTHROUGH; 5790 case ICmpInst::ICMP_ULE: 5791 // icmp ule i1 A, B -> ~A | B 5792 return BinaryOperator::CreateOr(Builder.CreateNot(A), B); 5793 5794 case ICmpInst::ICMP_SGE: 5795 // icmp sge -> icmp sle 5796 std::swap(A, B); 5797 LLVM_FALLTHROUGH; 5798 case ICmpInst::ICMP_SLE: 5799 // icmp sle i1 A, B -> A | ~B 5800 return BinaryOperator::CreateOr(Builder.CreateNot(B), A); 5801 } 5802 } 5803 5804 // Transform pattern like: 5805 // (1 << Y) u<= X or ~(-1 << Y) u< X or ((1 << Y)+(-1)) u< X 5806 // (1 << Y) u> X or ~(-1 << Y) u>= X or ((1 << Y)+(-1)) u>= X 5807 // Into: 5808 // (X l>> Y) != 0 5809 // (X l>> Y) == 0 5810 static Instruction *foldICmpWithHighBitMask(ICmpInst &Cmp, 5811 InstCombiner::BuilderTy &Builder) { 5812 ICmpInst::Predicate Pred, NewPred; 5813 Value *X, *Y; 5814 if (match(&Cmp, 5815 m_c_ICmp(Pred, m_OneUse(m_Shl(m_One(), m_Value(Y))), m_Value(X)))) { 5816 switch (Pred) { 5817 case ICmpInst::ICMP_ULE: 5818 NewPred = ICmpInst::ICMP_NE; 5819 break; 5820 case ICmpInst::ICMP_UGT: 5821 NewPred = ICmpInst::ICMP_EQ; 5822 break; 5823 default: 5824 return nullptr; 5825 } 5826 } else if (match(&Cmp, m_c_ICmp(Pred, 5827 m_OneUse(m_CombineOr( 5828 m_Not(m_Shl(m_AllOnes(), m_Value(Y))), 5829 m_Add(m_Shl(m_One(), m_Value(Y)), 5830 m_AllOnes()))), 5831 m_Value(X)))) { 5832 // The variant with 'add' is not canonical, (the variant with 'not' is) 5833 // we only get it because it has extra uses, and can't be canonicalized, 5834 5835 switch (Pred) { 5836 case ICmpInst::ICMP_ULT: 5837 NewPred = ICmpInst::ICMP_NE; 5838 break; 5839 case ICmpInst::ICMP_UGE: 5840 NewPred = ICmpInst::ICMP_EQ; 5841 break; 5842 default: 5843 return nullptr; 5844 } 5845 } else 5846 return nullptr; 5847 5848 Value *NewX = Builder.CreateLShr(X, Y, X->getName() + ".highbits"); 5849 Constant *Zero = Constant::getNullValue(NewX->getType()); 5850 return CmpInst::Create(Instruction::ICmp, NewPred, NewX, Zero); 5851 } 5852 5853 static Instruction *foldVectorCmp(CmpInst &Cmp, 5854 InstCombiner::BuilderTy &Builder) { 5855 const CmpInst::Predicate Pred = Cmp.getPredicate(); 5856 Value *LHS = Cmp.getOperand(0), *RHS = Cmp.getOperand(1); 5857 Value *V1, *V2; 5858 ArrayRef<int> M; 5859 if (!match(LHS, m_Shuffle(m_Value(V1), m_Undef(), m_Mask(M)))) 5860 return nullptr; 5861 5862 // If both arguments of the cmp are shuffles that use the same mask and 5863 // shuffle within a single vector, move the shuffle after the cmp: 5864 // cmp (shuffle V1, M), (shuffle V2, M) --> shuffle (cmp V1, V2), M 5865 Type *V1Ty = V1->getType(); 5866 if (match(RHS, m_Shuffle(m_Value(V2), m_Undef(), m_SpecificMask(M))) && 5867 V1Ty == V2->getType() && (LHS->hasOneUse() || RHS->hasOneUse())) { 5868 Value *NewCmp = Builder.CreateCmp(Pred, V1, V2); 5869 return new ShuffleVectorInst(NewCmp, M); 5870 } 5871 5872 // Try to canonicalize compare with splatted operand and splat constant. 5873 // TODO: We could generalize this for more than splats. See/use the code in 5874 // InstCombiner::foldVectorBinop(). 5875 Constant *C; 5876 if (!LHS->hasOneUse() || !match(RHS, m_Constant(C))) 5877 return nullptr; 5878 5879 // Length-changing splats are ok, so adjust the constants as needed: 5880 // cmp (shuffle V1, M), C --> shuffle (cmp V1, C'), M 5881 Constant *ScalarC = C->getSplatValue(/* AllowUndefs */ true); 5882 int MaskSplatIndex; 5883 if (ScalarC && match(M, m_SplatOrUndefMask(MaskSplatIndex))) { 5884 // We allow undefs in matching, but this transform removes those for safety. 5885 // Demanded elements analysis should be able to recover some/all of that. 5886 C = ConstantVector::getSplat(cast<VectorType>(V1Ty)->getElementCount(), 5887 ScalarC); 5888 SmallVector<int, 8> NewM(M.size(), MaskSplatIndex); 5889 Value *NewCmp = Builder.CreateCmp(Pred, V1, C); 5890 return new ShuffleVectorInst(NewCmp, NewM); 5891 } 5892 5893 return nullptr; 5894 } 5895 5896 // extract(uadd.with.overflow(A, B), 0) ult A 5897 // -> extract(uadd.with.overflow(A, B), 1) 5898 static Instruction *foldICmpOfUAddOv(ICmpInst &I) { 5899 CmpInst::Predicate Pred = I.getPredicate(); 5900 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5901 5902 Value *UAddOv; 5903 Value *A, *B; 5904 auto UAddOvResultPat = m_ExtractValue<0>( 5905 m_Intrinsic<Intrinsic::uadd_with_overflow>(m_Value(A), m_Value(B))); 5906 if (match(Op0, UAddOvResultPat) && 5907 ((Pred == ICmpInst::ICMP_ULT && (Op1 == A || Op1 == B)) || 5908 (Pred == ICmpInst::ICMP_EQ && match(Op1, m_ZeroInt()) && 5909 (match(A, m_One()) || match(B, m_One()))) || 5910 (Pred == ICmpInst::ICMP_NE && match(Op1, m_AllOnes()) && 5911 (match(A, m_AllOnes()) || match(B, m_AllOnes()))))) 5912 // extract(uadd.with.overflow(A, B), 0) < A 5913 // extract(uadd.with.overflow(A, 1), 0) == 0 5914 // extract(uadd.with.overflow(A, -1), 0) != -1 5915 UAddOv = cast<ExtractValueInst>(Op0)->getAggregateOperand(); 5916 else if (match(Op1, UAddOvResultPat) && 5917 Pred == ICmpInst::ICMP_UGT && (Op0 == A || Op0 == B)) 5918 // A > extract(uadd.with.overflow(A, B), 0) 5919 UAddOv = cast<ExtractValueInst>(Op1)->getAggregateOperand(); 5920 else 5921 return nullptr; 5922 5923 return ExtractValueInst::Create(UAddOv, 1); 5924 } 5925 5926 static Instruction *foldICmpInvariantGroup(ICmpInst &I) { 5927 if (!I.getOperand(0)->getType()->isPointerTy() || 5928 NullPointerIsDefined( 5929 I.getParent()->getParent(), 5930 I.getOperand(0)->getType()->getPointerAddressSpace())) { 5931 return nullptr; 5932 } 5933 Instruction *Op; 5934 if (match(I.getOperand(0), m_Instruction(Op)) && 5935 match(I.getOperand(1), m_Zero()) && 5936 Op->isLaunderOrStripInvariantGroup()) { 5937 return ICmpInst::Create(Instruction::ICmp, I.getPredicate(), 5938 Op->getOperand(0), I.getOperand(1)); 5939 } 5940 return nullptr; 5941 } 5942 5943 /// This function folds patterns produced by lowering of reduce idioms, such as 5944 /// llvm.vector.reduce.and which are lowered into instruction chains. This code 5945 /// attempts to generate fewer number of scalar comparisons instead of vector 5946 /// comparisons when possible. 5947 static Instruction *foldReductionIdiom(ICmpInst &I, 5948 InstCombiner::BuilderTy &Builder, 5949 const DataLayout &DL) { 5950 if (I.getType()->isVectorTy()) 5951 return nullptr; 5952 ICmpInst::Predicate OuterPred, InnerPred; 5953 Value *LHS, *RHS; 5954 5955 // Match lowering of @llvm.vector.reduce.and. Turn 5956 /// %vec_ne = icmp ne <8 x i8> %lhs, %rhs 5957 /// %scalar_ne = bitcast <8 x i1> %vec_ne to i8 5958 /// %res = icmp <pred> i8 %scalar_ne, 0 5959 /// 5960 /// into 5961 /// 5962 /// %lhs.scalar = bitcast <8 x i8> %lhs to i64 5963 /// %rhs.scalar = bitcast <8 x i8> %rhs to i64 5964 /// %res = icmp <pred> i64 %lhs.scalar, %rhs.scalar 5965 /// 5966 /// for <pred> in {ne, eq}. 5967 if (!match(&I, m_ICmp(OuterPred, 5968 m_OneUse(m_BitCast(m_OneUse( 5969 m_ICmp(InnerPred, m_Value(LHS), m_Value(RHS))))), 5970 m_Zero()))) 5971 return nullptr; 5972 auto *LHSTy = dyn_cast<FixedVectorType>(LHS->getType()); 5973 if (!LHSTy || !LHSTy->getElementType()->isIntegerTy()) 5974 return nullptr; 5975 unsigned NumBits = 5976 LHSTy->getNumElements() * LHSTy->getElementType()->getIntegerBitWidth(); 5977 // TODO: Relax this to "not wider than max legal integer type"? 5978 if (!DL.isLegalInteger(NumBits)) 5979 return nullptr; 5980 5981 if (ICmpInst::isEquality(OuterPred) && InnerPred == ICmpInst::ICMP_NE) { 5982 auto *ScalarTy = Builder.getIntNTy(NumBits); 5983 LHS = Builder.CreateBitCast(LHS, ScalarTy, LHS->getName() + ".scalar"); 5984 RHS = Builder.CreateBitCast(RHS, ScalarTy, RHS->getName() + ".scalar"); 5985 return ICmpInst::Create(Instruction::ICmp, OuterPred, LHS, RHS, 5986 I.getName()); 5987 } 5988 5989 return nullptr; 5990 } 5991 5992 Instruction *InstCombinerImpl::visitICmpInst(ICmpInst &I) { 5993 bool Changed = false; 5994 const SimplifyQuery Q = SQ.getWithInstruction(&I); 5995 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 5996 unsigned Op0Cplxity = getComplexity(Op0); 5997 unsigned Op1Cplxity = getComplexity(Op1); 5998 5999 /// Orders the operands of the compare so that they are listed from most 6000 /// complex to least complex. This puts constants before unary operators, 6001 /// before binary operators. 6002 if (Op0Cplxity < Op1Cplxity || 6003 (Op0Cplxity == Op1Cplxity && swapMayExposeCSEOpportunities(Op0, Op1))) { 6004 I.swapOperands(); 6005 std::swap(Op0, Op1); 6006 Changed = true; 6007 } 6008 6009 if (Value *V = SimplifyICmpInst(I.getPredicate(), Op0, Op1, Q)) 6010 return replaceInstUsesWith(I, V); 6011 6012 // Comparing -val or val with non-zero is the same as just comparing val 6013 // ie, abs(val) != 0 -> val != 0 6014 if (I.getPredicate() == ICmpInst::ICMP_NE && match(Op1, m_Zero())) { 6015 Value *Cond, *SelectTrue, *SelectFalse; 6016 if (match(Op0, m_Select(m_Value(Cond), m_Value(SelectTrue), 6017 m_Value(SelectFalse)))) { 6018 if (Value *V = dyn_castNegVal(SelectTrue)) { 6019 if (V == SelectFalse) 6020 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 6021 } 6022 else if (Value *V = dyn_castNegVal(SelectFalse)) { 6023 if (V == SelectTrue) 6024 return CmpInst::Create(Instruction::ICmp, I.getPredicate(), V, Op1); 6025 } 6026 } 6027 } 6028 6029 if (Op0->getType()->isIntOrIntVectorTy(1)) 6030 if (Instruction *Res = canonicalizeICmpBool(I, Builder)) 6031 return Res; 6032 6033 if (Instruction *Res = canonicalizeCmpWithConstant(I)) 6034 return Res; 6035 6036 if (Instruction *Res = canonicalizeICmpPredicate(I)) 6037 return Res; 6038 6039 if (Instruction *Res = foldICmpWithConstant(I)) 6040 return Res; 6041 6042 if (Instruction *Res = foldICmpWithDominatingICmp(I)) 6043 return Res; 6044 6045 if (Instruction *Res = foldICmpUsingKnownBits(I)) 6046 return Res; 6047 6048 // Test if the ICmpInst instruction is used exclusively by a select as 6049 // part of a minimum or maximum operation. If so, refrain from doing 6050 // any other folding. This helps out other analyses which understand 6051 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6052 // and CodeGen. And in this case, at least one of the comparison 6053 // operands has at least one user besides the compare (the select), 6054 // which would often largely negate the benefit of folding anyway. 6055 // 6056 // Do the same for the other patterns recognized by matchSelectPattern. 6057 if (I.hasOneUse()) 6058 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6059 Value *A, *B; 6060 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6061 if (SPR.Flavor != SPF_UNKNOWN) 6062 return nullptr; 6063 } 6064 6065 // Do this after checking for min/max to prevent infinite looping. 6066 if (Instruction *Res = foldICmpWithZero(I)) 6067 return Res; 6068 6069 // FIXME: We only do this after checking for min/max to prevent infinite 6070 // looping caused by a reverse canonicalization of these patterns for min/max. 6071 // FIXME: The organization of folds is a mess. These would naturally go into 6072 // canonicalizeCmpWithConstant(), but we can't move all of the above folds 6073 // down here after the min/max restriction. 6074 ICmpInst::Predicate Pred = I.getPredicate(); 6075 const APInt *C; 6076 if (match(Op1, m_APInt(C))) { 6077 // For i32: x >u 2147483647 -> x <s 0 -> true if sign bit set 6078 if (Pred == ICmpInst::ICMP_UGT && C->isMaxSignedValue()) { 6079 Constant *Zero = Constant::getNullValue(Op0->getType()); 6080 return new ICmpInst(ICmpInst::ICMP_SLT, Op0, Zero); 6081 } 6082 6083 // For i32: x <u 2147483648 -> x >s -1 -> true if sign bit clear 6084 if (Pred == ICmpInst::ICMP_ULT && C->isMinSignedValue()) { 6085 Constant *AllOnes = Constant::getAllOnesValue(Op0->getType()); 6086 return new ICmpInst(ICmpInst::ICMP_SGT, Op0, AllOnes); 6087 } 6088 } 6089 6090 // The folds in here may rely on wrapping flags and special constants, so 6091 // they can break up min/max idioms in some cases but not seemingly similar 6092 // patterns. 6093 // FIXME: It may be possible to enhance select folding to make this 6094 // unnecessary. It may also be moot if we canonicalize to min/max 6095 // intrinsics. 6096 if (Instruction *Res = foldICmpBinOp(I, Q)) 6097 return Res; 6098 6099 if (Instruction *Res = foldICmpInstWithConstant(I)) 6100 return Res; 6101 6102 // Try to match comparison as a sign bit test. Intentionally do this after 6103 // foldICmpInstWithConstant() to potentially let other folds to happen first. 6104 if (Instruction *New = foldSignBitTest(I)) 6105 return New; 6106 6107 if (Instruction *Res = foldICmpInstWithConstantNotInt(I)) 6108 return Res; 6109 6110 // Try to optimize 'icmp GEP, P' or 'icmp P, GEP'. 6111 if (auto *GEP = dyn_cast<GEPOperator>(Op0)) 6112 if (Instruction *NI = foldGEPICmp(GEP, Op1, I.getPredicate(), I)) 6113 return NI; 6114 if (auto *GEP = dyn_cast<GEPOperator>(Op1)) 6115 if (Instruction *NI = foldGEPICmp(GEP, Op0, I.getSwappedPredicate(), I)) 6116 return NI; 6117 6118 if (auto *SI = dyn_cast<SelectInst>(Op0)) 6119 if (Instruction *NI = foldSelectICmp(I.getPredicate(), SI, Op1, I)) 6120 return NI; 6121 if (auto *SI = dyn_cast<SelectInst>(Op1)) 6122 if (Instruction *NI = foldSelectICmp(I.getSwappedPredicate(), SI, Op0, I)) 6123 return NI; 6124 6125 // Try to optimize equality comparisons against alloca-based pointers. 6126 if (Op0->getType()->isPointerTy() && I.isEquality()) { 6127 assert(Op1->getType()->isPointerTy() && "Comparing pointer with non-pointer?"); 6128 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op0))) 6129 if (Instruction *New = foldAllocaCmp(I, Alloca)) 6130 return New; 6131 if (auto *Alloca = dyn_cast<AllocaInst>(getUnderlyingObject(Op1))) 6132 if (Instruction *New = foldAllocaCmp(I, Alloca)) 6133 return New; 6134 } 6135 6136 if (Instruction *Res = foldICmpBitCast(I)) 6137 return Res; 6138 6139 // TODO: Hoist this above the min/max bailout. 6140 if (Instruction *R = foldICmpWithCastOp(I)) 6141 return R; 6142 6143 if (Instruction *Res = foldICmpWithMinMax(I)) 6144 return Res; 6145 6146 { 6147 Value *A, *B; 6148 // Transform (A & ~B) == 0 --> (A & B) != 0 6149 // and (A & ~B) != 0 --> (A & B) == 0 6150 // if A is a power of 2. 6151 if (match(Op0, m_And(m_Value(A), m_Not(m_Value(B)))) && 6152 match(Op1, m_Zero()) && 6153 isKnownToBeAPowerOfTwo(A, false, 0, &I) && I.isEquality()) 6154 return new ICmpInst(I.getInversePredicate(), Builder.CreateAnd(A, B), 6155 Op1); 6156 6157 // ~X < ~Y --> Y < X 6158 // ~X < C --> X > ~C 6159 if (match(Op0, m_Not(m_Value(A)))) { 6160 if (match(Op1, m_Not(m_Value(B)))) 6161 return new ICmpInst(I.getPredicate(), B, A); 6162 6163 const APInt *C; 6164 if (match(Op1, m_APInt(C))) 6165 return new ICmpInst(I.getSwappedPredicate(), A, 6166 ConstantInt::get(Op1->getType(), ~(*C))); 6167 } 6168 6169 Instruction *AddI = nullptr; 6170 if (match(&I, m_UAddWithOverflow(m_Value(A), m_Value(B), 6171 m_Instruction(AddI))) && 6172 isa<IntegerType>(A->getType())) { 6173 Value *Result; 6174 Constant *Overflow; 6175 // m_UAddWithOverflow can match patterns that do not include an explicit 6176 // "add" instruction, so check the opcode of the matched op. 6177 if (AddI->getOpcode() == Instruction::Add && 6178 OptimizeOverflowCheck(Instruction::Add, /*Signed*/ false, A, B, *AddI, 6179 Result, Overflow)) { 6180 replaceInstUsesWith(*AddI, Result); 6181 eraseInstFromFunction(*AddI); 6182 return replaceInstUsesWith(I, Overflow); 6183 } 6184 } 6185 6186 // (zext a) * (zext b) --> llvm.umul.with.overflow. 6187 if (match(Op0, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 6188 if (Instruction *R = processUMulZExtIdiom(I, Op0, Op1, *this)) 6189 return R; 6190 } 6191 if (match(Op1, m_Mul(m_ZExt(m_Value(A)), m_ZExt(m_Value(B))))) { 6192 if (Instruction *R = processUMulZExtIdiom(I, Op1, Op0, *this)) 6193 return R; 6194 } 6195 } 6196 6197 if (Instruction *Res = foldICmpEquality(I)) 6198 return Res; 6199 6200 if (Instruction *Res = foldICmpOfUAddOv(I)) 6201 return Res; 6202 6203 // The 'cmpxchg' instruction returns an aggregate containing the old value and 6204 // an i1 which indicates whether or not we successfully did the swap. 6205 // 6206 // Replace comparisons between the old value and the expected value with the 6207 // indicator that 'cmpxchg' returns. 6208 // 6209 // N.B. This transform is only valid when the 'cmpxchg' is not permitted to 6210 // spuriously fail. In those cases, the old value may equal the expected 6211 // value but it is possible for the swap to not occur. 6212 if (I.getPredicate() == ICmpInst::ICMP_EQ) 6213 if (auto *EVI = dyn_cast<ExtractValueInst>(Op0)) 6214 if (auto *ACXI = dyn_cast<AtomicCmpXchgInst>(EVI->getAggregateOperand())) 6215 if (EVI->getIndices()[0] == 0 && ACXI->getCompareOperand() == Op1 && 6216 !ACXI->isWeak()) 6217 return ExtractValueInst::Create(ACXI, 1); 6218 6219 { 6220 Value *X; 6221 const APInt *C; 6222 // icmp X+Cst, X 6223 if (match(Op0, m_Add(m_Value(X), m_APInt(C))) && Op1 == X) 6224 return foldICmpAddOpConst(X, *C, I.getPredicate()); 6225 6226 // icmp X, X+Cst 6227 if (match(Op1, m_Add(m_Value(X), m_APInt(C))) && Op0 == X) 6228 return foldICmpAddOpConst(X, *C, I.getSwappedPredicate()); 6229 } 6230 6231 if (Instruction *Res = foldICmpWithHighBitMask(I, Builder)) 6232 return Res; 6233 6234 if (I.getType()->isVectorTy()) 6235 if (Instruction *Res = foldVectorCmp(I, Builder)) 6236 return Res; 6237 6238 if (Instruction *Res = foldICmpInvariantGroup(I)) 6239 return Res; 6240 6241 if (Instruction *Res = foldReductionIdiom(I, Builder, DL)) 6242 return Res; 6243 6244 return Changed ? &I : nullptr; 6245 } 6246 6247 /// Fold fcmp ([us]itofp x, cst) if possible. 6248 Instruction *InstCombinerImpl::foldFCmpIntToFPConst(FCmpInst &I, 6249 Instruction *LHSI, 6250 Constant *RHSC) { 6251 if (!isa<ConstantFP>(RHSC)) return nullptr; 6252 const APFloat &RHS = cast<ConstantFP>(RHSC)->getValueAPF(); 6253 6254 // Get the width of the mantissa. We don't want to hack on conversions that 6255 // might lose information from the integer, e.g. "i64 -> float" 6256 int MantissaWidth = LHSI->getType()->getFPMantissaWidth(); 6257 if (MantissaWidth == -1) return nullptr; // Unknown. 6258 6259 IntegerType *IntTy = cast<IntegerType>(LHSI->getOperand(0)->getType()); 6260 6261 bool LHSUnsigned = isa<UIToFPInst>(LHSI); 6262 6263 if (I.isEquality()) { 6264 FCmpInst::Predicate P = I.getPredicate(); 6265 bool IsExact = false; 6266 APSInt RHSCvt(IntTy->getBitWidth(), LHSUnsigned); 6267 RHS.convertToInteger(RHSCvt, APFloat::rmNearestTiesToEven, &IsExact); 6268 6269 // If the floating point constant isn't an integer value, we know if we will 6270 // ever compare equal / not equal to it. 6271 if (!IsExact) { 6272 // TODO: Can never be -0.0 and other non-representable values 6273 APFloat RHSRoundInt(RHS); 6274 RHSRoundInt.roundToIntegral(APFloat::rmNearestTiesToEven); 6275 if (RHS != RHSRoundInt) { 6276 if (P == FCmpInst::FCMP_OEQ || P == FCmpInst::FCMP_UEQ) 6277 return replaceInstUsesWith(I, Builder.getFalse()); 6278 6279 assert(P == FCmpInst::FCMP_ONE || P == FCmpInst::FCMP_UNE); 6280 return replaceInstUsesWith(I, Builder.getTrue()); 6281 } 6282 } 6283 6284 // TODO: If the constant is exactly representable, is it always OK to do 6285 // equality compares as integer? 6286 } 6287 6288 // Check to see that the input is converted from an integer type that is small 6289 // enough that preserves all bits. TODO: check here for "known" sign bits. 6290 // This would allow us to handle (fptosi (x >>s 62) to float) if x is i64 f.e. 6291 unsigned InputSize = IntTy->getScalarSizeInBits(); 6292 6293 // Following test does NOT adjust InputSize downwards for signed inputs, 6294 // because the most negative value still requires all the mantissa bits 6295 // to distinguish it from one less than that value. 6296 if ((int)InputSize > MantissaWidth) { 6297 // Conversion would lose accuracy. Check if loss can impact comparison. 6298 int Exp = ilogb(RHS); 6299 if (Exp == APFloat::IEK_Inf) { 6300 int MaxExponent = ilogb(APFloat::getLargest(RHS.getSemantics())); 6301 if (MaxExponent < (int)InputSize - !LHSUnsigned) 6302 // Conversion could create infinity. 6303 return nullptr; 6304 } else { 6305 // Note that if RHS is zero or NaN, then Exp is negative 6306 // and first condition is trivially false. 6307 if (MantissaWidth <= Exp && Exp <= (int)InputSize - !LHSUnsigned) 6308 // Conversion could affect comparison. 6309 return nullptr; 6310 } 6311 } 6312 6313 // Otherwise, we can potentially simplify the comparison. We know that it 6314 // will always come through as an integer value and we know the constant is 6315 // not a NAN (it would have been previously simplified). 6316 assert(!RHS.isNaN() && "NaN comparison not already folded!"); 6317 6318 ICmpInst::Predicate Pred; 6319 switch (I.getPredicate()) { 6320 default: llvm_unreachable("Unexpected predicate!"); 6321 case FCmpInst::FCMP_UEQ: 6322 case FCmpInst::FCMP_OEQ: 6323 Pred = ICmpInst::ICMP_EQ; 6324 break; 6325 case FCmpInst::FCMP_UGT: 6326 case FCmpInst::FCMP_OGT: 6327 Pred = LHSUnsigned ? ICmpInst::ICMP_UGT : ICmpInst::ICMP_SGT; 6328 break; 6329 case FCmpInst::FCMP_UGE: 6330 case FCmpInst::FCMP_OGE: 6331 Pred = LHSUnsigned ? ICmpInst::ICMP_UGE : ICmpInst::ICMP_SGE; 6332 break; 6333 case FCmpInst::FCMP_ULT: 6334 case FCmpInst::FCMP_OLT: 6335 Pred = LHSUnsigned ? ICmpInst::ICMP_ULT : ICmpInst::ICMP_SLT; 6336 break; 6337 case FCmpInst::FCMP_ULE: 6338 case FCmpInst::FCMP_OLE: 6339 Pred = LHSUnsigned ? ICmpInst::ICMP_ULE : ICmpInst::ICMP_SLE; 6340 break; 6341 case FCmpInst::FCMP_UNE: 6342 case FCmpInst::FCMP_ONE: 6343 Pred = ICmpInst::ICMP_NE; 6344 break; 6345 case FCmpInst::FCMP_ORD: 6346 return replaceInstUsesWith(I, Builder.getTrue()); 6347 case FCmpInst::FCMP_UNO: 6348 return replaceInstUsesWith(I, Builder.getFalse()); 6349 } 6350 6351 // Now we know that the APFloat is a normal number, zero or inf. 6352 6353 // See if the FP constant is too large for the integer. For example, 6354 // comparing an i8 to 300.0. 6355 unsigned IntWidth = IntTy->getScalarSizeInBits(); 6356 6357 if (!LHSUnsigned) { 6358 // If the RHS value is > SignedMax, fold the comparison. This handles +INF 6359 // and large values. 6360 APFloat SMax(RHS.getSemantics()); 6361 SMax.convertFromAPInt(APInt::getSignedMaxValue(IntWidth), true, 6362 APFloat::rmNearestTiesToEven); 6363 if (SMax < RHS) { // smax < 13123.0 6364 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SLT || 6365 Pred == ICmpInst::ICMP_SLE) 6366 return replaceInstUsesWith(I, Builder.getTrue()); 6367 return replaceInstUsesWith(I, Builder.getFalse()); 6368 } 6369 } else { 6370 // If the RHS value is > UnsignedMax, fold the comparison. This handles 6371 // +INF and large values. 6372 APFloat UMax(RHS.getSemantics()); 6373 UMax.convertFromAPInt(APInt::getMaxValue(IntWidth), false, 6374 APFloat::rmNearestTiesToEven); 6375 if (UMax < RHS) { // umax < 13123.0 6376 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_ULT || 6377 Pred == ICmpInst::ICMP_ULE) 6378 return replaceInstUsesWith(I, Builder.getTrue()); 6379 return replaceInstUsesWith(I, Builder.getFalse()); 6380 } 6381 } 6382 6383 if (!LHSUnsigned) { 6384 // See if the RHS value is < SignedMin. 6385 APFloat SMin(RHS.getSemantics()); 6386 SMin.convertFromAPInt(APInt::getSignedMinValue(IntWidth), true, 6387 APFloat::rmNearestTiesToEven); 6388 if (SMin > RHS) { // smin > 12312.0 6389 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_SGT || 6390 Pred == ICmpInst::ICMP_SGE) 6391 return replaceInstUsesWith(I, Builder.getTrue()); 6392 return replaceInstUsesWith(I, Builder.getFalse()); 6393 } 6394 } else { 6395 // See if the RHS value is < UnsignedMin. 6396 APFloat UMin(RHS.getSemantics()); 6397 UMin.convertFromAPInt(APInt::getMinValue(IntWidth), false, 6398 APFloat::rmNearestTiesToEven); 6399 if (UMin > RHS) { // umin > 12312.0 6400 if (Pred == ICmpInst::ICMP_NE || Pred == ICmpInst::ICMP_UGT || 6401 Pred == ICmpInst::ICMP_UGE) 6402 return replaceInstUsesWith(I, Builder.getTrue()); 6403 return replaceInstUsesWith(I, Builder.getFalse()); 6404 } 6405 } 6406 6407 // Okay, now we know that the FP constant fits in the range [SMIN, SMAX] or 6408 // [0, UMAX], but it may still be fractional. See if it is fractional by 6409 // casting the FP value to the integer value and back, checking for equality. 6410 // Don't do this for zero, because -0.0 is not fractional. 6411 Constant *RHSInt = LHSUnsigned 6412 ? ConstantExpr::getFPToUI(RHSC, IntTy) 6413 : ConstantExpr::getFPToSI(RHSC, IntTy); 6414 if (!RHS.isZero()) { 6415 bool Equal = LHSUnsigned 6416 ? ConstantExpr::getUIToFP(RHSInt, RHSC->getType()) == RHSC 6417 : ConstantExpr::getSIToFP(RHSInt, RHSC->getType()) == RHSC; 6418 if (!Equal) { 6419 // If we had a comparison against a fractional value, we have to adjust 6420 // the compare predicate and sometimes the value. RHSC is rounded towards 6421 // zero at this point. 6422 switch (Pred) { 6423 default: llvm_unreachable("Unexpected integer comparison!"); 6424 case ICmpInst::ICMP_NE: // (float)int != 4.4 --> true 6425 return replaceInstUsesWith(I, Builder.getTrue()); 6426 case ICmpInst::ICMP_EQ: // (float)int == 4.4 --> false 6427 return replaceInstUsesWith(I, Builder.getFalse()); 6428 case ICmpInst::ICMP_ULE: 6429 // (float)int <= 4.4 --> int <= 4 6430 // (float)int <= -4.4 --> false 6431 if (RHS.isNegative()) 6432 return replaceInstUsesWith(I, Builder.getFalse()); 6433 break; 6434 case ICmpInst::ICMP_SLE: 6435 // (float)int <= 4.4 --> int <= 4 6436 // (float)int <= -4.4 --> int < -4 6437 if (RHS.isNegative()) 6438 Pred = ICmpInst::ICMP_SLT; 6439 break; 6440 case ICmpInst::ICMP_ULT: 6441 // (float)int < -4.4 --> false 6442 // (float)int < 4.4 --> int <= 4 6443 if (RHS.isNegative()) 6444 return replaceInstUsesWith(I, Builder.getFalse()); 6445 Pred = ICmpInst::ICMP_ULE; 6446 break; 6447 case ICmpInst::ICMP_SLT: 6448 // (float)int < -4.4 --> int < -4 6449 // (float)int < 4.4 --> int <= 4 6450 if (!RHS.isNegative()) 6451 Pred = ICmpInst::ICMP_SLE; 6452 break; 6453 case ICmpInst::ICMP_UGT: 6454 // (float)int > 4.4 --> int > 4 6455 // (float)int > -4.4 --> true 6456 if (RHS.isNegative()) 6457 return replaceInstUsesWith(I, Builder.getTrue()); 6458 break; 6459 case ICmpInst::ICMP_SGT: 6460 // (float)int > 4.4 --> int > 4 6461 // (float)int > -4.4 --> int >= -4 6462 if (RHS.isNegative()) 6463 Pred = ICmpInst::ICMP_SGE; 6464 break; 6465 case ICmpInst::ICMP_UGE: 6466 // (float)int >= -4.4 --> true 6467 // (float)int >= 4.4 --> int > 4 6468 if (RHS.isNegative()) 6469 return replaceInstUsesWith(I, Builder.getTrue()); 6470 Pred = ICmpInst::ICMP_UGT; 6471 break; 6472 case ICmpInst::ICMP_SGE: 6473 // (float)int >= -4.4 --> int >= -4 6474 // (float)int >= 4.4 --> int > 4 6475 if (!RHS.isNegative()) 6476 Pred = ICmpInst::ICMP_SGT; 6477 break; 6478 } 6479 } 6480 } 6481 6482 // Lower this FP comparison into an appropriate integer version of the 6483 // comparison. 6484 return new ICmpInst(Pred, LHSI->getOperand(0), RHSInt); 6485 } 6486 6487 /// Fold (C / X) < 0.0 --> X < 0.0 if possible. Swap predicate if necessary. 6488 static Instruction *foldFCmpReciprocalAndZero(FCmpInst &I, Instruction *LHSI, 6489 Constant *RHSC) { 6490 // When C is not 0.0 and infinities are not allowed: 6491 // (C / X) < 0.0 is a sign-bit test of X 6492 // (C / X) < 0.0 --> X < 0.0 (if C is positive) 6493 // (C / X) < 0.0 --> X > 0.0 (if C is negative, swap the predicate) 6494 // 6495 // Proof: 6496 // Multiply (C / X) < 0.0 by X * X / C. 6497 // - X is non zero, if it is the flag 'ninf' is violated. 6498 // - C defines the sign of X * X * C. Thus it also defines whether to swap 6499 // the predicate. C is also non zero by definition. 6500 // 6501 // Thus X * X / C is non zero and the transformation is valid. [qed] 6502 6503 FCmpInst::Predicate Pred = I.getPredicate(); 6504 6505 // Check that predicates are valid. 6506 if ((Pred != FCmpInst::FCMP_OGT) && (Pred != FCmpInst::FCMP_OLT) && 6507 (Pred != FCmpInst::FCMP_OGE) && (Pred != FCmpInst::FCMP_OLE)) 6508 return nullptr; 6509 6510 // Check that RHS operand is zero. 6511 if (!match(RHSC, m_AnyZeroFP())) 6512 return nullptr; 6513 6514 // Check fastmath flags ('ninf'). 6515 if (!LHSI->hasNoInfs() || !I.hasNoInfs()) 6516 return nullptr; 6517 6518 // Check the properties of the dividend. It must not be zero to avoid a 6519 // division by zero (see Proof). 6520 const APFloat *C; 6521 if (!match(LHSI->getOperand(0), m_APFloat(C))) 6522 return nullptr; 6523 6524 if (C->isZero()) 6525 return nullptr; 6526 6527 // Get swapped predicate if necessary. 6528 if (C->isNegative()) 6529 Pred = I.getSwappedPredicate(); 6530 6531 return new FCmpInst(Pred, LHSI->getOperand(1), RHSC, "", &I); 6532 } 6533 6534 /// Optimize fabs(X) compared with zero. 6535 static Instruction *foldFabsWithFcmpZero(FCmpInst &I, InstCombinerImpl &IC) { 6536 Value *X; 6537 if (!match(I.getOperand(0), m_FAbs(m_Value(X))) || 6538 !match(I.getOperand(1), m_PosZeroFP())) 6539 return nullptr; 6540 6541 auto replacePredAndOp0 = [&IC](FCmpInst *I, FCmpInst::Predicate P, Value *X) { 6542 I->setPredicate(P); 6543 return IC.replaceOperand(*I, 0, X); 6544 }; 6545 6546 switch (I.getPredicate()) { 6547 case FCmpInst::FCMP_UGE: 6548 case FCmpInst::FCMP_OLT: 6549 // fabs(X) >= 0.0 --> true 6550 // fabs(X) < 0.0 --> false 6551 llvm_unreachable("fcmp should have simplified"); 6552 6553 case FCmpInst::FCMP_OGT: 6554 // fabs(X) > 0.0 --> X != 0.0 6555 return replacePredAndOp0(&I, FCmpInst::FCMP_ONE, X); 6556 6557 case FCmpInst::FCMP_UGT: 6558 // fabs(X) u> 0.0 --> X u!= 0.0 6559 return replacePredAndOp0(&I, FCmpInst::FCMP_UNE, X); 6560 6561 case FCmpInst::FCMP_OLE: 6562 // fabs(X) <= 0.0 --> X == 0.0 6563 return replacePredAndOp0(&I, FCmpInst::FCMP_OEQ, X); 6564 6565 case FCmpInst::FCMP_ULE: 6566 // fabs(X) u<= 0.0 --> X u== 0.0 6567 return replacePredAndOp0(&I, FCmpInst::FCMP_UEQ, X); 6568 6569 case FCmpInst::FCMP_OGE: 6570 // fabs(X) >= 0.0 --> !isnan(X) 6571 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6572 return replacePredAndOp0(&I, FCmpInst::FCMP_ORD, X); 6573 6574 case FCmpInst::FCMP_ULT: 6575 // fabs(X) u< 0.0 --> isnan(X) 6576 assert(!I.hasNoNaNs() && "fcmp should have simplified"); 6577 return replacePredAndOp0(&I, FCmpInst::FCMP_UNO, X); 6578 6579 case FCmpInst::FCMP_OEQ: 6580 case FCmpInst::FCMP_UEQ: 6581 case FCmpInst::FCMP_ONE: 6582 case FCmpInst::FCMP_UNE: 6583 case FCmpInst::FCMP_ORD: 6584 case FCmpInst::FCMP_UNO: 6585 // Look through the fabs() because it doesn't change anything but the sign. 6586 // fabs(X) == 0.0 --> X == 0.0, 6587 // fabs(X) != 0.0 --> X != 0.0 6588 // isnan(fabs(X)) --> isnan(X) 6589 // !isnan(fabs(X) --> !isnan(X) 6590 return replacePredAndOp0(&I, I.getPredicate(), X); 6591 6592 default: 6593 return nullptr; 6594 } 6595 } 6596 6597 static Instruction *foldFCmpFNegCommonOp(FCmpInst &I) { 6598 CmpInst::Predicate Pred = I.getPredicate(); 6599 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6600 6601 // Canonicalize fneg as Op1. 6602 if (match(Op0, m_FNeg(m_Value())) && !match(Op1, m_FNeg(m_Value()))) { 6603 std::swap(Op0, Op1); 6604 Pred = I.getSwappedPredicate(); 6605 } 6606 6607 if (!match(Op1, m_FNeg(m_Specific(Op0)))) 6608 return nullptr; 6609 6610 // Replace the negated operand with 0.0: 6611 // fcmp Pred Op0, -Op0 --> fcmp Pred Op0, 0.0 6612 Constant *Zero = ConstantFP::getNullValue(Op0->getType()); 6613 return new FCmpInst(Pred, Op0, Zero, "", &I); 6614 } 6615 6616 Instruction *InstCombinerImpl::visitFCmpInst(FCmpInst &I) { 6617 bool Changed = false; 6618 6619 /// Orders the operands of the compare so that they are listed from most 6620 /// complex to least complex. This puts constants before unary operators, 6621 /// before binary operators. 6622 if (getComplexity(I.getOperand(0)) < getComplexity(I.getOperand(1))) { 6623 I.swapOperands(); 6624 Changed = true; 6625 } 6626 6627 const CmpInst::Predicate Pred = I.getPredicate(); 6628 Value *Op0 = I.getOperand(0), *Op1 = I.getOperand(1); 6629 if (Value *V = SimplifyFCmpInst(Pred, Op0, Op1, I.getFastMathFlags(), 6630 SQ.getWithInstruction(&I))) 6631 return replaceInstUsesWith(I, V); 6632 6633 // Simplify 'fcmp pred X, X' 6634 Type *OpType = Op0->getType(); 6635 assert(OpType == Op1->getType() && "fcmp with different-typed operands?"); 6636 if (Op0 == Op1) { 6637 switch (Pred) { 6638 default: break; 6639 case FCmpInst::FCMP_UNO: // True if unordered: isnan(X) | isnan(Y) 6640 case FCmpInst::FCMP_ULT: // True if unordered or less than 6641 case FCmpInst::FCMP_UGT: // True if unordered or greater than 6642 case FCmpInst::FCMP_UNE: // True if unordered or not equal 6643 // Canonicalize these to be 'fcmp uno %X, 0.0'. 6644 I.setPredicate(FCmpInst::FCMP_UNO); 6645 I.setOperand(1, Constant::getNullValue(OpType)); 6646 return &I; 6647 6648 case FCmpInst::FCMP_ORD: // True if ordered (no nans) 6649 case FCmpInst::FCMP_OEQ: // True if ordered and equal 6650 case FCmpInst::FCMP_OGE: // True if ordered and greater than or equal 6651 case FCmpInst::FCMP_OLE: // True if ordered and less than or equal 6652 // Canonicalize these to be 'fcmp ord %X, 0.0'. 6653 I.setPredicate(FCmpInst::FCMP_ORD); 6654 I.setOperand(1, Constant::getNullValue(OpType)); 6655 return &I; 6656 } 6657 } 6658 6659 // If we're just checking for a NaN (ORD/UNO) and have a non-NaN operand, 6660 // then canonicalize the operand to 0.0. 6661 if (Pred == CmpInst::FCMP_ORD || Pred == CmpInst::FCMP_UNO) { 6662 if (!match(Op0, m_PosZeroFP()) && isKnownNeverNaN(Op0, &TLI)) 6663 return replaceOperand(I, 0, ConstantFP::getNullValue(OpType)); 6664 6665 if (!match(Op1, m_PosZeroFP()) && isKnownNeverNaN(Op1, &TLI)) 6666 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6667 } 6668 6669 // fcmp pred (fneg X), (fneg Y) -> fcmp swap(pred) X, Y 6670 Value *X, *Y; 6671 if (match(Op0, m_FNeg(m_Value(X))) && match(Op1, m_FNeg(m_Value(Y)))) 6672 return new FCmpInst(I.getSwappedPredicate(), X, Y, "", &I); 6673 6674 if (Instruction *R = foldFCmpFNegCommonOp(I)) 6675 return R; 6676 6677 // Test if the FCmpInst instruction is used exclusively by a select as 6678 // part of a minimum or maximum operation. If so, refrain from doing 6679 // any other folding. This helps out other analyses which understand 6680 // non-obfuscated minimum and maximum idioms, such as ScalarEvolution 6681 // and CodeGen. And in this case, at least one of the comparison 6682 // operands has at least one user besides the compare (the select), 6683 // which would often largely negate the benefit of folding anyway. 6684 if (I.hasOneUse()) 6685 if (SelectInst *SI = dyn_cast<SelectInst>(I.user_back())) { 6686 Value *A, *B; 6687 SelectPatternResult SPR = matchSelectPattern(SI, A, B); 6688 if (SPR.Flavor != SPF_UNKNOWN) 6689 return nullptr; 6690 } 6691 6692 // The sign of 0.0 is ignored by fcmp, so canonicalize to +0.0: 6693 // fcmp Pred X, -0.0 --> fcmp Pred X, 0.0 6694 if (match(Op1, m_AnyZeroFP()) && !match(Op1, m_PosZeroFP())) 6695 return replaceOperand(I, 1, ConstantFP::getNullValue(OpType)); 6696 6697 // Handle fcmp with instruction LHS and constant RHS. 6698 Instruction *LHSI; 6699 Constant *RHSC; 6700 if (match(Op0, m_Instruction(LHSI)) && match(Op1, m_Constant(RHSC))) { 6701 switch (LHSI->getOpcode()) { 6702 case Instruction::PHI: 6703 // Only fold fcmp into the PHI if the phi and fcmp are in the same 6704 // block. If in the same block, we're encouraging jump threading. If 6705 // not, we are just pessimizing the code by making an i1 phi. 6706 if (LHSI->getParent() == I.getParent()) 6707 if (Instruction *NV = foldOpIntoPhi(I, cast<PHINode>(LHSI))) 6708 return NV; 6709 break; 6710 case Instruction::SIToFP: 6711 case Instruction::UIToFP: 6712 if (Instruction *NV = foldFCmpIntToFPConst(I, LHSI, RHSC)) 6713 return NV; 6714 break; 6715 case Instruction::FDiv: 6716 if (Instruction *NV = foldFCmpReciprocalAndZero(I, LHSI, RHSC)) 6717 return NV; 6718 break; 6719 case Instruction::Load: 6720 if (auto *GEP = dyn_cast<GetElementPtrInst>(LHSI->getOperand(0))) 6721 if (auto *GV = dyn_cast<GlobalVariable>(GEP->getOperand(0))) 6722 if (Instruction *Res = foldCmpLoadFromIndexedGlobal( 6723 cast<LoadInst>(LHSI), GEP, GV, I)) 6724 return Res; 6725 break; 6726 } 6727 } 6728 6729 if (Instruction *R = foldFabsWithFcmpZero(I, *this)) 6730 return R; 6731 6732 if (match(Op0, m_FNeg(m_Value(X)))) { 6733 // fcmp pred (fneg X), C --> fcmp swap(pred) X, -C 6734 Constant *C; 6735 if (match(Op1, m_Constant(C))) { 6736 Constant *NegC = ConstantExpr::getFNeg(C); 6737 return new FCmpInst(I.getSwappedPredicate(), X, NegC, "", &I); 6738 } 6739 } 6740 6741 if (match(Op0, m_FPExt(m_Value(X)))) { 6742 // fcmp (fpext X), (fpext Y) -> fcmp X, Y 6743 if (match(Op1, m_FPExt(m_Value(Y))) && X->getType() == Y->getType()) 6744 return new FCmpInst(Pred, X, Y, "", &I); 6745 6746 const APFloat *C; 6747 if (match(Op1, m_APFloat(C))) { 6748 const fltSemantics &FPSem = 6749 X->getType()->getScalarType()->getFltSemantics(); 6750 bool Lossy; 6751 APFloat TruncC = *C; 6752 TruncC.convert(FPSem, APFloat::rmNearestTiesToEven, &Lossy); 6753 6754 if (Lossy) { 6755 // X can't possibly equal the higher-precision constant, so reduce any 6756 // equality comparison. 6757 // TODO: Other predicates can be handled via getFCmpCode(). 6758 switch (Pred) { 6759 case FCmpInst::FCMP_OEQ: 6760 // X is ordered and equal to an impossible constant --> false 6761 return replaceInstUsesWith(I, ConstantInt::getFalse(I.getType())); 6762 case FCmpInst::FCMP_ONE: 6763 // X is ordered and not equal to an impossible constant --> ordered 6764 return new FCmpInst(FCmpInst::FCMP_ORD, X, 6765 ConstantFP::getNullValue(X->getType())); 6766 case FCmpInst::FCMP_UEQ: 6767 // X is unordered or equal to an impossible constant --> unordered 6768 return new FCmpInst(FCmpInst::FCMP_UNO, X, 6769 ConstantFP::getNullValue(X->getType())); 6770 case FCmpInst::FCMP_UNE: 6771 // X is unordered or not equal to an impossible constant --> true 6772 return replaceInstUsesWith(I, ConstantInt::getTrue(I.getType())); 6773 default: 6774 break; 6775 } 6776 } 6777 6778 // fcmp (fpext X), C -> fcmp X, (fptrunc C) if fptrunc is lossless 6779 // Avoid lossy conversions and denormals. 6780 // Zero is a special case that's OK to convert. 6781 APFloat Fabs = TruncC; 6782 Fabs.clearSign(); 6783 if (!Lossy && 6784 (!(Fabs < APFloat::getSmallestNormalized(FPSem)) || Fabs.isZero())) { 6785 Constant *NewC = ConstantFP::get(X->getType(), TruncC); 6786 return new FCmpInst(Pred, X, NewC, "", &I); 6787 } 6788 } 6789 } 6790 6791 // Convert a sign-bit test of an FP value into a cast and integer compare. 6792 // TODO: Simplify if the copysign constant is 0.0 or NaN. 6793 // TODO: Handle non-zero compare constants. 6794 // TODO: Handle other predicates. 6795 const APFloat *C; 6796 if (match(Op0, m_OneUse(m_Intrinsic<Intrinsic::copysign>(m_APFloat(C), 6797 m_Value(X)))) && 6798 match(Op1, m_AnyZeroFP()) && !C->isZero() && !C->isNaN()) { 6799 Type *IntType = Builder.getIntNTy(X->getType()->getScalarSizeInBits()); 6800 if (auto *VecTy = dyn_cast<VectorType>(OpType)) 6801 IntType = VectorType::get(IntType, VecTy->getElementCount()); 6802 6803 // copysign(non-zero constant, X) < 0.0 --> (bitcast X) < 0 6804 if (Pred == FCmpInst::FCMP_OLT) { 6805 Value *IntX = Builder.CreateBitCast(X, IntType); 6806 return new ICmpInst(ICmpInst::ICMP_SLT, IntX, 6807 ConstantInt::getNullValue(IntType)); 6808 } 6809 } 6810 6811 if (I.getType()->isVectorTy()) 6812 if (Instruction *Res = foldVectorCmp(I, Builder)) 6813 return Res; 6814 6815 return Changed ? &I : nullptr; 6816 } 6817