1 //===- ArgumentPromotion.cpp - Promote by-reference arguments -------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 //
9 // This pass promotes "by reference" arguments to be "by value" arguments.  In
10 // practice, this means looking for internal functions that have pointer
11 // arguments.  If it can prove, through the use of alias analysis, that an
12 // argument is *only* loaded, then it can pass the value into the function
13 // instead of the address of the value.  This can cause recursive simplification
14 // of code and lead to the elimination of allocas (especially in C++ template
15 // code like the STL).
16 //
17 // This pass also handles aggregate arguments that are passed into a function,
18 // scalarizing them if the elements of the aggregate are only loaded.  Note that
19 // by default it refuses to scalarize aggregates which would require passing in
20 // more than three operands to the function, because passing thousands of
21 // operands for a large array or structure is unprofitable! This limit can be
22 // configured or disabled, however.
23 //
24 // Note that this transformation could also be done for arguments that are only
25 // stored to (returning the value instead), but does not currently.  This case
26 // would be best handled when and if LLVM begins supporting multiple return
27 // values from functions.
28 //
29 //===----------------------------------------------------------------------===//
30 
31 #include "llvm/Transforms/IPO/ArgumentPromotion.h"
32 #include "llvm/ADT/DepthFirstIterator.h"
33 #include "llvm/ADT/None.h"
34 #include "llvm/ADT/Optional.h"
35 #include "llvm/ADT/STLExtras.h"
36 #include "llvm/ADT/ScopeExit.h"
37 #include "llvm/ADT/SmallPtrSet.h"
38 #include "llvm/ADT/SmallVector.h"
39 #include "llvm/ADT/Statistic.h"
40 #include "llvm/ADT/Twine.h"
41 #include "llvm/Analysis/AssumptionCache.h"
42 #include "llvm/Analysis/BasicAliasAnalysis.h"
43 #include "llvm/Analysis/CGSCCPassManager.h"
44 #include "llvm/Analysis/CallGraph.h"
45 #include "llvm/Analysis/CallGraphSCCPass.h"
46 #include "llvm/Analysis/LazyCallGraph.h"
47 #include "llvm/Analysis/Loads.h"
48 #include "llvm/Analysis/MemoryLocation.h"
49 #include "llvm/Analysis/TargetLibraryInfo.h"
50 #include "llvm/Analysis/TargetTransformInfo.h"
51 #include "llvm/IR/Argument.h"
52 #include "llvm/IR/Attributes.h"
53 #include "llvm/IR/BasicBlock.h"
54 #include "llvm/IR/CFG.h"
55 #include "llvm/IR/Constants.h"
56 #include "llvm/IR/DataLayout.h"
57 #include "llvm/IR/DerivedTypes.h"
58 #include "llvm/IR/Function.h"
59 #include "llvm/IR/IRBuilder.h"
60 #include "llvm/IR/InstrTypes.h"
61 #include "llvm/IR/Instruction.h"
62 #include "llvm/IR/Instructions.h"
63 #include "llvm/IR/Metadata.h"
64 #include "llvm/IR/Module.h"
65 #include "llvm/IR/NoFolder.h"
66 #include "llvm/IR/PassManager.h"
67 #include "llvm/IR/Type.h"
68 #include "llvm/IR/Use.h"
69 #include "llvm/IR/User.h"
70 #include "llvm/IR/Value.h"
71 #include "llvm/InitializePasses.h"
72 #include "llvm/Pass.h"
73 #include "llvm/Support/Casting.h"
74 #include "llvm/Support/Debug.h"
75 #include "llvm/Support/FormatVariadic.h"
76 #include "llvm/Support/raw_ostream.h"
77 #include "llvm/Transforms/IPO.h"
78 #include <algorithm>
79 #include <cassert>
80 #include <cstdint>
81 #include <functional>
82 #include <iterator>
83 #include <map>
84 #include <set>
85 #include <string>
86 #include <utility>
87 #include <vector>
88 
89 using namespace llvm;
90 
91 #define DEBUG_TYPE "argpromotion"
92 
93 STATISTIC(NumArgumentsPromoted, "Number of pointer arguments promoted");
94 STATISTIC(NumAggregatesPromoted, "Number of aggregate arguments promoted");
95 STATISTIC(NumByValArgsPromoted, "Number of byval arguments promoted");
96 STATISTIC(NumArgumentsDead, "Number of dead pointer args eliminated");
97 
98 /// A vector used to hold the indices of a single GEP instruction
99 using IndicesVector = std::vector<uint64_t>;
100 
101 /// DoPromotion - This method actually performs the promotion of the specified
102 /// arguments, and returns the new function.  At this point, we know that it's
103 /// safe to do so.
104 static Function *
105 doPromotion(Function *F, SmallPtrSetImpl<Argument *> &ArgsToPromote,
106             SmallPtrSetImpl<Argument *> &ByValArgsToTransform,
107             Optional<function_ref<void(CallBase &OldCS, CallBase &NewCS)>>
108                 ReplaceCallSite) {
109   // Start by computing a new prototype for the function, which is the same as
110   // the old function, but has modified arguments.
111   FunctionType *FTy = F->getFunctionType();
112   std::vector<Type *> Params;
113 
114   using ScalarizeTable = std::set<std::pair<Type *, IndicesVector>>;
115 
116   // ScalarizedElements - If we are promoting a pointer that has elements
117   // accessed out of it, keep track of which elements are accessed so that we
118   // can add one argument for each.
119   //
120   // Arguments that are directly loaded will have a zero element value here, to
121   // handle cases where there are both a direct load and GEP accesses.
122   std::map<Argument *, ScalarizeTable> ScalarizedElements;
123 
124   // OriginalLoads - Keep track of a representative load instruction from the
125   // original function so that we can tell the alias analysis implementation
126   // what the new GEP/Load instructions we are inserting look like.
127   // We need to keep the original loads for each argument and the elements
128   // of the argument that are accessed.
129   std::map<std::pair<Argument *, IndicesVector>, LoadInst *> OriginalLoads;
130 
131   // Attribute - Keep track of the parameter attributes for the arguments
132   // that we are *not* promoting. For the ones that we do promote, the parameter
133   // attributes are lost
134   SmallVector<AttributeSet, 8> ArgAttrVec;
135   AttributeList PAL = F->getAttributes();
136 
137   // First, determine the new argument list
138   unsigned ArgNo = 0;
139   for (Function::arg_iterator I = F->arg_begin(), E = F->arg_end(); I != E;
140        ++I, ++ArgNo) {
141     if (ByValArgsToTransform.count(&*I)) {
142       // Simple byval argument? Just add all the struct element types.
143       Type *AgTy = cast<PointerType>(I->getType())->getElementType();
144       StructType *STy = cast<StructType>(AgTy);
145       llvm::append_range(Params, STy->elements());
146       ArgAttrVec.insert(ArgAttrVec.end(), STy->getNumElements(),
147                         AttributeSet());
148       ++NumByValArgsPromoted;
149     } else if (!ArgsToPromote.count(&*I)) {
150       // Unchanged argument
151       Params.push_back(I->getType());
152       ArgAttrVec.push_back(PAL.getParamAttributes(ArgNo));
153     } else if (I->use_empty()) {
154       // Dead argument (which are always marked as promotable)
155       ++NumArgumentsDead;
156     } else {
157       // Okay, this is being promoted. This means that the only uses are loads
158       // or GEPs which are only used by loads
159 
160       // In this table, we will track which indices are loaded from the argument
161       // (where direct loads are tracked as no indices).
162       ScalarizeTable &ArgIndices = ScalarizedElements[&*I];
163       for (User *U : I->users()) {
164         Instruction *UI = cast<Instruction>(U);
165         Type *SrcTy;
166         if (LoadInst *L = dyn_cast<LoadInst>(UI))
167           SrcTy = L->getType();
168         else
169           SrcTy = cast<GetElementPtrInst>(UI)->getSourceElementType();
170         IndicesVector Indices;
171         Indices.reserve(UI->getNumOperands() - 1);
172         // Since loads will only have a single operand, and GEPs only a single
173         // non-index operand, this will record direct loads without any indices,
174         // and gep+loads with the GEP indices.
175         for (User::op_iterator II = UI->op_begin() + 1, IE = UI->op_end();
176              II != IE; ++II)
177           Indices.push_back(cast<ConstantInt>(*II)->getSExtValue());
178         // GEPs with a single 0 index can be merged with direct loads
179         if (Indices.size() == 1 && Indices.front() == 0)
180           Indices.clear();
181         ArgIndices.insert(std::make_pair(SrcTy, Indices));
182         LoadInst *OrigLoad;
183         if (LoadInst *L = dyn_cast<LoadInst>(UI))
184           OrigLoad = L;
185         else
186           // Take any load, we will use it only to update Alias Analysis
187           OrigLoad = cast<LoadInst>(UI->user_back());
188         OriginalLoads[std::make_pair(&*I, Indices)] = OrigLoad;
189       }
190 
191       // Add a parameter to the function for each element passed in.
192       for (const auto &ArgIndex : ArgIndices) {
193         // not allowed to dereference ->begin() if size() is 0
194         Params.push_back(GetElementPtrInst::getIndexedType(
195             cast<PointerType>(I->getType())->getElementType(),
196             ArgIndex.second));
197         ArgAttrVec.push_back(AttributeSet());
198         assert(Params.back());
199       }
200 
201       if (ArgIndices.size() == 1 && ArgIndices.begin()->second.empty())
202         ++NumArgumentsPromoted;
203       else
204         ++NumAggregatesPromoted;
205     }
206   }
207 
208   Type *RetTy = FTy->getReturnType();
209 
210   // Construct the new function type using the new arguments.
211   FunctionType *NFTy = FunctionType::get(RetTy, Params, FTy->isVarArg());
212 
213   // Create the new function body and insert it into the module.
214   Function *NF = Function::Create(NFTy, F->getLinkage(), F->getAddressSpace(),
215                                   F->getName());
216   NF->copyAttributesFrom(F);
217   NF->copyMetadata(F, 0);
218 
219   // The new function will have the !dbg metadata copied from the original
220   // function. The original function may not be deleted, and dbg metadata need
221   // to be unique so we need to drop it.
222   F->setSubprogram(nullptr);
223 
224   LLVM_DEBUG(dbgs() << "ARG PROMOTION:  Promoting to:" << *NF << "\n"
225                     << "From: " << *F);
226 
227   // Recompute the parameter attributes list based on the new arguments for
228   // the function.
229   NF->setAttributes(AttributeList::get(F->getContext(), PAL.getFnAttributes(),
230                                        PAL.getRetAttributes(), ArgAttrVec));
231   ArgAttrVec.clear();
232 
233   F->getParent()->getFunctionList().insert(F->getIterator(), NF);
234   NF->takeName(F);
235 
236   // Loop over all of the callers of the function, transforming the call sites
237   // to pass in the loaded pointers.
238   //
239   SmallVector<Value *, 16> Args;
240   while (!F->use_empty()) {
241     CallBase &CB = cast<CallBase>(*F->user_back());
242     assert(CB.getCalledFunction() == F);
243     const AttributeList &CallPAL = CB.getAttributes();
244     IRBuilder<NoFolder> IRB(&CB);
245 
246     // Loop over the operands, inserting GEP and loads in the caller as
247     // appropriate.
248     auto AI = CB.arg_begin();
249     ArgNo = 0;
250     for (Function::arg_iterator I = F->arg_begin(), E = F->arg_end(); I != E;
251          ++I, ++AI, ++ArgNo)
252       if (!ArgsToPromote.count(&*I) && !ByValArgsToTransform.count(&*I)) {
253         Args.push_back(*AI); // Unmodified argument
254         ArgAttrVec.push_back(CallPAL.getParamAttributes(ArgNo));
255       } else if (ByValArgsToTransform.count(&*I)) {
256         // Emit a GEP and load for each element of the struct.
257         Type *AgTy = cast<PointerType>(I->getType())->getElementType();
258         StructType *STy = cast<StructType>(AgTy);
259         Value *Idxs[2] = {
260             ConstantInt::get(Type::getInt32Ty(F->getContext()), 0), nullptr};
261         for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) {
262           Idxs[1] = ConstantInt::get(Type::getInt32Ty(F->getContext()), i);
263           auto *Idx =
264               IRB.CreateGEP(STy, *AI, Idxs, (*AI)->getName() + "." + Twine(i));
265           // TODO: Tell AA about the new values?
266           Args.push_back(IRB.CreateLoad(STy->getElementType(i), Idx,
267                                         Idx->getName() + ".val"));
268           ArgAttrVec.push_back(AttributeSet());
269         }
270       } else if (!I->use_empty()) {
271         // Non-dead argument: insert GEPs and loads as appropriate.
272         ScalarizeTable &ArgIndices = ScalarizedElements[&*I];
273         // Store the Value* version of the indices in here, but declare it now
274         // for reuse.
275         std::vector<Value *> Ops;
276         for (const auto &ArgIndex : ArgIndices) {
277           Value *V = *AI;
278           LoadInst *OrigLoad =
279               OriginalLoads[std::make_pair(&*I, ArgIndex.second)];
280           if (!ArgIndex.second.empty()) {
281             Ops.reserve(ArgIndex.second.size());
282             Type *ElTy = V->getType();
283             for (auto II : ArgIndex.second) {
284               // Use i32 to index structs, and i64 for others (pointers/arrays).
285               // This satisfies GEP constraints.
286               Type *IdxTy =
287                   (ElTy->isStructTy() ? Type::getInt32Ty(F->getContext())
288                                       : Type::getInt64Ty(F->getContext()));
289               Ops.push_back(ConstantInt::get(IdxTy, II));
290               // Keep track of the type we're currently indexing.
291               if (auto *ElPTy = dyn_cast<PointerType>(ElTy))
292                 ElTy = ElPTy->getElementType();
293               else
294                 ElTy = GetElementPtrInst::getTypeAtIndex(ElTy, II);
295             }
296             // And create a GEP to extract those indices.
297             V = IRB.CreateGEP(ArgIndex.first, V, Ops, V->getName() + ".idx");
298             Ops.clear();
299           }
300           // Since we're replacing a load make sure we take the alignment
301           // of the previous load.
302           LoadInst *newLoad =
303               IRB.CreateLoad(OrigLoad->getType(), V, V->getName() + ".val");
304           newLoad->setAlignment(OrigLoad->getAlign());
305           // Transfer the AA info too.
306           AAMDNodes AAInfo;
307           OrigLoad->getAAMetadata(AAInfo);
308           newLoad->setAAMetadata(AAInfo);
309 
310           Args.push_back(newLoad);
311           ArgAttrVec.push_back(AttributeSet());
312         }
313       }
314 
315     // Push any varargs arguments on the list.
316     for (; AI != CB.arg_end(); ++AI, ++ArgNo) {
317       Args.push_back(*AI);
318       ArgAttrVec.push_back(CallPAL.getParamAttributes(ArgNo));
319     }
320 
321     SmallVector<OperandBundleDef, 1> OpBundles;
322     CB.getOperandBundlesAsDefs(OpBundles);
323 
324     CallBase *NewCS = nullptr;
325     if (InvokeInst *II = dyn_cast<InvokeInst>(&CB)) {
326       NewCS = InvokeInst::Create(NF, II->getNormalDest(), II->getUnwindDest(),
327                                  Args, OpBundles, "", &CB);
328     } else {
329       auto *NewCall = CallInst::Create(NF, Args, OpBundles, "", &CB);
330       NewCall->setTailCallKind(cast<CallInst>(&CB)->getTailCallKind());
331       NewCS = NewCall;
332     }
333     NewCS->setCallingConv(CB.getCallingConv());
334     NewCS->setAttributes(
335         AttributeList::get(F->getContext(), CallPAL.getFnAttributes(),
336                            CallPAL.getRetAttributes(), ArgAttrVec));
337     NewCS->copyMetadata(CB, {LLVMContext::MD_prof, LLVMContext::MD_dbg});
338     Args.clear();
339     ArgAttrVec.clear();
340 
341     // Update the callgraph to know that the callsite has been transformed.
342     if (ReplaceCallSite)
343       (*ReplaceCallSite)(CB, *NewCS);
344 
345     if (!CB.use_empty()) {
346       CB.replaceAllUsesWith(NewCS);
347       NewCS->takeName(&CB);
348     }
349 
350     // Finally, remove the old call from the program, reducing the use-count of
351     // F.
352     CB.eraseFromParent();
353   }
354 
355   const DataLayout &DL = F->getParent()->getDataLayout();
356 
357   // Since we have now created the new function, splice the body of the old
358   // function right into the new function, leaving the old rotting hulk of the
359   // function empty.
360   NF->getBasicBlockList().splice(NF->begin(), F->getBasicBlockList());
361 
362   // Loop over the argument list, transferring uses of the old arguments over to
363   // the new arguments, also transferring over the names as well.
364   for (Function::arg_iterator I = F->arg_begin(), E = F->arg_end(),
365                               I2 = NF->arg_begin();
366        I != E; ++I) {
367     if (!ArgsToPromote.count(&*I) && !ByValArgsToTransform.count(&*I)) {
368       // If this is an unmodified argument, move the name and users over to the
369       // new version.
370       I->replaceAllUsesWith(&*I2);
371       I2->takeName(&*I);
372       ++I2;
373       continue;
374     }
375 
376     if (ByValArgsToTransform.count(&*I)) {
377       // In the callee, we create an alloca, and store each of the new incoming
378       // arguments into the alloca.
379       Instruction *InsertPt = &NF->begin()->front();
380 
381       // Just add all the struct element types.
382       Type *AgTy = cast<PointerType>(I->getType())->getElementType();
383       Value *TheAlloca = new AllocaInst(
384           AgTy, DL.getAllocaAddrSpace(), nullptr,
385           I->getParamAlign().getValueOr(DL.getPrefTypeAlign(AgTy)), "",
386           InsertPt);
387       StructType *STy = cast<StructType>(AgTy);
388       Value *Idxs[2] = {ConstantInt::get(Type::getInt32Ty(F->getContext()), 0),
389                         nullptr};
390 
391       for (unsigned i = 0, e = STy->getNumElements(); i != e; ++i) {
392         Idxs[1] = ConstantInt::get(Type::getInt32Ty(F->getContext()), i);
393         Value *Idx = GetElementPtrInst::Create(
394             AgTy, TheAlloca, Idxs, TheAlloca->getName() + "." + Twine(i),
395             InsertPt);
396         I2->setName(I->getName() + "." + Twine(i));
397         new StoreInst(&*I2++, Idx, InsertPt);
398       }
399 
400       // Anything that used the arg should now use the alloca.
401       I->replaceAllUsesWith(TheAlloca);
402       TheAlloca->takeName(&*I);
403 
404       // If the alloca is used in a call, we must clear the tail flag since
405       // the callee now uses an alloca from the caller.
406       for (User *U : TheAlloca->users()) {
407         CallInst *Call = dyn_cast<CallInst>(U);
408         if (!Call)
409           continue;
410         Call->setTailCall(false);
411       }
412       continue;
413     }
414 
415     // There potentially are metadata uses for things like llvm.dbg.value.
416     // Replace them with undef, after handling the other regular uses.
417     auto RauwUndefMetadata = make_scope_exit(
418         [&]() { I->replaceAllUsesWith(UndefValue::get(I->getType())); });
419 
420     if (I->use_empty())
421       continue;
422 
423     // Otherwise, if we promoted this argument, then all users are load
424     // instructions (or GEPs with only load users), and all loads should be
425     // using the new argument that we added.
426     ScalarizeTable &ArgIndices = ScalarizedElements[&*I];
427 
428     while (!I->use_empty()) {
429       if (LoadInst *LI = dyn_cast<LoadInst>(I->user_back())) {
430         assert(ArgIndices.begin()->second.empty() &&
431                "Load element should sort to front!");
432         I2->setName(I->getName() + ".val");
433         LI->replaceAllUsesWith(&*I2);
434         LI->eraseFromParent();
435         LLVM_DEBUG(dbgs() << "*** Promoted load of argument '" << I->getName()
436                           << "' in function '" << F->getName() << "'\n");
437       } else {
438         GetElementPtrInst *GEP = cast<GetElementPtrInst>(I->user_back());
439         IndicesVector Operands;
440         Operands.reserve(GEP->getNumIndices());
441         for (User::op_iterator II = GEP->idx_begin(), IE = GEP->idx_end();
442              II != IE; ++II)
443           Operands.push_back(cast<ConstantInt>(*II)->getSExtValue());
444 
445         // GEPs with a single 0 index can be merged with direct loads
446         if (Operands.size() == 1 && Operands.front() == 0)
447           Operands.clear();
448 
449         Function::arg_iterator TheArg = I2;
450         for (ScalarizeTable::iterator It = ArgIndices.begin();
451              It->second != Operands; ++It, ++TheArg) {
452           assert(It != ArgIndices.end() && "GEP not handled??");
453         }
454 
455         TheArg->setName(formatv("{0}.{1:$[.]}.val", I->getName(),
456                                 make_range(Operands.begin(), Operands.end())));
457 
458         LLVM_DEBUG(dbgs() << "*** Promoted agg argument '" << TheArg->getName()
459                           << "' of function '" << NF->getName() << "'\n");
460 
461         // All of the uses must be load instructions.  Replace them all with
462         // the argument specified by ArgNo.
463         while (!GEP->use_empty()) {
464           LoadInst *L = cast<LoadInst>(GEP->user_back());
465           L->replaceAllUsesWith(&*TheArg);
466           L->eraseFromParent();
467         }
468         GEP->eraseFromParent();
469       }
470     }
471     // Increment I2 past all of the arguments added for this promoted pointer.
472     std::advance(I2, ArgIndices.size());
473   }
474 
475   return NF;
476 }
477 
478 /// Return true if we can prove that all callees pass in a valid pointer for the
479 /// specified function argument.
480 static bool allCallersPassValidPointerForArgument(Argument *Arg, Type *Ty) {
481   Function *Callee = Arg->getParent();
482   const DataLayout &DL = Callee->getParent()->getDataLayout();
483 
484   unsigned ArgNo = Arg->getArgNo();
485 
486   // Look at all call sites of the function.  At this point we know we only have
487   // direct callees.
488   for (User *U : Callee->users()) {
489     CallBase &CB = cast<CallBase>(*U);
490 
491     if (!isDereferenceablePointer(CB.getArgOperand(ArgNo), Ty, DL))
492       return false;
493   }
494   return true;
495 }
496 
497 /// Returns true if Prefix is a prefix of longer. That means, Longer has a size
498 /// that is greater than or equal to the size of prefix, and each of the
499 /// elements in Prefix is the same as the corresponding elements in Longer.
500 ///
501 /// This means it also returns true when Prefix and Longer are equal!
502 static bool isPrefix(const IndicesVector &Prefix, const IndicesVector &Longer) {
503   if (Prefix.size() > Longer.size())
504     return false;
505   return std::equal(Prefix.begin(), Prefix.end(), Longer.begin());
506 }
507 
508 /// Checks if Indices, or a prefix of Indices, is in Set.
509 static bool prefixIn(const IndicesVector &Indices,
510                      std::set<IndicesVector> &Set) {
511   std::set<IndicesVector>::iterator Low;
512   Low = Set.upper_bound(Indices);
513   if (Low != Set.begin())
514     Low--;
515   // Low is now the last element smaller than or equal to Indices. This means
516   // it points to a prefix of Indices (possibly Indices itself), if such
517   // prefix exists.
518   //
519   // This load is safe if any prefix of its operands is safe to load.
520   return Low != Set.end() && isPrefix(*Low, Indices);
521 }
522 
523 /// Mark the given indices (ToMark) as safe in the given set of indices
524 /// (Safe). Marking safe usually means adding ToMark to Safe. However, if there
525 /// is already a prefix of Indices in Safe, Indices are implicitely marked safe
526 /// already. Furthermore, any indices that Indices is itself a prefix of, are
527 /// removed from Safe (since they are implicitely safe because of Indices now).
528 static void markIndicesSafe(const IndicesVector &ToMark,
529                             std::set<IndicesVector> &Safe) {
530   std::set<IndicesVector>::iterator Low;
531   Low = Safe.upper_bound(ToMark);
532   // Guard against the case where Safe is empty
533   if (Low != Safe.begin())
534     Low--;
535   // Low is now the last element smaller than or equal to Indices. This
536   // means it points to a prefix of Indices (possibly Indices itself), if
537   // such prefix exists.
538   if (Low != Safe.end()) {
539     if (isPrefix(*Low, ToMark))
540       // If there is already a prefix of these indices (or exactly these
541       // indices) marked a safe, don't bother adding these indices
542       return;
543 
544     // Increment Low, so we can use it as a "insert before" hint
545     ++Low;
546   }
547   // Insert
548   Low = Safe.insert(Low, ToMark);
549   ++Low;
550   // If there we're a prefix of longer index list(s), remove those
551   std::set<IndicesVector>::iterator End = Safe.end();
552   while (Low != End && isPrefix(ToMark, *Low)) {
553     std::set<IndicesVector>::iterator Remove = Low;
554     ++Low;
555     Safe.erase(Remove);
556   }
557 }
558 
559 /// isSafeToPromoteArgument - As you might guess from the name of this method,
560 /// it checks to see if it is both safe and useful to promote the argument.
561 /// This method limits promotion of aggregates to only promote up to three
562 /// elements of the aggregate in order to avoid exploding the number of
563 /// arguments passed in.
564 static bool isSafeToPromoteArgument(Argument *Arg, Type *ByValTy, AAResults &AAR,
565                                     unsigned MaxElements) {
566   using GEPIndicesSet = std::set<IndicesVector>;
567 
568   // Quick exit for unused arguments
569   if (Arg->use_empty())
570     return true;
571 
572   // We can only promote this argument if all of the uses are loads, or are GEP
573   // instructions (with constant indices) that are subsequently loaded.
574   //
575   // Promoting the argument causes it to be loaded in the caller
576   // unconditionally. This is only safe if we can prove that either the load
577   // would have happened in the callee anyway (ie, there is a load in the entry
578   // block) or the pointer passed in at every call site is guaranteed to be
579   // valid.
580   // In the former case, invalid loads can happen, but would have happened
581   // anyway, in the latter case, invalid loads won't happen. This prevents us
582   // from introducing an invalid load that wouldn't have happened in the
583   // original code.
584   //
585   // This set will contain all sets of indices that are loaded in the entry
586   // block, and thus are safe to unconditionally load in the caller.
587   GEPIndicesSet SafeToUnconditionallyLoad;
588 
589   // This set contains all the sets of indices that we are planning to promote.
590   // This makes it possible to limit the number of arguments added.
591   GEPIndicesSet ToPromote;
592 
593   // If the pointer is always valid, any load with first index 0 is valid.
594 
595   if (ByValTy)
596     SafeToUnconditionallyLoad.insert(IndicesVector(1, 0));
597 
598   // Whenever a new underlying type for the operand is found, make sure it's
599   // consistent with the GEPs and loads we've already seen and, if necessary,
600   // use it to see if all incoming pointers are valid (which implies the 0-index
601   // is safe).
602   Type *BaseTy = ByValTy;
603   auto UpdateBaseTy = [&](Type *NewBaseTy) {
604     if (BaseTy)
605       return BaseTy == NewBaseTy;
606 
607     BaseTy = NewBaseTy;
608     if (allCallersPassValidPointerForArgument(Arg, BaseTy)) {
609       assert(SafeToUnconditionallyLoad.empty());
610       SafeToUnconditionallyLoad.insert(IndicesVector(1, 0));
611     }
612 
613     return true;
614   };
615 
616   // First, iterate the entry block and mark loads of (geps of) arguments as
617   // safe.
618   BasicBlock &EntryBlock = Arg->getParent()->front();
619   // Declare this here so we can reuse it
620   IndicesVector Indices;
621   for (Instruction &I : EntryBlock)
622     if (LoadInst *LI = dyn_cast<LoadInst>(&I)) {
623       Value *V = LI->getPointerOperand();
624       if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(V)) {
625         V = GEP->getPointerOperand();
626         if (V == Arg) {
627           // This load actually loads (part of) Arg? Check the indices then.
628           Indices.reserve(GEP->getNumIndices());
629           for (User::op_iterator II = GEP->idx_begin(), IE = GEP->idx_end();
630                II != IE; ++II)
631             if (ConstantInt *CI = dyn_cast<ConstantInt>(*II))
632               Indices.push_back(CI->getSExtValue());
633             else
634               // We found a non-constant GEP index for this argument? Bail out
635               // right away, can't promote this argument at all.
636               return false;
637 
638           if (!UpdateBaseTy(GEP->getSourceElementType()))
639             return false;
640 
641           // Indices checked out, mark them as safe
642           markIndicesSafe(Indices, SafeToUnconditionallyLoad);
643           Indices.clear();
644         }
645       } else if (V == Arg) {
646         // Direct loads are equivalent to a GEP with a single 0 index.
647         markIndicesSafe(IndicesVector(1, 0), SafeToUnconditionallyLoad);
648 
649         if (BaseTy && LI->getType() != BaseTy)
650           return false;
651 
652         BaseTy = LI->getType();
653       }
654     }
655 
656   // Now, iterate all uses of the argument to see if there are any uses that are
657   // not (GEP+)loads, or any (GEP+)loads that are not safe to promote.
658   SmallVector<LoadInst *, 16> Loads;
659   IndicesVector Operands;
660   for (Use &U : Arg->uses()) {
661     User *UR = U.getUser();
662     Operands.clear();
663     if (LoadInst *LI = dyn_cast<LoadInst>(UR)) {
664       // Don't hack volatile/atomic loads
665       if (!LI->isSimple())
666         return false;
667       Loads.push_back(LI);
668       // Direct loads are equivalent to a GEP with a zero index and then a load.
669       Operands.push_back(0);
670 
671       if (!UpdateBaseTy(LI->getType()))
672         return false;
673     } else if (GetElementPtrInst *GEP = dyn_cast<GetElementPtrInst>(UR)) {
674       if (GEP->use_empty()) {
675         // Dead GEP's cause trouble later.  Just remove them if we run into
676         // them.
677         GEP->eraseFromParent();
678         // TODO: This runs the above loop over and over again for dead GEPs
679         // Couldn't we just do increment the UI iterator earlier and erase the
680         // use?
681         return isSafeToPromoteArgument(Arg, ByValTy, AAR, MaxElements);
682       }
683 
684       if (!UpdateBaseTy(GEP->getSourceElementType()))
685         return false;
686 
687       // Ensure that all of the indices are constants.
688       for (User::op_iterator i = GEP->idx_begin(), e = GEP->idx_end(); i != e;
689            ++i)
690         if (ConstantInt *C = dyn_cast<ConstantInt>(*i))
691           Operands.push_back(C->getSExtValue());
692         else
693           return false; // Not a constant operand GEP!
694 
695       // Ensure that the only users of the GEP are load instructions.
696       for (User *GEPU : GEP->users())
697         if (LoadInst *LI = dyn_cast<LoadInst>(GEPU)) {
698           // Don't hack volatile/atomic loads
699           if (!LI->isSimple())
700             return false;
701           Loads.push_back(LI);
702         } else {
703           // Other uses than load?
704           return false;
705         }
706     } else {
707       return false; // Not a load or a GEP.
708     }
709 
710     // Now, see if it is safe to promote this load / loads of this GEP. Loading
711     // is safe if Operands, or a prefix of Operands, is marked as safe.
712     if (!prefixIn(Operands, SafeToUnconditionallyLoad))
713       return false;
714 
715     // See if we are already promoting a load with these indices. If not, check
716     // to make sure that we aren't promoting too many elements.  If so, nothing
717     // to do.
718     if (ToPromote.find(Operands) == ToPromote.end()) {
719       if (MaxElements > 0 && ToPromote.size() == MaxElements) {
720         LLVM_DEBUG(dbgs() << "argpromotion not promoting argument '"
721                           << Arg->getName()
722                           << "' because it would require adding more "
723                           << "than " << MaxElements
724                           << " arguments to the function.\n");
725         // We limit aggregate promotion to only promoting up to a fixed number
726         // of elements of the aggregate.
727         return false;
728       }
729       ToPromote.insert(std::move(Operands));
730     }
731   }
732 
733   if (Loads.empty())
734     return true; // No users, this is a dead argument.
735 
736   // Okay, now we know that the argument is only used by load instructions and
737   // it is safe to unconditionally perform all of them. Use alias analysis to
738   // check to see if the pointer is guaranteed to not be modified from entry of
739   // the function to each of the load instructions.
740 
741   // Because there could be several/many load instructions, remember which
742   // blocks we know to be transparent to the load.
743   df_iterator_default_set<BasicBlock *, 16> TranspBlocks;
744 
745   for (LoadInst *Load : Loads) {
746     // Check to see if the load is invalidated from the start of the block to
747     // the load itself.
748     BasicBlock *BB = Load->getParent();
749 
750     MemoryLocation Loc = MemoryLocation::get(Load);
751     if (AAR.canInstructionRangeModRef(BB->front(), *Load, Loc, ModRefInfo::Mod))
752       return false; // Pointer is invalidated!
753 
754     // Now check every path from the entry block to the load for transparency.
755     // To do this, we perform a depth first search on the inverse CFG from the
756     // loading block.
757     for (BasicBlock *P : predecessors(BB)) {
758       for (BasicBlock *TranspBB : inverse_depth_first_ext(P, TranspBlocks))
759         if (AAR.canBasicBlockModify(*TranspBB, Loc))
760           return false;
761     }
762   }
763 
764   // If the path from the entry of the function to each load is free of
765   // instructions that potentially invalidate the load, we can make the
766   // transformation!
767   return true;
768 }
769 
770 bool ArgumentPromotionPass::isDenselyPacked(Type *type, const DataLayout &DL) {
771   // There is no size information, so be conservative.
772   if (!type->isSized())
773     return false;
774 
775   // If the alloc size is not equal to the storage size, then there are padding
776   // bytes. For x86_fp80 on x86-64, size: 80 alloc size: 128.
777   if (DL.getTypeSizeInBits(type) != DL.getTypeAllocSizeInBits(type))
778     return false;
779 
780   // FIXME: This isn't the right way to check for padding in vectors with
781   // non-byte-size elements.
782   if (VectorType *seqTy = dyn_cast<VectorType>(type))
783     return isDenselyPacked(seqTy->getElementType(), DL);
784 
785   // For array types, check for padding within members.
786   if (ArrayType *seqTy = dyn_cast<ArrayType>(type))
787     return isDenselyPacked(seqTy->getElementType(), DL);
788 
789   if (!isa<StructType>(type))
790     return true;
791 
792   // Check for padding within and between elements of a struct.
793   StructType *StructTy = cast<StructType>(type);
794   const StructLayout *Layout = DL.getStructLayout(StructTy);
795   uint64_t StartPos = 0;
796   for (unsigned i = 0, E = StructTy->getNumElements(); i < E; ++i) {
797     Type *ElTy = StructTy->getElementType(i);
798     if (!isDenselyPacked(ElTy, DL))
799       return false;
800     if (StartPos != Layout->getElementOffsetInBits(i))
801       return false;
802     StartPos += DL.getTypeAllocSizeInBits(ElTy);
803   }
804 
805   return true;
806 }
807 
808 /// Checks if the padding bytes of an argument could be accessed.
809 static bool canPaddingBeAccessed(Argument *arg) {
810   assert(arg->hasByValAttr());
811 
812   // Track all the pointers to the argument to make sure they are not captured.
813   SmallPtrSet<Value *, 16> PtrValues;
814   PtrValues.insert(arg);
815 
816   // Track all of the stores.
817   SmallVector<StoreInst *, 16> Stores;
818 
819   // Scan through the uses recursively to make sure the pointer is always used
820   // sanely.
821   SmallVector<Value *, 16> WorkList;
822   WorkList.insert(WorkList.end(), arg->user_begin(), arg->user_end());
823   while (!WorkList.empty()) {
824     Value *V = WorkList.back();
825     WorkList.pop_back();
826     if (isa<GetElementPtrInst>(V) || isa<PHINode>(V)) {
827       if (PtrValues.insert(V).second)
828         llvm::append_range(WorkList, V->users());
829     } else if (StoreInst *Store = dyn_cast<StoreInst>(V)) {
830       Stores.push_back(Store);
831     } else if (!isa<LoadInst>(V)) {
832       return true;
833     }
834   }
835 
836   // Check to make sure the pointers aren't captured
837   for (StoreInst *Store : Stores)
838     if (PtrValues.count(Store->getValueOperand()))
839       return true;
840 
841   return false;
842 }
843 
844 bool ArgumentPromotionPass::areFunctionArgsABICompatible(
845     const Function &F, const TargetTransformInfo &TTI,
846     SmallPtrSetImpl<Argument *> &ArgsToPromote,
847     SmallPtrSetImpl<Argument *> &ByValArgsToTransform) {
848   for (const Use &U : F.uses()) {
849     CallBase *CB = dyn_cast<CallBase>(U.getUser());
850     if (!CB)
851       return false;
852     const Function *Caller = CB->getCaller();
853     const Function *Callee = CB->getCalledFunction();
854     if (!TTI.areFunctionArgsABICompatible(Caller, Callee, ArgsToPromote) ||
855         !TTI.areFunctionArgsABICompatible(Caller, Callee, ByValArgsToTransform))
856       return false;
857   }
858   return true;
859 }
860 
861 /// PromoteArguments - This method checks the specified function to see if there
862 /// are any promotable arguments and if it is safe to promote the function (for
863 /// example, all callers are direct).  If safe to promote some arguments, it
864 /// calls the DoPromotion method.
865 static Function *
866 promoteArguments(Function *F, function_ref<AAResults &(Function &F)> AARGetter,
867                  unsigned MaxElements,
868                  Optional<function_ref<void(CallBase &OldCS, CallBase &NewCS)>>
869                      ReplaceCallSite,
870                  const TargetTransformInfo &TTI) {
871   // Don't perform argument promotion for naked functions; otherwise we can end
872   // up removing parameters that are seemingly 'not used' as they are referred
873   // to in the assembly.
874   if(F->hasFnAttribute(Attribute::Naked))
875     return nullptr;
876 
877   // Make sure that it is local to this module.
878   if (!F->hasLocalLinkage())
879     return nullptr;
880 
881   // Don't promote arguments for variadic functions. Adding, removing, or
882   // changing non-pack parameters can change the classification of pack
883   // parameters. Frontends encode that classification at the call site in the
884   // IR, while in the callee the classification is determined dynamically based
885   // on the number of registers consumed so far.
886   if (F->isVarArg())
887     return nullptr;
888 
889   // Don't transform functions that receive inallocas, as the transformation may
890   // not be safe depending on calling convention.
891   if (F->getAttributes().hasAttrSomewhere(Attribute::InAlloca))
892     return nullptr;
893 
894   // First check: see if there are any pointer arguments!  If not, quick exit.
895   SmallVector<Argument *, 16> PointerArgs;
896   for (Argument &I : F->args())
897     if (I.getType()->isPointerTy())
898       PointerArgs.push_back(&I);
899   if (PointerArgs.empty())
900     return nullptr;
901 
902   // Second check: make sure that all callers are direct callers.  We can't
903   // transform functions that have indirect callers.  Also see if the function
904   // is self-recursive and check that target features are compatible.
905   bool isSelfRecursive = false;
906   for (Use &U : F->uses()) {
907     CallBase *CB = dyn_cast<CallBase>(U.getUser());
908     // Must be a direct call.
909     if (CB == nullptr || !CB->isCallee(&U))
910       return nullptr;
911 
912     // Can't change signature of musttail callee
913     if (CB->isMustTailCall())
914       return nullptr;
915 
916     if (CB->getParent()->getParent() == F)
917       isSelfRecursive = true;
918   }
919 
920   // Can't change signature of musttail caller
921   // FIXME: Support promoting whole chain of musttail functions
922   for (BasicBlock &BB : *F)
923     if (BB.getTerminatingMustTailCall())
924       return nullptr;
925 
926   const DataLayout &DL = F->getParent()->getDataLayout();
927 
928   AAResults &AAR = AARGetter(*F);
929 
930   // Check to see which arguments are promotable.  If an argument is promotable,
931   // add it to ArgsToPromote.
932   SmallPtrSet<Argument *, 8> ArgsToPromote;
933   SmallPtrSet<Argument *, 8> ByValArgsToTransform;
934   for (Argument *PtrArg : PointerArgs) {
935     Type *AgTy = cast<PointerType>(PtrArg->getType())->getElementType();
936 
937     // Replace sret attribute with noalias. This reduces register pressure by
938     // avoiding a register copy.
939     if (PtrArg->hasStructRetAttr()) {
940       unsigned ArgNo = PtrArg->getArgNo();
941       F->removeParamAttr(ArgNo, Attribute::StructRet);
942       F->addParamAttr(ArgNo, Attribute::NoAlias);
943       for (Use &U : F->uses()) {
944         CallBase &CB = cast<CallBase>(*U.getUser());
945         CB.removeParamAttr(ArgNo, Attribute::StructRet);
946         CB.addParamAttr(ArgNo, Attribute::NoAlias);
947       }
948     }
949 
950     // If this is a byval argument, and if the aggregate type is small, just
951     // pass the elements, which is always safe, if the passed value is densely
952     // packed or if we can prove the padding bytes are never accessed.
953     bool isSafeToPromote = PtrArg->hasByValAttr() &&
954                            (ArgumentPromotionPass::isDenselyPacked(AgTy, DL) ||
955                             !canPaddingBeAccessed(PtrArg));
956     if (isSafeToPromote) {
957       if (StructType *STy = dyn_cast<StructType>(AgTy)) {
958         if (MaxElements > 0 && STy->getNumElements() > MaxElements) {
959           LLVM_DEBUG(dbgs() << "argpromotion disable promoting argument '"
960                             << PtrArg->getName()
961                             << "' because it would require adding more"
962                             << " than " << MaxElements
963                             << " arguments to the function.\n");
964           continue;
965         }
966 
967         // If all the elements are single-value types, we can promote it.
968         bool AllSimple = true;
969         for (const auto *EltTy : STy->elements()) {
970           if (!EltTy->isSingleValueType()) {
971             AllSimple = false;
972             break;
973           }
974         }
975 
976         // Safe to transform, don't even bother trying to "promote" it.
977         // Passing the elements as a scalar will allow sroa to hack on
978         // the new alloca we introduce.
979         if (AllSimple) {
980           ByValArgsToTransform.insert(PtrArg);
981           continue;
982         }
983       }
984     }
985 
986     // If the argument is a recursive type and we're in a recursive
987     // function, we could end up infinitely peeling the function argument.
988     if (isSelfRecursive) {
989       if (StructType *STy = dyn_cast<StructType>(AgTy)) {
990         bool RecursiveType = false;
991         for (const auto *EltTy : STy->elements()) {
992           if (EltTy == PtrArg->getType()) {
993             RecursiveType = true;
994             break;
995           }
996         }
997         if (RecursiveType)
998           continue;
999       }
1000     }
1001 
1002     // Otherwise, see if we can promote the pointer to its value.
1003     Type *ByValTy =
1004         PtrArg->hasByValAttr() ? PtrArg->getParamByValType() : nullptr;
1005     if (isSafeToPromoteArgument(PtrArg, ByValTy, AAR, MaxElements))
1006       ArgsToPromote.insert(PtrArg);
1007   }
1008 
1009   // No promotable pointer arguments.
1010   if (ArgsToPromote.empty() && ByValArgsToTransform.empty())
1011     return nullptr;
1012 
1013   if (!ArgumentPromotionPass::areFunctionArgsABICompatible(
1014           *F, TTI, ArgsToPromote, ByValArgsToTransform))
1015     return nullptr;
1016 
1017   return doPromotion(F, ArgsToPromote, ByValArgsToTransform, ReplaceCallSite);
1018 }
1019 
1020 PreservedAnalyses ArgumentPromotionPass::run(LazyCallGraph::SCC &C,
1021                                              CGSCCAnalysisManager &AM,
1022                                              LazyCallGraph &CG,
1023                                              CGSCCUpdateResult &UR) {
1024   bool Changed = false, LocalChange;
1025 
1026   // Iterate until we stop promoting from this SCC.
1027   do {
1028     LocalChange = false;
1029 
1030     for (LazyCallGraph::Node &N : C) {
1031       Function &OldF = N.getFunction();
1032 
1033       FunctionAnalysisManager &FAM =
1034           AM.getResult<FunctionAnalysisManagerCGSCCProxy>(C, CG).getManager();
1035       // FIXME: This lambda must only be used with this function. We should
1036       // skip the lambda and just get the AA results directly.
1037       auto AARGetter = [&](Function &F) -> AAResults & {
1038         assert(&F == &OldF && "Called with an unexpected function!");
1039         return FAM.getResult<AAManager>(F);
1040       };
1041 
1042       const TargetTransformInfo &TTI = FAM.getResult<TargetIRAnalysis>(OldF);
1043       Function *NewF =
1044           promoteArguments(&OldF, AARGetter, MaxElements, None, TTI);
1045       if (!NewF)
1046         continue;
1047       LocalChange = true;
1048 
1049       // Directly substitute the functions in the call graph. Note that this
1050       // requires the old function to be completely dead and completely
1051       // replaced by the new function. It does no call graph updates, it merely
1052       // swaps out the particular function mapped to a particular node in the
1053       // graph.
1054       C.getOuterRefSCC().replaceNodeFunction(N, *NewF);
1055       OldF.eraseFromParent();
1056     }
1057 
1058     Changed |= LocalChange;
1059   } while (LocalChange);
1060 
1061   if (!Changed)
1062     return PreservedAnalyses::all();
1063 
1064   return PreservedAnalyses::none();
1065 }
1066 
1067 namespace {
1068 
1069 /// ArgPromotion - The 'by reference' to 'by value' argument promotion pass.
1070 struct ArgPromotion : public CallGraphSCCPass {
1071   // Pass identification, replacement for typeid
1072   static char ID;
1073 
1074   explicit ArgPromotion(unsigned MaxElements = 3)
1075       : CallGraphSCCPass(ID), MaxElements(MaxElements) {
1076     initializeArgPromotionPass(*PassRegistry::getPassRegistry());
1077   }
1078 
1079   void getAnalysisUsage(AnalysisUsage &AU) const override {
1080     AU.addRequired<AssumptionCacheTracker>();
1081     AU.addRequired<TargetLibraryInfoWrapperPass>();
1082     AU.addRequired<TargetTransformInfoWrapperPass>();
1083     getAAResultsAnalysisUsage(AU);
1084     CallGraphSCCPass::getAnalysisUsage(AU);
1085   }
1086 
1087   bool runOnSCC(CallGraphSCC &SCC) override;
1088 
1089 private:
1090   using llvm::Pass::doInitialization;
1091 
1092   bool doInitialization(CallGraph &CG) override;
1093 
1094   /// The maximum number of elements to expand, or 0 for unlimited.
1095   unsigned MaxElements;
1096 };
1097 
1098 } // end anonymous namespace
1099 
1100 char ArgPromotion::ID = 0;
1101 
1102 INITIALIZE_PASS_BEGIN(ArgPromotion, "argpromotion",
1103                       "Promote 'by reference' arguments to scalars", false,
1104                       false)
1105 INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
1106 INITIALIZE_PASS_DEPENDENCY(CallGraphWrapperPass)
1107 INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass)
1108 INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
1109 INITIALIZE_PASS_END(ArgPromotion, "argpromotion",
1110                     "Promote 'by reference' arguments to scalars", false, false)
1111 
1112 Pass *llvm::createArgumentPromotionPass(unsigned MaxElements) {
1113   return new ArgPromotion(MaxElements);
1114 }
1115 
1116 bool ArgPromotion::runOnSCC(CallGraphSCC &SCC) {
1117   if (skipSCC(SCC))
1118     return false;
1119 
1120   // Get the callgraph information that we need to update to reflect our
1121   // changes.
1122   CallGraph &CG = getAnalysis<CallGraphWrapperPass>().getCallGraph();
1123 
1124   LegacyAARGetter AARGetter(*this);
1125 
1126   bool Changed = false, LocalChange;
1127 
1128   // Iterate until we stop promoting from this SCC.
1129   do {
1130     LocalChange = false;
1131     // Attempt to promote arguments from all functions in this SCC.
1132     for (CallGraphNode *OldNode : SCC) {
1133       Function *OldF = OldNode->getFunction();
1134       if (!OldF)
1135         continue;
1136 
1137       auto ReplaceCallSite = [&](CallBase &OldCS, CallBase &NewCS) {
1138         Function *Caller = OldCS.getParent()->getParent();
1139         CallGraphNode *NewCalleeNode =
1140             CG.getOrInsertFunction(NewCS.getCalledFunction());
1141         CallGraphNode *CallerNode = CG[Caller];
1142         CallerNode->replaceCallEdge(cast<CallBase>(OldCS),
1143                                     cast<CallBase>(NewCS), NewCalleeNode);
1144       };
1145 
1146       const TargetTransformInfo &TTI =
1147           getAnalysis<TargetTransformInfoWrapperPass>().getTTI(*OldF);
1148       if (Function *NewF = promoteArguments(OldF, AARGetter, MaxElements,
1149                                             {ReplaceCallSite}, TTI)) {
1150         LocalChange = true;
1151 
1152         // Update the call graph for the newly promoted function.
1153         CallGraphNode *NewNode = CG.getOrInsertFunction(NewF);
1154         NewNode->stealCalledFunctionsFrom(OldNode);
1155         if (OldNode->getNumReferences() == 0)
1156           delete CG.removeFunctionFromModule(OldNode);
1157         else
1158           OldF->setLinkage(Function::ExternalLinkage);
1159 
1160         // And updat ethe SCC we're iterating as well.
1161         SCC.ReplaceNode(OldNode, NewNode);
1162       }
1163     }
1164     // Remember that we changed something.
1165     Changed |= LocalChange;
1166   } while (LocalChange);
1167 
1168   return Changed;
1169 }
1170 
1171 bool ArgPromotion::doInitialization(CallGraph &CG) {
1172   return CallGraphSCCPass::doInitialization(CG);
1173 }
1174