110e730a2SDan Gohman //===- WebAssemblyTargetMachine.cpp - Define TargetMachine for WebAssembly -==// 210e730a2SDan Gohman // 310e730a2SDan Gohman // The LLVM Compiler Infrastructure 410e730a2SDan Gohman // 510e730a2SDan Gohman // This file is distributed under the University of Illinois Open Source 610e730a2SDan Gohman // License. See LICENSE.TXT for details. 710e730a2SDan Gohman // 810e730a2SDan Gohman //===----------------------------------------------------------------------===// 910e730a2SDan Gohman /// 1010e730a2SDan Gohman /// \file 115f8f34e4SAdrian Prantl /// This file defines the WebAssembly-specific subclass of TargetMachine. 1210e730a2SDan Gohman /// 1310e730a2SDan Gohman //===----------------------------------------------------------------------===// 1410e730a2SDan Gohman 1510e730a2SDan Gohman #include "WebAssemblyTargetMachine.h" 166bda14b3SChandler Carruth #include "MCTargetDesc/WebAssemblyMCTargetDesc.h" 176bda14b3SChandler Carruth #include "WebAssembly.h" 185bf22fc8SDan Gohman #include "WebAssemblyTargetObjectFile.h" 1910e730a2SDan Gohman #include "WebAssemblyTargetTransformInfo.h" 2010e730a2SDan Gohman #include "llvm/CodeGen/MachineFunctionPass.h" 2110e730a2SDan Gohman #include "llvm/CodeGen/Passes.h" 2210e730a2SDan Gohman #include "llvm/CodeGen/RegAllocRegistry.h" 2331d19d43SMatthias Braun #include "llvm/CodeGen/TargetPassConfig.h" 2410e730a2SDan Gohman #include "llvm/IR/Function.h" 2510e730a2SDan Gohman #include "llvm/Support/TargetRegistry.h" 2610e730a2SDan Gohman #include "llvm/Target/TargetOptions.h" 2703855df1SJF Bastien #include "llvm/Transforms/Scalar.h" 28a373d18eSDavid Blaikie #include "llvm/Transforms/Utils.h" 2910e730a2SDan Gohman using namespace llvm; 3010e730a2SDan Gohman 3110e730a2SDan Gohman #define DEBUG_TYPE "wasm" 3210e730a2SDan Gohman 33f41f67d3SDerek Schuff // Emscripten's asm.js-style exception handling 34ccdceda1SDerek Schuff static cl::opt<bool> EnableEmException( 3553b9af02SDerek Schuff "enable-emscripten-cxx-exceptions", 36f41f67d3SDerek Schuff cl::desc("WebAssembly Emscripten-style exception handling"), 37f41f67d3SDerek Schuff cl::init(false)); 38f41f67d3SDerek Schuff 39ccdceda1SDerek Schuff // Emscripten's asm.js-style setjmp/longjmp handling 40ccdceda1SDerek Schuff static cl::opt<bool> EnableEmSjLj( 41ccdceda1SDerek Schuff "enable-emscripten-sjlj", 42ccdceda1SDerek Schuff cl::desc("WebAssembly Emscripten-style setjmp/longjmp handling"), 43ccdceda1SDerek Schuff cl::init(false)); 44ccdceda1SDerek Schuff 4510e730a2SDan Gohman extern "C" void LLVMInitializeWebAssemblyTarget() { 4610e730a2SDan Gohman // Register the target. 47f42454b9SMehdi Amini RegisterTargetMachine<WebAssemblyTargetMachine> X( 48f42454b9SMehdi Amini getTheWebAssemblyTarget32()); 49f42454b9SMehdi Amini RegisterTargetMachine<WebAssemblyTargetMachine> Y( 50f42454b9SMehdi Amini getTheWebAssemblyTarget64()); 51f41f67d3SDerek Schuff 5240926451SJacob Gravelle // Register backend passes 5340926451SJacob Gravelle auto &PR = *PassRegistry::getPassRegistry(); 5492617559SSam Clegg initializeWebAssemblyAddMissingPrototypesPass(PR); 5540926451SJacob Gravelle initializeWebAssemblyLowerEmscriptenEHSjLjPass(PR); 5640926451SJacob Gravelle initializeLowerGlobalDtorsPass(PR); 5740926451SJacob Gravelle initializeFixFunctionBitcastsPass(PR); 5840926451SJacob Gravelle initializeOptimizeReturnedPass(PR); 5940926451SJacob Gravelle initializeWebAssemblyArgumentMovePass(PR); 6040926451SJacob Gravelle initializeWebAssemblySetP2AlignOperandsPass(PR); 6140926451SJacob Gravelle initializeWebAssemblyReplacePhysRegsPass(PR); 6240926451SJacob Gravelle initializeWebAssemblyPrepareForLiveIntervalsPass(PR); 6340926451SJacob Gravelle initializeWebAssemblyOptimizeLiveIntervalsPass(PR); 6440926451SJacob Gravelle initializeWebAssemblyStoreResultsPass(PR); 6540926451SJacob Gravelle initializeWebAssemblyRegStackifyPass(PR); 6640926451SJacob Gravelle initializeWebAssemblyRegColoringPass(PR); 6740926451SJacob Gravelle initializeWebAssemblyExplicitLocalsPass(PR); 6840926451SJacob Gravelle initializeWebAssemblyFixIrreducibleControlFlowPass(PR); 694934f76bSHeejin Ahn initializeWebAssemblyLateEHPreparePass(PR); 7004c48949SHeejin Ahn initializeWebAssemblyExceptionInfoPass(PR); 7140926451SJacob Gravelle initializeWebAssemblyCFGSortPass(PR); 7240926451SJacob Gravelle initializeWebAssemblyCFGStackifyPass(PR); 7340926451SJacob Gravelle initializeWebAssemblyLowerBrUnlessPass(PR); 7440926451SJacob Gravelle initializeWebAssemblyRegNumberingPass(PR); 7540926451SJacob Gravelle initializeWebAssemblyPeepholePass(PR); 7640926451SJacob Gravelle initializeWebAssemblyCallIndirectFixupPass(PR); 7710e730a2SDan Gohman } 7810e730a2SDan Gohman 7910e730a2SDan Gohman //===----------------------------------------------------------------------===// 8010e730a2SDan Gohman // WebAssembly Lowering public interface. 8110e730a2SDan Gohman //===----------------------------------------------------------------------===// 8210e730a2SDan Gohman 8341133a3eSDan Gohman static Reloc::Model getEffectiveRelocModel(Optional<Reloc::Model> RM) { 8441133a3eSDan Gohman if (!RM.hasValue()) 8541133a3eSDan Gohman return Reloc::PIC_; 8641133a3eSDan Gohman return *RM; 8741133a3eSDan Gohman } 8841133a3eSDan Gohman 8910e730a2SDan Gohman /// Create an WebAssembly architecture model. 9010e730a2SDan Gohman /// 9110e730a2SDan Gohman WebAssemblyTargetMachine::WebAssemblyTargetMachine( 9210e730a2SDan Gohman const Target &T, const Triple &TT, StringRef CPU, StringRef FS, 9341133a3eSDan Gohman const TargetOptions &Options, Optional<Reloc::Model> RM, 94314ed201SDaniel Jasper Optional<CodeModel::Model> CM, CodeGenOpt::Level OL, bool JIT) 95bb8507e6SMatthias Braun : LLVMTargetMachine(T, 96bb8507e6SMatthias Braun TT.isArch64Bit() ? "e-m:e-p:64:64-i64:64-n32:64-S128" 970c6f5ac5SDan Gohman : "e-m:e-p:32:32-i64:64-n32:64-S128", 9841133a3eSDan Gohman TT, CPU, FS, Options, getEffectiveRelocModel(RM), 99314ed201SDaniel Jasper CM ? *CM : CodeModel::Large, OL), 100*cf2a9e28SSam Clegg TLOF(new WebAssemblyTargetObjectFile()) { 101e040533eSDan Gohman // WebAssembly type-checks instructions, but a noreturn function with a return 102ffa143ceSDerek Schuff // type that doesn't match the context will cause a check failure. So we lower 103ffa143ceSDerek Schuff // LLVM 'unreachable' to ISD::TRAP and then lower that to WebAssembly's 104e040533eSDan Gohman // 'unreachable' instructions which is meant for that case. 105ffa143ceSDerek Schuff this->Options.TrapUnreachable = true; 106ffa143ceSDerek Schuff 107d934cb88SDan Gohman // WebAssembly treats each function as an independent unit. Force 108d934cb88SDan Gohman // -ffunction-sections, effectively, so that we can emit them independently. 109d934cb88SDan Gohman this->Options.FunctionSections = true; 110d934cb88SDan Gohman this->Options.DataSections = true; 111d934cb88SDan Gohman this->Options.UniqueSectionNames = true; 112d934cb88SDan Gohman 11310e730a2SDan Gohman initAsmInfo(); 11410e730a2SDan Gohman 115d85ab7fcSDan Gohman // Note that we don't use setRequiresStructuredCFG(true). It disables 116d85ab7fcSDan Gohman // optimizations than we're ok with, and want, such as critical edge 117d85ab7fcSDan Gohman // splitting and tail merging. 11810e730a2SDan Gohman } 11910e730a2SDan Gohman 12010e730a2SDan Gohman WebAssemblyTargetMachine::~WebAssemblyTargetMachine() {} 12110e730a2SDan Gohman 12210e730a2SDan Gohman const WebAssemblySubtarget * 12310e730a2SDan Gohman WebAssemblyTargetMachine::getSubtargetImpl(const Function &F) const { 12410e730a2SDan Gohman Attribute CPUAttr = F.getFnAttribute("target-cpu"); 12510e730a2SDan Gohman Attribute FSAttr = F.getFnAttribute("target-features"); 12610e730a2SDan Gohman 12710e730a2SDan Gohman std::string CPU = !CPUAttr.hasAttribute(Attribute::None) 12810e730a2SDan Gohman ? CPUAttr.getValueAsString().str() 12910e730a2SDan Gohman : TargetCPU; 13010e730a2SDan Gohman std::string FS = !FSAttr.hasAttribute(Attribute::None) 13110e730a2SDan Gohman ? FSAttr.getValueAsString().str() 13210e730a2SDan Gohman : TargetFS; 13310e730a2SDan Gohman 13410e730a2SDan Gohman auto &I = SubtargetMap[CPU + FS]; 13510e730a2SDan Gohman if (!I) { 13610e730a2SDan Gohman // This needs to be done before we create a new subtarget since any 13710e730a2SDan Gohman // creation will depend on the TM and the code generation flags on the 13810e730a2SDan Gohman // function that reside in TargetOptions. 13910e730a2SDan Gohman resetTargetOptions(F); 1403adc7ce9SRafael Espindola I = llvm::make_unique<WebAssemblySubtarget>(TargetTriple, CPU, FS, *this); 14110e730a2SDan Gohman } 14210e730a2SDan Gohman return I.get(); 14310e730a2SDan Gohman } 14410e730a2SDan Gohman 14510e730a2SDan Gohman namespace { 14639b5367cSDerek Schuff class StripThreadLocal final : public ModulePass { 14739b5367cSDerek Schuff // The default thread model for wasm is single, where thread-local variables 14839b5367cSDerek Schuff // are identical to regular globals and should be treated the same. So this 14939b5367cSDerek Schuff // pass just converts all GlobalVariables to NotThreadLocal 15039b5367cSDerek Schuff static char ID; 15139b5367cSDerek Schuff 15239b5367cSDerek Schuff public: 15339b5367cSDerek Schuff StripThreadLocal() : ModulePass(ID) {} 15439b5367cSDerek Schuff bool runOnModule(Module &M) override { 15539b5367cSDerek Schuff for (auto &GV : M.globals()) 15639b5367cSDerek Schuff GV.setThreadLocalMode(GlobalValue::ThreadLocalMode::NotThreadLocal); 15739b5367cSDerek Schuff return true; 15839b5367cSDerek Schuff } 15939b5367cSDerek Schuff }; 16039b5367cSDerek Schuff char StripThreadLocal::ID = 0; 16139b5367cSDerek Schuff 16210e730a2SDan Gohman /// WebAssembly Code Generator Pass Configuration Options. 16310e730a2SDan Gohman class WebAssemblyPassConfig final : public TargetPassConfig { 16410e730a2SDan Gohman public: 1655e394c3dSMatthias Braun WebAssemblyPassConfig(WebAssemblyTargetMachine &TM, PassManagerBase &PM) 16610e730a2SDan Gohman : TargetPassConfig(TM, PM) {} 16710e730a2SDan Gohman 16810e730a2SDan Gohman WebAssemblyTargetMachine &getWebAssemblyTargetMachine() const { 16910e730a2SDan Gohman return getTM<WebAssemblyTargetMachine>(); 17010e730a2SDan Gohman } 17110e730a2SDan Gohman 17210e730a2SDan Gohman FunctionPass *createTargetRegisterAllocator(bool) override; 17310e730a2SDan Gohman 17410e730a2SDan Gohman void addIRPasses() override; 17510e730a2SDan Gohman bool addInstSelector() override; 17610e730a2SDan Gohman void addPostRegAlloc() override; 177ad154c83SDerek Schuff bool addGCPasses() override { return false; } 17810e730a2SDan Gohman void addPreEmitPass() override; 17910e730a2SDan Gohman }; 18010e730a2SDan Gohman } // end anonymous namespace 18110e730a2SDan Gohman 18226d11ca4SSanjoy Das TargetTransformInfo 18326d11ca4SSanjoy Das WebAssemblyTargetMachine::getTargetTransformInfo(const Function &F) { 18410e730a2SDan Gohman return TargetTransformInfo(WebAssemblyTTIImpl(this, F)); 18510e730a2SDan Gohman } 18610e730a2SDan Gohman 18710e730a2SDan Gohman TargetPassConfig * 18810e730a2SDan Gohman WebAssemblyTargetMachine::createPassConfig(PassManagerBase &PM) { 1895e394c3dSMatthias Braun return new WebAssemblyPassConfig(*this, PM); 19010e730a2SDan Gohman } 19110e730a2SDan Gohman 19210e730a2SDan Gohman FunctionPass *WebAssemblyPassConfig::createTargetRegisterAllocator(bool) { 19310e730a2SDan Gohman return nullptr; // No reg alloc 19410e730a2SDan Gohman } 19510e730a2SDan Gohman 19610e730a2SDan Gohman //===----------------------------------------------------------------------===// 19710e730a2SDan Gohman // The following functions are called from lib/CodeGen/Passes.cpp to modify 19810e730a2SDan Gohman // the CodeGen pass sequence. 19910e730a2SDan Gohman //===----------------------------------------------------------------------===// 20010e730a2SDan Gohman 20110e730a2SDan Gohman void WebAssemblyPassConfig::addIRPasses() { 20239b5367cSDerek Schuff if (TM->Options.ThreadModel == ThreadModel::Single) { 2039c54d3b4SDan Gohman // In "single" mode, atomics get lowered to non-atomics. 20403855df1SJF Bastien addPass(createLowerAtomicPass()); 20539b5367cSDerek Schuff addPass(new StripThreadLocal()); 20639b5367cSDerek Schuff } else { 20710e730a2SDan Gohman // Expand some atomic operations. WebAssemblyTargetLowering has hooks which 20810e730a2SDan Gohman // control specifically what gets lowered. 2098b61764cSFrancis Visoiu Mistrih addPass(createAtomicExpandPass()); 21039b5367cSDerek Schuff } 21110e730a2SDan Gohman 21292617559SSam Clegg // Add signatures to prototype-less function declarations 21392617559SSam Clegg addPass(createWebAssemblyAddMissingPrototypes()); 21492617559SSam Clegg 215bafe6902SSam Clegg // Lower .llvm.global_dtors into .llvm_global_ctors with __cxa_atexit calls. 216bafe6902SSam Clegg addPass(createWebAssemblyLowerGlobalDtors()); 217bafe6902SSam Clegg 2181b637458SDan Gohman // Fix function bitcasts, as WebAssembly requires caller and callee signatures 2191b637458SDan Gohman // to match. 2201b637458SDan Gohman addPass(createWebAssemblyFixFunctionBitcasts()); 2211b637458SDan Gohman 22281719f85SDan Gohman // Optimize "returned" function attributes. 223b13c91f1SDan Gohman if (getOptLevel() != CodeGenOpt::None) 22481719f85SDan Gohman addPass(createWebAssemblyOptimizeReturned()); 22581719f85SDan Gohman 226c0f18172SHeejin Ahn // If exception handling is not enabled and setjmp/longjmp handling is 227c0f18172SHeejin Ahn // enabled, we lower invokes into calls and delete unreachable landingpad 228c0f18172SHeejin Ahn // blocks. Lowering invokes when there is no EH support is done in 229c0f18172SHeejin Ahn // TargetPassConfig::addPassesToHandleExceptions, but this runs after this 230c0f18172SHeejin Ahn // function and SjLj handling expects all invokes to be lowered before. 2319386bde1SHeejin Ahn if (!EnableEmException && 2329386bde1SHeejin Ahn TM->Options.ExceptionModel == ExceptionHandling::None) { 233c0f18172SHeejin Ahn addPass(createLowerInvokePass()); 234c0f18172SHeejin Ahn // The lower invoke pass may create unreachable code. Remove it in order not 235c0f18172SHeejin Ahn // to process dead blocks in setjmp/longjmp handling. 236c0f18172SHeejin Ahn addPass(createUnreachableBlockEliminationPass()); 237c0f18172SHeejin Ahn } 238c0f18172SHeejin Ahn 239c0f18172SHeejin Ahn // Handle exceptions and setjmp/longjmp if enabled. 240ccdceda1SDerek Schuff if (EnableEmException || EnableEmSjLj) 241ccdceda1SDerek Schuff addPass(createWebAssemblyLowerEmscriptenEHSjLj(EnableEmException, 242ccdceda1SDerek Schuff EnableEmSjLj)); 243f41f67d3SDerek Schuff 24410e730a2SDan Gohman TargetPassConfig::addIRPasses(); 24510e730a2SDan Gohman } 24610e730a2SDan Gohman 24710e730a2SDan Gohman bool WebAssemblyPassConfig::addInstSelector() { 248b0921ca9SDan Gohman (void)TargetPassConfig::addInstSelector(); 24910e730a2SDan Gohman addPass( 25010e730a2SDan Gohman createWebAssemblyISelDag(getWebAssemblyTargetMachine(), getOptLevel())); 2511cf96c0cSDan Gohman // Run the argument-move pass immediately after the ScheduleDAG scheduler 2521cf96c0cSDan Gohman // so that we can fix up the ARGUMENT instructions before anything else 2531cf96c0cSDan Gohman // sees them in the wrong place. 2541cf96c0cSDan Gohman addPass(createWebAssemblyArgumentMove()); 255bb372243SDan Gohman // Set the p2align operands. This information is present during ISel, however 256bb372243SDan Gohman // it's inconvenient to collect. Collect it now, and update the immediate 257bb372243SDan Gohman // operands. 258bb372243SDan Gohman addPass(createWebAssemblySetP2AlignOperands()); 25910e730a2SDan Gohman return false; 26010e730a2SDan Gohman } 26110e730a2SDan Gohman 262600aee98SJF Bastien void WebAssemblyPassConfig::addPostRegAlloc() { 2639c54d3b4SDan Gohman // TODO: The following CodeGen passes don't currently support code containing 2649c54d3b4SDan Gohman // virtual registers. Consider removing their restrictions and re-enabling 2659c54d3b4SDan Gohman // them. 266ad154c83SDerek Schuff 2671eb47368SMatthias Braun // These functions all require the NoVRegs property. 268600aee98SJF Bastien disablePass(&MachineCopyPropagationID); 2697ab1b32bSJun Bum Lim disablePass(&PostRAMachineSinkingID); 270ecabac62SDerek Schuff disablePass(&PostRASchedulerID); 271ecabac62SDerek Schuff disablePass(&FuncletLayoutID); 272ecabac62SDerek Schuff disablePass(&StackMapLivenessID); 273ecabac62SDerek Schuff disablePass(&LiveDebugValuesID); 274fe71ec77SSanjoy Das disablePass(&PatchableFunctionID); 2757ab1b32bSJun Bum Lim disablePass(&ShrinkWrapID); 276950a13cfSDan Gohman 277b0921ca9SDan Gohman TargetPassConfig::addPostRegAlloc(); 278600aee98SJF Bastien } 27910e730a2SDan Gohman 280950a13cfSDan Gohman void WebAssemblyPassConfig::addPreEmitPass() { 281b0921ca9SDan Gohman TargetPassConfig::addPreEmitPass(); 282b0921ca9SDan Gohman 2830cfb5f85SDan Gohman // Now that we have a prologue and epilogue and all frame indices are 2840cfb5f85SDan Gohman // rewritten, eliminate SP and FP. This allows them to be stackified, 2850cfb5f85SDan Gohman // colored, and numbered with the rest of the registers. 2860cfb5f85SDan Gohman addPass(createWebAssemblyReplacePhysRegs()); 2870cfb5f85SDan Gohman 2886f69783fSDerek Schuff // Rewrite pseudo call_indirect instructions as real instructions. 2896f69783fSDerek Schuff // This needs to run before register stackification, because we change the 2906f69783fSDerek Schuff // order of the arguments. 2916f69783fSDerek Schuff addPass(createWebAssemblyCallIndirectFixup()); 2926f69783fSDerek Schuff 2930cfb5f85SDan Gohman if (getOptLevel() != CodeGenOpt::None) { 2940cfb5f85SDan Gohman // LiveIntervals isn't commonly run this late. Re-establish preconditions. 2950cfb5f85SDan Gohman addPass(createWebAssemblyPrepareForLiveIntervals()); 2960cfb5f85SDan Gohman 2970cfb5f85SDan Gohman // Depend on LiveIntervals and perform some optimizations on it. 2980cfb5f85SDan Gohman addPass(createWebAssemblyOptimizeLiveIntervals()); 2990cfb5f85SDan Gohman 3000cfb5f85SDan Gohman // Prepare store instructions for register stackifying. 3010cfb5f85SDan Gohman addPass(createWebAssemblyStoreResults()); 3020cfb5f85SDan Gohman 303e040533eSDan Gohman // Mark registers as representing wasm's value stack. This is a key 3040cfb5f85SDan Gohman // code-compression technique in WebAssembly. We run this pass (and 3050cfb5f85SDan Gohman // StoreResults above) very late, so that it sees as much code as possible, 3060cfb5f85SDan Gohman // including code emitted by PEI and expanded by late tail duplication. 3070cfb5f85SDan Gohman addPass(createWebAssemblyRegStackify()); 3080cfb5f85SDan Gohman 3090cfb5f85SDan Gohman // Run the register coloring pass to reduce the total number of registers. 3100cfb5f85SDan Gohman // This runs after stackification so that it doesn't consider registers 3110cfb5f85SDan Gohman // that become stackified. 3120cfb5f85SDan Gohman addPass(createWebAssemblyRegColoring()); 3130cfb5f85SDan Gohman } 3140cfb5f85SDan Gohman 315d934cb88SDan Gohman // Eliminate multiple-entry loops. Do this before inserting explicit get_local 316d934cb88SDan Gohman // and set_local operators because we create a new variable that we want 317d934cb88SDan Gohman // converted into a local. 318d934cb88SDan Gohman addPass(createWebAssemblyFixIrreducibleControlFlow()); 319d934cb88SDan Gohman 3204fc4e42dSDan Gohman // Insert explicit get_local and set_local operators. 3214fc4e42dSDan Gohman addPass(createWebAssemblyExplicitLocals()); 3224fc4e42dSDan Gohman 3235ef4d5f9SHeejin Ahn // Do various transformations for exception handling 3244934f76bSHeejin Ahn addPass(createWebAssemblyLateEHPrepare()); 3255ef4d5f9SHeejin Ahn 326f52ee17aSDan Gohman // Sort the blocks of the CFG into topological order, a prerequisite for 327f52ee17aSDan Gohman // BLOCK and LOOP markers. 328f52ee17aSDan Gohman addPass(createWebAssemblyCFGSort()); 329f52ee17aSDan Gohman 330f52ee17aSDan Gohman // Insert BLOCK and LOOP markers. 331950a13cfSDan Gohman addPass(createWebAssemblyCFGStackify()); 3325941bde0SDan Gohman 333f0b165a7SDan Gohman // Lower br_unless into br_if. 334f0b165a7SDan Gohman addPass(createWebAssemblyLowerBrUnless()); 335f0b165a7SDan Gohman 3365941bde0SDan Gohman // Perform the very last peephole optimizations on the code. 337b13c91f1SDan Gohman if (getOptLevel() != CodeGenOpt::None) 33881719f85SDan Gohman addPass(createWebAssemblyPeephole()); 339b7c2400fSDan Gohman 340b7c2400fSDan Gohman // Create a mapping from LLVM CodeGen virtual registers to wasm registers. 341b7c2400fSDan Gohman addPass(createWebAssemblyRegNumbering()); 342950a13cfSDan Gohman } 343