1 //===- InstrProfWriter.cpp - Instrumented profiling writer ----------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file contains support for writing profiling data for clang's 10 // instrumentation based PGO and coverage. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "llvm/ProfileData/InstrProfWriter.h" 15 #include "llvm/ADT/STLExtras.h" 16 #include "llvm/ADT/StringRef.h" 17 #include "llvm/IR/ProfileSummary.h" 18 #include "llvm/ProfileData/InstrProf.h" 19 #include "llvm/ProfileData/MemProf.h" 20 #include "llvm/ProfileData/ProfileCommon.h" 21 #include "llvm/Support/Endian.h" 22 #include "llvm/Support/EndianStream.h" 23 #include "llvm/Support/Error.h" 24 #include "llvm/Support/MemoryBuffer.h" 25 #include "llvm/Support/OnDiskHashTable.h" 26 #include "llvm/Support/raw_ostream.h" 27 #include <algorithm> 28 #include <cstdint> 29 #include <memory> 30 #include <string> 31 #include <tuple> 32 #include <utility> 33 #include <vector> 34 35 using namespace llvm; 36 37 // A struct to define how the data stream should be patched. For Indexed 38 // profiling, only uint64_t data type is needed. 39 struct PatchItem { 40 uint64_t Pos; // Where to patch. 41 uint64_t *D; // Pointer to an array of source data. 42 int N; // Number of elements in \c D array. 43 }; 44 45 namespace llvm { 46 47 // A wrapper class to abstract writer stream with support of bytes 48 // back patching. 49 class ProfOStream { 50 public: 51 ProfOStream(raw_fd_ostream &FD) 52 : IsFDOStream(true), OS(FD), LE(FD, support::little) {} 53 ProfOStream(raw_string_ostream &STR) 54 : IsFDOStream(false), OS(STR), LE(STR, support::little) {} 55 56 uint64_t tell() { return OS.tell(); } 57 void write(uint64_t V) { LE.write<uint64_t>(V); } 58 59 // \c patch can only be called when all data is written and flushed. 60 // For raw_string_ostream, the patch is done on the target string 61 // directly and it won't be reflected in the stream's internal buffer. 62 void patch(PatchItem *P, int NItems) { 63 using namespace support; 64 65 if (IsFDOStream) { 66 raw_fd_ostream &FDOStream = static_cast<raw_fd_ostream &>(OS); 67 const uint64_t LastPos = FDOStream.tell(); 68 for (int K = 0; K < NItems; K++) { 69 FDOStream.seek(P[K].Pos); 70 for (int I = 0; I < P[K].N; I++) 71 write(P[K].D[I]); 72 } 73 // Reset the stream to the last position after patching so that users 74 // don't accidentally overwrite data. This makes it consistent with 75 // the string stream below which replaces the data directly. 76 FDOStream.seek(LastPos); 77 } else { 78 raw_string_ostream &SOStream = static_cast<raw_string_ostream &>(OS); 79 std::string &Data = SOStream.str(); // with flush 80 for (int K = 0; K < NItems; K++) { 81 for (int I = 0; I < P[K].N; I++) { 82 uint64_t Bytes = endian::byte_swap<uint64_t, little>(P[K].D[I]); 83 Data.replace(P[K].Pos + I * sizeof(uint64_t), sizeof(uint64_t), 84 (const char *)&Bytes, sizeof(uint64_t)); 85 } 86 } 87 } 88 } 89 90 // If \c OS is an instance of \c raw_fd_ostream, this field will be 91 // true. Otherwise, \c OS will be an raw_string_ostream. 92 bool IsFDOStream; 93 raw_ostream &OS; 94 support::endian::Writer LE; 95 }; 96 97 class InstrProfRecordWriterTrait { 98 public: 99 using key_type = StringRef; 100 using key_type_ref = StringRef; 101 102 using data_type = const InstrProfWriter::ProfilingData *const; 103 using data_type_ref = const InstrProfWriter::ProfilingData *const; 104 105 using hash_value_type = uint64_t; 106 using offset_type = uint64_t; 107 108 support::endianness ValueProfDataEndianness = support::little; 109 InstrProfSummaryBuilder *SummaryBuilder; 110 InstrProfSummaryBuilder *CSSummaryBuilder; 111 112 InstrProfRecordWriterTrait() = default; 113 114 static hash_value_type ComputeHash(key_type_ref K) { 115 return IndexedInstrProf::ComputeHash(K); 116 } 117 118 static std::pair<offset_type, offset_type> 119 EmitKeyDataLength(raw_ostream &Out, key_type_ref K, data_type_ref V) { 120 using namespace support; 121 122 endian::Writer LE(Out, little); 123 124 offset_type N = K.size(); 125 LE.write<offset_type>(N); 126 127 offset_type M = 0; 128 for (const auto &ProfileData : *V) { 129 const InstrProfRecord &ProfRecord = ProfileData.second; 130 M += sizeof(uint64_t); // The function hash 131 M += sizeof(uint64_t); // The size of the Counts vector 132 M += ProfRecord.Counts.size() * sizeof(uint64_t); 133 134 // Value data 135 M += ValueProfData::getSize(ProfileData.second); 136 } 137 LE.write<offset_type>(M); 138 139 return std::make_pair(N, M); 140 } 141 142 void EmitKey(raw_ostream &Out, key_type_ref K, offset_type N) { 143 Out.write(K.data(), N); 144 } 145 146 void EmitData(raw_ostream &Out, key_type_ref, data_type_ref V, offset_type) { 147 using namespace support; 148 149 endian::Writer LE(Out, little); 150 for (const auto &ProfileData : *V) { 151 const InstrProfRecord &ProfRecord = ProfileData.second; 152 if (NamedInstrProfRecord::hasCSFlagInHash(ProfileData.first)) 153 CSSummaryBuilder->addRecord(ProfRecord); 154 else 155 SummaryBuilder->addRecord(ProfRecord); 156 157 LE.write<uint64_t>(ProfileData.first); // Function hash 158 LE.write<uint64_t>(ProfRecord.Counts.size()); 159 for (uint64_t I : ProfRecord.Counts) 160 LE.write<uint64_t>(I); 161 162 // Write value data 163 std::unique_ptr<ValueProfData> VDataPtr = 164 ValueProfData::serializeFrom(ProfileData.second); 165 uint32_t S = VDataPtr->getSize(); 166 VDataPtr->swapBytesFromHost(ValueProfDataEndianness); 167 Out.write((const char *)VDataPtr.get(), S); 168 } 169 } 170 }; 171 172 } // end namespace llvm 173 174 InstrProfWriter::InstrProfWriter(bool Sparse) 175 : Sparse(Sparse), InfoObj(new InstrProfRecordWriterTrait()) {} 176 177 InstrProfWriter::~InstrProfWriter() { delete InfoObj; } 178 179 // Internal interface for testing purpose only. 180 void InstrProfWriter::setValueProfDataEndianness( 181 support::endianness Endianness) { 182 InfoObj->ValueProfDataEndianness = Endianness; 183 } 184 185 void InstrProfWriter::setOutputSparse(bool Sparse) { 186 this->Sparse = Sparse; 187 } 188 189 void InstrProfWriter::addRecord(NamedInstrProfRecord &&I, uint64_t Weight, 190 function_ref<void(Error)> Warn) { 191 auto Name = I.Name; 192 auto Hash = I.Hash; 193 addRecord(Name, Hash, std::move(I), Weight, Warn); 194 } 195 196 void InstrProfWriter::overlapRecord(NamedInstrProfRecord &&Other, 197 OverlapStats &Overlap, 198 OverlapStats &FuncLevelOverlap, 199 const OverlapFuncFilters &FuncFilter) { 200 auto Name = Other.Name; 201 auto Hash = Other.Hash; 202 Other.accumulateCounts(FuncLevelOverlap.Test); 203 if (FunctionData.find(Name) == FunctionData.end()) { 204 Overlap.addOneUnique(FuncLevelOverlap.Test); 205 return; 206 } 207 if (FuncLevelOverlap.Test.CountSum < 1.0f) { 208 Overlap.Overlap.NumEntries += 1; 209 return; 210 } 211 auto &ProfileDataMap = FunctionData[Name]; 212 bool NewFunc; 213 ProfilingData::iterator Where; 214 std::tie(Where, NewFunc) = 215 ProfileDataMap.insert(std::make_pair(Hash, InstrProfRecord())); 216 if (NewFunc) { 217 Overlap.addOneMismatch(FuncLevelOverlap.Test); 218 return; 219 } 220 InstrProfRecord &Dest = Where->second; 221 222 uint64_t ValueCutoff = FuncFilter.ValueCutoff; 223 if (!FuncFilter.NameFilter.empty() && Name.contains(FuncFilter.NameFilter)) 224 ValueCutoff = 0; 225 226 Dest.overlap(Other, Overlap, FuncLevelOverlap, ValueCutoff); 227 } 228 229 void InstrProfWriter::addRecord(StringRef Name, uint64_t Hash, 230 InstrProfRecord &&I, uint64_t Weight, 231 function_ref<void(Error)> Warn) { 232 auto &ProfileDataMap = FunctionData[Name]; 233 234 bool NewFunc; 235 ProfilingData::iterator Where; 236 std::tie(Where, NewFunc) = 237 ProfileDataMap.insert(std::make_pair(Hash, InstrProfRecord())); 238 InstrProfRecord &Dest = Where->second; 239 240 auto MapWarn = [&](instrprof_error E) { 241 Warn(make_error<InstrProfError>(E)); 242 }; 243 244 if (NewFunc) { 245 // We've never seen a function with this name and hash, add it. 246 Dest = std::move(I); 247 if (Weight > 1) 248 Dest.scale(Weight, 1, MapWarn); 249 } else { 250 // We're updating a function we've seen before. 251 Dest.merge(I, Weight, MapWarn); 252 } 253 254 Dest.sortValueData(); 255 } 256 257 void InstrProfWriter::addRecord(const memprof::MemProfRecord &MR, 258 function_ref<void(Error)> Warn) { 259 // Use 0 as a sentinel value since its highly unlikely that the lower 64-bits 260 // of a 128 bit md5 hash will be all zeros. 261 // TODO: Move this Key frame detection to the contructor to avoid having to 262 // scan all the callstacks again when adding a new record. 263 uint64_t Key = 0; 264 for (auto Iter = MR.CallStack.rbegin(), End = MR.CallStack.rend(); 265 Iter != End; Iter++) { 266 if (!Iter->IsInlineFrame) { 267 Key = Iter->Function; 268 break; 269 } 270 } 271 272 if (Key == 0) { 273 Warn(make_error<InstrProfError>( 274 instrprof_error::invalid_prof, 275 "could not determine leaf function for memprof record.")); 276 } 277 278 MemProfData[Key].push_back(MR); 279 } 280 281 void InstrProfWriter::mergeRecordsFromWriter(InstrProfWriter &&IPW, 282 function_ref<void(Error)> Warn) { 283 for (auto &I : IPW.FunctionData) 284 for (auto &Func : I.getValue()) 285 addRecord(I.getKey(), Func.first, std::move(Func.second), 1, Warn); 286 287 for (auto &I : IPW.MemProfData) 288 for (const auto &MR : I.second) 289 addRecord(MR, Warn); 290 } 291 292 bool InstrProfWriter::shouldEncodeData(const ProfilingData &PD) { 293 if (!Sparse) 294 return true; 295 for (const auto &Func : PD) { 296 const InstrProfRecord &IPR = Func.second; 297 if (llvm::any_of(IPR.Counts, [](uint64_t Count) { return Count > 0; })) 298 return true; 299 } 300 return false; 301 } 302 303 static void setSummary(IndexedInstrProf::Summary *TheSummary, 304 ProfileSummary &PS) { 305 using namespace IndexedInstrProf; 306 307 const std::vector<ProfileSummaryEntry> &Res = PS.getDetailedSummary(); 308 TheSummary->NumSummaryFields = Summary::NumKinds; 309 TheSummary->NumCutoffEntries = Res.size(); 310 TheSummary->set(Summary::MaxFunctionCount, PS.getMaxFunctionCount()); 311 TheSummary->set(Summary::MaxBlockCount, PS.getMaxCount()); 312 TheSummary->set(Summary::MaxInternalBlockCount, PS.getMaxInternalCount()); 313 TheSummary->set(Summary::TotalBlockCount, PS.getTotalCount()); 314 TheSummary->set(Summary::TotalNumBlocks, PS.getNumCounts()); 315 TheSummary->set(Summary::TotalNumFunctions, PS.getNumFunctions()); 316 for (unsigned I = 0; I < Res.size(); I++) 317 TheSummary->setEntry(I, Res[I]); 318 } 319 320 Error InstrProfWriter::writeImpl(ProfOStream &OS) { 321 using namespace IndexedInstrProf; 322 323 OnDiskChainedHashTableGenerator<InstrProfRecordWriterTrait> Generator; 324 325 InstrProfSummaryBuilder ISB(ProfileSummaryBuilder::DefaultCutoffs); 326 InfoObj->SummaryBuilder = &ISB; 327 InstrProfSummaryBuilder CSISB(ProfileSummaryBuilder::DefaultCutoffs); 328 InfoObj->CSSummaryBuilder = &CSISB; 329 330 // Populate the hash table generator. 331 for (const auto &I : FunctionData) 332 if (shouldEncodeData(I.getValue())) 333 Generator.insert(I.getKey(), &I.getValue()); 334 335 // Write the header. 336 IndexedInstrProf::Header Header; 337 Header.Magic = IndexedInstrProf::Magic; 338 Header.Version = IndexedInstrProf::ProfVersion::CurrentVersion; 339 if (static_cast<bool>(ProfileKind & InstrProfKind::IR)) 340 Header.Version |= VARIANT_MASK_IR_PROF; 341 if (static_cast<bool>(ProfileKind & InstrProfKind::CS)) 342 Header.Version |= VARIANT_MASK_CSIR_PROF; 343 if (static_cast<bool>(ProfileKind & InstrProfKind::BB)) 344 Header.Version |= VARIANT_MASK_INSTR_ENTRY; 345 if (static_cast<bool>(ProfileKind & InstrProfKind::SingleByteCoverage)) 346 Header.Version |= VARIANT_MASK_BYTE_COVERAGE; 347 if (static_cast<bool>(ProfileKind & InstrProfKind::FunctionEntryOnly)) 348 Header.Version |= VARIANT_MASK_FUNCTION_ENTRY_ONLY; 349 if (static_cast<bool>(ProfileKind & InstrProfKind::MemProf)) 350 Header.Version |= VARIANT_MASK_MEMPROF; 351 352 Header.Unused = 0; 353 Header.HashType = static_cast<uint64_t>(IndexedInstrProf::HashType); 354 Header.HashOffset = 0; 355 Header.MemProfOffset = 0; 356 int N = sizeof(IndexedInstrProf::Header) / sizeof(uint64_t); 357 358 // Only write out all the fields except 'HashOffset' and 'MemProfOffset'. We 359 // need to remember the offset of these fields to allow back patching later. 360 for (int I = 0; I < N - 2; I++) 361 OS.write(reinterpret_cast<uint64_t *>(&Header)[I]); 362 363 // Save the location of Header.HashOffset field in \c OS. 364 uint64_t HashTableStartFieldOffset = OS.tell(); 365 // Reserve the space for HashOffset field. 366 OS.write(0); 367 368 // Save the location of MemProf profile data. This is stored in two parts as 369 // the schema and as a separate on-disk chained hashtable. 370 uint64_t MemProfSectionOffset = OS.tell(); 371 // Reserve space for the MemProf table field to be patched later if this 372 // profile contains memory profile information. 373 OS.write(0); 374 375 // Reserve space to write profile summary data. 376 uint32_t NumEntries = ProfileSummaryBuilder::DefaultCutoffs.size(); 377 uint32_t SummarySize = Summary::getSize(Summary::NumKinds, NumEntries); 378 // Remember the summary offset. 379 uint64_t SummaryOffset = OS.tell(); 380 for (unsigned I = 0; I < SummarySize / sizeof(uint64_t); I++) 381 OS.write(0); 382 uint64_t CSSummaryOffset = 0; 383 uint64_t CSSummarySize = 0; 384 if (static_cast<bool>(ProfileKind & InstrProfKind::CS)) { 385 CSSummaryOffset = OS.tell(); 386 CSSummarySize = SummarySize / sizeof(uint64_t); 387 for (unsigned I = 0; I < CSSummarySize; I++) 388 OS.write(0); 389 } 390 391 // Write the hash table. 392 uint64_t HashTableStart = Generator.Emit(OS.OS, *InfoObj); 393 394 // Write the MemProf profile data if we have it. This includes a simple schema 395 // with the format described below followed by the hashtable: 396 // uint64_t Offset = MemProfGenerator.Emit 397 // uint64_t Num schema entries 398 // uint64_t Schema entry 0 399 // uint64_t Schema entry 1 400 // .... 401 // uint64_t Schema entry N - 1 402 // OnDiskChainedHashTable MemProfFunctionData 403 uint64_t MemProfSectionStart = 0; 404 if (static_cast<bool>(ProfileKind & InstrProfKind::MemProf)) { 405 MemProfSectionStart = OS.tell(); 406 OS.write(0ULL); // Reserve space for the offset. 407 408 auto Schema = memprof::PortableMemInfoBlock::getSchema(); 409 OS.write(static_cast<uint64_t>(Schema.size())); 410 for (const auto Id : Schema) { 411 OS.write(static_cast<uint64_t>(Id)); 412 } 413 414 auto MemProfWriter = std::make_unique<memprof::MemProfRecordWriterTrait>(); 415 MemProfWriter->Schema = &Schema; 416 OnDiskChainedHashTableGenerator<memprof::MemProfRecordWriterTrait> 417 MemProfGenerator; 418 for (const auto &I : MemProfData) { 419 // Insert the key (func hash) and value (vector of memprof records). 420 MemProfGenerator.insert(I.first, I.second); 421 } 422 423 uint64_t TableOffset = MemProfGenerator.Emit(OS.OS, *MemProfWriter); 424 PatchItem PatchItems[] = { 425 {MemProfSectionStart, &TableOffset, 1}, 426 }; 427 OS.patch(PatchItems, 1); 428 } 429 430 // Allocate space for data to be serialized out. 431 std::unique_ptr<IndexedInstrProf::Summary> TheSummary = 432 IndexedInstrProf::allocSummary(SummarySize); 433 // Compute the Summary and copy the data to the data 434 // structure to be serialized out (to disk or buffer). 435 std::unique_ptr<ProfileSummary> PS = ISB.getSummary(); 436 setSummary(TheSummary.get(), *PS); 437 InfoObj->SummaryBuilder = nullptr; 438 439 // For Context Sensitive summary. 440 std::unique_ptr<IndexedInstrProf::Summary> TheCSSummary = nullptr; 441 if (static_cast<bool>(ProfileKind & InstrProfKind::CS)) { 442 TheCSSummary = IndexedInstrProf::allocSummary(SummarySize); 443 std::unique_ptr<ProfileSummary> CSPS = CSISB.getSummary(); 444 setSummary(TheCSSummary.get(), *CSPS); 445 } 446 InfoObj->CSSummaryBuilder = nullptr; 447 448 // Now do the final patch: 449 PatchItem PatchItems[] = { 450 // Patch the Header.HashOffset field. 451 {HashTableStartFieldOffset, &HashTableStart, 1}, 452 // Patch the Header.MemProfOffset (=0 for profiles without MemProf data). 453 {MemProfSectionOffset, &MemProfSectionStart, 1}, 454 // Patch the summary data. 455 {SummaryOffset, reinterpret_cast<uint64_t *>(TheSummary.get()), 456 (int)(SummarySize / sizeof(uint64_t))}, 457 {CSSummaryOffset, reinterpret_cast<uint64_t *>(TheCSSummary.get()), 458 (int)CSSummarySize}}; 459 460 OS.patch(PatchItems, sizeof(PatchItems) / sizeof(*PatchItems)); 461 462 for (const auto &I : FunctionData) 463 for (const auto &F : I.getValue()) 464 if (Error E = validateRecord(F.second)) 465 return E; 466 467 return Error::success(); 468 } 469 470 Error InstrProfWriter::write(raw_fd_ostream &OS) { 471 // Write the hash table. 472 ProfOStream POS(OS); 473 return writeImpl(POS); 474 } 475 476 std::unique_ptr<MemoryBuffer> InstrProfWriter::writeBuffer() { 477 std::string Data; 478 raw_string_ostream OS(Data); 479 ProfOStream POS(OS); 480 // Write the hash table. 481 if (Error E = writeImpl(POS)) 482 return nullptr; 483 // Return this in an aligned memory buffer. 484 return MemoryBuffer::getMemBufferCopy(Data); 485 } 486 487 static const char *ValueProfKindStr[] = { 488 #define VALUE_PROF_KIND(Enumerator, Value, Descr) #Enumerator, 489 #include "llvm/ProfileData/InstrProfData.inc" 490 }; 491 492 Error InstrProfWriter::validateRecord(const InstrProfRecord &Func) { 493 for (uint32_t VK = 0; VK <= IPVK_Last; VK++) { 494 uint32_t NS = Func.getNumValueSites(VK); 495 if (!NS) 496 continue; 497 for (uint32_t S = 0; S < NS; S++) { 498 uint32_t ND = Func.getNumValueDataForSite(VK, S); 499 std::unique_ptr<InstrProfValueData[]> VD = Func.getValueForSite(VK, S); 500 bool WasZero = false; 501 for (uint32_t I = 0; I < ND; I++) 502 if ((VK != IPVK_IndirectCallTarget) && (VD[I].Value == 0)) { 503 if (WasZero) 504 return make_error<InstrProfError>(instrprof_error::invalid_prof); 505 WasZero = true; 506 } 507 } 508 } 509 510 return Error::success(); 511 } 512 513 void InstrProfWriter::writeRecordInText(StringRef Name, uint64_t Hash, 514 const InstrProfRecord &Func, 515 InstrProfSymtab &Symtab, 516 raw_fd_ostream &OS) { 517 OS << Name << "\n"; 518 OS << "# Func Hash:\n" << Hash << "\n"; 519 OS << "# Num Counters:\n" << Func.Counts.size() << "\n"; 520 OS << "# Counter Values:\n"; 521 for (uint64_t Count : Func.Counts) 522 OS << Count << "\n"; 523 524 uint32_t NumValueKinds = Func.getNumValueKinds(); 525 if (!NumValueKinds) { 526 OS << "\n"; 527 return; 528 } 529 530 OS << "# Num Value Kinds:\n" << Func.getNumValueKinds() << "\n"; 531 for (uint32_t VK = 0; VK < IPVK_Last + 1; VK++) { 532 uint32_t NS = Func.getNumValueSites(VK); 533 if (!NS) 534 continue; 535 OS << "# ValueKind = " << ValueProfKindStr[VK] << ":\n" << VK << "\n"; 536 OS << "# NumValueSites:\n" << NS << "\n"; 537 for (uint32_t S = 0; S < NS; S++) { 538 uint32_t ND = Func.getNumValueDataForSite(VK, S); 539 OS << ND << "\n"; 540 std::unique_ptr<InstrProfValueData[]> VD = Func.getValueForSite(VK, S); 541 for (uint32_t I = 0; I < ND; I++) { 542 if (VK == IPVK_IndirectCallTarget) 543 OS << Symtab.getFuncNameOrExternalSymbol(VD[I].Value) << ":" 544 << VD[I].Count << "\n"; 545 else 546 OS << VD[I].Value << ":" << VD[I].Count << "\n"; 547 } 548 } 549 } 550 551 OS << "\n"; 552 } 553 554 Error InstrProfWriter::writeText(raw_fd_ostream &OS) { 555 // Check CS first since it implies an IR level profile. 556 if (static_cast<bool>(ProfileKind & InstrProfKind::CS)) 557 OS << "# CSIR level Instrumentation Flag\n:csir\n"; 558 else if (static_cast<bool>(ProfileKind & InstrProfKind::IR)) 559 OS << "# IR level Instrumentation Flag\n:ir\n"; 560 561 if (static_cast<bool>(ProfileKind & InstrProfKind::BB)) 562 OS << "# Always instrument the function entry block\n:entry_first\n"; 563 InstrProfSymtab Symtab; 564 565 using FuncPair = detail::DenseMapPair<uint64_t, InstrProfRecord>; 566 using RecordType = std::pair<StringRef, FuncPair>; 567 SmallVector<RecordType, 4> OrderedFuncData; 568 569 for (const auto &I : FunctionData) { 570 if (shouldEncodeData(I.getValue())) { 571 if (Error E = Symtab.addFuncName(I.getKey())) 572 return E; 573 for (const auto &Func : I.getValue()) 574 OrderedFuncData.push_back(std::make_pair(I.getKey(), Func)); 575 } 576 } 577 578 llvm::sort(OrderedFuncData, [](const RecordType &A, const RecordType &B) { 579 return std::tie(A.first, A.second.first) < 580 std::tie(B.first, B.second.first); 581 }); 582 583 for (const auto &record : OrderedFuncData) { 584 const StringRef &Name = record.first; 585 const FuncPair &Func = record.second; 586 writeRecordInText(Name, Func.first, Func.second, Symtab, OS); 587 } 588 589 for (const auto &record : OrderedFuncData) { 590 const FuncPair &Func = record.second; 591 if (Error E = validateRecord(Func.second)) 592 return E; 593 } 594 595 return Error::success(); 596 } 597