1 //===- DWARFVerifier.cpp --------------------------------------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 #include "llvm/DebugInfo/DWARF/DWARFVerifier.h" 10 #include "llvm/ADT/SmallSet.h" 11 #include "llvm/DebugInfo/DWARF/DWARFCompileUnit.h" 12 #include "llvm/DebugInfo/DWARF/DWARFContext.h" 13 #include "llvm/DebugInfo/DWARF/DWARFDebugLine.h" 14 #include "llvm/DebugInfo/DWARF/DWARFDie.h" 15 #include "llvm/DebugInfo/DWARF/DWARFExpression.h" 16 #include "llvm/DebugInfo/DWARF/DWARFFormValue.h" 17 #include "llvm/DebugInfo/DWARF/DWARFSection.h" 18 #include "llvm/Support/DJB.h" 19 #include "llvm/Support/FormatVariadic.h" 20 #include "llvm/Support/WithColor.h" 21 #include "llvm/Support/raw_ostream.h" 22 #include <map> 23 #include <set> 24 #include <vector> 25 26 using namespace llvm; 27 using namespace dwarf; 28 using namespace object; 29 30 DWARFVerifier::DieRangeInfo::address_range_iterator 31 DWARFVerifier::DieRangeInfo::insert(const DWARFAddressRange &R) { 32 auto Begin = Ranges.begin(); 33 auto End = Ranges.end(); 34 auto Pos = std::lower_bound(Begin, End, R); 35 36 if (Pos != End) { 37 if (Pos->intersects(R)) 38 return Pos; 39 if (Pos != Begin) { 40 auto Iter = Pos - 1; 41 if (Iter->intersects(R)) 42 return Iter; 43 } 44 } 45 46 Ranges.insert(Pos, R); 47 return Ranges.end(); 48 } 49 50 DWARFVerifier::DieRangeInfo::die_range_info_iterator 51 DWARFVerifier::DieRangeInfo::insert(const DieRangeInfo &RI) { 52 auto End = Children.end(); 53 auto Iter = Children.begin(); 54 while (Iter != End) { 55 if (Iter->intersects(RI)) 56 return Iter; 57 ++Iter; 58 } 59 Children.insert(RI); 60 return Children.end(); 61 } 62 63 bool DWARFVerifier::DieRangeInfo::contains(const DieRangeInfo &RHS) const { 64 // Both list of ranges are sorted so we can make this fast. 65 66 if (Ranges.empty() || RHS.Ranges.empty()) 67 return false; 68 69 // Since the ranges are sorted we can advance where we start searching with 70 // this object's ranges as we traverse RHS.Ranges. 71 auto End = Ranges.end(); 72 auto Iter = findRange(RHS.Ranges.front()); 73 74 // Now linearly walk the ranges in this object and see if they contain each 75 // ranges from RHS.Ranges. 76 for (const auto &R : RHS.Ranges) { 77 while (Iter != End) { 78 if (Iter->contains(R)) 79 break; 80 ++Iter; 81 } 82 if (Iter == End) 83 return false; 84 } 85 return true; 86 } 87 88 bool DWARFVerifier::DieRangeInfo::intersects(const DieRangeInfo &RHS) const { 89 if (Ranges.empty() || RHS.Ranges.empty()) 90 return false; 91 92 auto End = Ranges.end(); 93 auto Iter = findRange(RHS.Ranges.front()); 94 for (const auto &R : RHS.Ranges) { 95 if (Iter == End) 96 return false; 97 if (R.HighPC <= Iter->LowPC) 98 continue; 99 while (Iter != End) { 100 if (Iter->intersects(R)) 101 return true; 102 ++Iter; 103 } 104 } 105 106 return false; 107 } 108 109 bool DWARFVerifier::verifyUnitHeader(const DWARFDataExtractor DebugInfoData, 110 uint32_t *Offset, unsigned UnitIndex, 111 uint8_t &UnitType, bool &isUnitDWARF64) { 112 uint32_t AbbrOffset, Length; 113 uint8_t AddrSize = 0; 114 uint16_t Version; 115 bool Success = true; 116 117 bool ValidLength = false; 118 bool ValidVersion = false; 119 bool ValidAddrSize = false; 120 bool ValidType = true; 121 bool ValidAbbrevOffset = true; 122 123 uint32_t OffsetStart = *Offset; 124 Length = DebugInfoData.getU32(Offset); 125 if (Length == UINT32_MAX) { 126 isUnitDWARF64 = true; 127 OS << format( 128 "Unit[%d] is in 64-bit DWARF format; cannot verify from this point.\n", 129 UnitIndex); 130 return false; 131 } 132 Version = DebugInfoData.getU16(Offset); 133 134 if (Version >= 5) { 135 UnitType = DebugInfoData.getU8(Offset); 136 AddrSize = DebugInfoData.getU8(Offset); 137 AbbrOffset = DebugInfoData.getU32(Offset); 138 ValidType = dwarf::isUnitType(UnitType); 139 } else { 140 UnitType = 0; 141 AbbrOffset = DebugInfoData.getU32(Offset); 142 AddrSize = DebugInfoData.getU8(Offset); 143 } 144 145 if (!DCtx.getDebugAbbrev()->getAbbreviationDeclarationSet(AbbrOffset)) 146 ValidAbbrevOffset = false; 147 148 ValidLength = DebugInfoData.isValidOffset(OffsetStart + Length + 3); 149 ValidVersion = DWARFContext::isSupportedVersion(Version); 150 ValidAddrSize = AddrSize == 4 || AddrSize == 8; 151 if (!ValidLength || !ValidVersion || !ValidAddrSize || !ValidAbbrevOffset || 152 !ValidType) { 153 Success = false; 154 error() << format("Units[%d] - start offset: 0x%08x \n", UnitIndex, 155 OffsetStart); 156 if (!ValidLength) 157 note() << "The length for this unit is too " 158 "large for the .debug_info provided.\n"; 159 if (!ValidVersion) 160 note() << "The 16 bit unit header version is not valid.\n"; 161 if (!ValidType) 162 note() << "The unit type encoding is not valid.\n"; 163 if (!ValidAbbrevOffset) 164 note() << "The offset into the .debug_abbrev section is " 165 "not valid.\n"; 166 if (!ValidAddrSize) 167 note() << "The address size is unsupported.\n"; 168 } 169 *Offset = OffsetStart + Length + 4; 170 return Success; 171 } 172 173 unsigned DWARFVerifier::verifyUnitContents(DWARFUnit &Unit) { 174 unsigned NumUnitErrors = 0; 175 unsigned NumDies = Unit.getNumDIEs(); 176 for (unsigned I = 0; I < NumDies; ++I) { 177 auto Die = Unit.getDIEAtIndex(I); 178 179 if (Die.getTag() == DW_TAG_null) 180 continue; 181 182 bool HasTypeAttr = false; 183 for (auto AttrValue : Die.attributes()) { 184 NumUnitErrors += verifyDebugInfoAttribute(Die, AttrValue); 185 NumUnitErrors += verifyDebugInfoForm(Die, AttrValue); 186 HasTypeAttr |= (AttrValue.Attr == DW_AT_type); 187 } 188 189 if (!HasTypeAttr && (Die.getTag() == DW_TAG_formal_parameter || 190 Die.getTag() == DW_TAG_variable || 191 Die.getTag() == DW_TAG_array_type)) { 192 error() << "DIE with tag " << TagString(Die.getTag()) 193 << " is missing type attribute:\n"; 194 dump(Die) << '\n'; 195 NumUnitErrors++; 196 } 197 NumUnitErrors += verifyDebugInfoCallSite(Die); 198 } 199 200 DWARFDie Die = Unit.getUnitDIE(/* ExtractUnitDIEOnly = */ false); 201 if (!Die) { 202 error() << "Compilation unit without DIE.\n"; 203 NumUnitErrors++; 204 return NumUnitErrors; 205 } 206 207 if (!dwarf::isUnitType(Die.getTag())) { 208 error() << "Compilation unit root DIE is not a unit DIE: " 209 << dwarf::TagString(Die.getTag()) << ".\n"; 210 NumUnitErrors++; 211 } 212 213 uint8_t UnitType = Unit.getUnitType(); 214 if (!DWARFUnit::isMatchingUnitTypeAndTag(UnitType, Die.getTag())) { 215 error() << "Compilation unit type (" << dwarf::UnitTypeString(UnitType) 216 << ") and root DIE (" << dwarf::TagString(Die.getTag()) 217 << ") do not match.\n"; 218 NumUnitErrors++; 219 } 220 221 DieRangeInfo RI; 222 NumUnitErrors += verifyDieRanges(Die, RI); 223 224 return NumUnitErrors; 225 } 226 227 unsigned DWARFVerifier::verifyDebugInfoCallSite(const DWARFDie &Die) { 228 if (Die.getTag() != DW_TAG_call_site) 229 return 0; 230 231 DWARFDie Curr = Die.getParent(); 232 for (; Curr.isValid() && !Curr.isSubprogramDIE(); Curr = Die.getParent()) { 233 if (Curr.getTag() == DW_TAG_inlined_subroutine) { 234 error() << "Call site entry nested within inlined subroutine:"; 235 Curr.dump(OS); 236 return 1; 237 } 238 } 239 240 if (!Curr.isValid()) { 241 error() << "Call site entry not nested within a valid subprogram:"; 242 Die.dump(OS); 243 return 1; 244 } 245 246 Optional<DWARFFormValue> CallAttr = 247 Curr.find({DW_AT_call_all_calls, DW_AT_call_all_source_calls, 248 DW_AT_call_all_tail_calls}); 249 if (!CallAttr) { 250 error() << "Subprogram with call site entry has no DW_AT_call attribute:"; 251 Curr.dump(OS); 252 Die.dump(OS, /*indent*/ 1); 253 return 1; 254 } 255 256 return 0; 257 } 258 259 unsigned DWARFVerifier::verifyAbbrevSection(const DWARFDebugAbbrev *Abbrev) { 260 unsigned NumErrors = 0; 261 if (Abbrev) { 262 const DWARFAbbreviationDeclarationSet *AbbrDecls = 263 Abbrev->getAbbreviationDeclarationSet(0); 264 for (auto AbbrDecl : *AbbrDecls) { 265 SmallDenseSet<uint16_t> AttributeSet; 266 for (auto Attribute : AbbrDecl.attributes()) { 267 auto Result = AttributeSet.insert(Attribute.Attr); 268 if (!Result.second) { 269 error() << "Abbreviation declaration contains multiple " 270 << AttributeString(Attribute.Attr) << " attributes.\n"; 271 AbbrDecl.dump(OS); 272 ++NumErrors; 273 } 274 } 275 } 276 } 277 return NumErrors; 278 } 279 280 bool DWARFVerifier::handleDebugAbbrev() { 281 OS << "Verifying .debug_abbrev...\n"; 282 283 const DWARFObject &DObj = DCtx.getDWARFObj(); 284 bool noDebugAbbrev = DObj.getAbbrevSection().empty(); 285 bool noDebugAbbrevDWO = DObj.getAbbrevDWOSection().empty(); 286 287 if (noDebugAbbrev && noDebugAbbrevDWO) { 288 return true; 289 } 290 291 unsigned NumErrors = 0; 292 if (!noDebugAbbrev) 293 NumErrors += verifyAbbrevSection(DCtx.getDebugAbbrev()); 294 295 if (!noDebugAbbrevDWO) 296 NumErrors += verifyAbbrevSection(DCtx.getDebugAbbrevDWO()); 297 return NumErrors == 0; 298 } 299 300 unsigned DWARFVerifier::verifyUnitSection(const DWARFSection &S, 301 DWARFSectionKind SectionKind) { 302 const DWARFObject &DObj = DCtx.getDWARFObj(); 303 DWARFDataExtractor DebugInfoData(DObj, S, DCtx.isLittleEndian(), 0); 304 unsigned NumDebugInfoErrors = 0; 305 uint32_t OffsetStart = 0, Offset = 0, UnitIdx = 0; 306 uint8_t UnitType = 0; 307 bool isUnitDWARF64 = false; 308 bool isHeaderChainValid = true; 309 bool hasDIE = DebugInfoData.isValidOffset(Offset); 310 DWARFUnitVector TypeUnitVector; 311 DWARFUnitVector CompileUnitVector; 312 while (hasDIE) { 313 OffsetStart = Offset; 314 if (!verifyUnitHeader(DebugInfoData, &Offset, UnitIdx, UnitType, 315 isUnitDWARF64)) { 316 isHeaderChainValid = false; 317 if (isUnitDWARF64) 318 break; 319 } else { 320 DWARFUnitHeader Header; 321 Header.extract(DCtx, DebugInfoData, &OffsetStart, SectionKind); 322 DWARFUnit *Unit; 323 switch (UnitType) { 324 case dwarf::DW_UT_type: 325 case dwarf::DW_UT_split_type: { 326 Unit = TypeUnitVector.addUnit(llvm::make_unique<DWARFTypeUnit>( 327 DCtx, S, Header, DCtx.getDebugAbbrev(), &DObj.getRangeSection(), 328 &DObj.getLocSection(), DObj.getStringSection(), 329 DObj.getStringOffsetSection(), &DObj.getAppleObjCSection(), 330 DObj.getLineSection(), DCtx.isLittleEndian(), false, 331 TypeUnitVector)); 332 break; 333 } 334 case dwarf::DW_UT_skeleton: 335 case dwarf::DW_UT_split_compile: 336 case dwarf::DW_UT_compile: 337 case dwarf::DW_UT_partial: 338 // UnitType = 0 means that we are verifying a compile unit in DWARF v4. 339 case 0: { 340 Unit = CompileUnitVector.addUnit(llvm::make_unique<DWARFCompileUnit>( 341 DCtx, S, Header, DCtx.getDebugAbbrev(), &DObj.getRangeSection(), 342 &DObj.getLocSection(), DObj.getStringSection(), 343 DObj.getStringOffsetSection(), &DObj.getAppleObjCSection(), 344 DObj.getLineSection(), DCtx.isLittleEndian(), false, 345 CompileUnitVector)); 346 break; 347 } 348 default: { llvm_unreachable("Invalid UnitType."); } 349 } 350 NumDebugInfoErrors += verifyUnitContents(*Unit); 351 } 352 hasDIE = DebugInfoData.isValidOffset(Offset); 353 ++UnitIdx; 354 } 355 if (UnitIdx == 0 && !hasDIE) { 356 warn() << "Section is empty.\n"; 357 isHeaderChainValid = true; 358 } 359 if (!isHeaderChainValid) 360 ++NumDebugInfoErrors; 361 NumDebugInfoErrors += verifyDebugInfoReferences(); 362 return NumDebugInfoErrors; 363 } 364 365 bool DWARFVerifier::handleDebugInfo() { 366 const DWARFObject &DObj = DCtx.getDWARFObj(); 367 368 OS << "Verifying .debug_info Unit Header Chain...\n"; 369 unsigned result = verifyUnitSection(DObj.getInfoSection(), DW_SECT_INFO); 370 371 OS << "Verifying .debug_types Unit Header Chain...\n"; 372 DObj.forEachTypesSections([&](const DWARFSection &S) { 373 result += verifyUnitSection(S, DW_SECT_TYPES); 374 }); 375 return result == 0; 376 } 377 378 unsigned DWARFVerifier::verifyDieRanges(const DWARFDie &Die, 379 DieRangeInfo &ParentRI) { 380 unsigned NumErrors = 0; 381 382 if (!Die.isValid()) 383 return NumErrors; 384 385 auto RangesOrError = Die.getAddressRanges(); 386 if (!RangesOrError) { 387 // FIXME: Report the error. 388 ++NumErrors; 389 llvm::consumeError(RangesOrError.takeError()); 390 return NumErrors; 391 } 392 393 DWARFAddressRangesVector Ranges = RangesOrError.get(); 394 // Build RI for this DIE and check that ranges within this DIE do not 395 // overlap. 396 DieRangeInfo RI(Die); 397 for (auto Range : Ranges) { 398 if (!Range.valid()) { 399 ++NumErrors; 400 error() << "Invalid address range " << Range << "\n"; 401 continue; 402 } 403 404 // Verify that ranges don't intersect. 405 const auto IntersectingRange = RI.insert(Range); 406 if (IntersectingRange != RI.Ranges.end()) { 407 ++NumErrors; 408 error() << "DIE has overlapping address ranges: " << Range << " and " 409 << *IntersectingRange << "\n"; 410 break; 411 } 412 } 413 414 // Verify that children don't intersect. 415 const auto IntersectingChild = ParentRI.insert(RI); 416 if (IntersectingChild != ParentRI.Children.end()) { 417 ++NumErrors; 418 error() << "DIEs have overlapping address ranges:"; 419 dump(Die); 420 dump(IntersectingChild->Die) << '\n'; 421 } 422 423 // Verify that ranges are contained within their parent. 424 bool ShouldBeContained = !Ranges.empty() && !ParentRI.Ranges.empty() && 425 !(Die.getTag() == DW_TAG_subprogram && 426 ParentRI.Die.getTag() == DW_TAG_subprogram); 427 if (ShouldBeContained && !ParentRI.contains(RI)) { 428 ++NumErrors; 429 error() << "DIE address ranges are not contained in its parent's ranges:"; 430 dump(ParentRI.Die); 431 dump(Die, 2) << '\n'; 432 } 433 434 // Recursively check children. 435 for (DWARFDie Child : Die) 436 NumErrors += verifyDieRanges(Child, RI); 437 438 return NumErrors; 439 } 440 441 unsigned DWARFVerifier::verifyDebugInfoAttribute(const DWARFDie &Die, 442 DWARFAttribute &AttrValue) { 443 unsigned NumErrors = 0; 444 auto ReportError = [&](const Twine &TitleMsg) { 445 ++NumErrors; 446 error() << TitleMsg << '\n'; 447 dump(Die) << '\n'; 448 }; 449 450 const DWARFObject &DObj = DCtx.getDWARFObj(); 451 const auto Attr = AttrValue.Attr; 452 switch (Attr) { 453 case DW_AT_ranges: 454 // Make sure the offset in the DW_AT_ranges attribute is valid. 455 if (auto SectionOffset = AttrValue.Value.getAsSectionOffset()) { 456 if (*SectionOffset >= DObj.getRangeSection().Data.size()) 457 ReportError("DW_AT_ranges offset is beyond .debug_ranges bounds:"); 458 break; 459 } 460 ReportError("DIE has invalid DW_AT_ranges encoding:"); 461 break; 462 case DW_AT_stmt_list: 463 // Make sure the offset in the DW_AT_stmt_list attribute is valid. 464 if (auto SectionOffset = AttrValue.Value.getAsSectionOffset()) { 465 if (*SectionOffset >= DObj.getLineSection().Data.size()) 466 ReportError("DW_AT_stmt_list offset is beyond .debug_line bounds: " + 467 llvm::formatv("{0:x8}", *SectionOffset)); 468 break; 469 } 470 ReportError("DIE has invalid DW_AT_stmt_list encoding:"); 471 break; 472 case DW_AT_location: { 473 auto VerifyLocationExpr = [&](StringRef D) { 474 DWARFUnit *U = Die.getDwarfUnit(); 475 DataExtractor Data(D, DCtx.isLittleEndian(), 0); 476 DWARFExpression Expression(Data, U->getVersion(), 477 U->getAddressByteSize()); 478 bool Error = llvm::any_of(Expression, [](DWARFExpression::Operation &Op) { 479 return Op.isError(); 480 }); 481 if (Error) 482 ReportError("DIE contains invalid DWARF expression:"); 483 }; 484 if (Optional<ArrayRef<uint8_t>> Expr = AttrValue.Value.getAsBlock()) { 485 // Verify inlined location. 486 VerifyLocationExpr(llvm::toStringRef(*Expr)); 487 } else if (auto LocOffset = AttrValue.Value.getAsSectionOffset()) { 488 // Verify location list. 489 if (auto DebugLoc = DCtx.getDebugLoc()) 490 if (auto LocList = DebugLoc->getLocationListAtOffset(*LocOffset)) 491 for (const auto &Entry : LocList->Entries) 492 VerifyLocationExpr({Entry.Loc.data(), Entry.Loc.size()}); 493 } 494 break; 495 } 496 case DW_AT_specification: 497 case DW_AT_abstract_origin: { 498 if (auto ReferencedDie = Die.getAttributeValueAsReferencedDie(Attr)) { 499 auto DieTag = Die.getTag(); 500 auto RefTag = ReferencedDie.getTag(); 501 if (DieTag == RefTag) 502 break; 503 if (DieTag == DW_TAG_inlined_subroutine && RefTag == DW_TAG_subprogram) 504 break; 505 if (DieTag == DW_TAG_variable && RefTag == DW_TAG_member) 506 break; 507 ReportError("DIE with tag " + TagString(DieTag) + " has " + 508 AttributeString(Attr) + 509 " that points to DIE with " 510 "incompatible tag " + 511 TagString(RefTag)); 512 } 513 break; 514 } 515 case DW_AT_type: { 516 DWARFDie TypeDie = Die.getAttributeValueAsReferencedDie(DW_AT_type); 517 if (TypeDie && !isType(TypeDie.getTag())) { 518 ReportError("DIE has " + AttributeString(Attr) + 519 " with incompatible tag " + TagString(TypeDie.getTag())); 520 } 521 break; 522 } 523 default: 524 break; 525 } 526 return NumErrors; 527 } 528 529 unsigned DWARFVerifier::verifyDebugInfoForm(const DWARFDie &Die, 530 DWARFAttribute &AttrValue) { 531 const DWARFObject &DObj = DCtx.getDWARFObj(); 532 unsigned NumErrors = 0; 533 const auto Form = AttrValue.Value.getForm(); 534 switch (Form) { 535 case DW_FORM_ref1: 536 case DW_FORM_ref2: 537 case DW_FORM_ref4: 538 case DW_FORM_ref8: 539 case DW_FORM_ref_udata: { 540 // Verify all CU relative references are valid CU offsets. 541 Optional<uint64_t> RefVal = AttrValue.Value.getAsReference(); 542 assert(RefVal); 543 if (RefVal) { 544 auto DieCU = Die.getDwarfUnit(); 545 auto CUSize = DieCU->getNextUnitOffset() - DieCU->getOffset(); 546 auto CUOffset = AttrValue.Value.getRawUValue(); 547 if (CUOffset >= CUSize) { 548 ++NumErrors; 549 error() << FormEncodingString(Form) << " CU offset " 550 << format("0x%08" PRIx64, CUOffset) 551 << " is invalid (must be less than CU size of " 552 << format("0x%08" PRIx32, CUSize) << "):\n"; 553 Die.dump(OS, 0, DumpOpts); 554 dump(Die) << '\n'; 555 } else { 556 // Valid reference, but we will verify it points to an actual 557 // DIE later. 558 ReferenceToDIEOffsets[*RefVal].insert(Die.getOffset()); 559 } 560 } 561 break; 562 } 563 case DW_FORM_ref_addr: { 564 // Verify all absolute DIE references have valid offsets in the 565 // .debug_info section. 566 Optional<uint64_t> RefVal = AttrValue.Value.getAsReference(); 567 assert(RefVal); 568 if (RefVal) { 569 if (*RefVal >= DObj.getInfoSection().Data.size()) { 570 ++NumErrors; 571 error() << "DW_FORM_ref_addr offset beyond .debug_info " 572 "bounds:\n"; 573 dump(Die) << '\n'; 574 } else { 575 // Valid reference, but we will verify it points to an actual 576 // DIE later. 577 ReferenceToDIEOffsets[*RefVal].insert(Die.getOffset()); 578 } 579 } 580 break; 581 } 582 case DW_FORM_strp: { 583 auto SecOffset = AttrValue.Value.getAsSectionOffset(); 584 assert(SecOffset); // DW_FORM_strp is a section offset. 585 if (SecOffset && *SecOffset >= DObj.getStringSection().size()) { 586 ++NumErrors; 587 error() << "DW_FORM_strp offset beyond .debug_str bounds:\n"; 588 dump(Die) << '\n'; 589 } 590 break; 591 } 592 default: 593 break; 594 } 595 return NumErrors; 596 } 597 598 unsigned DWARFVerifier::verifyDebugInfoReferences() { 599 // Take all references and make sure they point to an actual DIE by 600 // getting the DIE by offset and emitting an error 601 OS << "Verifying .debug_info references...\n"; 602 unsigned NumErrors = 0; 603 for (auto Pair : ReferenceToDIEOffsets) { 604 auto Die = DCtx.getDIEForOffset(Pair.first); 605 if (Die) 606 continue; 607 ++NumErrors; 608 error() << "invalid DIE reference " << format("0x%08" PRIx64, Pair.first) 609 << ". Offset is in between DIEs:\n"; 610 for (auto Offset : Pair.second) 611 dump(DCtx.getDIEForOffset(Offset)) << '\n'; 612 OS << "\n"; 613 } 614 return NumErrors; 615 } 616 617 void DWARFVerifier::verifyDebugLineStmtOffsets() { 618 std::map<uint64_t, DWARFDie> StmtListToDie; 619 for (const auto &CU : DCtx.compile_units()) { 620 auto Die = CU->getUnitDIE(); 621 // Get the attribute value as a section offset. No need to produce an 622 // error here if the encoding isn't correct because we validate this in 623 // the .debug_info verifier. 624 auto StmtSectionOffset = toSectionOffset(Die.find(DW_AT_stmt_list)); 625 if (!StmtSectionOffset) 626 continue; 627 const uint32_t LineTableOffset = *StmtSectionOffset; 628 auto LineTable = DCtx.getLineTableForUnit(CU.get()); 629 if (LineTableOffset < DCtx.getDWARFObj().getLineSection().Data.size()) { 630 if (!LineTable) { 631 ++NumDebugLineErrors; 632 error() << ".debug_line[" << format("0x%08" PRIx32, LineTableOffset) 633 << "] was not able to be parsed for CU:\n"; 634 dump(Die) << '\n'; 635 continue; 636 } 637 } else { 638 // Make sure we don't get a valid line table back if the offset is wrong. 639 assert(LineTable == nullptr); 640 // Skip this line table as it isn't valid. No need to create an error 641 // here because we validate this in the .debug_info verifier. 642 continue; 643 } 644 auto Iter = StmtListToDie.find(LineTableOffset); 645 if (Iter != StmtListToDie.end()) { 646 ++NumDebugLineErrors; 647 error() << "two compile unit DIEs, " 648 << format("0x%08" PRIx32, Iter->second.getOffset()) << " and " 649 << format("0x%08" PRIx32, Die.getOffset()) 650 << ", have the same DW_AT_stmt_list section offset:\n"; 651 dump(Iter->second); 652 dump(Die) << '\n'; 653 // Already verified this line table before, no need to do it again. 654 continue; 655 } 656 StmtListToDie[LineTableOffset] = Die; 657 } 658 } 659 660 void DWARFVerifier::verifyDebugLineRows() { 661 for (const auto &CU : DCtx.compile_units()) { 662 auto Die = CU->getUnitDIE(); 663 auto LineTable = DCtx.getLineTableForUnit(CU.get()); 664 // If there is no line table we will have created an error in the 665 // .debug_info verifier or in verifyDebugLineStmtOffsets(). 666 if (!LineTable) 667 continue; 668 669 // Verify prologue. 670 uint32_t MaxFileIndex = LineTable->Prologue.FileNames.size(); 671 uint32_t MaxDirIndex = LineTable->Prologue.IncludeDirectories.size(); 672 uint32_t FileIndex = 1; 673 StringMap<uint16_t> FullPathMap; 674 for (const auto &FileName : LineTable->Prologue.FileNames) { 675 // Verify directory index. 676 if (FileName.DirIdx > MaxDirIndex) { 677 ++NumDebugLineErrors; 678 error() << ".debug_line[" 679 << format("0x%08" PRIx64, 680 *toSectionOffset(Die.find(DW_AT_stmt_list))) 681 << "].prologue.file_names[" << FileIndex 682 << "].dir_idx contains an invalid index: " << FileName.DirIdx 683 << "\n"; 684 } 685 686 // Check file paths for duplicates. 687 std::string FullPath; 688 const bool HasFullPath = LineTable->getFileNameByIndex( 689 FileIndex, CU->getCompilationDir(), 690 DILineInfoSpecifier::FileLineInfoKind::AbsoluteFilePath, FullPath); 691 assert(HasFullPath && "Invalid index?"); 692 (void)HasFullPath; 693 auto It = FullPathMap.find(FullPath); 694 if (It == FullPathMap.end()) 695 FullPathMap[FullPath] = FileIndex; 696 else if (It->second != FileIndex) { 697 warn() << ".debug_line[" 698 << format("0x%08" PRIx64, 699 *toSectionOffset(Die.find(DW_AT_stmt_list))) 700 << "].prologue.file_names[" << FileIndex 701 << "] is a duplicate of file_names[" << It->second << "]\n"; 702 } 703 704 FileIndex++; 705 } 706 707 // Verify rows. 708 uint64_t PrevAddress = 0; 709 uint32_t RowIndex = 0; 710 for (const auto &Row : LineTable->Rows) { 711 // Verify row address. 712 if (Row.Address < PrevAddress) { 713 ++NumDebugLineErrors; 714 error() << ".debug_line[" 715 << format("0x%08" PRIx64, 716 *toSectionOffset(Die.find(DW_AT_stmt_list))) 717 << "] row[" << RowIndex 718 << "] decreases in address from previous row:\n"; 719 720 DWARFDebugLine::Row::dumpTableHeader(OS); 721 if (RowIndex > 0) 722 LineTable->Rows[RowIndex - 1].dump(OS); 723 Row.dump(OS); 724 OS << '\n'; 725 } 726 727 // Verify file index. 728 if (Row.File > MaxFileIndex) { 729 ++NumDebugLineErrors; 730 error() << ".debug_line[" 731 << format("0x%08" PRIx64, 732 *toSectionOffset(Die.find(DW_AT_stmt_list))) 733 << "][" << RowIndex << "] has invalid file index " << Row.File 734 << " (valid values are [1," << MaxFileIndex << "]):\n"; 735 DWARFDebugLine::Row::dumpTableHeader(OS); 736 Row.dump(OS); 737 OS << '\n'; 738 } 739 if (Row.EndSequence) 740 PrevAddress = 0; 741 else 742 PrevAddress = Row.Address; 743 ++RowIndex; 744 } 745 } 746 } 747 748 bool DWARFVerifier::handleDebugLine() { 749 NumDebugLineErrors = 0; 750 OS << "Verifying .debug_line...\n"; 751 verifyDebugLineStmtOffsets(); 752 verifyDebugLineRows(); 753 return NumDebugLineErrors == 0; 754 } 755 756 unsigned DWARFVerifier::verifyAppleAccelTable(const DWARFSection *AccelSection, 757 DataExtractor *StrData, 758 const char *SectionName) { 759 unsigned NumErrors = 0; 760 DWARFDataExtractor AccelSectionData(DCtx.getDWARFObj(), *AccelSection, 761 DCtx.isLittleEndian(), 0); 762 AppleAcceleratorTable AccelTable(AccelSectionData, *StrData); 763 764 OS << "Verifying " << SectionName << "...\n"; 765 766 // Verify that the fixed part of the header is not too short. 767 if (!AccelSectionData.isValidOffset(AccelTable.getSizeHdr())) { 768 error() << "Section is too small to fit a section header.\n"; 769 return 1; 770 } 771 772 // Verify that the section is not too short. 773 if (Error E = AccelTable.extract()) { 774 error() << toString(std::move(E)) << '\n'; 775 return 1; 776 } 777 778 // Verify that all buckets have a valid hash index or are empty. 779 uint32_t NumBuckets = AccelTable.getNumBuckets(); 780 uint32_t NumHashes = AccelTable.getNumHashes(); 781 782 uint32_t BucketsOffset = 783 AccelTable.getSizeHdr() + AccelTable.getHeaderDataLength(); 784 uint32_t HashesBase = BucketsOffset + NumBuckets * 4; 785 uint32_t OffsetsBase = HashesBase + NumHashes * 4; 786 for (uint32_t BucketIdx = 0; BucketIdx < NumBuckets; ++BucketIdx) { 787 uint32_t HashIdx = AccelSectionData.getU32(&BucketsOffset); 788 if (HashIdx >= NumHashes && HashIdx != UINT32_MAX) { 789 error() << format("Bucket[%d] has invalid hash index: %u.\n", BucketIdx, 790 HashIdx); 791 ++NumErrors; 792 } 793 } 794 uint32_t NumAtoms = AccelTable.getAtomsDesc().size(); 795 if (NumAtoms == 0) { 796 error() << "No atoms: failed to read HashData.\n"; 797 return 1; 798 } 799 if (!AccelTable.validateForms()) { 800 error() << "Unsupported form: failed to read HashData.\n"; 801 return 1; 802 } 803 804 for (uint32_t HashIdx = 0; HashIdx < NumHashes; ++HashIdx) { 805 uint32_t HashOffset = HashesBase + 4 * HashIdx; 806 uint32_t DataOffset = OffsetsBase + 4 * HashIdx; 807 uint32_t Hash = AccelSectionData.getU32(&HashOffset); 808 uint32_t HashDataOffset = AccelSectionData.getU32(&DataOffset); 809 if (!AccelSectionData.isValidOffsetForDataOfSize(HashDataOffset, 810 sizeof(uint64_t))) { 811 error() << format("Hash[%d] has invalid HashData offset: 0x%08x.\n", 812 HashIdx, HashDataOffset); 813 ++NumErrors; 814 } 815 816 uint32_t StrpOffset; 817 uint32_t StringOffset; 818 uint32_t StringCount = 0; 819 unsigned Offset; 820 unsigned Tag; 821 while ((StrpOffset = AccelSectionData.getU32(&HashDataOffset)) != 0) { 822 const uint32_t NumHashDataObjects = 823 AccelSectionData.getU32(&HashDataOffset); 824 for (uint32_t HashDataIdx = 0; HashDataIdx < NumHashDataObjects; 825 ++HashDataIdx) { 826 std::tie(Offset, Tag) = AccelTable.readAtoms(HashDataOffset); 827 auto Die = DCtx.getDIEForOffset(Offset); 828 if (!Die) { 829 const uint32_t BucketIdx = 830 NumBuckets ? (Hash % NumBuckets) : UINT32_MAX; 831 StringOffset = StrpOffset; 832 const char *Name = StrData->getCStr(&StringOffset); 833 if (!Name) 834 Name = "<NULL>"; 835 836 error() << format( 837 "%s Bucket[%d] Hash[%d] = 0x%08x " 838 "Str[%u] = 0x%08x " 839 "DIE[%d] = 0x%08x is not a valid DIE offset for \"%s\".\n", 840 SectionName, BucketIdx, HashIdx, Hash, StringCount, StrpOffset, 841 HashDataIdx, Offset, Name); 842 843 ++NumErrors; 844 continue; 845 } 846 if ((Tag != dwarf::DW_TAG_null) && (Die.getTag() != Tag)) { 847 error() << "Tag " << dwarf::TagString(Tag) 848 << " in accelerator table does not match Tag " 849 << dwarf::TagString(Die.getTag()) << " of DIE[" << HashDataIdx 850 << "].\n"; 851 ++NumErrors; 852 } 853 } 854 ++StringCount; 855 } 856 } 857 return NumErrors; 858 } 859 860 unsigned 861 DWARFVerifier::verifyDebugNamesCULists(const DWARFDebugNames &AccelTable) { 862 // A map from CU offset to the (first) Name Index offset which claims to index 863 // this CU. 864 DenseMap<uint32_t, uint32_t> CUMap; 865 const uint32_t NotIndexed = std::numeric_limits<uint32_t>::max(); 866 867 CUMap.reserve(DCtx.getNumCompileUnits()); 868 for (const auto &CU : DCtx.compile_units()) 869 CUMap[CU->getOffset()] = NotIndexed; 870 871 unsigned NumErrors = 0; 872 for (const DWARFDebugNames::NameIndex &NI : AccelTable) { 873 if (NI.getCUCount() == 0) { 874 error() << formatv("Name Index @ {0:x} does not index any CU\n", 875 NI.getUnitOffset()); 876 ++NumErrors; 877 continue; 878 } 879 for (uint32_t CU = 0, End = NI.getCUCount(); CU < End; ++CU) { 880 uint32_t Offset = NI.getCUOffset(CU); 881 auto Iter = CUMap.find(Offset); 882 883 if (Iter == CUMap.end()) { 884 error() << formatv( 885 "Name Index @ {0:x} references a non-existing CU @ {1:x}\n", 886 NI.getUnitOffset(), Offset); 887 ++NumErrors; 888 continue; 889 } 890 891 if (Iter->second != NotIndexed) { 892 error() << formatv("Name Index @ {0:x} references a CU @ {1:x}, but " 893 "this CU is already indexed by Name Index @ {2:x}\n", 894 NI.getUnitOffset(), Offset, Iter->second); 895 continue; 896 } 897 Iter->second = NI.getUnitOffset(); 898 } 899 } 900 901 for (const auto &KV : CUMap) { 902 if (KV.second == NotIndexed) 903 warn() << formatv("CU @ {0:x} not covered by any Name Index\n", KV.first); 904 } 905 906 return NumErrors; 907 } 908 909 unsigned 910 DWARFVerifier::verifyNameIndexBuckets(const DWARFDebugNames::NameIndex &NI, 911 const DataExtractor &StrData) { 912 struct BucketInfo { 913 uint32_t Bucket; 914 uint32_t Index; 915 916 constexpr BucketInfo(uint32_t Bucket, uint32_t Index) 917 : Bucket(Bucket), Index(Index) {} 918 bool operator<(const BucketInfo &RHS) const { return Index < RHS.Index; }; 919 }; 920 921 uint32_t NumErrors = 0; 922 if (NI.getBucketCount() == 0) { 923 warn() << formatv("Name Index @ {0:x} does not contain a hash table.\n", 924 NI.getUnitOffset()); 925 return NumErrors; 926 } 927 928 // Build up a list of (Bucket, Index) pairs. We use this later to verify that 929 // each Name is reachable from the appropriate bucket. 930 std::vector<BucketInfo> BucketStarts; 931 BucketStarts.reserve(NI.getBucketCount() + 1); 932 for (uint32_t Bucket = 0, End = NI.getBucketCount(); Bucket < End; ++Bucket) { 933 uint32_t Index = NI.getBucketArrayEntry(Bucket); 934 if (Index > NI.getNameCount()) { 935 error() << formatv("Bucket {0} of Name Index @ {1:x} contains invalid " 936 "value {2}. Valid range is [0, {3}].\n", 937 Bucket, NI.getUnitOffset(), Index, NI.getNameCount()); 938 ++NumErrors; 939 continue; 940 } 941 if (Index > 0) 942 BucketStarts.emplace_back(Bucket, Index); 943 } 944 945 // If there were any buckets with invalid values, skip further checks as they 946 // will likely produce many errors which will only confuse the actual root 947 // problem. 948 if (NumErrors > 0) 949 return NumErrors; 950 951 // Sort the list in the order of increasing "Index" entries. 952 array_pod_sort(BucketStarts.begin(), BucketStarts.end()); 953 954 // Insert a sentinel entry at the end, so we can check that the end of the 955 // table is covered in the loop below. 956 BucketStarts.emplace_back(NI.getBucketCount(), NI.getNameCount() + 1); 957 958 // Loop invariant: NextUncovered is the (1-based) index of the first Name 959 // which is not reachable by any of the buckets we processed so far (and 960 // hasn't been reported as uncovered). 961 uint32_t NextUncovered = 1; 962 for (const BucketInfo &B : BucketStarts) { 963 // Under normal circumstances B.Index be equal to NextUncovered, but it can 964 // be less if a bucket points to names which are already known to be in some 965 // bucket we processed earlier. In that case, we won't trigger this error, 966 // but report the mismatched hash value error instead. (We know the hash 967 // will not match because we have already verified that the name's hash 968 // puts it into the previous bucket.) 969 if (B.Index > NextUncovered) { 970 error() << formatv("Name Index @ {0:x}: Name table entries [{1}, {2}] " 971 "are not covered by the hash table.\n", 972 NI.getUnitOffset(), NextUncovered, B.Index - 1); 973 ++NumErrors; 974 } 975 uint32_t Idx = B.Index; 976 977 // The rest of the checks apply only to non-sentinel entries. 978 if (B.Bucket == NI.getBucketCount()) 979 break; 980 981 // This triggers if a non-empty bucket points to a name with a mismatched 982 // hash. Clients are likely to interpret this as an empty bucket, because a 983 // mismatched hash signals the end of a bucket, but if this is indeed an 984 // empty bucket, the producer should have signalled this by marking the 985 // bucket as empty. 986 uint32_t FirstHash = NI.getHashArrayEntry(Idx); 987 if (FirstHash % NI.getBucketCount() != B.Bucket) { 988 error() << formatv( 989 "Name Index @ {0:x}: Bucket {1} is not empty but points to a " 990 "mismatched hash value {2:x} (belonging to bucket {3}).\n", 991 NI.getUnitOffset(), B.Bucket, FirstHash, 992 FirstHash % NI.getBucketCount()); 993 ++NumErrors; 994 } 995 996 // This find the end of this bucket and also verifies that all the hashes in 997 // this bucket are correct by comparing the stored hashes to the ones we 998 // compute ourselves. 999 while (Idx <= NI.getNameCount()) { 1000 uint32_t Hash = NI.getHashArrayEntry(Idx); 1001 if (Hash % NI.getBucketCount() != B.Bucket) 1002 break; 1003 1004 const char *Str = NI.getNameTableEntry(Idx).getString(); 1005 if (caseFoldingDjbHash(Str) != Hash) { 1006 error() << formatv("Name Index @ {0:x}: String ({1}) at index {2} " 1007 "hashes to {3:x}, but " 1008 "the Name Index hash is {4:x}\n", 1009 NI.getUnitOffset(), Str, Idx, 1010 caseFoldingDjbHash(Str), Hash); 1011 ++NumErrors; 1012 } 1013 1014 ++Idx; 1015 } 1016 NextUncovered = std::max(NextUncovered, Idx); 1017 } 1018 return NumErrors; 1019 } 1020 1021 unsigned DWARFVerifier::verifyNameIndexAttribute( 1022 const DWARFDebugNames::NameIndex &NI, const DWARFDebugNames::Abbrev &Abbr, 1023 DWARFDebugNames::AttributeEncoding AttrEnc) { 1024 StringRef FormName = dwarf::FormEncodingString(AttrEnc.Form); 1025 if (FormName.empty()) { 1026 error() << formatv("NameIndex @ {0:x}: Abbreviation {1:x}: {2} uses an " 1027 "unknown form: {3}.\n", 1028 NI.getUnitOffset(), Abbr.Code, AttrEnc.Index, 1029 AttrEnc.Form); 1030 return 1; 1031 } 1032 1033 if (AttrEnc.Index == DW_IDX_type_hash) { 1034 if (AttrEnc.Form != dwarf::DW_FORM_data8) { 1035 error() << formatv( 1036 "NameIndex @ {0:x}: Abbreviation {1:x}: DW_IDX_type_hash " 1037 "uses an unexpected form {2} (should be {3}).\n", 1038 NI.getUnitOffset(), Abbr.Code, AttrEnc.Form, dwarf::DW_FORM_data8); 1039 return 1; 1040 } 1041 } 1042 1043 // A list of known index attributes and their expected form classes. 1044 // DW_IDX_type_hash is handled specially in the check above, as it has a 1045 // specific form (not just a form class) we should expect. 1046 struct FormClassTable { 1047 dwarf::Index Index; 1048 DWARFFormValue::FormClass Class; 1049 StringLiteral ClassName; 1050 }; 1051 static constexpr FormClassTable Table[] = { 1052 {dwarf::DW_IDX_compile_unit, DWARFFormValue::FC_Constant, {"constant"}}, 1053 {dwarf::DW_IDX_type_unit, DWARFFormValue::FC_Constant, {"constant"}}, 1054 {dwarf::DW_IDX_die_offset, DWARFFormValue::FC_Reference, {"reference"}}, 1055 {dwarf::DW_IDX_parent, DWARFFormValue::FC_Constant, {"constant"}}, 1056 }; 1057 1058 ArrayRef<FormClassTable> TableRef(Table); 1059 auto Iter = find_if(TableRef, [AttrEnc](const FormClassTable &T) { 1060 return T.Index == AttrEnc.Index; 1061 }); 1062 if (Iter == TableRef.end()) { 1063 warn() << formatv("NameIndex @ {0:x}: Abbreviation {1:x} contains an " 1064 "unknown index attribute: {2}.\n", 1065 NI.getUnitOffset(), Abbr.Code, AttrEnc.Index); 1066 return 0; 1067 } 1068 1069 if (!DWARFFormValue(AttrEnc.Form).isFormClass(Iter->Class)) { 1070 error() << formatv("NameIndex @ {0:x}: Abbreviation {1:x}: {2} uses an " 1071 "unexpected form {3} (expected form class {4}).\n", 1072 NI.getUnitOffset(), Abbr.Code, AttrEnc.Index, 1073 AttrEnc.Form, Iter->ClassName); 1074 return 1; 1075 } 1076 return 0; 1077 } 1078 1079 unsigned 1080 DWARFVerifier::verifyNameIndexAbbrevs(const DWARFDebugNames::NameIndex &NI) { 1081 if (NI.getLocalTUCount() + NI.getForeignTUCount() > 0) { 1082 warn() << formatv("Name Index @ {0:x}: Verifying indexes of type units is " 1083 "not currently supported.\n", 1084 NI.getUnitOffset()); 1085 return 0; 1086 } 1087 1088 unsigned NumErrors = 0; 1089 for (const auto &Abbrev : NI.getAbbrevs()) { 1090 StringRef TagName = dwarf::TagString(Abbrev.Tag); 1091 if (TagName.empty()) { 1092 warn() << formatv("NameIndex @ {0:x}: Abbreviation {1:x} references an " 1093 "unknown tag: {2}.\n", 1094 NI.getUnitOffset(), Abbrev.Code, Abbrev.Tag); 1095 } 1096 SmallSet<unsigned, 5> Attributes; 1097 for (const auto &AttrEnc : Abbrev.Attributes) { 1098 if (!Attributes.insert(AttrEnc.Index).second) { 1099 error() << formatv("NameIndex @ {0:x}: Abbreviation {1:x} contains " 1100 "multiple {2} attributes.\n", 1101 NI.getUnitOffset(), Abbrev.Code, AttrEnc.Index); 1102 ++NumErrors; 1103 continue; 1104 } 1105 NumErrors += verifyNameIndexAttribute(NI, Abbrev, AttrEnc); 1106 } 1107 1108 if (NI.getCUCount() > 1 && !Attributes.count(dwarf::DW_IDX_compile_unit)) { 1109 error() << formatv("NameIndex @ {0:x}: Indexing multiple compile units " 1110 "and abbreviation {1:x} has no {2} attribute.\n", 1111 NI.getUnitOffset(), Abbrev.Code, 1112 dwarf::DW_IDX_compile_unit); 1113 ++NumErrors; 1114 } 1115 if (!Attributes.count(dwarf::DW_IDX_die_offset)) { 1116 error() << formatv( 1117 "NameIndex @ {0:x}: Abbreviation {1:x} has no {2} attribute.\n", 1118 NI.getUnitOffset(), Abbrev.Code, dwarf::DW_IDX_die_offset); 1119 ++NumErrors; 1120 } 1121 } 1122 return NumErrors; 1123 } 1124 1125 static SmallVector<StringRef, 2> getNames(const DWARFDie &DIE, 1126 bool IncludeLinkageName = true) { 1127 SmallVector<StringRef, 2> Result; 1128 if (const char *Str = DIE.getName(DINameKind::ShortName)) 1129 Result.emplace_back(Str); 1130 else if (DIE.getTag() == dwarf::DW_TAG_namespace) 1131 Result.emplace_back("(anonymous namespace)"); 1132 1133 if (IncludeLinkageName) { 1134 if (const char *Str = DIE.getName(DINameKind::LinkageName)) { 1135 if (Result.empty() || Result[0] != Str) 1136 Result.emplace_back(Str); 1137 } 1138 } 1139 1140 return Result; 1141 } 1142 1143 unsigned DWARFVerifier::verifyNameIndexEntries( 1144 const DWARFDebugNames::NameIndex &NI, 1145 const DWARFDebugNames::NameTableEntry &NTE) { 1146 // Verifying type unit indexes not supported. 1147 if (NI.getLocalTUCount() + NI.getForeignTUCount() > 0) 1148 return 0; 1149 1150 const char *CStr = NTE.getString(); 1151 if (!CStr) { 1152 error() << formatv( 1153 "Name Index @ {0:x}: Unable to get string associated with name {1}.\n", 1154 NI.getUnitOffset(), NTE.getIndex()); 1155 return 1; 1156 } 1157 StringRef Str(CStr); 1158 1159 unsigned NumErrors = 0; 1160 unsigned NumEntries = 0; 1161 uint32_t EntryID = NTE.getEntryOffset(); 1162 uint32_t NextEntryID = EntryID; 1163 Expected<DWARFDebugNames::Entry> EntryOr = NI.getEntry(&NextEntryID); 1164 for (; EntryOr; ++NumEntries, EntryID = NextEntryID, 1165 EntryOr = NI.getEntry(&NextEntryID)) { 1166 uint32_t CUIndex = *EntryOr->getCUIndex(); 1167 if (CUIndex > NI.getCUCount()) { 1168 error() << formatv("Name Index @ {0:x}: Entry @ {1:x} contains an " 1169 "invalid CU index ({2}).\n", 1170 NI.getUnitOffset(), EntryID, CUIndex); 1171 ++NumErrors; 1172 continue; 1173 } 1174 uint32_t CUOffset = NI.getCUOffset(CUIndex); 1175 uint64_t DIEOffset = CUOffset + *EntryOr->getDIEUnitOffset(); 1176 DWARFDie DIE = DCtx.getDIEForOffset(DIEOffset); 1177 if (!DIE) { 1178 error() << formatv("Name Index @ {0:x}: Entry @ {1:x} references a " 1179 "non-existing DIE @ {2:x}.\n", 1180 NI.getUnitOffset(), EntryID, DIEOffset); 1181 ++NumErrors; 1182 continue; 1183 } 1184 if (DIE.getDwarfUnit()->getOffset() != CUOffset) { 1185 error() << formatv("Name Index @ {0:x}: Entry @ {1:x}: mismatched CU of " 1186 "DIE @ {2:x}: index - {3:x}; debug_info - {4:x}.\n", 1187 NI.getUnitOffset(), EntryID, DIEOffset, CUOffset, 1188 DIE.getDwarfUnit()->getOffset()); 1189 ++NumErrors; 1190 } 1191 if (DIE.getTag() != EntryOr->tag()) { 1192 error() << formatv("Name Index @ {0:x}: Entry @ {1:x}: mismatched Tag of " 1193 "DIE @ {2:x}: index - {3}; debug_info - {4}.\n", 1194 NI.getUnitOffset(), EntryID, DIEOffset, EntryOr->tag(), 1195 DIE.getTag()); 1196 ++NumErrors; 1197 } 1198 1199 auto EntryNames = getNames(DIE); 1200 if (!is_contained(EntryNames, Str)) { 1201 error() << formatv("Name Index @ {0:x}: Entry @ {1:x}: mismatched Name " 1202 "of DIE @ {2:x}: index - {3}; debug_info - {4}.\n", 1203 NI.getUnitOffset(), EntryID, DIEOffset, Str, 1204 make_range(EntryNames.begin(), EntryNames.end())); 1205 ++NumErrors; 1206 } 1207 } 1208 handleAllErrors(EntryOr.takeError(), 1209 [&](const DWARFDebugNames::SentinelError &) { 1210 if (NumEntries > 0) 1211 return; 1212 error() << formatv("Name Index @ {0:x}: Name {1} ({2}) is " 1213 "not associated with any entries.\n", 1214 NI.getUnitOffset(), NTE.getIndex(), Str); 1215 ++NumErrors; 1216 }, 1217 [&](const ErrorInfoBase &Info) { 1218 error() 1219 << formatv("Name Index @ {0:x}: Name {1} ({2}): {3}\n", 1220 NI.getUnitOffset(), NTE.getIndex(), Str, 1221 Info.message()); 1222 ++NumErrors; 1223 }); 1224 return NumErrors; 1225 } 1226 1227 static bool isVariableIndexable(const DWARFDie &Die, DWARFContext &DCtx) { 1228 Optional<DWARFFormValue> Location = Die.findRecursively(DW_AT_location); 1229 if (!Location) 1230 return false; 1231 1232 auto ContainsInterestingOperators = [&](StringRef D) { 1233 DWARFUnit *U = Die.getDwarfUnit(); 1234 DataExtractor Data(D, DCtx.isLittleEndian(), U->getAddressByteSize()); 1235 DWARFExpression Expression(Data, U->getVersion(), U->getAddressByteSize()); 1236 return any_of(Expression, [](DWARFExpression::Operation &Op) { 1237 return !Op.isError() && (Op.getCode() == DW_OP_addr || 1238 Op.getCode() == DW_OP_form_tls_address || 1239 Op.getCode() == DW_OP_GNU_push_tls_address); 1240 }); 1241 }; 1242 1243 if (Optional<ArrayRef<uint8_t>> Expr = Location->getAsBlock()) { 1244 // Inlined location. 1245 if (ContainsInterestingOperators(toStringRef(*Expr))) 1246 return true; 1247 } else if (Optional<uint64_t> Offset = Location->getAsSectionOffset()) { 1248 // Location list. 1249 if (const DWARFDebugLoc *DebugLoc = DCtx.getDebugLoc()) { 1250 if (const DWARFDebugLoc::LocationList *LocList = 1251 DebugLoc->getLocationListAtOffset(*Offset)) { 1252 if (any_of(LocList->Entries, [&](const DWARFDebugLoc::Entry &E) { 1253 return ContainsInterestingOperators({E.Loc.data(), E.Loc.size()}); 1254 })) 1255 return true; 1256 } 1257 } 1258 } 1259 return false; 1260 } 1261 1262 unsigned DWARFVerifier::verifyNameIndexCompleteness( 1263 const DWARFDie &Die, const DWARFDebugNames::NameIndex &NI) { 1264 1265 // First check, if the Die should be indexed. The code follows the DWARF v5 1266 // wording as closely as possible. 1267 1268 // "All non-defining declarations (that is, debugging information entries 1269 // with a DW_AT_declaration attribute) are excluded." 1270 if (Die.find(DW_AT_declaration)) 1271 return 0; 1272 1273 // "DW_TAG_namespace debugging information entries without a DW_AT_name 1274 // attribute are included with the name “(anonymous namespace)”. 1275 // All other debugging information entries without a DW_AT_name attribute 1276 // are excluded." 1277 // "If a subprogram or inlined subroutine is included, and has a 1278 // DW_AT_linkage_name attribute, there will be an additional index entry for 1279 // the linkage name." 1280 auto IncludeLinkageName = Die.getTag() == DW_TAG_subprogram || 1281 Die.getTag() == DW_TAG_inlined_subroutine; 1282 auto EntryNames = getNames(Die, IncludeLinkageName); 1283 if (EntryNames.empty()) 1284 return 0; 1285 1286 // We deviate from the specification here, which says: 1287 // "The name index must contain an entry for each debugging information entry 1288 // that defines a named subprogram, label, variable, type, or namespace, 1289 // subject to ..." 1290 // Instead whitelisting all TAGs representing a "type" or a "subprogram", to 1291 // make sure we catch any missing items, we instead blacklist all TAGs that we 1292 // know shouldn't be indexed. 1293 switch (Die.getTag()) { 1294 // Compile units and modules have names but shouldn't be indexed. 1295 case DW_TAG_compile_unit: 1296 case DW_TAG_module: 1297 return 0; 1298 1299 // Function and template parameters are not globally visible, so we shouldn't 1300 // index them. 1301 case DW_TAG_formal_parameter: 1302 case DW_TAG_template_value_parameter: 1303 case DW_TAG_template_type_parameter: 1304 case DW_TAG_GNU_template_parameter_pack: 1305 case DW_TAG_GNU_template_template_param: 1306 return 0; 1307 1308 // Object members aren't globally visible. 1309 case DW_TAG_member: 1310 return 0; 1311 1312 // According to a strict reading of the specification, enumerators should not 1313 // be indexed (and LLVM currently does not do that). However, this causes 1314 // problems for the debuggers, so we may need to reconsider this. 1315 case DW_TAG_enumerator: 1316 return 0; 1317 1318 // Imported declarations should not be indexed according to the specification 1319 // and LLVM currently does not do that. 1320 case DW_TAG_imported_declaration: 1321 return 0; 1322 1323 // "DW_TAG_subprogram, DW_TAG_inlined_subroutine, and DW_TAG_label debugging 1324 // information entries without an address attribute (DW_AT_low_pc, 1325 // DW_AT_high_pc, DW_AT_ranges, or DW_AT_entry_pc) are excluded." 1326 case DW_TAG_subprogram: 1327 case DW_TAG_inlined_subroutine: 1328 case DW_TAG_label: 1329 if (Die.findRecursively( 1330 {DW_AT_low_pc, DW_AT_high_pc, DW_AT_ranges, DW_AT_entry_pc})) 1331 break; 1332 return 0; 1333 1334 // "DW_TAG_variable debugging information entries with a DW_AT_location 1335 // attribute that includes a DW_OP_addr or DW_OP_form_tls_address operator are 1336 // included; otherwise, they are excluded." 1337 // 1338 // LLVM extension: We also add DW_OP_GNU_push_tls_address to this list. 1339 case DW_TAG_variable: 1340 if (isVariableIndexable(Die, DCtx)) 1341 break; 1342 return 0; 1343 1344 default: 1345 break; 1346 } 1347 1348 // Now we know that our Die should be present in the Index. Let's check if 1349 // that's the case. 1350 unsigned NumErrors = 0; 1351 uint64_t DieUnitOffset = Die.getOffset() - Die.getDwarfUnit()->getOffset(); 1352 for (StringRef Name : EntryNames) { 1353 if (none_of(NI.equal_range(Name), [&](const DWARFDebugNames::Entry &E) { 1354 return E.getDIEUnitOffset() == DieUnitOffset; 1355 })) { 1356 error() << formatv("Name Index @ {0:x}: Entry for DIE @ {1:x} ({2}) with " 1357 "name {3} missing.\n", 1358 NI.getUnitOffset(), Die.getOffset(), Die.getTag(), 1359 Name); 1360 ++NumErrors; 1361 } 1362 } 1363 return NumErrors; 1364 } 1365 1366 unsigned DWARFVerifier::verifyDebugNames(const DWARFSection &AccelSection, 1367 const DataExtractor &StrData) { 1368 unsigned NumErrors = 0; 1369 DWARFDataExtractor AccelSectionData(DCtx.getDWARFObj(), AccelSection, 1370 DCtx.isLittleEndian(), 0); 1371 DWARFDebugNames AccelTable(AccelSectionData, StrData); 1372 1373 OS << "Verifying .debug_names...\n"; 1374 1375 // This verifies that we can read individual name indices and their 1376 // abbreviation tables. 1377 if (Error E = AccelTable.extract()) { 1378 error() << toString(std::move(E)) << '\n'; 1379 return 1; 1380 } 1381 1382 NumErrors += verifyDebugNamesCULists(AccelTable); 1383 for (const auto &NI : AccelTable) 1384 NumErrors += verifyNameIndexBuckets(NI, StrData); 1385 for (const auto &NI : AccelTable) 1386 NumErrors += verifyNameIndexAbbrevs(NI); 1387 1388 // Don't attempt Entry validation if any of the previous checks found errors 1389 if (NumErrors > 0) 1390 return NumErrors; 1391 for (const auto &NI : AccelTable) 1392 for (DWARFDebugNames::NameTableEntry NTE : NI) 1393 NumErrors += verifyNameIndexEntries(NI, NTE); 1394 1395 if (NumErrors > 0) 1396 return NumErrors; 1397 1398 for (const std::unique_ptr<DWARFUnit> &U : DCtx.compile_units()) { 1399 if (const DWARFDebugNames::NameIndex *NI = 1400 AccelTable.getCUNameIndex(U->getOffset())) { 1401 auto *CU = cast<DWARFCompileUnit>(U.get()); 1402 for (const DWARFDebugInfoEntry &Die : CU->dies()) 1403 NumErrors += verifyNameIndexCompleteness(DWARFDie(CU, &Die), *NI); 1404 } 1405 } 1406 return NumErrors; 1407 } 1408 1409 bool DWARFVerifier::handleAccelTables() { 1410 const DWARFObject &D = DCtx.getDWARFObj(); 1411 DataExtractor StrData(D.getStringSection(), DCtx.isLittleEndian(), 0); 1412 unsigned NumErrors = 0; 1413 if (!D.getAppleNamesSection().Data.empty()) 1414 NumErrors += verifyAppleAccelTable(&D.getAppleNamesSection(), &StrData, 1415 ".apple_names"); 1416 if (!D.getAppleTypesSection().Data.empty()) 1417 NumErrors += verifyAppleAccelTable(&D.getAppleTypesSection(), &StrData, 1418 ".apple_types"); 1419 if (!D.getAppleNamespacesSection().Data.empty()) 1420 NumErrors += verifyAppleAccelTable(&D.getAppleNamespacesSection(), &StrData, 1421 ".apple_namespaces"); 1422 if (!D.getAppleObjCSection().Data.empty()) 1423 NumErrors += verifyAppleAccelTable(&D.getAppleObjCSection(), &StrData, 1424 ".apple_objc"); 1425 1426 if (!D.getDebugNamesSection().Data.empty()) 1427 NumErrors += verifyDebugNames(D.getDebugNamesSection(), StrData); 1428 return NumErrors == 0; 1429 } 1430 1431 raw_ostream &DWARFVerifier::error() const { return WithColor::error(OS); } 1432 1433 raw_ostream &DWARFVerifier::warn() const { return WithColor::warning(OS); } 1434 1435 raw_ostream &DWARFVerifier::note() const { return WithColor::note(OS); } 1436 1437 raw_ostream &DWARFVerifier::dump(const DWARFDie &Die, unsigned indent) const { 1438 Die.dump(OS, indent, DumpOpts); 1439 return OS; 1440 } 1441