1 //===- MachineVerifier.cpp - Machine Code Verifier ------------------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // Pass to verify generated machine code. The following is checked: 11 // 12 // Operand counts: All explicit operands must be present. 13 // 14 // Register classes: All physical and virtual register operands must be 15 // compatible with the register class required by the instruction descriptor. 16 // 17 // Register live intervals: Registers must be defined only once, and must be 18 // defined before use. 19 // 20 // The machine code verifier is enabled from LLVMTargetMachine.cpp with the 21 // command-line option -verify-machineinstrs, or by defining the environment 22 // variable LLVM_VERIFY_MACHINEINSTRS to the name of a file that will receive 23 // the verifier errors. 24 //===----------------------------------------------------------------------===// 25 26 #include "llvm/ADT/BitVector.h" 27 #include "llvm/ADT/DenseMap.h" 28 #include "llvm/ADT/DenseSet.h" 29 #include "llvm/ADT/DepthFirstIterator.h" 30 #include "llvm/ADT/STLExtras.h" 31 #include "llvm/ADT/SetOperations.h" 32 #include "llvm/ADT/SmallPtrSet.h" 33 #include "llvm/ADT/SmallVector.h" 34 #include "llvm/ADT/StringRef.h" 35 #include "llvm/ADT/Twine.h" 36 #include "llvm/Analysis/EHPersonalities.h" 37 #include "llvm/CodeGen/GlobalISel/RegisterBank.h" 38 #include "llvm/CodeGen/LiveInterval.h" 39 #include "llvm/CodeGen/LiveIntervalAnalysis.h" 40 #include "llvm/CodeGen/LiveStackAnalysis.h" 41 #include "llvm/CodeGen/LiveVariables.h" 42 #include "llvm/CodeGen/MachineBasicBlock.h" 43 #include "llvm/CodeGen/MachineFrameInfo.h" 44 #include "llvm/CodeGen/MachineFunction.h" 45 #include "llvm/CodeGen/MachineFunctionPass.h" 46 #include "llvm/CodeGen/MachineInstr.h" 47 #include "llvm/CodeGen/MachineInstrBundle.h" 48 #include "llvm/CodeGen/MachineMemOperand.h" 49 #include "llvm/CodeGen/MachineOperand.h" 50 #include "llvm/CodeGen/MachineRegisterInfo.h" 51 #include "llvm/CodeGen/PseudoSourceValue.h" 52 #include "llvm/CodeGen/SlotIndexes.h" 53 #include "llvm/CodeGen/StackMaps.h" 54 #include "llvm/CodeGen/TargetInstrInfo.h" 55 #include "llvm/CodeGen/TargetOpcodes.h" 56 #include "llvm/CodeGen/TargetRegisterInfo.h" 57 #include "llvm/CodeGen/TargetSubtargetInfo.h" 58 #include "llvm/IR/BasicBlock.h" 59 #include "llvm/IR/Function.h" 60 #include "llvm/IR/InlineAsm.h" 61 #include "llvm/IR/Instructions.h" 62 #include "llvm/MC/LaneBitmask.h" 63 #include "llvm/MC/MCAsmInfo.h" 64 #include "llvm/MC/MCInstrDesc.h" 65 #include "llvm/MC/MCRegisterInfo.h" 66 #include "llvm/MC/MCTargetOptions.h" 67 #include "llvm/Pass.h" 68 #include "llvm/Support/Casting.h" 69 #include "llvm/Support/ErrorHandling.h" 70 #include "llvm/Support/LowLevelTypeImpl.h" 71 #include "llvm/Support/MathExtras.h" 72 #include "llvm/Support/raw_ostream.h" 73 #include "llvm/Target/TargetMachine.h" 74 #include <algorithm> 75 #include <cassert> 76 #include <cstddef> 77 #include <cstdint> 78 #include <iterator> 79 #include <string> 80 #include <utility> 81 82 using namespace llvm; 83 84 namespace { 85 86 struct MachineVerifier { 87 MachineVerifier(Pass *pass, const char *b) : PASS(pass), Banner(b) {} 88 89 unsigned verify(MachineFunction &MF); 90 91 Pass *const PASS; 92 const char *Banner; 93 const MachineFunction *MF; 94 const TargetMachine *TM; 95 const TargetInstrInfo *TII; 96 const TargetRegisterInfo *TRI; 97 const MachineRegisterInfo *MRI; 98 99 unsigned foundErrors; 100 101 // Avoid querying the MachineFunctionProperties for each operand. 102 bool isFunctionRegBankSelected; 103 bool isFunctionSelected; 104 105 using RegVector = SmallVector<unsigned, 16>; 106 using RegMaskVector = SmallVector<const uint32_t *, 4>; 107 using RegSet = DenseSet<unsigned>; 108 using RegMap = DenseMap<unsigned, const MachineInstr *>; 109 using BlockSet = SmallPtrSet<const MachineBasicBlock *, 8>; 110 111 const MachineInstr *FirstTerminator; 112 BlockSet FunctionBlocks; 113 114 BitVector regsReserved; 115 RegSet regsLive; 116 RegVector regsDefined, regsDead, regsKilled; 117 RegMaskVector regMasks; 118 119 SlotIndex lastIndex; 120 121 // Add Reg and any sub-registers to RV 122 void addRegWithSubRegs(RegVector &RV, unsigned Reg) { 123 RV.push_back(Reg); 124 if (TargetRegisterInfo::isPhysicalRegister(Reg)) 125 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs) 126 RV.push_back(*SubRegs); 127 } 128 129 struct BBInfo { 130 // Is this MBB reachable from the MF entry point? 131 bool reachable = false; 132 133 // Vregs that must be live in because they are used without being 134 // defined. Map value is the user. 135 RegMap vregsLiveIn; 136 137 // Regs killed in MBB. They may be defined again, and will then be in both 138 // regsKilled and regsLiveOut. 139 RegSet regsKilled; 140 141 // Regs defined in MBB and live out. Note that vregs passing through may 142 // be live out without being mentioned here. 143 RegSet regsLiveOut; 144 145 // Vregs that pass through MBB untouched. This set is disjoint from 146 // regsKilled and regsLiveOut. 147 RegSet vregsPassed; 148 149 // Vregs that must pass through MBB because they are needed by a successor 150 // block. This set is disjoint from regsLiveOut. 151 RegSet vregsRequired; 152 153 // Set versions of block's predecessor and successor lists. 154 BlockSet Preds, Succs; 155 156 BBInfo() = default; 157 158 // Add register to vregsPassed if it belongs there. Return true if 159 // anything changed. 160 bool addPassed(unsigned Reg) { 161 if (!TargetRegisterInfo::isVirtualRegister(Reg)) 162 return false; 163 if (regsKilled.count(Reg) || regsLiveOut.count(Reg)) 164 return false; 165 return vregsPassed.insert(Reg).second; 166 } 167 168 // Same for a full set. 169 bool addPassed(const RegSet &RS) { 170 bool changed = false; 171 for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I) 172 if (addPassed(*I)) 173 changed = true; 174 return changed; 175 } 176 177 // Add register to vregsRequired if it belongs there. Return true if 178 // anything changed. 179 bool addRequired(unsigned Reg) { 180 if (!TargetRegisterInfo::isVirtualRegister(Reg)) 181 return false; 182 if (regsLiveOut.count(Reg)) 183 return false; 184 return vregsRequired.insert(Reg).second; 185 } 186 187 // Same for a full set. 188 bool addRequired(const RegSet &RS) { 189 bool changed = false; 190 for (RegSet::const_iterator I = RS.begin(), E = RS.end(); I != E; ++I) 191 if (addRequired(*I)) 192 changed = true; 193 return changed; 194 } 195 196 // Same for a full map. 197 bool addRequired(const RegMap &RM) { 198 bool changed = false; 199 for (RegMap::const_iterator I = RM.begin(), E = RM.end(); I != E; ++I) 200 if (addRequired(I->first)) 201 changed = true; 202 return changed; 203 } 204 205 // Live-out registers are either in regsLiveOut or vregsPassed. 206 bool isLiveOut(unsigned Reg) const { 207 return regsLiveOut.count(Reg) || vregsPassed.count(Reg); 208 } 209 }; 210 211 // Extra register info per MBB. 212 DenseMap<const MachineBasicBlock*, BBInfo> MBBInfoMap; 213 214 bool isReserved(unsigned Reg) { 215 return Reg < regsReserved.size() && regsReserved.test(Reg); 216 } 217 218 bool isAllocatable(unsigned Reg) const { 219 return Reg < TRI->getNumRegs() && TRI->isInAllocatableClass(Reg) && 220 !regsReserved.test(Reg); 221 } 222 223 // Analysis information if available 224 LiveVariables *LiveVars; 225 LiveIntervals *LiveInts; 226 LiveStacks *LiveStks; 227 SlotIndexes *Indexes; 228 229 void visitMachineFunctionBefore(); 230 void visitMachineBasicBlockBefore(const MachineBasicBlock *MBB); 231 void visitMachineBundleBefore(const MachineInstr *MI); 232 void visitMachineInstrBefore(const MachineInstr *MI); 233 void visitMachineOperand(const MachineOperand *MO, unsigned MONum); 234 void visitMachineInstrAfter(const MachineInstr *MI); 235 void visitMachineBundleAfter(const MachineInstr *MI); 236 void visitMachineBasicBlockAfter(const MachineBasicBlock *MBB); 237 void visitMachineFunctionAfter(); 238 239 void report(const char *msg, const MachineFunction *MF); 240 void report(const char *msg, const MachineBasicBlock *MBB); 241 void report(const char *msg, const MachineInstr *MI); 242 void report(const char *msg, const MachineOperand *MO, unsigned MONum); 243 244 void report_context(const LiveInterval &LI) const; 245 void report_context(const LiveRange &LR, unsigned VRegUnit, 246 LaneBitmask LaneMask) const; 247 void report_context(const LiveRange::Segment &S) const; 248 void report_context(const VNInfo &VNI) const; 249 void report_context(SlotIndex Pos) const; 250 void report_context_liverange(const LiveRange &LR) const; 251 void report_context_lanemask(LaneBitmask LaneMask) const; 252 void report_context_vreg(unsigned VReg) const; 253 void report_context_vreg_regunit(unsigned VRegOrRegUnit) const; 254 255 void verifyInlineAsm(const MachineInstr *MI); 256 257 void checkLiveness(const MachineOperand *MO, unsigned MONum); 258 void checkLivenessAtUse(const MachineOperand *MO, unsigned MONum, 259 SlotIndex UseIdx, const LiveRange &LR, unsigned Reg, 260 LaneBitmask LaneMask = LaneBitmask::getNone()); 261 void checkLivenessAtDef(const MachineOperand *MO, unsigned MONum, 262 SlotIndex DefIdx, const LiveRange &LR, unsigned Reg, 263 LaneBitmask LaneMask = LaneBitmask::getNone()); 264 265 void markReachable(const MachineBasicBlock *MBB); 266 void calcRegsPassed(); 267 void checkPHIOps(const MachineBasicBlock &MBB); 268 269 void calcRegsRequired(); 270 void verifyLiveVariables(); 271 void verifyLiveIntervals(); 272 void verifyLiveInterval(const LiveInterval&); 273 void verifyLiveRangeValue(const LiveRange&, const VNInfo*, unsigned, 274 LaneBitmask); 275 void verifyLiveRangeSegment(const LiveRange&, 276 const LiveRange::const_iterator I, unsigned, 277 LaneBitmask); 278 void verifyLiveRange(const LiveRange&, unsigned, 279 LaneBitmask LaneMask = LaneBitmask::getNone()); 280 281 void verifyStackFrame(); 282 283 void verifySlotIndexes() const; 284 void verifyProperties(const MachineFunction &MF); 285 }; 286 287 struct MachineVerifierPass : public MachineFunctionPass { 288 static char ID; // Pass ID, replacement for typeid 289 290 const std::string Banner; 291 292 MachineVerifierPass(std::string banner = std::string()) 293 : MachineFunctionPass(ID), Banner(std::move(banner)) { 294 initializeMachineVerifierPassPass(*PassRegistry::getPassRegistry()); 295 } 296 297 void getAnalysisUsage(AnalysisUsage &AU) const override { 298 AU.setPreservesAll(); 299 MachineFunctionPass::getAnalysisUsage(AU); 300 } 301 302 bool runOnMachineFunction(MachineFunction &MF) override { 303 unsigned FoundErrors = MachineVerifier(this, Banner.c_str()).verify(MF); 304 if (FoundErrors) 305 report_fatal_error("Found "+Twine(FoundErrors)+" machine code errors."); 306 return false; 307 } 308 }; 309 310 } // end anonymous namespace 311 312 char MachineVerifierPass::ID = 0; 313 314 INITIALIZE_PASS(MachineVerifierPass, "machineverifier", 315 "Verify generated machine code", false, false) 316 317 FunctionPass *llvm::createMachineVerifierPass(const std::string &Banner) { 318 return new MachineVerifierPass(Banner); 319 } 320 321 bool MachineFunction::verify(Pass *p, const char *Banner, bool AbortOnErrors) 322 const { 323 MachineFunction &MF = const_cast<MachineFunction&>(*this); 324 unsigned FoundErrors = MachineVerifier(p, Banner).verify(MF); 325 if (AbortOnErrors && FoundErrors) 326 report_fatal_error("Found "+Twine(FoundErrors)+" machine code errors."); 327 return FoundErrors == 0; 328 } 329 330 void MachineVerifier::verifySlotIndexes() const { 331 if (Indexes == nullptr) 332 return; 333 334 // Ensure the IdxMBB list is sorted by slot indexes. 335 SlotIndex Last; 336 for (SlotIndexes::MBBIndexIterator I = Indexes->MBBIndexBegin(), 337 E = Indexes->MBBIndexEnd(); I != E; ++I) { 338 assert(!Last.isValid() || I->first > Last); 339 Last = I->first; 340 } 341 } 342 343 void MachineVerifier::verifyProperties(const MachineFunction &MF) { 344 // If a pass has introduced virtual registers without clearing the 345 // NoVRegs property (or set it without allocating the vregs) 346 // then report an error. 347 if (MF.getProperties().hasProperty( 348 MachineFunctionProperties::Property::NoVRegs) && 349 MRI->getNumVirtRegs()) 350 report("Function has NoVRegs property but there are VReg operands", &MF); 351 } 352 353 unsigned MachineVerifier::verify(MachineFunction &MF) { 354 foundErrors = 0; 355 356 this->MF = &MF; 357 TM = &MF.getTarget(); 358 TII = MF.getSubtarget().getInstrInfo(); 359 TRI = MF.getSubtarget().getRegisterInfo(); 360 MRI = &MF.getRegInfo(); 361 362 isFunctionRegBankSelected = MF.getProperties().hasProperty( 363 MachineFunctionProperties::Property::RegBankSelected); 364 isFunctionSelected = MF.getProperties().hasProperty( 365 MachineFunctionProperties::Property::Selected); 366 367 LiveVars = nullptr; 368 LiveInts = nullptr; 369 LiveStks = nullptr; 370 Indexes = nullptr; 371 if (PASS) { 372 LiveInts = PASS->getAnalysisIfAvailable<LiveIntervals>(); 373 // We don't want to verify LiveVariables if LiveIntervals is available. 374 if (!LiveInts) 375 LiveVars = PASS->getAnalysisIfAvailable<LiveVariables>(); 376 LiveStks = PASS->getAnalysisIfAvailable<LiveStacks>(); 377 Indexes = PASS->getAnalysisIfAvailable<SlotIndexes>(); 378 } 379 380 verifySlotIndexes(); 381 382 verifyProperties(MF); 383 384 visitMachineFunctionBefore(); 385 for (MachineFunction::const_iterator MFI = MF.begin(), MFE = MF.end(); 386 MFI!=MFE; ++MFI) { 387 visitMachineBasicBlockBefore(&*MFI); 388 // Keep track of the current bundle header. 389 const MachineInstr *CurBundle = nullptr; 390 // Do we expect the next instruction to be part of the same bundle? 391 bool InBundle = false; 392 393 for (MachineBasicBlock::const_instr_iterator MBBI = MFI->instr_begin(), 394 MBBE = MFI->instr_end(); MBBI != MBBE; ++MBBI) { 395 if (MBBI->getParent() != &*MFI) { 396 report("Bad instruction parent pointer", &*MFI); 397 errs() << "Instruction: " << *MBBI; 398 continue; 399 } 400 401 // Check for consistent bundle flags. 402 if (InBundle && !MBBI->isBundledWithPred()) 403 report("Missing BundledPred flag, " 404 "BundledSucc was set on predecessor", 405 &*MBBI); 406 if (!InBundle && MBBI->isBundledWithPred()) 407 report("BundledPred flag is set, " 408 "but BundledSucc not set on predecessor", 409 &*MBBI); 410 411 // Is this a bundle header? 412 if (!MBBI->isInsideBundle()) { 413 if (CurBundle) 414 visitMachineBundleAfter(CurBundle); 415 CurBundle = &*MBBI; 416 visitMachineBundleBefore(CurBundle); 417 } else if (!CurBundle) 418 report("No bundle header", &*MBBI); 419 visitMachineInstrBefore(&*MBBI); 420 for (unsigned I = 0, E = MBBI->getNumOperands(); I != E; ++I) { 421 const MachineInstr &MI = *MBBI; 422 const MachineOperand &Op = MI.getOperand(I); 423 if (Op.getParent() != &MI) { 424 // Make sure to use correct addOperand / RemoveOperand / ChangeTo 425 // functions when replacing operands of a MachineInstr. 426 report("Instruction has operand with wrong parent set", &MI); 427 } 428 429 visitMachineOperand(&Op, I); 430 } 431 432 visitMachineInstrAfter(&*MBBI); 433 434 // Was this the last bundled instruction? 435 InBundle = MBBI->isBundledWithSucc(); 436 } 437 if (CurBundle) 438 visitMachineBundleAfter(CurBundle); 439 if (InBundle) 440 report("BundledSucc flag set on last instruction in block", &MFI->back()); 441 visitMachineBasicBlockAfter(&*MFI); 442 } 443 visitMachineFunctionAfter(); 444 445 // Clean up. 446 regsLive.clear(); 447 regsDefined.clear(); 448 regsDead.clear(); 449 regsKilled.clear(); 450 regMasks.clear(); 451 MBBInfoMap.clear(); 452 453 return foundErrors; 454 } 455 456 void MachineVerifier::report(const char *msg, const MachineFunction *MF) { 457 assert(MF); 458 errs() << '\n'; 459 if (!foundErrors++) { 460 if (Banner) 461 errs() << "# " << Banner << '\n'; 462 if (LiveInts != nullptr) 463 LiveInts->print(errs()); 464 else 465 MF->print(errs(), Indexes); 466 } 467 errs() << "*** Bad machine code: " << msg << " ***\n" 468 << "- function: " << MF->getName() << "\n"; 469 } 470 471 void MachineVerifier::report(const char *msg, const MachineBasicBlock *MBB) { 472 assert(MBB); 473 report(msg, MBB->getParent()); 474 errs() << "- basic block: BB#" << MBB->getNumber() 475 << ' ' << MBB->getName() 476 << " (" << (const void*)MBB << ')'; 477 if (Indexes) 478 errs() << " [" << Indexes->getMBBStartIdx(MBB) 479 << ';' << Indexes->getMBBEndIdx(MBB) << ')'; 480 errs() << '\n'; 481 } 482 483 void MachineVerifier::report(const char *msg, const MachineInstr *MI) { 484 assert(MI); 485 report(msg, MI->getParent()); 486 errs() << "- instruction: "; 487 if (Indexes && Indexes->hasIndex(*MI)) 488 errs() << Indexes->getInstructionIndex(*MI) << '\t'; 489 MI->print(errs(), /*SkipOpers=*/true); 490 errs() << '\n'; 491 } 492 493 void MachineVerifier::report(const char *msg, 494 const MachineOperand *MO, unsigned MONum) { 495 assert(MO); 496 report(msg, MO->getParent()); 497 errs() << "- operand " << MONum << ": "; 498 MO->print(errs(), TRI); 499 errs() << "\n"; 500 } 501 502 void MachineVerifier::report_context(SlotIndex Pos) const { 503 errs() << "- at: " << Pos << '\n'; 504 } 505 506 void MachineVerifier::report_context(const LiveInterval &LI) const { 507 errs() << "- interval: " << LI << '\n'; 508 } 509 510 void MachineVerifier::report_context(const LiveRange &LR, unsigned VRegUnit, 511 LaneBitmask LaneMask) const { 512 report_context_liverange(LR); 513 report_context_vreg_regunit(VRegUnit); 514 if (LaneMask.any()) 515 report_context_lanemask(LaneMask); 516 } 517 518 void MachineVerifier::report_context(const LiveRange::Segment &S) const { 519 errs() << "- segment: " << S << '\n'; 520 } 521 522 void MachineVerifier::report_context(const VNInfo &VNI) const { 523 errs() << "- ValNo: " << VNI.id << " (def " << VNI.def << ")\n"; 524 } 525 526 void MachineVerifier::report_context_liverange(const LiveRange &LR) const { 527 errs() << "- liverange: " << LR << '\n'; 528 } 529 530 void MachineVerifier::report_context_vreg(unsigned VReg) const { 531 errs() << "- v. register: " << printReg(VReg, TRI) << '\n'; 532 } 533 534 void MachineVerifier::report_context_vreg_regunit(unsigned VRegOrUnit) const { 535 if (TargetRegisterInfo::isVirtualRegister(VRegOrUnit)) { 536 report_context_vreg(VRegOrUnit); 537 } else { 538 errs() << "- regunit: " << printRegUnit(VRegOrUnit, TRI) << '\n'; 539 } 540 } 541 542 void MachineVerifier::report_context_lanemask(LaneBitmask LaneMask) const { 543 errs() << "- lanemask: " << PrintLaneMask(LaneMask) << '\n'; 544 } 545 546 void MachineVerifier::markReachable(const MachineBasicBlock *MBB) { 547 BBInfo &MInfo = MBBInfoMap[MBB]; 548 if (!MInfo.reachable) { 549 MInfo.reachable = true; 550 for (MachineBasicBlock::const_succ_iterator SuI = MBB->succ_begin(), 551 SuE = MBB->succ_end(); SuI != SuE; ++SuI) 552 markReachable(*SuI); 553 } 554 } 555 556 void MachineVerifier::visitMachineFunctionBefore() { 557 lastIndex = SlotIndex(); 558 regsReserved = MRI->reservedRegsFrozen() ? MRI->getReservedRegs() 559 : TRI->getReservedRegs(*MF); 560 561 if (!MF->empty()) 562 markReachable(&MF->front()); 563 564 // Build a set of the basic blocks in the function. 565 FunctionBlocks.clear(); 566 for (const auto &MBB : *MF) { 567 FunctionBlocks.insert(&MBB); 568 BBInfo &MInfo = MBBInfoMap[&MBB]; 569 570 MInfo.Preds.insert(MBB.pred_begin(), MBB.pred_end()); 571 if (MInfo.Preds.size() != MBB.pred_size()) 572 report("MBB has duplicate entries in its predecessor list.", &MBB); 573 574 MInfo.Succs.insert(MBB.succ_begin(), MBB.succ_end()); 575 if (MInfo.Succs.size() != MBB.succ_size()) 576 report("MBB has duplicate entries in its successor list.", &MBB); 577 } 578 579 // Check that the register use lists are sane. 580 MRI->verifyUseLists(); 581 582 if (!MF->empty()) 583 verifyStackFrame(); 584 } 585 586 // Does iterator point to a and b as the first two elements? 587 static bool matchPair(MachineBasicBlock::const_succ_iterator i, 588 const MachineBasicBlock *a, const MachineBasicBlock *b) { 589 if (*i == a) 590 return *++i == b; 591 if (*i == b) 592 return *++i == a; 593 return false; 594 } 595 596 void 597 MachineVerifier::visitMachineBasicBlockBefore(const MachineBasicBlock *MBB) { 598 FirstTerminator = nullptr; 599 600 if (!MF->getProperties().hasProperty( 601 MachineFunctionProperties::Property::NoPHIs) && MRI->tracksLiveness()) { 602 // If this block has allocatable physical registers live-in, check that 603 // it is an entry block or landing pad. 604 for (const auto &LI : MBB->liveins()) { 605 if (isAllocatable(LI.PhysReg) && !MBB->isEHPad() && 606 MBB->getIterator() != MBB->getParent()->begin()) { 607 report("MBB has allocatable live-in, but isn't entry or landing-pad.", MBB); 608 } 609 } 610 } 611 612 // Count the number of landing pad successors. 613 SmallPtrSet<MachineBasicBlock*, 4> LandingPadSuccs; 614 for (MachineBasicBlock::const_succ_iterator I = MBB->succ_begin(), 615 E = MBB->succ_end(); I != E; ++I) { 616 if ((*I)->isEHPad()) 617 LandingPadSuccs.insert(*I); 618 if (!FunctionBlocks.count(*I)) 619 report("MBB has successor that isn't part of the function.", MBB); 620 if (!MBBInfoMap[*I].Preds.count(MBB)) { 621 report("Inconsistent CFG", MBB); 622 errs() << "MBB is not in the predecessor list of the successor BB#" 623 << (*I)->getNumber() << ".\n"; 624 } 625 } 626 627 // Check the predecessor list. 628 for (MachineBasicBlock::const_pred_iterator I = MBB->pred_begin(), 629 E = MBB->pred_end(); I != E; ++I) { 630 if (!FunctionBlocks.count(*I)) 631 report("MBB has predecessor that isn't part of the function.", MBB); 632 if (!MBBInfoMap[*I].Succs.count(MBB)) { 633 report("Inconsistent CFG", MBB); 634 errs() << "MBB is not in the successor list of the predecessor BB#" 635 << (*I)->getNumber() << ".\n"; 636 } 637 } 638 639 const MCAsmInfo *AsmInfo = TM->getMCAsmInfo(); 640 const BasicBlock *BB = MBB->getBasicBlock(); 641 const Function *Fn = MF->getFunction(); 642 if (LandingPadSuccs.size() > 1 && 643 !(AsmInfo && 644 AsmInfo->getExceptionHandlingType() == ExceptionHandling::SjLj && 645 BB && isa<SwitchInst>(BB->getTerminator())) && 646 !isFuncletEHPersonality(classifyEHPersonality(Fn->getPersonalityFn()))) 647 report("MBB has more than one landing pad successor", MBB); 648 649 // Call AnalyzeBranch. If it succeeds, there several more conditions to check. 650 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; 651 SmallVector<MachineOperand, 4> Cond; 652 if (!TII->analyzeBranch(*const_cast<MachineBasicBlock *>(MBB), TBB, FBB, 653 Cond)) { 654 // Ok, AnalyzeBranch thinks it knows what's going on with this block. Let's 655 // check whether its answers match up with reality. 656 if (!TBB && !FBB) { 657 // Block falls through to its successor. 658 MachineFunction::const_iterator MBBI = MBB->getIterator(); 659 ++MBBI; 660 if (MBBI == MF->end()) { 661 // It's possible that the block legitimately ends with a noreturn 662 // call or an unreachable, in which case it won't actually fall 663 // out the bottom of the function. 664 } else if (MBB->succ_size() == LandingPadSuccs.size()) { 665 // It's possible that the block legitimately ends with a noreturn 666 // call or an unreachable, in which case it won't actuall fall 667 // out of the block. 668 } else if (MBB->succ_size() != 1+LandingPadSuccs.size()) { 669 report("MBB exits via unconditional fall-through but doesn't have " 670 "exactly one CFG successor!", MBB); 671 } else if (!MBB->isSuccessor(&*MBBI)) { 672 report("MBB exits via unconditional fall-through but its successor " 673 "differs from its CFG successor!", MBB); 674 } 675 if (!MBB->empty() && MBB->back().isBarrier() && 676 !TII->isPredicated(MBB->back())) { 677 report("MBB exits via unconditional fall-through but ends with a " 678 "barrier instruction!", MBB); 679 } 680 if (!Cond.empty()) { 681 report("MBB exits via unconditional fall-through but has a condition!", 682 MBB); 683 } 684 } else if (TBB && !FBB && Cond.empty()) { 685 // Block unconditionally branches somewhere. 686 // If the block has exactly one successor, that happens to be a 687 // landingpad, accept it as valid control flow. 688 if (MBB->succ_size() != 1+LandingPadSuccs.size() && 689 (MBB->succ_size() != 1 || LandingPadSuccs.size() != 1 || 690 *MBB->succ_begin() != *LandingPadSuccs.begin())) { 691 report("MBB exits via unconditional branch but doesn't have " 692 "exactly one CFG successor!", MBB); 693 } else if (!MBB->isSuccessor(TBB)) { 694 report("MBB exits via unconditional branch but the CFG " 695 "successor doesn't match the actual successor!", MBB); 696 } 697 if (MBB->empty()) { 698 report("MBB exits via unconditional branch but doesn't contain " 699 "any instructions!", MBB); 700 } else if (!MBB->back().isBarrier()) { 701 report("MBB exits via unconditional branch but doesn't end with a " 702 "barrier instruction!", MBB); 703 } else if (!MBB->back().isTerminator()) { 704 report("MBB exits via unconditional branch but the branch isn't a " 705 "terminator instruction!", MBB); 706 } 707 } else if (TBB && !FBB && !Cond.empty()) { 708 // Block conditionally branches somewhere, otherwise falls through. 709 MachineFunction::const_iterator MBBI = MBB->getIterator(); 710 ++MBBI; 711 if (MBBI == MF->end()) { 712 report("MBB conditionally falls through out of function!", MBB); 713 } else if (MBB->succ_size() == 1) { 714 // A conditional branch with only one successor is weird, but allowed. 715 if (&*MBBI != TBB) 716 report("MBB exits via conditional branch/fall-through but only has " 717 "one CFG successor!", MBB); 718 else if (TBB != *MBB->succ_begin()) 719 report("MBB exits via conditional branch/fall-through but the CFG " 720 "successor don't match the actual successor!", MBB); 721 } else if (MBB->succ_size() != 2) { 722 report("MBB exits via conditional branch/fall-through but doesn't have " 723 "exactly two CFG successors!", MBB); 724 } else if (!matchPair(MBB->succ_begin(), TBB, &*MBBI)) { 725 report("MBB exits via conditional branch/fall-through but the CFG " 726 "successors don't match the actual successors!", MBB); 727 } 728 if (MBB->empty()) { 729 report("MBB exits via conditional branch/fall-through but doesn't " 730 "contain any instructions!", MBB); 731 } else if (MBB->back().isBarrier()) { 732 report("MBB exits via conditional branch/fall-through but ends with a " 733 "barrier instruction!", MBB); 734 } else if (!MBB->back().isTerminator()) { 735 report("MBB exits via conditional branch/fall-through but the branch " 736 "isn't a terminator instruction!", MBB); 737 } 738 } else if (TBB && FBB) { 739 // Block conditionally branches somewhere, otherwise branches 740 // somewhere else. 741 if (MBB->succ_size() == 1) { 742 // A conditional branch with only one successor is weird, but allowed. 743 if (FBB != TBB) 744 report("MBB exits via conditional branch/branch through but only has " 745 "one CFG successor!", MBB); 746 else if (TBB != *MBB->succ_begin()) 747 report("MBB exits via conditional branch/branch through but the CFG " 748 "successor don't match the actual successor!", MBB); 749 } else if (MBB->succ_size() != 2) { 750 report("MBB exits via conditional branch/branch but doesn't have " 751 "exactly two CFG successors!", MBB); 752 } else if (!matchPair(MBB->succ_begin(), TBB, FBB)) { 753 report("MBB exits via conditional branch/branch but the CFG " 754 "successors don't match the actual successors!", MBB); 755 } 756 if (MBB->empty()) { 757 report("MBB exits via conditional branch/branch but doesn't " 758 "contain any instructions!", MBB); 759 } else if (!MBB->back().isBarrier()) { 760 report("MBB exits via conditional branch/branch but doesn't end with a " 761 "barrier instruction!", MBB); 762 } else if (!MBB->back().isTerminator()) { 763 report("MBB exits via conditional branch/branch but the branch " 764 "isn't a terminator instruction!", MBB); 765 } 766 if (Cond.empty()) { 767 report("MBB exits via conditinal branch/branch but there's no " 768 "condition!", MBB); 769 } 770 } else { 771 report("AnalyzeBranch returned invalid data!", MBB); 772 } 773 } 774 775 regsLive.clear(); 776 if (MRI->tracksLiveness()) { 777 for (const auto &LI : MBB->liveins()) { 778 if (!TargetRegisterInfo::isPhysicalRegister(LI.PhysReg)) { 779 report("MBB live-in list contains non-physical register", MBB); 780 continue; 781 } 782 for (MCSubRegIterator SubRegs(LI.PhysReg, TRI, /*IncludeSelf=*/true); 783 SubRegs.isValid(); ++SubRegs) 784 regsLive.insert(*SubRegs); 785 } 786 } 787 788 const MachineFrameInfo &MFI = MF->getFrameInfo(); 789 BitVector PR = MFI.getPristineRegs(*MF); 790 for (unsigned I : PR.set_bits()) { 791 for (MCSubRegIterator SubRegs(I, TRI, /*IncludeSelf=*/true); 792 SubRegs.isValid(); ++SubRegs) 793 regsLive.insert(*SubRegs); 794 } 795 796 regsKilled.clear(); 797 regsDefined.clear(); 798 799 if (Indexes) 800 lastIndex = Indexes->getMBBStartIdx(MBB); 801 } 802 803 // This function gets called for all bundle headers, including normal 804 // stand-alone unbundled instructions. 805 void MachineVerifier::visitMachineBundleBefore(const MachineInstr *MI) { 806 if (Indexes && Indexes->hasIndex(*MI)) { 807 SlotIndex idx = Indexes->getInstructionIndex(*MI); 808 if (!(idx > lastIndex)) { 809 report("Instruction index out of order", MI); 810 errs() << "Last instruction was at " << lastIndex << '\n'; 811 } 812 lastIndex = idx; 813 } 814 815 // Ensure non-terminators don't follow terminators. 816 // Ignore predicated terminators formed by if conversion. 817 // FIXME: If conversion shouldn't need to violate this rule. 818 if (MI->isTerminator() && !TII->isPredicated(*MI)) { 819 if (!FirstTerminator) 820 FirstTerminator = MI; 821 } else if (FirstTerminator) { 822 report("Non-terminator instruction after the first terminator", MI); 823 errs() << "First terminator was:\t" << *FirstTerminator; 824 } 825 } 826 827 // The operands on an INLINEASM instruction must follow a template. 828 // Verify that the flag operands make sense. 829 void MachineVerifier::verifyInlineAsm(const MachineInstr *MI) { 830 // The first two operands on INLINEASM are the asm string and global flags. 831 if (MI->getNumOperands() < 2) { 832 report("Too few operands on inline asm", MI); 833 return; 834 } 835 if (!MI->getOperand(0).isSymbol()) 836 report("Asm string must be an external symbol", MI); 837 if (!MI->getOperand(1).isImm()) 838 report("Asm flags must be an immediate", MI); 839 // Allowed flags are Extra_HasSideEffects = 1, Extra_IsAlignStack = 2, 840 // Extra_AsmDialect = 4, Extra_MayLoad = 8, and Extra_MayStore = 16, 841 // and Extra_IsConvergent = 32. 842 if (!isUInt<6>(MI->getOperand(1).getImm())) 843 report("Unknown asm flags", &MI->getOperand(1), 1); 844 845 static_assert(InlineAsm::MIOp_FirstOperand == 2, "Asm format changed"); 846 847 unsigned OpNo = InlineAsm::MIOp_FirstOperand; 848 unsigned NumOps; 849 for (unsigned e = MI->getNumOperands(); OpNo < e; OpNo += NumOps) { 850 const MachineOperand &MO = MI->getOperand(OpNo); 851 // There may be implicit ops after the fixed operands. 852 if (!MO.isImm()) 853 break; 854 NumOps = 1 + InlineAsm::getNumOperandRegisters(MO.getImm()); 855 } 856 857 if (OpNo > MI->getNumOperands()) 858 report("Missing operands in last group", MI); 859 860 // An optional MDNode follows the groups. 861 if (OpNo < MI->getNumOperands() && MI->getOperand(OpNo).isMetadata()) 862 ++OpNo; 863 864 // All trailing operands must be implicit registers. 865 for (unsigned e = MI->getNumOperands(); OpNo < e; ++OpNo) { 866 const MachineOperand &MO = MI->getOperand(OpNo); 867 if (!MO.isReg() || !MO.isImplicit()) 868 report("Expected implicit register after groups", &MO, OpNo); 869 } 870 } 871 872 void MachineVerifier::visitMachineInstrBefore(const MachineInstr *MI) { 873 const MCInstrDesc &MCID = MI->getDesc(); 874 if (MI->getNumOperands() < MCID.getNumOperands()) { 875 report("Too few operands", MI); 876 errs() << MCID.getNumOperands() << " operands expected, but " 877 << MI->getNumOperands() << " given.\n"; 878 } 879 880 if (MI->isPHI() && MF->getProperties().hasProperty( 881 MachineFunctionProperties::Property::NoPHIs)) 882 report("Found PHI instruction with NoPHIs property set", MI); 883 884 // Check the tied operands. 885 if (MI->isInlineAsm()) 886 verifyInlineAsm(MI); 887 888 // Check the MachineMemOperands for basic consistency. 889 for (MachineInstr::mmo_iterator I = MI->memoperands_begin(), 890 E = MI->memoperands_end(); I != E; ++I) { 891 if ((*I)->isLoad() && !MI->mayLoad()) 892 report("Missing mayLoad flag", MI); 893 if ((*I)->isStore() && !MI->mayStore()) 894 report("Missing mayStore flag", MI); 895 } 896 897 // Debug values must not have a slot index. 898 // Other instructions must have one, unless they are inside a bundle. 899 if (LiveInts) { 900 bool mapped = !LiveInts->isNotInMIMap(*MI); 901 if (MI->isDebugValue()) { 902 if (mapped) 903 report("Debug instruction has a slot index", MI); 904 } else if (MI->isInsideBundle()) { 905 if (mapped) 906 report("Instruction inside bundle has a slot index", MI); 907 } else { 908 if (!mapped) 909 report("Missing slot index", MI); 910 } 911 } 912 913 // Check types. 914 if (isPreISelGenericOpcode(MCID.getOpcode())) { 915 if (isFunctionSelected) 916 report("Unexpected generic instruction in a Selected function", MI); 917 918 // Generic instructions specify equality constraints between some 919 // of their operands. Make sure these are consistent. 920 SmallVector<LLT, 4> Types; 921 for (unsigned i = 0; i < MCID.getNumOperands(); ++i) { 922 if (!MCID.OpInfo[i].isGenericType()) 923 continue; 924 size_t TypeIdx = MCID.OpInfo[i].getGenericTypeIndex(); 925 Types.resize(std::max(TypeIdx + 1, Types.size())); 926 927 LLT OpTy = MRI->getType(MI->getOperand(i).getReg()); 928 if (Types[TypeIdx].isValid() && Types[TypeIdx] != OpTy) 929 report("type mismatch in generic instruction", MI); 930 Types[TypeIdx] = OpTy; 931 } 932 } 933 934 // Generic opcodes must not have physical register operands. 935 if (isPreISelGenericOpcode(MCID.getOpcode())) { 936 for (auto &Op : MI->operands()) { 937 if (Op.isReg() && TargetRegisterInfo::isPhysicalRegister(Op.getReg())) 938 report("Generic instruction cannot have physical register", MI); 939 } 940 } 941 942 StringRef ErrorInfo; 943 if (!TII->verifyInstruction(*MI, ErrorInfo)) 944 report(ErrorInfo.data(), MI); 945 946 // Verify properties of various specific instruction types 947 switch(MI->getOpcode()) { 948 default: 949 break; 950 case TargetOpcode::G_LOAD: 951 case TargetOpcode::G_STORE: 952 // Generic loads and stores must have a single MachineMemOperand 953 // describing that access. 954 if (!MI->hasOneMemOperand()) 955 report("Generic instruction accessing memory must have one mem operand", 956 MI); 957 break; 958 case TargetOpcode::G_PHI: { 959 LLT DstTy = MRI->getType(MI->getOperand(0).getReg()); 960 if (!DstTy.isValid() || 961 !std::all_of(MI->operands_begin() + 1, MI->operands_end(), 962 [this, &DstTy](const MachineOperand &MO) { 963 if (!MO.isReg()) 964 return true; 965 LLT Ty = MRI->getType(MO.getReg()); 966 if (!Ty.isValid() || (Ty != DstTy)) 967 return false; 968 return true; 969 })) 970 report("Generic Instruction G_PHI has operands with incompatible/missing " 971 "types", 972 MI); 973 break; 974 } 975 case TargetOpcode::STATEPOINT: 976 if (!MI->getOperand(StatepointOpers::IDPos).isImm() || 977 !MI->getOperand(StatepointOpers::NBytesPos).isImm() || 978 !MI->getOperand(StatepointOpers::NCallArgsPos).isImm()) 979 report("meta operands to STATEPOINT not constant!", MI); 980 break; 981 982 auto VerifyStackMapConstant = [&](unsigned Offset) { 983 if (!MI->getOperand(Offset).isImm() || 984 MI->getOperand(Offset).getImm() != StackMaps::ConstantOp || 985 !MI->getOperand(Offset + 1).isImm()) 986 report("stack map constant to STATEPOINT not well formed!", MI); 987 }; 988 const unsigned VarStart = StatepointOpers(MI).getVarIdx(); 989 VerifyStackMapConstant(VarStart + StatepointOpers::CCOffset); 990 VerifyStackMapConstant(VarStart + StatepointOpers::FlagsOffset); 991 VerifyStackMapConstant(VarStart + StatepointOpers::NumDeoptOperandsOffset); 992 993 // TODO: verify we have properly encoded deopt arguments 994 }; 995 } 996 997 void 998 MachineVerifier::visitMachineOperand(const MachineOperand *MO, unsigned MONum) { 999 const MachineInstr *MI = MO->getParent(); 1000 const MCInstrDesc &MCID = MI->getDesc(); 1001 unsigned NumDefs = MCID.getNumDefs(); 1002 if (MCID.getOpcode() == TargetOpcode::PATCHPOINT) 1003 NumDefs = (MONum == 0 && MO->isReg()) ? NumDefs : 0; 1004 1005 // The first MCID.NumDefs operands must be explicit register defines 1006 if (MONum < NumDefs) { 1007 const MCOperandInfo &MCOI = MCID.OpInfo[MONum]; 1008 if (!MO->isReg()) 1009 report("Explicit definition must be a register", MO, MONum); 1010 else if (!MO->isDef() && !MCOI.isOptionalDef()) 1011 report("Explicit definition marked as use", MO, MONum); 1012 else if (MO->isImplicit()) 1013 report("Explicit definition marked as implicit", MO, MONum); 1014 } else if (MONum < MCID.getNumOperands()) { 1015 const MCOperandInfo &MCOI = MCID.OpInfo[MONum]; 1016 // Don't check if it's the last operand in a variadic instruction. See, 1017 // e.g., LDM_RET in the arm back end. 1018 if (MO->isReg() && 1019 !(MI->isVariadic() && MONum == MCID.getNumOperands()-1)) { 1020 if (MO->isDef() && !MCOI.isOptionalDef()) 1021 report("Explicit operand marked as def", MO, MONum); 1022 if (MO->isImplicit()) 1023 report("Explicit operand marked as implicit", MO, MONum); 1024 } 1025 1026 int TiedTo = MCID.getOperandConstraint(MONum, MCOI::TIED_TO); 1027 if (TiedTo != -1) { 1028 if (!MO->isReg()) 1029 report("Tied use must be a register", MO, MONum); 1030 else if (!MO->isTied()) 1031 report("Operand should be tied", MO, MONum); 1032 else if (unsigned(TiedTo) != MI->findTiedOperandIdx(MONum)) 1033 report("Tied def doesn't match MCInstrDesc", MO, MONum); 1034 else if (TargetRegisterInfo::isPhysicalRegister(MO->getReg())) { 1035 const MachineOperand &MOTied = MI->getOperand(TiedTo); 1036 if (!MOTied.isReg()) 1037 report("Tied counterpart must be a register", &MOTied, TiedTo); 1038 else if (TargetRegisterInfo::isPhysicalRegister(MOTied.getReg()) && 1039 MO->getReg() != MOTied.getReg()) 1040 report("Tied physical registers must match.", &MOTied, TiedTo); 1041 } 1042 } else if (MO->isReg() && MO->isTied()) 1043 report("Explicit operand should not be tied", MO, MONum); 1044 } else { 1045 // ARM adds %reg0 operands to indicate predicates. We'll allow that. 1046 if (MO->isReg() && !MO->isImplicit() && !MI->isVariadic() && MO->getReg()) 1047 report("Extra explicit operand on non-variadic instruction", MO, MONum); 1048 } 1049 1050 switch (MO->getType()) { 1051 case MachineOperand::MO_Register: { 1052 const unsigned Reg = MO->getReg(); 1053 if (!Reg) 1054 return; 1055 if (MRI->tracksLiveness() && !MI->isDebugValue()) 1056 checkLiveness(MO, MONum); 1057 1058 // Verify the consistency of tied operands. 1059 if (MO->isTied()) { 1060 unsigned OtherIdx = MI->findTiedOperandIdx(MONum); 1061 const MachineOperand &OtherMO = MI->getOperand(OtherIdx); 1062 if (!OtherMO.isReg()) 1063 report("Must be tied to a register", MO, MONum); 1064 if (!OtherMO.isTied()) 1065 report("Missing tie flags on tied operand", MO, MONum); 1066 if (MI->findTiedOperandIdx(OtherIdx) != MONum) 1067 report("Inconsistent tie links", MO, MONum); 1068 if (MONum < MCID.getNumDefs()) { 1069 if (OtherIdx < MCID.getNumOperands()) { 1070 if (-1 == MCID.getOperandConstraint(OtherIdx, MCOI::TIED_TO)) 1071 report("Explicit def tied to explicit use without tie constraint", 1072 MO, MONum); 1073 } else { 1074 if (!OtherMO.isImplicit()) 1075 report("Explicit def should be tied to implicit use", MO, MONum); 1076 } 1077 } 1078 } 1079 1080 // Verify two-address constraints after leaving SSA form. 1081 unsigned DefIdx; 1082 if (!MRI->isSSA() && MO->isUse() && 1083 MI->isRegTiedToDefOperand(MONum, &DefIdx) && 1084 Reg != MI->getOperand(DefIdx).getReg()) 1085 report("Two-address instruction operands must be identical", MO, MONum); 1086 1087 // Check register classes. 1088 unsigned SubIdx = MO->getSubReg(); 1089 1090 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1091 if (SubIdx) { 1092 report("Illegal subregister index for physical register", MO, MONum); 1093 return; 1094 } 1095 if (MONum < MCID.getNumOperands()) { 1096 if (const TargetRegisterClass *DRC = 1097 TII->getRegClass(MCID, MONum, TRI, *MF)) { 1098 if (!DRC->contains(Reg)) { 1099 report("Illegal physical register for instruction", MO, MONum); 1100 errs() << printReg(Reg, TRI) << " is not a " 1101 << TRI->getRegClassName(DRC) << " register.\n"; 1102 } 1103 } 1104 } 1105 } else { 1106 // Virtual register. 1107 const TargetRegisterClass *RC = MRI->getRegClassOrNull(Reg); 1108 if (!RC) { 1109 // This is a generic virtual register. 1110 1111 // If we're post-Select, we can't have gvregs anymore. 1112 if (isFunctionSelected) { 1113 report("Generic virtual register invalid in a Selected function", 1114 MO, MONum); 1115 return; 1116 } 1117 1118 // The gvreg must have a type and it must not have a SubIdx. 1119 LLT Ty = MRI->getType(Reg); 1120 if (!Ty.isValid()) { 1121 report("Generic virtual register must have a valid type", MO, 1122 MONum); 1123 return; 1124 } 1125 1126 const RegisterBank *RegBank = MRI->getRegBankOrNull(Reg); 1127 1128 // If we're post-RegBankSelect, the gvreg must have a bank. 1129 if (!RegBank && isFunctionRegBankSelected) { 1130 report("Generic virtual register must have a bank in a " 1131 "RegBankSelected function", 1132 MO, MONum); 1133 return; 1134 } 1135 1136 // Make sure the register fits into its register bank if any. 1137 if (RegBank && Ty.isValid() && 1138 RegBank->getSize() < Ty.getSizeInBits()) { 1139 report("Register bank is too small for virtual register", MO, 1140 MONum); 1141 errs() << "Register bank " << RegBank->getName() << " too small(" 1142 << RegBank->getSize() << ") to fit " << Ty.getSizeInBits() 1143 << "-bits\n"; 1144 return; 1145 } 1146 if (SubIdx) { 1147 report("Generic virtual register does not subregister index", MO, 1148 MONum); 1149 return; 1150 } 1151 1152 // If this is a target specific instruction and this operand 1153 // has register class constraint, the virtual register must 1154 // comply to it. 1155 if (!isPreISelGenericOpcode(MCID.getOpcode()) && 1156 MONum < MCID.getNumOperands() && 1157 TII->getRegClass(MCID, MONum, TRI, *MF)) { 1158 report("Virtual register does not match instruction constraint", MO, 1159 MONum); 1160 errs() << "Expect register class " 1161 << TRI->getRegClassName( 1162 TII->getRegClass(MCID, MONum, TRI, *MF)) 1163 << " but got nothing\n"; 1164 return; 1165 } 1166 1167 break; 1168 } 1169 if (SubIdx) { 1170 const TargetRegisterClass *SRC = 1171 TRI->getSubClassWithSubReg(RC, SubIdx); 1172 if (!SRC) { 1173 report("Invalid subregister index for virtual register", MO, MONum); 1174 errs() << "Register class " << TRI->getRegClassName(RC) 1175 << " does not support subreg index " << SubIdx << "\n"; 1176 return; 1177 } 1178 if (RC != SRC) { 1179 report("Invalid register class for subregister index", MO, MONum); 1180 errs() << "Register class " << TRI->getRegClassName(RC) 1181 << " does not fully support subreg index " << SubIdx << "\n"; 1182 return; 1183 } 1184 } 1185 if (MONum < MCID.getNumOperands()) { 1186 if (const TargetRegisterClass *DRC = 1187 TII->getRegClass(MCID, MONum, TRI, *MF)) { 1188 if (SubIdx) { 1189 const TargetRegisterClass *SuperRC = 1190 TRI->getLargestLegalSuperClass(RC, *MF); 1191 if (!SuperRC) { 1192 report("No largest legal super class exists.", MO, MONum); 1193 return; 1194 } 1195 DRC = TRI->getMatchingSuperRegClass(SuperRC, DRC, SubIdx); 1196 if (!DRC) { 1197 report("No matching super-reg register class.", MO, MONum); 1198 return; 1199 } 1200 } 1201 if (!RC->hasSuperClassEq(DRC)) { 1202 report("Illegal virtual register for instruction", MO, MONum); 1203 errs() << "Expected a " << TRI->getRegClassName(DRC) 1204 << " register, but got a " << TRI->getRegClassName(RC) 1205 << " register\n"; 1206 } 1207 } 1208 } 1209 } 1210 break; 1211 } 1212 1213 case MachineOperand::MO_RegisterMask: 1214 regMasks.push_back(MO->getRegMask()); 1215 break; 1216 1217 case MachineOperand::MO_MachineBasicBlock: 1218 if (MI->isPHI() && !MO->getMBB()->isSuccessor(MI->getParent())) 1219 report("PHI operand is not in the CFG", MO, MONum); 1220 break; 1221 1222 case MachineOperand::MO_FrameIndex: 1223 if (LiveStks && LiveStks->hasInterval(MO->getIndex()) && 1224 LiveInts && !LiveInts->isNotInMIMap(*MI)) { 1225 int FI = MO->getIndex(); 1226 LiveInterval &LI = LiveStks->getInterval(FI); 1227 SlotIndex Idx = LiveInts->getInstructionIndex(*MI); 1228 1229 bool stores = MI->mayStore(); 1230 bool loads = MI->mayLoad(); 1231 // For a memory-to-memory move, we need to check if the frame 1232 // index is used for storing or loading, by inspecting the 1233 // memory operands. 1234 if (stores && loads) { 1235 for (auto *MMO : MI->memoperands()) { 1236 const PseudoSourceValue *PSV = MMO->getPseudoValue(); 1237 if (PSV == nullptr) continue; 1238 const FixedStackPseudoSourceValue *Value = 1239 dyn_cast<FixedStackPseudoSourceValue>(PSV); 1240 if (Value == nullptr) continue; 1241 if (Value->getFrameIndex() != FI) continue; 1242 1243 if (MMO->isStore()) 1244 loads = false; 1245 else 1246 stores = false; 1247 break; 1248 } 1249 if (loads == stores) 1250 report("Missing fixed stack memoperand.", MI); 1251 } 1252 if (loads && !LI.liveAt(Idx.getRegSlot(true))) { 1253 report("Instruction loads from dead spill slot", MO, MONum); 1254 errs() << "Live stack: " << LI << '\n'; 1255 } 1256 if (stores && !LI.liveAt(Idx.getRegSlot())) { 1257 report("Instruction stores to dead spill slot", MO, MONum); 1258 errs() << "Live stack: " << LI << '\n'; 1259 } 1260 } 1261 break; 1262 1263 default: 1264 break; 1265 } 1266 } 1267 1268 void MachineVerifier::checkLivenessAtUse(const MachineOperand *MO, 1269 unsigned MONum, SlotIndex UseIdx, const LiveRange &LR, unsigned VRegOrUnit, 1270 LaneBitmask LaneMask) { 1271 LiveQueryResult LRQ = LR.Query(UseIdx); 1272 // Check if we have a segment at the use, note however that we only need one 1273 // live subregister range, the others may be dead. 1274 if (!LRQ.valueIn() && LaneMask.none()) { 1275 report("No live segment at use", MO, MONum); 1276 report_context_liverange(LR); 1277 report_context_vreg_regunit(VRegOrUnit); 1278 report_context(UseIdx); 1279 } 1280 if (MO->isKill() && !LRQ.isKill()) { 1281 report("Live range continues after kill flag", MO, MONum); 1282 report_context_liverange(LR); 1283 report_context_vreg_regunit(VRegOrUnit); 1284 if (LaneMask.any()) 1285 report_context_lanemask(LaneMask); 1286 report_context(UseIdx); 1287 } 1288 } 1289 1290 void MachineVerifier::checkLivenessAtDef(const MachineOperand *MO, 1291 unsigned MONum, SlotIndex DefIdx, const LiveRange &LR, unsigned VRegOrUnit, 1292 LaneBitmask LaneMask) { 1293 if (const VNInfo *VNI = LR.getVNInfoAt(DefIdx)) { 1294 assert(VNI && "NULL valno is not allowed"); 1295 if (VNI->def != DefIdx) { 1296 report("Inconsistent valno->def", MO, MONum); 1297 report_context_liverange(LR); 1298 report_context_vreg_regunit(VRegOrUnit); 1299 if (LaneMask.any()) 1300 report_context_lanemask(LaneMask); 1301 report_context(*VNI); 1302 report_context(DefIdx); 1303 } 1304 } else { 1305 report("No live segment at def", MO, MONum); 1306 report_context_liverange(LR); 1307 report_context_vreg_regunit(VRegOrUnit); 1308 if (LaneMask.any()) 1309 report_context_lanemask(LaneMask); 1310 report_context(DefIdx); 1311 } 1312 // Check that, if the dead def flag is present, LiveInts agree. 1313 if (MO->isDead()) { 1314 LiveQueryResult LRQ = LR.Query(DefIdx); 1315 if (!LRQ.isDeadDef()) { 1316 // In case of physregs we can have a non-dead definition on another 1317 // operand. 1318 bool otherDef = false; 1319 if (!TargetRegisterInfo::isVirtualRegister(VRegOrUnit)) { 1320 const MachineInstr &MI = *MO->getParent(); 1321 for (const MachineOperand &MO : MI.operands()) { 1322 if (!MO.isReg() || !MO.isDef() || MO.isDead()) 1323 continue; 1324 unsigned Reg = MO.getReg(); 1325 for (MCRegUnitIterator Units(Reg, TRI); Units.isValid(); ++Units) { 1326 if (*Units == VRegOrUnit) { 1327 otherDef = true; 1328 break; 1329 } 1330 } 1331 } 1332 } 1333 1334 if (!otherDef) { 1335 report("Live range continues after dead def flag", MO, MONum); 1336 report_context_liverange(LR); 1337 report_context_vreg_regunit(VRegOrUnit); 1338 if (LaneMask.any()) 1339 report_context_lanemask(LaneMask); 1340 } 1341 } 1342 } 1343 } 1344 1345 void MachineVerifier::checkLiveness(const MachineOperand *MO, unsigned MONum) { 1346 const MachineInstr *MI = MO->getParent(); 1347 const unsigned Reg = MO->getReg(); 1348 1349 // Both use and def operands can read a register. 1350 if (MO->readsReg()) { 1351 if (MO->isKill()) 1352 addRegWithSubRegs(regsKilled, Reg); 1353 1354 // Check that LiveVars knows this kill. 1355 if (LiveVars && TargetRegisterInfo::isVirtualRegister(Reg) && 1356 MO->isKill()) { 1357 LiveVariables::VarInfo &VI = LiveVars->getVarInfo(Reg); 1358 if (!is_contained(VI.Kills, MI)) 1359 report("Kill missing from LiveVariables", MO, MONum); 1360 } 1361 1362 // Check LiveInts liveness and kill. 1363 if (LiveInts && !LiveInts->isNotInMIMap(*MI)) { 1364 SlotIndex UseIdx = LiveInts->getInstructionIndex(*MI); 1365 // Check the cached regunit intervals. 1366 if (TargetRegisterInfo::isPhysicalRegister(Reg) && !isReserved(Reg)) { 1367 for (MCRegUnitIterator Units(Reg, TRI); Units.isValid(); ++Units) { 1368 if (MRI->isReservedRegUnit(*Units)) 1369 continue; 1370 if (const LiveRange *LR = LiveInts->getCachedRegUnit(*Units)) 1371 checkLivenessAtUse(MO, MONum, UseIdx, *LR, *Units); 1372 } 1373 } 1374 1375 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 1376 if (LiveInts->hasInterval(Reg)) { 1377 // This is a virtual register interval. 1378 const LiveInterval &LI = LiveInts->getInterval(Reg); 1379 checkLivenessAtUse(MO, MONum, UseIdx, LI, Reg); 1380 1381 if (LI.hasSubRanges() && !MO->isDef()) { 1382 unsigned SubRegIdx = MO->getSubReg(); 1383 LaneBitmask MOMask = SubRegIdx != 0 1384 ? TRI->getSubRegIndexLaneMask(SubRegIdx) 1385 : MRI->getMaxLaneMaskForVReg(Reg); 1386 LaneBitmask LiveInMask; 1387 for (const LiveInterval::SubRange &SR : LI.subranges()) { 1388 if ((MOMask & SR.LaneMask).none()) 1389 continue; 1390 checkLivenessAtUse(MO, MONum, UseIdx, SR, Reg, SR.LaneMask); 1391 LiveQueryResult LRQ = SR.Query(UseIdx); 1392 if (LRQ.valueIn()) 1393 LiveInMask |= SR.LaneMask; 1394 } 1395 // At least parts of the register has to be live at the use. 1396 if ((LiveInMask & MOMask).none()) { 1397 report("No live subrange at use", MO, MONum); 1398 report_context(LI); 1399 report_context(UseIdx); 1400 } 1401 } 1402 } else { 1403 report("Virtual register has no live interval", MO, MONum); 1404 } 1405 } 1406 } 1407 1408 // Use of a dead register. 1409 if (!regsLive.count(Reg)) { 1410 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1411 // Reserved registers may be used even when 'dead'. 1412 bool Bad = !isReserved(Reg); 1413 // We are fine if just any subregister has a defined value. 1414 if (Bad) { 1415 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); 1416 ++SubRegs) { 1417 if (regsLive.count(*SubRegs)) { 1418 Bad = false; 1419 break; 1420 } 1421 } 1422 } 1423 // If there is an additional implicit-use of a super register we stop 1424 // here. By definition we are fine if the super register is not 1425 // (completely) dead, if the complete super register is dead we will 1426 // get a report for its operand. 1427 if (Bad) { 1428 for (const MachineOperand &MOP : MI->uses()) { 1429 if (!MOP.isReg()) 1430 continue; 1431 if (!MOP.isImplicit()) 1432 continue; 1433 for (MCSubRegIterator SubRegs(MOP.getReg(), TRI); SubRegs.isValid(); 1434 ++SubRegs) { 1435 if (*SubRegs == Reg) { 1436 Bad = false; 1437 break; 1438 } 1439 } 1440 } 1441 } 1442 if (Bad) 1443 report("Using an undefined physical register", MO, MONum); 1444 } else if (MRI->def_empty(Reg)) { 1445 report("Reading virtual register without a def", MO, MONum); 1446 } else { 1447 BBInfo &MInfo = MBBInfoMap[MI->getParent()]; 1448 // We don't know which virtual registers are live in, so only complain 1449 // if vreg was killed in this MBB. Otherwise keep track of vregs that 1450 // must be live in. PHI instructions are handled separately. 1451 if (MInfo.regsKilled.count(Reg)) 1452 report("Using a killed virtual register", MO, MONum); 1453 else if (!MI->isPHI()) 1454 MInfo.vregsLiveIn.insert(std::make_pair(Reg, MI)); 1455 } 1456 } 1457 } 1458 1459 if (MO->isDef()) { 1460 // Register defined. 1461 // TODO: verify that earlyclobber ops are not used. 1462 if (MO->isDead()) 1463 addRegWithSubRegs(regsDead, Reg); 1464 else 1465 addRegWithSubRegs(regsDefined, Reg); 1466 1467 // Verify SSA form. 1468 if (MRI->isSSA() && TargetRegisterInfo::isVirtualRegister(Reg) && 1469 std::next(MRI->def_begin(Reg)) != MRI->def_end()) 1470 report("Multiple virtual register defs in SSA form", MO, MONum); 1471 1472 // Check LiveInts for a live segment, but only for virtual registers. 1473 if (LiveInts && !LiveInts->isNotInMIMap(*MI)) { 1474 SlotIndex DefIdx = LiveInts->getInstructionIndex(*MI); 1475 DefIdx = DefIdx.getRegSlot(MO->isEarlyClobber()); 1476 1477 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 1478 if (LiveInts->hasInterval(Reg)) { 1479 const LiveInterval &LI = LiveInts->getInterval(Reg); 1480 checkLivenessAtDef(MO, MONum, DefIdx, LI, Reg); 1481 1482 if (LI.hasSubRanges()) { 1483 unsigned SubRegIdx = MO->getSubReg(); 1484 LaneBitmask MOMask = SubRegIdx != 0 1485 ? TRI->getSubRegIndexLaneMask(SubRegIdx) 1486 : MRI->getMaxLaneMaskForVReg(Reg); 1487 for (const LiveInterval::SubRange &SR : LI.subranges()) { 1488 if ((SR.LaneMask & MOMask).none()) 1489 continue; 1490 checkLivenessAtDef(MO, MONum, DefIdx, SR, Reg, SR.LaneMask); 1491 } 1492 } 1493 } else { 1494 report("Virtual register has no Live interval", MO, MONum); 1495 } 1496 } 1497 } 1498 } 1499 } 1500 1501 void MachineVerifier::visitMachineInstrAfter(const MachineInstr *MI) {} 1502 1503 // This function gets called after visiting all instructions in a bundle. The 1504 // argument points to the bundle header. 1505 // Normal stand-alone instructions are also considered 'bundles', and this 1506 // function is called for all of them. 1507 void MachineVerifier::visitMachineBundleAfter(const MachineInstr *MI) { 1508 BBInfo &MInfo = MBBInfoMap[MI->getParent()]; 1509 set_union(MInfo.regsKilled, regsKilled); 1510 set_subtract(regsLive, regsKilled); regsKilled.clear(); 1511 // Kill any masked registers. 1512 while (!regMasks.empty()) { 1513 const uint32_t *Mask = regMasks.pop_back_val(); 1514 for (RegSet::iterator I = regsLive.begin(), E = regsLive.end(); I != E; ++I) 1515 if (TargetRegisterInfo::isPhysicalRegister(*I) && 1516 MachineOperand::clobbersPhysReg(Mask, *I)) 1517 regsDead.push_back(*I); 1518 } 1519 set_subtract(regsLive, regsDead); regsDead.clear(); 1520 set_union(regsLive, regsDefined); regsDefined.clear(); 1521 } 1522 1523 void 1524 MachineVerifier::visitMachineBasicBlockAfter(const MachineBasicBlock *MBB) { 1525 MBBInfoMap[MBB].regsLiveOut = regsLive; 1526 regsLive.clear(); 1527 1528 if (Indexes) { 1529 SlotIndex stop = Indexes->getMBBEndIdx(MBB); 1530 if (!(stop > lastIndex)) { 1531 report("Block ends before last instruction index", MBB); 1532 errs() << "Block ends at " << stop 1533 << " last instruction was at " << lastIndex << '\n'; 1534 } 1535 lastIndex = stop; 1536 } 1537 } 1538 1539 // Calculate the largest possible vregsPassed sets. These are the registers that 1540 // can pass through an MBB live, but may not be live every time. It is assumed 1541 // that all vregsPassed sets are empty before the call. 1542 void MachineVerifier::calcRegsPassed() { 1543 // First push live-out regs to successors' vregsPassed. Remember the MBBs that 1544 // have any vregsPassed. 1545 SmallPtrSet<const MachineBasicBlock*, 8> todo; 1546 for (const auto &MBB : *MF) { 1547 BBInfo &MInfo = MBBInfoMap[&MBB]; 1548 if (!MInfo.reachable) 1549 continue; 1550 for (MachineBasicBlock::const_succ_iterator SuI = MBB.succ_begin(), 1551 SuE = MBB.succ_end(); SuI != SuE; ++SuI) { 1552 BBInfo &SInfo = MBBInfoMap[*SuI]; 1553 if (SInfo.addPassed(MInfo.regsLiveOut)) 1554 todo.insert(*SuI); 1555 } 1556 } 1557 1558 // Iteratively push vregsPassed to successors. This will converge to the same 1559 // final state regardless of DenseSet iteration order. 1560 while (!todo.empty()) { 1561 const MachineBasicBlock *MBB = *todo.begin(); 1562 todo.erase(MBB); 1563 BBInfo &MInfo = MBBInfoMap[MBB]; 1564 for (MachineBasicBlock::const_succ_iterator SuI = MBB->succ_begin(), 1565 SuE = MBB->succ_end(); SuI != SuE; ++SuI) { 1566 if (*SuI == MBB) 1567 continue; 1568 BBInfo &SInfo = MBBInfoMap[*SuI]; 1569 if (SInfo.addPassed(MInfo.vregsPassed)) 1570 todo.insert(*SuI); 1571 } 1572 } 1573 } 1574 1575 // Calculate the set of virtual registers that must be passed through each basic 1576 // block in order to satisfy the requirements of successor blocks. This is very 1577 // similar to calcRegsPassed, only backwards. 1578 void MachineVerifier::calcRegsRequired() { 1579 // First push live-in regs to predecessors' vregsRequired. 1580 SmallPtrSet<const MachineBasicBlock*, 8> todo; 1581 for (const auto &MBB : *MF) { 1582 BBInfo &MInfo = MBBInfoMap[&MBB]; 1583 for (MachineBasicBlock::const_pred_iterator PrI = MBB.pred_begin(), 1584 PrE = MBB.pred_end(); PrI != PrE; ++PrI) { 1585 BBInfo &PInfo = MBBInfoMap[*PrI]; 1586 if (PInfo.addRequired(MInfo.vregsLiveIn)) 1587 todo.insert(*PrI); 1588 } 1589 } 1590 1591 // Iteratively push vregsRequired to predecessors. This will converge to the 1592 // same final state regardless of DenseSet iteration order. 1593 while (!todo.empty()) { 1594 const MachineBasicBlock *MBB = *todo.begin(); 1595 todo.erase(MBB); 1596 BBInfo &MInfo = MBBInfoMap[MBB]; 1597 for (MachineBasicBlock::const_pred_iterator PrI = MBB->pred_begin(), 1598 PrE = MBB->pred_end(); PrI != PrE; ++PrI) { 1599 if (*PrI == MBB) 1600 continue; 1601 BBInfo &SInfo = MBBInfoMap[*PrI]; 1602 if (SInfo.addRequired(MInfo.vregsRequired)) 1603 todo.insert(*PrI); 1604 } 1605 } 1606 } 1607 1608 // Check PHI instructions at the beginning of MBB. It is assumed that 1609 // calcRegsPassed has been run so BBInfo::isLiveOut is valid. 1610 void MachineVerifier::checkPHIOps(const MachineBasicBlock &MBB) { 1611 BBInfo &MInfo = MBBInfoMap[&MBB]; 1612 1613 SmallPtrSet<const MachineBasicBlock*, 8> seen; 1614 for (const MachineInstr &Phi : MBB) { 1615 if (!Phi.isPHI()) 1616 break; 1617 seen.clear(); 1618 1619 const MachineOperand &MODef = Phi.getOperand(0); 1620 if (!MODef.isReg() || !MODef.isDef()) { 1621 report("Expected first PHI operand to be a register def", &MODef, 0); 1622 continue; 1623 } 1624 if (MODef.isTied() || MODef.isImplicit() || MODef.isInternalRead() || 1625 MODef.isEarlyClobber() || MODef.isDebug()) 1626 report("Unexpected flag on PHI operand", &MODef, 0); 1627 unsigned DefReg = MODef.getReg(); 1628 if (!TargetRegisterInfo::isVirtualRegister(DefReg)) 1629 report("Expected first PHI operand to be a virtual register", &MODef, 0); 1630 1631 for (unsigned I = 1, E = Phi.getNumOperands(); I != E; I += 2) { 1632 const MachineOperand &MO0 = Phi.getOperand(I); 1633 if (!MO0.isReg()) { 1634 report("Expected PHI operand to be a register", &MO0, I); 1635 continue; 1636 } 1637 if (MO0.isImplicit() || MO0.isInternalRead() || MO0.isEarlyClobber() || 1638 MO0.isDebug() || MO0.isTied()) 1639 report("Unexpected flag on PHI operand", &MO0, I); 1640 1641 const MachineOperand &MO1 = Phi.getOperand(I + 1); 1642 if (!MO1.isMBB()) { 1643 report("Expected PHI operand to be a basic block", &MO1, I + 1); 1644 continue; 1645 } 1646 1647 const MachineBasicBlock &Pre = *MO1.getMBB(); 1648 if (!Pre.isSuccessor(&MBB)) { 1649 report("PHI input is not a predecessor block", &MO1, I + 1); 1650 continue; 1651 } 1652 1653 if (MInfo.reachable) { 1654 seen.insert(&Pre); 1655 BBInfo &PrInfo = MBBInfoMap[&Pre]; 1656 if (PrInfo.reachable && !PrInfo.isLiveOut(MO0.getReg())) 1657 report("PHI operand is not live-out from predecessor", &MO0, I); 1658 } 1659 } 1660 1661 // Did we see all predecessors? 1662 if (MInfo.reachable) { 1663 for (MachineBasicBlock *Pred : MBB.predecessors()) { 1664 if (!seen.count(Pred)) { 1665 report("Missing PHI operand", &Phi); 1666 errs() << "BB#" << Pred->getNumber() 1667 << " is a predecessor according to the CFG.\n"; 1668 } 1669 } 1670 } 1671 } 1672 } 1673 1674 void MachineVerifier::visitMachineFunctionAfter() { 1675 calcRegsPassed(); 1676 1677 for (const MachineBasicBlock &MBB : *MF) 1678 checkPHIOps(MBB); 1679 1680 // Now check liveness info if available 1681 calcRegsRequired(); 1682 1683 // Check for killed virtual registers that should be live out. 1684 for (const auto &MBB : *MF) { 1685 BBInfo &MInfo = MBBInfoMap[&MBB]; 1686 for (RegSet::iterator 1687 I = MInfo.vregsRequired.begin(), E = MInfo.vregsRequired.end(); I != E; 1688 ++I) 1689 if (MInfo.regsKilled.count(*I)) { 1690 report("Virtual register killed in block, but needed live out.", &MBB); 1691 errs() << "Virtual register " << printReg(*I) 1692 << " is used after the block.\n"; 1693 } 1694 } 1695 1696 if (!MF->empty()) { 1697 BBInfo &MInfo = MBBInfoMap[&MF->front()]; 1698 for (RegSet::iterator 1699 I = MInfo.vregsRequired.begin(), E = MInfo.vregsRequired.end(); I != E; 1700 ++I) { 1701 report("Virtual register defs don't dominate all uses.", MF); 1702 report_context_vreg(*I); 1703 } 1704 } 1705 1706 if (LiveVars) 1707 verifyLiveVariables(); 1708 if (LiveInts) 1709 verifyLiveIntervals(); 1710 } 1711 1712 void MachineVerifier::verifyLiveVariables() { 1713 assert(LiveVars && "Don't call verifyLiveVariables without LiveVars"); 1714 for (unsigned i = 0, e = MRI->getNumVirtRegs(); i != e; ++i) { 1715 unsigned Reg = TargetRegisterInfo::index2VirtReg(i); 1716 LiveVariables::VarInfo &VI = LiveVars->getVarInfo(Reg); 1717 for (const auto &MBB : *MF) { 1718 BBInfo &MInfo = MBBInfoMap[&MBB]; 1719 1720 // Our vregsRequired should be identical to LiveVariables' AliveBlocks 1721 if (MInfo.vregsRequired.count(Reg)) { 1722 if (!VI.AliveBlocks.test(MBB.getNumber())) { 1723 report("LiveVariables: Block missing from AliveBlocks", &MBB); 1724 errs() << "Virtual register " << printReg(Reg) 1725 << " must be live through the block.\n"; 1726 } 1727 } else { 1728 if (VI.AliveBlocks.test(MBB.getNumber())) { 1729 report("LiveVariables: Block should not be in AliveBlocks", &MBB); 1730 errs() << "Virtual register " << printReg(Reg) 1731 << " is not needed live through the block.\n"; 1732 } 1733 } 1734 } 1735 } 1736 } 1737 1738 void MachineVerifier::verifyLiveIntervals() { 1739 assert(LiveInts && "Don't call verifyLiveIntervals without LiveInts"); 1740 for (unsigned i = 0, e = MRI->getNumVirtRegs(); i != e; ++i) { 1741 unsigned Reg = TargetRegisterInfo::index2VirtReg(i); 1742 1743 // Spilling and splitting may leave unused registers around. Skip them. 1744 if (MRI->reg_nodbg_empty(Reg)) 1745 continue; 1746 1747 if (!LiveInts->hasInterval(Reg)) { 1748 report("Missing live interval for virtual register", MF); 1749 errs() << printReg(Reg, TRI) << " still has defs or uses\n"; 1750 continue; 1751 } 1752 1753 const LiveInterval &LI = LiveInts->getInterval(Reg); 1754 assert(Reg == LI.reg && "Invalid reg to interval mapping"); 1755 verifyLiveInterval(LI); 1756 } 1757 1758 // Verify all the cached regunit intervals. 1759 for (unsigned i = 0, e = TRI->getNumRegUnits(); i != e; ++i) 1760 if (const LiveRange *LR = LiveInts->getCachedRegUnit(i)) 1761 verifyLiveRange(*LR, i); 1762 } 1763 1764 void MachineVerifier::verifyLiveRangeValue(const LiveRange &LR, 1765 const VNInfo *VNI, unsigned Reg, 1766 LaneBitmask LaneMask) { 1767 if (VNI->isUnused()) 1768 return; 1769 1770 const VNInfo *DefVNI = LR.getVNInfoAt(VNI->def); 1771 1772 if (!DefVNI) { 1773 report("Value not live at VNInfo def and not marked unused", MF); 1774 report_context(LR, Reg, LaneMask); 1775 report_context(*VNI); 1776 return; 1777 } 1778 1779 if (DefVNI != VNI) { 1780 report("Live segment at def has different VNInfo", MF); 1781 report_context(LR, Reg, LaneMask); 1782 report_context(*VNI); 1783 return; 1784 } 1785 1786 const MachineBasicBlock *MBB = LiveInts->getMBBFromIndex(VNI->def); 1787 if (!MBB) { 1788 report("Invalid VNInfo definition index", MF); 1789 report_context(LR, Reg, LaneMask); 1790 report_context(*VNI); 1791 return; 1792 } 1793 1794 if (VNI->isPHIDef()) { 1795 if (VNI->def != LiveInts->getMBBStartIdx(MBB)) { 1796 report("PHIDef VNInfo is not defined at MBB start", MBB); 1797 report_context(LR, Reg, LaneMask); 1798 report_context(*VNI); 1799 } 1800 return; 1801 } 1802 1803 // Non-PHI def. 1804 const MachineInstr *MI = LiveInts->getInstructionFromIndex(VNI->def); 1805 if (!MI) { 1806 report("No instruction at VNInfo def index", MBB); 1807 report_context(LR, Reg, LaneMask); 1808 report_context(*VNI); 1809 return; 1810 } 1811 1812 if (Reg != 0) { 1813 bool hasDef = false; 1814 bool isEarlyClobber = false; 1815 for (ConstMIBundleOperands MOI(*MI); MOI.isValid(); ++MOI) { 1816 if (!MOI->isReg() || !MOI->isDef()) 1817 continue; 1818 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 1819 if (MOI->getReg() != Reg) 1820 continue; 1821 } else { 1822 if (!TargetRegisterInfo::isPhysicalRegister(MOI->getReg()) || 1823 !TRI->hasRegUnit(MOI->getReg(), Reg)) 1824 continue; 1825 } 1826 if (LaneMask.any() && 1827 (TRI->getSubRegIndexLaneMask(MOI->getSubReg()) & LaneMask).none()) 1828 continue; 1829 hasDef = true; 1830 if (MOI->isEarlyClobber()) 1831 isEarlyClobber = true; 1832 } 1833 1834 if (!hasDef) { 1835 report("Defining instruction does not modify register", MI); 1836 report_context(LR, Reg, LaneMask); 1837 report_context(*VNI); 1838 } 1839 1840 // Early clobber defs begin at USE slots, but other defs must begin at 1841 // DEF slots. 1842 if (isEarlyClobber) { 1843 if (!VNI->def.isEarlyClobber()) { 1844 report("Early clobber def must be at an early-clobber slot", MBB); 1845 report_context(LR, Reg, LaneMask); 1846 report_context(*VNI); 1847 } 1848 } else if (!VNI->def.isRegister()) { 1849 report("Non-PHI, non-early clobber def must be at a register slot", MBB); 1850 report_context(LR, Reg, LaneMask); 1851 report_context(*VNI); 1852 } 1853 } 1854 } 1855 1856 void MachineVerifier::verifyLiveRangeSegment(const LiveRange &LR, 1857 const LiveRange::const_iterator I, 1858 unsigned Reg, LaneBitmask LaneMask) 1859 { 1860 const LiveRange::Segment &S = *I; 1861 const VNInfo *VNI = S.valno; 1862 assert(VNI && "Live segment has no valno"); 1863 1864 if (VNI->id >= LR.getNumValNums() || VNI != LR.getValNumInfo(VNI->id)) { 1865 report("Foreign valno in live segment", MF); 1866 report_context(LR, Reg, LaneMask); 1867 report_context(S); 1868 report_context(*VNI); 1869 } 1870 1871 if (VNI->isUnused()) { 1872 report("Live segment valno is marked unused", MF); 1873 report_context(LR, Reg, LaneMask); 1874 report_context(S); 1875 } 1876 1877 const MachineBasicBlock *MBB = LiveInts->getMBBFromIndex(S.start); 1878 if (!MBB) { 1879 report("Bad start of live segment, no basic block", MF); 1880 report_context(LR, Reg, LaneMask); 1881 report_context(S); 1882 return; 1883 } 1884 SlotIndex MBBStartIdx = LiveInts->getMBBStartIdx(MBB); 1885 if (S.start != MBBStartIdx && S.start != VNI->def) { 1886 report("Live segment must begin at MBB entry or valno def", MBB); 1887 report_context(LR, Reg, LaneMask); 1888 report_context(S); 1889 } 1890 1891 const MachineBasicBlock *EndMBB = 1892 LiveInts->getMBBFromIndex(S.end.getPrevSlot()); 1893 if (!EndMBB) { 1894 report("Bad end of live segment, no basic block", MF); 1895 report_context(LR, Reg, LaneMask); 1896 report_context(S); 1897 return; 1898 } 1899 1900 // No more checks for live-out segments. 1901 if (S.end == LiveInts->getMBBEndIdx(EndMBB)) 1902 return; 1903 1904 // RegUnit intervals are allowed dead phis. 1905 if (!TargetRegisterInfo::isVirtualRegister(Reg) && VNI->isPHIDef() && 1906 S.start == VNI->def && S.end == VNI->def.getDeadSlot()) 1907 return; 1908 1909 // The live segment is ending inside EndMBB 1910 const MachineInstr *MI = 1911 LiveInts->getInstructionFromIndex(S.end.getPrevSlot()); 1912 if (!MI) { 1913 report("Live segment doesn't end at a valid instruction", EndMBB); 1914 report_context(LR, Reg, LaneMask); 1915 report_context(S); 1916 return; 1917 } 1918 1919 // The block slot must refer to a basic block boundary. 1920 if (S.end.isBlock()) { 1921 report("Live segment ends at B slot of an instruction", EndMBB); 1922 report_context(LR, Reg, LaneMask); 1923 report_context(S); 1924 } 1925 1926 if (S.end.isDead()) { 1927 // Segment ends on the dead slot. 1928 // That means there must be a dead def. 1929 if (!SlotIndex::isSameInstr(S.start, S.end)) { 1930 report("Live segment ending at dead slot spans instructions", EndMBB); 1931 report_context(LR, Reg, LaneMask); 1932 report_context(S); 1933 } 1934 } 1935 1936 // A live segment can only end at an early-clobber slot if it is being 1937 // redefined by an early-clobber def. 1938 if (S.end.isEarlyClobber()) { 1939 if (I+1 == LR.end() || (I+1)->start != S.end) { 1940 report("Live segment ending at early clobber slot must be " 1941 "redefined by an EC def in the same instruction", EndMBB); 1942 report_context(LR, Reg, LaneMask); 1943 report_context(S); 1944 } 1945 } 1946 1947 // The following checks only apply to virtual registers. Physreg liveness 1948 // is too weird to check. 1949 if (TargetRegisterInfo::isVirtualRegister(Reg)) { 1950 // A live segment can end with either a redefinition, a kill flag on a 1951 // use, or a dead flag on a def. 1952 bool hasRead = false; 1953 bool hasSubRegDef = false; 1954 bool hasDeadDef = false; 1955 for (ConstMIBundleOperands MOI(*MI); MOI.isValid(); ++MOI) { 1956 if (!MOI->isReg() || MOI->getReg() != Reg) 1957 continue; 1958 unsigned Sub = MOI->getSubReg(); 1959 LaneBitmask SLM = Sub != 0 ? TRI->getSubRegIndexLaneMask(Sub) 1960 : LaneBitmask::getAll(); 1961 if (MOI->isDef()) { 1962 if (Sub != 0) { 1963 hasSubRegDef = true; 1964 // An operand %0:sub0<def> reads %0:sub1..n. Invert the lane 1965 // mask for subregister defs. Read-undef defs will be handled by 1966 // readsReg below. 1967 SLM = ~SLM; 1968 } 1969 if (MOI->isDead()) 1970 hasDeadDef = true; 1971 } 1972 if (LaneMask.any() && (LaneMask & SLM).none()) 1973 continue; 1974 if (MOI->readsReg()) 1975 hasRead = true; 1976 } 1977 if (S.end.isDead()) { 1978 // Make sure that the corresponding machine operand for a "dead" live 1979 // range has the dead flag. We cannot perform this check for subregister 1980 // liveranges as partially dead values are allowed. 1981 if (LaneMask.none() && !hasDeadDef) { 1982 report("Instruction ending live segment on dead slot has no dead flag", 1983 MI); 1984 report_context(LR, Reg, LaneMask); 1985 report_context(S); 1986 } 1987 } else { 1988 if (!hasRead) { 1989 // When tracking subregister liveness, the main range must start new 1990 // values on partial register writes, even if there is no read. 1991 if (!MRI->shouldTrackSubRegLiveness(Reg) || LaneMask.any() || 1992 !hasSubRegDef) { 1993 report("Instruction ending live segment doesn't read the register", 1994 MI); 1995 report_context(LR, Reg, LaneMask); 1996 report_context(S); 1997 } 1998 } 1999 } 2000 } 2001 2002 // Now check all the basic blocks in this live segment. 2003 MachineFunction::const_iterator MFI = MBB->getIterator(); 2004 // Is this live segment the beginning of a non-PHIDef VN? 2005 if (S.start == VNI->def && !VNI->isPHIDef()) { 2006 // Not live-in to any blocks. 2007 if (MBB == EndMBB) 2008 return; 2009 // Skip this block. 2010 ++MFI; 2011 } 2012 while (true) { 2013 assert(LiveInts->isLiveInToMBB(LR, &*MFI)); 2014 // We don't know how to track physregs into a landing pad. 2015 if (!TargetRegisterInfo::isVirtualRegister(Reg) && 2016 MFI->isEHPad()) { 2017 if (&*MFI == EndMBB) 2018 break; 2019 ++MFI; 2020 continue; 2021 } 2022 2023 // Is VNI a PHI-def in the current block? 2024 bool IsPHI = VNI->isPHIDef() && 2025 VNI->def == LiveInts->getMBBStartIdx(&*MFI); 2026 2027 // Check that VNI is live-out of all predecessors. 2028 for (MachineBasicBlock::const_pred_iterator PI = MFI->pred_begin(), 2029 PE = MFI->pred_end(); PI != PE; ++PI) { 2030 SlotIndex PEnd = LiveInts->getMBBEndIdx(*PI); 2031 const VNInfo *PVNI = LR.getVNInfoBefore(PEnd); 2032 2033 // All predecessors must have a live-out value. However for a phi 2034 // instruction with subregister intervals 2035 // only one of the subregisters (not necessarily the current one) needs to 2036 // be defined. 2037 if (!PVNI && (LaneMask.none() || !IsPHI) ) { 2038 report("Register not marked live out of predecessor", *PI); 2039 report_context(LR, Reg, LaneMask); 2040 report_context(*VNI); 2041 errs() << " live into BB#" << MFI->getNumber() 2042 << '@' << LiveInts->getMBBStartIdx(&*MFI) << ", not live before " 2043 << PEnd << '\n'; 2044 continue; 2045 } 2046 2047 // Only PHI-defs can take different predecessor values. 2048 if (!IsPHI && PVNI != VNI) { 2049 report("Different value live out of predecessor", *PI); 2050 report_context(LR, Reg, LaneMask); 2051 errs() << "Valno #" << PVNI->id << " live out of BB#" 2052 << (*PI)->getNumber() << '@' << PEnd << "\nValno #" << VNI->id 2053 << " live into BB#" << MFI->getNumber() << '@' 2054 << LiveInts->getMBBStartIdx(&*MFI) << '\n'; 2055 } 2056 } 2057 if (&*MFI == EndMBB) 2058 break; 2059 ++MFI; 2060 } 2061 } 2062 2063 void MachineVerifier::verifyLiveRange(const LiveRange &LR, unsigned Reg, 2064 LaneBitmask LaneMask) { 2065 for (const VNInfo *VNI : LR.valnos) 2066 verifyLiveRangeValue(LR, VNI, Reg, LaneMask); 2067 2068 for (LiveRange::const_iterator I = LR.begin(), E = LR.end(); I != E; ++I) 2069 verifyLiveRangeSegment(LR, I, Reg, LaneMask); 2070 } 2071 2072 void MachineVerifier::verifyLiveInterval(const LiveInterval &LI) { 2073 unsigned Reg = LI.reg; 2074 assert(TargetRegisterInfo::isVirtualRegister(Reg)); 2075 verifyLiveRange(LI, Reg); 2076 2077 LaneBitmask Mask; 2078 LaneBitmask MaxMask = MRI->getMaxLaneMaskForVReg(Reg); 2079 for (const LiveInterval::SubRange &SR : LI.subranges()) { 2080 if ((Mask & SR.LaneMask).any()) { 2081 report("Lane masks of sub ranges overlap in live interval", MF); 2082 report_context(LI); 2083 } 2084 if ((SR.LaneMask & ~MaxMask).any()) { 2085 report("Subrange lanemask is invalid", MF); 2086 report_context(LI); 2087 } 2088 if (SR.empty()) { 2089 report("Subrange must not be empty", MF); 2090 report_context(SR, LI.reg, SR.LaneMask); 2091 } 2092 Mask |= SR.LaneMask; 2093 verifyLiveRange(SR, LI.reg, SR.LaneMask); 2094 if (!LI.covers(SR)) { 2095 report("A Subrange is not covered by the main range", MF); 2096 report_context(LI); 2097 } 2098 } 2099 2100 // Check the LI only has one connected component. 2101 ConnectedVNInfoEqClasses ConEQ(*LiveInts); 2102 unsigned NumComp = ConEQ.Classify(LI); 2103 if (NumComp > 1) { 2104 report("Multiple connected components in live interval", MF); 2105 report_context(LI); 2106 for (unsigned comp = 0; comp != NumComp; ++comp) { 2107 errs() << comp << ": valnos"; 2108 for (LiveInterval::const_vni_iterator I = LI.vni_begin(), 2109 E = LI.vni_end(); I!=E; ++I) 2110 if (comp == ConEQ.getEqClass(*I)) 2111 errs() << ' ' << (*I)->id; 2112 errs() << '\n'; 2113 } 2114 } 2115 } 2116 2117 namespace { 2118 2119 // FrameSetup and FrameDestroy can have zero adjustment, so using a single 2120 // integer, we can't tell whether it is a FrameSetup or FrameDestroy if the 2121 // value is zero. 2122 // We use a bool plus an integer to capture the stack state. 2123 struct StackStateOfBB { 2124 StackStateOfBB() = default; 2125 StackStateOfBB(int EntryVal, int ExitVal, bool EntrySetup, bool ExitSetup) : 2126 EntryValue(EntryVal), ExitValue(ExitVal), EntryIsSetup(EntrySetup), 2127 ExitIsSetup(ExitSetup) {} 2128 2129 // Can be negative, which means we are setting up a frame. 2130 int EntryValue = 0; 2131 int ExitValue = 0; 2132 bool EntryIsSetup = false; 2133 bool ExitIsSetup = false; 2134 }; 2135 2136 } // end anonymous namespace 2137 2138 /// Make sure on every path through the CFG, a FrameSetup <n> is always followed 2139 /// by a FrameDestroy <n>, stack adjustments are identical on all 2140 /// CFG edges to a merge point, and frame is destroyed at end of a return block. 2141 void MachineVerifier::verifyStackFrame() { 2142 unsigned FrameSetupOpcode = TII->getCallFrameSetupOpcode(); 2143 unsigned FrameDestroyOpcode = TII->getCallFrameDestroyOpcode(); 2144 if (FrameSetupOpcode == ~0u && FrameDestroyOpcode == ~0u) 2145 return; 2146 2147 SmallVector<StackStateOfBB, 8> SPState; 2148 SPState.resize(MF->getNumBlockIDs()); 2149 df_iterator_default_set<const MachineBasicBlock*> Reachable; 2150 2151 // Visit the MBBs in DFS order. 2152 for (df_ext_iterator<const MachineFunction *, 2153 df_iterator_default_set<const MachineBasicBlock *>> 2154 DFI = df_ext_begin(MF, Reachable), DFE = df_ext_end(MF, Reachable); 2155 DFI != DFE; ++DFI) { 2156 const MachineBasicBlock *MBB = *DFI; 2157 2158 StackStateOfBB BBState; 2159 // Check the exit state of the DFS stack predecessor. 2160 if (DFI.getPathLength() >= 2) { 2161 const MachineBasicBlock *StackPred = DFI.getPath(DFI.getPathLength() - 2); 2162 assert(Reachable.count(StackPred) && 2163 "DFS stack predecessor is already visited.\n"); 2164 BBState.EntryValue = SPState[StackPred->getNumber()].ExitValue; 2165 BBState.EntryIsSetup = SPState[StackPred->getNumber()].ExitIsSetup; 2166 BBState.ExitValue = BBState.EntryValue; 2167 BBState.ExitIsSetup = BBState.EntryIsSetup; 2168 } 2169 2170 // Update stack state by checking contents of MBB. 2171 for (const auto &I : *MBB) { 2172 if (I.getOpcode() == FrameSetupOpcode) { 2173 if (BBState.ExitIsSetup) 2174 report("FrameSetup is after another FrameSetup", &I); 2175 BBState.ExitValue -= TII->getFrameTotalSize(I); 2176 BBState.ExitIsSetup = true; 2177 } 2178 2179 if (I.getOpcode() == FrameDestroyOpcode) { 2180 int Size = TII->getFrameTotalSize(I); 2181 if (!BBState.ExitIsSetup) 2182 report("FrameDestroy is not after a FrameSetup", &I); 2183 int AbsSPAdj = BBState.ExitValue < 0 ? -BBState.ExitValue : 2184 BBState.ExitValue; 2185 if (BBState.ExitIsSetup && AbsSPAdj != Size) { 2186 report("FrameDestroy <n> is after FrameSetup <m>", &I); 2187 errs() << "FrameDestroy <" << Size << "> is after FrameSetup <" 2188 << AbsSPAdj << ">.\n"; 2189 } 2190 BBState.ExitValue += Size; 2191 BBState.ExitIsSetup = false; 2192 } 2193 } 2194 SPState[MBB->getNumber()] = BBState; 2195 2196 // Make sure the exit state of any predecessor is consistent with the entry 2197 // state. 2198 for (MachineBasicBlock::const_pred_iterator I = MBB->pred_begin(), 2199 E = MBB->pred_end(); I != E; ++I) { 2200 if (Reachable.count(*I) && 2201 (SPState[(*I)->getNumber()].ExitValue != BBState.EntryValue || 2202 SPState[(*I)->getNumber()].ExitIsSetup != BBState.EntryIsSetup)) { 2203 report("The exit stack state of a predecessor is inconsistent.", MBB); 2204 errs() << "Predecessor BB#" << (*I)->getNumber() << " has exit state (" 2205 << SPState[(*I)->getNumber()].ExitValue << ", " 2206 << SPState[(*I)->getNumber()].ExitIsSetup 2207 << "), while BB#" << MBB->getNumber() << " has entry state (" 2208 << BBState.EntryValue << ", " << BBState.EntryIsSetup << ").\n"; 2209 } 2210 } 2211 2212 // Make sure the entry state of any successor is consistent with the exit 2213 // state. 2214 for (MachineBasicBlock::const_succ_iterator I = MBB->succ_begin(), 2215 E = MBB->succ_end(); I != E; ++I) { 2216 if (Reachable.count(*I) && 2217 (SPState[(*I)->getNumber()].EntryValue != BBState.ExitValue || 2218 SPState[(*I)->getNumber()].EntryIsSetup != BBState.ExitIsSetup)) { 2219 report("The entry stack state of a successor is inconsistent.", MBB); 2220 errs() << "Successor BB#" << (*I)->getNumber() << " has entry state (" 2221 << SPState[(*I)->getNumber()].EntryValue << ", " 2222 << SPState[(*I)->getNumber()].EntryIsSetup 2223 << "), while BB#" << MBB->getNumber() << " has exit state (" 2224 << BBState.ExitValue << ", " << BBState.ExitIsSetup << ").\n"; 2225 } 2226 } 2227 2228 // Make sure a basic block with return ends with zero stack adjustment. 2229 if (!MBB->empty() && MBB->back().isReturn()) { 2230 if (BBState.ExitIsSetup) 2231 report("A return block ends with a FrameSetup.", MBB); 2232 if (BBState.ExitValue) 2233 report("A return block ends with a nonzero stack adjustment.", MBB); 2234 } 2235 } 2236 } 2237