1900b6335SEugene Zelenko //===- ImplicitNullChecks.cpp - Fold null checks into memory accesses -----===// 269fad079SSanjoy Das // 369fad079SSanjoy Das // The LLVM Compiler Infrastructure 469fad079SSanjoy Das // 569fad079SSanjoy Das // This file is distributed under the University of Illinois Open Source 669fad079SSanjoy Das // License. See LICENSE.TXT for details. 769fad079SSanjoy Das // 869fad079SSanjoy Das //===----------------------------------------------------------------------===// 969fad079SSanjoy Das // 1069fad079SSanjoy Das // This pass turns explicit null checks of the form 1169fad079SSanjoy Das // 1269fad079SSanjoy Das // test %r10, %r10 1369fad079SSanjoy Das // je throw_npe 1469fad079SSanjoy Das // movl (%r10), %esi 1569fad079SSanjoy Das // ... 1669fad079SSanjoy Das // 1769fad079SSanjoy Das // to 1869fad079SSanjoy Das // 1969fad079SSanjoy Das // faulting_load_op("movl (%r10), %esi", throw_npe) 2069fad079SSanjoy Das // ... 2169fad079SSanjoy Das // 2269fad079SSanjoy Das // With the help of a runtime that understands the .fault_maps section, 2369fad079SSanjoy Das // faulting_load_op branches to throw_npe if executing movl (%r10), %esi incurs 2469fad079SSanjoy Das // a page fault. 2551c220cbSSerguei Katkov // Store and LoadStore are also supported. 2669fad079SSanjoy Das // 2769fad079SSanjoy Das //===----------------------------------------------------------------------===// 2869fad079SSanjoy Das 29900b6335SEugene Zelenko #include "llvm/ADT/ArrayRef.h" 30900b6335SEugene Zelenko #include "llvm/ADT/None.h" 31900b6335SEugene Zelenko #include "llvm/ADT/Optional.h" 32900b6335SEugene Zelenko #include "llvm/ADT/STLExtras.h" 3369fad079SSanjoy Das #include "llvm/ADT/SmallVector.h" 348ee6a30bSSanjoy Das #include "llvm/ADT/Statistic.h" 35e57bf680SSanjoy Das #include "llvm/Analysis/AliasAnalysis.h" 36900b6335SEugene Zelenko #include "llvm/Analysis/MemoryLocation.h" 372f63cbccSSanjoy Das #include "llvm/CodeGen/FaultMaps.h" 38900b6335SEugene Zelenko #include "llvm/CodeGen/MachineBasicBlock.h" 3969fad079SSanjoy Das #include "llvm/CodeGen/MachineFunction.h" 4069fad079SSanjoy Das #include "llvm/CodeGen/MachineFunctionPass.h" 41900b6335SEugene Zelenko #include "llvm/CodeGen/MachineInstr.h" 4269fad079SSanjoy Das #include "llvm/CodeGen/MachineInstrBuilder.h" 436bda14b3SChandler Carruth #include "llvm/CodeGen/MachineMemOperand.h" 446bda14b3SChandler Carruth #include "llvm/CodeGen/MachineOperand.h" 456bda14b3SChandler Carruth #include "llvm/CodeGen/MachineRegisterInfo.h" 46900b6335SEugene Zelenko #include "llvm/CodeGen/PseudoSourceValue.h" 473f833edcSDavid Blaikie #include "llvm/CodeGen/TargetInstrInfo.h" 48*b3bde2eaSDavid Blaikie #include "llvm/CodeGen/TargetOpcodes.h" 49*b3bde2eaSDavid Blaikie #include "llvm/CodeGen/TargetRegisterInfo.h" 50*b3bde2eaSDavid Blaikie #include "llvm/CodeGen/TargetSubtargetInfo.h" 5169fad079SSanjoy Das #include "llvm/IR/BasicBlock.h" 52900b6335SEugene Zelenko #include "llvm/IR/DebugLoc.h" 5300038784SChen Li #include "llvm/IR/LLVMContext.h" 54900b6335SEugene Zelenko #include "llvm/MC/MCInstrDesc.h" 55900b6335SEugene Zelenko #include "llvm/MC/MCRegisterInfo.h" 56900b6335SEugene Zelenko #include "llvm/Pass.h" 5769fad079SSanjoy Das #include "llvm/Support/CommandLine.h" 58900b6335SEugene Zelenko #include <cassert> 59900b6335SEugene Zelenko #include <cstdint> 60900b6335SEugene Zelenko #include <iterator> 6169fad079SSanjoy Das 6269fad079SSanjoy Das using namespace llvm; 6369fad079SSanjoy Das 64c27a18f3SChad Rosier static cl::opt<int> PageSize("imp-null-check-page-size", 65c27a18f3SChad Rosier cl::desc("The page size of the target in bytes"), 6669fad079SSanjoy Das cl::init(4096)); 6769fad079SSanjoy Das 689a129807SSanjoy Das static cl::opt<unsigned> MaxInstsToConsider( 699a129807SSanjoy Das "imp-null-max-insts-to-consider", 709a129807SSanjoy Das cl::desc("The max number of instructions to consider hoisting loads over " 719a129807SSanjoy Das "(the algorithm is quadratic over this number)"), 729a129807SSanjoy Das cl::init(8)); 739a129807SSanjoy Das 748ee6a30bSSanjoy Das #define DEBUG_TYPE "implicit-null-checks" 758ee6a30bSSanjoy Das 768ee6a30bSSanjoy Das STATISTIC(NumImplicitNullChecks, 778ee6a30bSSanjoy Das "Number of explicit null checks made implicit"); 788ee6a30bSSanjoy Das 7969fad079SSanjoy Das namespace { 8069fad079SSanjoy Das 8169fad079SSanjoy Das class ImplicitNullChecks : public MachineFunctionPass { 829a129807SSanjoy Das /// Return true if \c computeDependence can process \p MI. 839a129807SSanjoy Das static bool canHandle(const MachineInstr *MI); 849a129807SSanjoy Das 859a129807SSanjoy Das /// Helper function for \c computeDependence. Return true if \p A 869a129807SSanjoy Das /// and \p B do not have any dependences between them, and can be 879a129807SSanjoy Das /// re-ordered without changing program semantics. 889a129807SSanjoy Das bool canReorder(const MachineInstr *A, const MachineInstr *B); 899a129807SSanjoy Das 909a129807SSanjoy Das /// A data type for representing the result computed by \c 919a129807SSanjoy Das /// computeDependence. States whether it is okay to reorder the 929a129807SSanjoy Das /// instruction passed to \c computeDependence with at most one 939a129807SSanjoy Das /// depednency. 949a129807SSanjoy Das struct DependenceResult { 959a129807SSanjoy Das /// Can we actually re-order \p MI with \p Insts (see \c 969a129807SSanjoy Das /// computeDependence). 979a129807SSanjoy Das bool CanReorder; 989a129807SSanjoy Das 999a129807SSanjoy Das /// If non-None, then an instruction in \p Insts that also must be 1009a129807SSanjoy Das /// hoisted. 1019a129807SSanjoy Das Optional<ArrayRef<MachineInstr *>::iterator> PotentialDependence; 1029a129807SSanjoy Das 1039a129807SSanjoy Das /*implicit*/ DependenceResult( 1049a129807SSanjoy Das bool CanReorder, 1059a129807SSanjoy Das Optional<ArrayRef<MachineInstr *>::iterator> PotentialDependence) 1069a129807SSanjoy Das : CanReorder(CanReorder), PotentialDependence(PotentialDependence) { 1079a129807SSanjoy Das assert((!PotentialDependence || CanReorder) && 1089a129807SSanjoy Das "!CanReorder && PotentialDependence.hasValue() not allowed!"); 1099a129807SSanjoy Das } 1109a129807SSanjoy Das }; 1119a129807SSanjoy Das 1129a129807SSanjoy Das /// Compute a result for the following question: can \p MI be 1139a129807SSanjoy Das /// re-ordered from after \p Insts to before it. 1149a129807SSanjoy Das /// 1159a129807SSanjoy Das /// \c canHandle should return true for all instructions in \p 1169a129807SSanjoy Das /// Insts. 1179a129807SSanjoy Das DependenceResult computeDependence(const MachineInstr *MI, 1189a129807SSanjoy Das ArrayRef<MachineInstr *> Insts); 1199a129807SSanjoy Das 12069fad079SSanjoy Das /// Represents one null check that can be made implicit. 121e173b9aeSSanjoy Das class NullCheck { 12269fad079SSanjoy Das // The memory operation the null check can be folded into. 12369fad079SSanjoy Das MachineInstr *MemOperation; 12469fad079SSanjoy Das 12569fad079SSanjoy Das // The instruction actually doing the null check (Ptr != 0). 12669fad079SSanjoy Das MachineInstr *CheckOperation; 12769fad079SSanjoy Das 12869fad079SSanjoy Das // The block the check resides in. 12969fad079SSanjoy Das MachineBasicBlock *CheckBlock; 13069fad079SSanjoy Das 131572e03a3SEric Christopher // The block branched to if the pointer is non-null. 13269fad079SSanjoy Das MachineBasicBlock *NotNullSucc; 13369fad079SSanjoy Das 134572e03a3SEric Christopher // The block branched to if the pointer is null. 13569fad079SSanjoy Das MachineBasicBlock *NullSucc; 13669fad079SSanjoy Das 137e57bf680SSanjoy Das // If this is non-null, then MemOperation has a dependency on on this 138e57bf680SSanjoy Das // instruction; and it needs to be hoisted to execute before MemOperation. 139e57bf680SSanjoy Das MachineInstr *OnlyDependency; 140e57bf680SSanjoy Das 141e173b9aeSSanjoy Das public: 14269fad079SSanjoy Das explicit NullCheck(MachineInstr *memOperation, MachineInstr *checkOperation, 14369fad079SSanjoy Das MachineBasicBlock *checkBlock, 14469fad079SSanjoy Das MachineBasicBlock *notNullSucc, 145e57bf680SSanjoy Das MachineBasicBlock *nullSucc, 146e57bf680SSanjoy Das MachineInstr *onlyDependency) 14769fad079SSanjoy Das : MemOperation(memOperation), CheckOperation(checkOperation), 148e57bf680SSanjoy Das CheckBlock(checkBlock), NotNullSucc(notNullSucc), NullSucc(nullSucc), 149e57bf680SSanjoy Das OnlyDependency(onlyDependency) {} 150e173b9aeSSanjoy Das 151e173b9aeSSanjoy Das MachineInstr *getMemOperation() const { return MemOperation; } 152e173b9aeSSanjoy Das 153e173b9aeSSanjoy Das MachineInstr *getCheckOperation() const { return CheckOperation; } 154e173b9aeSSanjoy Das 155e173b9aeSSanjoy Das MachineBasicBlock *getCheckBlock() const { return CheckBlock; } 156e173b9aeSSanjoy Das 157e173b9aeSSanjoy Das MachineBasicBlock *getNotNullSucc() const { return NotNullSucc; } 158e173b9aeSSanjoy Das 159e173b9aeSSanjoy Das MachineBasicBlock *getNullSucc() const { return NullSucc; } 160e57bf680SSanjoy Das 161e57bf680SSanjoy Das MachineInstr *getOnlyDependency() const { return OnlyDependency; } 16269fad079SSanjoy Das }; 16369fad079SSanjoy Das 16469fad079SSanjoy Das const TargetInstrInfo *TII = nullptr; 16569fad079SSanjoy Das const TargetRegisterInfo *TRI = nullptr; 166e57bf680SSanjoy Das AliasAnalysis *AA = nullptr; 167eef785c1SSanjoy Das MachineFrameInfo *MFI = nullptr; 16869fad079SSanjoy Das 16969fad079SSanjoy Das bool analyzeBlockForNullChecks(MachineBasicBlock &MBB, 17069fad079SSanjoy Das SmallVectorImpl<NullCheck> &NullCheckList); 1712f63cbccSSanjoy Das MachineInstr *insertFaultingInstr(MachineInstr *MI, MachineBasicBlock *MBB, 1724e1d389aSQuentin Colombet MachineBasicBlock *HandlerMBB); 17369fad079SSanjoy Das void rewriteNullChecks(ArrayRef<NullCheck> NullCheckList); 17469fad079SSanjoy Das 175eef785c1SSanjoy Das enum AliasResult { 176eef785c1SSanjoy Das AR_NoAlias, 177eef785c1SSanjoy Das AR_MayAlias, 178eef785c1SSanjoy Das AR_WillAliasEverything 179eef785c1SSanjoy Das }; 180900b6335SEugene Zelenko 181eef785c1SSanjoy Das /// Returns AR_NoAlias if \p MI memory operation does not alias with 182eef785c1SSanjoy Das /// \p PrevMI, AR_MayAlias if they may alias and AR_WillAliasEverything if 183eef785c1SSanjoy Das /// they may alias and any further memory operation may alias with \p PrevMI. 184eef785c1SSanjoy Das AliasResult areMemoryOpsAliased(MachineInstr &MI, MachineInstr *PrevMI); 18515e50b51SSanjoy Das 186eef785c1SSanjoy Das enum SuitabilityResult { 187eef785c1SSanjoy Das SR_Suitable, 188eef785c1SSanjoy Das SR_Unsuitable, 189eef785c1SSanjoy Das SR_Impossible 190eef785c1SSanjoy Das }; 191900b6335SEugene Zelenko 19215e50b51SSanjoy Das /// Return SR_Suitable if \p MI a memory operation that can be used to 19315e50b51SSanjoy Das /// implicitly null check the value in \p PointerReg, SR_Unsuitable if 19415e50b51SSanjoy Das /// \p MI cannot be used to null check and SR_Impossible if there is 19515e50b51SSanjoy Das /// no sense to continue lookup due to any other instruction will not be able 19615e50b51SSanjoy Das /// to be used. \p PrevInsts is the set of instruction seen since 197eef785c1SSanjoy Das /// the explicit null check on \p PointerReg. 19815e50b51SSanjoy Das SuitabilityResult isSuitableMemoryOp(MachineInstr &MI, unsigned PointerReg, 199eef785c1SSanjoy Das ArrayRef<MachineInstr *> PrevInsts); 20050fef432SSanjoy Das 20150fef432SSanjoy Das /// Return true if \p FaultingMI can be hoisted from after the the 20250fef432SSanjoy Das /// instructions in \p InstsSeenSoFar to before them. Set \p Dependence to a 20350fef432SSanjoy Das /// non-null value if we also need to (and legally can) hoist a depedency. 2042f63cbccSSanjoy Das bool canHoistInst(MachineInstr *FaultingMI, unsigned PointerReg, 20550fef432SSanjoy Das ArrayRef<MachineInstr *> InstsSeenSoFar, 20650fef432SSanjoy Das MachineBasicBlock *NullSucc, MachineInstr *&Dependence); 20750fef432SSanjoy Das 20869fad079SSanjoy Das public: 20969fad079SSanjoy Das static char ID; 21069fad079SSanjoy Das 21169fad079SSanjoy Das ImplicitNullChecks() : MachineFunctionPass(ID) { 21269fad079SSanjoy Das initializeImplicitNullChecksPass(*PassRegistry::getPassRegistry()); 21369fad079SSanjoy Das } 21469fad079SSanjoy Das 21569fad079SSanjoy Das bool runOnMachineFunction(MachineFunction &MF) override; 216900b6335SEugene Zelenko 217e57bf680SSanjoy Das void getAnalysisUsage(AnalysisUsage &AU) const override { 218e57bf680SSanjoy Das AU.addRequired<AAResultsWrapperPass>(); 219e57bf680SSanjoy Das MachineFunctionPass::getAnalysisUsage(AU); 220e57bf680SSanjoy Das } 221ad154c83SDerek Schuff 222ad154c83SDerek Schuff MachineFunctionProperties getRequiredProperties() const override { 223ad154c83SDerek Schuff return MachineFunctionProperties().set( 2241eb47368SMatthias Braun MachineFunctionProperties::Property::NoVRegs); 225ad154c83SDerek Schuff } 22669fad079SSanjoy Das }; 227edc394f1SSanjoy Das 228900b6335SEugene Zelenko } // end anonymous namespace 229e57bf680SSanjoy Das 2309a129807SSanjoy Das bool ImplicitNullChecks::canHandle(const MachineInstr *MI) { 2312f63cbccSSanjoy Das if (MI->isCall() || MI->hasUnmodeledSideEffects()) 2329a129807SSanjoy Das return false; 2339a129807SSanjoy Das auto IsRegMask = [](const MachineOperand &MO) { return MO.isRegMask(); }; 2349a129807SSanjoy Das (void)IsRegMask; 235edc394f1SSanjoy Das 2369a129807SSanjoy Das assert(!llvm::any_of(MI->operands(), IsRegMask) && 2379a129807SSanjoy Das "Calls were filtered out above!"); 238edc394f1SSanjoy Das 2399a129807SSanjoy Das auto IsUnordered = [](MachineMemOperand *MMO) { return MMO->isUnordered(); }; 2409a129807SSanjoy Das return llvm::all_of(MI->memoperands(), IsUnordered); 241edc394f1SSanjoy Das } 242edc394f1SSanjoy Das 2439a129807SSanjoy Das ImplicitNullChecks::DependenceResult 2449a129807SSanjoy Das ImplicitNullChecks::computeDependence(const MachineInstr *MI, 2459a129807SSanjoy Das ArrayRef<MachineInstr *> Block) { 2469a129807SSanjoy Das assert(llvm::all_of(Block, canHandle) && "Check this first!"); 247900b6335SEugene Zelenko assert(!is_contained(Block, MI) && "Block must be exclusive of MI!"); 248edc394f1SSanjoy Das 2499a129807SSanjoy Das Optional<ArrayRef<MachineInstr *>::iterator> Dep; 250edc394f1SSanjoy Das 2519a129807SSanjoy Das for (auto I = Block.begin(), E = Block.end(); I != E; ++I) { 2529a129807SSanjoy Das if (canReorder(*I, MI)) 253edc394f1SSanjoy Das continue; 254edc394f1SSanjoy Das 2559a129807SSanjoy Das if (Dep == None) { 2569a129807SSanjoy Das // Found one possible dependency, keep track of it. 2579a129807SSanjoy Das Dep = I; 2589a129807SSanjoy Das } else { 2599a129807SSanjoy Das // We found two dependencies, so bail out. 2609a129807SSanjoy Das return {false, None}; 261edc394f1SSanjoy Das } 262edc394f1SSanjoy Das } 263edc394f1SSanjoy Das 2649a129807SSanjoy Das return {true, Dep}; 2659a129807SSanjoy Das } 266edc394f1SSanjoy Das 2679a129807SSanjoy Das bool ImplicitNullChecks::canReorder(const MachineInstr *A, 2689a129807SSanjoy Das const MachineInstr *B) { 2699a129807SSanjoy Das assert(canHandle(A) && canHandle(B) && "Precondition!"); 270edc394f1SSanjoy Das 2719a129807SSanjoy Das // canHandle makes sure that we _can_ correctly analyze the dependencies 2729a129807SSanjoy Das // between A and B here -- for instance, we should not be dealing with heap 2739a129807SSanjoy Das // load-store dependencies here. 2749a129807SSanjoy Das 2759a129807SSanjoy Das for (auto MOA : A->operands()) { 2769a129807SSanjoy Das if (!(MOA.isReg() && MOA.getReg())) 277e57bf680SSanjoy Das continue; 278e57bf680SSanjoy Das 2799a129807SSanjoy Das unsigned RegA = MOA.getReg(); 2809a129807SSanjoy Das for (auto MOB : B->operands()) { 2819a129807SSanjoy Das if (!(MOB.isReg() && MOB.getReg())) 282e57bf680SSanjoy Das continue; 2839a129807SSanjoy Das 2849a129807SSanjoy Das unsigned RegB = MOB.getReg(); 2859a129807SSanjoy Das 28608da2e28SSanjoy Das if (TRI->regsOverlap(RegA, RegB) && (MOA.isDef() || MOB.isDef())) 287e57bf680SSanjoy Das return false; 288e57bf680SSanjoy Das } 289edc394f1SSanjoy Das } 290edc394f1SSanjoy Das 291edc394f1SSanjoy Das return true; 292f00654e3SAlexander Kornienko } 29369fad079SSanjoy Das 29469fad079SSanjoy Das bool ImplicitNullChecks::runOnMachineFunction(MachineFunction &MF) { 29569fad079SSanjoy Das TII = MF.getSubtarget().getInstrInfo(); 29669fad079SSanjoy Das TRI = MF.getRegInfo().getTargetRegisterInfo(); 297eef785c1SSanjoy Das MFI = &MF.getFrameInfo(); 298e57bf680SSanjoy Das AA = &getAnalysis<AAResultsWrapperPass>().getAAResults(); 29969fad079SSanjoy Das 30069fad079SSanjoy Das SmallVector<NullCheck, 16> NullCheckList; 30169fad079SSanjoy Das 30269fad079SSanjoy Das for (auto &MBB : MF) 30369fad079SSanjoy Das analyzeBlockForNullChecks(MBB, NullCheckList); 30469fad079SSanjoy Das 30569fad079SSanjoy Das if (!NullCheckList.empty()) 30669fad079SSanjoy Das rewriteNullChecks(NullCheckList); 30769fad079SSanjoy Das 30869fad079SSanjoy Das return !NullCheckList.empty(); 30969fad079SSanjoy Das } 31069fad079SSanjoy Das 311e57bf680SSanjoy Das // Return true if any register aliasing \p Reg is live-in into \p MBB. 312e57bf680SSanjoy Das static bool AnyAliasLiveIn(const TargetRegisterInfo *TRI, 313e57bf680SSanjoy Das MachineBasicBlock *MBB, unsigned Reg) { 314e57bf680SSanjoy Das for (MCRegAliasIterator AR(Reg, TRI, /*IncludeSelf*/ true); AR.isValid(); 315e57bf680SSanjoy Das ++AR) 316e57bf680SSanjoy Das if (MBB->isLiveIn(*AR)) 317e57bf680SSanjoy Das return true; 318e57bf680SSanjoy Das return false; 319e57bf680SSanjoy Das } 320e57bf680SSanjoy Das 321eef785c1SSanjoy Das ImplicitNullChecks::AliasResult 322eef785c1SSanjoy Das ImplicitNullChecks::areMemoryOpsAliased(MachineInstr &MI, 323eef785c1SSanjoy Das MachineInstr *PrevMI) { 324eef785c1SSanjoy Das // If it is not memory access, skip the check. 325eef785c1SSanjoy Das if (!(PrevMI->mayStore() || PrevMI->mayLoad())) 326eef785c1SSanjoy Das return AR_NoAlias; 327eef785c1SSanjoy Das // Load-Load may alias 328eef785c1SSanjoy Das if (!(MI.mayStore() || PrevMI->mayStore())) 329eef785c1SSanjoy Das return AR_NoAlias; 330eef785c1SSanjoy Das // We lost info, conservatively alias. If it was store then no sense to 331eef785c1SSanjoy Das // continue because we won't be able to check against it further. 332eef785c1SSanjoy Das if (MI.memoperands_empty()) 333eef785c1SSanjoy Das return MI.mayStore() ? AR_WillAliasEverything : AR_MayAlias; 334eef785c1SSanjoy Das if (PrevMI->memoperands_empty()) 335eef785c1SSanjoy Das return PrevMI->mayStore() ? AR_WillAliasEverything : AR_MayAlias; 336eef785c1SSanjoy Das 337eef785c1SSanjoy Das for (MachineMemOperand *MMO1 : MI.memoperands()) { 338eef785c1SSanjoy Das // MMO1 should have a value due it comes from operation we'd like to use 339eef785c1SSanjoy Das // as implicit null check. 340eef785c1SSanjoy Das assert(MMO1->getValue() && "MMO1 should have a Value!"); 341eef785c1SSanjoy Das for (MachineMemOperand *MMO2 : PrevMI->memoperands()) { 342eef785c1SSanjoy Das if (const PseudoSourceValue *PSV = MMO2->getPseudoValue()) { 343eef785c1SSanjoy Das if (PSV->mayAlias(MFI)) 344eef785c1SSanjoy Das return AR_MayAlias; 345eef785c1SSanjoy Das continue; 346eef785c1SSanjoy Das } 347eef785c1SSanjoy Das llvm::AliasResult AAResult = AA->alias( 348eef785c1SSanjoy Das MemoryLocation(MMO1->getValue(), MemoryLocation::UnknownSize, 349eef785c1SSanjoy Das MMO1->getAAInfo()), 350eef785c1SSanjoy Das MemoryLocation(MMO2->getValue(), MemoryLocation::UnknownSize, 351eef785c1SSanjoy Das MMO2->getAAInfo())); 352eef785c1SSanjoy Das if (AAResult != NoAlias) 353eef785c1SSanjoy Das return AR_MayAlias; 354eef785c1SSanjoy Das } 355eef785c1SSanjoy Das } 356eef785c1SSanjoy Das return AR_NoAlias; 357eef785c1SSanjoy Das } 358eef785c1SSanjoy Das 35915e50b51SSanjoy Das ImplicitNullChecks::SuitabilityResult 36015e50b51SSanjoy Das ImplicitNullChecks::isSuitableMemoryOp(MachineInstr &MI, unsigned PointerReg, 361eef785c1SSanjoy Das ArrayRef<MachineInstr *> PrevInsts) { 36250fef432SSanjoy Das int64_t Offset; 36350fef432SSanjoy Das unsigned BaseReg; 36450fef432SSanjoy Das 36550fef432SSanjoy Das if (!TII->getMemOpBaseRegImmOfs(MI, BaseReg, Offset, TRI) || 36650fef432SSanjoy Das BaseReg != PointerReg) 367eef785c1SSanjoy Das return SR_Unsuitable; 36850fef432SSanjoy Das 3692f63cbccSSanjoy Das // We want the mem access to be issued at a sane offset from PointerReg, 3702f63cbccSSanjoy Das // so that if PointerReg is null then the access reliably page faults. 3712f63cbccSSanjoy Das if (!((MI.mayLoad() || MI.mayStore()) && !MI.isPredicable() && 372a18b0b18SYichao Yu -PageSize < Offset && Offset < PageSize)) 373eef785c1SSanjoy Das return SR_Unsuitable; 37450fef432SSanjoy Das 3750b0dc57dSSerguei Katkov // Finally, check whether the current memory access aliases with previous one. 3760b0dc57dSSerguei Katkov for (auto *PrevMI : PrevInsts) { 377eef785c1SSanjoy Das AliasResult AR = areMemoryOpsAliased(MI, PrevMI); 378eef785c1SSanjoy Das if (AR == AR_WillAliasEverything) 379eef785c1SSanjoy Das return SR_Impossible; 380eef785c1SSanjoy Das if (AR == AR_MayAlias) 3810b0dc57dSSerguei Katkov return SR_Unsuitable; 382eef785c1SSanjoy Das } 3830b0dc57dSSerguei Katkov return SR_Suitable; 38450fef432SSanjoy Das } 38550fef432SSanjoy Das 3862f63cbccSSanjoy Das bool ImplicitNullChecks::canHoistInst(MachineInstr *FaultingMI, 3872f63cbccSSanjoy Das unsigned PointerReg, 3882f63cbccSSanjoy Das ArrayRef<MachineInstr *> InstsSeenSoFar, 3892f63cbccSSanjoy Das MachineBasicBlock *NullSucc, 39050fef432SSanjoy Das MachineInstr *&Dependence) { 39150fef432SSanjoy Das auto DepResult = computeDependence(FaultingMI, InstsSeenSoFar); 39250fef432SSanjoy Das if (!DepResult.CanReorder) 39350fef432SSanjoy Das return false; 39450fef432SSanjoy Das 39550fef432SSanjoy Das if (!DepResult.PotentialDependence) { 39650fef432SSanjoy Das Dependence = nullptr; 39750fef432SSanjoy Das return true; 39850fef432SSanjoy Das } 39950fef432SSanjoy Das 40050fef432SSanjoy Das auto DependenceItr = *DepResult.PotentialDependence; 40150fef432SSanjoy Das auto *DependenceMI = *DependenceItr; 40250fef432SSanjoy Das 40350fef432SSanjoy Das // We don't want to reason about speculating loads. Note -- at this point 40450fef432SSanjoy Das // we should have already filtered out all of the other non-speculatable 40550fef432SSanjoy Das // things, like calls and stores. 4066ea2e81cSSerguei Katkov // We also do not want to hoist stores because it might change the memory 4076ea2e81cSSerguei Katkov // while the FaultingMI may result in faulting. 40850fef432SSanjoy Das assert(canHandle(DependenceMI) && "Should never have reached here!"); 4096ea2e81cSSerguei Katkov if (DependenceMI->mayLoadOrStore()) 41050fef432SSanjoy Das return false; 41150fef432SSanjoy Das 41250fef432SSanjoy Das for (auto &DependenceMO : DependenceMI->operands()) { 41350fef432SSanjoy Das if (!(DependenceMO.isReg() && DependenceMO.getReg())) 41450fef432SSanjoy Das continue; 41550fef432SSanjoy Das 41650fef432SSanjoy Das // Make sure that we won't clobber any live ins to the sibling block by 41750fef432SSanjoy Das // hoisting Dependency. For instance, we can't hoist INST to before the 41850fef432SSanjoy Das // null check (even if it safe, and does not violate any dependencies in 41950fef432SSanjoy Das // the non_null_block) if %rdx is live in to _null_block. 42050fef432SSanjoy Das // 42150fef432SSanjoy Das // test %rcx, %rcx 42250fef432SSanjoy Das // je _null_block 42350fef432SSanjoy Das // _non_null_block: 42450fef432SSanjoy Das // %rdx<def> = INST 42550fef432SSanjoy Das // ... 42650fef432SSanjoy Das // 42750fef432SSanjoy Das // This restriction does not apply to the faulting load inst because in 42850fef432SSanjoy Das // case the pointer loaded from is in the null page, the load will not 42950fef432SSanjoy Das // semantically execute, and affect machine state. That is, if the load 43050fef432SSanjoy Das // was loading into %rax and it faults, the value of %rax should stay the 43150fef432SSanjoy Das // same as it would have been had the load not have executed and we'd have 43250fef432SSanjoy Das // branched to NullSucc directly. 43350fef432SSanjoy Das if (AnyAliasLiveIn(TRI, NullSucc, DependenceMO.getReg())) 43450fef432SSanjoy Das return false; 43550fef432SSanjoy Das 43650fef432SSanjoy Das // The Dependency can't be re-defining the base register -- then we won't 43750fef432SSanjoy Das // get the memory operation on the address we want. This is already 43850fef432SSanjoy Das // checked in \c IsSuitableMemoryOp. 43908da2e28SSanjoy Das assert(!(DependenceMO.isDef() && 44008da2e28SSanjoy Das TRI->regsOverlap(DependenceMO.getReg(), PointerReg)) && 44150fef432SSanjoy Das "Should have been checked before!"); 44250fef432SSanjoy Das } 44350fef432SSanjoy Das 44450fef432SSanjoy Das auto DepDepResult = 44550fef432SSanjoy Das computeDependence(DependenceMI, {InstsSeenSoFar.begin(), DependenceItr}); 44650fef432SSanjoy Das 44750fef432SSanjoy Das if (!DepDepResult.CanReorder || DepDepResult.PotentialDependence) 44850fef432SSanjoy Das return false; 44950fef432SSanjoy Das 45050fef432SSanjoy Das Dependence = DependenceMI; 45150fef432SSanjoy Das return true; 45250fef432SSanjoy Das } 45350fef432SSanjoy Das 45469fad079SSanjoy Das /// Analyze MBB to check if its terminating branch can be turned into an 45569fad079SSanjoy Das /// implicit null check. If yes, append a description of the said null check to 45669fad079SSanjoy Das /// NullCheckList and return true, else return false. 45769fad079SSanjoy Das bool ImplicitNullChecks::analyzeBlockForNullChecks( 45869fad079SSanjoy Das MachineBasicBlock &MBB, SmallVectorImpl<NullCheck> &NullCheckList) { 459900b6335SEugene Zelenko using MachineBranchPredicate = TargetInstrInfo::MachineBranchPredicate; 46069fad079SSanjoy Das 461e8b81649SSanjoy Das MDNode *BranchMD = nullptr; 462e8b81649SSanjoy Das if (auto *BB = MBB.getBasicBlock()) 463e8b81649SSanjoy Das BranchMD = BB->getTerminator()->getMetadata(LLVMContext::MD_make_implicit); 464e8b81649SSanjoy Das 4659c41a93eSSanjoy Das if (!BranchMD) 4669c41a93eSSanjoy Das return false; 4679c41a93eSSanjoy Das 46869fad079SSanjoy Das MachineBranchPredicate MBP; 46969fad079SSanjoy Das 47071c30a14SJacques Pienaar if (TII->analyzeBranchPredicate(MBB, MBP, true)) 47169fad079SSanjoy Das return false; 47269fad079SSanjoy Das 47369fad079SSanjoy Das // Is the predicate comparing an integer to zero? 47469fad079SSanjoy Das if (!(MBP.LHS.isReg() && MBP.RHS.isImm() && MBP.RHS.getImm() == 0 && 47569fad079SSanjoy Das (MBP.Predicate == MachineBranchPredicate::PRED_NE || 47669fad079SSanjoy Das MBP.Predicate == MachineBranchPredicate::PRED_EQ))) 47769fad079SSanjoy Das return false; 47869fad079SSanjoy Das 47969fad079SSanjoy Das // If we cannot erase the test instruction itself, then making the null check 48069fad079SSanjoy Das // implicit does not buy us much. 48169fad079SSanjoy Das if (!MBP.SingleUseCondition) 48269fad079SSanjoy Das return false; 48369fad079SSanjoy Das 48469fad079SSanjoy Das MachineBasicBlock *NotNullSucc, *NullSucc; 48569fad079SSanjoy Das 48669fad079SSanjoy Das if (MBP.Predicate == MachineBranchPredicate::PRED_NE) { 48769fad079SSanjoy Das NotNullSucc = MBP.TrueDest; 48869fad079SSanjoy Das NullSucc = MBP.FalseDest; 48969fad079SSanjoy Das } else { 49069fad079SSanjoy Das NotNullSucc = MBP.FalseDest; 49169fad079SSanjoy Das NullSucc = MBP.TrueDest; 49269fad079SSanjoy Das } 49369fad079SSanjoy Das 49469fad079SSanjoy Das // We handle the simplest case for now. We can potentially do better by using 49569fad079SSanjoy Das // the machine dominator tree. 49669fad079SSanjoy Das if (NotNullSucc->pred_size() != 1) 49769fad079SSanjoy Das return false; 49869fad079SSanjoy Das 49969fad079SSanjoy Das // Starting with a code fragment like: 50069fad079SSanjoy Das // 50169fad079SSanjoy Das // test %RAX, %RAX 50269fad079SSanjoy Das // jne LblNotNull 50369fad079SSanjoy Das // 50469fad079SSanjoy Das // LblNull: 50569fad079SSanjoy Das // callq throw_NullPointerException 50669fad079SSanjoy Das // 50769fad079SSanjoy Das // LblNotNull: 508b7718454SSanjoy Das // Inst0 509b7718454SSanjoy Das // Inst1 510b7718454SSanjoy Das // ... 51169fad079SSanjoy Das // Def = Load (%RAX + <offset>) 51269fad079SSanjoy Das // ... 51369fad079SSanjoy Das // 51469fad079SSanjoy Das // 51569fad079SSanjoy Das // we want to end up with 51669fad079SSanjoy Das // 517ac9c5b19SSanjoy Das // Def = FaultingLoad (%RAX + <offset>), LblNull 51869fad079SSanjoy Das // jmp LblNotNull ;; explicit or fallthrough 51969fad079SSanjoy Das // 52069fad079SSanjoy Das // LblNotNull: 521b7718454SSanjoy Das // Inst0 522b7718454SSanjoy Das // Inst1 52369fad079SSanjoy Das // ... 52469fad079SSanjoy Das // 52569fad079SSanjoy Das // LblNull: 52669fad079SSanjoy Das // callq throw_NullPointerException 52769fad079SSanjoy Das // 528ac9c5b19SSanjoy Das // 529ac9c5b19SSanjoy Das // To see why this is legal, consider the two possibilities: 530ac9c5b19SSanjoy Das // 531ac9c5b19SSanjoy Das // 1. %RAX is null: since we constrain <offset> to be less than PageSize, the 532ac9c5b19SSanjoy Das // load instruction dereferences the null page, causing a segmentation 533ac9c5b19SSanjoy Das // fault. 534ac9c5b19SSanjoy Das // 535ac9c5b19SSanjoy Das // 2. %RAX is not null: in this case we know that the load cannot fault, as 536ac9c5b19SSanjoy Das // otherwise the load would've faulted in the original program too and the 537ac9c5b19SSanjoy Das // original program would've been undefined. 538ac9c5b19SSanjoy Das // 539ac9c5b19SSanjoy Das // This reasoning cannot be extended to justify hoisting through arbitrary 540ac9c5b19SSanjoy Das // control flow. For instance, in the example below (in pseudo-C) 541ac9c5b19SSanjoy Das // 542ac9c5b19SSanjoy Das // if (ptr == null) { throw_npe(); unreachable; } 543ac9c5b19SSanjoy Das // if (some_cond) { return 42; } 544ac9c5b19SSanjoy Das // v = ptr->field; // LD 545ac9c5b19SSanjoy Das // ... 546ac9c5b19SSanjoy Das // 547ac9c5b19SSanjoy Das // we cannot (without code duplication) use the load marked "LD" to null check 548ac9c5b19SSanjoy Das // ptr -- clause (2) above does not apply in this case. In the above program 549ac9c5b19SSanjoy Das // the safety of ptr->field can be dependent on some_cond; and, for instance, 550ac9c5b19SSanjoy Das // ptr could be some non-null invalid reference that never gets loaded from 551ac9c5b19SSanjoy Das // because some_cond is always true. 55269fad079SSanjoy Das 5539a129807SSanjoy Das const unsigned PointerReg = MBP.LHS.getReg(); 554b7718454SSanjoy Das 5559a129807SSanjoy Das SmallVector<MachineInstr *, 8> InstsSeenSoFar; 556b7718454SSanjoy Das 5579a129807SSanjoy Das for (auto &MI : *NotNullSucc) { 5589a129807SSanjoy Das if (!canHandle(&MI) || InstsSeenSoFar.size() >= MaxInstsToConsider) 5599a129807SSanjoy Das return false; 560e57bf680SSanjoy Das 5619a129807SSanjoy Das MachineInstr *Dependence; 562eef785c1SSanjoy Das SuitabilityResult SR = isSuitableMemoryOp(MI, PointerReg, InstsSeenSoFar); 56315e50b51SSanjoy Das if (SR == SR_Impossible) 56415e50b51SSanjoy Das return false; 5652f63cbccSSanjoy Das if (SR == SR_Suitable && 5662f63cbccSSanjoy Das canHoistInst(&MI, PointerReg, InstsSeenSoFar, NullSucc, Dependence)) { 5679cfc75c2SDuncan P. N. Exon Smith NullCheckList.emplace_back(&MI, MBP.ConditionDef, &MBB, NotNullSucc, 5689a129807SSanjoy Das NullSucc, Dependence); 569e57bf680SSanjoy Das return true; 570e57bf680SSanjoy Das } 57169fad079SSanjoy Das 5720b0dc57dSSerguei Katkov // If MI re-defines the PointerReg then we cannot move further. 573900b6335SEugene Zelenko if (llvm::any_of(MI.operands(), [&](MachineOperand &MO) { 5740b0dc57dSSerguei Katkov return MO.isReg() && MO.getReg() && MO.isDef() && 5750b0dc57dSSerguei Katkov TRI->regsOverlap(MO.getReg(), PointerReg); 5760b0dc57dSSerguei Katkov })) 5770b0dc57dSSerguei Katkov return false; 5789a129807SSanjoy Das InstsSeenSoFar.push_back(&MI); 579b7718454SSanjoy Das } 580b7718454SSanjoy Das 58169fad079SSanjoy Das return false; 58269fad079SSanjoy Das } 58369fad079SSanjoy Das 5842f63cbccSSanjoy Das /// Wrap a machine instruction, MI, into a FAULTING machine instruction. 5852f63cbccSSanjoy Das /// The FAULTING instruction does the same load/store as MI 5862f63cbccSSanjoy Das /// (defining the same register), and branches to HandlerMBB if the mem access 5872f63cbccSSanjoy Das /// faults. The FAULTING instruction is inserted at the end of MBB. 5882f63cbccSSanjoy Das MachineInstr *ImplicitNullChecks::insertFaultingInstr( 5892f63cbccSSanjoy Das MachineInstr *MI, MachineBasicBlock *MBB, MachineBasicBlock *HandlerMBB) { 59093d608c3SSanjoy Das const unsigned NoRegister = 0; // Guaranteed to be the NoRegister value for 59193d608c3SSanjoy Das // all targets. 59293d608c3SSanjoy Das 59369fad079SSanjoy Das DebugLoc DL; 5942f63cbccSSanjoy Das unsigned NumDefs = MI->getDesc().getNumDefs(); 59593d608c3SSanjoy Das assert(NumDefs <= 1 && "other cases unhandled!"); 59669fad079SSanjoy Das 59793d608c3SSanjoy Das unsigned DefReg = NoRegister; 59893d608c3SSanjoy Das if (NumDefs != 0) { 5992f63cbccSSanjoy Das DefReg = MI->defs().begin()->getReg(); 6002f63cbccSSanjoy Das assert(std::distance(MI->defs().begin(), MI->defs().end()) == 1 && 60169fad079SSanjoy Das "expected exactly one def!"); 60293d608c3SSanjoy Das } 60369fad079SSanjoy Das 6042f63cbccSSanjoy Das FaultMaps::FaultKind FK; 6052f63cbccSSanjoy Das if (MI->mayLoad()) 6062f63cbccSSanjoy Das FK = 6072f63cbccSSanjoy Das MI->mayStore() ? FaultMaps::FaultingLoadStore : FaultMaps::FaultingLoad; 6082f63cbccSSanjoy Das else 6092f63cbccSSanjoy Das FK = FaultMaps::FaultingStore; 61069fad079SSanjoy Das 6112f63cbccSSanjoy Das auto MIB = BuildMI(MBB, DL, TII->get(TargetOpcode::FAULTING_OP), DefReg) 6122f63cbccSSanjoy Das .addImm(FK) 6132f63cbccSSanjoy Das .addMBB(HandlerMBB) 6142f63cbccSSanjoy Das .addImm(MI->getOpcode()); 6152f63cbccSSanjoy Das 616605f7795SMatthias Braun for (auto &MO : MI->uses()) { 617605f7795SMatthias Braun if (MO.isReg()) { 618605f7795SMatthias Braun MachineOperand NewMO = MO; 619605f7795SMatthias Braun if (MO.isUse()) { 620605f7795SMatthias Braun NewMO.setIsKill(false); 621605f7795SMatthias Braun } else { 622605f7795SMatthias Braun assert(MO.isDef() && "Expected def or use"); 623605f7795SMatthias Braun NewMO.setIsDead(false); 624605f7795SMatthias Braun } 625605f7795SMatthias Braun MIB.add(NewMO); 626605f7795SMatthias Braun } else { 627116bbab4SDiana Picus MIB.add(MO); 628605f7795SMatthias Braun } 629605f7795SMatthias Braun } 63069fad079SSanjoy Das 6312f63cbccSSanjoy Das MIB.setMemRefs(MI->memoperands_begin(), MI->memoperands_end()); 63269fad079SSanjoy Das 63369fad079SSanjoy Das return MIB; 63469fad079SSanjoy Das } 63569fad079SSanjoy Das 63669fad079SSanjoy Das /// Rewrite the null checks in NullCheckList into implicit null checks. 63769fad079SSanjoy Das void ImplicitNullChecks::rewriteNullChecks( 63869fad079SSanjoy Das ArrayRef<ImplicitNullChecks::NullCheck> NullCheckList) { 63969fad079SSanjoy Das DebugLoc DL; 64069fad079SSanjoy Das 64169fad079SSanjoy Das for (auto &NC : NullCheckList) { 64269fad079SSanjoy Das // Remove the conditional branch dependent on the null check. 6431b9fc8edSMatt Arsenault unsigned BranchesRemoved = TII->removeBranch(*NC.getCheckBlock()); 64469fad079SSanjoy Das (void)BranchesRemoved; 64569fad079SSanjoy Das assert(BranchesRemoved > 0 && "expected at least one branch!"); 64669fad079SSanjoy Das 647e57bf680SSanjoy Das if (auto *DepMI = NC.getOnlyDependency()) { 648e57bf680SSanjoy Das DepMI->removeFromParent(); 649e57bf680SSanjoy Das NC.getCheckBlock()->insert(NC.getCheckBlock()->end(), DepMI); 650e57bf680SSanjoy Das } 651e57bf680SSanjoy Das 6522f63cbccSSanjoy Das // Insert a faulting instruction where the conditional branch was 6532f63cbccSSanjoy Das // originally. We check earlier ensures that this bit of code motion 6542f63cbccSSanjoy Das // is legal. We do not touch the successors list for any basic block 6552f63cbccSSanjoy Das // since we haven't changed control flow, we've just made it implicit. 6562f63cbccSSanjoy Das MachineInstr *FaultingInstr = insertFaultingInstr( 657e173b9aeSSanjoy Das NC.getMemOperation(), NC.getCheckBlock(), NC.getNullSucc()); 65826dab3a4SQuentin Colombet // Now the values defined by MemOperation, if any, are live-in of 65926dab3a4SQuentin Colombet // the block of MemOperation. 6602f63cbccSSanjoy Das // The original operation may define implicit-defs alongside 6612f63cbccSSanjoy Das // the value. 662e173b9aeSSanjoy Das MachineBasicBlock *MBB = NC.getMemOperation()->getParent(); 6632f63cbccSSanjoy Das for (const MachineOperand &MO : FaultingInstr->operands()) { 66426dab3a4SQuentin Colombet if (!MO.isReg() || !MO.isDef()) 66526dab3a4SQuentin Colombet continue; 66626dab3a4SQuentin Colombet unsigned Reg = MO.getReg(); 66726dab3a4SQuentin Colombet if (!Reg || MBB->isLiveIn(Reg)) 66826dab3a4SQuentin Colombet continue; 66912b69919SQuentin Colombet MBB->addLiveIn(Reg); 67012b69919SQuentin Colombet } 671e57bf680SSanjoy Das 672e57bf680SSanjoy Das if (auto *DepMI = NC.getOnlyDependency()) { 673e57bf680SSanjoy Das for (auto &MO : DepMI->operands()) { 674e57bf680SSanjoy Das if (!MO.isReg() || !MO.getReg() || !MO.isDef()) 675e57bf680SSanjoy Das continue; 676e57bf680SSanjoy Das if (!NC.getNotNullSucc()->isLiveIn(MO.getReg())) 677e57bf680SSanjoy Das NC.getNotNullSucc()->addLiveIn(MO.getReg()); 678e57bf680SSanjoy Das } 679e57bf680SSanjoy Das } 680e57bf680SSanjoy Das 681e173b9aeSSanjoy Das NC.getMemOperation()->eraseFromParent(); 682e173b9aeSSanjoy Das NC.getCheckOperation()->eraseFromParent(); 68369fad079SSanjoy Das 68469fad079SSanjoy Das // Insert an *unconditional* branch to not-null successor. 685e8e0f5caSMatt Arsenault TII->insertBranch(*NC.getCheckBlock(), NC.getNotNullSucc(), nullptr, 686e173b9aeSSanjoy Das /*Cond=*/None, DL); 68769fad079SSanjoy Das 6888ee6a30bSSanjoy Das NumImplicitNullChecks++; 68969fad079SSanjoy Das } 69069fad079SSanjoy Das } 69169fad079SSanjoy Das 69269fad079SSanjoy Das char ImplicitNullChecks::ID = 0; 693900b6335SEugene Zelenko 69469fad079SSanjoy Das char &llvm::ImplicitNullChecksID = ImplicitNullChecks::ID; 695900b6335SEugene Zelenko 6961527baabSMatthias Braun INITIALIZE_PASS_BEGIN(ImplicitNullChecks, DEBUG_TYPE, 69769fad079SSanjoy Das "Implicit null checks", false, false) 698e57bf680SSanjoy Das INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass) 6991527baabSMatthias Braun INITIALIZE_PASS_END(ImplicitNullChecks, DEBUG_TYPE, 70069fad079SSanjoy Das "Implicit null checks", false, false) 701