1 //===-- BranchFolding.cpp - Fold machine code branch instructions ---------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This pass forwards branches to unconditional branches to make them branch 11 // directly to the target block. This pass often results in dead MBB's, which 12 // it then removes. 13 // 14 // Note that this pass must be run after register allocation, it cannot handle 15 // SSA form. 16 // 17 //===----------------------------------------------------------------------===// 18 19 #define DEBUG_TYPE "branchfolding" 20 #include "BranchFolding.h" 21 #include "llvm/Function.h" 22 #include "llvm/CodeGen/Passes.h" 23 #include "llvm/CodeGen/MachineModuleInfo.h" 24 #include "llvm/CodeGen/MachineFunctionPass.h" 25 #include "llvm/CodeGen/MachineJumpTableInfo.h" 26 #include "llvm/CodeGen/MachineRegisterInfo.h" 27 #include "llvm/CodeGen/RegisterScavenging.h" 28 #include "llvm/Target/TargetInstrInfo.h" 29 #include "llvm/Target/TargetMachine.h" 30 #include "llvm/Target/TargetRegisterInfo.h" 31 #include "llvm/Support/CommandLine.h" 32 #include "llvm/Support/Debug.h" 33 #include "llvm/Support/ErrorHandling.h" 34 #include "llvm/Support/raw_ostream.h" 35 #include "llvm/ADT/SmallSet.h" 36 #include "llvm/ADT/SetVector.h" 37 #include "llvm/ADT/Statistic.h" 38 #include "llvm/ADT/STLExtras.h" 39 #include <algorithm> 40 using namespace llvm; 41 42 STATISTIC(NumDeadBlocks, "Number of dead blocks removed"); 43 STATISTIC(NumBranchOpts, "Number of branches optimized"); 44 STATISTIC(NumTailMerge , "Number of block tails merged"); 45 STATISTIC(NumHoist , "Number of times common instructions are hoisted"); 46 47 static cl::opt<cl::boolOrDefault> FlagEnableTailMerge("enable-tail-merge", 48 cl::init(cl::BOU_UNSET), cl::Hidden); 49 50 // Throttle for huge numbers of predecessors (compile speed problems) 51 static cl::opt<unsigned> 52 TailMergeThreshold("tail-merge-threshold", 53 cl::desc("Max number of predecessors to consider tail merging"), 54 cl::init(150), cl::Hidden); 55 56 // Heuristic for tail merging (and, inversely, tail duplication). 57 // TODO: This should be replaced with a target query. 58 static cl::opt<unsigned> 59 TailMergeSize("tail-merge-size", 60 cl::desc("Min number of instructions to consider tail merging"), 61 cl::init(3), cl::Hidden); 62 63 namespace { 64 /// BranchFolderPass - Wrap branch folder in a machine function pass. 65 class BranchFolderPass : public MachineFunctionPass { 66 public: 67 static char ID; 68 explicit BranchFolderPass(): MachineFunctionPass(ID) {} 69 70 virtual bool runOnMachineFunction(MachineFunction &MF); 71 72 virtual void getAnalysisUsage(AnalysisUsage &AU) const { 73 AU.addRequired<TargetPassConfig>(); 74 MachineFunctionPass::getAnalysisUsage(AU); 75 } 76 }; 77 } 78 79 char BranchFolderPass::ID = 0; 80 char &llvm::BranchFolderPassID = BranchFolderPass::ID; 81 82 INITIALIZE_PASS(BranchFolderPass, "branch-folder", 83 "Control Flow Optimizer", false, false) 84 85 bool BranchFolderPass::runOnMachineFunction(MachineFunction &MF) { 86 TargetPassConfig *PassConfig = &getAnalysis<TargetPassConfig>(); 87 BranchFolder Folder(PassConfig->getEnableTailMerge(), /*CommonHoist=*/true); 88 return Folder.OptimizeFunction(MF, 89 MF.getTarget().getInstrInfo(), 90 MF.getTarget().getRegisterInfo(), 91 getAnalysisIfAvailable<MachineModuleInfo>()); 92 } 93 94 95 BranchFolder::BranchFolder(bool defaultEnableTailMerge, bool CommonHoist) { 96 switch (FlagEnableTailMerge) { 97 case cl::BOU_UNSET: EnableTailMerge = defaultEnableTailMerge; break; 98 case cl::BOU_TRUE: EnableTailMerge = true; break; 99 case cl::BOU_FALSE: EnableTailMerge = false; break; 100 } 101 102 EnableHoistCommonCode = CommonHoist; 103 } 104 105 /// RemoveDeadBlock - Remove the specified dead machine basic block from the 106 /// function, updating the CFG. 107 void BranchFolder::RemoveDeadBlock(MachineBasicBlock *MBB) { 108 assert(MBB->pred_empty() && "MBB must be dead!"); 109 DEBUG(dbgs() << "\nRemoving MBB: " << *MBB); 110 111 MachineFunction *MF = MBB->getParent(); 112 // drop all successors. 113 while (!MBB->succ_empty()) 114 MBB->removeSuccessor(MBB->succ_end()-1); 115 116 // Avoid matching if this pointer gets reused. 117 TriedMerging.erase(MBB); 118 119 // Remove the block. 120 MF->erase(MBB); 121 } 122 123 /// OptimizeImpDefsBlock - If a basic block is just a bunch of implicit_def 124 /// followed by terminators, and if the implicitly defined registers are not 125 /// used by the terminators, remove those implicit_def's. e.g. 126 /// BB1: 127 /// r0 = implicit_def 128 /// r1 = implicit_def 129 /// br 130 /// This block can be optimized away later if the implicit instructions are 131 /// removed. 132 bool BranchFolder::OptimizeImpDefsBlock(MachineBasicBlock *MBB) { 133 SmallSet<unsigned, 4> ImpDefRegs; 134 MachineBasicBlock::iterator I = MBB->begin(); 135 while (I != MBB->end()) { 136 if (!I->isImplicitDef()) 137 break; 138 unsigned Reg = I->getOperand(0).getReg(); 139 ImpDefRegs.insert(Reg); 140 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs) 141 ImpDefRegs.insert(*SubRegs); 142 ++I; 143 } 144 if (ImpDefRegs.empty()) 145 return false; 146 147 MachineBasicBlock::iterator FirstTerm = I; 148 while (I != MBB->end()) { 149 if (!TII->isUnpredicatedTerminator(I)) 150 return false; 151 // See if it uses any of the implicitly defined registers. 152 for (unsigned i = 0, e = I->getNumOperands(); i != e; ++i) { 153 MachineOperand &MO = I->getOperand(i); 154 if (!MO.isReg() || !MO.isUse()) 155 continue; 156 unsigned Reg = MO.getReg(); 157 if (ImpDefRegs.count(Reg)) 158 return false; 159 } 160 ++I; 161 } 162 163 I = MBB->begin(); 164 while (I != FirstTerm) { 165 MachineInstr *ImpDefMI = &*I; 166 ++I; 167 MBB->erase(ImpDefMI); 168 } 169 170 return true; 171 } 172 173 /// OptimizeFunction - Perhaps branch folding, tail merging and other 174 /// CFG optimizations on the given function. 175 bool BranchFolder::OptimizeFunction(MachineFunction &MF, 176 const TargetInstrInfo *tii, 177 const TargetRegisterInfo *tri, 178 MachineModuleInfo *mmi) { 179 if (!tii) return false; 180 181 TriedMerging.clear(); 182 183 TII = tii; 184 TRI = tri; 185 MMI = mmi; 186 RS = NULL; 187 188 // Use a RegScavenger to help update liveness when required. 189 MachineRegisterInfo &MRI = MF.getRegInfo(); 190 if (MRI.tracksLiveness() && TRI->trackLivenessAfterRegAlloc(MF)) 191 RS = new RegScavenger(); 192 else 193 MRI.invalidateLiveness(); 194 195 // Fix CFG. The later algorithms expect it to be right. 196 bool MadeChange = false; 197 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; I++) { 198 MachineBasicBlock *MBB = I, *TBB = 0, *FBB = 0; 199 SmallVector<MachineOperand, 4> Cond; 200 if (!TII->AnalyzeBranch(*MBB, TBB, FBB, Cond, true)) 201 MadeChange |= MBB->CorrectExtraCFGEdges(TBB, FBB, !Cond.empty()); 202 MadeChange |= OptimizeImpDefsBlock(MBB); 203 } 204 205 bool MadeChangeThisIteration = true; 206 while (MadeChangeThisIteration) { 207 MadeChangeThisIteration = TailMergeBlocks(MF); 208 MadeChangeThisIteration |= OptimizeBranches(MF); 209 if (EnableHoistCommonCode) 210 MadeChangeThisIteration |= HoistCommonCode(MF); 211 MadeChange |= MadeChangeThisIteration; 212 } 213 214 // See if any jump tables have become dead as the code generator 215 // did its thing. 216 MachineJumpTableInfo *JTI = MF.getJumpTableInfo(); 217 if (JTI == 0) { 218 delete RS; 219 return MadeChange; 220 } 221 222 // Walk the function to find jump tables that are live. 223 BitVector JTIsLive(JTI->getJumpTables().size()); 224 for (MachineFunction::iterator BB = MF.begin(), E = MF.end(); 225 BB != E; ++BB) { 226 for (MachineBasicBlock::iterator I = BB->begin(), E = BB->end(); 227 I != E; ++I) 228 for (unsigned op = 0, e = I->getNumOperands(); op != e; ++op) { 229 MachineOperand &Op = I->getOperand(op); 230 if (!Op.isJTI()) continue; 231 232 // Remember that this JT is live. 233 JTIsLive.set(Op.getIndex()); 234 } 235 } 236 237 // Finally, remove dead jump tables. This happens when the 238 // indirect jump was unreachable (and thus deleted). 239 for (unsigned i = 0, e = JTIsLive.size(); i != e; ++i) 240 if (!JTIsLive.test(i)) { 241 JTI->RemoveJumpTable(i); 242 MadeChange = true; 243 } 244 245 delete RS; 246 return MadeChange; 247 } 248 249 //===----------------------------------------------------------------------===// 250 // Tail Merging of Blocks 251 //===----------------------------------------------------------------------===// 252 253 /// HashMachineInstr - Compute a hash value for MI and its operands. 254 static unsigned HashMachineInstr(const MachineInstr *MI) { 255 unsigned Hash = MI->getOpcode(); 256 for (unsigned i = 0, e = MI->getNumOperands(); i != e; ++i) { 257 const MachineOperand &Op = MI->getOperand(i); 258 259 // Merge in bits from the operand if easy. 260 unsigned OperandHash = 0; 261 switch (Op.getType()) { 262 case MachineOperand::MO_Register: OperandHash = Op.getReg(); break; 263 case MachineOperand::MO_Immediate: OperandHash = Op.getImm(); break; 264 case MachineOperand::MO_MachineBasicBlock: 265 OperandHash = Op.getMBB()->getNumber(); 266 break; 267 case MachineOperand::MO_FrameIndex: 268 case MachineOperand::MO_ConstantPoolIndex: 269 case MachineOperand::MO_JumpTableIndex: 270 OperandHash = Op.getIndex(); 271 break; 272 case MachineOperand::MO_GlobalAddress: 273 case MachineOperand::MO_ExternalSymbol: 274 // Global address / external symbol are too hard, don't bother, but do 275 // pull in the offset. 276 OperandHash = Op.getOffset(); 277 break; 278 default: break; 279 } 280 281 Hash += ((OperandHash << 3) | Op.getType()) << (i&31); 282 } 283 return Hash; 284 } 285 286 /// HashEndOfMBB - Hash the last instruction in the MBB. 287 static unsigned HashEndOfMBB(const MachineBasicBlock *MBB) { 288 MachineBasicBlock::const_iterator I = MBB->end(); 289 if (I == MBB->begin()) 290 return 0; // Empty MBB. 291 292 --I; 293 // Skip debug info so it will not affect codegen. 294 while (I->isDebugValue()) { 295 if (I==MBB->begin()) 296 return 0; // MBB empty except for debug info. 297 --I; 298 } 299 300 return HashMachineInstr(I); 301 } 302 303 /// ComputeCommonTailLength - Given two machine basic blocks, compute the number 304 /// of instructions they actually have in common together at their end. Return 305 /// iterators for the first shared instruction in each block. 306 static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1, 307 MachineBasicBlock *MBB2, 308 MachineBasicBlock::iterator &I1, 309 MachineBasicBlock::iterator &I2) { 310 I1 = MBB1->end(); 311 I2 = MBB2->end(); 312 313 unsigned TailLen = 0; 314 while (I1 != MBB1->begin() && I2 != MBB2->begin()) { 315 --I1; --I2; 316 // Skip debugging pseudos; necessary to avoid changing the code. 317 while (I1->isDebugValue()) { 318 if (I1==MBB1->begin()) { 319 while (I2->isDebugValue()) { 320 if (I2==MBB2->begin()) 321 // I1==DBG at begin; I2==DBG at begin 322 return TailLen; 323 --I2; 324 } 325 ++I2; 326 // I1==DBG at begin; I2==non-DBG, or first of DBGs not at begin 327 return TailLen; 328 } 329 --I1; 330 } 331 // I1==first (untested) non-DBG preceding known match 332 while (I2->isDebugValue()) { 333 if (I2==MBB2->begin()) { 334 ++I1; 335 // I1==non-DBG, or first of DBGs not at begin; I2==DBG at begin 336 return TailLen; 337 } 338 --I2; 339 } 340 // I1, I2==first (untested) non-DBGs preceding known match 341 if (!I1->isIdenticalTo(I2) || 342 // FIXME: This check is dubious. It's used to get around a problem where 343 // people incorrectly expect inline asm directives to remain in the same 344 // relative order. This is untenable because normal compiler 345 // optimizations (like this one) may reorder and/or merge these 346 // directives. 347 I1->isInlineAsm()) { 348 ++I1; ++I2; 349 break; 350 } 351 ++TailLen; 352 } 353 // Back past possible debugging pseudos at beginning of block. This matters 354 // when one block differs from the other only by whether debugging pseudos 355 // are present at the beginning. (This way, the various checks later for 356 // I1==MBB1->begin() work as expected.) 357 if (I1 == MBB1->begin() && I2 != MBB2->begin()) { 358 --I2; 359 while (I2->isDebugValue()) { 360 if (I2 == MBB2->begin()) 361 return TailLen; 362 --I2; 363 } 364 ++I2; 365 } 366 if (I2 == MBB2->begin() && I1 != MBB1->begin()) { 367 --I1; 368 while (I1->isDebugValue()) { 369 if (I1 == MBB1->begin()) 370 return TailLen; 371 --I1; 372 } 373 ++I1; 374 } 375 return TailLen; 376 } 377 378 void BranchFolder::MaintainLiveIns(MachineBasicBlock *CurMBB, 379 MachineBasicBlock *NewMBB) { 380 if (RS) { 381 RS->enterBasicBlock(CurMBB); 382 if (!CurMBB->empty()) 383 RS->forward(prior(CurMBB->end())); 384 BitVector RegsLiveAtExit(TRI->getNumRegs()); 385 RS->getRegsUsed(RegsLiveAtExit, false); 386 for (unsigned int i = 0, e = TRI->getNumRegs(); i != e; i++) 387 if (RegsLiveAtExit[i]) 388 NewMBB->addLiveIn(i); 389 } 390 } 391 392 /// ReplaceTailWithBranchTo - Delete the instruction OldInst and everything 393 /// after it, replacing it with an unconditional branch to NewDest. 394 void BranchFolder::ReplaceTailWithBranchTo(MachineBasicBlock::iterator OldInst, 395 MachineBasicBlock *NewDest) { 396 MachineBasicBlock *CurMBB = OldInst->getParent(); 397 398 TII->ReplaceTailWithBranchTo(OldInst, NewDest); 399 400 // For targets that use the register scavenger, we must maintain LiveIns. 401 MaintainLiveIns(CurMBB, NewDest); 402 403 ++NumTailMerge; 404 } 405 406 /// SplitMBBAt - Given a machine basic block and an iterator into it, split the 407 /// MBB so that the part before the iterator falls into the part starting at the 408 /// iterator. This returns the new MBB. 409 MachineBasicBlock *BranchFolder::SplitMBBAt(MachineBasicBlock &CurMBB, 410 MachineBasicBlock::iterator BBI1) { 411 if (!TII->isLegalToSplitMBBAt(CurMBB, BBI1)) 412 return 0; 413 414 MachineFunction &MF = *CurMBB.getParent(); 415 416 // Create the fall-through block. 417 MachineFunction::iterator MBBI = &CurMBB; 418 MachineBasicBlock *NewMBB =MF.CreateMachineBasicBlock(CurMBB.getBasicBlock()); 419 CurMBB.getParent()->insert(++MBBI, NewMBB); 420 421 // Move all the successors of this block to the specified block. 422 NewMBB->transferSuccessors(&CurMBB); 423 424 // Add an edge from CurMBB to NewMBB for the fall-through. 425 CurMBB.addSuccessor(NewMBB); 426 427 // Splice the code over. 428 NewMBB->splice(NewMBB->end(), &CurMBB, BBI1, CurMBB.end()); 429 430 // For targets that use the register scavenger, we must maintain LiveIns. 431 MaintainLiveIns(&CurMBB, NewMBB); 432 433 return NewMBB; 434 } 435 436 /// EstimateRuntime - Make a rough estimate for how long it will take to run 437 /// the specified code. 438 static unsigned EstimateRuntime(MachineBasicBlock::iterator I, 439 MachineBasicBlock::iterator E) { 440 unsigned Time = 0; 441 for (; I != E; ++I) { 442 if (I->isDebugValue()) 443 continue; 444 if (I->isCall()) 445 Time += 10; 446 else if (I->mayLoad() || I->mayStore()) 447 Time += 2; 448 else 449 ++Time; 450 } 451 return Time; 452 } 453 454 // CurMBB needs to add an unconditional branch to SuccMBB (we removed these 455 // branches temporarily for tail merging). In the case where CurMBB ends 456 // with a conditional branch to the next block, optimize by reversing the 457 // test and conditionally branching to SuccMBB instead. 458 static void FixTail(MachineBasicBlock *CurMBB, MachineBasicBlock *SuccBB, 459 const TargetInstrInfo *TII) { 460 MachineFunction *MF = CurMBB->getParent(); 461 MachineFunction::iterator I = llvm::next(MachineFunction::iterator(CurMBB)); 462 MachineBasicBlock *TBB = 0, *FBB = 0; 463 SmallVector<MachineOperand, 4> Cond; 464 DebugLoc dl; // FIXME: this is nowhere 465 if (I != MF->end() && 466 !TII->AnalyzeBranch(*CurMBB, TBB, FBB, Cond, true)) { 467 MachineBasicBlock *NextBB = I; 468 if (TBB == NextBB && !Cond.empty() && !FBB) { 469 if (!TII->ReverseBranchCondition(Cond)) { 470 TII->RemoveBranch(*CurMBB); 471 TII->InsertBranch(*CurMBB, SuccBB, NULL, Cond, dl); 472 return; 473 } 474 } 475 } 476 TII->InsertBranch(*CurMBB, SuccBB, NULL, 477 SmallVector<MachineOperand, 0>(), dl); 478 } 479 480 bool 481 BranchFolder::MergePotentialsElt::operator<(const MergePotentialsElt &o) const { 482 if (getHash() < o.getHash()) 483 return true; 484 if (getHash() > o.getHash()) 485 return false; 486 if (getBlock()->getNumber() < o.getBlock()->getNumber()) 487 return true; 488 if (getBlock()->getNumber() > o.getBlock()->getNumber()) 489 return false; 490 // _GLIBCXX_DEBUG checks strict weak ordering, which involves comparing 491 // an object with itself. 492 #ifndef _GLIBCXX_DEBUG 493 llvm_unreachable("Predecessor appears twice"); 494 #else 495 return false; 496 #endif 497 } 498 499 /// CountTerminators - Count the number of terminators in the given 500 /// block and set I to the position of the first non-terminator, if there 501 /// is one, or MBB->end() otherwise. 502 static unsigned CountTerminators(MachineBasicBlock *MBB, 503 MachineBasicBlock::iterator &I) { 504 I = MBB->end(); 505 unsigned NumTerms = 0; 506 for (;;) { 507 if (I == MBB->begin()) { 508 I = MBB->end(); 509 break; 510 } 511 --I; 512 if (!I->isTerminator()) break; 513 ++NumTerms; 514 } 515 return NumTerms; 516 } 517 518 /// ProfitableToMerge - Check if two machine basic blocks have a common tail 519 /// and decide if it would be profitable to merge those tails. Return the 520 /// length of the common tail and iterators to the first common instruction 521 /// in each block. 522 static bool ProfitableToMerge(MachineBasicBlock *MBB1, 523 MachineBasicBlock *MBB2, 524 unsigned minCommonTailLength, 525 unsigned &CommonTailLen, 526 MachineBasicBlock::iterator &I1, 527 MachineBasicBlock::iterator &I2, 528 MachineBasicBlock *SuccBB, 529 MachineBasicBlock *PredBB) { 530 CommonTailLen = ComputeCommonTailLength(MBB1, MBB2, I1, I2); 531 if (CommonTailLen == 0) 532 return false; 533 DEBUG(dbgs() << "Common tail length of BB#" << MBB1->getNumber() 534 << " and BB#" << MBB2->getNumber() << " is " << CommonTailLen 535 << '\n'); 536 537 // It's almost always profitable to merge any number of non-terminator 538 // instructions with the block that falls through into the common successor. 539 if (MBB1 == PredBB || MBB2 == PredBB) { 540 MachineBasicBlock::iterator I; 541 unsigned NumTerms = CountTerminators(MBB1 == PredBB ? MBB2 : MBB1, I); 542 if (CommonTailLen > NumTerms) 543 return true; 544 } 545 546 // If one of the blocks can be completely merged and happens to be in 547 // a position where the other could fall through into it, merge any number 548 // of instructions, because it can be done without a branch. 549 // TODO: If the blocks are not adjacent, move one of them so that they are? 550 if (MBB1->isLayoutSuccessor(MBB2) && I2 == MBB2->begin()) 551 return true; 552 if (MBB2->isLayoutSuccessor(MBB1) && I1 == MBB1->begin()) 553 return true; 554 555 // If both blocks have an unconditional branch temporarily stripped out, 556 // count that as an additional common instruction for the following 557 // heuristics. 558 unsigned EffectiveTailLen = CommonTailLen; 559 if (SuccBB && MBB1 != PredBB && MBB2 != PredBB && 560 !MBB1->back().isBarrier() && 561 !MBB2->back().isBarrier()) 562 ++EffectiveTailLen; 563 564 // Check if the common tail is long enough to be worthwhile. 565 if (EffectiveTailLen >= minCommonTailLength) 566 return true; 567 568 // If we are optimizing for code size, 2 instructions in common is enough if 569 // we don't have to split a block. At worst we will be introducing 1 new 570 // branch instruction, which is likely to be smaller than the 2 571 // instructions that would be deleted in the merge. 572 MachineFunction *MF = MBB1->getParent(); 573 if (EffectiveTailLen >= 2 && 574 MF->getFunction()->getFnAttributes(). 575 hasAttribute(Attributes::OptimizeForSize) && 576 (I1 == MBB1->begin() || I2 == MBB2->begin())) 577 return true; 578 579 return false; 580 } 581 582 /// ComputeSameTails - Look through all the blocks in MergePotentials that have 583 /// hash CurHash (guaranteed to match the last element). Build the vector 584 /// SameTails of all those that have the (same) largest number of instructions 585 /// in common of any pair of these blocks. SameTails entries contain an 586 /// iterator into MergePotentials (from which the MachineBasicBlock can be 587 /// found) and a MachineBasicBlock::iterator into that MBB indicating the 588 /// instruction where the matching code sequence begins. 589 /// Order of elements in SameTails is the reverse of the order in which 590 /// those blocks appear in MergePotentials (where they are not necessarily 591 /// consecutive). 592 unsigned BranchFolder::ComputeSameTails(unsigned CurHash, 593 unsigned minCommonTailLength, 594 MachineBasicBlock *SuccBB, 595 MachineBasicBlock *PredBB) { 596 unsigned maxCommonTailLength = 0U; 597 SameTails.clear(); 598 MachineBasicBlock::iterator TrialBBI1, TrialBBI2; 599 MPIterator HighestMPIter = prior(MergePotentials.end()); 600 for (MPIterator CurMPIter = prior(MergePotentials.end()), 601 B = MergePotentials.begin(); 602 CurMPIter != B && CurMPIter->getHash() == CurHash; 603 --CurMPIter) { 604 for (MPIterator I = prior(CurMPIter); I->getHash() == CurHash ; --I) { 605 unsigned CommonTailLen; 606 if (ProfitableToMerge(CurMPIter->getBlock(), I->getBlock(), 607 minCommonTailLength, 608 CommonTailLen, TrialBBI1, TrialBBI2, 609 SuccBB, PredBB)) { 610 if (CommonTailLen > maxCommonTailLength) { 611 SameTails.clear(); 612 maxCommonTailLength = CommonTailLen; 613 HighestMPIter = CurMPIter; 614 SameTails.push_back(SameTailElt(CurMPIter, TrialBBI1)); 615 } 616 if (HighestMPIter == CurMPIter && 617 CommonTailLen == maxCommonTailLength) 618 SameTails.push_back(SameTailElt(I, TrialBBI2)); 619 } 620 if (I == B) 621 break; 622 } 623 } 624 return maxCommonTailLength; 625 } 626 627 /// RemoveBlocksWithHash - Remove all blocks with hash CurHash from 628 /// MergePotentials, restoring branches at ends of blocks as appropriate. 629 void BranchFolder::RemoveBlocksWithHash(unsigned CurHash, 630 MachineBasicBlock *SuccBB, 631 MachineBasicBlock *PredBB) { 632 MPIterator CurMPIter, B; 633 for (CurMPIter = prior(MergePotentials.end()), B = MergePotentials.begin(); 634 CurMPIter->getHash() == CurHash; 635 --CurMPIter) { 636 // Put the unconditional branch back, if we need one. 637 MachineBasicBlock *CurMBB = CurMPIter->getBlock(); 638 if (SuccBB && CurMBB != PredBB) 639 FixTail(CurMBB, SuccBB, TII); 640 if (CurMPIter == B) 641 break; 642 } 643 if (CurMPIter->getHash() != CurHash) 644 CurMPIter++; 645 MergePotentials.erase(CurMPIter, MergePotentials.end()); 646 } 647 648 /// CreateCommonTailOnlyBlock - None of the blocks to be tail-merged consist 649 /// only of the common tail. Create a block that does by splitting one. 650 bool BranchFolder::CreateCommonTailOnlyBlock(MachineBasicBlock *&PredBB, 651 unsigned maxCommonTailLength, 652 unsigned &commonTailIndex) { 653 commonTailIndex = 0; 654 unsigned TimeEstimate = ~0U; 655 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) { 656 // Use PredBB if possible; that doesn't require a new branch. 657 if (SameTails[i].getBlock() == PredBB) { 658 commonTailIndex = i; 659 break; 660 } 661 // Otherwise, make a (fairly bogus) choice based on estimate of 662 // how long it will take the various blocks to execute. 663 unsigned t = EstimateRuntime(SameTails[i].getBlock()->begin(), 664 SameTails[i].getTailStartPos()); 665 if (t <= TimeEstimate) { 666 TimeEstimate = t; 667 commonTailIndex = i; 668 } 669 } 670 671 MachineBasicBlock::iterator BBI = 672 SameTails[commonTailIndex].getTailStartPos(); 673 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); 674 675 // If the common tail includes any debug info we will take it pretty 676 // randomly from one of the inputs. Might be better to remove it? 677 DEBUG(dbgs() << "\nSplitting BB#" << MBB->getNumber() << ", size " 678 << maxCommonTailLength); 679 680 MachineBasicBlock *newMBB = SplitMBBAt(*MBB, BBI); 681 if (!newMBB) { 682 DEBUG(dbgs() << "... failed!"); 683 return false; 684 } 685 686 SameTails[commonTailIndex].setBlock(newMBB); 687 SameTails[commonTailIndex].setTailStartPos(newMBB->begin()); 688 689 // If we split PredBB, newMBB is the new predecessor. 690 if (PredBB == MBB) 691 PredBB = newMBB; 692 693 return true; 694 } 695 696 // See if any of the blocks in MergePotentials (which all have a common single 697 // successor, or all have no successor) can be tail-merged. If there is a 698 // successor, any blocks in MergePotentials that are not tail-merged and 699 // are not immediately before Succ must have an unconditional branch to 700 // Succ added (but the predecessor/successor lists need no adjustment). 701 // The lone predecessor of Succ that falls through into Succ, 702 // if any, is given in PredBB. 703 704 bool BranchFolder::TryTailMergeBlocks(MachineBasicBlock *SuccBB, 705 MachineBasicBlock *PredBB) { 706 bool MadeChange = false; 707 708 // Except for the special cases below, tail-merge if there are at least 709 // this many instructions in common. 710 unsigned minCommonTailLength = TailMergeSize; 711 712 DEBUG(dbgs() << "\nTryTailMergeBlocks: "; 713 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) 714 dbgs() << "BB#" << MergePotentials[i].getBlock()->getNumber() 715 << (i == e-1 ? "" : ", "); 716 dbgs() << "\n"; 717 if (SuccBB) { 718 dbgs() << " with successor BB#" << SuccBB->getNumber() << '\n'; 719 if (PredBB) 720 dbgs() << " which has fall-through from BB#" 721 << PredBB->getNumber() << "\n"; 722 } 723 dbgs() << "Looking for common tails of at least " 724 << minCommonTailLength << " instruction" 725 << (minCommonTailLength == 1 ? "" : "s") << '\n'; 726 ); 727 728 // Sort by hash value so that blocks with identical end sequences sort 729 // together. 730 std::stable_sort(MergePotentials.begin(), MergePotentials.end()); 731 732 // Walk through equivalence sets looking for actual exact matches. 733 while (MergePotentials.size() > 1) { 734 unsigned CurHash = MergePotentials.back().getHash(); 735 736 // Build SameTails, identifying the set of blocks with this hash code 737 // and with the maximum number of instructions in common. 738 unsigned maxCommonTailLength = ComputeSameTails(CurHash, 739 minCommonTailLength, 740 SuccBB, PredBB); 741 742 // If we didn't find any pair that has at least minCommonTailLength 743 // instructions in common, remove all blocks with this hash code and retry. 744 if (SameTails.empty()) { 745 RemoveBlocksWithHash(CurHash, SuccBB, PredBB); 746 continue; 747 } 748 749 // If one of the blocks is the entire common tail (and not the entry 750 // block, which we can't jump to), we can treat all blocks with this same 751 // tail at once. Use PredBB if that is one of the possibilities, as that 752 // will not introduce any extra branches. 753 MachineBasicBlock *EntryBB = MergePotentials.begin()->getBlock()-> 754 getParent()->begin(); 755 unsigned commonTailIndex = SameTails.size(); 756 // If there are two blocks, check to see if one can be made to fall through 757 // into the other. 758 if (SameTails.size() == 2 && 759 SameTails[0].getBlock()->isLayoutSuccessor(SameTails[1].getBlock()) && 760 SameTails[1].tailIsWholeBlock()) 761 commonTailIndex = 1; 762 else if (SameTails.size() == 2 && 763 SameTails[1].getBlock()->isLayoutSuccessor( 764 SameTails[0].getBlock()) && 765 SameTails[0].tailIsWholeBlock()) 766 commonTailIndex = 0; 767 else { 768 // Otherwise just pick one, favoring the fall-through predecessor if 769 // there is one. 770 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) { 771 MachineBasicBlock *MBB = SameTails[i].getBlock(); 772 if (MBB == EntryBB && SameTails[i].tailIsWholeBlock()) 773 continue; 774 if (MBB == PredBB) { 775 commonTailIndex = i; 776 break; 777 } 778 if (SameTails[i].tailIsWholeBlock()) 779 commonTailIndex = i; 780 } 781 } 782 783 if (commonTailIndex == SameTails.size() || 784 (SameTails[commonTailIndex].getBlock() == PredBB && 785 !SameTails[commonTailIndex].tailIsWholeBlock())) { 786 // None of the blocks consist entirely of the common tail. 787 // Split a block so that one does. 788 if (!CreateCommonTailOnlyBlock(PredBB, 789 maxCommonTailLength, commonTailIndex)) { 790 RemoveBlocksWithHash(CurHash, SuccBB, PredBB); 791 continue; 792 } 793 } 794 795 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); 796 // MBB is common tail. Adjust all other BB's to jump to this one. 797 // Traversal must be forwards so erases work. 798 DEBUG(dbgs() << "\nUsing common tail in BB#" << MBB->getNumber() 799 << " for "); 800 for (unsigned int i=0, e = SameTails.size(); i != e; ++i) { 801 if (commonTailIndex == i) 802 continue; 803 DEBUG(dbgs() << "BB#" << SameTails[i].getBlock()->getNumber() 804 << (i == e-1 ? "" : ", ")); 805 // Hack the end off BB i, making it jump to BB commonTailIndex instead. 806 ReplaceTailWithBranchTo(SameTails[i].getTailStartPos(), MBB); 807 // BB i is no longer a predecessor of SuccBB; remove it from the worklist. 808 MergePotentials.erase(SameTails[i].getMPIter()); 809 } 810 DEBUG(dbgs() << "\n"); 811 // We leave commonTailIndex in the worklist in case there are other blocks 812 // that match it with a smaller number of instructions. 813 MadeChange = true; 814 } 815 return MadeChange; 816 } 817 818 bool BranchFolder::TailMergeBlocks(MachineFunction &MF) { 819 bool MadeChange = false; 820 if (!EnableTailMerge) return MadeChange; 821 822 // First find blocks with no successors. 823 MergePotentials.clear(); 824 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); 825 I != E && MergePotentials.size() < TailMergeThreshold; ++I) { 826 if (TriedMerging.count(I)) 827 continue; 828 if (I->succ_empty()) 829 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(I), I)); 830 } 831 832 // If this is a large problem, avoid visiting the same basic blocks 833 // multiple times. 834 if (MergePotentials.size() == TailMergeThreshold) 835 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) 836 TriedMerging.insert(MergePotentials[i].getBlock()); 837 838 // See if we can do any tail merging on those. 839 if (MergePotentials.size() >= 2) 840 MadeChange |= TryTailMergeBlocks(NULL, NULL); 841 842 // Look at blocks (IBB) with multiple predecessors (PBB). 843 // We change each predecessor to a canonical form, by 844 // (1) temporarily removing any unconditional branch from the predecessor 845 // to IBB, and 846 // (2) alter conditional branches so they branch to the other block 847 // not IBB; this may require adding back an unconditional branch to IBB 848 // later, where there wasn't one coming in. E.g. 849 // Bcc IBB 850 // fallthrough to QBB 851 // here becomes 852 // Bncc QBB 853 // with a conceptual B to IBB after that, which never actually exists. 854 // With those changes, we see whether the predecessors' tails match, 855 // and merge them if so. We change things out of canonical form and 856 // back to the way they were later in the process. (OptimizeBranches 857 // would undo some of this, but we can't use it, because we'd get into 858 // a compile-time infinite loop repeatedly doing and undoing the same 859 // transformations.) 860 861 for (MachineFunction::iterator I = llvm::next(MF.begin()), E = MF.end(); 862 I != E; ++I) { 863 if (I->pred_size() < 2) continue; 864 SmallPtrSet<MachineBasicBlock *, 8> UniquePreds; 865 MachineBasicBlock *IBB = I; 866 MachineBasicBlock *PredBB = prior(I); 867 MergePotentials.clear(); 868 for (MachineBasicBlock::pred_iterator P = I->pred_begin(), 869 E2 = I->pred_end(); 870 P != E2 && MergePotentials.size() < TailMergeThreshold; ++P) { 871 MachineBasicBlock *PBB = *P; 872 if (TriedMerging.count(PBB)) 873 continue; 874 875 // Skip blocks that loop to themselves, can't tail merge these. 876 if (PBB == IBB) 877 continue; 878 879 // Visit each predecessor only once. 880 if (!UniquePreds.insert(PBB)) 881 continue; 882 883 // Skip blocks which may jump to a landing pad. Can't tail merge these. 884 if (PBB->getLandingPadSuccessor()) 885 continue; 886 887 MachineBasicBlock *TBB = 0, *FBB = 0; 888 SmallVector<MachineOperand, 4> Cond; 889 if (!TII->AnalyzeBranch(*PBB, TBB, FBB, Cond, true)) { 890 // Failing case: IBB is the target of a cbr, and we cannot reverse the 891 // branch. 892 SmallVector<MachineOperand, 4> NewCond(Cond); 893 if (!Cond.empty() && TBB == IBB) { 894 if (TII->ReverseBranchCondition(NewCond)) 895 continue; 896 // This is the QBB case described above 897 if (!FBB) 898 FBB = llvm::next(MachineFunction::iterator(PBB)); 899 } 900 901 // Failing case: the only way IBB can be reached from PBB is via 902 // exception handling. Happens for landing pads. Would be nice to have 903 // a bit in the edge so we didn't have to do all this. 904 if (IBB->isLandingPad()) { 905 MachineFunction::iterator IP = PBB; IP++; 906 MachineBasicBlock *PredNextBB = NULL; 907 if (IP != MF.end()) 908 PredNextBB = IP; 909 if (TBB == NULL) { 910 if (IBB != PredNextBB) // fallthrough 911 continue; 912 } else if (FBB) { 913 if (TBB != IBB && FBB != IBB) // cbr then ubr 914 continue; 915 } else if (Cond.empty()) { 916 if (TBB != IBB) // ubr 917 continue; 918 } else { 919 if (TBB != IBB && IBB != PredNextBB) // cbr 920 continue; 921 } 922 } 923 924 // Remove the unconditional branch at the end, if any. 925 if (TBB && (Cond.empty() || FBB)) { 926 DebugLoc dl; // FIXME: this is nowhere 927 TII->RemoveBranch(*PBB); 928 if (!Cond.empty()) 929 // reinsert conditional branch only, for now 930 TII->InsertBranch(*PBB, (TBB == IBB) ? FBB : TBB, 0, NewCond, dl); 931 } 932 933 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(PBB), *P)); 934 } 935 } 936 937 // If this is a large problem, avoid visiting the same basic blocks multiple 938 // times. 939 if (MergePotentials.size() == TailMergeThreshold) 940 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) 941 TriedMerging.insert(MergePotentials[i].getBlock()); 942 943 if (MergePotentials.size() >= 2) 944 MadeChange |= TryTailMergeBlocks(IBB, PredBB); 945 946 // Reinsert an unconditional branch if needed. The 1 below can occur as a 947 // result of removing blocks in TryTailMergeBlocks. 948 PredBB = prior(I); // this may have been changed in TryTailMergeBlocks 949 if (MergePotentials.size() == 1 && 950 MergePotentials.begin()->getBlock() != PredBB) 951 FixTail(MergePotentials.begin()->getBlock(), IBB, TII); 952 } 953 954 return MadeChange; 955 } 956 957 //===----------------------------------------------------------------------===// 958 // Branch Optimization 959 //===----------------------------------------------------------------------===// 960 961 bool BranchFolder::OptimizeBranches(MachineFunction &MF) { 962 bool MadeChange = false; 963 964 // Make sure blocks are numbered in order 965 MF.RenumberBlocks(); 966 967 for (MachineFunction::iterator I = llvm::next(MF.begin()), E = MF.end(); 968 I != E; ) { 969 MachineBasicBlock *MBB = I++; 970 MadeChange |= OptimizeBlock(MBB); 971 972 // If it is dead, remove it. 973 if (MBB->pred_empty()) { 974 RemoveDeadBlock(MBB); 975 MadeChange = true; 976 ++NumDeadBlocks; 977 } 978 } 979 return MadeChange; 980 } 981 982 // Blocks should be considered empty if they contain only debug info; 983 // else the debug info would affect codegen. 984 static bool IsEmptyBlock(MachineBasicBlock *MBB) { 985 if (MBB->empty()) 986 return true; 987 for (MachineBasicBlock::iterator MBBI = MBB->begin(), MBBE = MBB->end(); 988 MBBI!=MBBE; ++MBBI) { 989 if (!MBBI->isDebugValue()) 990 return false; 991 } 992 return true; 993 } 994 995 // Blocks with only debug info and branches should be considered the same 996 // as blocks with only branches. 997 static bool IsBranchOnlyBlock(MachineBasicBlock *MBB) { 998 MachineBasicBlock::iterator MBBI, MBBE; 999 for (MBBI = MBB->begin(), MBBE = MBB->end(); MBBI!=MBBE; ++MBBI) { 1000 if (!MBBI->isDebugValue()) 1001 break; 1002 } 1003 return (MBBI->isBranch()); 1004 } 1005 1006 /// IsBetterFallthrough - Return true if it would be clearly better to 1007 /// fall-through to MBB1 than to fall through into MBB2. This has to return 1008 /// a strict ordering, returning true for both (MBB1,MBB2) and (MBB2,MBB1) will 1009 /// result in infinite loops. 1010 static bool IsBetterFallthrough(MachineBasicBlock *MBB1, 1011 MachineBasicBlock *MBB2) { 1012 // Right now, we use a simple heuristic. If MBB2 ends with a call, and 1013 // MBB1 doesn't, we prefer to fall through into MBB1. This allows us to 1014 // optimize branches that branch to either a return block or an assert block 1015 // into a fallthrough to the return. 1016 if (IsEmptyBlock(MBB1) || IsEmptyBlock(MBB2)) return false; 1017 1018 // If there is a clear successor ordering we make sure that one block 1019 // will fall through to the next 1020 if (MBB1->isSuccessor(MBB2)) return true; 1021 if (MBB2->isSuccessor(MBB1)) return false; 1022 1023 // Neither block consists entirely of debug info (per IsEmptyBlock check), 1024 // so we needn't test for falling off the beginning here. 1025 MachineBasicBlock::iterator MBB1I = --MBB1->end(); 1026 while (MBB1I->isDebugValue()) 1027 --MBB1I; 1028 MachineBasicBlock::iterator MBB2I = --MBB2->end(); 1029 while (MBB2I->isDebugValue()) 1030 --MBB2I; 1031 return MBB2I->isCall() && !MBB1I->isCall(); 1032 } 1033 1034 /// getBranchDebugLoc - Find and return, if any, the DebugLoc of the branch 1035 /// instructions on the block. Always use the DebugLoc of the first 1036 /// branching instruction found unless its absent, in which case use the 1037 /// DebugLoc of the second if present. 1038 static DebugLoc getBranchDebugLoc(MachineBasicBlock &MBB) { 1039 MachineBasicBlock::iterator I = MBB.end(); 1040 if (I == MBB.begin()) 1041 return DebugLoc(); 1042 --I; 1043 while (I->isDebugValue() && I != MBB.begin()) 1044 --I; 1045 if (I->isBranch()) 1046 return I->getDebugLoc(); 1047 return DebugLoc(); 1048 } 1049 1050 /// OptimizeBlock - Analyze and optimize control flow related to the specified 1051 /// block. This is never called on the entry block. 1052 bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { 1053 bool MadeChange = false; 1054 MachineFunction &MF = *MBB->getParent(); 1055 ReoptimizeBlock: 1056 1057 MachineFunction::iterator FallThrough = MBB; 1058 ++FallThrough; 1059 1060 // If this block is empty, make everyone use its fall-through, not the block 1061 // explicitly. Landing pads should not do this since the landing-pad table 1062 // points to this block. Blocks with their addresses taken shouldn't be 1063 // optimized away. 1064 if (IsEmptyBlock(MBB) && !MBB->isLandingPad() && !MBB->hasAddressTaken()) { 1065 // Dead block? Leave for cleanup later. 1066 if (MBB->pred_empty()) return MadeChange; 1067 1068 if (FallThrough == MF.end()) { 1069 // TODO: Simplify preds to not branch here if possible! 1070 } else { 1071 // Rewrite all predecessors of the old block to go to the fallthrough 1072 // instead. 1073 while (!MBB->pred_empty()) { 1074 MachineBasicBlock *Pred = *(MBB->pred_end()-1); 1075 Pred->ReplaceUsesOfBlockWith(MBB, FallThrough); 1076 } 1077 // If MBB was the target of a jump table, update jump tables to go to the 1078 // fallthrough instead. 1079 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo()) 1080 MJTI->ReplaceMBBInJumpTables(MBB, FallThrough); 1081 MadeChange = true; 1082 } 1083 return MadeChange; 1084 } 1085 1086 // Check to see if we can simplify the terminator of the block before this 1087 // one. 1088 MachineBasicBlock &PrevBB = *prior(MachineFunction::iterator(MBB)); 1089 1090 MachineBasicBlock *PriorTBB = 0, *PriorFBB = 0; 1091 SmallVector<MachineOperand, 4> PriorCond; 1092 bool PriorUnAnalyzable = 1093 TII->AnalyzeBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, true); 1094 if (!PriorUnAnalyzable) { 1095 // If the CFG for the prior block has extra edges, remove them. 1096 MadeChange |= PrevBB.CorrectExtraCFGEdges(PriorTBB, PriorFBB, 1097 !PriorCond.empty()); 1098 1099 // If the previous branch is conditional and both conditions go to the same 1100 // destination, remove the branch, replacing it with an unconditional one or 1101 // a fall-through. 1102 if (PriorTBB && PriorTBB == PriorFBB) { 1103 DebugLoc dl = getBranchDebugLoc(PrevBB); 1104 TII->RemoveBranch(PrevBB); 1105 PriorCond.clear(); 1106 if (PriorTBB != MBB) 1107 TII->InsertBranch(PrevBB, PriorTBB, 0, PriorCond, dl); 1108 MadeChange = true; 1109 ++NumBranchOpts; 1110 goto ReoptimizeBlock; 1111 } 1112 1113 // If the previous block unconditionally falls through to this block and 1114 // this block has no other predecessors, move the contents of this block 1115 // into the prior block. This doesn't usually happen when SimplifyCFG 1116 // has been used, but it can happen if tail merging splits a fall-through 1117 // predecessor of a block. 1118 // This has to check PrevBB->succ_size() because EH edges are ignored by 1119 // AnalyzeBranch. 1120 if (PriorCond.empty() && !PriorTBB && MBB->pred_size() == 1 && 1121 PrevBB.succ_size() == 1 && 1122 !MBB->hasAddressTaken() && !MBB->isLandingPad()) { 1123 DEBUG(dbgs() << "\nMerging into block: " << PrevBB 1124 << "From MBB: " << *MBB); 1125 // Remove redundant DBG_VALUEs first. 1126 if (PrevBB.begin() != PrevBB.end()) { 1127 MachineBasicBlock::iterator PrevBBIter = PrevBB.end(); 1128 --PrevBBIter; 1129 MachineBasicBlock::iterator MBBIter = MBB->begin(); 1130 // Check if DBG_VALUE at the end of PrevBB is identical to the 1131 // DBG_VALUE at the beginning of MBB. 1132 while (PrevBBIter != PrevBB.begin() && MBBIter != MBB->end() 1133 && PrevBBIter->isDebugValue() && MBBIter->isDebugValue()) { 1134 if (!MBBIter->isIdenticalTo(PrevBBIter)) 1135 break; 1136 MachineInstr *DuplicateDbg = MBBIter; 1137 ++MBBIter; -- PrevBBIter; 1138 DuplicateDbg->eraseFromParent(); 1139 } 1140 } 1141 PrevBB.splice(PrevBB.end(), MBB, MBB->begin(), MBB->end()); 1142 PrevBB.removeSuccessor(PrevBB.succ_begin()); 1143 assert(PrevBB.succ_empty()); 1144 PrevBB.transferSuccessors(MBB); 1145 MadeChange = true; 1146 return MadeChange; 1147 } 1148 1149 // If the previous branch *only* branches to *this* block (conditional or 1150 // not) remove the branch. 1151 if (PriorTBB == MBB && PriorFBB == 0) { 1152 TII->RemoveBranch(PrevBB); 1153 MadeChange = true; 1154 ++NumBranchOpts; 1155 goto ReoptimizeBlock; 1156 } 1157 1158 // If the prior block branches somewhere else on the condition and here if 1159 // the condition is false, remove the uncond second branch. 1160 if (PriorFBB == MBB) { 1161 DebugLoc dl = getBranchDebugLoc(PrevBB); 1162 TII->RemoveBranch(PrevBB); 1163 TII->InsertBranch(PrevBB, PriorTBB, 0, PriorCond, dl); 1164 MadeChange = true; 1165 ++NumBranchOpts; 1166 goto ReoptimizeBlock; 1167 } 1168 1169 // If the prior block branches here on true and somewhere else on false, and 1170 // if the branch condition is reversible, reverse the branch to create a 1171 // fall-through. 1172 if (PriorTBB == MBB) { 1173 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond); 1174 if (!TII->ReverseBranchCondition(NewPriorCond)) { 1175 DebugLoc dl = getBranchDebugLoc(PrevBB); 1176 TII->RemoveBranch(PrevBB); 1177 TII->InsertBranch(PrevBB, PriorFBB, 0, NewPriorCond, dl); 1178 MadeChange = true; 1179 ++NumBranchOpts; 1180 goto ReoptimizeBlock; 1181 } 1182 } 1183 1184 // If this block has no successors (e.g. it is a return block or ends with 1185 // a call to a no-return function like abort or __cxa_throw) and if the pred 1186 // falls through into this block, and if it would otherwise fall through 1187 // into the block after this, move this block to the end of the function. 1188 // 1189 // We consider it more likely that execution will stay in the function (e.g. 1190 // due to loops) than it is to exit it. This asserts in loops etc, moving 1191 // the assert condition out of the loop body. 1192 if (MBB->succ_empty() && !PriorCond.empty() && PriorFBB == 0 && 1193 MachineFunction::iterator(PriorTBB) == FallThrough && 1194 !MBB->canFallThrough()) { 1195 bool DoTransform = true; 1196 1197 // We have to be careful that the succs of PredBB aren't both no-successor 1198 // blocks. If neither have successors and if PredBB is the second from 1199 // last block in the function, we'd just keep swapping the two blocks for 1200 // last. Only do the swap if one is clearly better to fall through than 1201 // the other. 1202 if (FallThrough == --MF.end() && 1203 !IsBetterFallthrough(PriorTBB, MBB)) 1204 DoTransform = false; 1205 1206 if (DoTransform) { 1207 // Reverse the branch so we will fall through on the previous true cond. 1208 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond); 1209 if (!TII->ReverseBranchCondition(NewPriorCond)) { 1210 DEBUG(dbgs() << "\nMoving MBB: " << *MBB 1211 << "To make fallthrough to: " << *PriorTBB << "\n"); 1212 1213 DebugLoc dl = getBranchDebugLoc(PrevBB); 1214 TII->RemoveBranch(PrevBB); 1215 TII->InsertBranch(PrevBB, MBB, 0, NewPriorCond, dl); 1216 1217 // Move this block to the end of the function. 1218 MBB->moveAfter(--MF.end()); 1219 MadeChange = true; 1220 ++NumBranchOpts; 1221 return MadeChange; 1222 } 1223 } 1224 } 1225 } 1226 1227 // Analyze the branch in the current block. 1228 MachineBasicBlock *CurTBB = 0, *CurFBB = 0; 1229 SmallVector<MachineOperand, 4> CurCond; 1230 bool CurUnAnalyzable= TII->AnalyzeBranch(*MBB, CurTBB, CurFBB, CurCond, true); 1231 if (!CurUnAnalyzable) { 1232 // If the CFG for the prior block has extra edges, remove them. 1233 MadeChange |= MBB->CorrectExtraCFGEdges(CurTBB, CurFBB, !CurCond.empty()); 1234 1235 // If this is a two-way branch, and the FBB branches to this block, reverse 1236 // the condition so the single-basic-block loop is faster. Instead of: 1237 // Loop: xxx; jcc Out; jmp Loop 1238 // we want: 1239 // Loop: xxx; jncc Loop; jmp Out 1240 if (CurTBB && CurFBB && CurFBB == MBB && CurTBB != MBB) { 1241 SmallVector<MachineOperand, 4> NewCond(CurCond); 1242 if (!TII->ReverseBranchCondition(NewCond)) { 1243 DebugLoc dl = getBranchDebugLoc(*MBB); 1244 TII->RemoveBranch(*MBB); 1245 TII->InsertBranch(*MBB, CurFBB, CurTBB, NewCond, dl); 1246 MadeChange = true; 1247 ++NumBranchOpts; 1248 goto ReoptimizeBlock; 1249 } 1250 } 1251 1252 // If this branch is the only thing in its block, see if we can forward 1253 // other blocks across it. 1254 if (CurTBB && CurCond.empty() && CurFBB == 0 && 1255 IsBranchOnlyBlock(MBB) && CurTBB != MBB && 1256 !MBB->hasAddressTaken()) { 1257 DebugLoc dl = getBranchDebugLoc(*MBB); 1258 // This block may contain just an unconditional branch. Because there can 1259 // be 'non-branch terminators' in the block, try removing the branch and 1260 // then seeing if the block is empty. 1261 TII->RemoveBranch(*MBB); 1262 // If the only things remaining in the block are debug info, remove these 1263 // as well, so this will behave the same as an empty block in non-debug 1264 // mode. 1265 if (!MBB->empty()) { 1266 bool NonDebugInfoFound = false; 1267 for (MachineBasicBlock::iterator I = MBB->begin(), E = MBB->end(); 1268 I != E; ++I) { 1269 if (!I->isDebugValue()) { 1270 NonDebugInfoFound = true; 1271 break; 1272 } 1273 } 1274 if (!NonDebugInfoFound) 1275 // Make the block empty, losing the debug info (we could probably 1276 // improve this in some cases.) 1277 MBB->erase(MBB->begin(), MBB->end()); 1278 } 1279 // If this block is just an unconditional branch to CurTBB, we can 1280 // usually completely eliminate the block. The only case we cannot 1281 // completely eliminate the block is when the block before this one 1282 // falls through into MBB and we can't understand the prior block's branch 1283 // condition. 1284 if (MBB->empty()) { 1285 bool PredHasNoFallThrough = !PrevBB.canFallThrough(); 1286 if (PredHasNoFallThrough || !PriorUnAnalyzable || 1287 !PrevBB.isSuccessor(MBB)) { 1288 // If the prior block falls through into us, turn it into an 1289 // explicit branch to us to make updates simpler. 1290 if (!PredHasNoFallThrough && PrevBB.isSuccessor(MBB) && 1291 PriorTBB != MBB && PriorFBB != MBB) { 1292 if (PriorTBB == 0) { 1293 assert(PriorCond.empty() && PriorFBB == 0 && 1294 "Bad branch analysis"); 1295 PriorTBB = MBB; 1296 } else { 1297 assert(PriorFBB == 0 && "Machine CFG out of date!"); 1298 PriorFBB = MBB; 1299 } 1300 DebugLoc pdl = getBranchDebugLoc(PrevBB); 1301 TII->RemoveBranch(PrevBB); 1302 TII->InsertBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, pdl); 1303 } 1304 1305 // Iterate through all the predecessors, revectoring each in-turn. 1306 size_t PI = 0; 1307 bool DidChange = false; 1308 bool HasBranchToSelf = false; 1309 while(PI != MBB->pred_size()) { 1310 MachineBasicBlock *PMBB = *(MBB->pred_begin() + PI); 1311 if (PMBB == MBB) { 1312 // If this block has an uncond branch to itself, leave it. 1313 ++PI; 1314 HasBranchToSelf = true; 1315 } else { 1316 DidChange = true; 1317 PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB); 1318 // If this change resulted in PMBB ending in a conditional 1319 // branch where both conditions go to the same destination, 1320 // change this to an unconditional branch (and fix the CFG). 1321 MachineBasicBlock *NewCurTBB = 0, *NewCurFBB = 0; 1322 SmallVector<MachineOperand, 4> NewCurCond; 1323 bool NewCurUnAnalyzable = TII->AnalyzeBranch(*PMBB, NewCurTBB, 1324 NewCurFBB, NewCurCond, true); 1325 if (!NewCurUnAnalyzable && NewCurTBB && NewCurTBB == NewCurFBB) { 1326 DebugLoc pdl = getBranchDebugLoc(*PMBB); 1327 TII->RemoveBranch(*PMBB); 1328 NewCurCond.clear(); 1329 TII->InsertBranch(*PMBB, NewCurTBB, 0, NewCurCond, pdl); 1330 MadeChange = true; 1331 ++NumBranchOpts; 1332 PMBB->CorrectExtraCFGEdges(NewCurTBB, 0, false); 1333 } 1334 } 1335 } 1336 1337 // Change any jumptables to go to the new MBB. 1338 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo()) 1339 MJTI->ReplaceMBBInJumpTables(MBB, CurTBB); 1340 if (DidChange) { 1341 ++NumBranchOpts; 1342 MadeChange = true; 1343 if (!HasBranchToSelf) return MadeChange; 1344 } 1345 } 1346 } 1347 1348 // Add the branch back if the block is more than just an uncond branch. 1349 TII->InsertBranch(*MBB, CurTBB, 0, CurCond, dl); 1350 } 1351 } 1352 1353 // If the prior block doesn't fall through into this block, and if this 1354 // block doesn't fall through into some other block, see if we can find a 1355 // place to move this block where a fall-through will happen. 1356 if (!PrevBB.canFallThrough()) { 1357 1358 // Now we know that there was no fall-through into this block, check to 1359 // see if it has a fall-through into its successor. 1360 bool CurFallsThru = MBB->canFallThrough(); 1361 1362 if (!MBB->isLandingPad()) { 1363 // Check all the predecessors of this block. If one of them has no fall 1364 // throughs, move this block right after it. 1365 for (MachineBasicBlock::pred_iterator PI = MBB->pred_begin(), 1366 E = MBB->pred_end(); PI != E; ++PI) { 1367 // Analyze the branch at the end of the pred. 1368 MachineBasicBlock *PredBB = *PI; 1369 MachineFunction::iterator PredFallthrough = PredBB; ++PredFallthrough; 1370 MachineBasicBlock *PredTBB = 0, *PredFBB = 0; 1371 SmallVector<MachineOperand, 4> PredCond; 1372 if (PredBB != MBB && !PredBB->canFallThrough() && 1373 !TII->AnalyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true) 1374 && (!CurFallsThru || !CurTBB || !CurFBB) 1375 && (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) { 1376 // If the current block doesn't fall through, just move it. 1377 // If the current block can fall through and does not end with a 1378 // conditional branch, we need to append an unconditional jump to 1379 // the (current) next block. To avoid a possible compile-time 1380 // infinite loop, move blocks only backward in this case. 1381 // Also, if there are already 2 branches here, we cannot add a third; 1382 // this means we have the case 1383 // Bcc next 1384 // B elsewhere 1385 // next: 1386 if (CurFallsThru) { 1387 MachineBasicBlock *NextBB = llvm::next(MachineFunction::iterator(MBB)); 1388 CurCond.clear(); 1389 TII->InsertBranch(*MBB, NextBB, 0, CurCond, DebugLoc()); 1390 } 1391 MBB->moveAfter(PredBB); 1392 MadeChange = true; 1393 goto ReoptimizeBlock; 1394 } 1395 } 1396 } 1397 1398 if (!CurFallsThru) { 1399 // Check all successors to see if we can move this block before it. 1400 for (MachineBasicBlock::succ_iterator SI = MBB->succ_begin(), 1401 E = MBB->succ_end(); SI != E; ++SI) { 1402 // Analyze the branch at the end of the block before the succ. 1403 MachineBasicBlock *SuccBB = *SI; 1404 MachineFunction::iterator SuccPrev = SuccBB; --SuccPrev; 1405 1406 // If this block doesn't already fall-through to that successor, and if 1407 // the succ doesn't already have a block that can fall through into it, 1408 // and if the successor isn't an EH destination, we can arrange for the 1409 // fallthrough to happen. 1410 if (SuccBB != MBB && &*SuccPrev != MBB && 1411 !SuccPrev->canFallThrough() && !CurUnAnalyzable && 1412 !SuccBB->isLandingPad()) { 1413 MBB->moveBefore(SuccBB); 1414 MadeChange = true; 1415 goto ReoptimizeBlock; 1416 } 1417 } 1418 1419 // Okay, there is no really great place to put this block. If, however, 1420 // the block before this one would be a fall-through if this block were 1421 // removed, move this block to the end of the function. 1422 MachineBasicBlock *PrevTBB = 0, *PrevFBB = 0; 1423 SmallVector<MachineOperand, 4> PrevCond; 1424 if (FallThrough != MF.end() && 1425 !TII->AnalyzeBranch(PrevBB, PrevTBB, PrevFBB, PrevCond, true) && 1426 PrevBB.isSuccessor(FallThrough)) { 1427 MBB->moveAfter(--MF.end()); 1428 MadeChange = true; 1429 return MadeChange; 1430 } 1431 } 1432 } 1433 1434 return MadeChange; 1435 } 1436 1437 //===----------------------------------------------------------------------===// 1438 // Hoist Common Code 1439 //===----------------------------------------------------------------------===// 1440 1441 /// HoistCommonCode - Hoist common instruction sequences at the start of basic 1442 /// blocks to their common predecessor. 1443 bool BranchFolder::HoistCommonCode(MachineFunction &MF) { 1444 bool MadeChange = false; 1445 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ) { 1446 MachineBasicBlock *MBB = I++; 1447 MadeChange |= HoistCommonCodeInSuccs(MBB); 1448 } 1449 1450 return MadeChange; 1451 } 1452 1453 /// findFalseBlock - BB has a fallthrough. Find its 'false' successor given 1454 /// its 'true' successor. 1455 static MachineBasicBlock *findFalseBlock(MachineBasicBlock *BB, 1456 MachineBasicBlock *TrueBB) { 1457 for (MachineBasicBlock::succ_iterator SI = BB->succ_begin(), 1458 E = BB->succ_end(); SI != E; ++SI) { 1459 MachineBasicBlock *SuccBB = *SI; 1460 if (SuccBB != TrueBB) 1461 return SuccBB; 1462 } 1463 return NULL; 1464 } 1465 1466 /// findHoistingInsertPosAndDeps - Find the location to move common instructions 1467 /// in successors to. The location is usually just before the terminator, 1468 /// however if the terminator is a conditional branch and its previous 1469 /// instruction is the flag setting instruction, the previous instruction is 1470 /// the preferred location. This function also gathers uses and defs of the 1471 /// instructions from the insertion point to the end of the block. The data is 1472 /// used by HoistCommonCodeInSuccs to ensure safety. 1473 static 1474 MachineBasicBlock::iterator findHoistingInsertPosAndDeps(MachineBasicBlock *MBB, 1475 const TargetInstrInfo *TII, 1476 const TargetRegisterInfo *TRI, 1477 SmallSet<unsigned,4> &Uses, 1478 SmallSet<unsigned,4> &Defs) { 1479 MachineBasicBlock::iterator Loc = MBB->getFirstTerminator(); 1480 if (!TII->isUnpredicatedTerminator(Loc)) 1481 return MBB->end(); 1482 1483 for (unsigned i = 0, e = Loc->getNumOperands(); i != e; ++i) { 1484 const MachineOperand &MO = Loc->getOperand(i); 1485 if (!MO.isReg()) 1486 continue; 1487 unsigned Reg = MO.getReg(); 1488 if (!Reg) 1489 continue; 1490 if (MO.isUse()) { 1491 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1492 Uses.insert(*AI); 1493 } else if (!MO.isDead()) 1494 // Don't try to hoist code in the rare case the terminator defines a 1495 // register that is later used. 1496 return MBB->end(); 1497 } 1498 1499 if (Uses.empty()) 1500 return Loc; 1501 if (Loc == MBB->begin()) 1502 return MBB->end(); 1503 1504 // The terminator is probably a conditional branch, try not to separate the 1505 // branch from condition setting instruction. 1506 MachineBasicBlock::iterator PI = Loc; 1507 --PI; 1508 while (PI != MBB->begin() && Loc->isDebugValue()) 1509 --PI; 1510 1511 bool IsDef = false; 1512 for (unsigned i = 0, e = PI->getNumOperands(); !IsDef && i != e; ++i) { 1513 const MachineOperand &MO = PI->getOperand(i); 1514 // If PI has a regmask operand, it is probably a call. Separate away. 1515 if (MO.isRegMask()) 1516 return Loc; 1517 if (!MO.isReg() || MO.isUse()) 1518 continue; 1519 unsigned Reg = MO.getReg(); 1520 if (!Reg) 1521 continue; 1522 if (Uses.count(Reg)) 1523 IsDef = true; 1524 } 1525 if (!IsDef) 1526 // The condition setting instruction is not just before the conditional 1527 // branch. 1528 return Loc; 1529 1530 // Be conservative, don't insert instruction above something that may have 1531 // side-effects. And since it's potentially bad to separate flag setting 1532 // instruction from the conditional branch, just abort the optimization 1533 // completely. 1534 // Also avoid moving code above predicated instruction since it's hard to 1535 // reason about register liveness with predicated instruction. 1536 bool DontMoveAcrossStore = true; 1537 if (!PI->isSafeToMove(TII, 0, DontMoveAcrossStore) || 1538 TII->isPredicated(PI)) 1539 return MBB->end(); 1540 1541 1542 // Find out what registers are live. Note this routine is ignoring other live 1543 // registers which are only used by instructions in successor blocks. 1544 for (unsigned i = 0, e = PI->getNumOperands(); i != e; ++i) { 1545 const MachineOperand &MO = PI->getOperand(i); 1546 if (!MO.isReg()) 1547 continue; 1548 unsigned Reg = MO.getReg(); 1549 if (!Reg) 1550 continue; 1551 if (MO.isUse()) { 1552 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1553 Uses.insert(*AI); 1554 } else { 1555 if (Uses.erase(Reg)) { 1556 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs) 1557 Uses.erase(*SubRegs); // Use sub-registers to be conservative 1558 } 1559 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1560 Defs.insert(*AI); 1561 } 1562 } 1563 1564 return PI; 1565 } 1566 1567 /// HoistCommonCodeInSuccs - If the successors of MBB has common instruction 1568 /// sequence at the start of the function, move the instructions before MBB 1569 /// terminator if it's legal. 1570 bool BranchFolder::HoistCommonCodeInSuccs(MachineBasicBlock *MBB) { 1571 MachineBasicBlock *TBB = 0, *FBB = 0; 1572 SmallVector<MachineOperand, 4> Cond; 1573 if (TII->AnalyzeBranch(*MBB, TBB, FBB, Cond, true) || !TBB || Cond.empty()) 1574 return false; 1575 1576 if (!FBB) FBB = findFalseBlock(MBB, TBB); 1577 if (!FBB) 1578 // Malformed bcc? True and false blocks are the same? 1579 return false; 1580 1581 // Restrict the optimization to cases where MBB is the only predecessor, 1582 // it is an obvious win. 1583 if (TBB->pred_size() > 1 || FBB->pred_size() > 1) 1584 return false; 1585 1586 // Find a suitable position to hoist the common instructions to. Also figure 1587 // out which registers are used or defined by instructions from the insertion 1588 // point to the end of the block. 1589 SmallSet<unsigned, 4> Uses, Defs; 1590 MachineBasicBlock::iterator Loc = 1591 findHoistingInsertPosAndDeps(MBB, TII, TRI, Uses, Defs); 1592 if (Loc == MBB->end()) 1593 return false; 1594 1595 bool HasDups = false; 1596 SmallVector<unsigned, 4> LocalDefs; 1597 SmallSet<unsigned, 4> LocalDefsSet; 1598 MachineBasicBlock::iterator TIB = TBB->begin(); 1599 MachineBasicBlock::iterator FIB = FBB->begin(); 1600 MachineBasicBlock::iterator TIE = TBB->end(); 1601 MachineBasicBlock::iterator FIE = FBB->end(); 1602 while (TIB != TIE && FIB != FIE) { 1603 // Skip dbg_value instructions. These do not count. 1604 if (TIB->isDebugValue()) { 1605 while (TIB != TIE && TIB->isDebugValue()) 1606 ++TIB; 1607 if (TIB == TIE) 1608 break; 1609 } 1610 if (FIB->isDebugValue()) { 1611 while (FIB != FIE && FIB->isDebugValue()) 1612 ++FIB; 1613 if (FIB == FIE) 1614 break; 1615 } 1616 if (!TIB->isIdenticalTo(FIB, MachineInstr::CheckKillDead)) 1617 break; 1618 1619 if (TII->isPredicated(TIB)) 1620 // Hard to reason about register liveness with predicated instruction. 1621 break; 1622 1623 bool IsSafe = true; 1624 for (unsigned i = 0, e = TIB->getNumOperands(); i != e; ++i) { 1625 MachineOperand &MO = TIB->getOperand(i); 1626 // Don't attempt to hoist instructions with register masks. 1627 if (MO.isRegMask()) { 1628 IsSafe = false; 1629 break; 1630 } 1631 if (!MO.isReg()) 1632 continue; 1633 unsigned Reg = MO.getReg(); 1634 if (!Reg) 1635 continue; 1636 if (MO.isDef()) { 1637 if (Uses.count(Reg)) { 1638 // Avoid clobbering a register that's used by the instruction at 1639 // the point of insertion. 1640 IsSafe = false; 1641 break; 1642 } 1643 1644 if (Defs.count(Reg) && !MO.isDead()) { 1645 // Don't hoist the instruction if the def would be clobber by the 1646 // instruction at the point insertion. FIXME: This is overly 1647 // conservative. It should be possible to hoist the instructions 1648 // in BB2 in the following example: 1649 // BB1: 1650 // r1, eflag = op1 r2, r3 1651 // brcc eflag 1652 // 1653 // BB2: 1654 // r1 = op2, ... 1655 // = op3, r1<kill> 1656 IsSafe = false; 1657 break; 1658 } 1659 } else if (!LocalDefsSet.count(Reg)) { 1660 if (Defs.count(Reg)) { 1661 // Use is defined by the instruction at the point of insertion. 1662 IsSafe = false; 1663 break; 1664 } 1665 1666 if (MO.isKill() && Uses.count(Reg)) 1667 // Kills a register that's read by the instruction at the point of 1668 // insertion. Remove the kill marker. 1669 MO.setIsKill(false); 1670 } 1671 } 1672 if (!IsSafe) 1673 break; 1674 1675 bool DontMoveAcrossStore = true; 1676 if (!TIB->isSafeToMove(TII, 0, DontMoveAcrossStore)) 1677 break; 1678 1679 // Remove kills from LocalDefsSet, these registers had short live ranges. 1680 for (unsigned i = 0, e = TIB->getNumOperands(); i != e; ++i) { 1681 MachineOperand &MO = TIB->getOperand(i); 1682 if (!MO.isReg() || !MO.isUse() || !MO.isKill()) 1683 continue; 1684 unsigned Reg = MO.getReg(); 1685 if (!Reg || !LocalDefsSet.count(Reg)) 1686 continue; 1687 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1688 LocalDefsSet.erase(*AI); 1689 } 1690 1691 // Track local defs so we can update liveins. 1692 for (unsigned i = 0, e = TIB->getNumOperands(); i != e; ++i) { 1693 MachineOperand &MO = TIB->getOperand(i); 1694 if (!MO.isReg() || !MO.isDef() || MO.isDead()) 1695 continue; 1696 unsigned Reg = MO.getReg(); 1697 if (!Reg) 1698 continue; 1699 LocalDefs.push_back(Reg); 1700 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1701 LocalDefsSet.insert(*AI); 1702 } 1703 1704 HasDups = true; 1705 ++TIB; 1706 ++FIB; 1707 } 1708 1709 if (!HasDups) 1710 return false; 1711 1712 MBB->splice(Loc, TBB, TBB->begin(), TIB); 1713 FBB->erase(FBB->begin(), FIB); 1714 1715 // Update livein's. 1716 for (unsigned i = 0, e = LocalDefs.size(); i != e; ++i) { 1717 unsigned Def = LocalDefs[i]; 1718 if (LocalDefsSet.count(Def)) { 1719 TBB->addLiveIn(Def); 1720 FBB->addLiveIn(Def); 1721 } 1722 } 1723 1724 ++NumHoist; 1725 return true; 1726 } 1727