1 //===-- BranchFolding.cpp - Fold machine code branch instructions ---------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This pass forwards branches to unconditional branches to make them branch 11 // directly to the target block. This pass often results in dead MBB's, which 12 // it then removes. 13 // 14 // Note that this pass must be run after register allocation, it cannot handle 15 // SSA form. It also must handle virtual registers for targets that emit virtual 16 // ISA (e.g. NVPTX). 17 // 18 //===----------------------------------------------------------------------===// 19 20 #include "BranchFolding.h" 21 #include "llvm/ADT/STLExtras.h" 22 #include "llvm/ADT/SmallSet.h" 23 #include "llvm/ADT/Statistic.h" 24 #include "llvm/CodeGen/Analysis.h" 25 #include "llvm/CodeGen/MachineBlockFrequencyInfo.h" 26 #include "llvm/CodeGen/MachineBranchProbabilityInfo.h" 27 #include "llvm/CodeGen/MachineFunctionPass.h" 28 #include "llvm/CodeGen/MachineJumpTableInfo.h" 29 #include "llvm/CodeGen/MachineMemOperand.h" 30 #include "llvm/CodeGen/MachineLoopInfo.h" 31 #include "llvm/CodeGen/MachineModuleInfo.h" 32 #include "llvm/CodeGen/MachineRegisterInfo.h" 33 #include "llvm/CodeGen/Passes.h" 34 #include "llvm/CodeGen/TargetPassConfig.h" 35 #include "llvm/IR/Function.h" 36 #include "llvm/Support/CommandLine.h" 37 #include "llvm/Support/Debug.h" 38 #include "llvm/Support/ErrorHandling.h" 39 #include "llvm/Support/raw_ostream.h" 40 #include "llvm/Target/TargetInstrInfo.h" 41 #include "llvm/Target/TargetRegisterInfo.h" 42 #include "llvm/Target/TargetSubtargetInfo.h" 43 #include <algorithm> 44 using namespace llvm; 45 46 #define DEBUG_TYPE "branchfolding" 47 48 STATISTIC(NumDeadBlocks, "Number of dead blocks removed"); 49 STATISTIC(NumBranchOpts, "Number of branches optimized"); 50 STATISTIC(NumTailMerge , "Number of block tails merged"); 51 STATISTIC(NumHoist , "Number of times common instructions are hoisted"); 52 STATISTIC(NumTailCalls, "Number of tail calls optimized"); 53 54 static cl::opt<cl::boolOrDefault> FlagEnableTailMerge("enable-tail-merge", 55 cl::init(cl::BOU_UNSET), cl::Hidden); 56 57 // Throttle for huge numbers of predecessors (compile speed problems) 58 static cl::opt<unsigned> 59 TailMergeThreshold("tail-merge-threshold", 60 cl::desc("Max number of predecessors to consider tail merging"), 61 cl::init(150), cl::Hidden); 62 63 // Heuristic for tail merging (and, inversely, tail duplication). 64 // TODO: This should be replaced with a target query. 65 static cl::opt<unsigned> 66 TailMergeSize("tail-merge-size", 67 cl::desc("Min number of instructions to consider tail merging"), 68 cl::init(3), cl::Hidden); 69 70 namespace { 71 /// BranchFolderPass - Wrap branch folder in a machine function pass. 72 class BranchFolderPass : public MachineFunctionPass { 73 public: 74 static char ID; 75 explicit BranchFolderPass(): MachineFunctionPass(ID) {} 76 77 bool runOnMachineFunction(MachineFunction &MF) override; 78 79 void getAnalysisUsage(AnalysisUsage &AU) const override { 80 AU.addRequired<MachineBlockFrequencyInfo>(); 81 AU.addRequired<MachineBranchProbabilityInfo>(); 82 AU.addRequired<TargetPassConfig>(); 83 MachineFunctionPass::getAnalysisUsage(AU); 84 } 85 }; 86 } 87 88 char BranchFolderPass::ID = 0; 89 char &llvm::BranchFolderPassID = BranchFolderPass::ID; 90 91 INITIALIZE_PASS(BranchFolderPass, "branch-folder", 92 "Control Flow Optimizer", false, false) 93 94 bool BranchFolderPass::runOnMachineFunction(MachineFunction &MF) { 95 if (skipFunction(*MF.getFunction())) 96 return false; 97 98 TargetPassConfig *PassConfig = &getAnalysis<TargetPassConfig>(); 99 // TailMerge can create jump into if branches that make CFG irreducible for 100 // HW that requires structurized CFG. 101 bool EnableTailMerge = !MF.getTarget().requiresStructuredCFG() && 102 PassConfig->getEnableTailMerge(); 103 BranchFolder::MBFIWrapper MBBFreqInfo( 104 getAnalysis<MachineBlockFrequencyInfo>()); 105 BranchFolder Folder(EnableTailMerge, /*CommonHoist=*/true, MBBFreqInfo, 106 getAnalysis<MachineBranchProbabilityInfo>()); 107 return Folder.OptimizeFunction(MF, MF.getSubtarget().getInstrInfo(), 108 MF.getSubtarget().getRegisterInfo(), 109 getAnalysisIfAvailable<MachineModuleInfo>()); 110 } 111 112 BranchFolder::BranchFolder(bool defaultEnableTailMerge, bool CommonHoist, 113 MBFIWrapper &FreqInfo, 114 const MachineBranchProbabilityInfo &ProbInfo, 115 unsigned MinTailLength) 116 : EnableHoistCommonCode(CommonHoist), MinCommonTailLength(MinTailLength), 117 MBBFreqInfo(FreqInfo), MBPI(ProbInfo) { 118 if (MinCommonTailLength == 0) 119 MinCommonTailLength = TailMergeSize; 120 switch (FlagEnableTailMerge) { 121 case cl::BOU_UNSET: EnableTailMerge = defaultEnableTailMerge; break; 122 case cl::BOU_TRUE: EnableTailMerge = true; break; 123 case cl::BOU_FALSE: EnableTailMerge = false; break; 124 } 125 } 126 127 /// RemoveDeadBlock - Remove the specified dead machine basic block from the 128 /// function, updating the CFG. 129 void BranchFolder::RemoveDeadBlock(MachineBasicBlock *MBB) { 130 assert(MBB->pred_empty() && "MBB must be dead!"); 131 DEBUG(dbgs() << "\nRemoving MBB: " << *MBB); 132 133 MachineFunction *MF = MBB->getParent(); 134 // drop all successors. 135 while (!MBB->succ_empty()) 136 MBB->removeSuccessor(MBB->succ_end()-1); 137 138 // Avoid matching if this pointer gets reused. 139 TriedMerging.erase(MBB); 140 141 // Remove the block. 142 MF->erase(MBB); 143 FuncletMembership.erase(MBB); 144 if (MLI) 145 MLI->removeBlock(MBB); 146 } 147 148 /// OptimizeFunction - Perhaps branch folding, tail merging and other 149 /// CFG optimizations on the given function. Block placement changes the layout 150 /// and may create new tail merging opportunities. 151 bool BranchFolder::OptimizeFunction(MachineFunction &MF, 152 const TargetInstrInfo *tii, 153 const TargetRegisterInfo *tri, 154 MachineModuleInfo *mmi, 155 MachineLoopInfo *mli, bool AfterPlacement) { 156 if (!tii) return false; 157 158 TriedMerging.clear(); 159 160 AfterBlockPlacement = AfterPlacement; 161 TII = tii; 162 TRI = tri; 163 MMI = mmi; 164 MLI = mli; 165 166 MachineRegisterInfo &MRI = MF.getRegInfo(); 167 UpdateLiveIns = MRI.tracksLiveness() && TRI->trackLivenessAfterRegAlloc(MF); 168 if (!UpdateLiveIns) 169 MRI.invalidateLiveness(); 170 171 // Fix CFG. The later algorithms expect it to be right. 172 bool MadeChange = false; 173 for (MachineBasicBlock &MBB : MF) { 174 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; 175 SmallVector<MachineOperand, 4> Cond; 176 if (!TII->analyzeBranch(MBB, TBB, FBB, Cond, true)) 177 MadeChange |= MBB.CorrectExtraCFGEdges(TBB, FBB, !Cond.empty()); 178 } 179 180 // Recalculate funclet membership. 181 FuncletMembership = getFuncletMembership(MF); 182 183 bool MadeChangeThisIteration = true; 184 while (MadeChangeThisIteration) { 185 MadeChangeThisIteration = TailMergeBlocks(MF); 186 // No need to clean up if tail merging does not change anything after the 187 // block placement. 188 if (!AfterBlockPlacement || MadeChangeThisIteration) 189 MadeChangeThisIteration |= OptimizeBranches(MF); 190 if (EnableHoistCommonCode) 191 MadeChangeThisIteration |= HoistCommonCode(MF); 192 MadeChange |= MadeChangeThisIteration; 193 } 194 195 // See if any jump tables have become dead as the code generator 196 // did its thing. 197 MachineJumpTableInfo *JTI = MF.getJumpTableInfo(); 198 if (!JTI) 199 return MadeChange; 200 201 // Walk the function to find jump tables that are live. 202 BitVector JTIsLive(JTI->getJumpTables().size()); 203 for (const MachineBasicBlock &BB : MF) { 204 for (const MachineInstr &I : BB) 205 for (const MachineOperand &Op : I.operands()) { 206 if (!Op.isJTI()) continue; 207 208 // Remember that this JT is live. 209 JTIsLive.set(Op.getIndex()); 210 } 211 } 212 213 // Finally, remove dead jump tables. This happens when the 214 // indirect jump was unreachable (and thus deleted). 215 for (unsigned i = 0, e = JTIsLive.size(); i != e; ++i) 216 if (!JTIsLive.test(i)) { 217 JTI->RemoveJumpTable(i); 218 MadeChange = true; 219 } 220 221 return MadeChange; 222 } 223 224 //===----------------------------------------------------------------------===// 225 // Tail Merging of Blocks 226 //===----------------------------------------------------------------------===// 227 228 /// HashMachineInstr - Compute a hash value for MI and its operands. 229 static unsigned HashMachineInstr(const MachineInstr &MI) { 230 unsigned Hash = MI.getOpcode(); 231 for (unsigned i = 0, e = MI.getNumOperands(); i != e; ++i) { 232 const MachineOperand &Op = MI.getOperand(i); 233 234 // Merge in bits from the operand if easy. We can't use MachineOperand's 235 // hash_code here because it's not deterministic and we sort by hash value 236 // later. 237 unsigned OperandHash = 0; 238 switch (Op.getType()) { 239 case MachineOperand::MO_Register: 240 OperandHash = Op.getReg(); 241 break; 242 case MachineOperand::MO_Immediate: 243 OperandHash = Op.getImm(); 244 break; 245 case MachineOperand::MO_MachineBasicBlock: 246 OperandHash = Op.getMBB()->getNumber(); 247 break; 248 case MachineOperand::MO_FrameIndex: 249 case MachineOperand::MO_ConstantPoolIndex: 250 case MachineOperand::MO_JumpTableIndex: 251 OperandHash = Op.getIndex(); 252 break; 253 case MachineOperand::MO_GlobalAddress: 254 case MachineOperand::MO_ExternalSymbol: 255 // Global address / external symbol are too hard, don't bother, but do 256 // pull in the offset. 257 OperandHash = Op.getOffset(); 258 break; 259 default: 260 break; 261 } 262 263 Hash += ((OperandHash << 3) | Op.getType()) << (i & 31); 264 } 265 return Hash; 266 } 267 268 /// HashEndOfMBB - Hash the last instruction in the MBB. 269 static unsigned HashEndOfMBB(const MachineBasicBlock &MBB) { 270 MachineBasicBlock::const_iterator I = MBB.getLastNonDebugInstr(); 271 if (I == MBB.end()) 272 return 0; 273 274 return HashMachineInstr(*I); 275 } 276 277 /// ComputeCommonTailLength - Given two machine basic blocks, compute the number 278 /// of instructions they actually have in common together at their end. Return 279 /// iterators for the first shared instruction in each block. 280 static unsigned ComputeCommonTailLength(MachineBasicBlock *MBB1, 281 MachineBasicBlock *MBB2, 282 MachineBasicBlock::iterator &I1, 283 MachineBasicBlock::iterator &I2) { 284 I1 = MBB1->end(); 285 I2 = MBB2->end(); 286 287 unsigned TailLen = 0; 288 while (I1 != MBB1->begin() && I2 != MBB2->begin()) { 289 --I1; --I2; 290 // Skip debugging pseudos; necessary to avoid changing the code. 291 while (I1->isDebugValue()) { 292 if (I1==MBB1->begin()) { 293 while (I2->isDebugValue()) { 294 if (I2==MBB2->begin()) 295 // I1==DBG at begin; I2==DBG at begin 296 return TailLen; 297 --I2; 298 } 299 ++I2; 300 // I1==DBG at begin; I2==non-DBG, or first of DBGs not at begin 301 return TailLen; 302 } 303 --I1; 304 } 305 // I1==first (untested) non-DBG preceding known match 306 while (I2->isDebugValue()) { 307 if (I2==MBB2->begin()) { 308 ++I1; 309 // I1==non-DBG, or first of DBGs not at begin; I2==DBG at begin 310 return TailLen; 311 } 312 --I2; 313 } 314 // I1, I2==first (untested) non-DBGs preceding known match 315 if (!I1->isIdenticalTo(*I2) || 316 // FIXME: This check is dubious. It's used to get around a problem where 317 // people incorrectly expect inline asm directives to remain in the same 318 // relative order. This is untenable because normal compiler 319 // optimizations (like this one) may reorder and/or merge these 320 // directives. 321 I1->isInlineAsm()) { 322 ++I1; ++I2; 323 break; 324 } 325 ++TailLen; 326 } 327 // Back past possible debugging pseudos at beginning of block. This matters 328 // when one block differs from the other only by whether debugging pseudos 329 // are present at the beginning. (This way, the various checks later for 330 // I1==MBB1->begin() work as expected.) 331 if (I1 == MBB1->begin() && I2 != MBB2->begin()) { 332 --I2; 333 while (I2->isDebugValue()) { 334 if (I2 == MBB2->begin()) 335 return TailLen; 336 --I2; 337 } 338 ++I2; 339 } 340 if (I2 == MBB2->begin() && I1 != MBB1->begin()) { 341 --I1; 342 while (I1->isDebugValue()) { 343 if (I1 == MBB1->begin()) 344 return TailLen; 345 --I1; 346 } 347 ++I1; 348 } 349 return TailLen; 350 } 351 352 void BranchFolder::computeLiveIns(MachineBasicBlock &MBB) { 353 if (!UpdateLiveIns) 354 return; 355 356 LiveRegs.init(TRI); 357 LiveRegs.addLiveOutsNoPristines(MBB); 358 for (MachineInstr &MI : make_range(MBB.rbegin(), MBB.rend())) 359 LiveRegs.stepBackward(MI); 360 361 for (unsigned Reg : LiveRegs) { 362 // Skip the register if we are about to add one of its super registers. 363 bool ContainsSuperReg = false; 364 for (MCSuperRegIterator SReg(Reg, TRI); SReg.isValid(); ++SReg) { 365 if (LiveRegs.contains(*SReg)) { 366 ContainsSuperReg = true; 367 break; 368 } 369 } 370 if (ContainsSuperReg) 371 continue; 372 MBB.addLiveIn(Reg); 373 } 374 } 375 376 /// ReplaceTailWithBranchTo - Delete the instruction OldInst and everything 377 /// after it, replacing it with an unconditional branch to NewDest. 378 void BranchFolder::ReplaceTailWithBranchTo(MachineBasicBlock::iterator OldInst, 379 MachineBasicBlock *NewDest) { 380 TII->ReplaceTailWithBranchTo(OldInst, NewDest); 381 382 computeLiveIns(*NewDest); 383 384 ++NumTailMerge; 385 } 386 387 /// SplitMBBAt - Given a machine basic block and an iterator into it, split the 388 /// MBB so that the part before the iterator falls into the part starting at the 389 /// iterator. This returns the new MBB. 390 MachineBasicBlock *BranchFolder::SplitMBBAt(MachineBasicBlock &CurMBB, 391 MachineBasicBlock::iterator BBI1, 392 const BasicBlock *BB) { 393 if (!TII->isLegalToSplitMBBAt(CurMBB, BBI1)) 394 return nullptr; 395 396 MachineFunction &MF = *CurMBB.getParent(); 397 398 // Create the fall-through block. 399 MachineFunction::iterator MBBI = CurMBB.getIterator(); 400 MachineBasicBlock *NewMBB =MF.CreateMachineBasicBlock(BB); 401 CurMBB.getParent()->insert(++MBBI, NewMBB); 402 403 // Move all the successors of this block to the specified block. 404 NewMBB->transferSuccessors(&CurMBB); 405 406 // Add an edge from CurMBB to NewMBB for the fall-through. 407 CurMBB.addSuccessor(NewMBB); 408 409 // Splice the code over. 410 NewMBB->splice(NewMBB->end(), &CurMBB, BBI1, CurMBB.end()); 411 412 // NewMBB belongs to the same loop as CurMBB. 413 if (MLI) 414 if (MachineLoop *ML = MLI->getLoopFor(&CurMBB)) 415 ML->addBasicBlockToLoop(NewMBB, MLI->getBase()); 416 417 // NewMBB inherits CurMBB's block frequency. 418 MBBFreqInfo.setBlockFreq(NewMBB, MBBFreqInfo.getBlockFreq(&CurMBB)); 419 420 computeLiveIns(*NewMBB); 421 422 // Add the new block to the funclet. 423 const auto &FuncletI = FuncletMembership.find(&CurMBB); 424 if (FuncletI != FuncletMembership.end()) { 425 auto n = FuncletI->second; 426 FuncletMembership[NewMBB] = n; 427 } 428 429 return NewMBB; 430 } 431 432 /// EstimateRuntime - Make a rough estimate for how long it will take to run 433 /// the specified code. 434 static unsigned EstimateRuntime(MachineBasicBlock::iterator I, 435 MachineBasicBlock::iterator E) { 436 unsigned Time = 0; 437 for (; I != E; ++I) { 438 if (I->isDebugValue()) 439 continue; 440 if (I->isCall()) 441 Time += 10; 442 else if (I->mayLoad() || I->mayStore()) 443 Time += 2; 444 else 445 ++Time; 446 } 447 return Time; 448 } 449 450 // CurMBB needs to add an unconditional branch to SuccMBB (we removed these 451 // branches temporarily for tail merging). In the case where CurMBB ends 452 // with a conditional branch to the next block, optimize by reversing the 453 // test and conditionally branching to SuccMBB instead. 454 static void FixTail(MachineBasicBlock *CurMBB, MachineBasicBlock *SuccBB, 455 const TargetInstrInfo *TII) { 456 MachineFunction *MF = CurMBB->getParent(); 457 MachineFunction::iterator I = std::next(MachineFunction::iterator(CurMBB)); 458 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; 459 SmallVector<MachineOperand, 4> Cond; 460 DebugLoc dl; // FIXME: this is nowhere 461 if (I != MF->end() && !TII->analyzeBranch(*CurMBB, TBB, FBB, Cond, true)) { 462 MachineBasicBlock *NextBB = &*I; 463 if (TBB == NextBB && !Cond.empty() && !FBB) { 464 if (!TII->reverseBranchCondition(Cond)) { 465 TII->removeBranch(*CurMBB); 466 TII->insertBranch(*CurMBB, SuccBB, nullptr, Cond, dl); 467 return; 468 } 469 } 470 } 471 TII->insertBranch(*CurMBB, SuccBB, nullptr, 472 SmallVector<MachineOperand, 0>(), dl); 473 } 474 475 bool 476 BranchFolder::MergePotentialsElt::operator<(const MergePotentialsElt &o) const { 477 if (getHash() < o.getHash()) 478 return true; 479 if (getHash() > o.getHash()) 480 return false; 481 if (getBlock()->getNumber() < o.getBlock()->getNumber()) 482 return true; 483 if (getBlock()->getNumber() > o.getBlock()->getNumber()) 484 return false; 485 // _GLIBCXX_DEBUG checks strict weak ordering, which involves comparing 486 // an object with itself. 487 #ifndef _GLIBCXX_DEBUG 488 llvm_unreachable("Predecessor appears twice"); 489 #else 490 return false; 491 #endif 492 } 493 494 BlockFrequency 495 BranchFolder::MBFIWrapper::getBlockFreq(const MachineBasicBlock *MBB) const { 496 auto I = MergedBBFreq.find(MBB); 497 498 if (I != MergedBBFreq.end()) 499 return I->second; 500 501 return MBFI.getBlockFreq(MBB); 502 } 503 504 void BranchFolder::MBFIWrapper::setBlockFreq(const MachineBasicBlock *MBB, 505 BlockFrequency F) { 506 MergedBBFreq[MBB] = F; 507 } 508 509 raw_ostream & 510 BranchFolder::MBFIWrapper::printBlockFreq(raw_ostream &OS, 511 const MachineBasicBlock *MBB) const { 512 return MBFI.printBlockFreq(OS, getBlockFreq(MBB)); 513 } 514 515 raw_ostream & 516 BranchFolder::MBFIWrapper::printBlockFreq(raw_ostream &OS, 517 const BlockFrequency Freq) const { 518 return MBFI.printBlockFreq(OS, Freq); 519 } 520 521 /// CountTerminators - Count the number of terminators in the given 522 /// block and set I to the position of the first non-terminator, if there 523 /// is one, or MBB->end() otherwise. 524 static unsigned CountTerminators(MachineBasicBlock *MBB, 525 MachineBasicBlock::iterator &I) { 526 I = MBB->end(); 527 unsigned NumTerms = 0; 528 for (;;) { 529 if (I == MBB->begin()) { 530 I = MBB->end(); 531 break; 532 } 533 --I; 534 if (!I->isTerminator()) break; 535 ++NumTerms; 536 } 537 return NumTerms; 538 } 539 540 /// ProfitableToMerge - Check if two machine basic blocks have a common tail 541 /// and decide if it would be profitable to merge those tails. Return the 542 /// length of the common tail and iterators to the first common instruction 543 /// in each block. 544 /// MBB1, MBB2 The blocks to check 545 /// MinCommonTailLength Minimum size of tail block to be merged. 546 /// CommonTailLen Out parameter to record the size of the shared tail between 547 /// MBB1 and MBB2 548 /// I1, I2 Iterator references that will be changed to point to the first 549 /// instruction in the common tail shared by MBB1,MBB2 550 /// SuccBB A common successor of MBB1, MBB2 which are in a canonical form 551 /// relative to SuccBB 552 /// PredBB The layout predecessor of SuccBB, if any. 553 /// FuncletMembership map from block to funclet #. 554 /// AfterPlacement True if we are merging blocks after layout. Stricter 555 /// thresholds apply to prevent undoing tail-duplication. 556 static bool 557 ProfitableToMerge(MachineBasicBlock *MBB1, MachineBasicBlock *MBB2, 558 unsigned MinCommonTailLength, unsigned &CommonTailLen, 559 MachineBasicBlock::iterator &I1, 560 MachineBasicBlock::iterator &I2, MachineBasicBlock *SuccBB, 561 MachineBasicBlock *PredBB, 562 DenseMap<const MachineBasicBlock *, int> &FuncletMembership, 563 bool AfterPlacement) { 564 // It is never profitable to tail-merge blocks from two different funclets. 565 if (!FuncletMembership.empty()) { 566 auto Funclet1 = FuncletMembership.find(MBB1); 567 assert(Funclet1 != FuncletMembership.end()); 568 auto Funclet2 = FuncletMembership.find(MBB2); 569 assert(Funclet2 != FuncletMembership.end()); 570 if (Funclet1->second != Funclet2->second) 571 return false; 572 } 573 574 CommonTailLen = ComputeCommonTailLength(MBB1, MBB2, I1, I2); 575 if (CommonTailLen == 0) 576 return false; 577 DEBUG(dbgs() << "Common tail length of BB#" << MBB1->getNumber() 578 << " and BB#" << MBB2->getNumber() << " is " << CommonTailLen 579 << '\n'); 580 581 // It's almost always profitable to merge any number of non-terminator 582 // instructions with the block that falls through into the common successor. 583 // This is true only for a single successor. For multiple successors, we are 584 // trading a conditional branch for an unconditional one. 585 // TODO: Re-visit successor size for non-layout tail merging. 586 if ((MBB1 == PredBB || MBB2 == PredBB) && 587 (!AfterPlacement || MBB1->succ_size() == 1)) { 588 MachineBasicBlock::iterator I; 589 unsigned NumTerms = CountTerminators(MBB1 == PredBB ? MBB2 : MBB1, I); 590 if (CommonTailLen > NumTerms) 591 return true; 592 } 593 594 // If one of the blocks can be completely merged and happens to be in 595 // a position where the other could fall through into it, merge any number 596 // of instructions, because it can be done without a branch. 597 // TODO: If the blocks are not adjacent, move one of them so that they are? 598 if (MBB1->isLayoutSuccessor(MBB2) && I2 == MBB2->begin()) 599 return true; 600 if (MBB2->isLayoutSuccessor(MBB1) && I1 == MBB1->begin()) 601 return true; 602 603 // If both blocks have an unconditional branch temporarily stripped out, 604 // count that as an additional common instruction for the following 605 // heuristics. This heuristic is only accurate for single-succ blocks, so to 606 // make sure that during layout merging and duplicating don't crash, we check 607 // for that when merging during layout. 608 unsigned EffectiveTailLen = CommonTailLen; 609 if (SuccBB && MBB1 != PredBB && MBB2 != PredBB && 610 (MBB1->succ_size() == 1 || !AfterPlacement) && 611 !MBB1->back().isBarrier() && 612 !MBB2->back().isBarrier()) 613 ++EffectiveTailLen; 614 615 // Check if the common tail is long enough to be worthwhile. 616 if (EffectiveTailLen >= MinCommonTailLength) 617 return true; 618 619 // If we are optimizing for code size, 2 instructions in common is enough if 620 // we don't have to split a block. At worst we will be introducing 1 new 621 // branch instruction, which is likely to be smaller than the 2 622 // instructions that would be deleted in the merge. 623 MachineFunction *MF = MBB1->getParent(); 624 return EffectiveTailLen >= 2 && MF->getFunction()->optForSize() && 625 (I1 == MBB1->begin() || I2 == MBB2->begin()); 626 } 627 628 /// ComputeSameTails - Look through all the blocks in MergePotentials that have 629 /// hash CurHash (guaranteed to match the last element). Build the vector 630 /// SameTails of all those that have the (same) largest number of instructions 631 /// in common of any pair of these blocks. SameTails entries contain an 632 /// iterator into MergePotentials (from which the MachineBasicBlock can be 633 /// found) and a MachineBasicBlock::iterator into that MBB indicating the 634 /// instruction where the matching code sequence begins. 635 /// Order of elements in SameTails is the reverse of the order in which 636 /// those blocks appear in MergePotentials (where they are not necessarily 637 /// consecutive). 638 unsigned BranchFolder::ComputeSameTails(unsigned CurHash, 639 unsigned MinCommonTailLength, 640 MachineBasicBlock *SuccBB, 641 MachineBasicBlock *PredBB) { 642 unsigned maxCommonTailLength = 0U; 643 SameTails.clear(); 644 MachineBasicBlock::iterator TrialBBI1, TrialBBI2; 645 MPIterator HighestMPIter = std::prev(MergePotentials.end()); 646 for (MPIterator CurMPIter = std::prev(MergePotentials.end()), 647 B = MergePotentials.begin(); 648 CurMPIter != B && CurMPIter->getHash() == CurHash; --CurMPIter) { 649 for (MPIterator I = std::prev(CurMPIter); I->getHash() == CurHash; --I) { 650 unsigned CommonTailLen; 651 if (ProfitableToMerge(CurMPIter->getBlock(), I->getBlock(), 652 MinCommonTailLength, 653 CommonTailLen, TrialBBI1, TrialBBI2, 654 SuccBB, PredBB, 655 FuncletMembership, 656 AfterBlockPlacement)) { 657 if (CommonTailLen > maxCommonTailLength) { 658 SameTails.clear(); 659 maxCommonTailLength = CommonTailLen; 660 HighestMPIter = CurMPIter; 661 SameTails.push_back(SameTailElt(CurMPIter, TrialBBI1)); 662 } 663 if (HighestMPIter == CurMPIter && 664 CommonTailLen == maxCommonTailLength) 665 SameTails.push_back(SameTailElt(I, TrialBBI2)); 666 } 667 if (I == B) 668 break; 669 } 670 } 671 return maxCommonTailLength; 672 } 673 674 /// RemoveBlocksWithHash - Remove all blocks with hash CurHash from 675 /// MergePotentials, restoring branches at ends of blocks as appropriate. 676 void BranchFolder::RemoveBlocksWithHash(unsigned CurHash, 677 MachineBasicBlock *SuccBB, 678 MachineBasicBlock *PredBB) { 679 MPIterator CurMPIter, B; 680 for (CurMPIter = std::prev(MergePotentials.end()), 681 B = MergePotentials.begin(); 682 CurMPIter->getHash() == CurHash; --CurMPIter) { 683 // Put the unconditional branch back, if we need one. 684 MachineBasicBlock *CurMBB = CurMPIter->getBlock(); 685 if (SuccBB && CurMBB != PredBB) 686 FixTail(CurMBB, SuccBB, TII); 687 if (CurMPIter == B) 688 break; 689 } 690 if (CurMPIter->getHash() != CurHash) 691 CurMPIter++; 692 MergePotentials.erase(CurMPIter, MergePotentials.end()); 693 } 694 695 /// CreateCommonTailOnlyBlock - None of the blocks to be tail-merged consist 696 /// only of the common tail. Create a block that does by splitting one. 697 bool BranchFolder::CreateCommonTailOnlyBlock(MachineBasicBlock *&PredBB, 698 MachineBasicBlock *SuccBB, 699 unsigned maxCommonTailLength, 700 unsigned &commonTailIndex) { 701 commonTailIndex = 0; 702 unsigned TimeEstimate = ~0U; 703 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) { 704 // Use PredBB if possible; that doesn't require a new branch. 705 if (SameTails[i].getBlock() == PredBB) { 706 commonTailIndex = i; 707 break; 708 } 709 // Otherwise, make a (fairly bogus) choice based on estimate of 710 // how long it will take the various blocks to execute. 711 unsigned t = EstimateRuntime(SameTails[i].getBlock()->begin(), 712 SameTails[i].getTailStartPos()); 713 if (t <= TimeEstimate) { 714 TimeEstimate = t; 715 commonTailIndex = i; 716 } 717 } 718 719 MachineBasicBlock::iterator BBI = 720 SameTails[commonTailIndex].getTailStartPos(); 721 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); 722 723 // If the common tail includes any debug info we will take it pretty 724 // randomly from one of the inputs. Might be better to remove it? 725 DEBUG(dbgs() << "\nSplitting BB#" << MBB->getNumber() << ", size " 726 << maxCommonTailLength); 727 728 // If the split block unconditionally falls-thru to SuccBB, it will be 729 // merged. In control flow terms it should then take SuccBB's name. e.g. If 730 // SuccBB is an inner loop, the common tail is still part of the inner loop. 731 const BasicBlock *BB = (SuccBB && MBB->succ_size() == 1) ? 732 SuccBB->getBasicBlock() : MBB->getBasicBlock(); 733 MachineBasicBlock *newMBB = SplitMBBAt(*MBB, BBI, BB); 734 if (!newMBB) { 735 DEBUG(dbgs() << "... failed!"); 736 return false; 737 } 738 739 SameTails[commonTailIndex].setBlock(newMBB); 740 SameTails[commonTailIndex].setTailStartPos(newMBB->begin()); 741 742 // If we split PredBB, newMBB is the new predecessor. 743 if (PredBB == MBB) 744 PredBB = newMBB; 745 746 return true; 747 } 748 749 static void 750 mergeOperations(MachineBasicBlock::iterator MBBIStartPos, 751 MachineBasicBlock &MBBCommon) { 752 MachineBasicBlock *MBB = MBBIStartPos->getParent(); 753 // Note CommonTailLen does not necessarily matches the size of 754 // the common BB nor all its instructions because of debug 755 // instructions differences. 756 unsigned CommonTailLen = 0; 757 for (auto E = MBB->end(); MBBIStartPos != E; ++MBBIStartPos) 758 ++CommonTailLen; 759 760 MachineBasicBlock::reverse_iterator MBBI = MBB->rbegin(); 761 MachineBasicBlock::reverse_iterator MBBIE = MBB->rend(); 762 MachineBasicBlock::reverse_iterator MBBICommon = MBBCommon.rbegin(); 763 MachineBasicBlock::reverse_iterator MBBIECommon = MBBCommon.rend(); 764 765 while (CommonTailLen--) { 766 assert(MBBI != MBBIE && "Reached BB end within common tail length!"); 767 (void)MBBIE; 768 769 if (MBBI->isDebugValue()) { 770 ++MBBI; 771 continue; 772 } 773 774 while ((MBBICommon != MBBIECommon) && MBBICommon->isDebugValue()) 775 ++MBBICommon; 776 777 assert(MBBICommon != MBBIECommon && 778 "Reached BB end within common tail length!"); 779 assert(MBBICommon->isIdenticalTo(*MBBI) && "Expected matching MIIs!"); 780 781 // Merge MMOs from memory operations in the common block. 782 if (MBBICommon->mayLoad() || MBBICommon->mayStore()) 783 MBBICommon->setMemRefs(MBBICommon->mergeMemRefsWith(*MBBI)); 784 // Drop undef flags if they aren't present in all merged instructions. 785 for (unsigned I = 0, E = MBBICommon->getNumOperands(); I != E; ++I) { 786 MachineOperand &MO = MBBICommon->getOperand(I); 787 if (MO.isReg() && MO.isUndef()) { 788 const MachineOperand &OtherMO = MBBI->getOperand(I); 789 if (!OtherMO.isUndef()) 790 MO.setIsUndef(false); 791 } 792 } 793 794 ++MBBI; 795 ++MBBICommon; 796 } 797 } 798 799 // See if any of the blocks in MergePotentials (which all have SuccBB as a 800 // successor, or all have no successor if it is null) can be tail-merged. 801 // If there is a successor, any blocks in MergePotentials that are not 802 // tail-merged and are not immediately before Succ must have an unconditional 803 // branch to Succ added (but the predecessor/successor lists need no 804 // adjustment). The lone predecessor of Succ that falls through into Succ, 805 // if any, is given in PredBB. 806 // MinCommonTailLength - Except for the special cases below, tail-merge if 807 // there are at least this many instructions in common. 808 bool BranchFolder::TryTailMergeBlocks(MachineBasicBlock *SuccBB, 809 MachineBasicBlock *PredBB, 810 unsigned MinCommonTailLength) { 811 bool MadeChange = false; 812 813 DEBUG(dbgs() << "\nTryTailMergeBlocks: "; 814 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) 815 dbgs() << "BB#" << MergePotentials[i].getBlock()->getNumber() 816 << (i == e-1 ? "" : ", "); 817 dbgs() << "\n"; 818 if (SuccBB) { 819 dbgs() << " with successor BB#" << SuccBB->getNumber() << '\n'; 820 if (PredBB) 821 dbgs() << " which has fall-through from BB#" 822 << PredBB->getNumber() << "\n"; 823 } 824 dbgs() << "Looking for common tails of at least " 825 << MinCommonTailLength << " instruction" 826 << (MinCommonTailLength == 1 ? "" : "s") << '\n'; 827 ); 828 829 // Sort by hash value so that blocks with identical end sequences sort 830 // together. 831 array_pod_sort(MergePotentials.begin(), MergePotentials.end()); 832 833 // Walk through equivalence sets looking for actual exact matches. 834 while (MergePotentials.size() > 1) { 835 unsigned CurHash = MergePotentials.back().getHash(); 836 837 // Build SameTails, identifying the set of blocks with this hash code 838 // and with the maximum number of instructions in common. 839 unsigned maxCommonTailLength = ComputeSameTails(CurHash, 840 MinCommonTailLength, 841 SuccBB, PredBB); 842 843 // If we didn't find any pair that has at least MinCommonTailLength 844 // instructions in common, remove all blocks with this hash code and retry. 845 if (SameTails.empty()) { 846 RemoveBlocksWithHash(CurHash, SuccBB, PredBB); 847 continue; 848 } 849 850 // If one of the blocks is the entire common tail (and not the entry 851 // block, which we can't jump to), we can treat all blocks with this same 852 // tail at once. Use PredBB if that is one of the possibilities, as that 853 // will not introduce any extra branches. 854 MachineBasicBlock *EntryBB = 855 &MergePotentials.front().getBlock()->getParent()->front(); 856 unsigned commonTailIndex = SameTails.size(); 857 // If there are two blocks, check to see if one can be made to fall through 858 // into the other. 859 if (SameTails.size() == 2 && 860 SameTails[0].getBlock()->isLayoutSuccessor(SameTails[1].getBlock()) && 861 SameTails[1].tailIsWholeBlock()) 862 commonTailIndex = 1; 863 else if (SameTails.size() == 2 && 864 SameTails[1].getBlock()->isLayoutSuccessor( 865 SameTails[0].getBlock()) && 866 SameTails[0].tailIsWholeBlock()) 867 commonTailIndex = 0; 868 else { 869 // Otherwise just pick one, favoring the fall-through predecessor if 870 // there is one. 871 for (unsigned i = 0, e = SameTails.size(); i != e; ++i) { 872 MachineBasicBlock *MBB = SameTails[i].getBlock(); 873 if (MBB == EntryBB && SameTails[i].tailIsWholeBlock()) 874 continue; 875 if (MBB == PredBB) { 876 commonTailIndex = i; 877 break; 878 } 879 if (SameTails[i].tailIsWholeBlock()) 880 commonTailIndex = i; 881 } 882 } 883 884 if (commonTailIndex == SameTails.size() || 885 (SameTails[commonTailIndex].getBlock() == PredBB && 886 !SameTails[commonTailIndex].tailIsWholeBlock())) { 887 // None of the blocks consist entirely of the common tail. 888 // Split a block so that one does. 889 if (!CreateCommonTailOnlyBlock(PredBB, SuccBB, 890 maxCommonTailLength, commonTailIndex)) { 891 RemoveBlocksWithHash(CurHash, SuccBB, PredBB); 892 continue; 893 } 894 } 895 896 MachineBasicBlock *MBB = SameTails[commonTailIndex].getBlock(); 897 898 // Recompute common tail MBB's edge weights and block frequency. 899 setCommonTailEdgeWeights(*MBB); 900 901 // MBB is common tail. Adjust all other BB's to jump to this one. 902 // Traversal must be forwards so erases work. 903 DEBUG(dbgs() << "\nUsing common tail in BB#" << MBB->getNumber() 904 << " for "); 905 for (unsigned int i=0, e = SameTails.size(); i != e; ++i) { 906 if (commonTailIndex == i) 907 continue; 908 DEBUG(dbgs() << "BB#" << SameTails[i].getBlock()->getNumber() 909 << (i == e-1 ? "" : ", ")); 910 // Merge operations (MMOs, undef flags) 911 mergeOperations(SameTails[i].getTailStartPos(), *MBB); 912 // Hack the end off BB i, making it jump to BB commonTailIndex instead. 913 ReplaceTailWithBranchTo(SameTails[i].getTailStartPos(), MBB); 914 // BB i is no longer a predecessor of SuccBB; remove it from the worklist. 915 MergePotentials.erase(SameTails[i].getMPIter()); 916 } 917 DEBUG(dbgs() << "\n"); 918 // We leave commonTailIndex in the worklist in case there are other blocks 919 // that match it with a smaller number of instructions. 920 MadeChange = true; 921 } 922 return MadeChange; 923 } 924 925 bool BranchFolder::TailMergeBlocks(MachineFunction &MF) { 926 bool MadeChange = false; 927 if (!EnableTailMerge) return MadeChange; 928 929 // First find blocks with no successors. 930 // Block placement does not create new tail merging opportunities for these 931 // blocks. 932 if (!AfterBlockPlacement) { 933 MergePotentials.clear(); 934 for (MachineBasicBlock &MBB : MF) { 935 if (MergePotentials.size() == TailMergeThreshold) 936 break; 937 if (!TriedMerging.count(&MBB) && MBB.succ_empty()) 938 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(MBB), &MBB)); 939 } 940 941 // If this is a large problem, avoid visiting the same basic blocks 942 // multiple times. 943 if (MergePotentials.size() == TailMergeThreshold) 944 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) 945 TriedMerging.insert(MergePotentials[i].getBlock()); 946 947 // See if we can do any tail merging on those. 948 if (MergePotentials.size() >= 2) 949 MadeChange |= TryTailMergeBlocks(nullptr, nullptr, MinCommonTailLength); 950 } 951 952 // Look at blocks (IBB) with multiple predecessors (PBB). 953 // We change each predecessor to a canonical form, by 954 // (1) temporarily removing any unconditional branch from the predecessor 955 // to IBB, and 956 // (2) alter conditional branches so they branch to the other block 957 // not IBB; this may require adding back an unconditional branch to IBB 958 // later, where there wasn't one coming in. E.g. 959 // Bcc IBB 960 // fallthrough to QBB 961 // here becomes 962 // Bncc QBB 963 // with a conceptual B to IBB after that, which never actually exists. 964 // With those changes, we see whether the predecessors' tails match, 965 // and merge them if so. We change things out of canonical form and 966 // back to the way they were later in the process. (OptimizeBranches 967 // would undo some of this, but we can't use it, because we'd get into 968 // a compile-time infinite loop repeatedly doing and undoing the same 969 // transformations.) 970 971 for (MachineFunction::iterator I = std::next(MF.begin()), E = MF.end(); 972 I != E; ++I) { 973 if (I->pred_size() < 2) continue; 974 SmallPtrSet<MachineBasicBlock *, 8> UniquePreds; 975 MachineBasicBlock *IBB = &*I; 976 MachineBasicBlock *PredBB = &*std::prev(I); 977 MergePotentials.clear(); 978 MachineLoop *ML; 979 980 // Bail if merging after placement and IBB is the loop header because 981 // -- If merging predecessors that belong to the same loop as IBB, the 982 // common tail of merged predecessors may become the loop top if block 983 // placement is called again and the predecessors may branch to this common 984 // tail and require more branches. This can be relaxed if 985 // MachineBlockPlacement::findBestLoopTop is more flexible. 986 // --If merging predecessors that do not belong to the same loop as IBB, the 987 // loop info of IBB's loop and the other loops may be affected. Calling the 988 // block placement again may make big change to the layout and eliminate the 989 // reason to do tail merging here. 990 if (AfterBlockPlacement && MLI) { 991 ML = MLI->getLoopFor(IBB); 992 if (ML && IBB == ML->getHeader()) 993 continue; 994 } 995 996 for (MachineBasicBlock *PBB : I->predecessors()) { 997 if (MergePotentials.size() == TailMergeThreshold) 998 break; 999 1000 if (TriedMerging.count(PBB)) 1001 continue; 1002 1003 // Skip blocks that loop to themselves, can't tail merge these. 1004 if (PBB == IBB) 1005 continue; 1006 1007 // Visit each predecessor only once. 1008 if (!UniquePreds.insert(PBB).second) 1009 continue; 1010 1011 // Skip blocks which may jump to a landing pad. Can't tail merge these. 1012 if (PBB->hasEHPadSuccessor()) 1013 continue; 1014 1015 // After block placement, only consider predecessors that belong to the 1016 // same loop as IBB. The reason is the same as above when skipping loop 1017 // header. 1018 if (AfterBlockPlacement && MLI) 1019 if (ML != MLI->getLoopFor(PBB)) 1020 continue; 1021 1022 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; 1023 SmallVector<MachineOperand, 4> Cond; 1024 if (!TII->analyzeBranch(*PBB, TBB, FBB, Cond, true)) { 1025 // Failing case: IBB is the target of a cbr, and we cannot reverse the 1026 // branch. 1027 SmallVector<MachineOperand, 4> NewCond(Cond); 1028 if (!Cond.empty() && TBB == IBB) { 1029 if (TII->reverseBranchCondition(NewCond)) 1030 continue; 1031 // This is the QBB case described above 1032 if (!FBB) { 1033 auto Next = ++PBB->getIterator(); 1034 if (Next != MF.end()) 1035 FBB = &*Next; 1036 } 1037 } 1038 1039 // Failing case: the only way IBB can be reached from PBB is via 1040 // exception handling. Happens for landing pads. Would be nice to have 1041 // a bit in the edge so we didn't have to do all this. 1042 if (IBB->isEHPad()) { 1043 MachineFunction::iterator IP = ++PBB->getIterator(); 1044 MachineBasicBlock *PredNextBB = nullptr; 1045 if (IP != MF.end()) 1046 PredNextBB = &*IP; 1047 if (!TBB) { 1048 if (IBB != PredNextBB) // fallthrough 1049 continue; 1050 } else if (FBB) { 1051 if (TBB != IBB && FBB != IBB) // cbr then ubr 1052 continue; 1053 } else if (Cond.empty()) { 1054 if (TBB != IBB) // ubr 1055 continue; 1056 } else { 1057 if (TBB != IBB && IBB != PredNextBB) // cbr 1058 continue; 1059 } 1060 } 1061 1062 // Remove the unconditional branch at the end, if any. 1063 if (TBB && (Cond.empty() || FBB)) { 1064 DebugLoc dl; // FIXME: this is nowhere 1065 TII->removeBranch(*PBB); 1066 if (!Cond.empty()) 1067 // reinsert conditional branch only, for now 1068 TII->insertBranch(*PBB, (TBB == IBB) ? FBB : TBB, nullptr, 1069 NewCond, dl); 1070 } 1071 1072 MergePotentials.push_back(MergePotentialsElt(HashEndOfMBB(*PBB), PBB)); 1073 } 1074 } 1075 1076 // If this is a large problem, avoid visiting the same basic blocks multiple 1077 // times. 1078 if (MergePotentials.size() == TailMergeThreshold) 1079 for (unsigned i = 0, e = MergePotentials.size(); i != e; ++i) 1080 TriedMerging.insert(MergePotentials[i].getBlock()); 1081 1082 if (MergePotentials.size() >= 2) 1083 MadeChange |= TryTailMergeBlocks(IBB, PredBB, MinCommonTailLength); 1084 1085 // Reinsert an unconditional branch if needed. The 1 below can occur as a 1086 // result of removing blocks in TryTailMergeBlocks. 1087 PredBB = &*std::prev(I); // this may have been changed in TryTailMergeBlocks 1088 if (MergePotentials.size() == 1 && 1089 MergePotentials.begin()->getBlock() != PredBB) 1090 FixTail(MergePotentials.begin()->getBlock(), IBB, TII); 1091 } 1092 1093 return MadeChange; 1094 } 1095 1096 void BranchFolder::setCommonTailEdgeWeights(MachineBasicBlock &TailMBB) { 1097 SmallVector<BlockFrequency, 2> EdgeFreqLs(TailMBB.succ_size()); 1098 BlockFrequency AccumulatedMBBFreq; 1099 1100 // Aggregate edge frequency of successor edge j: 1101 // edgeFreq(j) = sum (freq(bb) * edgeProb(bb, j)), 1102 // where bb is a basic block that is in SameTails. 1103 for (const auto &Src : SameTails) { 1104 const MachineBasicBlock *SrcMBB = Src.getBlock(); 1105 BlockFrequency BlockFreq = MBBFreqInfo.getBlockFreq(SrcMBB); 1106 AccumulatedMBBFreq += BlockFreq; 1107 1108 // It is not necessary to recompute edge weights if TailBB has less than two 1109 // successors. 1110 if (TailMBB.succ_size() <= 1) 1111 continue; 1112 1113 auto EdgeFreq = EdgeFreqLs.begin(); 1114 1115 for (auto SuccI = TailMBB.succ_begin(), SuccE = TailMBB.succ_end(); 1116 SuccI != SuccE; ++SuccI, ++EdgeFreq) 1117 *EdgeFreq += BlockFreq * MBPI.getEdgeProbability(SrcMBB, *SuccI); 1118 } 1119 1120 MBBFreqInfo.setBlockFreq(&TailMBB, AccumulatedMBBFreq); 1121 1122 if (TailMBB.succ_size() <= 1) 1123 return; 1124 1125 auto SumEdgeFreq = 1126 std::accumulate(EdgeFreqLs.begin(), EdgeFreqLs.end(), BlockFrequency(0)) 1127 .getFrequency(); 1128 auto EdgeFreq = EdgeFreqLs.begin(); 1129 1130 if (SumEdgeFreq > 0) { 1131 for (auto SuccI = TailMBB.succ_begin(), SuccE = TailMBB.succ_end(); 1132 SuccI != SuccE; ++SuccI, ++EdgeFreq) { 1133 auto Prob = BranchProbability::getBranchProbability( 1134 EdgeFreq->getFrequency(), SumEdgeFreq); 1135 TailMBB.setSuccProbability(SuccI, Prob); 1136 } 1137 } 1138 } 1139 1140 //===----------------------------------------------------------------------===// 1141 // Branch Optimization 1142 //===----------------------------------------------------------------------===// 1143 1144 bool BranchFolder::OptimizeBranches(MachineFunction &MF) { 1145 bool MadeChange = false; 1146 1147 // Make sure blocks are numbered in order 1148 MF.RenumberBlocks(); 1149 // Renumbering blocks alters funclet membership, recalculate it. 1150 FuncletMembership = getFuncletMembership(MF); 1151 1152 for (MachineFunction::iterator I = std::next(MF.begin()), E = MF.end(); 1153 I != E; ) { 1154 MachineBasicBlock *MBB = &*I++; 1155 MadeChange |= OptimizeBlock(MBB); 1156 1157 // If it is dead, remove it. 1158 if (MBB->pred_empty()) { 1159 RemoveDeadBlock(MBB); 1160 MadeChange = true; 1161 ++NumDeadBlocks; 1162 } 1163 } 1164 1165 return MadeChange; 1166 } 1167 1168 // Blocks should be considered empty if they contain only debug info; 1169 // else the debug info would affect codegen. 1170 static bool IsEmptyBlock(MachineBasicBlock *MBB) { 1171 return MBB->getFirstNonDebugInstr() == MBB->end(); 1172 } 1173 1174 // Blocks with only debug info and branches should be considered the same 1175 // as blocks with only branches. 1176 static bool IsBranchOnlyBlock(MachineBasicBlock *MBB) { 1177 MachineBasicBlock::iterator I = MBB->getFirstNonDebugInstr(); 1178 assert(I != MBB->end() && "empty block!"); 1179 return I->isBranch(); 1180 } 1181 1182 /// IsBetterFallthrough - Return true if it would be clearly better to 1183 /// fall-through to MBB1 than to fall through into MBB2. This has to return 1184 /// a strict ordering, returning true for both (MBB1,MBB2) and (MBB2,MBB1) will 1185 /// result in infinite loops. 1186 static bool IsBetterFallthrough(MachineBasicBlock *MBB1, 1187 MachineBasicBlock *MBB2) { 1188 // Right now, we use a simple heuristic. If MBB2 ends with a call, and 1189 // MBB1 doesn't, we prefer to fall through into MBB1. This allows us to 1190 // optimize branches that branch to either a return block or an assert block 1191 // into a fallthrough to the return. 1192 MachineBasicBlock::iterator MBB1I = MBB1->getLastNonDebugInstr(); 1193 MachineBasicBlock::iterator MBB2I = MBB2->getLastNonDebugInstr(); 1194 if (MBB1I == MBB1->end() || MBB2I == MBB2->end()) 1195 return false; 1196 1197 // If there is a clear successor ordering we make sure that one block 1198 // will fall through to the next 1199 if (MBB1->isSuccessor(MBB2)) return true; 1200 if (MBB2->isSuccessor(MBB1)) return false; 1201 1202 return MBB2I->isCall() && !MBB1I->isCall(); 1203 } 1204 1205 /// getBranchDebugLoc - Find and return, if any, the DebugLoc of the branch 1206 /// instructions on the block. 1207 static DebugLoc getBranchDebugLoc(MachineBasicBlock &MBB) { 1208 MachineBasicBlock::iterator I = MBB.getLastNonDebugInstr(); 1209 if (I != MBB.end() && I->isBranch()) 1210 return I->getDebugLoc(); 1211 return DebugLoc(); 1212 } 1213 1214 /// OptimizeBlock - Analyze and optimize control flow related to the specified 1215 /// block. This is never called on the entry block. 1216 bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) { 1217 bool MadeChange = false; 1218 MachineFunction &MF = *MBB->getParent(); 1219 ReoptimizeBlock: 1220 1221 MachineFunction::iterator FallThrough = MBB->getIterator(); 1222 ++FallThrough; 1223 1224 // Make sure MBB and FallThrough belong to the same funclet. 1225 bool SameFunclet = true; 1226 if (!FuncletMembership.empty() && FallThrough != MF.end()) { 1227 auto MBBFunclet = FuncletMembership.find(MBB); 1228 assert(MBBFunclet != FuncletMembership.end()); 1229 auto FallThroughFunclet = FuncletMembership.find(&*FallThrough); 1230 assert(FallThroughFunclet != FuncletMembership.end()); 1231 SameFunclet = MBBFunclet->second == FallThroughFunclet->second; 1232 } 1233 1234 // If this block is empty, make everyone use its fall-through, not the block 1235 // explicitly. Landing pads should not do this since the landing-pad table 1236 // points to this block. Blocks with their addresses taken shouldn't be 1237 // optimized away. 1238 if (IsEmptyBlock(MBB) && !MBB->isEHPad() && !MBB->hasAddressTaken() && 1239 SameFunclet) { 1240 // Dead block? Leave for cleanup later. 1241 if (MBB->pred_empty()) return MadeChange; 1242 1243 if (FallThrough == MF.end()) { 1244 // TODO: Simplify preds to not branch here if possible! 1245 } else if (FallThrough->isEHPad()) { 1246 // Don't rewrite to a landing pad fallthough. That could lead to the case 1247 // where a BB jumps to more than one landing pad. 1248 // TODO: Is it ever worth rewriting predecessors which don't already 1249 // jump to a landing pad, and so can safely jump to the fallthrough? 1250 } else if (MBB->isSuccessor(&*FallThrough)) { 1251 // Rewrite all predecessors of the old block to go to the fallthrough 1252 // instead. 1253 while (!MBB->pred_empty()) { 1254 MachineBasicBlock *Pred = *(MBB->pred_end()-1); 1255 Pred->ReplaceUsesOfBlockWith(MBB, &*FallThrough); 1256 } 1257 // If MBB was the target of a jump table, update jump tables to go to the 1258 // fallthrough instead. 1259 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo()) 1260 MJTI->ReplaceMBBInJumpTables(MBB, &*FallThrough); 1261 MadeChange = true; 1262 } 1263 return MadeChange; 1264 } 1265 1266 // Check to see if we can simplify the terminator of the block before this 1267 // one. 1268 MachineBasicBlock &PrevBB = *std::prev(MachineFunction::iterator(MBB)); 1269 1270 MachineBasicBlock *PriorTBB = nullptr, *PriorFBB = nullptr; 1271 SmallVector<MachineOperand, 4> PriorCond; 1272 bool PriorUnAnalyzable = 1273 TII->analyzeBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, true); 1274 if (!PriorUnAnalyzable) { 1275 // If the CFG for the prior block has extra edges, remove them. 1276 MadeChange |= PrevBB.CorrectExtraCFGEdges(PriorTBB, PriorFBB, 1277 !PriorCond.empty()); 1278 1279 // If the previous branch is conditional and both conditions go to the same 1280 // destination, remove the branch, replacing it with an unconditional one or 1281 // a fall-through. 1282 if (PriorTBB && PriorTBB == PriorFBB) { 1283 DebugLoc dl = getBranchDebugLoc(PrevBB); 1284 TII->removeBranch(PrevBB); 1285 PriorCond.clear(); 1286 if (PriorTBB != MBB) 1287 TII->insertBranch(PrevBB, PriorTBB, nullptr, PriorCond, dl); 1288 MadeChange = true; 1289 ++NumBranchOpts; 1290 goto ReoptimizeBlock; 1291 } 1292 1293 // If the previous block unconditionally falls through to this block and 1294 // this block has no other predecessors, move the contents of this block 1295 // into the prior block. This doesn't usually happen when SimplifyCFG 1296 // has been used, but it can happen if tail merging splits a fall-through 1297 // predecessor of a block. 1298 // This has to check PrevBB->succ_size() because EH edges are ignored by 1299 // AnalyzeBranch. 1300 if (PriorCond.empty() && !PriorTBB && MBB->pred_size() == 1 && 1301 PrevBB.succ_size() == 1 && 1302 !MBB->hasAddressTaken() && !MBB->isEHPad()) { 1303 DEBUG(dbgs() << "\nMerging into block: " << PrevBB 1304 << "From MBB: " << *MBB); 1305 // Remove redundant DBG_VALUEs first. 1306 if (PrevBB.begin() != PrevBB.end()) { 1307 MachineBasicBlock::iterator PrevBBIter = PrevBB.end(); 1308 --PrevBBIter; 1309 MachineBasicBlock::iterator MBBIter = MBB->begin(); 1310 // Check if DBG_VALUE at the end of PrevBB is identical to the 1311 // DBG_VALUE at the beginning of MBB. 1312 while (PrevBBIter != PrevBB.begin() && MBBIter != MBB->end() 1313 && PrevBBIter->isDebugValue() && MBBIter->isDebugValue()) { 1314 if (!MBBIter->isIdenticalTo(*PrevBBIter)) 1315 break; 1316 MachineInstr &DuplicateDbg = *MBBIter; 1317 ++MBBIter; -- PrevBBIter; 1318 DuplicateDbg.eraseFromParent(); 1319 } 1320 } 1321 PrevBB.splice(PrevBB.end(), MBB, MBB->begin(), MBB->end()); 1322 PrevBB.removeSuccessor(PrevBB.succ_begin()); 1323 assert(PrevBB.succ_empty()); 1324 PrevBB.transferSuccessors(MBB); 1325 MadeChange = true; 1326 return MadeChange; 1327 } 1328 1329 // If the previous branch *only* branches to *this* block (conditional or 1330 // not) remove the branch. 1331 if (PriorTBB == MBB && !PriorFBB) { 1332 TII->removeBranch(PrevBB); 1333 MadeChange = true; 1334 ++NumBranchOpts; 1335 goto ReoptimizeBlock; 1336 } 1337 1338 // If the prior block branches somewhere else on the condition and here if 1339 // the condition is false, remove the uncond second branch. 1340 if (PriorFBB == MBB) { 1341 DebugLoc dl = getBranchDebugLoc(PrevBB); 1342 TII->removeBranch(PrevBB); 1343 TII->insertBranch(PrevBB, PriorTBB, nullptr, PriorCond, dl); 1344 MadeChange = true; 1345 ++NumBranchOpts; 1346 goto ReoptimizeBlock; 1347 } 1348 1349 // If the prior block branches here on true and somewhere else on false, and 1350 // if the branch condition is reversible, reverse the branch to create a 1351 // fall-through. 1352 if (PriorTBB == MBB) { 1353 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond); 1354 if (!TII->reverseBranchCondition(NewPriorCond)) { 1355 DebugLoc dl = getBranchDebugLoc(PrevBB); 1356 TII->removeBranch(PrevBB); 1357 TII->insertBranch(PrevBB, PriorFBB, nullptr, NewPriorCond, dl); 1358 MadeChange = true; 1359 ++NumBranchOpts; 1360 goto ReoptimizeBlock; 1361 } 1362 } 1363 1364 // If this block has no successors (e.g. it is a return block or ends with 1365 // a call to a no-return function like abort or __cxa_throw) and if the pred 1366 // falls through into this block, and if it would otherwise fall through 1367 // into the block after this, move this block to the end of the function. 1368 // 1369 // We consider it more likely that execution will stay in the function (e.g. 1370 // due to loops) than it is to exit it. This asserts in loops etc, moving 1371 // the assert condition out of the loop body. 1372 if (MBB->succ_empty() && !PriorCond.empty() && !PriorFBB && 1373 MachineFunction::iterator(PriorTBB) == FallThrough && 1374 !MBB->canFallThrough()) { 1375 bool DoTransform = true; 1376 1377 // We have to be careful that the succs of PredBB aren't both no-successor 1378 // blocks. If neither have successors and if PredBB is the second from 1379 // last block in the function, we'd just keep swapping the two blocks for 1380 // last. Only do the swap if one is clearly better to fall through than 1381 // the other. 1382 if (FallThrough == --MF.end() && 1383 !IsBetterFallthrough(PriorTBB, MBB)) 1384 DoTransform = false; 1385 1386 if (DoTransform) { 1387 // Reverse the branch so we will fall through on the previous true cond. 1388 SmallVector<MachineOperand, 4> NewPriorCond(PriorCond); 1389 if (!TII->reverseBranchCondition(NewPriorCond)) { 1390 DEBUG(dbgs() << "\nMoving MBB: " << *MBB 1391 << "To make fallthrough to: " << *PriorTBB << "\n"); 1392 1393 DebugLoc dl = getBranchDebugLoc(PrevBB); 1394 TII->removeBranch(PrevBB); 1395 TII->insertBranch(PrevBB, MBB, nullptr, NewPriorCond, dl); 1396 1397 // Move this block to the end of the function. 1398 MBB->moveAfter(&MF.back()); 1399 MadeChange = true; 1400 ++NumBranchOpts; 1401 return MadeChange; 1402 } 1403 } 1404 } 1405 } 1406 1407 if (!IsEmptyBlock(MBB) && MBB->pred_size() == 1 && 1408 MF.getFunction()->optForSize()) { 1409 // Changing "Jcc foo; foo: jmp bar;" into "Jcc bar;" might change the branch 1410 // direction, thereby defeating careful block placement and regressing 1411 // performance. Therefore, only consider this for optsize functions. 1412 MachineInstr &TailCall = *MBB->getFirstNonDebugInstr(); 1413 if (TII->isUnconditionalTailCall(TailCall)) { 1414 MachineBasicBlock *Pred = *MBB->pred_begin(); 1415 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; 1416 SmallVector<MachineOperand, 4> PredCond; 1417 bool PredAnalyzable = 1418 !TII->analyzeBranch(*Pred, PredTBB, PredFBB, PredCond, true); 1419 1420 if (PredAnalyzable && !PredCond.empty() && PredTBB == MBB) { 1421 // The predecessor has a conditional branch to this block which consists 1422 // of only a tail call. Try to fold the tail call into the conditional 1423 // branch. 1424 if (TII->canMakeTailCallConditional(PredCond, TailCall)) { 1425 // TODO: It would be nice if analyzeBranch() could provide a pointer 1426 // to the branch insturction so replaceBranchWithTailCall() doesn't 1427 // have to search for it. 1428 TII->replaceBranchWithTailCall(*Pred, PredCond, TailCall); 1429 ++NumTailCalls; 1430 Pred->removeSuccessor(MBB); 1431 MadeChange = true; 1432 return MadeChange; 1433 } 1434 } 1435 // If the predecessor is falling through to this block, we could reverse 1436 // the branch condition and fold the tail call into that. However, after 1437 // that we might have to re-arrange the CFG to fall through to the other 1438 // block and there is a high risk of regressing code size rather than 1439 // improving it. 1440 } 1441 } 1442 1443 // Analyze the branch in the current block. 1444 MachineBasicBlock *CurTBB = nullptr, *CurFBB = nullptr; 1445 SmallVector<MachineOperand, 4> CurCond; 1446 bool CurUnAnalyzable = 1447 TII->analyzeBranch(*MBB, CurTBB, CurFBB, CurCond, true); 1448 if (!CurUnAnalyzable) { 1449 // If the CFG for the prior block has extra edges, remove them. 1450 MadeChange |= MBB->CorrectExtraCFGEdges(CurTBB, CurFBB, !CurCond.empty()); 1451 1452 // If this is a two-way branch, and the FBB branches to this block, reverse 1453 // the condition so the single-basic-block loop is faster. Instead of: 1454 // Loop: xxx; jcc Out; jmp Loop 1455 // we want: 1456 // Loop: xxx; jncc Loop; jmp Out 1457 if (CurTBB && CurFBB && CurFBB == MBB && CurTBB != MBB) { 1458 SmallVector<MachineOperand, 4> NewCond(CurCond); 1459 if (!TII->reverseBranchCondition(NewCond)) { 1460 DebugLoc dl = getBranchDebugLoc(*MBB); 1461 TII->removeBranch(*MBB); 1462 TII->insertBranch(*MBB, CurFBB, CurTBB, NewCond, dl); 1463 MadeChange = true; 1464 ++NumBranchOpts; 1465 goto ReoptimizeBlock; 1466 } 1467 } 1468 1469 // If this branch is the only thing in its block, see if we can forward 1470 // other blocks across it. 1471 if (CurTBB && CurCond.empty() && !CurFBB && 1472 IsBranchOnlyBlock(MBB) && CurTBB != MBB && 1473 !MBB->hasAddressTaken() && !MBB->isEHPad()) { 1474 DebugLoc dl = getBranchDebugLoc(*MBB); 1475 // This block may contain just an unconditional branch. Because there can 1476 // be 'non-branch terminators' in the block, try removing the branch and 1477 // then seeing if the block is empty. 1478 TII->removeBranch(*MBB); 1479 // If the only things remaining in the block are debug info, remove these 1480 // as well, so this will behave the same as an empty block in non-debug 1481 // mode. 1482 if (IsEmptyBlock(MBB)) { 1483 // Make the block empty, losing the debug info (we could probably 1484 // improve this in some cases.) 1485 MBB->erase(MBB->begin(), MBB->end()); 1486 } 1487 // If this block is just an unconditional branch to CurTBB, we can 1488 // usually completely eliminate the block. The only case we cannot 1489 // completely eliminate the block is when the block before this one 1490 // falls through into MBB and we can't understand the prior block's branch 1491 // condition. 1492 if (MBB->empty()) { 1493 bool PredHasNoFallThrough = !PrevBB.canFallThrough(); 1494 if (PredHasNoFallThrough || !PriorUnAnalyzable || 1495 !PrevBB.isSuccessor(MBB)) { 1496 // If the prior block falls through into us, turn it into an 1497 // explicit branch to us to make updates simpler. 1498 if (!PredHasNoFallThrough && PrevBB.isSuccessor(MBB) && 1499 PriorTBB != MBB && PriorFBB != MBB) { 1500 if (!PriorTBB) { 1501 assert(PriorCond.empty() && !PriorFBB && 1502 "Bad branch analysis"); 1503 PriorTBB = MBB; 1504 } else { 1505 assert(!PriorFBB && "Machine CFG out of date!"); 1506 PriorFBB = MBB; 1507 } 1508 DebugLoc pdl = getBranchDebugLoc(PrevBB); 1509 TII->removeBranch(PrevBB); 1510 TII->insertBranch(PrevBB, PriorTBB, PriorFBB, PriorCond, pdl); 1511 } 1512 1513 // Iterate through all the predecessors, revectoring each in-turn. 1514 size_t PI = 0; 1515 bool DidChange = false; 1516 bool HasBranchToSelf = false; 1517 while(PI != MBB->pred_size()) { 1518 MachineBasicBlock *PMBB = *(MBB->pred_begin() + PI); 1519 if (PMBB == MBB) { 1520 // If this block has an uncond branch to itself, leave it. 1521 ++PI; 1522 HasBranchToSelf = true; 1523 } else { 1524 DidChange = true; 1525 PMBB->ReplaceUsesOfBlockWith(MBB, CurTBB); 1526 // If this change resulted in PMBB ending in a conditional 1527 // branch where both conditions go to the same destination, 1528 // change this to an unconditional branch (and fix the CFG). 1529 MachineBasicBlock *NewCurTBB = nullptr, *NewCurFBB = nullptr; 1530 SmallVector<MachineOperand, 4> NewCurCond; 1531 bool NewCurUnAnalyzable = TII->analyzeBranch( 1532 *PMBB, NewCurTBB, NewCurFBB, NewCurCond, true); 1533 if (!NewCurUnAnalyzable && NewCurTBB && NewCurTBB == NewCurFBB) { 1534 DebugLoc pdl = getBranchDebugLoc(*PMBB); 1535 TII->removeBranch(*PMBB); 1536 NewCurCond.clear(); 1537 TII->insertBranch(*PMBB, NewCurTBB, nullptr, NewCurCond, pdl); 1538 MadeChange = true; 1539 ++NumBranchOpts; 1540 PMBB->CorrectExtraCFGEdges(NewCurTBB, nullptr, false); 1541 } 1542 } 1543 } 1544 1545 // Change any jumptables to go to the new MBB. 1546 if (MachineJumpTableInfo *MJTI = MF.getJumpTableInfo()) 1547 MJTI->ReplaceMBBInJumpTables(MBB, CurTBB); 1548 if (DidChange) { 1549 ++NumBranchOpts; 1550 MadeChange = true; 1551 if (!HasBranchToSelf) return MadeChange; 1552 } 1553 } 1554 } 1555 1556 // Add the branch back if the block is more than just an uncond branch. 1557 TII->insertBranch(*MBB, CurTBB, nullptr, CurCond, dl); 1558 } 1559 } 1560 1561 // If the prior block doesn't fall through into this block, and if this 1562 // block doesn't fall through into some other block, see if we can find a 1563 // place to move this block where a fall-through will happen. 1564 if (!PrevBB.canFallThrough()) { 1565 1566 // Now we know that there was no fall-through into this block, check to 1567 // see if it has a fall-through into its successor. 1568 bool CurFallsThru = MBB->canFallThrough(); 1569 1570 if (!MBB->isEHPad()) { 1571 // Check all the predecessors of this block. If one of them has no fall 1572 // throughs, move this block right after it. 1573 for (MachineBasicBlock *PredBB : MBB->predecessors()) { 1574 // Analyze the branch at the end of the pred. 1575 MachineBasicBlock *PredTBB = nullptr, *PredFBB = nullptr; 1576 SmallVector<MachineOperand, 4> PredCond; 1577 if (PredBB != MBB && !PredBB->canFallThrough() && 1578 !TII->analyzeBranch(*PredBB, PredTBB, PredFBB, PredCond, true) && 1579 (!CurFallsThru || !CurTBB || !CurFBB) && 1580 (!CurFallsThru || MBB->getNumber() >= PredBB->getNumber())) { 1581 // If the current block doesn't fall through, just move it. 1582 // If the current block can fall through and does not end with a 1583 // conditional branch, we need to append an unconditional jump to 1584 // the (current) next block. To avoid a possible compile-time 1585 // infinite loop, move blocks only backward in this case. 1586 // Also, if there are already 2 branches here, we cannot add a third; 1587 // this means we have the case 1588 // Bcc next 1589 // B elsewhere 1590 // next: 1591 if (CurFallsThru) { 1592 MachineBasicBlock *NextBB = &*std::next(MBB->getIterator()); 1593 CurCond.clear(); 1594 TII->insertBranch(*MBB, NextBB, nullptr, CurCond, DebugLoc()); 1595 } 1596 MBB->moveAfter(PredBB); 1597 MadeChange = true; 1598 goto ReoptimizeBlock; 1599 } 1600 } 1601 } 1602 1603 if (!CurFallsThru) { 1604 // Check all successors to see if we can move this block before it. 1605 for (MachineBasicBlock *SuccBB : MBB->successors()) { 1606 // Analyze the branch at the end of the block before the succ. 1607 MachineFunction::iterator SuccPrev = --SuccBB->getIterator(); 1608 1609 // If this block doesn't already fall-through to that successor, and if 1610 // the succ doesn't already have a block that can fall through into it, 1611 // and if the successor isn't an EH destination, we can arrange for the 1612 // fallthrough to happen. 1613 if (SuccBB != MBB && &*SuccPrev != MBB && 1614 !SuccPrev->canFallThrough() && !CurUnAnalyzable && 1615 !SuccBB->isEHPad()) { 1616 MBB->moveBefore(SuccBB); 1617 MadeChange = true; 1618 goto ReoptimizeBlock; 1619 } 1620 } 1621 1622 // Okay, there is no really great place to put this block. If, however, 1623 // the block before this one would be a fall-through if this block were 1624 // removed, move this block to the end of the function. 1625 MachineBasicBlock *PrevTBB = nullptr, *PrevFBB = nullptr; 1626 SmallVector<MachineOperand, 4> PrevCond; 1627 if (FallThrough != MF.end() && 1628 !TII->analyzeBranch(PrevBB, PrevTBB, PrevFBB, PrevCond, true) && 1629 PrevBB.isSuccessor(&*FallThrough)) { 1630 MBB->moveAfter(&MF.back()); 1631 MadeChange = true; 1632 return MadeChange; 1633 } 1634 } 1635 } 1636 1637 return MadeChange; 1638 } 1639 1640 //===----------------------------------------------------------------------===// 1641 // Hoist Common Code 1642 //===----------------------------------------------------------------------===// 1643 1644 /// HoistCommonCode - Hoist common instruction sequences at the start of basic 1645 /// blocks to their common predecessor. 1646 bool BranchFolder::HoistCommonCode(MachineFunction &MF) { 1647 bool MadeChange = false; 1648 for (MachineFunction::iterator I = MF.begin(), E = MF.end(); I != E; ) { 1649 MachineBasicBlock *MBB = &*I++; 1650 MadeChange |= HoistCommonCodeInSuccs(MBB); 1651 } 1652 1653 return MadeChange; 1654 } 1655 1656 /// findFalseBlock - BB has a fallthrough. Find its 'false' successor given 1657 /// its 'true' successor. 1658 static MachineBasicBlock *findFalseBlock(MachineBasicBlock *BB, 1659 MachineBasicBlock *TrueBB) { 1660 for (MachineBasicBlock *SuccBB : BB->successors()) 1661 if (SuccBB != TrueBB) 1662 return SuccBB; 1663 return nullptr; 1664 } 1665 1666 template <class Container> 1667 static void addRegAndItsAliases(unsigned Reg, const TargetRegisterInfo *TRI, 1668 Container &Set) { 1669 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1670 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1671 Set.insert(*AI); 1672 } else { 1673 Set.insert(Reg); 1674 } 1675 } 1676 1677 /// findHoistingInsertPosAndDeps - Find the location to move common instructions 1678 /// in successors to. The location is usually just before the terminator, 1679 /// however if the terminator is a conditional branch and its previous 1680 /// instruction is the flag setting instruction, the previous instruction is 1681 /// the preferred location. This function also gathers uses and defs of the 1682 /// instructions from the insertion point to the end of the block. The data is 1683 /// used by HoistCommonCodeInSuccs to ensure safety. 1684 static 1685 MachineBasicBlock::iterator findHoistingInsertPosAndDeps(MachineBasicBlock *MBB, 1686 const TargetInstrInfo *TII, 1687 const TargetRegisterInfo *TRI, 1688 SmallSet<unsigned,4> &Uses, 1689 SmallSet<unsigned,4> &Defs) { 1690 MachineBasicBlock::iterator Loc = MBB->getFirstTerminator(); 1691 if (!TII->isUnpredicatedTerminator(*Loc)) 1692 return MBB->end(); 1693 1694 for (const MachineOperand &MO : Loc->operands()) { 1695 if (!MO.isReg()) 1696 continue; 1697 unsigned Reg = MO.getReg(); 1698 if (!Reg) 1699 continue; 1700 if (MO.isUse()) { 1701 addRegAndItsAliases(Reg, TRI, Uses); 1702 } else { 1703 if (!MO.isDead()) 1704 // Don't try to hoist code in the rare case the terminator defines a 1705 // register that is later used. 1706 return MBB->end(); 1707 1708 // If the terminator defines a register, make sure we don't hoist 1709 // the instruction whose def might be clobbered by the terminator. 1710 addRegAndItsAliases(Reg, TRI, Defs); 1711 } 1712 } 1713 1714 if (Uses.empty()) 1715 return Loc; 1716 if (Loc == MBB->begin()) 1717 return MBB->end(); 1718 1719 // The terminator is probably a conditional branch, try not to separate the 1720 // branch from condition setting instruction. 1721 MachineBasicBlock::iterator PI = Loc; 1722 --PI; 1723 while (PI != MBB->begin() && PI->isDebugValue()) 1724 --PI; 1725 1726 bool IsDef = false; 1727 for (const MachineOperand &MO : PI->operands()) { 1728 // If PI has a regmask operand, it is probably a call. Separate away. 1729 if (MO.isRegMask()) 1730 return Loc; 1731 if (!MO.isReg() || MO.isUse()) 1732 continue; 1733 unsigned Reg = MO.getReg(); 1734 if (!Reg) 1735 continue; 1736 if (Uses.count(Reg)) { 1737 IsDef = true; 1738 break; 1739 } 1740 } 1741 if (!IsDef) 1742 // The condition setting instruction is not just before the conditional 1743 // branch. 1744 return Loc; 1745 1746 // Be conservative, don't insert instruction above something that may have 1747 // side-effects. And since it's potentially bad to separate flag setting 1748 // instruction from the conditional branch, just abort the optimization 1749 // completely. 1750 // Also avoid moving code above predicated instruction since it's hard to 1751 // reason about register liveness with predicated instruction. 1752 bool DontMoveAcrossStore = true; 1753 if (!PI->isSafeToMove(nullptr, DontMoveAcrossStore) || TII->isPredicated(*PI)) 1754 return MBB->end(); 1755 1756 1757 // Find out what registers are live. Note this routine is ignoring other live 1758 // registers which are only used by instructions in successor blocks. 1759 for (const MachineOperand &MO : PI->operands()) { 1760 if (!MO.isReg()) 1761 continue; 1762 unsigned Reg = MO.getReg(); 1763 if (!Reg) 1764 continue; 1765 if (MO.isUse()) { 1766 addRegAndItsAliases(Reg, TRI, Uses); 1767 } else { 1768 if (Uses.erase(Reg)) { 1769 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1770 for (MCSubRegIterator SubRegs(Reg, TRI); SubRegs.isValid(); ++SubRegs) 1771 Uses.erase(*SubRegs); // Use sub-registers to be conservative 1772 } 1773 } 1774 addRegAndItsAliases(Reg, TRI, Defs); 1775 } 1776 } 1777 1778 return PI; 1779 } 1780 1781 /// HoistCommonCodeInSuccs - If the successors of MBB has common instruction 1782 /// sequence at the start of the function, move the instructions before MBB 1783 /// terminator if it's legal. 1784 bool BranchFolder::HoistCommonCodeInSuccs(MachineBasicBlock *MBB) { 1785 MachineBasicBlock *TBB = nullptr, *FBB = nullptr; 1786 SmallVector<MachineOperand, 4> Cond; 1787 if (TII->analyzeBranch(*MBB, TBB, FBB, Cond, true) || !TBB || Cond.empty()) 1788 return false; 1789 1790 if (!FBB) FBB = findFalseBlock(MBB, TBB); 1791 if (!FBB) 1792 // Malformed bcc? True and false blocks are the same? 1793 return false; 1794 1795 // Restrict the optimization to cases where MBB is the only predecessor, 1796 // it is an obvious win. 1797 if (TBB->pred_size() > 1 || FBB->pred_size() > 1) 1798 return false; 1799 1800 // Find a suitable position to hoist the common instructions to. Also figure 1801 // out which registers are used or defined by instructions from the insertion 1802 // point to the end of the block. 1803 SmallSet<unsigned, 4> Uses, Defs; 1804 MachineBasicBlock::iterator Loc = 1805 findHoistingInsertPosAndDeps(MBB, TII, TRI, Uses, Defs); 1806 if (Loc == MBB->end()) 1807 return false; 1808 1809 bool HasDups = false; 1810 SmallVector<unsigned, 4> LocalDefs; 1811 SmallSet<unsigned, 4> LocalDefsSet; 1812 MachineBasicBlock::iterator TIB = TBB->begin(); 1813 MachineBasicBlock::iterator FIB = FBB->begin(); 1814 MachineBasicBlock::iterator TIE = TBB->end(); 1815 MachineBasicBlock::iterator FIE = FBB->end(); 1816 while (TIB != TIE && FIB != FIE) { 1817 // Skip dbg_value instructions. These do not count. 1818 if (TIB->isDebugValue()) { 1819 while (TIB != TIE && TIB->isDebugValue()) 1820 ++TIB; 1821 if (TIB == TIE) 1822 break; 1823 } 1824 if (FIB->isDebugValue()) { 1825 while (FIB != FIE && FIB->isDebugValue()) 1826 ++FIB; 1827 if (FIB == FIE) 1828 break; 1829 } 1830 if (!TIB->isIdenticalTo(*FIB, MachineInstr::CheckKillDead)) 1831 break; 1832 1833 if (TII->isPredicated(*TIB)) 1834 // Hard to reason about register liveness with predicated instruction. 1835 break; 1836 1837 bool IsSafe = true; 1838 for (MachineOperand &MO : TIB->operands()) { 1839 // Don't attempt to hoist instructions with register masks. 1840 if (MO.isRegMask()) { 1841 IsSafe = false; 1842 break; 1843 } 1844 if (!MO.isReg()) 1845 continue; 1846 unsigned Reg = MO.getReg(); 1847 if (!Reg) 1848 continue; 1849 if (MO.isDef()) { 1850 if (Uses.count(Reg)) { 1851 // Avoid clobbering a register that's used by the instruction at 1852 // the point of insertion. 1853 IsSafe = false; 1854 break; 1855 } 1856 1857 if (Defs.count(Reg) && !MO.isDead()) { 1858 // Don't hoist the instruction if the def would be clobber by the 1859 // instruction at the point insertion. FIXME: This is overly 1860 // conservative. It should be possible to hoist the instructions 1861 // in BB2 in the following example: 1862 // BB1: 1863 // r1, eflag = op1 r2, r3 1864 // brcc eflag 1865 // 1866 // BB2: 1867 // r1 = op2, ... 1868 // = op3, r1<kill> 1869 IsSafe = false; 1870 break; 1871 } 1872 } else if (!LocalDefsSet.count(Reg)) { 1873 if (Defs.count(Reg)) { 1874 // Use is defined by the instruction at the point of insertion. 1875 IsSafe = false; 1876 break; 1877 } 1878 1879 if (MO.isKill() && Uses.count(Reg)) 1880 // Kills a register that's read by the instruction at the point of 1881 // insertion. Remove the kill marker. 1882 MO.setIsKill(false); 1883 } 1884 } 1885 if (!IsSafe) 1886 break; 1887 1888 bool DontMoveAcrossStore = true; 1889 if (!TIB->isSafeToMove(nullptr, DontMoveAcrossStore)) 1890 break; 1891 1892 // Remove kills from LocalDefsSet, these registers had short live ranges. 1893 for (const MachineOperand &MO : TIB->operands()) { 1894 if (!MO.isReg() || !MO.isUse() || !MO.isKill()) 1895 continue; 1896 unsigned Reg = MO.getReg(); 1897 if (!Reg || !LocalDefsSet.count(Reg)) 1898 continue; 1899 if (TargetRegisterInfo::isPhysicalRegister(Reg)) { 1900 for (MCRegAliasIterator AI(Reg, TRI, true); AI.isValid(); ++AI) 1901 LocalDefsSet.erase(*AI); 1902 } else { 1903 LocalDefsSet.erase(Reg); 1904 } 1905 } 1906 1907 // Track local defs so we can update liveins. 1908 for (const MachineOperand &MO : TIB->operands()) { 1909 if (!MO.isReg() || !MO.isDef() || MO.isDead()) 1910 continue; 1911 unsigned Reg = MO.getReg(); 1912 if (!Reg || TargetRegisterInfo::isVirtualRegister(Reg)) 1913 continue; 1914 LocalDefs.push_back(Reg); 1915 addRegAndItsAliases(Reg, TRI, LocalDefsSet); 1916 } 1917 1918 HasDups = true; 1919 ++TIB; 1920 ++FIB; 1921 } 1922 1923 if (!HasDups) 1924 return false; 1925 1926 MBB->splice(Loc, TBB, TBB->begin(), TIB); 1927 FBB->erase(FBB->begin(), FIB); 1928 1929 // Update livein's. 1930 bool AddedLiveIns = false; 1931 for (unsigned i = 0, e = LocalDefs.size(); i != e; ++i) { 1932 unsigned Def = LocalDefs[i]; 1933 if (LocalDefsSet.count(Def)) { 1934 TBB->addLiveIn(Def); 1935 FBB->addLiveIn(Def); 1936 AddedLiveIns = true; 1937 } 1938 } 1939 1940 if (AddedLiveIns) { 1941 TBB->sortUniqueLiveIns(); 1942 FBB->sortUniqueLiveIns(); 1943 } 1944 1945 ++NumHoist; 1946 return true; 1947 } 1948