1e440b493SArthur Eubanks //===-- Lint.cpp - Check for common errors in LLVM IR ---------------------===// 2e440b493SArthur Eubanks // 3e440b493SArthur Eubanks // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4e440b493SArthur Eubanks // See https://llvm.org/LICENSE.txt for license information. 5e440b493SArthur Eubanks // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6e440b493SArthur Eubanks // 7e440b493SArthur Eubanks //===----------------------------------------------------------------------===// 8e440b493SArthur Eubanks // 9e440b493SArthur Eubanks // This pass statically checks for common and easily-identified constructs 10e440b493SArthur Eubanks // which produce undefined or likely unintended behavior in LLVM IR. 11e440b493SArthur Eubanks // 12e440b493SArthur Eubanks // It is not a guarantee of correctness, in two ways. First, it isn't 13e440b493SArthur Eubanks // comprehensive. There are checks which could be done statically which are 14e440b493SArthur Eubanks // not yet implemented. Some of these are indicated by TODO comments, but 15e440b493SArthur Eubanks // those aren't comprehensive either. Second, many conditions cannot be 16e440b493SArthur Eubanks // checked statically. This pass does no dynamic instrumentation, so it 17e440b493SArthur Eubanks // can't check for all possible problems. 18e440b493SArthur Eubanks // 19e440b493SArthur Eubanks // Another limitation is that it assumes all code will be executed. A store 20e440b493SArthur Eubanks // through a null pointer in a basic block which is never reached is harmless, 21e440b493SArthur Eubanks // but this pass will warn about it anyway. This is the main reason why most 22e440b493SArthur Eubanks // of these checks live here instead of in the Verifier pass. 23e440b493SArthur Eubanks // 24e440b493SArthur Eubanks // Optimization passes may make conditions that this pass checks for more or 25e440b493SArthur Eubanks // less obvious. If an optimization pass appears to be introducing a warning, 26e440b493SArthur Eubanks // it may be that the optimization pass is merely exposing an existing 27e440b493SArthur Eubanks // condition in the code. 28e440b493SArthur Eubanks // 29e440b493SArthur Eubanks // This code may be run before instcombine. In many cases, instcombine checks 30e440b493SArthur Eubanks // for the same kinds of things and turns instructions with undefined behavior 31e440b493SArthur Eubanks // into unreachable (or equivalent). Because of this, this pass makes some 32e440b493SArthur Eubanks // effort to look through bitcasts and so on. 33e440b493SArthur Eubanks // 34e440b493SArthur Eubanks //===----------------------------------------------------------------------===// 35e440b493SArthur Eubanks 36e440b493SArthur Eubanks #include "llvm/Analysis/Lint.h" 37e440b493SArthur Eubanks #include "llvm/ADT/APInt.h" 38e440b493SArthur Eubanks #include "llvm/ADT/ArrayRef.h" 39e440b493SArthur Eubanks #include "llvm/ADT/SmallPtrSet.h" 40e440b493SArthur Eubanks #include "llvm/ADT/Twine.h" 41e440b493SArthur Eubanks #include "llvm/Analysis/AliasAnalysis.h" 42e440b493SArthur Eubanks #include "llvm/Analysis/AssumptionCache.h" 43e440b493SArthur Eubanks #include "llvm/Analysis/ConstantFolding.h" 44e440b493SArthur Eubanks #include "llvm/Analysis/InstructionSimplify.h" 45e440b493SArthur Eubanks #include "llvm/Analysis/Loads.h" 46e440b493SArthur Eubanks #include "llvm/Analysis/MemoryLocation.h" 47e440b493SArthur Eubanks #include "llvm/Analysis/TargetLibraryInfo.h" 48e440b493SArthur Eubanks #include "llvm/Analysis/ValueTracking.h" 49e440b493SArthur Eubanks #include "llvm/IR/Argument.h" 50e440b493SArthur Eubanks #include "llvm/IR/BasicBlock.h" 51e440b493SArthur Eubanks #include "llvm/IR/Constant.h" 52e440b493SArthur Eubanks #include "llvm/IR/Constants.h" 53e440b493SArthur Eubanks #include "llvm/IR/DataLayout.h" 54e440b493SArthur Eubanks #include "llvm/IR/DerivedTypes.h" 55e440b493SArthur Eubanks #include "llvm/IR/Dominators.h" 56e440b493SArthur Eubanks #include "llvm/IR/Function.h" 57e440b493SArthur Eubanks #include "llvm/IR/GlobalVariable.h" 58e440b493SArthur Eubanks #include "llvm/IR/InstVisitor.h" 59e440b493SArthur Eubanks #include "llvm/IR/InstrTypes.h" 60e440b493SArthur Eubanks #include "llvm/IR/Instruction.h" 61e440b493SArthur Eubanks #include "llvm/IR/Instructions.h" 62e440b493SArthur Eubanks #include "llvm/IR/IntrinsicInst.h" 63e440b493SArthur Eubanks #include "llvm/IR/LegacyPassManager.h" 64e440b493SArthur Eubanks #include "llvm/IR/Module.h" 65c9771391SArthur Eubanks #include "llvm/IR/PassManager.h" 66e440b493SArthur Eubanks #include "llvm/IR/Type.h" 67e440b493SArthur Eubanks #include "llvm/IR/Value.h" 68e440b493SArthur Eubanks #include "llvm/InitializePasses.h" 69e440b493SArthur Eubanks #include "llvm/Pass.h" 70e440b493SArthur Eubanks #include "llvm/Support/Casting.h" 71e440b493SArthur Eubanks #include "llvm/Support/KnownBits.h" 72e440b493SArthur Eubanks #include "llvm/Support/raw_ostream.h" 73e440b493SArthur Eubanks #include <cassert> 74e440b493SArthur Eubanks #include <cstdint> 75e440b493SArthur Eubanks #include <iterator> 76e440b493SArthur Eubanks #include <string> 77e440b493SArthur Eubanks 78e440b493SArthur Eubanks using namespace llvm; 79e440b493SArthur Eubanks 80e440b493SArthur Eubanks namespace { 81e440b493SArthur Eubanks namespace MemRef { 82e440b493SArthur Eubanks static const unsigned Read = 1; 83e440b493SArthur Eubanks static const unsigned Write = 2; 84e440b493SArthur Eubanks static const unsigned Callee = 4; 85e440b493SArthur Eubanks static const unsigned Branchee = 8; 86e440b493SArthur Eubanks } // end namespace MemRef 87e440b493SArthur Eubanks 88c9771391SArthur Eubanks class Lint : public InstVisitor<Lint> { 89e440b493SArthur Eubanks friend class InstVisitor<Lint>; 90e440b493SArthur Eubanks 91e440b493SArthur Eubanks void visitFunction(Function &F); 92e440b493SArthur Eubanks 93e440b493SArthur Eubanks void visitCallBase(CallBase &CB); 9422ec72f8SNikita Popov void visitMemoryReference(Instruction &I, const MemoryLocation &Loc, 95e440b493SArthur Eubanks MaybeAlign Alignment, Type *Ty, unsigned Flags); 96e440b493SArthur Eubanks void visitEHBeginCatch(IntrinsicInst *II); 97e440b493SArthur Eubanks void visitEHEndCatch(IntrinsicInst *II); 98e440b493SArthur Eubanks 99e440b493SArthur Eubanks void visitReturnInst(ReturnInst &I); 100e440b493SArthur Eubanks void visitLoadInst(LoadInst &I); 101e440b493SArthur Eubanks void visitStoreInst(StoreInst &I); 102e440b493SArthur Eubanks void visitXor(BinaryOperator &I); 103e440b493SArthur Eubanks void visitSub(BinaryOperator &I); 104e440b493SArthur Eubanks void visitLShr(BinaryOperator &I); 105e440b493SArthur Eubanks void visitAShr(BinaryOperator &I); 106e440b493SArthur Eubanks void visitShl(BinaryOperator &I); 107e440b493SArthur Eubanks void visitSDiv(BinaryOperator &I); 108e440b493SArthur Eubanks void visitUDiv(BinaryOperator &I); 109e440b493SArthur Eubanks void visitSRem(BinaryOperator &I); 110e440b493SArthur Eubanks void visitURem(BinaryOperator &I); 111e440b493SArthur Eubanks void visitAllocaInst(AllocaInst &I); 112e440b493SArthur Eubanks void visitVAArgInst(VAArgInst &I); 113e440b493SArthur Eubanks void visitIndirectBrInst(IndirectBrInst &I); 114e440b493SArthur Eubanks void visitExtractElementInst(ExtractElementInst &I); 115e440b493SArthur Eubanks void visitInsertElementInst(InsertElementInst &I); 116e440b493SArthur Eubanks void visitUnreachableInst(UnreachableInst &I); 117e440b493SArthur Eubanks 118e440b493SArthur Eubanks Value *findValue(Value *V, bool OffsetOk) const; 119e440b493SArthur Eubanks Value *findValueImpl(Value *V, bool OffsetOk, 120e440b493SArthur Eubanks SmallPtrSetImpl<Value *> &Visited) const; 121e440b493SArthur Eubanks 122e440b493SArthur Eubanks public: 123e440b493SArthur Eubanks Module *Mod; 124e440b493SArthur Eubanks const DataLayout *DL; 125e440b493SArthur Eubanks AliasAnalysis *AA; 126e440b493SArthur Eubanks AssumptionCache *AC; 127e440b493SArthur Eubanks DominatorTree *DT; 128e440b493SArthur Eubanks TargetLibraryInfo *TLI; 129e440b493SArthur Eubanks 130e440b493SArthur Eubanks std::string Messages; 131e440b493SArthur Eubanks raw_string_ostream MessagesStr; 132e440b493SArthur Eubanks 133c9771391SArthur Eubanks Lint(Module *Mod, const DataLayout *DL, AliasAnalysis *AA, 134c9771391SArthur Eubanks AssumptionCache *AC, DominatorTree *DT, TargetLibraryInfo *TLI) 135c9771391SArthur Eubanks : Mod(Mod), DL(DL), AA(AA), AC(AC), DT(DT), TLI(TLI), 136c9771391SArthur Eubanks MessagesStr(Messages) {} 137e440b493SArthur Eubanks 138e440b493SArthur Eubanks void WriteValues(ArrayRef<const Value *> Vs) { 139e440b493SArthur Eubanks for (const Value *V : Vs) { 140e440b493SArthur Eubanks if (!V) 141e440b493SArthur Eubanks continue; 142e440b493SArthur Eubanks if (isa<Instruction>(V)) { 143e440b493SArthur Eubanks MessagesStr << *V << '\n'; 144e440b493SArthur Eubanks } else { 145e440b493SArthur Eubanks V->printAsOperand(MessagesStr, true, Mod); 146e440b493SArthur Eubanks MessagesStr << '\n'; 147e440b493SArthur Eubanks } 148e440b493SArthur Eubanks } 149e440b493SArthur Eubanks } 150e440b493SArthur Eubanks 151e440b493SArthur Eubanks /// A check failed, so printout out the condition and the message. 152e440b493SArthur Eubanks /// 153e440b493SArthur Eubanks /// This provides a nice place to put a breakpoint if you want to see why 154e440b493SArthur Eubanks /// something is not correct. 155e440b493SArthur Eubanks void CheckFailed(const Twine &Message) { MessagesStr << Message << '\n'; } 156e440b493SArthur Eubanks 157e440b493SArthur Eubanks /// A check failed (with values to print). 158e440b493SArthur Eubanks /// 159e440b493SArthur Eubanks /// This calls the Message-only version so that the above is easier to set 160e440b493SArthur Eubanks /// a breakpoint on. 161e440b493SArthur Eubanks template <typename T1, typename... Ts> 162e440b493SArthur Eubanks void CheckFailed(const Twine &Message, const T1 &V1, const Ts &... Vs) { 163e440b493SArthur Eubanks CheckFailed(Message); 164e440b493SArthur Eubanks WriteValues({V1, Vs...}); 165e440b493SArthur Eubanks } 166e440b493SArthur Eubanks }; 167e440b493SArthur Eubanks } // end anonymous namespace 168e440b493SArthur Eubanks 169c54ad136STom Honermann // Check - We know that cond should be true, if not print an error message. 170c54ad136STom Honermann #define Check(C, ...) \ 171c9771391SArthur Eubanks do { \ 172c9771391SArthur Eubanks if (!(C)) { \ 173c9771391SArthur Eubanks CheckFailed(__VA_ARGS__); \ 174c9771391SArthur Eubanks return; \ 175c9771391SArthur Eubanks } \ 176c9771391SArthur Eubanks } while (false) 177e440b493SArthur Eubanks 178e440b493SArthur Eubanks void Lint::visitFunction(Function &F) { 179e440b493SArthur Eubanks // This isn't undefined behavior, it's just a little unusual, and it's a 180e440b493SArthur Eubanks // fairly common mistake to neglect to name a function. 181c54ad136STom Honermann Check(F.hasName() || F.hasLocalLinkage(), 182e440b493SArthur Eubanks "Unusual: Unnamed function with non-local linkage", &F); 183e440b493SArthur Eubanks 184e440b493SArthur Eubanks // TODO: Check for irreducible control flow. 185e440b493SArthur Eubanks } 186e440b493SArthur Eubanks 187e440b493SArthur Eubanks void Lint::visitCallBase(CallBase &I) { 188e440b493SArthur Eubanks Value *Callee = I.getCalledOperand(); 189e440b493SArthur Eubanks 1904df8efceSNikita Popov visitMemoryReference(I, MemoryLocation::getAfter(Callee), None, nullptr, 1914df8efceSNikita Popov MemRef::Callee); 192e440b493SArthur Eubanks 193e440b493SArthur Eubanks if (Function *F = dyn_cast<Function>(findValue(Callee, 194e440b493SArthur Eubanks /*OffsetOk=*/false))) { 195c54ad136STom Honermann Check(I.getCallingConv() == F->getCallingConv(), 196e440b493SArthur Eubanks "Undefined behavior: Caller and callee calling convention differ", 197e440b493SArthur Eubanks &I); 198e440b493SArthur Eubanks 199e440b493SArthur Eubanks FunctionType *FT = F->getFunctionType(); 200e440b493SArthur Eubanks unsigned NumActualArgs = I.arg_size(); 201e440b493SArthur Eubanks 202c54ad136STom Honermann Check(FT->isVarArg() ? FT->getNumParams() <= NumActualArgs 203e440b493SArthur Eubanks : FT->getNumParams() == NumActualArgs, 204e440b493SArthur Eubanks "Undefined behavior: Call argument count mismatches callee " 205e440b493SArthur Eubanks "argument count", 206e440b493SArthur Eubanks &I); 207e440b493SArthur Eubanks 208c54ad136STom Honermann Check(FT->getReturnType() == I.getType(), 209e440b493SArthur Eubanks "Undefined behavior: Call return type mismatches " 210e440b493SArthur Eubanks "callee return type", 211e440b493SArthur Eubanks &I); 212e440b493SArthur Eubanks 213e440b493SArthur Eubanks // Check argument types (in case the callee was casted) and attributes. 214e440b493SArthur Eubanks // TODO: Verify that caller and callee attributes are compatible. 215e440b493SArthur Eubanks Function::arg_iterator PI = F->arg_begin(), PE = F->arg_end(); 216e440b493SArthur Eubanks auto AI = I.arg_begin(), AE = I.arg_end(); 217e440b493SArthur Eubanks for (; AI != AE; ++AI) { 218e440b493SArthur Eubanks Value *Actual = *AI; 219e440b493SArthur Eubanks if (PI != PE) { 220e440b493SArthur Eubanks Argument *Formal = &*PI++; 221c54ad136STom Honermann Check(Formal->getType() == Actual->getType(), 222e440b493SArthur Eubanks "Undefined behavior: Call argument type mismatches " 223e440b493SArthur Eubanks "callee parameter type", 224e440b493SArthur Eubanks &I); 225e440b493SArthur Eubanks 226e440b493SArthur Eubanks // Check that noalias arguments don't alias other arguments. This is 227e440b493SArthur Eubanks // not fully precise because we don't know the sizes of the dereferenced 228e440b493SArthur Eubanks // memory regions. 229e440b493SArthur Eubanks if (Formal->hasNoAliasAttr() && Actual->getType()->isPointerTy()) { 230e440b493SArthur Eubanks AttributeList PAL = I.getAttributes(); 231e440b493SArthur Eubanks unsigned ArgNo = 0; 232e440b493SArthur Eubanks for (auto BI = I.arg_begin(); BI != AE; ++BI, ++ArgNo) { 233e440b493SArthur Eubanks // Skip ByVal arguments since they will be memcpy'd to the callee's 234e440b493SArthur Eubanks // stack so we're not really passing the pointer anyway. 235a0c42ca5SArthur Eubanks if (PAL.hasParamAttr(ArgNo, Attribute::ByVal)) 236e440b493SArthur Eubanks continue; 237e440b493SArthur Eubanks // If both arguments are readonly, they have no dependence. 238e440b493SArthur Eubanks if (Formal->onlyReadsMemory() && I.onlyReadsMemory(ArgNo)) 239e440b493SArthur Eubanks continue; 240e440b493SArthur Eubanks if (AI != BI && (*BI)->getType()->isPointerTy()) { 241e440b493SArthur Eubanks AliasResult Result = AA->alias(*AI, *BI); 242c54ad136STom Honermann Check(Result != AliasResult::MustAlias && 243d0660797Sdfukalov Result != AliasResult::PartialAlias, 244e440b493SArthur Eubanks "Unusual: noalias argument aliases another argument", &I); 245e440b493SArthur Eubanks } 246e440b493SArthur Eubanks } 247e440b493SArthur Eubanks } 248e440b493SArthur Eubanks 249e440b493SArthur Eubanks // Check that an sret argument points to valid memory. 250e440b493SArthur Eubanks if (Formal->hasStructRetAttr() && Actual->getType()->isPointerTy()) { 251d65a7003SMatt Arsenault Type *Ty = Formal->getParamStructRetType(); 25222ec72f8SNikita Popov MemoryLocation Loc( 25322ec72f8SNikita Popov Actual, LocationSize::precise(DL->getTypeStoreSize(Ty))); 25422ec72f8SNikita Popov visitMemoryReference(I, Loc, DL->getABITypeAlign(Ty), Ty, 255e440b493SArthur Eubanks MemRef::Read | MemRef::Write); 256e440b493SArthur Eubanks } 257e440b493SArthur Eubanks } 258e440b493SArthur Eubanks } 259e440b493SArthur Eubanks } 260e440b493SArthur Eubanks 261e440b493SArthur Eubanks if (const auto *CI = dyn_cast<CallInst>(&I)) { 262e440b493SArthur Eubanks if (CI->isTailCall()) { 263e440b493SArthur Eubanks const AttributeList &PAL = CI->getAttributes(); 264e440b493SArthur Eubanks unsigned ArgNo = 0; 265e440b493SArthur Eubanks for (Value *Arg : I.args()) { 266e440b493SArthur Eubanks // Skip ByVal arguments since they will be memcpy'd to the callee's 267e440b493SArthur Eubanks // stack anyway. 268a0c42ca5SArthur Eubanks if (PAL.hasParamAttr(ArgNo++, Attribute::ByVal)) 269e440b493SArthur Eubanks continue; 270e440b493SArthur Eubanks Value *Obj = findValue(Arg, /*OffsetOk=*/true); 271c54ad136STom Honermann Check(!isa<AllocaInst>(Obj), 272e440b493SArthur Eubanks "Undefined behavior: Call with \"tail\" keyword references " 273e440b493SArthur Eubanks "alloca", 274e440b493SArthur Eubanks &I); 275e440b493SArthur Eubanks } 276e440b493SArthur Eubanks } 277e440b493SArthur Eubanks } 278e440b493SArthur Eubanks 279e440b493SArthur Eubanks if (IntrinsicInst *II = dyn_cast<IntrinsicInst>(&I)) 280e440b493SArthur Eubanks switch (II->getIntrinsicID()) { 281c9771391SArthur Eubanks default: 282c9771391SArthur Eubanks break; 283e440b493SArthur Eubanks 284e440b493SArthur Eubanks // TODO: Check more intrinsics 285e440b493SArthur Eubanks 286e440b493SArthur Eubanks case Intrinsic::memcpy: { 287e440b493SArthur Eubanks MemCpyInst *MCI = cast<MemCpyInst>(&I); 28822ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForDest(MCI), 289e440b493SArthur Eubanks MCI->getDestAlign(), nullptr, MemRef::Write); 29022ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForSource(MCI), 291e440b493SArthur Eubanks MCI->getSourceAlign(), nullptr, MemRef::Read); 292e440b493SArthur Eubanks 293e440b493SArthur Eubanks // Check that the memcpy arguments don't overlap. The AliasAnalysis API 294e440b493SArthur Eubanks // isn't expressive enough for what we really want to do. Known partial 295e440b493SArthur Eubanks // overlap is not distinguished from the case where nothing is known. 2964df8efceSNikita Popov auto Size = LocationSize::afterPointer(); 297e440b493SArthur Eubanks if (const ConstantInt *Len = 298e440b493SArthur Eubanks dyn_cast<ConstantInt>(findValue(MCI->getLength(), 299e440b493SArthur Eubanks /*OffsetOk=*/false))) 300e440b493SArthur Eubanks if (Len->getValue().isIntN(32)) 301e440b493SArthur Eubanks Size = LocationSize::precise(Len->getValue().getZExtValue()); 302c54ad136STom Honermann Check(AA->alias(MCI->getSource(), Size, MCI->getDest(), Size) != 303d0660797Sdfukalov AliasResult::MustAlias, 304e440b493SArthur Eubanks "Undefined behavior: memcpy source and destination overlap", &I); 305e440b493SArthur Eubanks break; 306e440b493SArthur Eubanks } 307e440b493SArthur Eubanks case Intrinsic::memcpy_inline: { 308e440b493SArthur Eubanks MemCpyInlineInst *MCII = cast<MemCpyInlineInst>(&I); 309e440b493SArthur Eubanks const uint64_t Size = MCII->getLength()->getValue().getLimitedValue(); 31022ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForDest(MCII), 31122ec72f8SNikita Popov MCII->getDestAlign(), nullptr, MemRef::Write); 31222ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForSource(MCII), 31322ec72f8SNikita Popov MCII->getSourceAlign(), nullptr, MemRef::Read); 314e440b493SArthur Eubanks 315e440b493SArthur Eubanks // Check that the memcpy arguments don't overlap. The AliasAnalysis API 316e440b493SArthur Eubanks // isn't expressive enough for what we really want to do. Known partial 317e440b493SArthur Eubanks // overlap is not distinguished from the case where nothing is known. 318e440b493SArthur Eubanks const LocationSize LS = LocationSize::precise(Size); 319c54ad136STom Honermann Check(AA->alias(MCII->getSource(), LS, MCII->getDest(), LS) != 320d0660797Sdfukalov AliasResult::MustAlias, 321e440b493SArthur Eubanks "Undefined behavior: memcpy source and destination overlap", &I); 322e440b493SArthur Eubanks break; 323e440b493SArthur Eubanks } 324e440b493SArthur Eubanks case Intrinsic::memmove: { 325e440b493SArthur Eubanks MemMoveInst *MMI = cast<MemMoveInst>(&I); 32622ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForDest(MMI), 327e440b493SArthur Eubanks MMI->getDestAlign(), nullptr, MemRef::Write); 32822ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForSource(MMI), 329e440b493SArthur Eubanks MMI->getSourceAlign(), nullptr, MemRef::Read); 330e440b493SArthur Eubanks break; 331e440b493SArthur Eubanks } 332e440b493SArthur Eubanks case Intrinsic::memset: { 333e440b493SArthur Eubanks MemSetInst *MSI = cast<MemSetInst>(&I); 33422ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForDest(MSI), 335e440b493SArthur Eubanks MSI->getDestAlign(), nullptr, MemRef::Write); 336e440b493SArthur Eubanks break; 337e440b493SArthur Eubanks } 338e440b493SArthur Eubanks 339e440b493SArthur Eubanks case Intrinsic::vastart: 340c54ad136STom Honermann Check(I.getParent()->getParent()->isVarArg(), 341e440b493SArthur Eubanks "Undefined behavior: va_start called in a non-varargs function", 342e440b493SArthur Eubanks &I); 343e440b493SArthur Eubanks 34422ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForArgument(&I, 0, TLI), None, 34522ec72f8SNikita Popov nullptr, MemRef::Read | MemRef::Write); 346e440b493SArthur Eubanks break; 347e440b493SArthur Eubanks case Intrinsic::vacopy: 34822ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForArgument(&I, 0, TLI), None, 34922ec72f8SNikita Popov nullptr, MemRef::Write); 35022ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForArgument(&I, 1, TLI), None, 35122ec72f8SNikita Popov nullptr, MemRef::Read); 352e440b493SArthur Eubanks break; 353e440b493SArthur Eubanks case Intrinsic::vaend: 35422ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForArgument(&I, 0, TLI), None, 35522ec72f8SNikita Popov nullptr, MemRef::Read | MemRef::Write); 356e440b493SArthur Eubanks break; 357e440b493SArthur Eubanks 358e440b493SArthur Eubanks case Intrinsic::stackrestore: 359e440b493SArthur Eubanks // Stackrestore doesn't read or write memory, but it sets the 360e440b493SArthur Eubanks // stack pointer, which the compiler may read from or write to 361e440b493SArthur Eubanks // at any time, so check it for both readability and writeability. 36222ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::getForArgument(&I, 0, TLI), None, 36322ec72f8SNikita Popov nullptr, MemRef::Read | MemRef::Write); 364e440b493SArthur Eubanks break; 3656637d72dSSjoerd Meijer case Intrinsic::get_active_lane_mask: 3666637d72dSSjoerd Meijer if (auto *TripCount = dyn_cast<ConstantInt>(I.getArgOperand(1))) 367c54ad136STom Honermann Check(!TripCount->isZero(), 368c54ad136STom Honermann "get_active_lane_mask: operand #2 " 369c54ad136STom Honermann "must be greater than 0", 370c54ad136STom Honermann &I); 3716637d72dSSjoerd Meijer break; 372e440b493SArthur Eubanks } 373e440b493SArthur Eubanks } 374e440b493SArthur Eubanks 375e440b493SArthur Eubanks void Lint::visitReturnInst(ReturnInst &I) { 376e440b493SArthur Eubanks Function *F = I.getParent()->getParent(); 377c54ad136STom Honermann Check(!F->doesNotReturn(), 378e440b493SArthur Eubanks "Unusual: Return statement in function with noreturn attribute", &I); 379e440b493SArthur Eubanks 380e440b493SArthur Eubanks if (Value *V = I.getReturnValue()) { 381e440b493SArthur Eubanks Value *Obj = findValue(V, /*OffsetOk=*/true); 382c54ad136STom Honermann Check(!isa<AllocaInst>(Obj), "Unusual: Returning alloca value", &I); 383e440b493SArthur Eubanks } 384e440b493SArthur Eubanks } 385e440b493SArthur Eubanks 386e440b493SArthur Eubanks // TODO: Check that the reference is in bounds. 387e440b493SArthur Eubanks // TODO: Check readnone/readonly function attributes. 38822ec72f8SNikita Popov void Lint::visitMemoryReference(Instruction &I, const MemoryLocation &Loc, 389e440b493SArthur Eubanks MaybeAlign Align, Type *Ty, unsigned Flags) { 390e440b493SArthur Eubanks // If no memory is being referenced, it doesn't matter if the pointer 391e440b493SArthur Eubanks // is valid. 39222ec72f8SNikita Popov if (Loc.Size.isZero()) 393e440b493SArthur Eubanks return; 394e440b493SArthur Eubanks 39522ec72f8SNikita Popov Value *Ptr = const_cast<Value *>(Loc.Ptr); 396e440b493SArthur Eubanks Value *UnderlyingObject = findValue(Ptr, /*OffsetOk=*/true); 397c54ad136STom Honermann Check(!isa<ConstantPointerNull>(UnderlyingObject), 398e440b493SArthur Eubanks "Undefined behavior: Null pointer dereference", &I); 399c54ad136STom Honermann Check(!isa<UndefValue>(UnderlyingObject), 400e440b493SArthur Eubanks "Undefined behavior: Undef pointer dereference", &I); 401c54ad136STom Honermann Check(!isa<ConstantInt>(UnderlyingObject) || 402e440b493SArthur Eubanks !cast<ConstantInt>(UnderlyingObject)->isMinusOne(), 403e440b493SArthur Eubanks "Unusual: All-ones pointer dereference", &I); 404c54ad136STom Honermann Check(!isa<ConstantInt>(UnderlyingObject) || 405e440b493SArthur Eubanks !cast<ConstantInt>(UnderlyingObject)->isOne(), 406e440b493SArthur Eubanks "Unusual: Address one pointer dereference", &I); 407e440b493SArthur Eubanks 408e440b493SArthur Eubanks if (Flags & MemRef::Write) { 409e440b493SArthur Eubanks if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(UnderlyingObject)) 410c54ad136STom Honermann Check(!GV->isConstant(), "Undefined behavior: Write to read-only memory", 411e440b493SArthur Eubanks &I); 412c54ad136STom Honermann Check(!isa<Function>(UnderlyingObject) && 413e440b493SArthur Eubanks !isa<BlockAddress>(UnderlyingObject), 414e440b493SArthur Eubanks "Undefined behavior: Write to text section", &I); 415e440b493SArthur Eubanks } 416e440b493SArthur Eubanks if (Flags & MemRef::Read) { 417c54ad136STom Honermann Check(!isa<Function>(UnderlyingObject), "Unusual: Load from function body", 418e440b493SArthur Eubanks &I); 419c54ad136STom Honermann Check(!isa<BlockAddress>(UnderlyingObject), 420e440b493SArthur Eubanks "Undefined behavior: Load from block address", &I); 421e440b493SArthur Eubanks } 422e440b493SArthur Eubanks if (Flags & MemRef::Callee) { 423c54ad136STom Honermann Check(!isa<BlockAddress>(UnderlyingObject), 424e440b493SArthur Eubanks "Undefined behavior: Call to block address", &I); 425e440b493SArthur Eubanks } 426e440b493SArthur Eubanks if (Flags & MemRef::Branchee) { 427c54ad136STom Honermann Check(!isa<Constant>(UnderlyingObject) || 428e440b493SArthur Eubanks isa<BlockAddress>(UnderlyingObject), 429e440b493SArthur Eubanks "Undefined behavior: Branch to non-blockaddress", &I); 430e440b493SArthur Eubanks } 431e440b493SArthur Eubanks 432e440b493SArthur Eubanks // Check for buffer overflows and misalignment. 433e440b493SArthur Eubanks // Only handles memory references that read/write something simple like an 434e440b493SArthur Eubanks // alloca instruction or a global variable. 435e440b493SArthur Eubanks int64_t Offset = 0; 436e440b493SArthur Eubanks if (Value *Base = GetPointerBaseWithConstantOffset(Ptr, Offset, *DL)) { 437e440b493SArthur Eubanks // OK, so the access is to a constant offset from Ptr. Check that Ptr is 438e440b493SArthur Eubanks // something we can handle and if so extract the size of this base object 439e440b493SArthur Eubanks // along with its alignment. 440e440b493SArthur Eubanks uint64_t BaseSize = MemoryLocation::UnknownSize; 441e440b493SArthur Eubanks MaybeAlign BaseAlign; 442e440b493SArthur Eubanks 443e440b493SArthur Eubanks if (AllocaInst *AI = dyn_cast<AllocaInst>(Base)) { 444e440b493SArthur Eubanks Type *ATy = AI->getAllocatedType(); 445e440b493SArthur Eubanks if (!AI->isArrayAllocation() && ATy->isSized()) 446e440b493SArthur Eubanks BaseSize = DL->getTypeAllocSize(ATy); 447e440b493SArthur Eubanks BaseAlign = AI->getAlign(); 448e440b493SArthur Eubanks } else if (GlobalVariable *GV = dyn_cast<GlobalVariable>(Base)) { 449e440b493SArthur Eubanks // If the global may be defined differently in another compilation unit 450e440b493SArthur Eubanks // then don't warn about funky memory accesses. 451e440b493SArthur Eubanks if (GV->hasDefinitiveInitializer()) { 452e440b493SArthur Eubanks Type *GTy = GV->getValueType(); 453e440b493SArthur Eubanks if (GTy->isSized()) 454e440b493SArthur Eubanks BaseSize = DL->getTypeAllocSize(GTy); 455e440b493SArthur Eubanks BaseAlign = GV->getAlign(); 456e440b493SArthur Eubanks if (!BaseAlign && GTy->isSized()) 457e440b493SArthur Eubanks BaseAlign = DL->getABITypeAlign(GTy); 458e440b493SArthur Eubanks } 459e440b493SArthur Eubanks } 460e440b493SArthur Eubanks 461e440b493SArthur Eubanks // Accesses from before the start or after the end of the object are not 462e440b493SArthur Eubanks // defined. 463c54ad136STom Honermann Check(!Loc.Size.hasValue() || BaseSize == MemoryLocation::UnknownSize || 46422ec72f8SNikita Popov (Offset >= 0 && Offset + Loc.Size.getValue() <= BaseSize), 465e440b493SArthur Eubanks "Undefined behavior: Buffer overflow", &I); 466e440b493SArthur Eubanks 467e440b493SArthur Eubanks // Accesses that say that the memory is more aligned than it is are not 468e440b493SArthur Eubanks // defined. 469e440b493SArthur Eubanks if (!Align && Ty && Ty->isSized()) 470e440b493SArthur Eubanks Align = DL->getABITypeAlign(Ty); 471e440b493SArthur Eubanks if (BaseAlign && Align) 472c54ad136STom Honermann Check(*Align <= commonAlignment(*BaseAlign, Offset), 473e440b493SArthur Eubanks "Undefined behavior: Memory reference address is misaligned", &I); 474e440b493SArthur Eubanks } 475e440b493SArthur Eubanks } 476e440b493SArthur Eubanks 477e440b493SArthur Eubanks void Lint::visitLoadInst(LoadInst &I) { 47822ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::get(&I), I.getAlign(), I.getType(), 47922ec72f8SNikita Popov MemRef::Read); 480e440b493SArthur Eubanks } 481e440b493SArthur Eubanks 482e440b493SArthur Eubanks void Lint::visitStoreInst(StoreInst &I) { 48322ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::get(&I), I.getAlign(), 48422ec72f8SNikita Popov I.getOperand(0)->getType(), MemRef::Write); 485e440b493SArthur Eubanks } 486e440b493SArthur Eubanks 487e440b493SArthur Eubanks void Lint::visitXor(BinaryOperator &I) { 488c54ad136STom Honermann Check(!isa<UndefValue>(I.getOperand(0)) || !isa<UndefValue>(I.getOperand(1)), 489e440b493SArthur Eubanks "Undefined result: xor(undef, undef)", &I); 490e440b493SArthur Eubanks } 491e440b493SArthur Eubanks 492e440b493SArthur Eubanks void Lint::visitSub(BinaryOperator &I) { 493c54ad136STom Honermann Check(!isa<UndefValue>(I.getOperand(0)) || !isa<UndefValue>(I.getOperand(1)), 494e440b493SArthur Eubanks "Undefined result: sub(undef, undef)", &I); 495e440b493SArthur Eubanks } 496e440b493SArthur Eubanks 497e440b493SArthur Eubanks void Lint::visitLShr(BinaryOperator &I) { 498e440b493SArthur Eubanks if (ConstantInt *CI = dyn_cast<ConstantInt>(findValue(I.getOperand(1), 499e440b493SArthur Eubanks /*OffsetOk=*/false))) 500c54ad136STom Honermann Check(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()), 501e440b493SArthur Eubanks "Undefined result: Shift count out of range", &I); 502e440b493SArthur Eubanks } 503e440b493SArthur Eubanks 504e440b493SArthur Eubanks void Lint::visitAShr(BinaryOperator &I) { 505e440b493SArthur Eubanks if (ConstantInt *CI = 506e440b493SArthur Eubanks dyn_cast<ConstantInt>(findValue(I.getOperand(1), /*OffsetOk=*/false))) 507c54ad136STom Honermann Check(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()), 508e440b493SArthur Eubanks "Undefined result: Shift count out of range", &I); 509e440b493SArthur Eubanks } 510e440b493SArthur Eubanks 511e440b493SArthur Eubanks void Lint::visitShl(BinaryOperator &I) { 512e440b493SArthur Eubanks if (ConstantInt *CI = 513e440b493SArthur Eubanks dyn_cast<ConstantInt>(findValue(I.getOperand(1), /*OffsetOk=*/false))) 514c54ad136STom Honermann Check(CI->getValue().ult(cast<IntegerType>(I.getType())->getBitWidth()), 515e440b493SArthur Eubanks "Undefined result: Shift count out of range", &I); 516e440b493SArthur Eubanks } 517e440b493SArthur Eubanks 518e440b493SArthur Eubanks static bool isZero(Value *V, const DataLayout &DL, DominatorTree *DT, 519e440b493SArthur Eubanks AssumptionCache *AC) { 520e440b493SArthur Eubanks // Assume undef could be zero. 521e440b493SArthur Eubanks if (isa<UndefValue>(V)) 522e440b493SArthur Eubanks return true; 523e440b493SArthur Eubanks 524e440b493SArthur Eubanks VectorType *VecTy = dyn_cast<VectorType>(V->getType()); 525e440b493SArthur Eubanks if (!VecTy) { 526c9771391SArthur Eubanks KnownBits Known = 527c9771391SArthur Eubanks computeKnownBits(V, DL, 0, AC, dyn_cast<Instruction>(V), DT); 528e440b493SArthur Eubanks return Known.isZero(); 529e440b493SArthur Eubanks } 530e440b493SArthur Eubanks 531e440b493SArthur Eubanks // Per-component check doesn't work with zeroinitializer 532e440b493SArthur Eubanks Constant *C = dyn_cast<Constant>(V); 533e440b493SArthur Eubanks if (!C) 534e440b493SArthur Eubanks return false; 535e440b493SArthur Eubanks 536e440b493SArthur Eubanks if (C->isZeroValue()) 537e440b493SArthur Eubanks return true; 538e440b493SArthur Eubanks 539e440b493SArthur Eubanks // For a vector, KnownZero will only be true if all values are zero, so check 540e440b493SArthur Eubanks // this per component 541e440b493SArthur Eubanks for (unsigned I = 0, N = cast<FixedVectorType>(VecTy)->getNumElements(); 542e440b493SArthur Eubanks I != N; ++I) { 543e440b493SArthur Eubanks Constant *Elem = C->getAggregateElement(I); 544e440b493SArthur Eubanks if (isa<UndefValue>(Elem)) 545e440b493SArthur Eubanks return true; 546e440b493SArthur Eubanks 547e440b493SArthur Eubanks KnownBits Known = computeKnownBits(Elem, DL); 548e440b493SArthur Eubanks if (Known.isZero()) 549e440b493SArthur Eubanks return true; 550e440b493SArthur Eubanks } 551e440b493SArthur Eubanks 552e440b493SArthur Eubanks return false; 553e440b493SArthur Eubanks } 554e440b493SArthur Eubanks 555e440b493SArthur Eubanks void Lint::visitSDiv(BinaryOperator &I) { 556c54ad136STom Honermann Check(!isZero(I.getOperand(1), I.getModule()->getDataLayout(), DT, AC), 557e440b493SArthur Eubanks "Undefined behavior: Division by zero", &I); 558e440b493SArthur Eubanks } 559e440b493SArthur Eubanks 560e440b493SArthur Eubanks void Lint::visitUDiv(BinaryOperator &I) { 561c54ad136STom Honermann Check(!isZero(I.getOperand(1), I.getModule()->getDataLayout(), DT, AC), 562e440b493SArthur Eubanks "Undefined behavior: Division by zero", &I); 563e440b493SArthur Eubanks } 564e440b493SArthur Eubanks 565e440b493SArthur Eubanks void Lint::visitSRem(BinaryOperator &I) { 566c54ad136STom Honermann Check(!isZero(I.getOperand(1), I.getModule()->getDataLayout(), DT, AC), 567e440b493SArthur Eubanks "Undefined behavior: Division by zero", &I); 568e440b493SArthur Eubanks } 569e440b493SArthur Eubanks 570e440b493SArthur Eubanks void Lint::visitURem(BinaryOperator &I) { 571c54ad136STom Honermann Check(!isZero(I.getOperand(1), I.getModule()->getDataLayout(), DT, AC), 572e440b493SArthur Eubanks "Undefined behavior: Division by zero", &I); 573e440b493SArthur Eubanks } 574e440b493SArthur Eubanks 575e440b493SArthur Eubanks void Lint::visitAllocaInst(AllocaInst &I) { 576e440b493SArthur Eubanks if (isa<ConstantInt>(I.getArraySize())) 577e440b493SArthur Eubanks // This isn't undefined behavior, it's just an obvious pessimization. 578c54ad136STom Honermann Check(&I.getParent()->getParent()->getEntryBlock() == I.getParent(), 579e440b493SArthur Eubanks "Pessimization: Static alloca outside of entry block", &I); 580e440b493SArthur Eubanks 581e440b493SArthur Eubanks // TODO: Check for an unusual size (MSB set?) 582e440b493SArthur Eubanks } 583e440b493SArthur Eubanks 584e440b493SArthur Eubanks void Lint::visitVAArgInst(VAArgInst &I) { 58522ec72f8SNikita Popov visitMemoryReference(I, MemoryLocation::get(&I), None, nullptr, 58622ec72f8SNikita Popov MemRef::Read | MemRef::Write); 587e440b493SArthur Eubanks } 588e440b493SArthur Eubanks 589e440b493SArthur Eubanks void Lint::visitIndirectBrInst(IndirectBrInst &I) { 5904df8efceSNikita Popov visitMemoryReference(I, MemoryLocation::getAfter(I.getAddress()), None, 5914df8efceSNikita Popov nullptr, MemRef::Branchee); 592e440b493SArthur Eubanks 593c54ad136STom Honermann Check(I.getNumDestinations() != 0, 594e440b493SArthur Eubanks "Undefined behavior: indirectbr with no destinations", &I); 595e440b493SArthur Eubanks } 596e440b493SArthur Eubanks 597e440b493SArthur Eubanks void Lint::visitExtractElementInst(ExtractElementInst &I) { 598e440b493SArthur Eubanks if (ConstantInt *CI = dyn_cast<ConstantInt>(findValue(I.getIndexOperand(), 599e440b493SArthur Eubanks /*OffsetOk=*/false))) 600c54ad136STom Honermann Check( 601e440b493SArthur Eubanks CI->getValue().ult( 602e440b493SArthur Eubanks cast<FixedVectorType>(I.getVectorOperandType())->getNumElements()), 603e440b493SArthur Eubanks "Undefined result: extractelement index out of range", &I); 604e440b493SArthur Eubanks } 605e440b493SArthur Eubanks 606e440b493SArthur Eubanks void Lint::visitInsertElementInst(InsertElementInst &I) { 607e440b493SArthur Eubanks if (ConstantInt *CI = dyn_cast<ConstantInt>(findValue(I.getOperand(2), 608e440b493SArthur Eubanks /*OffsetOk=*/false))) 609c54ad136STom Honermann Check(CI->getValue().ult( 610e440b493SArthur Eubanks cast<FixedVectorType>(I.getType())->getNumElements()), 611e440b493SArthur Eubanks "Undefined result: insertelement index out of range", &I); 612e440b493SArthur Eubanks } 613e440b493SArthur Eubanks 614e440b493SArthur Eubanks void Lint::visitUnreachableInst(UnreachableInst &I) { 615e440b493SArthur Eubanks // This isn't undefined behavior, it's merely suspicious. 616c54ad136STom Honermann Check(&I == &I.getParent()->front() || 617e440b493SArthur Eubanks std::prev(I.getIterator())->mayHaveSideEffects(), 618e440b493SArthur Eubanks "Unusual: unreachable immediately preceded by instruction without " 619e440b493SArthur Eubanks "side effects", 620e440b493SArthur Eubanks &I); 621e440b493SArthur Eubanks } 622e440b493SArthur Eubanks 623e440b493SArthur Eubanks /// findValue - Look through bitcasts and simple memory reference patterns 624e440b493SArthur Eubanks /// to identify an equivalent, but more informative, value. If OffsetOk 625e440b493SArthur Eubanks /// is true, look through getelementptrs with non-zero offsets too. 626e440b493SArthur Eubanks /// 627e440b493SArthur Eubanks /// Most analysis passes don't require this logic, because instcombine 628e440b493SArthur Eubanks /// will simplify most of these kinds of things away. But it's a goal of 629e440b493SArthur Eubanks /// this Lint pass to be useful even on non-optimized IR. 630e440b493SArthur Eubanks Value *Lint::findValue(Value *V, bool OffsetOk) const { 631e440b493SArthur Eubanks SmallPtrSet<Value *, 4> Visited; 632e440b493SArthur Eubanks return findValueImpl(V, OffsetOk, Visited); 633e440b493SArthur Eubanks } 634e440b493SArthur Eubanks 635e440b493SArthur Eubanks /// findValueImpl - Implementation helper for findValue. 636e440b493SArthur Eubanks Value *Lint::findValueImpl(Value *V, bool OffsetOk, 637e440b493SArthur Eubanks SmallPtrSetImpl<Value *> &Visited) const { 638e440b493SArthur Eubanks // Detect self-referential values. 639e440b493SArthur Eubanks if (!Visited.insert(V).second) 640e440b493SArthur Eubanks return UndefValue::get(V->getType()); 641e440b493SArthur Eubanks 642e440b493SArthur Eubanks // TODO: Look through sext or zext cast, when the result is known to 643e440b493SArthur Eubanks // be interpreted as signed or unsigned, respectively. 644e440b493SArthur Eubanks // TODO: Look through eliminable cast pairs. 645e440b493SArthur Eubanks // TODO: Look through calls with unique return values. 646e440b493SArthur Eubanks // TODO: Look through vector insert/extract/shuffle. 647e440b493SArthur Eubanks V = OffsetOk ? getUnderlyingObject(V) : V->stripPointerCasts(); 648e440b493SArthur Eubanks if (LoadInst *L = dyn_cast<LoadInst>(V)) { 649e440b493SArthur Eubanks BasicBlock::iterator BBI = L->getIterator(); 650e440b493SArthur Eubanks BasicBlock *BB = L->getParent(); 651e440b493SArthur Eubanks SmallPtrSet<BasicBlock *, 4> VisitedBlocks; 652e440b493SArthur Eubanks for (;;) { 653e440b493SArthur Eubanks if (!VisitedBlocks.insert(BB).second) 654e440b493SArthur Eubanks break; 655e440b493SArthur Eubanks if (Value *U = 656e440b493SArthur Eubanks FindAvailableLoadedValue(L, BB, BBI, DefMaxInstsToScan, AA)) 657e440b493SArthur Eubanks return findValueImpl(U, OffsetOk, Visited); 658c9771391SArthur Eubanks if (BBI != BB->begin()) 659c9771391SArthur Eubanks break; 660e440b493SArthur Eubanks BB = BB->getUniquePredecessor(); 661c9771391SArthur Eubanks if (!BB) 662c9771391SArthur Eubanks break; 663e440b493SArthur Eubanks BBI = BB->end(); 664e440b493SArthur Eubanks } 665e440b493SArthur Eubanks } else if (PHINode *PN = dyn_cast<PHINode>(V)) { 666e440b493SArthur Eubanks if (Value *W = PN->hasConstantValue()) 667e440b493SArthur Eubanks return findValueImpl(W, OffsetOk, Visited); 668e440b493SArthur Eubanks } else if (CastInst *CI = dyn_cast<CastInst>(V)) { 669e440b493SArthur Eubanks if (CI->isNoopCast(*DL)) 670e440b493SArthur Eubanks return findValueImpl(CI->getOperand(0), OffsetOk, Visited); 671e440b493SArthur Eubanks } else if (ExtractValueInst *Ex = dyn_cast<ExtractValueInst>(V)) { 672c9771391SArthur Eubanks if (Value *W = 673c9771391SArthur Eubanks FindInsertedValue(Ex->getAggregateOperand(), Ex->getIndices())) 674e440b493SArthur Eubanks if (W != V) 675e440b493SArthur Eubanks return findValueImpl(W, OffsetOk, Visited); 676e440b493SArthur Eubanks } else if (ConstantExpr *CE = dyn_cast<ConstantExpr>(V)) { 677e440b493SArthur Eubanks // Same as above, but for ConstantExpr instead of Instruction. 678e440b493SArthur Eubanks if (Instruction::isCast(CE->getOpcode())) { 679e440b493SArthur Eubanks if (CastInst::isNoopCast(Instruction::CastOps(CE->getOpcode()), 680e440b493SArthur Eubanks CE->getOperand(0)->getType(), CE->getType(), 681e440b493SArthur Eubanks *DL)) 682e440b493SArthur Eubanks return findValueImpl(CE->getOperand(0), OffsetOk, Visited); 683e440b493SArthur Eubanks } else if (CE->getOpcode() == Instruction::ExtractValue) { 684e440b493SArthur Eubanks ArrayRef<unsigned> Indices = CE->getIndices(); 685e440b493SArthur Eubanks if (Value *W = FindInsertedValue(CE->getOperand(0), Indices)) 686e440b493SArthur Eubanks if (W != V) 687e440b493SArthur Eubanks return findValueImpl(W, OffsetOk, Visited); 688e440b493SArthur Eubanks } 689e440b493SArthur Eubanks } 690e440b493SArthur Eubanks 691e440b493SArthur Eubanks // As a last resort, try SimplifyInstruction or constant folding. 692e440b493SArthur Eubanks if (Instruction *Inst = dyn_cast<Instruction>(V)) { 693*b8c2781fSSimon Moll if (Value *W = simplifyInstruction(Inst, {*DL, TLI, DT, AC})) 694e440b493SArthur Eubanks return findValueImpl(W, OffsetOk, Visited); 695e440b493SArthur Eubanks } else if (auto *C = dyn_cast<Constant>(V)) { 696e440b493SArthur Eubanks Value *W = ConstantFoldConstant(C, *DL, TLI); 697e440b493SArthur Eubanks if (W != V) 698e440b493SArthur Eubanks return findValueImpl(W, OffsetOk, Visited); 699e440b493SArthur Eubanks } 700e440b493SArthur Eubanks 701e440b493SArthur Eubanks return V; 702e440b493SArthur Eubanks } 703e440b493SArthur Eubanks 704c9771391SArthur Eubanks PreservedAnalyses LintPass::run(Function &F, FunctionAnalysisManager &AM) { 705c9771391SArthur Eubanks auto *Mod = F.getParent(); 706c9771391SArthur Eubanks auto *DL = &F.getParent()->getDataLayout(); 707c9771391SArthur Eubanks auto *AA = &AM.getResult<AAManager>(F); 708c9771391SArthur Eubanks auto *AC = &AM.getResult<AssumptionAnalysis>(F); 709c9771391SArthur Eubanks auto *DT = &AM.getResult<DominatorTreeAnalysis>(F); 710c9771391SArthur Eubanks auto *TLI = &AM.getResult<TargetLibraryAnalysis>(F); 711c9771391SArthur Eubanks Lint L(Mod, DL, AA, AC, DT, TLI); 712c9771391SArthur Eubanks L.visit(F); 713c9771391SArthur Eubanks dbgs() << L.MessagesStr.str(); 714c9771391SArthur Eubanks return PreservedAnalyses::all(); 715c9771391SArthur Eubanks } 716c9771391SArthur Eubanks 7179b8b1645SBenjamin Kramer namespace { 718c9771391SArthur Eubanks class LintLegacyPass : public FunctionPass { 719c9771391SArthur Eubanks public: 720c9771391SArthur Eubanks static char ID; // Pass identification, replacement for typeid 721c9771391SArthur Eubanks LintLegacyPass() : FunctionPass(ID) { 722c9771391SArthur Eubanks initializeLintLegacyPassPass(*PassRegistry::getPassRegistry()); 723c9771391SArthur Eubanks } 724c9771391SArthur Eubanks 725c9771391SArthur Eubanks bool runOnFunction(Function &F) override; 726c9771391SArthur Eubanks 727c9771391SArthur Eubanks void getAnalysisUsage(AnalysisUsage &AU) const override { 728c9771391SArthur Eubanks AU.setPreservesAll(); 729c9771391SArthur Eubanks AU.addRequired<AAResultsWrapperPass>(); 730c9771391SArthur Eubanks AU.addRequired<AssumptionCacheTracker>(); 731c9771391SArthur Eubanks AU.addRequired<TargetLibraryInfoWrapperPass>(); 732c9771391SArthur Eubanks AU.addRequired<DominatorTreeWrapperPass>(); 733c9771391SArthur Eubanks } 734c9771391SArthur Eubanks void print(raw_ostream &O, const Module *M) const override {} 735c9771391SArthur Eubanks }; 7369b8b1645SBenjamin Kramer } // namespace 737c9771391SArthur Eubanks 738c9771391SArthur Eubanks char LintLegacyPass::ID = 0; 739c9771391SArthur Eubanks INITIALIZE_PASS_BEGIN(LintLegacyPass, "lint", "Statically lint-checks LLVM IR", 740c9771391SArthur Eubanks false, true) 741c9771391SArthur Eubanks INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker) 742c9771391SArthur Eubanks INITIALIZE_PASS_DEPENDENCY(TargetLibraryInfoWrapperPass) 743c9771391SArthur Eubanks INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass) 744c9771391SArthur Eubanks INITIALIZE_PASS_DEPENDENCY(AAResultsWrapperPass) 745c9771391SArthur Eubanks INITIALIZE_PASS_END(LintLegacyPass, "lint", "Statically lint-checks LLVM IR", 746c9771391SArthur Eubanks false, true) 747c9771391SArthur Eubanks 748c9771391SArthur Eubanks bool LintLegacyPass::runOnFunction(Function &F) { 749c9771391SArthur Eubanks auto *Mod = F.getParent(); 750c9771391SArthur Eubanks auto *DL = &F.getParent()->getDataLayout(); 751c9771391SArthur Eubanks auto *AA = &getAnalysis<AAResultsWrapperPass>().getAAResults(); 752c9771391SArthur Eubanks auto *AC = &getAnalysis<AssumptionCacheTracker>().getAssumptionCache(F); 753c9771391SArthur Eubanks auto *DT = &getAnalysis<DominatorTreeWrapperPass>().getDomTree(); 754c9771391SArthur Eubanks auto *TLI = &getAnalysis<TargetLibraryInfoWrapperPass>().getTLI(F); 755c9771391SArthur Eubanks Lint L(Mod, DL, AA, AC, DT, TLI); 756c9771391SArthur Eubanks L.visit(F); 757c9771391SArthur Eubanks dbgs() << L.MessagesStr.str(); 758c9771391SArthur Eubanks return false; 759c9771391SArthur Eubanks } 760c9771391SArthur Eubanks 761e440b493SArthur Eubanks //===----------------------------------------------------------------------===// 762e440b493SArthur Eubanks // Implement the public interfaces to this file... 763e440b493SArthur Eubanks //===----------------------------------------------------------------------===// 764e440b493SArthur Eubanks 765c9771391SArthur Eubanks FunctionPass *llvm::createLintLegacyPassPass() { return new LintLegacyPass(); } 766e440b493SArthur Eubanks 767e440b493SArthur Eubanks /// lintFunction - Check a function for errors, printing messages on stderr. 768e440b493SArthur Eubanks /// 769e440b493SArthur Eubanks void llvm::lintFunction(const Function &f) { 770e440b493SArthur Eubanks Function &F = const_cast<Function &>(f); 771e440b493SArthur Eubanks assert(!F.isDeclaration() && "Cannot lint external functions"); 772e440b493SArthur Eubanks 773e440b493SArthur Eubanks legacy::FunctionPassManager FPM(F.getParent()); 774c9771391SArthur Eubanks auto *V = new LintLegacyPass(); 775e440b493SArthur Eubanks FPM.add(V); 776e440b493SArthur Eubanks FPM.run(F); 777e440b493SArthur Eubanks } 778e440b493SArthur Eubanks 779e440b493SArthur Eubanks /// lintModule - Check a module for errors, printing messages on stderr. 780e440b493SArthur Eubanks /// 781e440b493SArthur Eubanks void llvm::lintModule(const Module &M) { 782e440b493SArthur Eubanks legacy::PassManager PM; 783c9771391SArthur Eubanks auto *V = new LintLegacyPass(); 784e440b493SArthur Eubanks PM.add(V); 785e440b493SArthur Eubanks PM.run(const_cast<Module &>(M)); 786e440b493SArthur Eubanks } 787