1===================== 2LLVM Developer Policy 3===================== 4 5.. contents:: 6 :local: 7 8Introduction 9============ 10 11This document contains the LLVM Developer Policy which defines the project's 12policy towards developers and their contributions. The intent of this policy is 13to eliminate miscommunication, rework, and confusion that might arise from the 14distributed nature of LLVM's development. By stating the policy in clear terms, 15we hope each developer can know ahead of time what to expect when making LLVM 16contributions. This policy covers all llvm.org subprojects, including Clang, 17LLDB, libc++, etc. 18 19This policy is also designed to accomplish the following objectives: 20 21#. Attract both users and developers to the LLVM project. 22 23#. Make life as simple and easy for contributors as possible. 24 25#. Keep the top of Subversion trees as stable as possible. 26 27#. Establish awareness of the project's :ref:`copyright, license, and patent 28 policies <copyright-license-patents>` with contributors to the project. 29 30This policy is aimed at frequent contributors to LLVM. People interested in 31contributing one-off patches can do so in an informal way by sending them to the 32`llvm-commits mailing list 33<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_ and engaging another 34developer to see it through the process. 35 36Developer Policies 37================== 38 39This section contains policies that pertain to frequent LLVM developers. We 40always welcome `one-off patches`_ from people who do not routinely contribute to 41LLVM, but we expect more from frequent contributors to keep the system as 42efficient as possible for everyone. Frequent LLVM contributors are expected to 43meet the following requirements in order for LLVM to maintain a high standard of 44quality. 45 46Stay Informed 47------------- 48 49Developers should stay informed by reading at least the "dev" mailing list for 50the projects you are interested in, such as `llvm-dev 51<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ for LLVM, `cfe-dev 52<http://lists.llvm.org/mailman/listinfo/cfe-dev>`_ for Clang, or `lldb-dev 53<http://lists.llvm.org/mailman/listinfo/lldb-dev>`_ for LLDB. If you are 54doing anything more than just casual work on LLVM, it is suggested that you also 55subscribe to the "commits" mailing list for the subproject you're interested in, 56such as `llvm-commits 57<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_, `cfe-commits 58<http://lists.llvm.org/mailman/listinfo/cfe-commits>`_, or `lldb-commits 59<http://lists.llvm.org/mailman/listinfo/lldb-commits>`_. Reading the 60"commits" list and paying attention to changes being made by others is a good 61way to see what other people are interested in and watching the flow of the 62project as a whole. 63 64We recommend that active developers register an email account with `LLVM 65Bugzilla <https://bugs.llvm.org/>`_ and preferably subscribe to the `llvm-bugs 66<http://lists.llvm.org/mailman/listinfo/llvm-bugs>`_ email list to keep track 67of bugs and enhancements occurring in LLVM. We really appreciate people who are 68proactive at catching incoming bugs in their components and dealing with them 69promptly. 70 71Please be aware that all public LLVM mailing lists are public and archived, and 72that notices of confidentiality or non-disclosure cannot be respected. 73 74.. _patch: 75.. _one-off patches: 76 77Making and Submitting a Patch 78----------------------------- 79 80When making a patch for review, the goal is to make it as easy for the reviewer 81to read it as possible. As such, we recommend that you: 82 83#. Make your patch against the Subversion trunk, not a branch, and not an old 84 version of LLVM. This makes it easy to apply the patch. For information on 85 how to check out SVN trunk, please see the `Getting Started 86 Guide <GettingStarted.html#checkout>`_. 87 88#. Similarly, patches should be submitted soon after they are generated. Old 89 patches may not apply correctly if the underlying code changes between the 90 time the patch was created and the time it is applied. 91 92#. Patches should be made with ``svn diff``, or similar. If you use a 93 different tool, make sure it uses the ``diff -u`` format and that it 94 doesn't contain clutter which makes it hard to read. 95 96#. If you are modifying generated files, such as the top-level ``configure`` 97 script, please separate out those changes into a separate patch from the rest 98 of your changes. 99 100Once your patch is ready, submit it by emailing it to the appropriate project's 101commit mailing list (or commit it directly if applicable). Alternatively, some 102patches get sent to the project's development list or component of the LLVM bug 103tracker, but the commit list is the primary place for reviews and should 104generally be preferred. 105 106When sending a patch to a mailing list, it is a good idea to send it as an 107*attachment* to the message, not embedded into the text of the message. This 108ensures that your mailer will not mangle the patch when it sends it (e.g. by 109making whitespace changes or by wrapping lines). 110 111*For Thunderbird users:* Before submitting a patch, please open *Preferences > 112Advanced > General > Config Editor*, find the key 113``mail.content_disposition_type``, and set its value to ``1``. Without this 114setting, Thunderbird sends your attachment using ``Content-Disposition: inline`` 115rather than ``Content-Disposition: attachment``. Apple Mail gamely displays such 116a file inline, making it difficult to work with for reviewers using that 117program. 118 119When submitting patches, please do not add confidentiality or non-disclosure 120notices to the patches themselves. These notices conflict with the `LLVM 121License`_ and may result in your contribution being excluded. 122 123.. _code review: 124 125Code Reviews 126------------ 127 128LLVM has a code review policy. Code review is one way to increase the quality of 129software. We generally follow these policies: 130 131#. All developers are required to have significant changes reviewed before they 132 are committed to the repository. 133 134#. Code reviews are conducted by email on the relevant project's commit mailing 135 list, or alternatively on the project's development list or bug tracker. 136 137#. Code can be reviewed either before it is committed or after. We expect major 138 changes to be reviewed before being committed, but smaller changes (or 139 changes where the developer owns the component) can be reviewed after commit. 140 141#. The developer responsible for a code change is also responsible for making 142 all necessary review-related changes. 143 144#. Code review can be an iterative process, which continues until the patch is 145 ready to be committed. Specifically, once a patch is sent out for review, it 146 needs an explicit "looks good" before it is submitted. Do not assume silent 147 approval, or request active objections to the patch with a deadline. 148 149Sometimes code reviews will take longer than you would hope for, especially for 150larger features. Accepted ways to speed up review times for your patches are: 151 152* Review other people's patches. If you help out, everybody will be more 153 willing to do the same for you; goodwill is our currency. 154* Ping the patch. If it is urgent, provide reasons why it is important to you to 155 get this patch landed and ping it every couple of days. If it is 156 not urgent, the common courtesy ping rate is one week. Remember that you're 157 asking for valuable time from other professional developers. 158* Ask for help on IRC. Developers on IRC will be able to either help you 159 directly, or tell you who might be a good reviewer. 160* Split your patch into multiple smaller patches that build on each other. The 161 smaller your patch, the higher the probability that somebody will take a quick 162 look at it. 163 164Developers should participate in code reviews as both reviewers and 165reviewees. If someone is kind enough to review your code, you should return the 166favor for someone else. Note that anyone is welcome to review and give feedback 167on a patch, but only people with Subversion write access can approve it. 168 169There is a web based code review tool that can optionally be used 170for code reviews. See :doc:`Phabricator`. 171 172.. _code owners: 173 174Code Owners 175----------- 176 177The LLVM Project relies on two features of its process to maintain rapid 178development in addition to the high quality of its source base: the combination 179of code review plus post-commit review for trusted maintainers. Having both is 180a great way for the project to take advantage of the fact that most people do 181the right thing most of the time, and only commit patches without pre-commit 182review when they are confident they are right. 183 184The trick to this is that the project has to guarantee that all patches that are 185committed are reviewed after they go in: you don't want everyone to assume 186someone else will review it, allowing the patch to go unreviewed. To solve this 187problem, we have a notion of an 'owner' for a piece of the code. The sole 188responsibility of a code owner is to ensure that a commit to their area of the 189code is appropriately reviewed, either by themself or by someone else. The list 190of current code owners can be found in the file 191`CODE_OWNERS.TXT <http://git.llvm.org/klaus/llvm/blob/master/CODE_OWNERS.TXT>`_ 192in the root of the LLVM source tree. 193 194Note that code ownership is completely different than reviewers: anyone can 195review a piece of code, and we welcome code review from anyone who is 196interested. Code owners are the "last line of defense" to guarantee that all 197patches that are committed are actually reviewed. 198 199Being a code owner is a somewhat unglamorous position, but it is incredibly 200important for the ongoing success of the project. Because people get busy, 201interests change, and unexpected things happen, code ownership is purely opt-in, 202and anyone can choose to resign their "title" at any time. For now, we do not 203have an official policy on how one gets elected to be a code owner. 204 205.. _include a testcase: 206 207Test Cases 208---------- 209 210Developers are required to create test cases for any bugs fixed and any new 211features added. Some tips for getting your testcase approved: 212 213* All feature and regression test cases are added to the ``llvm/test`` 214 directory. The appropriate sub-directory should be selected (see the 215 :doc:`Testing Guide <TestingGuide>` for details). 216 217* Test cases should be written in :doc:`LLVM assembly language <LangRef>`. 218 219* Test cases, especially for regressions, should be reduced as much as possible, 220 by :doc:`bugpoint <Bugpoint>` or manually. It is unacceptable to place an 221 entire failing program into ``llvm/test`` as this creates a *time-to-test* 222 burden on all developers. Please keep them short. 223 224Note that llvm/test and clang/test are designed for regression and small feature 225tests only. More extensive test cases (e.g., entire applications, benchmarks, 226etc) should be added to the ``llvm-test`` test suite. The llvm-test suite is 227for coverage (correctness, performance, etc) testing, not feature or regression 228testing. 229 230Quality 231------- 232 233The minimum quality standards that any change must satisfy before being 234committed to the main development branch are: 235 236#. Code must adhere to the `LLVM Coding Standards <CodingStandards.html>`_. 237 238#. Code must compile cleanly (no errors, no warnings) on at least one platform. 239 240#. Bug fixes and new features should `include a testcase`_ so we know if the 241 fix/feature ever regresses in the future. 242 243#. Code must pass the ``llvm/test`` test suite. 244 245#. The code must not cause regressions on a reasonable subset of llvm-test, 246 where "reasonable" depends on the contributor's judgement and the scope of 247 the change (more invasive changes require more testing). A reasonable subset 248 might be something like "``llvm-test/MultiSource/Benchmarks``". 249 250Additionally, the committer is responsible for addressing any problems found in 251the future that the change is responsible for. For example: 252 253* The code should compile cleanly on all supported platforms. 254 255* The changes should not cause any correctness regressions in the ``llvm-test`` 256 suite and must not cause any major performance regressions. 257 258* The change set should not cause performance or correctness regressions for the 259 LLVM tools. 260 261* The changes should not cause performance or correctness regressions in code 262 compiled by LLVM on all applicable targets. 263 264* You are expected to address any `Bugzilla bugs <https://bugs.llvm.org/>`_ that 265 result from your change. 266 267We prefer for this to be handled before submission but understand that it isn't 268possible to test all of this for every submission. Our build bots and nightly 269testing infrastructure normally finds these problems. A good rule of thumb is 270to check the nightly testers for regressions the day after your change. Build 271bots will directly email you if a group of commits that included yours caused a 272failure. You are expected to check the build bot messages to see if they are 273your fault and, if so, fix the breakage. 274 275Commits that violate these quality standards (e.g. are very broken) may be 276reverted. This is necessary when the change blocks other developers from making 277progress. The developer is welcome to re-commit the change after the problem has 278been fixed. 279 280.. _commit messages: 281 282Commit messages 283--------------- 284 285Although we don't enforce the format of commit messages, we prefer that 286you follow these guidelines to help review, search in logs, email formatting 287and so on. These guidelines are very similar to rules used by other open source 288projects. 289 290Most importantly, the contents of the message should be carefully written to 291convey the rationale of the change (without delving too much in detail). It 292also should avoid being vague or overly specific. For example, "bits were not 293set right" will leave the reviewer wondering about which bits, and why they 294weren't right, while "Correctly set overflow bits in TargetInfo" conveys almost 295all there is to the change. 296 297Below are some guidelines about the format of the message itself: 298 299* Separate the commit message into title, body and, if you're not the original 300 author, a "Patch by" attribution line (see below). 301 302* The title should be concise. Because all commits are emailed to the list with 303 the first line as the subject, long titles are frowned upon. Short titles 304 also look better in `git log`. 305 306* When the changes are restricted to a specific part of the code (e.g. a 307 back-end or optimization pass), it is customary to add a tag to the 308 beginning of the line in square brackets. For example, "[SCEV] ..." 309 or "[OpenMP] ...". This helps email filters and searches for post-commit 310 reviews. 311 312* The body, if it exists, should be separated from the title by an empty line. 313 314* The body should be concise, but explanatory, including a complete 315 reasoning. Unless it is required to understand the change, examples, 316 code snippets and gory details should be left to bug comments, web 317 review or the mailing list. 318 319* If the patch fixes a bug in bugzilla, please include the PR# in the message. 320 321* `Attribution of Changes`_ should be in a separate line, after the end of 322 the body, as simple as "Patch by John Doe.". This is how we officially 323 handle attribution, and there are automated processes that rely on this 324 format. 325 326* Text formatting and spelling should follow the same rules as documentation 327 and in-code comments, ex. capitalization, full stop, etc. 328 329* If the commit is a bug fix on top of another recently committed patch, or a 330 revert or reapply of a patch, include the svn revision number of the prior 331 related commit. This could be as simple as "Revert rNNNN because it caused 332 PR#". 333 334For minor violations of these recommendations, the community normally favors 335reminding the contributor of this policy over reverting. Minor corrections and 336omissions can be handled by sending a reply to the commits mailing list. 337 338Obtaining Commit Access 339----------------------- 340 341We grant commit access to contributors with a track record of submitting high 342quality patches. If you would like commit access, please send an email to 343`Chris <mailto:[email protected]>`_ with the following information: 344 345#. The user name you want to commit with, e.g. "hacker". 346 347#. The full name and email address you want message to llvm-commits to come 348 from, e.g. "J. Random Hacker <[email protected]>". 349 350#. A "password hash" of the password you want to use, e.g. "``2ACR96qjUqsyM``". 351 Note that you don't ever tell us what your password is; you just give it to 352 us in an encrypted form. To get this, run "``htpasswd``" (a utility that 353 comes with apache) in *crypt* mode (often enabled with "``-d``"), or find a web 354 page that will do it for you. Note that our system does not work with MD5 355 hashes. These are significantly longer than a crypt hash - e.g. 356 "``$apr1$vea6bBV2$Z8IFx.AfeD8LhqlZFqJer0``", we only accept the shorter crypt hash. 357 358Once you've been granted commit access, you should be able to check out an LLVM 359tree with an SVN URL of "https://[email protected]/..." instead of the normal 360anonymous URL of "http://llvm.org/...". The first time you commit you'll have 361to type in your password. Note that you may get a warning from SVN about an 362untrusted key; you can ignore this. To verify that your commit access works, 363please do a test commit (e.g. change a comment or add a blank line). Your first 364commit to a repository may require the autogenerated email to be approved by a 365moderator of the mailing list. 366This is normal and will be done when the mailing list owner has time. 367 368If you have recently been granted commit access, these policies apply: 369 370#. You are granted *commit-after-approval* to all parts of LLVM. To get 371 approval, submit a `patch`_ to `llvm-commits 372 <http://lists.llvm.org/mailman/listinfo/llvm-commits>`_. When approved, 373 you may commit it yourself. 374 375#. You are allowed to commit patches without approval which you think are 376 obvious. This is clearly a subjective decision --- we simply expect you to 377 use good judgement. Examples include: fixing build breakage, reverting 378 obviously broken patches, documentation/comment changes, any other minor 379 changes. Avoid committing formatting- or whitespace-only changes outside of 380 code you plan to make subsequent changes to. Also, try to separate 381 formatting or whitespace changes from functional changes, either by 382 correcting the format first (ideally) or afterward. Such changes should be 383 highly localized and the commit message should clearly state that the commit 384 is not intended to change functionality, usually by stating it is 385 :ref:`NFC <nfc>`. 386 387#. You are allowed to commit patches without approval to those portions of LLVM 388 that you have contributed or maintain (i.e., have been assigned 389 responsibility for), with the proviso that such commits must not break the 390 build. This is a "trust but verify" policy, and commits of this nature are 391 reviewed after they are committed. 392 393#. Multiple violations of these policies or a single egregious violation may 394 cause commit access to be revoked. 395 396In any case, your changes are still subject to `code review`_ (either before or 397after they are committed, depending on the nature of the change). You are 398encouraged to review other peoples' patches as well, but you aren't required 399to do so. 400 401.. _discuss the change/gather consensus: 402 403Making a Major Change 404--------------------- 405 406When a developer begins a major new project with the aim of contributing it back 407to LLVM, they should inform the community with an email to the `llvm-dev 408<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ email list, to the extent 409possible. The reason for this is to: 410 411#. keep the community informed about future changes to LLVM, 412 413#. avoid duplication of effort by preventing multiple parties working on the 414 same thing and not knowing about it, and 415 416#. ensure that any technical issues around the proposed work are discussed and 417 resolved before any significant work is done. 418 419The design of LLVM is carefully controlled to ensure that all the pieces fit 420together well and are as consistent as possible. If you plan to make a major 421change to the way LLVM works or want to add a major new extension, it is a good 422idea to get consensus with the development community before you start working on 423it. 424 425Once the design of the new feature is finalized, the work itself should be done 426as a series of `incremental changes`_, not as a long-term development branch. 427 428.. _incremental changes: 429 430Incremental Development 431----------------------- 432 433In the LLVM project, we do all significant changes as a series of incremental 434patches. We have a strong dislike for huge changes or long-term development 435branches. Long-term development branches have a number of drawbacks: 436 437#. Branches must have mainline merged into them periodically. If the branch 438 development and mainline development occur in the same pieces of code, 439 resolving merge conflicts can take a lot of time. 440 441#. Other people in the community tend to ignore work on branches. 442 443#. Huge changes (produced when a branch is merged back onto mainline) are 444 extremely difficult to `code review`_. 445 446#. Branches are not routinely tested by our nightly tester infrastructure. 447 448#. Changes developed as monolithic large changes often don't work until the 449 entire set of changes is done. Breaking it down into a set of smaller 450 changes increases the odds that any of the work will be committed to the main 451 repository. 452 453To address these problems, LLVM uses an incremental development style and we 454require contributors to follow this practice when making a large/invasive 455change. Some tips: 456 457* Large/invasive changes usually have a number of secondary changes that are 458 required before the big change can be made (e.g. API cleanup, etc). These 459 sorts of changes can often be done before the major change is done, 460 independently of that work. 461 462* The remaining inter-related work should be decomposed into unrelated sets of 463 changes if possible. Once this is done, define the first increment and get 464 consensus on what the end goal of the change is. 465 466* Each change in the set can be stand alone (e.g. to fix a bug), or part of a 467 planned series of changes that works towards the development goal. 468 469* Each change should be kept as small as possible. This simplifies your work 470 (into a logical progression), simplifies code review and reduces the chance 471 that you will get negative feedback on the change. Small increments also 472 facilitate the maintenance of a high quality code base. 473 474* Often, an independent precursor to a big change is to add a new API and slowly 475 migrate clients to use the new API. Each change to use the new API is often 476 "obvious" and can be committed without review. Once the new API is in place 477 and used, it is much easier to replace the underlying implementation of the 478 API. This implementation change is logically separate from the API 479 change. 480 481If you are interested in making a large change, and this scares you, please make 482sure to first `discuss the change/gather consensus`_ then ask about the best way 483to go about making the change. 484 485Attribution of Changes 486---------------------- 487 488When contributors submit a patch to an LLVM project, other developers with 489commit access may commit it for the author once appropriate (based on the 490progression of code review, etc.). When doing so, it is important to retain 491correct attribution of contributions to their contributors. However, we do not 492want the source code to be littered with random attributions "this code written 493by J. Random Hacker" (this is noisy and distracting). In practice, the revision 494control system keeps a perfect history of who changed what, and the CREDITS.txt 495file describes higher-level contributions. If you commit a patch for someone 496else, please follow the attribution of changes in the simple manner as outlined 497by the `commit messages`_ section. Overall, please do not add contributor names 498to the source code. 499 500Also, don't commit patches authored by others unless they have submitted the 501patch to the project or you have been authorized to submit them on their behalf 502(you work together and your company authorized you to contribute the patches, 503etc.). The author should first submit them to the relevant project's commit 504list, development list, or LLVM bug tracker component. If someone sends you 505a patch privately, encourage them to submit it to the appropriate list first. 506 507 508.. _IR backwards compatibility: 509 510IR Backwards Compatibility 511-------------------------- 512 513When the IR format has to be changed, keep in mind that we try to maintain some 514backwards compatibility. The rules are intended as a balance between convenience 515for llvm users and not imposing a big burden on llvm developers: 516 517* The textual format is not backwards compatible. We don't change it too often, 518 but there are no specific promises. 519 520* Additions and changes to the IR should be reflected in 521 ``test/Bitcode/compatibility.ll``. 522 523* The current LLVM version supports loading any bitcode since version 3.0. 524 525* After each X.Y release, ``compatibility.ll`` must be copied to 526 ``compatibility-X.Y.ll``. The corresponding bitcode file should be assembled 527 using the X.Y build and committed as ``compatibility-X.Y.ll.bc``. 528 529* Newer releases can ignore features from older releases, but they cannot 530 miscompile them. For example, if nsw is ever replaced with something else, 531 dropping it would be a valid way to upgrade the IR. 532 533* Debug metadata is special in that it is currently dropped during upgrades. 534 535* Non-debug metadata is defined to be safe to drop, so a valid way to upgrade 536 it is to drop it. That is not very user friendly and a bit more effort is 537 expected, but no promises are made. 538 539C API Changes 540---------------- 541 542* Stability Guarantees: The C API is, in general, a "best effort" for stability. 543 This means that we make every attempt to keep the C API stable, but that 544 stability will be limited by the abstractness of the interface and the 545 stability of the C++ API that it wraps. In practice, this means that things 546 like "create debug info" or "create this type of instruction" are likely to be 547 less stable than "take this IR file and JIT it for my current machine". 548 549* Release stability: We won't break the C API on the release branch with patches 550 that go on that branch, with the exception that we will fix an unintentional 551 C API break that will keep the release consistent with both the previous and 552 next release. 553 554* Testing: Patches to the C API are expected to come with tests just like any 555 other patch. 556 557* Including new things into the API: If an LLVM subcomponent has a C API already 558 included, then expanding that C API is acceptable. Adding C API for 559 subcomponents that don't currently have one needs to be discussed on the 560 mailing list for design and maintainability feedback prior to implementation. 561 562* Documentation: Any changes to the C API are required to be documented in the 563 release notes so that it's clear to external users who do not follow the 564 project how the C API is changing and evolving. 565 566New Targets 567----------- 568 569LLVM is very receptive to new targets, even experimental ones, but a number of 570problems can appear when adding new large portions of code, and back-ends are 571normally added in bulk. We have found that landing large pieces of new code 572and then trying to fix emergent problems in-tree is problematic for a variety 573of reasons. 574 575For these reasons, new targets are *always* added as *experimental* until 576they can be proven stable, and later moved to non-experimental. The difference 577between both classes is that experimental targets are not built by default 578(need to be added to -DLLVM_TARGETS_TO_BUILD at CMake time). 579 580The basic rules for a back-end to be upstreamed in **experimental** mode are: 581 582* Every target must have a :ref:`code owner<code owners>`. The `CODE_OWNERS.TXT` 583 file has to be updated as part of the first merge. The code owner makes sure 584 that changes to the target get reviewed and steers the overall effort. 585 586* There must be an active community behind the target. This community 587 will help maintain the target by providing buildbots, fixing 588 bugs, answering the LLVM community's questions and making sure the new 589 target doesn't break any of the other targets, or generic code. This 590 behavior is expected to continue throughout the lifetime of the 591 target's code. 592 593* The code must be free of contentious issues, for example, large 594 changes in how the IR behaves or should be formed by the front-ends, 595 unless agreed by the majority of the community via refactoring of the 596 (:doc:`IR standard<LangRef>`) **before** the merge of the new target changes, 597 following the :ref:`IR backwards compatibility`. 598 599* The code conforms to all of the policies laid out in this developer policy 600 document, including license, patent, and coding standards. 601 602* The target should have either reasonable documentation on how it 603 works (ISA, ABI, etc.) or a publicly available simulator/hardware 604 (either free or cheap enough) - preferably both. This allows 605 developers to validate assumptions, understand constraints and review code 606 that can affect the target. 607 608In addition, the rules for a back-end to be promoted to **official** are: 609 610* The target must have addressed every other minimum requirement and 611 have been stable in tree for at least 3 months. This cool down 612 period is to make sure that the back-end and the target community can 613 endure continuous upstream development for the foreseeable future. 614 615* The target's code must have been completely adapted to this policy 616 as well as the :doc:`coding standards<CodingStandards>`. Any exceptions that 617 were made to move into experimental mode must have been fixed **before** 618 becoming official. 619 620* The test coverage needs to be broad and well written (small tests, 621 well documented). The build target ``check-all`` must pass with the 622 new target built, and where applicable, the ``test-suite`` must also 623 pass without errors, in at least one configuration (publicly 624 demonstrated, for example, via buildbots). 625 626* Public buildbots need to be created and actively maintained, unless 627 the target requires no additional buildbots (ex. ``check-all`` covers 628 all tests). The more relevant and public the new target's CI infrastructure 629 is, the more the LLVM community will embrace it. 630 631To **continue** as a supported and official target: 632 633* The maintainer(s) must continue following these rules throughout the lifetime 634 of the target. Continuous violations of aforementioned rules and policies 635 could lead to complete removal of the target from the code base. 636 637* Degradation in support, documentation or test coverage will make the target as 638 nuisance to other targets and be considered a candidate for deprecation and 639 ultimately removed. 640 641In essences, these rules are necessary for targets to gain and retain their 642status, but also markers to define bit-rot, and will be used to clean up the 643tree from unmaintained targets. 644 645.. _copyright-license-patents: 646 647Copyright, License, and Patents 648=============================== 649 650.. note:: 651 652 This section deals with legal matters but does not provide legal advice. We 653 are not lawyers --- please seek legal counsel from an attorney. 654 655This section addresses the issues of copyright, license and patents for the LLVM 656project. The copyright for the code is held by the individual contributors of 657the code and the terms of its license to LLVM users and developers is the 658`University of Illinois/NCSA Open Source License 659<http://www.opensource.org/licenses/UoI-NCSA.php>`_ (with portions dual licensed 660under the `MIT License <http://www.opensource.org/licenses/mit-license.php>`_, 661see below). As contributor to the LLVM project, you agree to allow any 662contributions to the project to licensed under these terms. 663 664Copyright 665--------- 666 667The LLVM project does not require copyright assignments, which means that the 668copyright for the code in the project is held by its respective contributors who 669have each agreed to release their contributed code under the terms of the `LLVM 670License`_. 671 672An implication of this is that the LLVM license is unlikely to ever change: 673changing it would require tracking down all the contributors to LLVM and getting 674them to agree that a license change is acceptable for their contribution. Since 675there are no plans to change the license, this is not a cause for concern. 676 677As a contributor to the project, this means that you (or your company) retain 678ownership of the code you contribute, that it cannot be used in a way that 679contradicts the license (which is a liberal BSD-style license), and that the 680license for your contributions won't change without your approval in the 681future. 682 683.. _LLVM License: 684 685License 686------- 687 688We intend to keep LLVM perpetually open source and to use a liberal open source 689license. **As a contributor to the project, you agree that any contributions be 690licensed under the terms of the corresponding subproject.** All of the code in 691LLVM is available under the `University of Illinois/NCSA Open Source License 692<http://www.opensource.org/licenses/UoI-NCSA.php>`_, which boils down to 693this: 694 695* You can freely distribute LLVM. 696* You must retain the copyright notice if you redistribute LLVM. 697* Binaries derived from LLVM must reproduce the copyright notice (e.g. in an 698 included readme file). 699* You can't use our names to promote your LLVM derived products. 700* There's no warranty on LLVM at all. 701 702We believe this fosters the widest adoption of LLVM because it **allows 703commercial products to be derived from LLVM** with few restrictions and without 704a requirement for making any derived works also open source (i.e. LLVM's 705license is not a "copyleft" license like the GPL). We suggest that you read the 706`License <http://www.opensource.org/licenses/UoI-NCSA.php>`_ if further 707clarification is needed. 708 709In addition to the UIUC license, the runtime library components of LLVM 710(**compiler_rt, libc++, and libclc**) are also licensed under the `MIT License 711<http://www.opensource.org/licenses/mit-license.php>`_, which does not contain 712the binary redistribution clause. As a user of these runtime libraries, it 713means that you can choose to use the code under either license (and thus don't 714need the binary redistribution clause), and as a contributor to the code that 715you agree that any contributions to these libraries be licensed under both 716licenses. We feel that this is important for runtime libraries, because they 717are implicitly linked into applications and therefore should not subject those 718applications to the binary redistribution clause. This also means that it is ok 719to move code from (e.g.) libc++ to the LLVM core without concern, but that code 720cannot be moved from the LLVM core to libc++ without the copyright owner's 721permission. 722 723Note that the LLVM Project does distribute dragonegg, **which is 724GPL.** This means that anything "linked" into dragonegg must itself be compatible 725with the GPL, and must be releasable under the terms of the GPL. This implies 726that **any code linked into dragonegg and distributed to others may be subject to 727the viral aspects of the GPL** (for example, a proprietary code generator linked 728into dragonegg must be made available under the GPL). This is not a problem for 729code already distributed under a more liberal license (like the UIUC license), 730and GPL-containing subprojects are kept in separate SVN repositories whose 731LICENSE.txt files specifically indicate that they contain GPL code. 732 733Patents 734------- 735 736To the best of our knowledge, LLVM does not infringe on any patents (we have 737actually removed code from LLVM in the past that was found to infringe). Having 738code in LLVM that infringes on patents would violate an important goal of the 739project by making it hard or impossible to reuse the code for arbitrary purposes 740(including commercial use). 741 742When contributing code, we expect contributors to notify us of any potential for 743patent-related trouble with their changes (including from third parties). If 744you or your employer own the rights to a patent and would like to contribute 745code to LLVM that relies on it, we require that the copyright owner sign an 746agreement that allows any other user of LLVM to freely use your patent. Please 747contact the `LLVM Foundation Board of Directors <mailto:[email protected]>`_ for more 748details. 749