1===================== 2LLVM Developer Policy 3===================== 4 5.. contents:: 6 :local: 7 8Introduction 9============ 10 11This document contains the LLVM Developer Policy which defines the project's 12policy towards developers and their contributions. The intent of this policy is 13to eliminate miscommunication, rework, and confusion that might arise from the 14distributed nature of LLVM's development. By stating the policy in clear terms, 15we hope each developer can know ahead of time what to expect when making LLVM 16contributions. This policy covers all llvm.org subprojects, including Clang, 17LLDB, libc++, etc. 18 19This policy is also designed to accomplish the following objectives: 20 21#. Attract both users and developers to the LLVM project. 22 23#. Make life as simple and easy for contributors as possible. 24 25#. Keep the top of tree as stable as possible. 26 27#. Establish awareness of the project's :ref:`copyright, license, and patent 28 policies <copyright-license-patents>` with contributors to the project. 29 30This policy is aimed at frequent contributors to LLVM. People interested in 31contributing one-off patches can do so in an informal way by sending them to the 32`llvm-commits mailing list 33<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_ and engaging another 34developer to see it through the process. 35 36Developer Policies 37================== 38 39This section contains policies that pertain to frequent LLVM developers. We 40always welcome `one-off patches`_ from people who do not routinely contribute to 41LLVM, but we expect more from frequent contributors to keep the system as 42efficient as possible for everyone. Frequent LLVM contributors are expected to 43meet the following requirements in order for LLVM to maintain a high standard of 44quality. 45 46Stay Informed 47------------- 48 49Developers should stay informed by reading at least the "dev" mailing list for 50the projects you are interested in, such as `llvm-dev 51<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ for LLVM, `cfe-dev 52<http://lists.llvm.org/mailman/listinfo/cfe-dev>`_ for Clang, or `lldb-dev 53<http://lists.llvm.org/mailman/listinfo/lldb-dev>`_ for LLDB. If you are 54doing anything more than just casual work on LLVM, it is suggested that you also 55subscribe to the "commits" mailing list for the subproject you're interested in, 56such as `llvm-commits 57<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_, `cfe-commits 58<http://lists.llvm.org/mailman/listinfo/cfe-commits>`_, or `lldb-commits 59<http://lists.llvm.org/mailman/listinfo/lldb-commits>`_. Reading the 60"commits" list and paying attention to changes being made by others is a good 61way to see what other people are interested in and watching the flow of the 62project as a whole. 63 64We recommend that active developers register an email account with `LLVM 65Bugzilla <https://bugs.llvm.org/>`_ and preferably subscribe to the `llvm-bugs 66<http://lists.llvm.org/mailman/listinfo/llvm-bugs>`_ email list to keep track 67of bugs and enhancements occurring in LLVM. We really appreciate people who are 68proactive at catching incoming bugs in their components and dealing with them 69promptly. 70 71Please be aware that all public LLVM mailing lists are public and archived, and 72that notices of confidentiality or non-disclosure cannot be respected. 73 74.. _patch: 75.. _one-off patches: 76 77Making and Submitting a Patch 78----------------------------- 79 80When making a patch for review, the goal is to make it as easy for the reviewer 81to read it as possible. As such, we recommend that you: 82 83#. Make your patch against git master, not a branch, and not an old version 84 of LLVM. This makes it easy to apply the patch. For information on how to 85 clone from git, please see the :ref:`Getting Started Guide 86 <checkout>`. 87 88#. Similarly, patches should be submitted soon after they are generated. Old 89 patches may not apply correctly if the underlying code changes between the 90 time the patch was created and the time it is applied. 91 92#. Patches should be made with ``git format-patch``, or similar (see special 93 commands for `Requesting Phabricator review via the web interface 94 <Phabricator.html#phabricator-request-review-web>`_ ). If you use a 95 different tool, make sure it uses the ``diff -u`` format and that it 96 doesn't contain clutter which makes it hard to read. 97 98Once your patch is ready, submit it by emailing it to the appropriate project's 99commit mailing list (or commit it directly if applicable). Alternatively, some 100patches get sent to the project's development list or component of the LLVM bug 101tracker, but the commit list is the primary place for reviews and should 102generally be preferred. 103 104When sending a patch to a mailing list, it is a good idea to send it as an 105*attachment* to the message, not embedded into the text of the message. This 106ensures that your mailer will not mangle the patch when it sends it (e.g. by 107making whitespace changes or by wrapping lines). 108 109*For Thunderbird users:* Before submitting a patch, please open *Preferences > 110Advanced > General > Config Editor*, find the key 111``mail.content_disposition_type``, and set its value to ``1``. Without this 112setting, Thunderbird sends your attachment using ``Content-Disposition: inline`` 113rather than ``Content-Disposition: attachment``. Apple Mail gamely displays such 114a file inline, making it difficult to work with for reviewers using that 115program. 116 117When submitting patches, please do not add confidentiality or non-disclosure 118notices to the patches themselves. These notices conflict with the LLVM 119licensing terms and may result in your contribution being excluded. 120 121.. _code review: 122 123Code Reviews 124------------ 125 126LLVM has a code-review policy. Code review is one way to increase the quality of 127software. Please see :doc:`CodeReview` for more information on LLVM's code-review 128process. 129 130.. _code owners: 131 132Code Owners 133----------- 134 135The LLVM Project relies on two features of its process to maintain rapid 136development in addition to the high quality of its source base: the combination 137of code review plus post-commit review for trusted maintainers. Having both is 138a great way for the project to take advantage of the fact that most people do 139the right thing most of the time, and only commit patches without pre-commit 140review when they are confident they are right. 141 142The trick to this is that the project has to guarantee that all patches that are 143committed are reviewed after they go in: you don't want everyone to assume 144someone else will review it, allowing the patch to go unreviewed. To solve this 145problem, we have a notion of an 'owner' for a piece of the code. The sole 146responsibility of a code owner is to ensure that a commit to their area of the 147code is appropriately reviewed, either by themself or by someone else. The list 148of current code owners can be found in the file `CODE_OWNERS.TXT 149<https://github.com/llvm/llvm-project/blob/master/llvm/CODE_OWNERS.TXT>`_ in the 150root of the LLVM source tree. 151 152Note that code ownership is completely different than reviewers: anyone can 153review a piece of code, and we welcome code review from anyone who is 154interested. Code owners are the "last line of defense" to guarantee that all 155patches that are committed are actually reviewed. 156 157Being a code owner is a somewhat unglamorous position, but it is incredibly 158important for the ongoing success of the project. Because people get busy, 159interests change, and unexpected things happen, code ownership is purely opt-in, 160and anyone can choose to resign their "title" at any time. For now, we do not 161have an official policy on how one gets elected to be a code owner. 162 163.. _include a testcase: 164 165Test Cases 166---------- 167 168Developers are required to create test cases for any bugs fixed and any new 169features added. Some tips for getting your testcase approved: 170 171* All feature and regression test cases are added to the ``llvm/test`` 172 directory. The appropriate sub-directory should be selected (see the 173 :doc:`Testing Guide <TestingGuide>` for details). 174 175* Test cases should be written in :doc:`LLVM assembly language <LangRef>`. 176 177* Test cases, especially for regressions, should be reduced as much as possible, 178 by :doc:`bugpoint <Bugpoint>` or manually. It is unacceptable to place an 179 entire failing program into ``llvm/test`` as this creates a *time-to-test* 180 burden on all developers. Please keep them short. 181 182Note that llvm/test and clang/test are designed for regression and small feature 183tests only. More extensive test cases (e.g., entire applications, benchmarks, 184etc) should be added to the ``llvm-test`` test suite. The llvm-test suite is 185for coverage (correctness, performance, etc) testing, not feature or regression 186testing. 187 188Quality 189------- 190 191The minimum quality standards that any change must satisfy before being 192committed to the main development branch are: 193 194#. Code must adhere to the `LLVM Coding Standards <CodingStandards.html>`_. 195 196#. Code must compile cleanly (no errors, no warnings) on at least one platform. 197 198#. Bug fixes and new features should `include a testcase`_ so we know if the 199 fix/feature ever regresses in the future. 200 201#. Code must pass the ``llvm/test`` test suite. 202 203#. The code must not cause regressions on a reasonable subset of llvm-test, 204 where "reasonable" depends on the contributor's judgement and the scope of 205 the change (more invasive changes require more testing). A reasonable subset 206 might be something like "``llvm-test/MultiSource/Benchmarks``". 207 208Additionally, the committer is responsible for addressing any problems found in 209the future that the change is responsible for. For example: 210 211* The code should compile cleanly on all supported platforms. 212 213* The changes should not cause any correctness regressions in the ``llvm-test`` 214 suite and must not cause any major performance regressions. 215 216* The change set should not cause performance or correctness regressions for the 217 LLVM tools. 218 219* The changes should not cause performance or correctness regressions in code 220 compiled by LLVM on all applicable targets. 221 222* You are expected to address any `Bugzilla bugs <https://bugs.llvm.org/>`_ that 223 result from your change. 224 225We prefer for this to be handled before submission but understand that it isn't 226possible to test all of this for every submission. Our build bots and nightly 227testing infrastructure normally finds these problems. A good rule of thumb is 228to check the nightly testers for regressions the day after your change. Build 229bots will directly email you if a group of commits that included yours caused a 230failure. You are expected to check the build bot messages to see if they are 231your fault and, if so, fix the breakage. 232 233Commits that violate these quality standards (e.g. are very broken) may be 234reverted. This is necessary when the change blocks other developers from making 235progress. The developer is welcome to re-commit the change after the problem has 236been fixed. 237 238.. _commit messages: 239 240Commit messages 241--------------- 242 243Although we don't enforce the format of commit messages, we prefer that 244you follow these guidelines to help review, search in logs, email formatting 245and so on. These guidelines are very similar to rules used by other open source 246projects. 247 248Most importantly, the contents of the message should be carefully written to 249convey the rationale of the change (without delving too much in detail). It 250also should avoid being vague or overly specific. For example, "bits were not 251set right" will leave the reviewer wondering about which bits, and why they 252weren't right, while "Correctly set overflow bits in TargetInfo" conveys almost 253all there is to the change. 254 255Below are some guidelines about the format of the message itself: 256 257* Separate the commit message into title and body separated by a blank line. 258 259* If you're not the original author, ensure the 'Author' property of the commit is 260 set to the original author and the 'Committer' property is set to yourself. 261 You can use a command similar to 262 ``git commit --amend --author="John Doe <[email protected]>`` to correct the 263 author property if it is incorrect. See `Attribution of Changes`_ for more 264 information including the method we used for attribution before the project 265 migrated to git. 266 267* The title should be concise. Because all commits are emailed to the list with 268 the first line as the subject, long titles are frowned upon. Short titles 269 also look better in `git log`. 270 271* When the changes are restricted to a specific part of the code (e.g. a 272 back-end or optimization pass), it is customary to add a tag to the 273 beginning of the line in square brackets. For example, "[SCEV] ..." 274 or "[OpenMP] ...". This helps email filters and searches for post-commit 275 reviews. 276 277* The body, if it exists, should be separated from the title by an empty line. 278 279* The body should be concise, but explanatory, including a complete 280 reasoning. Unless it is required to understand the change, examples, 281 code snippets and gory details should be left to bug comments, web 282 review or the mailing list. 283 284* If the patch fixes a bug in bugzilla, please include the PR# in the message. 285 286* Text formatting and spelling should follow the same rules as documentation 287 and in-code comments, ex. capitalization, full stop, etc. 288 289* If the commit is a bug fix on top of another recently committed patch, or a 290 revert or reapply of a patch, include the git commit hash of the prior 291 related commit. This could be as simple as "Revert commit NNNN because it 292 caused PR#". 293 294For minor violations of these recommendations, the community normally favors 295reminding the contributor of this policy over reverting. Minor corrections and 296omissions can be handled by sending a reply to the commits mailing list. 297 298Obtaining Commit Access 299----------------------- 300 301New Contributors 302^^^^^^^^^^^^^^^^ 303We grant commit access to contributors with a track record of submitting high 304quality patches. If you would like commit access, please send an email to 305`Chris <mailto:[email protected]>`_ with your GitHub username. 306 307Prior to obtaining commit access, it is common practice to request that 308someone with commit access commits on your behalf. When doing so, please 309provide the name and email address you would like to use in the Author 310property of the commit. 311 312Your first commit to a repository may require the autogenerated email to be 313approved by a moderator of the mailing list. 314This is normal and will be done when the mailing list owner has time. 315 316If you have recently been granted commit access, these policies apply: 317 318#. You are granted *commit-after-approval* to all parts of LLVM. For 319 information on how to get approval for a patch, please see :doc:`CodeReview`. 320 When approved, you may commit it yourself. 321 322#. You are allowed to commit patches without approval which you think are 323 obvious. This is clearly a subjective decision --- we simply expect you to 324 use good judgement. Examples include: fixing build breakage, reverting 325 obviously broken patches, documentation/comment changes, any other minor 326 changes. Avoid committing formatting- or whitespace-only changes outside of 327 code you plan to make subsequent changes to. Also, try to separate 328 formatting or whitespace changes from functional changes, either by 329 correcting the format first (ideally) or afterward. Such changes should be 330 highly localized and the commit message should clearly state that the commit 331 is not intended to change functionality, usually by stating it is 332 :ref:`NFC <nfc>`. 333 334#. You are allowed to commit patches without approval to those portions of LLVM 335 that you have contributed or maintain (i.e., have been assigned 336 responsibility for), with the proviso that such commits must not break the 337 build. This is a "trust but verify" policy, and commits of this nature are 338 reviewed after they are committed. 339 340#. Multiple violations of these policies or a single egregious violation may 341 cause commit access to be revoked. 342 343In any case, your changes are still subject to `code review`_ (either before or 344after they are committed, depending on the nature of the change). You are 345encouraged to review other peoples' patches as well, but you aren't required 346to do so. 347 348Current Contributors - Transferring from SVN 349^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 350If you had commit access to SVN and would like to request commit access to 351GitHub, please email `llvm-admin <mailto:[email protected]>`_ with your 352SVN username and GitHub username. 353 354.. _discuss the change/gather consensus: 355 356Making a Major Change 357--------------------- 358 359When a developer begins a major new project with the aim of contributing it back 360to LLVM, they should inform the community with an email to the `llvm-dev 361<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ email list, to the extent 362possible. The reason for this is to: 363 364#. keep the community informed about future changes to LLVM, 365 366#. avoid duplication of effort by preventing multiple parties working on the 367 same thing and not knowing about it, and 368 369#. ensure that any technical issues around the proposed work are discussed and 370 resolved before any significant work is done. 371 372The design of LLVM is carefully controlled to ensure that all the pieces fit 373together well and are as consistent as possible. If you plan to make a major 374change to the way LLVM works or want to add a major new extension, it is a good 375idea to get consensus with the development community before you start working on 376it. 377 378Once the design of the new feature is finalized, the work itself should be done 379as a series of `incremental changes`_, not as a long-term development branch. 380 381.. _incremental changes: 382 383Incremental Development 384----------------------- 385 386In the LLVM project, we do all significant changes as a series of incremental 387patches. We have a strong dislike for huge changes or long-term development 388branches. Long-term development branches have a number of drawbacks: 389 390#. Branches must have mainline merged into them periodically. If the branch 391 development and mainline development occur in the same pieces of code, 392 resolving merge conflicts can take a lot of time. 393 394#. Other people in the community tend to ignore work on branches. 395 396#. Huge changes (produced when a branch is merged back onto mainline) are 397 extremely difficult to `code review`_. 398 399#. Branches are not routinely tested by our nightly tester infrastructure. 400 401#. Changes developed as monolithic large changes often don't work until the 402 entire set of changes is done. Breaking it down into a set of smaller 403 changes increases the odds that any of the work will be committed to the main 404 repository. 405 406To address these problems, LLVM uses an incremental development style and we 407require contributors to follow this practice when making a large/invasive 408change. Some tips: 409 410* Large/invasive changes usually have a number of secondary changes that are 411 required before the big change can be made (e.g. API cleanup, etc). These 412 sorts of changes can often be done before the major change is done, 413 independently of that work. 414 415* The remaining inter-related work should be decomposed into unrelated sets of 416 changes if possible. Once this is done, define the first increment and get 417 consensus on what the end goal of the change is. 418 419* Each change in the set can be stand alone (e.g. to fix a bug), or part of a 420 planned series of changes that works towards the development goal. 421 422* Each change should be kept as small as possible. This simplifies your work 423 (into a logical progression), simplifies code review and reduces the chance 424 that you will get negative feedback on the change. Small increments also 425 facilitate the maintenance of a high quality code base. 426 427* Often, an independent precursor to a big change is to add a new API and slowly 428 migrate clients to use the new API. Each change to use the new API is often 429 "obvious" and can be committed without review. Once the new API is in place 430 and used, it is much easier to replace the underlying implementation of the 431 API. This implementation change is logically separate from the API 432 change. 433 434If you are interested in making a large change, and this scares you, please make 435sure to first `discuss the change/gather consensus`_ then ask about the best way 436to go about making the change. 437 438Attribution of Changes 439---------------------- 440 441When contributors submit a patch to an LLVM project, other developers with 442commit access may commit it for the author once appropriate (based on the 443progression of code review, etc.). When doing so, it is important to retain 444correct attribution of contributions to their contributors. However, we do not 445want the source code to be littered with random attributions "this code written 446by J. Random Hacker" (this is noisy and distracting). In practice, the revision 447control system keeps a perfect history of who changed what, and the CREDITS.txt 448file describes higher-level contributions. If you commit a patch for someone 449else, please follow the attribution of changes in the simple manner as outlined 450by the `commit messages`_ section. Overall, please do not add contributor names 451to the source code. 452 453Also, don't commit patches authored by others unless they have submitted the 454patch to the project or you have been authorized to submit them on their behalf 455(you work together and your company authorized you to contribute the patches, 456etc.). The author should first submit them to the relevant project's commit 457list, development list, or LLVM bug tracker component. If someone sends you 458a patch privately, encourage them to submit it to the appropriate list first. 459 460Our previous version control system (subversion) did not distinguish between the 461author and the committer like git does. As such, older commits used a different 462attribution mechanism. The previous method was to include "Patch by John Doe." 463in a separate line of the commit message and there are automated processes that 464rely on this format. 465 466.. _IR backwards compatibility: 467 468IR Backwards Compatibility 469-------------------------- 470 471When the IR format has to be changed, keep in mind that we try to maintain some 472backwards compatibility. The rules are intended as a balance between convenience 473for llvm users and not imposing a big burden on llvm developers: 474 475* The textual format is not backwards compatible. We don't change it too often, 476 but there are no specific promises. 477 478* Additions and changes to the IR should be reflected in 479 ``test/Bitcode/compatibility.ll``. 480 481* The current LLVM version supports loading any bitcode since version 3.0. 482 483* After each X.Y release, ``compatibility.ll`` must be copied to 484 ``compatibility-X.Y.ll``. The corresponding bitcode file should be assembled 485 using the X.Y build and committed as ``compatibility-X.Y.ll.bc``. 486 487* Newer releases can ignore features from older releases, but they cannot 488 miscompile them. For example, if nsw is ever replaced with something else, 489 dropping it would be a valid way to upgrade the IR. 490 491* Debug metadata is special in that it is currently dropped during upgrades. 492 493* Non-debug metadata is defined to be safe to drop, so a valid way to upgrade 494 it is to drop it. That is not very user friendly and a bit more effort is 495 expected, but no promises are made. 496 497C API Changes 498---------------- 499 500* Stability Guarantees: The C API is, in general, a "best effort" for stability. 501 This means that we make every attempt to keep the C API stable, but that 502 stability will be limited by the abstractness of the interface and the 503 stability of the C++ API that it wraps. In practice, this means that things 504 like "create debug info" or "create this type of instruction" are likely to be 505 less stable than "take this IR file and JIT it for my current machine". 506 507* Release stability: We won't break the C API on the release branch with patches 508 that go on that branch, with the exception that we will fix an unintentional 509 C API break that will keep the release consistent with both the previous and 510 next release. 511 512* Testing: Patches to the C API are expected to come with tests just like any 513 other patch. 514 515* Including new things into the API: If an LLVM subcomponent has a C API already 516 included, then expanding that C API is acceptable. Adding C API for 517 subcomponents that don't currently have one needs to be discussed on the 518 mailing list for design and maintainability feedback prior to implementation. 519 520* Documentation: Any changes to the C API are required to be documented in the 521 release notes so that it's clear to external users who do not follow the 522 project how the C API is changing and evolving. 523 524New Targets 525----------- 526 527LLVM is very receptive to new targets, even experimental ones, but a number of 528problems can appear when adding new large portions of code, and back-ends are 529normally added in bulk. We have found that landing large pieces of new code 530and then trying to fix emergent problems in-tree is problematic for a variety 531of reasons. 532 533For these reasons, new targets are *always* added as *experimental* until 534they can be proven stable, and later moved to non-experimental. The differences 535between both classes are: 536 537* Experimental targets are not built by default (they need to be explicitly 538 enabled at CMake time). 539 540* Test failures, bugs, and build breakages that only appear when the 541 experimental target is enabled, caused by changes unrelated to the target, are 542 the responsibility of the community behind the target to fix. 543 544The basic rules for a back-end to be upstreamed in **experimental** mode are: 545 546* Every target must have a :ref:`code owner<code owners>`. The `CODE_OWNERS.TXT` 547 file has to be updated as part of the first merge. The code owner makes sure 548 that changes to the target get reviewed and steers the overall effort. 549 550* There must be an active community behind the target. This community 551 will help maintain the target by providing buildbots, fixing 552 bugs, answering the LLVM community's questions and making sure the new 553 target doesn't break any of the other targets, or generic code. This 554 behavior is expected to continue throughout the lifetime of the 555 target's code. 556 557* The code must be free of contentious issues, for example, large 558 changes in how the IR behaves or should be formed by the front-ends, 559 unless agreed by the majority of the community via refactoring of the 560 (:doc:`IR standard<LangRef>`) **before** the merge of the new target changes, 561 following the :ref:`IR backwards compatibility`. 562 563* The code conforms to all of the policies laid out in this developer policy 564 document, including license, patent, and coding standards. 565 566* The target should have either reasonable documentation on how it 567 works (ISA, ABI, etc.) or a publicly available simulator/hardware 568 (either free or cheap enough) - preferably both. This allows 569 developers to validate assumptions, understand constraints and review code 570 that can affect the target. 571 572In addition, the rules for a back-end to be promoted to **official** are: 573 574* The target must have addressed every other minimum requirement and 575 have been stable in tree for at least 3 months. This cool down 576 period is to make sure that the back-end and the target community can 577 endure continuous upstream development for the foreseeable future. 578 579* The target's code must have been completely adapted to this policy 580 as well as the :doc:`coding standards<CodingStandards>`. Any exceptions that 581 were made to move into experimental mode must have been fixed **before** 582 becoming official. 583 584* The test coverage needs to be broad and well written (small tests, 585 well documented). The build target ``check-all`` must pass with the 586 new target built, and where applicable, the ``test-suite`` must also 587 pass without errors, in at least one configuration (publicly 588 demonstrated, for example, via buildbots). 589 590* Public buildbots need to be created and actively maintained, unless 591 the target requires no additional buildbots (ex. ``check-all`` covers 592 all tests). The more relevant and public the new target's CI infrastructure 593 is, the more the LLVM community will embrace it. 594 595To **continue** as a supported and official target: 596 597* The maintainer(s) must continue following these rules throughout the lifetime 598 of the target. Continuous violations of aforementioned rules and policies 599 could lead to complete removal of the target from the code base. 600 601* Degradation in support, documentation or test coverage will make the target as 602 nuisance to other targets and be considered a candidate for deprecation and 603 ultimately removed. 604 605In essences, these rules are necessary for targets to gain and retain their 606status, but also markers to define bit-rot, and will be used to clean up the 607tree from unmaintained targets. 608 609.. _toolchain: 610 611Updating Toolchain Requirements 612------------------------------- 613 614We intend to require newer toolchains as time goes by. This means LLVM's 615codebase can use newer versions of C++ as they get standardized. Requiring newer 616toolchains to build LLVM can be painful for those building LLVM; therefore, it 617will only be done through the following process: 618 619 * Generally, try to support LLVM and GCC versions from the last 3 years at a 620 minimum. This time-based guideline is not strict: we may support much older 621 compilers, or decide to support fewer versions. 622 623 * An RFC is sent to the `llvm-dev mailing list <http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ 624 625 - Detail upsides of the version increase (e.g. which newer C++ language or 626 library features LLVM should use; avoid miscompiles in particular compiler 627 versions, etc). 628 - Detail downsides on important platforms (e.g. Ubuntu LTS status). 629 630 * Once the RFC reaches consensus, update the CMake toolchain version checks as 631 well as the :doc:`getting started<GettingStarted>` guide. We want to 632 soft-error when developers compile LLVM. We say "soft-error" because the 633 error can be turned into a warning using a CMake flag. This is an important 634 step: LLVM still doesn't have code which requires the new toolchains, but it 635 soon will. If you compile LLVM but don't read the mailing list, we should 636 tell you! 637 638 * Ensure that at least one LLVM release has had this soft-error. Not all 639 developers compile LLVM top-of-tree. These release-bound developers should 640 also be told about upcoming changes. 641 642 * Turn the soft-error into a hard-error after said LLVM release has branched. 643 644 * Update the :doc:`coding standards<CodingStandards>` to allow the new 645 features we've explicitly approved in the RFC. 646 647 * Start using the new features in LLVM's codebase. 648 649Here's a `sample RFC 650<http://lists.llvm.org/pipermail/llvm-dev/2019-January/129452.html>`_ and the 651`corresponding change <https://reviews.llvm.org/D57264>`_. 652 653.. _copyright-license-patents: 654 655Copyright, License, and Patents 656=============================== 657 658.. note:: 659 660 This section deals with legal matters but does not provide legal advice. We 661 are not lawyers --- please seek legal counsel from a licensed attorney. 662 663This section addresses the issues of copyright, license and patents for the LLVM 664project. The copyright for the code is held by the contributors of 665the code. The code is licensed under permissive `open source licensing terms`_, 666namely the Apache 2 license, which includes a copyright and `patent license`_. 667When you contribute code to the LLVM project, you license it under these terms. 668 669If you have questions or comments about these topics, please contact the 670`LLVM Developer's Mailing List <mailto:[email protected]>`_. However, 671please realize that most compiler developers are not lawyers, and therefore you 672will not be getting official legal advice. 673 674Copyright 675--------- 676 677The LLVM project does not collect copyright assignments, which means that the 678copyright for the code in the project is held by the respective contributors. 679Because you (or your company) 680retain ownership of the code you contribute, you know it may only be used under 681the terms of the open source license you contributed it under: the license for 682your contributions cannot be changed in the future without your approval. 683 684Because the LLVM project does not require copyright assignments, changing the 685LLVM license requires tracking down the 686contributors to LLVM and getting them to agree that a license change is 687acceptable for their contributions. We feel that a high burden for relicensing 688is good for the project, because contributors do not have to fear that their 689code will be used in a way with which they disagree. 690 691Relicensing 692----------- 693 694The last paragraph notwithstanding, the LLVM Project is in the middle of a large 695effort to change licenses, which aims to solve several problems: 696 697* The old licenses made it difficult to move code from (e.g.) the compiler to 698 runtime libraries, because runtime libraries used a different license from the 699 rest of the compiler. 700* Some contributions were not submitted to LLVM due to concerns that 701 the patent grant required by the project was overly broad. 702* The patent grant was unique to the LLVM Project, not written by a lawyer, and 703 was difficult to determine what protection was provided (if any). 704 705The scope of relicensing is all code that is considered part of the LLVM 706project, including the main LLVM repository, runtime libraries (compiler_rt, 707OpenMP, etc), Polly, and all other subprojects. There are a few exceptions: 708 709* Code imported from other projects (e.g. Google Test, Autoconf, etc) will 710 remain as it is. This code isn't developed as part of the LLVM project, it 711 is used by LLVM. 712* Some subprojects are impractical or uninteresting to relicense (e.g. llvm-gcc 713 and dragonegg). These will be split off from the LLVM project (e.g. to 714 separate GitHub projects), allowing interested people to continue their 715 development elsewhere. 716 717To relicense LLVM, we will be seeking approval from all of the copyright holders 718of code in the repository, or potentially remove/rewrite code if we cannot. 719This is a large 720and challenging project which will take a significant amount of time to 721complete. In the interim, **all contributions to the project will be made under 722the terms of both the new license and the legacy license scheme** (each of which 723is described below). The exception to this is the legacy patent grant, which 724will not be required for new contributions. 725 726When all of the code in the project has been converted to the new license or 727removed, we will drop the requirement to contribute under the legacy license. 728This will achieve the goal of having 729a single standardized license for the entire codebase. 730 731If you are a prior contributor to LLVM and have not done so already, please do 732*TODO* to allow us to use your code. *Add a link to a separate page here, which 733is probably a click through web form or something like that. Details to be 734determined later*. 735 736 737.. _open source licensing terms: 738 739New LLVM Project License Framework 740---------------------------------- 741 742Contributions to LLVM are licensed under the `Apache License, Version 2.0 743<https://www.apache.org/licenses/LICENSE-2.0>`_, with two limited 744exceptions intended to ensure that LLVM is very permissively licensed. 745Collectively, the name of this license is "Apache 2.0 License with LLVM 746exceptions". The exceptions read: 747 748:: 749 750 ---- LLVM Exceptions to the Apache 2.0 License ---- 751 752 As an exception, if, as a result of your compiling your source code, portions 753 of this Software are embedded into an Object form of such source code, you 754 may redistribute such embedded portions in such Object form without complying 755 with the conditions of Sections 4(a), 4(b) and 4(d) of the License. 756 757 In addition, if you combine or link compiled forms of this Software with 758 software that is licensed under the GPLv2 ("Combined Software") and if a 759 court of competent jurisdiction determines that the patent provision (Section 760 3), the indemnity provision (Section 9) or other Section of the License 761 conflicts with the conditions of the GPLv2, you may retroactively and 762 prospectively choose to deem waived or otherwise exclude such Section(s) of 763 the License, but only in their entirety and only with respect to the Combined 764 Software. 765 766 767We intend to keep LLVM perpetually open source and available under a permissive 768license - this fosters the widest adoption of LLVM by 769**allowing commercial products to be derived from LLVM** with few restrictions 770and without a requirement for making any derived works also open source. In 771particular, LLVM's license is not a "copyleft" license like the GPL. 772 773The "Apache 2.0 License with LLVM exceptions" allows you to: 774 775* freely download and use LLVM (in whole or in part) for personal, internal, or 776 commercial purposes. 777* include LLVM in packages or distributions you create. 778* combine LLVM with code licensed under every other major open source 779 license (including BSD, MIT, GPLv2, GPLv3...). 780* make changes to LLVM code without being required to contribute it back 781 to the project - contributions are appreciated though! 782 783However, it imposes these limitations on you: 784 785* You must retain the copyright notice if you redistribute LLVM: You cannot 786 strip the copyright headers off or replace them with your own. 787* Binaries that include LLVM must reproduce the copyright notice (e.g. in an 788 included README file or in an "About" box), unless the LLVM code was added as 789 a by-product of compilation. For example, if an LLVM runtime library like 790 compiler_rt or libc++ was automatically included into your application by the 791 compiler, you do not need to attribute it. 792* You can't use our names to promote your products (LLVM derived or not) - 793 though you can make truthful statements about your use of the LLVM code, 794 without implying our sponsorship. 795* There's no warranty on LLVM at all. 796 797We want LLVM code to be widely used, and believe that this provides a model that 798is great for contributors and users of the project. For more information about 799the Apache 2.0 License, please see the `Apache License FAQ 800<http://www.apache.org/foundation/license-faq.html>`_, maintained by the 801Apache Project. 802 803 804.. note:: 805 806 The LLVM Project includes some really old subprojects (dragonegg, 807 llvm-gcc-4.0, and llvm-gcc-4.2), which are licensed under **GPL 808 licenses**. This code is not actively maintained - it does not even 809 build successfully. This code is cleanly separated into distinct SVN 810 repositories from the rest of LLVM, and the LICENSE.txt files specifically 811 indicate that they contain GPL code. When LLVM transitions from SVN to Git, 812 we plan to drop these code bases from the new repository structure. 813 814 815.. _patent license: 816 817Patents 818------- 819 820Section 3 of the Apache 2.0 license is a patent grant under which 821contributors of code to the project contribute the rights to use any of 822their patents that would otherwise be infringed by that code contribution 823(protecting uses of that code). Further, the patent grant is revoked 824from anyone who files a patent lawsuit about code in LLVM - this protects the 825community by providing a "patent commons" for the code base and reducing the 826odds of patent lawsuits in general. 827 828The license specifically scopes which patents are included with code 829contributions. To help explain this, the `Apache License FAQ 830<http://www.apache.org/foundation/license-faq.html>`_ explains this scope using 831some questions and answers, which we reproduce here for your convenience (for 832reference, the "ASF" is the Apache Software Foundation, the guidance still 833holds though):: 834 835 Q1: If I own a patent and contribute to a Work, and, at the time my 836 contribution is included in that Work, none of my patent's claims are subject 837 to Apache's Grant of Patent License, is there a way any of those claims would 838 later become subject to the Grant of Patent License solely due to subsequent 839 contributions by other parties who are not licensees of that patent. 840 841 A1: No. 842 843 Q2: If at any time after my contribution, I am able to license other patent 844 claims that would have been subject to Apache's Grant of Patent License if 845 they were licensable by me at the time of my contribution, do those other 846 claims become subject to the Grant of Patent License? 847 848 A2: Yes. 849 850 Q3: If I own or control a licensable patent and contribute code to a specific 851 Apache product, which of my patent claims are subject to Apache's Grant of 852 Patent License? 853 854 A3: The only patent claims that are licensed to the ASF are those you own or 855 have the right to license that read on your contribution or on the 856 combination of your contribution with the specific Apache product to which 857 you contributed as it existed at the time of your contribution. No additional 858 patent claims become licensed as a result of subsequent combinations of your 859 contribution with any other software. Note, however, that licensable patent 860 claims include those that you acquire in the future, as long as they read on 861 your original contribution as made at the original time. Once a patent claim 862 is subject to Apache's Grant of Patent License, it is licensed under the 863 terms of that Grant to the ASF and to recipients of any software distributed 864 by the ASF for any Apache software product whatsoever. 865 866.. _legacy: 867 868Legacy License Structure 869------------------------ 870 871.. note:: 872 The code base was previously licensed under the Terms described here. 873 We are in the middle of relicensing to a new approach (described above), but 874 until this effort is complete, the code is also still available under these 875 terms. Once we finish the relicensing project, new versions of the code will 876 not be available under these terms. However, nothing takes away your right 877 to use old versions under the licensing terms under which they were 878 originally released. 879 880We intend to keep LLVM perpetually open source and to use a permissive open 881source license. The code in 882LLVM is available under the `University of Illinois/NCSA Open Source License 883<http://www.opensource.org/licenses/UoI-NCSA.php>`_, which boils down to 884this: 885 886* You can freely distribute LLVM. 887* You must retain the copyright notice if you redistribute LLVM. 888* Binaries derived from LLVM must reproduce the copyright notice (e.g. in an 889 included README file). 890* You can't use our names to promote your LLVM derived products. 891* There's no warranty on LLVM at all. 892 893We believe this fosters the widest adoption of LLVM because it **allows 894commercial products to be derived from LLVM** with few restrictions and without 895a requirement for making any derived works also open source (i.e. LLVM's 896license is not a "copyleft" license like the GPL). We suggest that you read the 897`License <http://www.opensource.org/licenses/UoI-NCSA.php>`_ if further 898clarification is needed. 899 900In addition to the UIUC license, the runtime library components of LLVM 901(**compiler_rt, libc++, and libclc**) are also licensed under the `MIT License 902<http://www.opensource.org/licenses/mit-license.php>`_, which does not contain 903the binary redistribution clause. As a user of these runtime libraries, it 904means that you can choose to use the code under either license (and thus don't 905need the binary redistribution clause), and as a contributor to the code that 906you agree that any contributions to these libraries be licensed under both 907licenses. We feel that this is important for runtime libraries, because they 908are implicitly linked into applications and therefore should not subject those 909applications to the binary redistribution clause. This also means that it is ok 910to move code from (e.g.) libc++ to the LLVM core without concern, but that code 911cannot be moved from the LLVM core to libc++ without the copyright owner's 912permission. 913