1===================== 2LLVM Developer Policy 3===================== 4 5.. contents:: 6 :local: 7 8Introduction 9============ 10 11This document contains the LLVM Developer Policy which defines the project's 12policy towards developers and their contributions. The intent of this policy is 13to eliminate miscommunication, rework, and confusion that might arise from the 14distributed nature of LLVM's development. By stating the policy in clear terms, 15we hope each developer can know ahead of time what to expect when making LLVM 16contributions. This policy covers all llvm.org subprojects, including Clang, 17LLDB, libc++, etc. 18 19This policy is also designed to accomplish the following objectives: 20 21#. Attract both users and developers to the LLVM project. 22 23#. Make life as simple and easy for contributors as possible. 24 25#. Keep the top of tree as stable as possible. 26 27#. Establish awareness of the project's :ref:`copyright, license, and patent 28 policies <copyright-license-patents>` with contributors to the project. 29 30This policy is aimed at frequent contributors to LLVM. People interested in 31contributing one-off patches can do so in an informal way by sending them to the 32`llvm-commits mailing list 33<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_ and engaging another 34developer to see it through the process. 35 36Developer Policies 37================== 38 39This section contains policies that pertain to frequent LLVM developers. We 40always welcome `one-off patches`_ from people who do not routinely contribute to 41LLVM, but we expect more from frequent contributors to keep the system as 42efficient as possible for everyone. Frequent LLVM contributors are expected to 43meet the following requirements in order for LLVM to maintain a high standard of 44quality. 45 46Stay Informed 47------------- 48 49Developers should stay informed by reading at least the "dev" mailing list for 50the projects you are interested in, such as `llvm-dev 51<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ for LLVM, `cfe-dev 52<http://lists.llvm.org/mailman/listinfo/cfe-dev>`_ for Clang, or `lldb-dev 53<http://lists.llvm.org/mailman/listinfo/lldb-dev>`_ for LLDB. If you are 54doing anything more than just casual work on LLVM, it is suggested that you also 55subscribe to the "commits" mailing list for the subproject you're interested in, 56such as `llvm-commits 57<http://lists.llvm.org/mailman/listinfo/llvm-commits>`_, `cfe-commits 58<http://lists.llvm.org/mailman/listinfo/cfe-commits>`_, or `lldb-commits 59<http://lists.llvm.org/mailman/listinfo/lldb-commits>`_. Reading the 60"commits" list and paying attention to changes being made by others is a good 61way to see what other people are interested in and watching the flow of the 62project as a whole. 63 64We recommend that active developers register an email account with `LLVM 65Bugzilla <https://bugs.llvm.org/>`_ and preferably subscribe to the `llvm-bugs 66<http://lists.llvm.org/mailman/listinfo/llvm-bugs>`_ email list to keep track 67of bugs and enhancements occurring in LLVM. We really appreciate people who are 68proactive at catching incoming bugs in their components and dealing with them 69promptly. 70 71Please be aware that all public LLVM mailing lists are public and archived, and 72that notices of confidentiality or non-disclosure cannot be respected. 73 74.. _patch: 75.. _one-off patches: 76 77Making and Submitting a Patch 78----------------------------- 79 80When making a patch for review, the goal is to make it as easy for the reviewer 81to read it as possible. As such, we recommend that you: 82 83#. Make your patch against git master, not a branch, and not an old version 84 of LLVM. This makes it easy to apply the patch. For information on how to 85 clone from git, please see the :ref:`Getting Started Guide 86 <checkout>`. 87 88#. Similarly, patches should be submitted soon after they are generated. Old 89 patches may not apply correctly if the underlying code changes between the 90 time the patch was created and the time it is applied. 91 92#. Patches should be made with ``git format-patch``, or similar. If you use a 93 different tool, make sure it uses the ``diff -u`` format and that it 94 doesn't contain clutter which makes it hard to read. 95 96Once your patch is ready, submit it by emailing it to the appropriate project's 97commit mailing list (or commit it directly if applicable). Alternatively, some 98patches get sent to the project's development list or component of the LLVM bug 99tracker, but the commit list is the primary place for reviews and should 100generally be preferred. 101 102When sending a patch to a mailing list, it is a good idea to send it as an 103*attachment* to the message, not embedded into the text of the message. This 104ensures that your mailer will not mangle the patch when it sends it (e.g. by 105making whitespace changes or by wrapping lines). 106 107*For Thunderbird users:* Before submitting a patch, please open *Preferences > 108Advanced > General > Config Editor*, find the key 109``mail.content_disposition_type``, and set its value to ``1``. Without this 110setting, Thunderbird sends your attachment using ``Content-Disposition: inline`` 111rather than ``Content-Disposition: attachment``. Apple Mail gamely displays such 112a file inline, making it difficult to work with for reviewers using that 113program. 114 115When submitting patches, please do not add confidentiality or non-disclosure 116notices to the patches themselves. These notices conflict with the LLVM 117licensing terms and may result in your contribution being excluded. 118 119.. _code review: 120 121Code Reviews 122------------ 123 124LLVM has a code-review policy. Code review is one way to increase the quality of 125software. Please see :doc:`CodeReview` for more information on LLVM's code-review 126process. 127 128.. _code owners: 129 130Code Owners 131----------- 132 133The LLVM Project relies on two features of its process to maintain rapid 134development in addition to the high quality of its source base: the combination 135of code review plus post-commit review for trusted maintainers. Having both is 136a great way for the project to take advantage of the fact that most people do 137the right thing most of the time, and only commit patches without pre-commit 138review when they are confident they are right. 139 140The trick to this is that the project has to guarantee that all patches that are 141committed are reviewed after they go in: you don't want everyone to assume 142someone else will review it, allowing the patch to go unreviewed. To solve this 143problem, we have a notion of an 'owner' for a piece of the code. The sole 144responsibility of a code owner is to ensure that a commit to their area of the 145code is appropriately reviewed, either by themself or by someone else. The list 146of current code owners can be found in the file `CODE_OWNERS.TXT 147<https://github.com/llvm/llvm-project/blob/master/llvm/CODE_OWNERS.TXT>`_ in the 148root of the LLVM source tree. 149 150Note that code ownership is completely different than reviewers: anyone can 151review a piece of code, and we welcome code review from anyone who is 152interested. Code owners are the "last line of defense" to guarantee that all 153patches that are committed are actually reviewed. 154 155Being a code owner is a somewhat unglamorous position, but it is incredibly 156important for the ongoing success of the project. Because people get busy, 157interests change, and unexpected things happen, code ownership is purely opt-in, 158and anyone can choose to resign their "title" at any time. For now, we do not 159have an official policy on how one gets elected to be a code owner. 160 161.. _include a testcase: 162 163Test Cases 164---------- 165 166Developers are required to create test cases for any bugs fixed and any new 167features added. Some tips for getting your testcase approved: 168 169* All feature and regression test cases are added to the ``llvm/test`` 170 directory. The appropriate sub-directory should be selected (see the 171 :doc:`Testing Guide <TestingGuide>` for details). 172 173* Test cases should be written in :doc:`LLVM assembly language <LangRef>`. 174 175* Test cases, especially for regressions, should be reduced as much as possible, 176 by :doc:`bugpoint <Bugpoint>` or manually. It is unacceptable to place an 177 entire failing program into ``llvm/test`` as this creates a *time-to-test* 178 burden on all developers. Please keep them short. 179 180Note that llvm/test and clang/test are designed for regression and small feature 181tests only. More extensive test cases (e.g., entire applications, benchmarks, 182etc) should be added to the ``llvm-test`` test suite. The llvm-test suite is 183for coverage (correctness, performance, etc) testing, not feature or regression 184testing. 185 186Quality 187------- 188 189The minimum quality standards that any change must satisfy before being 190committed to the main development branch are: 191 192#. Code must adhere to the `LLVM Coding Standards <CodingStandards.html>`_. 193 194#. Code must compile cleanly (no errors, no warnings) on at least one platform. 195 196#. Bug fixes and new features should `include a testcase`_ so we know if the 197 fix/feature ever regresses in the future. 198 199#. Code must pass the ``llvm/test`` test suite. 200 201#. The code must not cause regressions on a reasonable subset of llvm-test, 202 where "reasonable" depends on the contributor's judgement and the scope of 203 the change (more invasive changes require more testing). A reasonable subset 204 might be something like "``llvm-test/MultiSource/Benchmarks``". 205 206Additionally, the committer is responsible for addressing any problems found in 207the future that the change is responsible for. For example: 208 209* The code should compile cleanly on all supported platforms. 210 211* The changes should not cause any correctness regressions in the ``llvm-test`` 212 suite and must not cause any major performance regressions. 213 214* The change set should not cause performance or correctness regressions for the 215 LLVM tools. 216 217* The changes should not cause performance or correctness regressions in code 218 compiled by LLVM on all applicable targets. 219 220* You are expected to address any `Bugzilla bugs <https://bugs.llvm.org/>`_ that 221 result from your change. 222 223We prefer for this to be handled before submission but understand that it isn't 224possible to test all of this for every submission. Our build bots and nightly 225testing infrastructure normally finds these problems. A good rule of thumb is 226to check the nightly testers for regressions the day after your change. Build 227bots will directly email you if a group of commits that included yours caused a 228failure. You are expected to check the build bot messages to see if they are 229your fault and, if so, fix the breakage. 230 231Commits that violate these quality standards (e.g. are very broken) may be 232reverted. This is necessary when the change blocks other developers from making 233progress. The developer is welcome to re-commit the change after the problem has 234been fixed. 235 236.. _commit messages: 237 238Commit messages 239--------------- 240 241Although we don't enforce the format of commit messages, we prefer that 242you follow these guidelines to help review, search in logs, email formatting 243and so on. These guidelines are very similar to rules used by other open source 244projects. 245 246Most importantly, the contents of the message should be carefully written to 247convey the rationale of the change (without delving too much in detail). It 248also should avoid being vague or overly specific. For example, "bits were not 249set right" will leave the reviewer wondering about which bits, and why they 250weren't right, while "Correctly set overflow bits in TargetInfo" conveys almost 251all there is to the change. 252 253Below are some guidelines about the format of the message itself: 254 255* Separate the commit message into title and body separated by a blank line. 256 257* If you're not the original author, ensure the 'Author' property of the commit is 258 set to the original author and the 'Committer' property is set to yourself. 259 You can use a command similar to 260 ``git commit --amend --author="John Doe <[email protected]>`` to correct the 261 author property if it is incorrect. See `Attribution of Changes`_ for more 262 information including the method we used for attribution before the project 263 migrated to git. 264 265* The title should be concise. Because all commits are emailed to the list with 266 the first line as the subject, long titles are frowned upon. Short titles 267 also look better in `git log`. 268 269* When the changes are restricted to a specific part of the code (e.g. a 270 back-end or optimization pass), it is customary to add a tag to the 271 beginning of the line in square brackets. For example, "[SCEV] ..." 272 or "[OpenMP] ...". This helps email filters and searches for post-commit 273 reviews. 274 275* The body, if it exists, should be separated from the title by an empty line. 276 277* The body should be concise, but explanatory, including a complete 278 reasoning. Unless it is required to understand the change, examples, 279 code snippets and gory details should be left to bug comments, web 280 review or the mailing list. 281 282* If the patch fixes a bug in bugzilla, please include the PR# in the message. 283 284* Text formatting and spelling should follow the same rules as documentation 285 and in-code comments, ex. capitalization, full stop, etc. 286 287* If the commit is a bug fix on top of another recently committed patch, or a 288 revert or reapply of a patch, include the git commit hash of the prior 289 related commit. This could be as simple as "Revert commit NNNN because it 290 caused PR#". 291 292For minor violations of these recommendations, the community normally favors 293reminding the contributor of this policy over reverting. Minor corrections and 294omissions can be handled by sending a reply to the commits mailing list. 295 296Obtaining Commit Access 297----------------------- 298 299New Contributors 300^^^^^^^^^^^^^^^^ 301We grant commit access to contributors with a track record of submitting high 302quality patches. If you would like commit access, please send an email to 303`Chris <mailto:[email protected]>`_ with your GitHub username. 304 305Prior to obtaining commit access, it is common practice to request that 306someone with commit access commits on your behalf. When doing so, please 307provide the name and email address you would like to use in the Author 308property of the commit. 309 310Your first commit to a repository may require the autogenerated email to be 311approved by a moderator of the mailing list. 312This is normal and will be done when the mailing list owner has time. 313 314If you have recently been granted commit access, these policies apply: 315 316#. You are granted *commit-after-approval* to all parts of LLVM. For 317 information on how to get approval for a patch, please see :doc:`CodeReview`. 318 When approved, you may commit it yourself. 319 320#. You are allowed to commit patches without approval which you think are 321 obvious. This is clearly a subjective decision --- we simply expect you to 322 use good judgement. Examples include: fixing build breakage, reverting 323 obviously broken patches, documentation/comment changes, any other minor 324 changes. Avoid committing formatting- or whitespace-only changes outside of 325 code you plan to make subsequent changes to. Also, try to separate 326 formatting or whitespace changes from functional changes, either by 327 correcting the format first (ideally) or afterward. Such changes should be 328 highly localized and the commit message should clearly state that the commit 329 is not intended to change functionality, usually by stating it is 330 :ref:`NFC <nfc>`. 331 332#. You are allowed to commit patches without approval to those portions of LLVM 333 that you have contributed or maintain (i.e., have been assigned 334 responsibility for), with the proviso that such commits must not break the 335 build. This is a "trust but verify" policy, and commits of this nature are 336 reviewed after they are committed. 337 338#. Multiple violations of these policies or a single egregious violation may 339 cause commit access to be revoked. 340 341In any case, your changes are still subject to `code review`_ (either before or 342after they are committed, depending on the nature of the change). You are 343encouraged to review other peoples' patches as well, but you aren't required 344to do so. 345 346Current Contributors - Transferring from SVN 347^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 348If you had commit access to SVN and would like to request commit access to 349GitHub, please email `llvm-admin <mailto:[email protected]>`_ with your 350SVN username and GitHub username. 351 352.. _discuss the change/gather consensus: 353 354Making a Major Change 355--------------------- 356 357When a developer begins a major new project with the aim of contributing it back 358to LLVM, they should inform the community with an email to the `llvm-dev 359<http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ email list, to the extent 360possible. The reason for this is to: 361 362#. keep the community informed about future changes to LLVM, 363 364#. avoid duplication of effort by preventing multiple parties working on the 365 same thing and not knowing about it, and 366 367#. ensure that any technical issues around the proposed work are discussed and 368 resolved before any significant work is done. 369 370The design of LLVM is carefully controlled to ensure that all the pieces fit 371together well and are as consistent as possible. If you plan to make a major 372change to the way LLVM works or want to add a major new extension, it is a good 373idea to get consensus with the development community before you start working on 374it. 375 376Once the design of the new feature is finalized, the work itself should be done 377as a series of `incremental changes`_, not as a long-term development branch. 378 379.. _incremental changes: 380 381Incremental Development 382----------------------- 383 384In the LLVM project, we do all significant changes as a series of incremental 385patches. We have a strong dislike for huge changes or long-term development 386branches. Long-term development branches have a number of drawbacks: 387 388#. Branches must have mainline merged into them periodically. If the branch 389 development and mainline development occur in the same pieces of code, 390 resolving merge conflicts can take a lot of time. 391 392#. Other people in the community tend to ignore work on branches. 393 394#. Huge changes (produced when a branch is merged back onto mainline) are 395 extremely difficult to `code review`_. 396 397#. Branches are not routinely tested by our nightly tester infrastructure. 398 399#. Changes developed as monolithic large changes often don't work until the 400 entire set of changes is done. Breaking it down into a set of smaller 401 changes increases the odds that any of the work will be committed to the main 402 repository. 403 404To address these problems, LLVM uses an incremental development style and we 405require contributors to follow this practice when making a large/invasive 406change. Some tips: 407 408* Large/invasive changes usually have a number of secondary changes that are 409 required before the big change can be made (e.g. API cleanup, etc). These 410 sorts of changes can often be done before the major change is done, 411 independently of that work. 412 413* The remaining inter-related work should be decomposed into unrelated sets of 414 changes if possible. Once this is done, define the first increment and get 415 consensus on what the end goal of the change is. 416 417* Each change in the set can be stand alone (e.g. to fix a bug), or part of a 418 planned series of changes that works towards the development goal. 419 420* Each change should be kept as small as possible. This simplifies your work 421 (into a logical progression), simplifies code review and reduces the chance 422 that you will get negative feedback on the change. Small increments also 423 facilitate the maintenance of a high quality code base. 424 425* Often, an independent precursor to a big change is to add a new API and slowly 426 migrate clients to use the new API. Each change to use the new API is often 427 "obvious" and can be committed without review. Once the new API is in place 428 and used, it is much easier to replace the underlying implementation of the 429 API. This implementation change is logically separate from the API 430 change. 431 432If you are interested in making a large change, and this scares you, please make 433sure to first `discuss the change/gather consensus`_ then ask about the best way 434to go about making the change. 435 436Attribution of Changes 437---------------------- 438 439When contributors submit a patch to an LLVM project, other developers with 440commit access may commit it for the author once appropriate (based on the 441progression of code review, etc.). When doing so, it is important to retain 442correct attribution of contributions to their contributors. However, we do not 443want the source code to be littered with random attributions "this code written 444by J. Random Hacker" (this is noisy and distracting). In practice, the revision 445control system keeps a perfect history of who changed what, and the CREDITS.txt 446file describes higher-level contributions. If you commit a patch for someone 447else, please follow the attribution of changes in the simple manner as outlined 448by the `commit messages`_ section. Overall, please do not add contributor names 449to the source code. 450 451Also, don't commit patches authored by others unless they have submitted the 452patch to the project or you have been authorized to submit them on their behalf 453(you work together and your company authorized you to contribute the patches, 454etc.). The author should first submit them to the relevant project's commit 455list, development list, or LLVM bug tracker component. If someone sends you 456a patch privately, encourage them to submit it to the appropriate list first. 457 458Our previous version control system (subversion) did not distinguish between the 459author and the committer like git does. As such, older commits used a different 460attribution mechanism. The previous method was to include "Patch by John Doe." 461in a separate line of the commit message and there are automated processes that 462rely on this format. 463 464.. _IR backwards compatibility: 465 466IR Backwards Compatibility 467-------------------------- 468 469When the IR format has to be changed, keep in mind that we try to maintain some 470backwards compatibility. The rules are intended as a balance between convenience 471for llvm users and not imposing a big burden on llvm developers: 472 473* The textual format is not backwards compatible. We don't change it too often, 474 but there are no specific promises. 475 476* Additions and changes to the IR should be reflected in 477 ``test/Bitcode/compatibility.ll``. 478 479* The current LLVM version supports loading any bitcode since version 3.0. 480 481* After each X.Y release, ``compatibility.ll`` must be copied to 482 ``compatibility-X.Y.ll``. The corresponding bitcode file should be assembled 483 using the X.Y build and committed as ``compatibility-X.Y.ll.bc``. 484 485* Newer releases can ignore features from older releases, but they cannot 486 miscompile them. For example, if nsw is ever replaced with something else, 487 dropping it would be a valid way to upgrade the IR. 488 489* Debug metadata is special in that it is currently dropped during upgrades. 490 491* Non-debug metadata is defined to be safe to drop, so a valid way to upgrade 492 it is to drop it. That is not very user friendly and a bit more effort is 493 expected, but no promises are made. 494 495C API Changes 496---------------- 497 498* Stability Guarantees: The C API is, in general, a "best effort" for stability. 499 This means that we make every attempt to keep the C API stable, but that 500 stability will be limited by the abstractness of the interface and the 501 stability of the C++ API that it wraps. In practice, this means that things 502 like "create debug info" or "create this type of instruction" are likely to be 503 less stable than "take this IR file and JIT it for my current machine". 504 505* Release stability: We won't break the C API on the release branch with patches 506 that go on that branch, with the exception that we will fix an unintentional 507 C API break that will keep the release consistent with both the previous and 508 next release. 509 510* Testing: Patches to the C API are expected to come with tests just like any 511 other patch. 512 513* Including new things into the API: If an LLVM subcomponent has a C API already 514 included, then expanding that C API is acceptable. Adding C API for 515 subcomponents that don't currently have one needs to be discussed on the 516 mailing list for design and maintainability feedback prior to implementation. 517 518* Documentation: Any changes to the C API are required to be documented in the 519 release notes so that it's clear to external users who do not follow the 520 project how the C API is changing and evolving. 521 522New Targets 523----------- 524 525LLVM is very receptive to new targets, even experimental ones, but a number of 526problems can appear when adding new large portions of code, and back-ends are 527normally added in bulk. We have found that landing large pieces of new code 528and then trying to fix emergent problems in-tree is problematic for a variety 529of reasons. 530 531For these reasons, new targets are *always* added as *experimental* until 532they can be proven stable, and later moved to non-experimental. The differences 533between both classes are: 534 535* Experimental targets are not built by default (they need to be explicitly 536 enabled at CMake time). 537 538* Test failures, bugs, and build breakages that only appear when the 539 experimental target is enabled, caused by changes unrelated to the target, are 540 the responsibility of the community behind the target to fix. 541 542The basic rules for a back-end to be upstreamed in **experimental** mode are: 543 544* Every target must have a :ref:`code owner<code owners>`. The `CODE_OWNERS.TXT` 545 file has to be updated as part of the first merge. The code owner makes sure 546 that changes to the target get reviewed and steers the overall effort. 547 548* There must be an active community behind the target. This community 549 will help maintain the target by providing buildbots, fixing 550 bugs, answering the LLVM community's questions and making sure the new 551 target doesn't break any of the other targets, or generic code. This 552 behavior is expected to continue throughout the lifetime of the 553 target's code. 554 555* The code must be free of contentious issues, for example, large 556 changes in how the IR behaves or should be formed by the front-ends, 557 unless agreed by the majority of the community via refactoring of the 558 (:doc:`IR standard<LangRef>`) **before** the merge of the new target changes, 559 following the :ref:`IR backwards compatibility`. 560 561* The code conforms to all of the policies laid out in this developer policy 562 document, including license, patent, and coding standards. 563 564* The target should have either reasonable documentation on how it 565 works (ISA, ABI, etc.) or a publicly available simulator/hardware 566 (either free or cheap enough) - preferably both. This allows 567 developers to validate assumptions, understand constraints and review code 568 that can affect the target. 569 570In addition, the rules for a back-end to be promoted to **official** are: 571 572* The target must have addressed every other minimum requirement and 573 have been stable in tree for at least 3 months. This cool down 574 period is to make sure that the back-end and the target community can 575 endure continuous upstream development for the foreseeable future. 576 577* The target's code must have been completely adapted to this policy 578 as well as the :doc:`coding standards<CodingStandards>`. Any exceptions that 579 were made to move into experimental mode must have been fixed **before** 580 becoming official. 581 582* The test coverage needs to be broad and well written (small tests, 583 well documented). The build target ``check-all`` must pass with the 584 new target built, and where applicable, the ``test-suite`` must also 585 pass without errors, in at least one configuration (publicly 586 demonstrated, for example, via buildbots). 587 588* Public buildbots need to be created and actively maintained, unless 589 the target requires no additional buildbots (ex. ``check-all`` covers 590 all tests). The more relevant and public the new target's CI infrastructure 591 is, the more the LLVM community will embrace it. 592 593To **continue** as a supported and official target: 594 595* The maintainer(s) must continue following these rules throughout the lifetime 596 of the target. Continuous violations of aforementioned rules and policies 597 could lead to complete removal of the target from the code base. 598 599* Degradation in support, documentation or test coverage will make the target as 600 nuisance to other targets and be considered a candidate for deprecation and 601 ultimately removed. 602 603In essences, these rules are necessary for targets to gain and retain their 604status, but also markers to define bit-rot, and will be used to clean up the 605tree from unmaintained targets. 606 607.. _toolchain: 608 609Updating Toolchain Requirements 610------------------------------- 611 612We intend to require newer toolchains as time goes by. This means LLVM's 613codebase can use newer versions of C++ as they get standardized. Requiring newer 614toolchains to build LLVM can be painful for those building LLVM; therefore, it 615will only be done through the following process: 616 617 * Generally, try to support LLVM and GCC versions from the last 3 years at a 618 minimum. This time-based guideline is not strict: we may support much older 619 compilers, or decide to support fewer versions. 620 621 * An RFC is sent to the `llvm-dev mailing list <http://lists.llvm.org/mailman/listinfo/llvm-dev>`_ 622 623 - Detail upsides of the version increase (e.g. which newer C++ language or 624 library features LLVM should use; avoid miscompiles in particular compiler 625 versions, etc). 626 - Detail downsides on important platforms (e.g. Ubuntu LTS status). 627 628 * Once the RFC reaches consensus, update the CMake toolchain version checks as 629 well as the :doc:`getting started<GettingStarted>` guide. We want to 630 soft-error when developers compile LLVM. We say "soft-error" because the 631 error can be turned into a warning using a CMake flag. This is an important 632 step: LLVM still doesn't have code which requires the new toolchains, but it 633 soon will. If you compile LLVM but don't read the mailing list, we should 634 tell you! 635 636 * Ensure that at least one LLVM release has had this soft-error. Not all 637 developers compile LLVM top-of-tree. These release-bound developers should 638 also be told about upcoming changes. 639 640 * Turn the soft-error into a hard-error after said LLVM release has branched. 641 642 * Update the :doc:`coding standards<CodingStandards>` to allow the new 643 features we've explicitly approved in the RFC. 644 645 * Start using the new features in LLVM's codebase. 646 647Here's a `sample RFC 648<http://lists.llvm.org/pipermail/llvm-dev/2019-January/129452.html>`_ and the 649`corresponding change <https://reviews.llvm.org/D57264>`_. 650 651.. _copyright-license-patents: 652 653Copyright, License, and Patents 654=============================== 655 656.. note:: 657 658 This section deals with legal matters but does not provide legal advice. We 659 are not lawyers --- please seek legal counsel from a licensed attorney. 660 661This section addresses the issues of copyright, license and patents for the LLVM 662project. The copyright for the code is held by the contributors of 663the code. The code is licensed under permissive `open source licensing terms`_, 664namely the Apache 2 license, which includes a copyright and `patent license`_. 665When you contribute code to the LLVM project, you license it under these terms. 666 667If you have questions or comments about these topics, please contact the 668`LLVM Developer's Mailing List <mailto:[email protected]>`_. However, 669please realize that most compiler developers are not lawyers, and therefore you 670will not be getting official legal advice. 671 672Copyright 673--------- 674 675The LLVM project does not collect copyright assignments, which means that the 676copyright for the code in the project is held by the respective contributors. 677Because you (or your company) 678retain ownership of the code you contribute, you know it may only be used under 679the terms of the open source license you contributed it under: the license for 680your contributions cannot be changed in the future without your approval. 681 682Because the LLVM project does not require copyright assignments, changing the 683LLVM license requires tracking down the 684contributors to LLVM and getting them to agree that a license change is 685acceptable for their contributions. We feel that a high burden for relicensing 686is good for the project, because contributors do not have to fear that their 687code will be used in a way with which they disagree. 688 689Relicensing 690----------- 691 692The last paragraph notwithstanding, the LLVM Project is in the middle of a large 693effort to change licenses, which aims to solve several problems: 694 695* The old licenses made it difficult to move code from (e.g.) the compiler to 696 runtime libraries, because runtime libraries used a different license from the 697 rest of the compiler. 698* Some contributions were not submitted to LLVM due to concerns that 699 the patent grant required by the project was overly broad. 700* The patent grant was unique to the LLVM Project, not written by a lawyer, and 701 was difficult to determine what protection was provided (if any). 702 703The scope of relicensing is all code that is considered part of the LLVM 704project, including the main LLVM repository, runtime libraries (compiler_rt, 705OpenMP, etc), Polly, and all other subprojects. There are a few exceptions: 706 707* Code imported from other projects (e.g. Google Test, Autoconf, etc) will 708 remain as it is. This code isn't developed as part of the LLVM project, it 709 is used by LLVM. 710* Some subprojects are impractical or uninteresting to relicense (e.g. llvm-gcc 711 and dragonegg). These will be split off from the LLVM project (e.g. to 712 separate GitHub projects), allowing interested people to continue their 713 development elsewhere. 714 715To relicense LLVM, we will be seeking approval from all of the copyright holders 716of code in the repository, or potentially remove/rewrite code if we cannot. 717This is a large 718and challenging project which will take a significant amount of time to 719complete. In the interim, **all contributions to the project will be made under 720the terms of both the new license and the legacy license scheme** (each of which 721is described below). The exception to this is the legacy patent grant, which 722will not be required for new contributions. 723 724When all of the code in the project has been converted to the new license or 725removed, we will drop the requirement to contribute under the legacy license. 726This will achieve the goal of having 727a single standardized license for the entire codebase. 728 729If you are a prior contributor to LLVM and have not done so already, please do 730*TODO* to allow us to use your code. *Add a link to a separate page here, which 731is probably a click through web form or something like that. Details to be 732determined later*. 733 734 735.. _open source licensing terms: 736 737New LLVM Project License Framework 738---------------------------------- 739 740Contributions to LLVM are licensed under the `Apache License, Version 2.0 741<https://www.apache.org/licenses/LICENSE-2.0>`_, with two limited 742exceptions intended to ensure that LLVM is very permissively licensed. 743Collectively, the name of this license is "Apache 2.0 License with LLVM 744exceptions". The exceptions read: 745 746:: 747 748 ---- LLVM Exceptions to the Apache 2.0 License ---- 749 750 As an exception, if, as a result of your compiling your source code, portions 751 of this Software are embedded into an Object form of such source code, you 752 may redistribute such embedded portions in such Object form without complying 753 with the conditions of Sections 4(a), 4(b) and 4(d) of the License. 754 755 In addition, if you combine or link compiled forms of this Software with 756 software that is licensed under the GPLv2 ("Combined Software") and if a 757 court of competent jurisdiction determines that the patent provision (Section 758 3), the indemnity provision (Section 9) or other Section of the License 759 conflicts with the conditions of the GPLv2, you may retroactively and 760 prospectively choose to deem waived or otherwise exclude such Section(s) of 761 the License, but only in their entirety and only with respect to the Combined 762 Software. 763 764 765We intend to keep LLVM perpetually open source and available under a permissive 766license - this fosters the widest adoption of LLVM by 767**allowing commercial products to be derived from LLVM** with few restrictions 768and without a requirement for making any derived works also open source. In 769particular, LLVM's license is not a "copyleft" license like the GPL. 770 771The "Apache 2.0 License with LLVM exceptions" allows you to: 772 773* freely download and use LLVM (in whole or in part) for personal, internal, or 774 commercial purposes. 775* include LLVM in packages or distributions you create. 776* combine LLVM with code licensed under every other major open source 777 license (including BSD, MIT, GPLv2, GPLv3...). 778* make changes to LLVM code without being required to contribute it back 779 to the project - contributions are appreciated though! 780 781However, it imposes these limitations on you: 782 783* You must retain the copyright notice if you redistribute LLVM: You cannot 784 strip the copyright headers off or replace them with your own. 785* Binaries that include LLVM must reproduce the copyright notice (e.g. in an 786 included README file or in an "About" box), unless the LLVM code was added as 787 a by-product of compilation. For example, if an LLVM runtime library like 788 compiler_rt or libc++ was automatically included into your application by the 789 compiler, you do not need to attribute it. 790* You can't use our names to promote your products (LLVM derived or not) - 791 though you can make truthful statements about your use of the LLVM code, 792 without implying our sponsorship. 793* There's no warranty on LLVM at all. 794 795We want LLVM code to be widely used, and believe that this provides a model that 796is great for contributors and users of the project. For more information about 797the Apache 2.0 License, please see the `Apache License FAQ 798<http://www.apache.org/foundation/license-faq.html>`_, maintained by the 799Apache Project. 800 801 802.. note:: 803 804 The LLVM Project includes some really old subprojects (dragonegg, 805 llvm-gcc-4.0, and llvm-gcc-4.2), which are licensed under **GPL 806 licenses**. This code is not actively maintained - it does not even 807 build successfully. This code is cleanly separated into distinct SVN 808 repositories from the rest of LLVM, and the LICENSE.txt files specifically 809 indicate that they contain GPL code. When LLVM transitions from SVN to Git, 810 we plan to drop these code bases from the new repository structure. 811 812 813.. _patent license: 814 815Patents 816------- 817 818Section 3 of the Apache 2.0 license is a patent grant under which 819contributors of code to the project contribute the rights to use any of 820their patents that would otherwise be infringed by that code contribution 821(protecting uses of that code). Further, the patent grant is revoked 822from anyone who files a patent lawsuit about code in LLVM - this protects the 823community by providing a "patent commons" for the code base and reducing the 824odds of patent lawsuits in general. 825 826The license specifically scopes which patents are included with code 827contributions. To help explain this, the `Apache License FAQ 828<http://www.apache.org/foundation/license-faq.html>`_ explains this scope using 829some questions and answers, which we reproduce here for your convenience (for 830reference, the "ASF" is the Apache Software Foundation, the guidance still 831holds though):: 832 833 Q1: If I own a patent and contribute to a Work, and, at the time my 834 contribution is included in that Work, none of my patent's claims are subject 835 to Apache's Grant of Patent License, is there a way any of those claims would 836 later become subject to the Grant of Patent License solely due to subsequent 837 contributions by other parties who are not licensees of that patent. 838 839 A1: No. 840 841 Q2: If at any time after my contribution, I am able to license other patent 842 claims that would have been subject to Apache's Grant of Patent License if 843 they were licensable by me at the time of my contribution, do those other 844 claims become subject to the Grant of Patent License? 845 846 A2: Yes. 847 848 Q3: If I own or control a licensable patent and contribute code to a specific 849 Apache product, which of my patent claims are subject to Apache's Grant of 850 Patent License? 851 852 A3: The only patent claims that are licensed to the ASF are those you own or 853 have the right to license that read on your contribution or on the 854 combination of your contribution with the specific Apache product to which 855 you contributed as it existed at the time of your contribution. No additional 856 patent claims become licensed as a result of subsequent combinations of your 857 contribution with any other software. Note, however, that licensable patent 858 claims include those that you acquire in the future, as long as they read on 859 your original contribution as made at the original time. Once a patent claim 860 is subject to Apache's Grant of Patent License, it is licensed under the 861 terms of that Grant to the ASF and to recipients of any software distributed 862 by the ASF for any Apache software product whatsoever. 863 864.. _legacy: 865 866Legacy License Structure 867------------------------ 868 869.. note:: 870 The code base was previously licensed under the Terms described here. 871 We are in the middle of relicensing to a new approach (described above), but 872 until this effort is complete, the code is also still available under these 873 terms. Once we finish the relicensing project, new versions of the code will 874 not be available under these terms. However, nothing takes away your right 875 to use old versions under the licensing terms under which they were 876 originally released. 877 878We intend to keep LLVM perpetually open source and to use a permissive open 879source license. The code in 880LLVM is available under the `University of Illinois/NCSA Open Source License 881<http://www.opensource.org/licenses/UoI-NCSA.php>`_, which boils down to 882this: 883 884* You can freely distribute LLVM. 885* You must retain the copyright notice if you redistribute LLVM. 886* Binaries derived from LLVM must reproduce the copyright notice (e.g. in an 887 included README file). 888* You can't use our names to promote your LLVM derived products. 889* There's no warranty on LLVM at all. 890 891We believe this fosters the widest adoption of LLVM because it **allows 892commercial products to be derived from LLVM** with few restrictions and without 893a requirement for making any derived works also open source (i.e. LLVM's 894license is not a "copyleft" license like the GPL). We suggest that you read the 895`License <http://www.opensource.org/licenses/UoI-NCSA.php>`_ if further 896clarification is needed. 897 898In addition to the UIUC license, the runtime library components of LLVM 899(**compiler_rt, libc++, and libclc**) are also licensed under the `MIT License 900<http://www.opensource.org/licenses/mit-license.php>`_, which does not contain 901the binary redistribution clause. As a user of these runtime libraries, it 902means that you can choose to use the code under either license (and thus don't 903need the binary redistribution clause), and as a contributor to the code that 904you agree that any contributions to these libraries be licensed under both 905licenses. We feel that this is important for runtime libraries, because they 906are implicitly linked into applications and therefore should not subject those 907applications to the binary redistribution clause. This also means that it is ok 908to move code from (e.g.) libc++ to the LLVM core without concern, but that code 909cannot be moved from the LLVM core to libc++ without the copyright owner's 910permission. 911