1 //===-- DWARFASTParserClang.cpp ---------------------------------*- C++ -*-===//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 
10 #include <stdlib.h>
11 
12 #include "DWARFASTParserClang.h"
13 #include "DWARFDIE.h"
14 #include "DWARFDIECollection.h"
15 #include "DWARFDebugInfo.h"
16 #include "DWARFDeclContext.h"
17 #include "DWARFDefines.h"
18 #include "SymbolFileDWARF.h"
19 #include "SymbolFileDWARFDwo.h"
20 #include "SymbolFileDWARFDebugMap.h"
21 #include "UniqueDWARFASTType.h"
22 
23 #include "Plugins/Language/ObjC/ObjCLanguage.h"
24 #include "lldb/Core/Module.h"
25 #include "lldb/Core/Value.h"
26 #include "lldb/Host/Host.h"
27 #include "lldb/Symbol/ClangASTImporter.h"
28 #include "lldb/Symbol/ClangExternalASTSourceCommon.h"
29 #include "lldb/Symbol/ClangUtil.h"
30 #include "lldb/Symbol/CompileUnit.h"
31 #include "lldb/Symbol/Function.h"
32 #include "lldb/Symbol/ObjectFile.h"
33 #include "lldb/Symbol/SymbolVendor.h"
34 #include "lldb/Symbol/TypeList.h"
35 #include "lldb/Symbol/TypeMap.h"
36 #include "lldb/Target/Language.h"
37 #include "lldb/Utility/LLDBAssert.h"
38 #include "lldb/Utility/Log.h"
39 #include "lldb/Utility/StreamString.h"
40 
41 #include "clang/AST/CXXInheritance.h"
42 #include "clang/AST/DeclCXX.h"
43 #include "clang/AST/DeclObjC.h"
44 #include "clang/AST/DeclTemplate.h"
45 
46 #include <map>
47 #include <vector>
48 
49 //#define ENABLE_DEBUG_PRINTF // COMMENT OUT THIS LINE PRIOR TO CHECKIN
50 
51 #ifdef ENABLE_DEBUG_PRINTF
52 #include <stdio.h>
53 #define DEBUG_PRINTF(fmt, ...) printf(fmt, __VA_ARGS__)
54 #else
55 #define DEBUG_PRINTF(fmt, ...)
56 #endif
57 
58 using namespace lldb;
59 using namespace lldb_private;
60 DWARFASTParserClang::DWARFASTParserClang(ClangASTContext &ast)
61     : m_ast(ast), m_die_to_decl_ctx(), m_decl_ctx_to_die() {}
62 
63 DWARFASTParserClang::~DWARFASTParserClang() {}
64 
65 static AccessType DW_ACCESS_to_AccessType(uint32_t dwarf_accessibility) {
66   switch (dwarf_accessibility) {
67   case DW_ACCESS_public:
68     return eAccessPublic;
69   case DW_ACCESS_private:
70     return eAccessPrivate;
71   case DW_ACCESS_protected:
72     return eAccessProtected;
73   default:
74     break;
75   }
76   return eAccessNone;
77 }
78 
79 static bool DeclKindIsCXXClass(clang::Decl::Kind decl_kind) {
80   switch (decl_kind) {
81   case clang::Decl::CXXRecord:
82   case clang::Decl::ClassTemplateSpecialization:
83     return true;
84   default:
85     break;
86   }
87   return false;
88 }
89 
90 struct BitfieldInfo {
91   uint64_t bit_size;
92   uint64_t bit_offset;
93 
94   BitfieldInfo()
95       : bit_size(LLDB_INVALID_ADDRESS), bit_offset(LLDB_INVALID_ADDRESS) {}
96 
97   void Clear() {
98     bit_size = LLDB_INVALID_ADDRESS;
99     bit_offset = LLDB_INVALID_ADDRESS;
100   }
101 
102   bool IsValid() const {
103     return (bit_size != LLDB_INVALID_ADDRESS) &&
104            (bit_offset != LLDB_INVALID_ADDRESS);
105   }
106 
107   bool NextBitfieldOffsetIsValid(const uint64_t next_bit_offset) const {
108     if (IsValid()) {
109       // This bitfield info is valid, so any subsequent bitfields must not
110       // overlap and must be at a higher bit offset than any previous bitfield
111       // + size.
112       return (bit_size + bit_offset) <= next_bit_offset;
113     } else {
114       // If the this BitfieldInfo is not valid, then any offset isOK
115       return true;
116     }
117   }
118 };
119 
120 ClangASTImporter &DWARFASTParserClang::GetClangASTImporter() {
121   if (!m_clang_ast_importer_ap) {
122     m_clang_ast_importer_ap.reset(new ClangASTImporter);
123   }
124   return *m_clang_ast_importer_ap;
125 }
126 
127 /// Detect a forward declaration that is nested in a DW_TAG_module.
128 static bool isClangModuleFwdDecl(const DWARFDIE &Die) {
129   if (!Die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0))
130     return false;
131   auto Parent = Die.GetParent();
132   while (Parent.IsValid()) {
133     if (Parent.Tag() == DW_TAG_module)
134       return true;
135     Parent = Parent.GetParent();
136   }
137   return false;
138 }
139 
140 TypeSP DWARFASTParserClang::ParseTypeFromDWO(const DWARFDIE &die, Log *log) {
141   ModuleSP dwo_module_sp = die.GetContainingDWOModule();
142   if (!dwo_module_sp)
143     return TypeSP();
144 
145   // This type comes from an external DWO module.
146   std::vector<CompilerContext> dwo_context;
147   die.GetDWOContext(dwo_context);
148   TypeMap dwo_types;
149 
150   if (!dwo_module_sp->GetSymbolVendor()->FindTypes(dwo_context, true,
151                                                    dwo_types)) {
152     if (!isClangModuleFwdDecl(die))
153       return TypeSP();
154 
155     // Since this this type is defined in one of the Clang modules imported by
156     // this symbol file, search all of them.
157     auto *SymFile = die.GetCU()->GetSymbolFileDWARF();
158     for (const auto &NameModule : SymFile->getExternalTypeModules()) {
159       if (!NameModule.second)
160         continue;
161       SymbolVendor *SymVendor = NameModule.second->GetSymbolVendor();
162       if (SymVendor->FindTypes(dwo_context, true, dwo_types))
163         break;
164     }
165   }
166 
167   const size_t num_dwo_types = dwo_types.GetSize();
168   if (num_dwo_types != 1)
169     return TypeSP();
170 
171   // We found a real definition for this type in the Clang module, so lets use
172   // it and cache the fact that we found a complete type for this die.
173   TypeSP dwo_type_sp = dwo_types.GetTypeAtIndex(0);
174   if (!dwo_type_sp)
175     return TypeSP();
176 
177   lldb_private::CompilerType dwo_type = dwo_type_sp->GetForwardCompilerType();
178 
179   lldb_private::CompilerType type =
180       GetClangASTImporter().CopyType(m_ast, dwo_type);
181 
182   if (!type)
183     return TypeSP();
184 
185   SymbolFileDWARF *dwarf = die.GetDWARF();
186   TypeSP type_sp(new Type(
187       die.GetID(), dwarf, dwo_type_sp->GetName(), dwo_type_sp->GetByteSize(),
188       NULL, LLDB_INVALID_UID, Type::eEncodingInvalid,
189       &dwo_type_sp->GetDeclaration(), type, Type::eResolveStateForward));
190 
191   dwarf->GetTypeList()->Insert(type_sp);
192   dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
193   clang::TagDecl *tag_decl = ClangASTContext::GetAsTagDecl(type);
194   if (tag_decl)
195     LinkDeclContextToDIE(tag_decl, die);
196   else {
197     clang::DeclContext *defn_decl_ctx = GetCachedClangDeclContextForDIE(die);
198     if (defn_decl_ctx)
199       LinkDeclContextToDIE(defn_decl_ctx, die);
200   }
201 
202   return type_sp;
203 }
204 
205 static void CompleteExternalTagDeclType(ClangASTImporter &ast_importer,
206                                         clang::DeclContext *decl_ctx,
207                                         DWARFDIE die,
208                                         const char *type_name_cstr) {
209   auto *tag_decl_ctx = clang::dyn_cast<clang::TagDecl>(decl_ctx);
210   if (!tag_decl_ctx)
211     return;
212 
213   // If this type was not imported from an external AST, there's nothing to do.
214   CompilerType type = ClangASTContext::GetTypeForDecl(tag_decl_ctx);
215   if (!type || !ast_importer.CanImport(type))
216     return;
217 
218   auto qual_type = ClangUtil::GetQualType(type);
219   if (!ast_importer.RequireCompleteType(qual_type)) {
220     die.GetDWARF()->GetObjectFile()->GetModule()->ReportError(
221         "Unable to complete the Decl context for DIE '%s' at offset "
222         "0x%8.8x.\nPlease file a bug report.",
223         type_name_cstr ? type_name_cstr : "", die.GetOffset());
224     // We need to make the type look complete otherwise, we might crash in
225     // Clang when adding children.
226     if (ClangASTContext::StartTagDeclarationDefinition(type))
227       ClangASTContext::CompleteTagDeclarationDefinition(type);
228   }
229 }
230 
231 TypeSP DWARFASTParserClang::ParseTypeFromDWARF(const SymbolContext &sc,
232                                                const DWARFDIE &die, Log *log,
233                                                bool *type_is_new_ptr) {
234   TypeSP type_sp;
235 
236   if (type_is_new_ptr)
237     *type_is_new_ptr = false;
238 
239   AccessType accessibility = eAccessNone;
240   if (die) {
241     SymbolFileDWARF *dwarf = die.GetDWARF();
242     if (log) {
243       DWARFDIE context_die;
244       clang::DeclContext *context =
245           GetClangDeclContextContainingDIE(die, &context_die);
246 
247       dwarf->GetObjectFile()->GetModule()->LogMessage(
248           log, "SymbolFileDWARF::ParseType (die = 0x%8.8x, decl_ctx = %p (die "
249                "0x%8.8x)) %s name = '%s')",
250           die.GetOffset(), static_cast<void *>(context),
251           context_die.GetOffset(), die.GetTagAsCString(), die.GetName());
252     }
253     Type *type_ptr = dwarf->GetDIEToType().lookup(die.GetDIE());
254     TypeList *type_list = dwarf->GetTypeList();
255     if (type_ptr == NULL) {
256       if (type_is_new_ptr)
257         *type_is_new_ptr = true;
258 
259       const dw_tag_t tag = die.Tag();
260 
261       bool is_forward_declaration = false;
262       DWARFAttributes attributes;
263       const char *type_name_cstr = NULL;
264       const char *mangled_name_cstr = NULL;
265       ConstString type_name_const_str;
266       Type::ResolveState resolve_state = Type::eResolveStateUnresolved;
267       uint64_t byte_size = 0;
268       Declaration decl;
269 
270       Type::EncodingDataType encoding_data_type = Type::eEncodingIsUID;
271       CompilerType clang_type;
272       DWARFFormValue form_value;
273 
274       dw_attr_t attr;
275 
276       switch (tag) {
277       case DW_TAG_typedef:
278       case DW_TAG_base_type:
279       case DW_TAG_pointer_type:
280       case DW_TAG_reference_type:
281       case DW_TAG_rvalue_reference_type:
282       case DW_TAG_const_type:
283       case DW_TAG_restrict_type:
284       case DW_TAG_volatile_type:
285       case DW_TAG_unspecified_type: {
286         // Set a bit that lets us know that we are currently parsing this
287         dwarf->GetDIEToType()[die.GetDIE()] = DIE_IS_BEING_PARSED;
288 
289         const size_t num_attributes = die.GetAttributes(attributes);
290         uint32_t encoding = 0;
291         DWARFFormValue encoding_uid;
292 
293         if (num_attributes > 0) {
294           uint32_t i;
295           for (i = 0; i < num_attributes; ++i) {
296             attr = attributes.AttributeAtIndex(i);
297             if (attributes.ExtractFormValueAtIndex(i, form_value)) {
298               switch (attr) {
299               case DW_AT_decl_file:
300                 decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
301                     form_value.Unsigned()));
302                 break;
303               case DW_AT_decl_line:
304                 decl.SetLine(form_value.Unsigned());
305                 break;
306               case DW_AT_decl_column:
307                 decl.SetColumn(form_value.Unsigned());
308                 break;
309               case DW_AT_name:
310                 type_name_cstr = form_value.AsCString();
311                 if (type_name_cstr)
312                   type_name_const_str.SetCString(type_name_cstr);
313                 break;
314               case DW_AT_byte_size:
315                 byte_size = form_value.Unsigned();
316                 break;
317               case DW_AT_encoding:
318                 encoding = form_value.Unsigned();
319                 break;
320               case DW_AT_type:
321                 encoding_uid = form_value;
322                 break;
323               default:
324               case DW_AT_sibling:
325                 break;
326               }
327             }
328           }
329         }
330 
331         if (tag == DW_TAG_typedef && encoding_uid.IsValid()) {
332           // Try to parse a typedef from the DWO file first as modules can
333           // contain typedef'ed structures that have no names like:
334           //
335           //  typedef struct { int a; } Foo;
336           //
337           // In this case we will have a structure with no name and a typedef
338           // named "Foo" that points to this unnamed structure. The name in the
339           // typedef is the only identifier for the struct, so always try to
340           // get typedefs from DWO files if possible.
341           //
342           // The type_sp returned will be empty if the typedef doesn't exist in
343           // a DWO file, so it is cheap to call this function just to check.
344           //
345           // If we don't do this we end up creating a TypeSP that says this is
346           // a typedef to type 0x123 (the DW_AT_type value would be 0x123 in
347           // the DW_TAG_typedef), and this is the unnamed structure type. We
348           // will have a hard time tracking down an unnammed structure type in
349           // the module DWO file, so we make sure we don't get into this
350           // situation by always resolving typedefs from the DWO file.
351           const DWARFDIE encoding_die = dwarf->GetDIE(DIERef(encoding_uid));
352 
353           // First make sure that the die that this is typedef'ed to _is_ just
354           // a declaration (DW_AT_declaration == 1), not a full definition
355           // since template types can't be represented in modules since only
356           // concrete instances of templates are ever emitted and modules won't
357           // contain those
358           if (encoding_die &&
359               encoding_die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0) ==
360                   1) {
361             type_sp = ParseTypeFromDWO(die, log);
362             if (type_sp)
363               return type_sp;
364           }
365         }
366 
367         DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\") type => 0x%8.8lx\n",
368                      die.GetID(), DW_TAG_value_to_name(tag), type_name_cstr,
369                      encoding_uid.Reference());
370 
371         switch (tag) {
372         default:
373           break;
374 
375         case DW_TAG_unspecified_type:
376           if (strcmp(type_name_cstr, "nullptr_t") == 0 ||
377               strcmp(type_name_cstr, "decltype(nullptr)") == 0) {
378             resolve_state = Type::eResolveStateFull;
379             clang_type = m_ast.GetBasicType(eBasicTypeNullPtr);
380             break;
381           }
382           // Fall through to base type below in case we can handle the type
383           // there...
384           LLVM_FALLTHROUGH;
385 
386         case DW_TAG_base_type:
387           resolve_state = Type::eResolveStateFull;
388           clang_type = m_ast.GetBuiltinTypeForDWARFEncodingAndBitSize(
389               type_name_cstr, encoding, byte_size * 8);
390           break;
391 
392         case DW_TAG_pointer_type:
393           encoding_data_type = Type::eEncodingIsPointerUID;
394           break;
395         case DW_TAG_reference_type:
396           encoding_data_type = Type::eEncodingIsLValueReferenceUID;
397           break;
398         case DW_TAG_rvalue_reference_type:
399           encoding_data_type = Type::eEncodingIsRValueReferenceUID;
400           break;
401         case DW_TAG_typedef:
402           encoding_data_type = Type::eEncodingIsTypedefUID;
403           break;
404         case DW_TAG_const_type:
405           encoding_data_type = Type::eEncodingIsConstUID;
406           break;
407         case DW_TAG_restrict_type:
408           encoding_data_type = Type::eEncodingIsRestrictUID;
409           break;
410         case DW_TAG_volatile_type:
411           encoding_data_type = Type::eEncodingIsVolatileUID;
412           break;
413         }
414 
415         if (!clang_type &&
416             (encoding_data_type == Type::eEncodingIsPointerUID ||
417              encoding_data_type == Type::eEncodingIsTypedefUID) &&
418             sc.comp_unit != NULL) {
419           if (tag == DW_TAG_pointer_type) {
420             DWARFDIE target_die = die.GetReferencedDIE(DW_AT_type);
421 
422             if (target_die.GetAttributeValueAsUnsigned(DW_AT_APPLE_block, 0)) {
423               // Blocks have a __FuncPtr inside them which is a pointer to a
424               // function of the proper type.
425 
426               for (DWARFDIE child_die = target_die.GetFirstChild();
427                    child_die.IsValid(); child_die = child_die.GetSibling()) {
428                 if (!strcmp(child_die.GetAttributeValueAsString(DW_AT_name, ""),
429                             "__FuncPtr")) {
430                   DWARFDIE function_pointer_type =
431                       child_die.GetReferencedDIE(DW_AT_type);
432 
433                   if (function_pointer_type) {
434                     DWARFDIE function_type =
435                         function_pointer_type.GetReferencedDIE(DW_AT_type);
436 
437                     bool function_type_is_new_pointer;
438                     TypeSP lldb_function_type_sp = ParseTypeFromDWARF(
439                         sc, function_type, log, &function_type_is_new_pointer);
440 
441                     if (lldb_function_type_sp) {
442                       clang_type = m_ast.CreateBlockPointerType(
443                           lldb_function_type_sp->GetForwardCompilerType());
444                       encoding_data_type = Type::eEncodingIsUID;
445                       encoding_uid.Clear();
446                       resolve_state = Type::eResolveStateFull;
447                     }
448                   }
449 
450                   break;
451                 }
452               }
453             }
454           }
455 
456           bool translation_unit_is_objc =
457               (sc.comp_unit->GetLanguage() == eLanguageTypeObjC ||
458                sc.comp_unit->GetLanguage() == eLanguageTypeObjC_plus_plus);
459 
460           if (translation_unit_is_objc) {
461             if (type_name_cstr != NULL) {
462               static ConstString g_objc_type_name_id("id");
463               static ConstString g_objc_type_name_Class("Class");
464               static ConstString g_objc_type_name_selector("SEL");
465 
466               if (type_name_const_str == g_objc_type_name_id) {
467                 if (log)
468                   dwarf->GetObjectFile()->GetModule()->LogMessage(
469                       log, "SymbolFileDWARF::ParseType (die = 0x%8.8x) %s '%s' "
470                            "is Objective-C 'id' built-in type.",
471                       die.GetOffset(), die.GetTagAsCString(), die.GetName());
472                 clang_type = m_ast.GetBasicType(eBasicTypeObjCID);
473                 encoding_data_type = Type::eEncodingIsUID;
474                 encoding_uid.Clear();
475                 resolve_state = Type::eResolveStateFull;
476 
477               } else if (type_name_const_str == g_objc_type_name_Class) {
478                 if (log)
479                   dwarf->GetObjectFile()->GetModule()->LogMessage(
480                       log, "SymbolFileDWARF::ParseType (die = 0x%8.8x) %s '%s' "
481                            "is Objective-C 'Class' built-in type.",
482                       die.GetOffset(), die.GetTagAsCString(), die.GetName());
483                 clang_type = m_ast.GetBasicType(eBasicTypeObjCClass);
484                 encoding_data_type = Type::eEncodingIsUID;
485                 encoding_uid.Clear();
486                 resolve_state = Type::eResolveStateFull;
487               } else if (type_name_const_str == g_objc_type_name_selector) {
488                 if (log)
489                   dwarf->GetObjectFile()->GetModule()->LogMessage(
490                       log, "SymbolFileDWARF::ParseType (die = 0x%8.8x) %s '%s' "
491                            "is Objective-C 'selector' built-in type.",
492                       die.GetOffset(), die.GetTagAsCString(), die.GetName());
493                 clang_type = m_ast.GetBasicType(eBasicTypeObjCSel);
494                 encoding_data_type = Type::eEncodingIsUID;
495                 encoding_uid.Clear();
496                 resolve_state = Type::eResolveStateFull;
497               }
498             } else if (encoding_data_type == Type::eEncodingIsPointerUID &&
499                        encoding_uid.IsValid()) {
500               // Clang sometimes erroneously emits id as objc_object*.  In that
501               // case we fix up the type to "id".
502 
503               const DWARFDIE encoding_die = dwarf->GetDIE(DIERef(encoding_uid));
504 
505               if (encoding_die && encoding_die.Tag() == DW_TAG_structure_type) {
506                 if (const char *struct_name = encoding_die.GetName()) {
507                   if (!strcmp(struct_name, "objc_object")) {
508                     if (log)
509                       dwarf->GetObjectFile()->GetModule()->LogMessage(
510                           log, "SymbolFileDWARF::ParseType (die = 0x%8.8x) %s "
511                                "'%s' is 'objc_object*', which we overrode to "
512                                "'id'.",
513                           die.GetOffset(), die.GetTagAsCString(),
514                           die.GetName());
515                     clang_type = m_ast.GetBasicType(eBasicTypeObjCID);
516                     encoding_data_type = Type::eEncodingIsUID;
517                     encoding_uid.Clear();
518                     resolve_state = Type::eResolveStateFull;
519                   }
520                 }
521               }
522             }
523           }
524         }
525 
526         type_sp.reset(
527             new Type(die.GetID(), dwarf, type_name_const_str, byte_size, NULL,
528                      DIERef(encoding_uid).GetUID(dwarf), encoding_data_type,
529                      &decl, clang_type, resolve_state));
530 
531         dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
532       } break;
533 
534       case DW_TAG_structure_type:
535       case DW_TAG_union_type:
536       case DW_TAG_class_type: {
537         // Set a bit that lets us know that we are currently parsing this
538         dwarf->GetDIEToType()[die.GetDIE()] = DIE_IS_BEING_PARSED;
539         bool byte_size_valid = false;
540 
541         LanguageType class_language = eLanguageTypeUnknown;
542         bool is_complete_objc_class = false;
543         size_t calling_convention
544                 = llvm::dwarf::CallingConvention::DW_CC_normal;
545 
546         const size_t num_attributes = die.GetAttributes(attributes);
547         if (num_attributes > 0) {
548           uint32_t i;
549           for (i = 0; i < num_attributes; ++i) {
550             attr = attributes.AttributeAtIndex(i);
551             if (attributes.ExtractFormValueAtIndex(i, form_value)) {
552               switch (attr) {
553               case DW_AT_decl_file:
554                 decl.SetFile(
555                    sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
556                       form_value.Unsigned()));
557                 break;
558 
559               case DW_AT_decl_line:
560                 decl.SetLine(form_value.Unsigned());
561                 break;
562 
563               case DW_AT_decl_column:
564                 decl.SetColumn(form_value.Unsigned());
565                 break;
566 
567               case DW_AT_name:
568                 type_name_cstr = form_value.AsCString();
569                 type_name_const_str.SetCString(type_name_cstr);
570                 break;
571 
572               case DW_AT_byte_size:
573                 byte_size = form_value.Unsigned();
574                 byte_size_valid = true;
575                 break;
576 
577               case DW_AT_accessibility:
578                 accessibility = DW_ACCESS_to_AccessType(form_value.Unsigned());
579                 break;
580 
581               case DW_AT_declaration:
582                 is_forward_declaration = form_value.Boolean();
583                 break;
584 
585               case DW_AT_APPLE_runtime_class:
586                 class_language = (LanguageType)form_value.Signed();
587                 break;
588 
589               case DW_AT_APPLE_objc_complete_type:
590                 is_complete_objc_class = form_value.Signed();
591                 break;
592               case DW_AT_calling_convention:
593                 calling_convention = form_value.Unsigned();
594                 break;
595 
596               case DW_AT_allocated:
597               case DW_AT_associated:
598               case DW_AT_data_location:
599               case DW_AT_description:
600               case DW_AT_start_scope:
601               case DW_AT_visibility:
602               default:
603               case DW_AT_sibling:
604                 break;
605               }
606             }
607           }
608         }
609 
610         // UniqueDWARFASTType is large, so don't create a local variables on
611         // the stack, put it on the heap. This function is often called
612         // recursively and clang isn't good and sharing the stack space for
613         // variables in different blocks.
614         std::unique_ptr<UniqueDWARFASTType> unique_ast_entry_ap(
615             new UniqueDWARFASTType());
616 
617         ConstString unique_typename(type_name_const_str);
618         Declaration unique_decl(decl);
619 
620         if (type_name_const_str) {
621           LanguageType die_language = die.GetLanguage();
622           if (Language::LanguageIsCPlusPlus(die_language)) {
623             // For C++, we rely solely upon the one definition rule that says
624             // only one thing can exist at a given decl context. We ignore the
625             // file and line that things are declared on.
626             std::string qualified_name;
627             if (die.GetQualifiedName(qualified_name))
628               unique_typename = ConstString(qualified_name);
629             unique_decl.Clear();
630           }
631 
632           if (dwarf->GetUniqueDWARFASTTypeMap().Find(
633                   unique_typename, die, unique_decl,
634                   byte_size_valid ? byte_size : -1, *unique_ast_entry_ap)) {
635             type_sp = unique_ast_entry_ap->m_type_sp;
636             if (type_sp) {
637               dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
638               return type_sp;
639             }
640           }
641         }
642 
643         DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(),
644                      DW_TAG_value_to_name(tag), type_name_cstr);
645 
646         int tag_decl_kind = -1;
647         AccessType default_accessibility = eAccessNone;
648         if (tag == DW_TAG_structure_type) {
649           tag_decl_kind = clang::TTK_Struct;
650           default_accessibility = eAccessPublic;
651         } else if (tag == DW_TAG_union_type) {
652           tag_decl_kind = clang::TTK_Union;
653           default_accessibility = eAccessPublic;
654         } else if (tag == DW_TAG_class_type) {
655           tag_decl_kind = clang::TTK_Class;
656           default_accessibility = eAccessPrivate;
657         }
658 
659         if (byte_size_valid && byte_size == 0 && type_name_cstr &&
660             die.HasChildren() == false &&
661             sc.comp_unit->GetLanguage() == eLanguageTypeObjC) {
662           // Work around an issue with clang at the moment where forward
663           // declarations for objective C classes are emitted as:
664           //  DW_TAG_structure_type [2]
665           //  DW_AT_name( "ForwardObjcClass" )
666           //  DW_AT_byte_size( 0x00 )
667           //  DW_AT_decl_file( "..." )
668           //  DW_AT_decl_line( 1 )
669           //
670           // Note that there is no DW_AT_declaration and there are no children,
671           // and the byte size is zero.
672           is_forward_declaration = true;
673         }
674 
675         if (class_language == eLanguageTypeObjC ||
676             class_language == eLanguageTypeObjC_plus_plus) {
677           if (!is_complete_objc_class &&
678               die.Supports_DW_AT_APPLE_objc_complete_type()) {
679             // We have a valid eSymbolTypeObjCClass class symbol whose name
680             // matches the current objective C class that we are trying to find
681             // and this DIE isn't the complete definition (we checked
682             // is_complete_objc_class above and know it is false), so the real
683             // definition is in here somewhere
684             type_sp = dwarf->FindCompleteObjCDefinitionTypeForDIE(
685                 die, type_name_const_str, true);
686 
687             if (!type_sp) {
688               SymbolFileDWARFDebugMap *debug_map_symfile =
689                   dwarf->GetDebugMapSymfile();
690               if (debug_map_symfile) {
691                 // We weren't able to find a full declaration in this DWARF,
692                 // see if we have a declaration anywhere else...
693                 type_sp =
694                     debug_map_symfile->FindCompleteObjCDefinitionTypeForDIE(
695                         die, type_name_const_str, true);
696               }
697             }
698 
699             if (type_sp) {
700               if (log) {
701                 dwarf->GetObjectFile()->GetModule()->LogMessage(
702                     log, "SymbolFileDWARF(%p) - 0x%8.8x: %s type \"%s\" is an "
703                          "incomplete objc type, complete type is 0x%8.8" PRIx64,
704                     static_cast<void *>(this), die.GetOffset(),
705                     DW_TAG_value_to_name(tag), type_name_cstr,
706                     type_sp->GetID());
707               }
708 
709               // We found a real definition for this type elsewhere so lets use
710               // it and cache the fact that we found a complete type for this
711               // die
712               dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
713               return type_sp;
714             }
715           }
716         }
717 
718         if (is_forward_declaration) {
719           // We have a forward declaration to a type and we need to try and
720           // find a full declaration. We look in the current type index just in
721           // case we have a forward declaration followed by an actual
722           // declarations in the DWARF. If this fails, we need to look
723           // elsewhere...
724           if (log) {
725             dwarf->GetObjectFile()->GetModule()->LogMessage(
726                 log, "SymbolFileDWARF(%p) - 0x%8.8x: %s type \"%s\" is a "
727                      "forward declaration, trying to find complete type",
728                 static_cast<void *>(this), die.GetOffset(),
729                 DW_TAG_value_to_name(tag), type_name_cstr);
730           }
731 
732           // See if the type comes from a DWO module and if so, track down that
733           // type.
734           type_sp = ParseTypeFromDWO(die, log);
735           if (type_sp)
736             return type_sp;
737 
738           DWARFDeclContext die_decl_ctx;
739           die.GetDWARFDeclContext(die_decl_ctx);
740 
741           // type_sp = FindDefinitionTypeForDIE (dwarf_cu, die,
742           // type_name_const_str);
743           type_sp = dwarf->FindDefinitionTypeForDWARFDeclContext(die_decl_ctx);
744 
745           if (!type_sp) {
746             SymbolFileDWARFDebugMap *debug_map_symfile =
747                 dwarf->GetDebugMapSymfile();
748             if (debug_map_symfile) {
749               // We weren't able to find a full declaration in this DWARF, see
750               // if we have a declaration anywhere else...
751               type_sp =
752                   debug_map_symfile->FindDefinitionTypeForDWARFDeclContext(
753                       die_decl_ctx);
754             }
755           }
756 
757           if (type_sp) {
758             if (log) {
759               dwarf->GetObjectFile()->GetModule()->LogMessage(
760                   log, "SymbolFileDWARF(%p) - 0x%8.8x: %s type \"%s\" is a "
761                        "forward declaration, complete type is 0x%8.8" PRIx64,
762                   static_cast<void *>(this), die.GetOffset(),
763                   DW_TAG_value_to_name(tag), type_name_cstr, type_sp->GetID());
764             }
765 
766             // We found a real definition for this type elsewhere so lets use
767             // it and cache the fact that we found a complete type for this die
768             dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
769             clang::DeclContext *defn_decl_ctx = GetCachedClangDeclContextForDIE(
770                 dwarf->DebugInfo()->GetDIE(DIERef(type_sp->GetID(), dwarf)));
771             if (defn_decl_ctx)
772               LinkDeclContextToDIE(defn_decl_ctx, die);
773             return type_sp;
774           }
775         }
776         assert(tag_decl_kind != -1);
777         bool clang_type_was_created = false;
778         clang_type.SetCompilerType(
779             &m_ast, dwarf->GetForwardDeclDieToClangType().lookup(die.GetDIE()));
780         if (!clang_type) {
781           clang::DeclContext *decl_ctx =
782               GetClangDeclContextContainingDIE(die, nullptr);
783 
784           // If your decl context is a record that was imported from another
785           // AST context (in the gmodules case), we need to make sure the type
786           // backing the Decl is complete before adding children to it. This is
787           // not an issue in the non-gmodules case because the debug info will
788           // always contain a full definition of parent types in that case.
789           CompleteExternalTagDeclType(GetClangASTImporter(), decl_ctx, die,
790                                       type_name_cstr);
791 
792           if (accessibility == eAccessNone && decl_ctx) {
793             // Check the decl context that contains this class/struct/union. If
794             // it is a class we must give it an accessibility.
795             const clang::Decl::Kind containing_decl_kind =
796                 decl_ctx->getDeclKind();
797             if (DeclKindIsCXXClass(containing_decl_kind))
798               accessibility = default_accessibility;
799           }
800 
801           ClangASTMetadata metadata;
802           metadata.SetUserID(die.GetID());
803           metadata.SetIsDynamicCXXType(dwarf->ClassOrStructIsVirtual(die));
804 
805           if (type_name_cstr && strchr(type_name_cstr, '<')) {
806             ClangASTContext::TemplateParameterInfos template_param_infos;
807             if (ParseTemplateParameterInfos(die, template_param_infos)) {
808               clang::ClassTemplateDecl *class_template_decl =
809                   m_ast.ParseClassTemplateDecl(decl_ctx, accessibility,
810                                                type_name_cstr, tag_decl_kind,
811                                                template_param_infos);
812               if (!class_template_decl) {
813                 if (log) {
814                   dwarf->GetObjectFile()->GetModule()->LogMessage(
815                     log, "SymbolFileDWARF(%p) - 0x%8.8x: %s type \"%s\" "
816                          "clang::ClassTemplateDecl failed to return a decl.",
817                     static_cast<void *>(this), die.GetOffset(),
818                     DW_TAG_value_to_name(tag), type_name_cstr);
819                 }
820                 return TypeSP();
821               }
822 
823               clang::ClassTemplateSpecializationDecl
824                   *class_specialization_decl =
825                       m_ast.CreateClassTemplateSpecializationDecl(
826                           decl_ctx, class_template_decl, tag_decl_kind,
827                           template_param_infos);
828               clang_type = m_ast.CreateClassTemplateSpecializationType(
829                   class_specialization_decl);
830               clang_type_was_created = true;
831 
832               m_ast.SetMetadata(class_template_decl, metadata);
833               m_ast.SetMetadata(class_specialization_decl, metadata);
834             }
835           }
836 
837           if (!clang_type_was_created) {
838             clang_type_was_created = true;
839             clang_type = m_ast.CreateRecordType(decl_ctx, accessibility,
840                                                 type_name_cstr, tag_decl_kind,
841                                                 class_language, &metadata);
842           }
843         }
844 
845         // Store a forward declaration to this class type in case any
846         // parameters in any class methods need it for the clang types for
847         // function prototypes.
848         LinkDeclContextToDIE(m_ast.GetDeclContextForType(clang_type), die);
849         type_sp.reset(new Type(die.GetID(), dwarf, type_name_const_str,
850                                byte_size, NULL, LLDB_INVALID_UID,
851                                Type::eEncodingIsUID, &decl, clang_type,
852                                Type::eResolveStateForward));
853 
854         type_sp->SetIsCompleteObjCClass(is_complete_objc_class);
855 
856         // Add our type to the unique type map so we don't end up creating many
857         // copies of the same type over and over in the ASTContext for our
858         // module
859         unique_ast_entry_ap->m_type_sp = type_sp;
860         unique_ast_entry_ap->m_die = die;
861         unique_ast_entry_ap->m_declaration = unique_decl;
862         unique_ast_entry_ap->m_byte_size = byte_size;
863         dwarf->GetUniqueDWARFASTTypeMap().Insert(unique_typename,
864                                                  *unique_ast_entry_ap);
865 
866         if (is_forward_declaration && die.HasChildren()) {
867           // Check to see if the DIE actually has a definition, some version of
868           // GCC will
869           // emit DIEs with DW_AT_declaration set to true, but yet still have
870           // subprogram, members, or inheritance, so we can't trust it
871           DWARFDIE child_die = die.GetFirstChild();
872           while (child_die) {
873             switch (child_die.Tag()) {
874             case DW_TAG_inheritance:
875             case DW_TAG_subprogram:
876             case DW_TAG_member:
877             case DW_TAG_APPLE_property:
878             case DW_TAG_class_type:
879             case DW_TAG_structure_type:
880             case DW_TAG_enumeration_type:
881             case DW_TAG_typedef:
882             case DW_TAG_union_type:
883               child_die.Clear();
884               is_forward_declaration = false;
885               break;
886             default:
887               child_die = child_die.GetSibling();
888               break;
889             }
890           }
891         }
892 
893         if (!is_forward_declaration) {
894           // Always start the definition for a class type so that if the class
895           // has child classes or types that require the class to be created
896           // for use as their decl contexts the class will be ready to accept
897           // these child definitions.
898           if (die.HasChildren() == false) {
899             // No children for this struct/union/class, lets finish it
900             if (ClangASTContext::StartTagDeclarationDefinition(clang_type)) {
901               ClangASTContext::CompleteTagDeclarationDefinition(clang_type);
902             } else {
903               dwarf->GetObjectFile()->GetModule()->ReportError(
904                   "DWARF DIE at 0x%8.8x named \"%s\" was not able to start its "
905                   "definition.\nPlease file a bug and attach the file at the "
906                   "start of this error message",
907                   die.GetOffset(), type_name_cstr);
908             }
909 
910             if (tag == DW_TAG_structure_type) // this only applies in C
911             {
912               clang::RecordDecl *record_decl =
913                   ClangASTContext::GetAsRecordDecl(clang_type);
914 
915               if (record_decl) {
916                 GetClangASTImporter().InsertRecordDecl(
917                     record_decl, ClangASTImporter::LayoutInfo());
918               }
919             }
920           } else if (clang_type_was_created) {
921             // Start the definition if the class is not objective C since the
922             // underlying decls respond to isCompleteDefinition(). Objective
923             // C decls don't respond to isCompleteDefinition() so we can't
924             // start the declaration definition right away. For C++
925             // class/union/structs we want to start the definition in case the
926             // class is needed as the declaration context for a contained class
927             // or type without the need to complete that type..
928 
929             if (class_language != eLanguageTypeObjC &&
930                 class_language != eLanguageTypeObjC_plus_plus)
931               ClangASTContext::StartTagDeclarationDefinition(clang_type);
932 
933             // Leave this as a forward declaration until we need to know the
934             // details of the type. lldb_private::Type will automatically call
935             // the SymbolFile virtual function
936             // "SymbolFileDWARF::CompleteType(Type *)" When the definition
937             // needs to be defined.
938             assert(!dwarf->GetForwardDeclClangTypeToDie().count(
939                        ClangUtil::RemoveFastQualifiers(clang_type)
940                            .GetOpaqueQualType()) &&
941                    "Type already in the forward declaration map!");
942             // Can't assume m_ast.GetSymbolFile() is actually a
943             // SymbolFileDWARF, it can be a SymbolFileDWARFDebugMap for Apple
944             // binaries.
945             dwarf->GetForwardDeclDieToClangType()[die.GetDIE()] =
946                 clang_type.GetOpaqueQualType();
947             dwarf->GetForwardDeclClangTypeToDie()
948                 [ClangUtil::RemoveFastQualifiers(clang_type)
949                      .GetOpaqueQualType()] = die.GetDIERef();
950             m_ast.SetHasExternalStorage(clang_type.GetOpaqueQualType(), true);
951           }
952         }
953 
954         // If we made a clang type, set the trivial abi if applicable: We only
955         // do this for pass by value - which implies the Trivial ABI. There
956         // isn't a way to assert that something that would normally be pass by
957         // value is pass by reference, so we ignore that attribute if set.
958         if (calling_convention == llvm::dwarf::DW_CC_pass_by_value) {
959           clang::CXXRecordDecl *record_decl =
960                   m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType());
961           if (record_decl) {
962             record_decl->setHasTrivialSpecialMemberForCall();
963           }
964         }
965 
966       } break;
967 
968       case DW_TAG_enumeration_type: {
969         // Set a bit that lets us know that we are currently parsing this
970         dwarf->GetDIEToType()[die.GetDIE()] = DIE_IS_BEING_PARSED;
971 
972         bool is_scoped = false;
973         DWARFFormValue encoding_form;
974 
975         const size_t num_attributes = die.GetAttributes(attributes);
976         if (num_attributes > 0) {
977           uint32_t i;
978 
979           for (i = 0; i < num_attributes; ++i) {
980             attr = attributes.AttributeAtIndex(i);
981             if (attributes.ExtractFormValueAtIndex(i, form_value)) {
982               switch (attr) {
983               case DW_AT_decl_file:
984                 decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
985                     form_value.Unsigned()));
986                 break;
987               case DW_AT_decl_line:
988                 decl.SetLine(form_value.Unsigned());
989                 break;
990               case DW_AT_decl_column:
991                 decl.SetColumn(form_value.Unsigned());
992                 break;
993               case DW_AT_name:
994                 type_name_cstr = form_value.AsCString();
995                 type_name_const_str.SetCString(type_name_cstr);
996                 break;
997               case DW_AT_type:
998                 encoding_form = form_value;
999                 break;
1000               case DW_AT_byte_size:
1001                 byte_size = form_value.Unsigned();
1002                 break;
1003               case DW_AT_accessibility:
1004                 break; // accessibility =
1005                        // DW_ACCESS_to_AccessType(form_value.Unsigned()); break;
1006               case DW_AT_declaration:
1007                 is_forward_declaration = form_value.Boolean();
1008                 break;
1009               case DW_AT_enum_class:
1010                 is_scoped = form_value.Boolean();
1011                 break;
1012               case DW_AT_allocated:
1013               case DW_AT_associated:
1014               case DW_AT_bit_stride:
1015               case DW_AT_byte_stride:
1016               case DW_AT_data_location:
1017               case DW_AT_description:
1018               case DW_AT_start_scope:
1019               case DW_AT_visibility:
1020               case DW_AT_specification:
1021               case DW_AT_abstract_origin:
1022               case DW_AT_sibling:
1023                 break;
1024               }
1025             }
1026           }
1027 
1028           if (is_forward_declaration) {
1029             type_sp = ParseTypeFromDWO(die, log);
1030             if (type_sp)
1031               return type_sp;
1032 
1033             DWARFDeclContext die_decl_ctx;
1034             die.GetDWARFDeclContext(die_decl_ctx);
1035 
1036             type_sp =
1037                 dwarf->FindDefinitionTypeForDWARFDeclContext(die_decl_ctx);
1038 
1039             if (!type_sp) {
1040               SymbolFileDWARFDebugMap *debug_map_symfile =
1041                   dwarf->GetDebugMapSymfile();
1042               if (debug_map_symfile) {
1043                 // We weren't able to find a full declaration in this DWARF,
1044                 // see if we have a declaration anywhere else...
1045                 type_sp =
1046                     debug_map_symfile->FindDefinitionTypeForDWARFDeclContext(
1047                         die_decl_ctx);
1048               }
1049             }
1050 
1051             if (type_sp) {
1052               if (log) {
1053                 dwarf->GetObjectFile()->GetModule()->LogMessage(
1054                     log, "SymbolFileDWARF(%p) - 0x%8.8x: %s type \"%s\" is a "
1055                          "forward declaration, complete type is 0x%8.8" PRIx64,
1056                     static_cast<void *>(this), die.GetOffset(),
1057                     DW_TAG_value_to_name(tag), type_name_cstr,
1058                     type_sp->GetID());
1059               }
1060 
1061               // We found a real definition for this type elsewhere so lets use
1062               // it and cache the fact that we found a complete type for this
1063               // die
1064               dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
1065               clang::DeclContext *defn_decl_ctx =
1066                   GetCachedClangDeclContextForDIE(dwarf->DebugInfo()->GetDIE(
1067                       DIERef(type_sp->GetID(), dwarf)));
1068               if (defn_decl_ctx)
1069                 LinkDeclContextToDIE(defn_decl_ctx, die);
1070               return type_sp;
1071             }
1072           }
1073           DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(),
1074                        DW_TAG_value_to_name(tag), type_name_cstr);
1075 
1076           CompilerType enumerator_clang_type;
1077           clang_type.SetCompilerType(
1078               &m_ast,
1079               dwarf->GetForwardDeclDieToClangType().lookup(die.GetDIE()));
1080           if (!clang_type) {
1081             if (encoding_form.IsValid()) {
1082               Type *enumerator_type =
1083                   dwarf->ResolveTypeUID(DIERef(encoding_form));
1084               if (enumerator_type)
1085                 enumerator_clang_type = enumerator_type->GetFullCompilerType();
1086             }
1087 
1088             if (!enumerator_clang_type) {
1089               if (byte_size > 0) {
1090                 enumerator_clang_type =
1091                     m_ast.GetBuiltinTypeForDWARFEncodingAndBitSize(
1092                         NULL, DW_ATE_signed, byte_size * 8);
1093               } else {
1094                 enumerator_clang_type = m_ast.GetBasicType(eBasicTypeInt);
1095               }
1096             }
1097 
1098             clang_type = m_ast.CreateEnumerationType(
1099                 type_name_cstr, GetClangDeclContextContainingDIE(die, nullptr),
1100                 decl, enumerator_clang_type, is_scoped);
1101           } else {
1102             enumerator_clang_type =
1103                 m_ast.GetEnumerationIntegerType(clang_type.GetOpaqueQualType());
1104           }
1105 
1106           LinkDeclContextToDIE(
1107               ClangASTContext::GetDeclContextForType(clang_type), die);
1108 
1109           type_sp.reset(new Type(
1110               die.GetID(), dwarf, type_name_const_str, byte_size, NULL,
1111               DIERef(encoding_form).GetUID(dwarf), Type::eEncodingIsUID, &decl,
1112               clang_type, Type::eResolveStateForward));
1113 
1114           if (ClangASTContext::StartTagDeclarationDefinition(clang_type)) {
1115             if (die.HasChildren()) {
1116               SymbolContext cu_sc(die.GetLLDBCompileUnit());
1117               bool is_signed = false;
1118               enumerator_clang_type.IsIntegerType(is_signed);
1119               ParseChildEnumerators(cu_sc, clang_type, is_signed,
1120                                     type_sp->GetByteSize(), die);
1121             }
1122             ClangASTContext::CompleteTagDeclarationDefinition(clang_type);
1123           } else {
1124             dwarf->GetObjectFile()->GetModule()->ReportError(
1125                 "DWARF DIE at 0x%8.8x named \"%s\" was not able to start its "
1126                 "definition.\nPlease file a bug and attach the file at the "
1127                 "start of this error message",
1128                 die.GetOffset(), type_name_cstr);
1129           }
1130         }
1131       } break;
1132 
1133       case DW_TAG_inlined_subroutine:
1134       case DW_TAG_subprogram:
1135       case DW_TAG_subroutine_type: {
1136         // Set a bit that lets us know that we are currently parsing this
1137         dwarf->GetDIEToType()[die.GetDIE()] = DIE_IS_BEING_PARSED;
1138 
1139         DWARFFormValue type_die_form;
1140         bool is_variadic = false;
1141         bool is_inline = false;
1142         bool is_static = false;
1143         bool is_virtual = false;
1144         bool is_explicit = false;
1145         bool is_artificial = false;
1146         bool has_template_params = false;
1147         DWARFFormValue specification_die_form;
1148         DWARFFormValue abstract_origin_die_form;
1149         dw_offset_t object_pointer_die_offset = DW_INVALID_OFFSET;
1150 
1151         unsigned type_quals = 0;
1152         clang::StorageClass storage =
1153             clang::SC_None; //, Extern, Static, PrivateExtern
1154 
1155         const size_t num_attributes = die.GetAttributes(attributes);
1156         if (num_attributes > 0) {
1157           uint32_t i;
1158           for (i = 0; i < num_attributes; ++i) {
1159             attr = attributes.AttributeAtIndex(i);
1160             if (attributes.ExtractFormValueAtIndex(i, form_value)) {
1161               switch (attr) {
1162               case DW_AT_decl_file:
1163                 decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
1164                     form_value.Unsigned()));
1165                 break;
1166               case DW_AT_decl_line:
1167                 decl.SetLine(form_value.Unsigned());
1168                 break;
1169               case DW_AT_decl_column:
1170                 decl.SetColumn(form_value.Unsigned());
1171                 break;
1172               case DW_AT_name:
1173                 type_name_cstr = form_value.AsCString();
1174                 type_name_const_str.SetCString(type_name_cstr);
1175                 break;
1176 
1177               case DW_AT_linkage_name:
1178               case DW_AT_MIPS_linkage_name:
1179                 mangled_name_cstr = form_value.AsCString();
1180                 break;
1181               case DW_AT_type:
1182                 type_die_form = form_value;
1183                 break;
1184               case DW_AT_accessibility:
1185                 accessibility = DW_ACCESS_to_AccessType(form_value.Unsigned());
1186                 break;
1187               case DW_AT_declaration:
1188                 break; // is_forward_declaration = form_value.Boolean(); break;
1189               case DW_AT_inline:
1190                 is_inline = form_value.Boolean();
1191                 break;
1192               case DW_AT_virtuality:
1193                 is_virtual = form_value.Boolean();
1194                 break;
1195               case DW_AT_explicit:
1196                 is_explicit = form_value.Boolean();
1197                 break;
1198               case DW_AT_artificial:
1199                 is_artificial = form_value.Boolean();
1200                 break;
1201 
1202               case DW_AT_external:
1203                 if (form_value.Unsigned()) {
1204                   if (storage == clang::SC_None)
1205                     storage = clang::SC_Extern;
1206                   else
1207                     storage = clang::SC_PrivateExtern;
1208                 }
1209                 break;
1210 
1211               case DW_AT_specification:
1212                 specification_die_form = form_value;
1213                 break;
1214 
1215               case DW_AT_abstract_origin:
1216                 abstract_origin_die_form = form_value;
1217                 break;
1218 
1219               case DW_AT_object_pointer:
1220                 object_pointer_die_offset = form_value.Reference();
1221                 break;
1222 
1223               case DW_AT_allocated:
1224               case DW_AT_associated:
1225               case DW_AT_address_class:
1226               case DW_AT_calling_convention:
1227               case DW_AT_data_location:
1228               case DW_AT_elemental:
1229               case DW_AT_entry_pc:
1230               case DW_AT_frame_base:
1231               case DW_AT_high_pc:
1232               case DW_AT_low_pc:
1233               case DW_AT_prototyped:
1234               case DW_AT_pure:
1235               case DW_AT_ranges:
1236               case DW_AT_recursive:
1237               case DW_AT_return_addr:
1238               case DW_AT_segment:
1239               case DW_AT_start_scope:
1240               case DW_AT_static_link:
1241               case DW_AT_trampoline:
1242               case DW_AT_visibility:
1243               case DW_AT_vtable_elem_location:
1244               case DW_AT_description:
1245               case DW_AT_sibling:
1246                 break;
1247               }
1248             }
1249           }
1250         }
1251 
1252         std::string object_pointer_name;
1253         if (object_pointer_die_offset != DW_INVALID_OFFSET) {
1254           DWARFDIE object_pointer_die = die.GetDIE(object_pointer_die_offset);
1255           if (object_pointer_die) {
1256             const char *object_pointer_name_cstr = object_pointer_die.GetName();
1257             if (object_pointer_name_cstr)
1258               object_pointer_name = object_pointer_name_cstr;
1259           }
1260         }
1261 
1262         DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(),
1263                      DW_TAG_value_to_name(tag), type_name_cstr);
1264 
1265         CompilerType return_clang_type;
1266         Type *func_type = NULL;
1267 
1268         if (type_die_form.IsValid())
1269           func_type = dwarf->ResolveTypeUID(DIERef(type_die_form));
1270 
1271         if (func_type)
1272           return_clang_type = func_type->GetForwardCompilerType();
1273         else
1274           return_clang_type = m_ast.GetBasicType(eBasicTypeVoid);
1275 
1276         std::vector<CompilerType> function_param_types;
1277         std::vector<clang::ParmVarDecl *> function_param_decls;
1278 
1279         // Parse the function children for the parameters
1280 
1281         DWARFDIE decl_ctx_die;
1282         clang::DeclContext *containing_decl_ctx =
1283             GetClangDeclContextContainingDIE(die, &decl_ctx_die);
1284         const clang::Decl::Kind containing_decl_kind =
1285             containing_decl_ctx->getDeclKind();
1286 
1287         bool is_cxx_method = DeclKindIsCXXClass(containing_decl_kind);
1288         // Start off static. This will be set to false in
1289         // ParseChildParameters(...) if we find a "this" parameters as the
1290         // first parameter
1291         if (is_cxx_method) {
1292           is_static = true;
1293         }
1294 
1295         if (die.HasChildren()) {
1296           bool skip_artificial = true;
1297           ParseChildParameters(sc, containing_decl_ctx, die, skip_artificial,
1298                                is_static, is_variadic, has_template_params,
1299                                function_param_types, function_param_decls,
1300                                type_quals);
1301         }
1302 
1303         bool ignore_containing_context = false;
1304         // Check for templatized class member functions. If we had any
1305         // DW_TAG_template_type_parameter or DW_TAG_template_value_parameter
1306         // the DW_TAG_subprogram DIE, then we can't let this become a method in
1307         // a class. Why? Because templatized functions are only emitted if one
1308         // of the templatized methods is used in the current compile unit and
1309         // we will end up with classes that may or may not include these member
1310         // functions and this means one class won't match another class
1311         // definition and it affects our ability to use a class in the clang
1312         // expression parser. So for the greater good, we currently must not
1313         // allow any template member functions in a class definition.
1314         if (is_cxx_method && has_template_params) {
1315           ignore_containing_context = true;
1316           is_cxx_method = false;
1317         }
1318 
1319         // clang_type will get the function prototype clang type after this
1320         // call
1321         clang_type = m_ast.CreateFunctionType(
1322             return_clang_type, function_param_types.data(),
1323             function_param_types.size(), is_variadic, type_quals);
1324 
1325         if (type_name_cstr) {
1326           bool type_handled = false;
1327           if (tag == DW_TAG_subprogram || tag == DW_TAG_inlined_subroutine) {
1328             ObjCLanguage::MethodName objc_method(type_name_cstr, true);
1329             if (objc_method.IsValid(true)) {
1330               CompilerType class_opaque_type;
1331               ConstString class_name(objc_method.GetClassName());
1332               if (class_name) {
1333                 TypeSP complete_objc_class_type_sp(
1334                     dwarf->FindCompleteObjCDefinitionTypeForDIE(
1335                         DWARFDIE(), class_name, false));
1336 
1337                 if (complete_objc_class_type_sp) {
1338                   CompilerType type_clang_forward_type =
1339                       complete_objc_class_type_sp->GetForwardCompilerType();
1340                   if (ClangASTContext::IsObjCObjectOrInterfaceType(
1341                           type_clang_forward_type))
1342                     class_opaque_type = type_clang_forward_type;
1343                 }
1344               }
1345 
1346               if (class_opaque_type) {
1347                 // If accessibility isn't set to anything valid, assume public
1348                 // for now...
1349                 if (accessibility == eAccessNone)
1350                   accessibility = eAccessPublic;
1351 
1352                 clang::ObjCMethodDecl *objc_method_decl =
1353                     m_ast.AddMethodToObjCObjectType(
1354                         class_opaque_type, type_name_cstr, clang_type,
1355                         accessibility, is_artificial, is_variadic);
1356                 type_handled = objc_method_decl != NULL;
1357                 if (type_handled) {
1358                   LinkDeclContextToDIE(
1359                       ClangASTContext::GetAsDeclContext(objc_method_decl), die);
1360                   m_ast.SetMetadataAsUserID(objc_method_decl, die.GetID());
1361                 } else {
1362                   dwarf->GetObjectFile()->GetModule()->ReportError(
1363                       "{0x%8.8x}: invalid Objective-C method 0x%4.4x (%s), "
1364                       "please file a bug and attach the file at the start of "
1365                       "this error message",
1366                       die.GetOffset(), tag, DW_TAG_value_to_name(tag));
1367                 }
1368               }
1369             } else if (is_cxx_method) {
1370               // Look at the parent of this DIE and see if is is a class or
1371               // struct and see if this is actually a C++ method
1372               Type *class_type = dwarf->ResolveType(decl_ctx_die);
1373               if (class_type) {
1374                 bool alternate_defn = false;
1375                 if (class_type->GetID() != decl_ctx_die.GetID() ||
1376                     decl_ctx_die.GetContainingDWOModuleDIE()) {
1377                   alternate_defn = true;
1378 
1379                   // We uniqued the parent class of this function to another
1380                   // class so we now need to associate all dies under
1381                   // "decl_ctx_die" to DIEs in the DIE for "class_type"...
1382                   SymbolFileDWARF *class_symfile = NULL;
1383                   DWARFDIE class_type_die;
1384 
1385                   SymbolFileDWARFDebugMap *debug_map_symfile =
1386                       dwarf->GetDebugMapSymfile();
1387                   if (debug_map_symfile) {
1388                     class_symfile = debug_map_symfile->GetSymbolFileByOSOIndex(
1389                         SymbolFileDWARFDebugMap::GetOSOIndexFromUserID(
1390                             class_type->GetID()));
1391                     class_type_die = class_symfile->DebugInfo()->GetDIE(
1392                         DIERef(class_type->GetID(), dwarf));
1393                   } else {
1394                     class_symfile = dwarf;
1395                     class_type_die = dwarf->DebugInfo()->GetDIE(
1396                         DIERef(class_type->GetID(), dwarf));
1397                   }
1398                   if (class_type_die) {
1399                     DWARFDIECollection failures;
1400 
1401                     CopyUniqueClassMethodTypes(decl_ctx_die, class_type_die,
1402                                                class_type, failures);
1403 
1404                     // FIXME do something with these failures that's smarter
1405                     // than
1406                     // just dropping them on the ground.  Unfortunately classes
1407                     // don't like having stuff added to them after their
1408                     // definitions are complete...
1409 
1410                     type_ptr = dwarf->GetDIEToType()[die.GetDIE()];
1411                     if (type_ptr && type_ptr != DIE_IS_BEING_PARSED) {
1412                       type_sp = type_ptr->shared_from_this();
1413                       break;
1414                     }
1415                   }
1416                 }
1417 
1418                 if (specification_die_form.IsValid()) {
1419                   // We have a specification which we are going to base our
1420                   // function prototype off of, so we need this type to be
1421                   // completed so that the m_die_to_decl_ctx for the method in
1422                   // the specification has a valid clang decl context.
1423                   class_type->GetForwardCompilerType();
1424                   // If we have a specification, then the function type should
1425                   // have been made with the specification and not with this
1426                   // die.
1427                   DWARFDIE spec_die = dwarf->DebugInfo()->GetDIE(
1428                       DIERef(specification_die_form));
1429                   clang::DeclContext *spec_clang_decl_ctx =
1430                       GetClangDeclContextForDIE(spec_die);
1431                   if (spec_clang_decl_ctx) {
1432                     LinkDeclContextToDIE(spec_clang_decl_ctx, die);
1433                   } else {
1434                     dwarf->GetObjectFile()->GetModule()->ReportWarning(
1435                         "0x%8.8" PRIx64 ": DW_AT_specification(0x%8.8" PRIx64
1436                         ") has no decl\n",
1437                         die.GetID(), specification_die_form.Reference());
1438                   }
1439                   type_handled = true;
1440                 } else if (abstract_origin_die_form.IsValid()) {
1441                   // We have a specification which we are going to base our
1442                   // function prototype off of, so we need this type to be
1443                   // completed so that the m_die_to_decl_ctx for the method in
1444                   // the abstract origin has a valid clang decl context.
1445                   class_type->GetForwardCompilerType();
1446 
1447                   DWARFDIE abs_die = dwarf->DebugInfo()->GetDIE(
1448                       DIERef(abstract_origin_die_form));
1449                   clang::DeclContext *abs_clang_decl_ctx =
1450                       GetClangDeclContextForDIE(abs_die);
1451                   if (abs_clang_decl_ctx) {
1452                     LinkDeclContextToDIE(abs_clang_decl_ctx, die);
1453                   } else {
1454                     dwarf->GetObjectFile()->GetModule()->ReportWarning(
1455                         "0x%8.8" PRIx64 ": DW_AT_abstract_origin(0x%8.8" PRIx64
1456                         ") has no decl\n",
1457                         die.GetID(), abstract_origin_die_form.Reference());
1458                   }
1459                   type_handled = true;
1460                 } else {
1461                   CompilerType class_opaque_type =
1462                       class_type->GetForwardCompilerType();
1463                   if (ClangASTContext::IsCXXClassType(class_opaque_type)) {
1464                     if (class_opaque_type.IsBeingDefined() || alternate_defn) {
1465                       if (!is_static && !die.HasChildren()) {
1466                         // We have a C++ member function with no children (this
1467                         // pointer!) and clang will get mad if we try and make
1468                         // a function that isn't well formed in the DWARF, so
1469                         // we will just skip it...
1470                         type_handled = true;
1471                       } else {
1472                         bool add_method = true;
1473                         if (alternate_defn) {
1474                           // If an alternate definition for the class exists,
1475                           // then add the method only if an equivalent is not
1476                           // already present.
1477                           clang::CXXRecordDecl *record_decl =
1478                               m_ast.GetAsCXXRecordDecl(
1479                                   class_opaque_type.GetOpaqueQualType());
1480                           if (record_decl) {
1481                             for (auto method_iter = record_decl->method_begin();
1482                                  method_iter != record_decl->method_end();
1483                                  method_iter++) {
1484                               clang::CXXMethodDecl *method_decl = *method_iter;
1485                               if (method_decl->getNameInfo().getAsString() ==
1486                                   std::string(type_name_cstr)) {
1487                                 if (method_decl->getType() ==
1488                                     ClangUtil::GetQualType(clang_type)) {
1489                                   add_method = false;
1490                                   LinkDeclContextToDIE(
1491                                       ClangASTContext::GetAsDeclContext(
1492                                           method_decl),
1493                                       die);
1494                                   type_handled = true;
1495 
1496                                   break;
1497                                 }
1498                               }
1499                             }
1500                           }
1501                         }
1502 
1503                         if (add_method) {
1504                           llvm::PrettyStackTraceFormat stack_trace(
1505                               "SymbolFileDWARF::ParseType() is adding a method "
1506                               "%s to class %s in DIE 0x%8.8" PRIx64 " from %s",
1507                               type_name_cstr,
1508                               class_type->GetName().GetCString(), die.GetID(),
1509                               dwarf->GetObjectFile()
1510                                   ->GetFileSpec()
1511                                   .GetPath()
1512                                   .c_str());
1513 
1514                           const bool is_attr_used = false;
1515                           // Neither GCC 4.2 nor clang++ currently set a valid
1516                           // accessibility in the DWARF for C++ methods...
1517                           // Default to public for now...
1518                           if (accessibility == eAccessNone)
1519                             accessibility = eAccessPublic;
1520 
1521                           clang::CXXMethodDecl *cxx_method_decl =
1522                               m_ast.AddMethodToCXXRecordType(
1523                                   class_opaque_type.GetOpaqueQualType(),
1524                                   type_name_cstr, mangled_name_cstr, clang_type,
1525                                   accessibility, is_virtual, is_static,
1526                                   is_inline, is_explicit, is_attr_used,
1527                                   is_artificial);
1528 
1529                           type_handled = cxx_method_decl != NULL;
1530 
1531                           if (type_handled) {
1532                             LinkDeclContextToDIE(
1533                                 ClangASTContext::GetAsDeclContext(
1534                                     cxx_method_decl),
1535                                 die);
1536 
1537                             ClangASTMetadata metadata;
1538                             metadata.SetUserID(die.GetID());
1539 
1540                             if (!object_pointer_name.empty()) {
1541                               metadata.SetObjectPtrName(
1542                                   object_pointer_name.c_str());
1543                               if (log)
1544                                 log->Printf(
1545                                     "Setting object pointer name: %s on method "
1546                                     "object %p.\n",
1547                                     object_pointer_name.c_str(),
1548                                     static_cast<void *>(cxx_method_decl));
1549                             }
1550                             m_ast.SetMetadata(cxx_method_decl, metadata);
1551                           } else {
1552                             ignore_containing_context = true;
1553                           }
1554                         }
1555                       }
1556                     } else {
1557                       // We were asked to parse the type for a method in a
1558                       // class, yet the class hasn't been asked to complete
1559                       // itself through the clang::ExternalASTSource protocol,
1560                       // so we need to just have the class complete itself and
1561                       // do things the right way, then our
1562                       // DIE should then have an entry in the
1563                       // dwarf->GetDIEToType() map. First
1564                       // we need to modify the dwarf->GetDIEToType() so it
1565                       // doesn't think we are trying to parse this DIE
1566                       // anymore...
1567                       dwarf->GetDIEToType()[die.GetDIE()] = NULL;
1568 
1569                       // Now we get the full type to force our class type to
1570                       // complete itself using the clang::ExternalASTSource
1571                       // protocol which will parse all base classes and all
1572                       // methods (including the method for this DIE).
1573                       class_type->GetFullCompilerType();
1574 
1575                       // The type for this DIE should have been filled in the
1576                       // function call above
1577                       type_ptr = dwarf->GetDIEToType()[die.GetDIE()];
1578                       if (type_ptr && type_ptr != DIE_IS_BEING_PARSED) {
1579                         type_sp = type_ptr->shared_from_this();
1580                         break;
1581                       }
1582 
1583                       // FIXME This is fixing some even uglier behavior but we
1584                       // really need to
1585                       // uniq the methods of each class as well as the class
1586                       // itself. <rdar://problem/11240464>
1587                       type_handled = true;
1588                     }
1589                   }
1590                 }
1591               }
1592             }
1593           }
1594 
1595           if (!type_handled) {
1596             clang::FunctionDecl *function_decl = nullptr;
1597 
1598             if (abstract_origin_die_form.IsValid()) {
1599               DWARFDIE abs_die =
1600                   dwarf->DebugInfo()->GetDIE(DIERef(abstract_origin_die_form));
1601 
1602               SymbolContext sc;
1603 
1604               if (dwarf->ResolveType(abs_die)) {
1605                 function_decl = llvm::dyn_cast_or_null<clang::FunctionDecl>(
1606                     GetCachedClangDeclContextForDIE(abs_die));
1607 
1608                 if (function_decl) {
1609                   LinkDeclContextToDIE(function_decl, die);
1610                 }
1611               }
1612             }
1613 
1614             if (!function_decl) {
1615               // We just have a function that isn't part of a class
1616               function_decl = m_ast.CreateFunctionDeclaration(
1617                   ignore_containing_context ? m_ast.GetTranslationUnitDecl()
1618                                             : containing_decl_ctx,
1619                   type_name_cstr, clang_type, storage, is_inline);
1620 
1621               if (has_template_params) {
1622                 ClangASTContext::TemplateParameterInfos template_param_infos;
1623                 ParseTemplateParameterInfos(die, template_param_infos);
1624                 clang::FunctionTemplateDecl *func_template_decl =
1625                     m_ast.CreateFunctionTemplateDecl(
1626                         containing_decl_ctx, function_decl, type_name_cstr,
1627                         template_param_infos);
1628                 m_ast.CreateFunctionTemplateSpecializationInfo(
1629                     function_decl, func_template_decl, template_param_infos);
1630               }
1631 
1632               lldbassert(function_decl);
1633 
1634               if (function_decl) {
1635                 LinkDeclContextToDIE(function_decl, die);
1636 
1637                 if (!function_param_decls.empty())
1638                   m_ast.SetFunctionParameters(function_decl,
1639                                               &function_param_decls.front(),
1640                                               function_param_decls.size());
1641 
1642                 ClangASTMetadata metadata;
1643                 metadata.SetUserID(die.GetID());
1644 
1645                 if (!object_pointer_name.empty()) {
1646                   metadata.SetObjectPtrName(object_pointer_name.c_str());
1647                   if (log)
1648                     log->Printf("Setting object pointer name: %s on function "
1649                                 "object %p.",
1650                                 object_pointer_name.c_str(),
1651                                 static_cast<void *>(function_decl));
1652                 }
1653                 m_ast.SetMetadata(function_decl, metadata);
1654               }
1655             }
1656           }
1657         }
1658         type_sp.reset(new Type(die.GetID(), dwarf, type_name_const_str, 0, NULL,
1659                                LLDB_INVALID_UID, Type::eEncodingIsUID, &decl,
1660                                clang_type, Type::eResolveStateFull));
1661         assert(type_sp.get());
1662       } break;
1663 
1664       case DW_TAG_array_type: {
1665         // Set a bit that lets us know that we are currently parsing this
1666         dwarf->GetDIEToType()[die.GetDIE()] = DIE_IS_BEING_PARSED;
1667 
1668         DWARFFormValue type_die_form;
1669         int64_t first_index = 0;
1670         uint32_t byte_stride = 0;
1671         uint32_t bit_stride = 0;
1672         bool is_vector = false;
1673         const size_t num_attributes = die.GetAttributes(attributes);
1674 
1675         if (num_attributes > 0) {
1676           uint32_t i;
1677           for (i = 0; i < num_attributes; ++i) {
1678             attr = attributes.AttributeAtIndex(i);
1679             if (attributes.ExtractFormValueAtIndex(i, form_value)) {
1680               switch (attr) {
1681               case DW_AT_decl_file:
1682                 decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
1683                     form_value.Unsigned()));
1684                 break;
1685               case DW_AT_decl_line:
1686                 decl.SetLine(form_value.Unsigned());
1687                 break;
1688               case DW_AT_decl_column:
1689                 decl.SetColumn(form_value.Unsigned());
1690                 break;
1691               case DW_AT_name:
1692                 type_name_cstr = form_value.AsCString();
1693                 type_name_const_str.SetCString(type_name_cstr);
1694                 break;
1695 
1696               case DW_AT_type:
1697                 type_die_form = form_value;
1698                 break;
1699               case DW_AT_byte_size:
1700                 break; // byte_size = form_value.Unsigned(); break;
1701               case DW_AT_byte_stride:
1702                 byte_stride = form_value.Unsigned();
1703                 break;
1704               case DW_AT_bit_stride:
1705                 bit_stride = form_value.Unsigned();
1706                 break;
1707               case DW_AT_GNU_vector:
1708                 is_vector = form_value.Boolean();
1709                 break;
1710               case DW_AT_accessibility:
1711                 break; // accessibility =
1712                        // DW_ACCESS_to_AccessType(form_value.Unsigned()); break;
1713               case DW_AT_declaration:
1714                 break; // is_forward_declaration = form_value.Boolean(); break;
1715               case DW_AT_allocated:
1716               case DW_AT_associated:
1717               case DW_AT_data_location:
1718               case DW_AT_description:
1719               case DW_AT_ordering:
1720               case DW_AT_start_scope:
1721               case DW_AT_visibility:
1722               case DW_AT_specification:
1723               case DW_AT_abstract_origin:
1724               case DW_AT_sibling:
1725                 break;
1726               }
1727             }
1728           }
1729 
1730           DEBUG_PRINTF("0x%8.8" PRIx64 ": %s (\"%s\")\n", die.GetID(),
1731                        DW_TAG_value_to_name(tag), type_name_cstr);
1732 
1733           DIERef type_die_ref(type_die_form);
1734           Type *element_type = dwarf->ResolveTypeUID(type_die_ref);
1735 
1736           if (element_type) {
1737             auto array_info = ParseChildArrayInfo(die);
1738             if (array_info) {
1739               first_index = array_info->first_index;
1740               byte_stride = array_info->byte_stride;
1741               bit_stride = array_info->bit_stride;
1742             }
1743             if (byte_stride == 0 && bit_stride == 0)
1744               byte_stride = element_type->GetByteSize();
1745             CompilerType array_element_type =
1746                 element_type->GetForwardCompilerType();
1747 
1748             if (ClangASTContext::IsCXXClassType(array_element_type) &&
1749                 array_element_type.GetCompleteType() == false) {
1750               ModuleSP module_sp = die.GetModule();
1751               if (module_sp) {
1752                 if (die.GetCU()->GetProducer() == eProducerClang)
1753                   module_sp->ReportError(
1754                       "DWARF DW_TAG_array_type DIE at 0x%8.8x has a "
1755                       "class/union/struct element type DIE 0x%8.8x that is a "
1756                       "forward declaration, not a complete definition.\nTry "
1757                       "compiling the source file with -fstandalone-debug or "
1758                       "disable -gmodules",
1759                       die.GetOffset(), type_die_ref.die_offset);
1760                 else
1761                   module_sp->ReportError(
1762                       "DWARF DW_TAG_array_type DIE at 0x%8.8x has a "
1763                       "class/union/struct element type DIE 0x%8.8x that is a "
1764                       "forward declaration, not a complete definition.\nPlease "
1765                       "file a bug against the compiler and include the "
1766                       "preprocessed output for %s",
1767                       die.GetOffset(), type_die_ref.die_offset,
1768                       die.GetLLDBCompileUnit()
1769                           ? die.GetLLDBCompileUnit()->GetPath().c_str()
1770                           : "the source file");
1771               }
1772 
1773               // We have no choice other than to pretend that the element class
1774               // type is complete. If we don't do this, clang will crash when
1775               // trying to layout the class. Since we provide layout
1776               // assistance, all ivars in this class and other classes will be
1777               // fine, this is the best we can do short of crashing.
1778               if (ClangASTContext::StartTagDeclarationDefinition(
1779                       array_element_type)) {
1780                 ClangASTContext::CompleteTagDeclarationDefinition(
1781                     array_element_type);
1782               } else {
1783                 module_sp->ReportError("DWARF DIE at 0x%8.8x was not able to "
1784                                        "start its definition.\nPlease file a "
1785                                        "bug and attach the file at the start "
1786                                        "of this error message",
1787                                        type_die_ref.die_offset);
1788               }
1789             }
1790 
1791             uint64_t array_element_bit_stride = byte_stride * 8 + bit_stride;
1792             if (array_info && array_info->element_orders.size() > 0) {
1793               uint64_t num_elements = 0;
1794               auto end = array_info->element_orders.rend();
1795               for (auto pos = array_info->element_orders.rbegin(); pos != end;
1796                    ++pos) {
1797                 num_elements = *pos;
1798                 clang_type = m_ast.CreateArrayType(array_element_type,
1799                                                    num_elements, is_vector);
1800                 array_element_type = clang_type;
1801                 array_element_bit_stride =
1802                     num_elements ? array_element_bit_stride * num_elements
1803                                  : array_element_bit_stride;
1804               }
1805             } else {
1806               clang_type =
1807                   m_ast.CreateArrayType(array_element_type, 0, is_vector);
1808             }
1809             ConstString empty_name;
1810             type_sp.reset(new Type(
1811                 die.GetID(), dwarf, empty_name, array_element_bit_stride / 8,
1812                 NULL, DIERef(type_die_form).GetUID(dwarf), Type::eEncodingIsUID,
1813                 &decl, clang_type, Type::eResolveStateFull));
1814             type_sp->SetEncodingType(element_type);
1815             m_ast.SetMetadataAsUserID(clang_type.GetOpaqueQualType(),
1816                                       die.GetID());
1817           }
1818         }
1819       } break;
1820 
1821       case DW_TAG_ptr_to_member_type: {
1822         DWARFFormValue type_die_form;
1823         DWARFFormValue containing_type_die_form;
1824 
1825         const size_t num_attributes = die.GetAttributes(attributes);
1826 
1827         if (num_attributes > 0) {
1828           uint32_t i;
1829           for (i = 0; i < num_attributes; ++i) {
1830             attr = attributes.AttributeAtIndex(i);
1831             if (attributes.ExtractFormValueAtIndex(i, form_value)) {
1832               switch (attr) {
1833               case DW_AT_type:
1834                 type_die_form = form_value;
1835                 break;
1836               case DW_AT_containing_type:
1837                 containing_type_die_form = form_value;
1838                 break;
1839               }
1840             }
1841           }
1842 
1843           Type *pointee_type = dwarf->ResolveTypeUID(DIERef(type_die_form));
1844           Type *class_type =
1845               dwarf->ResolveTypeUID(DIERef(containing_type_die_form));
1846 
1847           CompilerType pointee_clang_type =
1848               pointee_type->GetForwardCompilerType();
1849           CompilerType class_clang_type = class_type->GetLayoutCompilerType();
1850 
1851           clang_type = ClangASTContext::CreateMemberPointerType(
1852               class_clang_type, pointee_clang_type);
1853 
1854           byte_size = clang_type.GetByteSize(nullptr);
1855 
1856           type_sp.reset(new Type(die.GetID(), dwarf, type_name_const_str,
1857                                  byte_size, NULL, LLDB_INVALID_UID,
1858                                  Type::eEncodingIsUID, NULL, clang_type,
1859                                  Type::eResolveStateForward));
1860         }
1861 
1862         break;
1863       }
1864       default:
1865         dwarf->GetObjectFile()->GetModule()->ReportError(
1866             "{0x%8.8x}: unhandled type tag 0x%4.4x (%s), please file a bug and "
1867             "attach the file at the start of this error message",
1868             die.GetOffset(), tag, DW_TAG_value_to_name(tag));
1869         break;
1870       }
1871 
1872       if (type_sp.get()) {
1873         DWARFDIE sc_parent_die =
1874             SymbolFileDWARF::GetParentSymbolContextDIE(die);
1875         dw_tag_t sc_parent_tag = sc_parent_die.Tag();
1876 
1877         SymbolContextScope *symbol_context_scope = NULL;
1878         if (sc_parent_tag == DW_TAG_compile_unit ||
1879             sc_parent_tag == DW_TAG_partial_unit) {
1880           symbol_context_scope = sc.comp_unit;
1881         } else if (sc.function != NULL && sc_parent_die) {
1882           symbol_context_scope =
1883               sc.function->GetBlock(true).FindBlockByID(sc_parent_die.GetID());
1884           if (symbol_context_scope == NULL)
1885             symbol_context_scope = sc.function;
1886         }
1887 
1888         if (symbol_context_scope != NULL) {
1889           type_sp->SetSymbolContextScope(symbol_context_scope);
1890         }
1891 
1892         // We are ready to put this type into the uniqued list up at the module
1893         // level
1894         type_list->Insert(type_sp);
1895 
1896         dwarf->GetDIEToType()[die.GetDIE()] = type_sp.get();
1897       }
1898     } else if (type_ptr != DIE_IS_BEING_PARSED) {
1899       type_sp = type_ptr->shared_from_this();
1900     }
1901   }
1902   return type_sp;
1903 }
1904 
1905 // DWARF parsing functions
1906 
1907 class DWARFASTParserClang::DelayedAddObjCClassProperty {
1908 public:
1909   DelayedAddObjCClassProperty(
1910       const CompilerType &class_opaque_type, const char *property_name,
1911       const CompilerType &property_opaque_type, // The property type is only
1912                                                 // required if you don't have an
1913                                                 // ivar decl
1914       clang::ObjCIvarDecl *ivar_decl, const char *property_setter_name,
1915       const char *property_getter_name, uint32_t property_attributes,
1916       const ClangASTMetadata *metadata)
1917       : m_class_opaque_type(class_opaque_type), m_property_name(property_name),
1918         m_property_opaque_type(property_opaque_type), m_ivar_decl(ivar_decl),
1919         m_property_setter_name(property_setter_name),
1920         m_property_getter_name(property_getter_name),
1921         m_property_attributes(property_attributes) {
1922     if (metadata != NULL) {
1923       m_metadata_ap.reset(new ClangASTMetadata());
1924       *m_metadata_ap = *metadata;
1925     }
1926   }
1927 
1928   DelayedAddObjCClassProperty(const DelayedAddObjCClassProperty &rhs) {
1929     *this = rhs;
1930   }
1931 
1932   DelayedAddObjCClassProperty &
1933   operator=(const DelayedAddObjCClassProperty &rhs) {
1934     m_class_opaque_type = rhs.m_class_opaque_type;
1935     m_property_name = rhs.m_property_name;
1936     m_property_opaque_type = rhs.m_property_opaque_type;
1937     m_ivar_decl = rhs.m_ivar_decl;
1938     m_property_setter_name = rhs.m_property_setter_name;
1939     m_property_getter_name = rhs.m_property_getter_name;
1940     m_property_attributes = rhs.m_property_attributes;
1941 
1942     if (rhs.m_metadata_ap.get()) {
1943       m_metadata_ap.reset(new ClangASTMetadata());
1944       *m_metadata_ap = *rhs.m_metadata_ap;
1945     }
1946     return *this;
1947   }
1948 
1949   bool Finalize() {
1950     return ClangASTContext::AddObjCClassProperty(
1951         m_class_opaque_type, m_property_name, m_property_opaque_type,
1952         m_ivar_decl, m_property_setter_name, m_property_getter_name,
1953         m_property_attributes, m_metadata_ap.get());
1954   }
1955 
1956 private:
1957   CompilerType m_class_opaque_type;
1958   const char *m_property_name;
1959   CompilerType m_property_opaque_type;
1960   clang::ObjCIvarDecl *m_ivar_decl;
1961   const char *m_property_setter_name;
1962   const char *m_property_getter_name;
1963   uint32_t m_property_attributes;
1964   std::unique_ptr<ClangASTMetadata> m_metadata_ap;
1965 };
1966 
1967 bool DWARFASTParserClang::ParseTemplateDIE(
1968     const DWARFDIE &die,
1969     ClangASTContext::TemplateParameterInfos &template_param_infos) {
1970   const dw_tag_t tag = die.Tag();
1971   bool is_template_template_argument = false;
1972 
1973   switch (tag) {
1974   case DW_TAG_GNU_template_parameter_pack: {
1975     template_param_infos.packed_args.reset(
1976       new ClangASTContext::TemplateParameterInfos);
1977     for (DWARFDIE child_die = die.GetFirstChild(); child_die.IsValid();
1978          child_die = child_die.GetSibling()) {
1979       if (!ParseTemplateDIE(child_die, *template_param_infos.packed_args))
1980         return false;
1981     }
1982     if (const char *name = die.GetName()) {
1983       template_param_infos.pack_name = name;
1984     }
1985     return true;
1986   }
1987   case DW_TAG_GNU_template_template_param:
1988     is_template_template_argument = true;
1989     LLVM_FALLTHROUGH;
1990   case DW_TAG_template_type_parameter:
1991   case DW_TAG_template_value_parameter: {
1992     DWARFAttributes attributes;
1993     const size_t num_attributes = die.GetAttributes(attributes);
1994     const char *name = nullptr;
1995     const char *template_name = nullptr;
1996     CompilerType clang_type;
1997     uint64_t uval64 = 0;
1998     bool uval64_valid = false;
1999     if (num_attributes > 0) {
2000       DWARFFormValue form_value;
2001       for (size_t i = 0; i < num_attributes; ++i) {
2002         const dw_attr_t attr = attributes.AttributeAtIndex(i);
2003 
2004         switch (attr) {
2005         case DW_AT_name:
2006           if (attributes.ExtractFormValueAtIndex(i, form_value))
2007             name = form_value.AsCString();
2008           break;
2009 
2010         case DW_AT_GNU_template_name:
2011           if (attributes.ExtractFormValueAtIndex(i, form_value))
2012             template_name = form_value.AsCString();
2013           break;
2014 
2015         case DW_AT_type:
2016           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
2017             Type *lldb_type = die.ResolveTypeUID(DIERef(form_value));
2018             if (lldb_type)
2019               clang_type = lldb_type->GetForwardCompilerType();
2020           }
2021           break;
2022 
2023         case DW_AT_const_value:
2024           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
2025             uval64_valid = true;
2026             uval64 = form_value.Unsigned();
2027           }
2028           break;
2029         default:
2030           break;
2031         }
2032       }
2033 
2034       clang::ASTContext *ast = m_ast.getASTContext();
2035       if (!clang_type)
2036         clang_type = m_ast.GetBasicType(eBasicTypeVoid);
2037 
2038       if (!is_template_template_argument) {
2039         bool is_signed = false;
2040         if (name && name[0])
2041           template_param_infos.names.push_back(name);
2042         else
2043           template_param_infos.names.push_back(NULL);
2044 
2045         // Get the signed value for any integer or enumeration if available
2046         clang_type.IsIntegerOrEnumerationType(is_signed);
2047 
2048         if (tag == DW_TAG_template_value_parameter && uval64_valid) {
2049           llvm::APInt apint(clang_type.GetBitSize(nullptr), uval64, is_signed);
2050           template_param_infos.args.push_back(
2051               clang::TemplateArgument(*ast, llvm::APSInt(apint, !is_signed),
2052                                       ClangUtil::GetQualType(clang_type)));
2053         } else {
2054           template_param_infos.args.push_back(
2055               clang::TemplateArgument(ClangUtil::GetQualType(clang_type)));
2056         }
2057       } else {
2058         auto *tplt_type = m_ast.CreateTemplateTemplateParmDecl(template_name);
2059         template_param_infos.names.push_back(name);
2060         template_param_infos.args.push_back(
2061             clang::TemplateArgument(clang::TemplateName(tplt_type)));
2062       }
2063     }
2064   }
2065     return true;
2066 
2067   default:
2068     break;
2069   }
2070   return false;
2071 }
2072 
2073 bool DWARFASTParserClang::ParseTemplateParameterInfos(
2074     const DWARFDIE &parent_die,
2075     ClangASTContext::TemplateParameterInfos &template_param_infos) {
2076 
2077   if (!parent_die)
2078     return false;
2079 
2080   for (DWARFDIE die = parent_die.GetFirstChild(); die.IsValid();
2081        die = die.GetSibling()) {
2082     const dw_tag_t tag = die.Tag();
2083 
2084     switch (tag) {
2085     case DW_TAG_template_type_parameter:
2086     case DW_TAG_template_value_parameter:
2087     case DW_TAG_GNU_template_parameter_pack:
2088     case DW_TAG_GNU_template_template_param:
2089       ParseTemplateDIE(die, template_param_infos);
2090       break;
2091 
2092     default:
2093       break;
2094     }
2095   }
2096   if (template_param_infos.args.empty())
2097     return false;
2098   return template_param_infos.args.size() == template_param_infos.names.size();
2099 }
2100 
2101 bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE &die,
2102                                                 lldb_private::Type *type,
2103                                                 CompilerType &clang_type) {
2104   SymbolFileDWARF *dwarf = die.GetDWARF();
2105 
2106   std::lock_guard<std::recursive_mutex> guard(
2107       dwarf->GetObjectFile()->GetModule()->GetMutex());
2108 
2109   // Disable external storage for this type so we don't get anymore
2110   // clang::ExternalASTSource queries for this type.
2111   m_ast.SetHasExternalStorage(clang_type.GetOpaqueQualType(), false);
2112 
2113   if (!die)
2114     return false;
2115 
2116 #if defined LLDB_CONFIGURATION_DEBUG
2117   //----------------------------------------------------------------------
2118   // For debugging purposes, the LLDB_DWARF_DONT_COMPLETE_TYPENAMES environment
2119   // variable can be set with one or more typenames separated by ';'
2120   // characters. This will cause this function to not complete any types whose
2121   // names match.
2122   //
2123   // Examples of setting this environment variable:
2124   //
2125   // LLDB_DWARF_DONT_COMPLETE_TYPENAMES=Foo
2126   // LLDB_DWARF_DONT_COMPLETE_TYPENAMES=Foo;Bar;Baz
2127   //----------------------------------------------------------------------
2128   const char *dont_complete_typenames_cstr =
2129       getenv("LLDB_DWARF_DONT_COMPLETE_TYPENAMES");
2130   if (dont_complete_typenames_cstr && dont_complete_typenames_cstr[0]) {
2131     const char *die_name = die.GetName();
2132     if (die_name && die_name[0]) {
2133       const char *match = strstr(dont_complete_typenames_cstr, die_name);
2134       if (match) {
2135         size_t die_name_length = strlen(die_name);
2136         while (match) {
2137           const char separator_char = ';';
2138           const char next_char = match[die_name_length];
2139           if (next_char == '\0' || next_char == separator_char) {
2140             if (match == dont_complete_typenames_cstr ||
2141                 match[-1] == separator_char)
2142               return false;
2143           }
2144           match = strstr(match + 1, die_name);
2145         }
2146       }
2147     }
2148   }
2149 #endif
2150 
2151   const dw_tag_t tag = die.Tag();
2152 
2153   Log *log =
2154       nullptr; // (LogChannelDWARF::GetLogIfAny(DWARF_LOG_DEBUG_INFO|DWARF_LOG_TYPE_COMPLETION));
2155   if (log)
2156     dwarf->GetObjectFile()->GetModule()->LogMessageVerboseBacktrace(
2157         log, "0x%8.8" PRIx64 ": %s '%s' resolving forward declaration...",
2158         die.GetID(), die.GetTagAsCString(), type->GetName().AsCString());
2159   assert(clang_type);
2160   DWARFAttributes attributes;
2161   switch (tag) {
2162   case DW_TAG_structure_type:
2163   case DW_TAG_union_type:
2164   case DW_TAG_class_type: {
2165     ClangASTImporter::LayoutInfo layout_info;
2166 
2167     {
2168       if (die.HasChildren()) {
2169         LanguageType class_language = eLanguageTypeUnknown;
2170         if (ClangASTContext::IsObjCObjectOrInterfaceType(clang_type)) {
2171           class_language = eLanguageTypeObjC;
2172           // For objective C we don't start the definition when the class is
2173           // created.
2174           ClangASTContext::StartTagDeclarationDefinition(clang_type);
2175         }
2176 
2177         int tag_decl_kind = -1;
2178         AccessType default_accessibility = eAccessNone;
2179         if (tag == DW_TAG_structure_type) {
2180           tag_decl_kind = clang::TTK_Struct;
2181           default_accessibility = eAccessPublic;
2182         } else if (tag == DW_TAG_union_type) {
2183           tag_decl_kind = clang::TTK_Union;
2184           default_accessibility = eAccessPublic;
2185         } else if (tag == DW_TAG_class_type) {
2186           tag_decl_kind = clang::TTK_Class;
2187           default_accessibility = eAccessPrivate;
2188         }
2189 
2190         SymbolContext sc(die.GetLLDBCompileUnit());
2191         std::vector<std::unique_ptr<clang::CXXBaseSpecifier>> bases;
2192         std::vector<int> member_accessibilities;
2193         bool is_a_class = false;
2194         // Parse members and base classes first
2195         DWARFDIECollection member_function_dies;
2196 
2197         DelayedPropertyList delayed_properties;
2198         ParseChildMembers(sc, die, clang_type, class_language, bases,
2199                           member_accessibilities, member_function_dies,
2200                           delayed_properties, default_accessibility, is_a_class,
2201                           layout_info);
2202 
2203         // Now parse any methods if there were any...
2204         size_t num_functions = member_function_dies.Size();
2205         if (num_functions > 0) {
2206           for (size_t i = 0; i < num_functions; ++i) {
2207             dwarf->ResolveType(member_function_dies.GetDIEAtIndex(i));
2208           }
2209         }
2210 
2211         if (class_language == eLanguageTypeObjC) {
2212           ConstString class_name(clang_type.GetTypeName());
2213           if (class_name) {
2214             DIEArray method_die_offsets;
2215             dwarf->GetObjCMethodDIEOffsets(class_name, method_die_offsets);
2216 
2217             if (!method_die_offsets.empty()) {
2218               DWARFDebugInfo *debug_info = dwarf->DebugInfo();
2219 
2220               const size_t num_matches = method_die_offsets.size();
2221               for (size_t i = 0; i < num_matches; ++i) {
2222                 const DIERef &die_ref = method_die_offsets[i];
2223                 DWARFDIE method_die = debug_info->GetDIE(die_ref);
2224 
2225                 if (method_die)
2226                   method_die.ResolveType();
2227               }
2228             }
2229 
2230             for (DelayedPropertyList::iterator pi = delayed_properties.begin(),
2231                                                pe = delayed_properties.end();
2232                  pi != pe; ++pi)
2233               pi->Finalize();
2234           }
2235         }
2236 
2237         // If we have a DW_TAG_structure_type instead of a DW_TAG_class_type we
2238         // need to tell the clang type it is actually a class.
2239         if (class_language != eLanguageTypeObjC) {
2240           if (is_a_class && tag_decl_kind != clang::TTK_Class)
2241             m_ast.SetTagTypeKind(ClangUtil::GetQualType(clang_type),
2242                                  clang::TTK_Class);
2243         }
2244 
2245         // Since DW_TAG_structure_type gets used for both classes and
2246         // structures, we may need to set any DW_TAG_member fields to have a
2247         // "private" access if none was specified. When we parsed the child
2248         // members we tracked that actual accessibility value for each
2249         // DW_TAG_member in the "member_accessibilities" array. If the value
2250         // for the member is zero, then it was set to the
2251         // "default_accessibility" which for structs was "public". Below we
2252         // correct this by setting any fields to "private" that weren't
2253         // correctly set.
2254         if (is_a_class && !member_accessibilities.empty()) {
2255           // This is a class and all members that didn't have their access
2256           // specified are private.
2257           m_ast.SetDefaultAccessForRecordFields(
2258               m_ast.GetAsRecordDecl(clang_type), eAccessPrivate,
2259               &member_accessibilities.front(), member_accessibilities.size());
2260         }
2261 
2262         if (!bases.empty()) {
2263           // Make sure all base classes refer to complete types and not forward
2264           // declarations. If we don't do this, clang will crash with an
2265           // assertion in the call to clang_type.TransferBaseClasses()
2266           for (const auto &base_class : bases) {
2267             clang::TypeSourceInfo *type_source_info =
2268                 base_class->getTypeSourceInfo();
2269             if (type_source_info) {
2270               CompilerType base_class_type(
2271                   &m_ast, type_source_info->getType().getAsOpaquePtr());
2272               if (base_class_type.GetCompleteType() == false) {
2273                 auto module = dwarf->GetObjectFile()->GetModule();
2274                 module->ReportError(":: Class '%s' has a base class '%s' which "
2275                                     "does not have a complete definition.",
2276                                     die.GetName(),
2277                                     base_class_type.GetTypeName().GetCString());
2278                 if (die.GetCU()->GetProducer() == eProducerClang)
2279                   module->ReportError(":: Try compiling the source file with "
2280                                       "-fstandalone-debug.");
2281 
2282                 // We have no choice other than to pretend that the base class
2283                 // is complete. If we don't do this, clang will crash when we
2284                 // call setBases() inside of
2285                 // "clang_type.TransferBaseClasses()" below. Since we
2286                 // provide layout assistance, all ivars in this class and other
2287                 // classes will be fine, this is the best we can do short of
2288                 // crashing.
2289                 if (ClangASTContext::StartTagDeclarationDefinition(
2290                         base_class_type)) {
2291                   ClangASTContext::CompleteTagDeclarationDefinition(
2292                       base_class_type);
2293                 }
2294               }
2295             }
2296           }
2297 
2298           m_ast.TransferBaseClasses(clang_type.GetOpaqueQualType(),
2299                                     std::move(bases));
2300         }
2301       }
2302     }
2303 
2304     m_ast.AddMethodOverridesForCXXRecordType(clang_type.GetOpaqueQualType());
2305     ClangASTContext::BuildIndirectFields(clang_type);
2306     ClangASTContext::CompleteTagDeclarationDefinition(clang_type);
2307 
2308     if (!layout_info.field_offsets.empty() ||
2309         !layout_info.base_offsets.empty() ||
2310         !layout_info.vbase_offsets.empty()) {
2311       if (type)
2312         layout_info.bit_size = type->GetByteSize() * 8;
2313       if (layout_info.bit_size == 0)
2314         layout_info.bit_size =
2315             die.GetAttributeValueAsUnsigned(DW_AT_byte_size, 0) * 8;
2316 
2317       clang::CXXRecordDecl *record_decl =
2318           m_ast.GetAsCXXRecordDecl(clang_type.GetOpaqueQualType());
2319       if (record_decl) {
2320         if (log) {
2321           ModuleSP module_sp = dwarf->GetObjectFile()->GetModule();
2322 
2323           if (module_sp) {
2324             module_sp->LogMessage(
2325                 log,
2326                 "ClangASTContext::CompleteTypeFromDWARF (clang_type = %p) "
2327                 "caching layout info for record_decl = %p, bit_size = %" PRIu64
2328                 ", alignment = %" PRIu64
2329                 ", field_offsets[%u], base_offsets[%u], vbase_offsets[%u])",
2330                 static_cast<void *>(clang_type.GetOpaqueQualType()),
2331                 static_cast<void *>(record_decl), layout_info.bit_size,
2332                 layout_info.alignment,
2333                 static_cast<uint32_t>(layout_info.field_offsets.size()),
2334                 static_cast<uint32_t>(layout_info.base_offsets.size()),
2335                 static_cast<uint32_t>(layout_info.vbase_offsets.size()));
2336 
2337             uint32_t idx;
2338             {
2339               llvm::DenseMap<const clang::FieldDecl *, uint64_t>::const_iterator
2340                   pos,
2341                   end = layout_info.field_offsets.end();
2342               for (idx = 0, pos = layout_info.field_offsets.begin(); pos != end;
2343                    ++pos, ++idx) {
2344                 module_sp->LogMessage(
2345                     log, "ClangASTContext::CompleteTypeFromDWARF (clang_type = "
2346                          "%p) field[%u] = { bit_offset=%u, name='%s' }",
2347                     static_cast<void *>(clang_type.GetOpaqueQualType()), idx,
2348                     static_cast<uint32_t>(pos->second),
2349                     pos->first->getNameAsString().c_str());
2350               }
2351             }
2352 
2353             {
2354               llvm::DenseMap<const clang::CXXRecordDecl *,
2355                              clang::CharUnits>::const_iterator base_pos,
2356                   base_end = layout_info.base_offsets.end();
2357               for (idx = 0, base_pos = layout_info.base_offsets.begin();
2358                    base_pos != base_end; ++base_pos, ++idx) {
2359                 module_sp->LogMessage(
2360                     log, "ClangASTContext::CompleteTypeFromDWARF (clang_type = "
2361                          "%p) base[%u] = { byte_offset=%u, name='%s' }",
2362                     clang_type.GetOpaqueQualType(), idx,
2363                     (uint32_t)base_pos->second.getQuantity(),
2364                     base_pos->first->getNameAsString().c_str());
2365               }
2366             }
2367             {
2368               llvm::DenseMap<const clang::CXXRecordDecl *,
2369                              clang::CharUnits>::const_iterator vbase_pos,
2370                   vbase_end = layout_info.vbase_offsets.end();
2371               for (idx = 0, vbase_pos = layout_info.vbase_offsets.begin();
2372                    vbase_pos != vbase_end; ++vbase_pos, ++idx) {
2373                 module_sp->LogMessage(
2374                     log, "ClangASTContext::CompleteTypeFromDWARF (clang_type = "
2375                          "%p) vbase[%u] = { byte_offset=%u, name='%s' }",
2376                     static_cast<void *>(clang_type.GetOpaqueQualType()), idx,
2377                     static_cast<uint32_t>(vbase_pos->second.getQuantity()),
2378                     vbase_pos->first->getNameAsString().c_str());
2379               }
2380             }
2381           }
2382         }
2383         GetClangASTImporter().InsertRecordDecl(record_decl, layout_info);
2384       }
2385     }
2386   }
2387 
2388     return (bool)clang_type;
2389 
2390   case DW_TAG_enumeration_type:
2391     if (ClangASTContext::StartTagDeclarationDefinition(clang_type)) {
2392       if (die.HasChildren()) {
2393         SymbolContext sc(die.GetLLDBCompileUnit());
2394         bool is_signed = false;
2395         clang_type.IsIntegerType(is_signed);
2396         ParseChildEnumerators(sc, clang_type, is_signed, type->GetByteSize(),
2397                               die);
2398       }
2399       ClangASTContext::CompleteTagDeclarationDefinition(clang_type);
2400     }
2401     return (bool)clang_type;
2402 
2403   default:
2404     assert(false && "not a forward clang type decl!");
2405     break;
2406   }
2407 
2408   return false;
2409 }
2410 
2411 std::vector<DWARFDIE> DWARFASTParserClang::GetDIEForDeclContext(
2412     lldb_private::CompilerDeclContext decl_context) {
2413   std::vector<DWARFDIE> result;
2414   for (auto it = m_decl_ctx_to_die.find(
2415            (clang::DeclContext *)decl_context.GetOpaqueDeclContext());
2416        it != m_decl_ctx_to_die.end(); it++)
2417     result.push_back(it->second);
2418   return result;
2419 }
2420 
2421 CompilerDecl DWARFASTParserClang::GetDeclForUIDFromDWARF(const DWARFDIE &die) {
2422   clang::Decl *clang_decl = GetClangDeclForDIE(die);
2423   if (clang_decl != nullptr)
2424     return CompilerDecl(&m_ast, clang_decl);
2425   return CompilerDecl();
2426 }
2427 
2428 CompilerDeclContext
2429 DWARFASTParserClang::GetDeclContextForUIDFromDWARF(const DWARFDIE &die) {
2430   clang::DeclContext *clang_decl_ctx = GetClangDeclContextForDIE(die);
2431   if (clang_decl_ctx)
2432     return CompilerDeclContext(&m_ast, clang_decl_ctx);
2433   return CompilerDeclContext();
2434 }
2435 
2436 CompilerDeclContext
2437 DWARFASTParserClang::GetDeclContextContainingUIDFromDWARF(const DWARFDIE &die) {
2438   clang::DeclContext *clang_decl_ctx =
2439       GetClangDeclContextContainingDIE(die, nullptr);
2440   if (clang_decl_ctx)
2441     return CompilerDeclContext(&m_ast, clang_decl_ctx);
2442   return CompilerDeclContext();
2443 }
2444 
2445 size_t DWARFASTParserClang::ParseChildEnumerators(
2446     const SymbolContext &sc, lldb_private::CompilerType &clang_type,
2447     bool is_signed, uint32_t enumerator_byte_size, const DWARFDIE &parent_die) {
2448   if (!parent_die)
2449     return 0;
2450 
2451   size_t enumerators_added = 0;
2452 
2453   for (DWARFDIE die = parent_die.GetFirstChild(); die.IsValid();
2454        die = die.GetSibling()) {
2455     const dw_tag_t tag = die.Tag();
2456     if (tag == DW_TAG_enumerator) {
2457       DWARFAttributes attributes;
2458       const size_t num_child_attributes = die.GetAttributes(attributes);
2459       if (num_child_attributes > 0) {
2460         const char *name = NULL;
2461         bool got_value = false;
2462         int64_t enum_value = 0;
2463         Declaration decl;
2464 
2465         uint32_t i;
2466         for (i = 0; i < num_child_attributes; ++i) {
2467           const dw_attr_t attr = attributes.AttributeAtIndex(i);
2468           DWARFFormValue form_value;
2469           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
2470             switch (attr) {
2471             case DW_AT_const_value:
2472               got_value = true;
2473               if (is_signed)
2474                 enum_value = form_value.Signed();
2475               else
2476                 enum_value = form_value.Unsigned();
2477               break;
2478 
2479             case DW_AT_name:
2480               name = form_value.AsCString();
2481               break;
2482 
2483             case DW_AT_description:
2484             default:
2485             case DW_AT_decl_file:
2486               decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
2487                   form_value.Unsigned()));
2488               break;
2489             case DW_AT_decl_line:
2490               decl.SetLine(form_value.Unsigned());
2491               break;
2492             case DW_AT_decl_column:
2493               decl.SetColumn(form_value.Unsigned());
2494               break;
2495             case DW_AT_sibling:
2496               break;
2497             }
2498           }
2499         }
2500 
2501         if (name && name[0] && got_value) {
2502           m_ast.AddEnumerationValueToEnumerationType(
2503               clang_type, decl, name, enum_value, enumerator_byte_size * 8);
2504           ++enumerators_added;
2505         }
2506       }
2507     }
2508   }
2509   return enumerators_added;
2510 }
2511 
2512 #if defined(LLDB_CONFIGURATION_DEBUG) || defined(LLDB_CONFIGURATION_RELEASE)
2513 
2514 class DIEStack {
2515 public:
2516   void Push(const DWARFDIE &die) { m_dies.push_back(die); }
2517 
2518   void LogDIEs(Log *log) {
2519     StreamString log_strm;
2520     const size_t n = m_dies.size();
2521     log_strm.Printf("DIEStack[%" PRIu64 "]:\n", (uint64_t)n);
2522     for (size_t i = 0; i < n; i++) {
2523       std::string qualified_name;
2524       const DWARFDIE &die = m_dies[i];
2525       die.GetQualifiedName(qualified_name);
2526       log_strm.Printf("[%" PRIu64 "] 0x%8.8x: %s name='%s'\n", (uint64_t)i,
2527                       die.GetOffset(), die.GetTagAsCString(),
2528                       qualified_name.c_str());
2529     }
2530     log->PutCString(log_strm.GetData());
2531   }
2532   void Pop() { m_dies.pop_back(); }
2533 
2534   class ScopedPopper {
2535   public:
2536     ScopedPopper(DIEStack &die_stack)
2537         : m_die_stack(die_stack), m_valid(false) {}
2538 
2539     void Push(const DWARFDIE &die) {
2540       m_valid = true;
2541       m_die_stack.Push(die);
2542     }
2543 
2544     ~ScopedPopper() {
2545       if (m_valid)
2546         m_die_stack.Pop();
2547     }
2548 
2549   protected:
2550     DIEStack &m_die_stack;
2551     bool m_valid;
2552   };
2553 
2554 protected:
2555   typedef std::vector<DWARFDIE> Stack;
2556   Stack m_dies;
2557 };
2558 #endif
2559 
2560 Function *DWARFASTParserClang::ParseFunctionFromDWARF(const SymbolContext &sc,
2561                                                       const DWARFDIE &die) {
2562   DWARFRangeList func_ranges;
2563   const char *name = NULL;
2564   const char *mangled = NULL;
2565   int decl_file = 0;
2566   int decl_line = 0;
2567   int decl_column = 0;
2568   int call_file = 0;
2569   int call_line = 0;
2570   int call_column = 0;
2571   DWARFExpression frame_base(die.GetCU());
2572 
2573   const dw_tag_t tag = die.Tag();
2574 
2575   if (tag != DW_TAG_subprogram)
2576     return NULL;
2577 
2578   if (die.GetDIENamesAndRanges(name, mangled, func_ranges, decl_file, decl_line,
2579                                decl_column, call_file, call_line, call_column,
2580                                &frame_base)) {
2581 
2582     // Union of all ranges in the function DIE (if the function is
2583     // discontiguous)
2584     AddressRange func_range;
2585     lldb::addr_t lowest_func_addr = func_ranges.GetMinRangeBase(0);
2586     lldb::addr_t highest_func_addr = func_ranges.GetMaxRangeEnd(0);
2587     if (lowest_func_addr != LLDB_INVALID_ADDRESS &&
2588         lowest_func_addr <= highest_func_addr) {
2589       ModuleSP module_sp(die.GetModule());
2590       func_range.GetBaseAddress().ResolveAddressUsingFileSections(
2591           lowest_func_addr, module_sp->GetSectionList());
2592       if (func_range.GetBaseAddress().IsValid())
2593         func_range.SetByteSize(highest_func_addr - lowest_func_addr);
2594     }
2595 
2596     if (func_range.GetBaseAddress().IsValid()) {
2597       Mangled func_name;
2598       if (mangled)
2599         func_name.SetValue(ConstString(mangled), true);
2600       else if ((die.GetParent().Tag() == DW_TAG_compile_unit ||
2601                 die.GetParent().Tag() == DW_TAG_partial_unit) &&
2602                Language::LanguageIsCPlusPlus(die.GetLanguage()) && name &&
2603                strcmp(name, "main") != 0) {
2604         // If the mangled name is not present in the DWARF, generate the
2605         // demangled name using the decl context. We skip if the function is
2606         // "main" as its name is never mangled.
2607         bool is_static = false;
2608         bool is_variadic = false;
2609         bool has_template_params = false;
2610         unsigned type_quals = 0;
2611         std::vector<CompilerType> param_types;
2612         std::vector<clang::ParmVarDecl *> param_decls;
2613         DWARFDeclContext decl_ctx;
2614         StreamString sstr;
2615 
2616         die.GetDWARFDeclContext(decl_ctx);
2617         sstr << decl_ctx.GetQualifiedName();
2618 
2619         clang::DeclContext *containing_decl_ctx =
2620             GetClangDeclContextContainingDIE(die, nullptr);
2621         ParseChildParameters(sc, containing_decl_ctx, die, true, is_static,
2622                              is_variadic, has_template_params, param_types,
2623                              param_decls, type_quals);
2624         sstr << "(";
2625         for (size_t i = 0; i < param_types.size(); i++) {
2626           if (i > 0)
2627             sstr << ", ";
2628           sstr << param_types[i].GetTypeName();
2629         }
2630         if (is_variadic)
2631           sstr << ", ...";
2632         sstr << ")";
2633         if (type_quals & clang::Qualifiers::Const)
2634           sstr << " const";
2635 
2636         func_name.SetValue(ConstString(sstr.GetString()), false);
2637       } else
2638         func_name.SetValue(ConstString(name), false);
2639 
2640       FunctionSP func_sp;
2641       std::unique_ptr<Declaration> decl_ap;
2642       if (decl_file != 0 || decl_line != 0 || decl_column != 0)
2643         decl_ap.reset(new Declaration(
2644             sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(decl_file),
2645             decl_line, decl_column));
2646 
2647       SymbolFileDWARF *dwarf = die.GetDWARF();
2648       // Supply the type _only_ if it has already been parsed
2649       Type *func_type = dwarf->GetDIEToType().lookup(die.GetDIE());
2650 
2651       assert(func_type == NULL || func_type != DIE_IS_BEING_PARSED);
2652 
2653       if (dwarf->FixupAddress(func_range.GetBaseAddress())) {
2654         const user_id_t func_user_id = die.GetID();
2655         func_sp.reset(new Function(sc.comp_unit,
2656                                    func_user_id, // UserID is the DIE offset
2657                                    func_user_id, func_name, func_type,
2658                                    func_range)); // first address range
2659 
2660         if (func_sp.get() != NULL) {
2661           if (frame_base.IsValid())
2662             func_sp->GetFrameBaseExpression() = frame_base;
2663           sc.comp_unit->AddFunction(func_sp);
2664           return func_sp.get();
2665         }
2666       }
2667     }
2668   }
2669   return NULL;
2670 }
2671 
2672 bool DWARFASTParserClang::ParseChildMembers(
2673     const SymbolContext &sc, const DWARFDIE &parent_die,
2674     CompilerType &class_clang_type, const LanguageType class_language,
2675     std::vector<std::unique_ptr<clang::CXXBaseSpecifier>> &base_classes,
2676     std::vector<int> &member_accessibilities,
2677     DWARFDIECollection &member_function_dies,
2678     DelayedPropertyList &delayed_properties, AccessType &default_accessibility,
2679     bool &is_a_class, ClangASTImporter::LayoutInfo &layout_info) {
2680   if (!parent_die)
2681     return 0;
2682 
2683   // Get the parent byte size so we can verify any members will fit
2684   const uint64_t parent_byte_size =
2685       parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size, UINT64_MAX);
2686   const uint64_t parent_bit_size =
2687       parent_byte_size == UINT64_MAX ? UINT64_MAX : parent_byte_size * 8;
2688 
2689   uint32_t member_idx = 0;
2690   BitfieldInfo last_field_info;
2691 
2692   ModuleSP module_sp = parent_die.GetDWARF()->GetObjectFile()->GetModule();
2693   ClangASTContext *ast =
2694       llvm::dyn_cast_or_null<ClangASTContext>(class_clang_type.GetTypeSystem());
2695   if (ast == nullptr)
2696     return 0;
2697 
2698   for (DWARFDIE die = parent_die.GetFirstChild(); die.IsValid();
2699        die = die.GetSibling()) {
2700     dw_tag_t tag = die.Tag();
2701 
2702     switch (tag) {
2703     case DW_TAG_member:
2704     case DW_TAG_APPLE_property: {
2705       DWARFAttributes attributes;
2706       const size_t num_attributes = die.GetAttributes(attributes);
2707       if (num_attributes > 0) {
2708         Declaration decl;
2709         // DWARFExpression location;
2710         const char *name = NULL;
2711         const char *prop_name = NULL;
2712         const char *prop_getter_name = NULL;
2713         const char *prop_setter_name = NULL;
2714         uint32_t prop_attributes = 0;
2715 
2716         bool is_artificial = false;
2717         DWARFFormValue encoding_form;
2718         AccessType accessibility = eAccessNone;
2719         uint32_t member_byte_offset =
2720             (parent_die.Tag() == DW_TAG_union_type) ? 0 : UINT32_MAX;
2721         size_t byte_size = 0;
2722         int64_t bit_offset = 0;
2723         uint64_t data_bit_offset = UINT64_MAX;
2724         size_t bit_size = 0;
2725         bool is_external =
2726             false; // On DW_TAG_members, this means the member is static
2727         uint32_t i;
2728         for (i = 0; i < num_attributes && !is_artificial; ++i) {
2729           const dw_attr_t attr = attributes.AttributeAtIndex(i);
2730           DWARFFormValue form_value;
2731           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
2732             switch (attr) {
2733             case DW_AT_decl_file:
2734               decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
2735                   form_value.Unsigned()));
2736               break;
2737             case DW_AT_decl_line:
2738               decl.SetLine(form_value.Unsigned());
2739               break;
2740             case DW_AT_decl_column:
2741               decl.SetColumn(form_value.Unsigned());
2742               break;
2743             case DW_AT_name:
2744               name = form_value.AsCString();
2745               break;
2746             case DW_AT_type:
2747               encoding_form = form_value;
2748               break;
2749             case DW_AT_bit_offset:
2750               bit_offset = form_value.Signed();
2751               break;
2752             case DW_AT_bit_size:
2753               bit_size = form_value.Unsigned();
2754               break;
2755             case DW_AT_byte_size:
2756               byte_size = form_value.Unsigned();
2757               break;
2758             case DW_AT_data_bit_offset:
2759               data_bit_offset = form_value.Unsigned();
2760               break;
2761             case DW_AT_data_member_location:
2762               if (form_value.BlockData()) {
2763                 Value initialValue(0);
2764                 Value memberOffset(0);
2765                 const DWARFDataExtractor &debug_info_data = die.GetData();
2766                 uint32_t block_length = form_value.Unsigned();
2767                 uint32_t block_offset =
2768                     form_value.BlockData() - debug_info_data.GetDataStart();
2769                 if (DWARFExpression::Evaluate(
2770                         nullptr, // ExecutionContext *
2771                         nullptr, // RegisterContext *
2772                         module_sp, debug_info_data, die.GetCU(), block_offset,
2773                         block_length, eRegisterKindDWARF, &initialValue,
2774                         nullptr, memberOffset, nullptr)) {
2775                   member_byte_offset = memberOffset.ResolveValue(NULL).UInt();
2776                 }
2777               } else {
2778                 // With DWARF 3 and later, if the value is an integer constant,
2779                 // this form value is the offset in bytes from the beginning of
2780                 // the containing entity.
2781                 member_byte_offset = form_value.Unsigned();
2782               }
2783               break;
2784 
2785             case DW_AT_accessibility:
2786               accessibility = DW_ACCESS_to_AccessType(form_value.Unsigned());
2787               break;
2788             case DW_AT_artificial:
2789               is_artificial = form_value.Boolean();
2790               break;
2791             case DW_AT_APPLE_property_name:
2792               prop_name = form_value.AsCString();
2793               break;
2794             case DW_AT_APPLE_property_getter:
2795               prop_getter_name = form_value.AsCString();
2796               break;
2797             case DW_AT_APPLE_property_setter:
2798               prop_setter_name = form_value.AsCString();
2799               break;
2800             case DW_AT_APPLE_property_attribute:
2801               prop_attributes = form_value.Unsigned();
2802               break;
2803             case DW_AT_external:
2804               is_external = form_value.Boolean();
2805               break;
2806 
2807             default:
2808             case DW_AT_declaration:
2809             case DW_AT_description:
2810             case DW_AT_mutable:
2811             case DW_AT_visibility:
2812             case DW_AT_sibling:
2813               break;
2814             }
2815           }
2816         }
2817 
2818         if (prop_name) {
2819           ConstString fixed_getter;
2820           ConstString fixed_setter;
2821 
2822           // Check if the property getter/setter were provided as full names.
2823           // We want basenames, so we extract them.
2824 
2825           if (prop_getter_name && prop_getter_name[0] == '-') {
2826             ObjCLanguage::MethodName prop_getter_method(prop_getter_name, true);
2827             prop_getter_name = prop_getter_method.GetSelector().GetCString();
2828           }
2829 
2830           if (prop_setter_name && prop_setter_name[0] == '-') {
2831             ObjCLanguage::MethodName prop_setter_method(prop_setter_name, true);
2832             prop_setter_name = prop_setter_method.GetSelector().GetCString();
2833           }
2834 
2835           // If the names haven't been provided, they need to be filled in.
2836 
2837           if (!prop_getter_name) {
2838             prop_getter_name = prop_name;
2839           }
2840           if (!prop_setter_name && prop_name[0] &&
2841               !(prop_attributes & DW_APPLE_PROPERTY_readonly)) {
2842             StreamString ss;
2843 
2844             ss.Printf("set%c%s:", toupper(prop_name[0]), &prop_name[1]);
2845 
2846             fixed_setter.SetString(ss.GetString());
2847             prop_setter_name = fixed_setter.GetCString();
2848           }
2849         }
2850 
2851         // Clang has a DWARF generation bug where sometimes it represents
2852         // fields that are references with bad byte size and bit size/offset
2853         // information such as:
2854         //
2855         //  DW_AT_byte_size( 0x00 )
2856         //  DW_AT_bit_size( 0x40 )
2857         //  DW_AT_bit_offset( 0xffffffffffffffc0 )
2858         //
2859         // So check the bit offset to make sure it is sane, and if the values
2860         // are not sane, remove them. If we don't do this then we will end up
2861         // with a crash if we try to use this type in an expression when clang
2862         // becomes unhappy with its recycled debug info.
2863 
2864         if (byte_size == 0 && bit_offset < 0) {
2865           bit_size = 0;
2866           bit_offset = 0;
2867         }
2868 
2869         // FIXME: Make Clang ignore Objective-C accessibility for expressions
2870         if (class_language == eLanguageTypeObjC ||
2871             class_language == eLanguageTypeObjC_plus_plus)
2872           accessibility = eAccessNone;
2873 
2874         // Handle static members
2875         if (is_external && member_byte_offset == UINT32_MAX) {
2876           Type *var_type = die.ResolveTypeUID(DIERef(encoding_form));
2877 
2878           if (var_type) {
2879             if (accessibility == eAccessNone)
2880               accessibility = eAccessPublic;
2881             ClangASTContext::AddVariableToRecordType(
2882                 class_clang_type, name, var_type->GetLayoutCompilerType(),
2883                 accessibility);
2884           }
2885           break;
2886         }
2887 
2888         if (is_artificial == false) {
2889           Type *member_type = die.ResolveTypeUID(DIERef(encoding_form));
2890 
2891           clang::FieldDecl *field_decl = NULL;
2892           if (tag == DW_TAG_member) {
2893             if (member_type) {
2894               if (accessibility == eAccessNone)
2895                 accessibility = default_accessibility;
2896               member_accessibilities.push_back(accessibility);
2897 
2898               uint64_t field_bit_offset =
2899                   (member_byte_offset == UINT32_MAX ? 0
2900                                                     : (member_byte_offset * 8));
2901               if (bit_size > 0) {
2902 
2903                 BitfieldInfo this_field_info;
2904                 this_field_info.bit_offset = field_bit_offset;
2905                 this_field_info.bit_size = bit_size;
2906 
2907                 /////////////////////////////////////////////////////////////
2908                 // How to locate a field given the DWARF debug information
2909                 //
2910                 // AT_byte_size indicates the size of the word in which the bit
2911                 // offset must be interpreted.
2912                 //
2913                 // AT_data_member_location indicates the byte offset of the
2914                 // word from the base address of the structure.
2915                 //
2916                 // AT_bit_offset indicates how many bits into the word
2917                 // (according to the host endianness) the low-order bit of the
2918                 // field starts.  AT_bit_offset can be negative.
2919                 //
2920                 // AT_bit_size indicates the size of the field in bits.
2921                 /////////////////////////////////////////////////////////////
2922 
2923                 if (data_bit_offset != UINT64_MAX) {
2924                   this_field_info.bit_offset = data_bit_offset;
2925                 } else {
2926                   if (byte_size == 0)
2927                     byte_size = member_type->GetByteSize();
2928 
2929                   ObjectFile *objfile = die.GetDWARF()->GetObjectFile();
2930                   if (objfile->GetByteOrder() == eByteOrderLittle) {
2931                     this_field_info.bit_offset += byte_size * 8;
2932                     this_field_info.bit_offset -= (bit_offset + bit_size);
2933                   } else {
2934                     this_field_info.bit_offset += bit_offset;
2935                   }
2936                 }
2937 
2938                 if ((this_field_info.bit_offset >= parent_bit_size) ||
2939                     !last_field_info.NextBitfieldOffsetIsValid(
2940                         this_field_info.bit_offset)) {
2941                   ObjectFile *objfile = die.GetDWARF()->GetObjectFile();
2942                   objfile->GetModule()->ReportWarning(
2943                       "0x%8.8" PRIx64 ": %s bitfield named \"%s\" has invalid "
2944                                       "bit offset (0x%8.8" PRIx64
2945                       ") member will be ignored. Please file a bug against the "
2946                       "compiler and include the preprocessed output for %s\n",
2947                       die.GetID(), DW_TAG_value_to_name(tag), name,
2948                       this_field_info.bit_offset,
2949                       sc.comp_unit ? sc.comp_unit->GetPath().c_str()
2950                                    : "the source file");
2951                   this_field_info.Clear();
2952                   continue;
2953                 }
2954 
2955                 // Update the field bit offset we will report for layout
2956                 field_bit_offset = this_field_info.bit_offset;
2957 
2958                 // If the member to be emitted did not start on a character
2959                 // boundary and there is empty space between the last field and
2960                 // this one, then we need to emit an anonymous member filling
2961                 // up the space up to its start.  There are three cases here:
2962                 //
2963                 // 1 If the previous member ended on a character boundary, then
2964                 // we can emit an
2965                 //   anonymous member starting at the most recent character
2966                 //   boundary.
2967                 //
2968                 // 2 If the previous member did not end on a character boundary
2969                 // and the distance
2970                 //   from the end of the previous member to the current member
2971                 //   is less than a
2972                 //   word width, then we can emit an anonymous member starting
2973                 //   right after the
2974                 //   previous member and right before this member.
2975                 //
2976                 // 3 If the previous member did not end on a character boundary
2977                 // and the distance
2978                 //   from the end of the previous member to the current member
2979                 //   is greater than
2980                 //   or equal a word width, then we act as in Case 1.
2981 
2982                 const uint64_t character_width = 8;
2983                 const uint64_t word_width = 32;
2984 
2985                 // Objective-C has invalid DW_AT_bit_offset values in older
2986                 // versions of clang, so we have to be careful and only insert
2987                 // unnamed bitfields if we have a new enough clang.
2988                 bool detect_unnamed_bitfields = true;
2989 
2990                 if (class_language == eLanguageTypeObjC ||
2991                     class_language == eLanguageTypeObjC_plus_plus)
2992                   detect_unnamed_bitfields =
2993                       die.GetCU()->Supports_unnamed_objc_bitfields();
2994 
2995                 if (detect_unnamed_bitfields) {
2996                   BitfieldInfo anon_field_info;
2997 
2998                   if ((this_field_info.bit_offset % character_width) !=
2999                       0) // not char aligned
3000                   {
3001                     uint64_t last_field_end = 0;
3002 
3003                     if (last_field_info.IsValid())
3004                       last_field_end =
3005                           last_field_info.bit_offset + last_field_info.bit_size;
3006 
3007                     if (this_field_info.bit_offset != last_field_end) {
3008                       if (((last_field_end % character_width) == 0) || // case 1
3009                           (this_field_info.bit_offset - last_field_end >=
3010                            word_width)) // case 3
3011                       {
3012                         anon_field_info.bit_size =
3013                             this_field_info.bit_offset % character_width;
3014                         anon_field_info.bit_offset =
3015                             this_field_info.bit_offset -
3016                             anon_field_info.bit_size;
3017                       } else // case 2
3018                       {
3019                         anon_field_info.bit_size =
3020                             this_field_info.bit_offset - last_field_end;
3021                         anon_field_info.bit_offset = last_field_end;
3022                       }
3023                     }
3024                   }
3025 
3026                   if (anon_field_info.IsValid()) {
3027                     clang::FieldDecl *unnamed_bitfield_decl =
3028                         ClangASTContext::AddFieldToRecordType(
3029                             class_clang_type, llvm::StringRef(),
3030                             m_ast.GetBuiltinTypeForEncodingAndBitSize(
3031                                 eEncodingSint, word_width),
3032                             accessibility, anon_field_info.bit_size);
3033 
3034                     layout_info.field_offsets.insert(std::make_pair(
3035                         unnamed_bitfield_decl, anon_field_info.bit_offset));
3036                   }
3037                 }
3038                 last_field_info = this_field_info;
3039               } else {
3040                 last_field_info.Clear();
3041               }
3042 
3043               CompilerType member_clang_type =
3044                   member_type->GetLayoutCompilerType();
3045               if (!member_clang_type.IsCompleteType())
3046                 member_clang_type.GetCompleteType();
3047 
3048               {
3049                 // Older versions of clang emit array[0] and array[1] in the
3050                 // same way (<rdar://problem/12566646>). If the current field
3051                 // is at the end of the structure, then there is definitely no
3052                 // room for extra elements and we override the type to
3053                 // array[0].
3054 
3055                 CompilerType member_array_element_type;
3056                 uint64_t member_array_size;
3057                 bool member_array_is_incomplete;
3058 
3059                 if (member_clang_type.IsArrayType(
3060                         &member_array_element_type, &member_array_size,
3061                         &member_array_is_incomplete) &&
3062                     !member_array_is_incomplete) {
3063                   uint64_t parent_byte_size =
3064                       parent_die.GetAttributeValueAsUnsigned(DW_AT_byte_size,
3065                                                              UINT64_MAX);
3066 
3067                   if (member_byte_offset >= parent_byte_size) {
3068                     if (member_array_size != 1 &&
3069                         (member_array_size != 0 ||
3070                          member_byte_offset > parent_byte_size)) {
3071                       module_sp->ReportError(
3072                           "0x%8.8" PRIx64
3073                           ": DW_TAG_member '%s' refers to type 0x%8.8" PRIx64
3074                           " which extends beyond the bounds of 0x%8.8" PRIx64,
3075                           die.GetID(), name, encoding_form.Reference(),
3076                           parent_die.GetID());
3077                     }
3078 
3079                     member_clang_type = m_ast.CreateArrayType(
3080                         member_array_element_type, 0, false);
3081                   }
3082                 }
3083               }
3084 
3085               if (ClangASTContext::IsCXXClassType(member_clang_type) &&
3086                   member_clang_type.GetCompleteType() == false) {
3087                 if (die.GetCU()->GetProducer() == eProducerClang)
3088                   module_sp->ReportError(
3089                       "DWARF DIE at 0x%8.8x (class %s) has a member variable "
3090                       "0x%8.8x (%s) whose type is a forward declaration, not a "
3091                       "complete definition.\nTry compiling the source file "
3092                       "with -fstandalone-debug",
3093                       parent_die.GetOffset(), parent_die.GetName(),
3094                       die.GetOffset(), name);
3095                 else
3096                   module_sp->ReportError(
3097                       "DWARF DIE at 0x%8.8x (class %s) has a member variable "
3098                       "0x%8.8x (%s) whose type is a forward declaration, not a "
3099                       "complete definition.\nPlease file a bug against the "
3100                       "compiler and include the preprocessed output for %s",
3101                       parent_die.GetOffset(), parent_die.GetName(),
3102                       die.GetOffset(), name,
3103                       sc.comp_unit ? sc.comp_unit->GetPath().c_str()
3104                                    : "the source file");
3105                 // We have no choice other than to pretend that the member
3106                 // class is complete. If we don't do this, clang will crash
3107                 // when trying to layout the class. Since we provide layout
3108                 // assistance, all ivars in this class and other classes will
3109                 // be fine, this is the best we can do short of crashing.
3110                 if (ClangASTContext::StartTagDeclarationDefinition(
3111                         member_clang_type)) {
3112                   ClangASTContext::CompleteTagDeclarationDefinition(
3113                       member_clang_type);
3114                 } else {
3115                   module_sp->ReportError(
3116                       "DWARF DIE at 0x%8.8x (class %s) has a member variable "
3117                       "0x%8.8x (%s) whose type claims to be a C++ class but we "
3118                       "were not able to start its definition.\nPlease file a "
3119                       "bug and attach the file at the start of this error "
3120                       "message",
3121                       parent_die.GetOffset(), parent_die.GetName(),
3122                       die.GetOffset(), name);
3123                 }
3124               }
3125 
3126               field_decl = ClangASTContext::AddFieldToRecordType(
3127                   class_clang_type, name, member_clang_type, accessibility,
3128                   bit_size);
3129 
3130               m_ast.SetMetadataAsUserID(field_decl, die.GetID());
3131 
3132               layout_info.field_offsets.insert(
3133                   std::make_pair(field_decl, field_bit_offset));
3134             } else {
3135               if (name)
3136                 module_sp->ReportError(
3137                     "0x%8.8" PRIx64
3138                     ": DW_TAG_member '%s' refers to type 0x%8.8" PRIx64
3139                     " which was unable to be parsed",
3140                     die.GetID(), name, encoding_form.Reference());
3141               else
3142                 module_sp->ReportError(
3143                     "0x%8.8" PRIx64
3144                     ": DW_TAG_member refers to type 0x%8.8" PRIx64
3145                     " which was unable to be parsed",
3146                     die.GetID(), encoding_form.Reference());
3147             }
3148           }
3149 
3150           if (prop_name != NULL && member_type) {
3151             clang::ObjCIvarDecl *ivar_decl = NULL;
3152 
3153             if (field_decl) {
3154               ivar_decl = clang::dyn_cast<clang::ObjCIvarDecl>(field_decl);
3155               assert(ivar_decl != NULL);
3156             }
3157 
3158             ClangASTMetadata metadata;
3159             metadata.SetUserID(die.GetID());
3160             delayed_properties.push_back(DelayedAddObjCClassProperty(
3161                 class_clang_type, prop_name,
3162                 member_type->GetLayoutCompilerType(), ivar_decl,
3163                 prop_setter_name, prop_getter_name, prop_attributes,
3164                 &metadata));
3165 
3166             if (ivar_decl)
3167               m_ast.SetMetadataAsUserID(ivar_decl, die.GetID());
3168           }
3169         }
3170       }
3171       ++member_idx;
3172     } break;
3173 
3174     case DW_TAG_subprogram:
3175       // Let the type parsing code handle this one for us.
3176       member_function_dies.Append(die);
3177       break;
3178 
3179     case DW_TAG_inheritance: {
3180       is_a_class = true;
3181       if (default_accessibility == eAccessNone)
3182         default_accessibility = eAccessPrivate;
3183       // TODO: implement DW_TAG_inheritance type parsing
3184       DWARFAttributes attributes;
3185       const size_t num_attributes = die.GetAttributes(attributes);
3186       if (num_attributes > 0) {
3187         Declaration decl;
3188         DWARFExpression location(die.GetCU());
3189         DWARFFormValue encoding_form;
3190         AccessType accessibility = default_accessibility;
3191         bool is_virtual = false;
3192         bool is_base_of_class = true;
3193         off_t member_byte_offset = 0;
3194         uint32_t i;
3195         for (i = 0; i < num_attributes; ++i) {
3196           const dw_attr_t attr = attributes.AttributeAtIndex(i);
3197           DWARFFormValue form_value;
3198           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
3199             switch (attr) {
3200             case DW_AT_decl_file:
3201               decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
3202                   form_value.Unsigned()));
3203               break;
3204             case DW_AT_decl_line:
3205               decl.SetLine(form_value.Unsigned());
3206               break;
3207             case DW_AT_decl_column:
3208               decl.SetColumn(form_value.Unsigned());
3209               break;
3210             case DW_AT_type:
3211               encoding_form = form_value;
3212               break;
3213             case DW_AT_data_member_location:
3214               if (form_value.BlockData()) {
3215                 Value initialValue(0);
3216                 Value memberOffset(0);
3217                 const DWARFDataExtractor &debug_info_data = die.GetData();
3218                 uint32_t block_length = form_value.Unsigned();
3219                 uint32_t block_offset =
3220                     form_value.BlockData() - debug_info_data.GetDataStart();
3221                 if (DWARFExpression::Evaluate(nullptr, nullptr, module_sp,
3222                                               debug_info_data, die.GetCU(),
3223                                               block_offset, block_length,
3224                                               eRegisterKindDWARF, &initialValue,
3225                                               nullptr, memberOffset, nullptr)) {
3226                   member_byte_offset = memberOffset.ResolveValue(NULL).UInt();
3227                 }
3228               } else {
3229                 // With DWARF 3 and later, if the value is an integer constant,
3230                 // this form value is the offset in bytes from the beginning of
3231                 // the containing entity.
3232                 member_byte_offset = form_value.Unsigned();
3233               }
3234               break;
3235 
3236             case DW_AT_accessibility:
3237               accessibility = DW_ACCESS_to_AccessType(form_value.Unsigned());
3238               break;
3239 
3240             case DW_AT_virtuality:
3241               is_virtual = form_value.Boolean();
3242               break;
3243 
3244             case DW_AT_sibling:
3245               break;
3246 
3247             default:
3248               break;
3249             }
3250           }
3251         }
3252 
3253         Type *base_class_type = die.ResolveTypeUID(DIERef(encoding_form));
3254         if (base_class_type == NULL) {
3255           module_sp->ReportError("0x%8.8x: DW_TAG_inheritance failed to "
3256                                  "resolve the base class at 0x%8.8" PRIx64
3257                                  " from enclosing type 0x%8.8x. \nPlease file "
3258                                  "a bug and attach the file at the start of "
3259                                  "this error message",
3260                                  die.GetOffset(), encoding_form.Reference(),
3261                                  parent_die.GetOffset());
3262           break;
3263         }
3264 
3265         CompilerType base_class_clang_type =
3266             base_class_type->GetFullCompilerType();
3267         assert(base_class_clang_type);
3268         if (class_language == eLanguageTypeObjC) {
3269           ast->SetObjCSuperClass(class_clang_type, base_class_clang_type);
3270         } else {
3271           std::unique_ptr<clang::CXXBaseSpecifier> result =
3272               ast->CreateBaseClassSpecifier(
3273                   base_class_clang_type.GetOpaqueQualType(), accessibility,
3274                   is_virtual, is_base_of_class);
3275           if (!result)
3276             break;
3277 
3278           base_classes.push_back(std::move(result));
3279 
3280           if (is_virtual) {
3281             // Do not specify any offset for virtual inheritance. The DWARF
3282             // produced by clang doesn't give us a constant offset, but gives
3283             // us a DWARF expressions that requires an actual object in memory.
3284             // the DW_AT_data_member_location for a virtual base class looks
3285             // like:
3286             //      DW_AT_data_member_location( DW_OP_dup, DW_OP_deref,
3287             //      DW_OP_constu(0x00000018), DW_OP_minus, DW_OP_deref,
3288             //      DW_OP_plus )
3289             // Given this, there is really no valid response we can give to
3290             // clang for virtual base class offsets, and this should eventually
3291             // be removed from LayoutRecordType() in the external
3292             // AST source in clang.
3293           } else {
3294             layout_info.base_offsets.insert(std::make_pair(
3295                 ast->GetAsCXXRecordDecl(
3296                     base_class_clang_type.GetOpaqueQualType()),
3297                 clang::CharUnits::fromQuantity(member_byte_offset)));
3298           }
3299         }
3300       }
3301     } break;
3302 
3303     default:
3304       break;
3305     }
3306   }
3307 
3308   return true;
3309 }
3310 
3311 size_t DWARFASTParserClang::ParseChildParameters(
3312     const SymbolContext &sc, clang::DeclContext *containing_decl_ctx,
3313     const DWARFDIE &parent_die, bool skip_artificial, bool &is_static,
3314     bool &is_variadic, bool &has_template_params,
3315     std::vector<CompilerType> &function_param_types,
3316     std::vector<clang::ParmVarDecl *> &function_param_decls,
3317     unsigned &type_quals) {
3318   if (!parent_die)
3319     return 0;
3320 
3321   size_t arg_idx = 0;
3322   for (DWARFDIE die = parent_die.GetFirstChild(); die.IsValid();
3323        die = die.GetSibling()) {
3324     const dw_tag_t tag = die.Tag();
3325     switch (tag) {
3326     case DW_TAG_formal_parameter: {
3327       DWARFAttributes attributes;
3328       const size_t num_attributes = die.GetAttributes(attributes);
3329       if (num_attributes > 0) {
3330         const char *name = NULL;
3331         Declaration decl;
3332         DWARFFormValue param_type_die_form;
3333         bool is_artificial = false;
3334         // one of None, Auto, Register, Extern, Static, PrivateExtern
3335 
3336         clang::StorageClass storage = clang::SC_None;
3337         uint32_t i;
3338         for (i = 0; i < num_attributes; ++i) {
3339           const dw_attr_t attr = attributes.AttributeAtIndex(i);
3340           DWARFFormValue form_value;
3341           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
3342             switch (attr) {
3343             case DW_AT_decl_file:
3344               decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
3345                   form_value.Unsigned()));
3346               break;
3347             case DW_AT_decl_line:
3348               decl.SetLine(form_value.Unsigned());
3349               break;
3350             case DW_AT_decl_column:
3351               decl.SetColumn(form_value.Unsigned());
3352               break;
3353             case DW_AT_name:
3354               name = form_value.AsCString();
3355               break;
3356             case DW_AT_type:
3357               param_type_die_form = form_value;
3358               break;
3359             case DW_AT_artificial:
3360               is_artificial = form_value.Boolean();
3361               break;
3362             case DW_AT_location:
3363             case DW_AT_const_value:
3364             case DW_AT_default_value:
3365             case DW_AT_description:
3366             case DW_AT_endianity:
3367             case DW_AT_is_optional:
3368             case DW_AT_segment:
3369             case DW_AT_variable_parameter:
3370             default:
3371             case DW_AT_abstract_origin:
3372             case DW_AT_sibling:
3373               break;
3374             }
3375           }
3376         }
3377 
3378         bool skip = false;
3379         if (skip_artificial && is_artificial) {
3380           // In order to determine if a C++ member function is "const" we
3381           // have to look at the const-ness of "this"...
3382           if (arg_idx == 0 &&
3383               DeclKindIsCXXClass(containing_decl_ctx->getDeclKind()) &&
3384               // Often times compilers omit the "this" name for the
3385               // specification DIEs, so we can't rely upon the name being in
3386               // the formal parameter DIE...
3387               (name == NULL || ::strcmp(name, "this") == 0)) {
3388             Type *this_type = die.ResolveTypeUID(DIERef(param_type_die_form));
3389             if (this_type) {
3390               uint32_t encoding_mask = this_type->GetEncodingMask();
3391               if (encoding_mask & Type::eEncodingIsPointerUID) {
3392                 is_static = false;
3393 
3394                 if (encoding_mask & (1u << Type::eEncodingIsConstUID))
3395                   type_quals |= clang::Qualifiers::Const;
3396                 if (encoding_mask & (1u << Type::eEncodingIsVolatileUID))
3397                   type_quals |= clang::Qualifiers::Volatile;
3398               }
3399             }
3400           }
3401           skip = true;
3402         }
3403 
3404         if (!skip) {
3405           Type *type = die.ResolveTypeUID(DIERef(param_type_die_form));
3406           if (type) {
3407             function_param_types.push_back(type->GetForwardCompilerType());
3408 
3409             clang::ParmVarDecl *param_var_decl =
3410                 m_ast.CreateParameterDeclaration(
3411                     name, type->GetForwardCompilerType(), storage);
3412             assert(param_var_decl);
3413             function_param_decls.push_back(param_var_decl);
3414 
3415             m_ast.SetMetadataAsUserID(param_var_decl, die.GetID());
3416           }
3417         }
3418       }
3419       arg_idx++;
3420     } break;
3421 
3422     case DW_TAG_unspecified_parameters:
3423       is_variadic = true;
3424       break;
3425 
3426     case DW_TAG_template_type_parameter:
3427     case DW_TAG_template_value_parameter:
3428     case DW_TAG_GNU_template_parameter_pack:
3429       // The one caller of this was never using the template_param_infos, and
3430       // the local variable was taking up a large amount of stack space in
3431       // SymbolFileDWARF::ParseType() so this was removed. If we ever need the
3432       // template params back, we can add them back.
3433       // ParseTemplateDIE (dwarf_cu, die, template_param_infos);
3434       has_template_params = true;
3435       break;
3436 
3437     default:
3438       break;
3439     }
3440   }
3441   return arg_idx;
3442 }
3443 
3444 llvm::Optional<SymbolFile::ArrayInfo>
3445 DWARFASTParser::ParseChildArrayInfo(const DWARFDIE &parent_die,
3446                                     const ExecutionContext *exe_ctx) {
3447   SymbolFile::ArrayInfo array_info;
3448   if (!parent_die)
3449     return llvm::None;
3450 
3451   for (DWARFDIE die = parent_die.GetFirstChild(); die.IsValid();
3452        die = die.GetSibling()) {
3453     const dw_tag_t tag = die.Tag();
3454     switch (tag) {
3455     case DW_TAG_subrange_type: {
3456       DWARFAttributes attributes;
3457       const size_t num_child_attributes = die.GetAttributes(attributes);
3458       if (num_child_attributes > 0) {
3459         uint64_t num_elements = 0;
3460         uint64_t lower_bound = 0;
3461         uint64_t upper_bound = 0;
3462         bool upper_bound_valid = false;
3463         uint32_t i;
3464         for (i = 0; i < num_child_attributes; ++i) {
3465           const dw_attr_t attr = attributes.AttributeAtIndex(i);
3466           DWARFFormValue form_value;
3467           if (attributes.ExtractFormValueAtIndex(i, form_value)) {
3468             switch (attr) {
3469             case DW_AT_name:
3470               break;
3471 
3472             case DW_AT_count:
3473               if (DWARFDIE var_die = die.GetReferencedDIE(DW_AT_count)) {
3474                 if (var_die.Tag() == DW_TAG_variable)
3475                   if (exe_ctx) {
3476                     if (auto frame = exe_ctx->GetFrameSP()) {
3477                       Status error;
3478                       lldb::VariableSP var_sp;
3479                       auto valobj_sp = frame->GetValueForVariableExpressionPath(
3480                           var_die.GetName(), eNoDynamicValues, 0, var_sp,
3481                           error);
3482                       if (valobj_sp) {
3483                         num_elements = valobj_sp->GetValueAsUnsigned(0);
3484                         break;
3485                       }
3486                     }
3487                   }
3488               } else
3489                 num_elements = form_value.Unsigned();
3490               break;
3491 
3492             case DW_AT_bit_stride:
3493               array_info.bit_stride = form_value.Unsigned();
3494               break;
3495 
3496             case DW_AT_byte_stride:
3497               array_info.byte_stride = form_value.Unsigned();
3498               break;
3499 
3500             case DW_AT_lower_bound:
3501               lower_bound = form_value.Unsigned();
3502               break;
3503 
3504             case DW_AT_upper_bound:
3505               upper_bound_valid = true;
3506               upper_bound = form_value.Unsigned();
3507               break;
3508 
3509             default:
3510             case DW_AT_abstract_origin:
3511             case DW_AT_accessibility:
3512             case DW_AT_allocated:
3513             case DW_AT_associated:
3514             case DW_AT_data_location:
3515             case DW_AT_declaration:
3516             case DW_AT_description:
3517             case DW_AT_sibling:
3518             case DW_AT_threads_scaled:
3519             case DW_AT_type:
3520             case DW_AT_visibility:
3521               break;
3522             }
3523           }
3524         }
3525 
3526         if (num_elements == 0) {
3527           if (upper_bound_valid && upper_bound >= lower_bound)
3528             num_elements = upper_bound - lower_bound + 1;
3529         }
3530 
3531         array_info.element_orders.push_back(num_elements);
3532       }
3533     } break;
3534     }
3535   }
3536   return array_info;
3537 }
3538 
3539 Type *DWARFASTParserClang::GetTypeForDIE(const DWARFDIE &die) {
3540   if (die) {
3541     SymbolFileDWARF *dwarf = die.GetDWARF();
3542     DWARFAttributes attributes;
3543     const size_t num_attributes = die.GetAttributes(attributes);
3544     if (num_attributes > 0) {
3545       DWARFFormValue type_die_form;
3546       for (size_t i = 0; i < num_attributes; ++i) {
3547         dw_attr_t attr = attributes.AttributeAtIndex(i);
3548         DWARFFormValue form_value;
3549 
3550         if (attr == DW_AT_type &&
3551             attributes.ExtractFormValueAtIndex(i, form_value))
3552           return dwarf->ResolveTypeUID(dwarf->GetDIE(DIERef(form_value)), true);
3553       }
3554     }
3555   }
3556 
3557   return nullptr;
3558 }
3559 
3560 clang::Decl *DWARFASTParserClang::GetClangDeclForDIE(const DWARFDIE &die) {
3561   if (!die)
3562     return nullptr;
3563 
3564   switch (die.Tag()) {
3565   case DW_TAG_variable:
3566   case DW_TAG_constant:
3567   case DW_TAG_formal_parameter:
3568   case DW_TAG_imported_declaration:
3569   case DW_TAG_imported_module:
3570     break;
3571   default:
3572     return nullptr;
3573   }
3574 
3575   DIEToDeclMap::iterator cache_pos = m_die_to_decl.find(die.GetDIE());
3576   if (cache_pos != m_die_to_decl.end())
3577     return cache_pos->second;
3578 
3579   if (DWARFDIE spec_die = die.GetReferencedDIE(DW_AT_specification)) {
3580     clang::Decl *decl = GetClangDeclForDIE(spec_die);
3581     m_die_to_decl[die.GetDIE()] = decl;
3582     m_decl_to_die[decl].insert(die.GetDIE());
3583     return decl;
3584   }
3585 
3586   if (DWARFDIE abstract_origin_die =
3587           die.GetReferencedDIE(DW_AT_abstract_origin)) {
3588     clang::Decl *decl = GetClangDeclForDIE(abstract_origin_die);
3589     m_die_to_decl[die.GetDIE()] = decl;
3590     m_decl_to_die[decl].insert(die.GetDIE());
3591     return decl;
3592   }
3593 
3594   clang::Decl *decl = nullptr;
3595   switch (die.Tag()) {
3596   case DW_TAG_variable:
3597   case DW_TAG_constant:
3598   case DW_TAG_formal_parameter: {
3599     SymbolFileDWARF *dwarf = die.GetDWARF();
3600     Type *type = GetTypeForDIE(die);
3601     if (dwarf && type) {
3602       const char *name = die.GetName();
3603       clang::DeclContext *decl_context =
3604           ClangASTContext::DeclContextGetAsDeclContext(
3605               dwarf->GetDeclContextContainingUID(die.GetID()));
3606       decl = m_ast.CreateVariableDeclaration(
3607           decl_context, name,
3608           ClangUtil::GetQualType(type->GetForwardCompilerType()));
3609     }
3610     break;
3611   }
3612   case DW_TAG_imported_declaration: {
3613     SymbolFileDWARF *dwarf = die.GetDWARF();
3614     DWARFDIE imported_uid = die.GetAttributeValueAsReferenceDIE(DW_AT_import);
3615     if (imported_uid) {
3616       CompilerDecl imported_decl = imported_uid.GetDecl();
3617       if (imported_decl) {
3618         clang::DeclContext *decl_context =
3619             ClangASTContext::DeclContextGetAsDeclContext(
3620                 dwarf->GetDeclContextContainingUID(die.GetID()));
3621         if (clang::NamedDecl *clang_imported_decl =
3622                 llvm::dyn_cast<clang::NamedDecl>(
3623                     (clang::Decl *)imported_decl.GetOpaqueDecl()))
3624           decl =
3625               m_ast.CreateUsingDeclaration(decl_context, clang_imported_decl);
3626       }
3627     }
3628     break;
3629   }
3630   case DW_TAG_imported_module: {
3631     SymbolFileDWARF *dwarf = die.GetDWARF();
3632     DWARFDIE imported_uid = die.GetAttributeValueAsReferenceDIE(DW_AT_import);
3633 
3634     if (imported_uid) {
3635       CompilerDeclContext imported_decl_ctx = imported_uid.GetDeclContext();
3636       if (imported_decl_ctx) {
3637         clang::DeclContext *decl_context =
3638             ClangASTContext::DeclContextGetAsDeclContext(
3639                 dwarf->GetDeclContextContainingUID(die.GetID()));
3640         if (clang::NamespaceDecl *ns_decl =
3641                 ClangASTContext::DeclContextGetAsNamespaceDecl(
3642                     imported_decl_ctx))
3643           decl = m_ast.CreateUsingDirectiveDeclaration(decl_context, ns_decl);
3644       }
3645     }
3646     break;
3647   }
3648   default:
3649     break;
3650   }
3651 
3652   m_die_to_decl[die.GetDIE()] = decl;
3653   m_decl_to_die[decl].insert(die.GetDIE());
3654 
3655   return decl;
3656 }
3657 
3658 clang::DeclContext *
3659 DWARFASTParserClang::GetClangDeclContextForDIE(const DWARFDIE &die) {
3660   if (die) {
3661     clang::DeclContext *decl_ctx = GetCachedClangDeclContextForDIE(die);
3662     if (decl_ctx)
3663       return decl_ctx;
3664 
3665     bool try_parsing_type = true;
3666     switch (die.Tag()) {
3667     case DW_TAG_compile_unit:
3668     case DW_TAG_partial_unit:
3669       decl_ctx = m_ast.GetTranslationUnitDecl();
3670       try_parsing_type = false;
3671       break;
3672 
3673     case DW_TAG_namespace:
3674       decl_ctx = ResolveNamespaceDIE(die);
3675       try_parsing_type = false;
3676       break;
3677 
3678     case DW_TAG_lexical_block:
3679       decl_ctx = GetDeclContextForBlock(die);
3680       try_parsing_type = false;
3681       break;
3682 
3683     default:
3684       break;
3685     }
3686 
3687     if (decl_ctx == nullptr && try_parsing_type) {
3688       Type *type = die.GetDWARF()->ResolveType(die);
3689       if (type)
3690         decl_ctx = GetCachedClangDeclContextForDIE(die);
3691     }
3692 
3693     if (decl_ctx) {
3694       LinkDeclContextToDIE(decl_ctx, die);
3695       return decl_ctx;
3696     }
3697   }
3698   return nullptr;
3699 }
3700 
3701 static bool IsSubroutine(const DWARFDIE &die) {
3702   switch (die.Tag()) {
3703   case DW_TAG_subprogram:
3704   case DW_TAG_inlined_subroutine:
3705     return true;
3706   default:
3707     return false;
3708   }
3709 }
3710 
3711 static DWARFDIE GetContainingFunctionWithAbstractOrigin(const DWARFDIE &die) {
3712   for (DWARFDIE candidate = die; candidate; candidate = candidate.GetParent()) {
3713     if (IsSubroutine(candidate)) {
3714       if (candidate.GetReferencedDIE(DW_AT_abstract_origin)) {
3715         return candidate;
3716       } else {
3717         return DWARFDIE();
3718       }
3719     }
3720   }
3721   assert(0 && "Shouldn't call GetContainingFunctionWithAbstractOrigin on "
3722               "something not in a function");
3723   return DWARFDIE();
3724 }
3725 
3726 static DWARFDIE FindAnyChildWithAbstractOrigin(const DWARFDIE &context) {
3727   for (DWARFDIE candidate = context.GetFirstChild(); candidate.IsValid();
3728        candidate = candidate.GetSibling()) {
3729     if (candidate.GetReferencedDIE(DW_AT_abstract_origin)) {
3730       return candidate;
3731     }
3732   }
3733   return DWARFDIE();
3734 }
3735 
3736 static DWARFDIE FindFirstChildWithAbstractOrigin(const DWARFDIE &block,
3737                                                  const DWARFDIE &function) {
3738   assert(IsSubroutine(function));
3739   for (DWARFDIE context = block; context != function.GetParent();
3740        context = context.GetParent()) {
3741     assert(!IsSubroutine(context) || context == function);
3742     if (DWARFDIE child = FindAnyChildWithAbstractOrigin(context)) {
3743       return child;
3744     }
3745   }
3746   return DWARFDIE();
3747 }
3748 
3749 clang::DeclContext *
3750 DWARFASTParserClang::GetDeclContextForBlock(const DWARFDIE &die) {
3751   assert(die.Tag() == DW_TAG_lexical_block);
3752   DWARFDIE containing_function_with_abstract_origin =
3753       GetContainingFunctionWithAbstractOrigin(die);
3754   if (!containing_function_with_abstract_origin) {
3755     return (clang::DeclContext *)ResolveBlockDIE(die);
3756   }
3757   DWARFDIE child = FindFirstChildWithAbstractOrigin(
3758       die, containing_function_with_abstract_origin);
3759   CompilerDeclContext decl_context =
3760       GetDeclContextContainingUIDFromDWARF(child);
3761   return (clang::DeclContext *)decl_context.GetOpaqueDeclContext();
3762 }
3763 
3764 clang::BlockDecl *DWARFASTParserClang::ResolveBlockDIE(const DWARFDIE &die) {
3765   if (die && die.Tag() == DW_TAG_lexical_block) {
3766     clang::BlockDecl *decl =
3767         llvm::cast_or_null<clang::BlockDecl>(m_die_to_decl_ctx[die.GetDIE()]);
3768 
3769     if (!decl) {
3770       DWARFDIE decl_context_die;
3771       clang::DeclContext *decl_context =
3772           GetClangDeclContextContainingDIE(die, &decl_context_die);
3773       decl = m_ast.CreateBlockDeclaration(decl_context);
3774 
3775       if (decl)
3776         LinkDeclContextToDIE((clang::DeclContext *)decl, die);
3777     }
3778 
3779     return decl;
3780   }
3781   return nullptr;
3782 }
3783 
3784 clang::NamespaceDecl *
3785 DWARFASTParserClang::ResolveNamespaceDIE(const DWARFDIE &die) {
3786   if (die && die.Tag() == DW_TAG_namespace) {
3787     // See if we already parsed this namespace DIE and associated it with a
3788     // uniqued namespace declaration
3789     clang::NamespaceDecl *namespace_decl =
3790         static_cast<clang::NamespaceDecl *>(m_die_to_decl_ctx[die.GetDIE()]);
3791     if (namespace_decl)
3792       return namespace_decl;
3793     else {
3794       const char *namespace_name = die.GetName();
3795       clang::DeclContext *containing_decl_ctx =
3796           GetClangDeclContextContainingDIE(die, nullptr);
3797       namespace_decl = m_ast.GetUniqueNamespaceDeclaration(namespace_name,
3798                                                            containing_decl_ctx);
3799       Log *log =
3800           nullptr; // (LogChannelDWARF::GetLogIfAll(DWARF_LOG_DEBUG_INFO));
3801       if (log) {
3802         SymbolFileDWARF *dwarf = die.GetDWARF();
3803         if (namespace_name) {
3804           dwarf->GetObjectFile()->GetModule()->LogMessage(
3805               log, "ASTContext => %p: 0x%8.8" PRIx64
3806                    ": DW_TAG_namespace with DW_AT_name(\"%s\") => "
3807                    "clang::NamespaceDecl *%p (original = %p)",
3808               static_cast<void *>(m_ast.getASTContext()), die.GetID(),
3809               namespace_name, static_cast<void *>(namespace_decl),
3810               static_cast<void *>(namespace_decl->getOriginalNamespace()));
3811         } else {
3812           dwarf->GetObjectFile()->GetModule()->LogMessage(
3813               log, "ASTContext => %p: 0x%8.8" PRIx64
3814                    ": DW_TAG_namespace (anonymous) => clang::NamespaceDecl *%p "
3815                    "(original = %p)",
3816               static_cast<void *>(m_ast.getASTContext()), die.GetID(),
3817               static_cast<void *>(namespace_decl),
3818               static_cast<void *>(namespace_decl->getOriginalNamespace()));
3819         }
3820       }
3821 
3822       if (namespace_decl)
3823         LinkDeclContextToDIE((clang::DeclContext *)namespace_decl, die);
3824       return namespace_decl;
3825     }
3826   }
3827   return nullptr;
3828 }
3829 
3830 clang::DeclContext *DWARFASTParserClang::GetClangDeclContextContainingDIE(
3831     const DWARFDIE &die, DWARFDIE *decl_ctx_die_copy) {
3832   SymbolFileDWARF *dwarf = die.GetDWARF();
3833 
3834   DWARFDIE decl_ctx_die = dwarf->GetDeclContextDIEContainingDIE(die);
3835 
3836   if (decl_ctx_die_copy)
3837     *decl_ctx_die_copy = decl_ctx_die;
3838 
3839   if (decl_ctx_die) {
3840     clang::DeclContext *clang_decl_ctx =
3841         GetClangDeclContextForDIE(decl_ctx_die);
3842     if (clang_decl_ctx)
3843       return clang_decl_ctx;
3844   }
3845   return m_ast.GetTranslationUnitDecl();
3846 }
3847 
3848 clang::DeclContext *
3849 DWARFASTParserClang::GetCachedClangDeclContextForDIE(const DWARFDIE &die) {
3850   if (die) {
3851     DIEToDeclContextMap::iterator pos = m_die_to_decl_ctx.find(die.GetDIE());
3852     if (pos != m_die_to_decl_ctx.end())
3853       return pos->second;
3854   }
3855   return nullptr;
3856 }
3857 
3858 void DWARFASTParserClang::LinkDeclContextToDIE(clang::DeclContext *decl_ctx,
3859                                                const DWARFDIE &die) {
3860   m_die_to_decl_ctx[die.GetDIE()] = decl_ctx;
3861   // There can be many DIEs for a single decl context
3862   // m_decl_ctx_to_die[decl_ctx].insert(die.GetDIE());
3863   m_decl_ctx_to_die.insert(std::make_pair(decl_ctx, die));
3864 }
3865 
3866 bool DWARFASTParserClang::CopyUniqueClassMethodTypes(
3867     const DWARFDIE &src_class_die, const DWARFDIE &dst_class_die,
3868     lldb_private::Type *class_type, DWARFDIECollection &failures) {
3869   if (!class_type || !src_class_die || !dst_class_die)
3870     return false;
3871   if (src_class_die.Tag() != dst_class_die.Tag())
3872     return false;
3873 
3874   // We need to complete the class type so we can get all of the method types
3875   // parsed so we can then unique those types to their equivalent counterparts
3876   // in "dst_cu" and "dst_class_die"
3877   class_type->GetFullCompilerType();
3878 
3879   DWARFDIE src_die;
3880   DWARFDIE dst_die;
3881   UniqueCStringMap<DWARFDIE> src_name_to_die;
3882   UniqueCStringMap<DWARFDIE> dst_name_to_die;
3883   UniqueCStringMap<DWARFDIE> src_name_to_die_artificial;
3884   UniqueCStringMap<DWARFDIE> dst_name_to_die_artificial;
3885   for (src_die = src_class_die.GetFirstChild(); src_die.IsValid();
3886        src_die = src_die.GetSibling()) {
3887     if (src_die.Tag() == DW_TAG_subprogram) {
3888       // Make sure this is a declaration and not a concrete instance by looking
3889       // for DW_AT_declaration set to 1. Sometimes concrete function instances
3890       // are placed inside the class definitions and shouldn't be included in
3891       // the list of things are are tracking here.
3892       if (src_die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0) == 1) {
3893         const char *src_name = src_die.GetMangledName();
3894         if (src_name) {
3895           ConstString src_const_name(src_name);
3896           if (src_die.GetAttributeValueAsUnsigned(DW_AT_artificial, 0))
3897             src_name_to_die_artificial.Append(src_const_name, src_die);
3898           else
3899             src_name_to_die.Append(src_const_name, src_die);
3900         }
3901       }
3902     }
3903   }
3904   for (dst_die = dst_class_die.GetFirstChild(); dst_die.IsValid();
3905        dst_die = dst_die.GetSibling()) {
3906     if (dst_die.Tag() == DW_TAG_subprogram) {
3907       // Make sure this is a declaration and not a concrete instance by looking
3908       // for DW_AT_declaration set to 1. Sometimes concrete function instances
3909       // are placed inside the class definitions and shouldn't be included in
3910       // the list of things are are tracking here.
3911       if (dst_die.GetAttributeValueAsUnsigned(DW_AT_declaration, 0) == 1) {
3912         const char *dst_name = dst_die.GetMangledName();
3913         if (dst_name) {
3914           ConstString dst_const_name(dst_name);
3915           if (dst_die.GetAttributeValueAsUnsigned(DW_AT_artificial, 0))
3916             dst_name_to_die_artificial.Append(dst_const_name, dst_die);
3917           else
3918             dst_name_to_die.Append(dst_const_name, dst_die);
3919         }
3920       }
3921     }
3922   }
3923   const uint32_t src_size = src_name_to_die.GetSize();
3924   const uint32_t dst_size = dst_name_to_die.GetSize();
3925   Log *log = nullptr; // (LogChannelDWARF::GetLogIfAny(DWARF_LOG_DEBUG_INFO |
3926                       // DWARF_LOG_TYPE_COMPLETION));
3927 
3928   // Is everything kosher so we can go through the members at top speed?
3929   bool fast_path = true;
3930 
3931   if (src_size != dst_size) {
3932     if (src_size != 0 && dst_size != 0) {
3933       if (log)
3934         log->Printf("warning: trying to unique class DIE 0x%8.8x to 0x%8.8x, "
3935                     "but they didn't have the same size (src=%d, dst=%d)",
3936                     src_class_die.GetOffset(), dst_class_die.GetOffset(),
3937                     src_size, dst_size);
3938     }
3939 
3940     fast_path = false;
3941   }
3942 
3943   uint32_t idx;
3944 
3945   if (fast_path) {
3946     for (idx = 0; idx < src_size; ++idx) {
3947       src_die = src_name_to_die.GetValueAtIndexUnchecked(idx);
3948       dst_die = dst_name_to_die.GetValueAtIndexUnchecked(idx);
3949 
3950       if (src_die.Tag() != dst_die.Tag()) {
3951         if (log)
3952           log->Printf("warning: tried to unique class DIE 0x%8.8x to 0x%8.8x, "
3953                       "but 0x%8.8x (%s) tags didn't match 0x%8.8x (%s)",
3954                       src_class_die.GetOffset(), dst_class_die.GetOffset(),
3955                       src_die.GetOffset(), src_die.GetTagAsCString(),
3956                       dst_die.GetOffset(), dst_die.GetTagAsCString());
3957         fast_path = false;
3958       }
3959 
3960       const char *src_name = src_die.GetMangledName();
3961       const char *dst_name = dst_die.GetMangledName();
3962 
3963       // Make sure the names match
3964       if (src_name == dst_name || (strcmp(src_name, dst_name) == 0))
3965         continue;
3966 
3967       if (log)
3968         log->Printf("warning: tried to unique class DIE 0x%8.8x to 0x%8.8x, "
3969                     "but 0x%8.8x (%s) names didn't match 0x%8.8x (%s)",
3970                     src_class_die.GetOffset(), dst_class_die.GetOffset(),
3971                     src_die.GetOffset(), src_name, dst_die.GetOffset(),
3972                     dst_name);
3973 
3974       fast_path = false;
3975     }
3976   }
3977 
3978   DWARFASTParserClang *src_dwarf_ast_parser =
3979       (DWARFASTParserClang *)src_die.GetDWARFParser();
3980   DWARFASTParserClang *dst_dwarf_ast_parser =
3981       (DWARFASTParserClang *)dst_die.GetDWARFParser();
3982 
3983   // Now do the work of linking the DeclContexts and Types.
3984   if (fast_path) {
3985     // We can do this quickly.  Just run across the tables index-for-index
3986     // since we know each node has matching names and tags.
3987     for (idx = 0; idx < src_size; ++idx) {
3988       src_die = src_name_to_die.GetValueAtIndexUnchecked(idx);
3989       dst_die = dst_name_to_die.GetValueAtIndexUnchecked(idx);
3990 
3991       clang::DeclContext *src_decl_ctx =
3992           src_dwarf_ast_parser->m_die_to_decl_ctx[src_die.GetDIE()];
3993       if (src_decl_ctx) {
3994         if (log)
3995           log->Printf("uniquing decl context %p from 0x%8.8x for 0x%8.8x",
3996                       static_cast<void *>(src_decl_ctx), src_die.GetOffset(),
3997                       dst_die.GetOffset());
3998         dst_dwarf_ast_parser->LinkDeclContextToDIE(src_decl_ctx, dst_die);
3999       } else {
4000         if (log)
4001           log->Printf("warning: tried to unique decl context from 0x%8.8x for "
4002                       "0x%8.8x, but none was found",
4003                       src_die.GetOffset(), dst_die.GetOffset());
4004       }
4005 
4006       Type *src_child_type =
4007           dst_die.GetDWARF()->GetDIEToType()[src_die.GetDIE()];
4008       if (src_child_type) {
4009         if (log)
4010           log->Printf(
4011               "uniquing type %p (uid=0x%" PRIx64 ") from 0x%8.8x for 0x%8.8x",
4012               static_cast<void *>(src_child_type), src_child_type->GetID(),
4013               src_die.GetOffset(), dst_die.GetOffset());
4014         dst_die.GetDWARF()->GetDIEToType()[dst_die.GetDIE()] = src_child_type;
4015       } else {
4016         if (log)
4017           log->Printf("warning: tried to unique lldb_private::Type from "
4018                       "0x%8.8x for 0x%8.8x, but none was found",
4019                       src_die.GetOffset(), dst_die.GetOffset());
4020       }
4021     }
4022   } else {
4023     // We must do this slowly.  For each member of the destination, look up a
4024     // member in the source with the same name, check its tag, and unique them
4025     // if everything matches up.  Report failures.
4026 
4027     if (!src_name_to_die.IsEmpty() && !dst_name_to_die.IsEmpty()) {
4028       src_name_to_die.Sort();
4029 
4030       for (idx = 0; idx < dst_size; ++idx) {
4031         ConstString dst_name = dst_name_to_die.GetCStringAtIndex(idx);
4032         dst_die = dst_name_to_die.GetValueAtIndexUnchecked(idx);
4033         src_die = src_name_to_die.Find(dst_name, DWARFDIE());
4034 
4035         if (src_die && (src_die.Tag() == dst_die.Tag())) {
4036           clang::DeclContext *src_decl_ctx =
4037               src_dwarf_ast_parser->m_die_to_decl_ctx[src_die.GetDIE()];
4038           if (src_decl_ctx) {
4039             if (log)
4040               log->Printf("uniquing decl context %p from 0x%8.8x for 0x%8.8x",
4041                           static_cast<void *>(src_decl_ctx),
4042                           src_die.GetOffset(), dst_die.GetOffset());
4043             dst_dwarf_ast_parser->LinkDeclContextToDIE(src_decl_ctx, dst_die);
4044           } else {
4045             if (log)
4046               log->Printf("warning: tried to unique decl context from 0x%8.8x "
4047                           "for 0x%8.8x, but none was found",
4048                           src_die.GetOffset(), dst_die.GetOffset());
4049           }
4050 
4051           Type *src_child_type =
4052               dst_die.GetDWARF()->GetDIEToType()[src_die.GetDIE()];
4053           if (src_child_type) {
4054             if (log)
4055               log->Printf("uniquing type %p (uid=0x%" PRIx64
4056                           ") from 0x%8.8x for 0x%8.8x",
4057                           static_cast<void *>(src_child_type),
4058                           src_child_type->GetID(), src_die.GetOffset(),
4059                           dst_die.GetOffset());
4060             dst_die.GetDWARF()->GetDIEToType()[dst_die.GetDIE()] =
4061                 src_child_type;
4062           } else {
4063             if (log)
4064               log->Printf("warning: tried to unique lldb_private::Type from "
4065                           "0x%8.8x for 0x%8.8x, but none was found",
4066                           src_die.GetOffset(), dst_die.GetOffset());
4067           }
4068         } else {
4069           if (log)
4070             log->Printf("warning: couldn't find a match for 0x%8.8x",
4071                         dst_die.GetOffset());
4072 
4073           failures.Append(dst_die);
4074         }
4075       }
4076     }
4077   }
4078 
4079   const uint32_t src_size_artificial = src_name_to_die_artificial.GetSize();
4080   const uint32_t dst_size_artificial = dst_name_to_die_artificial.GetSize();
4081 
4082   if (src_size_artificial && dst_size_artificial) {
4083     dst_name_to_die_artificial.Sort();
4084 
4085     for (idx = 0; idx < src_size_artificial; ++idx) {
4086       ConstString src_name_artificial =
4087           src_name_to_die_artificial.GetCStringAtIndex(idx);
4088       src_die = src_name_to_die_artificial.GetValueAtIndexUnchecked(idx);
4089       dst_die =
4090           dst_name_to_die_artificial.Find(src_name_artificial, DWARFDIE());
4091 
4092       if (dst_die) {
4093         // Both classes have the artificial types, link them
4094         clang::DeclContext *src_decl_ctx =
4095             src_dwarf_ast_parser->m_die_to_decl_ctx[src_die.GetDIE()];
4096         if (src_decl_ctx) {
4097           if (log)
4098             log->Printf("uniquing decl context %p from 0x%8.8x for 0x%8.8x",
4099                         static_cast<void *>(src_decl_ctx), src_die.GetOffset(),
4100                         dst_die.GetOffset());
4101           dst_dwarf_ast_parser->LinkDeclContextToDIE(src_decl_ctx, dst_die);
4102         } else {
4103           if (log)
4104             log->Printf("warning: tried to unique decl context from 0x%8.8x "
4105                         "for 0x%8.8x, but none was found",
4106                         src_die.GetOffset(), dst_die.GetOffset());
4107         }
4108 
4109         Type *src_child_type =
4110             dst_die.GetDWARF()->GetDIEToType()[src_die.GetDIE()];
4111         if (src_child_type) {
4112           if (log)
4113             log->Printf(
4114                 "uniquing type %p (uid=0x%" PRIx64 ") from 0x%8.8x for 0x%8.8x",
4115                 static_cast<void *>(src_child_type), src_child_type->GetID(),
4116                 src_die.GetOffset(), dst_die.GetOffset());
4117           dst_die.GetDWARF()->GetDIEToType()[dst_die.GetDIE()] = src_child_type;
4118         } else {
4119           if (log)
4120             log->Printf("warning: tried to unique lldb_private::Type from "
4121                         "0x%8.8x for 0x%8.8x, but none was found",
4122                         src_die.GetOffset(), dst_die.GetOffset());
4123         }
4124       }
4125     }
4126   }
4127 
4128   if (dst_size_artificial) {
4129     for (idx = 0; idx < dst_size_artificial; ++idx) {
4130       ConstString dst_name_artificial =
4131           dst_name_to_die_artificial.GetCStringAtIndex(idx);
4132       dst_die = dst_name_to_die_artificial.GetValueAtIndexUnchecked(idx);
4133       if (log)
4134         log->Printf("warning: need to create artificial method for 0x%8.8x for "
4135                     "method '%s'",
4136                     dst_die.GetOffset(), dst_name_artificial.GetCString());
4137 
4138       failures.Append(dst_die);
4139     }
4140   }
4141 
4142   return (failures.Size() != 0);
4143 }
4144