1 //===-- lib/Semantics/check-omp-structure.cpp -----------------------------===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 9 #include "check-omp-structure.h" 10 #include "flang/Parser/parse-tree.h" 11 #include "flang/Semantics/tools.h" 12 #include <algorithm> 13 14 namespace Fortran::semantics { 15 16 // Use when clause falls under 'struct OmpClause' in 'parse-tree.h'. 17 #define CHECK_SIMPLE_CLAUSE(X, Y) \ 18 void OmpStructureChecker::Enter(const parser::OmpClause::X &) { \ 19 CheckAllowed(llvm::omp::Clause::Y); \ 20 } 21 22 #define CHECK_REQ_CONSTANT_SCALAR_INT_CLAUSE(X, Y) \ 23 void OmpStructureChecker::Enter(const parser::OmpClause::X &c) { \ 24 CheckAllowed(llvm::omp::Clause::Y); \ 25 RequiresConstantPositiveParameter(llvm::omp::Clause::Y, c.v); \ 26 } 27 28 #define CHECK_REQ_SCALAR_INT_CLAUSE(X, Y) \ 29 void OmpStructureChecker::Enter(const parser::OmpClause::X &c) { \ 30 CheckAllowed(llvm::omp::Clause::Y); \ 31 RequiresPositiveParameter(llvm::omp::Clause::Y, c.v); \ 32 } 33 34 // Use when clause don't falls under 'struct OmpClause' in 'parse-tree.h'. 35 #define CHECK_SIMPLE_PARSER_CLAUSE(X, Y) \ 36 void OmpStructureChecker::Enter(const parser::X &) { \ 37 CheckAllowed(llvm::omp::Y); \ 38 } 39 40 // 'OmpWorkshareBlockChecker' is used to check the validity of the assignment 41 // statements and the expressions enclosed in an OpenMP Workshare construct 42 class OmpWorkshareBlockChecker { 43 public: 44 OmpWorkshareBlockChecker(SemanticsContext &context, parser::CharBlock source) 45 : context_{context}, source_{source} {} 46 47 template <typename T> bool Pre(const T &) { return true; } 48 template <typename T> void Post(const T &) {} 49 50 bool Pre(const parser::AssignmentStmt &assignment) { 51 const auto &var{std::get<parser::Variable>(assignment.t)}; 52 const auto &expr{std::get<parser::Expr>(assignment.t)}; 53 const auto *lhs{GetExpr(var)}; 54 const auto *rhs{GetExpr(expr)}; 55 if (lhs && rhs) { 56 Tristate isDefined{semantics::IsDefinedAssignment( 57 lhs->GetType(), lhs->Rank(), rhs->GetType(), rhs->Rank())}; 58 if (isDefined == Tristate::Yes) { 59 context_.Say(expr.source, 60 "Defined assignment statement is not " 61 "allowed in a WORKSHARE construct"_err_en_US); 62 } 63 } 64 return true; 65 } 66 67 bool Pre(const parser::Expr &expr) { 68 if (const auto *e{GetExpr(expr)}) { 69 for (const Symbol &symbol : evaluate::CollectSymbols(*e)) { 70 const Symbol &root{GetAssociationRoot(symbol)}; 71 if (IsFunction(root) && 72 !(root.attrs().test(Attr::ELEMENTAL) || 73 root.attrs().test(Attr::INTRINSIC))) { 74 context_.Say(expr.source, 75 "User defined non-ELEMENTAL function " 76 "'%s' is not allowed in a WORKSHARE construct"_err_en_US, 77 root.name()); 78 } 79 } 80 } 81 return false; 82 } 83 84 private: 85 SemanticsContext &context_; 86 parser::CharBlock source_; 87 }; 88 89 class OmpCycleChecker { 90 public: 91 OmpCycleChecker(SemanticsContext &context, std::int64_t cycleLevel) 92 : context_{context}, cycleLevel_{cycleLevel} {} 93 94 template <typename T> bool Pre(const T &) { return true; } 95 template <typename T> void Post(const T &) {} 96 97 bool Pre(const parser::DoConstruct &dc) { 98 cycleLevel_--; 99 const auto &labelName{std::get<0>(std::get<0>(dc.t).statement.t)}; 100 if (labelName) { 101 labelNamesandLevels_.emplace(labelName.value().ToString(), cycleLevel_); 102 } 103 return true; 104 } 105 106 bool Pre(const parser::CycleStmt &cyclestmt) { 107 std::map<std::string, std::int64_t>::iterator it; 108 bool err{false}; 109 if (cyclestmt.v) { 110 it = labelNamesandLevels_.find(cyclestmt.v->source.ToString()); 111 err = (it != labelNamesandLevels_.end() && it->second > 0); 112 } 113 if (cycleLevel_ > 0 || err) { 114 context_.Say(*cycleSource_, 115 "CYCLE statement to non-innermost associated loop of an OpenMP DO construct"_err_en_US); 116 } 117 return true; 118 } 119 120 bool Pre(const parser::Statement<parser::ActionStmt> &actionstmt) { 121 cycleSource_ = &actionstmt.source; 122 return true; 123 } 124 125 private: 126 SemanticsContext &context_; 127 const parser::CharBlock *cycleSource_; 128 std::int64_t cycleLevel_; 129 std::map<std::string, std::int64_t> labelNamesandLevels_; 130 }; 131 132 bool OmpStructureChecker::IsCloselyNestedRegion(const OmpDirectiveSet &set) { 133 // Definition of close nesting: 134 // 135 // `A region nested inside another region with no parallel region nested 136 // between them` 137 // 138 // Examples: 139 // non-parallel construct 1 140 // non-parallel construct 2 141 // parallel construct 142 // construct 3 143 // In the above example, construct 3 is NOT closely nested inside construct 1 144 // or 2 145 // 146 // non-parallel construct 1 147 // non-parallel construct 2 148 // construct 3 149 // In the above example, construct 3 is closely nested inside BOTH construct 1 150 // and 2 151 // 152 // Algorithm: 153 // Starting from the parent context, Check in a bottom-up fashion, each level 154 // of the context stack. If we have a match for one of the (supplied) 155 // violating directives, `close nesting` is satisfied. If no match is there in 156 // the entire stack, `close nesting` is not satisfied. If at any level, a 157 // `parallel` region is found, `close nesting` is not satisfied. 158 159 if (CurrentDirectiveIsNested()) { 160 int index = dirContext_.size() - 2; 161 while (index != -1) { 162 if (set.test(dirContext_[index].directive)) { 163 return true; 164 } else if (llvm::omp::parallelSet.test(dirContext_[index].directive)) { 165 return false; 166 } 167 index--; 168 } 169 } 170 return false; 171 } 172 173 bool OmpStructureChecker::HasInvalidWorksharingNesting( 174 const parser::CharBlock &source, const OmpDirectiveSet &set) { 175 // set contains all the invalid closely nested directives 176 // for the given directive (`source` here) 177 if (IsCloselyNestedRegion(set)) { 178 context_.Say(source, 179 "A worksharing region may not be closely nested inside a " 180 "worksharing, explicit task, taskloop, critical, ordered, atomic, or " 181 "master region"_err_en_US); 182 return true; 183 } 184 return false; 185 } 186 187 void OmpStructureChecker::HasInvalidDistributeNesting( 188 const parser::OpenMPLoopConstruct &x) { 189 bool violation{false}; 190 191 OmpDirectiveSet distributeSet{llvm::omp::Directive::OMPD_distribute, 192 llvm::omp::Directive::OMPD_distribute_parallel_do, 193 llvm::omp::Directive::OMPD_distribute_parallel_do_simd, 194 llvm::omp::Directive::OMPD_distribute_parallel_for, 195 llvm::omp::Directive::OMPD_distribute_parallel_for_simd, 196 llvm::omp::Directive::OMPD_distribute_simd}; 197 198 const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; 199 const auto &beginDir{std::get<parser::OmpLoopDirective>(beginLoopDir.t)}; 200 if (distributeSet.test(beginDir.v)) { 201 // `distribute` region has to be nested 202 if (!CurrentDirectiveIsNested()) { 203 violation = true; 204 } else { 205 // `distribute` region has to be strictly nested inside `teams` 206 if (!llvm::omp::teamSet.test(GetContextParent().directive)) { 207 violation = true; 208 } 209 } 210 } 211 if (violation) { 212 context_.Say(beginDir.source, 213 "`DISTRIBUTE` region has to be strictly nested inside `TEAMS` region."_err_en_US); 214 } 215 } 216 217 void OmpStructureChecker::HasInvalidTeamsNesting( 218 const llvm::omp::Directive &dir, const parser::CharBlock &source) { 219 OmpDirectiveSet allowedSet{llvm::omp::Directive::OMPD_parallel, 220 llvm::omp::Directive::OMPD_parallel_do, 221 llvm::omp::Directive::OMPD_parallel_do_simd, 222 llvm::omp::Directive::OMPD_parallel_for, 223 llvm::omp::Directive::OMPD_parallel_for_simd, 224 llvm::omp::Directive::OMPD_parallel_master, 225 llvm::omp::Directive::OMPD_parallel_master_taskloop, 226 llvm::omp::Directive::OMPD_parallel_master_taskloop_simd, 227 llvm::omp::Directive::OMPD_parallel_sections, 228 llvm::omp::Directive::OMPD_parallel_workshare, 229 llvm::omp::Directive::OMPD_distribute, 230 llvm::omp::Directive::OMPD_distribute_parallel_do, 231 llvm::omp::Directive::OMPD_distribute_parallel_do_simd, 232 llvm::omp::Directive::OMPD_distribute_parallel_for, 233 llvm::omp::Directive::OMPD_distribute_parallel_for_simd, 234 llvm::omp::Directive::OMPD_distribute_simd}; 235 236 if (!allowedSet.test(dir)) { 237 context_.Say(source, 238 "Only `DISTRIBUTE` or `PARALLEL` regions are allowed to be strictly nested inside `TEAMS` region."_err_en_US); 239 } 240 } 241 242 void OmpStructureChecker::CheckPredefinedAllocatorRestriction( 243 const parser::CharBlock &source, const parser::Name &name) { 244 if (const auto *symbol{name.symbol}) { 245 const auto *commonBlock{FindCommonBlockContaining(*symbol)}; 246 const auto &scope{context_.FindScope(symbol->name())}; 247 const Scope &containingScope{GetProgramUnitContaining(scope)}; 248 if (!isPredefinedAllocator && 249 (IsSave(*symbol) || commonBlock || 250 containingScope.kind() == Scope::Kind::Module)) { 251 context_.Say(source, 252 "If list items within the ALLOCATE directive have the " 253 "SAVE attribute, are a common block name, or are " 254 "declared in the scope of a module, then only " 255 "predefined memory allocator parameters can be used " 256 "in the allocator clause"_err_en_US); 257 } 258 } 259 } 260 261 void OmpStructureChecker::CheckPredefinedAllocatorRestriction( 262 const parser::CharBlock &source, 263 const parser::OmpObjectList &ompObjectList) { 264 for (const auto &ompObject : ompObjectList.v) { 265 std::visit( 266 common::visitors{ 267 [&](const parser::Designator &designator) { 268 if (const auto *dataRef{ 269 std::get_if<parser::DataRef>(&designator.u)}) { 270 if (const auto *name{std::get_if<parser::Name>(&dataRef->u)}) { 271 CheckPredefinedAllocatorRestriction(source, *name); 272 } 273 } 274 }, 275 [&](const parser::Name &name) { 276 CheckPredefinedAllocatorRestriction(source, name); 277 }, 278 }, 279 ompObject.u); 280 } 281 } 282 283 void OmpStructureChecker::Enter(const parser::OpenMPConstruct &x) { 284 // Simd Construct with Ordered Construct Nesting check 285 // We cannot use CurrentDirectiveIsNested() here because 286 // PushContextAndClauseSets() has not been called yet, it is 287 // called individually for each construct. Therefore a 288 // dirContext_ size `1` means the current construct is nested 289 if (dirContext_.size() >= 1) { 290 if (GetDirectiveNest(SIMDNest) > 0) { 291 CheckSIMDNest(x); 292 } 293 if (GetDirectiveNest(TargetNest) > 0) { 294 CheckTargetNest(x); 295 } 296 } 297 } 298 299 void OmpStructureChecker::Enter(const parser::OpenMPLoopConstruct &x) { 300 const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; 301 const auto &beginDir{std::get<parser::OmpLoopDirective>(beginLoopDir.t)}; 302 303 // check matching, End directive is optional 304 if (const auto &endLoopDir{ 305 std::get<std::optional<parser::OmpEndLoopDirective>>(x.t)}) { 306 const auto &endDir{ 307 std::get<parser::OmpLoopDirective>(endLoopDir.value().t)}; 308 309 CheckMatching<parser::OmpLoopDirective>(beginDir, endDir); 310 } 311 312 PushContextAndClauseSets(beginDir.source, beginDir.v); 313 if (llvm::omp::simdSet.test(GetContext().directive)) { 314 EnterDirectiveNest(SIMDNest); 315 } 316 317 if (beginDir.v == llvm::omp::Directive::OMPD_do) { 318 // 2.7.1 do-clause -> private-clause | 319 // firstprivate-clause | 320 // lastprivate-clause | 321 // linear-clause | 322 // reduction-clause | 323 // schedule-clause | 324 // collapse-clause | 325 // ordered-clause 326 327 // nesting check 328 HasInvalidWorksharingNesting( 329 beginDir.source, llvm::omp::nestedWorkshareErrSet); 330 } 331 SetLoopInfo(x); 332 333 if (const auto &doConstruct{ 334 std::get<std::optional<parser::DoConstruct>>(x.t)}) { 335 const auto &doBlock{std::get<parser::Block>(doConstruct->t)}; 336 CheckNoBranching(doBlock, beginDir.v, beginDir.source); 337 } 338 CheckDoWhile(x); 339 CheckLoopItrVariableIsInt(x); 340 CheckCycleConstraints(x); 341 HasInvalidDistributeNesting(x); 342 if (CurrentDirectiveIsNested() && 343 llvm::omp::teamSet.test(GetContextParent().directive)) { 344 HasInvalidTeamsNesting(beginDir.v, beginDir.source); 345 } 346 if ((beginDir.v == llvm::omp::Directive::OMPD_distribute_parallel_do_simd) || 347 (beginDir.v == llvm::omp::Directive::OMPD_distribute_simd)) { 348 CheckDistLinear(x); 349 } 350 } 351 const parser::Name OmpStructureChecker::GetLoopIndex( 352 const parser::DoConstruct *x) { 353 using Bounds = parser::LoopControl::Bounds; 354 return std::get<Bounds>(x->GetLoopControl()->u).name.thing; 355 } 356 void OmpStructureChecker::SetLoopInfo(const parser::OpenMPLoopConstruct &x) { 357 if (const auto &loopConstruct{ 358 std::get<std::optional<parser::DoConstruct>>(x.t)}) { 359 const parser::DoConstruct *loop{&*loopConstruct}; 360 if (loop && loop->IsDoNormal()) { 361 const parser::Name &itrVal{GetLoopIndex(loop)}; 362 SetLoopIv(itrVal.symbol); 363 } 364 } 365 } 366 void OmpStructureChecker::CheckDoWhile(const parser::OpenMPLoopConstruct &x) { 367 const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; 368 const auto &beginDir{std::get<parser::OmpLoopDirective>(beginLoopDir.t)}; 369 if (beginDir.v == llvm::omp::Directive::OMPD_do) { 370 if (const auto &doConstruct{ 371 std::get<std::optional<parser::DoConstruct>>(x.t)}) { 372 if (doConstruct.value().IsDoWhile()) { 373 const auto &doStmt{std::get<parser::Statement<parser::NonLabelDoStmt>>( 374 doConstruct.value().t)}; 375 context_.Say(doStmt.source, 376 "The DO loop cannot be a DO WHILE with DO directive."_err_en_US); 377 } 378 } 379 } 380 } 381 382 void OmpStructureChecker::CheckLoopItrVariableIsInt( 383 const parser::OpenMPLoopConstruct &x) { 384 if (const auto &loopConstruct{ 385 std::get<std::optional<parser::DoConstruct>>(x.t)}) { 386 387 for (const parser::DoConstruct *loop{&*loopConstruct}; loop;) { 388 if (loop->IsDoNormal()) { 389 const parser::Name &itrVal{GetLoopIndex(loop)}; 390 if (itrVal.symbol) { 391 const auto *type{itrVal.symbol->GetType()}; 392 if (!type->IsNumeric(TypeCategory::Integer)) { 393 context_.Say(itrVal.source, 394 "The DO loop iteration" 395 " variable must be of the type integer."_err_en_US, 396 itrVal.ToString()); 397 } 398 } 399 } 400 // Get the next DoConstruct if block is not empty. 401 const auto &block{std::get<parser::Block>(loop->t)}; 402 const auto it{block.begin()}; 403 loop = it != block.end() ? parser::Unwrap<parser::DoConstruct>(*it) 404 : nullptr; 405 } 406 } 407 } 408 409 void OmpStructureChecker::CheckSIMDNest(const parser::OpenMPConstruct &c) { 410 // Check the following: 411 // The only OpenMP constructs that can be encountered during execution of 412 // a simd region are the `atomic` construct, the `loop` construct, the `simd` 413 // construct and the `ordered` construct with the `simd` clause. 414 // TODO: Expand the check to include `LOOP` construct as well when it is 415 // supported. 416 417 // Check if the parent context has the SIMD clause 418 // Please note that we use GetContext() instead of GetContextParent() 419 // because PushContextAndClauseSets() has not been called on the 420 // current context yet. 421 // TODO: Check for declare simd regions. 422 bool eligibleSIMD{false}; 423 std::visit(Fortran::common::visitors{ 424 // Allow `!$OMP ORDERED SIMD` 425 [&](const parser::OpenMPBlockConstruct &c) { 426 const auto &beginBlockDir{ 427 std::get<parser::OmpBeginBlockDirective>(c.t)}; 428 const auto &beginDir{ 429 std::get<parser::OmpBlockDirective>(beginBlockDir.t)}; 430 if (beginDir.v == llvm::omp::Directive::OMPD_ordered) { 431 const auto &clauses{ 432 std::get<parser::OmpClauseList>(beginBlockDir.t)}; 433 for (const auto &clause : clauses.v) { 434 if (std::get_if<parser::OmpClause::Simd>(&clause.u)) { 435 eligibleSIMD = true; 436 break; 437 } 438 } 439 } 440 }, 441 [&](const parser::OpenMPSimpleStandaloneConstruct &c) { 442 const auto &dir{ 443 std::get<parser::OmpSimpleStandaloneDirective>(c.t)}; 444 if (dir.v == llvm::omp::Directive::OMPD_ordered) { 445 const auto &clauses{std::get<parser::OmpClauseList>(c.t)}; 446 for (const auto &clause : clauses.v) { 447 if (std::get_if<parser::OmpClause::Simd>(&clause.u)) { 448 eligibleSIMD = true; 449 break; 450 } 451 } 452 } 453 }, 454 // Allowing SIMD construct 455 [&](const parser::OpenMPLoopConstruct &c) { 456 const auto &beginLoopDir{ 457 std::get<parser::OmpBeginLoopDirective>(c.t)}; 458 const auto &beginDir{ 459 std::get<parser::OmpLoopDirective>(beginLoopDir.t)}; 460 if ((beginDir.v == llvm::omp::Directive::OMPD_simd) || 461 (beginDir.v == llvm::omp::Directive::OMPD_do_simd)) { 462 eligibleSIMD = true; 463 } 464 }, 465 [&](const parser::OpenMPAtomicConstruct &c) { 466 // Allow `!$OMP ATOMIC` 467 eligibleSIMD = true; 468 }, 469 [&](const auto &c) {}, 470 }, 471 c.u); 472 if (!eligibleSIMD) { 473 context_.Say(parser::FindSourceLocation(c), 474 "The only OpenMP constructs that can be encountered during execution " 475 "of a 'SIMD'" 476 " region are the `ATOMIC` construct, the `LOOP` construct, the `SIMD`" 477 " construct and the `ORDERED` construct with the `SIMD` clause."_err_en_US); 478 } 479 } 480 481 void OmpStructureChecker::CheckTargetNest(const parser::OpenMPConstruct &c) { 482 // 2.12.5 Target Construct Restriction 483 bool eligibleTarget{true}; 484 llvm::omp::Directive ineligibleTargetDir; 485 std::visit( 486 common::visitors{ 487 [&](const parser::OpenMPBlockConstruct &c) { 488 const auto &beginBlockDir{ 489 std::get<parser::OmpBeginBlockDirective>(c.t)}; 490 const auto &beginDir{ 491 std::get<parser::OmpBlockDirective>(beginBlockDir.t)}; 492 if (beginDir.v == llvm::omp::Directive::OMPD_target_data) { 493 eligibleTarget = false; 494 ineligibleTargetDir = beginDir.v; 495 } 496 }, 497 [&](const parser::OpenMPStandaloneConstruct &c) { 498 std::visit( 499 common::visitors{ 500 [&](const parser::OpenMPSimpleStandaloneConstruct &c) { 501 const auto &dir{ 502 std::get<parser::OmpSimpleStandaloneDirective>(c.t)}; 503 if (dir.v == llvm::omp::Directive::OMPD_target_update || 504 dir.v == 505 llvm::omp::Directive::OMPD_target_enter_data || 506 dir.v == 507 llvm::omp::Directive::OMPD_target_exit_data) { 508 eligibleTarget = false; 509 ineligibleTargetDir = dir.v; 510 } 511 }, 512 [&](const auto &c) {}, 513 }, 514 c.u); 515 }, 516 [&](const auto &c) {}, 517 }, 518 c.u); 519 if (!eligibleTarget) { 520 context_.Say(parser::FindSourceLocation(c), 521 "If %s directive is nested inside TARGET region, the behaviour " 522 "is unspecified"_en_US, 523 parser::ToUpperCaseLetters( 524 getDirectiveName(ineligibleTargetDir).str())); 525 } 526 } 527 528 std::int64_t OmpStructureChecker::GetOrdCollapseLevel( 529 const parser::OpenMPLoopConstruct &x) { 530 const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; 531 const auto &clauseList{std::get<parser::OmpClauseList>(beginLoopDir.t)}; 532 std::int64_t orderedCollapseLevel{1}; 533 std::int64_t orderedLevel{0}; 534 std::int64_t collapseLevel{0}; 535 536 for (const auto &clause : clauseList.v) { 537 if (const auto *collapseClause{ 538 std::get_if<parser::OmpClause::Collapse>(&clause.u)}) { 539 if (const auto v{GetIntValue(collapseClause->v)}) { 540 collapseLevel = *v; 541 } 542 } 543 if (const auto *orderedClause{ 544 std::get_if<parser::OmpClause::Ordered>(&clause.u)}) { 545 if (const auto v{GetIntValue(orderedClause->v)}) { 546 orderedLevel = *v; 547 } 548 } 549 } 550 if (orderedLevel >= collapseLevel) { 551 orderedCollapseLevel = orderedLevel; 552 } else { 553 orderedCollapseLevel = collapseLevel; 554 } 555 return orderedCollapseLevel; 556 } 557 558 void OmpStructureChecker::CheckCycleConstraints( 559 const parser::OpenMPLoopConstruct &x) { 560 std::int64_t ordCollapseLevel{GetOrdCollapseLevel(x)}; 561 OmpCycleChecker ompCycleChecker{context_, ordCollapseLevel}; 562 parser::Walk(x, ompCycleChecker); 563 } 564 565 void OmpStructureChecker::CheckDistLinear( 566 const parser::OpenMPLoopConstruct &x) { 567 568 const auto &beginLoopDir{std::get<parser::OmpBeginLoopDirective>(x.t)}; 569 const auto &clauses{std::get<parser::OmpClauseList>(beginLoopDir.t)}; 570 571 semantics::UnorderedSymbolSet indexVars; 572 573 // Collect symbols of all the variables from linear clauses 574 for (const auto &clause : clauses.v) { 575 if (const auto *linearClause{ 576 std::get_if<parser::OmpClause::Linear>(&clause.u)}) { 577 578 std::list<parser::Name> values; 579 // Get the variant type 580 if (std::holds_alternative<parser::OmpLinearClause::WithModifier>( 581 linearClause->v.u)) { 582 const auto &withM{ 583 std::get<parser::OmpLinearClause::WithModifier>(linearClause->v.u)}; 584 values = withM.names; 585 } else { 586 const auto &withOutM{std::get<parser::OmpLinearClause::WithoutModifier>( 587 linearClause->v.u)}; 588 values = withOutM.names; 589 } 590 for (auto const &v : values) { 591 indexVars.insert(*(v.symbol)); 592 } 593 } 594 } 595 596 if (!indexVars.empty()) { 597 // Get collapse level, if given, to find which loops are "associated." 598 std::int64_t collapseVal{GetOrdCollapseLevel(x)}; 599 // Include the top loop if no collapse is specified 600 if (collapseVal == 0) { 601 collapseVal = 1; 602 } 603 604 // Match the loop index variables with the collected symbols from linear 605 // clauses. 606 if (const auto &loopConstruct{ 607 std::get<std::optional<parser::DoConstruct>>(x.t)}) { 608 for (const parser::DoConstruct *loop{&*loopConstruct}; loop;) { 609 if (loop->IsDoNormal()) { 610 const parser::Name &itrVal{GetLoopIndex(loop)}; 611 if (itrVal.symbol) { 612 // Remove the symbol from the collcted set 613 indexVars.erase(*(itrVal.symbol)); 614 } 615 collapseVal--; 616 if (collapseVal == 0) { 617 break; 618 } 619 } 620 // Get the next DoConstruct if block is not empty. 621 const auto &block{std::get<parser::Block>(loop->t)}; 622 const auto it{block.begin()}; 623 loop = it != block.end() ? parser::Unwrap<parser::DoConstruct>(*it) 624 : nullptr; 625 } 626 } 627 628 // Show error for the remaining variables 629 for (auto var : indexVars) { 630 const Symbol &root{GetAssociationRoot(var)}; 631 context_.Say(parser::FindSourceLocation(x), 632 "Variable '%s' not allowed in `LINEAR` clause, only loop iterator can be specified in `LINEAR` clause of a construct combined with `DISTRIBUTE`"_err_en_US, 633 root.name()); 634 } 635 } 636 } 637 638 void OmpStructureChecker::Leave(const parser::OpenMPLoopConstruct &) { 639 if (llvm::omp::simdSet.test(GetContext().directive)) { 640 ExitDirectiveNest(SIMDNest); 641 } 642 dirContext_.pop_back(); 643 } 644 645 void OmpStructureChecker::Enter(const parser::OmpEndLoopDirective &x) { 646 const auto &dir{std::get<parser::OmpLoopDirective>(x.t)}; 647 ResetPartialContext(dir.source); 648 switch (dir.v) { 649 // 2.7.1 end-do -> END DO [nowait-clause] 650 // 2.8.3 end-do-simd -> END DO SIMD [nowait-clause] 651 case llvm::omp::Directive::OMPD_do: 652 case llvm::omp::Directive::OMPD_do_simd: 653 SetClauseSets(dir.v); 654 break; 655 default: 656 // no clauses are allowed 657 break; 658 } 659 } 660 661 void OmpStructureChecker::Enter(const parser::OpenMPBlockConstruct &x) { 662 const auto &beginBlockDir{std::get<parser::OmpBeginBlockDirective>(x.t)}; 663 const auto &endBlockDir{std::get<parser::OmpEndBlockDirective>(x.t)}; 664 const auto &beginDir{std::get<parser::OmpBlockDirective>(beginBlockDir.t)}; 665 const auto &endDir{std::get<parser::OmpBlockDirective>(endBlockDir.t)}; 666 const parser::Block &block{std::get<parser::Block>(x.t)}; 667 668 CheckMatching<parser::OmpBlockDirective>(beginDir, endDir); 669 670 PushContextAndClauseSets(beginDir.source, beginDir.v); 671 if (GetContext().directive == llvm::omp::Directive::OMPD_target) { 672 EnterDirectiveNest(TargetNest); 673 } 674 675 if (CurrentDirectiveIsNested()) { 676 CheckIfDoOrderedClause(beginDir); 677 if (llvm::omp::teamSet.test(GetContextParent().directive)) { 678 HasInvalidTeamsNesting(beginDir.v, beginDir.source); 679 } 680 if (GetContext().directive == llvm::omp::Directive::OMPD_master) { 681 CheckMasterNesting(x); 682 } 683 // A teams region can only be strictly nested within the implicit parallel 684 // region or a target region. 685 if (GetContext().directive == llvm::omp::Directive::OMPD_teams && 686 GetContextParent().directive != llvm::omp::Directive::OMPD_target) { 687 context_.Say(parser::FindSourceLocation(x), 688 "%s region can only be strictly nested within the implicit parallel " 689 "region or TARGET region"_err_en_US, 690 ContextDirectiveAsFortran()); 691 } 692 // If a teams construct is nested within a target construct, that target 693 // construct must contain no statements, declarations or directives outside 694 // of the teams construct. 695 if (GetContext().directive == llvm::omp::Directive::OMPD_teams && 696 GetContextParent().directive == llvm::omp::Directive::OMPD_target && 697 !GetDirectiveNest(TargetBlockOnlyTeams)) { 698 context_.Say(GetContextParent().directiveSource, 699 "TARGET construct with nested TEAMS region contains statements or " 700 "directives outside of the TEAMS construct"_err_en_US); 701 } 702 } 703 704 CheckNoBranching(block, beginDir.v, beginDir.source); 705 706 switch (beginDir.v) { 707 case llvm::omp::Directive::OMPD_target: 708 if (CheckTargetBlockOnlyTeams(block)) { 709 EnterDirectiveNest(TargetBlockOnlyTeams); 710 } 711 break; 712 case llvm::omp::OMPD_workshare: 713 case llvm::omp::OMPD_parallel_workshare: 714 CheckWorkshareBlockStmts(block, beginDir.source); 715 HasInvalidWorksharingNesting( 716 beginDir.source, llvm::omp::nestedWorkshareErrSet); 717 break; 718 case llvm::omp::Directive::OMPD_single: 719 // TODO: This check needs to be extended while implementing nesting of 720 // regions checks. 721 HasInvalidWorksharingNesting( 722 beginDir.source, llvm::omp::nestedWorkshareErrSet); 723 break; 724 default: 725 break; 726 } 727 } 728 729 void OmpStructureChecker::CheckMasterNesting( 730 const parser::OpenMPBlockConstruct &x) { 731 // A MASTER region may not be `closely nested` inside a worksharing, loop, 732 // task, taskloop, or atomic region. 733 // TODO: Expand the check to include `LOOP` construct as well when it is 734 // supported. 735 if (IsCloselyNestedRegion(llvm::omp::nestedMasterErrSet)) { 736 context_.Say(parser::FindSourceLocation(x), 737 "`MASTER` region may not be closely nested inside of `WORKSHARING`, " 738 "`LOOP`, `TASK`, `TASKLOOP`," 739 " or `ATOMIC` region."_err_en_US); 740 } 741 } 742 743 void OmpStructureChecker::CheckIfDoOrderedClause( 744 const parser::OmpBlockDirective &blkDirective) { 745 if (blkDirective.v == llvm::omp::OMPD_ordered) { 746 // Loops 747 if (llvm::omp::doSet.test(GetContextParent().directive) && 748 !FindClauseParent(llvm::omp::Clause::OMPC_ordered)) { 749 context_.Say(blkDirective.source, 750 "The ORDERED clause must be present on the loop" 751 " construct if any ORDERED region ever binds" 752 " to a loop region arising from the loop construct."_err_en_US); 753 } 754 // Other disallowed nestings, these directives do not support 755 // ordered clause in them, so no need to check 756 else if (IsCloselyNestedRegion(llvm::omp::nestedOrderedErrSet)) { 757 context_.Say(blkDirective.source, 758 "`ORDERED` region may not be closely nested inside of " 759 "`CRITICAL`, `ORDERED`, explicit `TASK` or `TASKLOOP` region."_err_en_US); 760 } 761 } 762 } 763 764 void OmpStructureChecker::Leave(const parser::OpenMPBlockConstruct &) { 765 if (GetDirectiveNest(TargetBlockOnlyTeams)) { 766 ExitDirectiveNest(TargetBlockOnlyTeams); 767 } 768 if (GetContext().directive == llvm::omp::Directive::OMPD_target) { 769 ExitDirectiveNest(TargetNest); 770 } 771 dirContext_.pop_back(); 772 } 773 774 void OmpStructureChecker::ChecksOnOrderedAsBlock() { 775 if (FindClause(llvm::omp::Clause::OMPC_depend)) { 776 context_.Say(GetContext().clauseSource, 777 "DEPEND(*) clauses are not allowed when ORDERED construct is a block" 778 " construct with an ORDERED region"_err_en_US); 779 } 780 } 781 782 void OmpStructureChecker::Leave(const parser::OmpBeginBlockDirective &) { 783 switch (GetContext().directive) { 784 case llvm::omp::Directive::OMPD_ordered: 785 // [5.1] 2.19.9 Ordered Construct Restriction 786 ChecksOnOrderedAsBlock(); 787 break; 788 default: 789 break; 790 } 791 } 792 793 void OmpStructureChecker::Enter(const parser::OpenMPSectionsConstruct &x) { 794 const auto &beginSectionsDir{ 795 std::get<parser::OmpBeginSectionsDirective>(x.t)}; 796 const auto &endSectionsDir{std::get<parser::OmpEndSectionsDirective>(x.t)}; 797 const auto &beginDir{ 798 std::get<parser::OmpSectionsDirective>(beginSectionsDir.t)}; 799 const auto &endDir{std::get<parser::OmpSectionsDirective>(endSectionsDir.t)}; 800 CheckMatching<parser::OmpSectionsDirective>(beginDir, endDir); 801 802 PushContextAndClauseSets(beginDir.source, beginDir.v); 803 const auto §ionBlocks{std::get<parser::OmpSectionBlocks>(x.t)}; 804 for (const auto &block : sectionBlocks.v) { 805 CheckNoBranching(block, beginDir.v, beginDir.source); 806 } 807 HasInvalidWorksharingNesting( 808 beginDir.source, llvm::omp::nestedWorkshareErrSet); 809 } 810 811 void OmpStructureChecker::Leave(const parser::OpenMPSectionsConstruct &) { 812 dirContext_.pop_back(); 813 } 814 815 void OmpStructureChecker::Enter(const parser::OmpEndSectionsDirective &x) { 816 const auto &dir{std::get<parser::OmpSectionsDirective>(x.t)}; 817 ResetPartialContext(dir.source); 818 switch (dir.v) { 819 // 2.7.2 end-sections -> END SECTIONS [nowait-clause] 820 case llvm::omp::Directive::OMPD_sections: 821 PushContextAndClauseSets( 822 dir.source, llvm::omp::Directive::OMPD_end_sections); 823 break; 824 default: 825 // no clauses are allowed 826 break; 827 } 828 } 829 830 // TODO: Verify the popping of dirContext requirement after nowait 831 // implementation, as there is an implicit barrier at the end of the worksharing 832 // constructs unless a nowait clause is specified. Only OMPD_end_sections is 833 // popped becuase it is pushed while entering the EndSectionsDirective. 834 void OmpStructureChecker::Leave(const parser::OmpEndSectionsDirective &x) { 835 if (GetContext().directive == llvm::omp::Directive::OMPD_end_sections) { 836 dirContext_.pop_back(); 837 } 838 } 839 840 void OmpStructureChecker::Enter(const parser::OpenMPThreadprivate &c) { 841 const auto &dir{std::get<parser::Verbatim>(c.t)}; 842 PushContextAndClauseSets( 843 dir.source, llvm::omp::Directive::OMPD_threadprivate); 844 } 845 846 void OmpStructureChecker::Leave(const parser::OpenMPThreadprivate &c) { 847 const auto &dir{std::get<parser::Verbatim>(c.t)}; 848 const auto &objectList{std::get<parser::OmpObjectList>(c.t)}; 849 CheckIsVarPartOfAnotherVar(dir.source, objectList); 850 dirContext_.pop_back(); 851 } 852 853 void OmpStructureChecker::Enter(const parser::OpenMPDeclareSimdConstruct &x) { 854 const auto &dir{std::get<parser::Verbatim>(x.t)}; 855 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_declare_simd); 856 } 857 858 void OmpStructureChecker::Leave(const parser::OpenMPDeclareSimdConstruct &) { 859 dirContext_.pop_back(); 860 } 861 862 void OmpStructureChecker::Enter(const parser::OpenMPDeclarativeAllocate &x) { 863 isPredefinedAllocator = true; 864 const auto &dir{std::get<parser::Verbatim>(x.t)}; 865 const auto &objectList{std::get<parser::OmpObjectList>(x.t)}; 866 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_allocate); 867 CheckIsVarPartOfAnotherVar(dir.source, objectList); 868 } 869 870 void OmpStructureChecker::Leave(const parser::OpenMPDeclarativeAllocate &x) { 871 const auto &dir{std::get<parser::Verbatim>(x.t)}; 872 const auto &objectList{std::get<parser::OmpObjectList>(x.t)}; 873 CheckPredefinedAllocatorRestriction(dir.source, objectList); 874 dirContext_.pop_back(); 875 } 876 877 void OmpStructureChecker::Enter(const parser::OmpClause::Allocator &x) { 878 CheckAllowed(llvm::omp::Clause::OMPC_allocator); 879 // Note: Predefined allocators are stored in ScalarExpr as numbers 880 // whereas custom allocators are stored as strings, so if the ScalarExpr 881 // actually has an int value, then it must be a predefined allocator 882 isPredefinedAllocator = GetIntValue(x.v).has_value(); 883 RequiresPositiveParameter(llvm::omp::Clause::OMPC_allocator, x.v); 884 } 885 886 void OmpStructureChecker::Enter(const parser::OpenMPDeclareTargetConstruct &x) { 887 const auto &dir{std::get<parser::Verbatim>(x.t)}; 888 PushContext(dir.source, llvm::omp::Directive::OMPD_declare_target); 889 const auto &spec{std::get<parser::OmpDeclareTargetSpecifier>(x.t)}; 890 if (std::holds_alternative<parser::OmpDeclareTargetWithClause>(spec.u)) { 891 SetClauseSets(llvm::omp::Directive::OMPD_declare_target); 892 } 893 } 894 895 void OmpStructureChecker::Leave(const parser::OpenMPDeclareTargetConstruct &) { 896 dirContext_.pop_back(); 897 } 898 899 void OmpStructureChecker::Enter(const parser::OpenMPExecutableAllocate &x) { 900 isPredefinedAllocator = true; 901 const auto &dir{std::get<parser::Verbatim>(x.t)}; 902 const auto &objectList{std::get<std::optional<parser::OmpObjectList>>(x.t)}; 903 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_allocate); 904 if (objectList) { 905 CheckIsVarPartOfAnotherVar(dir.source, *objectList); 906 } 907 } 908 909 void OmpStructureChecker::Leave(const parser::OpenMPExecutableAllocate &x) { 910 const auto &dir{std::get<parser::Verbatim>(x.t)}; 911 const auto &objectList{std::get<std::optional<parser::OmpObjectList>>(x.t)}; 912 if (objectList) 913 CheckPredefinedAllocatorRestriction(dir.source, *objectList); 914 dirContext_.pop_back(); 915 } 916 917 void OmpStructureChecker::CheckBarrierNesting( 918 const parser::OpenMPSimpleStandaloneConstruct &x) { 919 // A barrier region may not be `closely nested` inside a worksharing, loop, 920 // task, taskloop, critical, ordered, atomic, or master region. 921 // TODO: Expand the check to include `LOOP` construct as well when it is 922 // supported. 923 if (GetContext().directive == llvm::omp::Directive::OMPD_barrier) { 924 if (IsCloselyNestedRegion(llvm::omp::nestedBarrierErrSet)) { 925 context_.Say(parser::FindSourceLocation(x), 926 "`BARRIER` region may not be closely nested inside of `WORKSHARING`, " 927 "`LOOP`, `TASK`, `TASKLOOP`," 928 "`CRITICAL`, `ORDERED`, `ATOMIC` or `MASTER` region."_err_en_US); 929 } 930 } 931 } 932 933 void OmpStructureChecker::ChecksOnOrderedAsStandalone() { 934 if (FindClause(llvm::omp::Clause::OMPC_threads) || 935 FindClause(llvm::omp::Clause::OMPC_simd)) { 936 context_.Say(GetContext().clauseSource, 937 "THREADS, SIMD clauses are not allowed when ORDERED construct is a " 938 "standalone construct with no ORDERED region"_err_en_US); 939 } 940 941 bool isSinkPresent{false}; 942 int dependSourceCount{0}; 943 auto clauseAll = FindClauses(llvm::omp::Clause::OMPC_depend); 944 for (auto itr = clauseAll.first; itr != clauseAll.second; ++itr) { 945 const auto &dependClause{ 946 std::get<parser::OmpClause::Depend>(itr->second->u)}; 947 if (std::get_if<parser::OmpDependClause::Source>(&dependClause.v.u)) { 948 dependSourceCount++; 949 if (isSinkPresent) { 950 context_.Say(itr->second->source, 951 "DEPEND(SOURCE) is not allowed when DEPEND(SINK: vec) is present " 952 "on ORDERED directive"_err_en_US); 953 } 954 if (dependSourceCount > 1) { 955 context_.Say(itr->second->source, 956 "At most one DEPEND(SOURCE) clause can appear on the ORDERED " 957 "directive"_err_en_US); 958 } 959 } else if (std::get_if<parser::OmpDependClause::Sink>(&dependClause.v.u)) { 960 isSinkPresent = true; 961 if (dependSourceCount > 0) { 962 context_.Say(itr->second->source, 963 "DEPEND(SINK: vec) is not allowed when DEPEND(SOURCE) is present " 964 "on ORDERED directive"_err_en_US); 965 } 966 } else { 967 context_.Say(itr->second->source, 968 "Only DEPEND(SOURCE) or DEPEND(SINK: vec) are allowed when ORDERED " 969 "construct is a standalone construct with no ORDERED " 970 "region"_err_en_US); 971 } 972 } 973 } 974 975 void OmpStructureChecker::Enter( 976 const parser::OpenMPSimpleStandaloneConstruct &x) { 977 const auto &dir{std::get<parser::OmpSimpleStandaloneDirective>(x.t)}; 978 PushContextAndClauseSets(dir.source, dir.v); 979 CheckBarrierNesting(x); 980 } 981 982 void OmpStructureChecker::Leave( 983 const parser::OpenMPSimpleStandaloneConstruct &) { 984 switch (GetContext().directive) { 985 case llvm::omp::Directive::OMPD_ordered: 986 // [5.1] 2.19.9 Ordered Construct Restriction 987 ChecksOnOrderedAsStandalone(); 988 break; 989 default: 990 break; 991 } 992 dirContext_.pop_back(); 993 } 994 995 void OmpStructureChecker::Enter(const parser::OpenMPFlushConstruct &x) { 996 const auto &dir{std::get<parser::Verbatim>(x.t)}; 997 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_flush); 998 } 999 1000 void OmpStructureChecker::Leave(const parser::OpenMPFlushConstruct &x) { 1001 if (FindClause(llvm::omp::Clause::OMPC_acquire) || 1002 FindClause(llvm::omp::Clause::OMPC_release) || 1003 FindClause(llvm::omp::Clause::OMPC_acq_rel)) { 1004 if (const auto &flushList{ 1005 std::get<std::optional<parser::OmpObjectList>>(x.t)}) { 1006 context_.Say(parser::FindSourceLocation(flushList), 1007 "If memory-order-clause is RELEASE, ACQUIRE, or ACQ_REL, list items " 1008 "must not be specified on the FLUSH directive"_err_en_US); 1009 } 1010 } 1011 dirContext_.pop_back(); 1012 } 1013 1014 void OmpStructureChecker::Enter(const parser::OpenMPCancelConstruct &x) { 1015 const auto &dir{std::get<parser::Verbatim>(x.t)}; 1016 const auto &type{std::get<parser::OmpCancelType>(x.t)}; 1017 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_cancel); 1018 CheckCancellationNest(dir.source, type.v); 1019 } 1020 1021 void OmpStructureChecker::Leave(const parser::OpenMPCancelConstruct &) { 1022 dirContext_.pop_back(); 1023 } 1024 1025 void OmpStructureChecker::Enter(const parser::OpenMPCriticalConstruct &x) { 1026 const auto &dir{std::get<parser::OmpCriticalDirective>(x.t)}; 1027 const auto &endDir{std::get<parser::OmpEndCriticalDirective>(x.t)}; 1028 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_critical); 1029 const auto &block{std::get<parser::Block>(x.t)}; 1030 CheckNoBranching(block, llvm::omp::Directive::OMPD_critical, dir.source); 1031 const auto &dirName{std::get<std::optional<parser::Name>>(dir.t)}; 1032 const auto &endDirName{std::get<std::optional<parser::Name>>(endDir.t)}; 1033 const auto &ompClause{std::get<parser::OmpClauseList>(dir.t)}; 1034 if (dirName && endDirName && 1035 dirName->ToString().compare(endDirName->ToString())) { 1036 context_ 1037 .Say(endDirName->source, 1038 parser::MessageFormattedText{ 1039 "CRITICAL directive names do not match"_err_en_US}) 1040 .Attach(dirName->source, "should be "_en_US); 1041 } else if (dirName && !endDirName) { 1042 context_ 1043 .Say(dirName->source, 1044 parser::MessageFormattedText{ 1045 "CRITICAL directive names do not match"_err_en_US}) 1046 .Attach(dirName->source, "should be NULL"_en_US); 1047 } else if (!dirName && endDirName) { 1048 context_ 1049 .Say(endDirName->source, 1050 parser::MessageFormattedText{ 1051 "CRITICAL directive names do not match"_err_en_US}) 1052 .Attach(endDirName->source, "should be NULL"_en_US); 1053 } 1054 if (!dirName && !ompClause.source.empty() && 1055 ompClause.source.NULTerminatedToString() != "hint(omp_sync_hint_none)") { 1056 context_.Say(dir.source, 1057 parser::MessageFormattedText{ 1058 "Hint clause other than omp_sync_hint_none cannot be specified for an unnamed CRITICAL directive"_err_en_US}); 1059 } 1060 } 1061 1062 void OmpStructureChecker::Leave(const parser::OpenMPCriticalConstruct &) { 1063 dirContext_.pop_back(); 1064 } 1065 1066 void OmpStructureChecker::Enter( 1067 const parser::OpenMPCancellationPointConstruct &x) { 1068 const auto &dir{std::get<parser::Verbatim>(x.t)}; 1069 const auto &type{std::get<parser::OmpCancelType>(x.t)}; 1070 PushContextAndClauseSets( 1071 dir.source, llvm::omp::Directive::OMPD_cancellation_point); 1072 CheckCancellationNest(dir.source, type.v); 1073 } 1074 1075 void OmpStructureChecker::Leave( 1076 const parser::OpenMPCancellationPointConstruct &) { 1077 dirContext_.pop_back(); 1078 } 1079 1080 void OmpStructureChecker::CheckCancellationNest( 1081 const parser::CharBlock &source, const parser::OmpCancelType::Type &type) { 1082 if (CurrentDirectiveIsNested()) { 1083 // If construct-type-clause is taskgroup, the cancellation construct must be 1084 // closely nested inside a task or a taskloop construct and the cancellation 1085 // region must be closely nested inside a taskgroup region. If 1086 // construct-type-clause is sections, the cancellation construct must be 1087 // closely nested inside a sections or section construct. Otherwise, the 1088 // cancellation construct must be closely nested inside an OpenMP construct 1089 // that matches the type specified in construct-type-clause of the 1090 // cancellation construct. 1091 1092 OmpDirectiveSet allowedTaskgroupSet{ 1093 llvm::omp::Directive::OMPD_task, llvm::omp::Directive::OMPD_taskloop}; 1094 OmpDirectiveSet allowedSectionsSet{llvm::omp::Directive::OMPD_sections, 1095 llvm::omp::Directive::OMPD_parallel_sections}; 1096 OmpDirectiveSet allowedDoSet{llvm::omp::Directive::OMPD_do, 1097 llvm::omp::Directive::OMPD_distribute_parallel_do, 1098 llvm::omp::Directive::OMPD_parallel_do, 1099 llvm::omp::Directive::OMPD_target_parallel_do, 1100 llvm::omp::Directive::OMPD_target_teams_distribute_parallel_do, 1101 llvm::omp::Directive::OMPD_teams_distribute_parallel_do}; 1102 OmpDirectiveSet allowedParallelSet{llvm::omp::Directive::OMPD_parallel, 1103 llvm::omp::Directive::OMPD_target_parallel}; 1104 1105 bool eligibleCancellation{false}; 1106 switch (type) { 1107 case parser::OmpCancelType::Type::Taskgroup: 1108 if (allowedTaskgroupSet.test(GetContextParent().directive)) { 1109 eligibleCancellation = true; 1110 if (dirContext_.size() >= 3) { 1111 // Check if the cancellation region is closely nested inside a 1112 // taskgroup region when there are more than two levels of directives 1113 // in the directive context stack. 1114 if (GetContextParent().directive == llvm::omp::Directive::OMPD_task || 1115 FindClauseParent(llvm::omp::Clause::OMPC_nogroup)) { 1116 for (int i = dirContext_.size() - 3; i >= 0; i--) { 1117 if (dirContext_[i].directive == 1118 llvm::omp::Directive::OMPD_taskgroup) { 1119 break; 1120 } 1121 if (allowedParallelSet.test(dirContext_[i].directive)) { 1122 eligibleCancellation = false; 1123 break; 1124 } 1125 } 1126 } 1127 } 1128 } 1129 if (!eligibleCancellation) { 1130 context_.Say(source, 1131 "With %s clause, %s construct must be closely nested inside TASK " 1132 "or TASKLOOP construct and %s region must be closely nested inside " 1133 "TASKGROUP region"_err_en_US, 1134 parser::ToUpperCaseLetters( 1135 parser::OmpCancelType::EnumToString(type)), 1136 ContextDirectiveAsFortran(), ContextDirectiveAsFortran()); 1137 } 1138 return; 1139 case parser::OmpCancelType::Type::Sections: 1140 if (allowedSectionsSet.test(GetContextParent().directive)) { 1141 eligibleCancellation = true; 1142 } 1143 break; 1144 case Fortran::parser::OmpCancelType::Type::Do: 1145 if (allowedDoSet.test(GetContextParent().directive)) { 1146 eligibleCancellation = true; 1147 } 1148 break; 1149 case parser::OmpCancelType::Type::Parallel: 1150 if (allowedParallelSet.test(GetContextParent().directive)) { 1151 eligibleCancellation = true; 1152 } 1153 break; 1154 } 1155 if (!eligibleCancellation) { 1156 context_.Say(source, 1157 "With %s clause, %s construct cannot be closely nested inside %s " 1158 "construct"_err_en_US, 1159 parser::ToUpperCaseLetters(parser::OmpCancelType::EnumToString(type)), 1160 ContextDirectiveAsFortran(), 1161 parser::ToUpperCaseLetters( 1162 getDirectiveName(GetContextParent().directive).str())); 1163 } 1164 } else { 1165 // The cancellation directive cannot be orphaned. 1166 switch (type) { 1167 case parser::OmpCancelType::Type::Taskgroup: 1168 context_.Say(source, 1169 "%s %s directive is not closely nested inside " 1170 "TASK or TASKLOOP"_err_en_US, 1171 ContextDirectiveAsFortran(), 1172 parser::ToUpperCaseLetters( 1173 parser::OmpCancelType::EnumToString(type))); 1174 break; 1175 case parser::OmpCancelType::Type::Sections: 1176 context_.Say(source, 1177 "%s %s directive is not closely nested inside " 1178 "SECTION or SECTIONS"_err_en_US, 1179 ContextDirectiveAsFortran(), 1180 parser::ToUpperCaseLetters( 1181 parser::OmpCancelType::EnumToString(type))); 1182 break; 1183 case Fortran::parser::OmpCancelType::Type::Do: 1184 context_.Say(source, 1185 "%s %s directive is not closely nested inside " 1186 "the construct that matches the DO clause type"_err_en_US, 1187 ContextDirectiveAsFortran(), 1188 parser::ToUpperCaseLetters( 1189 parser::OmpCancelType::EnumToString(type))); 1190 break; 1191 case parser::OmpCancelType::Type::Parallel: 1192 context_.Say(source, 1193 "%s %s directive is not closely nested inside " 1194 "the construct that matches the PARALLEL clause type"_err_en_US, 1195 ContextDirectiveAsFortran(), 1196 parser::ToUpperCaseLetters( 1197 parser::OmpCancelType::EnumToString(type))); 1198 break; 1199 } 1200 } 1201 } 1202 1203 void OmpStructureChecker::Enter(const parser::OmpEndBlockDirective &x) { 1204 const auto &dir{std::get<parser::OmpBlockDirective>(x.t)}; 1205 ResetPartialContext(dir.source); 1206 switch (dir.v) { 1207 // 2.7.3 end-single-clause -> copyprivate-clause | 1208 // nowait-clause 1209 case llvm::omp::Directive::OMPD_single: 1210 PushContextAndClauseSets(dir.source, llvm::omp::Directive::OMPD_end_single); 1211 break; 1212 // 2.7.4 end-workshare -> END WORKSHARE [nowait-clause] 1213 case llvm::omp::Directive::OMPD_workshare: 1214 PushContextAndClauseSets( 1215 dir.source, llvm::omp::Directive::OMPD_end_workshare); 1216 break; 1217 default: 1218 // no clauses are allowed 1219 break; 1220 } 1221 } 1222 1223 // TODO: Verify the popping of dirContext requirement after nowait 1224 // implementation, as there is an implicit barrier at the end of the worksharing 1225 // constructs unless a nowait clause is specified. Only OMPD_end_single and 1226 // end_workshareare popped as they are pushed while entering the 1227 // EndBlockDirective. 1228 void OmpStructureChecker::Leave(const parser::OmpEndBlockDirective &x) { 1229 if ((GetContext().directive == llvm::omp::Directive::OMPD_end_single) || 1230 (GetContext().directive == llvm::omp::Directive::OMPD_end_workshare)) { 1231 dirContext_.pop_back(); 1232 } 1233 } 1234 1235 void OmpStructureChecker::Enter(const parser::OpenMPAtomicConstruct &x) { 1236 std::visit( 1237 common::visitors{ 1238 [&](const auto &someAtomicConstruct) { 1239 const auto &dir{std::get<parser::Verbatim>(someAtomicConstruct.t)}; 1240 PushContextAndClauseSets( 1241 dir.source, llvm::omp::Directive::OMPD_atomic); 1242 }, 1243 }, 1244 x.u); 1245 } 1246 1247 void OmpStructureChecker::Leave(const parser::OpenMPAtomicConstruct &) { 1248 dirContext_.pop_back(); 1249 } 1250 1251 // Clauses 1252 // Mainly categorized as 1253 // 1. Checks on 'OmpClauseList' from 'parse-tree.h'. 1254 // 2. Checks on clauses which fall under 'struct OmpClause' from parse-tree.h. 1255 // 3. Checks on clauses which are not in 'struct OmpClause' from parse-tree.h. 1256 1257 void OmpStructureChecker::Leave(const parser::OmpClauseList &) { 1258 // 2.7.1 Loop Construct Restriction 1259 if (llvm::omp::doSet.test(GetContext().directive)) { 1260 if (auto *clause{FindClause(llvm::omp::Clause::OMPC_schedule)}) { 1261 // only one schedule clause is allowed 1262 const auto &schedClause{std::get<parser::OmpClause::Schedule>(clause->u)}; 1263 if (ScheduleModifierHasType(schedClause.v, 1264 parser::OmpScheduleModifierType::ModType::Nonmonotonic)) { 1265 if (FindClause(llvm::omp::Clause::OMPC_ordered)) { 1266 context_.Say(clause->source, 1267 "The NONMONOTONIC modifier cannot be specified " 1268 "if an ORDERED clause is specified"_err_en_US); 1269 } 1270 if (ScheduleModifierHasType(schedClause.v, 1271 parser::OmpScheduleModifierType::ModType::Monotonic)) { 1272 context_.Say(clause->source, 1273 "The MONOTONIC and NONMONOTONIC modifiers " 1274 "cannot be both specified"_err_en_US); 1275 } 1276 } 1277 } 1278 1279 if (auto *clause{FindClause(llvm::omp::Clause::OMPC_ordered)}) { 1280 // only one ordered clause is allowed 1281 const auto &orderedClause{ 1282 std::get<parser::OmpClause::Ordered>(clause->u)}; 1283 1284 if (orderedClause.v) { 1285 CheckNotAllowedIfClause( 1286 llvm::omp::Clause::OMPC_ordered, {llvm::omp::Clause::OMPC_linear}); 1287 1288 if (auto *clause2{FindClause(llvm::omp::Clause::OMPC_collapse)}) { 1289 const auto &collapseClause{ 1290 std::get<parser::OmpClause::Collapse>(clause2->u)}; 1291 // ordered and collapse both have parameters 1292 if (const auto orderedValue{GetIntValue(orderedClause.v)}) { 1293 if (const auto collapseValue{GetIntValue(collapseClause.v)}) { 1294 if (*orderedValue > 0 && *orderedValue < *collapseValue) { 1295 context_.Say(clause->source, 1296 "The parameter of the ORDERED clause must be " 1297 "greater than or equal to " 1298 "the parameter of the COLLAPSE clause"_err_en_US); 1299 } 1300 } 1301 } 1302 } 1303 } 1304 1305 // TODO: ordered region binding check (requires nesting implementation) 1306 } 1307 } // doSet 1308 1309 // 2.8.1 Simd Construct Restriction 1310 if (llvm::omp::simdSet.test(GetContext().directive)) { 1311 if (auto *clause{FindClause(llvm::omp::Clause::OMPC_simdlen)}) { 1312 if (auto *clause2{FindClause(llvm::omp::Clause::OMPC_safelen)}) { 1313 const auto &simdlenClause{ 1314 std::get<parser::OmpClause::Simdlen>(clause->u)}; 1315 const auto &safelenClause{ 1316 std::get<parser::OmpClause::Safelen>(clause2->u)}; 1317 // simdlen and safelen both have parameters 1318 if (const auto simdlenValue{GetIntValue(simdlenClause.v)}) { 1319 if (const auto safelenValue{GetIntValue(safelenClause.v)}) { 1320 if (*safelenValue > 0 && *simdlenValue > *safelenValue) { 1321 context_.Say(clause->source, 1322 "The parameter of the SIMDLEN clause must be less than or " 1323 "equal to the parameter of the SAFELEN clause"_err_en_US); 1324 } 1325 } 1326 } 1327 } 1328 } 1329 // A list-item cannot appear in more than one aligned clause 1330 semantics::UnorderedSymbolSet alignedVars; 1331 auto clauseAll = FindClauses(llvm::omp::Clause::OMPC_aligned); 1332 for (auto itr = clauseAll.first; itr != clauseAll.second; ++itr) { 1333 const auto &alignedClause{ 1334 std::get<parser::OmpClause::Aligned>(itr->second->u)}; 1335 const auto &alignedNameList{ 1336 std::get<std::list<parser::Name>>(alignedClause.v.t)}; 1337 for (auto const &var : alignedNameList) { 1338 if (alignedVars.count(*(var.symbol)) == 1) { 1339 context_.Say(itr->second->source, 1340 "List item '%s' present at multiple ALIGNED clauses"_err_en_US, 1341 var.ToString()); 1342 break; 1343 } 1344 alignedVars.insert(*(var.symbol)); 1345 } 1346 } 1347 } // SIMD 1348 1349 // 2.7.3 Single Construct Restriction 1350 if (GetContext().directive == llvm::omp::Directive::OMPD_end_single) { 1351 CheckNotAllowedIfClause( 1352 llvm::omp::Clause::OMPC_copyprivate, {llvm::omp::Clause::OMPC_nowait}); 1353 } 1354 1355 CheckRequireAtLeastOneOf(); 1356 } 1357 1358 void OmpStructureChecker::Enter(const parser::OmpClause &x) { 1359 SetContextClause(x); 1360 } 1361 1362 // Following clauses do not have a separate node in parse-tree.h. 1363 CHECK_SIMPLE_CLAUSE(AcqRel, OMPC_acq_rel) 1364 CHECK_SIMPLE_CLAUSE(Acquire, OMPC_acquire) 1365 CHECK_SIMPLE_CLAUSE(AtomicDefaultMemOrder, OMPC_atomic_default_mem_order) 1366 CHECK_SIMPLE_CLAUSE(Affinity, OMPC_affinity) 1367 CHECK_SIMPLE_CLAUSE(Allocate, OMPC_allocate) 1368 CHECK_SIMPLE_CLAUSE(Capture, OMPC_capture) 1369 CHECK_SIMPLE_CLAUSE(Copyin, OMPC_copyin) 1370 CHECK_SIMPLE_CLAUSE(Default, OMPC_default) 1371 CHECK_SIMPLE_CLAUSE(Depobj, OMPC_depobj) 1372 CHECK_SIMPLE_CLAUSE(Destroy, OMPC_destroy) 1373 CHECK_SIMPLE_CLAUSE(Detach, OMPC_detach) 1374 CHECK_SIMPLE_CLAUSE(Device, OMPC_device) 1375 CHECK_SIMPLE_CLAUSE(DeviceType, OMPC_device_type) 1376 CHECK_SIMPLE_CLAUSE(DistSchedule, OMPC_dist_schedule) 1377 CHECK_SIMPLE_CLAUSE(DynamicAllocators, OMPC_dynamic_allocators) 1378 CHECK_SIMPLE_CLAUSE(Exclusive, OMPC_exclusive) 1379 CHECK_SIMPLE_CLAUSE(Final, OMPC_final) 1380 CHECK_SIMPLE_CLAUSE(Flush, OMPC_flush) 1381 CHECK_SIMPLE_CLAUSE(From, OMPC_from) 1382 CHECK_SIMPLE_CLAUSE(Full, OMPC_full) 1383 CHECK_SIMPLE_CLAUSE(Hint, OMPC_hint) 1384 CHECK_SIMPLE_CLAUSE(InReduction, OMPC_in_reduction) 1385 CHECK_SIMPLE_CLAUSE(Inclusive, OMPC_inclusive) 1386 CHECK_SIMPLE_CLAUSE(Match, OMPC_match) 1387 CHECK_SIMPLE_CLAUSE(Nontemporal, OMPC_nontemporal) 1388 CHECK_SIMPLE_CLAUSE(Order, OMPC_order) 1389 CHECK_SIMPLE_CLAUSE(Read, OMPC_read) 1390 CHECK_SIMPLE_CLAUSE(ReverseOffload, OMPC_reverse_offload) 1391 CHECK_SIMPLE_CLAUSE(Threadprivate, OMPC_threadprivate) 1392 CHECK_SIMPLE_CLAUSE(Threads, OMPC_threads) 1393 CHECK_SIMPLE_CLAUSE(Inbranch, OMPC_inbranch) 1394 CHECK_SIMPLE_CLAUSE(IsDevicePtr, OMPC_is_device_ptr) 1395 CHECK_SIMPLE_CLAUSE(Link, OMPC_link) 1396 CHECK_SIMPLE_CLAUSE(Mergeable, OMPC_mergeable) 1397 CHECK_SIMPLE_CLAUSE(Nogroup, OMPC_nogroup) 1398 CHECK_SIMPLE_CLAUSE(Notinbranch, OMPC_notinbranch) 1399 CHECK_SIMPLE_CLAUSE(Nowait, OMPC_nowait) 1400 CHECK_SIMPLE_CLAUSE(Partial, OMPC_partial) 1401 CHECK_SIMPLE_CLAUSE(ProcBind, OMPC_proc_bind) 1402 CHECK_SIMPLE_CLAUSE(Release, OMPC_release) 1403 CHECK_SIMPLE_CLAUSE(Relaxed, OMPC_relaxed) 1404 CHECK_SIMPLE_CLAUSE(SeqCst, OMPC_seq_cst) 1405 CHECK_SIMPLE_CLAUSE(Simd, OMPC_simd) 1406 CHECK_SIMPLE_CLAUSE(Sizes, OMPC_sizes) 1407 CHECK_SIMPLE_CLAUSE(TaskReduction, OMPC_task_reduction) 1408 CHECK_SIMPLE_CLAUSE(To, OMPC_to) 1409 CHECK_SIMPLE_CLAUSE(UnifiedAddress, OMPC_unified_address) 1410 CHECK_SIMPLE_CLAUSE(UnifiedSharedMemory, OMPC_unified_shared_memory) 1411 CHECK_SIMPLE_CLAUSE(Uniform, OMPC_uniform) 1412 CHECK_SIMPLE_CLAUSE(Unknown, OMPC_unknown) 1413 CHECK_SIMPLE_CLAUSE(Untied, OMPC_untied) 1414 CHECK_SIMPLE_CLAUSE(UseDevicePtr, OMPC_use_device_ptr) 1415 CHECK_SIMPLE_CLAUSE(UsesAllocators, OMPC_uses_allocators) 1416 CHECK_SIMPLE_CLAUSE(Update, OMPC_update) 1417 CHECK_SIMPLE_CLAUSE(UseDeviceAddr, OMPC_use_device_addr) 1418 CHECK_SIMPLE_CLAUSE(Write, OMPC_write) 1419 CHECK_SIMPLE_CLAUSE(Init, OMPC_init) 1420 CHECK_SIMPLE_CLAUSE(Use, OMPC_use) 1421 CHECK_SIMPLE_CLAUSE(Novariants, OMPC_novariants) 1422 CHECK_SIMPLE_CLAUSE(Nocontext, OMPC_nocontext) 1423 CHECK_SIMPLE_CLAUSE(Filter, OMPC_filter) 1424 CHECK_SIMPLE_CLAUSE(When, OMPC_when) 1425 CHECK_SIMPLE_CLAUSE(AdjustArgs, OMPC_adjust_args) 1426 1427 CHECK_REQ_SCALAR_INT_CLAUSE(Grainsize, OMPC_grainsize) 1428 CHECK_REQ_SCALAR_INT_CLAUSE(NumTasks, OMPC_num_tasks) 1429 CHECK_REQ_SCALAR_INT_CLAUSE(NumTeams, OMPC_num_teams) 1430 CHECK_REQ_SCALAR_INT_CLAUSE(NumThreads, OMPC_num_threads) 1431 CHECK_REQ_SCALAR_INT_CLAUSE(Priority, OMPC_priority) 1432 CHECK_REQ_SCALAR_INT_CLAUSE(ThreadLimit, OMPC_thread_limit) 1433 1434 CHECK_REQ_CONSTANT_SCALAR_INT_CLAUSE(Collapse, OMPC_collapse) 1435 CHECK_REQ_CONSTANT_SCALAR_INT_CLAUSE(Safelen, OMPC_safelen) 1436 CHECK_REQ_CONSTANT_SCALAR_INT_CLAUSE(Simdlen, OMPC_simdlen) 1437 1438 // Restrictions specific to each clause are implemented apart from the 1439 // generalized restrictions. 1440 void OmpStructureChecker::Enter(const parser::OmpClause::Reduction &x) { 1441 CheckAllowed(llvm::omp::Clause::OMPC_reduction); 1442 if (CheckReductionOperators(x)) { 1443 CheckReductionTypeList(x); 1444 } 1445 } 1446 bool OmpStructureChecker::CheckReductionOperators( 1447 const parser::OmpClause::Reduction &x) { 1448 1449 const auto &definedOp{std::get<0>(x.v.t)}; 1450 bool ok = false; 1451 std::visit( 1452 common::visitors{ 1453 [&](const parser::DefinedOperator &dOpr) { 1454 const auto &intrinsicOp{ 1455 std::get<parser::DefinedOperator::IntrinsicOperator>(dOpr.u)}; 1456 ok = CheckIntrinsicOperator(intrinsicOp); 1457 }, 1458 [&](const parser::ProcedureDesignator &procD) { 1459 const parser::Name *name{std::get_if<parser::Name>(&procD.u)}; 1460 if (name) { 1461 if (name->source == "max" || name->source == "min" || 1462 name->source == "iand" || name->source == "ior" || 1463 name->source == "ieor") { 1464 ok = true; 1465 } else { 1466 context_.Say(GetContext().clauseSource, 1467 "Invalid reduction identifier in REDUCTION clause."_err_en_US, 1468 ContextDirectiveAsFortran()); 1469 } 1470 } 1471 }, 1472 }, 1473 definedOp.u); 1474 1475 return ok; 1476 } 1477 bool OmpStructureChecker::CheckIntrinsicOperator( 1478 const parser::DefinedOperator::IntrinsicOperator &op) { 1479 1480 switch (op) { 1481 case parser::DefinedOperator::IntrinsicOperator::Add: 1482 case parser::DefinedOperator::IntrinsicOperator::Subtract: 1483 case parser::DefinedOperator::IntrinsicOperator::Multiply: 1484 case parser::DefinedOperator::IntrinsicOperator::AND: 1485 case parser::DefinedOperator::IntrinsicOperator::OR: 1486 case parser::DefinedOperator::IntrinsicOperator::EQV: 1487 case parser::DefinedOperator::IntrinsicOperator::NEQV: 1488 return true; 1489 default: 1490 context_.Say(GetContext().clauseSource, 1491 "Invalid reduction operator in REDUCTION clause."_err_en_US, 1492 ContextDirectiveAsFortran()); 1493 } 1494 return false; 1495 } 1496 1497 void OmpStructureChecker::CheckReductionTypeList( 1498 const parser::OmpClause::Reduction &x) { 1499 const auto &ompObjectList{std::get<parser::OmpObjectList>(x.v.t)}; 1500 CheckIntentInPointerAndDefinable( 1501 ompObjectList, llvm::omp::Clause::OMPC_reduction); 1502 CheckReductionArraySection(ompObjectList); 1503 CheckMultipleAppearanceAcrossContext(ompObjectList); 1504 } 1505 1506 void OmpStructureChecker::CheckIntentInPointerAndDefinable( 1507 const parser::OmpObjectList &objectList, const llvm::omp::Clause clause) { 1508 for (const auto &ompObject : objectList.v) { 1509 if (const auto *name{parser::Unwrap<parser::Name>(ompObject)}) { 1510 if (const auto *symbol{name->symbol}) { 1511 if (IsPointer(symbol->GetUltimate()) && 1512 IsIntentIn(symbol->GetUltimate())) { 1513 context_.Say(GetContext().clauseSource, 1514 "Pointer '%s' with the INTENT(IN) attribute may not appear " 1515 "in a %s clause"_err_en_US, 1516 symbol->name(), 1517 parser::ToUpperCaseLetters(getClauseName(clause).str())); 1518 } 1519 if (auto msg{ 1520 WhyNotModifiable(*symbol, context_.FindScope(name->source))}) { 1521 context_.Say(GetContext().clauseSource, 1522 "Variable '%s' on the %s clause is not definable"_err_en_US, 1523 symbol->name(), 1524 parser::ToUpperCaseLetters(getClauseName(clause).str())); 1525 } 1526 } 1527 } 1528 } 1529 } 1530 1531 void OmpStructureChecker::CheckReductionArraySection( 1532 const parser::OmpObjectList &ompObjectList) { 1533 for (const auto &ompObject : ompObjectList.v) { 1534 if (const auto *dataRef{parser::Unwrap<parser::DataRef>(ompObject)}) { 1535 if (const auto *arrayElement{ 1536 parser::Unwrap<parser::ArrayElement>(ompObject)}) { 1537 if (arrayElement) { 1538 CheckArraySection(*arrayElement, GetLastName(*dataRef), 1539 llvm::omp::Clause::OMPC_reduction); 1540 } 1541 } 1542 } 1543 } 1544 } 1545 1546 void OmpStructureChecker::CheckMultipleAppearanceAcrossContext( 1547 const parser::OmpObjectList &redObjectList) { 1548 // TODO: Verify the assumption here that the immediately enclosing region is 1549 // the parallel region to which the worksharing construct having reduction 1550 // binds to. 1551 if (auto *enclosingContext{GetEnclosingDirContext()}) { 1552 for (auto it : enclosingContext->clauseInfo) { 1553 llvmOmpClause type = it.first; 1554 const auto *clause = it.second; 1555 if (llvm::omp::privateReductionSet.test(type)) { 1556 if (const auto *objList{GetOmpObjectList(*clause)}) { 1557 for (const auto &ompObject : objList->v) { 1558 if (const auto *name{parser::Unwrap<parser::Name>(ompObject)}) { 1559 if (const auto *symbol{name->symbol}) { 1560 for (const auto &redOmpObject : redObjectList.v) { 1561 if (const auto *rname{ 1562 parser::Unwrap<parser::Name>(redOmpObject)}) { 1563 if (const auto *rsymbol{rname->symbol}) { 1564 if (rsymbol->name() == symbol->name()) { 1565 context_.Say(GetContext().clauseSource, 1566 "%s variable '%s' is %s in outer context must" 1567 " be shared in the parallel regions to which any" 1568 " of the worksharing regions arising from the " 1569 "worksharing" 1570 " construct bind."_err_en_US, 1571 parser::ToUpperCaseLetters( 1572 getClauseName(llvm::omp::Clause::OMPC_reduction) 1573 .str()), 1574 symbol->name(), 1575 parser::ToUpperCaseLetters( 1576 getClauseName(type).str())); 1577 } 1578 } 1579 } 1580 } 1581 } 1582 } 1583 } 1584 } 1585 } 1586 } 1587 } 1588 } 1589 1590 void OmpStructureChecker::Enter(const parser::OmpClause::Ordered &x) { 1591 CheckAllowed(llvm::omp::Clause::OMPC_ordered); 1592 // the parameter of ordered clause is optional 1593 if (const auto &expr{x.v}) { 1594 RequiresConstantPositiveParameter(llvm::omp::Clause::OMPC_ordered, *expr); 1595 // 2.8.3 Loop SIMD Construct Restriction 1596 if (llvm::omp::doSimdSet.test(GetContext().directive)) { 1597 context_.Say(GetContext().clauseSource, 1598 "No ORDERED clause with a parameter can be specified " 1599 "on the %s directive"_err_en_US, 1600 ContextDirectiveAsFortran()); 1601 } 1602 } 1603 } 1604 1605 void OmpStructureChecker::Enter(const parser::OmpClause::Shared &x) { 1606 CheckAllowed(llvm::omp::Clause::OMPC_shared); 1607 CheckIsVarPartOfAnotherVar(GetContext().clauseSource, x.v); 1608 } 1609 void OmpStructureChecker::Enter(const parser::OmpClause::Private &x) { 1610 CheckAllowed(llvm::omp::Clause::OMPC_private); 1611 CheckIsVarPartOfAnotherVar(GetContext().clauseSource, x.v); 1612 CheckIntentInPointer(x.v, llvm::omp::Clause::OMPC_private); 1613 } 1614 1615 bool OmpStructureChecker::IsDataRefTypeParamInquiry( 1616 const parser::DataRef *dataRef) { 1617 bool dataRefIsTypeParamInquiry{false}; 1618 if (const auto *structComp{ 1619 parser::Unwrap<parser::StructureComponent>(dataRef)}) { 1620 if (const auto *compSymbol{structComp->component.symbol}) { 1621 if (const auto *compSymbolMiscDetails{ 1622 std::get_if<MiscDetails>(&compSymbol->details())}) { 1623 const auto detailsKind = compSymbolMiscDetails->kind(); 1624 dataRefIsTypeParamInquiry = 1625 (detailsKind == MiscDetails::Kind::KindParamInquiry || 1626 detailsKind == MiscDetails::Kind::LenParamInquiry); 1627 } else if (compSymbol->has<TypeParamDetails>()) { 1628 dataRefIsTypeParamInquiry = true; 1629 } 1630 } 1631 } 1632 return dataRefIsTypeParamInquiry; 1633 } 1634 1635 void OmpStructureChecker::CheckIsVarPartOfAnotherVar( 1636 const parser::CharBlock &source, const parser::OmpObjectList &objList) { 1637 OmpDirectiveSet nonPartialVarSet{llvm::omp::Directive::OMPD_allocate, 1638 llvm::omp::Directive::OMPD_threadprivate}; 1639 for (const auto &ompObject : objList.v) { 1640 std::visit( 1641 common::visitors{ 1642 [&](const parser::Designator &designator) { 1643 if (const auto *dataRef{ 1644 std::get_if<parser::DataRef>(&designator.u)}) { 1645 if (IsDataRefTypeParamInquiry(dataRef)) { 1646 context_.Say(source, 1647 "A type parameter inquiry cannot appear on the %s " 1648 "directive"_err_en_US, 1649 ContextDirectiveAsFortran()); 1650 } else if (parser::Unwrap<parser::StructureComponent>( 1651 ompObject) || 1652 parser::Unwrap<parser::ArrayElement>(ompObject)) { 1653 if (nonPartialVarSet.test(GetContext().directive)) { 1654 context_.Say(source, 1655 "A variable that is part of another variable (as an " 1656 "array or structure element) cannot appear on the %s " 1657 "directive"_err_en_US, 1658 ContextDirectiveAsFortran()); 1659 } else { 1660 context_.Say(source, 1661 "A variable that is part of another variable (as an " 1662 "array or structure element) cannot appear in a " 1663 "PRIVATE or SHARED clause"_err_en_US); 1664 } 1665 } 1666 } 1667 }, 1668 [&](const parser::Name &name) {}, 1669 }, 1670 ompObject.u); 1671 } 1672 } 1673 1674 void OmpStructureChecker::Enter(const parser::OmpClause::Firstprivate &x) { 1675 CheckAllowed(llvm::omp::Clause::OMPC_firstprivate); 1676 CheckIsLoopIvPartOfClause(llvmOmpClause::OMPC_firstprivate, x.v); 1677 1678 SymbolSourceMap currSymbols; 1679 GetSymbolsInObjectList(x.v, currSymbols); 1680 1681 DirectivesClauseTriple dirClauseTriple; 1682 // Check firstprivate variables in worksharing constructs 1683 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_do, 1684 std::make_pair( 1685 llvm::omp::Directive::OMPD_parallel, llvm::omp::privateReductionSet)); 1686 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_sections, 1687 std::make_pair( 1688 llvm::omp::Directive::OMPD_parallel, llvm::omp::privateReductionSet)); 1689 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_single, 1690 std::make_pair( 1691 llvm::omp::Directive::OMPD_parallel, llvm::omp::privateReductionSet)); 1692 // Check firstprivate variables in distribute construct 1693 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_distribute, 1694 std::make_pair( 1695 llvm::omp::Directive::OMPD_teams, llvm::omp::privateReductionSet)); 1696 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_distribute, 1697 std::make_pair(llvm::omp::Directive::OMPD_target_teams, 1698 llvm::omp::privateReductionSet)); 1699 // Check firstprivate variables in task and taskloop constructs 1700 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_task, 1701 std::make_pair(llvm::omp::Directive::OMPD_parallel, 1702 OmpClauseSet{llvm::omp::Clause::OMPC_reduction})); 1703 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_taskloop, 1704 std::make_pair(llvm::omp::Directive::OMPD_parallel, 1705 OmpClauseSet{llvm::omp::Clause::OMPC_reduction})); 1706 1707 CheckPrivateSymbolsInOuterCxt( 1708 currSymbols, dirClauseTriple, llvm::omp::Clause::OMPC_firstprivate); 1709 } 1710 1711 void OmpStructureChecker::CheckIsLoopIvPartOfClause( 1712 llvmOmpClause clause, const parser::OmpObjectList &ompObjectList) { 1713 for (const auto &ompObject : ompObjectList.v) { 1714 if (const parser::Name * name{parser::Unwrap<parser::Name>(ompObject)}) { 1715 if (name->symbol == GetContext().loopIV) { 1716 context_.Say(name->source, 1717 "DO iteration variable %s is not allowed in %s clause."_err_en_US, 1718 name->ToString(), 1719 parser::ToUpperCaseLetters(getClauseName(clause).str())); 1720 } 1721 } 1722 } 1723 } 1724 // Following clauses have a seperate node in parse-tree.h. 1725 // Atomic-clause 1726 CHECK_SIMPLE_PARSER_CLAUSE(OmpAtomicRead, OMPC_read) 1727 CHECK_SIMPLE_PARSER_CLAUSE(OmpAtomicWrite, OMPC_write) 1728 CHECK_SIMPLE_PARSER_CLAUSE(OmpAtomicUpdate, OMPC_update) 1729 CHECK_SIMPLE_PARSER_CLAUSE(OmpAtomicCapture, OMPC_capture) 1730 1731 void OmpStructureChecker::Leave(const parser::OmpAtomicRead &) { 1732 CheckNotAllowedIfClause(llvm::omp::Clause::OMPC_read, 1733 {llvm::omp::Clause::OMPC_release, llvm::omp::Clause::OMPC_acq_rel}); 1734 } 1735 void OmpStructureChecker::Leave(const parser::OmpAtomicWrite &) { 1736 CheckNotAllowedIfClause(llvm::omp::Clause::OMPC_write, 1737 {llvm::omp::Clause::OMPC_acquire, llvm::omp::Clause::OMPC_acq_rel}); 1738 } 1739 void OmpStructureChecker::Leave(const parser::OmpAtomicUpdate &) { 1740 CheckNotAllowedIfClause(llvm::omp::Clause::OMPC_update, 1741 {llvm::omp::Clause::OMPC_acquire, llvm::omp::Clause::OMPC_acq_rel}); 1742 } 1743 // OmpAtomic node represents atomic directive without atomic-clause. 1744 // atomic-clause - READ,WRITE,UPDATE,CAPTURE. 1745 void OmpStructureChecker::Leave(const parser::OmpAtomic &) { 1746 if (const auto *clause{FindClause(llvm::omp::Clause::OMPC_acquire)}) { 1747 context_.Say(clause->source, 1748 "Clause ACQUIRE is not allowed on the ATOMIC directive"_err_en_US); 1749 } 1750 if (const auto *clause{FindClause(llvm::omp::Clause::OMPC_acq_rel)}) { 1751 context_.Say(clause->source, 1752 "Clause ACQ_REL is not allowed on the ATOMIC directive"_err_en_US); 1753 } 1754 } 1755 // Restrictions specific to each clause are implemented apart from the 1756 // generalized restrictions. 1757 void OmpStructureChecker::Enter(const parser::OmpClause::Aligned &x) { 1758 CheckAllowed(llvm::omp::Clause::OMPC_aligned); 1759 1760 if (const auto &expr{ 1761 std::get<std::optional<parser::ScalarIntConstantExpr>>(x.v.t)}) { 1762 RequiresConstantPositiveParameter(llvm::omp::Clause::OMPC_aligned, *expr); 1763 } 1764 // 2.8.1 TODO: list-item attribute check 1765 } 1766 void OmpStructureChecker::Enter(const parser::OmpClause::Defaultmap &x) { 1767 CheckAllowed(llvm::omp::Clause::OMPC_defaultmap); 1768 using VariableCategory = parser::OmpDefaultmapClause::VariableCategory; 1769 if (!std::get<std::optional<VariableCategory>>(x.v.t)) { 1770 context_.Say(GetContext().clauseSource, 1771 "The argument TOFROM:SCALAR must be specified on the DEFAULTMAP " 1772 "clause"_err_en_US); 1773 } 1774 } 1775 void OmpStructureChecker::Enter(const parser::OmpClause::If &x) { 1776 CheckAllowed(llvm::omp::Clause::OMPC_if); 1777 using dirNameModifier = parser::OmpIfClause::DirectiveNameModifier; 1778 static std::unordered_map<dirNameModifier, OmpDirectiveSet> 1779 dirNameModifierMap{{dirNameModifier::Parallel, llvm::omp::parallelSet}, 1780 {dirNameModifier::Target, llvm::omp::targetSet}, 1781 {dirNameModifier::TargetEnterData, 1782 {llvm::omp::Directive::OMPD_target_enter_data}}, 1783 {dirNameModifier::TargetExitData, 1784 {llvm::omp::Directive::OMPD_target_exit_data}}, 1785 {dirNameModifier::TargetData, 1786 {llvm::omp::Directive::OMPD_target_data}}, 1787 {dirNameModifier::TargetUpdate, 1788 {llvm::omp::Directive::OMPD_target_update}}, 1789 {dirNameModifier::Task, {llvm::omp::Directive::OMPD_task}}, 1790 {dirNameModifier::Taskloop, llvm::omp::taskloopSet}}; 1791 if (const auto &directiveName{ 1792 std::get<std::optional<dirNameModifier>>(x.v.t)}) { 1793 auto search{dirNameModifierMap.find(*directiveName)}; 1794 if (search == dirNameModifierMap.end() || 1795 !search->second.test(GetContext().directive)) { 1796 context_ 1797 .Say(GetContext().clauseSource, 1798 "Unmatched directive name modifier %s on the IF clause"_err_en_US, 1799 parser::ToUpperCaseLetters( 1800 parser::OmpIfClause::EnumToString(*directiveName))) 1801 .Attach( 1802 GetContext().directiveSource, "Cannot apply to directive"_en_US); 1803 } 1804 } 1805 } 1806 1807 void OmpStructureChecker::Enter(const parser::OmpClause::Linear &x) { 1808 CheckAllowed(llvm::omp::Clause::OMPC_linear); 1809 1810 // 2.7 Loop Construct Restriction 1811 if ((llvm::omp::doSet | llvm::omp::simdSet).test(GetContext().directive)) { 1812 if (std::holds_alternative<parser::OmpLinearClause::WithModifier>(x.v.u)) { 1813 context_.Say(GetContext().clauseSource, 1814 "A modifier may not be specified in a LINEAR clause " 1815 "on the %s directive"_err_en_US, 1816 ContextDirectiveAsFortran()); 1817 } 1818 } 1819 } 1820 1821 void OmpStructureChecker::CheckAllowedMapTypes( 1822 const parser::OmpMapType::Type &type, 1823 const std::list<parser::OmpMapType::Type> &allowedMapTypeList) { 1824 const auto found{std::find( 1825 std::begin(allowedMapTypeList), std::end(allowedMapTypeList), type)}; 1826 if (found == std::end(allowedMapTypeList)) { 1827 std::string commaSeperatedMapTypes; 1828 llvm::interleave( 1829 allowedMapTypeList.begin(), allowedMapTypeList.end(), 1830 [&](const parser::OmpMapType::Type &mapType) { 1831 commaSeperatedMapTypes.append(parser::ToUpperCaseLetters( 1832 parser::OmpMapType::EnumToString(mapType))); 1833 }, 1834 [&] { commaSeperatedMapTypes.append(", "); }); 1835 context_.Say(GetContext().clauseSource, 1836 "Only the %s map types are permitted " 1837 "for MAP clauses on the %s directive"_err_en_US, 1838 commaSeperatedMapTypes, ContextDirectiveAsFortran()); 1839 } 1840 } 1841 1842 void OmpStructureChecker::Enter(const parser::OmpClause::Map &x) { 1843 CheckAllowed(llvm::omp::Clause::OMPC_map); 1844 1845 if (const auto &maptype{std::get<std::optional<parser::OmpMapType>>(x.v.t)}) { 1846 using Type = parser::OmpMapType::Type; 1847 const Type &type{std::get<Type>(maptype->t)}; 1848 switch (GetContext().directive) { 1849 case llvm::omp::Directive::OMPD_target: 1850 case llvm::omp::Directive::OMPD_target_teams: 1851 case llvm::omp::Directive::OMPD_target_teams_distribute: 1852 case llvm::omp::Directive::OMPD_target_teams_distribute_simd: 1853 case llvm::omp::Directive::OMPD_target_teams_distribute_parallel_do: 1854 case llvm::omp::Directive::OMPD_target_teams_distribute_parallel_do_simd: 1855 case llvm::omp::Directive::OMPD_target_data: 1856 CheckAllowedMapTypes( 1857 type, {Type::To, Type::From, Type::Tofrom, Type::Alloc}); 1858 break; 1859 case llvm::omp::Directive::OMPD_target_enter_data: 1860 CheckAllowedMapTypes(type, {Type::To, Type::Alloc}); 1861 break; 1862 case llvm::omp::Directive::OMPD_target_exit_data: 1863 CheckAllowedMapTypes(type, {Type::From, Type::Release, Type::Delete}); 1864 break; 1865 default: 1866 break; 1867 } 1868 } 1869 } 1870 1871 bool OmpStructureChecker::ScheduleModifierHasType( 1872 const parser::OmpScheduleClause &x, 1873 const parser::OmpScheduleModifierType::ModType &type) { 1874 const auto &modifier{ 1875 std::get<std::optional<parser::OmpScheduleModifier>>(x.t)}; 1876 if (modifier) { 1877 const auto &modType1{ 1878 std::get<parser::OmpScheduleModifier::Modifier1>(modifier->t)}; 1879 const auto &modType2{ 1880 std::get<std::optional<parser::OmpScheduleModifier::Modifier2>>( 1881 modifier->t)}; 1882 if (modType1.v.v == type || (modType2 && modType2->v.v == type)) { 1883 return true; 1884 } 1885 } 1886 return false; 1887 } 1888 void OmpStructureChecker::Enter(const parser::OmpClause::Schedule &x) { 1889 CheckAllowed(llvm::omp::Clause::OMPC_schedule); 1890 const parser::OmpScheduleClause &scheduleClause = x.v; 1891 1892 // 2.7 Loop Construct Restriction 1893 if (llvm::omp::doSet.test(GetContext().directive)) { 1894 const auto &kind{std::get<1>(scheduleClause.t)}; 1895 const auto &chunk{std::get<2>(scheduleClause.t)}; 1896 if (chunk) { 1897 if (kind == parser::OmpScheduleClause::ScheduleType::Runtime || 1898 kind == parser::OmpScheduleClause::ScheduleType::Auto) { 1899 context_.Say(GetContext().clauseSource, 1900 "When SCHEDULE clause has %s specified, " 1901 "it must not have chunk size specified"_err_en_US, 1902 parser::ToUpperCaseLetters( 1903 parser::OmpScheduleClause::EnumToString(kind))); 1904 } 1905 if (const auto &chunkExpr{std::get<std::optional<parser::ScalarIntExpr>>( 1906 scheduleClause.t)}) { 1907 RequiresPositiveParameter( 1908 llvm::omp::Clause::OMPC_schedule, *chunkExpr, "chunk size"); 1909 } 1910 } 1911 1912 if (ScheduleModifierHasType(scheduleClause, 1913 parser::OmpScheduleModifierType::ModType::Nonmonotonic)) { 1914 if (kind != parser::OmpScheduleClause::ScheduleType::Dynamic && 1915 kind != parser::OmpScheduleClause::ScheduleType::Guided) { 1916 context_.Say(GetContext().clauseSource, 1917 "The NONMONOTONIC modifier can only be specified with " 1918 "SCHEDULE(DYNAMIC) or SCHEDULE(GUIDED)"_err_en_US); 1919 } 1920 } 1921 } 1922 } 1923 1924 void OmpStructureChecker::Enter(const parser::OmpClause::Depend &x) { 1925 CheckAllowed(llvm::omp::Clause::OMPC_depend); 1926 if (const auto *inOut{std::get_if<parser::OmpDependClause::InOut>(&x.v.u)}) { 1927 const auto &designators{std::get<std::list<parser::Designator>>(inOut->t)}; 1928 for (const auto &ele : designators) { 1929 if (const auto *dataRef{std::get_if<parser::DataRef>(&ele.u)}) { 1930 CheckDependList(*dataRef); 1931 if (const auto *arr{ 1932 std::get_if<common::Indirection<parser::ArrayElement>>( 1933 &dataRef->u)}) { 1934 CheckArraySection(arr->value(), GetLastName(*dataRef), 1935 llvm::omp::Clause::OMPC_depend); 1936 } 1937 } 1938 } 1939 } 1940 } 1941 1942 void OmpStructureChecker::Enter(const parser::OmpClause::Copyprivate &x) { 1943 CheckAllowed(llvm::omp::Clause::OMPC_copyprivate); 1944 CheckIntentInPointer(x.v, llvm::omp::Clause::OMPC_copyprivate); 1945 } 1946 1947 void OmpStructureChecker::Enter(const parser::OmpClause::Lastprivate &x) { 1948 CheckAllowed(llvm::omp::Clause::OMPC_lastprivate); 1949 1950 DirectivesClauseTriple dirClauseTriple; 1951 SymbolSourceMap currSymbols; 1952 GetSymbolsInObjectList(x.v, currSymbols); 1953 CheckDefinableObjects(currSymbols, GetClauseKindForParserClass(x)); 1954 1955 // Check lastprivate variables in worksharing constructs 1956 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_do, 1957 std::make_pair( 1958 llvm::omp::Directive::OMPD_parallel, llvm::omp::privateReductionSet)); 1959 dirClauseTriple.emplace(llvm::omp::Directive::OMPD_sections, 1960 std::make_pair( 1961 llvm::omp::Directive::OMPD_parallel, llvm::omp::privateReductionSet)); 1962 1963 CheckPrivateSymbolsInOuterCxt( 1964 currSymbols, dirClauseTriple, GetClauseKindForParserClass(x)); 1965 } 1966 1967 llvm::StringRef OmpStructureChecker::getClauseName(llvm::omp::Clause clause) { 1968 return llvm::omp::getOpenMPClauseName(clause); 1969 } 1970 1971 llvm::StringRef OmpStructureChecker::getDirectiveName( 1972 llvm::omp::Directive directive) { 1973 return llvm::omp::getOpenMPDirectiveName(directive); 1974 } 1975 1976 void OmpStructureChecker::CheckDependList(const parser::DataRef &d) { 1977 std::visit( 1978 common::visitors{ 1979 [&](const common::Indirection<parser::ArrayElement> &elem) { 1980 // Check if the base element is valid on Depend Clause 1981 CheckDependList(elem.value().base); 1982 }, 1983 [&](const common::Indirection<parser::StructureComponent> &) { 1984 context_.Say(GetContext().clauseSource, 1985 "A variable that is part of another variable " 1986 "(such as an element of a structure) but is not an array " 1987 "element or an array section cannot appear in a DEPEND " 1988 "clause"_err_en_US); 1989 }, 1990 [&](const common::Indirection<parser::CoindexedNamedObject> &) { 1991 context_.Say(GetContext().clauseSource, 1992 "Coarrays are not supported in DEPEND clause"_err_en_US); 1993 }, 1994 [&](const parser::Name &) { return; }, 1995 }, 1996 d.u); 1997 } 1998 1999 // Called from both Reduction and Depend clause. 2000 void OmpStructureChecker::CheckArraySection( 2001 const parser::ArrayElement &arrayElement, const parser::Name &name, 2002 const llvm::omp::Clause clause) { 2003 if (!arrayElement.subscripts.empty()) { 2004 for (const auto &subscript : arrayElement.subscripts) { 2005 if (const auto *triplet{ 2006 std::get_if<parser::SubscriptTriplet>(&subscript.u)}) { 2007 if (std::get<0>(triplet->t) && std::get<1>(triplet->t)) { 2008 const auto &lower{std::get<0>(triplet->t)}; 2009 const auto &upper{std::get<1>(triplet->t)}; 2010 if (lower && upper) { 2011 const auto lval{GetIntValue(lower)}; 2012 const auto uval{GetIntValue(upper)}; 2013 if (lval && uval && *uval < *lval) { 2014 context_.Say(GetContext().clauseSource, 2015 "'%s' in %s clause" 2016 " is a zero size array section"_err_en_US, 2017 name.ToString(), 2018 parser::ToUpperCaseLetters(getClauseName(clause).str())); 2019 break; 2020 } else if (std::get<2>(triplet->t)) { 2021 const auto &strideExpr{std::get<2>(triplet->t)}; 2022 if (strideExpr) { 2023 if (clause == llvm::omp::Clause::OMPC_depend) { 2024 context_.Say(GetContext().clauseSource, 2025 "Stride should not be specified for array section in " 2026 "DEPEND " 2027 "clause"_err_en_US); 2028 } 2029 const auto stride{GetIntValue(strideExpr)}; 2030 if ((stride && stride != 1)) { 2031 context_.Say(GetContext().clauseSource, 2032 "A list item that appears in a REDUCTION clause" 2033 " should have a contiguous storage array section."_err_en_US, 2034 ContextDirectiveAsFortran()); 2035 break; 2036 } 2037 } 2038 } 2039 } 2040 } 2041 } 2042 } 2043 } 2044 } 2045 2046 void OmpStructureChecker::CheckIntentInPointer( 2047 const parser::OmpObjectList &objectList, const llvm::omp::Clause clause) { 2048 SymbolSourceMap symbols; 2049 GetSymbolsInObjectList(objectList, symbols); 2050 for (auto it{symbols.begin()}; it != symbols.end(); ++it) { 2051 const auto *symbol{it->first}; 2052 const auto source{it->second}; 2053 if (IsPointer(*symbol) && IsIntentIn(*symbol)) { 2054 context_.Say(source, 2055 "Pointer '%s' with the INTENT(IN) attribute may not appear " 2056 "in a %s clause"_err_en_US, 2057 symbol->name(), 2058 parser::ToUpperCaseLetters(getClauseName(clause).str())); 2059 } 2060 } 2061 } 2062 2063 void OmpStructureChecker::GetSymbolsInObjectList( 2064 const parser::OmpObjectList &objectList, SymbolSourceMap &symbols) { 2065 for (const auto &ompObject : objectList.v) { 2066 if (const auto *name{parser::Unwrap<parser::Name>(ompObject)}) { 2067 if (const auto *symbol{name->symbol}) { 2068 if (const auto *commonBlockDetails{ 2069 symbol->detailsIf<CommonBlockDetails>()}) { 2070 for (const auto &object : commonBlockDetails->objects()) { 2071 symbols.emplace(&object->GetUltimate(), name->source); 2072 } 2073 } else { 2074 symbols.emplace(&symbol->GetUltimate(), name->source); 2075 } 2076 } 2077 } 2078 } 2079 } 2080 2081 void OmpStructureChecker::CheckDefinableObjects( 2082 SymbolSourceMap &symbols, const llvm::omp::Clause clause) { 2083 for (auto it{symbols.begin()}; it != symbols.end(); ++it) { 2084 const auto *symbol{it->first}; 2085 const auto source{it->second}; 2086 if (auto msg{WhyNotModifiable(*symbol, context_.FindScope(source))}) { 2087 context_ 2088 .Say(source, 2089 "Variable '%s' on the %s clause is not definable"_err_en_US, 2090 symbol->name(), 2091 parser::ToUpperCaseLetters(getClauseName(clause).str())) 2092 .Attach(source, std::move(*msg), symbol->name()); 2093 } 2094 } 2095 } 2096 2097 void OmpStructureChecker::CheckPrivateSymbolsInOuterCxt( 2098 SymbolSourceMap &currSymbols, DirectivesClauseTriple &dirClauseTriple, 2099 const llvm::omp::Clause currClause) { 2100 SymbolSourceMap enclosingSymbols; 2101 auto range{dirClauseTriple.equal_range(GetContext().directive)}; 2102 for (auto dirIter{range.first}; dirIter != range.second; ++dirIter) { 2103 auto enclosingDir{dirIter->second.first}; 2104 auto enclosingClauseSet{dirIter->second.second}; 2105 if (auto *enclosingContext{GetEnclosingContextWithDir(enclosingDir)}) { 2106 for (auto it{enclosingContext->clauseInfo.begin()}; 2107 it != enclosingContext->clauseInfo.end(); ++it) { 2108 if (enclosingClauseSet.test(it->first)) { 2109 if (const auto *ompObjectList{GetOmpObjectList(*it->second)}) { 2110 GetSymbolsInObjectList(*ompObjectList, enclosingSymbols); 2111 } 2112 } 2113 } 2114 2115 // Check if the symbols in current context are private in outer context 2116 for (auto iter{currSymbols.begin()}; iter != currSymbols.end(); ++iter) { 2117 const auto *symbol{iter->first}; 2118 const auto source{iter->second}; 2119 if (enclosingSymbols.find(symbol) != enclosingSymbols.end()) { 2120 context_.Say(source, 2121 "%s variable '%s' is PRIVATE in outer context"_err_en_US, 2122 parser::ToUpperCaseLetters(getClauseName(currClause).str()), 2123 symbol->name()); 2124 } 2125 } 2126 } 2127 } 2128 } 2129 2130 bool OmpStructureChecker::CheckTargetBlockOnlyTeams( 2131 const parser::Block &block) { 2132 bool nestedTeams{false}; 2133 auto it{block.begin()}; 2134 2135 if (const auto *ompConstruct{parser::Unwrap<parser::OpenMPConstruct>(*it)}) { 2136 if (const auto *ompBlockConstruct{ 2137 std::get_if<parser::OpenMPBlockConstruct>(&ompConstruct->u)}) { 2138 const auto &beginBlockDir{ 2139 std::get<parser::OmpBeginBlockDirective>(ompBlockConstruct->t)}; 2140 const auto &beginDir{ 2141 std::get<parser::OmpBlockDirective>(beginBlockDir.t)}; 2142 if (beginDir.v == llvm::omp::Directive::OMPD_teams) { 2143 nestedTeams = true; 2144 } 2145 } 2146 } 2147 2148 if (nestedTeams && ++it == block.end()) { 2149 return true; 2150 } 2151 return false; 2152 } 2153 2154 void OmpStructureChecker::CheckWorkshareBlockStmts( 2155 const parser::Block &block, parser::CharBlock source) { 2156 OmpWorkshareBlockChecker ompWorkshareBlockChecker{context_, source}; 2157 2158 for (auto it{block.begin()}; it != block.end(); ++it) { 2159 if (parser::Unwrap<parser::AssignmentStmt>(*it) || 2160 parser::Unwrap<parser::ForallStmt>(*it) || 2161 parser::Unwrap<parser::ForallConstruct>(*it) || 2162 parser::Unwrap<parser::WhereStmt>(*it) || 2163 parser::Unwrap<parser::WhereConstruct>(*it)) { 2164 parser::Walk(*it, ompWorkshareBlockChecker); 2165 } else if (const auto *ompConstruct{ 2166 parser::Unwrap<parser::OpenMPConstruct>(*it)}) { 2167 if (const auto *ompAtomicConstruct{ 2168 std::get_if<parser::OpenMPAtomicConstruct>(&ompConstruct->u)}) { 2169 // Check if assignment statements in the enclosing OpenMP Atomic 2170 // construct are allowed in the Workshare construct 2171 parser::Walk(*ompAtomicConstruct, ompWorkshareBlockChecker); 2172 } else if (const auto *ompCriticalConstruct{ 2173 std::get_if<parser::OpenMPCriticalConstruct>( 2174 &ompConstruct->u)}) { 2175 // All the restrictions on the Workshare construct apply to the 2176 // statements in the enclosing critical constructs 2177 const auto &criticalBlock{ 2178 std::get<parser::Block>(ompCriticalConstruct->t)}; 2179 CheckWorkshareBlockStmts(criticalBlock, source); 2180 } else { 2181 // Check if OpenMP constructs enclosed in the Workshare construct are 2182 // 'Parallel' constructs 2183 auto currentDir{llvm::omp::Directive::OMPD_unknown}; 2184 const OmpDirectiveSet parallelDirSet{ 2185 llvm::omp::Directive::OMPD_parallel, 2186 llvm::omp::Directive::OMPD_parallel_do, 2187 llvm::omp::Directive::OMPD_parallel_sections, 2188 llvm::omp::Directive::OMPD_parallel_workshare, 2189 llvm::omp::Directive::OMPD_parallel_do_simd}; 2190 2191 if (const auto *ompBlockConstruct{ 2192 std::get_if<parser::OpenMPBlockConstruct>(&ompConstruct->u)}) { 2193 const auto &beginBlockDir{ 2194 std::get<parser::OmpBeginBlockDirective>(ompBlockConstruct->t)}; 2195 const auto &beginDir{ 2196 std::get<parser::OmpBlockDirective>(beginBlockDir.t)}; 2197 currentDir = beginDir.v; 2198 } else if (const auto *ompLoopConstruct{ 2199 std::get_if<parser::OpenMPLoopConstruct>( 2200 &ompConstruct->u)}) { 2201 const auto &beginLoopDir{ 2202 std::get<parser::OmpBeginLoopDirective>(ompLoopConstruct->t)}; 2203 const auto &beginDir{ 2204 std::get<parser::OmpLoopDirective>(beginLoopDir.t)}; 2205 currentDir = beginDir.v; 2206 } else if (const auto *ompSectionsConstruct{ 2207 std::get_if<parser::OpenMPSectionsConstruct>( 2208 &ompConstruct->u)}) { 2209 const auto &beginSectionsDir{ 2210 std::get<parser::OmpBeginSectionsDirective>( 2211 ompSectionsConstruct->t)}; 2212 const auto &beginDir{ 2213 std::get<parser::OmpSectionsDirective>(beginSectionsDir.t)}; 2214 currentDir = beginDir.v; 2215 } 2216 2217 if (!parallelDirSet.test(currentDir)) { 2218 context_.Say(source, 2219 "OpenMP constructs enclosed in WORKSHARE construct may consist " 2220 "of ATOMIC, CRITICAL or PARALLEL constructs only"_err_en_US); 2221 } 2222 } 2223 } else { 2224 context_.Say(source, 2225 "The structured block in a WORKSHARE construct may consist of only " 2226 "SCALAR or ARRAY assignments, FORALL or WHERE statements, " 2227 "FORALL, WHERE, ATOMIC, CRITICAL or PARALLEL constructs"_err_en_US); 2228 } 2229 } 2230 } 2231 2232 const parser::OmpObjectList *OmpStructureChecker::GetOmpObjectList( 2233 const parser::OmpClause &clause) { 2234 2235 // Clauses with OmpObjectList as its data member 2236 using MemberObjectListClauses = std::tuple<parser::OmpClause::Copyprivate, 2237 parser::OmpClause::Copyin, parser::OmpClause::Firstprivate, 2238 parser::OmpClause::From, parser::OmpClause::Lastprivate, 2239 parser::OmpClause::Link, parser::OmpClause::Private, 2240 parser::OmpClause::Shared, parser::OmpClause::To>; 2241 2242 // Clauses with OmpObjectList in the tuple 2243 using TupleObjectListClauses = std::tuple<parser::OmpClause::Allocate, 2244 parser::OmpClause::Map, parser::OmpClause::Reduction>; 2245 2246 // TODO:: Generate the tuples using TableGen. 2247 // Handle other constructs with OmpObjectList such as OpenMPThreadprivate. 2248 return std::visit( 2249 common::visitors{ 2250 [&](const auto &x) -> const parser::OmpObjectList * { 2251 using Ty = std::decay_t<decltype(x)>; 2252 if constexpr (common::HasMember<Ty, MemberObjectListClauses>) { 2253 return &x.v; 2254 } else if constexpr (common::HasMember<Ty, 2255 TupleObjectListClauses>) { 2256 return &(std::get<parser::OmpObjectList>(x.v.t)); 2257 } else { 2258 return nullptr; 2259 } 2260 }, 2261 }, 2262 clause.u); 2263 } 2264 2265 } // namespace Fortran::semantics 2266