1 //===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 10 #include "FormatTestUtils.h" 11 #include "clang/Format/Format.h" 12 #include "llvm/Support/Debug.h" 13 #include "gtest/gtest.h" 14 15 #define DEBUG_TYPE "format-test" 16 17 namespace clang { 18 namespace format { 19 20 FormatStyle getGoogleStyle() { 21 return getGoogleStyle(FormatStyle::LK_Cpp); 22 } 23 24 class FormatTest : public ::testing::Test { 25 protected: 26 std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length, 27 const FormatStyle &Style) { 28 DEBUG(llvm::errs() << "---\n"); 29 DEBUG(llvm::errs() << Code << "\n\n"); 30 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); 31 tooling::Replacements Replaces = reformat(Style, Code, Ranges); 32 ReplacementCount = Replaces.size(); 33 std::string Result = applyAllReplacements(Code, Replaces); 34 EXPECT_NE("", Result); 35 DEBUG(llvm::errs() << "\n" << Result << "\n\n"); 36 return Result; 37 } 38 39 std::string 40 format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) { 41 return format(Code, 0, Code.size(), Style); 42 } 43 44 FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { 45 FormatStyle Style = getLLVMStyle(); 46 Style.ColumnLimit = ColumnLimit; 47 return Style; 48 } 49 50 FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) { 51 FormatStyle Style = getGoogleStyle(); 52 Style.ColumnLimit = ColumnLimit; 53 return Style; 54 } 55 56 void verifyFormat(llvm::StringRef Code, 57 const FormatStyle &Style = getLLVMStyle()) { 58 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style)); 59 } 60 61 void verifyGoogleFormat(llvm::StringRef Code) { 62 verifyFormat(Code, getGoogleStyle()); 63 } 64 65 void verifyIndependentOfContext(llvm::StringRef text) { 66 verifyFormat(text); 67 verifyFormat(llvm::Twine("void f() { " + text + " }").str()); 68 } 69 70 int ReplacementCount; 71 }; 72 73 TEST_F(FormatTest, MessUp) { 74 EXPECT_EQ("1 2 3", test::messUp("1 2 3")); 75 EXPECT_EQ("1 2 3\n", test::messUp("1\n2\n3\n")); 76 EXPECT_EQ("a\n//b\nc", test::messUp("a\n//b\nc")); 77 EXPECT_EQ("a\n#b\nc", test::messUp("a\n#b\nc")); 78 EXPECT_EQ("a\n#b c d\ne", test::messUp("a\n#b\\\nc\\\nd\ne")); 79 } 80 81 //===----------------------------------------------------------------------===// 82 // Basic function tests. 83 //===----------------------------------------------------------------------===// 84 85 TEST_F(FormatTest, DoesNotChangeCorrectlyFormattedCode) { 86 EXPECT_EQ(";", format(";")); 87 } 88 89 TEST_F(FormatTest, FormatsGlobalStatementsAt0) { 90 EXPECT_EQ("int i;", format(" int i;")); 91 EXPECT_EQ("\nint i;", format(" \n\t \v \f int i;")); 92 EXPECT_EQ("int i;\nint j;", format(" int i; int j;")); 93 EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;")); 94 } 95 96 TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) { 97 EXPECT_EQ("int i;", format("int\ni;")); 98 } 99 100 TEST_F(FormatTest, FormatsNestedBlockStatements) { 101 EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}")); 102 } 103 104 TEST_F(FormatTest, FormatsNestedCall) { 105 verifyFormat("Method(f1, f2(f3));"); 106 verifyFormat("Method(f1(f2, f3()));"); 107 verifyFormat("Method(f1(f2, (f3())));"); 108 } 109 110 TEST_F(FormatTest, NestedNameSpecifiers) { 111 verifyFormat("vector<::Type> v;"); 112 verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())"); 113 verifyFormat("static constexpr bool Bar = decltype(bar())::value;"); 114 } 115 116 TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) { 117 EXPECT_EQ("if (a) {\n" 118 " f();\n" 119 "}", 120 format("if(a){f();}")); 121 EXPECT_EQ(4, ReplacementCount); 122 EXPECT_EQ("if (a) {\n" 123 " f();\n" 124 "}", 125 format("if (a) {\n" 126 " f();\n" 127 "}")); 128 EXPECT_EQ(0, ReplacementCount); 129 } 130 131 TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) { 132 EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle())); 133 EXPECT_EQ("int a;", format("int a; ")); 134 EXPECT_EQ("int a;\n", format("int a; \n \n \n ")); 135 EXPECT_EQ("int a;\nint b; ", 136 format("int a; \nint b; ", 0, 0, getLLVMStyle())); 137 } 138 139 TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) { 140 EXPECT_EQ("int b;\nint a;", 141 format("int b;\n int a;", 7, 0, getLLVMStyle())); 142 EXPECT_EQ("int b;\n int a;", 143 format("int b;\n int a;", 6, 0, getLLVMStyle())); 144 145 EXPECT_EQ("#define A \\\n" 146 " int a; \\\n" 147 " int b;", 148 format("#define A \\\n" 149 " int a; \\\n" 150 " int b;", 151 26, 0, getLLVMStyleWithColumns(12))); 152 EXPECT_EQ("#define A \\\n" 153 " int a; \\\n" 154 " int b;", 155 format("#define A \\\n" 156 " int a; \\\n" 157 " int b;", 158 25, 0, getLLVMStyleWithColumns(12))); 159 } 160 161 TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) { 162 EXPECT_EQ("int a;\n\n int b;", 163 format("int a;\n \n\n int b;", 7, 0, getLLVMStyle())); 164 EXPECT_EQ("int a;\n\n int b;", 165 format("int a;\n \n\n int b;", 9, 0, getLLVMStyle())); 166 } 167 168 TEST_F(FormatTest, RemovesEmptyLines) { 169 EXPECT_EQ("class C {\n" 170 " int i;\n" 171 "};", 172 format("class C {\n" 173 " int i;\n" 174 "\n" 175 "};")); 176 177 // Don't remove empty lines at the start of namespaces. 178 EXPECT_EQ("namespace N {\n" 179 "\n" 180 "int i;\n" 181 "}", 182 format("namespace N {\n" 183 "\n" 184 "int i;\n" 185 "}", 186 getGoogleStyle())); 187 188 // Remove empty lines at the beginning and end of blocks. 189 EXPECT_EQ("void f() {\n" 190 "\n" 191 " if (a) {\n" 192 "\n" 193 " f();\n" 194 " }\n" 195 "}", 196 format("void f() {\n" 197 "\n" 198 " if (a) {\n" 199 "\n" 200 " f();\n" 201 "\n" 202 " }\n" 203 "\n" 204 "}", 205 getLLVMStyle())); 206 EXPECT_EQ("void f() {\n" 207 " if (a) {\n" 208 " f();\n" 209 " }\n" 210 "}", 211 format("void f() {\n" 212 "\n" 213 " if (a) {\n" 214 "\n" 215 " f();\n" 216 "\n" 217 " }\n" 218 "\n" 219 "}", 220 getGoogleStyle())); 221 222 // Don't remove empty lines in more complex control statements. 223 EXPECT_EQ("void f() {\n" 224 " if (a) {\n" 225 " f();\n" 226 "\n" 227 " } else if (b) {\n" 228 " f();\n" 229 " }\n" 230 "}", 231 format("void f() {\n" 232 " if (a) {\n" 233 " f();\n" 234 "\n" 235 " } else if (b) {\n" 236 " f();\n" 237 "\n" 238 " }\n" 239 "\n" 240 "}")); 241 242 // FIXME: This is slightly inconsistent. 243 EXPECT_EQ("namespace {\n" 244 "int i;\n" 245 "}", 246 format("namespace {\n" 247 "int i;\n" 248 "\n" 249 "}")); 250 EXPECT_EQ("namespace {\n" 251 "int i;\n" 252 "\n" 253 "} // namespace", 254 format("namespace {\n" 255 "int i;\n" 256 "\n" 257 "} // namespace")); 258 } 259 260 TEST_F(FormatTest, ReformatsMovedLines) { 261 EXPECT_EQ( 262 "template <typename T> T *getFETokenInfo() const {\n" 263 " return static_cast<T *>(FETokenInfo);\n" 264 "}\n" 265 " int a; // <- Should not be formatted", 266 format( 267 "template<typename T>\n" 268 "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n" 269 " int a; // <- Should not be formatted", 270 9, 5, getLLVMStyle())); 271 } 272 273 TEST_F(FormatTest, RecognizesBinaryOperatorKeywords) { 274 verifyFormat("x = (a) and (b);"); 275 verifyFormat("x = (a) or (b);"); 276 verifyFormat("x = (a) bitand (b);"); 277 verifyFormat("x = (a) bitor (b);"); 278 verifyFormat("x = (a) not_eq (b);"); 279 verifyFormat("x = (a) and_eq (b);"); 280 verifyFormat("x = (a) or_eq (b);"); 281 verifyFormat("x = (a) xor (b);"); 282 } 283 284 //===----------------------------------------------------------------------===// 285 // Tests for control statements. 286 //===----------------------------------------------------------------------===// 287 288 TEST_F(FormatTest, FormatIfWithoutCompoundStatement) { 289 verifyFormat("if (true)\n f();\ng();"); 290 verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();"); 291 verifyFormat("if (a)\n if (b) {\n f();\n }\ng();"); 292 293 FormatStyle AllowsMergedIf = getLLVMStyle(); 294 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 295 verifyFormat("if (a)\n" 296 " // comment\n" 297 " f();", 298 AllowsMergedIf); 299 verifyFormat("if (a)\n" 300 " ;", 301 AllowsMergedIf); 302 verifyFormat("if (a)\n" 303 " if (b) return;", 304 AllowsMergedIf); 305 306 verifyFormat("if (a) // Can't merge this\n" 307 " f();\n", 308 AllowsMergedIf); 309 verifyFormat("if (a) /* still don't merge */\n" 310 " f();", 311 AllowsMergedIf); 312 verifyFormat("if (a) { // Never merge this\n" 313 " f();\n" 314 "}", 315 AllowsMergedIf); 316 verifyFormat("if (a) {/* Never merge this */\n" 317 " f();\n" 318 "}", 319 AllowsMergedIf); 320 321 EXPECT_EQ("if (a) return;", format("if(a)\nreturn;", 7, 1, AllowsMergedIf)); 322 EXPECT_EQ("if (a) return; // comment", 323 format("if(a)\nreturn; // comment", 20, 1, AllowsMergedIf)); 324 325 AllowsMergedIf.ColumnLimit = 14; 326 verifyFormat("if (a) return;", AllowsMergedIf); 327 verifyFormat("if (aaaaaaaaa)\n" 328 " return;", 329 AllowsMergedIf); 330 331 AllowsMergedIf.ColumnLimit = 13; 332 verifyFormat("if (a)\n return;", AllowsMergedIf); 333 } 334 335 TEST_F(FormatTest, FormatLoopsWithoutCompoundStatement) { 336 FormatStyle AllowsMergedLoops = getLLVMStyle(); 337 AllowsMergedLoops.AllowShortLoopsOnASingleLine = true; 338 verifyFormat("while (true) continue;", AllowsMergedLoops); 339 verifyFormat("for (;;) continue;", AllowsMergedLoops); 340 verifyFormat("for (int &v : vec) v *= 2;", AllowsMergedLoops); 341 verifyFormat("while (true)\n" 342 " ;", 343 AllowsMergedLoops); 344 verifyFormat("for (;;)\n" 345 " ;", 346 AllowsMergedLoops); 347 verifyFormat("for (;;)\n" 348 " for (;;) continue;", 349 AllowsMergedLoops); 350 verifyFormat("for (;;) // Can't merge this\n" 351 " continue;", 352 AllowsMergedLoops); 353 verifyFormat("for (;;) /* still don't merge */\n" 354 " continue;", 355 AllowsMergedLoops); 356 } 357 358 TEST_F(FormatTest, FormatShortBracedStatements) { 359 FormatStyle AllowSimpleBracedStatements = getLLVMStyle(); 360 AllowSimpleBracedStatements.AllowShortBlocksOnASingleLine = true; 361 362 AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = true; 363 AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = true; 364 365 verifyFormat("if (true) {}", AllowSimpleBracedStatements); 366 verifyFormat("while (true) {}", AllowSimpleBracedStatements); 367 verifyFormat("for (;;) {}", AllowSimpleBracedStatements); 368 verifyFormat("if (true) { f(); }", AllowSimpleBracedStatements); 369 verifyFormat("while (true) { f(); }", AllowSimpleBracedStatements); 370 verifyFormat("for (;;) { f(); }", AllowSimpleBracedStatements); 371 verifyFormat("if (true) { //\n" 372 " f();\n" 373 "}", 374 AllowSimpleBracedStatements); 375 verifyFormat("if (true) {\n" 376 " f();\n" 377 " f();\n" 378 "}", 379 AllowSimpleBracedStatements); 380 381 verifyFormat("template <int> struct A2 {\n" 382 " struct B {};\n" 383 "};", 384 AllowSimpleBracedStatements); 385 386 AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = false; 387 verifyFormat("if (true) {\n" 388 " f();\n" 389 "}", 390 AllowSimpleBracedStatements); 391 392 AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = false; 393 verifyFormat("while (true) {\n" 394 " f();\n" 395 "}", 396 AllowSimpleBracedStatements); 397 verifyFormat("for (;;) {\n" 398 " f();\n" 399 "}", 400 AllowSimpleBracedStatements); 401 } 402 403 TEST_F(FormatTest, ParseIfElse) { 404 verifyFormat("if (true)\n" 405 " if (true)\n" 406 " if (true)\n" 407 " f();\n" 408 " else\n" 409 " g();\n" 410 " else\n" 411 " h();\n" 412 "else\n" 413 " i();"); 414 verifyFormat("if (true)\n" 415 " if (true)\n" 416 " if (true) {\n" 417 " if (true)\n" 418 " f();\n" 419 " } else {\n" 420 " g();\n" 421 " }\n" 422 " else\n" 423 " h();\n" 424 "else {\n" 425 " i();\n" 426 "}"); 427 verifyFormat("void f() {\n" 428 " if (a) {\n" 429 " } else {\n" 430 " }\n" 431 "}"); 432 } 433 434 TEST_F(FormatTest, ElseIf) { 435 verifyFormat("if (a) {\n} else if (b) {\n}"); 436 verifyFormat("if (a)\n" 437 " f();\n" 438 "else if (b)\n" 439 " g();\n" 440 "else\n" 441 " h();"); 442 verifyFormat("if (a) {\n" 443 " f();\n" 444 "}\n" 445 "// or else ..\n" 446 "else {\n" 447 " g()\n" 448 "}"); 449 450 verifyFormat("if (a) {\n" 451 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 452 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 453 "}"); 454 } 455 456 TEST_F(FormatTest, FormatsForLoop) { 457 verifyFormat( 458 "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n" 459 " ++VeryVeryLongLoopVariable)\n" 460 " ;"); 461 verifyFormat("for (;;)\n" 462 " f();"); 463 verifyFormat("for (;;) {\n}"); 464 verifyFormat("for (;;) {\n" 465 " f();\n" 466 "}"); 467 verifyFormat("for (int i = 0; (i < 10); ++i) {\n}"); 468 469 verifyFormat( 470 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 471 " E = UnwrappedLines.end();\n" 472 " I != E; ++I) {\n}"); 473 474 verifyFormat( 475 "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n" 476 " ++IIIII) {\n}"); 477 verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n" 478 " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n" 479 " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}"); 480 verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n" 481 " I = FD->getDeclsInPrototypeScope().begin(),\n" 482 " E = FD->getDeclsInPrototypeScope().end();\n" 483 " I != E; ++I) {\n}"); 484 485 // FIXME: Not sure whether we want extra identation in line 3 here: 486 verifyFormat( 487 "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 488 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n" 489 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 490 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 491 " ++aaaaaaaaaaa) {\n}"); 492 verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n" 493 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 494 "}"); 495 verifyFormat("for (some_namespace::SomeIterator iter( // force break\n" 496 " aaaaaaaaaa);\n" 497 " iter; ++iter) {\n" 498 "}"); 499 500 FormatStyle NoBinPacking = getLLVMStyle(); 501 NoBinPacking.BinPackParameters = false; 502 verifyFormat("for (int aaaaaaaaaaa = 1;\n" 503 " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n" 504 " aaaaaaaaaaaaaaaa,\n" 505 " aaaaaaaaaaaaaaaa,\n" 506 " aaaaaaaaaaaaaaaa);\n" 507 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 508 "}", 509 NoBinPacking); 510 verifyFormat( 511 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 512 " E = UnwrappedLines.end();\n" 513 " I != E;\n" 514 " ++I) {\n}", 515 NoBinPacking); 516 } 517 518 TEST_F(FormatTest, RangeBasedForLoops) { 519 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 520 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 521 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n" 522 " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}"); 523 verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n" 524 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 525 verifyFormat("for (aaaaaaaaa aaaaaaaaaaaaaaaaaaaaa :\n" 526 " aaaaaaaaaaaa.aaaaaaaaaaaa().aaaaaaaaa().a()) {\n}"); 527 } 528 529 TEST_F(FormatTest, ForEachLoops) { 530 verifyFormat("void f() {\n" 531 " foreach (Item *item, itemlist) {}\n" 532 " Q_FOREACH (Item *item, itemlist) {}\n" 533 " BOOST_FOREACH (Item *item, itemlist) {}\n" 534 " UNKNOWN_FORACH(Item * item, itemlist) {}\n" 535 "}"); 536 } 537 538 TEST_F(FormatTest, FormatsWhileLoop) { 539 verifyFormat("while (true) {\n}"); 540 verifyFormat("while (true)\n" 541 " f();"); 542 verifyFormat("while () {\n}"); 543 verifyFormat("while () {\n" 544 " f();\n" 545 "}"); 546 } 547 548 TEST_F(FormatTest, FormatsDoWhile) { 549 verifyFormat("do {\n" 550 " do_something();\n" 551 "} while (something());"); 552 verifyFormat("do\n" 553 " do_something();\n" 554 "while (something());"); 555 } 556 557 TEST_F(FormatTest, FormatsSwitchStatement) { 558 verifyFormat("switch (x) {\n" 559 "case 1:\n" 560 " f();\n" 561 " break;\n" 562 "case kFoo:\n" 563 "case ns::kBar:\n" 564 "case kBaz:\n" 565 " break;\n" 566 "default:\n" 567 " g();\n" 568 " break;\n" 569 "}"); 570 verifyFormat("switch (x) {\n" 571 "case 1: {\n" 572 " f();\n" 573 " break;\n" 574 "}\n" 575 "case 2: {\n" 576 " break;\n" 577 "}\n" 578 "}"); 579 verifyFormat("switch (x) {\n" 580 "case 1: {\n" 581 " f();\n" 582 " {\n" 583 " g();\n" 584 " h();\n" 585 " }\n" 586 " break;\n" 587 "}\n" 588 "}"); 589 verifyFormat("switch (x) {\n" 590 "case 1: {\n" 591 " f();\n" 592 " if (foo) {\n" 593 " g();\n" 594 " h();\n" 595 " }\n" 596 " break;\n" 597 "}\n" 598 "}"); 599 verifyFormat("switch (x) {\n" 600 "case 1: {\n" 601 " f();\n" 602 " g();\n" 603 "} break;\n" 604 "}"); 605 verifyFormat("switch (test)\n" 606 " ;"); 607 verifyFormat("switch (x) {\n" 608 "default: {\n" 609 " // Do nothing.\n" 610 "}\n" 611 "}"); 612 verifyFormat("switch (x) {\n" 613 "// comment\n" 614 "// if 1, do f()\n" 615 "case 1:\n" 616 " f();\n" 617 "}"); 618 verifyFormat("switch (x) {\n" 619 "case 1:\n" 620 " // Do amazing stuff\n" 621 " {\n" 622 " f();\n" 623 " g();\n" 624 " }\n" 625 " break;\n" 626 "}"); 627 verifyFormat("#define A \\\n" 628 " switch (x) { \\\n" 629 " case a: \\\n" 630 " foo = b; \\\n" 631 " }", getLLVMStyleWithColumns(20)); 632 verifyFormat("#define OPERATION_CASE(name) \\\n" 633 " case OP_name: \\\n" 634 " return operations::Operation##name\n", 635 getLLVMStyleWithColumns(40)); 636 637 verifyGoogleFormat("switch (x) {\n" 638 " case 1:\n" 639 " f();\n" 640 " break;\n" 641 " case kFoo:\n" 642 " case ns::kBar:\n" 643 " case kBaz:\n" 644 " break;\n" 645 " default:\n" 646 " g();\n" 647 " break;\n" 648 "}"); 649 verifyGoogleFormat("switch (x) {\n" 650 " case 1: {\n" 651 " f();\n" 652 " break;\n" 653 " }\n" 654 "}"); 655 verifyGoogleFormat("switch (test)\n" 656 " ;"); 657 658 verifyGoogleFormat("#define OPERATION_CASE(name) \\\n" 659 " case OP_name: \\\n" 660 " return operations::Operation##name\n"); 661 verifyGoogleFormat("Operation codeToOperation(OperationCode OpCode) {\n" 662 " // Get the correction operation class.\n" 663 " switch (OpCode) {\n" 664 " CASE(Add);\n" 665 " CASE(Subtract);\n" 666 " default:\n" 667 " return operations::Unknown;\n" 668 " }\n" 669 "#undef OPERATION_CASE\n" 670 "}"); 671 verifyFormat("DEBUG({\n" 672 " switch (x) {\n" 673 " case A:\n" 674 " f();\n" 675 " break;\n" 676 " // On B:\n" 677 " case B:\n" 678 " g();\n" 679 " break;\n" 680 " }\n" 681 "});"); 682 verifyFormat("switch (a) {\n" 683 "case (b):\n" 684 " return;\n" 685 "}"); 686 687 verifyFormat("switch (a) {\n" 688 "case some_namespace::\n" 689 " some_constant:\n" 690 " return;\n" 691 "}", 692 getLLVMStyleWithColumns(34)); 693 } 694 695 TEST_F(FormatTest, CaseRanges) { 696 verifyFormat("switch (x) {\n" 697 "case 'A' ... 'Z':\n" 698 "case 1 ... 5:\n" 699 " break;\n" 700 "}"); 701 } 702 703 TEST_F(FormatTest, FormatsLabels) { 704 verifyFormat("void f() {\n" 705 " some_code();\n" 706 "test_label:\n" 707 " some_other_code();\n" 708 " {\n" 709 " some_more_code();\n" 710 " another_label:\n" 711 " some_more_code();\n" 712 " }\n" 713 "}"); 714 verifyFormat("some_code();\n" 715 "test_label:\n" 716 "some_other_code();"); 717 } 718 719 //===----------------------------------------------------------------------===// 720 // Tests for comments. 721 //===----------------------------------------------------------------------===// 722 723 TEST_F(FormatTest, UnderstandsSingleLineComments) { 724 verifyFormat("//* */"); 725 verifyFormat("// line 1\n" 726 "// line 2\n" 727 "void f() {}\n"); 728 729 verifyFormat("void f() {\n" 730 " // Doesn't do anything\n" 731 "}"); 732 verifyFormat("SomeObject\n" 733 " // Calling someFunction on SomeObject\n" 734 " .someFunction();"); 735 verifyFormat("auto result = SomeObject\n" 736 " // Calling someFunction on SomeObject\n" 737 " .someFunction();"); 738 verifyFormat("void f(int i, // some comment (probably for i)\n" 739 " int j, // some comment (probably for j)\n" 740 " int k); // some comment (probably for k)"); 741 verifyFormat("void f(int i,\n" 742 " // some comment (probably for j)\n" 743 " int j,\n" 744 " // some comment (probably for k)\n" 745 " int k);"); 746 747 verifyFormat("int i // This is a fancy variable\n" 748 " = 5; // with nicely aligned comment."); 749 750 verifyFormat("// Leading comment.\n" 751 "int a; // Trailing comment."); 752 verifyFormat("int a; // Trailing comment\n" 753 " // on 2\n" 754 " // or 3 lines.\n" 755 "int b;"); 756 verifyFormat("int a; // Trailing comment\n" 757 "\n" 758 "// Leading comment.\n" 759 "int b;"); 760 verifyFormat("int a; // Comment.\n" 761 " // More details.\n" 762 "int bbbb; // Another comment."); 763 verifyFormat( 764 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 765 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n" 766 "int cccccccccccccccccccccccccccccc; // comment\n" 767 "int ddd; // looooooooooooooooooooooooong comment\n" 768 "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 769 "int bbbbbbbbbbbbbbbbbbbbb; // comment\n" 770 "int ccccccccccccccccccc; // comment"); 771 772 verifyFormat("#include \"a\" // comment\n" 773 "#include \"a/b/c\" // comment"); 774 verifyFormat("#include <a> // comment\n" 775 "#include <a/b/c> // comment"); 776 EXPECT_EQ("#include \"a\" // comment\n" 777 "#include \"a/b/c\" // comment", 778 format("#include \\\n" 779 " \"a\" // comment\n" 780 "#include \"a/b/c\" // comment")); 781 782 verifyFormat("enum E {\n" 783 " // comment\n" 784 " VAL_A, // comment\n" 785 " VAL_B\n" 786 "};"); 787 788 verifyFormat( 789 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 790 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment"); 791 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 792 " // Comment inside a statement.\n" 793 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 794 verifyFormat( 795 "bool aaaaaaaaaaaaa = // comment\n" 796 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 797 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 798 799 verifyFormat("int aaaa; // aaaaa\n" 800 "int aa; // aaaaaaa", 801 getLLVMStyleWithColumns(20)); 802 803 EXPECT_EQ("void f() { // This does something ..\n" 804 "}\n" 805 "int a; // This is unrelated", 806 format("void f() { // This does something ..\n" 807 " }\n" 808 "int a; // This is unrelated")); 809 EXPECT_EQ("class C {\n" 810 " void f() { // This does something ..\n" 811 " } // awesome..\n" 812 "\n" 813 " int a; // This is unrelated\n" 814 "};", 815 format("class C{void f() { // This does something ..\n" 816 " } // awesome..\n" 817 " \n" 818 "int a; // This is unrelated\n" 819 "};")); 820 821 EXPECT_EQ("int i; // single line trailing comment", 822 format("int i;\\\n// single line trailing comment")); 823 824 verifyGoogleFormat("int a; // Trailing comment."); 825 826 verifyFormat("someFunction(anotherFunction( // Force break.\n" 827 " parameter));"); 828 829 verifyGoogleFormat("#endif // HEADER_GUARD"); 830 831 verifyFormat("const char *test[] = {\n" 832 " // A\n" 833 " \"aaaa\",\n" 834 " // B\n" 835 " \"aaaaa\"};"); 836 verifyGoogleFormat( 837 "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 838 " aaaaaaaaaaaaaaaaaaaaaa); // 81_cols_with_this_comment"); 839 EXPECT_EQ("D(a, {\n" 840 " // test\n" 841 " int a;\n" 842 "});", 843 format("D(a, {\n" 844 "// test\n" 845 "int a;\n" 846 "});")); 847 848 EXPECT_EQ("lineWith(); // comment\n" 849 "// at start\n" 850 "otherLine();", 851 format("lineWith(); // comment\n" 852 "// at start\n" 853 "otherLine();")); 854 EXPECT_EQ("lineWith(); // comment\n" 855 " // at start\n" 856 "otherLine();", 857 format("lineWith(); // comment\n" 858 " // at start\n" 859 "otherLine();")); 860 861 EXPECT_EQ("lineWith(); // comment\n" 862 "// at start\n" 863 "otherLine(); // comment", 864 format("lineWith(); // comment\n" 865 "// at start\n" 866 "otherLine(); // comment")); 867 EXPECT_EQ("lineWith();\n" 868 "// at start\n" 869 "otherLine(); // comment", 870 format("lineWith();\n" 871 " // at start\n" 872 "otherLine(); // comment")); 873 EXPECT_EQ("// first\n" 874 "// at start\n" 875 "otherLine(); // comment", 876 format("// first\n" 877 " // at start\n" 878 "otherLine(); // comment")); 879 EXPECT_EQ("f();\n" 880 "// first\n" 881 "// at start\n" 882 "otherLine(); // comment", 883 format("f();\n" 884 "// first\n" 885 " // at start\n" 886 "otherLine(); // comment")); 887 verifyFormat("f(); // comment\n" 888 "// first\n" 889 "// at start\n" 890 "otherLine();"); 891 EXPECT_EQ("f(); // comment\n" 892 "// first\n" 893 "// at start\n" 894 "otherLine();", 895 format("f(); // comment\n" 896 "// first\n" 897 " // at start\n" 898 "otherLine();")); 899 EXPECT_EQ("f(); // comment\n" 900 " // first\n" 901 "// at start\n" 902 "otherLine();", 903 format("f(); // comment\n" 904 " // first\n" 905 "// at start\n" 906 "otherLine();")); 907 908 verifyFormat( 909 "#define A \\\n" 910 " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" 911 " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", 912 getLLVMStyleWithColumns(60)); 913 verifyFormat( 914 "#define A \\\n" 915 " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" 916 " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", 917 getLLVMStyleWithColumns(61)); 918 919 verifyFormat("if ( // This is some comment\n" 920 " x + 3) {\n" 921 "}"); 922 EXPECT_EQ("if ( // This is some comment\n" 923 " // spanning two lines\n" 924 " x + 3) {\n" 925 "}", 926 format("if( // This is some comment\n" 927 " // spanning two lines\n" 928 " x + 3) {\n" 929 "}")); 930 } 931 932 TEST_F(FormatTest, KeepsParameterWithTrailingCommentsOnTheirOwnLine) { 933 EXPECT_EQ("SomeFunction(a,\n" 934 " b, // comment\n" 935 " c);", 936 format("SomeFunction(a,\n" 937 " b, // comment\n" 938 " c);")); 939 EXPECT_EQ("SomeFunction(a, b,\n" 940 " // comment\n" 941 " c);", 942 format("SomeFunction(a,\n" 943 " b,\n" 944 " // comment\n" 945 " c);")); 946 EXPECT_EQ("SomeFunction(a, b, // comment (unclear relation)\n" 947 " c);", 948 format("SomeFunction(a, b, // comment (unclear relation)\n" 949 " c);")); 950 EXPECT_EQ("SomeFunction(a, // comment\n" 951 " b,\n" 952 " c); // comment", 953 format("SomeFunction(a, // comment\n" 954 " b,\n" 955 " c); // comment")); 956 } 957 958 TEST_F(FormatTest, CanFormatCommentsLocally) { 959 EXPECT_EQ("int a; // comment\n" 960 "int b; // comment", 961 format("int a; // comment\n" 962 "int b; // comment", 963 0, 0, getLLVMStyle())); 964 EXPECT_EQ("int a; // comment\n" 965 " // line 2\n" 966 "int b;", 967 format("int a; // comment\n" 968 " // line 2\n" 969 "int b;", 970 28, 0, getLLVMStyle())); 971 EXPECT_EQ("int aaaaaa; // comment\n" 972 "int b;\n" 973 "int c; // unrelated comment", 974 format("int aaaaaa; // comment\n" 975 "int b;\n" 976 "int c; // unrelated comment", 977 31, 0, getLLVMStyle())); 978 979 EXPECT_EQ("int a; // This\n" 980 " // is\n" 981 " // a", 982 format("int a; // This\n" 983 " // is\n" 984 " // a", 985 0, 0, getLLVMStyle())); 986 EXPECT_EQ("int a; // This\n" 987 " // is\n" 988 " // a\n" 989 "// This is b\n" 990 "int b;", 991 format("int a; // This\n" 992 " // is\n" 993 " // a\n" 994 "// This is b\n" 995 "int b;", 996 0, 0, getLLVMStyle())); 997 EXPECT_EQ("int a; // This\n" 998 " // is\n" 999 " // a\n" 1000 "\n" 1001 " // This is unrelated", 1002 format("int a; // This\n" 1003 " // is\n" 1004 " // a\n" 1005 "\n" 1006 " // This is unrelated", 1007 0, 0, getLLVMStyle())); 1008 EXPECT_EQ("int a;\n" 1009 "// This is\n" 1010 "// not formatted. ", 1011 format("int a;\n" 1012 "// This is\n" 1013 "// not formatted. ", 1014 0, 0, getLLVMStyle())); 1015 } 1016 1017 TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) { 1018 EXPECT_EQ("// comment", format("// comment ")); 1019 EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment", 1020 format("int aaaaaaa, bbbbbbb; // comment ", 1021 getLLVMStyleWithColumns(33))); 1022 EXPECT_EQ("// comment\\\n", format("// comment\\\n \t \v \f ")); 1023 EXPECT_EQ("// comment \\\n", format("// comment \\\n \t \v \f ")); 1024 } 1025 1026 TEST_F(FormatTest, UnderstandsBlockComments) { 1027 verifyFormat("f(/*noSpaceAfterParameterNamingComment=*/true);"); 1028 verifyFormat("void f() { g(/*aaa=*/x, /*bbb=*/!y); }"); 1029 EXPECT_EQ("f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n" 1030 " bbbbbbbbbbbbbbbbbbbbbbbbb);", 1031 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n" 1032 "/* Trailing comment for aa... */\n" 1033 " bbbbbbbbbbbbbbbbbbbbbbbbb);")); 1034 EXPECT_EQ( 1035 "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 1036 " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);", 1037 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n" 1038 "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);")); 1039 EXPECT_EQ( 1040 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 1041 " aaaaaaaaaaaaaaaaaa,\n" 1042 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 1043 "}", 1044 format("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 1045 " aaaaaaaaaaaaaaaaaa ,\n" 1046 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 1047 "}")); 1048 1049 FormatStyle NoBinPacking = getLLVMStyle(); 1050 NoBinPacking.BinPackParameters = false; 1051 verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n" 1052 " /* parameter 2 */ aaaaaa,\n" 1053 " /* parameter 3 */ aaaaaa,\n" 1054 " /* parameter 4 */ aaaaaa);", 1055 NoBinPacking); 1056 1057 // Aligning block comments in macros. 1058 verifyGoogleFormat("#define A \\\n" 1059 " int i; /*a*/ \\\n" 1060 " int jjj; /*b*/"); 1061 } 1062 1063 TEST_F(FormatTest, AlignsBlockComments) { 1064 EXPECT_EQ("/*\n" 1065 " * Really multi-line\n" 1066 " * comment.\n" 1067 " */\n" 1068 "void f() {}", 1069 format(" /*\n" 1070 " * Really multi-line\n" 1071 " * comment.\n" 1072 " */\n" 1073 " void f() {}")); 1074 EXPECT_EQ("class C {\n" 1075 " /*\n" 1076 " * Another multi-line\n" 1077 " * comment.\n" 1078 " */\n" 1079 " void f() {}\n" 1080 "};", 1081 format("class C {\n" 1082 "/*\n" 1083 " * Another multi-line\n" 1084 " * comment.\n" 1085 " */\n" 1086 "void f() {}\n" 1087 "};")); 1088 EXPECT_EQ("/*\n" 1089 " 1. This is a comment with non-trivial formatting.\n" 1090 " 1.1. We have to indent/outdent all lines equally\n" 1091 " 1.1.1. to keep the formatting.\n" 1092 " */", 1093 format(" /*\n" 1094 " 1. This is a comment with non-trivial formatting.\n" 1095 " 1.1. We have to indent/outdent all lines equally\n" 1096 " 1.1.1. to keep the formatting.\n" 1097 " */")); 1098 EXPECT_EQ("/*\n" 1099 "Don't try to outdent if there's not enough indentation.\n" 1100 "*/", 1101 format(" /*\n" 1102 " Don't try to outdent if there's not enough indentation.\n" 1103 " */")); 1104 1105 EXPECT_EQ("int i; /* Comment with empty...\n" 1106 " *\n" 1107 " * line. */", 1108 format("int i; /* Comment with empty...\n" 1109 " *\n" 1110 " * line. */")); 1111 EXPECT_EQ("int foobar = 0; /* comment */\n" 1112 "int bar = 0; /* multiline\n" 1113 " comment 1 */\n" 1114 "int baz = 0; /* multiline\n" 1115 " comment 2 */\n" 1116 "int bzz = 0; /* multiline\n" 1117 " comment 3 */", 1118 format("int foobar = 0; /* comment */\n" 1119 "int bar = 0; /* multiline\n" 1120 " comment 1 */\n" 1121 "int baz = 0; /* multiline\n" 1122 " comment 2 */\n" 1123 "int bzz = 0; /* multiline\n" 1124 " comment 3 */")); 1125 EXPECT_EQ("int foobar = 0; /* comment */\n" 1126 "int bar = 0; /* multiline\n" 1127 " comment */\n" 1128 "int baz = 0; /* multiline\n" 1129 "comment */", 1130 format("int foobar = 0; /* comment */\n" 1131 "int bar = 0; /* multiline\n" 1132 "comment */\n" 1133 "int baz = 0; /* multiline\n" 1134 "comment */")); 1135 } 1136 1137 TEST_F(FormatTest, CorrectlyHandlesLengthOfBlockComments) { 1138 EXPECT_EQ("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 1139 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */", 1140 format("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 1141 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */")); 1142 EXPECT_EQ( 1143 "void ffffffffffff(\n" 1144 " int aaaaaaaa, int bbbbbbbb,\n" 1145 " int cccccccccccc) { /*\n" 1146 " aaaaaaaaaa\n" 1147 " aaaaaaaaaaaaa\n" 1148 " bbbbbbbbbbbbbb\n" 1149 " bbbbbbbbbb\n" 1150 " */\n" 1151 "}", 1152 format("void ffffffffffff(int aaaaaaaa, int bbbbbbbb, int cccccccccccc)\n" 1153 "{ /*\n" 1154 " aaaaaaaaaa aaaaaaaaaaaaa\n" 1155 " bbbbbbbbbbbbbb bbbbbbbbbb\n" 1156 " */\n" 1157 "}", 1158 getLLVMStyleWithColumns(40))); 1159 } 1160 1161 TEST_F(FormatTest, DontBreakNonTrailingBlockComments) { 1162 EXPECT_EQ("void\n" 1163 "ffffffffff(int aaaaa /* test */);", 1164 format("void ffffffffff(int aaaaa /* test */);", 1165 getLLVMStyleWithColumns(35))); 1166 } 1167 1168 TEST_F(FormatTest, SplitsLongCxxComments) { 1169 EXPECT_EQ("// A comment that\n" 1170 "// doesn't fit on\n" 1171 "// one line", 1172 format("// A comment that doesn't fit on one line", 1173 getLLVMStyleWithColumns(20))); 1174 EXPECT_EQ("// a b c d\n" 1175 "// e f g\n" 1176 "// h i j k", 1177 format("// a b c d e f g h i j k", 1178 getLLVMStyleWithColumns(10))); 1179 EXPECT_EQ("// a b c d\n" 1180 "// e f g\n" 1181 "// h i j k", 1182 format("\\\n// a b c d e f g h i j k", 1183 getLLVMStyleWithColumns(10))); 1184 EXPECT_EQ("if (true) // A comment that\n" 1185 " // doesn't fit on\n" 1186 " // one line", 1187 format("if (true) // A comment that doesn't fit on one line ", 1188 getLLVMStyleWithColumns(30))); 1189 EXPECT_EQ("// Don't_touch_leading_whitespace", 1190 format("// Don't_touch_leading_whitespace", 1191 getLLVMStyleWithColumns(20))); 1192 EXPECT_EQ("// Add leading\n" 1193 "// whitespace", 1194 format("//Add leading whitespace", getLLVMStyleWithColumns(20))); 1195 EXPECT_EQ("// whitespace", format("//whitespace", getLLVMStyle())); 1196 EXPECT_EQ("// Even if it makes the line exceed the column\n" 1197 "// limit", 1198 format("//Even if it makes the line exceed the column limit", 1199 getLLVMStyleWithColumns(51))); 1200 EXPECT_EQ("//--But not here", format("//--But not here", getLLVMStyle())); 1201 1202 EXPECT_EQ("// aa bb cc dd", 1203 format("// aa bb cc dd ", 1204 getLLVMStyleWithColumns(15))); 1205 1206 EXPECT_EQ("// A comment before\n" 1207 "// a macro\n" 1208 "// definition\n" 1209 "#define a b", 1210 format("// A comment before a macro definition\n" 1211 "#define a b", 1212 getLLVMStyleWithColumns(20))); 1213 EXPECT_EQ("void\n" 1214 "ffffff(int aaaaaaaaa, // wwww\n" 1215 " int bbbbbbbbbb, // xxxxxxx\n" 1216 " // yyyyyyyyyy\n" 1217 " int c, int d, int e) {}", 1218 format("void ffffff(\n" 1219 " int aaaaaaaaa, // wwww\n" 1220 " int bbbbbbbbbb, // xxxxxxx yyyyyyyyyy\n" 1221 " int c, int d, int e) {}", 1222 getLLVMStyleWithColumns(40))); 1223 EXPECT_EQ("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1224 format("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1225 getLLVMStyleWithColumns(20))); 1226 EXPECT_EQ( 1227 "#define XXX // a b c d\n" 1228 " // e f g h", 1229 format("#define XXX // a b c d e f g h", getLLVMStyleWithColumns(22))); 1230 EXPECT_EQ( 1231 "#define XXX // q w e r\n" 1232 " // t y u i", 1233 format("#define XXX //q w e r t y u i", getLLVMStyleWithColumns(22))); 1234 } 1235 1236 TEST_F(FormatTest, PreservesHangingIndentInCxxComments) { 1237 EXPECT_EQ("// A comment\n" 1238 "// that doesn't\n" 1239 "// fit on one\n" 1240 "// line", 1241 format("// A comment that doesn't fit on one line", 1242 getLLVMStyleWithColumns(20))); 1243 EXPECT_EQ("/// A comment\n" 1244 "/// that doesn't\n" 1245 "/// fit on one\n" 1246 "/// line", 1247 format("/// A comment that doesn't fit on one line", 1248 getLLVMStyleWithColumns(20))); 1249 } 1250 1251 TEST_F(FormatTest, DontSplitLineCommentsWithEscapedNewlines) { 1252 EXPECT_EQ("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1253 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1254 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1255 format("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1256 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1257 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")); 1258 EXPECT_EQ("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1259 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1260 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1261 format("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1262 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1263 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1264 getLLVMStyleWithColumns(50))); 1265 // FIXME: One day we might want to implement adjustment of leading whitespace 1266 // of the consecutive lines in this kind of comment: 1267 EXPECT_EQ("double\n" 1268 " a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1269 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1270 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1271 format("double a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1272 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1273 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1274 getLLVMStyleWithColumns(49))); 1275 } 1276 1277 TEST_F(FormatTest, DontSplitLineCommentsWithPragmas) { 1278 FormatStyle Pragmas = getLLVMStyleWithColumns(30); 1279 Pragmas.CommentPragmas = "^ IWYU pragma:"; 1280 EXPECT_EQ( 1281 "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", 1282 format("// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", Pragmas)); 1283 EXPECT_EQ( 1284 "/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", 1285 format("/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", Pragmas)); 1286 } 1287 1288 TEST_F(FormatTest, PriorityOfCommentBreaking) { 1289 EXPECT_EQ("if (xxx ==\n" 1290 " yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1291 " zzz)\n" 1292 " q();", 1293 format("if (xxx == yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1294 " zzz) q();", 1295 getLLVMStyleWithColumns(40))); 1296 EXPECT_EQ("if (xxxxxxxxxx ==\n" 1297 " yyy && // aaaaaa bbbbbbbb cccc\n" 1298 " zzz)\n" 1299 " q();", 1300 format("if (xxxxxxxxxx == yyy && // aaaaaa bbbbbbbb cccc\n" 1301 " zzz) q();", 1302 getLLVMStyleWithColumns(40))); 1303 EXPECT_EQ("if (xxxxxxxxxx &&\n" 1304 " yyy || // aaaaaa bbbbbbbb cccc\n" 1305 " zzz)\n" 1306 " q();", 1307 format("if (xxxxxxxxxx && yyy || // aaaaaa bbbbbbbb cccc\n" 1308 " zzz) q();", 1309 getLLVMStyleWithColumns(40))); 1310 EXPECT_EQ("fffffffff(\n" 1311 " &xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1312 " zzz);", 1313 format("fffffffff(&xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1314 " zzz);", 1315 getLLVMStyleWithColumns(40))); 1316 } 1317 1318 TEST_F(FormatTest, MultiLineCommentsInDefines) { 1319 EXPECT_EQ("#define A(x) /* \\\n" 1320 " a comment \\\n" 1321 " inside */ \\\n" 1322 " f();", 1323 format("#define A(x) /* \\\n" 1324 " a comment \\\n" 1325 " inside */ \\\n" 1326 " f();", 1327 getLLVMStyleWithColumns(17))); 1328 EXPECT_EQ("#define A( \\\n" 1329 " x) /* \\\n" 1330 " a comment \\\n" 1331 " inside */ \\\n" 1332 " f();", 1333 format("#define A( \\\n" 1334 " x) /* \\\n" 1335 " a comment \\\n" 1336 " inside */ \\\n" 1337 " f();", 1338 getLLVMStyleWithColumns(17))); 1339 } 1340 1341 TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) { 1342 EXPECT_EQ("namespace {}\n// Test\n#define A", 1343 format("namespace {}\n // Test\n#define A")); 1344 EXPECT_EQ("namespace {}\n/* Test */\n#define A", 1345 format("namespace {}\n /* Test */\n#define A")); 1346 EXPECT_EQ("namespace {}\n/* Test */ #define A", 1347 format("namespace {}\n /* Test */ #define A")); 1348 } 1349 1350 TEST_F(FormatTest, SplitsLongLinesInComments) { 1351 EXPECT_EQ("/* This is a long\n" 1352 " * comment that\n" 1353 " * doesn't\n" 1354 " * fit on one line.\n" 1355 " */", 1356 format("/* " 1357 "This is a long " 1358 "comment that " 1359 "doesn't " 1360 "fit on one line. */", 1361 getLLVMStyleWithColumns(20))); 1362 EXPECT_EQ("/* a b c d\n" 1363 " * e f g\n" 1364 " * h i j k\n" 1365 " */", 1366 format("/* a b c d e f g h i j k */", 1367 getLLVMStyleWithColumns(10))); 1368 EXPECT_EQ("/* a b c d\n" 1369 " * e f g\n" 1370 " * h i j k\n" 1371 " */", 1372 format("\\\n/* a b c d e f g h i j k */", 1373 getLLVMStyleWithColumns(10))); 1374 EXPECT_EQ("/*\n" 1375 "This is a long\n" 1376 "comment that doesn't\n" 1377 "fit on one line.\n" 1378 "*/", 1379 format("/*\n" 1380 "This is a long " 1381 "comment that doesn't " 1382 "fit on one line. \n" 1383 "*/", getLLVMStyleWithColumns(20))); 1384 EXPECT_EQ("/*\n" 1385 " * This is a long\n" 1386 " * comment that\n" 1387 " * doesn't fit on\n" 1388 " * one line.\n" 1389 " */", 1390 format("/* \n" 1391 " * This is a long " 1392 " comment that " 1393 " doesn't fit on " 1394 " one line. \n" 1395 " */", getLLVMStyleWithColumns(20))); 1396 EXPECT_EQ("/*\n" 1397 " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n" 1398 " * so_it_should_be_broken\n" 1399 " * wherever_a_space_occurs\n" 1400 " */", 1401 format("/*\n" 1402 " * This_is_a_comment_with_words_that_dont_fit_on_one_line " 1403 " so_it_should_be_broken " 1404 " wherever_a_space_occurs \n" 1405 " */", 1406 getLLVMStyleWithColumns(20))); 1407 EXPECT_EQ("/*\n" 1408 " * This_comment_can_not_be_broken_into_lines\n" 1409 " */", 1410 format("/*\n" 1411 " * This_comment_can_not_be_broken_into_lines\n" 1412 " */", 1413 getLLVMStyleWithColumns(20))); 1414 EXPECT_EQ("{\n" 1415 " /*\n" 1416 " This is another\n" 1417 " long comment that\n" 1418 " doesn't fit on one\n" 1419 " line 1234567890\n" 1420 " */\n" 1421 "}", 1422 format("{\n" 1423 "/*\n" 1424 "This is another " 1425 " long comment that " 1426 " doesn't fit on one" 1427 " line 1234567890\n" 1428 "*/\n" 1429 "}", getLLVMStyleWithColumns(20))); 1430 EXPECT_EQ("{\n" 1431 " /*\n" 1432 " * This i s\n" 1433 " * another comment\n" 1434 " * t hat doesn' t\n" 1435 " * fit on one l i\n" 1436 " * n e\n" 1437 " */\n" 1438 "}", 1439 format("{\n" 1440 "/*\n" 1441 " * This i s" 1442 " another comment" 1443 " t hat doesn' t" 1444 " fit on one l i" 1445 " n e\n" 1446 " */\n" 1447 "}", getLLVMStyleWithColumns(20))); 1448 EXPECT_EQ("/*\n" 1449 " * This is a long\n" 1450 " * comment that\n" 1451 " * doesn't fit on\n" 1452 " * one line\n" 1453 " */", 1454 format(" /*\n" 1455 " * This is a long comment that doesn't fit on one line\n" 1456 " */", getLLVMStyleWithColumns(20))); 1457 EXPECT_EQ("{\n" 1458 " if (something) /* This is a\n" 1459 " long\n" 1460 " comment */\n" 1461 " ;\n" 1462 "}", 1463 format("{\n" 1464 " if (something) /* This is a long comment */\n" 1465 " ;\n" 1466 "}", 1467 getLLVMStyleWithColumns(30))); 1468 1469 EXPECT_EQ("/* A comment before\n" 1470 " * a macro\n" 1471 " * definition */\n" 1472 "#define a b", 1473 format("/* A comment before a macro definition */\n" 1474 "#define a b", 1475 getLLVMStyleWithColumns(20))); 1476 1477 EXPECT_EQ("/* some comment\n" 1478 " * a comment\n" 1479 "* that we break\n" 1480 " * another comment\n" 1481 "* we have to break\n" 1482 "* a left comment\n" 1483 " */", 1484 format(" /* some comment\n" 1485 " * a comment that we break\n" 1486 " * another comment we have to break\n" 1487 "* a left comment\n" 1488 " */", 1489 getLLVMStyleWithColumns(20))); 1490 1491 EXPECT_EQ("/*\n" 1492 "\n" 1493 "\n" 1494 " */\n", 1495 format(" /* \n" 1496 " \n" 1497 " \n" 1498 " */\n")); 1499 1500 EXPECT_EQ("/* a a */", 1501 format("/* a a */", getLLVMStyleWithColumns(15))); 1502 EXPECT_EQ("/* a a bc */", 1503 format("/* a a bc */", getLLVMStyleWithColumns(15))); 1504 EXPECT_EQ("/* aaa aaa\n" 1505 " * aaaaa */", 1506 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1507 EXPECT_EQ("/* aaa aaa\n" 1508 " * aaaaa */", 1509 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1510 } 1511 1512 TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) { 1513 EXPECT_EQ("#define X \\\n" 1514 " /* \\\n" 1515 " Test \\\n" 1516 " Macro comment \\\n" 1517 " with a long \\\n" 1518 " line \\\n" 1519 " */ \\\n" 1520 " A + B", 1521 format("#define X \\\n" 1522 " /*\n" 1523 " Test\n" 1524 " Macro comment with a long line\n" 1525 " */ \\\n" 1526 " A + B", 1527 getLLVMStyleWithColumns(20))); 1528 EXPECT_EQ("#define X \\\n" 1529 " /* Macro comment \\\n" 1530 " with a long \\\n" 1531 " line */ \\\n" 1532 " A + B", 1533 format("#define X \\\n" 1534 " /* Macro comment with a long\n" 1535 " line */ \\\n" 1536 " A + B", 1537 getLLVMStyleWithColumns(20))); 1538 EXPECT_EQ("#define X \\\n" 1539 " /* Macro comment \\\n" 1540 " * with a long \\\n" 1541 " * line */ \\\n" 1542 " A + B", 1543 format("#define X \\\n" 1544 " /* Macro comment with a long line */ \\\n" 1545 " A + B", 1546 getLLVMStyleWithColumns(20))); 1547 } 1548 1549 TEST_F(FormatTest, CommentsInStaticInitializers) { 1550 EXPECT_EQ( 1551 "static SomeType type = {aaaaaaaaaaaaaaaaaaaa, /* comment */\n" 1552 " aaaaaaaaaaaaaaaaaaaa /* comment */,\n" 1553 " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n" 1554 " aaaaaaaaaaaaaaaaaaaa, // comment\n" 1555 " aaaaaaaaaaaaaaaaaaaa};", 1556 format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n" 1557 " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n" 1558 " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n" 1559 " aaaaaaaaaaaaaaaaaaaa , // comment\n" 1560 " aaaaaaaaaaaaaaaaaaaa };")); 1561 verifyFormat("static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1562 " bbbbbbbbbbb, ccccccccccc};"); 1563 verifyFormat("static SomeType type = {aaaaaaaaaaa,\n" 1564 " // comment for bb....\n" 1565 " bbbbbbbbbbb, ccccccccccc};"); 1566 verifyGoogleFormat( 1567 "static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1568 " bbbbbbbbbbb, ccccccccccc};"); 1569 verifyGoogleFormat("static SomeType type = {aaaaaaaaaaa,\n" 1570 " // comment for bb....\n" 1571 " bbbbbbbbbbb, ccccccccccc};"); 1572 1573 verifyFormat("S s = {{a, b, c}, // Group #1\n" 1574 " {d, e, f}, // Group #2\n" 1575 " {g, h, i}}; // Group #3"); 1576 verifyFormat("S s = {{// Group #1\n" 1577 " a, b, c},\n" 1578 " {// Group #2\n" 1579 " d, e, f},\n" 1580 " {// Group #3\n" 1581 " g, h, i}};"); 1582 1583 EXPECT_EQ("S s = {\n" 1584 " // Some comment\n" 1585 " a,\n" 1586 "\n" 1587 " // Comment after empty line\n" 1588 " b}", 1589 format("S s = {\n" 1590 " // Some comment\n" 1591 " a,\n" 1592 " \n" 1593 " // Comment after empty line\n" 1594 " b\n" 1595 "}")); 1596 EXPECT_EQ("S s = {\n" 1597 " /* Some comment */\n" 1598 " a,\n" 1599 "\n" 1600 " /* Comment after empty line */\n" 1601 " b}", 1602 format("S s = {\n" 1603 " /* Some comment */\n" 1604 " a,\n" 1605 " \n" 1606 " /* Comment after empty line */\n" 1607 " b\n" 1608 "}")); 1609 verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n" 1610 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1611 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1612 " 0x00, 0x00, 0x00, 0x00}; // comment\n"); 1613 } 1614 1615 TEST_F(FormatTest, IgnoresIf0Contents) { 1616 EXPECT_EQ("#if 0\n" 1617 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1618 "#endif\n" 1619 "void f() {}", 1620 format("#if 0\n" 1621 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1622 "#endif\n" 1623 "void f( ) { }")); 1624 EXPECT_EQ("#if false\n" 1625 "void f( ) { }\n" 1626 "#endif\n" 1627 "void g() {}\n", 1628 format("#if false\n" 1629 "void f( ) { }\n" 1630 "#endif\n" 1631 "void g( ) { }\n")); 1632 EXPECT_EQ("enum E {\n" 1633 " One,\n" 1634 " Two,\n" 1635 "#if 0\n" 1636 "Three,\n" 1637 " Four,\n" 1638 "#endif\n" 1639 " Five\n" 1640 "};", 1641 format("enum E {\n" 1642 " One,Two,\n" 1643 "#if 0\n" 1644 "Three,\n" 1645 " Four,\n" 1646 "#endif\n" 1647 " Five};")); 1648 EXPECT_EQ("enum F {\n" 1649 " One,\n" 1650 "#if 1\n" 1651 " Two,\n" 1652 "#if 0\n" 1653 "Three,\n" 1654 " Four,\n" 1655 "#endif\n" 1656 " Five\n" 1657 "#endif\n" 1658 "};", 1659 format("enum F {\n" 1660 "One,\n" 1661 "#if 1\n" 1662 "Two,\n" 1663 "#if 0\n" 1664 "Three,\n" 1665 " Four,\n" 1666 "#endif\n" 1667 "Five\n" 1668 "#endif\n" 1669 "};")); 1670 EXPECT_EQ("enum G {\n" 1671 " One,\n" 1672 "#if 0\n" 1673 "Two,\n" 1674 "#else\n" 1675 " Three,\n" 1676 "#endif\n" 1677 " Four\n" 1678 "};", 1679 format("enum G {\n" 1680 "One,\n" 1681 "#if 0\n" 1682 "Two,\n" 1683 "#else\n" 1684 "Three,\n" 1685 "#endif\n" 1686 "Four\n" 1687 "};")); 1688 EXPECT_EQ("enum H {\n" 1689 " One,\n" 1690 "#if 0\n" 1691 "#ifdef Q\n" 1692 "Two,\n" 1693 "#else\n" 1694 "Three,\n" 1695 "#endif\n" 1696 "#endif\n" 1697 " Four\n" 1698 "};", 1699 format("enum H {\n" 1700 "One,\n" 1701 "#if 0\n" 1702 "#ifdef Q\n" 1703 "Two,\n" 1704 "#else\n" 1705 "Three,\n" 1706 "#endif\n" 1707 "#endif\n" 1708 "Four\n" 1709 "};")); 1710 EXPECT_EQ("enum I {\n" 1711 " One,\n" 1712 "#if /* test */ 0 || 1\n" 1713 "Two,\n" 1714 "Three,\n" 1715 "#endif\n" 1716 " Four\n" 1717 "};", 1718 format("enum I {\n" 1719 "One,\n" 1720 "#if /* test */ 0 || 1\n" 1721 "Two,\n" 1722 "Three,\n" 1723 "#endif\n" 1724 "Four\n" 1725 "};")); 1726 EXPECT_EQ("enum J {\n" 1727 " One,\n" 1728 "#if 0\n" 1729 "#if 0\n" 1730 "Two,\n" 1731 "#else\n" 1732 "Three,\n" 1733 "#endif\n" 1734 "Four,\n" 1735 "#endif\n" 1736 " Five\n" 1737 "};", 1738 format("enum J {\n" 1739 "One,\n" 1740 "#if 0\n" 1741 "#if 0\n" 1742 "Two,\n" 1743 "#else\n" 1744 "Three,\n" 1745 "#endif\n" 1746 "Four,\n" 1747 "#endif\n" 1748 "Five\n" 1749 "};")); 1750 1751 } 1752 1753 //===----------------------------------------------------------------------===// 1754 // Tests for classes, namespaces, etc. 1755 //===----------------------------------------------------------------------===// 1756 1757 TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) { 1758 verifyFormat("class A {};"); 1759 } 1760 1761 TEST_F(FormatTest, UnderstandsAccessSpecifiers) { 1762 verifyFormat("class A {\n" 1763 "public:\n" 1764 "public: // comment\n" 1765 "protected:\n" 1766 "private:\n" 1767 " void f() {}\n" 1768 "};"); 1769 verifyGoogleFormat("class A {\n" 1770 " public:\n" 1771 " protected:\n" 1772 " private:\n" 1773 " void f() {}\n" 1774 "};"); 1775 verifyFormat("class A {\n" 1776 "public slots:\n" 1777 " void f() {}\n" 1778 "public Q_SLOTS:\n" 1779 " void f() {}\n" 1780 "};"); 1781 } 1782 1783 TEST_F(FormatTest, SeparatesLogicalBlocks) { 1784 EXPECT_EQ("class A {\n" 1785 "public:\n" 1786 " void f();\n" 1787 "\n" 1788 "private:\n" 1789 " void g() {}\n" 1790 " // test\n" 1791 "protected:\n" 1792 " int h;\n" 1793 "};", 1794 format("class A {\n" 1795 "public:\n" 1796 "void f();\n" 1797 "private:\n" 1798 "void g() {}\n" 1799 "// test\n" 1800 "protected:\n" 1801 "int h;\n" 1802 "};")); 1803 EXPECT_EQ("class A {\n" 1804 "protected:\n" 1805 "public:\n" 1806 " void f();\n" 1807 "};", 1808 format("class A {\n" 1809 "protected:\n" 1810 "\n" 1811 "public:\n" 1812 "\n" 1813 " void f();\n" 1814 "};")); 1815 } 1816 1817 TEST_F(FormatTest, FormatsClasses) { 1818 verifyFormat("class A : public B {};"); 1819 verifyFormat("class A : public ::B {};"); 1820 1821 verifyFormat( 1822 "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1823 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1824 verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n" 1825 " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1826 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1827 verifyFormat( 1828 "class A : public B, public C, public D, public E, public F {};"); 1829 verifyFormat("class AAAAAAAAAAAA : public B,\n" 1830 " public C,\n" 1831 " public D,\n" 1832 " public E,\n" 1833 " public F,\n" 1834 " public G {};"); 1835 1836 verifyFormat("class\n" 1837 " ReallyReallyLongClassName {\n" 1838 " int i;\n" 1839 "};", 1840 getLLVMStyleWithColumns(32)); 1841 verifyFormat("struct aaaaaaaaaaaaa : public aaaaaaaaaaaaaaaaaaa< // break\n" 1842 " aaaaaaaaaaaaaaaa> {};"); 1843 verifyFormat("struct aaaaaaaaaaaaaaaaaaaa\n" 1844 " : public aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaa,\n" 1845 " aaaaaaaaaaaaaaaaaaaaaa> {};"); 1846 verifyFormat("template <class R, class C>\n" 1847 "struct Aaaaaaaaaaaaaaaaa<R (C::*)(int) const>\n" 1848 " : Aaaaaaaaaaaaaaaaa<R (C::*)(int)> {};"); 1849 verifyFormat("class ::A::B {};"); 1850 } 1851 1852 TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) { 1853 verifyFormat("class A {\n} a, b;"); 1854 verifyFormat("struct A {\n} a, b;"); 1855 verifyFormat("union A {\n} a;"); 1856 } 1857 1858 TEST_F(FormatTest, FormatsEnum) { 1859 verifyFormat("enum {\n" 1860 " Zero,\n" 1861 " One = 1,\n" 1862 " Two = One + 1,\n" 1863 " Three = (One + Two),\n" 1864 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1865 " Five = (One, Two, Three, Four, 5)\n" 1866 "};"); 1867 verifyGoogleFormat("enum {\n" 1868 " Zero,\n" 1869 " One = 1,\n" 1870 " Two = One + 1,\n" 1871 " Three = (One + Two),\n" 1872 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1873 " Five = (One, Two, Three, Four, 5)\n" 1874 "};"); 1875 verifyFormat("enum Enum {};"); 1876 verifyFormat("enum {};"); 1877 verifyFormat("enum X E {} d;"); 1878 verifyFormat("enum __attribute__((...)) E {} d;"); 1879 verifyFormat("enum __declspec__((...)) E {} d;"); 1880 verifyFormat("enum X f() {\n a();\n return 42;\n}"); 1881 verifyFormat("enum {\n" 1882 " Bar = Foo<int, int>::value\n" 1883 "};", 1884 getLLVMStyleWithColumns(30)); 1885 1886 verifyFormat("enum ShortEnum { A, B, C };"); 1887 verifyGoogleFormat("enum ShortEnum { A, B, C };"); 1888 1889 EXPECT_EQ("enum KeepEmptyLines {\n" 1890 " ONE,\n" 1891 "\n" 1892 " TWO,\n" 1893 "\n" 1894 " THREE\n" 1895 "}", 1896 format("enum KeepEmptyLines {\n" 1897 " ONE,\n" 1898 "\n" 1899 " TWO,\n" 1900 "\n" 1901 "\n" 1902 " THREE\n" 1903 "}")); 1904 verifyFormat("enum E { // comment\n" 1905 " ONE,\n" 1906 " TWO\n" 1907 "};"); 1908 } 1909 1910 TEST_F(FormatTest, FormatsEnumsWithErrors) { 1911 verifyFormat("enum Type {\n" 1912 " One = 0; // These semicolons should be commas.\n" 1913 " Two = 1;\n" 1914 "};"); 1915 verifyFormat("namespace n {\n" 1916 "enum Type {\n" 1917 " One,\n" 1918 " Two, // missing };\n" 1919 " int i;\n" 1920 "}\n" 1921 "void g() {}"); 1922 } 1923 1924 TEST_F(FormatTest, FormatsEnumStruct) { 1925 verifyFormat("enum struct {\n" 1926 " Zero,\n" 1927 " One = 1,\n" 1928 " Two = One + 1,\n" 1929 " Three = (One + Two),\n" 1930 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1931 " Five = (One, Two, Three, Four, 5)\n" 1932 "};"); 1933 verifyFormat("enum struct Enum {};"); 1934 verifyFormat("enum struct {};"); 1935 verifyFormat("enum struct X E {} d;"); 1936 verifyFormat("enum struct __attribute__((...)) E {} d;"); 1937 verifyFormat("enum struct __declspec__((...)) E {} d;"); 1938 verifyFormat("enum struct X f() {\n a();\n return 42;\n}"); 1939 } 1940 1941 TEST_F(FormatTest, FormatsEnumClass) { 1942 verifyFormat("enum class {\n" 1943 " Zero,\n" 1944 " One = 1,\n" 1945 " Two = One + 1,\n" 1946 " Three = (One + Two),\n" 1947 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1948 " Five = (One, Two, Three, Four, 5)\n" 1949 "};"); 1950 verifyFormat("enum class Enum {};"); 1951 verifyFormat("enum class {};"); 1952 verifyFormat("enum class X E {} d;"); 1953 verifyFormat("enum class __attribute__((...)) E {} d;"); 1954 verifyFormat("enum class __declspec__((...)) E {} d;"); 1955 verifyFormat("enum class X f() {\n a();\n return 42;\n}"); 1956 } 1957 1958 TEST_F(FormatTest, FormatsEnumTypes) { 1959 verifyFormat("enum X : int {\n" 1960 " A, // Force multiple lines.\n" 1961 " B\n" 1962 "};"); 1963 verifyFormat("enum X : int { A, B };"); 1964 verifyFormat("enum X : std::uint32_t { A, B };"); 1965 } 1966 1967 TEST_F(FormatTest, FormatsNSEnums) { 1968 verifyGoogleFormat("typedef NS_ENUM(NSInteger, SomeName) { AAA, BBB }"); 1969 verifyGoogleFormat("typedef NS_ENUM(NSInteger, MyType) {\n" 1970 " // Information about someDecentlyLongValue.\n" 1971 " someDecentlyLongValue,\n" 1972 " // Information about anotherDecentlyLongValue.\n" 1973 " anotherDecentlyLongValue,\n" 1974 " // Information about aThirdDecentlyLongValue.\n" 1975 " aThirdDecentlyLongValue\n" 1976 "};"); 1977 } 1978 1979 TEST_F(FormatTest, FormatsBitfields) { 1980 verifyFormat("struct Bitfields {\n" 1981 " unsigned sClass : 8;\n" 1982 " unsigned ValueKind : 2;\n" 1983 "};"); 1984 verifyFormat("struct A {\n" 1985 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa : 1,\n" 1986 " bbbbbbbbbbbbbbbbbbbbbbbbb;\n" 1987 "};"); 1988 } 1989 1990 TEST_F(FormatTest, FormatsNamespaces) { 1991 verifyFormat("namespace some_namespace {\n" 1992 "class A {};\n" 1993 "void f() { f(); }\n" 1994 "}"); 1995 verifyFormat("namespace {\n" 1996 "class A {};\n" 1997 "void f() { f(); }\n" 1998 "}"); 1999 verifyFormat("inline namespace X {\n" 2000 "class A {};\n" 2001 "void f() { f(); }\n" 2002 "}"); 2003 verifyFormat("using namespace some_namespace;\n" 2004 "class A {};\n" 2005 "void f() { f(); }"); 2006 2007 // This code is more common than we thought; if we 2008 // layout this correctly the semicolon will go into 2009 // its own line, which is undesirable. 2010 verifyFormat("namespace {};"); 2011 verifyFormat("namespace {\n" 2012 "class A {};\n" 2013 "};"); 2014 2015 verifyFormat("namespace {\n" 2016 "int SomeVariable = 0; // comment\n" 2017 "} // namespace"); 2018 EXPECT_EQ("#ifndef HEADER_GUARD\n" 2019 "#define HEADER_GUARD\n" 2020 "namespace my_namespace {\n" 2021 "int i;\n" 2022 "} // my_namespace\n" 2023 "#endif // HEADER_GUARD", 2024 format("#ifndef HEADER_GUARD\n" 2025 " #define HEADER_GUARD\n" 2026 " namespace my_namespace {\n" 2027 "int i;\n" 2028 "} // my_namespace\n" 2029 "#endif // HEADER_GUARD")); 2030 2031 FormatStyle Style = getLLVMStyle(); 2032 Style.NamespaceIndentation = FormatStyle::NI_All; 2033 EXPECT_EQ("namespace out {\n" 2034 " int i;\n" 2035 " namespace in {\n" 2036 " int i;\n" 2037 " } // namespace\n" 2038 "} // namespace", 2039 format("namespace out {\n" 2040 "int i;\n" 2041 "namespace in {\n" 2042 "int i;\n" 2043 "} // namespace\n" 2044 "} // namespace", 2045 Style)); 2046 2047 Style.NamespaceIndentation = FormatStyle::NI_Inner; 2048 EXPECT_EQ("namespace out {\n" 2049 "int i;\n" 2050 "namespace in {\n" 2051 " int i;\n" 2052 "} // namespace\n" 2053 "} // namespace", 2054 format("namespace out {\n" 2055 "int i;\n" 2056 "namespace in {\n" 2057 "int i;\n" 2058 "} // namespace\n" 2059 "} // namespace", 2060 Style)); 2061 } 2062 2063 TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); } 2064 2065 TEST_F(FormatTest, FormatsInlineASM) { 2066 verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));"); 2067 verifyFormat( 2068 "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n" 2069 " \"cpuid\\n\\t\"\n" 2070 " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n" 2071 " : \"=a\"(*rEAX), \"=S\"(*rEBX), \"=c\"(*rECX), \"=d\"(*rEDX)\n" 2072 " : \"a\"(value));"); 2073 } 2074 2075 TEST_F(FormatTest, FormatTryCatch) { 2076 verifyFormat("try {\n" 2077 " throw a * b;\n" 2078 "} catch (int a) {\n" 2079 " // Do nothing.\n" 2080 "} catch (...) {\n" 2081 " exit(42);\n" 2082 "}"); 2083 2084 // Function-level try statements. 2085 verifyFormat("int f() try { return 4; } catch (...) {\n" 2086 " return 5;\n" 2087 "}"); 2088 verifyFormat("class A {\n" 2089 " int a;\n" 2090 " A() try : a(0) {\n" 2091 " } catch (...) {\n" 2092 " throw;\n" 2093 " }\n" 2094 "};\n"); 2095 } 2096 2097 TEST_F(FormatTest, IncompleteTryCatchBlocks) { 2098 verifyFormat("try {\n" 2099 " f();\n" 2100 "} catch {\n" 2101 " g();\n" 2102 "}"); 2103 verifyFormat("try {\n" 2104 " f();\n" 2105 "} catch (A a) MACRO(x) {\n" 2106 " g();\n" 2107 "} catch (B b) MACRO(x) {\n" 2108 " g();\n" 2109 "}"); 2110 } 2111 2112 TEST_F(FormatTest, FormatTryCatchBraceStyles) { 2113 FormatStyle Style = getLLVMStyle(); 2114 Style.BreakBeforeBraces = FormatStyle::BS_Attach; 2115 verifyFormat("try {\n" 2116 " // something\n" 2117 "} catch (...) {\n" 2118 " // something\n" 2119 "}", 2120 Style); 2121 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 2122 verifyFormat("try {\n" 2123 " // something\n" 2124 "}\n" 2125 "catch (...) {\n" 2126 " // something\n" 2127 "}", 2128 Style); 2129 Style.BreakBeforeBraces = FormatStyle::BS_Allman; 2130 verifyFormat("try\n" 2131 "{\n" 2132 " // something\n" 2133 "}\n" 2134 "catch (...)\n" 2135 "{\n" 2136 " // something\n" 2137 "}", 2138 Style); 2139 Style.BreakBeforeBraces = FormatStyle::BS_GNU; 2140 verifyFormat("try\n" 2141 " {\n" 2142 " // something\n" 2143 " }\n" 2144 "catch (...)\n" 2145 " {\n" 2146 " // something\n" 2147 " }", 2148 Style); 2149 } 2150 2151 TEST_F(FormatTest, FormatObjCTryCatch) { 2152 verifyFormat("@try {\n" 2153 " f();\n" 2154 "}\n" 2155 "@catch (NSException e) {\n" 2156 " @throw;\n" 2157 "}\n" 2158 "@finally {\n" 2159 " exit(42);\n" 2160 "}"); 2161 } 2162 2163 TEST_F(FormatTest, StaticInitializers) { 2164 verifyFormat("static SomeClass SC = {1, 'a'};"); 2165 2166 verifyFormat( 2167 "static SomeClass WithALoooooooooooooooooooongName = {\n" 2168 " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"};"); 2169 2170 // Here, everything other than the "}" would fit on a line. 2171 verifyFormat("static int LooooooooooooooooooooooooongVariable[1] = {\n" 2172 " 10000000000000000000000000};"); 2173 EXPECT_EQ("S s = {a,\n" 2174 "\n" 2175 " b};", 2176 format("S s = {\n" 2177 " a,\n" 2178 "\n" 2179 " b\n" 2180 "};")); 2181 2182 // FIXME: This would fit into the column limit if we'd fit "{ {" on the first 2183 // line. However, the formatting looks a bit off and this probably doesn't 2184 // happen often in practice. 2185 verifyFormat("static int Variable[1] = {\n" 2186 " {1000000000000000000000000000000000000}};", 2187 getLLVMStyleWithColumns(40)); 2188 } 2189 2190 TEST_F(FormatTest, DesignatedInitializers) { 2191 verifyFormat("const struct A a = {.a = 1, .b = 2};"); 2192 verifyFormat("const struct A a = {.aaaaaaaaaa = 1,\n" 2193 " .bbbbbbbbbb = 2,\n" 2194 " .cccccccccc = 3,\n" 2195 " .dddddddddd = 4,\n" 2196 " .eeeeeeeeee = 5};"); 2197 verifyFormat("const struct Aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa = {\n" 2198 " .aaaaaaaaaaaaaaaaaaaaaaaaaaa = 1,\n" 2199 " .bbbbbbbbbbbbbbbbbbbbbbbbbbb = 2,\n" 2200 " .ccccccccccccccccccccccccccc = 3,\n" 2201 " .ddddddddddddddddddddddddddd = 4,\n" 2202 " .eeeeeeeeeeeeeeeeeeeeeeeeeee = 5};"); 2203 2204 verifyGoogleFormat("const struct A a = {.a = 1, .b = 2};"); 2205 } 2206 2207 TEST_F(FormatTest, NestedStaticInitializers) { 2208 verifyFormat("static A x = {{{}}};\n"); 2209 verifyFormat("static A x = {{{init1, init2, init3, init4},\n" 2210 " {init1, init2, init3, init4}}};", 2211 getLLVMStyleWithColumns(50)); 2212 2213 verifyFormat("somes Status::global_reps[3] = {\n" 2214 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 2215 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 2216 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};", 2217 getLLVMStyleWithColumns(60)); 2218 verifyGoogleFormat("SomeType Status::global_reps[3] = {\n" 2219 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 2220 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 2221 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};"); 2222 verifyFormat( 2223 "CGRect cg_rect = {{rect.fLeft, rect.fTop},\n" 2224 " {rect.fRight - rect.fLeft, rect.fBottom - rect.fTop}};"); 2225 2226 verifyFormat( 2227 "SomeArrayOfSomeType a = {\n" 2228 " {{1, 2, 3},\n" 2229 " {1, 2, 3},\n" 2230 " {111111111111111111111111111111, 222222222222222222222222222222,\n" 2231 " 333333333333333333333333333333},\n" 2232 " {1, 2, 3},\n" 2233 " {1, 2, 3}}};"); 2234 verifyFormat( 2235 "SomeArrayOfSomeType a = {\n" 2236 " {{1, 2, 3}},\n" 2237 " {{1, 2, 3}},\n" 2238 " {{111111111111111111111111111111, 222222222222222222222222222222,\n" 2239 " 333333333333333333333333333333}},\n" 2240 " {{1, 2, 3}},\n" 2241 " {{1, 2, 3}}};"); 2242 2243 verifyFormat( 2244 "struct {\n" 2245 " unsigned bit;\n" 2246 " const char *const name;\n" 2247 "} kBitsToOs[] = {{kOsMac, \"Mac\"},\n" 2248 " {kOsWin, \"Windows\"},\n" 2249 " {kOsLinux, \"Linux\"},\n" 2250 " {kOsCrOS, \"Chrome OS\"}};"); 2251 } 2252 2253 TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) { 2254 verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2255 " \\\n" 2256 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)"); 2257 } 2258 2259 TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) { 2260 verifyFormat("virtual void write(ELFWriter *writerrr,\n" 2261 " OwningPtr<FileOutputBuffer> &buffer) = 0;"); 2262 } 2263 2264 TEST_F(FormatTest, BreaksStringLiteralsOnlyInDefine) { 2265 verifyFormat("# 1111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\" 2 3", 2266 getLLVMStyleWithColumns(40)); 2267 verifyFormat("#line 11111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 2268 getLLVMStyleWithColumns(40)); 2269 EXPECT_EQ("#define Q \\\n" 2270 " \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/\" \\\n" 2271 " \"aaaaaaaa.cpp\"", 2272 format("#define Q \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 2273 getLLVMStyleWithColumns(40))); 2274 } 2275 2276 TEST_F(FormatTest, UnderstandsLinePPDirective) { 2277 EXPECT_EQ("# 123 \"A string literal\"", 2278 format(" # 123 \"A string literal\"")); 2279 } 2280 2281 TEST_F(FormatTest, LayoutUnknownPPDirective) { 2282 EXPECT_EQ("#;", format("#;")); 2283 verifyFormat("#\n;\n;\n;"); 2284 } 2285 2286 TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) { 2287 EXPECT_EQ("#line 42 \"test\"\n", 2288 format("# \\\n line \\\n 42 \\\n \"test\"\n")); 2289 EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n", 2290 getLLVMStyleWithColumns(12))); 2291 } 2292 2293 TEST_F(FormatTest, EndOfFileEndsPPDirective) { 2294 EXPECT_EQ("#line 42 \"test\"", 2295 format("# \\\n line \\\n 42 \\\n \"test\"")); 2296 EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B")); 2297 } 2298 2299 TEST_F(FormatTest, DoesntRemoveUnknownTokens) { 2300 verifyFormat("#define A \\x20"); 2301 verifyFormat("#define A \\ x20"); 2302 EXPECT_EQ("#define A \\ x20", format("#define A \\ x20")); 2303 verifyFormat("#define A ''"); 2304 verifyFormat("#define A ''qqq"); 2305 verifyFormat("#define A `qqq"); 2306 verifyFormat("f(\"aaaa, bbbb, \"\\\"ccccc\\\"\");"); 2307 EXPECT_EQ("const char *c = STRINGIFY(\n" 2308 "\\na : b);", 2309 format("const char * c = STRINGIFY(\n" 2310 "\\na : b);")); 2311 } 2312 2313 TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) { 2314 verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13)); 2315 verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12)); 2316 verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12)); 2317 // FIXME: We never break before the macro name. 2318 verifyFormat("#define AA( \\\n B)", getLLVMStyleWithColumns(12)); 2319 2320 verifyFormat("#define A A\n#define A A"); 2321 verifyFormat("#define A(X) A\n#define A A"); 2322 2323 verifyFormat("#define Something Other", getLLVMStyleWithColumns(23)); 2324 verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22)); 2325 } 2326 2327 TEST_F(FormatTest, HandlePreprocessorDirectiveContext) { 2328 EXPECT_EQ("// somecomment\n" 2329 "#include \"a.h\"\n" 2330 "#define A( \\\n" 2331 " A, B)\n" 2332 "#include \"b.h\"\n" 2333 "// somecomment\n", 2334 format(" // somecomment\n" 2335 " #include \"a.h\"\n" 2336 "#define A(A,\\\n" 2337 " B)\n" 2338 " #include \"b.h\"\n" 2339 " // somecomment\n", 2340 getLLVMStyleWithColumns(13))); 2341 } 2342 2343 TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); } 2344 2345 TEST_F(FormatTest, LayoutCodeInMacroDefinitions) { 2346 EXPECT_EQ("#define A \\\n" 2347 " c; \\\n" 2348 " e;\n" 2349 "f;", 2350 format("#define A c; e;\n" 2351 "f;", 2352 getLLVMStyleWithColumns(14))); 2353 } 2354 2355 TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); } 2356 2357 TEST_F(FormatTest, AlwaysFormatsEntireMacroDefinitions) { 2358 EXPECT_EQ("int i;\n" 2359 "#define A \\\n" 2360 " int i; \\\n" 2361 " int j\n" 2362 "int k;", 2363 format("int i;\n" 2364 "#define A \\\n" 2365 " int i ; \\\n" 2366 " int j\n" 2367 "int k;", 2368 8, 0, getGoogleStyle())); // 8: position of "#define". 2369 EXPECT_EQ("int i;\n" 2370 "#define A \\\n" 2371 " int i; \\\n" 2372 " int j\n" 2373 "int k;", 2374 format("int i;\n" 2375 "#define A \\\n" 2376 " int i ; \\\n" 2377 " int j\n" 2378 "int k;", 2379 45, 0, getGoogleStyle())); // 45: position of "j". 2380 } 2381 2382 TEST_F(FormatTest, MacroDefinitionInsideStatement) { 2383 EXPECT_EQ("int x,\n" 2384 "#define A\n" 2385 " y;", 2386 format("int x,\n#define A\ny;")); 2387 } 2388 2389 TEST_F(FormatTest, HashInMacroDefinition) { 2390 EXPECT_EQ("#define A(c) L#c", format("#define A(c) L#c", getLLVMStyle())); 2391 verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11)); 2392 verifyFormat("#define A \\\n" 2393 " { \\\n" 2394 " f(#c); \\\n" 2395 " }", 2396 getLLVMStyleWithColumns(11)); 2397 2398 verifyFormat("#define A(X) \\\n" 2399 " void function##X()", 2400 getLLVMStyleWithColumns(22)); 2401 2402 verifyFormat("#define A(a, b, c) \\\n" 2403 " void a##b##c()", 2404 getLLVMStyleWithColumns(22)); 2405 2406 verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22)); 2407 } 2408 2409 TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) { 2410 EXPECT_EQ("#define A (x)", format("#define A (x)")); 2411 EXPECT_EQ("#define A(x)", format("#define A(x)")); 2412 } 2413 2414 TEST_F(FormatTest, EmptyLinesInMacroDefinitions) { 2415 EXPECT_EQ("#define A b;", format("#define A \\\n" 2416 " \\\n" 2417 " b;", 2418 getLLVMStyleWithColumns(25))); 2419 EXPECT_EQ("#define A \\\n" 2420 " \\\n" 2421 " a; \\\n" 2422 " b;", 2423 format("#define A \\\n" 2424 " \\\n" 2425 " a; \\\n" 2426 " b;", 2427 getLLVMStyleWithColumns(11))); 2428 EXPECT_EQ("#define A \\\n" 2429 " a; \\\n" 2430 " \\\n" 2431 " b;", 2432 format("#define A \\\n" 2433 " a; \\\n" 2434 " \\\n" 2435 " b;", 2436 getLLVMStyleWithColumns(11))); 2437 } 2438 2439 TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) { 2440 verifyFormat("#define A :"); 2441 verifyFormat("#define SOMECASES \\\n" 2442 " case 1: \\\n" 2443 " case 2\n", 2444 getLLVMStyleWithColumns(20)); 2445 verifyFormat("#define A template <typename T>"); 2446 verifyFormat("#define STR(x) #x\n" 2447 "f(STR(this_is_a_string_literal{));"); 2448 verifyFormat("#pragma omp threadprivate( \\\n" 2449 " y)), // expected-warning", 2450 getLLVMStyleWithColumns(28)); 2451 } 2452 2453 TEST_F(FormatTest, MacrosWithoutTrailingSemicolon) { 2454 verifyFormat("SOME_TYPE_NAME abc;"); // Gated on the newline. 2455 EXPECT_EQ("class A : public QObject {\n" 2456 " Q_OBJECT\n" 2457 "\n" 2458 " A() {}\n" 2459 "};", 2460 format("class A : public QObject {\n" 2461 " Q_OBJECT\n" 2462 "\n" 2463 " A() {\n}\n" 2464 "} ;")); 2465 EXPECT_EQ("SOME_MACRO\n" 2466 "namespace {\n" 2467 "void f();\n" 2468 "}", 2469 format("SOME_MACRO\n" 2470 " namespace {\n" 2471 "void f( );\n" 2472 "}")); 2473 // Only if the identifier contains at least 5 characters. 2474 EXPECT_EQ("HTTP f();", 2475 format("HTTP\nf();")); 2476 EXPECT_EQ("MACRO\nf();", 2477 format("MACRO\nf();")); 2478 // Only if everything is upper case. 2479 EXPECT_EQ("class A : public QObject {\n" 2480 " Q_Object A() {}\n" 2481 "};", 2482 format("class A : public QObject {\n" 2483 " Q_Object\n" 2484 " A() {\n}\n" 2485 "} ;")); 2486 } 2487 2488 TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) { 2489 EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2490 "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2491 "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2492 "class X {};\n" 2493 "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2494 "int *createScopDetectionPass() { return 0; }", 2495 format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2496 " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2497 " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2498 " class X {};\n" 2499 " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2500 " int *createScopDetectionPass() { return 0; }")); 2501 // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as 2502 // braces, so that inner block is indented one level more. 2503 EXPECT_EQ("int q() {\n" 2504 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2505 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2506 " IPC_END_MESSAGE_MAP()\n" 2507 "}", 2508 format("int q() {\n" 2509 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2510 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2511 " IPC_END_MESSAGE_MAP()\n" 2512 "}")); 2513 2514 // Same inside macros. 2515 EXPECT_EQ("#define LIST(L) \\\n" 2516 " L(A) \\\n" 2517 " L(B) \\\n" 2518 " L(C)", 2519 format("#define LIST(L) \\\n" 2520 " L(A) \\\n" 2521 " L(B) \\\n" 2522 " L(C)", 2523 getGoogleStyle())); 2524 2525 // These must not be recognized as macros. 2526 EXPECT_EQ("int q() {\n" 2527 " f(x);\n" 2528 " f(x) {}\n" 2529 " f(x)->g();\n" 2530 " f(x)->*g();\n" 2531 " f(x).g();\n" 2532 " f(x) = x;\n" 2533 " f(x) += x;\n" 2534 " f(x) -= x;\n" 2535 " f(x) *= x;\n" 2536 " f(x) /= x;\n" 2537 " f(x) %= x;\n" 2538 " f(x) &= x;\n" 2539 " f(x) |= x;\n" 2540 " f(x) ^= x;\n" 2541 " f(x) >>= x;\n" 2542 " f(x) <<= x;\n" 2543 " f(x)[y].z();\n" 2544 " LOG(INFO) << x;\n" 2545 " ifstream(x) >> x;\n" 2546 "}\n", 2547 format("int q() {\n" 2548 " f(x)\n;\n" 2549 " f(x)\n {}\n" 2550 " f(x)\n->g();\n" 2551 " f(x)\n->*g();\n" 2552 " f(x)\n.g();\n" 2553 " f(x)\n = x;\n" 2554 " f(x)\n += x;\n" 2555 " f(x)\n -= x;\n" 2556 " f(x)\n *= x;\n" 2557 " f(x)\n /= x;\n" 2558 " f(x)\n %= x;\n" 2559 " f(x)\n &= x;\n" 2560 " f(x)\n |= x;\n" 2561 " f(x)\n ^= x;\n" 2562 " f(x)\n >>= x;\n" 2563 " f(x)\n <<= x;\n" 2564 " f(x)\n[y].z();\n" 2565 " LOG(INFO)\n << x;\n" 2566 " ifstream(x)\n >> x;\n" 2567 "}\n")); 2568 EXPECT_EQ("int q() {\n" 2569 " F(x)\n" 2570 " if (1) {\n" 2571 " }\n" 2572 " F(x)\n" 2573 " while (1) {\n" 2574 " }\n" 2575 " F(x)\n" 2576 " G(x);\n" 2577 " F(x)\n" 2578 " try {\n" 2579 " Q();\n" 2580 " } catch (...) {\n" 2581 " }\n" 2582 "}\n", 2583 format("int q() {\n" 2584 "F(x)\n" 2585 "if (1) {}\n" 2586 "F(x)\n" 2587 "while (1) {}\n" 2588 "F(x)\n" 2589 "G(x);\n" 2590 "F(x)\n" 2591 "try { Q(); } catch (...) {}\n" 2592 "}\n")); 2593 EXPECT_EQ("class A {\n" 2594 " A() : t(0) {}\n" 2595 " A(int i) noexcept() : {}\n" 2596 " A(X x)\n" // FIXME: function-level try blocks are broken. 2597 " try : t(0) {\n" 2598 " } catch (...) {\n" 2599 " }\n" 2600 "};", 2601 format("class A {\n" 2602 " A()\n : t(0) {}\n" 2603 " A(int i)\n noexcept() : {}\n" 2604 " A(X x)\n" 2605 " try : t(0) {} catch (...) {}\n" 2606 "};")); 2607 EXPECT_EQ( 2608 "class SomeClass {\n" 2609 "public:\n" 2610 " SomeClass() EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2611 "};", 2612 format("class SomeClass {\n" 2613 "public:\n" 2614 " SomeClass()\n" 2615 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2616 "};")); 2617 EXPECT_EQ( 2618 "class SomeClass {\n" 2619 "public:\n" 2620 " SomeClass()\n" 2621 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2622 "};", 2623 format("class SomeClass {\n" 2624 "public:\n" 2625 " SomeClass()\n" 2626 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2627 "};", getLLVMStyleWithColumns(40))); 2628 } 2629 2630 TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { 2631 verifyFormat("#define A \\\n" 2632 " f({ \\\n" 2633 " g(); \\\n" 2634 " });", getLLVMStyleWithColumns(11)); 2635 } 2636 2637 TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) { 2638 EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}")); 2639 } 2640 2641 TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { 2642 verifyFormat("{\n { a #c; }\n}"); 2643 } 2644 2645 TEST_F(FormatTest, FormatUnbalancedStructuralElements) { 2646 EXPECT_EQ("#define A \\\n { \\\n {\nint i;", 2647 format("#define A { {\nint i;", getLLVMStyleWithColumns(11))); 2648 EXPECT_EQ("#define A \\\n } \\\n }\nint i;", 2649 format("#define A } }\nint i;", getLLVMStyleWithColumns(11))); 2650 } 2651 2652 TEST_F(FormatTest, EscapedNewlineAtStartOfToken) { 2653 EXPECT_EQ( 2654 "#define A \\\n int i; \\\n int j;", 2655 format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11))); 2656 EXPECT_EQ("template <class T> f();", format("\\\ntemplate <class T> f();")); 2657 } 2658 2659 TEST_F(FormatTest, NoEscapedNewlineHandlingInBlockComments) { 2660 EXPECT_EQ("/* \\ \\ \\\n*/", format("\\\n/* \\ \\ \\\n*/")); 2661 } 2662 2663 TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) { 2664 verifyFormat("#define A \\\n" 2665 " int v( \\\n" 2666 " a); \\\n" 2667 " int i;", 2668 getLLVMStyleWithColumns(11)); 2669 } 2670 2671 TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) { 2672 EXPECT_EQ( 2673 "#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2674 " \\\n" 2675 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2676 "\n" 2677 "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2678 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n", 2679 format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2680 "\\\n" 2681 "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2682 " \n" 2683 " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2684 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n")); 2685 } 2686 2687 TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) { 2688 EXPECT_EQ("int\n" 2689 "#define A\n" 2690 " a;", 2691 format("int\n#define A\na;")); 2692 verifyFormat("functionCallTo(\n" 2693 " someOtherFunction(\n" 2694 " withSomeParameters, whichInSequence,\n" 2695 " areLongerThanALine(andAnotherCall,\n" 2696 "#define A B\n" 2697 " withMoreParamters,\n" 2698 " whichStronglyInfluenceTheLayout),\n" 2699 " andMoreParameters),\n" 2700 " trailing);", 2701 getLLVMStyleWithColumns(69)); 2702 verifyFormat("Foo::Foo()\n" 2703 "#ifdef BAR\n" 2704 " : baz(0)\n" 2705 "#endif\n" 2706 "{\n" 2707 "}"); 2708 verifyFormat("void f() {\n" 2709 " if (true)\n" 2710 "#ifdef A\n" 2711 " f(42);\n" 2712 " x();\n" 2713 "#else\n" 2714 " g();\n" 2715 " x();\n" 2716 "#endif\n" 2717 "}"); 2718 verifyFormat("void f(param1, param2,\n" 2719 " param3,\n" 2720 "#ifdef A\n" 2721 " param4(param5,\n" 2722 "#ifdef A1\n" 2723 " param6,\n" 2724 "#ifdef A2\n" 2725 " param7),\n" 2726 "#else\n" 2727 " param8),\n" 2728 " param9,\n" 2729 "#endif\n" 2730 " param10,\n" 2731 "#endif\n" 2732 " param11)\n" 2733 "#else\n" 2734 " param12)\n" 2735 "#endif\n" 2736 "{\n" 2737 " x();\n" 2738 "}", 2739 getLLVMStyleWithColumns(28)); 2740 verifyFormat("#if 1\n" 2741 "int i;"); 2742 verifyFormat( 2743 "#if 1\n" 2744 "#endif\n" 2745 "#if 1\n" 2746 "#else\n" 2747 "#endif\n"); 2748 verifyFormat("DEBUG({\n" 2749 " return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2750 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 2751 "});\n" 2752 "#if a\n" 2753 "#else\n" 2754 "#endif"); 2755 } 2756 2757 TEST_F(FormatTest, GraciouslyHandleIncorrectPreprocessorConditions) { 2758 verifyFormat("#endif\n" 2759 "#if B"); 2760 } 2761 2762 TEST_F(FormatTest, FormatsJoinedLinesOnSubsequentRuns) { 2763 FormatStyle SingleLine = getLLVMStyle(); 2764 SingleLine.AllowShortIfStatementsOnASingleLine = true; 2765 verifyFormat( 2766 "#if 0\n" 2767 "#elif 1\n" 2768 "#endif\n" 2769 "void foo() {\n" 2770 " if (test) foo2();\n" 2771 "}", 2772 SingleLine); 2773 } 2774 2775 TEST_F(FormatTest, LayoutBlockInsideParens) { 2776 EXPECT_EQ("functionCall({ int i; });", format(" functionCall ( {int i;} );")); 2777 EXPECT_EQ("functionCall({\n" 2778 " int i;\n" 2779 " int j;\n" 2780 "});", 2781 format(" functionCall ( {int i;int j;} );")); 2782 EXPECT_EQ("functionCall({\n" 2783 " int i;\n" 2784 " int j;\n" 2785 " },\n" 2786 " aaaa, bbbb, cccc);", 2787 format(" functionCall ( {int i;int j;}, aaaa, bbbb, cccc);")); 2788 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 2789 format(" functionCall (aaaa, bbbb, {int i;});")); 2790 EXPECT_EQ("functionCall(aaaa, bbbb, {\n" 2791 " int i;\n" 2792 " int j;\n" 2793 "});", 2794 format(" functionCall (aaaa, bbbb, {int i;int j;});")); 2795 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 2796 format(" functionCall (aaaa, bbbb, {int i;});")); 2797 verifyFormat( 2798 "Aaa({\n" 2799 " int i; // break\n" 2800 " },\n" 2801 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 2802 " ccccccccccccccccc));"); 2803 verifyFormat("DEBUG({\n" 2804 " if (a)\n" 2805 " f();\n" 2806 "});"); 2807 } 2808 2809 TEST_F(FormatTest, LayoutBlockInsideStatement) { 2810 EXPECT_EQ("SOME_MACRO { int i; }\n" 2811 "int i;", 2812 format(" SOME_MACRO {int i;} int i;")); 2813 } 2814 2815 TEST_F(FormatTest, LayoutNestedBlocks) { 2816 verifyFormat("void AddOsStrings(unsigned bitmask) {\n" 2817 " struct s {\n" 2818 " int i;\n" 2819 " };\n" 2820 " s kBitsToOs[] = {{10}};\n" 2821 " for (int i = 0; i < 10; ++i)\n" 2822 " return;\n" 2823 "}"); 2824 verifyFormat("call(parameter, {\n" 2825 " something();\n" 2826 " // Comment using all columns.\n" 2827 " somethingelse();\n" 2828 "});", 2829 getLLVMStyleWithColumns(40)); 2830 verifyFormat("DEBUG( //\n" 2831 " { f(); }, a);"); 2832 verifyFormat("DEBUG( //\n" 2833 " {\n" 2834 " f(); //\n" 2835 " },\n" 2836 " a);"); 2837 2838 EXPECT_EQ("call(parameter, {\n" 2839 " something();\n" 2840 " // Comment too\n" 2841 " // looooooooooong.\n" 2842 " somethingElse();\n" 2843 "});", 2844 format("call(parameter, {\n" 2845 " something();\n" 2846 " // Comment too looooooooooong.\n" 2847 " somethingElse();\n" 2848 "});", 2849 getLLVMStyleWithColumns(29))); 2850 EXPECT_EQ("DEBUG({ int i; });", format("DEBUG({ int i; });")); 2851 EXPECT_EQ("DEBUG({ // comment\n" 2852 " int i;\n" 2853 "});", 2854 format("DEBUG({ // comment\n" 2855 "int i;\n" 2856 "});")); 2857 EXPECT_EQ("DEBUG({\n" 2858 " int i;\n" 2859 "\n" 2860 " // comment\n" 2861 " int j;\n" 2862 "});", 2863 format("DEBUG({\n" 2864 " int i;\n" 2865 "\n" 2866 " // comment\n" 2867 " int j;\n" 2868 "});")); 2869 2870 verifyFormat("DEBUG({\n" 2871 " if (a)\n" 2872 " return;\n" 2873 "});"); 2874 verifyGoogleFormat("DEBUG({\n" 2875 " if (a) return;\n" 2876 "});"); 2877 FormatStyle Style = getGoogleStyle(); 2878 Style.ColumnLimit = 45; 2879 verifyFormat("Debug(aaaaa, {\n" 2880 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2881 " return;\n" 2882 " },\n" 2883 " a);", Style); 2884 } 2885 2886 TEST_F(FormatTest, IndividualStatementsOfNestedBlocks) { 2887 EXPECT_EQ("DEBUG({\n" 2888 " int i;\n" 2889 " int j;\n" 2890 "});", 2891 format("DEBUG( {\n" 2892 " int i;\n" 2893 " int j;\n" 2894 "} ) ;", 2895 20, 1, getLLVMStyle())); 2896 EXPECT_EQ("DEBUG( {\n" 2897 " int i;\n" 2898 " int j;\n" 2899 "} ) ;", 2900 format("DEBUG( {\n" 2901 " int i;\n" 2902 " int j;\n" 2903 "} ) ;", 2904 41, 1, getLLVMStyle())); 2905 EXPECT_EQ("DEBUG( {\n" 2906 " int i;\n" 2907 " int j;\n" 2908 "} ) ;", 2909 format("DEBUG( {\n" 2910 " int i;\n" 2911 " int j;\n" 2912 "} ) ;", 2913 41, 1, getLLVMStyle())); 2914 EXPECT_EQ("DEBUG({\n" 2915 " int i;\n" 2916 " int j;\n" 2917 "});", 2918 format("DEBUG( {\n" 2919 " int i;\n" 2920 " int j;\n" 2921 "} ) ;", 2922 20, 1, getLLVMStyle())); 2923 2924 EXPECT_EQ("Debug({\n" 2925 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2926 " return;\n" 2927 " },\n" 2928 " a);", 2929 format("Debug({\n" 2930 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 2931 " return;\n" 2932 " },\n" 2933 " a);", 2934 50, 1, getLLVMStyle())); 2935 EXPECT_EQ("DEBUG({\n" 2936 " DEBUG({\n" 2937 " int a;\n" 2938 " int b;\n" 2939 " }) ;\n" 2940 "});", 2941 format("DEBUG({\n" 2942 " DEBUG({\n" 2943 " int a;\n" 2944 " int b;\n" // Format this line only. 2945 " }) ;\n" // Don't touch this line. 2946 "});", 2947 35, 0, getLLVMStyle())); 2948 EXPECT_EQ("DEBUG({\n" 2949 " int a; //\n" 2950 "});", 2951 format("DEBUG({\n" 2952 " int a; //\n" 2953 "});", 2954 0, 0, getLLVMStyle())); 2955 } 2956 2957 TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) { 2958 EXPECT_EQ("{}", format("{}")); 2959 verifyFormat("enum E {};"); 2960 verifyFormat("enum E {}"); 2961 } 2962 2963 //===----------------------------------------------------------------------===// 2964 // Line break tests. 2965 //===----------------------------------------------------------------------===// 2966 2967 TEST_F(FormatTest, PreventConfusingIndents) { 2968 verifyFormat( 2969 "void f() {\n" 2970 " SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n" 2971 " parameter, parameter, parameter)),\n" 2972 " SecondLongCall(parameter));\n" 2973 "}"); 2974 verifyFormat( 2975 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 2976 " aaaaaaaaaaaaaaaaaaaaaaaa(\n" 2977 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 2978 " aaaaaaaaaaaaaaaaaaaaaaaa);"); 2979 verifyFormat( 2980 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 2981 " [aaaaaaaaaaaaaaaaaaaaaaaa\n" 2982 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 2983 " [aaaaaaaaaaaaaaaaaaaaaaaa]];"); 2984 verifyFormat( 2985 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 2986 " aaaaaaaaaaaaaaaaaaaaaaaa<\n" 2987 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n" 2988 " aaaaaaaaaaaaaaaaaaaaaaaa>;"); 2989 verifyFormat("int a = bbbb && ccc && fffff(\n" 2990 "#define A Just forcing a new line\n" 2991 " ddd);"); 2992 } 2993 2994 TEST_F(FormatTest, LineBreakingInBinaryExpressions) { 2995 verifyFormat( 2996 "bool aaaaaaa =\n" 2997 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n" 2998 " bbbbbbbb();"); 2999 verifyFormat( 3000 "bool aaaaaaa =\n" 3001 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() or\n" 3002 " bbbbbbbb();"); 3003 3004 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 3005 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n" 3006 " ccccccccc == ddddddddddd;"); 3007 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 3008 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb and\n" 3009 " ccccccccc == ddddddddddd;"); 3010 verifyFormat( 3011 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 3012 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa not_eq bbbbbbbbbbbbbbbbbb and\n" 3013 " ccccccccc == ddddddddddd;"); 3014 3015 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 3016 " aaaaaa) &&\n" 3017 " bbbbbb && cccccc;"); 3018 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 3019 " aaaaaa) >>\n" 3020 " bbbbbb;"); 3021 verifyFormat("Whitespaces.addUntouchableComment(\n" 3022 " SourceMgr.getSpellingColumnNumber(\n" 3023 " TheLine.Last->FormatTok.Tok.getLocation()) -\n" 3024 " 1);"); 3025 3026 verifyFormat("if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3027 " bbbbbbbbbbbbbbbbbb) && // aaaaaaaaaaaaaaaa\n" 3028 " cccccc) {\n}"); 3029 3030 // If the LHS of a comparison is not a binary expression itself, the 3031 // additional linebreak confuses many people. 3032 verifyFormat( 3033 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3034 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) > 5) {\n" 3035 "}"); 3036 verifyFormat( 3037 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3038 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3039 "}"); 3040 verifyFormat( 3041 "if (aaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaa(\n" 3042 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3043 "}"); 3044 // Even explicit parentheses stress the precedence enough to make the 3045 // additional break unnecessary. 3046 verifyFormat( 3047 "if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3048 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3049 "}"); 3050 // This cases is borderline, but with the indentation it is still readable. 3051 verifyFormat( 3052 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3053 " aaaaaaaaaaaaaaa) > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3054 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 3055 "}", 3056 getLLVMStyleWithColumns(75)); 3057 3058 // If the LHS is a binary expression, we should still use the additional break 3059 // as otherwise the formatting hides the operator precedence. 3060 verifyFormat( 3061 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3062 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3063 " 5) {\n" 3064 "}"); 3065 3066 FormatStyle OnePerLine = getLLVMStyle(); 3067 OnePerLine.BinPackParameters = false; 3068 verifyFormat( 3069 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3070 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3071 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}", 3072 OnePerLine); 3073 } 3074 3075 TEST_F(FormatTest, ExpressionIndentation) { 3076 verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3077 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3078 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3079 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3080 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n" 3081 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n" 3082 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3083 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n" 3084 " ccccccccccccccccccccccccccccccccccccccccc;"); 3085 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3086 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3087 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3088 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3089 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3090 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3091 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3092 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3093 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3094 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3095 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3096 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3097 verifyFormat("if () {\n" 3098 "} else if (aaaaa &&\n" 3099 " bbbbb > // break\n" 3100 " ccccc) {\n" 3101 "}"); 3102 3103 // Presence of a trailing comment used to change indentation of b. 3104 verifyFormat("return aaaaaaaaaaaaaaaaaaa +\n" 3105 " b;\n" 3106 "return aaaaaaaaaaaaaaaaaaa +\n" 3107 " b; //", 3108 getLLVMStyleWithColumns(30)); 3109 } 3110 3111 TEST_F(FormatTest, ExpressionIndentationBreakingBeforeOperators) { 3112 // Not sure what the best system is here. Like this, the LHS can be found 3113 // immediately above an operator (everything with the same or a higher 3114 // indent). The RHS is aligned right of the operator and so compasses 3115 // everything until something with the same indent as the operator is found. 3116 // FIXME: Is this a good system? 3117 FormatStyle Style = getLLVMStyle(); 3118 Style.BreakBeforeBinaryOperators = true; 3119 verifyFormat( 3120 "bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3121 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3122 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3123 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3124 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3125 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3126 " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3127 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3128 " > ccccccccccccccccccccccccccccccccccccccccc;", 3129 Style); 3130 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3131 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3132 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3133 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3134 Style); 3135 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3136 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3137 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3138 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3139 Style); 3140 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3141 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3142 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3143 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3144 Style); 3145 verifyFormat("if () {\n" 3146 "} else if (aaaaa\n" 3147 " && bbbbb // break\n" 3148 " > ccccc) {\n" 3149 "}", 3150 Style); 3151 3152 // Forced by comments. 3153 verifyFormat( 3154 "unsigned ContentSize =\n" 3155 " sizeof(int16_t) // DWARF ARange version number\n" 3156 " + sizeof(int32_t) // Offset of CU in the .debug_info section\n" 3157 " + sizeof(int8_t) // Pointer Size (in bytes)\n" 3158 " + sizeof(int8_t); // Segment Size (in bytes)"); 3159 3160 verifyFormat("return boost::fusion::at_c<0>(iiii).second\n" 3161 " == boost::fusion::at_c<1>(iiii).second;", 3162 Style); 3163 3164 Style.ColumnLimit = 60; 3165 verifyFormat("zzzzzzzzzz\n" 3166 " = bbbbbbbbbbbbbbbbb\n" 3167 " >> aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa);", 3168 Style); 3169 } 3170 3171 TEST_F(FormatTest, ConstructorInitializers) { 3172 verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); 3173 verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}", 3174 getLLVMStyleWithColumns(45)); 3175 verifyFormat("Constructor()\n" 3176 " : Inttializer(FitsOnTheLine) {}", 3177 getLLVMStyleWithColumns(44)); 3178 verifyFormat("Constructor()\n" 3179 " : Inttializer(FitsOnTheLine) {}", 3180 getLLVMStyleWithColumns(43)); 3181 3182 verifyFormat( 3183 "SomeClass::Constructor()\n" 3184 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 3185 3186 verifyFormat( 3187 "SomeClass::Constructor()\n" 3188 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3189 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); 3190 verifyFormat( 3191 "SomeClass::Constructor()\n" 3192 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3193 " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 3194 3195 verifyFormat("Constructor()\n" 3196 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3197 " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3198 " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3199 " aaaaaaaaaaaaaaaaaaaaaaa() {}"); 3200 3201 verifyFormat("Constructor()\n" 3202 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3203 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3204 3205 verifyFormat("Constructor(int Parameter = 0)\n" 3206 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" 3207 " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}"); 3208 verifyFormat("Constructor()\n" 3209 " : aaaaaaaaaaaaaaaaaaaa(a), bbbbbbbbbbbbbbbbbbbbbbbb(b) {\n" 3210 "}", 3211 getLLVMStyleWithColumns(60)); 3212 verifyFormat("Constructor()\n" 3213 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3214 " aaaaaaaaaaaaaaaaaaaaaaaaa(aaaa, aaaa)) {}"); 3215 3216 // Here a line could be saved by splitting the second initializer onto two 3217 // lines, but that is not desirable. 3218 verifyFormat("Constructor()\n" 3219 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" 3220 " aaaaaaaaaaa(aaaaaaaaaaa),\n" 3221 " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3222 3223 FormatStyle OnePerLine = getLLVMStyle(); 3224 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 3225 verifyFormat("SomeClass::Constructor()\n" 3226 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3227 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3228 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 3229 OnePerLine); 3230 verifyFormat("SomeClass::Constructor()\n" 3231 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" 3232 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3233 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 3234 OnePerLine); 3235 verifyFormat("MyClass::MyClass(int var)\n" 3236 " : some_var_(var), // 4 space indent\n" 3237 " some_other_var_(var + 1) { // lined up\n" 3238 "}", 3239 OnePerLine); 3240 verifyFormat("Constructor()\n" 3241 " : aaaaa(aaaaaa),\n" 3242 " aaaaa(aaaaaa),\n" 3243 " aaaaa(aaaaaa),\n" 3244 " aaaaa(aaaaaa),\n" 3245 " aaaaa(aaaaaa) {}", 3246 OnePerLine); 3247 verifyFormat("Constructor()\n" 3248 " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" 3249 " aaaaaaaaaaaaaaaaaaaaaa) {}", 3250 OnePerLine); 3251 3252 EXPECT_EQ("Constructor()\n" 3253 " : // Comment forcing unwanted break.\n" 3254 " aaaa(aaaa) {}", 3255 format("Constructor() :\n" 3256 " // Comment forcing unwanted break.\n" 3257 " aaaa(aaaa) {}")); 3258 } 3259 3260 TEST_F(FormatTest, MemoizationTests) { 3261 // This breaks if the memoization lookup does not take \c Indent and 3262 // \c LastSpace into account. 3263 verifyFormat( 3264 "extern CFRunLoopTimerRef\n" 3265 "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n" 3266 " CFTimeInterval interval, CFOptionFlags flags,\n" 3267 " CFIndex order, CFRunLoopTimerCallBack callout,\n" 3268 " CFRunLoopTimerContext *context) {}"); 3269 3270 // Deep nesting somewhat works around our memoization. 3271 verifyFormat( 3272 "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3273 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3274 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3275 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3276 " aaaaa())))))))))))))))))))))))))))))))))))))));", 3277 getLLVMStyleWithColumns(65)); 3278 verifyFormat( 3279 "aaaaa(\n" 3280 " aaaaa,\n" 3281 " aaaaa(\n" 3282 " aaaaa,\n" 3283 " aaaaa(\n" 3284 " aaaaa,\n" 3285 " aaaaa(\n" 3286 " aaaaa,\n" 3287 " aaaaa(\n" 3288 " aaaaa,\n" 3289 " aaaaa(\n" 3290 " aaaaa,\n" 3291 " aaaaa(\n" 3292 " aaaaa,\n" 3293 " aaaaa(\n" 3294 " aaaaa,\n" 3295 " aaaaa(\n" 3296 " aaaaa,\n" 3297 " aaaaa(\n" 3298 " aaaaa,\n" 3299 " aaaaa(\n" 3300 " aaaaa,\n" 3301 " aaaaa(\n" 3302 " aaaaa,\n" 3303 " aaaaa))))))))))));", 3304 getLLVMStyleWithColumns(65)); 3305 verifyFormat( 3306 "a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(), a), a), a), a),\n" 3307 " a),\n" 3308 " a),\n" 3309 " a),\n" 3310 " a),\n" 3311 " a),\n" 3312 " a),\n" 3313 " a),\n" 3314 " a),\n" 3315 " a),\n" 3316 " a),\n" 3317 " a),\n" 3318 " a),\n" 3319 " a),\n" 3320 " a),\n" 3321 " a),\n" 3322 " a),\n" 3323 " a)", 3324 getLLVMStyleWithColumns(65)); 3325 3326 // This test takes VERY long when memoization is broken. 3327 FormatStyle OnePerLine = getLLVMStyle(); 3328 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 3329 OnePerLine.BinPackParameters = false; 3330 std::string input = "Constructor()\n" 3331 " : aaaa(a,\n"; 3332 for (unsigned i = 0, e = 80; i != e; ++i) { 3333 input += " a,\n"; 3334 } 3335 input += " a) {}"; 3336 verifyFormat(input, OnePerLine); 3337 } 3338 3339 TEST_F(FormatTest, BreaksAsHighAsPossible) { 3340 verifyFormat( 3341 "void f() {\n" 3342 " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n" 3343 " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n" 3344 " f();\n" 3345 "}"); 3346 verifyFormat("if (Intervals[i].getRange().getFirst() <\n" 3347 " Intervals[i - 1].getRange().getLast()) {\n}"); 3348 } 3349 3350 TEST_F(FormatTest, BreaksFunctionDeclarations) { 3351 // Principially, we break function declarations in a certain order: 3352 // 1) break amongst arguments. 3353 verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n" 3354 " Cccccccccccccc cccccccccccccc);"); 3355 verifyFormat( 3356 "template <class TemplateIt>\n" 3357 "SomeReturnType SomeFunction(TemplateIt begin, TemplateIt end,\n" 3358 " TemplateIt *stop) {}"); 3359 3360 // 2) break after return type. 3361 verifyFormat( 3362 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3363 "bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);", 3364 getGoogleStyle()); 3365 3366 // 3) break after (. 3367 verifyFormat( 3368 "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n" 3369 " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);", 3370 getGoogleStyle()); 3371 3372 // 4) break before after nested name specifiers. 3373 verifyFormat( 3374 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3375 "SomeClasssssssssssssssssssssssssssssssssssssss::\n" 3376 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);", 3377 getGoogleStyle()); 3378 3379 // However, there are exceptions, if a sufficient amount of lines can be 3380 // saved. 3381 // FIXME: The precise cut-offs wrt. the number of saved lines might need some 3382 // more adjusting. 3383 verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 3384 " Cccccccccccccc cccccccccc,\n" 3385 " Cccccccccccccc cccccccccc,\n" 3386 " Cccccccccccccc cccccccccc,\n" 3387 " Cccccccccccccc cccccccccc);"); 3388 verifyFormat( 3389 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3390 "bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3391 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3392 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);", 3393 getGoogleStyle()); 3394 verifyFormat( 3395 "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 3396 " Cccccccccccccc cccccccccc,\n" 3397 " Cccccccccccccc cccccccccc,\n" 3398 " Cccccccccccccc cccccccccc,\n" 3399 " Cccccccccccccc cccccccccc,\n" 3400 " Cccccccccccccc cccccccccc,\n" 3401 " Cccccccccccccc cccccccccc);"); 3402 verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3403 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3404 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3405 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3406 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); 3407 3408 // Break after multi-line parameters. 3409 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3410 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3411 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3412 " bbbb bbbb);"); 3413 3414 // Treat overloaded operators like other functions. 3415 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3416 "operator>(const SomeLoooooooooooooooooooooooooogType &other);"); 3417 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3418 "operator>>(const SomeLooooooooooooooooooooooooogType &other);"); 3419 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3420 "operator<<(const SomeLooooooooooooooooooooooooogType &other);"); 3421 verifyGoogleFormat( 3422 "SomeLoooooooooooooooooooooooooooooogType operator>>(\n" 3423 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 3424 verifyGoogleFormat( 3425 "SomeLoooooooooooooooooooooooooooooogType operator<<(\n" 3426 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 3427 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3428 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa = 1);"); 3429 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa\n" 3430 "aaaaaaaaaaaaaaaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaa = 1);"); 3431 verifyGoogleFormat( 3432 "typename aaaaaaaaaa<aaaaaa>::aaaaaaaaaaa\n" 3433 "aaaaaaaaaa<aaaaaa>::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3434 " bool *aaaaaaaaaaaaaaaaaa, bool *aa) {}"); 3435 } 3436 3437 TEST_F(FormatTest, TrailingReturnType) { 3438 verifyFormat("auto foo() -> int;\n"); 3439 verifyFormat("struct S {\n" 3440 " auto bar() const -> int;\n" 3441 "};"); 3442 verifyFormat("template <size_t Order, typename T>\n" 3443 "auto load_img(const std::string &filename)\n" 3444 " -> alias::tensor<Order, T, mem::tag::cpu> {}"); 3445 3446 // Not trailing return types. 3447 verifyFormat("void f() { auto a = b->c(); }"); 3448 } 3449 3450 TEST_F(FormatTest, BreaksFunctionDeclarationsWithTrailingTokens) { 3451 // Avoid breaking before trailing 'const' or other trailing annotations, if 3452 // they are not function-like. 3453 FormatStyle Style = getGoogleStyle(); 3454 Style.ColumnLimit = 47; 3455 verifyFormat("void\n" 3456 "someLongFunction(int someLongParameter) const {\n}", 3457 getLLVMStyleWithColumns(47)); 3458 verifyFormat("LoooooongReturnType\n" 3459 "someLoooooooongFunction() const {}", 3460 getLLVMStyleWithColumns(47)); 3461 verifyFormat("LoooooongReturnType someLoooooooongFunction()\n" 3462 " const {}", 3463 Style); 3464 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3465 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE;"); 3466 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3467 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE FINAL;"); 3468 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3469 " aaaaa aaaaaaaaaaaaaaaaaaaa) override final;"); 3470 verifyFormat("virtual void aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa,\n" 3471 " aaaaaaaaaaa aaaaa) const override;"); 3472 verifyGoogleFormat( 3473 "virtual void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 3474 " const override;"); 3475 3476 // Even if the first parameter has to be wrapped. 3477 verifyFormat("void someLongFunction(\n" 3478 " int someLongParameter) const {}", 3479 getLLVMStyleWithColumns(46)); 3480 verifyFormat("void someLongFunction(\n" 3481 " int someLongParameter) const {}", 3482 Style); 3483 verifyFormat("void someLongFunction(\n" 3484 " int someLongParameter) override {}", 3485 Style); 3486 verifyFormat("void someLongFunction(\n" 3487 " int someLongParameter) OVERRIDE {}", 3488 Style); 3489 verifyFormat("void someLongFunction(\n" 3490 " int someLongParameter) final {}", 3491 Style); 3492 verifyFormat("void someLongFunction(\n" 3493 " int someLongParameter) FINAL {}", 3494 Style); 3495 verifyFormat("void someLongFunction(\n" 3496 " int parameter) const override {}", 3497 Style); 3498 3499 Style.BreakBeforeBraces = FormatStyle::BS_Allman; 3500 verifyFormat("void someLongFunction(\n" 3501 " int someLongParameter) const\n" 3502 "{\n" 3503 "}", 3504 Style); 3505 3506 // Unless these are unknown annotations. 3507 verifyFormat("void SomeFunction(aaaaaaaaaa aaaaaaaaaaaaaaa,\n" 3508 " aaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3509 " LONG_AND_UGLY_ANNOTATION;"); 3510 3511 // Breaking before function-like trailing annotations is fine to keep them 3512 // close to their arguments. 3513 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3514 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3515 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3516 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3517 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3518 " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}"); 3519 verifyGoogleFormat("void aaaaaaaaaaaaaa(aaaaaaaa aaa) override\n" 3520 " AAAAAAAAAAAAAAAAAAAAAAAA(aaaaaaaaaaaaaaa);"); 3521 verifyFormat("SomeFunction([](int i) LOCKS_EXCLUDED(a) {});"); 3522 3523 verifyFormat( 3524 "void aaaaaaaaaaaaaaaaaa()\n" 3525 " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n" 3526 " aaaaaaaaaaaaaaaaaaaaaaaaa));"); 3527 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3528 " __attribute__((unused));"); 3529 verifyGoogleFormat( 3530 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3531 " GUARDED_BY(aaaaaaaaaaaa);"); 3532 verifyGoogleFormat( 3533 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3534 " GUARDED_BY(aaaaaaaaaaaa);"); 3535 verifyGoogleFormat( 3536 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa GUARDED_BY(aaaaaaaaaaaa) =\n" 3537 " aaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3538 } 3539 3540 TEST_F(FormatTest, BreaksDesireably) { 3541 verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3542 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3543 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}"); 3544 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3545 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 3546 "}"); 3547 3548 verifyFormat( 3549 "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3550 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3551 3552 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3553 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3554 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3555 3556 verifyFormat( 3557 "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3558 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3559 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3560 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));"); 3561 3562 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3563 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3564 3565 verifyFormat( 3566 "void f() {\n" 3567 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" 3568 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 3569 "}"); 3570 verifyFormat( 3571 "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3572 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3573 verifyFormat( 3574 "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3575 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3576 verifyFormat( 3577 "aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3578 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3579 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3580 3581 // Indent consistently independent of call expression. 3582 verifyFormat("aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccc(\n" 3583 " dddddddddddddddddddddddddddddd));\n" 3584 "aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3585 " dddddddddddddddddddddddddddddd));"); 3586 3587 // This test case breaks on an incorrect memoization, i.e. an optimization not 3588 // taking into account the StopAt value. 3589 verifyFormat( 3590 "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3591 " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3592 " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3593 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3594 3595 verifyFormat("{\n {\n {\n" 3596 " Annotation.SpaceRequiredBefore =\n" 3597 " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n" 3598 " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n" 3599 " }\n }\n}"); 3600 3601 // Break on an outer level if there was a break on an inner level. 3602 EXPECT_EQ("f(g(h(a, // comment\n" 3603 " b, c),\n" 3604 " d, e),\n" 3605 " x, y);", 3606 format("f(g(h(a, // comment\n" 3607 " b, c), d, e), x, y);")); 3608 3609 // Prefer breaking similar line breaks. 3610 verifyFormat( 3611 "const int kTrackingOptions = NSTrackingMouseMoved |\n" 3612 " NSTrackingMouseEnteredAndExited |\n" 3613 " NSTrackingActiveAlways;"); 3614 } 3615 3616 TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) { 3617 FormatStyle NoBinPacking = getGoogleStyle(); 3618 NoBinPacking.BinPackParameters = false; 3619 verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n" 3620 " aaaaaaaaaaaaaaaaaaaa,\n" 3621 " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);", 3622 NoBinPacking); 3623 verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n" 3624 " aaaaaaaaaaaaa,\n" 3625 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));", 3626 NoBinPacking); 3627 verifyFormat( 3628 "aaaaaaaa(aaaaaaaaaaaaa,\n" 3629 " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3630 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3631 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3632 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));", 3633 NoBinPacking); 3634 verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3635 " .aaaaaaaaaaaaaaaaaa();", 3636 NoBinPacking); 3637 verifyFormat("void f() {\n" 3638 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3639 " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);\n" 3640 "}", 3641 NoBinPacking); 3642 3643 verifyFormat( 3644 "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3645 " aaaaaaaaaaaa,\n" 3646 " aaaaaaaaaaaa);", 3647 NoBinPacking); 3648 verifyFormat( 3649 "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n" 3650 " ddddddddddddddddddddddddddddd),\n" 3651 " test);", 3652 NoBinPacking); 3653 3654 verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n" 3655 " aaaaaaaaaaaaaaaaaaaaaaa,\n" 3656 " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;", 3657 NoBinPacking); 3658 verifyFormat("a(\"a\"\n" 3659 " \"a\",\n" 3660 " a);"); 3661 3662 NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; 3663 verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n" 3664 " aaaaaaaaa,\n" 3665 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3666 NoBinPacking); 3667 verifyFormat( 3668 "void f() {\n" 3669 " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3670 " .aaaaaaa();\n" 3671 "}", 3672 NoBinPacking); 3673 verifyFormat( 3674 "template <class SomeType, class SomeOtherType>\n" 3675 "SomeType SomeFunction(SomeType Type, SomeOtherType OtherType) {}", 3676 NoBinPacking); 3677 } 3678 3679 TEST_F(FormatTest, AdaptiveOnePerLineFormatting) { 3680 FormatStyle Style = getLLVMStyleWithColumns(15); 3681 Style.ExperimentalAutoDetectBinPacking = true; 3682 EXPECT_EQ("aaa(aaaa,\n" 3683 " aaaa,\n" 3684 " aaaa);\n" 3685 "aaa(aaaa,\n" 3686 " aaaa,\n" 3687 " aaaa);", 3688 format("aaa(aaaa,\n" // one-per-line 3689 " aaaa,\n" 3690 " aaaa );\n" 3691 "aaa(aaaa, aaaa, aaaa);", // inconclusive 3692 Style)); 3693 EXPECT_EQ("aaa(aaaa, aaaa,\n" 3694 " aaaa);\n" 3695 "aaa(aaaa, aaaa,\n" 3696 " aaaa);", 3697 format("aaa(aaaa, aaaa,\n" // bin-packed 3698 " aaaa );\n" 3699 "aaa(aaaa, aaaa, aaaa);", // inconclusive 3700 Style)); 3701 } 3702 3703 TEST_F(FormatTest, FormatsBuilderPattern) { 3704 verifyFormat( 3705 "return llvm::StringSwitch<Reference::Kind>(name)\n" 3706 " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n" 3707 " .StartsWith(\".eh_frame\", ORDER_EH_FRAME)\n" 3708 " .StartsWith(\".init\", ORDER_INIT)\n" 3709 " .StartsWith(\".fini\", ORDER_FINI)\n" 3710 " .StartsWith(\".hash\", ORDER_HASH)\n" 3711 " .Default(ORDER_TEXT);\n"); 3712 3713 verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n" 3714 " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();"); 3715 verifyFormat( 3716 "aaaaaaa->aaaaaaa->aaaaaaaaaaaaaaaa(\n" 3717 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3718 " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); 3719 verifyFormat( 3720 "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n" 3721 " aaaaaaaaaaaaaa);"); 3722 verifyFormat( 3723 "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa =\n" 3724 " aaaaaa->aaaaaaaaaaaa()\n" 3725 " ->aaaaaaaaaaaaaaaa(\n" 3726 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3727 " ->aaaaaaaaaaaaaaaaa();"); 3728 verifyGoogleFormat( 3729 "void f() {\n" 3730 " someo->Add((new util::filetools::Handler(dir))\n" 3731 " ->OnEvent1(NewPermanentCallback(\n" 3732 " this, &HandlerHolderClass::EventHandlerCBA))\n" 3733 " ->OnEvent2(NewPermanentCallback(\n" 3734 " this, &HandlerHolderClass::EventHandlerCBB))\n" 3735 " ->OnEvent3(NewPermanentCallback(\n" 3736 " this, &HandlerHolderClass::EventHandlerCBC))\n" 3737 " ->OnEvent5(NewPermanentCallback(\n" 3738 " this, &HandlerHolderClass::EventHandlerCBD))\n" 3739 " ->OnEvent6(NewPermanentCallback(\n" 3740 " this, &HandlerHolderClass::EventHandlerCBE)));\n" 3741 "}"); 3742 3743 verifyFormat( 3744 "aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa();"); 3745 verifyFormat("aaaaaaaaaaaaaaa()\n" 3746 " .aaaaaaaaaaaaaaa()\n" 3747 " .aaaaaaaaaaaaaaa()\n" 3748 " .aaaaaaaaaaaaaaa()\n" 3749 " .aaaaaaaaaaaaaaa();"); 3750 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3751 " .aaaaaaaaaaaaaaa()\n" 3752 " .aaaaaaaaaaaaaaa()\n" 3753 " .aaaaaaaaaaaaaaa();"); 3754 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3755 " .aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 3756 " .aaaaaaaaaaaaaaa();"); 3757 verifyFormat("aaaaaaaaaaaaa->aaaaaaaaaaaaaaaaaaaaaaaa()\n" 3758 " ->aaaaaaaaaaaaaae(0)\n" 3759 " ->aaaaaaaaaaaaaaa();"); 3760 3761 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 3762 " .aaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 3763 " .has<bbbbbbbbbbbbbbbbbbbbb>();"); 3764 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 3765 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 3766 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>();"); 3767 3768 // Prefer not to break after empty parentheses. 3769 verifyFormat("FirstToken->WhitespaceRange.getBegin().getLocWithOffset(\n" 3770 " First->LastNewlineOffset);"); 3771 } 3772 3773 TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) { 3774 verifyFormat( 3775 "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3776 " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}"); 3777 verifyFormat( 3778 "if (aaaaaaaaaaaaaaaaaaaaaaaaa or\n" 3779 " bbbbbbbbbbbbbbbbbbbbbbbbb and cccccccccccccccccccccccc) {\n}"); 3780 3781 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 3782 " ccccccccccccccccccccccccc) {\n}"); 3783 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa and bbbbbbbbbbbbbbbbbbbbbbbb or\n" 3784 " ccccccccccccccccccccccccc) {\n}"); 3785 3786 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 3787 " ccccccccccccccccccccccccc) {\n}"); 3788 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb or\n" 3789 " ccccccccccccccccccccccccc) {\n}"); 3790 3791 verifyFormat( 3792 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n" 3793 " ccccccccccccccccccccccccc) {\n}"); 3794 verifyFormat( 3795 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb) and\n" 3796 " ccccccccccccccccccccccccc) {\n}"); 3797 3798 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n" 3799 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n" 3800 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n" 3801 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 3802 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA or\n" 3803 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB or\n" 3804 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC or\n" 3805 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 3806 3807 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n" 3808 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n" 3809 " aaaaaaaaaaaaaaa != aa) {\n}"); 3810 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa or\n" 3811 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) and\n" 3812 " aaaaaaaaaaaaaaa != aa) {\n}"); 3813 } 3814 3815 TEST_F(FormatTest, BreaksAfterAssignments) { 3816 verifyFormat( 3817 "unsigned Cost =\n" 3818 " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n" 3819 " SI->getPointerAddressSpaceee());\n"); 3820 verifyFormat( 3821 "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n" 3822 " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());"); 3823 3824 verifyFormat( 3825 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa().aaaaaaaaa(\n" 3826 " aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);"); 3827 verifyFormat("unsigned OriginalStartColumn =\n" 3828 " SourceMgr.getSpellingColumnNumber(\n" 3829 " Current.FormatTok.getStartOfNonWhitespace()) -\n" 3830 " 1;"); 3831 } 3832 3833 TEST_F(FormatTest, AlignsAfterAssignments) { 3834 verifyFormat( 3835 "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3836 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3837 verifyFormat( 3838 "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3839 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3840 verifyFormat( 3841 "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3842 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3843 verifyFormat( 3844 "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3845 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 3846 verifyFormat( 3847 "double LooooooooooooooooooooooooongResult = aaaaaaaaaaaaaaaaaaaaaaaa +\n" 3848 " aaaaaaaaaaaaaaaaaaaaaaaa +\n" 3849 " aaaaaaaaaaaaaaaaaaaaaaaa;"); 3850 } 3851 3852 TEST_F(FormatTest, AlignsAfterReturn) { 3853 verifyFormat( 3854 "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3855 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 3856 verifyFormat( 3857 "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3858 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 3859 verifyFormat( 3860 "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 3861 " aaaaaaaaaaaaaaaaaaaaaa();"); 3862 verifyFormat( 3863 "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 3864 " aaaaaaaaaaaaaaaaaaaaaa());"); 3865 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3866 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3867 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3868 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n" 3869 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3870 verifyFormat("return\n" 3871 " // true if code is one of a or b.\n" 3872 " code == a || code == b;"); 3873 } 3874 3875 TEST_F(FormatTest, BreaksConditionalExpressions) { 3876 verifyFormat( 3877 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3878 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3879 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3880 verifyFormat( 3881 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3882 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3883 verifyFormat( 3884 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n" 3885 " : aaaaaaaaaaaaa);"); 3886 verifyFormat( 3887 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3888 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3889 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3890 " aaaaaaaaaaaaa);"); 3891 verifyFormat( 3892 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3893 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3894 " aaaaaaaaaaaaa);"); 3895 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3896 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3897 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3898 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3899 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3900 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3901 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3902 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3903 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3904 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3905 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3906 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3907 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3908 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3909 " ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3910 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3911 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3912 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3913 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3914 " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3915 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 3916 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3917 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3918 " : aaaaaaaaaaaaaaaa;"); 3919 verifyFormat( 3920 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3921 " ? aaaaaaaaaaaaaaa\n" 3922 " : aaaaaaaaaaaaaaa;"); 3923 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 3924 " aaaaaaaaa\n" 3925 " ? b\n" 3926 " : c);"); 3927 verifyFormat( 3928 "unsigned Indent =\n" 3929 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n" 3930 " ? IndentForLevel[TheLine.Level]\n" 3931 " : TheLine * 2,\n" 3932 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 3933 getLLVMStyleWithColumns(70)); 3934 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 3935 " ? aaaaaaaaaaaaaaa\n" 3936 " : bbbbbbbbbbbbbbb //\n" 3937 " ? ccccccccccccccc\n" 3938 " : ddddddddddddddd;"); 3939 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 3940 " ? aaaaaaaaaaaaaaa\n" 3941 " : (bbbbbbbbbbbbbbb //\n" 3942 " ? ccccccccccccccc\n" 3943 " : ddddddddddddddd);"); 3944 verifyFormat( 3945 "int aaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3946 " ? aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3947 " aaaaaaaaaaaaaaaaaaaaa +\n" 3948 " aaaaaaaaaaaaaaaaaaaaa\n" 3949 " : aaaaaaaaaa;"); 3950 verifyFormat( 3951 "aaaaaa = aaaaaaaaaaaa\n" 3952 " ? aaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3953 " : aaaaaaaaaaaaaaaaaaaaaa\n" 3954 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3955 3956 FormatStyle NoBinPacking = getLLVMStyle(); 3957 NoBinPacking.BinPackParameters = false; 3958 verifyFormat( 3959 "void f() {\n" 3960 " g(aaa,\n" 3961 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 3962 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3963 " ? aaaaaaaaaaaaaaa\n" 3964 " : aaaaaaaaaaaaaaa);\n" 3965 "}", 3966 NoBinPacking); 3967 verifyFormat( 3968 "void f() {\n" 3969 " g(aaa,\n" 3970 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 3971 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3972 " ?: aaaaaaaaaaaaaaa);\n" 3973 "}", 3974 NoBinPacking); 3975 } 3976 3977 TEST_F(FormatTest, BreaksConditionalExpressionsAfterOperator) { 3978 FormatStyle Style = getLLVMStyle(); 3979 Style.BreakBeforeTernaryOperators = false; 3980 Style.ColumnLimit = 70; 3981 verifyFormat( 3982 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 3983 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3984 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3985 Style); 3986 verifyFormat( 3987 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3988 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3989 Style); 3990 verifyFormat( 3991 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa) :\n" 3992 " aaaaaaaaaaaaa);", 3993 Style); 3994 verifyFormat( 3995 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3996 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 3997 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3998 " aaaaaaaaaaaaa);", 3999 Style); 4000 verifyFormat( 4001 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4002 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4003 " aaaaaaaaaaaaa);", 4004 Style); 4005 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4006 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4007 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 4008 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4009 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4010 Style); 4011 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4012 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4013 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4014 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 4015 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4016 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4017 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4018 Style); 4019 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4020 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?:\n" 4021 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4022 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4023 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4024 Style); 4025 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4026 " aaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4027 " aaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4028 Style); 4029 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 4030 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4031 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4032 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4033 Style); 4034 verifyFormat( 4035 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4036 " aaaaaaaaaaaaaaa :\n" 4037 " aaaaaaaaaaaaaaa;", 4038 Style); 4039 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 4040 " aaaaaaaaa ?\n" 4041 " b :\n" 4042 " c);", 4043 Style); 4044 verifyFormat( 4045 "unsigned Indent =\n" 4046 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0 ?\n" 4047 " IndentForLevel[TheLine.Level] :\n" 4048 " TheLine * 2,\n" 4049 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 4050 Style); 4051 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 4052 " aaaaaaaaaaaaaaa :\n" 4053 " bbbbbbbbbbbbbbb ? //\n" 4054 " ccccccccccccccc :\n" 4055 " ddddddddddddddd;", 4056 Style); 4057 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 4058 " aaaaaaaaaaaaaaa :\n" 4059 " (bbbbbbbbbbbbbbb ? //\n" 4060 " ccccccccccccccc :\n" 4061 " ddddddddddddddd);", 4062 Style); 4063 } 4064 4065 TEST_F(FormatTest, DeclarationsOfMultipleVariables) { 4066 verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n" 4067 " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();"); 4068 verifyFormat("bool a = true, b = false;"); 4069 4070 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4071 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n" 4072 " bbbbbbbbbbbbbbbbbbbbbbbbb =\n" 4073 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);"); 4074 verifyFormat( 4075 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 4076 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n" 4077 " d = e && f;"); 4078 verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n" 4079 " c = cccccccccccccccccccc, d = dddddddddddddddddddd;"); 4080 verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" 4081 " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;"); 4082 verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n" 4083 " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;"); 4084 // FIXME: If multiple variables are defined, the "*" needs to move to the new 4085 // line. Also fix indent for breaking after the type, this looks bad. 4086 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*\n" 4087 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n" 4088 " * b = bbbbbbbbbbbbbbbbbbb;", 4089 getGoogleStyle()); 4090 4091 // Not ideal, but pointer-with-type does not allow much here. 4092 verifyGoogleFormat( 4093 "aaaaaaaaa* a = aaaaaaaaaaaaaaaaaaa, * b = bbbbbbbbbbbbbbbbbbb,\n" 4094 " * b = bbbbbbbbbbbbbbbbbbb, * d = ddddddddddddddddddd;"); 4095 } 4096 4097 TEST_F(FormatTest, ConditionalExpressionsInBrackets) { 4098 verifyFormat("arr[foo ? bar : baz];"); 4099 verifyFormat("f()[foo ? bar : baz];"); 4100 verifyFormat("(a + b)[foo ? bar : baz];"); 4101 verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];"); 4102 } 4103 4104 TEST_F(FormatTest, AlignsStringLiterals) { 4105 verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n" 4106 " \"short literal\");"); 4107 verifyFormat( 4108 "looooooooooooooooooooooooongFunction(\n" 4109 " \"short literal\"\n" 4110 " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");"); 4111 verifyFormat("someFunction(\"Always break between multi-line\"\n" 4112 " \" string literals\",\n" 4113 " and, other, parameters);"); 4114 EXPECT_EQ("fun + \"1243\" /* comment */\n" 4115 " \"5678\";", 4116 format("fun + \"1243\" /* comment */\n" 4117 " \"5678\";", 4118 getLLVMStyleWithColumns(28))); 4119 EXPECT_EQ( 4120 "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 4121 " \"aaaaaaaaaaaaaaaaaaaaa\"\n" 4122 " \"aaaaaaaaaaaaaaaa\";", 4123 format("aaaaaa =" 4124 "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa " 4125 "aaaaaaaaaaaaaaaaaaaaa\" " 4126 "\"aaaaaaaaaaaaaaaa\";")); 4127 verifyFormat("a = a + \"a\"\n" 4128 " \"a\"\n" 4129 " \"a\";"); 4130 verifyFormat("f(\"a\", \"b\"\n" 4131 " \"c\");"); 4132 4133 verifyFormat( 4134 "#define LL_FORMAT \"ll\"\n" 4135 "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n" 4136 " \"d, ddddddddd: %\" LL_FORMAT \"d\");"); 4137 4138 verifyFormat("#define A(X) \\\n" 4139 " \"aaaaa\" #X \"bbbbbb\" \\\n" 4140 " \"ccccc\"", 4141 getLLVMStyleWithColumns(23)); 4142 verifyFormat("#define A \"def\"\n" 4143 "f(\"abc\" A \"ghi\"\n" 4144 " \"jkl\");"); 4145 4146 verifyFormat("f(L\"a\"\n" 4147 " L\"b\")"); 4148 verifyFormat("#define A(X) \\\n" 4149 " L\"aaaaa\" #X L\"bbbbbb\" \\\n" 4150 " L\"ccccc\"", 4151 getLLVMStyleWithColumns(25)); 4152 } 4153 4154 TEST_F(FormatTest, AlwaysBreakAfterDefinitionReturnType) { 4155 FormatStyle AfterType = getLLVMStyle(); 4156 AfterType.AlwaysBreakAfterDefinitionReturnType = true; 4157 verifyFormat("const char *\n" 4158 "f(void) {\n" // Break here. 4159 " return \"\";\n" 4160 "}\n" 4161 "const char *bar(void);\n", // No break here. 4162 AfterType); 4163 verifyFormat("template <class T>\n" 4164 "T *\n" 4165 "f(T &c) {\n" // Break here. 4166 " return NULL;\n" 4167 "}\n" 4168 "template <class T> T *f(T &c);\n", // No break here. 4169 AfterType); 4170 AfterType.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 4171 verifyFormat("const char *\n" 4172 "f(void)\n" // Break here. 4173 "{\n" 4174 " return \"\";\n" 4175 "}\n" 4176 "const char *bar(void);\n", // No break here. 4177 AfterType); 4178 verifyFormat("template <class T>\n" 4179 "T *\n" // Problem here: no line break 4180 "f(T &c)\n" // Break here. 4181 "{\n" 4182 " return NULL;\n" 4183 "}\n" 4184 "template <class T> T *f(T &c);\n", // No break here. 4185 AfterType); 4186 } 4187 4188 TEST_F(FormatTest, AlwaysBreakBeforeMultilineStrings) { 4189 FormatStyle NoBreak = getLLVMStyle(); 4190 NoBreak.AlwaysBreakBeforeMultilineStrings = false; 4191 FormatStyle Break = getLLVMStyle(); 4192 Break.AlwaysBreakBeforeMultilineStrings = true; 4193 verifyFormat("aaaa = \"bbbb\"\n" 4194 " \"cccc\";", 4195 NoBreak); 4196 verifyFormat("aaaa =\n" 4197 " \"bbbb\"\n" 4198 " \"cccc\";", 4199 Break); 4200 verifyFormat("aaaa(\"bbbb\"\n" 4201 " \"cccc\");", 4202 NoBreak); 4203 verifyFormat("aaaa(\n" 4204 " \"bbbb\"\n" 4205 " \"cccc\");", 4206 Break); 4207 verifyFormat("aaaa(qqq, \"bbbb\"\n" 4208 " \"cccc\");", 4209 NoBreak); 4210 verifyFormat("aaaa(qqq,\n" 4211 " \"bbbb\"\n" 4212 " \"cccc\");", 4213 Break); 4214 verifyFormat("aaaa(qqq,\n" 4215 " L\"bbbb\"\n" 4216 " L\"cccc\");", 4217 Break); 4218 4219 // As we break before unary operators, breaking right after them is bad. 4220 verifyFormat("string foo = abc ? \"x\"\n" 4221 " \"blah blah blah blah blah blah\"\n" 4222 " : \"y\";", 4223 Break); 4224 4225 // Don't break if there is no column gain. 4226 verifyFormat("f(\"aaaa\"\n" 4227 " \"bbbb\");", 4228 Break); 4229 4230 // Treat literals with escaped newlines like multi-line string literals. 4231 EXPECT_EQ("x = \"a\\\n" 4232 "b\\\n" 4233 "c\";", 4234 format("x = \"a\\\n" 4235 "b\\\n" 4236 "c\";", 4237 NoBreak)); 4238 EXPECT_EQ("x =\n" 4239 " \"a\\\n" 4240 "b\\\n" 4241 "c\";", 4242 format("x = \"a\\\n" 4243 "b\\\n" 4244 "c\";", 4245 Break)); 4246 4247 // Exempt ObjC strings for now. 4248 EXPECT_EQ("NSString *const kString = @\"aaaa\"\n" 4249 " \"bbbb\";", 4250 format("NSString *const kString = @\"aaaa\"\n" 4251 "\"bbbb\";", 4252 Break)); 4253 } 4254 4255 TEST_F(FormatTest, AlignsPipes) { 4256 verifyFormat( 4257 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4258 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4259 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4260 verifyFormat( 4261 "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n" 4262 " << aaaaaaaaaaaaaaaaaaaa;"); 4263 verifyFormat( 4264 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4265 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4266 verifyFormat( 4267 "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" 4268 " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n" 4269 " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";"); 4270 verifyFormat( 4271 "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4272 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4273 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4274 verifyFormat( 4275 "llvm::errs() << \"a: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4276 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4277 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4278 verifyFormat( 4279 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4280 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4281 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4282 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4283 verifyFormat( 4284 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4285 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4286 4287 verifyFormat("return out << \"somepacket = {\\n\"\n" 4288 " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n" 4289 " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n" 4290 " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n" 4291 " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n" 4292 " << \"}\";"); 4293 4294 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 4295 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 4296 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa;"); 4297 verifyFormat( 4298 "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n" 4299 " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n" 4300 " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n" 4301 " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n" 4302 " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;"); 4303 verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n" 4304 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4305 verifyFormat( 4306 "void f() {\n" 4307 " llvm::outs() << \"aaaaaaaaaaaaaaaaaaaa: \"\n" 4308 " << aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 4309 "}"); 4310 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \"\n" 4311 " << aaaaaaaa.aaaaaaaaaaaa(aaa)->aaaaaaaaaaaaaa();"); 4312 4313 // Breaking before the first "<<" is generally not desirable. 4314 verifyFormat( 4315 "llvm::errs()\n" 4316 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4317 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4318 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4319 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4320 getLLVMStyleWithColumns(70)); 4321 verifyFormat("llvm::errs() << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4322 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4323 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4324 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4325 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4326 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4327 getLLVMStyleWithColumns(70)); 4328 4329 // But sometimes, breaking before the first "<<" is desirable. 4330 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaa, aaaaaaaa)\n" 4331 " << aaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaa);"); 4332 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbb)\n" 4333 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4334 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4335 verifyFormat("SemaRef.Diag(Loc, diag::note_for_range_begin_end)\n" 4336 " << BEF << IsTemplate << Description << E->getType();"); 4337 4338 verifyFormat( 4339 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4340 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4341 4342 // Incomplete string literal. 4343 EXPECT_EQ("llvm::errs() << \"\n" 4344 " << a;", 4345 format("llvm::errs() << \"\n<<a;")); 4346 4347 verifyFormat("void f() {\n" 4348 " CHECK_EQ(aaaa, (*bbbbbbbbb)->cccccc)\n" 4349 " << \"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\";\n" 4350 "}"); 4351 } 4352 4353 TEST_F(FormatTest, UnderstandsEquals) { 4354 verifyFormat( 4355 "aaaaaaaaaaaaaaaaa =\n" 4356 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4357 verifyFormat( 4358 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4359 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 4360 verifyFormat( 4361 "if (a) {\n" 4362 " f();\n" 4363 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4364 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 4365 "}"); 4366 4367 verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4368 " 100000000 + 10000000) {\n}"); 4369 } 4370 4371 TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) { 4372 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 4373 " .looooooooooooooooooooooooooooooooooooooongFunction();"); 4374 4375 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 4376 " ->looooooooooooooooooooooooooooooooooooooongFunction();"); 4377 4378 verifyFormat( 4379 "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n" 4380 " Parameter2);"); 4381 4382 verifyFormat( 4383 "ShortObject->shortFunction(\n" 4384 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n" 4385 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);"); 4386 4387 verifyFormat("loooooooooooooongFunction(\n" 4388 " LoooooooooooooongObject->looooooooooooooooongFunction());"); 4389 4390 verifyFormat( 4391 "function(LoooooooooooooooooooooooooooooooooooongObject\n" 4392 " ->loooooooooooooooooooooooooooooooooooooooongFunction());"); 4393 4394 verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" 4395 " .WillRepeatedly(Return(SomeValue));"); 4396 verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)].insert(\n" 4397 " ccccccccccccccccccccccc);"); 4398 verifyFormat("aaaaa(aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4399 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).aaaaa(aaaaa),\n" 4400 " aaaaaaaaaaaaaaaaaaaaa);"); 4401 verifyFormat("void f() {\n" 4402 " aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4403 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa)->aaaaaaaaa());\n" 4404 "}"); 4405 verifyFormat( 4406 "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4407 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4408 " .aaaaaaaaaaaaaaa(aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4409 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4410 " aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 4411 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4412 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4413 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4414 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n" 4415 "}"); 4416 4417 // Here, it is not necessary to wrap at "." or "->". 4418 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n" 4419 " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 4420 verifyFormat( 4421 "aaaaaaaaaaa->aaaaaaaaa(\n" 4422 " aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4423 " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n"); 4424 4425 verifyFormat( 4426 "aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4427 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());"); 4428 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n" 4429 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 4430 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n" 4431 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 4432 4433 // FIXME: Should we break before .a()? 4434 verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4435 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();"); 4436 4437 FormatStyle NoBinPacking = getLLVMStyle(); 4438 NoBinPacking.BinPackParameters = false; 4439 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 4440 " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 4441 " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n" 4442 " aaaaaaaaaaaaaaaaaaa,\n" 4443 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4444 NoBinPacking); 4445 4446 // If there is a subsequent call, change to hanging indentation. 4447 verifyFormat( 4448 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4449 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa))\n" 4450 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4451 verifyFormat( 4452 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4453 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa));"); 4454 verifyFormat("aaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4455 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4456 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4457 verifyFormat("aaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4458 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4459 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 4460 } 4461 4462 TEST_F(FormatTest, WrapsTemplateDeclarations) { 4463 verifyFormat("template <typename T>\n" 4464 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 4465 verifyFormat("template <typename T>\n" 4466 "// T should be one of {A, B}.\n" 4467 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 4468 verifyFormat( 4469 "template <typename T>\n" 4470 "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;"); 4471 verifyFormat("template <typename T>\n" 4472 "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n" 4473 " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);"); 4474 verifyFormat( 4475 "template <typename T>\n" 4476 "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n" 4477 " int Paaaaaaaaaaaaaaaaaaaaram2);"); 4478 verifyFormat( 4479 "template <typename T>\n" 4480 "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n" 4481 " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n" 4482 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4483 verifyFormat("template <typename T>\n" 4484 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4485 " int aaaaaaaaaaaaaaaaaaaaaa);"); 4486 verifyFormat( 4487 "template <typename T1, typename T2 = char, typename T3 = char,\n" 4488 " typename T4 = char>\n" 4489 "void f();"); 4490 verifyFormat("template <typename aaaaaaaaaaa, typename bbbbbbbbbbbbb,\n" 4491 " template <typename> class cccccccccccccccccccccc,\n" 4492 " typename ddddddddddddd>\n" 4493 "class C {};"); 4494 verifyFormat( 4495 "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n" 4496 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4497 4498 verifyFormat("void f() {\n" 4499 " a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n" 4500 " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));\n" 4501 "}"); 4502 4503 verifyFormat("template <typename T> class C {};"); 4504 verifyFormat("template <typename T> void f();"); 4505 verifyFormat("template <typename T> void f() {}"); 4506 verifyFormat( 4507 "aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 4508 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4509 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> *aaaa =\n" 4510 " new aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 4511 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4512 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>(\n" 4513 " bbbbbbbbbbbbbbbbbbbbbbbb);", 4514 getLLVMStyleWithColumns(72)); 4515 EXPECT_EQ("static_cast<A< //\n" 4516 " B> *>(\n" 4517 "\n" 4518 " );", 4519 format("static_cast<A<//\n" 4520 " B>*>(\n" 4521 "\n" 4522 " );")); 4523 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4524 " const typename aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaa);"); 4525 4526 FormatStyle AlwaysBreak = getLLVMStyle(); 4527 AlwaysBreak.AlwaysBreakTemplateDeclarations = true; 4528 verifyFormat("template <typename T>\nclass C {};", AlwaysBreak); 4529 verifyFormat("template <typename T>\nvoid f();", AlwaysBreak); 4530 verifyFormat("template <typename T>\nvoid f() {}", AlwaysBreak); 4531 verifyFormat("void aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4532 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb>(\n" 4533 " ccccccccccccccccccccccccccccccccccccccccccccccc);"); 4534 verifyFormat("template <template <typename> class Fooooooo,\n" 4535 " template <typename> class Baaaaaaar>\n" 4536 "struct C {};", 4537 AlwaysBreak); 4538 verifyFormat("template <typename T> // T can be A, B or C.\n" 4539 "struct C {};", 4540 AlwaysBreak); 4541 } 4542 4543 TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) { 4544 verifyFormat( 4545 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4546 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4547 verifyFormat( 4548 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4549 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4550 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 4551 4552 // FIXME: Should we have the extra indent after the second break? 4553 verifyFormat( 4554 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4555 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4556 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4557 4558 verifyFormat( 4559 "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n" 4560 " cccccccccccccccccccccccccccccccccccccccccccccc());"); 4561 4562 // Breaking at nested name specifiers is generally not desirable. 4563 verifyFormat( 4564 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4565 " aaaaaaaaaaaaaaaaaaaaaaa);"); 4566 4567 verifyFormat( 4568 "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4569 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4570 " aaaaaaaaaaaaaaaaaaaaa);", 4571 getLLVMStyleWithColumns(74)); 4572 4573 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4574 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4575 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4576 } 4577 4578 TEST_F(FormatTest, UnderstandsTemplateParameters) { 4579 verifyFormat("A<int> a;"); 4580 verifyFormat("A<A<A<int>>> a;"); 4581 verifyFormat("A<A<A<int, 2>, 3>, 4> a;"); 4582 verifyFormat("bool x = a < 1 || 2 > a;"); 4583 verifyFormat("bool x = 5 < f<int>();"); 4584 verifyFormat("bool x = f<int>() > 5;"); 4585 verifyFormat("bool x = 5 < a<int>::x;"); 4586 verifyFormat("bool x = a < 4 ? a > 2 : false;"); 4587 verifyFormat("bool x = f() ? a < 2 : a > 2;"); 4588 4589 verifyGoogleFormat("A<A<int>> a;"); 4590 verifyGoogleFormat("A<A<A<int>>> a;"); 4591 verifyGoogleFormat("A<A<A<A<int>>>> a;"); 4592 verifyGoogleFormat("A<A<int> > a;"); 4593 verifyGoogleFormat("A<A<A<int> > > a;"); 4594 verifyGoogleFormat("A<A<A<A<int> > > > a;"); 4595 verifyGoogleFormat("A<::A<int>> a;"); 4596 verifyGoogleFormat("A<::A> a;"); 4597 verifyGoogleFormat("A< ::A> a;"); 4598 verifyGoogleFormat("A< ::A<int> > a;"); 4599 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle())); 4600 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle())); 4601 EXPECT_EQ("A<::A<int>> a;", format("A< ::A<int>> a;", getGoogleStyle())); 4602 EXPECT_EQ("A<::A<int>> a;", format("A<::A<int> > a;", getGoogleStyle())); 4603 4604 verifyFormat("test >> a >> b;"); 4605 verifyFormat("test << a >> b;"); 4606 4607 verifyFormat("f<int>();"); 4608 verifyFormat("template <typename T> void f() {}"); 4609 4610 // Not template parameters. 4611 verifyFormat("return a < b && c > d;"); 4612 verifyFormat("void f() {\n" 4613 " while (a < b && c > d) {\n" 4614 " }\n" 4615 "}"); 4616 verifyFormat("template <typename... Types>\n" 4617 "typename enable_if<0 < sizeof...(Types)>::type Foo() {}"); 4618 4619 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4620 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaa);", 4621 getLLVMStyleWithColumns(60)); 4622 verifyFormat("static_assert(is_convertible<A &&, B>::value, \"AAA\");"); 4623 verifyFormat("Constructor(A... a) : a_(X<A>{std::forward<A>(a)}...) {}"); 4624 } 4625 4626 TEST_F(FormatTest, UnderstandsBinaryOperators) { 4627 verifyFormat("COMPARE(a, ==, b);"); 4628 } 4629 4630 TEST_F(FormatTest, UnderstandsPointersToMembers) { 4631 verifyFormat("int A::*x;"); 4632 verifyFormat("int (S::*func)(void *);"); 4633 verifyFormat("void f() { int (S::*func)(void *); }"); 4634 verifyFormat("typedef bool *(Class::*Member)() const;"); 4635 verifyFormat("void f() {\n" 4636 " (a->*f)();\n" 4637 " a->*x;\n" 4638 " (a.*f)();\n" 4639 " ((*a).*f)();\n" 4640 " a.*x;\n" 4641 "}"); 4642 verifyFormat("void f() {\n" 4643 " (a->*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" 4644 " aaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);\n" 4645 "}"); 4646 verifyFormat( 4647 "(aaaaaaaaaa->*bbbbbbb)(\n" 4648 " aaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 4649 FormatStyle Style = getLLVMStyle(); 4650 Style.PointerAlignment = FormatStyle::PAS_Left; 4651 verifyFormat("typedef bool* (Class::*Member)() const;", Style); 4652 } 4653 4654 TEST_F(FormatTest, UnderstandsUnaryOperators) { 4655 verifyFormat("int a = -2;"); 4656 verifyFormat("f(-1, -2, -3);"); 4657 verifyFormat("a[-1] = 5;"); 4658 verifyFormat("int a = 5 + -2;"); 4659 verifyFormat("if (i == -1) {\n}"); 4660 verifyFormat("if (i != -1) {\n}"); 4661 verifyFormat("if (i > -1) {\n}"); 4662 verifyFormat("if (i < -1) {\n}"); 4663 verifyFormat("++(a->f());"); 4664 verifyFormat("--(a->f());"); 4665 verifyFormat("(a->f())++;"); 4666 verifyFormat("a[42]++;"); 4667 verifyFormat("if (!(a->f())) {\n}"); 4668 4669 verifyFormat("a-- > b;"); 4670 verifyFormat("b ? -a : c;"); 4671 verifyFormat("n * sizeof char16;"); 4672 verifyFormat("n * alignof char16;", getGoogleStyle()); 4673 verifyFormat("sizeof(char);"); 4674 verifyFormat("alignof(char);", getGoogleStyle()); 4675 4676 verifyFormat("return -1;"); 4677 verifyFormat("switch (a) {\n" 4678 "case -1:\n" 4679 " break;\n" 4680 "}"); 4681 verifyFormat("#define X -1"); 4682 verifyFormat("#define X -kConstant"); 4683 4684 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {-5, +3};"); 4685 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {+5, -3};"); 4686 4687 verifyFormat("int a = /* confusing comment */ -1;"); 4688 // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case. 4689 verifyFormat("int a = i /* confusing comment */++;"); 4690 } 4691 4692 TEST_F(FormatTest, DoesNotIndentRelativeToUnaryOperators) { 4693 verifyFormat("if (!aaaaaaaaaa( // break\n" 4694 " aaaaa)) {\n" 4695 "}"); 4696 verifyFormat("aaaaaaaaaa(!aaaaaaaaaa( // break\n" 4697 " aaaaa));"); 4698 verifyFormat("*aaa = aaaaaaa( // break\n" 4699 " bbbbbb);"); 4700 } 4701 4702 TEST_F(FormatTest, UnderstandsOverloadedOperators) { 4703 verifyFormat("bool operator<();"); 4704 verifyFormat("bool operator>();"); 4705 verifyFormat("bool operator=();"); 4706 verifyFormat("bool operator==();"); 4707 verifyFormat("bool operator!=();"); 4708 verifyFormat("int operator+();"); 4709 verifyFormat("int operator++();"); 4710 verifyFormat("bool operator();"); 4711 verifyFormat("bool operator()();"); 4712 verifyFormat("bool operator[]();"); 4713 verifyFormat("operator bool();"); 4714 verifyFormat("operator int();"); 4715 verifyFormat("operator void *();"); 4716 verifyFormat("operator SomeType<int>();"); 4717 verifyFormat("operator SomeType<int, int>();"); 4718 verifyFormat("operator SomeType<SomeType<int>>();"); 4719 verifyFormat("void *operator new(std::size_t size);"); 4720 verifyFormat("void *operator new[](std::size_t size);"); 4721 verifyFormat("void operator delete(void *ptr);"); 4722 verifyFormat("void operator delete[](void *ptr);"); 4723 verifyFormat("template <typename AAAAAAA, typename BBBBBBB>\n" 4724 "AAAAAAA operator/(const AAAAAAA &a, BBBBBBB &b);"); 4725 4726 verifyFormat( 4727 "ostream &operator<<(ostream &OutputStream,\n" 4728 " SomeReallyLongType WithSomeReallyLongValue);"); 4729 verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n" 4730 " const aaaaaaaaaaaaaaaaaaaaa &right) {\n" 4731 " return left.group < right.group;\n" 4732 "}"); 4733 verifyFormat("SomeType &operator=(const SomeType &S);"); 4734 4735 verifyGoogleFormat("operator void*();"); 4736 verifyGoogleFormat("operator SomeType<SomeType<int>>();"); 4737 verifyGoogleFormat("operator ::A();"); 4738 4739 verifyFormat("using A::operator+;"); 4740 4741 verifyFormat("Deleted &operator=(const Deleted &)& = default;"); 4742 verifyFormat("Deleted &operator=(const Deleted &)&& = delete;"); 4743 verifyGoogleFormat("Deleted& operator=(const Deleted&)& = default;"); 4744 verifyGoogleFormat("Deleted& operator=(const Deleted&)&& = delete;"); 4745 4746 verifyFormat("string // break\n" 4747 "operator()() & {}"); 4748 verifyFormat("string // break\n" 4749 "operator()() && {}"); 4750 } 4751 4752 TEST_F(FormatTest, UnderstandsNewAndDelete) { 4753 verifyFormat("void f() {\n" 4754 " A *a = new A;\n" 4755 " A *a = new (placement) A;\n" 4756 " delete a;\n" 4757 " delete (A *)a;\n" 4758 "}"); 4759 verifyFormat("new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" 4760 " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); 4761 verifyFormat("auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4762 " new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" 4763 " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); 4764 } 4765 4766 TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { 4767 verifyFormat("int *f(int *a) {}"); 4768 verifyFormat("int main(int argc, char **argv) {}"); 4769 verifyFormat("Test::Test(int b) : a(b * b) {}"); 4770 verifyIndependentOfContext("f(a, *a);"); 4771 verifyFormat("void g() { f(*a); }"); 4772 verifyIndependentOfContext("int a = b * 10;"); 4773 verifyIndependentOfContext("int a = 10 * b;"); 4774 verifyIndependentOfContext("int a = b * c;"); 4775 verifyIndependentOfContext("int a += b * c;"); 4776 verifyIndependentOfContext("int a -= b * c;"); 4777 verifyIndependentOfContext("int a *= b * c;"); 4778 verifyIndependentOfContext("int a /= b * c;"); 4779 verifyIndependentOfContext("int a = *b;"); 4780 verifyIndependentOfContext("int a = *b * c;"); 4781 verifyIndependentOfContext("int a = b * *c;"); 4782 verifyIndependentOfContext("return 10 * b;"); 4783 verifyIndependentOfContext("return *b * *c;"); 4784 verifyIndependentOfContext("return a & ~b;"); 4785 verifyIndependentOfContext("f(b ? *c : *d);"); 4786 verifyIndependentOfContext("int a = b ? *c : *d;"); 4787 verifyIndependentOfContext("*b = a;"); 4788 verifyIndependentOfContext("a * ~b;"); 4789 verifyIndependentOfContext("a * !b;"); 4790 verifyIndependentOfContext("a * +b;"); 4791 verifyIndependentOfContext("a * -b;"); 4792 verifyIndependentOfContext("a * ++b;"); 4793 verifyIndependentOfContext("a * --b;"); 4794 verifyIndependentOfContext("a[4] * b;"); 4795 verifyIndependentOfContext("a[a * a] = 1;"); 4796 verifyIndependentOfContext("f() * b;"); 4797 verifyIndependentOfContext("a * [self dostuff];"); 4798 verifyIndependentOfContext("int x = a * (a + b);"); 4799 verifyIndependentOfContext("(a *)(a + b);"); 4800 verifyIndependentOfContext("*(int *)(p & ~3UL) = 0;"); 4801 verifyIndependentOfContext("int *pa = (int *)&a;"); 4802 verifyIndependentOfContext("return sizeof(int **);"); 4803 verifyIndependentOfContext("return sizeof(int ******);"); 4804 verifyIndependentOfContext("return (int **&)a;"); 4805 verifyIndependentOfContext("f((*PointerToArray)[10]);"); 4806 verifyFormat("void f(Type (*parameter)[10]) {}"); 4807 verifyGoogleFormat("return sizeof(int**);"); 4808 verifyIndependentOfContext("Type **A = static_cast<Type **>(P);"); 4809 verifyGoogleFormat("Type** A = static_cast<Type**>(P);"); 4810 verifyFormat("auto a = [](int **&, int ***) {};"); 4811 verifyFormat("auto PointerBinding = [](const char *S) {};"); 4812 verifyFormat("typedef typeof(int(int, int)) *MyFunc;"); 4813 verifyFormat("[](const decltype(*a) &value) {}"); 4814 verifyIndependentOfContext("typedef void (*f)(int *a);"); 4815 verifyIndependentOfContext("int i{a * b};"); 4816 verifyIndependentOfContext("aaa && aaa->f();"); 4817 verifyIndependentOfContext("int x = ~*p;"); 4818 4819 verifyIndependentOfContext("InvalidRegions[*R] = 0;"); 4820 4821 verifyIndependentOfContext("A<int *> a;"); 4822 verifyIndependentOfContext("A<int **> a;"); 4823 verifyIndependentOfContext("A<int *, int *> a;"); 4824 verifyIndependentOfContext("A<int *[]> a;"); 4825 verifyIndependentOfContext( 4826 "const char *const p = reinterpret_cast<const char *const>(q);"); 4827 verifyIndependentOfContext("A<int **, int **> a;"); 4828 verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);"); 4829 verifyFormat("for (char **a = b; *a; ++a) {\n}"); 4830 verifyFormat("for (; a && b;) {\n}"); 4831 verifyFormat("bool foo = true && [] { return false; }();"); 4832 4833 verifyFormat( 4834 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4835 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4836 4837 verifyGoogleFormat("int main(int argc, char** argv) {}"); 4838 verifyGoogleFormat("A<int*> a;"); 4839 verifyGoogleFormat("A<int**> a;"); 4840 verifyGoogleFormat("A<int*, int*> a;"); 4841 verifyGoogleFormat("A<int**, int**> a;"); 4842 verifyGoogleFormat("f(b ? *c : *d);"); 4843 verifyGoogleFormat("int a = b ? *c : *d;"); 4844 verifyGoogleFormat("Type* t = **x;"); 4845 verifyGoogleFormat("Type* t = *++*x;"); 4846 verifyGoogleFormat("*++*x;"); 4847 verifyGoogleFormat("Type* t = const_cast<T*>(&*x);"); 4848 verifyGoogleFormat("Type* t = x++ * y;"); 4849 verifyGoogleFormat( 4850 "const char* const p = reinterpret_cast<const char* const>(q);"); 4851 verifyGoogleFormat("void f(int i = 0, SomeType** temps = NULL);"); 4852 4853 FormatStyle Left = getLLVMStyle(); 4854 Left.PointerAlignment = FormatStyle::PAS_Left; 4855 verifyFormat("x = *a(x) = *a(y);", Left); 4856 4857 verifyIndependentOfContext("a = *(x + y);"); 4858 verifyIndependentOfContext("a = &(x + y);"); 4859 verifyIndependentOfContext("*(x + y).call();"); 4860 verifyIndependentOfContext("&(x + y)->call();"); 4861 verifyFormat("void f() { &(*I).first; }"); 4862 4863 verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); 4864 verifyFormat( 4865 "int *MyValues = {\n" 4866 " *A, // Operator detection might be confused by the '{'\n" 4867 " *BB // Operator detection might be confused by previous comment\n" 4868 "};"); 4869 4870 verifyIndependentOfContext("if (int *a = &b)"); 4871 verifyIndependentOfContext("if (int &a = *b)"); 4872 verifyIndependentOfContext("if (a & b[i])"); 4873 verifyIndependentOfContext("if (a::b::c::d & b[i])"); 4874 verifyIndependentOfContext("if (*b[i])"); 4875 verifyIndependentOfContext("if (int *a = (&b))"); 4876 verifyIndependentOfContext("while (int *a = &b)"); 4877 verifyIndependentOfContext("size = sizeof *a;"); 4878 verifyFormat("void f() {\n" 4879 " for (const int &v : Values) {\n" 4880 " }\n" 4881 "}"); 4882 verifyFormat("for (int i = a * a; i < 10; ++i) {\n}"); 4883 verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); 4884 verifyGoogleFormat("for (int i = 0; i * 2 < z; i *= 2) {\n}"); 4885 4886 verifyFormat("#define A (!a * b)"); 4887 verifyFormat("#define MACRO \\\n" 4888 " int *i = a * b; \\\n" 4889 " void f(a *b);", 4890 getLLVMStyleWithColumns(19)); 4891 4892 verifyIndependentOfContext("A = new SomeType *[Length];"); 4893 verifyIndependentOfContext("A = new SomeType *[Length]();"); 4894 verifyIndependentOfContext("T **t = new T *;"); 4895 verifyIndependentOfContext("T **t = new T *();"); 4896 verifyGoogleFormat("A = new SomeType* [Length]();"); 4897 verifyGoogleFormat("A = new SomeType* [Length];"); 4898 verifyGoogleFormat("T** t = new T*;"); 4899 verifyGoogleFormat("T** t = new T*();"); 4900 4901 FormatStyle PointerLeft = getLLVMStyle(); 4902 PointerLeft.PointerAlignment = FormatStyle::PAS_Left; 4903 verifyFormat("delete *x;", PointerLeft); 4904 verifyFormat("STATIC_ASSERT((a & b) == 0);"); 4905 verifyFormat("STATIC_ASSERT(0 == (a & b));"); 4906 verifyFormat("template <bool a, bool b> " 4907 "typename t::if<x && y>::type f() {}"); 4908 verifyFormat("template <int *y> f() {}"); 4909 verifyFormat("vector<int *> v;"); 4910 verifyFormat("vector<int *const> v;"); 4911 verifyFormat("vector<int *const **const *> v;"); 4912 verifyFormat("vector<int *volatile> v;"); 4913 verifyFormat("vector<a * b> v;"); 4914 verifyFormat("foo<b && false>();"); 4915 verifyFormat("foo<b & 1>();"); 4916 4917 verifyIndependentOfContext("MACRO(int *i);"); 4918 verifyIndependentOfContext("MACRO(auto *a);"); 4919 verifyIndependentOfContext("MACRO(const A *a);"); 4920 verifyIndependentOfContext("MACRO('0' <= c && c <= '9');"); 4921 // FIXME: Is there a way to make this work? 4922 // verifyIndependentOfContext("MACRO(A *a);"); 4923 4924 verifyFormat("DatumHandle const *operator->() const { return input_; }"); 4925 4926 EXPECT_EQ("#define OP(x) \\\n" 4927 " ostream &operator<<(ostream &s, const A &a) { \\\n" 4928 " return s << a.DebugString(); \\\n" 4929 " }", 4930 format("#define OP(x) \\\n" 4931 " ostream &operator<<(ostream &s, const A &a) { \\\n" 4932 " return s << a.DebugString(); \\\n" 4933 " }", 4934 getLLVMStyleWithColumns(50))); 4935 4936 // FIXME: We cannot handle this case yet; we might be able to figure out that 4937 // foo<x> d > v; doesn't make sense. 4938 verifyFormat("foo<a<b && c> d> v;"); 4939 4940 FormatStyle PointerMiddle = getLLVMStyle(); 4941 PointerMiddle.PointerAlignment = FormatStyle::PAS_Middle; 4942 verifyFormat("delete *x;", PointerMiddle); 4943 verifyFormat("int * x;", PointerMiddle); 4944 verifyFormat("template <int * y> f() {}", PointerMiddle); 4945 verifyFormat("int * f(int * a) {}", PointerMiddle); 4946 verifyFormat("int main(int argc, char ** argv) {}", PointerMiddle); 4947 verifyFormat("Test::Test(int b) : a(b * b) {}", PointerMiddle); 4948 verifyFormat("A<int *> a;", PointerMiddle); 4949 verifyFormat("A<int **> a;", PointerMiddle); 4950 verifyFormat("A<int *, int *> a;", PointerMiddle); 4951 verifyFormat("A<int * []> a;", PointerMiddle); 4952 verifyFormat("A = new SomeType * [Length]();", PointerMiddle); 4953 verifyFormat("A = new SomeType * [Length];", PointerMiddle); 4954 verifyFormat("T ** t = new T *;", PointerMiddle); 4955 } 4956 4957 TEST_F(FormatTest, UnderstandsAttributes) { 4958 verifyFormat("SomeType s __attribute__((unused)) (InitValue);"); 4959 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa __attribute__((unused))\n" 4960 "aaaaaaaaaaaaaaaaaaaaaaa(int i);"); 4961 } 4962 4963 TEST_F(FormatTest, UnderstandsEllipsis) { 4964 verifyFormat("int printf(const char *fmt, ...);"); 4965 verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }"); 4966 verifyFormat("template <class... Ts> void Foo(Ts *... ts) {}"); 4967 4968 FormatStyle PointersLeft = getLLVMStyle(); 4969 PointersLeft.PointerAlignment = FormatStyle::PAS_Left; 4970 verifyFormat("template <class... Ts> void Foo(Ts*... ts) {}", PointersLeft); 4971 } 4972 4973 TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) { 4974 EXPECT_EQ("int *a;\n" 4975 "int *a;\n" 4976 "int *a;", 4977 format("int *a;\n" 4978 "int* a;\n" 4979 "int *a;", 4980 getGoogleStyle())); 4981 EXPECT_EQ("int* a;\n" 4982 "int* a;\n" 4983 "int* a;", 4984 format("int* a;\n" 4985 "int* a;\n" 4986 "int *a;", 4987 getGoogleStyle())); 4988 EXPECT_EQ("int *a;\n" 4989 "int *a;\n" 4990 "int *a;", 4991 format("int *a;\n" 4992 "int * a;\n" 4993 "int * a;", 4994 getGoogleStyle())); 4995 } 4996 4997 TEST_F(FormatTest, UnderstandsRvalueReferences) { 4998 verifyFormat("int f(int &&a) {}"); 4999 verifyFormat("int f(int a, char &&b) {}"); 5000 verifyFormat("void f() { int &&a = b; }"); 5001 verifyGoogleFormat("int f(int a, char&& b) {}"); 5002 verifyGoogleFormat("void f() { int&& a = b; }"); 5003 5004 verifyIndependentOfContext("A<int &&> a;"); 5005 verifyIndependentOfContext("A<int &&, int &&> a;"); 5006 verifyGoogleFormat("A<int&&> a;"); 5007 verifyGoogleFormat("A<int&&, int&&> a;"); 5008 5009 // Not rvalue references: 5010 verifyFormat("template <bool B, bool C> class A {\n" 5011 " static_assert(B && C, \"Something is wrong\");\n" 5012 "};"); 5013 verifyGoogleFormat("#define IF(a, b, c) if (a && (b == c))"); 5014 verifyGoogleFormat("#define WHILE(a, b, c) while (a && (b == c))"); 5015 verifyFormat("#define A(a, b) (a && b)"); 5016 } 5017 5018 TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) { 5019 verifyFormat("void f() {\n" 5020 " x[aaaaaaaaa -\n" 5021 " b] = 23;\n" 5022 "}", 5023 getLLVMStyleWithColumns(15)); 5024 } 5025 5026 TEST_F(FormatTest, FormatsCasts) { 5027 verifyFormat("Type *A = static_cast<Type *>(P);"); 5028 verifyFormat("Type *A = (Type *)P;"); 5029 verifyFormat("Type *A = (vector<Type *, int *>)P;"); 5030 verifyFormat("int a = (int)(2.0f);"); 5031 verifyFormat("int a = (int)2.0f;"); 5032 verifyFormat("x[(int32)y];"); 5033 verifyFormat("x = (int32)y;"); 5034 verifyFormat("#define AA(X) sizeof(((X *)NULL)->a)"); 5035 verifyFormat("int a = (int)*b;"); 5036 verifyFormat("int a = (int)2.0f;"); 5037 verifyFormat("int a = (int)~0;"); 5038 verifyFormat("int a = (int)++a;"); 5039 verifyFormat("int a = (int)sizeof(int);"); 5040 verifyFormat("int a = (int)+2;"); 5041 verifyFormat("my_int a = (my_int)2.0f;"); 5042 verifyFormat("my_int a = (my_int)sizeof(int);"); 5043 verifyFormat("return (my_int)aaa;"); 5044 verifyFormat("#define x ((int)-1)"); 5045 verifyFormat("#define p(q) ((int *)&q)"); 5046 verifyFormat("fn(a)(b) + 1;"); 5047 5048 verifyFormat("void f() { my_int a = (my_int)*b; }"); 5049 verifyFormat("void f() { return P ? (my_int)*P : (my_int)0; }"); 5050 verifyFormat("my_int a = (my_int)~0;"); 5051 verifyFormat("my_int a = (my_int)++a;"); 5052 verifyFormat("my_int a = (my_int)+2;"); 5053 verifyFormat("my_int a = (my_int)1;"); 5054 verifyFormat("my_int a = (my_int *)1;"); 5055 verifyFormat("my_int a = (const my_int)-1;"); 5056 verifyFormat("my_int a = (const my_int *)-1;"); 5057 5058 // FIXME: single value wrapped with paren will be treated as cast. 5059 verifyFormat("void f(int i = (kValue)*kMask) {}"); 5060 5061 verifyFormat("{ (void)F; }"); 5062 5063 // Don't break after a cast's 5064 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 5065 " (aaaaaaaaaaaaaaaaaaaaaaaaaa *)(aaaaaaaaaaaaaaaaaaaaaa +\n" 5066 " bbbbbbbbbbbbbbbbbbbbbb);"); 5067 5068 // These are not casts. 5069 verifyFormat("void f(int *) {}"); 5070 verifyFormat("f(foo)->b;"); 5071 verifyFormat("f(foo).b;"); 5072 verifyFormat("f(foo)(b);"); 5073 verifyFormat("f(foo)[b];"); 5074 verifyFormat("[](foo) { return 4; }(bar);"); 5075 verifyFormat("(*funptr)(foo)[4];"); 5076 verifyFormat("funptrs[4](foo)[4];"); 5077 verifyFormat("void f(int *);"); 5078 verifyFormat("void f(int *) = 0;"); 5079 verifyFormat("void f(SmallVector<int>) {}"); 5080 verifyFormat("void f(SmallVector<int>);"); 5081 verifyFormat("void f(SmallVector<int>) = 0;"); 5082 verifyFormat("void f(int i = (kA * kB) & kMask) {}"); 5083 verifyFormat("int a = sizeof(int) * b;"); 5084 verifyFormat("int a = alignof(int) * b;", getGoogleStyle()); 5085 verifyFormat("template <> void f<int>(int i) SOME_ANNOTATION;"); 5086 verifyFormat("f(\"%\" SOME_MACRO(ll) \"d\");"); 5087 verifyFormat("aaaaa &operator=(const aaaaa &) LLVM_DELETED_FUNCTION;"); 5088 5089 // These are not casts, but at some point were confused with casts. 5090 verifyFormat("virtual void foo(int *) override;"); 5091 verifyFormat("virtual void foo(char &) const;"); 5092 verifyFormat("virtual void foo(int *a, char *) const;"); 5093 verifyFormat("int a = sizeof(int *) + b;"); 5094 verifyFormat("int a = alignof(int *) + b;", getGoogleStyle()); 5095 5096 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *foo = (aaaaaaaaaaaaaaaaa *)\n" 5097 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 5098 // FIXME: The indentation here is not ideal. 5099 verifyFormat( 5100 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5101 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = (*cccccccccccccccc)\n" 5102 " [dddddddddddddddddddddddddddddddddddddddddddddddddddddddd];"); 5103 } 5104 5105 TEST_F(FormatTest, FormatsFunctionTypes) { 5106 verifyFormat("A<bool()> a;"); 5107 verifyFormat("A<SomeType()> a;"); 5108 verifyFormat("A<void (*)(int, std::string)> a;"); 5109 verifyFormat("A<void *(int)>;"); 5110 verifyFormat("void *(*a)(int *, SomeType *);"); 5111 verifyFormat("int (*func)(void *);"); 5112 verifyFormat("void f() { int (*func)(void *); }"); 5113 verifyFormat("template <class CallbackClass>\n" 5114 "using MyCallback = void (CallbackClass::*)(SomeObject *Data);"); 5115 5116 verifyGoogleFormat("A<void*(int*, SomeType*)>;"); 5117 verifyGoogleFormat("void* (*a)(int);"); 5118 verifyGoogleFormat( 5119 "template <class CallbackClass>\n" 5120 "using MyCallback = void (CallbackClass::*)(SomeObject* Data);"); 5121 5122 // Other constructs can look somewhat like function types: 5123 verifyFormat("A<sizeof(*x)> a;"); 5124 verifyFormat("#define DEREF_AND_CALL_F(x) f(*x)"); 5125 verifyFormat("some_var = function(*some_pointer_var)[0];"); 5126 verifyFormat("void f() { function(*some_pointer_var)[0] = 10; }"); 5127 } 5128 5129 TEST_F(FormatTest, BreaksLongVariableDeclarations) { 5130 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5131 " LoooooooooooooooooooooooooooooooooooooooongVariable;"); 5132 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType const\n" 5133 " LoooooooooooooooooooooooooooooooooooooooongVariable;"); 5134 5135 // Different ways of ()-initializiation. 5136 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5137 " LoooooooooooooooooooooooooooooooooooooooongVariable(1);"); 5138 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5139 " LoooooooooooooooooooooooooooooooooooooooongVariable(a);"); 5140 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5141 " LoooooooooooooooooooooooooooooooooooooooongVariable({});"); 5142 } 5143 5144 TEST_F(FormatTest, BreaksLongDeclarations) { 5145 verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n" 5146 " AnotherNameForTheLongType;"); 5147 verifyFormat("typedef LongTemplateType<aaaaaaaaaaaaaaaaaaa()>\n" 5148 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 5149 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5150 "LoooooooooooooooooooooooooooooooongFunctionDeclaration();"); 5151 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5152 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5153 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 5154 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5155 verifyFormat("decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" 5156 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5157 FormatStyle Indented = getLLVMStyle(); 5158 Indented.IndentWrappedFunctionNames = true; 5159 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5160 " LoooooooooooooooooooooooooooooooongFunctionDeclaration();", 5161 Indented); 5162 verifyFormat( 5163 "LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5164 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5165 Indented); 5166 verifyFormat( 5167 "LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 5168 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5169 Indented); 5170 verifyFormat( 5171 "decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" 5172 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5173 Indented); 5174 5175 // FIXME: Without the comment, this breaks after "(". 5176 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n" 5177 " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();", 5178 getGoogleStyle()); 5179 5180 verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n" 5181 " int LoooooooooooooooooooongParam2) {}"); 5182 verifyFormat( 5183 "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n" 5184 " SourceLocation L, IdentifierIn *II,\n" 5185 " Type *T) {}"); 5186 verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n" 5187 "ReallyReallyLongFunctionName(\n" 5188 " const std::string &SomeParameter,\n" 5189 " const SomeType<string, SomeOtherTemplateParameter> &\n" 5190 " ReallyReallyLongParameterName,\n" 5191 " const SomeType<string, SomeOtherTemplateParameter> &\n" 5192 " AnotherLongParameterName) {}"); 5193 verifyFormat("template <typename A>\n" 5194 "SomeLoooooooooooooooooooooongType<\n" 5195 " typename some_namespace::SomeOtherType<A>::Type>\n" 5196 "Function() {}"); 5197 5198 verifyGoogleFormat( 5199 "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n" 5200 " aaaaaaaaaaaaaaaaaaaaaaa;"); 5201 verifyGoogleFormat( 5202 "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n" 5203 " SourceLocation L) {}"); 5204 verifyGoogleFormat( 5205 "some_namespace::LongReturnType\n" 5206 "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n" 5207 " int first_long_parameter, int second_parameter) {}"); 5208 5209 verifyGoogleFormat("template <typename T>\n" 5210 "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n" 5211 "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}"); 5212 verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5213 " int aaaaaaaaaaaaaaaaaaaaaaa);"); 5214 5215 verifyFormat("typedef size_t (*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" 5216 " const aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 5217 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 5218 } 5219 5220 TEST_F(FormatTest, FormatsArrays) { 5221 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5222 " [bbbbbbbbbbbbbbbbbbbbbbbbb] = c;"); 5223 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5224 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 5225 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5226 " [a][bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = cccccccc;"); 5227 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5228 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5229 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 5230 verifyFormat( 5231 "llvm::outs() << \"aaaaaaaaaaaa: \"\n" 5232 " << (*aaaaaaaiaaaaaaa)[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5233 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); 5234 5235 verifyGoogleFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<int>\n" 5236 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaa];"); 5237 verifyFormat( 5238 "aaaaaaaaaaa aaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaa->aaaaaaaaa[0]\n" 5239 " .aaaaaaa[0]\n" 5240 " .aaaaaaaaaaaaaaaaaaaaaa();"); 5241 } 5242 5243 TEST_F(FormatTest, LineStartsWithSpecialCharacter) { 5244 verifyFormat("(a)->b();"); 5245 verifyFormat("--a;"); 5246 } 5247 5248 TEST_F(FormatTest, HandlesIncludeDirectives) { 5249 verifyFormat("#include <string>\n" 5250 "#include <a/b/c.h>\n" 5251 "#include \"a/b/string\"\n" 5252 "#include \"string.h\"\n" 5253 "#include \"string.h\"\n" 5254 "#include <a-a>\n" 5255 "#include < path with space >\n" 5256 "#include \"abc.h\" // this is included for ABC\n" 5257 "#include \"some long include\" // with a comment\n" 5258 "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"", 5259 getLLVMStyleWithColumns(35)); 5260 EXPECT_EQ("#include \"a.h\"", format("#include \"a.h\"")); 5261 EXPECT_EQ("#include <a>", format("#include<a>")); 5262 5263 verifyFormat("#import <string>"); 5264 verifyFormat("#import <a/b/c.h>"); 5265 verifyFormat("#import \"a/b/string\""); 5266 verifyFormat("#import \"string.h\""); 5267 verifyFormat("#import \"string.h\""); 5268 verifyFormat("#if __has_include(<strstream>)\n" 5269 "#include <strstream>\n" 5270 "#endif"); 5271 5272 verifyFormat("#define MY_IMPORT <a/b>"); 5273 5274 // Protocol buffer definition or missing "#". 5275 verifyFormat("import \"aaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaa\";", 5276 getLLVMStyleWithColumns(30)); 5277 5278 FormatStyle Style = getLLVMStyle(); 5279 Style.AlwaysBreakBeforeMultilineStrings = true; 5280 Style.ColumnLimit = 0; 5281 verifyFormat("#import \"abc.h\"", Style); 5282 } 5283 5284 //===----------------------------------------------------------------------===// 5285 // Error recovery tests. 5286 //===----------------------------------------------------------------------===// 5287 5288 TEST_F(FormatTest, IncompleteParameterLists) { 5289 FormatStyle NoBinPacking = getLLVMStyle(); 5290 NoBinPacking.BinPackParameters = false; 5291 verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n" 5292 " double *min_x,\n" 5293 " double *max_x,\n" 5294 " double *min_y,\n" 5295 " double *max_y,\n" 5296 " double *min_z,\n" 5297 " double *max_z, ) {}", 5298 NoBinPacking); 5299 } 5300 5301 TEST_F(FormatTest, IncorrectCodeTrailingStuff) { 5302 verifyFormat("void f() { return; }\n42"); 5303 verifyFormat("void f() {\n" 5304 " if (0)\n" 5305 " return;\n" 5306 "}\n" 5307 "42"); 5308 verifyFormat("void f() { return }\n42"); 5309 verifyFormat("void f() {\n" 5310 " if (0)\n" 5311 " return\n" 5312 "}\n" 5313 "42"); 5314 } 5315 5316 TEST_F(FormatTest, IncorrectCodeMissingSemicolon) { 5317 EXPECT_EQ("void f() { return }", format("void f ( ) { return }")); 5318 EXPECT_EQ("void f() {\n" 5319 " if (a)\n" 5320 " return\n" 5321 "}", 5322 format("void f ( ) { if ( a ) return }")); 5323 EXPECT_EQ("namespace N {\n" 5324 "void f()\n" 5325 "}", 5326 format("namespace N { void f() }")); 5327 EXPECT_EQ("namespace N {\n" 5328 "void f() {}\n" 5329 "void g()\n" 5330 "}", 5331 format("namespace N { void f( ) { } void g( ) }")); 5332 } 5333 5334 TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) { 5335 verifyFormat("int aaaaaaaa =\n" 5336 " // Overlylongcomment\n" 5337 " b;", 5338 getLLVMStyleWithColumns(20)); 5339 verifyFormat("function(\n" 5340 " ShortArgument,\n" 5341 " LoooooooooooongArgument);\n", 5342 getLLVMStyleWithColumns(20)); 5343 } 5344 5345 TEST_F(FormatTest, IncorrectAccessSpecifier) { 5346 verifyFormat("public:"); 5347 verifyFormat("class A {\n" 5348 "public\n" 5349 " void f() {}\n" 5350 "};"); 5351 verifyFormat("public\n" 5352 "int qwerty;"); 5353 verifyFormat("public\n" 5354 "B {}"); 5355 verifyFormat("public\n" 5356 "{}"); 5357 verifyFormat("public\n" 5358 "B { int x; }"); 5359 } 5360 5361 TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) { 5362 verifyFormat("{"); 5363 verifyFormat("#})"); 5364 } 5365 5366 TEST_F(FormatTest, IncorrectCodeDoNoWhile) { 5367 verifyFormat("do {\n}"); 5368 verifyFormat("do {\n}\n" 5369 "f();"); 5370 verifyFormat("do {\n}\n" 5371 "wheeee(fun);"); 5372 verifyFormat("do {\n" 5373 " f();\n" 5374 "}"); 5375 } 5376 5377 TEST_F(FormatTest, IncorrectCodeMissingParens) { 5378 verifyFormat("if {\n foo;\n foo();\n}"); 5379 verifyFormat("switch {\n foo;\n foo();\n}"); 5380 verifyFormat("for {\n foo;\n foo();\n}"); 5381 verifyFormat("while {\n foo;\n foo();\n}"); 5382 verifyFormat("do {\n foo;\n foo();\n} while;"); 5383 } 5384 5385 TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) { 5386 verifyFormat("namespace {\n" 5387 "class Foo { Foo (\n" 5388 "};\n" 5389 "} // comment"); 5390 } 5391 5392 TEST_F(FormatTest, IncorrectCodeErrorDetection) { 5393 EXPECT_EQ("{\n {}\n", format("{\n{\n}\n")); 5394 EXPECT_EQ("{\n {}\n", format("{\n {\n}\n")); 5395 EXPECT_EQ("{\n {}\n", format("{\n {\n }\n")); 5396 EXPECT_EQ("{\n {}\n}\n}\n", format("{\n {\n }\n }\n}\n")); 5397 5398 EXPECT_EQ("{\n" 5399 " {\n" 5400 " breakme(\n" 5401 " qwe);\n" 5402 " }\n", 5403 format("{\n" 5404 " {\n" 5405 " breakme(qwe);\n" 5406 "}\n", 5407 getLLVMStyleWithColumns(10))); 5408 } 5409 5410 TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) { 5411 verifyFormat("int x = {\n" 5412 " avariable,\n" 5413 " b(alongervariable)};", 5414 getLLVMStyleWithColumns(25)); 5415 } 5416 5417 TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) { 5418 verifyFormat("return (a)(b){1, 2, 3};"); 5419 } 5420 5421 TEST_F(FormatTest, LayoutCxx11BraceInitializers) { 5422 verifyFormat("vector<int> x{1, 2, 3, 4};"); 5423 verifyFormat("vector<int> x{\n" 5424 " 1, 2, 3, 4,\n" 5425 "};"); 5426 verifyFormat("vector<T> x{{}, {}, {}, {}};"); 5427 verifyFormat("f({1, 2});"); 5428 verifyFormat("auto v = Foo{-1};"); 5429 verifyFormat("f({1, 2}, {{2, 3}, {4, 5}}, c, {d});"); 5430 verifyFormat("Class::Class : member{1, 2, 3} {}"); 5431 verifyFormat("new vector<int>{1, 2, 3};"); 5432 verifyFormat("new int[3]{1, 2, 3};"); 5433 verifyFormat("new int{1};"); 5434 verifyFormat("return {arg1, arg2};"); 5435 verifyFormat("return {arg1, SomeType{parameter}};"); 5436 verifyFormat("int count = set<int>{f(), g(), h()}.size();"); 5437 verifyFormat("new T{arg1, arg2};"); 5438 verifyFormat("f(MyMap[{composite, key}]);"); 5439 verifyFormat("class Class {\n" 5440 " T member = {arg1, arg2};\n" 5441 "};"); 5442 verifyFormat("vector<int> foo = {::SomeGlobalFunction()};"); 5443 verifyFormat("static_assert(std::is_integral<int>{} + 0, \"\");"); 5444 verifyFormat("int a = std::is_integral<int>{} + 0;"); 5445 5446 verifyFormat("int foo(int i) { return fo1{}(i); }"); 5447 verifyFormat("int foo(int i) { return fo1{}(i); }"); 5448 verifyFormat("auto i = decltype(x){};"); 5449 5450 // In combination with BinPackParameters = false. 5451 FormatStyle NoBinPacking = getLLVMStyle(); 5452 NoBinPacking.BinPackParameters = false; 5453 verifyFormat("const Aaaaaa aaaaa = {aaaaa,\n" 5454 " bbbbb,\n" 5455 " ccccc,\n" 5456 " ddddd,\n" 5457 " eeeee,\n" 5458 " ffffff,\n" 5459 " ggggg,\n" 5460 " hhhhhh,\n" 5461 " iiiiii,\n" 5462 " jjjjjj,\n" 5463 " kkkkkk};", 5464 NoBinPacking); 5465 verifyFormat("const Aaaaaa aaaaa = {\n" 5466 " aaaaa,\n" 5467 " bbbbb,\n" 5468 " ccccc,\n" 5469 " ddddd,\n" 5470 " eeeee,\n" 5471 " ffffff,\n" 5472 " ggggg,\n" 5473 " hhhhhh,\n" 5474 " iiiiii,\n" 5475 " jjjjjj,\n" 5476 " kkkkkk,\n" 5477 "};", 5478 NoBinPacking); 5479 verifyFormat( 5480 "const Aaaaaa aaaaa = {\n" 5481 " aaaaa, bbbbb, ccccc, ddddd, eeeee, ffffff, ggggg, hhhhhh,\n" 5482 " iiiiii, jjjjjj, kkkkkk, aaaaa, bbbbb, ccccc, ddddd, eeeee,\n" 5483 " ffffff, ggggg, hhhhhh, iiiiii, jjjjjj, kkkkkk,\n" 5484 "};", 5485 NoBinPacking); 5486 5487 // FIXME: The alignment of these trailing comments might be bad. Then again, 5488 // this might be utterly useless in real code. 5489 verifyFormat("Constructor::Constructor()\n" 5490 " : some_value{ //\n" 5491 " aaaaaaa //\n" 5492 " } {}"); 5493 5494 // In braced lists, the first comment is always assumed to belong to the 5495 // first element. Thus, it can be moved to the next or previous line as 5496 // appropriate. 5497 EXPECT_EQ("function({// First element:\n" 5498 " 1,\n" 5499 " // Second element:\n" 5500 " 2});", 5501 format("function({\n" 5502 " // First element:\n" 5503 " 1,\n" 5504 " // Second element:\n" 5505 " 2});")); 5506 EXPECT_EQ("std::vector<int> MyNumbers{\n" 5507 " // First element:\n" 5508 " 1,\n" 5509 " // Second element:\n" 5510 " 2};", 5511 format("std::vector<int> MyNumbers{// First element:\n" 5512 " 1,\n" 5513 " // Second element:\n" 5514 " 2};", 5515 getLLVMStyleWithColumns(30))); 5516 5517 FormatStyle ExtraSpaces = getLLVMStyle(); 5518 ExtraSpaces.Cpp11BracedListStyle = false; 5519 ExtraSpaces.ColumnLimit = 75; 5520 verifyFormat("vector<int> x{ 1, 2, 3, 4 };", ExtraSpaces); 5521 verifyFormat("vector<T> x{ {}, {}, {}, {} };", ExtraSpaces); 5522 verifyFormat("f({ 1, 2 });", ExtraSpaces); 5523 verifyFormat("auto v = Foo{ 1 };", ExtraSpaces); 5524 verifyFormat("f({ 1, 2 }, { { 2, 3 }, { 4, 5 } }, c, { d });", ExtraSpaces); 5525 verifyFormat("Class::Class : member{ 1, 2, 3 } {}", ExtraSpaces); 5526 verifyFormat("new vector<int>{ 1, 2, 3 };", ExtraSpaces); 5527 verifyFormat("new int[3]{ 1, 2, 3 };", ExtraSpaces); 5528 verifyFormat("return { arg1, arg2 };", ExtraSpaces); 5529 verifyFormat("return { arg1, SomeType{ parameter } };", ExtraSpaces); 5530 verifyFormat("int count = set<int>{ f(), g(), h() }.size();", ExtraSpaces); 5531 verifyFormat("new T{ arg1, arg2 };", ExtraSpaces); 5532 verifyFormat("f(MyMap[{ composite, key }]);", ExtraSpaces); 5533 verifyFormat("class Class {\n" 5534 " T member = { arg1, arg2 };\n" 5535 "};", 5536 ExtraSpaces); 5537 verifyFormat( 5538 "foo = aaaaaaaaaaa ? vector<int>{ aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5539 " aaaaaaaaaaaaaaaaaaaa, aaaaa }\n" 5540 " : vector<int>{ bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 5541 " bbbbbbbbbbbbbbbbbbbb, bbbbb };", 5542 ExtraSpaces); 5543 verifyFormat("DoSomethingWithVector({} /* No data */);", ExtraSpaces); 5544 verifyFormat("DoSomethingWithVector({\n" 5545 " {} /* No data */\n" 5546 " },\n" 5547 " { { 1, 2 } });", 5548 ExtraSpaces); 5549 verifyFormat( 5550 "someFunction(OtherParam,\n" 5551 " BracedList{ // comment 1 (Forcing interesting break)\n" 5552 " param1, param2,\n" 5553 " // comment 2\n" 5554 " param3, param4\n" 5555 " });", 5556 ExtraSpaces); 5557 verifyFormat( 5558 "std::this_thread::sleep_for(\n" 5559 " std::chrono::nanoseconds{ std::chrono::seconds{ 1 } } / 5);", 5560 ExtraSpaces); 5561 verifyFormat("std::vector<MyValues> aaaaaaaaaaaaaaaaaaa{\n" 5562 " aaaaaaa, aaaaaaaaaa,\n" 5563 " aaaaa, aaaaaaaaaaaaaaa,\n" 5564 " aaa, aaaaaaaaaa,\n" 5565 " a, aaaaaaaaaaaaaaaaaaaaa,\n" 5566 " aaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaa,\n" 5567 " aaaaaaa, a\n" 5568 "};", 5569 ExtraSpaces); 5570 verifyFormat("vector<int> foo = { ::SomeGlobalFunction() };", ExtraSpaces); 5571 } 5572 5573 TEST_F(FormatTest, FormatsBracedListsInColumnLayout) { 5574 verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5575 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5576 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5577 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5578 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5579 " 1, 22, 333, 4444, 55555, 666666, 7777777};"); 5580 verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5581 " // line comment\n" 5582 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5583 " 1, 22, 333, 4444, 55555,\n" 5584 " // line comment\n" 5585 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5586 " 1, 22, 333, 4444, 55555, 666666, 7777777};"); 5587 verifyFormat( 5588 "vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5589 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 5590 " 1, 22, 333, 4444, 55555, 666666, // comment\n" 5591 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 5592 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 5593 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 5594 " 7777777};"); 5595 verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" 5596 " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" 5597 " X86::R8, X86::R9, X86::R10, X86::R11, 0};"); 5598 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 5599 " 1, 1, 1, 1};", 5600 getLLVMStyleWithColumns(39)); 5601 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 5602 " 1, 1, 1, 1};", 5603 getLLVMStyleWithColumns(38)); 5604 verifyFormat("vector<int> aaaaaaaaaaaaaaaaaaaaaa = {\n" 5605 " 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1};", 5606 getLLVMStyleWithColumns(43)); 5607 5608 // Trailing commas. 5609 verifyFormat("vector<int> x = {\n" 5610 " 1, 1, 1, 1, 1, 1, 1, 1,\n" 5611 "};", 5612 getLLVMStyleWithColumns(39)); 5613 verifyFormat("vector<int> x = {\n" 5614 " 1, 1, 1, 1, 1, 1, 1, 1, //\n" 5615 "};", 5616 getLLVMStyleWithColumns(39)); 5617 verifyFormat("vector<int> x = {\n" 5618 " 1, 1, 1, 1, 1, 1, 1, 1,\n" 5619 " /**/ /**/\n" 5620 "};", 5621 getLLVMStyleWithColumns(39)); 5622 verifyFormat("return {{aaaaaaaaaaaaaaaaaaaaa},\n" 5623 " {aaaaaaaaaaaaaaaaaaa},\n" 5624 " {aaaaaaaaaaaaaaaaaaaaa},\n" 5625 " {aaaaaaaaaaaaaaaaa}};", 5626 getLLVMStyleWithColumns(60)); 5627 5628 // With nested lists, we should either format one item per line or all nested 5629 // lists one one line. 5630 // FIXME: For some nested lists, we can do better. 5631 verifyFormat( 5632 "SomeStruct my_struct_array = {\n" 5633 " {aaaaaa, aaaaaaaa, aaaaaaaaaa, aaaaaaaaa, aaaaaaaaa, aaaaaaaaaa,\n" 5634 " aaaaaaaaaaaaa, aaaaaaa, aaa},\n" 5635 " {aaa, aaa},\n" 5636 " {aaa, aaa},\n" 5637 " {aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaa},\n" 5638 " {aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaa,\n" 5639 " aaaaaaaaaaaa, a, aaaaaaaaaa, aaaaaaaaa, aaa}};"); 5640 5641 // No column layout should be used here. 5642 verifyFormat("aaaaaaaaaaaaaaa = {aaaaaaaaaaaaaaaaaaaaaaaaaaa, 0, 0,\n" 5643 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb};"); 5644 } 5645 5646 TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) { 5647 FormatStyle DoNotMerge = getLLVMStyle(); 5648 DoNotMerge.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; 5649 5650 verifyFormat("void f() { return 42; }"); 5651 verifyFormat("void f() {\n" 5652 " return 42;\n" 5653 "}", 5654 DoNotMerge); 5655 verifyFormat("void f() {\n" 5656 " // Comment\n" 5657 "}"); 5658 verifyFormat("{\n" 5659 "#error {\n" 5660 " int a;\n" 5661 "}"); 5662 verifyFormat("{\n" 5663 " int a;\n" 5664 "#error {\n" 5665 "}"); 5666 verifyFormat("void f() {} // comment"); 5667 verifyFormat("void f() { int a; } // comment"); 5668 verifyFormat("void f() {\n" 5669 "} // comment", 5670 DoNotMerge); 5671 verifyFormat("void f() {\n" 5672 " int a;\n" 5673 "} // comment", 5674 DoNotMerge); 5675 verifyFormat("void f() {\n" 5676 "} // comment", 5677 getLLVMStyleWithColumns(15)); 5678 5679 verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23)); 5680 verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22)); 5681 5682 verifyFormat("void f() {}", getLLVMStyleWithColumns(11)); 5683 verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10)); 5684 verifyFormat("class C {\n" 5685 " C()\n" 5686 " : iiiiiiii(nullptr),\n" 5687 " kkkkkkk(nullptr),\n" 5688 " mmmmmmm(nullptr),\n" 5689 " nnnnnnn(nullptr) {}\n" 5690 "};", 5691 getGoogleStyle()); 5692 5693 FormatStyle NoColumnLimit = getLLVMStyle(); 5694 NoColumnLimit.ColumnLimit = 0; 5695 EXPECT_EQ("A() : b(0) {}", format("A():b(0){}", NoColumnLimit)); 5696 EXPECT_EQ("class C {\n" 5697 " A() : b(0) {}\n" 5698 "};", format("class C{A():b(0){}};", NoColumnLimit)); 5699 EXPECT_EQ("A()\n" 5700 " : b(0) {\n" 5701 "}", 5702 format("A()\n:b(0)\n{\n}", NoColumnLimit)); 5703 5704 FormatStyle DoNotMergeNoColumnLimit = NoColumnLimit; 5705 DoNotMergeNoColumnLimit.AllowShortFunctionsOnASingleLine = 5706 FormatStyle::SFS_None; 5707 EXPECT_EQ("A()\n" 5708 " : b(0) {\n" 5709 "}", 5710 format("A():b(0){}", DoNotMergeNoColumnLimit)); 5711 EXPECT_EQ("A()\n" 5712 " : b(0) {\n" 5713 "}", 5714 format("A()\n:b(0)\n{\n}", DoNotMergeNoColumnLimit)); 5715 5716 verifyFormat("#define A \\\n" 5717 " void f() { \\\n" 5718 " int i; \\\n" 5719 " }", 5720 getLLVMStyleWithColumns(20)); 5721 verifyFormat("#define A \\\n" 5722 " void f() { int i; }", 5723 getLLVMStyleWithColumns(21)); 5724 verifyFormat("#define A \\\n" 5725 " void f() { \\\n" 5726 " int i; \\\n" 5727 " } \\\n" 5728 " int j;", 5729 getLLVMStyleWithColumns(22)); 5730 verifyFormat("#define A \\\n" 5731 " void f() { int i; } \\\n" 5732 " int j;", 5733 getLLVMStyleWithColumns(23)); 5734 } 5735 5736 TEST_F(FormatTest, PullInlineFunctionDefinitionsIntoSingleLine) { 5737 FormatStyle MergeInlineOnly = getLLVMStyle(); 5738 MergeInlineOnly.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 5739 verifyFormat("class C {\n" 5740 " int f() { return 42; }\n" 5741 "};", 5742 MergeInlineOnly); 5743 verifyFormat("int f() {\n" 5744 " return 42;\n" 5745 "}", 5746 MergeInlineOnly); 5747 } 5748 5749 TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) { 5750 // Elaborate type variable declarations. 5751 verifyFormat("struct foo a = {bar};\nint n;"); 5752 verifyFormat("class foo a = {bar};\nint n;"); 5753 verifyFormat("union foo a = {bar};\nint n;"); 5754 5755 // Elaborate types inside function definitions. 5756 verifyFormat("struct foo f() {}\nint n;"); 5757 verifyFormat("class foo f() {}\nint n;"); 5758 verifyFormat("union foo f() {}\nint n;"); 5759 5760 // Templates. 5761 verifyFormat("template <class X> void f() {}\nint n;"); 5762 verifyFormat("template <struct X> void f() {}\nint n;"); 5763 verifyFormat("template <union X> void f() {}\nint n;"); 5764 5765 // Actual definitions... 5766 verifyFormat("struct {\n} n;"); 5767 verifyFormat( 5768 "template <template <class T, class Y>, class Z> class X {\n} n;"); 5769 verifyFormat("union Z {\n int n;\n} x;"); 5770 verifyFormat("class MACRO Z {\n} n;"); 5771 verifyFormat("class MACRO(X) Z {\n} n;"); 5772 verifyFormat("class __attribute__(X) Z {\n} n;"); 5773 verifyFormat("class __declspec(X) Z {\n} n;"); 5774 verifyFormat("class A##B##C {\n} n;"); 5775 verifyFormat("class alignas(16) Z {\n} n;"); 5776 5777 // Redefinition from nested context: 5778 verifyFormat("class A::B::C {\n} n;"); 5779 5780 // Template definitions. 5781 verifyFormat( 5782 "template <typename F>\n" 5783 "Matcher(const Matcher<F> &Other,\n" 5784 " typename enable_if_c<is_base_of<F, T>::value &&\n" 5785 " !is_same<F, T>::value>::type * = 0)\n" 5786 " : Implementation(new ImplicitCastMatcher<F>(Other)) {}"); 5787 5788 // FIXME: This is still incorrectly handled at the formatter side. 5789 verifyFormat("template <> struct X < 15, i<3 && 42 < 50 && 33 < 28> {};"); 5790 5791 // FIXME: 5792 // This now gets parsed incorrectly as class definition. 5793 // verifyFormat("class A<int> f() {\n}\nint n;"); 5794 5795 // Elaborate types where incorrectly parsing the structural element would 5796 // break the indent. 5797 verifyFormat("if (true)\n" 5798 " class X x;\n" 5799 "else\n" 5800 " f();\n"); 5801 5802 // This is simply incomplete. Formatting is not important, but must not crash. 5803 verifyFormat("class A:"); 5804 } 5805 5806 TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) { 5807 EXPECT_EQ("#error Leave all white!!!!! space* alone!\n", 5808 format("#error Leave all white!!!!! space* alone!\n")); 5809 EXPECT_EQ( 5810 "#warning Leave all white!!!!! space* alone!\n", 5811 format("#warning Leave all white!!!!! space* alone!\n")); 5812 EXPECT_EQ("#error 1", format(" # error 1")); 5813 EXPECT_EQ("#warning 1", format(" # warning 1")); 5814 } 5815 5816 TEST_F(FormatTest, FormatHashIfExpressions) { 5817 verifyFormat("#if AAAA && BBBB"); 5818 // FIXME: Come up with a better indentation for #elif. 5819 verifyFormat( 5820 "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n" 5821 " defined(BBBBBBBB)\n" 5822 "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n" 5823 " defined(BBBBBBBB)\n" 5824 "#endif", 5825 getLLVMStyleWithColumns(65)); 5826 } 5827 5828 TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) { 5829 FormatStyle AllowsMergedIf = getGoogleStyle(); 5830 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 5831 verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf); 5832 verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf); 5833 verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf); 5834 EXPECT_EQ("if (true) return 42;", 5835 format("if (true)\nreturn 42;", AllowsMergedIf)); 5836 FormatStyle ShortMergedIf = AllowsMergedIf; 5837 ShortMergedIf.ColumnLimit = 25; 5838 verifyFormat("#define A \\\n" 5839 " if (true) return 42;", 5840 ShortMergedIf); 5841 verifyFormat("#define A \\\n" 5842 " f(); \\\n" 5843 " if (true)\n" 5844 "#define B", 5845 ShortMergedIf); 5846 verifyFormat("#define A \\\n" 5847 " f(); \\\n" 5848 " if (true)\n" 5849 "g();", 5850 ShortMergedIf); 5851 verifyFormat("{\n" 5852 "#ifdef A\n" 5853 " // Comment\n" 5854 " if (true) continue;\n" 5855 "#endif\n" 5856 " // Comment\n" 5857 " if (true) continue;\n" 5858 "}", 5859 ShortMergedIf); 5860 ShortMergedIf.ColumnLimit = 29; 5861 verifyFormat("#define A \\\n" 5862 " if (aaaaaaaaaa) return 1; \\\n" 5863 " return 2;", 5864 ShortMergedIf); 5865 ShortMergedIf.ColumnLimit = 28; 5866 verifyFormat("#define A \\\n" 5867 " if (aaaaaaaaaa) \\\n" 5868 " return 1; \\\n" 5869 " return 2;", 5870 ShortMergedIf); 5871 } 5872 5873 TEST_F(FormatTest, BlockCommentsInControlLoops) { 5874 verifyFormat("if (0) /* a comment in a strange place */ {\n" 5875 " f();\n" 5876 "}"); 5877 verifyFormat("if (0) /* a comment in a strange place */ {\n" 5878 " f();\n" 5879 "} /* another comment */ else /* comment #3 */ {\n" 5880 " g();\n" 5881 "}"); 5882 verifyFormat("while (0) /* a comment in a strange place */ {\n" 5883 " f();\n" 5884 "}"); 5885 verifyFormat("for (;;) /* a comment in a strange place */ {\n" 5886 " f();\n" 5887 "}"); 5888 verifyFormat("do /* a comment in a strange place */ {\n" 5889 " f();\n" 5890 "} /* another comment */ while (0);"); 5891 } 5892 5893 TEST_F(FormatTest, BlockComments) { 5894 EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */", 5895 format("/* *//* */ /* */\n/* *//* */ /* */")); 5896 EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;")); 5897 EXPECT_EQ("#define A /*123*/ \\\n" 5898 " b\n" 5899 "/* */\n" 5900 "someCall(\n" 5901 " parameter);", 5902 format("#define A /*123*/ b\n" 5903 "/* */\n" 5904 "someCall(parameter);", 5905 getLLVMStyleWithColumns(15))); 5906 5907 EXPECT_EQ("#define A\n" 5908 "/* */ someCall(\n" 5909 " parameter);", 5910 format("#define A\n" 5911 "/* */someCall(parameter);", 5912 getLLVMStyleWithColumns(15))); 5913 EXPECT_EQ("/*\n**\n*/", format("/*\n**\n*/")); 5914 EXPECT_EQ("/*\n" 5915 "*\n" 5916 " * aaaaaa\n" 5917 "*aaaaaa\n" 5918 "*/", 5919 format("/*\n" 5920 "*\n" 5921 " * aaaaaa aaaaaa\n" 5922 "*/", 5923 getLLVMStyleWithColumns(10))); 5924 EXPECT_EQ("/*\n" 5925 "**\n" 5926 "* aaaaaa\n" 5927 "*aaaaaa\n" 5928 "*/", 5929 format("/*\n" 5930 "**\n" 5931 "* aaaaaa aaaaaa\n" 5932 "*/", 5933 getLLVMStyleWithColumns(10))); 5934 5935 FormatStyle NoBinPacking = getLLVMStyle(); 5936 NoBinPacking.BinPackParameters = false; 5937 EXPECT_EQ("someFunction(1, /* comment 1 */\n" 5938 " 2, /* comment 2 */\n" 5939 " 3, /* comment 3 */\n" 5940 " aaaa,\n" 5941 " bbbb);", 5942 format("someFunction (1, /* comment 1 */\n" 5943 " 2, /* comment 2 */ \n" 5944 " 3, /* comment 3 */\n" 5945 "aaaa, bbbb );", 5946 NoBinPacking)); 5947 verifyFormat( 5948 "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 5949 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 5950 EXPECT_EQ( 5951 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 5952 " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 5953 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;", 5954 format( 5955 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 5956 " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 5957 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;")); 5958 EXPECT_EQ( 5959 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 5960 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 5961 "int cccccccccccccccccccccccccccccc; /* comment */\n", 5962 format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 5963 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 5964 "int cccccccccccccccccccccccccccccc; /* comment */\n")); 5965 5966 verifyFormat("void f(int * /* unused */) {}"); 5967 5968 EXPECT_EQ("/*\n" 5969 " **\n" 5970 " */", 5971 format("/*\n" 5972 " **\n" 5973 " */")); 5974 EXPECT_EQ("/*\n" 5975 " *q\n" 5976 " */", 5977 format("/*\n" 5978 " *q\n" 5979 " */")); 5980 EXPECT_EQ("/*\n" 5981 " * q\n" 5982 " */", 5983 format("/*\n" 5984 " * q\n" 5985 " */")); 5986 EXPECT_EQ("/*\n" 5987 " **/", 5988 format("/*\n" 5989 " **/")); 5990 EXPECT_EQ("/*\n" 5991 " ***/", 5992 format("/*\n" 5993 " ***/")); 5994 } 5995 5996 TEST_F(FormatTest, BlockCommentsInMacros) { 5997 EXPECT_EQ("#define A \\\n" 5998 " { \\\n" 5999 " /* one line */ \\\n" 6000 " someCall();", 6001 format("#define A { \\\n" 6002 " /* one line */ \\\n" 6003 " someCall();", 6004 getLLVMStyleWithColumns(20))); 6005 EXPECT_EQ("#define A \\\n" 6006 " { \\\n" 6007 " /* previous */ \\\n" 6008 " /* one line */ \\\n" 6009 " someCall();", 6010 format("#define A { \\\n" 6011 " /* previous */ \\\n" 6012 " /* one line */ \\\n" 6013 " someCall();", 6014 getLLVMStyleWithColumns(20))); 6015 } 6016 6017 TEST_F(FormatTest, BlockCommentsAtEndOfLine) { 6018 EXPECT_EQ("a = {\n" 6019 " 1111 /* */\n" 6020 "};", 6021 format("a = {1111 /* */\n" 6022 "};", 6023 getLLVMStyleWithColumns(15))); 6024 EXPECT_EQ("a = {\n" 6025 " 1111 /* */\n" 6026 "};", 6027 format("a = {1111 /* */\n" 6028 "};", 6029 getLLVMStyleWithColumns(15))); 6030 6031 // FIXME: The formatting is still wrong here. 6032 EXPECT_EQ("a = {\n" 6033 " 1111 /* a\n" 6034 " */\n" 6035 "};", 6036 format("a = {1111 /* a */\n" 6037 "};", 6038 getLLVMStyleWithColumns(15))); 6039 } 6040 6041 TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) { 6042 // FIXME: This is not what we want... 6043 verifyFormat("{\n" 6044 "// a" 6045 "// b"); 6046 } 6047 6048 TEST_F(FormatTest, FormatStarDependingOnContext) { 6049 verifyFormat("void f(int *a);"); 6050 verifyFormat("void f() { f(fint * b); }"); 6051 verifyFormat("class A {\n void f(int *a);\n};"); 6052 verifyFormat("class A {\n int *a;\n};"); 6053 verifyFormat("namespace a {\n" 6054 "namespace b {\n" 6055 "class A {\n" 6056 " void f() {}\n" 6057 " int *a;\n" 6058 "};\n" 6059 "}\n" 6060 "}"); 6061 } 6062 6063 TEST_F(FormatTest, SpecialTokensAtEndOfLine) { 6064 verifyFormat("while"); 6065 verifyFormat("operator"); 6066 } 6067 6068 //===----------------------------------------------------------------------===// 6069 // Objective-C tests. 6070 //===----------------------------------------------------------------------===// 6071 6072 TEST_F(FormatTest, FormatForObjectiveCMethodDecls) { 6073 verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;"); 6074 EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;", 6075 format("-(NSUInteger)indexOfObject:(id)anObject;")); 6076 EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;")); 6077 EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;")); 6078 EXPECT_EQ("- (NSInteger)Method3:(id)anObject;", 6079 format("-(NSInteger)Method3:(id)anObject;")); 6080 EXPECT_EQ("- (NSInteger)Method4:(id)anObject;", 6081 format("-(NSInteger)Method4:(id)anObject;")); 6082 EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;", 6083 format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;")); 6084 EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;", 6085 format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;")); 6086 EXPECT_EQ( 6087 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;", 6088 format( 6089 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;")); 6090 6091 // Very long objectiveC method declaration. 6092 verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n" 6093 " inRange:(NSRange)range\n" 6094 " outRange:(NSRange)out_range\n" 6095 " outRange1:(NSRange)out_range1\n" 6096 " outRange2:(NSRange)out_range2\n" 6097 " outRange3:(NSRange)out_range3\n" 6098 " outRange4:(NSRange)out_range4\n" 6099 " outRange5:(NSRange)out_range5\n" 6100 " outRange6:(NSRange)out_range6\n" 6101 " outRange7:(NSRange)out_range7\n" 6102 " outRange8:(NSRange)out_range8\n" 6103 " outRange9:(NSRange)out_range9;"); 6104 6105 verifyFormat("- (int)sum:(vector<int>)numbers;"); 6106 verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;"); 6107 // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC 6108 // protocol lists (but not for template classes): 6109 //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;"); 6110 6111 verifyFormat("- (int (*)())foo:(int (*)())f;"); 6112 verifyGoogleFormat("- (int (*)())foo:(int (*)())foo;"); 6113 6114 // If there's no return type (very rare in practice!), LLVM and Google style 6115 // agree. 6116 verifyFormat("- foo;"); 6117 verifyFormat("- foo:(int)f;"); 6118 verifyGoogleFormat("- foo:(int)foo;"); 6119 } 6120 6121 TEST_F(FormatTest, FormatObjCInterface) { 6122 verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" 6123 "@public\n" 6124 " int field1;\n" 6125 "@protected\n" 6126 " int field2;\n" 6127 "@private\n" 6128 " int field3;\n" 6129 "@package\n" 6130 " int field4;\n" 6131 "}\n" 6132 "+ (id)init;\n" 6133 "@end"); 6134 6135 verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n" 6136 " @public\n" 6137 " int field1;\n" 6138 " @protected\n" 6139 " int field2;\n" 6140 " @private\n" 6141 " int field3;\n" 6142 " @package\n" 6143 " int field4;\n" 6144 "}\n" 6145 "+ (id)init;\n" 6146 "@end"); 6147 6148 verifyFormat("@interface /* wait for it */ Foo\n" 6149 "+ (id)init;\n" 6150 "// Look, a comment!\n" 6151 "- (int)answerWith:(int)i;\n" 6152 "@end"); 6153 6154 verifyFormat("@interface Foo\n" 6155 "@end\n" 6156 "@interface Bar\n" 6157 "@end"); 6158 6159 verifyFormat("@interface Foo : Bar\n" 6160 "+ (id)init;\n" 6161 "@end"); 6162 6163 verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n" 6164 "+ (id)init;\n" 6165 "@end"); 6166 6167 verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n" 6168 "+ (id)init;\n" 6169 "@end"); 6170 6171 verifyFormat("@interface Foo (HackStuff)\n" 6172 "+ (id)init;\n" 6173 "@end"); 6174 6175 verifyFormat("@interface Foo ()\n" 6176 "+ (id)init;\n" 6177 "@end"); 6178 6179 verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" 6180 "+ (id)init;\n" 6181 "@end"); 6182 6183 verifyGoogleFormat("@interface Foo (HackStuff) <MyProtocol>\n" 6184 "+ (id)init;\n" 6185 "@end"); 6186 6187 verifyFormat("@interface Foo {\n" 6188 " int _i;\n" 6189 "}\n" 6190 "+ (id)init;\n" 6191 "@end"); 6192 6193 verifyFormat("@interface Foo : Bar {\n" 6194 " int _i;\n" 6195 "}\n" 6196 "+ (id)init;\n" 6197 "@end"); 6198 6199 verifyFormat("@interface Foo : Bar <Baz, Quux> {\n" 6200 " int _i;\n" 6201 "}\n" 6202 "+ (id)init;\n" 6203 "@end"); 6204 6205 verifyFormat("@interface Foo (HackStuff) {\n" 6206 " int _i;\n" 6207 "}\n" 6208 "+ (id)init;\n" 6209 "@end"); 6210 6211 verifyFormat("@interface Foo () {\n" 6212 " int _i;\n" 6213 "}\n" 6214 "+ (id)init;\n" 6215 "@end"); 6216 6217 verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n" 6218 " int _i;\n" 6219 "}\n" 6220 "+ (id)init;\n" 6221 "@end"); 6222 6223 FormatStyle OnePerLine = getGoogleStyle(); 6224 OnePerLine.BinPackParameters = false; 6225 verifyFormat("@interface aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa () <\n" 6226 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6227 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6228 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6229 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n" 6230 "}", 6231 OnePerLine); 6232 } 6233 6234 TEST_F(FormatTest, FormatObjCImplementation) { 6235 verifyFormat("@implementation Foo : NSObject {\n" 6236 "@public\n" 6237 " int field1;\n" 6238 "@protected\n" 6239 " int field2;\n" 6240 "@private\n" 6241 " int field3;\n" 6242 "@package\n" 6243 " int field4;\n" 6244 "}\n" 6245 "+ (id)init {\n}\n" 6246 "@end"); 6247 6248 verifyGoogleFormat("@implementation Foo : NSObject {\n" 6249 " @public\n" 6250 " int field1;\n" 6251 " @protected\n" 6252 " int field2;\n" 6253 " @private\n" 6254 " int field3;\n" 6255 " @package\n" 6256 " int field4;\n" 6257 "}\n" 6258 "+ (id)init {\n}\n" 6259 "@end"); 6260 6261 verifyFormat("@implementation Foo\n" 6262 "+ (id)init {\n" 6263 " if (true)\n" 6264 " return nil;\n" 6265 "}\n" 6266 "// Look, a comment!\n" 6267 "- (int)answerWith:(int)i {\n" 6268 " return i;\n" 6269 "}\n" 6270 "+ (int)answerWith:(int)i {\n" 6271 " return i;\n" 6272 "}\n" 6273 "@end"); 6274 6275 verifyFormat("@implementation Foo\n" 6276 "@end\n" 6277 "@implementation Bar\n" 6278 "@end"); 6279 6280 EXPECT_EQ("@implementation Foo : Bar\n" 6281 "+ (id)init {\n}\n" 6282 "- (void)foo {\n}\n" 6283 "@end", 6284 format("@implementation Foo : Bar\n" 6285 "+(id)init{}\n" 6286 "-(void)foo{}\n" 6287 "@end")); 6288 6289 verifyFormat("@implementation Foo {\n" 6290 " int _i;\n" 6291 "}\n" 6292 "+ (id)init {\n}\n" 6293 "@end"); 6294 6295 verifyFormat("@implementation Foo : Bar {\n" 6296 " int _i;\n" 6297 "}\n" 6298 "+ (id)init {\n}\n" 6299 "@end"); 6300 6301 verifyFormat("@implementation Foo (HackStuff)\n" 6302 "+ (id)init {\n}\n" 6303 "@end"); 6304 verifyFormat("@implementation ObjcClass\n" 6305 "- (void)method;\n" 6306 "{}\n" 6307 "@end"); 6308 } 6309 6310 TEST_F(FormatTest, FormatObjCProtocol) { 6311 verifyFormat("@protocol Foo\n" 6312 "@property(weak) id delegate;\n" 6313 "- (NSUInteger)numberOfThings;\n" 6314 "@end"); 6315 6316 verifyFormat("@protocol MyProtocol <NSObject>\n" 6317 "- (NSUInteger)numberOfThings;\n" 6318 "@end"); 6319 6320 verifyGoogleFormat("@protocol MyProtocol<NSObject>\n" 6321 "- (NSUInteger)numberOfThings;\n" 6322 "@end"); 6323 6324 verifyFormat("@protocol Foo;\n" 6325 "@protocol Bar;\n"); 6326 6327 verifyFormat("@protocol Foo\n" 6328 "@end\n" 6329 "@protocol Bar\n" 6330 "@end"); 6331 6332 verifyFormat("@protocol myProtocol\n" 6333 "- (void)mandatoryWithInt:(int)i;\n" 6334 "@optional\n" 6335 "- (void)optional;\n" 6336 "@required\n" 6337 "- (void)required;\n" 6338 "@optional\n" 6339 "@property(assign) int madProp;\n" 6340 "@end\n"); 6341 6342 verifyFormat("@property(nonatomic, assign, readonly)\n" 6343 " int *looooooooooooooooooooooooooooongNumber;\n" 6344 "@property(nonatomic, assign, readonly)\n" 6345 " NSString *looooooooooooooooooooooooooooongName;"); 6346 6347 verifyFormat("@implementation PR18406\n" 6348 "}\n" 6349 "@end"); 6350 } 6351 6352 TEST_F(FormatTest, FormatObjCMethodDeclarations) { 6353 verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" 6354 " rect:(NSRect)theRect\n" 6355 " interval:(float)theInterval {\n" 6356 "}"); 6357 verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" 6358 " longKeyword:(NSRect)theRect\n" 6359 " evenLongerKeyword:(float)theInterval\n" 6360 " error:(NSError **)theError {\n" 6361 "}"); 6362 } 6363 6364 TEST_F(FormatTest, FormatObjCMethodExpr) { 6365 verifyFormat("[foo bar:baz];"); 6366 verifyFormat("return [foo bar:baz];"); 6367 verifyFormat("f([foo bar:baz]);"); 6368 verifyFormat("f(2, [foo bar:baz]);"); 6369 verifyFormat("f(2, a ? b : c);"); 6370 verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); 6371 6372 // Unary operators. 6373 verifyFormat("int a = +[foo bar:baz];"); 6374 verifyFormat("int a = -[foo bar:baz];"); 6375 verifyFormat("int a = ![foo bar:baz];"); 6376 verifyFormat("int a = ~[foo bar:baz];"); 6377 verifyFormat("int a = ++[foo bar:baz];"); 6378 verifyFormat("int a = --[foo bar:baz];"); 6379 verifyFormat("int a = sizeof [foo bar:baz];"); 6380 verifyFormat("int a = alignof [foo bar:baz];", getGoogleStyle()); 6381 verifyFormat("int a = &[foo bar:baz];"); 6382 verifyFormat("int a = *[foo bar:baz];"); 6383 // FIXME: Make casts work, without breaking f()[4]. 6384 //verifyFormat("int a = (int)[foo bar:baz];"); 6385 //verifyFormat("return (int)[foo bar:baz];"); 6386 //verifyFormat("(void)[foo bar:baz];"); 6387 verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); 6388 6389 // Binary operators. 6390 verifyFormat("[foo bar:baz], [foo bar:baz];"); 6391 verifyFormat("[foo bar:baz] = [foo bar:baz];"); 6392 verifyFormat("[foo bar:baz] *= [foo bar:baz];"); 6393 verifyFormat("[foo bar:baz] /= [foo bar:baz];"); 6394 verifyFormat("[foo bar:baz] %= [foo bar:baz];"); 6395 verifyFormat("[foo bar:baz] += [foo bar:baz];"); 6396 verifyFormat("[foo bar:baz] -= [foo bar:baz];"); 6397 verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); 6398 verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); 6399 verifyFormat("[foo bar:baz] &= [foo bar:baz];"); 6400 verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); 6401 verifyFormat("[foo bar:baz] |= [foo bar:baz];"); 6402 verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); 6403 verifyFormat("[foo bar:baz] || [foo bar:baz];"); 6404 verifyFormat("[foo bar:baz] && [foo bar:baz];"); 6405 verifyFormat("[foo bar:baz] | [foo bar:baz];"); 6406 verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); 6407 verifyFormat("[foo bar:baz] & [foo bar:baz];"); 6408 verifyFormat("[foo bar:baz] == [foo bar:baz];"); 6409 verifyFormat("[foo bar:baz] != [foo bar:baz];"); 6410 verifyFormat("[foo bar:baz] >= [foo bar:baz];"); 6411 verifyFormat("[foo bar:baz] <= [foo bar:baz];"); 6412 verifyFormat("[foo bar:baz] > [foo bar:baz];"); 6413 verifyFormat("[foo bar:baz] < [foo bar:baz];"); 6414 verifyFormat("[foo bar:baz] >> [foo bar:baz];"); 6415 verifyFormat("[foo bar:baz] << [foo bar:baz];"); 6416 verifyFormat("[foo bar:baz] - [foo bar:baz];"); 6417 verifyFormat("[foo bar:baz] + [foo bar:baz];"); 6418 verifyFormat("[foo bar:baz] * [foo bar:baz];"); 6419 verifyFormat("[foo bar:baz] / [foo bar:baz];"); 6420 verifyFormat("[foo bar:baz] % [foo bar:baz];"); 6421 // Whew! 6422 6423 verifyFormat("return in[42];"); 6424 verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" 6425 "}"); 6426 6427 verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); 6428 verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); 6429 verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); 6430 verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); 6431 verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); 6432 verifyFormat("[button setAction:@selector(zoomOut:)];"); 6433 verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); 6434 6435 verifyFormat("arr[[self indexForFoo:a]];"); 6436 verifyFormat("throw [self errorFor:a];"); 6437 verifyFormat("@throw [self errorFor:a];"); 6438 6439 verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); 6440 verifyFormat("[(id)foo bar:(id) ? baz : quux];"); 6441 verifyFormat("4 > 4 ? (id)a : (id)baz;"); 6442 6443 // This tests that the formatter doesn't break after "backing" but before ":", 6444 // which would be at 80 columns. 6445 verifyFormat( 6446 "void f() {\n" 6447 " if ((self = [super initWithContentRect:contentRect\n" 6448 " styleMask:styleMask ?: otherMask\n" 6449 " backing:NSBackingStoreBuffered\n" 6450 " defer:YES]))"); 6451 6452 verifyFormat( 6453 "[foo checkThatBreakingAfterColonWorksOk:\n" 6454 " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); 6455 6456 verifyFormat("[myObj short:arg1 // Force line break\n" 6457 " longKeyword:arg2 != nil ? arg2 : @\"longKeyword\"\n" 6458 " evenLongerKeyword:arg3 ?: @\"evenLongerKeyword\"\n" 6459 " error:arg4];"); 6460 verifyFormat( 6461 "void f() {\n" 6462 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 6463 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" 6464 " pos.width(), pos.height())\n" 6465 " styleMask:NSBorderlessWindowMask\n" 6466 " backing:NSBackingStoreBuffered\n" 6467 " defer:NO]);\n" 6468 "}"); 6469 verifyFormat( 6470 "void f() {\n" 6471 " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" 6472 " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" 6473 " pos.width(), pos.height())\n" 6474 " syeMask:NSBorderlessWindowMask\n" 6475 " bking:NSBackingStoreBuffered\n" 6476 " der:NO]);\n" 6477 "}", 6478 getLLVMStyleWithColumns(70)); 6479 verifyFormat("{\n" 6480 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 6481 " initWithContentRect:NSMakeRect(origin_global.x,\n" 6482 " origin_global.y,\n" 6483 " pos.width(),\n" 6484 " pos.height())\n" 6485 " styleMask:NSBorderlessWindowMask\n" 6486 " backing:NSBackingStoreBuffered\n" 6487 " defer:NO]);\n" 6488 "}", 6489 getChromiumStyle(FormatStyle::LK_Cpp)); 6490 verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" 6491 " with:contentsNativeView];"); 6492 6493 verifyFormat( 6494 "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" 6495 " owner:nillllll];"); 6496 6497 verifyFormat( 6498 "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" 6499 " forType:kBookmarkButtonDragType];"); 6500 6501 verifyFormat("[defaultCenter addObserver:self\n" 6502 " selector:@selector(willEnterFullscreen)\n" 6503 " name:kWillEnterFullscreenNotification\n" 6504 " object:nil];"); 6505 verifyFormat("[image_rep drawInRect:drawRect\n" 6506 " fromRect:NSZeroRect\n" 6507 " operation:NSCompositeCopy\n" 6508 " fraction:1.0\n" 6509 " respectFlipped:NO\n" 6510 " hints:nil];"); 6511 6512 verifyFormat( 6513 "scoped_nsobject<NSTextField> message(\n" 6514 " // The frame will be fixed up when |-setMessageText:| is called.\n" 6515 " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); 6516 verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" 6517 " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" 6518 " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" 6519 " aaaa:bbb];"); 6520 verifyFormat("[self param:function( //\n" 6521 " parameter)]"); 6522 verifyFormat( 6523 "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 6524 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 6525 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); 6526 6527 // Variadic parameters. 6528 verifyFormat( 6529 "NSArray *myStrings = [NSArray stringarray:@\"a\", @\"b\", nil];"); 6530 verifyFormat( 6531 "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 6532 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 6533 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); 6534 verifyFormat("[self // break\n" 6535 " a:a\n" 6536 " aaa:aaa];"); 6537 verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" 6538 " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); 6539 } 6540 6541 TEST_F(FormatTest, ObjCAt) { 6542 verifyFormat("@autoreleasepool"); 6543 verifyFormat("@catch"); 6544 verifyFormat("@class"); 6545 verifyFormat("@compatibility_alias"); 6546 verifyFormat("@defs"); 6547 verifyFormat("@dynamic"); 6548 verifyFormat("@encode"); 6549 verifyFormat("@end"); 6550 verifyFormat("@finally"); 6551 verifyFormat("@implementation"); 6552 verifyFormat("@import"); 6553 verifyFormat("@interface"); 6554 verifyFormat("@optional"); 6555 verifyFormat("@package"); 6556 verifyFormat("@private"); 6557 verifyFormat("@property"); 6558 verifyFormat("@protected"); 6559 verifyFormat("@protocol"); 6560 verifyFormat("@public"); 6561 verifyFormat("@required"); 6562 verifyFormat("@selector"); 6563 verifyFormat("@synchronized"); 6564 verifyFormat("@synthesize"); 6565 verifyFormat("@throw"); 6566 verifyFormat("@try"); 6567 6568 EXPECT_EQ("@interface", format("@ interface")); 6569 6570 // The precise formatting of this doesn't matter, nobody writes code like 6571 // this. 6572 verifyFormat("@ /*foo*/ interface"); 6573 } 6574 6575 TEST_F(FormatTest, ObjCSnippets) { 6576 verifyFormat("@autoreleasepool {\n" 6577 " foo();\n" 6578 "}"); 6579 verifyFormat("@class Foo, Bar;"); 6580 verifyFormat("@compatibility_alias AliasName ExistingClass;"); 6581 verifyFormat("@dynamic textColor;"); 6582 verifyFormat("char *buf1 = @encode(int *);"); 6583 verifyFormat("char *buf1 = @encode(typeof(4 * 5));"); 6584 verifyFormat("char *buf1 = @encode(int **);"); 6585 verifyFormat("Protocol *proto = @protocol(p1);"); 6586 verifyFormat("SEL s = @selector(foo:);"); 6587 verifyFormat("@synchronized(self) {\n" 6588 " f();\n" 6589 "}"); 6590 6591 verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 6592 verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 6593 6594 verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;"); 6595 verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); 6596 verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;"); 6597 verifyFormat("@property (assign, getter=isEditable) BOOL editable;", 6598 getMozillaStyle()); 6599 verifyFormat("@property BOOL editable;", getMozillaStyle()); 6600 verifyFormat("@property (assign, getter=isEditable) BOOL editable;", 6601 getWebKitStyle()); 6602 verifyFormat("@property BOOL editable;", getWebKitStyle()); 6603 6604 verifyFormat("@import foo.bar;\n" 6605 "@import baz;"); 6606 } 6607 6608 TEST_F(FormatTest, ObjCLiterals) { 6609 verifyFormat("@\"String\""); 6610 verifyFormat("@1"); 6611 verifyFormat("@+4.8"); 6612 verifyFormat("@-4"); 6613 verifyFormat("@1LL"); 6614 verifyFormat("@.5"); 6615 verifyFormat("@'c'"); 6616 verifyFormat("@true"); 6617 6618 verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);"); 6619 verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);"); 6620 verifyFormat("NSNumber *favoriteColor = @(Green);"); 6621 verifyFormat("NSString *path = @(getenv(\"PATH\"));"); 6622 6623 verifyFormat("[dictionary setObject:@(1) forKey:@\"number\"];"); 6624 } 6625 6626 TEST_F(FormatTest, ObjCDictLiterals) { 6627 verifyFormat("@{"); 6628 verifyFormat("@{}"); 6629 verifyFormat("@{@\"one\" : @1}"); 6630 verifyFormat("return @{@\"one\" : @1;"); 6631 verifyFormat("@{@\"one\" : @1}"); 6632 6633 verifyFormat("@{@\"one\" : @{@2 : @1}}"); 6634 verifyFormat("@{\n" 6635 " @\"one\" : @{@2 : @1},\n" 6636 "}"); 6637 6638 verifyFormat("@{1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2}"); 6639 verifyFormat("[self setDict:@{}"); 6640 verifyFormat("[self setDict:@{@1 : @2}"); 6641 verifyFormat("NSLog(@\"%@\", @{@1 : @2, @2 : @3}[@1]);"); 6642 verifyFormat( 6643 "NSDictionary *masses = @{@\"H\" : @1.0078, @\"He\" : @4.0026};"); 6644 verifyFormat( 6645 "NSDictionary *settings = @{AVEncoderKey : @(AVAudioQualityMax)};"); 6646 6647 verifyFormat( 6648 "NSDictionary *d = @{\n" 6649 " @\"nam\" : NSUserNam(),\n" 6650 " @\"dte\" : [NSDate date],\n" 6651 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 6652 "};"); 6653 verifyFormat( 6654 "@{\n" 6655 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 6656 "regularFont,\n" 6657 "};"); 6658 verifyGoogleFormat( 6659 "@{\n" 6660 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 6661 "regularFont,\n" 6662 "};"); 6663 verifyFormat( 6664 "@{\n" 6665 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee :\n" 6666 " reeeeeeeeeeeeeeeeeeeeeeeegularFont,\n" 6667 "};"); 6668 6669 // We should try to be robust in case someone forgets the "@". 6670 verifyFormat( 6671 "NSDictionary *d = {\n" 6672 " @\"nam\" : NSUserNam(),\n" 6673 " @\"dte\" : [NSDate date],\n" 6674 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 6675 "};"); 6676 verifyFormat("NSMutableDictionary *dictionary =\n" 6677 " [NSMutableDictionary dictionaryWithDictionary:@{\n" 6678 " aaaaaaaaaaaaaaaaaaaaa : aaaaaaaaaaaaa,\n" 6679 " bbbbbbbbbbbbbbbbbb : bbbbb,\n" 6680 " cccccccccccccccc : ccccccccccccccc\n" 6681 " }];"); 6682 } 6683 6684 TEST_F(FormatTest, ObjCArrayLiterals) { 6685 verifyFormat("@["); 6686 verifyFormat("@[]"); 6687 verifyFormat( 6688 "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); 6689 verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];"); 6690 verifyFormat("NSArray *array = @[ [foo description] ];"); 6691 6692 verifyFormat( 6693 "NSArray *some_variable = @[\n" 6694 " aaaa == bbbbbbbbbbb ? @\"aaaaaaaaaaaa\" : @\"aaaaaaaaaaaaaa\",\n" 6695 " @\"aaaaaaaaaaaaaaaaa\",\n" 6696 " @\"aaaaaaaaaaaaaaaaa\",\n" 6697 " @\"aaaaaaaaaaaaaaaaa\"\n" 6698 "];"); 6699 verifyFormat("NSArray *some_variable = @[\n" 6700 " @\"aaaaaaaaaaaaaaaaa\",\n" 6701 " @\"aaaaaaaaaaaaaaaaa\",\n" 6702 " @\"aaaaaaaaaaaaaaaaa\",\n" 6703 " @\"aaaaaaaaaaaaaaaaa\",\n" 6704 "];"); 6705 verifyGoogleFormat("NSArray *some_variable = @[\n" 6706 " @\"aaaaaaaaaaaaaaaaa\",\n" 6707 " @\"aaaaaaaaaaaaaaaaa\",\n" 6708 " @\"aaaaaaaaaaaaaaaaa\",\n" 6709 " @\"aaaaaaaaaaaaaaaaa\"\n" 6710 "];"); 6711 6712 // We should try to be robust in case someone forgets the "@". 6713 verifyFormat("NSArray *some_variable = [\n" 6714 " @\"aaaaaaaaaaaaaaaaa\",\n" 6715 " @\"aaaaaaaaaaaaaaaaa\",\n" 6716 " @\"aaaaaaaaaaaaaaaaa\",\n" 6717 " @\"aaaaaaaaaaaaaaaaa\",\n" 6718 "];"); 6719 verifyFormat( 6720 "- (NSAttributedString *)attributedStringForSegment:(NSUInteger)segment\n" 6721 " index:(NSUInteger)index\n" 6722 " nonDigitAttributes:\n" 6723 " (NSDictionary *)noDigitAttributes;"); 6724 verifyFormat( 6725 "[someFunction someLooooooooooooongParameter:\n" 6726 " @[ NSBundle.mainBundle.infoDictionary[@\"a\"] ]];"); 6727 } 6728 6729 TEST_F(FormatTest, ReformatRegionAdjustsIndent) { 6730 EXPECT_EQ("{\n" 6731 "{\n" 6732 "a;\n" 6733 "b;\n" 6734 "}\n" 6735 "}", 6736 format("{\n" 6737 "{\n" 6738 "a;\n" 6739 " b;\n" 6740 "}\n" 6741 "}", 6742 13, 2, getLLVMStyle())); 6743 EXPECT_EQ("{\n" 6744 "{\n" 6745 " a;\n" 6746 "b;\n" 6747 "}\n" 6748 "}", 6749 format("{\n" 6750 "{\n" 6751 " a;\n" 6752 "b;\n" 6753 "}\n" 6754 "}", 6755 9, 2, getLLVMStyle())); 6756 EXPECT_EQ("{\n" 6757 "{\n" 6758 "public:\n" 6759 " b;\n" 6760 "}\n" 6761 "}", 6762 format("{\n" 6763 "{\n" 6764 "public:\n" 6765 " b;\n" 6766 "}\n" 6767 "}", 6768 17, 2, getLLVMStyle())); 6769 EXPECT_EQ("{\n" 6770 "{\n" 6771 "a;\n" 6772 "}\n" 6773 "{\n" 6774 " b; //\n" 6775 "}\n" 6776 "}", 6777 format("{\n" 6778 "{\n" 6779 "a;\n" 6780 "}\n" 6781 "{\n" 6782 " b; //\n" 6783 "}\n" 6784 "}", 6785 22, 2, getLLVMStyle())); 6786 EXPECT_EQ(" {\n" 6787 " a; //\n" 6788 " }", 6789 format(" {\n" 6790 "a; //\n" 6791 " }", 6792 4, 2, getLLVMStyle())); 6793 EXPECT_EQ("void f() {}\n" 6794 "void g() {}", 6795 format("void f() {}\n" 6796 "void g() {}", 6797 13, 0, getLLVMStyle())); 6798 EXPECT_EQ("int a; // comment\n" 6799 " // line 2\n" 6800 "int b;", 6801 format("int a; // comment\n" 6802 " // line 2\n" 6803 " int b;", 6804 35, 0, getLLVMStyle())); 6805 EXPECT_EQ(" int a;\n" 6806 " void\n" 6807 " ffffff() {\n" 6808 " }", 6809 format(" int a;\n" 6810 "void ffffff() {}", 6811 11, 0, getLLVMStyleWithColumns(11))); 6812 6813 EXPECT_EQ(" void f() {\n" 6814 "#define A 1\n" 6815 " }", 6816 format(" void f() {\n" 6817 " #define A 1\n" // Format this line. 6818 " }", 6819 20, 0, getLLVMStyle())); 6820 EXPECT_EQ(" void f() {\n" 6821 " int i;\n" 6822 "#define A \\\n" 6823 " int i; \\\n" 6824 " int j;\n" 6825 " int k;\n" 6826 " }", 6827 format(" void f() {\n" 6828 " int i;\n" 6829 "#define A \\\n" 6830 " int i; \\\n" 6831 " int j;\n" 6832 " int k;\n" // Format this line. 6833 " }", 6834 67, 0, getLLVMStyle())); 6835 } 6836 6837 TEST_F(FormatTest, BreaksStringLiterals) { 6838 EXPECT_EQ("\"some text \"\n" 6839 "\"other\";", 6840 format("\"some text other\";", getLLVMStyleWithColumns(12))); 6841 EXPECT_EQ("\"some text \"\n" 6842 "\"other\";", 6843 format("\\\n\"some text other\";", getLLVMStyleWithColumns(12))); 6844 EXPECT_EQ( 6845 "#define A \\\n" 6846 " \"some \" \\\n" 6847 " \"text \" \\\n" 6848 " \"other\";", 6849 format("#define A \"some text other\";", getLLVMStyleWithColumns(12))); 6850 EXPECT_EQ( 6851 "#define A \\\n" 6852 " \"so \" \\\n" 6853 " \"text \" \\\n" 6854 " \"other\";", 6855 format("#define A \"so text other\";", getLLVMStyleWithColumns(12))); 6856 6857 EXPECT_EQ("\"some text\"", 6858 format("\"some text\"", getLLVMStyleWithColumns(1))); 6859 EXPECT_EQ("\"some text\"", 6860 format("\"some text\"", getLLVMStyleWithColumns(11))); 6861 EXPECT_EQ("\"some \"\n" 6862 "\"text\"", 6863 format("\"some text\"", getLLVMStyleWithColumns(10))); 6864 EXPECT_EQ("\"some \"\n" 6865 "\"text\"", 6866 format("\"some text\"", getLLVMStyleWithColumns(7))); 6867 EXPECT_EQ("\"some\"\n" 6868 "\" tex\"\n" 6869 "\"t\"", 6870 format("\"some text\"", getLLVMStyleWithColumns(6))); 6871 EXPECT_EQ("\"some\"\n" 6872 "\" tex\"\n" 6873 "\" and\"", 6874 format("\"some tex and\"", getLLVMStyleWithColumns(6))); 6875 EXPECT_EQ("\"some\"\n" 6876 "\"/tex\"\n" 6877 "\"/and\"", 6878 format("\"some/tex/and\"", getLLVMStyleWithColumns(6))); 6879 6880 EXPECT_EQ("variable =\n" 6881 " \"long string \"\n" 6882 " \"literal\";", 6883 format("variable = \"long string literal\";", 6884 getLLVMStyleWithColumns(20))); 6885 6886 EXPECT_EQ("variable = f(\n" 6887 " \"long string \"\n" 6888 " \"literal\",\n" 6889 " short,\n" 6890 " loooooooooooooooooooong);", 6891 format("variable = f(\"long string literal\", short, " 6892 "loooooooooooooooooooong);", 6893 getLLVMStyleWithColumns(20))); 6894 6895 EXPECT_EQ("f(g(\"long string \"\n" 6896 " \"literal\"),\n" 6897 " b);", 6898 format("f(g(\"long string literal\"), b);", 6899 getLLVMStyleWithColumns(20))); 6900 EXPECT_EQ("f(g(\"long string \"\n" 6901 " \"literal\",\n" 6902 " a),\n" 6903 " b);", 6904 format("f(g(\"long string literal\", a), b);", 6905 getLLVMStyleWithColumns(20))); 6906 EXPECT_EQ( 6907 "f(\"one two\".split(\n" 6908 " variable));", 6909 format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20))); 6910 EXPECT_EQ("f(\"one two three four five six \"\n" 6911 " \"seven\".split(\n" 6912 " really_looooong_variable));", 6913 format("f(\"one two three four five six seven\"." 6914 "split(really_looooong_variable));", 6915 getLLVMStyleWithColumns(33))); 6916 6917 EXPECT_EQ("f(\"some \"\n" 6918 " \"text\",\n" 6919 " other);", 6920 format("f(\"some text\", other);", getLLVMStyleWithColumns(10))); 6921 6922 // Only break as a last resort. 6923 verifyFormat( 6924 "aaaaaaaaaaaaaaaaaaaa(\n" 6925 " aaaaaaaaaaaaaaaaaaaa,\n" 6926 " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));"); 6927 6928 EXPECT_EQ( 6929 "\"splitmea\"\n" 6930 "\"trandomp\"\n" 6931 "\"oint\"", 6932 format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10))); 6933 6934 EXPECT_EQ( 6935 "\"split/\"\n" 6936 "\"pathat/\"\n" 6937 "\"slashes\"", 6938 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 6939 6940 EXPECT_EQ( 6941 "\"split/\"\n" 6942 "\"pathat/\"\n" 6943 "\"slashes\"", 6944 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 6945 EXPECT_EQ("\"split at \"\n" 6946 "\"spaces/at/\"\n" 6947 "\"slashes.at.any$\"\n" 6948 "\"non-alphanumeric%\"\n" 6949 "\"1111111111characte\"\n" 6950 "\"rs\"", 6951 format("\"split at " 6952 "spaces/at/" 6953 "slashes.at." 6954 "any$non-" 6955 "alphanumeric%" 6956 "1111111111characte" 6957 "rs\"", 6958 getLLVMStyleWithColumns(20))); 6959 6960 // Verify that splitting the strings understands 6961 // Style::AlwaysBreakBeforeMultilineStrings. 6962 EXPECT_EQ("aaaaaaaaaaaa(aaaaaaaaaaaaa,\n" 6963 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa \"\n" 6964 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\");", 6965 format("aaaaaaaaaaaa(aaaaaaaaaaaaa, \"aaaaaaaaaaaaaaaaaaaaaa " 6966 "aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa " 6967 "aaaaaaaaaaaaaaaaaaaaaa\");", 6968 getGoogleStyle())); 6969 EXPECT_EQ("return \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 6970 " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\";", 6971 format("return \"aaaaaaaaaaaaaaaaaaaaaa " 6972 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa " 6973 "aaaaaaaaaaaaaaaaaaaaaa\";", 6974 getGoogleStyle())); 6975 EXPECT_EQ("llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 6976 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 6977 format("llvm::outs() << " 6978 "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa" 6979 "aaaaaaaaaaaaaaaaaaa\";")); 6980 EXPECT_EQ("ffff(\n" 6981 " {\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 6982 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 6983 format("ffff({\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa " 6984 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 6985 getGoogleStyle())); 6986 6987 FormatStyle AlignLeft = getLLVMStyleWithColumns(12); 6988 AlignLeft.AlignEscapedNewlinesLeft = true; 6989 EXPECT_EQ( 6990 "#define A \\\n" 6991 " \"some \" \\\n" 6992 " \"text \" \\\n" 6993 " \"other\";", 6994 format("#define A \"some text other\";", AlignLeft)); 6995 } 6996 6997 TEST_F(FormatTest, BreaksStringLiteralsWithTabs) { 6998 EXPECT_EQ( 6999 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 7000 "(\n" 7001 " \"x\t\");", 7002 format("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 7003 "aaaaaaa(" 7004 "\"x\t\");")); 7005 } 7006 7007 TEST_F(FormatTest, BreaksWideAndNSStringLiterals) { 7008 EXPECT_EQ( 7009 "u8\"utf8 string \"\n" 7010 "u8\"literal\";", 7011 format("u8\"utf8 string literal\";", getGoogleStyleWithColumns(16))); 7012 EXPECT_EQ( 7013 "u\"utf16 string \"\n" 7014 "u\"literal\";", 7015 format("u\"utf16 string literal\";", getGoogleStyleWithColumns(16))); 7016 EXPECT_EQ( 7017 "U\"utf32 string \"\n" 7018 "U\"literal\";", 7019 format("U\"utf32 string literal\";", getGoogleStyleWithColumns(16))); 7020 EXPECT_EQ("L\"wide string \"\n" 7021 "L\"literal\";", 7022 format("L\"wide string literal\";", getGoogleStyleWithColumns(16))); 7023 EXPECT_EQ("@\"NSString \"\n" 7024 "@\"literal\";", 7025 format("@\"NSString literal\";", getGoogleStyleWithColumns(19))); 7026 } 7027 7028 TEST_F(FormatTest, BreaksRawStringLiterals) { 7029 EXPECT_EQ("R\"x(raw )x\"\n" 7030 "R\"x(literal)x\";", 7031 format("R\"x(raw literal)x\";", getGoogleStyleWithColumns(15))); 7032 EXPECT_EQ("uR\"x(raw )x\"\n" 7033 "uR\"x(literal)x\";", 7034 format("uR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 7035 EXPECT_EQ("u8R\"x(raw )x\"\n" 7036 "u8R\"x(literal)x\";", 7037 format("u8R\"x(raw literal)x\";", getGoogleStyleWithColumns(17))); 7038 EXPECT_EQ("LR\"x(raw )x\"\n" 7039 "LR\"x(literal)x\";", 7040 format("LR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 7041 EXPECT_EQ("UR\"x(raw )x\"\n" 7042 "UR\"x(literal)x\";", 7043 format("UR\"x(raw literal)x\";", getGoogleStyleWithColumns(16))); 7044 } 7045 7046 TEST_F(FormatTest, BreaksStringLiteralsWithin_TMacro) { 7047 FormatStyle Style = getLLVMStyleWithColumns(20); 7048 EXPECT_EQ( 7049 "_T(\"aaaaaaaaaaaaaa\")\n" 7050 "_T(\"aaaaaaaaaaaaaa\")\n" 7051 "_T(\"aaaaaaaaaaaa\")", 7052 format(" _T(\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")", Style)); 7053 EXPECT_EQ("f(x, _T(\"aaaaaaaaa\")\n" 7054 " _T(\"aaaaaa\"),\n" 7055 " z);", 7056 format("f(x, _T(\"aaaaaaaaaaaaaaa\"), z);", Style)); 7057 7058 // FIXME: Handle embedded spaces in one iteration. 7059 // EXPECT_EQ("_T(\"aaaaaaaaaaaaa\")\n" 7060 // "_T(\"aaaaaaaaaaaaa\")\n" 7061 // "_T(\"aaaaaaaaaaaaa\")\n" 7062 // "_T(\"a\")", 7063 // format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 7064 // getLLVMStyleWithColumns(20))); 7065 EXPECT_EQ( 7066 "_T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 7067 format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", Style)); 7068 } 7069 7070 TEST_F(FormatTest, DontSplitStringLiteralsWithEscapedNewlines) { 7071 EXPECT_EQ( 7072 "aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7073 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7074 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 7075 format("aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7076 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7077 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";")); 7078 } 7079 7080 TEST_F(FormatTest, CountsCharactersInMultilineRawStringLiterals) { 7081 EXPECT_EQ("f(g(R\"x(raw literal)x\", a), b);", 7082 format("f(g(R\"x(raw literal)x\", a), b);", getGoogleStyle())); 7083 EXPECT_EQ("fffffffffff(g(R\"x(\n" 7084 "multiline raw string literal xxxxxxxxxxxxxx\n" 7085 ")x\",\n" 7086 " a),\n" 7087 " b);", 7088 format("fffffffffff(g(R\"x(\n" 7089 "multiline raw string literal xxxxxxxxxxxxxx\n" 7090 ")x\", a), b);", 7091 getGoogleStyleWithColumns(20))); 7092 EXPECT_EQ("fffffffffff(\n" 7093 " g(R\"x(qqq\n" 7094 "multiline raw string literal xxxxxxxxxxxxxx\n" 7095 ")x\",\n" 7096 " a),\n" 7097 " b);", 7098 format("fffffffffff(g(R\"x(qqq\n" 7099 "multiline raw string literal xxxxxxxxxxxxxx\n" 7100 ")x\", a), b);", 7101 getGoogleStyleWithColumns(20))); 7102 7103 EXPECT_EQ("fffffffffff(R\"x(\n" 7104 "multiline raw string literal xxxxxxxxxxxxxx\n" 7105 ")x\");", 7106 format("fffffffffff(R\"x(\n" 7107 "multiline raw string literal xxxxxxxxxxxxxx\n" 7108 ")x\");", 7109 getGoogleStyleWithColumns(20))); 7110 EXPECT_EQ("fffffffffff(R\"x(\n" 7111 "multiline raw string literal xxxxxxxxxxxxxx\n" 7112 ")x\" + bbbbbb);", 7113 format("fffffffffff(R\"x(\n" 7114 "multiline raw string literal xxxxxxxxxxxxxx\n" 7115 ")x\" + bbbbbb);", 7116 getGoogleStyleWithColumns(20))); 7117 EXPECT_EQ("fffffffffff(\n" 7118 " R\"x(\n" 7119 "multiline raw string literal xxxxxxxxxxxxxx\n" 7120 ")x\" +\n" 7121 " bbbbbb);", 7122 format("fffffffffff(\n" 7123 " R\"x(\n" 7124 "multiline raw string literal xxxxxxxxxxxxxx\n" 7125 ")x\" + bbbbbb);", 7126 getGoogleStyleWithColumns(20))); 7127 } 7128 7129 TEST_F(FormatTest, SkipsUnknownStringLiterals) { 7130 verifyFormat("string a = \"unterminated;"); 7131 EXPECT_EQ("function(\"unterminated,\n" 7132 " OtherParameter);", 7133 format("function( \"unterminated,\n" 7134 " OtherParameter);")); 7135 } 7136 7137 TEST_F(FormatTest, DoesNotTryToParseUDLiteralsInPreCpp11Code) { 7138 FormatStyle Style = getLLVMStyle(); 7139 Style.Standard = FormatStyle::LS_Cpp03; 7140 EXPECT_EQ("#define x(_a) printf(\"foo\" _a);", 7141 format("#define x(_a) printf(\"foo\"_a);", Style)); 7142 } 7143 7144 TEST_F(FormatTest, UnderstandsCpp1y) { 7145 verifyFormat("int bi{1'000'000};"); 7146 } 7147 7148 TEST_F(FormatTest, BreakStringLiteralsBeforeUnbreakableTokenSequence) { 7149 EXPECT_EQ("someFunction(\"aaabbbcccd\"\n" 7150 " \"ddeeefff\");", 7151 format("someFunction(\"aaabbbcccdddeeefff\");", 7152 getLLVMStyleWithColumns(25))); 7153 EXPECT_EQ("someFunction1234567890(\n" 7154 " \"aaabbbcccdddeeefff\");", 7155 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7156 getLLVMStyleWithColumns(26))); 7157 EXPECT_EQ("someFunction1234567890(\n" 7158 " \"aaabbbcccdddeeeff\"\n" 7159 " \"f\");", 7160 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7161 getLLVMStyleWithColumns(25))); 7162 EXPECT_EQ("someFunction1234567890(\n" 7163 " \"aaabbbcccdddeeeff\"\n" 7164 " \"f\");", 7165 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7166 getLLVMStyleWithColumns(24))); 7167 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 7168 " \"ddde \"\n" 7169 " \"efff\");", 7170 format("someFunction(\"aaabbbcc ddde efff\");", 7171 getLLVMStyleWithColumns(25))); 7172 EXPECT_EQ("someFunction(\"aaabbbccc \"\n" 7173 " \"ddeeefff\");", 7174 format("someFunction(\"aaabbbccc ddeeefff\");", 7175 getLLVMStyleWithColumns(25))); 7176 EXPECT_EQ("someFunction1234567890(\n" 7177 " \"aaabb \"\n" 7178 " \"cccdddeeefff\");", 7179 format("someFunction1234567890(\"aaabb cccdddeeefff\");", 7180 getLLVMStyleWithColumns(25))); 7181 EXPECT_EQ("#define A \\\n" 7182 " string s = \\\n" 7183 " \"123456789\" \\\n" 7184 " \"0\"; \\\n" 7185 " int i;", 7186 format("#define A string s = \"1234567890\"; int i;", 7187 getLLVMStyleWithColumns(20))); 7188 // FIXME: Put additional penalties on breaking at non-whitespace locations. 7189 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 7190 " \"dddeeeff\"\n" 7191 " \"f\");", 7192 format("someFunction(\"aaabbbcc dddeeefff\");", 7193 getLLVMStyleWithColumns(25))); 7194 } 7195 7196 TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) { 7197 EXPECT_EQ("\"\\a\"", 7198 format("\"\\a\"", getLLVMStyleWithColumns(3))); 7199 EXPECT_EQ("\"\\\"", 7200 format("\"\\\"", getLLVMStyleWithColumns(2))); 7201 EXPECT_EQ("\"test\"\n" 7202 "\"\\n\"", 7203 format("\"test\\n\"", getLLVMStyleWithColumns(7))); 7204 EXPECT_EQ("\"tes\\\\\"\n" 7205 "\"n\"", 7206 format("\"tes\\\\n\"", getLLVMStyleWithColumns(7))); 7207 EXPECT_EQ("\"\\\\\\\\\"\n" 7208 "\"\\n\"", 7209 format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7))); 7210 EXPECT_EQ("\"\\uff01\"", 7211 format("\"\\uff01\"", getLLVMStyleWithColumns(7))); 7212 EXPECT_EQ("\"\\uff01\"\n" 7213 "\"test\"", 7214 format("\"\\uff01test\"", getLLVMStyleWithColumns(8))); 7215 EXPECT_EQ("\"\\Uff01ff02\"", 7216 format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11))); 7217 EXPECT_EQ("\"\\x000000000001\"\n" 7218 "\"next\"", 7219 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16))); 7220 EXPECT_EQ("\"\\x000000000001next\"", 7221 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15))); 7222 EXPECT_EQ("\"\\x000000000001\"", 7223 format("\"\\x000000000001\"", getLLVMStyleWithColumns(7))); 7224 EXPECT_EQ("\"test\"\n" 7225 "\"\\000000\"\n" 7226 "\"000001\"", 7227 format("\"test\\000000000001\"", getLLVMStyleWithColumns(9))); 7228 EXPECT_EQ("\"test\\000\"\n" 7229 "\"00000000\"\n" 7230 "\"1\"", 7231 format("\"test\\000000000001\"", getLLVMStyleWithColumns(10))); 7232 // FIXME: We probably don't need to care about escape sequences in raw 7233 // literals. 7234 EXPECT_EQ("R\"(\\x)\"\n" 7235 "R\"(\\x00)\"\n", 7236 format("R\"(\\x\\x00)\"\n", getGoogleStyleWithColumns(7))); 7237 } 7238 7239 TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) { 7240 verifyFormat("void f() {\n" 7241 " return g() {}\n" 7242 " void h() {}"); 7243 verifyFormat("int a[] = {void forgot_closing_brace(){f();\n" 7244 "g();\n" 7245 "}"); 7246 } 7247 7248 TEST_F(FormatTest, DoNotPrematurelyEndUnwrappedLineForReturnStatements) { 7249 verifyFormat( 7250 "void f() { return C{param1, param2}.SomeCall(param1, param2); }"); 7251 } 7252 7253 TEST_F(FormatTest, FormatsClosingBracesInEmptyNestedBlocks) { 7254 verifyFormat("class X {\n" 7255 " void f() {\n" 7256 " }\n" 7257 "};", 7258 getLLVMStyleWithColumns(12)); 7259 } 7260 7261 TEST_F(FormatTest, ConfigurableIndentWidth) { 7262 FormatStyle EightIndent = getLLVMStyleWithColumns(18); 7263 EightIndent.IndentWidth = 8; 7264 EightIndent.ContinuationIndentWidth = 8; 7265 verifyFormat("void f() {\n" 7266 " someFunction();\n" 7267 " if (true) {\n" 7268 " f();\n" 7269 " }\n" 7270 "}", 7271 EightIndent); 7272 verifyFormat("class X {\n" 7273 " void f() {\n" 7274 " }\n" 7275 "};", 7276 EightIndent); 7277 verifyFormat("int x[] = {\n" 7278 " call(),\n" 7279 " call()};", 7280 EightIndent); 7281 } 7282 7283 TEST_F(FormatTest, ConfigurableFunctionDeclarationIndentAfterType) { 7284 verifyFormat("void\n" 7285 "f();", 7286 getLLVMStyleWithColumns(8)); 7287 } 7288 7289 TEST_F(FormatTest, ConfigurableUseOfTab) { 7290 FormatStyle Tab = getLLVMStyleWithColumns(42); 7291 Tab.IndentWidth = 8; 7292 Tab.UseTab = FormatStyle::UT_Always; 7293 Tab.AlignEscapedNewlinesLeft = true; 7294 7295 EXPECT_EQ("if (aaaaaaaa && // q\n" 7296 " bb)\t\t// w\n" 7297 "\t;", 7298 format("if (aaaaaaaa &&// q\n" 7299 "bb)// w\n" 7300 ";", 7301 Tab)); 7302 EXPECT_EQ("if (aaa && bbb) // w\n" 7303 "\t;", 7304 format("if(aaa&&bbb)// w\n" 7305 ";", 7306 Tab)); 7307 7308 verifyFormat("class X {\n" 7309 "\tvoid f() {\n" 7310 "\t\tsomeFunction(parameter1,\n" 7311 "\t\t\t parameter2);\n" 7312 "\t}\n" 7313 "};", 7314 Tab); 7315 verifyFormat("#define A \\\n" 7316 "\tvoid f() { \\\n" 7317 "\t\tsomeFunction( \\\n" 7318 "\t\t parameter1, \\\n" 7319 "\t\t parameter2); \\\n" 7320 "\t}", 7321 Tab); 7322 EXPECT_EQ("void f() {\n" 7323 "\tf();\n" 7324 "\tg();\n" 7325 "}", 7326 format("void f() {\n" 7327 "\tf();\n" 7328 "\tg();\n" 7329 "}", 7330 0, 0, Tab)); 7331 EXPECT_EQ("void f() {\n" 7332 "\tf();\n" 7333 "\tg();\n" 7334 "}", 7335 format("void f() {\n" 7336 "\tf();\n" 7337 "\tg();\n" 7338 "}", 7339 16, 0, Tab)); 7340 EXPECT_EQ("void f() {\n" 7341 " \tf();\n" 7342 "\tg();\n" 7343 "}", 7344 format("void f() {\n" 7345 " \tf();\n" 7346 " \tg();\n" 7347 "}", 7348 21, 0, Tab)); 7349 7350 Tab.TabWidth = 4; 7351 Tab.IndentWidth = 8; 7352 verifyFormat("class TabWidth4Indent8 {\n" 7353 "\t\tvoid f() {\n" 7354 "\t\t\t\tsomeFunction(parameter1,\n" 7355 "\t\t\t\t\t\t\t parameter2);\n" 7356 "\t\t}\n" 7357 "};", 7358 Tab); 7359 7360 Tab.TabWidth = 4; 7361 Tab.IndentWidth = 4; 7362 verifyFormat("class TabWidth4Indent4 {\n" 7363 "\tvoid f() {\n" 7364 "\t\tsomeFunction(parameter1,\n" 7365 "\t\t\t\t\t parameter2);\n" 7366 "\t}\n" 7367 "};", 7368 Tab); 7369 7370 Tab.TabWidth = 8; 7371 Tab.IndentWidth = 4; 7372 verifyFormat("class TabWidth8Indent4 {\n" 7373 " void f() {\n" 7374 "\tsomeFunction(parameter1,\n" 7375 "\t\t parameter2);\n" 7376 " }\n" 7377 "};", 7378 Tab); 7379 7380 Tab.TabWidth = 8; 7381 Tab.IndentWidth = 8; 7382 EXPECT_EQ("/*\n" 7383 "\t a\t\tcomment\n" 7384 "\t in multiple lines\n" 7385 " */", 7386 format(" /*\t \t \n" 7387 " \t \t a\t\tcomment\t \t\n" 7388 " \t \t in multiple lines\t\n" 7389 " \t */", 7390 Tab)); 7391 7392 Tab.UseTab = FormatStyle::UT_ForIndentation; 7393 verifyFormat("{\n" 7394 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7395 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7396 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7397 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7398 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7399 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7400 "};", 7401 Tab); 7402 verifyFormat("enum A {\n" 7403 "\ta1, // Force multiple lines\n" 7404 "\ta2,\n" 7405 "\ta3\n" 7406 "};", 7407 Tab); 7408 EXPECT_EQ("if (aaaaaaaa && // q\n" 7409 " bb) // w\n" 7410 "\t;", 7411 format("if (aaaaaaaa &&// q\n" 7412 "bb)// w\n" 7413 ";", 7414 Tab)); 7415 verifyFormat("class X {\n" 7416 "\tvoid f() {\n" 7417 "\t\tsomeFunction(parameter1,\n" 7418 "\t\t parameter2);\n" 7419 "\t}\n" 7420 "};", 7421 Tab); 7422 verifyFormat("{\n" 7423 "\tQ({\n" 7424 "\t\t int a;\n" 7425 "\t\t someFunction(aaaaaaaaaa,\n" 7426 "\t\t bbbbbbbbb);\n" 7427 "\t },\n" 7428 "\t p);\n" 7429 "}", 7430 Tab); 7431 EXPECT_EQ("{\n" 7432 "\t/* aaaa\n" 7433 "\t bbbb */\n" 7434 "}", 7435 format("{\n" 7436 "/* aaaa\n" 7437 " bbbb */\n" 7438 "}", 7439 Tab)); 7440 EXPECT_EQ("{\n" 7441 "\t/*\n" 7442 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7443 "\t bbbbbbbbbbbbb\n" 7444 "\t*/\n" 7445 "}", 7446 format("{\n" 7447 "/*\n" 7448 " aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7449 "*/\n" 7450 "}", 7451 Tab)); 7452 EXPECT_EQ("{\n" 7453 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7454 "\t// bbbbbbbbbbbbb\n" 7455 "}", 7456 format("{\n" 7457 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7458 "}", 7459 Tab)); 7460 EXPECT_EQ("{\n" 7461 "\t/*\n" 7462 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7463 "\t bbbbbbbbbbbbb\n" 7464 "\t*/\n" 7465 "}", 7466 format("{\n" 7467 "\t/*\n" 7468 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7469 "\t*/\n" 7470 "}", 7471 Tab)); 7472 EXPECT_EQ("{\n" 7473 "\t/*\n" 7474 "\n" 7475 "\t*/\n" 7476 "}", 7477 format("{\n" 7478 "\t/*\n" 7479 "\n" 7480 "\t*/\n" 7481 "}", 7482 Tab)); 7483 EXPECT_EQ("{\n" 7484 "\t/*\n" 7485 " asdf\n" 7486 "\t*/\n" 7487 "}", 7488 format("{\n" 7489 "\t/*\n" 7490 " asdf\n" 7491 "\t*/\n" 7492 "}", 7493 Tab)); 7494 7495 Tab.UseTab = FormatStyle::UT_Never; 7496 EXPECT_EQ("/*\n" 7497 " a\t\tcomment\n" 7498 " in multiple lines\n" 7499 " */", 7500 format(" /*\t \t \n" 7501 " \t \t a\t\tcomment\t \t\n" 7502 " \t \t in multiple lines\t\n" 7503 " \t */", 7504 Tab)); 7505 EXPECT_EQ("/* some\n" 7506 " comment */", 7507 format(" \t \t /* some\n" 7508 " \t \t comment */", 7509 Tab)); 7510 EXPECT_EQ("int a; /* some\n" 7511 " comment */", 7512 format(" \t \t int a; /* some\n" 7513 " \t \t comment */", 7514 Tab)); 7515 7516 EXPECT_EQ("int a; /* some\n" 7517 "comment */", 7518 format(" \t \t int\ta; /* some\n" 7519 " \t \t comment */", 7520 Tab)); 7521 EXPECT_EQ("f(\"\t\t\"); /* some\n" 7522 " comment */", 7523 format(" \t \t f(\"\t\t\"); /* some\n" 7524 " \t \t comment */", 7525 Tab)); 7526 EXPECT_EQ("{\n" 7527 " /*\n" 7528 " * Comment\n" 7529 " */\n" 7530 " int i;\n" 7531 "}", 7532 format("{\n" 7533 "\t/*\n" 7534 "\t * Comment\n" 7535 "\t */\n" 7536 "\t int i;\n" 7537 "}")); 7538 } 7539 7540 TEST_F(FormatTest, CalculatesOriginalColumn) { 7541 EXPECT_EQ("\"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7542 "q\"; /* some\n" 7543 " comment */", 7544 format(" \"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7545 "q\"; /* some\n" 7546 " comment */", 7547 getLLVMStyle())); 7548 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 7549 "/* some\n" 7550 " comment */", 7551 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 7552 " /* some\n" 7553 " comment */", 7554 getLLVMStyle())); 7555 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7556 "qqq\n" 7557 "/* some\n" 7558 " comment */", 7559 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7560 "qqq\n" 7561 " /* some\n" 7562 " comment */", 7563 getLLVMStyle())); 7564 EXPECT_EQ("inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7565 "wwww; /* some\n" 7566 " comment */", 7567 format(" inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 7568 "wwww; /* some\n" 7569 " comment */", 7570 getLLVMStyle())); 7571 } 7572 7573 TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { 7574 FormatStyle NoSpace = getLLVMStyle(); 7575 NoSpace.SpaceBeforeParens = FormatStyle::SBPO_Never; 7576 7577 verifyFormat("while(true)\n" 7578 " continue;", NoSpace); 7579 verifyFormat("for(;;)\n" 7580 " continue;", NoSpace); 7581 verifyFormat("if(true)\n" 7582 " f();\n" 7583 "else if(true)\n" 7584 " f();", NoSpace); 7585 verifyFormat("do {\n" 7586 " do_something();\n" 7587 "} while(something());", NoSpace); 7588 verifyFormat("switch(x) {\n" 7589 "default:\n" 7590 " break;\n" 7591 "}", NoSpace); 7592 verifyFormat("auto i = std::make_unique<int>(5);", NoSpace); 7593 verifyFormat("size_t x = sizeof(x);", NoSpace); 7594 verifyFormat("auto f(int x) -> decltype(x);", NoSpace); 7595 verifyFormat("int f(T x) noexcept(x.create());", NoSpace); 7596 verifyFormat("alignas(128) char a[128];", NoSpace); 7597 verifyFormat("size_t x = alignof(MyType);", NoSpace); 7598 verifyFormat("static_assert(sizeof(char) == 1, \"Impossible!\");", NoSpace); 7599 verifyFormat("int f() throw(Deprecated);", NoSpace); 7600 7601 FormatStyle Space = getLLVMStyle(); 7602 Space.SpaceBeforeParens = FormatStyle::SBPO_Always; 7603 7604 verifyFormat("int f ();", Space); 7605 verifyFormat("void f (int a, T b) {\n" 7606 " while (true)\n" 7607 " continue;\n" 7608 "}", 7609 Space); 7610 verifyFormat("if (true)\n" 7611 " f ();\n" 7612 "else if (true)\n" 7613 " f ();", 7614 Space); 7615 verifyFormat("do {\n" 7616 " do_something ();\n" 7617 "} while (something ());", 7618 Space); 7619 verifyFormat("switch (x) {\n" 7620 "default:\n" 7621 " break;\n" 7622 "}", 7623 Space); 7624 verifyFormat("A::A () : a (1) {}", Space); 7625 verifyFormat("void f () __attribute__ ((asdf));", Space); 7626 verifyFormat("*(&a + 1);\n" 7627 "&((&a)[1]);\n" 7628 "a[(b + c) * d];\n" 7629 "(((a + 1) * 2) + 3) * 4;", 7630 Space); 7631 verifyFormat("#define A(x) x", Space); 7632 verifyFormat("#define A (x) x", Space); 7633 verifyFormat("#if defined(x)\n" 7634 "#endif", 7635 Space); 7636 verifyFormat("auto i = std::make_unique<int> (5);", Space); 7637 verifyFormat("size_t x = sizeof (x);", Space); 7638 verifyFormat("auto f (int x) -> decltype (x);", Space); 7639 verifyFormat("int f (T x) noexcept (x.create ());", Space); 7640 verifyFormat("alignas (128) char a[128];", Space); 7641 verifyFormat("size_t x = alignof (MyType);", Space); 7642 verifyFormat("static_assert (sizeof (char) == 1, \"Impossible!\");", Space); 7643 verifyFormat("int f () throw (Deprecated);", Space); 7644 } 7645 7646 TEST_F(FormatTest, ConfigurableSpacesInParentheses) { 7647 FormatStyle Spaces = getLLVMStyle(); 7648 7649 Spaces.SpacesInParentheses = true; 7650 verifyFormat("call( x, y, z );", Spaces); 7651 verifyFormat("while ( (bool)1 )\n" 7652 " continue;", Spaces); 7653 verifyFormat("for ( ;; )\n" 7654 " continue;", Spaces); 7655 verifyFormat("if ( true )\n" 7656 " f();\n" 7657 "else if ( true )\n" 7658 " f();", Spaces); 7659 verifyFormat("do {\n" 7660 " do_something( (int)i );\n" 7661 "} while ( something() );", Spaces); 7662 verifyFormat("switch ( x ) {\n" 7663 "default:\n" 7664 " break;\n" 7665 "}", Spaces); 7666 7667 Spaces.SpacesInParentheses = false; 7668 Spaces.SpacesInCStyleCastParentheses = true; 7669 verifyFormat("Type *A = ( Type * )P;", Spaces); 7670 verifyFormat("Type *A = ( vector<Type *, int *> )P;", Spaces); 7671 verifyFormat("x = ( int32 )y;", Spaces); 7672 verifyFormat("int a = ( int )(2.0f);", Spaces); 7673 verifyFormat("#define AA(X) sizeof((( X * )NULL)->a)", Spaces); 7674 verifyFormat("my_int a = ( my_int )sizeof(int);", Spaces); 7675 verifyFormat("#define x (( int )-1)", Spaces); 7676 7677 Spaces.SpacesInParentheses = false; 7678 Spaces.SpaceInEmptyParentheses = true; 7679 verifyFormat("call(x, y, z);", Spaces); 7680 verifyFormat("call( )", Spaces); 7681 7682 // Run the first set of tests again with 7683 // Spaces.SpacesInParentheses = false, 7684 // Spaces.SpaceInEmptyParentheses = true and 7685 // Spaces.SpacesInCStyleCastParentheses = true 7686 Spaces.SpacesInParentheses = false, 7687 Spaces.SpaceInEmptyParentheses = true; 7688 Spaces.SpacesInCStyleCastParentheses = true; 7689 verifyFormat("call(x, y, z);", Spaces); 7690 verifyFormat("while (( bool )1)\n" 7691 " continue;", Spaces); 7692 verifyFormat("for (;;)\n" 7693 " continue;", Spaces); 7694 verifyFormat("if (true)\n" 7695 " f( );\n" 7696 "else if (true)\n" 7697 " f( );", Spaces); 7698 verifyFormat("do {\n" 7699 " do_something(( int )i);\n" 7700 "} while (something( ));", Spaces); 7701 verifyFormat("switch (x) {\n" 7702 "default:\n" 7703 " break;\n" 7704 "}", Spaces); 7705 } 7706 7707 TEST_F(FormatTest, ConfigurableSpaceBeforeAssignmentOperators) { 7708 verifyFormat("int a = 5;"); 7709 verifyFormat("a += 42;"); 7710 verifyFormat("a or_eq 8;"); 7711 7712 FormatStyle Spaces = getLLVMStyle(); 7713 Spaces.SpaceBeforeAssignmentOperators = false; 7714 verifyFormat("int a= 5;", Spaces); 7715 verifyFormat("a+= 42;", Spaces); 7716 verifyFormat("a or_eq 8;", Spaces); 7717 } 7718 7719 TEST_F(FormatTest, LinuxBraceBreaking) { 7720 FormatStyle LinuxBraceStyle = getLLVMStyle(); 7721 LinuxBraceStyle.BreakBeforeBraces = FormatStyle::BS_Linux; 7722 verifyFormat("namespace a\n" 7723 "{\n" 7724 "class A\n" 7725 "{\n" 7726 " void f()\n" 7727 " {\n" 7728 " if (true) {\n" 7729 " a();\n" 7730 " b();\n" 7731 " }\n" 7732 " }\n" 7733 " void g() { return; }\n" 7734 "};\n" 7735 "struct B {\n" 7736 " int x;\n" 7737 "};\n" 7738 "}\n", 7739 LinuxBraceStyle); 7740 verifyFormat("enum X {\n" 7741 " Y = 0,\n" 7742 "}\n", 7743 LinuxBraceStyle); 7744 verifyFormat("struct S {\n" 7745 " int Type;\n" 7746 " union {\n" 7747 " int x;\n" 7748 " double y;\n" 7749 " } Value;\n" 7750 " class C\n" 7751 " {\n" 7752 " MyFavoriteType Value;\n" 7753 " } Class;\n" 7754 "}\n", 7755 LinuxBraceStyle); 7756 } 7757 7758 TEST_F(FormatTest, StroustrupBraceBreaking) { 7759 FormatStyle StroustrupBraceStyle = getLLVMStyle(); 7760 StroustrupBraceStyle.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 7761 verifyFormat("namespace a {\n" 7762 "class A {\n" 7763 " void f()\n" 7764 " {\n" 7765 " if (true) {\n" 7766 " a();\n" 7767 " b();\n" 7768 " }\n" 7769 " }\n" 7770 " void g() { return; }\n" 7771 "};\n" 7772 "struct B {\n" 7773 " int x;\n" 7774 "};\n" 7775 "}\n", 7776 StroustrupBraceStyle); 7777 7778 verifyFormat("void foo()\n" 7779 "{\n" 7780 " if (a) {\n" 7781 " a();\n" 7782 " }\n" 7783 " else {\n" 7784 " b();\n" 7785 " }\n" 7786 "}\n", 7787 StroustrupBraceStyle); 7788 7789 verifyFormat("#ifdef _DEBUG\n" 7790 "int foo(int i = 0)\n" 7791 "#else\n" 7792 "int foo(int i = 5)\n" 7793 "#endif\n" 7794 "{\n" 7795 " return i;\n" 7796 "}", 7797 StroustrupBraceStyle); 7798 7799 verifyFormat("void foo() {}\n" 7800 "void bar()\n" 7801 "#ifdef _DEBUG\n" 7802 "{\n" 7803 " foo();\n" 7804 "}\n" 7805 "#else\n" 7806 "{\n" 7807 "}\n" 7808 "#endif", 7809 StroustrupBraceStyle); 7810 7811 verifyFormat("void foobar() { int i = 5; }\n" 7812 "#ifdef _DEBUG\n" 7813 "void bar() {}\n" 7814 "#else\n" 7815 "void bar() { foobar(); }\n" 7816 "#endif", 7817 StroustrupBraceStyle); 7818 } 7819 7820 TEST_F(FormatTest, AllmanBraceBreaking) { 7821 FormatStyle AllmanBraceStyle = getLLVMStyle(); 7822 AllmanBraceStyle.BreakBeforeBraces = FormatStyle::BS_Allman; 7823 verifyFormat("namespace a\n" 7824 "{\n" 7825 "class A\n" 7826 "{\n" 7827 " void f()\n" 7828 " {\n" 7829 " if (true)\n" 7830 " {\n" 7831 " a();\n" 7832 " b();\n" 7833 " }\n" 7834 " }\n" 7835 " void g() { return; }\n" 7836 "};\n" 7837 "struct B\n" 7838 "{\n" 7839 " int x;\n" 7840 "};\n" 7841 "}", 7842 AllmanBraceStyle); 7843 7844 verifyFormat("void f()\n" 7845 "{\n" 7846 " if (true)\n" 7847 " {\n" 7848 " a();\n" 7849 " }\n" 7850 " else if (false)\n" 7851 " {\n" 7852 " b();\n" 7853 " }\n" 7854 " else\n" 7855 " {\n" 7856 " c();\n" 7857 " }\n" 7858 "}\n", 7859 AllmanBraceStyle); 7860 7861 verifyFormat("void f()\n" 7862 "{\n" 7863 " for (int i = 0; i < 10; ++i)\n" 7864 " {\n" 7865 " a();\n" 7866 " }\n" 7867 " while (false)\n" 7868 " {\n" 7869 " b();\n" 7870 " }\n" 7871 " do\n" 7872 " {\n" 7873 " c();\n" 7874 " } while (false)\n" 7875 "}\n", 7876 AllmanBraceStyle); 7877 7878 verifyFormat("void f(int a)\n" 7879 "{\n" 7880 " switch (a)\n" 7881 " {\n" 7882 " case 0:\n" 7883 " break;\n" 7884 " case 1:\n" 7885 " {\n" 7886 " break;\n" 7887 " }\n" 7888 " case 2:\n" 7889 " {\n" 7890 " }\n" 7891 " break;\n" 7892 " default:\n" 7893 " break;\n" 7894 " }\n" 7895 "}\n", 7896 AllmanBraceStyle); 7897 7898 verifyFormat("enum X\n" 7899 "{\n" 7900 " Y = 0,\n" 7901 "}\n", 7902 AllmanBraceStyle); 7903 verifyFormat("enum X\n" 7904 "{\n" 7905 " Y = 0\n" 7906 "}\n", 7907 AllmanBraceStyle); 7908 7909 verifyFormat("@interface BSApplicationController ()\n" 7910 "{\n" 7911 "@private\n" 7912 " id _extraIvar;\n" 7913 "}\n" 7914 "@end\n", 7915 AllmanBraceStyle); 7916 7917 verifyFormat("#ifdef _DEBUG\n" 7918 "int foo(int i = 0)\n" 7919 "#else\n" 7920 "int foo(int i = 5)\n" 7921 "#endif\n" 7922 "{\n" 7923 " return i;\n" 7924 "}", 7925 AllmanBraceStyle); 7926 7927 verifyFormat("void foo() {}\n" 7928 "void bar()\n" 7929 "#ifdef _DEBUG\n" 7930 "{\n" 7931 " foo();\n" 7932 "}\n" 7933 "#else\n" 7934 "{\n" 7935 "}\n" 7936 "#endif", 7937 AllmanBraceStyle); 7938 7939 verifyFormat("void foobar() { int i = 5; }\n" 7940 "#ifdef _DEBUG\n" 7941 "void bar() {}\n" 7942 "#else\n" 7943 "void bar() { foobar(); }\n" 7944 "#endif", 7945 AllmanBraceStyle); 7946 7947 // This shouldn't affect ObjC blocks.. 7948 verifyFormat("[self doSomeThingWithACompletionHandler:^{\n" 7949 " // ...\n" 7950 " int i;\n" 7951 "}];", 7952 AllmanBraceStyle); 7953 verifyFormat("void (^block)(void) = ^{\n" 7954 " // ...\n" 7955 " int i;\n" 7956 "};", 7957 AllmanBraceStyle); 7958 // .. or dict literals. 7959 verifyFormat("void f()\n" 7960 "{\n" 7961 " [object someMethod:@{ @\"a\" : @\"b\" }];\n" 7962 "}", 7963 AllmanBraceStyle); 7964 7965 AllmanBraceStyle.ColumnLimit = 19; 7966 verifyFormat("void f() { int i; }", AllmanBraceStyle); 7967 AllmanBraceStyle.ColumnLimit = 18; 7968 verifyFormat("void f()\n" 7969 "{\n" 7970 " int i;\n" 7971 "}", 7972 AllmanBraceStyle); 7973 AllmanBraceStyle.ColumnLimit = 80; 7974 7975 FormatStyle BreakBeforeBraceShortIfs = AllmanBraceStyle; 7976 BreakBeforeBraceShortIfs.AllowShortIfStatementsOnASingleLine = true; 7977 BreakBeforeBraceShortIfs.AllowShortLoopsOnASingleLine = true; 7978 verifyFormat("void f(bool b)\n" 7979 "{\n" 7980 " if (b)\n" 7981 " {\n" 7982 " return;\n" 7983 " }\n" 7984 "}\n", 7985 BreakBeforeBraceShortIfs); 7986 verifyFormat("void f(bool b)\n" 7987 "{\n" 7988 " if (b) return;\n" 7989 "}\n", 7990 BreakBeforeBraceShortIfs); 7991 verifyFormat("void f(bool b)\n" 7992 "{\n" 7993 " while (b)\n" 7994 " {\n" 7995 " return;\n" 7996 " }\n" 7997 "}\n", 7998 BreakBeforeBraceShortIfs); 7999 } 8000 8001 TEST_F(FormatTest, GNUBraceBreaking) { 8002 FormatStyle GNUBraceStyle = getLLVMStyle(); 8003 GNUBraceStyle.BreakBeforeBraces = FormatStyle::BS_GNU; 8004 verifyFormat("namespace a\n" 8005 "{\n" 8006 "class A\n" 8007 "{\n" 8008 " void f()\n" 8009 " {\n" 8010 " int a;\n" 8011 " {\n" 8012 " int b;\n" 8013 " }\n" 8014 " if (true)\n" 8015 " {\n" 8016 " a();\n" 8017 " b();\n" 8018 " }\n" 8019 " }\n" 8020 " void g() { return; }\n" 8021 "}\n" 8022 "}", 8023 GNUBraceStyle); 8024 8025 verifyFormat("void f()\n" 8026 "{\n" 8027 " if (true)\n" 8028 " {\n" 8029 " a();\n" 8030 " }\n" 8031 " else if (false)\n" 8032 " {\n" 8033 " b();\n" 8034 " }\n" 8035 " else\n" 8036 " {\n" 8037 " c();\n" 8038 " }\n" 8039 "}\n", 8040 GNUBraceStyle); 8041 8042 verifyFormat("void f()\n" 8043 "{\n" 8044 " for (int i = 0; i < 10; ++i)\n" 8045 " {\n" 8046 " a();\n" 8047 " }\n" 8048 " while (false)\n" 8049 " {\n" 8050 " b();\n" 8051 " }\n" 8052 " do\n" 8053 " {\n" 8054 " c();\n" 8055 " }\n" 8056 " while (false);\n" 8057 "}\n", 8058 GNUBraceStyle); 8059 8060 verifyFormat("void f(int a)\n" 8061 "{\n" 8062 " switch (a)\n" 8063 " {\n" 8064 " case 0:\n" 8065 " break;\n" 8066 " case 1:\n" 8067 " {\n" 8068 " break;\n" 8069 " }\n" 8070 " case 2:\n" 8071 " {\n" 8072 " }\n" 8073 " break;\n" 8074 " default:\n" 8075 " break;\n" 8076 " }\n" 8077 "}\n", 8078 GNUBraceStyle); 8079 8080 verifyFormat("enum X\n" 8081 "{\n" 8082 " Y = 0,\n" 8083 "}\n", 8084 GNUBraceStyle); 8085 8086 verifyFormat("@interface BSApplicationController ()\n" 8087 "{\n" 8088 "@private\n" 8089 " id _extraIvar;\n" 8090 "}\n" 8091 "@end\n", 8092 GNUBraceStyle); 8093 8094 verifyFormat("#ifdef _DEBUG\n" 8095 "int foo(int i = 0)\n" 8096 "#else\n" 8097 "int foo(int i = 5)\n" 8098 "#endif\n" 8099 "{\n" 8100 " return i;\n" 8101 "}", 8102 GNUBraceStyle); 8103 8104 verifyFormat("void foo() {}\n" 8105 "void bar()\n" 8106 "#ifdef _DEBUG\n" 8107 "{\n" 8108 " foo();\n" 8109 "}\n" 8110 "#else\n" 8111 "{\n" 8112 "}\n" 8113 "#endif", 8114 GNUBraceStyle); 8115 8116 verifyFormat("void foobar() { int i = 5; }\n" 8117 "#ifdef _DEBUG\n" 8118 "void bar() {}\n" 8119 "#else\n" 8120 "void bar() { foobar(); }\n" 8121 "#endif", 8122 GNUBraceStyle); 8123 } 8124 TEST_F(FormatTest, CatchExceptionReferenceBinding) { 8125 verifyFormat("void f() {\n" 8126 " try {\n" 8127 " } catch (const Exception &e) {\n" 8128 " }\n" 8129 "}\n", 8130 getLLVMStyle()); 8131 } 8132 8133 TEST_F(FormatTest, UnderstandsPragmas) { 8134 verifyFormat("#pragma omp reduction(| : var)"); 8135 verifyFormat("#pragma omp reduction(+ : var)"); 8136 8137 EXPECT_EQ("#pragma mark Any non-hyphenated or hyphenated string " 8138 "(including parentheses).", 8139 format("#pragma mark Any non-hyphenated or hyphenated string " 8140 "(including parentheses).")); 8141 } 8142 8143 #define EXPECT_ALL_STYLES_EQUAL(Styles) \ 8144 for (size_t i = 1; i < Styles.size(); ++i) \ 8145 EXPECT_EQ(Styles[0], Styles[i]) << "Style #" << i << " of " \ 8146 << Styles.size() \ 8147 << " differs from Style #0" 8148 8149 TEST_F(FormatTest, GetsPredefinedStyleByName) { 8150 SmallVector<FormatStyle, 3> Styles; 8151 Styles.resize(3); 8152 8153 Styles[0] = getLLVMStyle(); 8154 EXPECT_TRUE(getPredefinedStyle("LLVM", FormatStyle::LK_Cpp, &Styles[1])); 8155 EXPECT_TRUE(getPredefinedStyle("lLvM", FormatStyle::LK_Cpp, &Styles[2])); 8156 EXPECT_ALL_STYLES_EQUAL(Styles); 8157 8158 Styles[0] = getGoogleStyle(); 8159 EXPECT_TRUE(getPredefinedStyle("Google", FormatStyle::LK_Cpp, &Styles[1])); 8160 EXPECT_TRUE(getPredefinedStyle("gOOgle", FormatStyle::LK_Cpp, &Styles[2])); 8161 EXPECT_ALL_STYLES_EQUAL(Styles); 8162 8163 Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); 8164 EXPECT_TRUE( 8165 getPredefinedStyle("Google", FormatStyle::LK_JavaScript, &Styles[1])); 8166 EXPECT_TRUE( 8167 getPredefinedStyle("gOOgle", FormatStyle::LK_JavaScript, &Styles[2])); 8168 EXPECT_ALL_STYLES_EQUAL(Styles); 8169 8170 Styles[0] = getChromiumStyle(FormatStyle::LK_Cpp); 8171 EXPECT_TRUE(getPredefinedStyle("Chromium", FormatStyle::LK_Cpp, &Styles[1])); 8172 EXPECT_TRUE(getPredefinedStyle("cHRoMiUM", FormatStyle::LK_Cpp, &Styles[2])); 8173 EXPECT_ALL_STYLES_EQUAL(Styles); 8174 8175 Styles[0] = getMozillaStyle(); 8176 EXPECT_TRUE(getPredefinedStyle("Mozilla", FormatStyle::LK_Cpp, &Styles[1])); 8177 EXPECT_TRUE(getPredefinedStyle("moZILla", FormatStyle::LK_Cpp, &Styles[2])); 8178 EXPECT_ALL_STYLES_EQUAL(Styles); 8179 8180 Styles[0] = getWebKitStyle(); 8181 EXPECT_TRUE(getPredefinedStyle("WebKit", FormatStyle::LK_Cpp, &Styles[1])); 8182 EXPECT_TRUE(getPredefinedStyle("wEbKit", FormatStyle::LK_Cpp, &Styles[2])); 8183 EXPECT_ALL_STYLES_EQUAL(Styles); 8184 8185 Styles[0] = getGNUStyle(); 8186 EXPECT_TRUE(getPredefinedStyle("GNU", FormatStyle::LK_Cpp, &Styles[1])); 8187 EXPECT_TRUE(getPredefinedStyle("gnU", FormatStyle::LK_Cpp, &Styles[2])); 8188 EXPECT_ALL_STYLES_EQUAL(Styles); 8189 8190 EXPECT_FALSE(getPredefinedStyle("qwerty", FormatStyle::LK_Cpp, &Styles[0])); 8191 } 8192 8193 TEST_F(FormatTest, GetsCorrectBasedOnStyle) { 8194 SmallVector<FormatStyle, 8> Styles; 8195 Styles.resize(2); 8196 8197 Styles[0] = getGoogleStyle(); 8198 Styles[1] = getLLVMStyle(); 8199 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); 8200 EXPECT_ALL_STYLES_EQUAL(Styles); 8201 8202 Styles.resize(5); 8203 Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); 8204 Styles[1] = getLLVMStyle(); 8205 Styles[1].Language = FormatStyle::LK_JavaScript; 8206 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); 8207 8208 Styles[2] = getLLVMStyle(); 8209 Styles[2].Language = FormatStyle::LK_JavaScript; 8210 EXPECT_EQ(0, parseConfiguration("Language: JavaScript\n" 8211 "BasedOnStyle: Google", 8212 &Styles[2]).value()); 8213 8214 Styles[3] = getLLVMStyle(); 8215 Styles[3].Language = FormatStyle::LK_JavaScript; 8216 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google\n" 8217 "Language: JavaScript", 8218 &Styles[3]).value()); 8219 8220 Styles[4] = getLLVMStyle(); 8221 Styles[4].Language = FormatStyle::LK_JavaScript; 8222 EXPECT_EQ(0, parseConfiguration("---\n" 8223 "BasedOnStyle: LLVM\n" 8224 "IndentWidth: 123\n" 8225 "---\n" 8226 "BasedOnStyle: Google\n" 8227 "Language: JavaScript", 8228 &Styles[4]).value()); 8229 EXPECT_ALL_STYLES_EQUAL(Styles); 8230 } 8231 8232 #define CHECK_PARSE_BOOL(FIELD) \ 8233 Style.FIELD = false; \ 8234 EXPECT_EQ(0, parseConfiguration(#FIELD ": true", &Style).value()); \ 8235 EXPECT_TRUE(Style.FIELD); \ 8236 EXPECT_EQ(0, parseConfiguration(#FIELD ": false", &Style).value()); \ 8237 EXPECT_FALSE(Style.FIELD); 8238 8239 TEST_F(FormatTest, ParsesConfigurationBools) { 8240 FormatStyle Style = {}; 8241 Style.Language = FormatStyle::LK_Cpp; 8242 CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft); 8243 CHECK_PARSE_BOOL(AlignTrailingComments); 8244 CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine); 8245 CHECK_PARSE_BOOL(AllowShortBlocksOnASingleLine); 8246 CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine); 8247 CHECK_PARSE_BOOL(AllowShortLoopsOnASingleLine); 8248 CHECK_PARSE_BOOL(AlwaysBreakAfterDefinitionReturnType); 8249 CHECK_PARSE_BOOL(AlwaysBreakTemplateDeclarations); 8250 CHECK_PARSE_BOOL(BinPackParameters); 8251 CHECK_PARSE_BOOL(BreakBeforeBinaryOperators); 8252 CHECK_PARSE_BOOL(BreakBeforeTernaryOperators); 8253 CHECK_PARSE_BOOL(BreakConstructorInitializersBeforeComma); 8254 CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine); 8255 CHECK_PARSE_BOOL(DerivePointerAlignment); 8256 CHECK_PARSE_BOOL(IndentCaseLabels); 8257 CHECK_PARSE_BOOL(IndentWrappedFunctionNames); 8258 CHECK_PARSE_BOOL(KeepEmptyLinesAtTheStartOfBlocks); 8259 CHECK_PARSE_BOOL(ObjCSpaceAfterProperty); 8260 CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList); 8261 CHECK_PARSE_BOOL(Cpp11BracedListStyle); 8262 CHECK_PARSE_BOOL(SpacesInParentheses); 8263 CHECK_PARSE_BOOL(SpacesInAngles); 8264 CHECK_PARSE_BOOL(SpaceInEmptyParentheses); 8265 CHECK_PARSE_BOOL(SpacesInContainerLiterals); 8266 CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses); 8267 CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators); 8268 } 8269 8270 #undef CHECK_PARSE_BOOL 8271 8272 #define CHECK_PARSE(TEXT, FIELD, VALUE) \ 8273 EXPECT_NE(VALUE, Style.FIELD); \ 8274 EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \ 8275 EXPECT_EQ(VALUE, Style.FIELD) 8276 8277 TEST_F(FormatTest, ParsesConfiguration) { 8278 FormatStyle Style = {}; 8279 Style.Language = FormatStyle::LK_Cpp; 8280 CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234); 8281 CHECK_PARSE("ConstructorInitializerIndentWidth: 1234", 8282 ConstructorInitializerIndentWidth, 1234u); 8283 CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u); 8284 CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u); 8285 CHECK_PARSE("PenaltyBreakBeforeFirstCallParameter: 1234", 8286 PenaltyBreakBeforeFirstCallParameter, 1234u); 8287 CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u); 8288 CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234", 8289 PenaltyReturnTypeOnItsOwnLine, 1234u); 8290 CHECK_PARSE("SpacesBeforeTrailingComments: 1234", 8291 SpacesBeforeTrailingComments, 1234u); 8292 CHECK_PARSE("IndentWidth: 32", IndentWidth, 32u); 8293 CHECK_PARSE("ContinuationIndentWidth: 11", ContinuationIndentWidth, 11u); 8294 8295 Style.PointerAlignment = FormatStyle::PAS_Middle; 8296 CHECK_PARSE("PointerAlignment: Left", PointerAlignment, FormatStyle::PAS_Left); 8297 CHECK_PARSE("PointerAlignment: Right", PointerAlignment, FormatStyle::PAS_Right); 8298 CHECK_PARSE("PointerAlignment: Middle", PointerAlignment, FormatStyle::PAS_Middle); 8299 8300 Style.Standard = FormatStyle::LS_Auto; 8301 CHECK_PARSE("Standard: Cpp03", Standard, FormatStyle::LS_Cpp03); 8302 CHECK_PARSE("Standard: Cpp11", Standard, FormatStyle::LS_Cpp11); 8303 CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03); 8304 CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11); 8305 CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto); 8306 8307 Style.UseTab = FormatStyle::UT_ForIndentation; 8308 CHECK_PARSE("UseTab: false", UseTab, FormatStyle::UT_Never); 8309 CHECK_PARSE("UseTab: true", UseTab, FormatStyle::UT_Always); 8310 CHECK_PARSE("UseTab: Never", UseTab, FormatStyle::UT_Never); 8311 CHECK_PARSE("UseTab: ForIndentation", UseTab, FormatStyle::UT_ForIndentation); 8312 CHECK_PARSE("UseTab: Always", UseTab, FormatStyle::UT_Always); 8313 8314 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 8315 CHECK_PARSE("AllowShortFunctionsOnASingleLine: false", 8316 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); 8317 CHECK_PARSE("AllowShortFunctionsOnASingleLine: true", 8318 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); 8319 CHECK_PARSE("AllowShortFunctionsOnASingleLine: None", 8320 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); 8321 CHECK_PARSE("AllowShortFunctionsOnASingleLine: Inline", 8322 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_Inline); 8323 CHECK_PARSE("AllowShortFunctionsOnASingleLine: All", 8324 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); 8325 8326 Style.SpaceBeforeParens = FormatStyle::SBPO_Always; 8327 CHECK_PARSE("SpaceBeforeParens: Never", SpaceBeforeParens, 8328 FormatStyle::SBPO_Never); 8329 CHECK_PARSE("SpaceBeforeParens: Always", SpaceBeforeParens, 8330 FormatStyle::SBPO_Always); 8331 CHECK_PARSE("SpaceBeforeParens: ControlStatements", SpaceBeforeParens, 8332 FormatStyle::SBPO_ControlStatements); 8333 // For backward compatibility: 8334 CHECK_PARSE("SpaceAfterControlStatementKeyword: false", SpaceBeforeParens, 8335 FormatStyle::SBPO_Never); 8336 CHECK_PARSE("SpaceAfterControlStatementKeyword: true", SpaceBeforeParens, 8337 FormatStyle::SBPO_ControlStatements); 8338 8339 Style.ColumnLimit = 123; 8340 FormatStyle BaseStyle = getLLVMStyle(); 8341 CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); 8342 CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); 8343 8344 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 8345 CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces, 8346 FormatStyle::BS_Attach); 8347 CHECK_PARSE("BreakBeforeBraces: Linux", BreakBeforeBraces, 8348 FormatStyle::BS_Linux); 8349 CHECK_PARSE("BreakBeforeBraces: Stroustrup", BreakBeforeBraces, 8350 FormatStyle::BS_Stroustrup); 8351 CHECK_PARSE("BreakBeforeBraces: Allman", BreakBeforeBraces, 8352 FormatStyle::BS_Allman); 8353 CHECK_PARSE("BreakBeforeBraces: GNU", BreakBeforeBraces, FormatStyle::BS_GNU); 8354 8355 Style.NamespaceIndentation = FormatStyle::NI_All; 8356 CHECK_PARSE("NamespaceIndentation: None", NamespaceIndentation, 8357 FormatStyle::NI_None); 8358 CHECK_PARSE("NamespaceIndentation: Inner", NamespaceIndentation, 8359 FormatStyle::NI_Inner); 8360 CHECK_PARSE("NamespaceIndentation: All", NamespaceIndentation, 8361 FormatStyle::NI_All); 8362 8363 Style.ForEachMacros.clear(); 8364 std::vector<std::string> BoostForeach; 8365 BoostForeach.push_back("BOOST_FOREACH"); 8366 CHECK_PARSE("ForEachMacros: [BOOST_FOREACH]", ForEachMacros, BoostForeach); 8367 std::vector<std::string> BoostAndQForeach; 8368 BoostAndQForeach.push_back("BOOST_FOREACH"); 8369 BoostAndQForeach.push_back("Q_FOREACH"); 8370 CHECK_PARSE("ForEachMacros: [BOOST_FOREACH, Q_FOREACH]", ForEachMacros, 8371 BoostAndQForeach); 8372 } 8373 8374 TEST_F(FormatTest, ParsesConfigurationWithLanguages) { 8375 FormatStyle Style = {}; 8376 Style.Language = FormatStyle::LK_Cpp; 8377 CHECK_PARSE("Language: Cpp\n" 8378 "IndentWidth: 12", 8379 IndentWidth, 12u); 8380 EXPECT_EQ(parseConfiguration("Language: JavaScript\n" 8381 "IndentWidth: 34", 8382 &Style), 8383 ParseError::Unsuitable); 8384 EXPECT_EQ(12u, Style.IndentWidth); 8385 CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); 8386 EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); 8387 8388 Style.Language = FormatStyle::LK_JavaScript; 8389 CHECK_PARSE("Language: JavaScript\n" 8390 "IndentWidth: 12", 8391 IndentWidth, 12u); 8392 CHECK_PARSE("IndentWidth: 23", IndentWidth, 23u); 8393 EXPECT_EQ(parseConfiguration("Language: Cpp\n" 8394 "IndentWidth: 34", 8395 &Style), 8396 ParseError::Unsuitable); 8397 EXPECT_EQ(23u, Style.IndentWidth); 8398 CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); 8399 EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); 8400 8401 CHECK_PARSE("BasedOnStyle: LLVM\n" 8402 "IndentWidth: 67", 8403 IndentWidth, 67u); 8404 8405 CHECK_PARSE("---\n" 8406 "Language: JavaScript\n" 8407 "IndentWidth: 12\n" 8408 "---\n" 8409 "Language: Cpp\n" 8410 "IndentWidth: 34\n" 8411 "...\n", 8412 IndentWidth, 12u); 8413 8414 Style.Language = FormatStyle::LK_Cpp; 8415 CHECK_PARSE("---\n" 8416 "Language: JavaScript\n" 8417 "IndentWidth: 12\n" 8418 "---\n" 8419 "Language: Cpp\n" 8420 "IndentWidth: 34\n" 8421 "...\n", 8422 IndentWidth, 34u); 8423 CHECK_PARSE("---\n" 8424 "IndentWidth: 78\n" 8425 "---\n" 8426 "Language: JavaScript\n" 8427 "IndentWidth: 56\n" 8428 "...\n", 8429 IndentWidth, 78u); 8430 8431 Style.ColumnLimit = 123; 8432 Style.IndentWidth = 234; 8433 Style.BreakBeforeBraces = FormatStyle::BS_Linux; 8434 Style.TabWidth = 345; 8435 EXPECT_FALSE(parseConfiguration("---\n" 8436 "IndentWidth: 456\n" 8437 "BreakBeforeBraces: Allman\n" 8438 "---\n" 8439 "Language: JavaScript\n" 8440 "IndentWidth: 111\n" 8441 "TabWidth: 111\n" 8442 "---\n" 8443 "Language: Cpp\n" 8444 "BreakBeforeBraces: Stroustrup\n" 8445 "TabWidth: 789\n" 8446 "...\n", 8447 &Style)); 8448 EXPECT_EQ(123u, Style.ColumnLimit); 8449 EXPECT_EQ(456u, Style.IndentWidth); 8450 EXPECT_EQ(FormatStyle::BS_Stroustrup, Style.BreakBeforeBraces); 8451 EXPECT_EQ(789u, Style.TabWidth); 8452 8453 EXPECT_EQ(parseConfiguration("---\n" 8454 "Language: JavaScript\n" 8455 "IndentWidth: 56\n" 8456 "---\n" 8457 "IndentWidth: 78\n" 8458 "...\n", 8459 &Style), 8460 ParseError::Error); 8461 EXPECT_EQ(parseConfiguration("---\n" 8462 "Language: JavaScript\n" 8463 "IndentWidth: 56\n" 8464 "---\n" 8465 "Language: JavaScript\n" 8466 "IndentWidth: 78\n" 8467 "...\n", 8468 &Style), 8469 ParseError::Error); 8470 8471 EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); 8472 } 8473 8474 #undef CHECK_PARSE 8475 8476 TEST_F(FormatTest, UsesLanguageForBasedOnStyle) { 8477 FormatStyle Style = {}; 8478 Style.Language = FormatStyle::LK_JavaScript; 8479 Style.BreakBeforeTernaryOperators = true; 8480 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Style).value()); 8481 EXPECT_FALSE(Style.BreakBeforeTernaryOperators); 8482 8483 Style.BreakBeforeTernaryOperators = true; 8484 EXPECT_EQ(0, parseConfiguration("---\n" 8485 "BasedOnStyle: Google\n" 8486 "---\n" 8487 "Language: JavaScript\n" 8488 "IndentWidth: 76\n" 8489 "...\n", &Style).value()); 8490 EXPECT_FALSE(Style.BreakBeforeTernaryOperators); 8491 EXPECT_EQ(76u, Style.IndentWidth); 8492 EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); 8493 } 8494 8495 TEST_F(FormatTest, ConfigurationRoundTripTest) { 8496 FormatStyle Style = getLLVMStyle(); 8497 std::string YAML = configurationAsText(Style); 8498 FormatStyle ParsedStyle = {}; 8499 ParsedStyle.Language = FormatStyle::LK_Cpp; 8500 EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value()); 8501 EXPECT_EQ(Style, ParsedStyle); 8502 } 8503 8504 TEST_F(FormatTest, WorksFor8bitEncodings) { 8505 EXPECT_EQ("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 \"\n" 8506 "\"\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \"\n" 8507 "\"\xe7\xe8\xec\xed\xfe\xfe \"\n" 8508 "\"\xef\xee\xf0\xf3...\"", 8509 format("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 " 8510 "\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \xe7\xe8\xec\xed\xfe\xfe " 8511 "\xef\xee\xf0\xf3...\"", 8512 getLLVMStyleWithColumns(12))); 8513 } 8514 8515 TEST_F(FormatTest, HandlesUTF8BOM) { 8516 EXPECT_EQ("\xef\xbb\xbf", format("\xef\xbb\xbf")); 8517 EXPECT_EQ("\xef\xbb\xbf#include <iostream>", 8518 format("\xef\xbb\xbf#include <iostream>")); 8519 EXPECT_EQ("\xef\xbb\xbf\n#include <iostream>", 8520 format("\xef\xbb\xbf\n#include <iostream>")); 8521 } 8522 8523 // FIXME: Encode Cyrillic and CJK characters below to appease MS compilers. 8524 #if !defined(_MSC_VER) 8525 8526 TEST_F(FormatTest, CountsUTF8CharactersProperly) { 8527 verifyFormat("\"Однажды в студёную зимнюю пору...\"", 8528 getLLVMStyleWithColumns(35)); 8529 verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", 8530 getLLVMStyleWithColumns(31)); 8531 verifyFormat("// Однажды в студёную зимнюю пору...", 8532 getLLVMStyleWithColumns(36)); 8533 verifyFormat("// 一 二 三 四 五 六 七 八 九 十", 8534 getLLVMStyleWithColumns(32)); 8535 verifyFormat("/* Однажды в студёную зимнюю пору... */", 8536 getLLVMStyleWithColumns(39)); 8537 verifyFormat("/* 一 二 三 四 五 六 七 八 九 十 */", 8538 getLLVMStyleWithColumns(35)); 8539 } 8540 8541 TEST_F(FormatTest, SplitsUTF8Strings) { 8542 // Non-printable characters' width is currently considered to be the length in 8543 // bytes in UTF8. The characters can be displayed in very different manner 8544 // (zero-width, single width with a substitution glyph, expanded to their code 8545 // (e.g. "<8d>"), so there's no single correct way to handle them. 8546 EXPECT_EQ("\"aaaaÄ\"\n" 8547 "\"\xc2\x8d\";", 8548 format("\"aaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); 8549 EXPECT_EQ("\"aaaaaaaÄ\"\n" 8550 "\"\xc2\x8d\";", 8551 format("\"aaaaaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); 8552 EXPECT_EQ( 8553 "\"Однажды, в \"\n" 8554 "\"студёную \"\n" 8555 "\"зимнюю \"\n" 8556 "\"пору,\"", 8557 format("\"Однажды, в студёную зимнюю пору,\"", 8558 getLLVMStyleWithColumns(13))); 8559 EXPECT_EQ("\"一 二 三 \"\n" 8560 "\"四 五六 \"\n" 8561 "\"七 八 九 \"\n" 8562 "\"十\"", 8563 format("\"一 二 三 四 五六 七 八 九 十\"", 8564 getLLVMStyleWithColumns(11))); 8565 EXPECT_EQ("\"一\t二 \"\n" 8566 "\"\t三 \"\n" 8567 "\"四 五\t六 \"\n" 8568 "\"\t七 \"\n" 8569 "\"八九十\tqq\"", 8570 format("\"一\t二 \t三 四 五\t六 \t七 八九十\tqq\"", 8571 getLLVMStyleWithColumns(11))); 8572 } 8573 8574 8575 TEST_F(FormatTest, HandlesDoubleWidthCharsInMultiLineStrings) { 8576 EXPECT_EQ("const char *sssss =\n" 8577 " \"一二三四五六七八\\\n" 8578 " 九 十\";", 8579 format("const char *sssss = \"一二三四五六七八\\\n" 8580 " 九 十\";", 8581 getLLVMStyleWithColumns(30))); 8582 } 8583 8584 TEST_F(FormatTest, SplitsUTF8LineComments) { 8585 EXPECT_EQ("// aaaaÄ\xc2\x8d", 8586 format("// aaaaÄ\xc2\x8d", getLLVMStyleWithColumns(10))); 8587 EXPECT_EQ("// Я из лесу\n" 8588 "// вышел; был\n" 8589 "// сильный\n" 8590 "// мороз.", 8591 format("// Я из лесу вышел; был сильный мороз.", 8592 getLLVMStyleWithColumns(13))); 8593 EXPECT_EQ("// 一二三\n" 8594 "// 四五六七\n" 8595 "// 八 九\n" 8596 "// 十", 8597 format("// 一二三 四五六七 八 九 十", getLLVMStyleWithColumns(9))); 8598 } 8599 8600 TEST_F(FormatTest, SplitsUTF8BlockComments) { 8601 EXPECT_EQ("/* Гляжу,\n" 8602 " * поднимается\n" 8603 " * медленно в\n" 8604 " * гору\n" 8605 " * Лошадка,\n" 8606 " * везущая\n" 8607 " * хворосту\n" 8608 " * воз. */", 8609 format("/* Гляжу, поднимается медленно в гору\n" 8610 " * Лошадка, везущая хворосту воз. */", 8611 getLLVMStyleWithColumns(13))); 8612 EXPECT_EQ( 8613 "/* 一二三\n" 8614 " * 四五六七\n" 8615 " * 八 九\n" 8616 " * 十 */", 8617 format("/* 一二三 四五六七 八 九 十 */", getLLVMStyleWithColumns(9))); 8618 EXPECT_EQ("/* �������� ��������\n" 8619 " * ��������\n" 8620 " * ������-�� */", 8621 format("/* �������� �������� �������� ������-�� */", getLLVMStyleWithColumns(12))); 8622 } 8623 8624 #endif // _MSC_VER 8625 8626 TEST_F(FormatTest, ConstructorInitializerIndentWidth) { 8627 FormatStyle Style = getLLVMStyle(); 8628 8629 Style.ConstructorInitializerIndentWidth = 4; 8630 verifyFormat( 8631 "SomeClass::Constructor()\n" 8632 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 8633 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 8634 Style); 8635 8636 Style.ConstructorInitializerIndentWidth = 2; 8637 verifyFormat( 8638 "SomeClass::Constructor()\n" 8639 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 8640 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 8641 Style); 8642 8643 Style.ConstructorInitializerIndentWidth = 0; 8644 verifyFormat( 8645 "SomeClass::Constructor()\n" 8646 ": aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 8647 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 8648 Style); 8649 8650 Style.BreakConstructorInitializersBeforeComma = true; 8651 Style.ConstructorInitializerIndentWidth = 4; 8652 verifyFormat("SomeClass::Constructor()\n" 8653 " : a(a)\n" 8654 " , b(b)\n" 8655 " , c(c) {}", 8656 Style); 8657 verifyFormat("SomeClass::Constructor()\n" 8658 " : a(a) {}", 8659 Style); 8660 8661 Style.ColumnLimit = 0; 8662 verifyFormat("SomeClass::Constructor()\n" 8663 " : a(a) {}", 8664 Style); 8665 verifyFormat("SomeClass::Constructor()\n" 8666 " : a(a)\n" 8667 " , b(b)\n" 8668 " , c(c) {}", 8669 Style); 8670 verifyFormat("SomeClass::Constructor()\n" 8671 " : a(a) {\n" 8672 " foo();\n" 8673 " bar();\n" 8674 "}", 8675 Style); 8676 8677 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; 8678 verifyFormat("SomeClass::Constructor()\n" 8679 " : a(a)\n" 8680 " , b(b)\n" 8681 " , c(c) {\n}", 8682 Style); 8683 verifyFormat("SomeClass::Constructor()\n" 8684 " : a(a) {\n}", 8685 Style); 8686 8687 Style.ColumnLimit = 80; 8688 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; 8689 Style.ConstructorInitializerIndentWidth = 2; 8690 verifyFormat("SomeClass::Constructor()\n" 8691 " : a(a)\n" 8692 " , b(b)\n" 8693 " , c(c) {}", 8694 Style); 8695 8696 Style.ConstructorInitializerIndentWidth = 0; 8697 verifyFormat("SomeClass::Constructor()\n" 8698 ": a(a)\n" 8699 ", b(b)\n" 8700 ", c(c) {}", 8701 Style); 8702 8703 Style.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 8704 Style.ConstructorInitializerIndentWidth = 4; 8705 verifyFormat("SomeClass::Constructor() : aaaaaaaa(aaaaaaaa) {}", Style); 8706 verifyFormat( 8707 "SomeClass::Constructor() : aaaaa(aaaaa), aaaaa(aaaaa), aaaaa(aaaaa)\n", 8708 Style); 8709 verifyFormat( 8710 "SomeClass::Constructor()\n" 8711 " : aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa) {}", 8712 Style); 8713 Style.ConstructorInitializerIndentWidth = 4; 8714 Style.ColumnLimit = 60; 8715 verifyFormat("SomeClass::Constructor()\n" 8716 " : aaaaaaaa(aaaaaaaa)\n" 8717 " , aaaaaaaa(aaaaaaaa)\n" 8718 " , aaaaaaaa(aaaaaaaa) {}", 8719 Style); 8720 } 8721 8722 TEST_F(FormatTest, FormatsWithWebKitStyle) { 8723 FormatStyle Style = getWebKitStyle(); 8724 8725 // Don't indent in outer namespaces. 8726 verifyFormat("namespace outer {\n" 8727 "int i;\n" 8728 "namespace inner {\n" 8729 " int i;\n" 8730 "} // namespace inner\n" 8731 "} // namespace outer\n" 8732 "namespace other_outer {\n" 8733 "int i;\n" 8734 "}", 8735 Style); 8736 8737 // Don't indent case labels. 8738 verifyFormat("switch (variable) {\n" 8739 "case 1:\n" 8740 "case 2:\n" 8741 " doSomething();\n" 8742 " break;\n" 8743 "default:\n" 8744 " ++variable;\n" 8745 "}", 8746 Style); 8747 8748 // Wrap before binary operators. 8749 EXPECT_EQ( 8750 "void f()\n" 8751 "{\n" 8752 " if (aaaaaaaaaaaaaaaa\n" 8753 " && bbbbbbbbbbbbbbbbbbbbbbbb\n" 8754 " && (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 8755 " return;\n" 8756 "}", 8757 format( 8758 "void f() {\n" 8759 "if (aaaaaaaaaaaaaaaa\n" 8760 "&& bbbbbbbbbbbbbbbbbbbbbbbb\n" 8761 "&& (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 8762 "return;\n" 8763 "}", 8764 Style)); 8765 8766 // Allow functions on a single line. 8767 verifyFormat("void f() { return; }", Style); 8768 8769 // Constructor initializers are formatted one per line with the "," on the 8770 // new line. 8771 verifyFormat("Constructor()\n" 8772 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 8773 " , aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaa, // break\n" 8774 " aaaaaaaaaaaaaa)\n" 8775 " , aaaaaaaaaaaaaaaaaaaaaaa()\n" 8776 "{\n" 8777 "}", 8778 Style); 8779 verifyFormat("SomeClass::Constructor()\n" 8780 " : a(a)\n" 8781 "{\n" 8782 "}", 8783 Style); 8784 EXPECT_EQ("SomeClass::Constructor()\n" 8785 " : a(a)\n" 8786 "{\n" 8787 "}", 8788 format("SomeClass::Constructor():a(a){}", Style)); 8789 verifyFormat("SomeClass::Constructor()\n" 8790 " : a(a)\n" 8791 " , b(b)\n" 8792 " , c(c)\n" 8793 "{\n" 8794 "}", Style); 8795 verifyFormat("SomeClass::Constructor()\n" 8796 " : a(a)\n" 8797 "{\n" 8798 " foo();\n" 8799 " bar();\n" 8800 "}", 8801 Style); 8802 8803 // Access specifiers should be aligned left. 8804 verifyFormat("class C {\n" 8805 "public:\n" 8806 " int i;\n" 8807 "};", 8808 Style); 8809 8810 // Do not align comments. 8811 verifyFormat("int a; // Do not\n" 8812 "double b; // align comments.", 8813 Style); 8814 8815 // Accept input's line breaks. 8816 EXPECT_EQ("if (aaaaaaaaaaaaaaa\n" 8817 " || bbbbbbbbbbbbbbb) {\n" 8818 " i++;\n" 8819 "}", 8820 format("if (aaaaaaaaaaaaaaa\n" 8821 "|| bbbbbbbbbbbbbbb) { i++; }", 8822 Style)); 8823 EXPECT_EQ("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) {\n" 8824 " i++;\n" 8825 "}", 8826 format("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) { i++; }", Style)); 8827 8828 // Don't automatically break all macro definitions (llvm.org/PR17842). 8829 verifyFormat("#define aNumber 10", Style); 8830 // However, generally keep the line breaks that the user authored. 8831 EXPECT_EQ("#define aNumber \\\n" 8832 " 10", 8833 format("#define aNumber \\\n" 8834 " 10", 8835 Style)); 8836 8837 // Keep empty and one-element array literals on a single line. 8838 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[]\n" 8839 " copyItems:YES];", 8840 format("NSArray*a=[[NSArray alloc] initWithArray:@[]\n" 8841 "copyItems:YES];", 8842 Style)); 8843 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\" ]\n" 8844 " copyItems:YES];", 8845 format("NSArray*a=[[NSArray alloc]initWithArray:@[ @\"a\" ]\n" 8846 " copyItems:YES];", 8847 Style)); 8848 // FIXME: This does not seem right, there should be more indentation before 8849 // the array literal's entries. Nested blocks have the same problem. 8850 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[\n" 8851 " @\"a\",\n" 8852 " @\"a\"\n" 8853 "]\n" 8854 " copyItems:YES];", 8855 format("NSArray* a = [[NSArray alloc] initWithArray:@[\n" 8856 " @\"a\",\n" 8857 " @\"a\"\n" 8858 " ]\n" 8859 " copyItems:YES];", 8860 Style)); 8861 EXPECT_EQ( 8862 "NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" 8863 " copyItems:YES];", 8864 format("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" 8865 " copyItems:YES];", 8866 Style)); 8867 8868 verifyFormat("[self.a b:c c:d];", Style); 8869 EXPECT_EQ("[self.a b:c\n" 8870 " c:d];", 8871 format("[self.a b:c\n" 8872 "c:d];", 8873 Style)); 8874 } 8875 8876 TEST_F(FormatTest, FormatsLambdas) { 8877 verifyFormat("int c = [b]() mutable { return [&b] { return b++; }(); }();\n"); 8878 verifyFormat("int c = [&] { [=] { return b++; }(); }();\n"); 8879 verifyFormat("int c = [&, &a, a] { [=, c, &d] { return b++; }(); }();\n"); 8880 verifyFormat("int c = [&a, &a, a] { [=, a, b, &c] { return b++; }(); }();\n"); 8881 verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] { return b++; }(); }}\n"); 8882 verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] {}(); }}\n"); 8883 verifyFormat("void f() {\n" 8884 " other(x.begin(), x.end(), [&](int, int) { return 1; });\n" 8885 "}\n"); 8886 verifyFormat("void f() {\n" 8887 " other(x.begin(), //\n" 8888 " x.end(), //\n" 8889 " [&](int, int) { return 1; });\n" 8890 "}\n"); 8891 verifyFormat("SomeFunction([]() { // A cool function...\n" 8892 " return 43;\n" 8893 "});"); 8894 verifyFormat("void f() {\n" 8895 " SomeFunction([](decltype(x), A *a) {});\n" 8896 "}"); 8897 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 8898 " [](const aaaaaaaaaa &a) { return a; });"); 8899 verifyFormat("string abc = SomeFunction(aaaaaaaaaaaaa, aaaaa, []() {\n" 8900 " SomeOtherFunctioooooooooooooooooooooooooon();\n" 8901 "});"); 8902 8903 // Lambdas with return types. 8904 verifyFormat("int c = []() -> int { return 2; }();\n"); 8905 verifyFormat("int c = []() -> vector<int> { return {2}; }();\n"); 8906 verifyFormat("Foo([]() -> std::vector<int> { return {2}; }());"); 8907 verifyFormat("auto aaaaaaaa = [](int i, // break for some reason\n" 8908 " int j) -> int {\n" 8909 " return ffffffffffffffffffffffffffffffffffffffffffff(i * j);\n" 8910 "};"); 8911 8912 // Multiple lambdas in the same parentheses change indentation rules. 8913 verifyFormat("SomeFunction([]() {\n" 8914 " int i = 42;\n" 8915 " return i;\n" 8916 " },\n" 8917 " []() {\n" 8918 " int j = 43;\n" 8919 " return j;\n" 8920 " });"); 8921 8922 // More complex introducers. 8923 verifyFormat("return [i, args...] {};"); 8924 8925 // Not lambdas. 8926 verifyFormat("constexpr char hello[]{\"hello\"};"); 8927 verifyFormat("double &operator[](int i) { return 0; }\n" 8928 "int i;"); 8929 verifyFormat("std::unique_ptr<int[]> foo() {}"); 8930 verifyFormat("int i = a[a][a]->f();"); 8931 verifyFormat("int i = (*b)[a]->f();"); 8932 8933 // Other corner cases. 8934 verifyFormat("void f() {\n" 8935 " bar([]() {} // Did not respect SpacesBeforeTrailingComments\n" 8936 " );\n" 8937 "}"); 8938 8939 // Lambdas created through weird macros. 8940 verifyFormat("void f() {\n" 8941 " MACRO((const AA &a) { return 1; });\n" 8942 "}"); 8943 } 8944 8945 TEST_F(FormatTest, FormatsBlocks) { 8946 verifyFormat("int (^Block)(int, int);"); 8947 verifyFormat("int (^Block1)(int, int) = ^(int i, int j)"); 8948 verifyFormat("void (^block)(int) = ^(id test) { int i; };"); 8949 verifyFormat("void (^block)(int) = ^(int test) { int i; };"); 8950 verifyFormat("void (^block)(int) = ^id(int test) { int i; };"); 8951 verifyFormat("void (^block)(int) = ^int(int test) { int i; };"); 8952 8953 verifyFormat("foo(^{ bar(); });"); 8954 verifyFormat("foo(a, ^{ bar(); });"); 8955 8956 // FIXME: Make whitespace formatting consistent. Ask a ObjC dev how 8957 // it would ideally look. 8958 verifyFormat("[operation setCompletionBlock:^{ [self onOperationDone]; }];"); 8959 verifyFormat("int i = {[operation setCompletionBlock : ^{ [self " 8960 "onOperationDone]; }]};"); 8961 verifyFormat("[operation setCompletionBlock:^(int *i) { f(); }];"); 8962 verifyFormat("int a = [operation block:^int(int *i) { return 1; }];"); 8963 verifyFormat("[myObject doSomethingWith:arg1\n" 8964 " aaa:^int(int *a) { return 1; }\n" 8965 " bbb:f(a * bbbbbbbb)];"); 8966 8967 verifyFormat("[operation setCompletionBlock:^{\n" 8968 " [self.delegate newDataAvailable];\n" 8969 "}];", 8970 getLLVMStyleWithColumns(60)); 8971 verifyFormat("dispatch_async(_fileIOQueue, ^{\n" 8972 " NSString *path = [self sessionFilePath];\n" 8973 " if (path) {\n" 8974 " // ...\n" 8975 " }\n" 8976 "});"); 8977 verifyFormat("[[SessionService sharedService]\n" 8978 " loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" 8979 " if (window) {\n" 8980 " [self windowDidLoad:window];\n" 8981 " } else {\n" 8982 " [self errorLoadingWindow];\n" 8983 " }\n" 8984 " }];"); 8985 verifyFormat("void (^largeBlock)(void) = ^{\n" 8986 " // ...\n" 8987 "};\n", 8988 getLLVMStyleWithColumns(40)); 8989 verifyFormat("[[SessionService sharedService]\n" 8990 " loadWindowWithCompletionBlock: //\n" 8991 " ^(SessionWindow *window) {\n" 8992 " if (window) {\n" 8993 " [self windowDidLoad:window];\n" 8994 " } else {\n" 8995 " [self errorLoadingWindow];\n" 8996 " }\n" 8997 " }];", 8998 getLLVMStyleWithColumns(60)); 8999 verifyFormat("[myObject doSomethingWith:arg1\n" 9000 " firstBlock:^(Foo *a) {\n" 9001 " // ...\n" 9002 " int i;\n" 9003 " }\n" 9004 " secondBlock:^(Bar *b) {\n" 9005 " // ...\n" 9006 " int i;\n" 9007 " }\n" 9008 " thirdBlock:^Foo(Bar *b) {\n" 9009 " // ...\n" 9010 " int i;\n" 9011 " }];"); 9012 verifyFormat("[myObject doSomethingWith:arg1\n" 9013 " firstBlock:-1\n" 9014 " secondBlock:^(Bar *b) {\n" 9015 " // ...\n" 9016 " int i;\n" 9017 " }];"); 9018 9019 verifyFormat("f(^{\n" 9020 " @autoreleasepool {\n" 9021 " if (a) {\n" 9022 " g();\n" 9023 " }\n" 9024 " }\n" 9025 "});"); 9026 } 9027 9028 TEST_F(FormatTest, SupportsCRLF) { 9029 EXPECT_EQ("int a;\r\n" 9030 "int b;\r\n" 9031 "int c;\r\n", 9032 format("int a;\r\n" 9033 " int b;\r\n" 9034 " int c;\r\n", 9035 getLLVMStyle())); 9036 EXPECT_EQ("int a;\r\n" 9037 "int b;\r\n" 9038 "int c;\r\n", 9039 format("int a;\r\n" 9040 " int b;\n" 9041 " int c;\r\n", 9042 getLLVMStyle())); 9043 EXPECT_EQ("int a;\n" 9044 "int b;\n" 9045 "int c;\n", 9046 format("int a;\r\n" 9047 " int b;\n" 9048 " int c;\n", 9049 getLLVMStyle())); 9050 EXPECT_EQ("\"aaaaaaa \"\r\n" 9051 "\"bbbbbbb\";\r\n", 9052 format("\"aaaaaaa bbbbbbb\";\r\n", getLLVMStyleWithColumns(10))); 9053 EXPECT_EQ("#define A \\\r\n" 9054 " b; \\\r\n" 9055 " c; \\\r\n" 9056 " d;\r\n", 9057 format("#define A \\\r\n" 9058 " b; \\\r\n" 9059 " c; d; \r\n", 9060 getGoogleStyle())); 9061 9062 EXPECT_EQ("/*\r\n" 9063 "multi line block comments\r\n" 9064 "should not introduce\r\n" 9065 "an extra carriage return\r\n" 9066 "*/\r\n", 9067 format("/*\r\n" 9068 "multi line block comments\r\n" 9069 "should not introduce\r\n" 9070 "an extra carriage return\r\n" 9071 "*/\r\n")); 9072 } 9073 9074 TEST_F(FormatTest, MunchSemicolonAfterBlocks) { 9075 verifyFormat("MY_CLASS(C) {\n" 9076 " int i;\n" 9077 " int j;\n" 9078 "};"); 9079 } 9080 9081 TEST_F(FormatTest, ConfigurableContinuationIndentWidth) { 9082 FormatStyle TwoIndent = getLLVMStyleWithColumns(15); 9083 TwoIndent.ContinuationIndentWidth = 2; 9084 9085 EXPECT_EQ("int i =\n" 9086 " longFunction(\n" 9087 " arg);", 9088 format("int i = longFunction(arg);", TwoIndent)); 9089 9090 FormatStyle SixIndent = getLLVMStyleWithColumns(20); 9091 SixIndent.ContinuationIndentWidth = 6; 9092 9093 EXPECT_EQ("int i =\n" 9094 " longFunction(\n" 9095 " arg);", 9096 format("int i = longFunction(arg);", SixIndent)); 9097 } 9098 9099 TEST_F(FormatTest, SpacesInAngles) { 9100 FormatStyle Spaces = getLLVMStyle(); 9101 Spaces.SpacesInAngles = true; 9102 9103 verifyFormat("static_cast< int >(arg);", Spaces); 9104 verifyFormat("template < typename T0, typename T1 > void f() {}", Spaces); 9105 verifyFormat("f< int, float >();", Spaces); 9106 verifyFormat("template <> g() {}", Spaces); 9107 verifyFormat("template < std::vector< int > > f() {}", Spaces); 9108 9109 Spaces.Standard = FormatStyle::LS_Cpp03; 9110 Spaces.SpacesInAngles = true; 9111 verifyFormat("A< A< int > >();", Spaces); 9112 9113 Spaces.SpacesInAngles = false; 9114 verifyFormat("A<A<int> >();", Spaces); 9115 9116 Spaces.Standard = FormatStyle::LS_Cpp11; 9117 Spaces.SpacesInAngles = true; 9118 verifyFormat("A< A< int > >();", Spaces); 9119 9120 Spaces.SpacesInAngles = false; 9121 verifyFormat("A<A<int>>();", Spaces); 9122 } 9123 9124 TEST_F(FormatTest, HandleUnbalancedImplicitBracesAcrossPPBranches) { 9125 std::string code = "#if A\n" 9126 "#if B\n" 9127 "a.\n" 9128 "#endif\n" 9129 " a = 1;\n" 9130 "#else\n" 9131 "#endif\n" 9132 "#if C\n" 9133 "#else\n" 9134 "#endif\n"; 9135 EXPECT_EQ(code, format(code)); 9136 } 9137 9138 TEST_F(FormatTest, HandleConflictMarkers) { 9139 // Git/SVN conflict markers. 9140 EXPECT_EQ("int a;\n" 9141 "void f() {\n" 9142 " callme(some(parameter1,\n" 9143 "<<<<<<< text by the vcs\n" 9144 " parameter2),\n" 9145 "||||||| text by the vcs\n" 9146 " parameter2),\n" 9147 " parameter3,\n" 9148 "======= text by the vcs\n" 9149 " parameter2, parameter3),\n" 9150 ">>>>>>> text by the vcs\n" 9151 " otherparameter);\n", 9152 format("int a;\n" 9153 "void f() {\n" 9154 " callme(some(parameter1,\n" 9155 "<<<<<<< text by the vcs\n" 9156 " parameter2),\n" 9157 "||||||| text by the vcs\n" 9158 " parameter2),\n" 9159 " parameter3,\n" 9160 "======= text by the vcs\n" 9161 " parameter2,\n" 9162 " parameter3),\n" 9163 ">>>>>>> text by the vcs\n" 9164 " otherparameter);\n")); 9165 9166 // Perforce markers. 9167 EXPECT_EQ("void f() {\n" 9168 " function(\n" 9169 ">>>> text by the vcs\n" 9170 " parameter,\n" 9171 "==== text by the vcs\n" 9172 " parameter,\n" 9173 "==== text by the vcs\n" 9174 " parameter,\n" 9175 "<<<< text by the vcs\n" 9176 " parameter);\n", 9177 format("void f() {\n" 9178 " function(\n" 9179 ">>>> text by the vcs\n" 9180 " parameter,\n" 9181 "==== text by the vcs\n" 9182 " parameter,\n" 9183 "==== text by the vcs\n" 9184 " parameter,\n" 9185 "<<<< text by the vcs\n" 9186 " parameter);\n")); 9187 9188 EXPECT_EQ("<<<<<<<\n" 9189 "|||||||\n" 9190 "=======\n" 9191 ">>>>>>>", 9192 format("<<<<<<<\n" 9193 "|||||||\n" 9194 "=======\n" 9195 ">>>>>>>")); 9196 9197 EXPECT_EQ("<<<<<<<\n" 9198 "|||||||\n" 9199 "int i;\n" 9200 "=======\n" 9201 ">>>>>>>", 9202 format("<<<<<<<\n" 9203 "|||||||\n" 9204 "int i;\n" 9205 "=======\n" 9206 ">>>>>>>")); 9207 9208 // FIXME: Handle parsing of macros around conflict markers correctly: 9209 EXPECT_EQ("#define Macro \\\n" 9210 "<<<<<<<\n" 9211 "Something \\\n" 9212 "|||||||\n" 9213 "Else \\\n" 9214 "=======\n" 9215 "Other \\\n" 9216 ">>>>>>>\n" 9217 " End int i;\n", 9218 format("#define Macro \\\n" 9219 "<<<<<<<\n" 9220 " Something \\\n" 9221 "|||||||\n" 9222 " Else \\\n" 9223 "=======\n" 9224 " Other \\\n" 9225 ">>>>>>>\n" 9226 " End\n" 9227 "int i;\n")); 9228 } 9229 9230 TEST_F(FormatTest, DisableRegions) { 9231 EXPECT_EQ("int i;\n" 9232 "// clang-format off\n" 9233 " int j;\n" 9234 "// clang-format on\n" 9235 "int k;", 9236 format(" int i;\n" 9237 " // clang-format off\n" 9238 " int j;\n" 9239 " // clang-format on\n" 9240 " int k;")); 9241 } 9242 9243 TEST_F(FormatTest, DoNotCrashOnInvalidInput) { 9244 format("? ) ="); 9245 } 9246 9247 } // end namespace tooling 9248 } // end namespace clang 9249