1 //===- unittest/Format/FormatTest.cpp - Formatting unit tests -------------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 10 #include "FormatTestUtils.h" 11 #include "clang/Format/Format.h" 12 #include "llvm/Support/Debug.h" 13 #include "gtest/gtest.h" 14 15 #define DEBUG_TYPE "format-test" 16 17 namespace clang { 18 namespace format { 19 20 FormatStyle getGoogleStyle() { 21 return getGoogleStyle(FormatStyle::LK_Cpp); 22 } 23 24 class FormatTest : public ::testing::Test { 25 protected: 26 std::string format(llvm::StringRef Code, unsigned Offset, unsigned Length, 27 const FormatStyle &Style) { 28 DEBUG(llvm::errs() << "---\n"); 29 DEBUG(llvm::errs() << Code << "\n\n"); 30 std::vector<tooling::Range> Ranges(1, tooling::Range(Offset, Length)); 31 tooling::Replacements Replaces = reformat(Style, Code, Ranges); 32 ReplacementCount = Replaces.size(); 33 std::string Result = applyAllReplacements(Code, Replaces); 34 EXPECT_NE("", Result); 35 DEBUG(llvm::errs() << "\n" << Result << "\n\n"); 36 return Result; 37 } 38 39 std::string 40 format(llvm::StringRef Code, const FormatStyle &Style = getLLVMStyle()) { 41 return format(Code, 0, Code.size(), Style); 42 } 43 44 FormatStyle getLLVMStyleWithColumns(unsigned ColumnLimit) { 45 FormatStyle Style = getLLVMStyle(); 46 Style.ColumnLimit = ColumnLimit; 47 return Style; 48 } 49 50 FormatStyle getGoogleStyleWithColumns(unsigned ColumnLimit) { 51 FormatStyle Style = getGoogleStyle(); 52 Style.ColumnLimit = ColumnLimit; 53 return Style; 54 } 55 56 void verifyFormat(llvm::StringRef Code, 57 const FormatStyle &Style = getLLVMStyle()) { 58 EXPECT_EQ(Code.str(), format(test::messUp(Code), Style)); 59 } 60 61 void verifyGoogleFormat(llvm::StringRef Code) { 62 verifyFormat(Code, getGoogleStyle()); 63 } 64 65 void verifyIndependentOfContext(llvm::StringRef text) { 66 verifyFormat(text); 67 verifyFormat(llvm::Twine("void f() { " + text + " }").str()); 68 } 69 70 /// \brief Verify that clang-format does not crash on the given input. 71 void verifyNoCrash(llvm::StringRef Code, 72 const FormatStyle &Style = getLLVMStyle()) { 73 format(Code, Style); 74 } 75 76 int ReplacementCount; 77 }; 78 79 TEST_F(FormatTest, MessUp) { 80 EXPECT_EQ("1 2 3", test::messUp("1 2 3")); 81 EXPECT_EQ("1 2 3\n", test::messUp("1\n2\n3\n")); 82 EXPECT_EQ("a\n//b\nc", test::messUp("a\n//b\nc")); 83 EXPECT_EQ("a\n#b\nc", test::messUp("a\n#b\nc")); 84 EXPECT_EQ("a\n#b c d\ne", test::messUp("a\n#b\\\nc\\\nd\ne")); 85 } 86 87 //===----------------------------------------------------------------------===// 88 // Basic function tests. 89 //===----------------------------------------------------------------------===// 90 91 TEST_F(FormatTest, DoesNotChangeCorrectlyFormattedCode) { 92 EXPECT_EQ(";", format(";")); 93 } 94 95 TEST_F(FormatTest, FormatsGlobalStatementsAt0) { 96 EXPECT_EQ("int i;", format(" int i;")); 97 EXPECT_EQ("\nint i;", format(" \n\t \v \f int i;")); 98 EXPECT_EQ("int i;\nint j;", format(" int i; int j;")); 99 EXPECT_EQ("int i;\nint j;", format(" int i;\n int j;")); 100 } 101 102 TEST_F(FormatTest, FormatsUnwrappedLinesAtFirstFormat) { 103 EXPECT_EQ("int i;", format("int\ni;")); 104 } 105 106 TEST_F(FormatTest, FormatsNestedBlockStatements) { 107 EXPECT_EQ("{\n {\n {}\n }\n}", format("{{{}}}")); 108 } 109 110 TEST_F(FormatTest, FormatsNestedCall) { 111 verifyFormat("Method(f1, f2(f3));"); 112 verifyFormat("Method(f1(f2, f3()));"); 113 verifyFormat("Method(f1(f2, (f3())));"); 114 } 115 116 TEST_F(FormatTest, NestedNameSpecifiers) { 117 verifyFormat("vector<::Type> v;"); 118 verifyFormat("::ns::SomeFunction(::ns::SomeOtherFunction())"); 119 verifyFormat("static constexpr bool Bar = decltype(bar())::value;"); 120 verifyFormat("bool a = 2 < ::SomeFunction();"); 121 } 122 123 TEST_F(FormatTest, OnlyGeneratesNecessaryReplacements) { 124 EXPECT_EQ("if (a) {\n" 125 " f();\n" 126 "}", 127 format("if(a){f();}")); 128 EXPECT_EQ(4, ReplacementCount); 129 EXPECT_EQ("if (a) {\n" 130 " f();\n" 131 "}", 132 format("if (a) {\n" 133 " f();\n" 134 "}")); 135 EXPECT_EQ(0, ReplacementCount); 136 } 137 138 TEST_F(FormatTest, RemovesTrailingWhitespaceOfFormattedLine) { 139 EXPECT_EQ("int a;\nint b;", format("int a; \nint b;", 0, 0, getLLVMStyle())); 140 EXPECT_EQ("int a;", format("int a; ")); 141 EXPECT_EQ("int a;\n", format("int a; \n \n \n ")); 142 EXPECT_EQ("int a;\nint b; ", 143 format("int a; \nint b; ", 0, 0, getLLVMStyle())); 144 } 145 146 TEST_F(FormatTest, FormatsCorrectRegionForLeadingWhitespace) { 147 EXPECT_EQ("int b;\nint a;", 148 format("int b;\n int a;", 7, 0, getLLVMStyle())); 149 EXPECT_EQ("int b;\n int a;", 150 format("int b;\n int a;", 6, 0, getLLVMStyle())); 151 152 EXPECT_EQ("#define A \\\n" 153 " int a; \\\n" 154 " int b;", 155 format("#define A \\\n" 156 " int a; \\\n" 157 " int b;", 158 26, 0, getLLVMStyleWithColumns(12))); 159 EXPECT_EQ("#define A \\\n" 160 " int a; \\\n" 161 " int b;", 162 format("#define A \\\n" 163 " int a; \\\n" 164 " int b;", 165 25, 0, getLLVMStyleWithColumns(12))); 166 } 167 168 TEST_F(FormatTest, FormatLineWhenInvokedOnTrailingNewline) { 169 EXPECT_EQ("int b;\n\nint a;", 170 format("int b;\n\nint a;", 8, 0, getLLVMStyle())); 171 EXPECT_EQ("int b;\n\nint a;", 172 format("int b;\n\nint a;", 7, 0, getLLVMStyle())); 173 174 // This might not strictly be correct, but is likely good in all practical 175 // cases. 176 EXPECT_EQ("int b;\nint a;", 177 format("int b;int a;", 7, 0, getLLVMStyle())); 178 } 179 180 TEST_F(FormatTest, RemovesWhitespaceWhenTriggeredOnEmptyLine) { 181 EXPECT_EQ("int a;\n\n int b;", 182 format("int a;\n \n\n int b;", 8, 0, getLLVMStyle())); 183 EXPECT_EQ("int a;\n\n int b;", 184 format("int a;\n \n\n int b;", 9, 0, getLLVMStyle())); 185 } 186 187 TEST_F(FormatTest, RemovesEmptyLines) { 188 EXPECT_EQ("class C {\n" 189 " int i;\n" 190 "};", 191 format("class C {\n" 192 " int i;\n" 193 "\n" 194 "};")); 195 196 // Don't remove empty lines at the start of namespaces or extern "C" blocks. 197 EXPECT_EQ("namespace N {\n" 198 "\n" 199 "int i;\n" 200 "}", 201 format("namespace N {\n" 202 "\n" 203 "int i;\n" 204 "}", 205 getGoogleStyle())); 206 EXPECT_EQ("extern /**/ \"C\" /**/ {\n" 207 "\n" 208 "int i;\n" 209 "}", 210 format("extern /**/ \"C\" /**/ {\n" 211 "\n" 212 "int i;\n" 213 "}", 214 getGoogleStyle())); 215 216 // ...but do keep inlining and removing empty lines for non-block extern "C" 217 // functions. 218 verifyFormat("extern \"C\" int f() { return 42; }", getGoogleStyle()); 219 EXPECT_EQ("extern \"C\" int f() {\n" 220 " int i = 42;\n" 221 " return i;\n" 222 "}", 223 format("extern \"C\" int f() {\n" 224 "\n" 225 " int i = 42;\n" 226 " return i;\n" 227 "}", 228 getGoogleStyle())); 229 230 // Remove empty lines at the beginning and end of blocks. 231 EXPECT_EQ("void f() {\n" 232 "\n" 233 " if (a) {\n" 234 "\n" 235 " f();\n" 236 " }\n" 237 "}", 238 format("void f() {\n" 239 "\n" 240 " if (a) {\n" 241 "\n" 242 " f();\n" 243 "\n" 244 " }\n" 245 "\n" 246 "}", 247 getLLVMStyle())); 248 EXPECT_EQ("void f() {\n" 249 " if (a) {\n" 250 " f();\n" 251 " }\n" 252 "}", 253 format("void f() {\n" 254 "\n" 255 " if (a) {\n" 256 "\n" 257 " f();\n" 258 "\n" 259 " }\n" 260 "\n" 261 "}", 262 getGoogleStyle())); 263 264 // Don't remove empty lines in more complex control statements. 265 EXPECT_EQ("void f() {\n" 266 " if (a) {\n" 267 " f();\n" 268 "\n" 269 " } else if (b) {\n" 270 " f();\n" 271 " }\n" 272 "}", 273 format("void f() {\n" 274 " if (a) {\n" 275 " f();\n" 276 "\n" 277 " } else if (b) {\n" 278 " f();\n" 279 "\n" 280 " }\n" 281 "\n" 282 "}")); 283 284 // FIXME: This is slightly inconsistent. 285 EXPECT_EQ("namespace {\n" 286 "int i;\n" 287 "}", 288 format("namespace {\n" 289 "int i;\n" 290 "\n" 291 "}")); 292 EXPECT_EQ("namespace {\n" 293 "int i;\n" 294 "\n" 295 "} // namespace", 296 format("namespace {\n" 297 "int i;\n" 298 "\n" 299 "} // namespace")); 300 } 301 302 TEST_F(FormatTest, ReformatsMovedLines) { 303 EXPECT_EQ( 304 "template <typename T> T *getFETokenInfo() const {\n" 305 " return static_cast<T *>(FETokenInfo);\n" 306 "}\n" 307 " int a; // <- Should not be formatted", 308 format( 309 "template<typename T>\n" 310 "T *getFETokenInfo() const { return static_cast<T*>(FETokenInfo); }\n" 311 " int a; // <- Should not be formatted", 312 9, 5, getLLVMStyle())); 313 } 314 315 TEST_F(FormatTest, RecognizesBinaryOperatorKeywords) { 316 verifyFormat("x = (a) and (b);"); 317 verifyFormat("x = (a) or (b);"); 318 verifyFormat("x = (a) bitand (b);"); 319 verifyFormat("x = (a) bitor (b);"); 320 verifyFormat("x = (a) not_eq (b);"); 321 verifyFormat("x = (a) and_eq (b);"); 322 verifyFormat("x = (a) or_eq (b);"); 323 verifyFormat("x = (a) xor (b);"); 324 } 325 326 //===----------------------------------------------------------------------===// 327 // Tests for control statements. 328 //===----------------------------------------------------------------------===// 329 330 TEST_F(FormatTest, FormatIfWithoutCompoundStatement) { 331 verifyFormat("if (true)\n f();\ng();"); 332 verifyFormat("if (a)\n if (b)\n if (c)\n g();\nh();"); 333 verifyFormat("if (a)\n if (b) {\n f();\n }\ng();"); 334 335 FormatStyle AllowsMergedIf = getLLVMStyle(); 336 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 337 verifyFormat("if (a)\n" 338 " // comment\n" 339 " f();", 340 AllowsMergedIf); 341 verifyFormat("if (a)\n" 342 " ;", 343 AllowsMergedIf); 344 verifyFormat("if (a)\n" 345 " if (b) return;", 346 AllowsMergedIf); 347 348 verifyFormat("if (a) // Can't merge this\n" 349 " f();\n", 350 AllowsMergedIf); 351 verifyFormat("if (a) /* still don't merge */\n" 352 " f();", 353 AllowsMergedIf); 354 verifyFormat("if (a) { // Never merge this\n" 355 " f();\n" 356 "}", 357 AllowsMergedIf); 358 verifyFormat("if (a) {/* Never merge this */\n" 359 " f();\n" 360 "}", 361 AllowsMergedIf); 362 363 EXPECT_EQ("if (a) return;", format("if(a)\nreturn;", 7, 1, AllowsMergedIf)); 364 EXPECT_EQ("if (a) return; // comment", 365 format("if(a)\nreturn; // comment", 20, 1, AllowsMergedIf)); 366 367 AllowsMergedIf.ColumnLimit = 14; 368 verifyFormat("if (a) return;", AllowsMergedIf); 369 verifyFormat("if (aaaaaaaaa)\n" 370 " return;", 371 AllowsMergedIf); 372 373 AllowsMergedIf.ColumnLimit = 13; 374 verifyFormat("if (a)\n return;", AllowsMergedIf); 375 } 376 377 TEST_F(FormatTest, FormatLoopsWithoutCompoundStatement) { 378 FormatStyle AllowsMergedLoops = getLLVMStyle(); 379 AllowsMergedLoops.AllowShortLoopsOnASingleLine = true; 380 verifyFormat("while (true) continue;", AllowsMergedLoops); 381 verifyFormat("for (;;) continue;", AllowsMergedLoops); 382 verifyFormat("for (int &v : vec) v *= 2;", AllowsMergedLoops); 383 verifyFormat("while (true)\n" 384 " ;", 385 AllowsMergedLoops); 386 verifyFormat("for (;;)\n" 387 " ;", 388 AllowsMergedLoops); 389 verifyFormat("for (;;)\n" 390 " for (;;) continue;", 391 AllowsMergedLoops); 392 verifyFormat("for (;;) // Can't merge this\n" 393 " continue;", 394 AllowsMergedLoops); 395 verifyFormat("for (;;) /* still don't merge */\n" 396 " continue;", 397 AllowsMergedLoops); 398 } 399 400 TEST_F(FormatTest, FormatShortBracedStatements) { 401 FormatStyle AllowSimpleBracedStatements = getLLVMStyle(); 402 AllowSimpleBracedStatements.AllowShortBlocksOnASingleLine = true; 403 404 AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = true; 405 AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = true; 406 407 verifyFormat("if (true) {}", AllowSimpleBracedStatements); 408 verifyFormat("while (true) {}", AllowSimpleBracedStatements); 409 verifyFormat("for (;;) {}", AllowSimpleBracedStatements); 410 verifyFormat("if (true) { f(); }", AllowSimpleBracedStatements); 411 verifyFormat("while (true) { f(); }", AllowSimpleBracedStatements); 412 verifyFormat("for (;;) { f(); }", AllowSimpleBracedStatements); 413 verifyFormat("if (true) { //\n" 414 " f();\n" 415 "}", 416 AllowSimpleBracedStatements); 417 verifyFormat("if (true) {\n" 418 " f();\n" 419 " f();\n" 420 "}", 421 AllowSimpleBracedStatements); 422 423 verifyFormat("template <int> struct A2 {\n" 424 " struct B {};\n" 425 "};", 426 AllowSimpleBracedStatements); 427 428 AllowSimpleBracedStatements.AllowShortIfStatementsOnASingleLine = false; 429 verifyFormat("if (true) {\n" 430 " f();\n" 431 "}", 432 AllowSimpleBracedStatements); 433 434 AllowSimpleBracedStatements.AllowShortLoopsOnASingleLine = false; 435 verifyFormat("while (true) {\n" 436 " f();\n" 437 "}", 438 AllowSimpleBracedStatements); 439 verifyFormat("for (;;) {\n" 440 " f();\n" 441 "}", 442 AllowSimpleBracedStatements); 443 } 444 445 TEST_F(FormatTest, ParseIfElse) { 446 verifyFormat("if (true)\n" 447 " if (true)\n" 448 " if (true)\n" 449 " f();\n" 450 " else\n" 451 " g();\n" 452 " else\n" 453 " h();\n" 454 "else\n" 455 " i();"); 456 verifyFormat("if (true)\n" 457 " if (true)\n" 458 " if (true) {\n" 459 " if (true)\n" 460 " f();\n" 461 " } else {\n" 462 " g();\n" 463 " }\n" 464 " else\n" 465 " h();\n" 466 "else {\n" 467 " i();\n" 468 "}"); 469 verifyFormat("void f() {\n" 470 " if (a) {\n" 471 " } else {\n" 472 " }\n" 473 "}"); 474 } 475 476 TEST_F(FormatTest, ElseIf) { 477 verifyFormat("if (a) {\n} else if (b) {\n}"); 478 verifyFormat("if (a)\n" 479 " f();\n" 480 "else if (b)\n" 481 " g();\n" 482 "else\n" 483 " h();"); 484 verifyFormat("if (a) {\n" 485 " f();\n" 486 "}\n" 487 "// or else ..\n" 488 "else {\n" 489 " g()\n" 490 "}"); 491 492 verifyFormat("if (a) {\n" 493 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 494 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 495 "}"); 496 verifyFormat("if (a) {\n" 497 "} else if (\n" 498 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 499 "}", 500 getLLVMStyleWithColumns(62)); 501 } 502 503 TEST_F(FormatTest, FormatsForLoop) { 504 verifyFormat( 505 "for (int VeryVeryLongLoopVariable = 0; VeryVeryLongLoopVariable < 10;\n" 506 " ++VeryVeryLongLoopVariable)\n" 507 " ;"); 508 verifyFormat("for (;;)\n" 509 " f();"); 510 verifyFormat("for (;;) {\n}"); 511 verifyFormat("for (;;) {\n" 512 " f();\n" 513 "}"); 514 verifyFormat("for (int i = 0; (i < 10); ++i) {\n}"); 515 516 verifyFormat( 517 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 518 " E = UnwrappedLines.end();\n" 519 " I != E; ++I) {\n}"); 520 521 verifyFormat( 522 "for (MachineFun::iterator IIII = PrevIt, EEEE = F.end(); IIII != EEEE;\n" 523 " ++IIIII) {\n}"); 524 verifyFormat("for (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaa =\n" 525 " aaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa;\n" 526 " aaaaaaaaaaa != aaaaaaaaaaaaaaaaaaa; ++aaaaaaaaaaa) {\n}"); 527 verifyFormat("for (llvm::ArrayRef<NamedDecl *>::iterator\n" 528 " I = FD->getDeclsInPrototypeScope().begin(),\n" 529 " E = FD->getDeclsInPrototypeScope().end();\n" 530 " I != E; ++I) {\n}"); 531 532 // FIXME: Not sure whether we want extra identation in line 3 here: 533 verifyFormat( 534 "for (aaaaaaaaaaaaaaaaa aaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 535 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa !=\n" 536 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 537 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 538 " ++aaaaaaaaaaa) {\n}"); 539 verifyFormat("for (int aaaaaaaaaaa = 1; aaaaaaaaaaa <= bbbbbbbbbbbbbbb;\n" 540 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 541 "}"); 542 verifyFormat("for (some_namespace::SomeIterator iter( // force break\n" 543 " aaaaaaaaaa);\n" 544 " iter; ++iter) {\n" 545 "}"); 546 547 FormatStyle NoBinPacking = getLLVMStyle(); 548 NoBinPacking.BinPackParameters = false; 549 verifyFormat("for (int aaaaaaaaaaa = 1;\n" 550 " aaaaaaaaaaa <= aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa,\n" 551 " aaaaaaaaaaaaaaaa,\n" 552 " aaaaaaaaaaaaaaaa,\n" 553 " aaaaaaaaaaaaaaaa);\n" 554 " aaaaaaaaaaa++, bbbbbbbbbbbbbbbbb++) {\n" 555 "}", 556 NoBinPacking); 557 verifyFormat( 558 "for (std::vector<UnwrappedLine>::iterator I = UnwrappedLines.begin(),\n" 559 " E = UnwrappedLines.end();\n" 560 " I != E;\n" 561 " ++I) {\n}", 562 NoBinPacking); 563 } 564 565 TEST_F(FormatTest, RangeBasedForLoops) { 566 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 567 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 568 verifyFormat("for (auto aaaaaaaaaaaaaaaaaaaaa :\n" 569 " aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa, aaaaaaaaaaaaa)) {\n}"); 570 verifyFormat("for (const aaaaaaaaaaaaaaaaaaaaa &aaaaaaaaa :\n" 571 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 572 verifyFormat("for (aaaaaaaaa aaaaaaaaaaaaaaaaaaaaa :\n" 573 " aaaaaaaaaaaa.aaaaaaaaaaaa().aaaaaaaaa().a()) {\n}"); 574 } 575 576 TEST_F(FormatTest, ForEachLoops) { 577 verifyFormat("void f() {\n" 578 " foreach (Item *item, itemlist) {}\n" 579 " Q_FOREACH (Item *item, itemlist) {}\n" 580 " BOOST_FOREACH (Item *item, itemlist) {}\n" 581 " UNKNOWN_FORACH(Item * item, itemlist) {}\n" 582 "}"); 583 } 584 585 TEST_F(FormatTest, FormatsWhileLoop) { 586 verifyFormat("while (true) {\n}"); 587 verifyFormat("while (true)\n" 588 " f();"); 589 verifyFormat("while () {\n}"); 590 verifyFormat("while () {\n" 591 " f();\n" 592 "}"); 593 } 594 595 TEST_F(FormatTest, FormatsDoWhile) { 596 verifyFormat("do {\n" 597 " do_something();\n" 598 "} while (something());"); 599 verifyFormat("do\n" 600 " do_something();\n" 601 "while (something());"); 602 } 603 604 TEST_F(FormatTest, FormatsSwitchStatement) { 605 verifyFormat("switch (x) {\n" 606 "case 1:\n" 607 " f();\n" 608 " break;\n" 609 "case kFoo:\n" 610 "case ns::kBar:\n" 611 "case kBaz:\n" 612 " break;\n" 613 "default:\n" 614 " g();\n" 615 " break;\n" 616 "}"); 617 verifyFormat("switch (x) {\n" 618 "case 1: {\n" 619 " f();\n" 620 " break;\n" 621 "}\n" 622 "case 2: {\n" 623 " break;\n" 624 "}\n" 625 "}"); 626 verifyFormat("switch (x) {\n" 627 "case 1: {\n" 628 " f();\n" 629 " {\n" 630 " g();\n" 631 " h();\n" 632 " }\n" 633 " break;\n" 634 "}\n" 635 "}"); 636 verifyFormat("switch (x) {\n" 637 "case 1: {\n" 638 " f();\n" 639 " if (foo) {\n" 640 " g();\n" 641 " h();\n" 642 " }\n" 643 " break;\n" 644 "}\n" 645 "}"); 646 verifyFormat("switch (x) {\n" 647 "case 1: {\n" 648 " f();\n" 649 " g();\n" 650 "} break;\n" 651 "}"); 652 verifyFormat("switch (test)\n" 653 " ;"); 654 verifyFormat("switch (x) {\n" 655 "default: {\n" 656 " // Do nothing.\n" 657 "}\n" 658 "}"); 659 verifyFormat("switch (x) {\n" 660 "// comment\n" 661 "// if 1, do f()\n" 662 "case 1:\n" 663 " f();\n" 664 "}"); 665 verifyFormat("switch (x) {\n" 666 "case 1:\n" 667 " // Do amazing stuff\n" 668 " {\n" 669 " f();\n" 670 " g();\n" 671 " }\n" 672 " break;\n" 673 "}"); 674 verifyFormat("#define A \\\n" 675 " switch (x) { \\\n" 676 " case a: \\\n" 677 " foo = b; \\\n" 678 " }", getLLVMStyleWithColumns(20)); 679 verifyFormat("#define OPERATION_CASE(name) \\\n" 680 " case OP_name: \\\n" 681 " return operations::Operation##name\n", 682 getLLVMStyleWithColumns(40)); 683 684 verifyGoogleFormat("switch (x) {\n" 685 " case 1:\n" 686 " f();\n" 687 " break;\n" 688 " case kFoo:\n" 689 " case ns::kBar:\n" 690 " case kBaz:\n" 691 " break;\n" 692 " default:\n" 693 " g();\n" 694 " break;\n" 695 "}"); 696 verifyGoogleFormat("switch (x) {\n" 697 " case 1: {\n" 698 " f();\n" 699 " break;\n" 700 " }\n" 701 "}"); 702 verifyGoogleFormat("switch (test)\n" 703 " ;"); 704 705 verifyGoogleFormat("#define OPERATION_CASE(name) \\\n" 706 " case OP_name: \\\n" 707 " return operations::Operation##name\n"); 708 verifyGoogleFormat("Operation codeToOperation(OperationCode OpCode) {\n" 709 " // Get the correction operation class.\n" 710 " switch (OpCode) {\n" 711 " CASE(Add);\n" 712 " CASE(Subtract);\n" 713 " default:\n" 714 " return operations::Unknown;\n" 715 " }\n" 716 "#undef OPERATION_CASE\n" 717 "}"); 718 verifyFormat("DEBUG({\n" 719 " switch (x) {\n" 720 " case A:\n" 721 " f();\n" 722 " break;\n" 723 " // On B:\n" 724 " case B:\n" 725 " g();\n" 726 " break;\n" 727 " }\n" 728 "});"); 729 verifyFormat("switch (a) {\n" 730 "case (b):\n" 731 " return;\n" 732 "}"); 733 734 verifyFormat("switch (a) {\n" 735 "case some_namespace::\n" 736 " some_constant:\n" 737 " return;\n" 738 "}", 739 getLLVMStyleWithColumns(34)); 740 } 741 742 TEST_F(FormatTest, CaseRanges) { 743 verifyFormat("switch (x) {\n" 744 "case 'A' ... 'Z':\n" 745 "case 1 ... 5:\n" 746 " break;\n" 747 "}"); 748 } 749 750 TEST_F(FormatTest, ShortCaseLabels) { 751 FormatStyle Style = getLLVMStyle(); 752 Style.AllowShortCaseLabelsOnASingleLine = true; 753 verifyFormat("switch (a) {\n" 754 "case 1: x = 1; break;\n" 755 "case 2: return;\n" 756 "case 3:\n" 757 "case 4:\n" 758 "case 5: return;\n" 759 "case 6: // comment\n" 760 " return;\n" 761 "case 7:\n" 762 " // comment\n" 763 " return;\n" 764 "default: y = 1; break;\n" 765 "}", 766 Style); 767 verifyFormat("switch (a) {\n" 768 "#if FOO\n" 769 "case 0: return 0;\n" 770 "#endif\n" 771 "}", 772 Style); 773 verifyFormat("switch (a) {\n" 774 "case 1: {\n" 775 "}\n" 776 "case 2: {\n" 777 " return;\n" 778 "}\n" 779 "case 3: {\n" 780 " x = 1;\n" 781 " return;\n" 782 "}\n" 783 "case 4:\n" 784 " if (x)\n" 785 " return;\n" 786 "}", 787 Style); 788 Style.ColumnLimit = 21; 789 verifyFormat("switch (a) {\n" 790 "case 1: x = 1; break;\n" 791 "case 2: return;\n" 792 "case 3:\n" 793 "case 4:\n" 794 "case 5: return;\n" 795 "default:\n" 796 " y = 1;\n" 797 " break;\n" 798 "}", 799 Style); 800 } 801 802 TEST_F(FormatTest, FormatsLabels) { 803 verifyFormat("void f() {\n" 804 " some_code();\n" 805 "test_label:\n" 806 " some_other_code();\n" 807 " {\n" 808 " some_more_code();\n" 809 " another_label:\n" 810 " some_more_code();\n" 811 " }\n" 812 "}"); 813 verifyFormat("some_code();\n" 814 "test_label:\n" 815 "some_other_code();"); 816 } 817 818 //===----------------------------------------------------------------------===// 819 // Tests for comments. 820 //===----------------------------------------------------------------------===// 821 822 TEST_F(FormatTest, UnderstandsSingleLineComments) { 823 verifyFormat("//* */"); 824 verifyFormat("// line 1\n" 825 "// line 2\n" 826 "void f() {}\n"); 827 828 verifyFormat("void f() {\n" 829 " // Doesn't do anything\n" 830 "}"); 831 verifyFormat("SomeObject\n" 832 " // Calling someFunction on SomeObject\n" 833 " .someFunction();"); 834 verifyFormat("auto result = SomeObject\n" 835 " // Calling someFunction on SomeObject\n" 836 " .someFunction();"); 837 verifyFormat("void f(int i, // some comment (probably for i)\n" 838 " int j, // some comment (probably for j)\n" 839 " int k); // some comment (probably for k)"); 840 verifyFormat("void f(int i,\n" 841 " // some comment (probably for j)\n" 842 " int j,\n" 843 " // some comment (probably for k)\n" 844 " int k);"); 845 846 verifyFormat("int i // This is a fancy variable\n" 847 " = 5; // with nicely aligned comment."); 848 849 verifyFormat("// Leading comment.\n" 850 "int a; // Trailing comment."); 851 verifyFormat("int a; // Trailing comment\n" 852 " // on 2\n" 853 " // or 3 lines.\n" 854 "int b;"); 855 verifyFormat("int a; // Trailing comment\n" 856 "\n" 857 "// Leading comment.\n" 858 "int b;"); 859 verifyFormat("int a; // Comment.\n" 860 " // More details.\n" 861 "int bbbb; // Another comment."); 862 verifyFormat( 863 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 864 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // comment\n" 865 "int cccccccccccccccccccccccccccccc; // comment\n" 866 "int ddd; // looooooooooooooooooooooooong comment\n" 867 "int aaaaaaaaaaaaaaaaaaaaaaa; // comment\n" 868 "int bbbbbbbbbbbbbbbbbbbbb; // comment\n" 869 "int ccccccccccccccccccc; // comment"); 870 871 verifyFormat("#include \"a\" // comment\n" 872 "#include \"a/b/c\" // comment"); 873 verifyFormat("#include <a> // comment\n" 874 "#include <a/b/c> // comment"); 875 EXPECT_EQ("#include \"a\" // comment\n" 876 "#include \"a/b/c\" // comment", 877 format("#include \\\n" 878 " \"a\" // comment\n" 879 "#include \"a/b/c\" // comment")); 880 881 verifyFormat("enum E {\n" 882 " // comment\n" 883 " VAL_A, // comment\n" 884 " VAL_B\n" 885 "};"); 886 887 verifyFormat( 888 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 889 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; // Trailing comment"); 890 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 891 " // Comment inside a statement.\n" 892 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 893 verifyFormat("SomeFunction(a,\n" 894 " // comment\n" 895 " b + x);"); 896 verifyFormat("SomeFunction(a, a,\n" 897 " // comment\n" 898 " b + x);"); 899 verifyFormat( 900 "bool aaaaaaaaaaaaa = // comment\n" 901 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 902 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 903 904 verifyFormat("int aaaa; // aaaaa\n" 905 "int aa; // aaaaaaa", 906 getLLVMStyleWithColumns(20)); 907 908 EXPECT_EQ("void f() { // This does something ..\n" 909 "}\n" 910 "int a; // This is unrelated", 911 format("void f() { // This does something ..\n" 912 " }\n" 913 "int a; // This is unrelated")); 914 EXPECT_EQ("class C {\n" 915 " void f() { // This does something ..\n" 916 " } // awesome..\n" 917 "\n" 918 " int a; // This is unrelated\n" 919 "};", 920 format("class C{void f() { // This does something ..\n" 921 " } // awesome..\n" 922 " \n" 923 "int a; // This is unrelated\n" 924 "};")); 925 926 EXPECT_EQ("int i; // single line trailing comment", 927 format("int i;\\\n// single line trailing comment")); 928 929 verifyGoogleFormat("int a; // Trailing comment."); 930 931 verifyFormat("someFunction(anotherFunction( // Force break.\n" 932 " parameter));"); 933 934 verifyGoogleFormat("#endif // HEADER_GUARD"); 935 936 verifyFormat("const char *test[] = {\n" 937 " // A\n" 938 " \"aaaa\",\n" 939 " // B\n" 940 " \"aaaaa\"};"); 941 verifyGoogleFormat( 942 "aaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 943 " aaaaaaaaaaaaaaaaaaaaaa); // 81_cols_with_this_comment"); 944 EXPECT_EQ("D(a, {\n" 945 " // test\n" 946 " int a;\n" 947 "});", 948 format("D(a, {\n" 949 "// test\n" 950 "int a;\n" 951 "});")); 952 953 EXPECT_EQ("lineWith(); // comment\n" 954 "// at start\n" 955 "otherLine();", 956 format("lineWith(); // comment\n" 957 "// at start\n" 958 "otherLine();")); 959 EXPECT_EQ("lineWith(); // comment\n" 960 " // at start\n" 961 "otherLine();", 962 format("lineWith(); // comment\n" 963 " // at start\n" 964 "otherLine();")); 965 966 EXPECT_EQ("lineWith(); // comment\n" 967 "// at start\n" 968 "otherLine(); // comment", 969 format("lineWith(); // comment\n" 970 "// at start\n" 971 "otherLine(); // comment")); 972 EXPECT_EQ("lineWith();\n" 973 "// at start\n" 974 "otherLine(); // comment", 975 format("lineWith();\n" 976 " // at start\n" 977 "otherLine(); // comment")); 978 EXPECT_EQ("// first\n" 979 "// at start\n" 980 "otherLine(); // comment", 981 format("// first\n" 982 " // at start\n" 983 "otherLine(); // comment")); 984 EXPECT_EQ("f();\n" 985 "// first\n" 986 "// at start\n" 987 "otherLine(); // comment", 988 format("f();\n" 989 "// first\n" 990 " // at start\n" 991 "otherLine(); // comment")); 992 verifyFormat("f(); // comment\n" 993 "// first\n" 994 "// at start\n" 995 "otherLine();"); 996 EXPECT_EQ("f(); // comment\n" 997 "// first\n" 998 "// at start\n" 999 "otherLine();", 1000 format("f(); // comment\n" 1001 "// first\n" 1002 " // at start\n" 1003 "otherLine();")); 1004 EXPECT_EQ("f(); // comment\n" 1005 " // first\n" 1006 "// at start\n" 1007 "otherLine();", 1008 format("f(); // comment\n" 1009 " // first\n" 1010 "// at start\n" 1011 "otherLine();")); 1012 EXPECT_EQ("void f() {\n" 1013 " lineWith(); // comment\n" 1014 " // at start\n" 1015 "}", 1016 format("void f() {\n" 1017 " lineWith(); // comment\n" 1018 " // at start\n" 1019 "}")); 1020 1021 verifyFormat( 1022 "#define A \\\n" 1023 " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" 1024 " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", 1025 getLLVMStyleWithColumns(60)); 1026 verifyFormat( 1027 "#define A \\\n" 1028 " int i; /* iiiiiiiiiiiiiiiiiiiii */ \\\n" 1029 " int jjjjjjjjjjjjjjjjjjjjjjjj; /* */", 1030 getLLVMStyleWithColumns(61)); 1031 1032 verifyFormat("if ( // This is some comment\n" 1033 " x + 3) {\n" 1034 "}"); 1035 EXPECT_EQ("if ( // This is some comment\n" 1036 " // spanning two lines\n" 1037 " x + 3) {\n" 1038 "}", 1039 format("if( // This is some comment\n" 1040 " // spanning two lines\n" 1041 " x + 3) {\n" 1042 "}")); 1043 1044 verifyNoCrash("/\\\n/"); 1045 verifyNoCrash("/\\\n* */"); 1046 } 1047 1048 TEST_F(FormatTest, KeepsParameterWithTrailingCommentsOnTheirOwnLine) { 1049 EXPECT_EQ("SomeFunction(a,\n" 1050 " b, // comment\n" 1051 " c);", 1052 format("SomeFunction(a,\n" 1053 " b, // comment\n" 1054 " c);")); 1055 EXPECT_EQ("SomeFunction(a, b,\n" 1056 " // comment\n" 1057 " c);", 1058 format("SomeFunction(a,\n" 1059 " b,\n" 1060 " // comment\n" 1061 " c);")); 1062 EXPECT_EQ("SomeFunction(a, b, // comment (unclear relation)\n" 1063 " c);", 1064 format("SomeFunction(a, b, // comment (unclear relation)\n" 1065 " c);")); 1066 EXPECT_EQ("SomeFunction(a, // comment\n" 1067 " b,\n" 1068 " c); // comment", 1069 format("SomeFunction(a, // comment\n" 1070 " b,\n" 1071 " c); // comment")); 1072 } 1073 1074 TEST_F(FormatTest, CanFormatCommentsLocally) { 1075 EXPECT_EQ("int a; // comment\n" 1076 "int b; // comment", 1077 format("int a; // comment\n" 1078 "int b; // comment", 1079 0, 0, getLLVMStyle())); 1080 EXPECT_EQ("int a; // comment\n" 1081 " // line 2\n" 1082 "int b;", 1083 format("int a; // comment\n" 1084 " // line 2\n" 1085 "int b;", 1086 28, 0, getLLVMStyle())); 1087 EXPECT_EQ("int aaaaaa; // comment\n" 1088 "int b;\n" 1089 "int c; // unrelated comment", 1090 format("int aaaaaa; // comment\n" 1091 "int b;\n" 1092 "int c; // unrelated comment", 1093 31, 0, getLLVMStyle())); 1094 1095 EXPECT_EQ("int a; // This\n" 1096 " // is\n" 1097 " // a", 1098 format("int a; // This\n" 1099 " // is\n" 1100 " // a", 1101 0, 0, getLLVMStyle())); 1102 EXPECT_EQ("int a; // This\n" 1103 " // is\n" 1104 " // a\n" 1105 "// This is b\n" 1106 "int b;", 1107 format("int a; // This\n" 1108 " // is\n" 1109 " // a\n" 1110 "// This is b\n" 1111 "int b;", 1112 0, 0, getLLVMStyle())); 1113 EXPECT_EQ("int a; // This\n" 1114 " // is\n" 1115 " // a\n" 1116 "\n" 1117 " // This is unrelated", 1118 format("int a; // This\n" 1119 " // is\n" 1120 " // a\n" 1121 "\n" 1122 " // This is unrelated", 1123 0, 0, getLLVMStyle())); 1124 EXPECT_EQ("int a;\n" 1125 "// This is\n" 1126 "// not formatted. ", 1127 format("int a;\n" 1128 "// This is\n" 1129 "// not formatted. ", 1130 0, 0, getLLVMStyle())); 1131 } 1132 1133 TEST_F(FormatTest, RemovesTrailingWhitespaceOfComments) { 1134 EXPECT_EQ("// comment", format("// comment ")); 1135 EXPECT_EQ("int aaaaaaa, bbbbbbb; // comment", 1136 format("int aaaaaaa, bbbbbbb; // comment ", 1137 getLLVMStyleWithColumns(33))); 1138 EXPECT_EQ("// comment\\\n", format("// comment\\\n \t \v \f ")); 1139 EXPECT_EQ("// comment \\\n", format("// comment \\\n \t \v \f ")); 1140 } 1141 1142 TEST_F(FormatTest, UnderstandsBlockComments) { 1143 verifyFormat("f(/*noSpaceAfterParameterNamingComment=*/true);"); 1144 verifyFormat("void f() { g(/*aaa=*/x, /*bbb=*/!y); }"); 1145 EXPECT_EQ("f(aaaaaaaaaaaaaaaaaaaaaaaaa, /* Trailing comment for aa... */\n" 1146 " bbbbbbbbbbbbbbbbbbbbbbbbb);", 1147 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \\\n" 1148 "/* Trailing comment for aa... */\n" 1149 " bbbbbbbbbbbbbbbbbbbbbbbbb);")); 1150 EXPECT_EQ( 1151 "f(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 1152 " /* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);", 1153 format("f(aaaaaaaaaaaaaaaaaaaaaaaaa , \n" 1154 "/* Leading comment for bb... */ bbbbbbbbbbbbbbbbbbbbbbbbb);")); 1155 EXPECT_EQ( 1156 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 1157 " aaaaaaaaaaaaaaaaaa,\n" 1158 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 1159 "}", 1160 format("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 1161 " aaaaaaaaaaaaaaaaaa ,\n" 1162 " aaaaaaaaaaaaaaaaaa) { /*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa*/\n" 1163 "}")); 1164 1165 FormatStyle NoBinPacking = getLLVMStyle(); 1166 NoBinPacking.BinPackParameters = false; 1167 verifyFormat("aaaaaaaa(/* parameter 1 */ aaaaaa,\n" 1168 " /* parameter 2 */ aaaaaa,\n" 1169 " /* parameter 3 */ aaaaaa,\n" 1170 " /* parameter 4 */ aaaaaa);", 1171 NoBinPacking); 1172 1173 // Aligning block comments in macros. 1174 verifyGoogleFormat("#define A \\\n" 1175 " int i; /*a*/ \\\n" 1176 " int jjj; /*b*/"); 1177 } 1178 1179 TEST_F(FormatTest, AlignsBlockComments) { 1180 EXPECT_EQ("/*\n" 1181 " * Really multi-line\n" 1182 " * comment.\n" 1183 " */\n" 1184 "void f() {}", 1185 format(" /*\n" 1186 " * Really multi-line\n" 1187 " * comment.\n" 1188 " */\n" 1189 " void f() {}")); 1190 EXPECT_EQ("class C {\n" 1191 " /*\n" 1192 " * Another multi-line\n" 1193 " * comment.\n" 1194 " */\n" 1195 " void f() {}\n" 1196 "};", 1197 format("class C {\n" 1198 "/*\n" 1199 " * Another multi-line\n" 1200 " * comment.\n" 1201 " */\n" 1202 "void f() {}\n" 1203 "};")); 1204 EXPECT_EQ("/*\n" 1205 " 1. This is a comment with non-trivial formatting.\n" 1206 " 1.1. We have to indent/outdent all lines equally\n" 1207 " 1.1.1. to keep the formatting.\n" 1208 " */", 1209 format(" /*\n" 1210 " 1. This is a comment with non-trivial formatting.\n" 1211 " 1.1. We have to indent/outdent all lines equally\n" 1212 " 1.1.1. to keep the formatting.\n" 1213 " */")); 1214 EXPECT_EQ("/*\n" 1215 "Don't try to outdent if there's not enough indentation.\n" 1216 "*/", 1217 format(" /*\n" 1218 " Don't try to outdent if there's not enough indentation.\n" 1219 " */")); 1220 1221 EXPECT_EQ("int i; /* Comment with empty...\n" 1222 " *\n" 1223 " * line. */", 1224 format("int i; /* Comment with empty...\n" 1225 " *\n" 1226 " * line. */")); 1227 EXPECT_EQ("int foobar = 0; /* comment */\n" 1228 "int bar = 0; /* multiline\n" 1229 " comment 1 */\n" 1230 "int baz = 0; /* multiline\n" 1231 " comment 2 */\n" 1232 "int bzz = 0; /* multiline\n" 1233 " comment 3 */", 1234 format("int foobar = 0; /* comment */\n" 1235 "int bar = 0; /* multiline\n" 1236 " comment 1 */\n" 1237 "int baz = 0; /* multiline\n" 1238 " comment 2 */\n" 1239 "int bzz = 0; /* multiline\n" 1240 " comment 3 */")); 1241 EXPECT_EQ("int foobar = 0; /* comment */\n" 1242 "int bar = 0; /* multiline\n" 1243 " comment */\n" 1244 "int baz = 0; /* multiline\n" 1245 "comment */", 1246 format("int foobar = 0; /* comment */\n" 1247 "int bar = 0; /* multiline\n" 1248 "comment */\n" 1249 "int baz = 0; /* multiline\n" 1250 "comment */")); 1251 } 1252 1253 TEST_F(FormatTest, CorrectlyHandlesLengthOfBlockComments) { 1254 EXPECT_EQ("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 1255 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */", 1256 format("double *x; /* aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 1257 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa */")); 1258 EXPECT_EQ( 1259 "void ffffffffffff(\n" 1260 " int aaaaaaaa, int bbbbbbbb,\n" 1261 " int cccccccccccc) { /*\n" 1262 " aaaaaaaaaa\n" 1263 " aaaaaaaaaaaaa\n" 1264 " bbbbbbbbbbbbbb\n" 1265 " bbbbbbbbbb\n" 1266 " */\n" 1267 "}", 1268 format("void ffffffffffff(int aaaaaaaa, int bbbbbbbb, int cccccccccccc)\n" 1269 "{ /*\n" 1270 " aaaaaaaaaa aaaaaaaaaaaaa\n" 1271 " bbbbbbbbbbbbbb bbbbbbbbbb\n" 1272 " */\n" 1273 "}", 1274 getLLVMStyleWithColumns(40))); 1275 } 1276 1277 TEST_F(FormatTest, DontBreakNonTrailingBlockComments) { 1278 EXPECT_EQ("void ffffffffff(\n" 1279 " int aaaaa /* test */);", 1280 format("void ffffffffff(int aaaaa /* test */);", 1281 getLLVMStyleWithColumns(35))); 1282 } 1283 1284 TEST_F(FormatTest, SplitsLongCxxComments) { 1285 EXPECT_EQ("// A comment that\n" 1286 "// doesn't fit on\n" 1287 "// one line", 1288 format("// A comment that doesn't fit on one line", 1289 getLLVMStyleWithColumns(20))); 1290 EXPECT_EQ("// a b c d\n" 1291 "// e f g\n" 1292 "// h i j k", 1293 format("// a b c d e f g h i j k", 1294 getLLVMStyleWithColumns(10))); 1295 EXPECT_EQ("// a b c d\n" 1296 "// e f g\n" 1297 "// h i j k", 1298 format("\\\n// a b c d e f g h i j k", 1299 getLLVMStyleWithColumns(10))); 1300 EXPECT_EQ("if (true) // A comment that\n" 1301 " // doesn't fit on\n" 1302 " // one line", 1303 format("if (true) // A comment that doesn't fit on one line ", 1304 getLLVMStyleWithColumns(30))); 1305 EXPECT_EQ("// Don't_touch_leading_whitespace", 1306 format("// Don't_touch_leading_whitespace", 1307 getLLVMStyleWithColumns(20))); 1308 EXPECT_EQ("// Add leading\n" 1309 "// whitespace", 1310 format("//Add leading whitespace", getLLVMStyleWithColumns(20))); 1311 EXPECT_EQ("// whitespace", format("//whitespace", getLLVMStyle())); 1312 EXPECT_EQ("// Even if it makes the line exceed the column\n" 1313 "// limit", 1314 format("//Even if it makes the line exceed the column limit", 1315 getLLVMStyleWithColumns(51))); 1316 EXPECT_EQ("//--But not here", format("//--But not here", getLLVMStyle())); 1317 1318 EXPECT_EQ("// aa bb cc dd", 1319 format("// aa bb cc dd ", 1320 getLLVMStyleWithColumns(15))); 1321 1322 EXPECT_EQ("// A comment before\n" 1323 "// a macro\n" 1324 "// definition\n" 1325 "#define a b", 1326 format("// A comment before a macro definition\n" 1327 "#define a b", 1328 getLLVMStyleWithColumns(20))); 1329 EXPECT_EQ("void ffffff(\n" 1330 " int aaaaaaaaa, // wwww\n" 1331 " int bbbbbbbbbb, // xxxxxxx\n" 1332 " // yyyyyyyyyy\n" 1333 " int c, int d, int e) {}", 1334 format("void ffffff(\n" 1335 " int aaaaaaaaa, // wwww\n" 1336 " int bbbbbbbbbb, // xxxxxxx yyyyyyyyyy\n" 1337 " int c, int d, int e) {}", 1338 getLLVMStyleWithColumns(40))); 1339 EXPECT_EQ("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1340 format("//\t aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1341 getLLVMStyleWithColumns(20))); 1342 EXPECT_EQ( 1343 "#define XXX // a b c d\n" 1344 " // e f g h", 1345 format("#define XXX // a b c d e f g h", getLLVMStyleWithColumns(22))); 1346 EXPECT_EQ( 1347 "#define XXX // q w e r\n" 1348 " // t y u i", 1349 format("#define XXX //q w e r t y u i", getLLVMStyleWithColumns(22))); 1350 } 1351 1352 TEST_F(FormatTest, PreservesHangingIndentInCxxComments) { 1353 EXPECT_EQ("// A comment\n" 1354 "// that doesn't\n" 1355 "// fit on one\n" 1356 "// line", 1357 format("// A comment that doesn't fit on one line", 1358 getLLVMStyleWithColumns(20))); 1359 EXPECT_EQ("/// A comment\n" 1360 "/// that doesn't\n" 1361 "/// fit on one\n" 1362 "/// line", 1363 format("/// A comment that doesn't fit on one line", 1364 getLLVMStyleWithColumns(20))); 1365 } 1366 1367 TEST_F(FormatTest, DontSplitLineCommentsWithEscapedNewlines) { 1368 EXPECT_EQ("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1369 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1370 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 1371 format("// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1372 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 1373 "// aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")); 1374 EXPECT_EQ("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1375 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1376 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1377 format("int a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1378 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1379 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1380 getLLVMStyleWithColumns(50))); 1381 // FIXME: One day we might want to implement adjustment of leading whitespace 1382 // of the consecutive lines in this kind of comment: 1383 EXPECT_EQ("double\n" 1384 " a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1385 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1386 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1387 format("double a; // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1388 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\\\n" 1389 " // AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA", 1390 getLLVMStyleWithColumns(49))); 1391 } 1392 1393 TEST_F(FormatTest, DontSplitLineCommentsWithPragmas) { 1394 FormatStyle Pragmas = getLLVMStyleWithColumns(30); 1395 Pragmas.CommentPragmas = "^ IWYU pragma:"; 1396 EXPECT_EQ( 1397 "// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", 1398 format("// IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb", Pragmas)); 1399 EXPECT_EQ( 1400 "/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", 1401 format("/* IWYU pragma: aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb */", Pragmas)); 1402 } 1403 1404 TEST_F(FormatTest, PriorityOfCommentBreaking) { 1405 EXPECT_EQ("if (xxx ==\n" 1406 " yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1407 " zzz)\n" 1408 " q();", 1409 format("if (xxx == yyy && // aaaaaaaaaaaa bbbbbbbbb\n" 1410 " zzz) q();", 1411 getLLVMStyleWithColumns(40))); 1412 EXPECT_EQ("if (xxxxxxxxxx ==\n" 1413 " yyy && // aaaaaa bbbbbbbb cccc\n" 1414 " zzz)\n" 1415 " q();", 1416 format("if (xxxxxxxxxx == yyy && // aaaaaa bbbbbbbb cccc\n" 1417 " zzz) q();", 1418 getLLVMStyleWithColumns(40))); 1419 EXPECT_EQ("if (xxxxxxxxxx &&\n" 1420 " yyy || // aaaaaa bbbbbbbb cccc\n" 1421 " zzz)\n" 1422 " q();", 1423 format("if (xxxxxxxxxx && yyy || // aaaaaa bbbbbbbb cccc\n" 1424 " zzz) q();", 1425 getLLVMStyleWithColumns(40))); 1426 EXPECT_EQ("fffffffff(\n" 1427 " &xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1428 " zzz);", 1429 format("fffffffff(&xxx, // aaaaaaaaaaaa bbbbbbbbbbb\n" 1430 " zzz);", 1431 getLLVMStyleWithColumns(40))); 1432 } 1433 1434 TEST_F(FormatTest, MultiLineCommentsInDefines) { 1435 EXPECT_EQ("#define A(x) /* \\\n" 1436 " a comment \\\n" 1437 " inside */ \\\n" 1438 " f();", 1439 format("#define A(x) /* \\\n" 1440 " a comment \\\n" 1441 " inside */ \\\n" 1442 " f();", 1443 getLLVMStyleWithColumns(17))); 1444 EXPECT_EQ("#define A( \\\n" 1445 " x) /* \\\n" 1446 " a comment \\\n" 1447 " inside */ \\\n" 1448 " f();", 1449 format("#define A( \\\n" 1450 " x) /* \\\n" 1451 " a comment \\\n" 1452 " inside */ \\\n" 1453 " f();", 1454 getLLVMStyleWithColumns(17))); 1455 } 1456 1457 TEST_F(FormatTest, ParsesCommentsAdjacentToPPDirectives) { 1458 EXPECT_EQ("namespace {}\n// Test\n#define A", 1459 format("namespace {}\n // Test\n#define A")); 1460 EXPECT_EQ("namespace {}\n/* Test */\n#define A", 1461 format("namespace {}\n /* Test */\n#define A")); 1462 EXPECT_EQ("namespace {}\n/* Test */ #define A", 1463 format("namespace {}\n /* Test */ #define A")); 1464 } 1465 1466 TEST_F(FormatTest, SplitsLongLinesInComments) { 1467 EXPECT_EQ("/* This is a long\n" 1468 " * comment that\n" 1469 " * doesn't\n" 1470 " * fit on one line.\n" 1471 " */", 1472 format("/* " 1473 "This is a long " 1474 "comment that " 1475 "doesn't " 1476 "fit on one line. */", 1477 getLLVMStyleWithColumns(20))); 1478 EXPECT_EQ("/* a b c d\n" 1479 " * e f g\n" 1480 " * h i j k\n" 1481 " */", 1482 format("/* a b c d e f g h i j k */", 1483 getLLVMStyleWithColumns(10))); 1484 EXPECT_EQ("/* a b c d\n" 1485 " * e f g\n" 1486 " * h i j k\n" 1487 " */", 1488 format("\\\n/* a b c d e f g h i j k */", 1489 getLLVMStyleWithColumns(10))); 1490 EXPECT_EQ("/*\n" 1491 "This is a long\n" 1492 "comment that doesn't\n" 1493 "fit on one line.\n" 1494 "*/", 1495 format("/*\n" 1496 "This is a long " 1497 "comment that doesn't " 1498 "fit on one line. \n" 1499 "*/", getLLVMStyleWithColumns(20))); 1500 EXPECT_EQ("/*\n" 1501 " * This is a long\n" 1502 " * comment that\n" 1503 " * doesn't fit on\n" 1504 " * one line.\n" 1505 " */", 1506 format("/* \n" 1507 " * This is a long " 1508 " comment that " 1509 " doesn't fit on " 1510 " one line. \n" 1511 " */", getLLVMStyleWithColumns(20))); 1512 EXPECT_EQ("/*\n" 1513 " * This_is_a_comment_with_words_that_dont_fit_on_one_line\n" 1514 " * so_it_should_be_broken\n" 1515 " * wherever_a_space_occurs\n" 1516 " */", 1517 format("/*\n" 1518 " * This_is_a_comment_with_words_that_dont_fit_on_one_line " 1519 " so_it_should_be_broken " 1520 " wherever_a_space_occurs \n" 1521 " */", 1522 getLLVMStyleWithColumns(20))); 1523 EXPECT_EQ("/*\n" 1524 " * This_comment_can_not_be_broken_into_lines\n" 1525 " */", 1526 format("/*\n" 1527 " * This_comment_can_not_be_broken_into_lines\n" 1528 " */", 1529 getLLVMStyleWithColumns(20))); 1530 EXPECT_EQ("{\n" 1531 " /*\n" 1532 " This is another\n" 1533 " long comment that\n" 1534 " doesn't fit on one\n" 1535 " line 1234567890\n" 1536 " */\n" 1537 "}", 1538 format("{\n" 1539 "/*\n" 1540 "This is another " 1541 " long comment that " 1542 " doesn't fit on one" 1543 " line 1234567890\n" 1544 "*/\n" 1545 "}", getLLVMStyleWithColumns(20))); 1546 EXPECT_EQ("{\n" 1547 " /*\n" 1548 " * This i s\n" 1549 " * another comment\n" 1550 " * t hat doesn' t\n" 1551 " * fit on one l i\n" 1552 " * n e\n" 1553 " */\n" 1554 "}", 1555 format("{\n" 1556 "/*\n" 1557 " * This i s" 1558 " another comment" 1559 " t hat doesn' t" 1560 " fit on one l i" 1561 " n e\n" 1562 " */\n" 1563 "}", getLLVMStyleWithColumns(20))); 1564 EXPECT_EQ("/*\n" 1565 " * This is a long\n" 1566 " * comment that\n" 1567 " * doesn't fit on\n" 1568 " * one line\n" 1569 " */", 1570 format(" /*\n" 1571 " * This is a long comment that doesn't fit on one line\n" 1572 " */", getLLVMStyleWithColumns(20))); 1573 EXPECT_EQ("{\n" 1574 " if (something) /* This is a\n" 1575 " long\n" 1576 " comment */\n" 1577 " ;\n" 1578 "}", 1579 format("{\n" 1580 " if (something) /* This is a long comment */\n" 1581 " ;\n" 1582 "}", 1583 getLLVMStyleWithColumns(30))); 1584 1585 EXPECT_EQ("/* A comment before\n" 1586 " * a macro\n" 1587 " * definition */\n" 1588 "#define a b", 1589 format("/* A comment before a macro definition */\n" 1590 "#define a b", 1591 getLLVMStyleWithColumns(20))); 1592 1593 EXPECT_EQ("/* some comment\n" 1594 " * a comment\n" 1595 "* that we break\n" 1596 " * another comment\n" 1597 "* we have to break\n" 1598 "* a left comment\n" 1599 " */", 1600 format(" /* some comment\n" 1601 " * a comment that we break\n" 1602 " * another comment we have to break\n" 1603 "* a left comment\n" 1604 " */", 1605 getLLVMStyleWithColumns(20))); 1606 1607 EXPECT_EQ("/*\n" 1608 "\n" 1609 "\n" 1610 " */\n", 1611 format(" /* \n" 1612 " \n" 1613 " \n" 1614 " */\n")); 1615 1616 EXPECT_EQ("/* a a */", 1617 format("/* a a */", getLLVMStyleWithColumns(15))); 1618 EXPECT_EQ("/* a a bc */", 1619 format("/* a a bc */", getLLVMStyleWithColumns(15))); 1620 EXPECT_EQ("/* aaa aaa\n" 1621 " * aaaaa */", 1622 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1623 EXPECT_EQ("/* aaa aaa\n" 1624 " * aaaaa */", 1625 format("/* aaa aaa aaaaa */", getLLVMStyleWithColumns(15))); 1626 } 1627 1628 TEST_F(FormatTest, SplitsLongLinesInCommentsInPreprocessor) { 1629 EXPECT_EQ("#define X \\\n" 1630 " /* \\\n" 1631 " Test \\\n" 1632 " Macro comment \\\n" 1633 " with a long \\\n" 1634 " line \\\n" 1635 " */ \\\n" 1636 " A + B", 1637 format("#define X \\\n" 1638 " /*\n" 1639 " Test\n" 1640 " Macro comment with a long line\n" 1641 " */ \\\n" 1642 " A + B", 1643 getLLVMStyleWithColumns(20))); 1644 EXPECT_EQ("#define X \\\n" 1645 " /* Macro comment \\\n" 1646 " with a long \\\n" 1647 " line */ \\\n" 1648 " A + B", 1649 format("#define X \\\n" 1650 " /* Macro comment with a long\n" 1651 " line */ \\\n" 1652 " A + B", 1653 getLLVMStyleWithColumns(20))); 1654 EXPECT_EQ("#define X \\\n" 1655 " /* Macro comment \\\n" 1656 " * with a long \\\n" 1657 " * line */ \\\n" 1658 " A + B", 1659 format("#define X \\\n" 1660 " /* Macro comment with a long line */ \\\n" 1661 " A + B", 1662 getLLVMStyleWithColumns(20))); 1663 } 1664 1665 TEST_F(FormatTest, CommentsInStaticInitializers) { 1666 EXPECT_EQ( 1667 "static SomeType type = {aaaaaaaaaaaaaaaaaaaa, /* comment */\n" 1668 " aaaaaaaaaaaaaaaaaaaa /* comment */,\n" 1669 " /* comment */ aaaaaaaaaaaaaaaaaaaa,\n" 1670 " aaaaaaaaaaaaaaaaaaaa, // comment\n" 1671 " aaaaaaaaaaaaaaaaaaaa};", 1672 format("static SomeType type = { aaaaaaaaaaaaaaaaaaaa , /* comment */\n" 1673 " aaaaaaaaaaaaaaaaaaaa /* comment */ ,\n" 1674 " /* comment */ aaaaaaaaaaaaaaaaaaaa ,\n" 1675 " aaaaaaaaaaaaaaaaaaaa , // comment\n" 1676 " aaaaaaaaaaaaaaaaaaaa };")); 1677 verifyFormat("static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1678 " bbbbbbbbbbb, ccccccccccc};"); 1679 verifyFormat("static SomeType type = {aaaaaaaaaaa,\n" 1680 " // comment for bb....\n" 1681 " bbbbbbbbbbb, ccccccccccc};"); 1682 verifyGoogleFormat( 1683 "static SomeType type = {aaaaaaaaaaa, // comment for aa...\n" 1684 " bbbbbbbbbbb, ccccccccccc};"); 1685 verifyGoogleFormat("static SomeType type = {aaaaaaaaaaa,\n" 1686 " // comment for bb....\n" 1687 " bbbbbbbbbbb, ccccccccccc};"); 1688 1689 verifyFormat("S s = {{a, b, c}, // Group #1\n" 1690 " {d, e, f}, // Group #2\n" 1691 " {g, h, i}}; // Group #3"); 1692 verifyFormat("S s = {{// Group #1\n" 1693 " a, b, c},\n" 1694 " {// Group #2\n" 1695 " d, e, f},\n" 1696 " {// Group #3\n" 1697 " g, h, i}};"); 1698 1699 EXPECT_EQ("S s = {\n" 1700 " // Some comment\n" 1701 " a,\n" 1702 "\n" 1703 " // Comment after empty line\n" 1704 " b}", 1705 format("S s = {\n" 1706 " // Some comment\n" 1707 " a,\n" 1708 " \n" 1709 " // Comment after empty line\n" 1710 " b\n" 1711 "}")); 1712 EXPECT_EQ("S s = {\n" 1713 " /* Some comment */\n" 1714 " a,\n" 1715 "\n" 1716 " /* Comment after empty line */\n" 1717 " b}", 1718 format("S s = {\n" 1719 " /* Some comment */\n" 1720 " a,\n" 1721 " \n" 1722 " /* Comment after empty line */\n" 1723 " b\n" 1724 "}")); 1725 verifyFormat("const uint8_t aaaaaaaaaaaaaaaaaaaaaa[0] = {\n" 1726 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1727 " 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" 1728 " 0x00, 0x00, 0x00, 0x00}; // comment\n"); 1729 } 1730 1731 TEST_F(FormatTest, IgnoresIf0Contents) { 1732 EXPECT_EQ("#if 0\n" 1733 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1734 "#endif\n" 1735 "void f() {}", 1736 format("#if 0\n" 1737 "}{)(&*(^%%#%@! fsadj f;ldjs ,:;| <<<>>>][)(][\n" 1738 "#endif\n" 1739 "void f( ) { }")); 1740 EXPECT_EQ("#if false\n" 1741 "void f( ) { }\n" 1742 "#endif\n" 1743 "void g() {}\n", 1744 format("#if false\n" 1745 "void f( ) { }\n" 1746 "#endif\n" 1747 "void g( ) { }\n")); 1748 EXPECT_EQ("enum E {\n" 1749 " One,\n" 1750 " Two,\n" 1751 "#if 0\n" 1752 "Three,\n" 1753 " Four,\n" 1754 "#endif\n" 1755 " Five\n" 1756 "};", 1757 format("enum E {\n" 1758 " One,Two,\n" 1759 "#if 0\n" 1760 "Three,\n" 1761 " Four,\n" 1762 "#endif\n" 1763 " Five};")); 1764 EXPECT_EQ("enum F {\n" 1765 " One,\n" 1766 "#if 1\n" 1767 " Two,\n" 1768 "#if 0\n" 1769 "Three,\n" 1770 " Four,\n" 1771 "#endif\n" 1772 " Five\n" 1773 "#endif\n" 1774 "};", 1775 format("enum F {\n" 1776 "One,\n" 1777 "#if 1\n" 1778 "Two,\n" 1779 "#if 0\n" 1780 "Three,\n" 1781 " Four,\n" 1782 "#endif\n" 1783 "Five\n" 1784 "#endif\n" 1785 "};")); 1786 EXPECT_EQ("enum G {\n" 1787 " One,\n" 1788 "#if 0\n" 1789 "Two,\n" 1790 "#else\n" 1791 " Three,\n" 1792 "#endif\n" 1793 " Four\n" 1794 "};", 1795 format("enum G {\n" 1796 "One,\n" 1797 "#if 0\n" 1798 "Two,\n" 1799 "#else\n" 1800 "Three,\n" 1801 "#endif\n" 1802 "Four\n" 1803 "};")); 1804 EXPECT_EQ("enum H {\n" 1805 " One,\n" 1806 "#if 0\n" 1807 "#ifdef Q\n" 1808 "Two,\n" 1809 "#else\n" 1810 "Three,\n" 1811 "#endif\n" 1812 "#endif\n" 1813 " Four\n" 1814 "};", 1815 format("enum H {\n" 1816 "One,\n" 1817 "#if 0\n" 1818 "#ifdef Q\n" 1819 "Two,\n" 1820 "#else\n" 1821 "Three,\n" 1822 "#endif\n" 1823 "#endif\n" 1824 "Four\n" 1825 "};")); 1826 EXPECT_EQ("enum I {\n" 1827 " One,\n" 1828 "#if /* test */ 0 || 1\n" 1829 "Two,\n" 1830 "Three,\n" 1831 "#endif\n" 1832 " Four\n" 1833 "};", 1834 format("enum I {\n" 1835 "One,\n" 1836 "#if /* test */ 0 || 1\n" 1837 "Two,\n" 1838 "Three,\n" 1839 "#endif\n" 1840 "Four\n" 1841 "};")); 1842 EXPECT_EQ("enum J {\n" 1843 " One,\n" 1844 "#if 0\n" 1845 "#if 0\n" 1846 "Two,\n" 1847 "#else\n" 1848 "Three,\n" 1849 "#endif\n" 1850 "Four,\n" 1851 "#endif\n" 1852 " Five\n" 1853 "};", 1854 format("enum J {\n" 1855 "One,\n" 1856 "#if 0\n" 1857 "#if 0\n" 1858 "Two,\n" 1859 "#else\n" 1860 "Three,\n" 1861 "#endif\n" 1862 "Four,\n" 1863 "#endif\n" 1864 "Five\n" 1865 "};")); 1866 1867 } 1868 1869 //===----------------------------------------------------------------------===// 1870 // Tests for classes, namespaces, etc. 1871 //===----------------------------------------------------------------------===// 1872 1873 TEST_F(FormatTest, DoesNotBreakSemiAfterClassDecl) { 1874 verifyFormat("class A {};"); 1875 } 1876 1877 TEST_F(FormatTest, UnderstandsAccessSpecifiers) { 1878 verifyFormat("class A {\n" 1879 "public:\n" 1880 "public: // comment\n" 1881 "protected:\n" 1882 "private:\n" 1883 " void f() {}\n" 1884 "};"); 1885 verifyGoogleFormat("class A {\n" 1886 " public:\n" 1887 " protected:\n" 1888 " private:\n" 1889 " void f() {}\n" 1890 "};"); 1891 verifyFormat("class A {\n" 1892 "public slots:\n" 1893 " void f() {}\n" 1894 "public Q_SLOTS:\n" 1895 " void f() {}\n" 1896 "};"); 1897 } 1898 1899 TEST_F(FormatTest, SeparatesLogicalBlocks) { 1900 EXPECT_EQ("class A {\n" 1901 "public:\n" 1902 " void f();\n" 1903 "\n" 1904 "private:\n" 1905 " void g() {}\n" 1906 " // test\n" 1907 "protected:\n" 1908 " int h;\n" 1909 "};", 1910 format("class A {\n" 1911 "public:\n" 1912 "void f();\n" 1913 "private:\n" 1914 "void g() {}\n" 1915 "// test\n" 1916 "protected:\n" 1917 "int h;\n" 1918 "};")); 1919 EXPECT_EQ("class A {\n" 1920 "protected:\n" 1921 "public:\n" 1922 " void f();\n" 1923 "};", 1924 format("class A {\n" 1925 "protected:\n" 1926 "\n" 1927 "public:\n" 1928 "\n" 1929 " void f();\n" 1930 "};")); 1931 } 1932 1933 TEST_F(FormatTest, FormatsClasses) { 1934 verifyFormat("class A : public B {};"); 1935 verifyFormat("class A : public ::B {};"); 1936 1937 verifyFormat( 1938 "class AAAAAAAAAAAAAAAAAAAA : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1939 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1940 verifyFormat("class AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA\n" 1941 " : public BBBBBBBBBBBBBBBBBBBBBBBBBBBBBB,\n" 1942 " public CCCCCCCCCCCCCCCCCCCCCCCCCCCCCC {};"); 1943 verifyFormat( 1944 "class A : public B, public C, public D, public E, public F {};"); 1945 verifyFormat("class AAAAAAAAAAAA : public B,\n" 1946 " public C,\n" 1947 " public D,\n" 1948 " public E,\n" 1949 " public F,\n" 1950 " public G {};"); 1951 1952 verifyFormat("class\n" 1953 " ReallyReallyLongClassName {\n" 1954 " int i;\n" 1955 "};", 1956 getLLVMStyleWithColumns(32)); 1957 verifyFormat("struct aaaaaaaaaaaaa : public aaaaaaaaaaaaaaaaaaa< // break\n" 1958 " aaaaaaaaaaaaaaaa> {};"); 1959 verifyFormat("struct aaaaaaaaaaaaaaaaaaaa\n" 1960 " : public aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaa,\n" 1961 " aaaaaaaaaaaaaaaaaaaaaa> {};"); 1962 verifyFormat("template <class R, class C>\n" 1963 "struct Aaaaaaaaaaaaaaaaa<R (C::*)(int) const>\n" 1964 " : Aaaaaaaaaaaaaaaaa<R (C::*)(int)> {};"); 1965 verifyFormat("class ::A::B {};"); 1966 } 1967 1968 TEST_F(FormatTest, FormatsVariableDeclarationsAfterStructOrClass) { 1969 verifyFormat("class A {\n} a, b;"); 1970 verifyFormat("struct A {\n} a, b;"); 1971 verifyFormat("union A {\n} a;"); 1972 } 1973 1974 TEST_F(FormatTest, FormatsEnum) { 1975 verifyFormat("enum {\n" 1976 " Zero,\n" 1977 " One = 1,\n" 1978 " Two = One + 1,\n" 1979 " Three = (One + Two),\n" 1980 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1981 " Five = (One, Two, Three, Four, 5)\n" 1982 "};"); 1983 verifyGoogleFormat("enum {\n" 1984 " Zero,\n" 1985 " One = 1,\n" 1986 " Two = One + 1,\n" 1987 " Three = (One + Two),\n" 1988 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 1989 " Five = (One, Two, Three, Four, 5)\n" 1990 "};"); 1991 verifyFormat("enum Enum {};"); 1992 verifyFormat("enum {};"); 1993 verifyFormat("enum X E {} d;"); 1994 verifyFormat("enum __attribute__((...)) E {} d;"); 1995 verifyFormat("enum __declspec__((...)) E {} d;"); 1996 verifyFormat("enum X f() {\n a();\n return 42;\n}"); 1997 verifyFormat("enum {\n" 1998 " Bar = Foo<int, int>::value\n" 1999 "};", 2000 getLLVMStyleWithColumns(30)); 2001 2002 verifyFormat("enum ShortEnum { A, B, C };"); 2003 verifyGoogleFormat("enum ShortEnum { A, B, C };"); 2004 2005 EXPECT_EQ("enum KeepEmptyLines {\n" 2006 " ONE,\n" 2007 "\n" 2008 " TWO,\n" 2009 "\n" 2010 " THREE\n" 2011 "}", 2012 format("enum KeepEmptyLines {\n" 2013 " ONE,\n" 2014 "\n" 2015 " TWO,\n" 2016 "\n" 2017 "\n" 2018 " THREE\n" 2019 "}")); 2020 verifyFormat("enum E { // comment\n" 2021 " ONE,\n" 2022 " TWO\n" 2023 "};\n" 2024 "int i;"); 2025 } 2026 2027 TEST_F(FormatTest, FormatsEnumsWithErrors) { 2028 verifyFormat("enum Type {\n" 2029 " One = 0; // These semicolons should be commas.\n" 2030 " Two = 1;\n" 2031 "};"); 2032 verifyFormat("namespace n {\n" 2033 "enum Type {\n" 2034 " One,\n" 2035 " Two, // missing };\n" 2036 " int i;\n" 2037 "}\n" 2038 "void g() {}"); 2039 } 2040 2041 TEST_F(FormatTest, FormatsEnumStruct) { 2042 verifyFormat("enum struct {\n" 2043 " Zero,\n" 2044 " One = 1,\n" 2045 " Two = One + 1,\n" 2046 " Three = (One + Two),\n" 2047 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 2048 " Five = (One, Two, Three, Four, 5)\n" 2049 "};"); 2050 verifyFormat("enum struct Enum {};"); 2051 verifyFormat("enum struct {};"); 2052 verifyFormat("enum struct X E {} d;"); 2053 verifyFormat("enum struct __attribute__((...)) E {} d;"); 2054 verifyFormat("enum struct __declspec__((...)) E {} d;"); 2055 verifyFormat("enum struct X f() {\n a();\n return 42;\n}"); 2056 } 2057 2058 TEST_F(FormatTest, FormatsEnumClass) { 2059 verifyFormat("enum class {\n" 2060 " Zero,\n" 2061 " One = 1,\n" 2062 " Two = One + 1,\n" 2063 " Three = (One + Two),\n" 2064 " Four = (Zero && (One ^ Two)) | (One << Two),\n" 2065 " Five = (One, Two, Three, Four, 5)\n" 2066 "};"); 2067 verifyFormat("enum class Enum {};"); 2068 verifyFormat("enum class {};"); 2069 verifyFormat("enum class X E {} d;"); 2070 verifyFormat("enum class __attribute__((...)) E {} d;"); 2071 verifyFormat("enum class __declspec__((...)) E {} d;"); 2072 verifyFormat("enum class X f() {\n a();\n return 42;\n}"); 2073 } 2074 2075 TEST_F(FormatTest, FormatsEnumTypes) { 2076 verifyFormat("enum X : int {\n" 2077 " A, // Force multiple lines.\n" 2078 " B\n" 2079 "};"); 2080 verifyFormat("enum X : int { A, B };"); 2081 verifyFormat("enum X : std::uint32_t { A, B };"); 2082 } 2083 2084 TEST_F(FormatTest, FormatsNSEnums) { 2085 verifyGoogleFormat("typedef NS_ENUM(NSInteger, SomeName) { AAA, BBB }"); 2086 verifyGoogleFormat("typedef NS_ENUM(NSInteger, MyType) {\n" 2087 " // Information about someDecentlyLongValue.\n" 2088 " someDecentlyLongValue,\n" 2089 " // Information about anotherDecentlyLongValue.\n" 2090 " anotherDecentlyLongValue,\n" 2091 " // Information about aThirdDecentlyLongValue.\n" 2092 " aThirdDecentlyLongValue\n" 2093 "};"); 2094 verifyGoogleFormat("typedef NS_OPTIONS(NSInteger, MyType) {\n" 2095 " a = 1,\n" 2096 " b = 2,\n" 2097 " c = 3,\n" 2098 "};"); 2099 verifyGoogleFormat("typedef CF_ENUM(NSInteger, MyType) {\n" 2100 " a = 1,\n" 2101 " b = 2,\n" 2102 " c = 3,\n" 2103 "};"); 2104 verifyGoogleFormat("typedef CF_OPTIONS(NSInteger, MyType) {\n" 2105 " a = 1,\n" 2106 " b = 2,\n" 2107 " c = 3,\n" 2108 "};"); 2109 } 2110 2111 TEST_F(FormatTest, FormatsBitfields) { 2112 verifyFormat("struct Bitfields {\n" 2113 " unsigned sClass : 8;\n" 2114 " unsigned ValueKind : 2;\n" 2115 "};"); 2116 verifyFormat("struct A {\n" 2117 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa : 1,\n" 2118 " bbbbbbbbbbbbbbbbbbbbbbbbb;\n" 2119 "};"); 2120 } 2121 2122 TEST_F(FormatTest, FormatsNamespaces) { 2123 verifyFormat("namespace some_namespace {\n" 2124 "class A {};\n" 2125 "void f() { f(); }\n" 2126 "}"); 2127 verifyFormat("namespace {\n" 2128 "class A {};\n" 2129 "void f() { f(); }\n" 2130 "}"); 2131 verifyFormat("inline namespace X {\n" 2132 "class A {};\n" 2133 "void f() { f(); }\n" 2134 "}"); 2135 verifyFormat("using namespace some_namespace;\n" 2136 "class A {};\n" 2137 "void f() { f(); }"); 2138 2139 // This code is more common than we thought; if we 2140 // layout this correctly the semicolon will go into 2141 // its own line, which is undesirable. 2142 verifyFormat("namespace {};"); 2143 verifyFormat("namespace {\n" 2144 "class A {};\n" 2145 "};"); 2146 2147 verifyFormat("namespace {\n" 2148 "int SomeVariable = 0; // comment\n" 2149 "} // namespace"); 2150 EXPECT_EQ("#ifndef HEADER_GUARD\n" 2151 "#define HEADER_GUARD\n" 2152 "namespace my_namespace {\n" 2153 "int i;\n" 2154 "} // my_namespace\n" 2155 "#endif // HEADER_GUARD", 2156 format("#ifndef HEADER_GUARD\n" 2157 " #define HEADER_GUARD\n" 2158 " namespace my_namespace {\n" 2159 "int i;\n" 2160 "} // my_namespace\n" 2161 "#endif // HEADER_GUARD")); 2162 2163 FormatStyle Style = getLLVMStyle(); 2164 Style.NamespaceIndentation = FormatStyle::NI_All; 2165 EXPECT_EQ("namespace out {\n" 2166 " int i;\n" 2167 " namespace in {\n" 2168 " int i;\n" 2169 " } // namespace\n" 2170 "} // namespace", 2171 format("namespace out {\n" 2172 "int i;\n" 2173 "namespace in {\n" 2174 "int i;\n" 2175 "} // namespace\n" 2176 "} // namespace", 2177 Style)); 2178 2179 Style.NamespaceIndentation = FormatStyle::NI_Inner; 2180 EXPECT_EQ("namespace out {\n" 2181 "int i;\n" 2182 "namespace in {\n" 2183 " int i;\n" 2184 "} // namespace\n" 2185 "} // namespace", 2186 format("namespace out {\n" 2187 "int i;\n" 2188 "namespace in {\n" 2189 "int i;\n" 2190 "} // namespace\n" 2191 "} // namespace", 2192 Style)); 2193 } 2194 2195 TEST_F(FormatTest, FormatsExternC) { verifyFormat("extern \"C\" {\nint a;"); } 2196 2197 TEST_F(FormatTest, FormatsInlineASM) { 2198 verifyFormat("asm(\"xyz\" : \"=a\"(a), \"=d\"(b) : \"a\"(data));"); 2199 verifyFormat("asm(\"nop\" ::: \"memory\");"); 2200 verifyFormat( 2201 "asm(\"movq\\t%%rbx, %%rsi\\n\\t\"\n" 2202 " \"cpuid\\n\\t\"\n" 2203 " \"xchgq\\t%%rbx, %%rsi\\n\\t\"\n" 2204 " : \"=a\"(*rEAX), \"=S\"(*rEBX), \"=c\"(*rECX), \"=d\"(*rEDX)\n" 2205 " : \"a\"(value));"); 2206 EXPECT_EQ( 2207 "void NS_InvokeByIndex(void *that, unsigned int methodIndex) {\n" 2208 " __asm {\n" 2209 " mov edx,[that] // vtable in edx\n" 2210 " mov eax,methodIndex\n" 2211 " call [edx][eax*4] // stdcall\n" 2212 " }\n" 2213 "}", 2214 format("void NS_InvokeByIndex(void *that, unsigned int methodIndex) {\n" 2215 " __asm {\n" 2216 " mov edx,[that] // vtable in edx\n" 2217 " mov eax,methodIndex\n" 2218 " call [edx][eax*4] // stdcall\n" 2219 " }\n" 2220 "}")); 2221 verifyFormat("void function() {\n" 2222 " // comment\n" 2223 " asm(\"\");\n" 2224 "}"); 2225 } 2226 2227 TEST_F(FormatTest, FormatTryCatch) { 2228 verifyFormat("try {\n" 2229 " throw a * b;\n" 2230 "} catch (int a) {\n" 2231 " // Do nothing.\n" 2232 "} catch (...) {\n" 2233 " exit(42);\n" 2234 "}"); 2235 2236 // Function-level try statements. 2237 verifyFormat("int f() try { return 4; } catch (...) {\n" 2238 " return 5;\n" 2239 "}"); 2240 verifyFormat("class A {\n" 2241 " int a;\n" 2242 " A() try : a(0) {\n" 2243 " } catch (...) {\n" 2244 " throw;\n" 2245 " }\n" 2246 "};\n"); 2247 2248 // Incomplete try-catch blocks. 2249 verifyFormat("try {} catch ("); 2250 } 2251 2252 TEST_F(FormatTest, FormatSEHTryCatch) { 2253 verifyFormat("__try {\n" 2254 " int a = b * c;\n" 2255 "} __except (EXCEPTION_EXECUTE_HANDLER) {\n" 2256 " // Do nothing.\n" 2257 "}"); 2258 2259 verifyFormat("__try {\n" 2260 " int a = b * c;\n" 2261 "} __finally {\n" 2262 " // Do nothing.\n" 2263 "}"); 2264 2265 verifyFormat("DEBUG({\n" 2266 " __try {\n" 2267 " } __finally {\n" 2268 " }\n" 2269 "});\n"); 2270 } 2271 2272 TEST_F(FormatTest, IncompleteTryCatchBlocks) { 2273 verifyFormat("try {\n" 2274 " f();\n" 2275 "} catch {\n" 2276 " g();\n" 2277 "}"); 2278 verifyFormat("try {\n" 2279 " f();\n" 2280 "} catch (A a) MACRO(x) {\n" 2281 " g();\n" 2282 "} catch (B b) MACRO(x) {\n" 2283 " g();\n" 2284 "}"); 2285 } 2286 2287 TEST_F(FormatTest, FormatTryCatchBraceStyles) { 2288 FormatStyle Style = getLLVMStyle(); 2289 Style.BreakBeforeBraces = FormatStyle::BS_Attach; 2290 verifyFormat("try {\n" 2291 " // something\n" 2292 "} catch (...) {\n" 2293 " // something\n" 2294 "}", 2295 Style); 2296 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 2297 verifyFormat("try {\n" 2298 " // something\n" 2299 "}\n" 2300 "catch (...) {\n" 2301 " // something\n" 2302 "}", 2303 Style); 2304 verifyFormat("__try {\n" 2305 " // something\n" 2306 "}\n" 2307 "__finally {\n" 2308 " // something\n" 2309 "}", 2310 Style); 2311 verifyFormat("@try {\n" 2312 " // something\n" 2313 "}\n" 2314 "@finally {\n" 2315 " // something\n" 2316 "}", 2317 Style); 2318 Style.BreakBeforeBraces = FormatStyle::BS_Allman; 2319 verifyFormat("try\n" 2320 "{\n" 2321 " // something\n" 2322 "}\n" 2323 "catch (...)\n" 2324 "{\n" 2325 " // something\n" 2326 "}", 2327 Style); 2328 Style.BreakBeforeBraces = FormatStyle::BS_GNU; 2329 verifyFormat("try\n" 2330 " {\n" 2331 " // something\n" 2332 " }\n" 2333 "catch (...)\n" 2334 " {\n" 2335 " // something\n" 2336 " }", 2337 Style); 2338 } 2339 2340 TEST_F(FormatTest, FormatObjCTryCatch) { 2341 verifyFormat("@try {\n" 2342 " f();\n" 2343 "} @catch (NSException e) {\n" 2344 " @throw;\n" 2345 "} @finally {\n" 2346 " exit(42);\n" 2347 "}"); 2348 verifyFormat("DEBUG({\n" 2349 " @try {\n" 2350 " } @finally {\n" 2351 " }\n" 2352 "});\n"); 2353 } 2354 2355 TEST_F(FormatTest, StaticInitializers) { 2356 verifyFormat("static SomeClass SC = {1, 'a'};"); 2357 2358 verifyFormat( 2359 "static SomeClass WithALoooooooooooooooooooongName = {\n" 2360 " 100000000, \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"};"); 2361 2362 // Here, everything other than the "}" would fit on a line. 2363 verifyFormat("static int LooooooooooooooooooooooooongVariable[1] = {\n" 2364 " 10000000000000000000000000};"); 2365 EXPECT_EQ("S s = {a,\n" 2366 "\n" 2367 " b};", 2368 format("S s = {\n" 2369 " a,\n" 2370 "\n" 2371 " b\n" 2372 "};")); 2373 2374 // FIXME: This would fit into the column limit if we'd fit "{ {" on the first 2375 // line. However, the formatting looks a bit off and this probably doesn't 2376 // happen often in practice. 2377 verifyFormat("static int Variable[1] = {\n" 2378 " {1000000000000000000000000000000000000}};", 2379 getLLVMStyleWithColumns(40)); 2380 } 2381 2382 TEST_F(FormatTest, DesignatedInitializers) { 2383 verifyFormat("const struct A a = {.a = 1, .b = 2};"); 2384 verifyFormat("const struct A a = {.aaaaaaaaaa = 1,\n" 2385 " .bbbbbbbbbb = 2,\n" 2386 " .cccccccccc = 3,\n" 2387 " .dddddddddd = 4,\n" 2388 " .eeeeeeeeee = 5};"); 2389 verifyFormat("const struct Aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa = {\n" 2390 " .aaaaaaaaaaaaaaaaaaaaaaaaaaa = 1,\n" 2391 " .bbbbbbbbbbbbbbbbbbbbbbbbbbb = 2,\n" 2392 " .ccccccccccccccccccccccccccc = 3,\n" 2393 " .ddddddddddddddddddddddddddd = 4,\n" 2394 " .eeeeeeeeeeeeeeeeeeeeeeeeeee = 5};"); 2395 2396 verifyGoogleFormat("const struct A a = {.a = 1, .b = 2};"); 2397 } 2398 2399 TEST_F(FormatTest, NestedStaticInitializers) { 2400 verifyFormat("static A x = {{{}}};\n"); 2401 verifyFormat("static A x = {{{init1, init2, init3, init4},\n" 2402 " {init1, init2, init3, init4}}};", 2403 getLLVMStyleWithColumns(50)); 2404 2405 verifyFormat("somes Status::global_reps[3] = {\n" 2406 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 2407 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 2408 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};", 2409 getLLVMStyleWithColumns(60)); 2410 verifyGoogleFormat("SomeType Status::global_reps[3] = {\n" 2411 " {kGlobalRef, OK_CODE, NULL, NULL, NULL},\n" 2412 " {kGlobalRef, CANCELLED_CODE, NULL, NULL, NULL},\n" 2413 " {kGlobalRef, UNKNOWN_CODE, NULL, NULL, NULL}};"); 2414 verifyFormat( 2415 "CGRect cg_rect = {{rect.fLeft, rect.fTop},\n" 2416 " {rect.fRight - rect.fLeft, rect.fBottom - rect.fTop}};"); 2417 2418 verifyFormat( 2419 "SomeArrayOfSomeType a = {\n" 2420 " {{1, 2, 3},\n" 2421 " {1, 2, 3},\n" 2422 " {111111111111111111111111111111, 222222222222222222222222222222,\n" 2423 " 333333333333333333333333333333},\n" 2424 " {1, 2, 3},\n" 2425 " {1, 2, 3}}};"); 2426 verifyFormat( 2427 "SomeArrayOfSomeType a = {\n" 2428 " {{1, 2, 3}},\n" 2429 " {{1, 2, 3}},\n" 2430 " {{111111111111111111111111111111, 222222222222222222222222222222,\n" 2431 " 333333333333333333333333333333}},\n" 2432 " {{1, 2, 3}},\n" 2433 " {{1, 2, 3}}};"); 2434 2435 verifyFormat( 2436 "struct {\n" 2437 " unsigned bit;\n" 2438 " const char *const name;\n" 2439 "} kBitsToOs[] = {{kOsMac, \"Mac\"},\n" 2440 " {kOsWin, \"Windows\"},\n" 2441 " {kOsLinux, \"Linux\"},\n" 2442 " {kOsCrOS, \"Chrome OS\"}};"); 2443 verifyFormat( 2444 "struct {\n" 2445 " unsigned bit;\n" 2446 " const char *const name;\n" 2447 "} kBitsToOs[] = {\n" 2448 " {kOsMac, \"Mac\"},\n" 2449 " {kOsWin, \"Windows\"},\n" 2450 " {kOsLinux, \"Linux\"},\n" 2451 " {kOsCrOS, \"Chrome OS\"},\n" 2452 "};"); 2453 } 2454 2455 TEST_F(FormatTest, FormatsSmallMacroDefinitionsInSingleLine) { 2456 verifyFormat("#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2457 " \\\n" 2458 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)"); 2459 } 2460 2461 TEST_F(FormatTest, DoesNotBreakPureVirtualFunctionDefinition) { 2462 verifyFormat("virtual void write(ELFWriter *writerrr,\n" 2463 " OwningPtr<FileOutputBuffer> &buffer) = 0;"); 2464 } 2465 2466 TEST_F(FormatTest, BreaksStringLiteralsOnlyInDefine) { 2467 verifyFormat("# 1111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\" 2 3", 2468 getLLVMStyleWithColumns(40)); 2469 verifyFormat("#line 11111 \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 2470 getLLVMStyleWithColumns(40)); 2471 EXPECT_EQ("#define Q \\\n" 2472 " \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/\" \\\n" 2473 " \"aaaaaaaa.cpp\"", 2474 format("#define Q \"/aaaaaaaaa/aaaaaaaaaaaaaaaaaaa/aaaaaaaa.cpp\"", 2475 getLLVMStyleWithColumns(40))); 2476 } 2477 2478 TEST_F(FormatTest, UnderstandsLinePPDirective) { 2479 EXPECT_EQ("# 123 \"A string literal\"", 2480 format(" # 123 \"A string literal\"")); 2481 } 2482 2483 TEST_F(FormatTest, LayoutUnknownPPDirective) { 2484 EXPECT_EQ("#;", format("#;")); 2485 verifyFormat("#\n;\n;\n;"); 2486 } 2487 2488 TEST_F(FormatTest, UnescapedEndOfLineEndsPPDirective) { 2489 EXPECT_EQ("#line 42 \"test\"\n", 2490 format("# \\\n line \\\n 42 \\\n \"test\"\n")); 2491 EXPECT_EQ("#define A B\n", format("# \\\n define \\\n A \\\n B\n", 2492 getLLVMStyleWithColumns(12))); 2493 } 2494 2495 TEST_F(FormatTest, EndOfFileEndsPPDirective) { 2496 EXPECT_EQ("#line 42 \"test\"", 2497 format("# \\\n line \\\n 42 \\\n \"test\"")); 2498 EXPECT_EQ("#define A B", format("# \\\n define \\\n A \\\n B")); 2499 } 2500 2501 TEST_F(FormatTest, DoesntRemoveUnknownTokens) { 2502 verifyFormat("#define A \\x20"); 2503 verifyFormat("#define A \\ x20"); 2504 EXPECT_EQ("#define A \\ x20", format("#define A \\ x20")); 2505 verifyFormat("#define A ''"); 2506 verifyFormat("#define A ''qqq"); 2507 verifyFormat("#define A `qqq"); 2508 verifyFormat("f(\"aaaa, bbbb, \"\\\"ccccc\\\"\");"); 2509 EXPECT_EQ("const char *c = STRINGIFY(\n" 2510 "\\na : b);", 2511 format("const char * c = STRINGIFY(\n" 2512 "\\na : b);")); 2513 2514 verifyFormat("a\r\\"); 2515 verifyFormat("a\v\\"); 2516 verifyFormat("a\f\\"); 2517 } 2518 2519 TEST_F(FormatTest, IndentsPPDirectiveInReducedSpace) { 2520 verifyFormat("#define A(BB)", getLLVMStyleWithColumns(13)); 2521 verifyFormat("#define A( \\\n BB)", getLLVMStyleWithColumns(12)); 2522 verifyFormat("#define A( \\\n A, B)", getLLVMStyleWithColumns(12)); 2523 // FIXME: We never break before the macro name. 2524 verifyFormat("#define AA( \\\n B)", getLLVMStyleWithColumns(12)); 2525 2526 verifyFormat("#define A A\n#define A A"); 2527 verifyFormat("#define A(X) A\n#define A A"); 2528 2529 verifyFormat("#define Something Other", getLLVMStyleWithColumns(23)); 2530 verifyFormat("#define Something \\\n Other", getLLVMStyleWithColumns(22)); 2531 } 2532 2533 TEST_F(FormatTest, HandlePreprocessorDirectiveContext) { 2534 EXPECT_EQ("// somecomment\n" 2535 "#include \"a.h\"\n" 2536 "#define A( \\\n" 2537 " A, B)\n" 2538 "#include \"b.h\"\n" 2539 "// somecomment\n", 2540 format(" // somecomment\n" 2541 " #include \"a.h\"\n" 2542 "#define A(A,\\\n" 2543 " B)\n" 2544 " #include \"b.h\"\n" 2545 " // somecomment\n", 2546 getLLVMStyleWithColumns(13))); 2547 } 2548 2549 TEST_F(FormatTest, LayoutSingleHash) { EXPECT_EQ("#\na;", format("#\na;")); } 2550 2551 TEST_F(FormatTest, LayoutCodeInMacroDefinitions) { 2552 EXPECT_EQ("#define A \\\n" 2553 " c; \\\n" 2554 " e;\n" 2555 "f;", 2556 format("#define A c; e;\n" 2557 "f;", 2558 getLLVMStyleWithColumns(14))); 2559 } 2560 2561 TEST_F(FormatTest, LayoutRemainingTokens) { EXPECT_EQ("{}", format("{}")); } 2562 2563 TEST_F(FormatTest, AlwaysFormatsEntireMacroDefinitions) { 2564 EXPECT_EQ("int i;\n" 2565 "#define A \\\n" 2566 " int i; \\\n" 2567 " int j\n" 2568 "int k;", 2569 format("int i;\n" 2570 "#define A \\\n" 2571 " int i ; \\\n" 2572 " int j\n" 2573 "int k;", 2574 8, 0, getGoogleStyle())); // 8: position of "#define". 2575 EXPECT_EQ("int i;\n" 2576 "#define A \\\n" 2577 " int i; \\\n" 2578 " int j\n" 2579 "int k;", 2580 format("int i;\n" 2581 "#define A \\\n" 2582 " int i ; \\\n" 2583 " int j\n" 2584 "int k;", 2585 45, 0, getGoogleStyle())); // 45: position of "j". 2586 } 2587 2588 TEST_F(FormatTest, MacroDefinitionInsideStatement) { 2589 EXPECT_EQ("int x,\n" 2590 "#define A\n" 2591 " y;", 2592 format("int x,\n#define A\ny;")); 2593 } 2594 2595 TEST_F(FormatTest, HashInMacroDefinition) { 2596 EXPECT_EQ("#define A(c) L#c", format("#define A(c) L#c", getLLVMStyle())); 2597 verifyFormat("#define A \\\n b #c;", getLLVMStyleWithColumns(11)); 2598 verifyFormat("#define A \\\n" 2599 " { \\\n" 2600 " f(#c); \\\n" 2601 " }", 2602 getLLVMStyleWithColumns(11)); 2603 2604 verifyFormat("#define A(X) \\\n" 2605 " void function##X()", 2606 getLLVMStyleWithColumns(22)); 2607 2608 verifyFormat("#define A(a, b, c) \\\n" 2609 " void a##b##c()", 2610 getLLVMStyleWithColumns(22)); 2611 2612 verifyFormat("#define A void # ## #", getLLVMStyleWithColumns(22)); 2613 } 2614 2615 TEST_F(FormatTest, RespectWhitespaceInMacroDefinitions) { 2616 EXPECT_EQ("#define A (x)", format("#define A (x)")); 2617 EXPECT_EQ("#define A(x)", format("#define A(x)")); 2618 } 2619 2620 TEST_F(FormatTest, EmptyLinesInMacroDefinitions) { 2621 EXPECT_EQ("#define A b;", format("#define A \\\n" 2622 " \\\n" 2623 " b;", 2624 getLLVMStyleWithColumns(25))); 2625 EXPECT_EQ("#define A \\\n" 2626 " \\\n" 2627 " a; \\\n" 2628 " b;", 2629 format("#define A \\\n" 2630 " \\\n" 2631 " a; \\\n" 2632 " b;", 2633 getLLVMStyleWithColumns(11))); 2634 EXPECT_EQ("#define A \\\n" 2635 " a; \\\n" 2636 " \\\n" 2637 " b;", 2638 format("#define A \\\n" 2639 " a; \\\n" 2640 " \\\n" 2641 " b;", 2642 getLLVMStyleWithColumns(11))); 2643 } 2644 2645 TEST_F(FormatTest, MacroDefinitionsWithIncompleteCode) { 2646 verifyFormat("#define A :"); 2647 verifyFormat("#define SOMECASES \\\n" 2648 " case 1: \\\n" 2649 " case 2\n", 2650 getLLVMStyleWithColumns(20)); 2651 verifyFormat("#define A template <typename T>"); 2652 verifyFormat("#define STR(x) #x\n" 2653 "f(STR(this_is_a_string_literal{));"); 2654 verifyFormat("#pragma omp threadprivate( \\\n" 2655 " y)), // expected-warning", 2656 getLLVMStyleWithColumns(28)); 2657 verifyFormat("#d, = };"); 2658 verifyFormat("#if \"a"); 2659 verifyFormat("({\n" 2660 "#define b }\\\n" 2661 " a\n" 2662 "a"); 2663 2664 verifyNoCrash("#if a\na(\n#else\n#endif\n{a"); 2665 verifyNoCrash("a={0,1\n#if a\n#else\n;\n#endif\n}"); 2666 verifyNoCrash("#if a\na(\n#else\n#endif\n) a {a,b,c,d,f,g};"); 2667 verifyNoCrash("#ifdef A\n a(\n #else\n #endif\n) = []() { \n)}"); 2668 } 2669 2670 TEST_F(FormatTest, MacrosWithoutTrailingSemicolon) { 2671 verifyFormat("SOME_TYPE_NAME abc;"); // Gated on the newline. 2672 EXPECT_EQ("class A : public QObject {\n" 2673 " Q_OBJECT\n" 2674 "\n" 2675 " A() {}\n" 2676 "};", 2677 format("class A : public QObject {\n" 2678 " Q_OBJECT\n" 2679 "\n" 2680 " A() {\n}\n" 2681 "} ;")); 2682 EXPECT_EQ("SOME_MACRO\n" 2683 "namespace {\n" 2684 "void f();\n" 2685 "}", 2686 format("SOME_MACRO\n" 2687 " namespace {\n" 2688 "void f( );\n" 2689 "}")); 2690 // Only if the identifier contains at least 5 characters. 2691 EXPECT_EQ("HTTP f();", 2692 format("HTTP\nf();")); 2693 EXPECT_EQ("MACRO\nf();", 2694 format("MACRO\nf();")); 2695 // Only if everything is upper case. 2696 EXPECT_EQ("class A : public QObject {\n" 2697 " Q_Object A() {}\n" 2698 "};", 2699 format("class A : public QObject {\n" 2700 " Q_Object\n" 2701 " A() {\n}\n" 2702 "} ;")); 2703 2704 // Only if the next line can actually start an unwrapped line. 2705 EXPECT_EQ("SOME_WEIRD_LOG_MACRO << SomeThing;", 2706 format("SOME_WEIRD_LOG_MACRO\n" 2707 "<< SomeThing;")); 2708 2709 verifyFormat("VISIT_GL_CALL(GenBuffers, void, (GLsizei n, GLuint* buffers), " 2710 "(n, buffers))\n", getChromiumStyle(FormatStyle::LK_Cpp)); 2711 } 2712 2713 TEST_F(FormatTest, MacroCallsWithoutTrailingSemicolon) { 2714 EXPECT_EQ("INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2715 "INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2716 "INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2717 "class X {};\n" 2718 "INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2719 "int *createScopDetectionPass() { return 0; }", 2720 format(" INITIALIZE_PASS_BEGIN(ScopDetection, \"polly-detect\")\n" 2721 " INITIALIZE_AG_DEPENDENCY(AliasAnalysis)\n" 2722 " INITIALIZE_PASS_DEPENDENCY(DominatorTree)\n" 2723 " class X {};\n" 2724 " INITIALIZE_PASS_END(ScopDetection, \"polly-detect\")\n" 2725 " int *createScopDetectionPass() { return 0; }")); 2726 // FIXME: We could probably treat IPC_BEGIN_MESSAGE_MAP/IPC_END_MESSAGE_MAP as 2727 // braces, so that inner block is indented one level more. 2728 EXPECT_EQ("int q() {\n" 2729 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2730 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2731 " IPC_END_MESSAGE_MAP()\n" 2732 "}", 2733 format("int q() {\n" 2734 " IPC_BEGIN_MESSAGE_MAP(WebKitTestController, message)\n" 2735 " IPC_MESSAGE_HANDLER(xxx, qqq)\n" 2736 " IPC_END_MESSAGE_MAP()\n" 2737 "}")); 2738 2739 // Same inside macros. 2740 EXPECT_EQ("#define LIST(L) \\\n" 2741 " L(A) \\\n" 2742 " L(B) \\\n" 2743 " L(C)", 2744 format("#define LIST(L) \\\n" 2745 " L(A) \\\n" 2746 " L(B) \\\n" 2747 " L(C)", 2748 getGoogleStyle())); 2749 2750 // These must not be recognized as macros. 2751 EXPECT_EQ("int q() {\n" 2752 " f(x);\n" 2753 " f(x) {}\n" 2754 " f(x)->g();\n" 2755 " f(x)->*g();\n" 2756 " f(x).g();\n" 2757 " f(x) = x;\n" 2758 " f(x) += x;\n" 2759 " f(x) -= x;\n" 2760 " f(x) *= x;\n" 2761 " f(x) /= x;\n" 2762 " f(x) %= x;\n" 2763 " f(x) &= x;\n" 2764 " f(x) |= x;\n" 2765 " f(x) ^= x;\n" 2766 " f(x) >>= x;\n" 2767 " f(x) <<= x;\n" 2768 " f(x)[y].z();\n" 2769 " LOG(INFO) << x;\n" 2770 " ifstream(x) >> x;\n" 2771 "}\n", 2772 format("int q() {\n" 2773 " f(x)\n;\n" 2774 " f(x)\n {}\n" 2775 " f(x)\n->g();\n" 2776 " f(x)\n->*g();\n" 2777 " f(x)\n.g();\n" 2778 " f(x)\n = x;\n" 2779 " f(x)\n += x;\n" 2780 " f(x)\n -= x;\n" 2781 " f(x)\n *= x;\n" 2782 " f(x)\n /= x;\n" 2783 " f(x)\n %= x;\n" 2784 " f(x)\n &= x;\n" 2785 " f(x)\n |= x;\n" 2786 " f(x)\n ^= x;\n" 2787 " f(x)\n >>= x;\n" 2788 " f(x)\n <<= x;\n" 2789 " f(x)\n[y].z();\n" 2790 " LOG(INFO)\n << x;\n" 2791 " ifstream(x)\n >> x;\n" 2792 "}\n")); 2793 EXPECT_EQ("int q() {\n" 2794 " F(x)\n" 2795 " if (1) {\n" 2796 " }\n" 2797 " F(x)\n" 2798 " while (1) {\n" 2799 " }\n" 2800 " F(x)\n" 2801 " G(x);\n" 2802 " F(x)\n" 2803 " try {\n" 2804 " Q();\n" 2805 " } catch (...) {\n" 2806 " }\n" 2807 "}\n", 2808 format("int q() {\n" 2809 "F(x)\n" 2810 "if (1) {}\n" 2811 "F(x)\n" 2812 "while (1) {}\n" 2813 "F(x)\n" 2814 "G(x);\n" 2815 "F(x)\n" 2816 "try { Q(); } catch (...) {}\n" 2817 "}\n")); 2818 EXPECT_EQ("class A {\n" 2819 " A() : t(0) {}\n" 2820 " A(int i) noexcept() : {}\n" 2821 " A(X x)\n" // FIXME: function-level try blocks are broken. 2822 " try : t(0) {\n" 2823 " } catch (...) {\n" 2824 " }\n" 2825 "};", 2826 format("class A {\n" 2827 " A()\n : t(0) {}\n" 2828 " A(int i)\n noexcept() : {}\n" 2829 " A(X x)\n" 2830 " try : t(0) {} catch (...) {}\n" 2831 "};")); 2832 EXPECT_EQ( 2833 "class SomeClass {\n" 2834 "public:\n" 2835 " SomeClass() EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2836 "};", 2837 format("class SomeClass {\n" 2838 "public:\n" 2839 " SomeClass()\n" 2840 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2841 "};")); 2842 EXPECT_EQ( 2843 "class SomeClass {\n" 2844 "public:\n" 2845 " SomeClass()\n" 2846 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2847 "};", 2848 format("class SomeClass {\n" 2849 "public:\n" 2850 " SomeClass()\n" 2851 " EXCLUSIVE_LOCK_FUNCTION(mu_);\n" 2852 "};", getLLVMStyleWithColumns(40))); 2853 } 2854 2855 TEST_F(FormatTest, LayoutMacroDefinitionsStatementsSpanningBlocks) { 2856 verifyFormat("#define A \\\n" 2857 " f({ \\\n" 2858 " g(); \\\n" 2859 " });", getLLVMStyleWithColumns(11)); 2860 } 2861 2862 TEST_F(FormatTest, IndentPreprocessorDirectivesAtZero) { 2863 EXPECT_EQ("{\n {\n#define A\n }\n}", format("{{\n#define A\n}}")); 2864 } 2865 2866 TEST_F(FormatTest, FormatHashIfNotAtStartOfLine) { 2867 verifyFormat("{\n { a #c; }\n}"); 2868 } 2869 2870 TEST_F(FormatTest, FormatUnbalancedStructuralElements) { 2871 EXPECT_EQ("#define A \\\n { \\\n {\nint i;", 2872 format("#define A { {\nint i;", getLLVMStyleWithColumns(11))); 2873 EXPECT_EQ("#define A \\\n } \\\n }\nint i;", 2874 format("#define A } }\nint i;", getLLVMStyleWithColumns(11))); 2875 } 2876 2877 TEST_F(FormatTest, EscapedNewlineAtStartOfToken) { 2878 EXPECT_EQ( 2879 "#define A \\\n int i; \\\n int j;", 2880 format("#define A \\\nint i;\\\n int j;", getLLVMStyleWithColumns(11))); 2881 EXPECT_EQ("template <class T> f();", format("\\\ntemplate <class T> f();")); 2882 } 2883 2884 TEST_F(FormatTest, NoEscapedNewlineHandlingInBlockComments) { 2885 EXPECT_EQ("/* \\ \\ \\\n*/", format("\\\n/* \\ \\ \\\n*/")); 2886 } 2887 2888 TEST_F(FormatTest, DontCrashOnBlockComments) { 2889 EXPECT_EQ( 2890 "int xxxxxxxxx; /* " 2891 "yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy\n" 2892 "zzzzzz\n" 2893 "0*/", 2894 format("int xxxxxxxxx; /* " 2895 "yyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyyy zzzzzz\n" 2896 "0*/")); 2897 } 2898 2899 TEST_F(FormatTest, CalculateSpaceOnConsecutiveLinesInMacro) { 2900 verifyFormat("#define A \\\n" 2901 " int v( \\\n" 2902 " a); \\\n" 2903 " int i;", 2904 getLLVMStyleWithColumns(11)); 2905 } 2906 2907 TEST_F(FormatTest, MixingPreprocessorDirectivesAndNormalCode) { 2908 EXPECT_EQ( 2909 "#define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2910 " \\\n" 2911 " aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2912 "\n" 2913 "AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2914 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n", 2915 format(" #define ALooooooooooooooooooooooooooooooooooooooongMacro(" 2916 "\\\n" 2917 "aLoooooooooooooooooooooooongFuuuuuuuuuuuuuunctiooooooooo)\n" 2918 " \n" 2919 " AlooooooooooooooooooooooooooooooooooooooongCaaaaaaaaaal(\n" 2920 " aLooooooooooooooooooooooonPaaaaaaaaaaaaaaaaaaaaarmmmm);\n")); 2921 } 2922 2923 TEST_F(FormatTest, LayoutStatementsAroundPreprocessorDirectives) { 2924 EXPECT_EQ("int\n" 2925 "#define A\n" 2926 " a;", 2927 format("int\n#define A\na;")); 2928 verifyFormat("functionCallTo(\n" 2929 " someOtherFunction(\n" 2930 " withSomeParameters, whichInSequence,\n" 2931 " areLongerThanALine(andAnotherCall,\n" 2932 "#define A B\n" 2933 " withMoreParamters,\n" 2934 " whichStronglyInfluenceTheLayout),\n" 2935 " andMoreParameters),\n" 2936 " trailing);", 2937 getLLVMStyleWithColumns(69)); 2938 verifyFormat("Foo::Foo()\n" 2939 "#ifdef BAR\n" 2940 " : baz(0)\n" 2941 "#endif\n" 2942 "{\n" 2943 "}"); 2944 verifyFormat("void f() {\n" 2945 " if (true)\n" 2946 "#ifdef A\n" 2947 " f(42);\n" 2948 " x();\n" 2949 "#else\n" 2950 " g();\n" 2951 " x();\n" 2952 "#endif\n" 2953 "}"); 2954 verifyFormat("void f(param1, param2,\n" 2955 " param3,\n" 2956 "#ifdef A\n" 2957 " param4(param5,\n" 2958 "#ifdef A1\n" 2959 " param6,\n" 2960 "#ifdef A2\n" 2961 " param7),\n" 2962 "#else\n" 2963 " param8),\n" 2964 " param9,\n" 2965 "#endif\n" 2966 " param10,\n" 2967 "#endif\n" 2968 " param11)\n" 2969 "#else\n" 2970 " param12)\n" 2971 "#endif\n" 2972 "{\n" 2973 " x();\n" 2974 "}", 2975 getLLVMStyleWithColumns(28)); 2976 verifyFormat("#if 1\n" 2977 "int i;"); 2978 verifyFormat( 2979 "#if 1\n" 2980 "#endif\n" 2981 "#if 1\n" 2982 "#else\n" 2983 "#endif\n"); 2984 verifyFormat("DEBUG({\n" 2985 " return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 2986 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;\n" 2987 "});\n" 2988 "#if a\n" 2989 "#else\n" 2990 "#endif"); 2991 2992 verifyFormat("void f(\n" 2993 "#if A\n" 2994 " );\n" 2995 "#else\n" 2996 "#endif"); 2997 } 2998 2999 TEST_F(FormatTest, GraciouslyHandleIncorrectPreprocessorConditions) { 3000 verifyFormat("#endif\n" 3001 "#if B"); 3002 } 3003 3004 TEST_F(FormatTest, FormatsJoinedLinesOnSubsequentRuns) { 3005 FormatStyle SingleLine = getLLVMStyle(); 3006 SingleLine.AllowShortIfStatementsOnASingleLine = true; 3007 verifyFormat( 3008 "#if 0\n" 3009 "#elif 1\n" 3010 "#endif\n" 3011 "void foo() {\n" 3012 " if (test) foo2();\n" 3013 "}", 3014 SingleLine); 3015 } 3016 3017 TEST_F(FormatTest, LayoutBlockInsideParens) { 3018 EXPECT_EQ("functionCall({ int i; });", format(" functionCall ( {int i;} );")); 3019 EXPECT_EQ("functionCall({\n" 3020 " int i;\n" 3021 " int j;\n" 3022 "});", 3023 format(" functionCall ( {int i;int j;} );")); 3024 EXPECT_EQ("functionCall({\n" 3025 " int i;\n" 3026 " int j;\n" 3027 "}, aaaa, bbbb, cccc);", 3028 format(" functionCall ( {int i;int j;}, aaaa, bbbb, cccc);")); 3029 EXPECT_EQ("functionCall(\n" 3030 " {\n" 3031 " int i;\n" 3032 " int j;\n" 3033 " },\n" 3034 " aaaa, bbbb, // comment\n" 3035 " cccc);", 3036 format(" functionCall ( {int i;int j;}, aaaa, bbbb, // comment\n" 3037 "cccc);")); 3038 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 3039 format(" functionCall (aaaa, bbbb, {int i;});")); 3040 EXPECT_EQ("functionCall(aaaa, bbbb, {\n" 3041 " int i;\n" 3042 " int j;\n" 3043 "});", 3044 format(" functionCall (aaaa, bbbb, {int i;int j;});")); 3045 EXPECT_EQ("functionCall(aaaa, bbbb, { int i; });", 3046 format(" functionCall (aaaa, bbbb, {int i;});")); 3047 verifyFormat( 3048 "Aaa(\n" // FIXME: There shouldn't be a linebreak here. 3049 " {\n" 3050 " int i; // break\n" 3051 " },\n" 3052 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 3053 " ccccccccccccccccc));"); 3054 verifyFormat("DEBUG({\n" 3055 " if (a)\n" 3056 " f();\n" 3057 "});"); 3058 } 3059 3060 TEST_F(FormatTest, LayoutBlockInsideStatement) { 3061 EXPECT_EQ("SOME_MACRO { int i; }\n" 3062 "int i;", 3063 format(" SOME_MACRO {int i;} int i;")); 3064 } 3065 3066 TEST_F(FormatTest, LayoutNestedBlocks) { 3067 verifyFormat("void AddOsStrings(unsigned bitmask) {\n" 3068 " struct s {\n" 3069 " int i;\n" 3070 " };\n" 3071 " s kBitsToOs[] = {{10}};\n" 3072 " for (int i = 0; i < 10; ++i)\n" 3073 " return;\n" 3074 "}"); 3075 verifyFormat("call(parameter, {\n" 3076 " something();\n" 3077 " // Comment using all columns.\n" 3078 " somethingelse();\n" 3079 "});", 3080 getLLVMStyleWithColumns(40)); 3081 verifyFormat("DEBUG( //\n" 3082 " { f(); }, a);"); 3083 verifyFormat("DEBUG( //\n" 3084 " {\n" 3085 " f(); //\n" 3086 " },\n" 3087 " a);"); 3088 3089 EXPECT_EQ("call(parameter, {\n" 3090 " something();\n" 3091 " // Comment too\n" 3092 " // looooooooooong.\n" 3093 " somethingElse();\n" 3094 "});", 3095 format("call(parameter, {\n" 3096 " something();\n" 3097 " // Comment too looooooooooong.\n" 3098 " somethingElse();\n" 3099 "});", 3100 getLLVMStyleWithColumns(29))); 3101 EXPECT_EQ("DEBUG({ int i; });", format("DEBUG({ int i; });")); 3102 EXPECT_EQ("DEBUG({ // comment\n" 3103 " int i;\n" 3104 "});", 3105 format("DEBUG({ // comment\n" 3106 "int i;\n" 3107 "});")); 3108 EXPECT_EQ("DEBUG({\n" 3109 " int i;\n" 3110 "\n" 3111 " // comment\n" 3112 " int j;\n" 3113 "});", 3114 format("DEBUG({\n" 3115 " int i;\n" 3116 "\n" 3117 " // comment\n" 3118 " int j;\n" 3119 "});")); 3120 3121 verifyFormat("DEBUG({\n" 3122 " if (a)\n" 3123 " return;\n" 3124 "});"); 3125 verifyGoogleFormat("DEBUG({\n" 3126 " if (a) return;\n" 3127 "});"); 3128 FormatStyle Style = getGoogleStyle(); 3129 Style.ColumnLimit = 45; 3130 verifyFormat("Debug(aaaaa, {\n" 3131 " if (aaaaaaaaaaaaaaaaaaaaaaaa) return;\n" 3132 "}, a);", 3133 Style); 3134 3135 verifyNoCrash("^{v^{a}}"); 3136 } 3137 3138 TEST_F(FormatTest, IndividualStatementsOfNestedBlocks) { 3139 EXPECT_EQ("DEBUG({\n" 3140 " int i;\n" 3141 " int j;\n" 3142 "});", 3143 format("DEBUG( {\n" 3144 " int i;\n" 3145 " int j;\n" 3146 "} ) ;", 3147 20, 1, getLLVMStyle())); 3148 EXPECT_EQ("DEBUG( {\n" 3149 " int i;\n" 3150 " int j;\n" 3151 "} ) ;", 3152 format("DEBUG( {\n" 3153 " int i;\n" 3154 " int j;\n" 3155 "} ) ;", 3156 41, 1, getLLVMStyle())); 3157 EXPECT_EQ("DEBUG( {\n" 3158 " int i;\n" 3159 " int j;\n" 3160 "} ) ;", 3161 format("DEBUG( {\n" 3162 " int i;\n" 3163 " int j;\n" 3164 "} ) ;", 3165 41, 1, getLLVMStyle())); 3166 EXPECT_EQ("DEBUG({\n" 3167 " int i;\n" 3168 " int j;\n" 3169 "});", 3170 format("DEBUG( {\n" 3171 " int i;\n" 3172 " int j;\n" 3173 "} ) ;", 3174 20, 1, getLLVMStyle())); 3175 3176 EXPECT_EQ("Debug({\n" 3177 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 3178 " return;\n" 3179 " },\n" 3180 " a);", 3181 format("Debug({\n" 3182 " if (aaaaaaaaaaaaaaaaaaaaaaaa)\n" 3183 " return;\n" 3184 " },\n" 3185 " a);", 3186 50, 1, getLLVMStyle())); 3187 EXPECT_EQ("DEBUG({\n" 3188 " DEBUG({\n" 3189 " int a;\n" 3190 " int b;\n" 3191 " }) ;\n" 3192 "});", 3193 format("DEBUG({\n" 3194 " DEBUG({\n" 3195 " int a;\n" 3196 " int b;\n" // Format this line only. 3197 " }) ;\n" // Don't touch this line. 3198 "});", 3199 35, 0, getLLVMStyle())); 3200 EXPECT_EQ("DEBUG({\n" 3201 " int a; //\n" 3202 "});", 3203 format("DEBUG({\n" 3204 " int a; //\n" 3205 "});", 3206 0, 0, getLLVMStyle())); 3207 } 3208 3209 TEST_F(FormatTest, PutEmptyBlocksIntoOneLine) { 3210 EXPECT_EQ("{}", format("{}")); 3211 verifyFormat("enum E {};"); 3212 verifyFormat("enum E {}"); 3213 } 3214 3215 //===----------------------------------------------------------------------===// 3216 // Line break tests. 3217 //===----------------------------------------------------------------------===// 3218 3219 TEST_F(FormatTest, PreventConfusingIndents) { 3220 verifyFormat( 3221 "void f() {\n" 3222 " SomeLongMethodName(SomeReallyLongMethod(CallOtherReallyLongMethod(\n" 3223 " parameter, parameter, parameter)),\n" 3224 " SecondLongCall(parameter));\n" 3225 "}"); 3226 verifyFormat( 3227 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3228 " aaaaaaaaaaaaaaaaaaaaaaaa(\n" 3229 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3230 " aaaaaaaaaaaaaaaaaaaaaaaa);"); 3231 verifyFormat( 3232 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3233 " [aaaaaaaaaaaaaaaaaaaaaaaa\n" 3234 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 3235 " [aaaaaaaaaaaaaaaaaaaaaaaa]];"); 3236 verifyFormat( 3237 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 3238 " aaaaaaaaaaaaaaaaaaaaaaaa<\n" 3239 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>,\n" 3240 " aaaaaaaaaaaaaaaaaaaaaaaa>;"); 3241 verifyFormat("int a = bbbb && ccc && fffff(\n" 3242 "#define A Just forcing a new line\n" 3243 " ddd);"); 3244 } 3245 3246 TEST_F(FormatTest, LineBreakingInBinaryExpressions) { 3247 verifyFormat( 3248 "bool aaaaaaa =\n" 3249 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() ||\n" 3250 " bbbbbbbb();"); 3251 verifyFormat( 3252 "bool aaaaaaa =\n" 3253 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaa).aaaaaaaaaaaaaaaaaaa() or\n" 3254 " bbbbbbbb();"); 3255 3256 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 3257 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb &&\n" 3258 " ccccccccc == ddddddddddd;"); 3259 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaa =\n" 3260 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa != bbbbbbbbbbbbbbbbbb and\n" 3261 " ccccccccc == ddddddddddd;"); 3262 verifyFormat( 3263 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 3264 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa not_eq bbbbbbbbbbbbbbbbbb and\n" 3265 " ccccccccc == ddddddddddd;"); 3266 3267 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 3268 " aaaaaa) &&\n" 3269 " bbbbbb && cccccc;"); 3270 verifyFormat("aaaaaa = aaaaaaa(aaaaaaa, // break\n" 3271 " aaaaaa) >>\n" 3272 " bbbbbb;"); 3273 verifyFormat("Whitespaces.addUntouchableComment(\n" 3274 " SourceMgr.getSpellingColumnNumber(\n" 3275 " TheLine.Last->FormatTok.Tok.getLocation()) -\n" 3276 " 1);"); 3277 3278 verifyFormat("if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3279 " bbbbbbbbbbbbbbbbbb) && // aaaaaaaaaaaaaaaa\n" 3280 " cccccc) {\n}"); 3281 verifyFormat("b = a &&\n" 3282 " // Comment\n" 3283 " b.c && d;"); 3284 3285 // If the LHS of a comparison is not a binary expression itself, the 3286 // additional linebreak confuses many people. 3287 verifyFormat( 3288 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3289 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) > 5) {\n" 3290 "}"); 3291 verifyFormat( 3292 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3293 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3294 "}"); 3295 verifyFormat( 3296 "if (aaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaaaaaaaaaaa(\n" 3297 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3298 "}"); 3299 // Even explicit parentheses stress the precedence enough to make the 3300 // additional break unnecessary. 3301 verifyFormat( 3302 "if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3303 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) == 5) {\n" 3304 "}"); 3305 // This cases is borderline, but with the indentation it is still readable. 3306 verifyFormat( 3307 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3308 " aaaaaaaaaaaaaaa) > aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3309 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 3310 "}", 3311 getLLVMStyleWithColumns(75)); 3312 3313 // If the LHS is a binary expression, we should still use the additional break 3314 // as otherwise the formatting hides the operator precedence. 3315 verifyFormat( 3316 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3317 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3318 " 5) {\n" 3319 "}"); 3320 3321 FormatStyle OnePerLine = getLLVMStyle(); 3322 OnePerLine.BinPackParameters = false; 3323 verifyFormat( 3324 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3325 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3326 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}", 3327 OnePerLine); 3328 } 3329 3330 TEST_F(FormatTest, ExpressionIndentation) { 3331 verifyFormat("bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3332 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3333 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3334 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3335 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb +\n" 3336 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb &&\n" 3337 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3338 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >\n" 3339 " ccccccccccccccccccccccccccccccccccccccccc;"); 3340 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3341 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3342 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3343 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3344 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3345 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3346 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3347 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3348 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ==\n" 3349 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 3350 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3351 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}"); 3352 verifyFormat("if () {\n" 3353 "} else if (aaaaa &&\n" 3354 " bbbbb > // break\n" 3355 " ccccc) {\n" 3356 "}"); 3357 3358 // Presence of a trailing comment used to change indentation of b. 3359 verifyFormat("return aaaaaaaaaaaaaaaaaaa +\n" 3360 " b;\n" 3361 "return aaaaaaaaaaaaaaaaaaa +\n" 3362 " b; //", 3363 getLLVMStyleWithColumns(30)); 3364 } 3365 3366 TEST_F(FormatTest, ExpressionIndentationBreakingBeforeOperators) { 3367 // Not sure what the best system is here. Like this, the LHS can be found 3368 // immediately above an operator (everything with the same or a higher 3369 // indent). The RHS is aligned right of the operator and so compasses 3370 // everything until something with the same indent as the operator is found. 3371 // FIXME: Is this a good system? 3372 FormatStyle Style = getLLVMStyle(); 3373 Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; 3374 verifyFormat( 3375 "bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3376 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3377 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3378 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3379 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3380 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3381 " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3382 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3383 " > ccccccccccccccccccccccccccccccccccccccccc;", 3384 Style); 3385 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3386 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3387 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3388 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3389 Style); 3390 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3391 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3392 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3393 " == bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3394 Style); 3395 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3396 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3397 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3398 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb) {\n}", 3399 Style); 3400 verifyFormat("if () {\n" 3401 "} else if (aaaaa\n" 3402 " && bbbbb // break\n" 3403 " > ccccc) {\n" 3404 "}", 3405 Style); 3406 verifyFormat("return (a)\n" 3407 " // comment\n" 3408 " + b;", 3409 Style); 3410 verifyFormat("int aaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3411 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3412 " + cc;", 3413 Style); 3414 3415 // Forced by comments. 3416 verifyFormat( 3417 "unsigned ContentSize =\n" 3418 " sizeof(int16_t) // DWARF ARange version number\n" 3419 " + sizeof(int32_t) // Offset of CU in the .debug_info section\n" 3420 " + sizeof(int8_t) // Pointer Size (in bytes)\n" 3421 " + sizeof(int8_t); // Segment Size (in bytes)"); 3422 3423 verifyFormat("return boost::fusion::at_c<0>(iiii).second\n" 3424 " == boost::fusion::at_c<1>(iiii).second;", 3425 Style); 3426 3427 Style.ColumnLimit = 60; 3428 verifyFormat("zzzzzzzzzz\n" 3429 " = bbbbbbbbbbbbbbbbb\n" 3430 " >> aaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa);", 3431 Style); 3432 } 3433 3434 TEST_F(FormatTest, NoOperandAlignment) { 3435 FormatStyle Style = getLLVMStyle(); 3436 Style.AlignOperands = false; 3437 Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment; 3438 verifyFormat( 3439 "bool value = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3440 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3441 " + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3442 " == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3443 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3444 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3445 " && aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3446 " * aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3447 " > ccccccccccccccccccccccccccccccccccccccccc;", 3448 Style); 3449 3450 verifyFormat("int aaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3451 " * bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3452 " + cc;", 3453 Style); 3454 verifyFormat("int a = aa\n" 3455 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\n" 3456 " * cccccccccccccccccccccccccccccccccccc;", 3457 Style); 3458 3459 Style.AlignAfterOpenBracket = false; 3460 verifyFormat("return (a > b\n" 3461 " // comment1\n" 3462 " // comment2\n" 3463 " || c);", 3464 Style); 3465 } 3466 3467 TEST_F(FormatTest, BreakingBeforeNonAssigmentOperators) { 3468 FormatStyle Style = getLLVMStyle(); 3469 Style.BreakBeforeBinaryOperators = FormatStyle::BOS_NonAssignment; 3470 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 3471 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3472 " + bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;", 3473 Style); 3474 } 3475 3476 TEST_F(FormatTest, ConstructorInitializers) { 3477 verifyFormat("Constructor() : Initializer(FitsOnTheLine) {}"); 3478 verifyFormat("Constructor() : Inttializer(FitsOnTheLine) {}", 3479 getLLVMStyleWithColumns(45)); 3480 verifyFormat("Constructor()\n" 3481 " : Inttializer(FitsOnTheLine) {}", 3482 getLLVMStyleWithColumns(44)); 3483 verifyFormat("Constructor()\n" 3484 " : Inttializer(FitsOnTheLine) {}", 3485 getLLVMStyleWithColumns(43)); 3486 3487 verifyFormat( 3488 "SomeClass::Constructor()\n" 3489 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 3490 3491 verifyFormat( 3492 "SomeClass::Constructor()\n" 3493 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3494 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}"); 3495 verifyFormat( 3496 "SomeClass::Constructor()\n" 3497 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3498 " aaaaaaaaaaaaaaa(aaaaaaaaaaaa) {}"); 3499 3500 verifyFormat("Constructor()\n" 3501 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3502 " aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3503 " aaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 3504 " aaaaaaaaaaaaaaaaaaaaaaa() {}"); 3505 3506 verifyFormat("Constructor()\n" 3507 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3508 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3509 3510 verifyFormat("Constructor(int Parameter = 0)\n" 3511 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa),\n" 3512 " aaaaaaaaaaaa(aaaaaaaaaaaaaaaaa) {}"); 3513 verifyFormat("Constructor()\n" 3514 " : aaaaaaaaaaaaaaaaaaaa(a), bbbbbbbbbbbbbbbbbbbbbbbb(b) {\n" 3515 "}", 3516 getLLVMStyleWithColumns(60)); 3517 verifyFormat("Constructor()\n" 3518 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3519 " aaaaaaaaaaaaaaaaaaaaaaaaa(aaaa, aaaa)) {}"); 3520 3521 // Here a line could be saved by splitting the second initializer onto two 3522 // lines, but that is not desirable. 3523 verifyFormat("Constructor()\n" 3524 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaa),\n" 3525 " aaaaaaaaaaa(aaaaaaaaaaa),\n" 3526 " aaaaaaaaaaaaaaaaaaaaat(aaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3527 3528 FormatStyle OnePerLine = getLLVMStyle(); 3529 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 3530 verifyFormat("SomeClass::Constructor()\n" 3531 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3532 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3533 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 3534 OnePerLine); 3535 verifyFormat("SomeClass::Constructor()\n" 3536 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), // Some comment\n" 3537 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 3538 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 3539 OnePerLine); 3540 verifyFormat("MyClass::MyClass(int var)\n" 3541 " : some_var_(var), // 4 space indent\n" 3542 " some_other_var_(var + 1) { // lined up\n" 3543 "}", 3544 OnePerLine); 3545 verifyFormat("Constructor()\n" 3546 " : aaaaa(aaaaaa),\n" 3547 " aaaaa(aaaaaa),\n" 3548 " aaaaa(aaaaaa),\n" 3549 " aaaaa(aaaaaa),\n" 3550 " aaaaa(aaaaaa) {}", 3551 OnePerLine); 3552 verifyFormat("Constructor()\n" 3553 " : aaaaa(aaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaa,\n" 3554 " aaaaaaaaaaaaaaaaaaaaaa) {}", 3555 OnePerLine); 3556 3557 EXPECT_EQ("Constructor()\n" 3558 " : // Comment forcing unwanted break.\n" 3559 " aaaa(aaaa) {}", 3560 format("Constructor() :\n" 3561 " // Comment forcing unwanted break.\n" 3562 " aaaa(aaaa) {}")); 3563 } 3564 3565 TEST_F(FormatTest, MemoizationTests) { 3566 // This breaks if the memoization lookup does not take \c Indent and 3567 // \c LastSpace into account. 3568 verifyFormat( 3569 "extern CFRunLoopTimerRef\n" 3570 "CFRunLoopTimerCreate(CFAllocatorRef allocato, CFAbsoluteTime fireDate,\n" 3571 " CFTimeInterval interval, CFOptionFlags flags,\n" 3572 " CFIndex order, CFRunLoopTimerCallBack callout,\n" 3573 " CFRunLoopTimerContext *context) {}"); 3574 3575 // Deep nesting somewhat works around our memoization. 3576 verifyFormat( 3577 "aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3578 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3579 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3580 " aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(aaaaa(\n" 3581 " aaaaa())))))))))))))))))))))))))))))))))))))));", 3582 getLLVMStyleWithColumns(65)); 3583 verifyFormat( 3584 "aaaaa(\n" 3585 " aaaaa,\n" 3586 " aaaaa(\n" 3587 " aaaaa,\n" 3588 " aaaaa(\n" 3589 " aaaaa,\n" 3590 " aaaaa(\n" 3591 " aaaaa,\n" 3592 " aaaaa(\n" 3593 " aaaaa,\n" 3594 " aaaaa(\n" 3595 " aaaaa,\n" 3596 " aaaaa(\n" 3597 " aaaaa,\n" 3598 " aaaaa(\n" 3599 " aaaaa,\n" 3600 " aaaaa(\n" 3601 " aaaaa,\n" 3602 " aaaaa(\n" 3603 " aaaaa,\n" 3604 " aaaaa(\n" 3605 " aaaaa,\n" 3606 " aaaaa(\n" 3607 " aaaaa,\n" 3608 " aaaaa))))))))))));", 3609 getLLVMStyleWithColumns(65)); 3610 verifyFormat( 3611 "a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(a(), a), a), a), a),\n" 3612 " a),\n" 3613 " a),\n" 3614 " a),\n" 3615 " a),\n" 3616 " a),\n" 3617 " a),\n" 3618 " a),\n" 3619 " a),\n" 3620 " a),\n" 3621 " a),\n" 3622 " a),\n" 3623 " a),\n" 3624 " a),\n" 3625 " a),\n" 3626 " a),\n" 3627 " a),\n" 3628 " a)", 3629 getLLVMStyleWithColumns(65)); 3630 3631 // This test takes VERY long when memoization is broken. 3632 FormatStyle OnePerLine = getLLVMStyle(); 3633 OnePerLine.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 3634 OnePerLine.BinPackParameters = false; 3635 std::string input = "Constructor()\n" 3636 " : aaaa(a,\n"; 3637 for (unsigned i = 0, e = 80; i != e; ++i) { 3638 input += " a,\n"; 3639 } 3640 input += " a) {}"; 3641 verifyFormat(input, OnePerLine); 3642 } 3643 3644 TEST_F(FormatTest, BreaksAsHighAsPossible) { 3645 verifyFormat( 3646 "void f() {\n" 3647 " if ((aaaaaaaaaaaaaaaaaaaaaaaaaaaaa && aaaaaaaaaaaaaaaaaaaaaaaaaa) ||\n" 3648 " (bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb && bbbbbbbbbbbbbbbbbbbbbbbbbb))\n" 3649 " f();\n" 3650 "}"); 3651 verifyFormat("if (Intervals[i].getRange().getFirst() <\n" 3652 " Intervals[i - 1].getRange().getLast()) {\n}"); 3653 } 3654 3655 TEST_F(FormatTest, BreaksFunctionDeclarations) { 3656 // Principially, we break function declarations in a certain order: 3657 // 1) break amongst arguments. 3658 verifyFormat("Aaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccc,\n" 3659 " Cccccccccccccc cccccccccccccc);"); 3660 verifyFormat( 3661 "template <class TemplateIt>\n" 3662 "SomeReturnType SomeFunction(TemplateIt begin, TemplateIt end,\n" 3663 " TemplateIt *stop) {}"); 3664 3665 // 2) break after return type. 3666 verifyFormat( 3667 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3668 "bbbbbbbbbbbbbb(Cccccccccccccc cccccccccccccccccccccccccc);", 3669 getGoogleStyle()); 3670 3671 // 3) break after (. 3672 verifyFormat( 3673 "Aaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbbbbbb(\n" 3674 " Cccccccccccccccccccccccccccccc cccccccccccccccccccccccccccccccc);", 3675 getGoogleStyle()); 3676 3677 // 4) break before after nested name specifiers. 3678 verifyFormat( 3679 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3680 "SomeClasssssssssssssssssssssssssssssssssssssss::\n" 3681 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc);", 3682 getGoogleStyle()); 3683 3684 // However, there are exceptions, if a sufficient amount of lines can be 3685 // saved. 3686 // FIXME: The precise cut-offs wrt. the number of saved lines might need some 3687 // more adjusting. 3688 verifyFormat("Aaaaaaaaaaaaaaaaaa bbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 3689 " Cccccccccccccc cccccccccc,\n" 3690 " Cccccccccccccc cccccccccc,\n" 3691 " Cccccccccccccc cccccccccc,\n" 3692 " Cccccccccccccc cccccccccc);"); 3693 verifyFormat( 3694 "Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3695 "bbbbbbbbbbb(Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3696 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3697 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);", 3698 getGoogleStyle()); 3699 verifyFormat( 3700 "Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(Cccccccccccccc cccccccccc,\n" 3701 " Cccccccccccccc cccccccccc,\n" 3702 " Cccccccccccccc cccccccccc,\n" 3703 " Cccccccccccccc cccccccccc,\n" 3704 " Cccccccccccccc cccccccccc,\n" 3705 " Cccccccccccccc cccccccccc,\n" 3706 " Cccccccccccccc cccccccccc);"); 3707 verifyFormat("Aaaaaaaaaa bbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3708 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3709 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3710 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc,\n" 3711 " Cccccccccccccc cccccccccc, Cccccccccccccc cccccccccc);"); 3712 3713 // Break after multi-line parameters. 3714 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3715 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3716 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3717 " bbbb bbbb);"); 3718 verifyFormat("void SomeLoooooooooooongFunction(\n" 3719 " std::unique_ptr<aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>\n" 3720 " aaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3721 " int bbbbbbbbbbbbb);"); 3722 3723 // Treat overloaded operators like other functions. 3724 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3725 "operator>(const SomeLoooooooooooooooooooooooooogType &other);"); 3726 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3727 "operator>>(const SomeLooooooooooooooooooooooooogType &other);"); 3728 verifyFormat("SomeLoooooooooooooooooooooooooogType\n" 3729 "operator<<(const SomeLooooooooooooooooooooooooogType &other);"); 3730 verifyGoogleFormat( 3731 "SomeLoooooooooooooooooooooooooooooogType operator>>(\n" 3732 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 3733 verifyGoogleFormat( 3734 "SomeLoooooooooooooooooooooooooooooogType operator<<(\n" 3735 " const SomeLooooooooogType &a, const SomeLooooooooogType &b);"); 3736 verifyFormat("void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3737 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa = 1);"); 3738 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa\n" 3739 "aaaaaaaaaaaaaaaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaa = 1);"); 3740 verifyGoogleFormat( 3741 "typename aaaaaaaaaa<aaaaaa>::aaaaaaaaaaa\n" 3742 "aaaaaaaaaa<aaaaaa>::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3743 " bool *aaaaaaaaaaaaaaaaaa, bool *aa) {}"); 3744 } 3745 3746 TEST_F(FormatTest, TrailingReturnType) { 3747 verifyFormat("auto foo() -> int;\n"); 3748 verifyFormat("struct S {\n" 3749 " auto bar() const -> int;\n" 3750 "};"); 3751 verifyFormat("template <size_t Order, typename T>\n" 3752 "auto load_img(const std::string &filename)\n" 3753 " -> alias::tensor<Order, T, mem::tag::cpu> {}"); 3754 verifyFormat("auto SomeFunction(A aaaaaaaaaaaaaaaaaaaaa) const\n" 3755 " -> decltype(f(aaaaaaaaaaaaaaaaaaaaa)) {}"); 3756 verifyFormat("auto doSomething(Aaaaaa *aaaaaa) -> decltype(aaaaaa->f()) {}"); 3757 3758 // Not trailing return types. 3759 verifyFormat("void f() { auto a = b->c(); }"); 3760 } 3761 3762 TEST_F(FormatTest, BreaksFunctionDeclarationsWithTrailingTokens) { 3763 // Avoid breaking before trailing 'const' or other trailing annotations, if 3764 // they are not function-like. 3765 FormatStyle Style = getGoogleStyle(); 3766 Style.ColumnLimit = 47; 3767 verifyFormat("void someLongFunction(\n" 3768 " int someLoooooooooooooongParameter) const {\n}", 3769 getLLVMStyleWithColumns(47)); 3770 verifyFormat("LoooooongReturnType\n" 3771 "someLoooooooongFunction() const {}", 3772 getLLVMStyleWithColumns(47)); 3773 verifyFormat("LoooooongReturnType someLoooooooongFunction()\n" 3774 " const {}", 3775 Style); 3776 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3777 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE;"); 3778 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3779 " aaaaa aaaaaaaaaaaaaaaaaaaa) OVERRIDE FINAL;"); 3780 verifyFormat("void SomeFunction(aaaaa aaaaaaaaaaaaaaaaaaaa,\n" 3781 " aaaaa aaaaaaaaaaaaaaaaaaaa) override final;"); 3782 verifyFormat("virtual void aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa,\n" 3783 " aaaaaaaaaaa aaaaa) const override;"); 3784 verifyGoogleFormat( 3785 "virtual void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 3786 " const override;"); 3787 3788 // Even if the first parameter has to be wrapped. 3789 verifyFormat("void someLongFunction(\n" 3790 " int someLongParameter) const {}", 3791 getLLVMStyleWithColumns(46)); 3792 verifyFormat("void someLongFunction(\n" 3793 " int someLongParameter) const {}", 3794 Style); 3795 verifyFormat("void someLongFunction(\n" 3796 " int someLongParameter) override {}", 3797 Style); 3798 verifyFormat("void someLongFunction(\n" 3799 " int someLongParameter) OVERRIDE {}", 3800 Style); 3801 verifyFormat("void someLongFunction(\n" 3802 " int someLongParameter) final {}", 3803 Style); 3804 verifyFormat("void someLongFunction(\n" 3805 " int someLongParameter) FINAL {}", 3806 Style); 3807 verifyFormat("void someLongFunction(\n" 3808 " int parameter) const override {}", 3809 Style); 3810 3811 Style.BreakBeforeBraces = FormatStyle::BS_Allman; 3812 verifyFormat("void someLongFunction(\n" 3813 " int someLongParameter) const\n" 3814 "{\n" 3815 "}", 3816 Style); 3817 3818 // Unless these are unknown annotations. 3819 verifyFormat("void SomeFunction(aaaaaaaaaa aaaaaaaaaaaaaaa,\n" 3820 " aaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3821 " LONG_AND_UGLY_ANNOTATION;"); 3822 3823 // Breaking before function-like trailing annotations is fine to keep them 3824 // close to their arguments. 3825 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 3826 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3827 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3828 " LOCKS_EXCLUDED(aaaaaaaaaaaaa);"); 3829 verifyFormat("void aaaaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) const\n" 3830 " LOCKS_EXCLUDED(aaaaaaaaaaaaa) {}"); 3831 verifyGoogleFormat("void aaaaaaaaaaaaaa(aaaaaaaa aaa) override\n" 3832 " AAAAAAAAAAAAAAAAAAAAAAAA(aaaaaaaaaaaaaaa);"); 3833 verifyFormat("SomeFunction([](int i) LOCKS_EXCLUDED(a) {});"); 3834 3835 verifyFormat( 3836 "void aaaaaaaaaaaaaaaaaa()\n" 3837 " __attribute__((aaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaa,\n" 3838 " aaaaaaaaaaaaaaaaaaaaaaaaa));"); 3839 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3840 " __attribute__((unused));"); 3841 verifyGoogleFormat( 3842 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3843 " GUARDED_BY(aaaaaaaaaaaa);"); 3844 verifyGoogleFormat( 3845 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 3846 " GUARDED_BY(aaaaaaaaaaaa);"); 3847 verifyGoogleFormat( 3848 "bool aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa GUARDED_BY(aaaaaaaaaaaa) =\n" 3849 " aaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 3850 } 3851 3852 TEST_F(FormatTest, BreaksDesireably) { 3853 verifyFormat("if (aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3854 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa) ||\n" 3855 " aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaa)) {\n}"); 3856 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3857 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)) {\n" 3858 "}"); 3859 3860 verifyFormat( 3861 "aaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3862 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}"); 3863 3864 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3865 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3866 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3867 3868 verifyFormat( 3869 "aaaaaaaa(aaaaaaaaaaaaa, aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3870 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3871 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3872 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));"); 3873 3874 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 3875 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3876 3877 verifyFormat( 3878 "void f() {\n" 3879 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa &&\n" 3880 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 3881 "}"); 3882 verifyFormat( 3883 "aaaaaa(new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3884 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3885 verifyFormat( 3886 "aaaaaa(aaa, new Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3887 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 3888 verifyFormat( 3889 "aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa +\n" 3890 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3891 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3892 3893 // Indent consistently independent of call expression. 3894 verifyFormat("aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbb.ccccccccccccccccc(\n" 3895 " dddddddddddddddddddddddddddddd));\n" 3896 "aaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(\n" 3897 " dddddddddddddddddddddddddddddd));"); 3898 3899 // This test case breaks on an incorrect memoization, i.e. an optimization not 3900 // taking into account the StopAt value. 3901 verifyFormat( 3902 "return aaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3903 " aaaaaaaaaaa(aaaaaaaaa) || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3904 " aaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaa ||\n" 3905 " (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 3906 3907 verifyFormat("{\n {\n {\n" 3908 " Annotation.SpaceRequiredBefore =\n" 3909 " Line.Tokens[i - 1].Tok.isNot(tok::l_paren) &&\n" 3910 " Line.Tokens[i - 1].Tok.isNot(tok::l_square);\n" 3911 " }\n }\n}"); 3912 3913 // Break on an outer level if there was a break on an inner level. 3914 EXPECT_EQ("f(g(h(a, // comment\n" 3915 " b, c),\n" 3916 " d, e),\n" 3917 " x, y);", 3918 format("f(g(h(a, // comment\n" 3919 " b, c), d, e), x, y);")); 3920 3921 // Prefer breaking similar line breaks. 3922 verifyFormat( 3923 "const int kTrackingOptions = NSTrackingMouseMoved |\n" 3924 " NSTrackingMouseEnteredAndExited |\n" 3925 " NSTrackingActiveAlways;"); 3926 } 3927 3928 TEST_F(FormatTest, FormatsDeclarationsOnePerLine) { 3929 FormatStyle NoBinPacking = getGoogleStyle(); 3930 NoBinPacking.BinPackParameters = false; 3931 NoBinPacking.BinPackArguments = true; 3932 verifyFormat("void f() {\n" 3933 " f(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaa,\n" 3934 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 3935 "}", 3936 NoBinPacking); 3937 verifyFormat("void f(int aaaaaaaaaaaaaaaaaaaa,\n" 3938 " int aaaaaaaaaaaaaaaaaaaa,\n" 3939 " int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", 3940 NoBinPacking); 3941 } 3942 3943 TEST_F(FormatTest, FormatsOneParameterPerLineIfNecessary) { 3944 FormatStyle NoBinPacking = getGoogleStyle(); 3945 NoBinPacking.BinPackParameters = false; 3946 NoBinPacking.BinPackArguments = false; 3947 verifyFormat("f(aaaaaaaaaaaaaaaaaaaa,\n" 3948 " aaaaaaaaaaaaaaaaaaaa,\n" 3949 " aaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaa);", 3950 NoBinPacking); 3951 verifyFormat("aaaaaaa(aaaaaaaaaaaaa,\n" 3952 " aaaaaaaaaaaaa,\n" 3953 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));", 3954 NoBinPacking); 3955 verifyFormat( 3956 "aaaaaaaa(aaaaaaaaaaaaa,\n" 3957 " aaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3958 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)),\n" 3959 " aaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3960 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)));", 3961 NoBinPacking); 3962 verifyFormat("aaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3963 " .aaaaaaaaaaaaaaaaaa();", 3964 NoBinPacking); 3965 verifyFormat("void f() {\n" 3966 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 3967 " aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaa, aaaaaaaaaaa);\n" 3968 "}", 3969 NoBinPacking); 3970 3971 verifyFormat( 3972 "aaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 3973 " aaaaaaaaaaaa,\n" 3974 " aaaaaaaaaaaa);", 3975 NoBinPacking); 3976 verifyFormat( 3977 "somefunction(someotherFunction(ddddddddddddddddddddddddddddddddddd,\n" 3978 " ddddddddddddddddddddddddddddd),\n" 3979 " test);", 3980 NoBinPacking); 3981 3982 verifyFormat("std::vector<aaaaaaaaaaaaaaaaaaaaaaa,\n" 3983 " aaaaaaaaaaaaaaaaaaaaaaa,\n" 3984 " aaaaaaaaaaaaaaaaaaaaaaa> aaaaaaaaaaaaaaaaaa;", 3985 NoBinPacking); 3986 verifyFormat("a(\"a\"\n" 3987 " \"a\",\n" 3988 " a);"); 3989 3990 NoBinPacking.AllowAllParametersOfDeclarationOnNextLine = false; 3991 verifyFormat("void aaaaaaaaaa(aaaaaaaaa,\n" 3992 " aaaaaaaaa,\n" 3993 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 3994 NoBinPacking); 3995 verifyFormat( 3996 "void f() {\n" 3997 " aaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaa, aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa)\n" 3998 " .aaaaaaa();\n" 3999 "}", 4000 NoBinPacking); 4001 verifyFormat( 4002 "template <class SomeType, class SomeOtherType>\n" 4003 "SomeType SomeFunction(SomeType Type, SomeOtherType OtherType) {}", 4004 NoBinPacking); 4005 } 4006 4007 TEST_F(FormatTest, AdaptiveOnePerLineFormatting) { 4008 FormatStyle Style = getLLVMStyleWithColumns(15); 4009 Style.ExperimentalAutoDetectBinPacking = true; 4010 EXPECT_EQ("aaa(aaaa,\n" 4011 " aaaa,\n" 4012 " aaaa);\n" 4013 "aaa(aaaa,\n" 4014 " aaaa,\n" 4015 " aaaa);", 4016 format("aaa(aaaa,\n" // one-per-line 4017 " aaaa,\n" 4018 " aaaa );\n" 4019 "aaa(aaaa, aaaa, aaaa);", // inconclusive 4020 Style)); 4021 EXPECT_EQ("aaa(aaaa, aaaa,\n" 4022 " aaaa);\n" 4023 "aaa(aaaa, aaaa,\n" 4024 " aaaa);", 4025 format("aaa(aaaa, aaaa,\n" // bin-packed 4026 " aaaa );\n" 4027 "aaa(aaaa, aaaa, aaaa);", // inconclusive 4028 Style)); 4029 } 4030 4031 TEST_F(FormatTest, FormatsBuilderPattern) { 4032 verifyFormat( 4033 "return llvm::StringSwitch<Reference::Kind>(name)\n" 4034 " .StartsWith(\".eh_frame_hdr\", ORDER_EH_FRAMEHDR)\n" 4035 " .StartsWith(\".eh_frame\", ORDER_EH_FRAME)\n" 4036 " .StartsWith(\".init\", ORDER_INIT)\n" 4037 " .StartsWith(\".fini\", ORDER_FINI)\n" 4038 " .StartsWith(\".hash\", ORDER_HASH)\n" 4039 " .Default(ORDER_TEXT);\n"); 4040 4041 verifyFormat("return aaaaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa() <\n" 4042 " aaaaaaaaaaaaaaa->aaaaa().aaaaaaaaaaaaa().aaaaaa();"); 4043 verifyFormat( 4044 "aaaaaaa->aaaaaaa->aaaaaaaaaaaaaaaa(\n" 4045 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4046 " ->aaaaaaaa(aaaaaaaaaaaaaaa);"); 4047 verifyFormat( 4048 "aaaaaaaaaaaaaaaaaaa()->aaaaaa(bbbbb)->aaaaaaaaaaaaaaaaaaa( // break\n" 4049 " aaaaaaaaaaaaaa);"); 4050 verifyFormat( 4051 "aaaaaaaaaaaaaaaaaaaaaaa *aaaaaaaaa =\n" 4052 " aaaaaa->aaaaaaaaaaaa()\n" 4053 " ->aaaaaaaaaaaaaaaa(\n" 4054 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4055 " ->aaaaaaaaaaaaaaaaa();"); 4056 verifyGoogleFormat( 4057 "void f() {\n" 4058 " someo->Add((new util::filetools::Handler(dir))\n" 4059 " ->OnEvent1(NewPermanentCallback(\n" 4060 " this, &HandlerHolderClass::EventHandlerCBA))\n" 4061 " ->OnEvent2(NewPermanentCallback(\n" 4062 " this, &HandlerHolderClass::EventHandlerCBB))\n" 4063 " ->OnEvent3(NewPermanentCallback(\n" 4064 " this, &HandlerHolderClass::EventHandlerCBC))\n" 4065 " ->OnEvent5(NewPermanentCallback(\n" 4066 " this, &HandlerHolderClass::EventHandlerCBD))\n" 4067 " ->OnEvent6(NewPermanentCallback(\n" 4068 " this, &HandlerHolderClass::EventHandlerCBE)));\n" 4069 "}"); 4070 4071 verifyFormat( 4072 "aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa().aaaaaaaaaaa();"); 4073 verifyFormat("aaaaaaaaaaaaaaa()\n" 4074 " .aaaaaaaaaaaaaaa()\n" 4075 " .aaaaaaaaaaaaaaa()\n" 4076 " .aaaaaaaaaaaaaaa()\n" 4077 " .aaaaaaaaaaaaaaa();"); 4078 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 4079 " .aaaaaaaaaaaaaaa()\n" 4080 " .aaaaaaaaaaaaaaa()\n" 4081 " .aaaaaaaaaaaaaaa();"); 4082 verifyFormat("aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 4083 " .aaaaaaaaaaaaaaa.aaaaaaaaaaaaaaa()\n" 4084 " .aaaaaaaaaaaaaaa();"); 4085 verifyFormat("aaaaaaaaaaaaa->aaaaaaaaaaaaaaaaaaaaaaaa()\n" 4086 " ->aaaaaaaaaaaaaae(0)\n" 4087 " ->aaaaaaaaaaaaaaa();"); 4088 4089 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 4090 " .aaaaaaaaaaaaaaaaaaaaaaaaaa()\n" 4091 " .has<bbbbbbbbbbbbbbbbbbbbb>();"); 4092 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaa.aaaaaaaaaaaaa()\n" 4093 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<\n" 4094 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>();"); 4095 4096 // Prefer not to break after empty parentheses. 4097 verifyFormat("FirstToken->WhitespaceRange.getBegin().getLocWithOffset(\n" 4098 " First->LastNewlineOffset);"); 4099 } 4100 4101 TEST_F(FormatTest, BreaksAccordingToOperatorPrecedence) { 4102 verifyFormat( 4103 "if (aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 4104 " bbbbbbbbbbbbbbbbbbbbbbbbb && ccccccccccccccccccccccccc) {\n}"); 4105 verifyFormat( 4106 "if (aaaaaaaaaaaaaaaaaaaaaaaaa or\n" 4107 " bbbbbbbbbbbbbbbbbbbbbbbbb and cccccccccccccccccccccccc) {\n}"); 4108 4109 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa && bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 4110 " ccccccccccccccccccccccccc) {\n}"); 4111 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa and bbbbbbbbbbbbbbbbbbbbbbbb or\n" 4112 " ccccccccccccccccccccccccc) {\n}"); 4113 4114 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb ||\n" 4115 " ccccccccccccccccccccccccc) {\n}"); 4116 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb or\n" 4117 " ccccccccccccccccccccccccc) {\n}"); 4118 4119 verifyFormat( 4120 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa || bbbbbbbbbbbbbbbbbbbbbbbbb) &&\n" 4121 " ccccccccccccccccccccccccc) {\n}"); 4122 verifyFormat( 4123 "if ((aaaaaaaaaaaaaaaaaaaaaaaaa or bbbbbbbbbbbbbbbbbbbbbbbbb) and\n" 4124 " ccccccccccccccccccccccccc) {\n}"); 4125 4126 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA ||\n" 4127 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB ||\n" 4128 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC ||\n" 4129 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 4130 verifyFormat("return aaaa & AAAAAAAAAAAAAAAAAAAAAAAAAAAAA or\n" 4131 " bbbb & BBBBBBBBBBBBBBBBBBBBBBBBBBBBB or\n" 4132 " cccc & CCCCCCCCCCCCCCCCCCCCCCCCCC or\n" 4133 " dddd & DDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDDD;"); 4134 4135 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa ||\n" 4136 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) &&\n" 4137 " aaaaaaaaaaaaaaa != aa) {\n}"); 4138 verifyFormat("if ((aaaaaaaaaa != aaaaaaaaaaaaaaa or\n" 4139 " aaaaaaaaaaaaaaaaaaaaaaaa() >= aaaaaaaaaaaaaaaaaaaa) and\n" 4140 " aaaaaaaaaaaaaaa != aa) {\n}"); 4141 } 4142 4143 TEST_F(FormatTest, BreaksAfterAssignments) { 4144 verifyFormat( 4145 "unsigned Cost =\n" 4146 " TTI.getMemoryOpCost(I->getOpcode(), VectorTy, SI->getAlignment(),\n" 4147 " SI->getPointerAddressSpaceee());\n"); 4148 verifyFormat( 4149 "CharSourceRange LineRange = CharSourceRange::getTokenRange(\n" 4150 " Line.Tokens.front().Tok.getLo(), Line.Tokens.back().Tok.getLoc());"); 4151 4152 verifyFormat( 4153 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaa = aaaaaaaaaaaaaa(0).aaaa().aaaaaaaaa(\n" 4154 " aaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaa);"); 4155 verifyFormat("unsigned OriginalStartColumn =\n" 4156 " SourceMgr.getSpellingColumnNumber(\n" 4157 " Current.FormatTok.getStartOfNonWhitespace()) -\n" 4158 " 1;"); 4159 } 4160 4161 TEST_F(FormatTest, AlignsAfterAssignments) { 4162 verifyFormat( 4163 "int Result = aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4164 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 4165 verifyFormat( 4166 "Result += aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4167 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 4168 verifyFormat( 4169 "Result >>= aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4170 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 4171 verifyFormat( 4172 "int Result = (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4173 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 4174 verifyFormat( 4175 "double LooooooooooooooooooooooooongResult = aaaaaaaaaaaaaaaaaaaaaaaa +\n" 4176 " aaaaaaaaaaaaaaaaaaaaaaaa +\n" 4177 " aaaaaaaaaaaaaaaaaaaaaaaa;"); 4178 } 4179 4180 TEST_F(FormatTest, AlignsAfterReturn) { 4181 verifyFormat( 4182 "return aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4183 " aaaaaaaaaaaaaaaaaaaaaaaaa;"); 4184 verifyFormat( 4185 "return (aaaaaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4186 " aaaaaaaaaaaaaaaaaaaaaaaaa);"); 4187 verifyFormat( 4188 "return aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 4189 " aaaaaaaaaaaaaaaaaaaaaa();"); 4190 verifyFormat( 4191 "return (aaaaaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >=\n" 4192 " aaaaaaaaaaaaaaaaaaaaaa());"); 4193 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4194 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4195 verifyFormat("return aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4196 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) &&\n" 4197 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4198 verifyFormat("return\n" 4199 " // true if code is one of a or b.\n" 4200 " code == a || code == b;"); 4201 } 4202 4203 TEST_F(FormatTest, AlignsAfterOpenBracket) { 4204 verifyFormat( 4205 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaa aaaaaaaa,\n" 4206 " aaaaaaaaa aaaaaaa) {}"); 4207 verifyFormat( 4208 "SomeLongVariableName->someVeryLongFunctionName(aaaaaaaaaaa aaaaaaaaa,\n" 4209 " aaaaaaaaaaa aaaaaaaaa);"); 4210 verifyFormat( 4211 "SomeLongVariableName->someFunction(foooooooo(aaaaaaaaaaaaaaa,\n" 4212 " aaaaaaaaaaaaaaaaaaaaa));"); 4213 FormatStyle Style = getLLVMStyle(); 4214 Style.AlignAfterOpenBracket = false; 4215 verifyFormat( 4216 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4217 " aaaaaaaaaaa aaaaaaaa, aaaaaaaaa aaaaaaa) {}", 4218 Style); 4219 verifyFormat( 4220 "SomeLongVariableName->someVeryLongFunctionName(\n" 4221 " aaaaaaaaaaa aaaaaaaaa, aaaaaaaaaaa aaaaaaaaa);", 4222 Style); 4223 verifyFormat( 4224 "SomeLongVariableName->someFunction(\n" 4225 " foooooooo(aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaa));", 4226 Style); 4227 verifyFormat( 4228 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaa aaaaaaaa,\n" 4229 " aaaaaaaaa aaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {}", 4230 Style); 4231 verifyFormat( 4232 "SomeLongVariableName->someVeryLongFunctionName(aaaaaaaaaaa aaaaaaaaa,\n" 4233 " aaaaaaaaaaa aaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4234 Style); 4235 verifyFormat( 4236 "SomeLongVariableName->someFunction(foooooooo(aaaaaaaaaaaaaaa,\n" 4237 " aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa));", 4238 Style); 4239 } 4240 4241 TEST_F(FormatTest, ParenthesesAndOperandAlignment) { 4242 FormatStyle Style = getLLVMStyleWithColumns(40); 4243 verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" 4244 " bbbbbbbbbbbbbbbbbbbbbb);", 4245 Style); 4246 Style.AlignAfterOpenBracket = true; 4247 Style.AlignOperands = false; 4248 verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" 4249 " bbbbbbbbbbbbbbbbbbbbbb);", 4250 Style); 4251 Style.AlignAfterOpenBracket = false; 4252 Style.AlignOperands = true; 4253 verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" 4254 " bbbbbbbbbbbbbbbbbbbbbb);", 4255 Style); 4256 Style.AlignAfterOpenBracket = false; 4257 Style.AlignOperands = false; 4258 verifyFormat("int a = f(aaaaaaaaaaaaaaaaaaaaaa &&\n" 4259 " bbbbbbbbbbbbbbbbbbbbbb);", 4260 Style); 4261 } 4262 4263 TEST_F(FormatTest, BreaksConditionalExpressions) { 4264 verifyFormat( 4265 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4266 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4267 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4268 verifyFormat( 4269 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4270 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4271 verifyFormat( 4272 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa)\n" 4273 " : aaaaaaaaaaaaa);"); 4274 verifyFormat( 4275 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4276 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4277 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4278 " aaaaaaaaaaaaa);"); 4279 verifyFormat( 4280 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4281 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4282 " aaaaaaaaaaaaa);"); 4283 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4284 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4285 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4286 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4287 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4288 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4289 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4290 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4291 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4292 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4293 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4294 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4295 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4296 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4297 " ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4298 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4299 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4300 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4301 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4302 " : aaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4303 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 4304 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4305 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4306 " : aaaaaaaaaaaaaaaa;"); 4307 verifyFormat( 4308 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4309 " ? aaaaaaaaaaaaaaa\n" 4310 " : aaaaaaaaaaaaaaa;"); 4311 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 4312 " aaaaaaaaa\n" 4313 " ? b\n" 4314 " : c);"); 4315 verifyFormat("return aaaa == bbbb\n" 4316 " // comment\n" 4317 " ? aaaa\n" 4318 " : bbbb;"); 4319 verifyFormat( 4320 "unsigned Indent =\n" 4321 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0\n" 4322 " ? IndentForLevel[TheLine.Level]\n" 4323 " : TheLine * 2,\n" 4324 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 4325 getLLVMStyleWithColumns(70)); 4326 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 4327 " ? aaaaaaaaaaaaaaa\n" 4328 " : bbbbbbbbbbbbbbb //\n" 4329 " ? ccccccccccccccc\n" 4330 " : ddddddddddddddd;"); 4331 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa //\n" 4332 " ? aaaaaaaaaaaaaaa\n" 4333 " : (bbbbbbbbbbbbbbb //\n" 4334 " ? ccccccccccccccc\n" 4335 " : ddddddddddddddd);"); 4336 verifyFormat( 4337 "int aaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4338 " ? aaaaaaaaaaaaaaaaaaaaaaaaa +\n" 4339 " aaaaaaaaaaaaaaaaaaaaa +\n" 4340 " aaaaaaaaaaaaaaaaaaaaa\n" 4341 " : aaaaaaaaaa;"); 4342 verifyFormat( 4343 "aaaaaa = aaaaaaaaaaaa\n" 4344 " ? aaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4345 " : aaaaaaaaaaaaaaaaaaaaaa\n" 4346 " : aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4347 4348 FormatStyle NoBinPacking = getLLVMStyle(); 4349 NoBinPacking.BinPackArguments = false; 4350 verifyFormat( 4351 "void f() {\n" 4352 " g(aaa,\n" 4353 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 4354 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4355 " ? aaaaaaaaaaaaaaa\n" 4356 " : aaaaaaaaaaaaaaa);\n" 4357 "}", 4358 NoBinPacking); 4359 verifyFormat( 4360 "void f() {\n" 4361 " g(aaa,\n" 4362 " aaaaaaaaaa == aaaaaaaaaa ? aaaa : aaaaa,\n" 4363 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4364 " ?: aaaaaaaaaaaaaaa);\n" 4365 "}", 4366 NoBinPacking); 4367 4368 verifyFormat("SomeFunction(aaaaaaaaaaaaaaaaa,\n" 4369 " // comment.\n" 4370 " ccccccccccccccccccccccccccccccccccccccc\n" 4371 " ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4372 " : bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);"); 4373 4374 // Assignments in conditional expressions. Apparently not uncommon :-(. 4375 verifyFormat("return a != b\n" 4376 " // comment\n" 4377 " ? a = b\n" 4378 " : a = b;"); 4379 verifyFormat("return a != b\n" 4380 " // comment\n" 4381 " ? a = a != b\n" 4382 " // comment\n" 4383 " ? a = b\n" 4384 " : a\n" 4385 " : a;\n"); 4386 verifyFormat("return a != b\n" 4387 " // comment\n" 4388 " ? a\n" 4389 " : a = a != b\n" 4390 " // comment\n" 4391 " ? a = b\n" 4392 " : a;"); 4393 } 4394 4395 TEST_F(FormatTest, BreaksConditionalExpressionsAfterOperator) { 4396 FormatStyle Style = getLLVMStyle(); 4397 Style.BreakBeforeTernaryOperators = false; 4398 Style.ColumnLimit = 70; 4399 verifyFormat( 4400 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4401 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4402 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4403 Style); 4404 verifyFormat( 4405 "aaaa(aaaaaaaaaaaaaaaaaaaa, aaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4406 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4407 Style); 4408 verifyFormat( 4409 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaa ? aaaa(aaaaaa) :\n" 4410 " aaaaaaaaaaaaa);", 4411 Style); 4412 verifyFormat( 4413 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4414 " aaaaaaaaaaaaaaaa ? aaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4415 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4416 " aaaaaaaaaaaaa);", 4417 Style); 4418 verifyFormat( 4419 "aaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4420 " aaaaaaaaaaaaaaaa ?: aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4421 " aaaaaaaaaaaaa);", 4422 Style); 4423 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4424 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4425 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 4426 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4427 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4428 Style); 4429 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4430 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4431 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4432 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) :\n" 4433 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4434 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4435 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4436 Style); 4437 verifyFormat("aaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4438 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?:\n" 4439 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4440 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa),\n" 4441 " aaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4442 Style); 4443 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4444 " aaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4445 " aaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4446 Style); 4447 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaa =\n" 4448 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4449 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa :\n" 4450 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4451 Style); 4452 verifyFormat( 4453 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa == aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ?\n" 4454 " aaaaaaaaaaaaaaa :\n" 4455 " aaaaaaaaaaaaaaa;", 4456 Style); 4457 verifyFormat("f(aaaaaaaaaaaaaaaa == // force break\n" 4458 " aaaaaaaaa ?\n" 4459 " b :\n" 4460 " c);", 4461 Style); 4462 verifyFormat( 4463 "unsigned Indent =\n" 4464 " format(TheLine.First, IndentForLevel[TheLine.Level] >= 0 ?\n" 4465 " IndentForLevel[TheLine.Level] :\n" 4466 " TheLine * 2,\n" 4467 " TheLine.InPPDirective, PreviousEndOfLineColumn);", 4468 Style); 4469 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 4470 " aaaaaaaaaaaaaaa :\n" 4471 " bbbbbbbbbbbbbbb ? //\n" 4472 " ccccccccccccccc :\n" 4473 " ddddddddddddddd;", 4474 Style); 4475 verifyFormat("bool aaaaaa = aaaaaaaaaaaaa ? //\n" 4476 " aaaaaaaaaaaaaaa :\n" 4477 " (bbbbbbbbbbbbbbb ? //\n" 4478 " ccccccccccccccc :\n" 4479 " ddddddddddddddd);", 4480 Style); 4481 } 4482 4483 TEST_F(FormatTest, DeclarationsOfMultipleVariables) { 4484 verifyFormat("bool aaaaaaaaaaaaaaaaa = aaaaaa->aaaaaaaaaaaaaaaaa(),\n" 4485 " aaaaaaaaaaa = aaaaaa->aaaaaaaaaaa();"); 4486 verifyFormat("bool a = true, b = false;"); 4487 4488 verifyFormat("bool aaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4489 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaa),\n" 4490 " bbbbbbbbbbbbbbbbbbbbbbbbb =\n" 4491 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb(bbbbbbbbbbbbbbbb);"); 4492 verifyFormat( 4493 "bool aaaaaaaaaaaaaaaaaaaaa =\n" 4494 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb && cccccccccccccccccccccccccccc,\n" 4495 " d = e && f;"); 4496 verifyFormat("aaaaaaaaa a = aaaaaaaaaaaaaaaaaaaa, b = bbbbbbbbbbbbbbbbbbbb,\n" 4497 " c = cccccccccccccccccccc, d = dddddddddddddddddddd;"); 4498 verifyFormat("aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" 4499 " *c = ccccccccccccccccccc, *d = ddddddddddddddddddd;"); 4500 verifyFormat("aaaaaaaaa ***a = aaaaaaaaaaaaaaaaaaa, ***b = bbbbbbbbbbbbbbb,\n" 4501 " ***c = ccccccccccccccccccc, ***d = ddddddddddddddd;"); 4502 4503 FormatStyle Style = getGoogleStyle(); 4504 Style.PointerAlignment = FormatStyle::PAS_Left; 4505 Style.DerivePointerAlignment = false; 4506 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4507 " *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaa,\n" 4508 " *b = bbbbbbbbbbbbbbbbbbb;", 4509 Style); 4510 verifyFormat( 4511 "aaaaaaaaa *a = aaaaaaaaaaaaaaaaaaa, *b = bbbbbbbbbbbbbbbbbbb,\n" 4512 " *b = bbbbbbbbbbbbbbbbbbb, *d = ddddddddddddddddddd;", 4513 Style); 4514 } 4515 4516 TEST_F(FormatTest, ConditionalExpressionsInBrackets) { 4517 verifyFormat("arr[foo ? bar : baz];"); 4518 verifyFormat("f()[foo ? bar : baz];"); 4519 verifyFormat("(a + b)[foo ? bar : baz];"); 4520 verifyFormat("arr[foo ? (4 > 5 ? 4 : 5) : 5 < 5 ? 5 : 7];"); 4521 } 4522 4523 TEST_F(FormatTest, AlignsStringLiterals) { 4524 verifyFormat("loooooooooooooooooooooooooongFunction(\"short literal \"\n" 4525 " \"short literal\");"); 4526 verifyFormat( 4527 "looooooooooooooooooooooooongFunction(\n" 4528 " \"short literal\"\n" 4529 " \"looooooooooooooooooooooooooooooooooooooooooooooooong literal\");"); 4530 verifyFormat("someFunction(\"Always break between multi-line\"\n" 4531 " \" string literals\",\n" 4532 " and, other, parameters);"); 4533 EXPECT_EQ("fun + \"1243\" /* comment */\n" 4534 " \"5678\";", 4535 format("fun + \"1243\" /* comment */\n" 4536 " \"5678\";", 4537 getLLVMStyleWithColumns(28))); 4538 EXPECT_EQ( 4539 "aaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 4540 " \"aaaaaaaaaaaaaaaaaaaaa\"\n" 4541 " \"aaaaaaaaaaaaaaaa\";", 4542 format("aaaaaa =" 4543 "\"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaaaa " 4544 "aaaaaaaaaaaaaaaaaaaaa\" " 4545 "\"aaaaaaaaaaaaaaaa\";")); 4546 verifyFormat("a = a + \"a\"\n" 4547 " \"a\"\n" 4548 " \"a\";"); 4549 verifyFormat("f(\"a\", \"b\"\n" 4550 " \"c\");"); 4551 4552 verifyFormat( 4553 "#define LL_FORMAT \"ll\"\n" 4554 "printf(\"aaaaa: %d, bbbbbb: %\" LL_FORMAT \"d, cccccccc: %\" LL_FORMAT\n" 4555 " \"d, ddddddddd: %\" LL_FORMAT \"d\");"); 4556 4557 verifyFormat("#define A(X) \\\n" 4558 " \"aaaaa\" #X \"bbbbbb\" \\\n" 4559 " \"ccccc\"", 4560 getLLVMStyleWithColumns(23)); 4561 verifyFormat("#define A \"def\"\n" 4562 "f(\"abc\" A \"ghi\"\n" 4563 " \"jkl\");"); 4564 4565 verifyFormat("f(L\"a\"\n" 4566 " L\"b\")"); 4567 verifyFormat("#define A(X) \\\n" 4568 " L\"aaaaa\" #X L\"bbbbbb\" \\\n" 4569 " L\"ccccc\"", 4570 getLLVMStyleWithColumns(25)); 4571 } 4572 4573 TEST_F(FormatTest, AlwaysBreakAfterDefinitionReturnType) { 4574 FormatStyle AfterType = getLLVMStyle(); 4575 AfterType.AlwaysBreakAfterDefinitionReturnType = true; 4576 verifyFormat("const char *\n" 4577 "f(void) {\n" // Break here. 4578 " return \"\";\n" 4579 "}\n" 4580 "const char *bar(void);\n", // No break here. 4581 AfterType); 4582 verifyFormat("template <class T>\n" 4583 "T *\n" 4584 "f(T &c) {\n" // Break here. 4585 " return NULL;\n" 4586 "}\n" 4587 "template <class T> T *f(T &c);\n", // No break here. 4588 AfterType); 4589 AfterType.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 4590 verifyFormat("const char *\n" 4591 "f(void)\n" // Break here. 4592 "{\n" 4593 " return \"\";\n" 4594 "}\n" 4595 "const char *bar(void);\n", // No break here. 4596 AfterType); 4597 verifyFormat("template <class T>\n" 4598 "T *\n" // Problem here: no line break 4599 "f(T &c)\n" // Break here. 4600 "{\n" 4601 " return NULL;\n" 4602 "}\n" 4603 "template <class T> T *f(T &c);\n", // No break here. 4604 AfterType); 4605 } 4606 4607 TEST_F(FormatTest, AlwaysBreakBeforeMultilineStrings) { 4608 FormatStyle NoBreak = getLLVMStyle(); 4609 NoBreak.AlwaysBreakBeforeMultilineStrings = false; 4610 FormatStyle Break = getLLVMStyle(); 4611 Break.AlwaysBreakBeforeMultilineStrings = true; 4612 verifyFormat("aaaa = \"bbbb\"\n" 4613 " \"cccc\";", 4614 NoBreak); 4615 verifyFormat("aaaa =\n" 4616 " \"bbbb\"\n" 4617 " \"cccc\";", 4618 Break); 4619 verifyFormat("aaaa(\"bbbb\"\n" 4620 " \"cccc\");", 4621 NoBreak); 4622 verifyFormat("aaaa(\n" 4623 " \"bbbb\"\n" 4624 " \"cccc\");", 4625 Break); 4626 verifyFormat("aaaa(qqq, \"bbbb\"\n" 4627 " \"cccc\");", 4628 NoBreak); 4629 verifyFormat("aaaa(qqq,\n" 4630 " \"bbbb\"\n" 4631 " \"cccc\");", 4632 Break); 4633 verifyFormat("aaaa(qqq,\n" 4634 " L\"bbbb\"\n" 4635 " L\"cccc\");", 4636 Break); 4637 4638 // As we break before unary operators, breaking right after them is bad. 4639 verifyFormat("string foo = abc ? \"x\"\n" 4640 " \"blah blah blah blah blah blah\"\n" 4641 " : \"y\";", 4642 Break); 4643 4644 // Don't break if there is no column gain. 4645 verifyFormat("f(\"aaaa\"\n" 4646 " \"bbbb\");", 4647 Break); 4648 4649 // Treat literals with escaped newlines like multi-line string literals. 4650 EXPECT_EQ("x = \"a\\\n" 4651 "b\\\n" 4652 "c\";", 4653 format("x = \"a\\\n" 4654 "b\\\n" 4655 "c\";", 4656 NoBreak)); 4657 EXPECT_EQ("x =\n" 4658 " \"a\\\n" 4659 "b\\\n" 4660 "c\";", 4661 format("x = \"a\\\n" 4662 "b\\\n" 4663 "c\";", 4664 Break)); 4665 4666 // Exempt ObjC strings for now. 4667 EXPECT_EQ("NSString *const kString = @\"aaaa\"\n" 4668 " \"bbbb\";", 4669 format("NSString *const kString = @\"aaaa\"\n" 4670 "\"bbbb\";", 4671 Break)); 4672 4673 Break.ColumnLimit = 0; 4674 verifyFormat("const char *hello = \"hello llvm\";", Break); 4675 } 4676 4677 TEST_F(FormatTest, AlignsPipes) { 4678 verifyFormat( 4679 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4680 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4681 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4682 verifyFormat( 4683 "aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaa\n" 4684 " << aaaaaaaaaaaaaaaaaaaa;"); 4685 verifyFormat( 4686 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4687 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4688 verifyFormat( 4689 "llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"\n" 4690 " \"bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb\"\n" 4691 " << \"ccccccccccccccccccccccccccccccccccccccccccccccccc\";"); 4692 verifyFormat( 4693 "aaaaaaaa << (aaaaaaaaaaaaaaaaaaa << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4694 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4695 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4696 verifyFormat( 4697 "llvm::errs() << \"a: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4698 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4699 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4700 verifyFormat( 4701 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4702 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4703 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4704 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4705 verifyFormat( 4706 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4707 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4708 4709 verifyFormat("return out << \"somepacket = {\\n\"\n" 4710 " << \" aaaaaa = \" << pkt.aaaaaa << \"\\n\"\n" 4711 " << \" bbbb = \" << pkt.bbbb << \"\\n\"\n" 4712 " << \" cccccc = \" << pkt.cccccc << \"\\n\"\n" 4713 " << \" ddd = [\" << pkt.ddd << \"]\\n\"\n" 4714 " << \"}\";"); 4715 4716 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 4717 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa\n" 4718 " << \"aaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaa;"); 4719 verifyFormat( 4720 "llvm::outs() << \"aaaaaaaaaaaaaaaaa = \" << aaaaaaaaaaaaaaaaa\n" 4721 " << \"bbbbbbbbbbbbbbbbb = \" << bbbbbbbbbbbbbbbbb\n" 4722 " << \"ccccccccccccccccc = \" << ccccccccccccccccc\n" 4723 " << \"ddddddddddddddddd = \" << ddddddddddddddddd\n" 4724 " << \"eeeeeeeeeeeeeeeee = \" << eeeeeeeeeeeeeeeee;"); 4725 verifyFormat("llvm::outs() << aaaaaaaaaaaaaaaaaaaaaaaa << \"=\"\n" 4726 " << bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 4727 verifyFormat( 4728 "void f() {\n" 4729 " llvm::outs() << \"aaaaaaaaaaaaaaaaaaaa: \"\n" 4730 " << aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaa);\n" 4731 "}"); 4732 verifyFormat("llvm::outs() << \"aaaaaaaaaaaaaaaa: \"\n" 4733 " << aaaaaaaa.aaaaaaaaaaaa(aaa)->aaaaaaaaaaaaaa();"); 4734 4735 // Breaking before the first "<<" is generally not desirable. 4736 verifyFormat( 4737 "llvm::errs()\n" 4738 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4739 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4740 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4741 " << \"aaaaaaaaaaaaaaaaaaa: \" << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4742 getLLVMStyleWithColumns(70)); 4743 verifyFormat("llvm::errs() << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4744 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4745 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4746 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4747 " << \"aaaaaaaaaaaaaaaaaaa: \"\n" 4748 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaa;", 4749 getLLVMStyleWithColumns(70)); 4750 4751 // But sometimes, breaking before the first "<<" is desirable. 4752 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaa, aaaaaaaa)\n" 4753 " << aaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaa);"); 4754 verifyFormat("Diag(aaaaaaaaaaaaaaaaaaaaaaaaaaaaa, bbbbbbbbb)\n" 4755 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4756 " << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4757 verifyFormat("SemaRef.Diag(Loc, diag::note_for_range_begin_end)\n" 4758 " << BEF << IsTemplate << Description << E->getType();"); 4759 4760 verifyFormat( 4761 "llvm::errs() << aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4762 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4763 4764 // Incomplete string literal. 4765 EXPECT_EQ("llvm::errs() << \"\n" 4766 " << a;", 4767 format("llvm::errs() << \"\n<<a;")); 4768 4769 verifyFormat("void f() {\n" 4770 " CHECK_EQ(aaaa, (*bbbbbbbbb)->cccccc)\n" 4771 " << \"qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\";\n" 4772 "}"); 4773 4774 // Handle 'endl'. 4775 verifyFormat("llvm::errs() << aaaaaaaaaaaaaaaaaaaaaa << endl\n" 4776 " << bbbbbbbbbbbbbbbbbbbbbb << endl;"); 4777 verifyFormat("llvm::errs() << endl << bbbbbbbbbbbbbbbbbbbbbb << endl;"); 4778 } 4779 4780 TEST_F(FormatTest, UnderstandsEquals) { 4781 verifyFormat( 4782 "aaaaaaaaaaaaaaaaa =\n" 4783 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 4784 verifyFormat( 4785 "if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4786 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 4787 verifyFormat( 4788 "if (a) {\n" 4789 " f();\n" 4790 "} else if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4791 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n" 4792 "}"); 4793 4794 verifyFormat("if (int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 4795 " 100000000 + 10000000) {\n}"); 4796 } 4797 4798 TEST_F(FormatTest, WrapsAtFunctionCallsIfNecessary) { 4799 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 4800 " .looooooooooooooooooooooooooooooooooooooongFunction();"); 4801 4802 verifyFormat("LoooooooooooooooooooooooooooooooooooooongObject\n" 4803 " ->looooooooooooooooooooooooooooooooooooooongFunction();"); 4804 4805 verifyFormat( 4806 "LooooooooooooooooooooooooooooooooongObject->shortFunction(Parameter1,\n" 4807 " Parameter2);"); 4808 4809 verifyFormat( 4810 "ShortObject->shortFunction(\n" 4811 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter1,\n" 4812 " LooooooooooooooooooooooooooooooooooooooooooooooongParameter2);"); 4813 4814 verifyFormat("loooooooooooooongFunction(\n" 4815 " LoooooooooooooongObject->looooooooooooooooongFunction());"); 4816 4817 verifyFormat( 4818 "function(LoooooooooooooooooooooooooooooooooooongObject\n" 4819 " ->loooooooooooooooooooooooooooooooooooooooongFunction());"); 4820 4821 verifyFormat("EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" 4822 " .WillRepeatedly(Return(SomeValue));"); 4823 verifyFormat("void f() {\n" 4824 " EXPECT_CALL(SomeObject, SomeFunction(Parameter))\n" 4825 " .Times(2)\n" 4826 " .WillRepeatedly(Return(SomeValue));\n" 4827 "}"); 4828 verifyFormat("SomeMap[std::pair(aaaaaaaaaaaa, bbbbbbbbbbbbbbb)].insert(\n" 4829 " ccccccccccccccccccccccc);"); 4830 verifyFormat("aaaaa(aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4831 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).aaaaa(aaaaa),\n" 4832 " aaaaaaaaaaaaaaaaaaaaa);"); 4833 verifyFormat("void f() {\n" 4834 " aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4835 " aaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa)->aaaaaaaaa());\n" 4836 "}"); 4837 verifyFormat( 4838 "aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4839 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4840 " .aaaaaaaaaaaaaaa(aa(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4841 " aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4842 " aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 4843 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4844 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4845 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 4846 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa()) {\n" 4847 "}"); 4848 4849 // Here, it is not necessary to wrap at "." or "->". 4850 verifyFormat("if (aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaa) ||\n" 4851 " aaaa.aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa) {\n}"); 4852 verifyFormat( 4853 "aaaaaaaaaaa->aaaaaaaaa(\n" 4854 " aaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4855 " aaaaaaaaaaaaaaaaaa->aaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaa));\n"); 4856 4857 verifyFormat( 4858 "aaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4859 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa().aaaaaaaaaaaaaaaaa());"); 4860 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() *\n" 4861 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 4862 verifyFormat("a->aaaaaa()->aaaaaaaaaaa(aaaaaaaa()->aaaaaa()->aaaaa() ||\n" 4863 " aaaaaaaaa()->aaaaaa()->aaaaa());"); 4864 4865 // FIXME: Should we break before .a()? 4866 verifyFormat("aaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4867 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa).a();"); 4868 4869 FormatStyle NoBinPacking = getLLVMStyle(); 4870 NoBinPacking.BinPackParameters = false; 4871 verifyFormat("aaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 4872 " .aaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaa)\n" 4873 " .aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaa,\n" 4874 " aaaaaaaaaaaaaaaaaaa,\n" 4875 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);", 4876 NoBinPacking); 4877 4878 // If there is a subsequent call, change to hanging indentation. 4879 verifyFormat( 4880 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4881 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa))\n" 4882 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4883 verifyFormat( 4884 "aaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4885 " aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa));"); 4886 verifyFormat("aaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4887 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4888 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4889 verifyFormat("aaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4890 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 4891 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 4892 } 4893 4894 TEST_F(FormatTest, WrapsTemplateDeclarations) { 4895 verifyFormat("template <typename T>\n" 4896 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 4897 verifyFormat("template <typename T>\n" 4898 "// T should be one of {A, B}.\n" 4899 "virtual void loooooooooooongFunction(int Param1, int Param2);"); 4900 verifyFormat( 4901 "template <typename T>\n" 4902 "using comment_to_xml_conversion = comment_to_xml_conversion<T, int>;"); 4903 verifyFormat("template <typename T>\n" 4904 "void f(int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram1,\n" 4905 " int Paaaaaaaaaaaaaaaaaaaaaaaaaaaaaaram2);"); 4906 verifyFormat( 4907 "template <typename T>\n" 4908 "void looooooooooooooooooooongFunction(int Paaaaaaaaaaaaaaaaaaaaram1,\n" 4909 " int Paaaaaaaaaaaaaaaaaaaaram2);"); 4910 verifyFormat( 4911 "template <typename T>\n" 4912 "aaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaa,\n" 4913 " aaaaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaaaaa,\n" 4914 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4915 verifyFormat("template <typename T>\n" 4916 "void aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4917 " int aaaaaaaaaaaaaaaaaaaaaa);"); 4918 verifyFormat( 4919 "template <typename T1, typename T2 = char, typename T3 = char,\n" 4920 " typename T4 = char>\n" 4921 "void f();"); 4922 verifyFormat("template <typename aaaaaaaaaaa, typename bbbbbbbbbbbbb,\n" 4923 " template <typename> class cccccccccccccccccccccc,\n" 4924 " typename ddddddddddddd>\n" 4925 "class C {};"); 4926 verifyFormat( 4927 "aaaaaaaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa>(\n" 4928 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 4929 4930 verifyFormat("void f() {\n" 4931 " a<aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaa>(\n" 4932 " a(aaaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaa));\n" 4933 "}"); 4934 4935 verifyFormat("template <typename T> class C {};"); 4936 verifyFormat("template <typename T> void f();"); 4937 verifyFormat("template <typename T> void f() {}"); 4938 verifyFormat( 4939 "aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 4940 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4941 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> *aaaa =\n" 4942 " new aaaaaaaaaaaaa<aaaaaaaaaa, aaaaaaaaaaa,\n" 4943 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4944 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa>(\n" 4945 " bbbbbbbbbbbbbbbbbbbbbbbb);", 4946 getLLVMStyleWithColumns(72)); 4947 EXPECT_EQ("static_cast<A< //\n" 4948 " B> *>(\n" 4949 "\n" 4950 " );", 4951 format("static_cast<A<//\n" 4952 " B>*>(\n" 4953 "\n" 4954 " );")); 4955 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4956 " const typename aaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaa);"); 4957 4958 FormatStyle AlwaysBreak = getLLVMStyle(); 4959 AlwaysBreak.AlwaysBreakTemplateDeclarations = true; 4960 verifyFormat("template <typename T>\nclass C {};", AlwaysBreak); 4961 verifyFormat("template <typename T>\nvoid f();", AlwaysBreak); 4962 verifyFormat("template <typename T>\nvoid f() {}", AlwaysBreak); 4963 verifyFormat("void aaaaaaaaaaaaaaaaaaa<aaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 4964 " bbbbbbbbbbbbbbbbbbbbbbbbbbbb>(\n" 4965 " ccccccccccccccccccccccccccccccccccccccccccccccc);"); 4966 verifyFormat("template <template <typename> class Fooooooo,\n" 4967 " template <typename> class Baaaaaaar>\n" 4968 "struct C {};", 4969 AlwaysBreak); 4970 verifyFormat("template <typename T> // T can be A, B or C.\n" 4971 "struct C {};", 4972 AlwaysBreak); 4973 } 4974 4975 TEST_F(FormatTest, WrapsAtNestedNameSpecifiers) { 4976 verifyFormat( 4977 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4978 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4979 verifyFormat( 4980 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4981 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4982 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa());"); 4983 4984 // FIXME: Should we have the extra indent after the second break? 4985 verifyFormat( 4986 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4987 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 4988 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 4989 4990 verifyFormat( 4991 "aaaaaaaaaaaaaaa(bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb::\n" 4992 " cccccccccccccccccccccccccccccccccccccccccccccc());"); 4993 4994 // Breaking at nested name specifiers is generally not desirable. 4995 verifyFormat( 4996 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 4997 " aaaaaaaaaaaaaaaaaaaaaaa);"); 4998 4999 verifyFormat( 5000 "aaaaaaaaaaaaaaaaaa(aaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 5001 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5002 " aaaaaaaaaaaaaaaaaaaaa);", 5003 getLLVMStyleWithColumns(74)); 5004 5005 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::\n" 5006 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5007 " .aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa();"); 5008 } 5009 5010 TEST_F(FormatTest, UnderstandsTemplateParameters) { 5011 verifyFormat("A<int> a;"); 5012 verifyFormat("A<A<A<int>>> a;"); 5013 verifyFormat("A<A<A<int, 2>, 3>, 4> a;"); 5014 verifyFormat("bool x = a < 1 || 2 > a;"); 5015 verifyFormat("bool x = 5 < f<int>();"); 5016 verifyFormat("bool x = f<int>() > 5;"); 5017 verifyFormat("bool x = 5 < a<int>::x;"); 5018 verifyFormat("bool x = a < 4 ? a > 2 : false;"); 5019 verifyFormat("bool x = f() ? a < 2 : a > 2;"); 5020 5021 verifyGoogleFormat("A<A<int>> a;"); 5022 verifyGoogleFormat("A<A<A<int>>> a;"); 5023 verifyGoogleFormat("A<A<A<A<int>>>> a;"); 5024 verifyGoogleFormat("A<A<int> > a;"); 5025 verifyGoogleFormat("A<A<A<int> > > a;"); 5026 verifyGoogleFormat("A<A<A<A<int> > > > a;"); 5027 verifyGoogleFormat("A<::A<int>> a;"); 5028 verifyGoogleFormat("A<::A> a;"); 5029 verifyGoogleFormat("A< ::A> a;"); 5030 verifyGoogleFormat("A< ::A<int> > a;"); 5031 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A> >> a;", getGoogleStyle())); 5032 EXPECT_EQ("A<A<A<A>>> a;", format("A<A<A<A>> > a;", getGoogleStyle())); 5033 EXPECT_EQ("A<::A<int>> a;", format("A< ::A<int>> a;", getGoogleStyle())); 5034 EXPECT_EQ("A<::A<int>> a;", format("A<::A<int> > a;", getGoogleStyle())); 5035 5036 verifyFormat("A<A>> a;", getChromiumStyle(FormatStyle::LK_Cpp)); 5037 5038 verifyFormat("test >> a >> b;"); 5039 verifyFormat("test << a >> b;"); 5040 5041 verifyFormat("f<int>();"); 5042 verifyFormat("template <typename T> void f() {}"); 5043 verifyFormat("struct A<std::enable_if<sizeof(T2) < sizeof(int32)>::type>;"); 5044 5045 // Not template parameters. 5046 verifyFormat("return a < b && c > d;"); 5047 verifyFormat("void f() {\n" 5048 " while (a < b && c > d) {\n" 5049 " }\n" 5050 "}"); 5051 verifyFormat("template <typename... Types>\n" 5052 "typename enable_if<0 < sizeof...(Types)>::type Foo() {}"); 5053 5054 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 5055 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaa);", 5056 getLLVMStyleWithColumns(60)); 5057 verifyFormat("static_assert(is_convertible<A &&, B>::value, \"AAA\");"); 5058 verifyFormat("Constructor(A... a) : a_(X<A>{std::forward<A>(a)}...) {}"); 5059 } 5060 5061 TEST_F(FormatTest, UnderstandsBinaryOperators) { 5062 verifyFormat("COMPARE(a, ==, b);"); 5063 } 5064 5065 TEST_F(FormatTest, UnderstandsPointersToMembers) { 5066 verifyFormat("int A::*x;"); 5067 verifyFormat("int (S::*func)(void *);"); 5068 verifyFormat("void f() { int (S::*func)(void *); }"); 5069 verifyFormat("typedef bool *(Class::*Member)() const;"); 5070 verifyFormat("void f() {\n" 5071 " (a->*f)();\n" 5072 " a->*x;\n" 5073 " (a.*f)();\n" 5074 " ((*a).*f)();\n" 5075 " a.*x;\n" 5076 "}"); 5077 verifyFormat("void f() {\n" 5078 " (a->*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" 5079 " aaaa, bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb);\n" 5080 "}"); 5081 verifyFormat( 5082 "(aaaaaaaaaa->*bbbbbbb)(\n" 5083 " aaaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa));"); 5084 FormatStyle Style = getLLVMStyle(); 5085 Style.PointerAlignment = FormatStyle::PAS_Left; 5086 verifyFormat("typedef bool* (Class::*Member)() const;", Style); 5087 } 5088 5089 TEST_F(FormatTest, UnderstandsUnaryOperators) { 5090 verifyFormat("int a = -2;"); 5091 verifyFormat("f(-1, -2, -3);"); 5092 verifyFormat("a[-1] = 5;"); 5093 verifyFormat("int a = 5 + -2;"); 5094 verifyFormat("if (i == -1) {\n}"); 5095 verifyFormat("if (i != -1) {\n}"); 5096 verifyFormat("if (i > -1) {\n}"); 5097 verifyFormat("if (i < -1) {\n}"); 5098 verifyFormat("++(a->f());"); 5099 verifyFormat("--(a->f());"); 5100 verifyFormat("(a->f())++;"); 5101 verifyFormat("a[42]++;"); 5102 verifyFormat("if (!(a->f())) {\n}"); 5103 5104 verifyFormat("a-- > b;"); 5105 verifyFormat("b ? -a : c;"); 5106 verifyFormat("n * sizeof char16;"); 5107 verifyFormat("n * alignof char16;", getGoogleStyle()); 5108 verifyFormat("sizeof(char);"); 5109 verifyFormat("alignof(char);", getGoogleStyle()); 5110 5111 verifyFormat("return -1;"); 5112 verifyFormat("switch (a) {\n" 5113 "case -1:\n" 5114 " break;\n" 5115 "}"); 5116 verifyFormat("#define X -1"); 5117 verifyFormat("#define X -kConstant"); 5118 5119 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {-5, +3};"); 5120 verifyFormat("const NSPoint kBrowserFrameViewPatternOffset = {+5, -3};"); 5121 5122 verifyFormat("int a = /* confusing comment */ -1;"); 5123 // FIXME: The space after 'i' is wrong, but hopefully, this is a rare case. 5124 verifyFormat("int a = i /* confusing comment */++;"); 5125 } 5126 5127 TEST_F(FormatTest, DoesNotIndentRelativeToUnaryOperators) { 5128 verifyFormat("if (!aaaaaaaaaa( // break\n" 5129 " aaaaa)) {\n" 5130 "}"); 5131 verifyFormat("aaaaaaaaaa(!aaaaaaaaaa( // break\n" 5132 " aaaaa));"); 5133 verifyFormat("*aaa = aaaaaaa( // break\n" 5134 " bbbbbb);"); 5135 } 5136 5137 TEST_F(FormatTest, UnderstandsOverloadedOperators) { 5138 verifyFormat("bool operator<();"); 5139 verifyFormat("bool operator>();"); 5140 verifyFormat("bool operator=();"); 5141 verifyFormat("bool operator==();"); 5142 verifyFormat("bool operator!=();"); 5143 verifyFormat("int operator+();"); 5144 verifyFormat("int operator++();"); 5145 verifyFormat("bool operator();"); 5146 verifyFormat("bool operator()();"); 5147 verifyFormat("bool operator[]();"); 5148 verifyFormat("operator bool();"); 5149 verifyFormat("operator int();"); 5150 verifyFormat("operator void *();"); 5151 verifyFormat("operator SomeType<int>();"); 5152 verifyFormat("operator SomeType<int, int>();"); 5153 verifyFormat("operator SomeType<SomeType<int>>();"); 5154 verifyFormat("void *operator new(std::size_t size);"); 5155 verifyFormat("void *operator new[](std::size_t size);"); 5156 verifyFormat("void operator delete(void *ptr);"); 5157 verifyFormat("void operator delete[](void *ptr);"); 5158 verifyFormat("template <typename AAAAAAA, typename BBBBBBB>\n" 5159 "AAAAAAA operator/(const AAAAAAA &a, BBBBBBB &b);"); 5160 5161 verifyFormat( 5162 "ostream &operator<<(ostream &OutputStream,\n" 5163 " SomeReallyLongType WithSomeReallyLongValue);"); 5164 verifyFormat("bool operator<(const aaaaaaaaaaaaaaaaaaaaa &left,\n" 5165 " const aaaaaaaaaaaaaaaaaaaaa &right) {\n" 5166 " return left.group < right.group;\n" 5167 "}"); 5168 verifyFormat("SomeType &operator=(const SomeType &S);"); 5169 verifyFormat("f.template operator()<int>();"); 5170 5171 verifyGoogleFormat("operator void*();"); 5172 verifyGoogleFormat("operator SomeType<SomeType<int>>();"); 5173 verifyGoogleFormat("operator ::A();"); 5174 5175 verifyFormat("using A::operator+;"); 5176 5177 verifyFormat("string // break\n" 5178 "operator()() & {}"); 5179 verifyFormat("string // break\n" 5180 "operator()() && {}"); 5181 } 5182 5183 TEST_F(FormatTest, UnderstandsFunctionRefQualification) { 5184 verifyFormat("Deleted &operator=(const Deleted &)& = default;"); 5185 verifyFormat("Deleted &operator=(const Deleted &)&& = delete;"); 5186 verifyFormat("SomeType MemberFunction(const Deleted &)& = delete;"); 5187 verifyFormat("SomeType MemberFunction(const Deleted &)&& = delete;"); 5188 verifyFormat("Deleted &operator=(const Deleted &)&;"); 5189 verifyFormat("Deleted &operator=(const Deleted &)&&;"); 5190 verifyFormat("SomeType MemberFunction(const Deleted &)&;"); 5191 verifyFormat("SomeType MemberFunction(const Deleted &)&&;"); 5192 5193 verifyGoogleFormat("Deleted& operator=(const Deleted&)& = default;"); 5194 verifyGoogleFormat("SomeType MemberFunction(const Deleted&)& = delete;"); 5195 verifyGoogleFormat("Deleted& operator=(const Deleted&)&;"); 5196 verifyGoogleFormat("SomeType MemberFunction(const Deleted&)&;"); 5197 5198 FormatStyle Spaces = getLLVMStyle(); 5199 Spaces.SpacesInCStyleCastParentheses = true; 5200 verifyFormat("Deleted &operator=(const Deleted &)& = default;", Spaces); 5201 verifyFormat("SomeType MemberFunction(const Deleted &)& = delete;", Spaces); 5202 verifyFormat("Deleted &operator=(const Deleted &)&;", Spaces); 5203 verifyFormat("SomeType MemberFunction(const Deleted &)&;", Spaces); 5204 5205 Spaces.SpacesInCStyleCastParentheses = false; 5206 Spaces.SpacesInParentheses = true; 5207 verifyFormat("Deleted &operator=( const Deleted & )& = default;", Spaces); 5208 verifyFormat("SomeType MemberFunction( const Deleted & )& = delete;", Spaces); 5209 verifyFormat("Deleted &operator=( const Deleted & )&;", Spaces); 5210 verifyFormat("SomeType MemberFunction( const Deleted & )&;", Spaces); 5211 } 5212 5213 TEST_F(FormatTest, UnderstandsNewAndDelete) { 5214 verifyFormat("void f() {\n" 5215 " A *a = new A;\n" 5216 " A *a = new (placement) A;\n" 5217 " delete a;\n" 5218 " delete (A *)a;\n" 5219 "}"); 5220 verifyFormat("new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" 5221 " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); 5222 verifyFormat("auto aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 5223 " new (aaaaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaa))\n" 5224 " typename aaaaaaaaaaaaaaaaaaaaaaaa();"); 5225 verifyFormat("delete[] h->p;"); 5226 } 5227 5228 TEST_F(FormatTest, UnderstandsUsesOfStarAndAmp) { 5229 verifyFormat("int *f(int *a) {}"); 5230 verifyFormat("int main(int argc, char **argv) {}"); 5231 verifyFormat("Test::Test(int b) : a(b * b) {}"); 5232 verifyIndependentOfContext("f(a, *a);"); 5233 verifyFormat("void g() { f(*a); }"); 5234 verifyIndependentOfContext("int a = b * 10;"); 5235 verifyIndependentOfContext("int a = 10 * b;"); 5236 verifyIndependentOfContext("int a = b * c;"); 5237 verifyIndependentOfContext("int a += b * c;"); 5238 verifyIndependentOfContext("int a -= b * c;"); 5239 verifyIndependentOfContext("int a *= b * c;"); 5240 verifyIndependentOfContext("int a /= b * c;"); 5241 verifyIndependentOfContext("int a = *b;"); 5242 verifyIndependentOfContext("int a = *b * c;"); 5243 verifyIndependentOfContext("int a = b * *c;"); 5244 verifyIndependentOfContext("return 10 * b;"); 5245 verifyIndependentOfContext("return *b * *c;"); 5246 verifyIndependentOfContext("return a & ~b;"); 5247 verifyIndependentOfContext("f(b ? *c : *d);"); 5248 verifyIndependentOfContext("int a = b ? *c : *d;"); 5249 verifyIndependentOfContext("*b = a;"); 5250 verifyIndependentOfContext("a * ~b;"); 5251 verifyIndependentOfContext("a * !b;"); 5252 verifyIndependentOfContext("a * +b;"); 5253 verifyIndependentOfContext("a * -b;"); 5254 verifyIndependentOfContext("a * ++b;"); 5255 verifyIndependentOfContext("a * --b;"); 5256 verifyIndependentOfContext("a[4] * b;"); 5257 verifyIndependentOfContext("a[a * a] = 1;"); 5258 verifyIndependentOfContext("f() * b;"); 5259 verifyIndependentOfContext("a * [self dostuff];"); 5260 verifyIndependentOfContext("int x = a * (a + b);"); 5261 verifyIndependentOfContext("(a *)(a + b);"); 5262 verifyIndependentOfContext("*(int *)(p & ~3UL) = 0;"); 5263 verifyIndependentOfContext("int *pa = (int *)&a;"); 5264 verifyIndependentOfContext("return sizeof(int **);"); 5265 verifyIndependentOfContext("return sizeof(int ******);"); 5266 verifyIndependentOfContext("return (int **&)a;"); 5267 verifyIndependentOfContext("f((*PointerToArray)[10]);"); 5268 verifyFormat("void f(Type (*parameter)[10]) {}"); 5269 verifyGoogleFormat("return sizeof(int**);"); 5270 verifyIndependentOfContext("Type **A = static_cast<Type **>(P);"); 5271 verifyGoogleFormat("Type** A = static_cast<Type**>(P);"); 5272 verifyFormat("auto a = [](int **&, int ***) {};"); 5273 verifyFormat("auto PointerBinding = [](const char *S) {};"); 5274 verifyFormat("typedef typeof(int(int, int)) *MyFunc;"); 5275 verifyFormat("[](const decltype(*a) &value) {}"); 5276 verifyIndependentOfContext("typedef void (*f)(int *a);"); 5277 verifyIndependentOfContext("int i{a * b};"); 5278 verifyIndependentOfContext("aaa && aaa->f();"); 5279 verifyIndependentOfContext("int x = ~*p;"); 5280 verifyFormat("Constructor() : a(a), area(width * height) {}"); 5281 verifyFormat("Constructor() : a(a), area(a, width * height) {}"); 5282 verifyFormat("void f() { f(a, c * d); }"); 5283 5284 verifyIndependentOfContext("InvalidRegions[*R] = 0;"); 5285 5286 verifyIndependentOfContext("A<int *> a;"); 5287 verifyIndependentOfContext("A<int **> a;"); 5288 verifyIndependentOfContext("A<int *, int *> a;"); 5289 verifyIndependentOfContext("A<int *[]> a;"); 5290 verifyIndependentOfContext( 5291 "const char *const p = reinterpret_cast<const char *const>(q);"); 5292 verifyIndependentOfContext("A<int **, int **> a;"); 5293 verifyIndependentOfContext("void f(int *a = d * e, int *b = c * d);"); 5294 verifyFormat("for (char **a = b; *a; ++a) {\n}"); 5295 verifyFormat("for (; a && b;) {\n}"); 5296 verifyFormat("bool foo = true && [] { return false; }();"); 5297 5298 verifyFormat( 5299 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 5300 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa, *aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 5301 5302 verifyGoogleFormat("**outparam = 1;"); 5303 verifyGoogleFormat("*outparam = a * b;"); 5304 verifyGoogleFormat("int main(int argc, char** argv) {}"); 5305 verifyGoogleFormat("A<int*> a;"); 5306 verifyGoogleFormat("A<int**> a;"); 5307 verifyGoogleFormat("A<int*, int*> a;"); 5308 verifyGoogleFormat("A<int**, int**> a;"); 5309 verifyGoogleFormat("f(b ? *c : *d);"); 5310 verifyGoogleFormat("int a = b ? *c : *d;"); 5311 verifyGoogleFormat("Type* t = **x;"); 5312 verifyGoogleFormat("Type* t = *++*x;"); 5313 verifyGoogleFormat("*++*x;"); 5314 verifyGoogleFormat("Type* t = const_cast<T*>(&*x);"); 5315 verifyGoogleFormat("Type* t = x++ * y;"); 5316 verifyGoogleFormat( 5317 "const char* const p = reinterpret_cast<const char* const>(q);"); 5318 verifyGoogleFormat("void f(int i = 0, SomeType** temps = NULL);"); 5319 verifyGoogleFormat("void f(Bar* a = nullptr, Bar* b);"); 5320 verifyGoogleFormat("template <typename T>\n" 5321 "void f(int i = 0, SomeType** temps = NULL);"); 5322 5323 FormatStyle Left = getLLVMStyle(); 5324 Left.PointerAlignment = FormatStyle::PAS_Left; 5325 verifyFormat("x = *a(x) = *a(y);", Left); 5326 5327 verifyIndependentOfContext("a = *(x + y);"); 5328 verifyIndependentOfContext("a = &(x + y);"); 5329 verifyIndependentOfContext("*(x + y).call();"); 5330 verifyIndependentOfContext("&(x + y)->call();"); 5331 verifyFormat("void f() { &(*I).first; }"); 5332 5333 verifyIndependentOfContext("f(b * /* confusing comment */ ++c);"); 5334 verifyFormat( 5335 "int *MyValues = {\n" 5336 " *A, // Operator detection might be confused by the '{'\n" 5337 " *BB // Operator detection might be confused by previous comment\n" 5338 "};"); 5339 5340 verifyIndependentOfContext("if (int *a = &b)"); 5341 verifyIndependentOfContext("if (int &a = *b)"); 5342 verifyIndependentOfContext("if (a & b[i])"); 5343 verifyIndependentOfContext("if (a::b::c::d & b[i])"); 5344 verifyIndependentOfContext("if (*b[i])"); 5345 verifyIndependentOfContext("if (int *a = (&b))"); 5346 verifyIndependentOfContext("while (int *a = &b)"); 5347 verifyIndependentOfContext("size = sizeof *a;"); 5348 verifyFormat("void f() {\n" 5349 " for (const int &v : Values) {\n" 5350 " }\n" 5351 "}"); 5352 verifyFormat("for (int i = a * a; i < 10; ++i) {\n}"); 5353 verifyFormat("for (int i = 0; i < a * a; ++i) {\n}"); 5354 verifyGoogleFormat("for (int i = 0; i * 2 < z; i *= 2) {\n}"); 5355 5356 verifyFormat("#define A (!a * b)"); 5357 verifyFormat("#define MACRO \\\n" 5358 " int *i = a * b; \\\n" 5359 " void f(a *b);", 5360 getLLVMStyleWithColumns(19)); 5361 5362 verifyIndependentOfContext("A = new SomeType *[Length];"); 5363 verifyIndependentOfContext("A = new SomeType *[Length]();"); 5364 verifyIndependentOfContext("T **t = new T *;"); 5365 verifyIndependentOfContext("T **t = new T *();"); 5366 verifyGoogleFormat("A = new SomeType* [Length]();"); 5367 verifyGoogleFormat("A = new SomeType* [Length];"); 5368 verifyGoogleFormat("T** t = new T*;"); 5369 verifyGoogleFormat("T** t = new T*();"); 5370 5371 FormatStyle PointerLeft = getLLVMStyle(); 5372 PointerLeft.PointerAlignment = FormatStyle::PAS_Left; 5373 verifyFormat("delete *x;", PointerLeft); 5374 verifyFormat("STATIC_ASSERT((a & b) == 0);"); 5375 verifyFormat("STATIC_ASSERT(0 == (a & b));"); 5376 verifyFormat("template <bool a, bool b> " 5377 "typename t::if<x && y>::type f() {}"); 5378 verifyFormat("template <int *y> f() {}"); 5379 verifyFormat("vector<int *> v;"); 5380 verifyFormat("vector<int *const> v;"); 5381 verifyFormat("vector<int *const **const *> v;"); 5382 verifyFormat("vector<int *volatile> v;"); 5383 verifyFormat("vector<a * b> v;"); 5384 verifyFormat("foo<b && false>();"); 5385 verifyFormat("foo<b & 1>();"); 5386 verifyFormat("decltype(*::std::declval<const T &>()) void F();"); 5387 verifyFormat( 5388 "template <class T, class = typename std::enable_if<\n" 5389 " std::is_integral<T>::value &&\n" 5390 " (sizeof(T) > 1 || sizeof(T) < 8)>::type>\n" 5391 "void F();", 5392 getLLVMStyleWithColumns(76)); 5393 verifyFormat( 5394 "template <class T,\n" 5395 " class = typename ::std::enable_if<\n" 5396 " ::std::is_array<T>{} && ::std::is_array<T>{}>::type>\n" 5397 "void F();", 5398 getGoogleStyleWithColumns(68)); 5399 5400 verifyIndependentOfContext("MACRO(int *i);"); 5401 verifyIndependentOfContext("MACRO(auto *a);"); 5402 verifyIndependentOfContext("MACRO(const A *a);"); 5403 verifyIndependentOfContext("MACRO('0' <= c && c <= '9');"); 5404 // FIXME: Is there a way to make this work? 5405 // verifyIndependentOfContext("MACRO(A *a);"); 5406 5407 verifyFormat("DatumHandle const *operator->() const { return input_; }"); 5408 5409 EXPECT_EQ("#define OP(x) \\\n" 5410 " ostream &operator<<(ostream &s, const A &a) { \\\n" 5411 " return s << a.DebugString(); \\\n" 5412 " }", 5413 format("#define OP(x) \\\n" 5414 " ostream &operator<<(ostream &s, const A &a) { \\\n" 5415 " return s << a.DebugString(); \\\n" 5416 " }", 5417 getLLVMStyleWithColumns(50))); 5418 5419 // FIXME: We cannot handle this case yet; we might be able to figure out that 5420 // foo<x> d > v; doesn't make sense. 5421 verifyFormat("foo<a<b && c> d> v;"); 5422 5423 FormatStyle PointerMiddle = getLLVMStyle(); 5424 PointerMiddle.PointerAlignment = FormatStyle::PAS_Middle; 5425 verifyFormat("delete *x;", PointerMiddle); 5426 verifyFormat("int * x;", PointerMiddle); 5427 verifyFormat("template <int * y> f() {}", PointerMiddle); 5428 verifyFormat("int * f(int * a) {}", PointerMiddle); 5429 verifyFormat("int main(int argc, char ** argv) {}", PointerMiddle); 5430 verifyFormat("Test::Test(int b) : a(b * b) {}", PointerMiddle); 5431 verifyFormat("A<int *> a;", PointerMiddle); 5432 verifyFormat("A<int **> a;", PointerMiddle); 5433 verifyFormat("A<int *, int *> a;", PointerMiddle); 5434 verifyFormat("A<int * []> a;", PointerMiddle); 5435 verifyFormat("A = new SomeType * [Length]();", PointerMiddle); 5436 verifyFormat("A = new SomeType * [Length];", PointerMiddle); 5437 verifyFormat("T ** t = new T *;", PointerMiddle); 5438 } 5439 5440 TEST_F(FormatTest, UnderstandsAttributes) { 5441 verifyFormat("SomeType s __attribute__((unused)) (InitValue);"); 5442 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa __attribute__((unused))\n" 5443 "aaaaaaaaaaaaaaaaaaaaaaa(int i);"); 5444 } 5445 5446 TEST_F(FormatTest, UnderstandsEllipsis) { 5447 verifyFormat("int printf(const char *fmt, ...);"); 5448 verifyFormat("template <class... Ts> void Foo(Ts... ts) { Foo(ts...); }"); 5449 verifyFormat("template <class... Ts> void Foo(Ts *... ts) {}"); 5450 5451 FormatStyle PointersLeft = getLLVMStyle(); 5452 PointersLeft.PointerAlignment = FormatStyle::PAS_Left; 5453 verifyFormat("template <class... Ts> void Foo(Ts*... ts) {}", PointersLeft); 5454 } 5455 5456 TEST_F(FormatTest, AdaptivelyFormatsPointersAndReferences) { 5457 EXPECT_EQ("int *a;\n" 5458 "int *a;\n" 5459 "int *a;", 5460 format("int *a;\n" 5461 "int* a;\n" 5462 "int *a;", 5463 getGoogleStyle())); 5464 EXPECT_EQ("int* a;\n" 5465 "int* a;\n" 5466 "int* a;", 5467 format("int* a;\n" 5468 "int* a;\n" 5469 "int *a;", 5470 getGoogleStyle())); 5471 EXPECT_EQ("int *a;\n" 5472 "int *a;\n" 5473 "int *a;", 5474 format("int *a;\n" 5475 "int * a;\n" 5476 "int * a;", 5477 getGoogleStyle())); 5478 } 5479 5480 TEST_F(FormatTest, UnderstandsRvalueReferences) { 5481 verifyFormat("int f(int &&a) {}"); 5482 verifyFormat("int f(int a, char &&b) {}"); 5483 verifyFormat("void f() { int &&a = b; }"); 5484 verifyGoogleFormat("int f(int a, char&& b) {}"); 5485 verifyGoogleFormat("void f() { int&& a = b; }"); 5486 5487 verifyIndependentOfContext("A<int &&> a;"); 5488 verifyIndependentOfContext("A<int &&, int &&> a;"); 5489 verifyGoogleFormat("A<int&&> a;"); 5490 verifyGoogleFormat("A<int&&, int&&> a;"); 5491 5492 // Not rvalue references: 5493 verifyFormat("template <bool B, bool C> class A {\n" 5494 " static_assert(B && C, \"Something is wrong\");\n" 5495 "};"); 5496 verifyGoogleFormat("#define IF(a, b, c) if (a && (b == c))"); 5497 verifyGoogleFormat("#define WHILE(a, b, c) while (a && (b == c))"); 5498 verifyFormat("#define A(a, b) (a && b)"); 5499 } 5500 5501 TEST_F(FormatTest, FormatsBinaryOperatorsPrecedingEquals) { 5502 verifyFormat("void f() {\n" 5503 " x[aaaaaaaaa -\n" 5504 " b] = 23;\n" 5505 "}", 5506 getLLVMStyleWithColumns(15)); 5507 } 5508 5509 TEST_F(FormatTest, FormatsCasts) { 5510 verifyFormat("Type *A = static_cast<Type *>(P);"); 5511 verifyFormat("Type *A = (Type *)P;"); 5512 verifyFormat("Type *A = (vector<Type *, int *>)P;"); 5513 verifyFormat("int a = (int)(2.0f);"); 5514 verifyFormat("int a = (int)2.0f;"); 5515 verifyFormat("x[(int32)y];"); 5516 verifyFormat("x = (int32)y;"); 5517 verifyFormat("#define AA(X) sizeof(((X *)NULL)->a)"); 5518 verifyFormat("int a = (int)*b;"); 5519 verifyFormat("int a = (int)2.0f;"); 5520 verifyFormat("int a = (int)~0;"); 5521 verifyFormat("int a = (int)++a;"); 5522 verifyFormat("int a = (int)sizeof(int);"); 5523 verifyFormat("int a = (int)+2;"); 5524 verifyFormat("my_int a = (my_int)2.0f;"); 5525 verifyFormat("my_int a = (my_int)sizeof(int);"); 5526 verifyFormat("return (my_int)aaa;"); 5527 verifyFormat("#define x ((int)-1)"); 5528 verifyFormat("#define LENGTH(x, y) (x) - (y) + 1"); 5529 verifyFormat("#define p(q) ((int *)&q)"); 5530 verifyFormat("fn(a)(b) + 1;"); 5531 5532 verifyFormat("void f() { my_int a = (my_int)*b; }"); 5533 verifyFormat("void f() { return P ? (my_int)*P : (my_int)0; }"); 5534 verifyFormat("my_int a = (my_int)~0;"); 5535 verifyFormat("my_int a = (my_int)++a;"); 5536 verifyFormat("my_int a = (my_int)-2;"); 5537 verifyFormat("my_int a = (my_int)1;"); 5538 verifyFormat("my_int a = (my_int *)1;"); 5539 verifyFormat("my_int a = (const my_int)-1;"); 5540 verifyFormat("my_int a = (const my_int *)-1;"); 5541 verifyFormat("my_int a = (my_int)(my_int)-1;"); 5542 5543 // FIXME: single value wrapped with paren will be treated as cast. 5544 verifyFormat("void f(int i = (kValue)*kMask) {}"); 5545 5546 verifyFormat("{ (void)F; }"); 5547 5548 // Don't break after a cast's 5549 verifyFormat("int aaaaaaaaaaaaaaaaaaaaaaaaaaa =\n" 5550 " (aaaaaaaaaaaaaaaaaaaaaaaaaa *)(aaaaaaaaaaaaaaaaaaaaaa +\n" 5551 " bbbbbbbbbbbbbbbbbbbbbb);"); 5552 5553 // These are not casts. 5554 verifyFormat("void f(int *) {}"); 5555 verifyFormat("f(foo)->b;"); 5556 verifyFormat("f(foo).b;"); 5557 verifyFormat("f(foo)(b);"); 5558 verifyFormat("f(foo)[b];"); 5559 verifyFormat("[](foo) { return 4; }(bar);"); 5560 verifyFormat("(*funptr)(foo)[4];"); 5561 verifyFormat("funptrs[4](foo)[4];"); 5562 verifyFormat("void f(int *);"); 5563 verifyFormat("void f(int *) = 0;"); 5564 verifyFormat("void f(SmallVector<int>) {}"); 5565 verifyFormat("void f(SmallVector<int>);"); 5566 verifyFormat("void f(SmallVector<int>) = 0;"); 5567 verifyFormat("void f(int i = (kA * kB) & kMask) {}"); 5568 verifyFormat("int a = sizeof(int) * b;"); 5569 verifyFormat("int a = alignof(int) * b;", getGoogleStyle()); 5570 verifyFormat("template <> void f<int>(int i) SOME_ANNOTATION;"); 5571 verifyFormat("f(\"%\" SOME_MACRO(ll) \"d\");"); 5572 verifyFormat("aaaaa &operator=(const aaaaa &) LLVM_DELETED_FUNCTION;"); 5573 5574 // These are not casts, but at some point were confused with casts. 5575 verifyFormat("virtual void foo(int *) override;"); 5576 verifyFormat("virtual void foo(char &) const;"); 5577 verifyFormat("virtual void foo(int *a, char *) const;"); 5578 verifyFormat("int a = sizeof(int *) + b;"); 5579 verifyFormat("int a = alignof(int *) + b;", getGoogleStyle()); 5580 5581 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *foo = (aaaaaaaaaaaaaaaaa *)\n" 5582 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb;"); 5583 // FIXME: The indentation here is not ideal. 5584 verifyFormat( 5585 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5586 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = (*cccccccccccccccc)\n" 5587 " [dddddddddddddddddddddddddddddddddddddddddddddddddddddddd];"); 5588 } 5589 5590 TEST_F(FormatTest, FormatsFunctionTypes) { 5591 verifyFormat("A<bool()> a;"); 5592 verifyFormat("A<SomeType()> a;"); 5593 verifyFormat("A<void (*)(int, std::string)> a;"); 5594 verifyFormat("A<void *(int)>;"); 5595 verifyFormat("void *(*a)(int *, SomeType *);"); 5596 verifyFormat("int (*func)(void *);"); 5597 verifyFormat("void f() { int (*func)(void *); }"); 5598 verifyFormat("template <class CallbackClass>\n" 5599 "using MyCallback = void (CallbackClass::*)(SomeObject *Data);"); 5600 5601 verifyGoogleFormat("A<void*(int*, SomeType*)>;"); 5602 verifyGoogleFormat("void* (*a)(int);"); 5603 verifyGoogleFormat( 5604 "template <class CallbackClass>\n" 5605 "using MyCallback = void (CallbackClass::*)(SomeObject* Data);"); 5606 5607 // Other constructs can look somewhat like function types: 5608 verifyFormat("A<sizeof(*x)> a;"); 5609 verifyFormat("#define DEREF_AND_CALL_F(x) f(*x)"); 5610 verifyFormat("some_var = function(*some_pointer_var)[0];"); 5611 verifyFormat("void f() { function(*some_pointer_var)[0] = 10; }"); 5612 } 5613 5614 TEST_F(FormatTest, FormatsPointersToArrayTypes) { 5615 verifyFormat("A (*foo_)[6];"); 5616 verifyFormat("vector<int> (*foo_)[6];"); 5617 } 5618 5619 TEST_F(FormatTest, BreaksLongVariableDeclarations) { 5620 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5621 " LoooooooooooooooooooooooooooooooooooooooongVariable;"); 5622 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType const\n" 5623 " LoooooooooooooooooooooooooooooooooooooooongVariable;"); 5624 5625 // Different ways of ()-initializiation. 5626 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5627 " LoooooooooooooooooooooooooooooooooooooooongVariable(1);"); 5628 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5629 " LoooooooooooooooooooooooooooooooooooooooongVariable(a);"); 5630 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType\n" 5631 " LoooooooooooooooooooooooooooooooooooooooongVariable({});"); 5632 } 5633 5634 TEST_F(FormatTest, BreaksLongDeclarations) { 5635 verifyFormat("typedef LoooooooooooooooooooooooooooooooooooooooongType\n" 5636 " AnotherNameForTheLongType;"); 5637 verifyFormat("typedef LongTemplateType<aaaaaaaaaaaaaaaaaaa()>\n" 5638 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 5639 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5640 "LoooooooooooooooooooooooooooooooongFunctionDeclaration();"); 5641 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5642 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5643 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType MACRO\n" 5644 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5645 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 5646 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5647 verifyFormat("decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" 5648 "LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}"); 5649 FormatStyle Indented = getLLVMStyle(); 5650 Indented.IndentWrappedFunctionNames = true; 5651 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5652 " LoooooooooooooooooooooooooooooooongFunctionDeclaration();", 5653 Indented); 5654 verifyFormat( 5655 "LoooooooooooooooooooooooooooooooooooooooongReturnType\n" 5656 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5657 Indented); 5658 verifyFormat( 5659 "LoooooooooooooooooooooooooooooooooooooooongReturnType const\n" 5660 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5661 Indented); 5662 verifyFormat( 5663 "decltype(LoooooooooooooooooooooooooooooooooooooooongName)\n" 5664 " LooooooooooooooooooooooooooooooooooongFunctionDefinition() {}", 5665 Indented); 5666 5667 // FIXME: Without the comment, this breaks after "(". 5668 verifyFormat("LoooooooooooooooooooooooooooooooooooooooongType // break\n" 5669 " (*LoooooooooooooooooooooooooooongFunctionTypeVarialbe)();", 5670 getGoogleStyle()); 5671 5672 verifyFormat("int *someFunction(int LoooooooooooooooooooongParam1,\n" 5673 " int LoooooooooooooooooooongParam2) {}"); 5674 verifyFormat( 5675 "TypeSpecDecl *TypeSpecDecl::Create(ASTContext &C, DeclContext *DC,\n" 5676 " SourceLocation L, IdentifierIn *II,\n" 5677 " Type *T) {}"); 5678 verifyFormat("ReallyLongReturnType<TemplateParam1, TemplateParam2>\n" 5679 "ReallyReallyLongFunctionName(\n" 5680 " const std::string &SomeParameter,\n" 5681 " const SomeType<string, SomeOtherTemplateParameter> &\n" 5682 " ReallyReallyLongParameterName,\n" 5683 " const SomeType<string, SomeOtherTemplateParameter> &\n" 5684 " AnotherLongParameterName) {}"); 5685 verifyFormat("template <typename A>\n" 5686 "SomeLoooooooooooooooooooooongType<\n" 5687 " typename some_namespace::SomeOtherType<A>::Type>\n" 5688 "Function() {}"); 5689 5690 verifyGoogleFormat( 5691 "aaaaaaaaaaaaaaaa::aaaaaaaaaaaaaaaa<aaaaaaaaaaaaa, aaaaaaaaaaaa>\n" 5692 " aaaaaaaaaaaaaaaaaaaaaaa;"); 5693 verifyGoogleFormat( 5694 "TypeSpecDecl* TypeSpecDecl::Create(ASTContext& C, DeclContext* DC,\n" 5695 " SourceLocation L) {}"); 5696 verifyGoogleFormat( 5697 "some_namespace::LongReturnType\n" 5698 "long_namespace::SomeVeryLongClass::SomeVeryLongFunction(\n" 5699 " int first_long_parameter, int second_parameter) {}"); 5700 5701 verifyGoogleFormat("template <typename T>\n" 5702 "aaaaaaaa::aaaaa::aaaaaa<T, aaaaaaaaaaaaaaaaaaaaaaaaa>\n" 5703 "aaaaaaaaaaaaaaaaaaaaaaaa<T>::aaaaaaa() {}"); 5704 verifyGoogleFormat("A<A<A>> aaaaaaaaaa(int aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5705 " int aaaaaaaaaaaaaaaaaaaaaaa);"); 5706 5707 verifyFormat("typedef size_t (*aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)(\n" 5708 " const aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa *\n" 5709 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 5710 } 5711 5712 TEST_F(FormatTest, FormatsArrays) { 5713 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5714 " [bbbbbbbbbbbbbbbbbbbbbbbbb] = c;"); 5715 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5716 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 5717 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5718 " [a][bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = cccccccc;"); 5719 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\n" 5720 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5721 " [bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb] = ccccccccccc;"); 5722 verifyFormat( 5723 "llvm::outs() << \"aaaaaaaaaaaa: \"\n" 5724 " << (*aaaaaaaiaaaaaaa)[aaaaaaaaaaaaaaaaaaaaaaaaa]\n" 5725 " [aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa];"); 5726 5727 verifyGoogleFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa<int>\n" 5728 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa[aaaaaaaaaaaa];"); 5729 verifyFormat( 5730 "aaaaaaaaaaa aaaaaaaaaaaaaaa = aaaaaaaaaaaaaaaaaaaaaaaaaa->aaaaaaaaa[0]\n" 5731 " .aaaaaaa[0]\n" 5732 " .aaaaaaaaaaaaaaaaaaaaaa();"); 5733 5734 verifyNoCrash("a[,Y?)]", getLLVMStyleWithColumns(10)); 5735 } 5736 5737 TEST_F(FormatTest, LineStartsWithSpecialCharacter) { 5738 verifyFormat("(a)->b();"); 5739 verifyFormat("--a;"); 5740 } 5741 5742 TEST_F(FormatTest, HandlesIncludeDirectives) { 5743 verifyFormat("#include <string>\n" 5744 "#include <a/b/c.h>\n" 5745 "#include \"a/b/string\"\n" 5746 "#include \"string.h\"\n" 5747 "#include \"string.h\"\n" 5748 "#include <a-a>\n" 5749 "#include < path with space >\n" 5750 "#include \"abc.h\" // this is included for ABC\n" 5751 "#include \"some long include\" // with a comment\n" 5752 "#include \"some very long include paaaaaaaaaaaaaaaaaaaaaaath\"", 5753 getLLVMStyleWithColumns(35)); 5754 EXPECT_EQ("#include \"a.h\"", format("#include \"a.h\"")); 5755 EXPECT_EQ("#include <a>", format("#include<a>")); 5756 5757 verifyFormat("#import <string>"); 5758 verifyFormat("#import <a/b/c.h>"); 5759 verifyFormat("#import \"a/b/string\""); 5760 verifyFormat("#import \"string.h\""); 5761 verifyFormat("#import \"string.h\""); 5762 verifyFormat("#if __has_include(<strstream>)\n" 5763 "#include <strstream>\n" 5764 "#endif"); 5765 5766 verifyFormat("#define MY_IMPORT <a/b>"); 5767 5768 // Protocol buffer definition or missing "#". 5769 verifyFormat("import \"aaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaa\";", 5770 getLLVMStyleWithColumns(30)); 5771 5772 FormatStyle Style = getLLVMStyle(); 5773 Style.AlwaysBreakBeforeMultilineStrings = true; 5774 Style.ColumnLimit = 0; 5775 verifyFormat("#import \"abc.h\"", Style); 5776 5777 // But 'import' might also be a regular C++ namespace. 5778 verifyFormat("import::SomeFunction(aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 5779 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaa);"); 5780 } 5781 5782 //===----------------------------------------------------------------------===// 5783 // Error recovery tests. 5784 //===----------------------------------------------------------------------===// 5785 5786 TEST_F(FormatTest, IncompleteParameterLists) { 5787 FormatStyle NoBinPacking = getLLVMStyle(); 5788 NoBinPacking.BinPackParameters = false; 5789 verifyFormat("void aaaaaaaaaaaaaaaaaa(int level,\n" 5790 " double *min_x,\n" 5791 " double *max_x,\n" 5792 " double *min_y,\n" 5793 " double *max_y,\n" 5794 " double *min_z,\n" 5795 " double *max_z, ) {}", 5796 NoBinPacking); 5797 } 5798 5799 TEST_F(FormatTest, IncorrectCodeTrailingStuff) { 5800 verifyFormat("void f() { return; }\n42"); 5801 verifyFormat("void f() {\n" 5802 " if (0)\n" 5803 " return;\n" 5804 "}\n" 5805 "42"); 5806 verifyFormat("void f() { return }\n42"); 5807 verifyFormat("void f() {\n" 5808 " if (0)\n" 5809 " return\n" 5810 "}\n" 5811 "42"); 5812 } 5813 5814 TEST_F(FormatTest, IncorrectCodeMissingSemicolon) { 5815 EXPECT_EQ("void f() { return }", format("void f ( ) { return }")); 5816 EXPECT_EQ("void f() {\n" 5817 " if (a)\n" 5818 " return\n" 5819 "}", 5820 format("void f ( ) { if ( a ) return }")); 5821 EXPECT_EQ("namespace N {\n" 5822 "void f()\n" 5823 "}", 5824 format("namespace N { void f() }")); 5825 EXPECT_EQ("namespace N {\n" 5826 "void f() {}\n" 5827 "void g()\n" 5828 "}", 5829 format("namespace N { void f( ) { } void g( ) }")); 5830 } 5831 5832 TEST_F(FormatTest, IndentationWithinColumnLimitNotPossible) { 5833 verifyFormat("int aaaaaaaa =\n" 5834 " // Overlylongcomment\n" 5835 " b;", 5836 getLLVMStyleWithColumns(20)); 5837 verifyFormat("function(\n" 5838 " ShortArgument,\n" 5839 " LoooooooooooongArgument);\n", 5840 getLLVMStyleWithColumns(20)); 5841 } 5842 5843 TEST_F(FormatTest, IncorrectAccessSpecifier) { 5844 verifyFormat("public:"); 5845 verifyFormat("class A {\n" 5846 "public\n" 5847 " void f() {}\n" 5848 "};"); 5849 verifyFormat("public\n" 5850 "int qwerty;"); 5851 verifyFormat("public\n" 5852 "B {}"); 5853 verifyFormat("public\n" 5854 "{}"); 5855 verifyFormat("public\n" 5856 "B { int x; }"); 5857 } 5858 5859 TEST_F(FormatTest, IncorrectCodeUnbalancedBraces) { 5860 verifyFormat("{"); 5861 verifyFormat("#})"); 5862 verifyNoCrash("(/**/[:!] ?[)."); 5863 } 5864 5865 TEST_F(FormatTest, IncorrectCodeDoNoWhile) { 5866 verifyFormat("do {\n}"); 5867 verifyFormat("do {\n}\n" 5868 "f();"); 5869 verifyFormat("do {\n}\n" 5870 "wheeee(fun);"); 5871 verifyFormat("do {\n" 5872 " f();\n" 5873 "}"); 5874 } 5875 5876 TEST_F(FormatTest, IncorrectCodeMissingParens) { 5877 verifyFormat("if {\n foo;\n foo();\n}"); 5878 verifyFormat("switch {\n foo;\n foo();\n}"); 5879 verifyFormat("for {\n foo;\n foo();\n}"); 5880 verifyFormat("while {\n foo;\n foo();\n}"); 5881 verifyFormat("do {\n foo;\n foo();\n} while;"); 5882 } 5883 5884 TEST_F(FormatTest, DoesNotTouchUnwrappedLinesWithErrors) { 5885 verifyFormat("namespace {\n" 5886 "class Foo { Foo (\n" 5887 "};\n" 5888 "} // comment"); 5889 } 5890 5891 TEST_F(FormatTest, IncorrectCodeErrorDetection) { 5892 EXPECT_EQ("{\n {}\n", format("{\n{\n}\n")); 5893 EXPECT_EQ("{\n {}\n", format("{\n {\n}\n")); 5894 EXPECT_EQ("{\n {}\n", format("{\n {\n }\n")); 5895 EXPECT_EQ("{\n {}\n}\n}\n", format("{\n {\n }\n }\n}\n")); 5896 5897 EXPECT_EQ("{\n" 5898 " {\n" 5899 " breakme(\n" 5900 " qwe);\n" 5901 " }\n", 5902 format("{\n" 5903 " {\n" 5904 " breakme(qwe);\n" 5905 "}\n", 5906 getLLVMStyleWithColumns(10))); 5907 } 5908 5909 TEST_F(FormatTest, LayoutCallsInsideBraceInitializers) { 5910 verifyFormat("int x = {\n" 5911 " avariable,\n" 5912 " b(alongervariable)};", 5913 getLLVMStyleWithColumns(25)); 5914 } 5915 5916 TEST_F(FormatTest, LayoutBraceInitializersInReturnStatement) { 5917 verifyFormat("return (a)(b){1, 2, 3};"); 5918 } 5919 5920 TEST_F(FormatTest, LayoutCxx11BraceInitializers) { 5921 verifyFormat("vector<int> x{1, 2, 3, 4};"); 5922 verifyFormat("vector<int> x{\n" 5923 " 1, 2, 3, 4,\n" 5924 "};"); 5925 verifyFormat("vector<T> x{{}, {}, {}, {}};"); 5926 verifyFormat("f({1, 2});"); 5927 verifyFormat("auto v = Foo{-1};"); 5928 verifyFormat("f({1, 2}, {{2, 3}, {4, 5}}, c, {d});"); 5929 verifyFormat("Class::Class : member{1, 2, 3} {}"); 5930 verifyFormat("new vector<int>{1, 2, 3};"); 5931 verifyFormat("new int[3]{1, 2, 3};"); 5932 verifyFormat("new int{1};"); 5933 verifyFormat("return {arg1, arg2};"); 5934 verifyFormat("return {arg1, SomeType{parameter}};"); 5935 verifyFormat("int count = set<int>{f(), g(), h()}.size();"); 5936 verifyFormat("new T{arg1, arg2};"); 5937 verifyFormat("f(MyMap[{composite, key}]);"); 5938 verifyFormat("class Class {\n" 5939 " T member = {arg1, arg2};\n" 5940 "};"); 5941 verifyFormat("vector<int> foo = {::SomeGlobalFunction()};"); 5942 verifyFormat("static_assert(std::is_integral<int>{} + 0, \"\");"); 5943 verifyFormat("int a = std::is_integral<int>{} + 0;"); 5944 5945 verifyFormat("int foo(int i) { return fo1{}(i); }"); 5946 verifyFormat("int foo(int i) { return fo1{}(i); }"); 5947 verifyFormat("auto i = decltype(x){};"); 5948 verifyFormat("std::vector<int> v = {1, 0 /* comment */};"); 5949 verifyFormat("Node n{1, Node{1000}, //\n" 5950 " 2};"); 5951 verifyFormat("Aaaa aaaaaaa{\n" 5952 " {\n" 5953 " aaaa,\n" 5954 " },\n" 5955 "};"); 5956 5957 // In combination with BinPackParameters = false. 5958 FormatStyle NoBinPacking = getLLVMStyle(); 5959 NoBinPacking.BinPackParameters = false; 5960 verifyFormat("const Aaaaaa aaaaa = {aaaaa,\n" 5961 " bbbbb,\n" 5962 " ccccc,\n" 5963 " ddddd,\n" 5964 " eeeee,\n" 5965 " ffffff,\n" 5966 " ggggg,\n" 5967 " hhhhhh,\n" 5968 " iiiiii,\n" 5969 " jjjjjj,\n" 5970 " kkkkkk};", 5971 NoBinPacking); 5972 verifyFormat("const Aaaaaa aaaaa = {\n" 5973 " aaaaa,\n" 5974 " bbbbb,\n" 5975 " ccccc,\n" 5976 " ddddd,\n" 5977 " eeeee,\n" 5978 " ffffff,\n" 5979 " ggggg,\n" 5980 " hhhhhh,\n" 5981 " iiiiii,\n" 5982 " jjjjjj,\n" 5983 " kkkkkk,\n" 5984 "};", 5985 NoBinPacking); 5986 verifyFormat( 5987 "const Aaaaaa aaaaa = {\n" 5988 " aaaaa, bbbbb, ccccc, ddddd, eeeee, ffffff, ggggg, hhhhhh,\n" 5989 " iiiiii, jjjjjj, kkkkkk, aaaaa, bbbbb, ccccc, ddddd, eeeee,\n" 5990 " ffffff, ggggg, hhhhhh, iiiiii, jjjjjj, kkkkkk,\n" 5991 "};", 5992 NoBinPacking); 5993 5994 // FIXME: The alignment of these trailing comments might be bad. Then again, 5995 // this might be utterly useless in real code. 5996 verifyFormat("Constructor::Constructor()\n" 5997 " : some_value{ //\n" 5998 " aaaaaaa, //\n" 5999 " bbbbbbb} {}"); 6000 6001 // In braced lists, the first comment is always assumed to belong to the 6002 // first element. Thus, it can be moved to the next or previous line as 6003 // appropriate. 6004 EXPECT_EQ("function({// First element:\n" 6005 " 1,\n" 6006 " // Second element:\n" 6007 " 2});", 6008 format("function({\n" 6009 " // First element:\n" 6010 " 1,\n" 6011 " // Second element:\n" 6012 " 2});")); 6013 EXPECT_EQ("std::vector<int> MyNumbers{\n" 6014 " // First element:\n" 6015 " 1,\n" 6016 " // Second element:\n" 6017 " 2};", 6018 format("std::vector<int> MyNumbers{// First element:\n" 6019 " 1,\n" 6020 " // Second element:\n" 6021 " 2};", 6022 getLLVMStyleWithColumns(30))); 6023 // A trailing comma should still lead to an enforced line break. 6024 EXPECT_EQ("vector<int> SomeVector = {\n" 6025 " // aaa\n" 6026 " 1, 2,\n" 6027 "};", 6028 format("vector<int> SomeVector = { // aaa\n" 6029 " 1, 2, };")); 6030 6031 FormatStyle ExtraSpaces = getLLVMStyle(); 6032 ExtraSpaces.Cpp11BracedListStyle = false; 6033 ExtraSpaces.ColumnLimit = 75; 6034 verifyFormat("vector<int> x{ 1, 2, 3, 4 };", ExtraSpaces); 6035 verifyFormat("vector<T> x{ {}, {}, {}, {} };", ExtraSpaces); 6036 verifyFormat("f({ 1, 2 });", ExtraSpaces); 6037 verifyFormat("auto v = Foo{ 1 };", ExtraSpaces); 6038 verifyFormat("f({ 1, 2 }, { { 2, 3 }, { 4, 5 } }, c, { d });", ExtraSpaces); 6039 verifyFormat("Class::Class : member{ 1, 2, 3 } {}", ExtraSpaces); 6040 verifyFormat("new vector<int>{ 1, 2, 3 };", ExtraSpaces); 6041 verifyFormat("new int[3]{ 1, 2, 3 };", ExtraSpaces); 6042 verifyFormat("return { arg1, arg2 };", ExtraSpaces); 6043 verifyFormat("return { arg1, SomeType{ parameter } };", ExtraSpaces); 6044 verifyFormat("int count = set<int>{ f(), g(), h() }.size();", ExtraSpaces); 6045 verifyFormat("new T{ arg1, arg2 };", ExtraSpaces); 6046 verifyFormat("f(MyMap[{ composite, key }]);", ExtraSpaces); 6047 verifyFormat("class Class {\n" 6048 " T member = { arg1, arg2 };\n" 6049 "};", 6050 ExtraSpaces); 6051 verifyFormat( 6052 "foo = aaaaaaaaaaa ? vector<int>{ aaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6053 " aaaaaaaaaaaaaaaaaaaa, aaaaa }\n" 6054 " : vector<int>{ bbbbbbbbbbbbbbbbbbbbbbbbbbb,\n" 6055 " bbbbbbbbbbbbbbbbbbbb, bbbbb };", 6056 ExtraSpaces); 6057 verifyFormat("DoSomethingWithVector({} /* No data */);", ExtraSpaces); 6058 verifyFormat("DoSomethingWithVector({ {} /* No data */ }, { { 1, 2 } });", 6059 ExtraSpaces); 6060 verifyFormat( 6061 "someFunction(OtherParam,\n" 6062 " BracedList{ // comment 1 (Forcing interesting break)\n" 6063 " param1, param2,\n" 6064 " // comment 2\n" 6065 " param3, param4 });", 6066 ExtraSpaces); 6067 verifyFormat( 6068 "std::this_thread::sleep_for(\n" 6069 " std::chrono::nanoseconds{ std::chrono::seconds{ 1 } } / 5);", 6070 ExtraSpaces); 6071 verifyFormat( 6072 "std::vector<MyValues> aaaaaaaaaaaaaaaaaaa{\n" 6073 " aaaaaaa, aaaaaaaaaa, aaaaa, aaaaaaaaaaaaaaa, aaa, aaaaaaaaaa, a,\n" 6074 " aaaaaaaaaaaaaaaaaaaaa, aaaaaaaaaaaa,\n" 6075 " aaaaaaaaaaaaaaaaaaa + aaaaaaaaaaaaaaaaaaa, aaaaaaa, a};"); 6076 verifyFormat("vector<int> foo = { ::SomeGlobalFunction() };", ExtraSpaces); 6077 } 6078 6079 TEST_F(FormatTest, FormatsBracedListsInColumnLayout) { 6080 verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6081 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6082 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6083 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6084 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6085 " 1, 22, 333, 4444, 55555, 666666, 7777777};"); 6086 verifyFormat("vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6087 " // line comment\n" 6088 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6089 " 1, 22, 333, 4444, 55555,\n" 6090 " // line comment\n" 6091 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6092 " 1, 22, 333, 4444, 55555, 666666, 7777777};"); 6093 verifyFormat( 6094 "vector<int> x = {1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6095 " 1, 22, 333, 4444, 55555, 666666, 7777777,\n" 6096 " 1, 22, 333, 4444, 55555, 666666, // comment\n" 6097 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 6098 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 6099 " 7777777, 1, 22, 333, 4444, 55555, 666666,\n" 6100 " 7777777};"); 6101 verifyFormat("static const uint16_t CallerSavedRegs64Bittttt[] = {\n" 6102 " X86::RAX, X86::RDX, X86::RCX, X86::RSI, X86::RDI,\n" 6103 " X86::R8, X86::R9, X86::R10, X86::R11, 0};"); 6104 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 6105 " 1, 1, 1, 1};", 6106 getLLVMStyleWithColumns(39)); 6107 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 6108 " 1, 1, 1, 1};", 6109 getLLVMStyleWithColumns(38)); 6110 verifyFormat("vector<int> aaaaaaaaaaaaaaaaaaaaaa = {\n" 6111 " 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1};", 6112 getLLVMStyleWithColumns(43)); 6113 6114 // Trailing commas. 6115 verifyFormat("vector<int> x = {\n" 6116 " 1, 1, 1, 1, 1, 1, 1, 1,\n" 6117 "};", 6118 getLLVMStyleWithColumns(39)); 6119 verifyFormat("vector<int> x = {\n" 6120 " 1, 1, 1, 1, 1, 1, 1, 1, //\n" 6121 "};", 6122 getLLVMStyleWithColumns(39)); 6123 verifyFormat("vector<int> x = {1, 1, 1, 1,\n" 6124 " 1, 1, 1, 1,\n" 6125 " /**/ /**/};", 6126 getLLVMStyleWithColumns(39)); 6127 verifyFormat("return {{aaaaaaaaaaaaaaaaaaaaa},\n" 6128 " {aaaaaaaaaaaaaaaaaaa},\n" 6129 " {aaaaaaaaaaaaaaaaaaaaa},\n" 6130 " {aaaaaaaaaaaaaaaaa}};", 6131 getLLVMStyleWithColumns(60)); 6132 6133 // With nested lists, we should either format one item per line or all nested 6134 // lists one one line. 6135 // FIXME: For some nested lists, we can do better. 6136 verifyFormat( 6137 "SomeStruct my_struct_array = {\n" 6138 " {aaaaaa, aaaaaaaa, aaaaaaaaaa, aaaaaaaaa, aaaaaaaaa, aaaaaaaaaa,\n" 6139 " aaaaaaaaaaaaa, aaaaaaa, aaa},\n" 6140 " {aaa, aaa},\n" 6141 " {aaa, aaa},\n" 6142 " {aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaaa, aaa},\n" 6143 " {aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaa, aaaaaaaaaaaaaaaaaaaaaaaa,\n" 6144 " aaaaaaaaaaaa, a, aaaaaaaaaa, aaaaaaaaa, aaa}};"); 6145 6146 // No column layout should be used here. 6147 verifyFormat("aaaaaaaaaaaaaaa = {aaaaaaaaaaaaaaaaaaaaaaaaaaa, 0, 0,\n" 6148 " bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb};"); 6149 6150 verifyNoCrash("a<,"); 6151 } 6152 6153 TEST_F(FormatTest, PullTrivialFunctionDefinitionsIntoSingleLine) { 6154 FormatStyle DoNotMerge = getLLVMStyle(); 6155 DoNotMerge.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; 6156 6157 verifyFormat("void f() { return 42; }"); 6158 verifyFormat("void f() {\n" 6159 " return 42;\n" 6160 "}", 6161 DoNotMerge); 6162 verifyFormat("void f() {\n" 6163 " // Comment\n" 6164 "}"); 6165 verifyFormat("{\n" 6166 "#error {\n" 6167 " int a;\n" 6168 "}"); 6169 verifyFormat("{\n" 6170 " int a;\n" 6171 "#error {\n" 6172 "}"); 6173 verifyFormat("void f() {} // comment"); 6174 verifyFormat("void f() { int a; } // comment"); 6175 verifyFormat("void f() {\n" 6176 "} // comment", 6177 DoNotMerge); 6178 verifyFormat("void f() {\n" 6179 " int a;\n" 6180 "} // comment", 6181 DoNotMerge); 6182 verifyFormat("void f() {\n" 6183 "} // comment", 6184 getLLVMStyleWithColumns(15)); 6185 6186 verifyFormat("void f() { return 42; }", getLLVMStyleWithColumns(23)); 6187 verifyFormat("void f() {\n return 42;\n}", getLLVMStyleWithColumns(22)); 6188 6189 verifyFormat("void f() {}", getLLVMStyleWithColumns(11)); 6190 verifyFormat("void f() {\n}", getLLVMStyleWithColumns(10)); 6191 verifyFormat("class C {\n" 6192 " C()\n" 6193 " : iiiiiiii(nullptr),\n" 6194 " kkkkkkk(nullptr),\n" 6195 " mmmmmmm(nullptr),\n" 6196 " nnnnnnn(nullptr) {}\n" 6197 "};", 6198 getGoogleStyle()); 6199 6200 FormatStyle NoColumnLimit = getLLVMStyle(); 6201 NoColumnLimit.ColumnLimit = 0; 6202 EXPECT_EQ("A() : b(0) {}", format("A():b(0){}", NoColumnLimit)); 6203 EXPECT_EQ("class C {\n" 6204 " A() : b(0) {}\n" 6205 "};", format("class C{A():b(0){}};", NoColumnLimit)); 6206 EXPECT_EQ("A()\n" 6207 " : b(0) {\n" 6208 "}", 6209 format("A()\n:b(0)\n{\n}", NoColumnLimit)); 6210 6211 FormatStyle DoNotMergeNoColumnLimit = NoColumnLimit; 6212 DoNotMergeNoColumnLimit.AllowShortFunctionsOnASingleLine = 6213 FormatStyle::SFS_None; 6214 EXPECT_EQ("A()\n" 6215 " : b(0) {\n" 6216 "}", 6217 format("A():b(0){}", DoNotMergeNoColumnLimit)); 6218 EXPECT_EQ("A()\n" 6219 " : b(0) {\n" 6220 "}", 6221 format("A()\n:b(0)\n{\n}", DoNotMergeNoColumnLimit)); 6222 6223 verifyFormat("#define A \\\n" 6224 " void f() { \\\n" 6225 " int i; \\\n" 6226 " }", 6227 getLLVMStyleWithColumns(20)); 6228 verifyFormat("#define A \\\n" 6229 " void f() { int i; }", 6230 getLLVMStyleWithColumns(21)); 6231 verifyFormat("#define A \\\n" 6232 " void f() { \\\n" 6233 " int i; \\\n" 6234 " } \\\n" 6235 " int j;", 6236 getLLVMStyleWithColumns(22)); 6237 verifyFormat("#define A \\\n" 6238 " void f() { int i; } \\\n" 6239 " int j;", 6240 getLLVMStyleWithColumns(23)); 6241 } 6242 6243 TEST_F(FormatTest, PullInlineFunctionDefinitionsIntoSingleLine) { 6244 FormatStyle MergeInlineOnly = getLLVMStyle(); 6245 MergeInlineOnly.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 6246 verifyFormat("class C {\n" 6247 " int f() { return 42; }\n" 6248 "};", 6249 MergeInlineOnly); 6250 verifyFormat("int f() {\n" 6251 " return 42;\n" 6252 "}", 6253 MergeInlineOnly); 6254 } 6255 6256 TEST_F(FormatTest, UnderstandContextOfRecordTypeKeywords) { 6257 // Elaborate type variable declarations. 6258 verifyFormat("struct foo a = {bar};\nint n;"); 6259 verifyFormat("class foo a = {bar};\nint n;"); 6260 verifyFormat("union foo a = {bar};\nint n;"); 6261 6262 // Elaborate types inside function definitions. 6263 verifyFormat("struct foo f() {}\nint n;"); 6264 verifyFormat("class foo f() {}\nint n;"); 6265 verifyFormat("union foo f() {}\nint n;"); 6266 6267 // Templates. 6268 verifyFormat("template <class X> void f() {}\nint n;"); 6269 verifyFormat("template <struct X> void f() {}\nint n;"); 6270 verifyFormat("template <union X> void f() {}\nint n;"); 6271 6272 // Actual definitions... 6273 verifyFormat("struct {\n} n;"); 6274 verifyFormat( 6275 "template <template <class T, class Y>, class Z> class X {\n} n;"); 6276 verifyFormat("union Z {\n int n;\n} x;"); 6277 verifyFormat("class MACRO Z {\n} n;"); 6278 verifyFormat("class MACRO(X) Z {\n} n;"); 6279 verifyFormat("class __attribute__(X) Z {\n} n;"); 6280 verifyFormat("class __declspec(X) Z {\n} n;"); 6281 verifyFormat("class A##B##C {\n} n;"); 6282 verifyFormat("class alignas(16) Z {\n} n;"); 6283 6284 // Redefinition from nested context: 6285 verifyFormat("class A::B::C {\n} n;"); 6286 6287 // Template definitions. 6288 verifyFormat( 6289 "template <typename F>\n" 6290 "Matcher(const Matcher<F> &Other,\n" 6291 " typename enable_if_c<is_base_of<F, T>::value &&\n" 6292 " !is_same<F, T>::value>::type * = 0)\n" 6293 " : Implementation(new ImplicitCastMatcher<F>(Other)) {}"); 6294 6295 // FIXME: This is still incorrectly handled at the formatter side. 6296 verifyFormat("template <> struct X < 15, i<3 && 42 < 50 && 33 < 28> {};"); 6297 6298 // FIXME: 6299 // This now gets parsed incorrectly as class definition. 6300 // verifyFormat("class A<int> f() {\n}\nint n;"); 6301 6302 // Elaborate types where incorrectly parsing the structural element would 6303 // break the indent. 6304 verifyFormat("if (true)\n" 6305 " class X x;\n" 6306 "else\n" 6307 " f();\n"); 6308 6309 // This is simply incomplete. Formatting is not important, but must not crash. 6310 verifyFormat("class A:"); 6311 } 6312 6313 TEST_F(FormatTest, DoNotInterfereWithErrorAndWarning) { 6314 EXPECT_EQ("#error Leave all white!!!!! space* alone!\n", 6315 format("#error Leave all white!!!!! space* alone!\n")); 6316 EXPECT_EQ( 6317 "#warning Leave all white!!!!! space* alone!\n", 6318 format("#warning Leave all white!!!!! space* alone!\n")); 6319 EXPECT_EQ("#error 1", format(" # error 1")); 6320 EXPECT_EQ("#warning 1", format(" # warning 1")); 6321 } 6322 6323 TEST_F(FormatTest, FormatHashIfExpressions) { 6324 verifyFormat("#if AAAA && BBBB"); 6325 // FIXME: Come up with a better indentation for #elif. 6326 verifyFormat( 6327 "#if !defined(AAAAAAA) && (defined CCCCCC || defined DDDDDD) && \\\n" 6328 " defined(BBBBBBBB)\n" 6329 "#elif !defined(AAAAAA) && (defined CCCCC || defined DDDDDD) && \\\n" 6330 " defined(BBBBBBBB)\n" 6331 "#endif", 6332 getLLVMStyleWithColumns(65)); 6333 } 6334 6335 TEST_F(FormatTest, MergeHandlingInTheFaceOfPreprocessorDirectives) { 6336 FormatStyle AllowsMergedIf = getGoogleStyle(); 6337 AllowsMergedIf.AllowShortIfStatementsOnASingleLine = true; 6338 verifyFormat("void f() { f(); }\n#error E", AllowsMergedIf); 6339 verifyFormat("if (true) return 42;\n#error E", AllowsMergedIf); 6340 verifyFormat("if (true)\n#error E\n return 42;", AllowsMergedIf); 6341 EXPECT_EQ("if (true) return 42;", 6342 format("if (true)\nreturn 42;", AllowsMergedIf)); 6343 FormatStyle ShortMergedIf = AllowsMergedIf; 6344 ShortMergedIf.ColumnLimit = 25; 6345 verifyFormat("#define A \\\n" 6346 " if (true) return 42;", 6347 ShortMergedIf); 6348 verifyFormat("#define A \\\n" 6349 " f(); \\\n" 6350 " if (true)\n" 6351 "#define B", 6352 ShortMergedIf); 6353 verifyFormat("#define A \\\n" 6354 " f(); \\\n" 6355 " if (true)\n" 6356 "g();", 6357 ShortMergedIf); 6358 verifyFormat("{\n" 6359 "#ifdef A\n" 6360 " // Comment\n" 6361 " if (true) continue;\n" 6362 "#endif\n" 6363 " // Comment\n" 6364 " if (true) continue;\n" 6365 "}", 6366 ShortMergedIf); 6367 ShortMergedIf.ColumnLimit = 29; 6368 verifyFormat("#define A \\\n" 6369 " if (aaaaaaaaaa) return 1; \\\n" 6370 " return 2;", 6371 ShortMergedIf); 6372 ShortMergedIf.ColumnLimit = 28; 6373 verifyFormat("#define A \\\n" 6374 " if (aaaaaaaaaa) \\\n" 6375 " return 1; \\\n" 6376 " return 2;", 6377 ShortMergedIf); 6378 } 6379 6380 TEST_F(FormatTest, BlockCommentsInControlLoops) { 6381 verifyFormat("if (0) /* a comment in a strange place */ {\n" 6382 " f();\n" 6383 "}"); 6384 verifyFormat("if (0) /* a comment in a strange place */ {\n" 6385 " f();\n" 6386 "} /* another comment */ else /* comment #3 */ {\n" 6387 " g();\n" 6388 "}"); 6389 verifyFormat("while (0) /* a comment in a strange place */ {\n" 6390 " f();\n" 6391 "}"); 6392 verifyFormat("for (;;) /* a comment in a strange place */ {\n" 6393 " f();\n" 6394 "}"); 6395 verifyFormat("do /* a comment in a strange place */ {\n" 6396 " f();\n" 6397 "} /* another comment */ while (0);"); 6398 } 6399 6400 TEST_F(FormatTest, BlockComments) { 6401 EXPECT_EQ("/* */ /* */ /* */\n/* */ /* */ /* */", 6402 format("/* *//* */ /* */\n/* *//* */ /* */")); 6403 EXPECT_EQ("/* */ a /* */ b;", format(" /* */ a/* */ b;")); 6404 EXPECT_EQ("#define A /*123*/ \\\n" 6405 " b\n" 6406 "/* */\n" 6407 "someCall(\n" 6408 " parameter);", 6409 format("#define A /*123*/ b\n" 6410 "/* */\n" 6411 "someCall(parameter);", 6412 getLLVMStyleWithColumns(15))); 6413 6414 EXPECT_EQ("#define A\n" 6415 "/* */ someCall(\n" 6416 " parameter);", 6417 format("#define A\n" 6418 "/* */someCall(parameter);", 6419 getLLVMStyleWithColumns(15))); 6420 EXPECT_EQ("/*\n**\n*/", format("/*\n**\n*/")); 6421 EXPECT_EQ("/*\n" 6422 "*\n" 6423 " * aaaaaa\n" 6424 "*aaaaaa\n" 6425 "*/", 6426 format("/*\n" 6427 "*\n" 6428 " * aaaaaa aaaaaa\n" 6429 "*/", 6430 getLLVMStyleWithColumns(10))); 6431 EXPECT_EQ("/*\n" 6432 "**\n" 6433 "* aaaaaa\n" 6434 "*aaaaaa\n" 6435 "*/", 6436 format("/*\n" 6437 "**\n" 6438 "* aaaaaa aaaaaa\n" 6439 "*/", 6440 getLLVMStyleWithColumns(10))); 6441 6442 FormatStyle NoBinPacking = getLLVMStyle(); 6443 NoBinPacking.BinPackParameters = false; 6444 EXPECT_EQ("someFunction(1, /* comment 1 */\n" 6445 " 2, /* comment 2 */\n" 6446 " 3, /* comment 3 */\n" 6447 " aaaa,\n" 6448 " bbbb);", 6449 format("someFunction (1, /* comment 1 */\n" 6450 " 2, /* comment 2 */ \n" 6451 " 3, /* comment 3 */\n" 6452 "aaaa, bbbb );", 6453 NoBinPacking)); 6454 verifyFormat( 6455 "bool aaaaaaaaaaaaa = /* comment: */ aaaaaaaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 6456 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa;"); 6457 EXPECT_EQ( 6458 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 6459 " aaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 6460 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;", 6461 format( 6462 "bool aaaaaaaaaaaaa = /* trailing comment */\n" 6463 " aaaaaaaaaaaaaaaaaaaaaaaaaaa||aaaaaaaaaaaaaaaaaaaaaaaaa ||\n" 6464 " aaaaaaaaaaaaaaaaaaaaaaaaaaaa || aaaaaaaaaaaaaaaaaaaaaaaaaa;")); 6465 EXPECT_EQ( 6466 "int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 6467 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 6468 "int cccccccccccccccccccccccccccccc; /* comment */\n", 6469 format("int aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa; /* comment */\n" 6470 "int bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb; /* comment */\n" 6471 "int cccccccccccccccccccccccccccccc; /* comment */\n")); 6472 6473 verifyFormat("void f(int * /* unused */) {}"); 6474 6475 EXPECT_EQ("/*\n" 6476 " **\n" 6477 " */", 6478 format("/*\n" 6479 " **\n" 6480 " */")); 6481 EXPECT_EQ("/*\n" 6482 " *q\n" 6483 " */", 6484 format("/*\n" 6485 " *q\n" 6486 " */")); 6487 EXPECT_EQ("/*\n" 6488 " * q\n" 6489 " */", 6490 format("/*\n" 6491 " * q\n" 6492 " */")); 6493 EXPECT_EQ("/*\n" 6494 " **/", 6495 format("/*\n" 6496 " **/")); 6497 EXPECT_EQ("/*\n" 6498 " ***/", 6499 format("/*\n" 6500 " ***/")); 6501 } 6502 6503 TEST_F(FormatTest, BlockCommentsInMacros) { 6504 EXPECT_EQ("#define A \\\n" 6505 " { \\\n" 6506 " /* one line */ \\\n" 6507 " someCall();", 6508 format("#define A { \\\n" 6509 " /* one line */ \\\n" 6510 " someCall();", 6511 getLLVMStyleWithColumns(20))); 6512 EXPECT_EQ("#define A \\\n" 6513 " { \\\n" 6514 " /* previous */ \\\n" 6515 " /* one line */ \\\n" 6516 " someCall();", 6517 format("#define A { \\\n" 6518 " /* previous */ \\\n" 6519 " /* one line */ \\\n" 6520 " someCall();", 6521 getLLVMStyleWithColumns(20))); 6522 } 6523 6524 TEST_F(FormatTest, BlockCommentsAtEndOfLine) { 6525 EXPECT_EQ("a = {\n" 6526 " 1111 /* */\n" 6527 "};", 6528 format("a = {1111 /* */\n" 6529 "};", 6530 getLLVMStyleWithColumns(15))); 6531 EXPECT_EQ("a = {\n" 6532 " 1111 /* */\n" 6533 "};", 6534 format("a = {1111 /* */\n" 6535 "};", 6536 getLLVMStyleWithColumns(15))); 6537 6538 // FIXME: The formatting is still wrong here. 6539 EXPECT_EQ("a = {\n" 6540 " 1111 /* a\n" 6541 " */\n" 6542 "};", 6543 format("a = {1111 /* a */\n" 6544 "};", 6545 getLLVMStyleWithColumns(15))); 6546 } 6547 6548 TEST_F(FormatTest, IndentLineCommentsInStartOfBlockAtEndOfFile) { 6549 // FIXME: This is not what we want... 6550 verifyFormat("{\n" 6551 "// a" 6552 "// b"); 6553 } 6554 6555 TEST_F(FormatTest, FormatStarDependingOnContext) { 6556 verifyFormat("void f(int *a);"); 6557 verifyFormat("void f() { f(fint * b); }"); 6558 verifyFormat("class A {\n void f(int *a);\n};"); 6559 verifyFormat("class A {\n int *a;\n};"); 6560 verifyFormat("namespace a {\n" 6561 "namespace b {\n" 6562 "class A {\n" 6563 " void f() {}\n" 6564 " int *a;\n" 6565 "};\n" 6566 "}\n" 6567 "}"); 6568 } 6569 6570 TEST_F(FormatTest, SpecialTokensAtEndOfLine) { 6571 verifyFormat("while"); 6572 verifyFormat("operator"); 6573 } 6574 6575 //===----------------------------------------------------------------------===// 6576 // Objective-C tests. 6577 //===----------------------------------------------------------------------===// 6578 6579 TEST_F(FormatTest, FormatForObjectiveCMethodDecls) { 6580 verifyFormat("- (void)sendAction:(SEL)aSelector to:(BOOL)anObject;"); 6581 EXPECT_EQ("- (NSUInteger)indexOfObject:(id)anObject;", 6582 format("-(NSUInteger)indexOfObject:(id)anObject;")); 6583 EXPECT_EQ("- (NSInteger)Mthod1;", format("-(NSInteger)Mthod1;")); 6584 EXPECT_EQ("+ (id)Mthod2;", format("+(id)Mthod2;")); 6585 EXPECT_EQ("- (NSInteger)Method3:(id)anObject;", 6586 format("-(NSInteger)Method3:(id)anObject;")); 6587 EXPECT_EQ("- (NSInteger)Method4:(id)anObject;", 6588 format("-(NSInteger)Method4:(id)anObject;")); 6589 EXPECT_EQ("- (NSInteger)Method5:(id)anObject:(id)AnotherObject;", 6590 format("-(NSInteger)Method5:(id)anObject:(id)AnotherObject;")); 6591 EXPECT_EQ("- (id)Method6:(id)A:(id)B:(id)C:(id)D;", 6592 format("- (id)Method6:(id)A:(id)B:(id)C:(id)D;")); 6593 EXPECT_EQ( 6594 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;", 6595 format( 6596 "- (void)sendAction:(SEL)aSelector to:(id)anObject forAllCells:(BOOL)flag;")); 6597 6598 // Very long objectiveC method declaration. 6599 verifyFormat("- (NSUInteger)indexOfObject:(id)anObject\n" 6600 " inRange:(NSRange)range\n" 6601 " outRange:(NSRange)out_range\n" 6602 " outRange1:(NSRange)out_range1\n" 6603 " outRange2:(NSRange)out_range2\n" 6604 " outRange3:(NSRange)out_range3\n" 6605 " outRange4:(NSRange)out_range4\n" 6606 " outRange5:(NSRange)out_range5\n" 6607 " outRange6:(NSRange)out_range6\n" 6608 " outRange7:(NSRange)out_range7\n" 6609 " outRange8:(NSRange)out_range8\n" 6610 " outRange9:(NSRange)out_range9;"); 6611 6612 verifyFormat("- (int)sum:(vector<int>)numbers;"); 6613 verifyGoogleFormat("- (void)setDelegate:(id<Protocol>)delegate;"); 6614 // FIXME: In LLVM style, there should be a space in front of a '<' for ObjC 6615 // protocol lists (but not for template classes): 6616 //verifyFormat("- (void)setDelegate:(id <Protocol>)delegate;"); 6617 6618 verifyFormat("- (int (*)())foo:(int (*)())f;"); 6619 verifyGoogleFormat("- (int (*)())foo:(int (*)())foo;"); 6620 6621 // If there's no return type (very rare in practice!), LLVM and Google style 6622 // agree. 6623 verifyFormat("- foo;"); 6624 verifyFormat("- foo:(int)f;"); 6625 verifyGoogleFormat("- foo:(int)foo;"); 6626 } 6627 6628 TEST_F(FormatTest, FormatObjCInterface) { 6629 verifyFormat("@interface Foo : NSObject <NSSomeDelegate> {\n" 6630 "@public\n" 6631 " int field1;\n" 6632 "@protected\n" 6633 " int field2;\n" 6634 "@private\n" 6635 " int field3;\n" 6636 "@package\n" 6637 " int field4;\n" 6638 "}\n" 6639 "+ (id)init;\n" 6640 "@end"); 6641 6642 verifyGoogleFormat("@interface Foo : NSObject<NSSomeDelegate> {\n" 6643 " @public\n" 6644 " int field1;\n" 6645 " @protected\n" 6646 " int field2;\n" 6647 " @private\n" 6648 " int field3;\n" 6649 " @package\n" 6650 " int field4;\n" 6651 "}\n" 6652 "+ (id)init;\n" 6653 "@end"); 6654 6655 verifyFormat("@interface /* wait for it */ Foo\n" 6656 "+ (id)init;\n" 6657 "// Look, a comment!\n" 6658 "- (int)answerWith:(int)i;\n" 6659 "@end"); 6660 6661 verifyFormat("@interface Foo\n" 6662 "@end\n" 6663 "@interface Bar\n" 6664 "@end"); 6665 6666 verifyFormat("@interface Foo : Bar\n" 6667 "+ (id)init;\n" 6668 "@end"); 6669 6670 verifyFormat("@interface Foo : /**/ Bar /**/ <Baz, /**/ Quux>\n" 6671 "+ (id)init;\n" 6672 "@end"); 6673 6674 verifyGoogleFormat("@interface Foo : Bar<Baz, Quux>\n" 6675 "+ (id)init;\n" 6676 "@end"); 6677 6678 verifyFormat("@interface Foo (HackStuff)\n" 6679 "+ (id)init;\n" 6680 "@end"); 6681 6682 verifyFormat("@interface Foo ()\n" 6683 "+ (id)init;\n" 6684 "@end"); 6685 6686 verifyFormat("@interface Foo (HackStuff) <MyProtocol>\n" 6687 "+ (id)init;\n" 6688 "@end"); 6689 6690 verifyGoogleFormat("@interface Foo (HackStuff) <MyProtocol>\n" 6691 "+ (id)init;\n" 6692 "@end"); 6693 6694 verifyFormat("@interface Foo {\n" 6695 " int _i;\n" 6696 "}\n" 6697 "+ (id)init;\n" 6698 "@end"); 6699 6700 verifyFormat("@interface Foo : Bar {\n" 6701 " int _i;\n" 6702 "}\n" 6703 "+ (id)init;\n" 6704 "@end"); 6705 6706 verifyFormat("@interface Foo : Bar <Baz, Quux> {\n" 6707 " int _i;\n" 6708 "}\n" 6709 "+ (id)init;\n" 6710 "@end"); 6711 6712 verifyFormat("@interface Foo (HackStuff) {\n" 6713 " int _i;\n" 6714 "}\n" 6715 "+ (id)init;\n" 6716 "@end"); 6717 6718 verifyFormat("@interface Foo () {\n" 6719 " int _i;\n" 6720 "}\n" 6721 "+ (id)init;\n" 6722 "@end"); 6723 6724 verifyFormat("@interface Foo (HackStuff) <MyProtocol> {\n" 6725 " int _i;\n" 6726 "}\n" 6727 "+ (id)init;\n" 6728 "@end"); 6729 6730 FormatStyle OnePerLine = getGoogleStyle(); 6731 OnePerLine.BinPackParameters = false; 6732 verifyFormat("@interface aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa () <\n" 6733 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6734 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6735 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa,\n" 6736 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa> {\n" 6737 "}", 6738 OnePerLine); 6739 } 6740 6741 TEST_F(FormatTest, FormatObjCImplementation) { 6742 verifyFormat("@implementation Foo : NSObject {\n" 6743 "@public\n" 6744 " int field1;\n" 6745 "@protected\n" 6746 " int field2;\n" 6747 "@private\n" 6748 " int field3;\n" 6749 "@package\n" 6750 " int field4;\n" 6751 "}\n" 6752 "+ (id)init {\n}\n" 6753 "@end"); 6754 6755 verifyGoogleFormat("@implementation Foo : NSObject {\n" 6756 " @public\n" 6757 " int field1;\n" 6758 " @protected\n" 6759 " int field2;\n" 6760 " @private\n" 6761 " int field3;\n" 6762 " @package\n" 6763 " int field4;\n" 6764 "}\n" 6765 "+ (id)init {\n}\n" 6766 "@end"); 6767 6768 verifyFormat("@implementation Foo\n" 6769 "+ (id)init {\n" 6770 " if (true)\n" 6771 " return nil;\n" 6772 "}\n" 6773 "// Look, a comment!\n" 6774 "- (int)answerWith:(int)i {\n" 6775 " return i;\n" 6776 "}\n" 6777 "+ (int)answerWith:(int)i {\n" 6778 " return i;\n" 6779 "}\n" 6780 "@end"); 6781 6782 verifyFormat("@implementation Foo\n" 6783 "@end\n" 6784 "@implementation Bar\n" 6785 "@end"); 6786 6787 EXPECT_EQ("@implementation Foo : Bar\n" 6788 "+ (id)init {\n}\n" 6789 "- (void)foo {\n}\n" 6790 "@end", 6791 format("@implementation Foo : Bar\n" 6792 "+(id)init{}\n" 6793 "-(void)foo{}\n" 6794 "@end")); 6795 6796 verifyFormat("@implementation Foo {\n" 6797 " int _i;\n" 6798 "}\n" 6799 "+ (id)init {\n}\n" 6800 "@end"); 6801 6802 verifyFormat("@implementation Foo : Bar {\n" 6803 " int _i;\n" 6804 "}\n" 6805 "+ (id)init {\n}\n" 6806 "@end"); 6807 6808 verifyFormat("@implementation Foo (HackStuff)\n" 6809 "+ (id)init {\n}\n" 6810 "@end"); 6811 verifyFormat("@implementation ObjcClass\n" 6812 "- (void)method;\n" 6813 "{}\n" 6814 "@end"); 6815 } 6816 6817 TEST_F(FormatTest, FormatObjCProtocol) { 6818 verifyFormat("@protocol Foo\n" 6819 "@property(weak) id delegate;\n" 6820 "- (NSUInteger)numberOfThings;\n" 6821 "@end"); 6822 6823 verifyFormat("@protocol MyProtocol <NSObject>\n" 6824 "- (NSUInteger)numberOfThings;\n" 6825 "@end"); 6826 6827 verifyGoogleFormat("@protocol MyProtocol<NSObject>\n" 6828 "- (NSUInteger)numberOfThings;\n" 6829 "@end"); 6830 6831 verifyFormat("@protocol Foo;\n" 6832 "@protocol Bar;\n"); 6833 6834 verifyFormat("@protocol Foo\n" 6835 "@end\n" 6836 "@protocol Bar\n" 6837 "@end"); 6838 6839 verifyFormat("@protocol myProtocol\n" 6840 "- (void)mandatoryWithInt:(int)i;\n" 6841 "@optional\n" 6842 "- (void)optional;\n" 6843 "@required\n" 6844 "- (void)required;\n" 6845 "@optional\n" 6846 "@property(assign) int madProp;\n" 6847 "@end\n"); 6848 6849 verifyFormat("@property(nonatomic, assign, readonly)\n" 6850 " int *looooooooooooooooooooooooooooongNumber;\n" 6851 "@property(nonatomic, assign, readonly)\n" 6852 " NSString *looooooooooooooooooooooooooooongName;"); 6853 6854 verifyFormat("@implementation PR18406\n" 6855 "}\n" 6856 "@end"); 6857 } 6858 6859 TEST_F(FormatTest, FormatObjCMethodDeclarations) { 6860 verifyFormat("- (void)doSomethingWith:(GTMFoo *)theFoo\n" 6861 " rect:(NSRect)theRect\n" 6862 " interval:(float)theInterval {\n" 6863 "}"); 6864 verifyFormat("- (void)shortf:(GTMFoo *)theFoo\n" 6865 " longKeyword:(NSRect)theRect\n" 6866 " evenLongerKeyword:(float)theInterval\n" 6867 " error:(NSError **)theError {\n" 6868 "}"); 6869 verifyFormat("- (instancetype)initXxxxxx:(id<x>)x\n" 6870 " y:(id<yyyyyyyyyyyyyyyyyyyy>)y\n" 6871 " NS_DESIGNATED_INITIALIZER;", 6872 getLLVMStyleWithColumns(60)); 6873 } 6874 6875 TEST_F(FormatTest, FormatObjCMethodExpr) { 6876 verifyFormat("[foo bar:baz];"); 6877 verifyFormat("return [foo bar:baz];"); 6878 verifyFormat("return (a)[foo bar:baz];"); 6879 verifyFormat("f([foo bar:baz]);"); 6880 verifyFormat("f(2, [foo bar:baz]);"); 6881 verifyFormat("f(2, a ? b : c);"); 6882 verifyFormat("[[self initWithInt:4] bar:[baz quux:arrrr]];"); 6883 6884 // Unary operators. 6885 verifyFormat("int a = +[foo bar:baz];"); 6886 verifyFormat("int a = -[foo bar:baz];"); 6887 verifyFormat("int a = ![foo bar:baz];"); 6888 verifyFormat("int a = ~[foo bar:baz];"); 6889 verifyFormat("int a = ++[foo bar:baz];"); 6890 verifyFormat("int a = --[foo bar:baz];"); 6891 verifyFormat("int a = sizeof [foo bar:baz];"); 6892 verifyFormat("int a = alignof [foo bar:baz];", getGoogleStyle()); 6893 verifyFormat("int a = &[foo bar:baz];"); 6894 verifyFormat("int a = *[foo bar:baz];"); 6895 // FIXME: Make casts work, without breaking f()[4]. 6896 //verifyFormat("int a = (int)[foo bar:baz];"); 6897 //verifyFormat("return (int)[foo bar:baz];"); 6898 //verifyFormat("(void)[foo bar:baz];"); 6899 verifyFormat("return (MyType *)[self.tableView cellForRowAtIndexPath:cell];"); 6900 6901 // Binary operators. 6902 verifyFormat("[foo bar:baz], [foo bar:baz];"); 6903 verifyFormat("[foo bar:baz] = [foo bar:baz];"); 6904 verifyFormat("[foo bar:baz] *= [foo bar:baz];"); 6905 verifyFormat("[foo bar:baz] /= [foo bar:baz];"); 6906 verifyFormat("[foo bar:baz] %= [foo bar:baz];"); 6907 verifyFormat("[foo bar:baz] += [foo bar:baz];"); 6908 verifyFormat("[foo bar:baz] -= [foo bar:baz];"); 6909 verifyFormat("[foo bar:baz] <<= [foo bar:baz];"); 6910 verifyFormat("[foo bar:baz] >>= [foo bar:baz];"); 6911 verifyFormat("[foo bar:baz] &= [foo bar:baz];"); 6912 verifyFormat("[foo bar:baz] ^= [foo bar:baz];"); 6913 verifyFormat("[foo bar:baz] |= [foo bar:baz];"); 6914 verifyFormat("[foo bar:baz] ? [foo bar:baz] : [foo bar:baz];"); 6915 verifyFormat("[foo bar:baz] || [foo bar:baz];"); 6916 verifyFormat("[foo bar:baz] && [foo bar:baz];"); 6917 verifyFormat("[foo bar:baz] | [foo bar:baz];"); 6918 verifyFormat("[foo bar:baz] ^ [foo bar:baz];"); 6919 verifyFormat("[foo bar:baz] & [foo bar:baz];"); 6920 verifyFormat("[foo bar:baz] == [foo bar:baz];"); 6921 verifyFormat("[foo bar:baz] != [foo bar:baz];"); 6922 verifyFormat("[foo bar:baz] >= [foo bar:baz];"); 6923 verifyFormat("[foo bar:baz] <= [foo bar:baz];"); 6924 verifyFormat("[foo bar:baz] > [foo bar:baz];"); 6925 verifyFormat("[foo bar:baz] < [foo bar:baz];"); 6926 verifyFormat("[foo bar:baz] >> [foo bar:baz];"); 6927 verifyFormat("[foo bar:baz] << [foo bar:baz];"); 6928 verifyFormat("[foo bar:baz] - [foo bar:baz];"); 6929 verifyFormat("[foo bar:baz] + [foo bar:baz];"); 6930 verifyFormat("[foo bar:baz] * [foo bar:baz];"); 6931 verifyFormat("[foo bar:baz] / [foo bar:baz];"); 6932 verifyFormat("[foo bar:baz] % [foo bar:baz];"); 6933 // Whew! 6934 6935 verifyFormat("return in[42];"); 6936 verifyFormat("for (auto v : in[1]) {\n}"); 6937 verifyFormat("for (id foo in [self getStuffFor:bla]) {\n" 6938 "}"); 6939 verifyFormat("[self aaaaa:MACRO(a, b:, c:)];"); 6940 6941 verifyFormat("[self stuffWithInt:(4 + 2) float:4.5];"); 6942 verifyFormat("[self stuffWithInt:a ? b : c float:4.5];"); 6943 verifyFormat("[self stuffWithInt:a ? [self foo:bar] : c];"); 6944 verifyFormat("[self stuffWithInt:a ? (e ? f : g) : c];"); 6945 verifyFormat("[cond ? obj1 : obj2 methodWithParam:param]"); 6946 verifyFormat("[button setAction:@selector(zoomOut:)];"); 6947 verifyFormat("[color getRed:&r green:&g blue:&b alpha:&a];"); 6948 6949 verifyFormat("arr[[self indexForFoo:a]];"); 6950 verifyFormat("throw [self errorFor:a];"); 6951 verifyFormat("@throw [self errorFor:a];"); 6952 6953 verifyFormat("[(id)foo bar:(id)baz quux:(id)snorf];"); 6954 verifyFormat("[(id)foo bar:(id) ? baz : quux];"); 6955 verifyFormat("4 > 4 ? (id)a : (id)baz;"); 6956 6957 // This tests that the formatter doesn't break after "backing" but before ":", 6958 // which would be at 80 columns. 6959 verifyFormat( 6960 "void f() {\n" 6961 " if ((self = [super initWithContentRect:contentRect\n" 6962 " styleMask:styleMask ?: otherMask\n" 6963 " backing:NSBackingStoreBuffered\n" 6964 " defer:YES]))"); 6965 6966 verifyFormat( 6967 "[foo checkThatBreakingAfterColonWorksOk:\n" 6968 " [bar ifItDoes:reduceOverallLineLengthLikeInThisCase]];"); 6969 6970 verifyFormat("[myObj short:arg1 // Force line break\n" 6971 " longKeyword:arg2 != nil ? arg2 : @\"longKeyword\"\n" 6972 " evenLongerKeyword:arg3 ?: @\"evenLongerKeyword\"\n" 6973 " error:arg4];"); 6974 verifyFormat( 6975 "void f() {\n" 6976 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 6977 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" 6978 " pos.width(), pos.height())\n" 6979 " styleMask:NSBorderlessWindowMask\n" 6980 " backing:NSBackingStoreBuffered\n" 6981 " defer:NO]);\n" 6982 "}"); 6983 verifyFormat( 6984 "void f() {\n" 6985 " popup_wdow_.reset([[RenderWidgetPopupWindow alloc]\n" 6986 " iniithContentRect:NSMakRet(origin_global.x, origin_global.y,\n" 6987 " pos.width(), pos.height())\n" 6988 " syeMask:NSBorderlessWindowMask\n" 6989 " bking:NSBackingStoreBuffered\n" 6990 " der:NO]);\n" 6991 "}", 6992 getLLVMStyleWithColumns(70)); 6993 verifyFormat( 6994 "void f() {\n" 6995 " popup_window_.reset([[RenderWidgetPopupWindow alloc]\n" 6996 " initWithContentRect:NSMakeRect(origin_global.x, origin_global.y,\n" 6997 " pos.width(), pos.height())\n" 6998 " styleMask:NSBorderlessWindowMask\n" 6999 " backing:NSBackingStoreBuffered\n" 7000 " defer:NO]);\n" 7001 "}", 7002 getChromiumStyle(FormatStyle::LK_Cpp)); 7003 verifyFormat("[contentsContainer replaceSubview:[subviews objectAtIndex:0]\n" 7004 " with:contentsNativeView];"); 7005 7006 verifyFormat( 7007 "[pboard addTypes:[NSArray arrayWithObject:kBookmarkButtonDragType]\n" 7008 " owner:nillllll];"); 7009 7010 verifyFormat( 7011 "[pboard setData:[NSData dataWithBytes:&button length:sizeof(button)]\n" 7012 " forType:kBookmarkButtonDragType];"); 7013 7014 verifyFormat("[defaultCenter addObserver:self\n" 7015 " selector:@selector(willEnterFullscreen)\n" 7016 " name:kWillEnterFullscreenNotification\n" 7017 " object:nil];"); 7018 verifyFormat("[image_rep drawInRect:drawRect\n" 7019 " fromRect:NSZeroRect\n" 7020 " operation:NSCompositeCopy\n" 7021 " fraction:1.0\n" 7022 " respectFlipped:NO\n" 7023 " hints:nil];"); 7024 7025 verifyFormat( 7026 "scoped_nsobject<NSTextField> message(\n" 7027 " // The frame will be fixed up when |-setMessageText:| is called.\n" 7028 " [[NSTextField alloc] initWithFrame:NSMakeRect(0, 0, 0, 0)]);"); 7029 verifyFormat("[self aaaaaa:bbbbbbbbbbbbb\n" 7030 " aaaaaaaaaa:bbbbbbbbbbbbbbbbb\n" 7031 " aaaaa:bbbbbbbbbbb + bbbbbbbbbbbb\n" 7032 " aaaa:bbb];"); 7033 verifyFormat("[self param:function( //\n" 7034 " parameter)]"); 7035 verifyFormat( 7036 "[self aaaaaaaaaa:aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 7037 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa |\n" 7038 " aaaaaaaaaaaaaaa | aaaaaaaaaaaaaaa];"); 7039 7040 // Variadic parameters. 7041 verifyFormat( 7042 "NSArray *myStrings = [NSArray stringarray:@\"a\", @\"b\", nil];"); 7043 verifyFormat( 7044 "[self aaaaaaaaaaaaa:aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 7045 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa,\n" 7046 " aaaaaaaaaaaaaaa, aaaaaaaaaaaaaaa];"); 7047 verifyFormat("[self // break\n" 7048 " a:a\n" 7049 " aaa:aaa];"); 7050 verifyFormat("bool a = ([aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaa ||\n" 7051 " [aaaaaaaa aaaaa] == aaaaaaaaaaaaaaaaaaaa);"); 7052 } 7053 7054 TEST_F(FormatTest, ObjCAt) { 7055 verifyFormat("@autoreleasepool"); 7056 verifyFormat("@catch"); 7057 verifyFormat("@class"); 7058 verifyFormat("@compatibility_alias"); 7059 verifyFormat("@defs"); 7060 verifyFormat("@dynamic"); 7061 verifyFormat("@encode"); 7062 verifyFormat("@end"); 7063 verifyFormat("@finally"); 7064 verifyFormat("@implementation"); 7065 verifyFormat("@import"); 7066 verifyFormat("@interface"); 7067 verifyFormat("@optional"); 7068 verifyFormat("@package"); 7069 verifyFormat("@private"); 7070 verifyFormat("@property"); 7071 verifyFormat("@protected"); 7072 verifyFormat("@protocol"); 7073 verifyFormat("@public"); 7074 verifyFormat("@required"); 7075 verifyFormat("@selector"); 7076 verifyFormat("@synchronized"); 7077 verifyFormat("@synthesize"); 7078 verifyFormat("@throw"); 7079 verifyFormat("@try"); 7080 7081 EXPECT_EQ("@interface", format("@ interface")); 7082 7083 // The precise formatting of this doesn't matter, nobody writes code like 7084 // this. 7085 verifyFormat("@ /*foo*/ interface"); 7086 } 7087 7088 TEST_F(FormatTest, ObjCSnippets) { 7089 verifyFormat("@autoreleasepool {\n" 7090 " foo();\n" 7091 "}"); 7092 verifyFormat("@class Foo, Bar;"); 7093 verifyFormat("@compatibility_alias AliasName ExistingClass;"); 7094 verifyFormat("@dynamic textColor;"); 7095 verifyFormat("char *buf1 = @encode(int *);"); 7096 verifyFormat("char *buf1 = @encode(typeof(4 * 5));"); 7097 verifyFormat("char *buf1 = @encode(int **);"); 7098 verifyFormat("Protocol *proto = @protocol(p1);"); 7099 verifyFormat("SEL s = @selector(foo:);"); 7100 verifyFormat("@synchronized(self) {\n" 7101 " f();\n" 7102 "}"); 7103 7104 verifyFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 7105 verifyGoogleFormat("@synthesize dropArrowPosition = dropArrowPosition_;"); 7106 7107 verifyFormat("@property(assign, nonatomic) CGFloat hoverAlpha;"); 7108 verifyFormat("@property(assign, getter=isEditable) BOOL editable;"); 7109 verifyGoogleFormat("@property(assign, getter=isEditable) BOOL editable;"); 7110 verifyFormat("@property (assign, getter=isEditable) BOOL editable;", 7111 getMozillaStyle()); 7112 verifyFormat("@property BOOL editable;", getMozillaStyle()); 7113 verifyFormat("@property (assign, getter=isEditable) BOOL editable;", 7114 getWebKitStyle()); 7115 verifyFormat("@property BOOL editable;", getWebKitStyle()); 7116 7117 verifyFormat("@import foo.bar;\n" 7118 "@import baz;"); 7119 } 7120 7121 TEST_F(FormatTest, ObjCLiterals) { 7122 verifyFormat("@\"String\""); 7123 verifyFormat("@1"); 7124 verifyFormat("@+4.8"); 7125 verifyFormat("@-4"); 7126 verifyFormat("@1LL"); 7127 verifyFormat("@.5"); 7128 verifyFormat("@'c'"); 7129 verifyFormat("@true"); 7130 7131 verifyFormat("NSNumber *smallestInt = @(-INT_MAX - 1);"); 7132 verifyFormat("NSNumber *piOverTwo = @(M_PI / 2);"); 7133 verifyFormat("NSNumber *favoriteColor = @(Green);"); 7134 verifyFormat("NSString *path = @(getenv(\"PATH\"));"); 7135 7136 verifyFormat("[dictionary setObject:@(1) forKey:@\"number\"];"); 7137 } 7138 7139 TEST_F(FormatTest, ObjCDictLiterals) { 7140 verifyFormat("@{"); 7141 verifyFormat("@{}"); 7142 verifyFormat("@{@\"one\" : @1}"); 7143 verifyFormat("return @{@\"one\" : @1;"); 7144 verifyFormat("@{@\"one\" : @1}"); 7145 7146 verifyFormat("@{@\"one\" : @{@2 : @1}}"); 7147 verifyFormat("@{\n" 7148 " @\"one\" : @{@2 : @1},\n" 7149 "}"); 7150 7151 verifyFormat("@{1 > 2 ? @\"one\" : @\"two\" : 1 > 2 ? @1 : @2}"); 7152 verifyFormat("[self setDict:@{}"); 7153 verifyFormat("[self setDict:@{@1 : @2}"); 7154 verifyFormat("NSLog(@\"%@\", @{@1 : @2, @2 : @3}[@1]);"); 7155 verifyFormat( 7156 "NSDictionary *masses = @{@\"H\" : @1.0078, @\"He\" : @4.0026};"); 7157 verifyFormat( 7158 "NSDictionary *settings = @{AVEncoderKey : @(AVAudioQualityMax)};"); 7159 7160 verifyFormat( 7161 "NSDictionary *d = @{\n" 7162 " @\"nam\" : NSUserNam(),\n" 7163 " @\"dte\" : [NSDate date],\n" 7164 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 7165 "};"); 7166 verifyFormat( 7167 "@{\n" 7168 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 7169 "regularFont,\n" 7170 "};"); 7171 verifyGoogleFormat( 7172 "@{\n" 7173 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee : " 7174 "regularFont,\n" 7175 "};"); 7176 verifyFormat( 7177 "@{\n" 7178 " NSFontAttributeNameeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee :\n" 7179 " reeeeeeeeeeeeeeeeeeeeeeeegularFont,\n" 7180 "};"); 7181 7182 // We should try to be robust in case someone forgets the "@". 7183 verifyFormat( 7184 "NSDictionary *d = {\n" 7185 " @\"nam\" : NSUserNam(),\n" 7186 " @\"dte\" : [NSDate date],\n" 7187 " @\"processInfo\" : [NSProcessInfo processInfo]\n" 7188 "};"); 7189 verifyFormat("NSMutableDictionary *dictionary =\n" 7190 " [NSMutableDictionary dictionaryWithDictionary:@{\n" 7191 " aaaaaaaaaaaaaaaaaaaaa : aaaaaaaaaaaaa,\n" 7192 " bbbbbbbbbbbbbbbbbb : bbbbb,\n" 7193 " cccccccccccccccc : ccccccccccccccc\n" 7194 " }];"); 7195 } 7196 7197 TEST_F(FormatTest, ObjCArrayLiterals) { 7198 verifyFormat("@["); 7199 verifyFormat("@[]"); 7200 verifyFormat( 7201 "NSArray *array = @[ @\" Hey \", NSApp, [NSNumber numberWithInt:42] ];"); 7202 verifyFormat("return @[ @3, @[], @[ @4, @5 ] ];"); 7203 verifyFormat("NSArray *array = @[ [foo description] ];"); 7204 7205 verifyFormat( 7206 "NSArray *some_variable = @[\n" 7207 " aaaa == bbbbbbbbbbb ? @\"aaaaaaaaaaaa\" : @\"aaaaaaaaaaaaaa\",\n" 7208 " @\"aaaaaaaaaaaaaaaaa\",\n" 7209 " @\"aaaaaaaaaaaaaaaaa\",\n" 7210 " @\"aaaaaaaaaaaaaaaaa\"\n" 7211 "];"); 7212 verifyFormat("NSArray *some_variable = @[\n" 7213 " @\"aaaaaaaaaaaaaaaaa\",\n" 7214 " @\"aaaaaaaaaaaaaaaaa\",\n" 7215 " @\"aaaaaaaaaaaaaaaaa\",\n" 7216 " @\"aaaaaaaaaaaaaaaaa\",\n" 7217 "];"); 7218 verifyGoogleFormat("NSArray *some_variable = @[\n" 7219 " @\"aaaaaaaaaaaaaaaaa\",\n" 7220 " @\"aaaaaaaaaaaaaaaaa\",\n" 7221 " @\"aaaaaaaaaaaaaaaaa\",\n" 7222 " @\"aaaaaaaaaaaaaaaaa\"\n" 7223 "];"); 7224 verifyFormat("NSArray *array = @[\n" 7225 " @\"a\",\n" 7226 " @\"a\",\n" // Trailing comma -> one per line. 7227 "];"); 7228 7229 // We should try to be robust in case someone forgets the "@". 7230 verifyFormat("NSArray *some_variable = [\n" 7231 " @\"aaaaaaaaaaaaaaaaa\",\n" 7232 " @\"aaaaaaaaaaaaaaaaa\",\n" 7233 " @\"aaaaaaaaaaaaaaaaa\",\n" 7234 " @\"aaaaaaaaaaaaaaaaa\",\n" 7235 "];"); 7236 verifyFormat( 7237 "- (NSAttributedString *)attributedStringForSegment:(NSUInteger)segment\n" 7238 " index:(NSUInteger)index\n" 7239 " nonDigitAttributes:\n" 7240 " (NSDictionary *)noDigitAttributes;"); 7241 verifyFormat( 7242 "[someFunction someLooooooooooooongParameter:\n" 7243 " @[ NSBundle.mainBundle.infoDictionary[@\"a\"] ]];"); 7244 } 7245 7246 TEST_F(FormatTest, ReformatRegionAdjustsIndent) { 7247 EXPECT_EQ("{\n" 7248 "{\n" 7249 "a;\n" 7250 "b;\n" 7251 "}\n" 7252 "}", 7253 format("{\n" 7254 "{\n" 7255 "a;\n" 7256 " b;\n" 7257 "}\n" 7258 "}", 7259 13, 2, getLLVMStyle())); 7260 EXPECT_EQ("{\n" 7261 "{\n" 7262 " a;\n" 7263 "b;\n" 7264 "}\n" 7265 "}", 7266 format("{\n" 7267 "{\n" 7268 " a;\n" 7269 "b;\n" 7270 "}\n" 7271 "}", 7272 9, 2, getLLVMStyle())); 7273 EXPECT_EQ("{\n" 7274 "{\n" 7275 "public:\n" 7276 " b;\n" 7277 "}\n" 7278 "}", 7279 format("{\n" 7280 "{\n" 7281 "public:\n" 7282 " b;\n" 7283 "}\n" 7284 "}", 7285 17, 2, getLLVMStyle())); 7286 EXPECT_EQ("{\n" 7287 "{\n" 7288 "a;\n" 7289 "}\n" 7290 "{\n" 7291 " b; //\n" 7292 "}\n" 7293 "}", 7294 format("{\n" 7295 "{\n" 7296 "a;\n" 7297 "}\n" 7298 "{\n" 7299 " b; //\n" 7300 "}\n" 7301 "}", 7302 22, 2, getLLVMStyle())); 7303 EXPECT_EQ(" {\n" 7304 " a; //\n" 7305 " }", 7306 format(" {\n" 7307 "a; //\n" 7308 " }", 7309 4, 2, getLLVMStyle())); 7310 EXPECT_EQ("void f() {}\n" 7311 "void g() {}", 7312 format("void f() {}\n" 7313 "void g() {}", 7314 13, 0, getLLVMStyle())); 7315 EXPECT_EQ("int a; // comment\n" 7316 " // line 2\n" 7317 "int b;", 7318 format("int a; // comment\n" 7319 " // line 2\n" 7320 " int b;", 7321 35, 0, getLLVMStyle())); 7322 EXPECT_EQ(" int a;\n" 7323 " void\n" 7324 " ffffff() {\n" 7325 " }", 7326 format(" int a;\n" 7327 "void ffffff() {}", 7328 11, 0, getLLVMStyleWithColumns(11))); 7329 7330 EXPECT_EQ(" void f() {\n" 7331 "#define A 1\n" 7332 " }", 7333 format(" void f() {\n" 7334 " #define A 1\n" // Format this line. 7335 " }", 7336 20, 0, getLLVMStyle())); 7337 EXPECT_EQ(" void f() {\n" 7338 " int i;\n" 7339 "#define A \\\n" 7340 " int i; \\\n" 7341 " int j;\n" 7342 " int k;\n" 7343 " }", 7344 format(" void f() {\n" 7345 " int i;\n" 7346 "#define A \\\n" 7347 " int i; \\\n" 7348 " int j;\n" 7349 " int k;\n" // Format this line. 7350 " }", 7351 67, 0, getLLVMStyle())); 7352 } 7353 7354 TEST_F(FormatTest, BreaksStringLiterals) { 7355 EXPECT_EQ("\"some text \"\n" 7356 "\"other\";", 7357 format("\"some text other\";", getLLVMStyleWithColumns(12))); 7358 EXPECT_EQ("\"some text \"\n" 7359 "\"other\";", 7360 format("\\\n\"some text other\";", getLLVMStyleWithColumns(12))); 7361 EXPECT_EQ( 7362 "#define A \\\n" 7363 " \"some \" \\\n" 7364 " \"text \" \\\n" 7365 " \"other\";", 7366 format("#define A \"some text other\";", getLLVMStyleWithColumns(12))); 7367 EXPECT_EQ( 7368 "#define A \\\n" 7369 " \"so \" \\\n" 7370 " \"text \" \\\n" 7371 " \"other\";", 7372 format("#define A \"so text other\";", getLLVMStyleWithColumns(12))); 7373 7374 EXPECT_EQ("\"some text\"", 7375 format("\"some text\"", getLLVMStyleWithColumns(1))); 7376 EXPECT_EQ("\"some text\"", 7377 format("\"some text\"", getLLVMStyleWithColumns(11))); 7378 EXPECT_EQ("\"some \"\n" 7379 "\"text\"", 7380 format("\"some text\"", getLLVMStyleWithColumns(10))); 7381 EXPECT_EQ("\"some \"\n" 7382 "\"text\"", 7383 format("\"some text\"", getLLVMStyleWithColumns(7))); 7384 EXPECT_EQ("\"some\"\n" 7385 "\" tex\"\n" 7386 "\"t\"", 7387 format("\"some text\"", getLLVMStyleWithColumns(6))); 7388 EXPECT_EQ("\"some\"\n" 7389 "\" tex\"\n" 7390 "\" and\"", 7391 format("\"some tex and\"", getLLVMStyleWithColumns(6))); 7392 EXPECT_EQ("\"some\"\n" 7393 "\"/tex\"\n" 7394 "\"/and\"", 7395 format("\"some/tex/and\"", getLLVMStyleWithColumns(6))); 7396 7397 EXPECT_EQ("variable =\n" 7398 " \"long string \"\n" 7399 " \"literal\";", 7400 format("variable = \"long string literal\";", 7401 getLLVMStyleWithColumns(20))); 7402 7403 EXPECT_EQ("variable = f(\n" 7404 " \"long string \"\n" 7405 " \"literal\",\n" 7406 " short,\n" 7407 " loooooooooooooooooooong);", 7408 format("variable = f(\"long string literal\", short, " 7409 "loooooooooooooooooooong);", 7410 getLLVMStyleWithColumns(20))); 7411 7412 EXPECT_EQ("f(g(\"long string \"\n" 7413 " \"literal\"),\n" 7414 " b);", 7415 format("f(g(\"long string literal\"), b);", 7416 getLLVMStyleWithColumns(20))); 7417 EXPECT_EQ("f(g(\"long string \"\n" 7418 " \"literal\",\n" 7419 " a),\n" 7420 " b);", 7421 format("f(g(\"long string literal\", a), b);", 7422 getLLVMStyleWithColumns(20))); 7423 EXPECT_EQ( 7424 "f(\"one two\".split(\n" 7425 " variable));", 7426 format("f(\"one two\".split(variable));", getLLVMStyleWithColumns(20))); 7427 EXPECT_EQ("f(\"one two three four five six \"\n" 7428 " \"seven\".split(\n" 7429 " really_looooong_variable));", 7430 format("f(\"one two three four five six seven\"." 7431 "split(really_looooong_variable));", 7432 getLLVMStyleWithColumns(33))); 7433 7434 EXPECT_EQ("f(\"some \"\n" 7435 " \"text\",\n" 7436 " other);", 7437 format("f(\"some text\", other);", getLLVMStyleWithColumns(10))); 7438 7439 // Only break as a last resort. 7440 verifyFormat( 7441 "aaaaaaaaaaaaaaaaaaaa(\n" 7442 " aaaaaaaaaaaaaaaaaaaa,\n" 7443 " aaaaaa(\"aaa aaaaa aaa aaa aaaaa aaa aaaaa aaa aaa aaaaaa\"));"); 7444 7445 EXPECT_EQ( 7446 "\"splitmea\"\n" 7447 "\"trandomp\"\n" 7448 "\"oint\"", 7449 format("\"splitmeatrandompoint\"", getLLVMStyleWithColumns(10))); 7450 7451 EXPECT_EQ( 7452 "\"split/\"\n" 7453 "\"pathat/\"\n" 7454 "\"slashes\"", 7455 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 7456 7457 EXPECT_EQ( 7458 "\"split/\"\n" 7459 "\"pathat/\"\n" 7460 "\"slashes\"", 7461 format("\"split/pathat/slashes\"", getLLVMStyleWithColumns(10))); 7462 EXPECT_EQ("\"split at \"\n" 7463 "\"spaces/at/\"\n" 7464 "\"slashes.at.any$\"\n" 7465 "\"non-alphanumeric%\"\n" 7466 "\"1111111111characte\"\n" 7467 "\"rs\"", 7468 format("\"split at " 7469 "spaces/at/" 7470 "slashes.at." 7471 "any$non-" 7472 "alphanumeric%" 7473 "1111111111characte" 7474 "rs\"", 7475 getLLVMStyleWithColumns(20))); 7476 7477 // Verify that splitting the strings understands 7478 // Style::AlwaysBreakBeforeMultilineStrings. 7479 EXPECT_EQ("aaaaaaaaaaaa(aaaaaaaaaaaaa,\n" 7480 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa \"\n" 7481 " \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\");", 7482 format("aaaaaaaaaaaa(aaaaaaaaaaaaa, \"aaaaaaaaaaaaaaaaaaaaaa " 7483 "aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa " 7484 "aaaaaaaaaaaaaaaaaaaaaa\");", 7485 getGoogleStyle())); 7486 EXPECT_EQ("return \"aaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 7487 " \"aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaa\";", 7488 format("return \"aaaaaaaaaaaaaaaaaaaaaa " 7489 "aaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaaaaaaaaaa " 7490 "aaaaaaaaaaaaaaaaaaaaaa\";", 7491 getGoogleStyle())); 7492 EXPECT_EQ("llvm::outs() << \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 7493 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 7494 format("llvm::outs() << " 7495 "\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa aaaaaaaaaaaaaaaaaa" 7496 "aaaaaaaaaaaaaaaaaaa\";")); 7497 EXPECT_EQ("ffff(\n" 7498 " {\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa \"\n" 7499 " \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 7500 format("ffff({\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa " 7501 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\"});", 7502 getGoogleStyle())); 7503 7504 FormatStyle AlignLeft = getLLVMStyleWithColumns(12); 7505 AlignLeft.AlignEscapedNewlinesLeft = true; 7506 EXPECT_EQ( 7507 "#define A \\\n" 7508 " \"some \" \\\n" 7509 " \"text \" \\\n" 7510 " \"other\";", 7511 format("#define A \"some text other\";", AlignLeft)); 7512 } 7513 7514 TEST_F(FormatTest, BreaksStringLiteralsWithTabs) { 7515 EXPECT_EQ( 7516 "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 7517 "(\n" 7518 " \"x\t\");", 7519 format("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 7520 "aaaaaaa(" 7521 "\"x\t\");")); 7522 } 7523 7524 TEST_F(FormatTest, BreaksWideAndNSStringLiterals) { 7525 EXPECT_EQ( 7526 "u8\"utf8 string \"\n" 7527 "u8\"literal\";", 7528 format("u8\"utf8 string literal\";", getGoogleStyleWithColumns(16))); 7529 EXPECT_EQ( 7530 "u\"utf16 string \"\n" 7531 "u\"literal\";", 7532 format("u\"utf16 string literal\";", getGoogleStyleWithColumns(16))); 7533 EXPECT_EQ( 7534 "U\"utf32 string \"\n" 7535 "U\"literal\";", 7536 format("U\"utf32 string literal\";", getGoogleStyleWithColumns(16))); 7537 EXPECT_EQ("L\"wide string \"\n" 7538 "L\"literal\";", 7539 format("L\"wide string literal\";", getGoogleStyleWithColumns(16))); 7540 EXPECT_EQ("@\"NSString \"\n" 7541 "@\"literal\";", 7542 format("@\"NSString literal\";", getGoogleStyleWithColumns(19))); 7543 7544 // This input makes clang-format try to split the incomplete unicode escape 7545 // sequence, which used to lead to a crasher. 7546 verifyNoCrash( 7547 "aaaaaaaaaaaaaaaaaaaa = L\"\\udff\"'; // aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", 7548 getLLVMStyleWithColumns(60)); 7549 } 7550 7551 TEST_F(FormatTest, DoesNotBreakRawStringLiterals) { 7552 FormatStyle Style = getGoogleStyleWithColumns(15); 7553 EXPECT_EQ("R\"x(raw literal)x\";", format("R\"x(raw literal)x\";", Style)); 7554 EXPECT_EQ("uR\"x(raw literal)x\";", format("uR\"x(raw literal)x\";", Style)); 7555 EXPECT_EQ("LR\"x(raw literal)x\";", format("LR\"x(raw literal)x\";", Style)); 7556 EXPECT_EQ("UR\"x(raw literal)x\";", format("UR\"x(raw literal)x\";", Style)); 7557 EXPECT_EQ("u8R\"x(raw literal)x\";", 7558 format("u8R\"x(raw literal)x\";", Style)); 7559 } 7560 7561 TEST_F(FormatTest, BreaksStringLiteralsWithin_TMacro) { 7562 FormatStyle Style = getLLVMStyleWithColumns(20); 7563 EXPECT_EQ( 7564 "_T(\"aaaaaaaaaaaaaa\")\n" 7565 "_T(\"aaaaaaaaaaaaaa\")\n" 7566 "_T(\"aaaaaaaaaaaa\")", 7567 format(" _T(\"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\")", Style)); 7568 EXPECT_EQ("f(x, _T(\"aaaaaaaaa\")\n" 7569 " _T(\"aaaaaa\"),\n" 7570 " z);", 7571 format("f(x, _T(\"aaaaaaaaaaaaaaa\"), z);", Style)); 7572 7573 // FIXME: Handle embedded spaces in one iteration. 7574 // EXPECT_EQ("_T(\"aaaaaaaaaaaaa\")\n" 7575 // "_T(\"aaaaaaaaaaaaa\")\n" 7576 // "_T(\"aaaaaaaaaaaaa\")\n" 7577 // "_T(\"a\")", 7578 // format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 7579 // getLLVMStyleWithColumns(20))); 7580 EXPECT_EQ( 7581 "_T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", 7582 format(" _T ( \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\" )", Style)); 7583 } 7584 7585 TEST_F(FormatTest, DontSplitStringLiteralsWithEscapedNewlines) { 7586 EXPECT_EQ( 7587 "aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7588 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7589 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";", 7590 format("aaaaaaaaaaa = \"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7591 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\\\n" 7592 " aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\";")); 7593 } 7594 7595 TEST_F(FormatTest, CountsCharactersInMultilineRawStringLiterals) { 7596 EXPECT_EQ("f(g(R\"x(raw literal)x\", a), b);", 7597 format("f(g(R\"x(raw literal)x\", a), b);", getGoogleStyle())); 7598 EXPECT_EQ("fffffffffff(g(R\"x(\n" 7599 "multiline raw string literal xxxxxxxxxxxxxx\n" 7600 ")x\",\n" 7601 " a),\n" 7602 " b);", 7603 format("fffffffffff(g(R\"x(\n" 7604 "multiline raw string literal xxxxxxxxxxxxxx\n" 7605 ")x\", a), b);", 7606 getGoogleStyleWithColumns(20))); 7607 EXPECT_EQ("fffffffffff(\n" 7608 " g(R\"x(qqq\n" 7609 "multiline raw string literal xxxxxxxxxxxxxx\n" 7610 ")x\",\n" 7611 " a),\n" 7612 " b);", 7613 format("fffffffffff(g(R\"x(qqq\n" 7614 "multiline raw string literal xxxxxxxxxxxxxx\n" 7615 ")x\", a), b);", 7616 getGoogleStyleWithColumns(20))); 7617 7618 EXPECT_EQ("fffffffffff(R\"x(\n" 7619 "multiline raw string literal xxxxxxxxxxxxxx\n" 7620 ")x\");", 7621 format("fffffffffff(R\"x(\n" 7622 "multiline raw string literal xxxxxxxxxxxxxx\n" 7623 ")x\");", 7624 getGoogleStyleWithColumns(20))); 7625 EXPECT_EQ("fffffffffff(R\"x(\n" 7626 "multiline raw string literal xxxxxxxxxxxxxx\n" 7627 ")x\" + bbbbbb);", 7628 format("fffffffffff(R\"x(\n" 7629 "multiline raw string literal xxxxxxxxxxxxxx\n" 7630 ")x\" + bbbbbb);", 7631 getGoogleStyleWithColumns(20))); 7632 EXPECT_EQ("fffffffffff(\n" 7633 " R\"x(\n" 7634 "multiline raw string literal xxxxxxxxxxxxxx\n" 7635 ")x\" +\n" 7636 " bbbbbb);", 7637 format("fffffffffff(\n" 7638 " R\"x(\n" 7639 "multiline raw string literal xxxxxxxxxxxxxx\n" 7640 ")x\" + bbbbbb);", 7641 getGoogleStyleWithColumns(20))); 7642 } 7643 7644 TEST_F(FormatTest, SkipsUnknownStringLiterals) { 7645 verifyFormat("string a = \"unterminated;"); 7646 EXPECT_EQ("function(\"unterminated,\n" 7647 " OtherParameter);", 7648 format("function( \"unterminated,\n" 7649 " OtherParameter);")); 7650 } 7651 7652 TEST_F(FormatTest, DoesNotTryToParseUDLiteralsInPreCpp11Code) { 7653 FormatStyle Style = getLLVMStyle(); 7654 Style.Standard = FormatStyle::LS_Cpp03; 7655 EXPECT_EQ("#define x(_a) printf(\"foo\" _a);", 7656 format("#define x(_a) printf(\"foo\"_a);", Style)); 7657 } 7658 7659 TEST_F(FormatTest, UnderstandsCpp1y) { 7660 verifyFormat("int bi{1'000'000};"); 7661 } 7662 7663 TEST_F(FormatTest, BreakStringLiteralsBeforeUnbreakableTokenSequence) { 7664 EXPECT_EQ("someFunction(\"aaabbbcccd\"\n" 7665 " \"ddeeefff\");", 7666 format("someFunction(\"aaabbbcccdddeeefff\");", 7667 getLLVMStyleWithColumns(25))); 7668 EXPECT_EQ("someFunction1234567890(\n" 7669 " \"aaabbbcccdddeeefff\");", 7670 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7671 getLLVMStyleWithColumns(26))); 7672 EXPECT_EQ("someFunction1234567890(\n" 7673 " \"aaabbbcccdddeeeff\"\n" 7674 " \"f\");", 7675 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7676 getLLVMStyleWithColumns(25))); 7677 EXPECT_EQ("someFunction1234567890(\n" 7678 " \"aaabbbcccdddeeeff\"\n" 7679 " \"f\");", 7680 format("someFunction1234567890(\"aaabbbcccdddeeefff\");", 7681 getLLVMStyleWithColumns(24))); 7682 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 7683 " \"ddde \"\n" 7684 " \"efff\");", 7685 format("someFunction(\"aaabbbcc ddde efff\");", 7686 getLLVMStyleWithColumns(25))); 7687 EXPECT_EQ("someFunction(\"aaabbbccc \"\n" 7688 " \"ddeeefff\");", 7689 format("someFunction(\"aaabbbccc ddeeefff\");", 7690 getLLVMStyleWithColumns(25))); 7691 EXPECT_EQ("someFunction1234567890(\n" 7692 " \"aaabb \"\n" 7693 " \"cccdddeeefff\");", 7694 format("someFunction1234567890(\"aaabb cccdddeeefff\");", 7695 getLLVMStyleWithColumns(25))); 7696 EXPECT_EQ("#define A \\\n" 7697 " string s = \\\n" 7698 " \"123456789\" \\\n" 7699 " \"0\"; \\\n" 7700 " int i;", 7701 format("#define A string s = \"1234567890\"; int i;", 7702 getLLVMStyleWithColumns(20))); 7703 // FIXME: Put additional penalties on breaking at non-whitespace locations. 7704 EXPECT_EQ("someFunction(\"aaabbbcc \"\n" 7705 " \"dddeeeff\"\n" 7706 " \"f\");", 7707 format("someFunction(\"aaabbbcc dddeeefff\");", 7708 getLLVMStyleWithColumns(25))); 7709 } 7710 7711 TEST_F(FormatTest, DoNotBreakStringLiteralsInEscapeSequence) { 7712 EXPECT_EQ("\"\\a\"", 7713 format("\"\\a\"", getLLVMStyleWithColumns(3))); 7714 EXPECT_EQ("\"\\\"", 7715 format("\"\\\"", getLLVMStyleWithColumns(2))); 7716 EXPECT_EQ("\"test\"\n" 7717 "\"\\n\"", 7718 format("\"test\\n\"", getLLVMStyleWithColumns(7))); 7719 EXPECT_EQ("\"tes\\\\\"\n" 7720 "\"n\"", 7721 format("\"tes\\\\n\"", getLLVMStyleWithColumns(7))); 7722 EXPECT_EQ("\"\\\\\\\\\"\n" 7723 "\"\\n\"", 7724 format("\"\\\\\\\\\\n\"", getLLVMStyleWithColumns(7))); 7725 EXPECT_EQ("\"\\uff01\"", 7726 format("\"\\uff01\"", getLLVMStyleWithColumns(7))); 7727 EXPECT_EQ("\"\\uff01\"\n" 7728 "\"test\"", 7729 format("\"\\uff01test\"", getLLVMStyleWithColumns(8))); 7730 EXPECT_EQ("\"\\Uff01ff02\"", 7731 format("\"\\Uff01ff02\"", getLLVMStyleWithColumns(11))); 7732 EXPECT_EQ("\"\\x000000000001\"\n" 7733 "\"next\"", 7734 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(16))); 7735 EXPECT_EQ("\"\\x000000000001next\"", 7736 format("\"\\x000000000001next\"", getLLVMStyleWithColumns(15))); 7737 EXPECT_EQ("\"\\x000000000001\"", 7738 format("\"\\x000000000001\"", getLLVMStyleWithColumns(7))); 7739 EXPECT_EQ("\"test\"\n" 7740 "\"\\000000\"\n" 7741 "\"000001\"", 7742 format("\"test\\000000000001\"", getLLVMStyleWithColumns(9))); 7743 EXPECT_EQ("\"test\\000\"\n" 7744 "\"00000000\"\n" 7745 "\"1\"", 7746 format("\"test\\000000000001\"", getLLVMStyleWithColumns(10))); 7747 } 7748 7749 TEST_F(FormatTest, DoNotCreateUnreasonableUnwrappedLines) { 7750 verifyFormat("void f() {\n" 7751 " return g() {}\n" 7752 " void h() {}"); 7753 verifyFormat("int a[] = {void forgot_closing_brace(){f();\n" 7754 "g();\n" 7755 "}"); 7756 } 7757 7758 TEST_F(FormatTest, DoNotPrematurelyEndUnwrappedLineForReturnStatements) { 7759 verifyFormat( 7760 "void f() { return C{param1, param2}.SomeCall(param1, param2); }"); 7761 } 7762 7763 TEST_F(FormatTest, FormatsClosingBracesInEmptyNestedBlocks) { 7764 verifyFormat("class X {\n" 7765 " void f() {\n" 7766 " }\n" 7767 "};", 7768 getLLVMStyleWithColumns(12)); 7769 } 7770 7771 TEST_F(FormatTest, ConfigurableIndentWidth) { 7772 FormatStyle EightIndent = getLLVMStyleWithColumns(18); 7773 EightIndent.IndentWidth = 8; 7774 EightIndent.ContinuationIndentWidth = 8; 7775 verifyFormat("void f() {\n" 7776 " someFunction();\n" 7777 " if (true) {\n" 7778 " f();\n" 7779 " }\n" 7780 "}", 7781 EightIndent); 7782 verifyFormat("class X {\n" 7783 " void f() {\n" 7784 " }\n" 7785 "};", 7786 EightIndent); 7787 verifyFormat("int x[] = {\n" 7788 " call(),\n" 7789 " call()};", 7790 EightIndent); 7791 } 7792 7793 TEST_F(FormatTest, ConfigurableFunctionDeclarationIndentAfterType) { 7794 verifyFormat("double\n" 7795 "f();", 7796 getLLVMStyleWithColumns(8)); 7797 } 7798 7799 TEST_F(FormatTest, ConfigurableUseOfTab) { 7800 FormatStyle Tab = getLLVMStyleWithColumns(42); 7801 Tab.IndentWidth = 8; 7802 Tab.UseTab = FormatStyle::UT_Always; 7803 Tab.AlignEscapedNewlinesLeft = true; 7804 7805 EXPECT_EQ("if (aaaaaaaa && // q\n" 7806 " bb)\t\t// w\n" 7807 "\t;", 7808 format("if (aaaaaaaa &&// q\n" 7809 "bb)// w\n" 7810 ";", 7811 Tab)); 7812 EXPECT_EQ("if (aaa && bbb) // w\n" 7813 "\t;", 7814 format("if(aaa&&bbb)// w\n" 7815 ";", 7816 Tab)); 7817 7818 verifyFormat("class X {\n" 7819 "\tvoid f() {\n" 7820 "\t\tsomeFunction(parameter1,\n" 7821 "\t\t\t parameter2);\n" 7822 "\t}\n" 7823 "};", 7824 Tab); 7825 verifyFormat("#define A \\\n" 7826 "\tvoid f() { \\\n" 7827 "\t\tsomeFunction( \\\n" 7828 "\t\t parameter1, \\\n" 7829 "\t\t parameter2); \\\n" 7830 "\t}", 7831 Tab); 7832 EXPECT_EQ("void f() {\n" 7833 "\tf();\n" 7834 "\tg();\n" 7835 "}", 7836 format("void f() {\n" 7837 "\tf();\n" 7838 "\tg();\n" 7839 "}", 7840 0, 0, Tab)); 7841 EXPECT_EQ("void f() {\n" 7842 "\tf();\n" 7843 "\tg();\n" 7844 "}", 7845 format("void f() {\n" 7846 "\tf();\n" 7847 "\tg();\n" 7848 "}", 7849 16, 0, Tab)); 7850 EXPECT_EQ("void f() {\n" 7851 " \tf();\n" 7852 "\tg();\n" 7853 "}", 7854 format("void f() {\n" 7855 " \tf();\n" 7856 " \tg();\n" 7857 "}", 7858 21, 0, Tab)); 7859 7860 Tab.TabWidth = 4; 7861 Tab.IndentWidth = 8; 7862 verifyFormat("class TabWidth4Indent8 {\n" 7863 "\t\tvoid f() {\n" 7864 "\t\t\t\tsomeFunction(parameter1,\n" 7865 "\t\t\t\t\t\t\t parameter2);\n" 7866 "\t\t}\n" 7867 "};", 7868 Tab); 7869 7870 Tab.TabWidth = 4; 7871 Tab.IndentWidth = 4; 7872 verifyFormat("class TabWidth4Indent4 {\n" 7873 "\tvoid f() {\n" 7874 "\t\tsomeFunction(parameter1,\n" 7875 "\t\t\t\t\t parameter2);\n" 7876 "\t}\n" 7877 "};", 7878 Tab); 7879 7880 Tab.TabWidth = 8; 7881 Tab.IndentWidth = 4; 7882 verifyFormat("class TabWidth8Indent4 {\n" 7883 " void f() {\n" 7884 "\tsomeFunction(parameter1,\n" 7885 "\t\t parameter2);\n" 7886 " }\n" 7887 "};", 7888 Tab); 7889 7890 Tab.TabWidth = 8; 7891 Tab.IndentWidth = 8; 7892 EXPECT_EQ("/*\n" 7893 "\t a\t\tcomment\n" 7894 "\t in multiple lines\n" 7895 " */", 7896 format(" /*\t \t \n" 7897 " \t \t a\t\tcomment\t \t\n" 7898 " \t \t in multiple lines\t\n" 7899 " \t */", 7900 Tab)); 7901 7902 Tab.UseTab = FormatStyle::UT_ForIndentation; 7903 verifyFormat("{\n" 7904 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7905 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7906 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7907 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7908 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7909 "\taaaaaaaaaaaaaaaaaaaaaaaaaaaa();\n" 7910 "};", 7911 Tab); 7912 verifyFormat("enum A {\n" 7913 "\ta1, // Force multiple lines\n" 7914 "\ta2,\n" 7915 "\ta3\n" 7916 "};", 7917 Tab); 7918 EXPECT_EQ("if (aaaaaaaa && // q\n" 7919 " bb) // w\n" 7920 "\t;", 7921 format("if (aaaaaaaa &&// q\n" 7922 "bb)// w\n" 7923 ";", 7924 Tab)); 7925 verifyFormat("class X {\n" 7926 "\tvoid f() {\n" 7927 "\t\tsomeFunction(parameter1,\n" 7928 "\t\t parameter2);\n" 7929 "\t}\n" 7930 "};", 7931 Tab); 7932 verifyFormat("{\n" 7933 "\tQ({\n" 7934 "\t\tint a;\n" 7935 "\t\tsomeFunction(aaaaaaaa,\n" 7936 "\t\t bbbbbbb);\n" 7937 "\t}, p);\n" 7938 "}", 7939 Tab); 7940 EXPECT_EQ("{\n" 7941 "\t/* aaaa\n" 7942 "\t bbbb */\n" 7943 "}", 7944 format("{\n" 7945 "/* aaaa\n" 7946 " bbbb */\n" 7947 "}", 7948 Tab)); 7949 EXPECT_EQ("{\n" 7950 "\t/*\n" 7951 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7952 "\t bbbbbbbbbbbbb\n" 7953 "\t*/\n" 7954 "}", 7955 format("{\n" 7956 "/*\n" 7957 " aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7958 "*/\n" 7959 "}", 7960 Tab)); 7961 EXPECT_EQ("{\n" 7962 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7963 "\t// bbbbbbbbbbbbb\n" 7964 "}", 7965 format("{\n" 7966 "\t// aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7967 "}", 7968 Tab)); 7969 EXPECT_EQ("{\n" 7970 "\t/*\n" 7971 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa\n" 7972 "\t bbbbbbbbbbbbb\n" 7973 "\t*/\n" 7974 "}", 7975 format("{\n" 7976 "\t/*\n" 7977 "\t aaaaaaaaaaaaaaaaaaaaaaaaaa bbbbbbbbbbbbb\n" 7978 "\t*/\n" 7979 "}", 7980 Tab)); 7981 EXPECT_EQ("{\n" 7982 "\t/*\n" 7983 "\n" 7984 "\t*/\n" 7985 "}", 7986 format("{\n" 7987 "\t/*\n" 7988 "\n" 7989 "\t*/\n" 7990 "}", 7991 Tab)); 7992 EXPECT_EQ("{\n" 7993 "\t/*\n" 7994 " asdf\n" 7995 "\t*/\n" 7996 "}", 7997 format("{\n" 7998 "\t/*\n" 7999 " asdf\n" 8000 "\t*/\n" 8001 "}", 8002 Tab)); 8003 8004 Tab.UseTab = FormatStyle::UT_Never; 8005 EXPECT_EQ("/*\n" 8006 " a\t\tcomment\n" 8007 " in multiple lines\n" 8008 " */", 8009 format(" /*\t \t \n" 8010 " \t \t a\t\tcomment\t \t\n" 8011 " \t \t in multiple lines\t\n" 8012 " \t */", 8013 Tab)); 8014 EXPECT_EQ("/* some\n" 8015 " comment */", 8016 format(" \t \t /* some\n" 8017 " \t \t comment */", 8018 Tab)); 8019 EXPECT_EQ("int a; /* some\n" 8020 " comment */", 8021 format(" \t \t int a; /* some\n" 8022 " \t \t comment */", 8023 Tab)); 8024 8025 EXPECT_EQ("int a; /* some\n" 8026 "comment */", 8027 format(" \t \t int\ta; /* some\n" 8028 " \t \t comment */", 8029 Tab)); 8030 EXPECT_EQ("f(\"\t\t\"); /* some\n" 8031 " comment */", 8032 format(" \t \t f(\"\t\t\"); /* some\n" 8033 " \t \t comment */", 8034 Tab)); 8035 EXPECT_EQ("{\n" 8036 " /*\n" 8037 " * Comment\n" 8038 " */\n" 8039 " int i;\n" 8040 "}", 8041 format("{\n" 8042 "\t/*\n" 8043 "\t * Comment\n" 8044 "\t */\n" 8045 "\t int i;\n" 8046 "}")); 8047 } 8048 8049 TEST_F(FormatTest, CalculatesOriginalColumn) { 8050 EXPECT_EQ("\"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 8051 "q\"; /* some\n" 8052 " comment */", 8053 format(" \"qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 8054 "q\"; /* some\n" 8055 " comment */", 8056 getLLVMStyle())); 8057 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 8058 "/* some\n" 8059 " comment */", 8060 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\n" 8061 " /* some\n" 8062 " comment */", 8063 getLLVMStyle())); 8064 EXPECT_EQ("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 8065 "qqq\n" 8066 "/* some\n" 8067 " comment */", 8068 format("// qqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 8069 "qqq\n" 8070 " /* some\n" 8071 " comment */", 8072 getLLVMStyle())); 8073 EXPECT_EQ("inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 8074 "wwww; /* some\n" 8075 " comment */", 8076 format(" inttt qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqq\\\n" 8077 "wwww; /* some\n" 8078 " comment */", 8079 getLLVMStyle())); 8080 } 8081 8082 TEST_F(FormatTest, ConfigurableSpaceBeforeParens) { 8083 FormatStyle NoSpace = getLLVMStyle(); 8084 NoSpace.SpaceBeforeParens = FormatStyle::SBPO_Never; 8085 8086 verifyFormat("while(true)\n" 8087 " continue;", NoSpace); 8088 verifyFormat("for(;;)\n" 8089 " continue;", NoSpace); 8090 verifyFormat("if(true)\n" 8091 " f();\n" 8092 "else if(true)\n" 8093 " f();", NoSpace); 8094 verifyFormat("do {\n" 8095 " do_something();\n" 8096 "} while(something());", NoSpace); 8097 verifyFormat("switch(x) {\n" 8098 "default:\n" 8099 " break;\n" 8100 "}", NoSpace); 8101 verifyFormat("auto i = std::make_unique<int>(5);", NoSpace); 8102 verifyFormat("size_t x = sizeof(x);", NoSpace); 8103 verifyFormat("auto f(int x) -> decltype(x);", NoSpace); 8104 verifyFormat("int f(T x) noexcept(x.create());", NoSpace); 8105 verifyFormat("alignas(128) char a[128];", NoSpace); 8106 verifyFormat("size_t x = alignof(MyType);", NoSpace); 8107 verifyFormat("static_assert(sizeof(char) == 1, \"Impossible!\");", NoSpace); 8108 verifyFormat("int f() throw(Deprecated);", NoSpace); 8109 8110 FormatStyle Space = getLLVMStyle(); 8111 Space.SpaceBeforeParens = FormatStyle::SBPO_Always; 8112 8113 verifyFormat("int f ();", Space); 8114 verifyFormat("void f (int a, T b) {\n" 8115 " while (true)\n" 8116 " continue;\n" 8117 "}", 8118 Space); 8119 verifyFormat("if (true)\n" 8120 " f ();\n" 8121 "else if (true)\n" 8122 " f ();", 8123 Space); 8124 verifyFormat("do {\n" 8125 " do_something ();\n" 8126 "} while (something ());", 8127 Space); 8128 verifyFormat("switch (x) {\n" 8129 "default:\n" 8130 " break;\n" 8131 "}", 8132 Space); 8133 verifyFormat("A::A () : a (1) {}", Space); 8134 verifyFormat("void f () __attribute__ ((asdf));", Space); 8135 verifyFormat("*(&a + 1);\n" 8136 "&((&a)[1]);\n" 8137 "a[(b + c) * d];\n" 8138 "(((a + 1) * 2) + 3) * 4;", 8139 Space); 8140 verifyFormat("#define A(x) x", Space); 8141 verifyFormat("#define A (x) x", Space); 8142 verifyFormat("#if defined(x)\n" 8143 "#endif", 8144 Space); 8145 verifyFormat("auto i = std::make_unique<int> (5);", Space); 8146 verifyFormat("size_t x = sizeof (x);", Space); 8147 verifyFormat("auto f (int x) -> decltype (x);", Space); 8148 verifyFormat("int f (T x) noexcept (x.create ());", Space); 8149 verifyFormat("alignas (128) char a[128];", Space); 8150 verifyFormat("size_t x = alignof (MyType);", Space); 8151 verifyFormat("static_assert (sizeof (char) == 1, \"Impossible!\");", Space); 8152 verifyFormat("int f () throw (Deprecated);", Space); 8153 } 8154 8155 TEST_F(FormatTest, ConfigurableSpacesInParentheses) { 8156 FormatStyle Spaces = getLLVMStyle(); 8157 8158 Spaces.SpacesInParentheses = true; 8159 verifyFormat("call( x, y, z );", Spaces); 8160 verifyFormat("while ( (bool)1 )\n" 8161 " continue;", Spaces); 8162 verifyFormat("for ( ;; )\n" 8163 " continue;", Spaces); 8164 verifyFormat("if ( true )\n" 8165 " f();\n" 8166 "else if ( true )\n" 8167 " f();", Spaces); 8168 verifyFormat("do {\n" 8169 " do_something( (int)i );\n" 8170 "} while ( something() );", Spaces); 8171 verifyFormat("switch ( x ) {\n" 8172 "default:\n" 8173 " break;\n" 8174 "}", Spaces); 8175 8176 Spaces.SpacesInParentheses = false; 8177 Spaces.SpacesInCStyleCastParentheses = true; 8178 verifyFormat("Type *A = ( Type * )P;", Spaces); 8179 verifyFormat("Type *A = ( vector<Type *, int *> )P;", Spaces); 8180 verifyFormat("x = ( int32 )y;", Spaces); 8181 verifyFormat("int a = ( int )(2.0f);", Spaces); 8182 verifyFormat("#define AA(X) sizeof((( X * )NULL)->a)", Spaces); 8183 verifyFormat("my_int a = ( my_int )sizeof(int);", Spaces); 8184 verifyFormat("#define x (( int )-1)", Spaces); 8185 8186 Spaces.SpacesInParentheses = false; 8187 Spaces.SpaceInEmptyParentheses = true; 8188 verifyFormat("call(x, y, z);", Spaces); 8189 verifyFormat("call( )", Spaces); 8190 8191 // Run the first set of tests again with 8192 // Spaces.SpacesInParentheses = false, 8193 // Spaces.SpaceInEmptyParentheses = true and 8194 // Spaces.SpacesInCStyleCastParentheses = true 8195 Spaces.SpacesInParentheses = false, 8196 Spaces.SpaceInEmptyParentheses = true; 8197 Spaces.SpacesInCStyleCastParentheses = true; 8198 verifyFormat("call(x, y, z);", Spaces); 8199 verifyFormat("while (( bool )1)\n" 8200 " continue;", Spaces); 8201 verifyFormat("for (;;)\n" 8202 " continue;", Spaces); 8203 verifyFormat("if (true)\n" 8204 " f( );\n" 8205 "else if (true)\n" 8206 " f( );", Spaces); 8207 verifyFormat("do {\n" 8208 " do_something(( int )i);\n" 8209 "} while (something( ));", Spaces); 8210 verifyFormat("switch (x) {\n" 8211 "default:\n" 8212 " break;\n" 8213 "}", Spaces); 8214 8215 Spaces.SpaceAfterCStyleCast = true; 8216 verifyFormat("call(x, y, z);", Spaces); 8217 verifyFormat("while (( bool ) 1)\n" 8218 " continue;", 8219 Spaces); 8220 verifyFormat("for (;;)\n" 8221 " continue;", 8222 Spaces); 8223 verifyFormat("if (true)\n" 8224 " f( );\n" 8225 "else if (true)\n" 8226 " f( );", 8227 Spaces); 8228 verifyFormat("do {\n" 8229 " do_something(( int ) i);\n" 8230 "} while (something( ));", 8231 Spaces); 8232 verifyFormat("switch (x) {\n" 8233 "default:\n" 8234 " break;\n" 8235 "}", 8236 Spaces); 8237 Spaces.SpacesInCStyleCastParentheses = false; 8238 Spaces.SpaceAfterCStyleCast = true; 8239 verifyFormat("while ((bool) 1)\n" 8240 " continue;", 8241 Spaces); 8242 verifyFormat("do {\n" 8243 " do_something((int) i);\n" 8244 "} while (something( ));", 8245 Spaces); 8246 } 8247 8248 TEST_F(FormatTest, ConfigurableSpacesInSquareBrackets) { 8249 verifyFormat("int a[5];"); 8250 verifyFormat("a[3] += 42;"); 8251 8252 FormatStyle Spaces = getLLVMStyle(); 8253 Spaces.SpacesInSquareBrackets = true; 8254 // Lambdas unchanged. 8255 verifyFormat("int c = []() -> int { return 2; }();\n", Spaces); 8256 verifyFormat("return [i, args...] {};", Spaces); 8257 8258 // Not lambdas. 8259 verifyFormat("int a[ 5 ];", Spaces); 8260 verifyFormat("a[ 3 ] += 42;", Spaces); 8261 verifyFormat("constexpr char hello[]{\"hello\"};", Spaces); 8262 verifyFormat("double &operator[](int i) { return 0; }\n" 8263 "int i;", 8264 Spaces); 8265 verifyFormat("std::unique_ptr<int[]> foo() {}", Spaces); 8266 verifyFormat("int i = a[ a ][ a ]->f();", Spaces); 8267 verifyFormat("int i = (*b)[ a ]->f();", Spaces); 8268 } 8269 8270 TEST_F(FormatTest, ConfigurableSpaceBeforeAssignmentOperators) { 8271 verifyFormat("int a = 5;"); 8272 verifyFormat("a += 42;"); 8273 verifyFormat("a or_eq 8;"); 8274 8275 FormatStyle Spaces = getLLVMStyle(); 8276 Spaces.SpaceBeforeAssignmentOperators = false; 8277 verifyFormat("int a= 5;", Spaces); 8278 verifyFormat("a+= 42;", Spaces); 8279 verifyFormat("a or_eq 8;", Spaces); 8280 } 8281 8282 TEST_F(FormatTest, LinuxBraceBreaking) { 8283 FormatStyle LinuxBraceStyle = getLLVMStyle(); 8284 LinuxBraceStyle.BreakBeforeBraces = FormatStyle::BS_Linux; 8285 verifyFormat("namespace a\n" 8286 "{\n" 8287 "class A\n" 8288 "{\n" 8289 " void f()\n" 8290 " {\n" 8291 " if (true) {\n" 8292 " a();\n" 8293 " b();\n" 8294 " }\n" 8295 " }\n" 8296 " void g() { return; }\n" 8297 "};\n" 8298 "struct B {\n" 8299 " int x;\n" 8300 "};\n" 8301 "}\n", 8302 LinuxBraceStyle); 8303 verifyFormat("enum X {\n" 8304 " Y = 0,\n" 8305 "}\n", 8306 LinuxBraceStyle); 8307 verifyFormat("struct S {\n" 8308 " int Type;\n" 8309 " union {\n" 8310 " int x;\n" 8311 " double y;\n" 8312 " } Value;\n" 8313 " class C\n" 8314 " {\n" 8315 " MyFavoriteType Value;\n" 8316 " } Class;\n" 8317 "}\n", 8318 LinuxBraceStyle); 8319 } 8320 8321 TEST_F(FormatTest, StroustrupBraceBreaking) { 8322 FormatStyle StroustrupBraceStyle = getLLVMStyle(); 8323 StroustrupBraceStyle.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 8324 verifyFormat("namespace a {\n" 8325 "class A {\n" 8326 " void f()\n" 8327 " {\n" 8328 " if (true) {\n" 8329 " a();\n" 8330 " b();\n" 8331 " }\n" 8332 " }\n" 8333 " void g() { return; }\n" 8334 "};\n" 8335 "struct B {\n" 8336 " int x;\n" 8337 "};\n" 8338 "}\n", 8339 StroustrupBraceStyle); 8340 8341 verifyFormat("void foo()\n" 8342 "{\n" 8343 " if (a) {\n" 8344 " a();\n" 8345 " }\n" 8346 " else {\n" 8347 " b();\n" 8348 " }\n" 8349 "}\n", 8350 StroustrupBraceStyle); 8351 8352 verifyFormat("#ifdef _DEBUG\n" 8353 "int foo(int i = 0)\n" 8354 "#else\n" 8355 "int foo(int i = 5)\n" 8356 "#endif\n" 8357 "{\n" 8358 " return i;\n" 8359 "}", 8360 StroustrupBraceStyle); 8361 8362 verifyFormat("void foo() {}\n" 8363 "void bar()\n" 8364 "#ifdef _DEBUG\n" 8365 "{\n" 8366 " foo();\n" 8367 "}\n" 8368 "#else\n" 8369 "{\n" 8370 "}\n" 8371 "#endif", 8372 StroustrupBraceStyle); 8373 8374 verifyFormat("void foobar() { int i = 5; }\n" 8375 "#ifdef _DEBUG\n" 8376 "void bar() {}\n" 8377 "#else\n" 8378 "void bar() { foobar(); }\n" 8379 "#endif", 8380 StroustrupBraceStyle); 8381 } 8382 8383 TEST_F(FormatTest, AllmanBraceBreaking) { 8384 FormatStyle AllmanBraceStyle = getLLVMStyle(); 8385 AllmanBraceStyle.BreakBeforeBraces = FormatStyle::BS_Allman; 8386 verifyFormat("namespace a\n" 8387 "{\n" 8388 "class A\n" 8389 "{\n" 8390 " void f()\n" 8391 " {\n" 8392 " if (true)\n" 8393 " {\n" 8394 " a();\n" 8395 " b();\n" 8396 " }\n" 8397 " }\n" 8398 " void g() { return; }\n" 8399 "};\n" 8400 "struct B\n" 8401 "{\n" 8402 " int x;\n" 8403 "};\n" 8404 "}", 8405 AllmanBraceStyle); 8406 8407 verifyFormat("void f()\n" 8408 "{\n" 8409 " if (true)\n" 8410 " {\n" 8411 " a();\n" 8412 " }\n" 8413 " else if (false)\n" 8414 " {\n" 8415 " b();\n" 8416 " }\n" 8417 " else\n" 8418 " {\n" 8419 " c();\n" 8420 " }\n" 8421 "}\n", 8422 AllmanBraceStyle); 8423 8424 verifyFormat("void f()\n" 8425 "{\n" 8426 " for (int i = 0; i < 10; ++i)\n" 8427 " {\n" 8428 " a();\n" 8429 " }\n" 8430 " while (false)\n" 8431 " {\n" 8432 " b();\n" 8433 " }\n" 8434 " do\n" 8435 " {\n" 8436 " c();\n" 8437 " } while (false)\n" 8438 "}\n", 8439 AllmanBraceStyle); 8440 8441 verifyFormat("void f(int a)\n" 8442 "{\n" 8443 " switch (a)\n" 8444 " {\n" 8445 " case 0:\n" 8446 " break;\n" 8447 " case 1:\n" 8448 " {\n" 8449 " break;\n" 8450 " }\n" 8451 " case 2:\n" 8452 " {\n" 8453 " }\n" 8454 " break;\n" 8455 " default:\n" 8456 " break;\n" 8457 " }\n" 8458 "}\n", 8459 AllmanBraceStyle); 8460 8461 verifyFormat("enum X\n" 8462 "{\n" 8463 " Y = 0,\n" 8464 "}\n", 8465 AllmanBraceStyle); 8466 verifyFormat("enum X\n" 8467 "{\n" 8468 " Y = 0\n" 8469 "}\n", 8470 AllmanBraceStyle); 8471 8472 verifyFormat("@interface BSApplicationController ()\n" 8473 "{\n" 8474 "@private\n" 8475 " id _extraIvar;\n" 8476 "}\n" 8477 "@end\n", 8478 AllmanBraceStyle); 8479 8480 verifyFormat("#ifdef _DEBUG\n" 8481 "int foo(int i = 0)\n" 8482 "#else\n" 8483 "int foo(int i = 5)\n" 8484 "#endif\n" 8485 "{\n" 8486 " return i;\n" 8487 "}", 8488 AllmanBraceStyle); 8489 8490 verifyFormat("void foo() {}\n" 8491 "void bar()\n" 8492 "#ifdef _DEBUG\n" 8493 "{\n" 8494 " foo();\n" 8495 "}\n" 8496 "#else\n" 8497 "{\n" 8498 "}\n" 8499 "#endif", 8500 AllmanBraceStyle); 8501 8502 verifyFormat("void foobar() { int i = 5; }\n" 8503 "#ifdef _DEBUG\n" 8504 "void bar() {}\n" 8505 "#else\n" 8506 "void bar() { foobar(); }\n" 8507 "#endif", 8508 AllmanBraceStyle); 8509 8510 // This shouldn't affect ObjC blocks.. 8511 verifyFormat("[self doSomeThingWithACompletionHandler:^{\n" 8512 " // ...\n" 8513 " int i;\n" 8514 "}];", 8515 AllmanBraceStyle); 8516 verifyFormat("void (^block)(void) = ^{\n" 8517 " // ...\n" 8518 " int i;\n" 8519 "};", 8520 AllmanBraceStyle); 8521 // .. or dict literals. 8522 verifyFormat("void f()\n" 8523 "{\n" 8524 " [object someMethod:@{ @\"a\" : @\"b\" }];\n" 8525 "}", 8526 AllmanBraceStyle); 8527 verifyFormat("int f()\n" 8528 "{ // comment\n" 8529 " return 42;\n" 8530 "}", 8531 AllmanBraceStyle); 8532 8533 AllmanBraceStyle.ColumnLimit = 19; 8534 verifyFormat("void f() { int i; }", AllmanBraceStyle); 8535 AllmanBraceStyle.ColumnLimit = 18; 8536 verifyFormat("void f()\n" 8537 "{\n" 8538 " int i;\n" 8539 "}", 8540 AllmanBraceStyle); 8541 AllmanBraceStyle.ColumnLimit = 80; 8542 8543 FormatStyle BreakBeforeBraceShortIfs = AllmanBraceStyle; 8544 BreakBeforeBraceShortIfs.AllowShortIfStatementsOnASingleLine = true; 8545 BreakBeforeBraceShortIfs.AllowShortLoopsOnASingleLine = true; 8546 verifyFormat("void f(bool b)\n" 8547 "{\n" 8548 " if (b)\n" 8549 " {\n" 8550 " return;\n" 8551 " }\n" 8552 "}\n", 8553 BreakBeforeBraceShortIfs); 8554 verifyFormat("void f(bool b)\n" 8555 "{\n" 8556 " if (b) return;\n" 8557 "}\n", 8558 BreakBeforeBraceShortIfs); 8559 verifyFormat("void f(bool b)\n" 8560 "{\n" 8561 " while (b)\n" 8562 " {\n" 8563 " return;\n" 8564 " }\n" 8565 "}\n", 8566 BreakBeforeBraceShortIfs); 8567 } 8568 8569 TEST_F(FormatTest, GNUBraceBreaking) { 8570 FormatStyle GNUBraceStyle = getLLVMStyle(); 8571 GNUBraceStyle.BreakBeforeBraces = FormatStyle::BS_GNU; 8572 verifyFormat("namespace a\n" 8573 "{\n" 8574 "class A\n" 8575 "{\n" 8576 " void f()\n" 8577 " {\n" 8578 " int a;\n" 8579 " {\n" 8580 " int b;\n" 8581 " }\n" 8582 " if (true)\n" 8583 " {\n" 8584 " a();\n" 8585 " b();\n" 8586 " }\n" 8587 " }\n" 8588 " void g() { return; }\n" 8589 "}\n" 8590 "}", 8591 GNUBraceStyle); 8592 8593 verifyFormat("void f()\n" 8594 "{\n" 8595 " if (true)\n" 8596 " {\n" 8597 " a();\n" 8598 " }\n" 8599 " else if (false)\n" 8600 " {\n" 8601 " b();\n" 8602 " }\n" 8603 " else\n" 8604 " {\n" 8605 " c();\n" 8606 " }\n" 8607 "}\n", 8608 GNUBraceStyle); 8609 8610 verifyFormat("void f()\n" 8611 "{\n" 8612 " for (int i = 0; i < 10; ++i)\n" 8613 " {\n" 8614 " a();\n" 8615 " }\n" 8616 " while (false)\n" 8617 " {\n" 8618 " b();\n" 8619 " }\n" 8620 " do\n" 8621 " {\n" 8622 " c();\n" 8623 " }\n" 8624 " while (false);\n" 8625 "}\n", 8626 GNUBraceStyle); 8627 8628 verifyFormat("void f(int a)\n" 8629 "{\n" 8630 " switch (a)\n" 8631 " {\n" 8632 " case 0:\n" 8633 " break;\n" 8634 " case 1:\n" 8635 " {\n" 8636 " break;\n" 8637 " }\n" 8638 " case 2:\n" 8639 " {\n" 8640 " }\n" 8641 " break;\n" 8642 " default:\n" 8643 " break;\n" 8644 " }\n" 8645 "}\n", 8646 GNUBraceStyle); 8647 8648 verifyFormat("enum X\n" 8649 "{\n" 8650 " Y = 0,\n" 8651 "}\n", 8652 GNUBraceStyle); 8653 8654 verifyFormat("@interface BSApplicationController ()\n" 8655 "{\n" 8656 "@private\n" 8657 " id _extraIvar;\n" 8658 "}\n" 8659 "@end\n", 8660 GNUBraceStyle); 8661 8662 verifyFormat("#ifdef _DEBUG\n" 8663 "int foo(int i = 0)\n" 8664 "#else\n" 8665 "int foo(int i = 5)\n" 8666 "#endif\n" 8667 "{\n" 8668 " return i;\n" 8669 "}", 8670 GNUBraceStyle); 8671 8672 verifyFormat("void foo() {}\n" 8673 "void bar()\n" 8674 "#ifdef _DEBUG\n" 8675 "{\n" 8676 " foo();\n" 8677 "}\n" 8678 "#else\n" 8679 "{\n" 8680 "}\n" 8681 "#endif", 8682 GNUBraceStyle); 8683 8684 verifyFormat("void foobar() { int i = 5; }\n" 8685 "#ifdef _DEBUG\n" 8686 "void bar() {}\n" 8687 "#else\n" 8688 "void bar() { foobar(); }\n" 8689 "#endif", 8690 GNUBraceStyle); 8691 } 8692 TEST_F(FormatTest, CatchExceptionReferenceBinding) { 8693 verifyFormat("void f() {\n" 8694 " try {\n" 8695 " } catch (const Exception &e) {\n" 8696 " }\n" 8697 "}\n", 8698 getLLVMStyle()); 8699 } 8700 8701 TEST_F(FormatTest, UnderstandsPragmas) { 8702 verifyFormat("#pragma omp reduction(| : var)"); 8703 verifyFormat("#pragma omp reduction(+ : var)"); 8704 8705 EXPECT_EQ("#pragma mark Any non-hyphenated or hyphenated string " 8706 "(including parentheses).", 8707 format("#pragma mark Any non-hyphenated or hyphenated string " 8708 "(including parentheses).")); 8709 } 8710 8711 #define EXPECT_ALL_STYLES_EQUAL(Styles) \ 8712 for (size_t i = 1; i < Styles.size(); ++i) \ 8713 EXPECT_EQ(Styles[0], Styles[i]) << "Style #" << i << " of " \ 8714 << Styles.size() \ 8715 << " differs from Style #0" 8716 8717 TEST_F(FormatTest, GetsPredefinedStyleByName) { 8718 SmallVector<FormatStyle, 3> Styles; 8719 Styles.resize(3); 8720 8721 Styles[0] = getLLVMStyle(); 8722 EXPECT_TRUE(getPredefinedStyle("LLVM", FormatStyle::LK_Cpp, &Styles[1])); 8723 EXPECT_TRUE(getPredefinedStyle("lLvM", FormatStyle::LK_Cpp, &Styles[2])); 8724 EXPECT_ALL_STYLES_EQUAL(Styles); 8725 8726 Styles[0] = getGoogleStyle(); 8727 EXPECT_TRUE(getPredefinedStyle("Google", FormatStyle::LK_Cpp, &Styles[1])); 8728 EXPECT_TRUE(getPredefinedStyle("gOOgle", FormatStyle::LK_Cpp, &Styles[2])); 8729 EXPECT_ALL_STYLES_EQUAL(Styles); 8730 8731 Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); 8732 EXPECT_TRUE( 8733 getPredefinedStyle("Google", FormatStyle::LK_JavaScript, &Styles[1])); 8734 EXPECT_TRUE( 8735 getPredefinedStyle("gOOgle", FormatStyle::LK_JavaScript, &Styles[2])); 8736 EXPECT_ALL_STYLES_EQUAL(Styles); 8737 8738 Styles[0] = getChromiumStyle(FormatStyle::LK_Cpp); 8739 EXPECT_TRUE(getPredefinedStyle("Chromium", FormatStyle::LK_Cpp, &Styles[1])); 8740 EXPECT_TRUE(getPredefinedStyle("cHRoMiUM", FormatStyle::LK_Cpp, &Styles[2])); 8741 EXPECT_ALL_STYLES_EQUAL(Styles); 8742 8743 Styles[0] = getMozillaStyle(); 8744 EXPECT_TRUE(getPredefinedStyle("Mozilla", FormatStyle::LK_Cpp, &Styles[1])); 8745 EXPECT_TRUE(getPredefinedStyle("moZILla", FormatStyle::LK_Cpp, &Styles[2])); 8746 EXPECT_ALL_STYLES_EQUAL(Styles); 8747 8748 Styles[0] = getWebKitStyle(); 8749 EXPECT_TRUE(getPredefinedStyle("WebKit", FormatStyle::LK_Cpp, &Styles[1])); 8750 EXPECT_TRUE(getPredefinedStyle("wEbKit", FormatStyle::LK_Cpp, &Styles[2])); 8751 EXPECT_ALL_STYLES_EQUAL(Styles); 8752 8753 Styles[0] = getGNUStyle(); 8754 EXPECT_TRUE(getPredefinedStyle("GNU", FormatStyle::LK_Cpp, &Styles[1])); 8755 EXPECT_TRUE(getPredefinedStyle("gnU", FormatStyle::LK_Cpp, &Styles[2])); 8756 EXPECT_ALL_STYLES_EQUAL(Styles); 8757 8758 EXPECT_FALSE(getPredefinedStyle("qwerty", FormatStyle::LK_Cpp, &Styles[0])); 8759 } 8760 8761 TEST_F(FormatTest, GetsCorrectBasedOnStyle) { 8762 SmallVector<FormatStyle, 8> Styles; 8763 Styles.resize(2); 8764 8765 Styles[0] = getGoogleStyle(); 8766 Styles[1] = getLLVMStyle(); 8767 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); 8768 EXPECT_ALL_STYLES_EQUAL(Styles); 8769 8770 Styles.resize(5); 8771 Styles[0] = getGoogleStyle(FormatStyle::LK_JavaScript); 8772 Styles[1] = getLLVMStyle(); 8773 Styles[1].Language = FormatStyle::LK_JavaScript; 8774 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Styles[1]).value()); 8775 8776 Styles[2] = getLLVMStyle(); 8777 Styles[2].Language = FormatStyle::LK_JavaScript; 8778 EXPECT_EQ(0, parseConfiguration("Language: JavaScript\n" 8779 "BasedOnStyle: Google", 8780 &Styles[2]).value()); 8781 8782 Styles[3] = getLLVMStyle(); 8783 Styles[3].Language = FormatStyle::LK_JavaScript; 8784 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google\n" 8785 "Language: JavaScript", 8786 &Styles[3]).value()); 8787 8788 Styles[4] = getLLVMStyle(); 8789 Styles[4].Language = FormatStyle::LK_JavaScript; 8790 EXPECT_EQ(0, parseConfiguration("---\n" 8791 "BasedOnStyle: LLVM\n" 8792 "IndentWidth: 123\n" 8793 "---\n" 8794 "BasedOnStyle: Google\n" 8795 "Language: JavaScript", 8796 &Styles[4]).value()); 8797 EXPECT_ALL_STYLES_EQUAL(Styles); 8798 } 8799 8800 #define CHECK_PARSE_BOOL_FIELD(FIELD, CONFIG_NAME) \ 8801 Style.FIELD = false; \ 8802 EXPECT_EQ(0, parseConfiguration(CONFIG_NAME ": true", &Style).value()); \ 8803 EXPECT_TRUE(Style.FIELD); \ 8804 EXPECT_EQ(0, parseConfiguration(CONFIG_NAME ": false", &Style).value()); \ 8805 EXPECT_FALSE(Style.FIELD); 8806 8807 #define CHECK_PARSE_BOOL(FIELD) CHECK_PARSE_BOOL_FIELD(FIELD, #FIELD) 8808 8809 #define CHECK_PARSE(TEXT, FIELD, VALUE) \ 8810 EXPECT_NE(VALUE, Style.FIELD); \ 8811 EXPECT_EQ(0, parseConfiguration(TEXT, &Style).value()); \ 8812 EXPECT_EQ(VALUE, Style.FIELD) 8813 8814 TEST_F(FormatTest, ParsesConfigurationBools) { 8815 FormatStyle Style = {}; 8816 Style.Language = FormatStyle::LK_Cpp; 8817 CHECK_PARSE_BOOL(AlignAfterOpenBracket); 8818 CHECK_PARSE_BOOL(AlignEscapedNewlinesLeft); 8819 CHECK_PARSE_BOOL(AlignOperands); 8820 CHECK_PARSE_BOOL(AlignTrailingComments); 8821 CHECK_PARSE_BOOL(AllowAllParametersOfDeclarationOnNextLine); 8822 CHECK_PARSE_BOOL(AllowShortBlocksOnASingleLine); 8823 CHECK_PARSE_BOOL(AllowShortCaseLabelsOnASingleLine); 8824 CHECK_PARSE_BOOL(AllowShortIfStatementsOnASingleLine); 8825 CHECK_PARSE_BOOL(AllowShortLoopsOnASingleLine); 8826 CHECK_PARSE_BOOL(AlwaysBreakAfterDefinitionReturnType); 8827 CHECK_PARSE_BOOL(AlwaysBreakTemplateDeclarations); 8828 CHECK_PARSE_BOOL(BinPackParameters); 8829 CHECK_PARSE_BOOL(BinPackArguments); 8830 CHECK_PARSE_BOOL(BreakBeforeTernaryOperators); 8831 CHECK_PARSE_BOOL(BreakConstructorInitializersBeforeComma); 8832 CHECK_PARSE_BOOL(ConstructorInitializerAllOnOneLineOrOnePerLine); 8833 CHECK_PARSE_BOOL(DerivePointerAlignment); 8834 CHECK_PARSE_BOOL_FIELD(DerivePointerAlignment, "DerivePointerBinding"); 8835 CHECK_PARSE_BOOL(IndentCaseLabels); 8836 CHECK_PARSE_BOOL(IndentWrappedFunctionNames); 8837 CHECK_PARSE_BOOL(KeepEmptyLinesAtTheStartOfBlocks); 8838 CHECK_PARSE_BOOL(ObjCSpaceAfterProperty); 8839 CHECK_PARSE_BOOL(ObjCSpaceBeforeProtocolList); 8840 CHECK_PARSE_BOOL(Cpp11BracedListStyle); 8841 CHECK_PARSE_BOOL(SpacesInParentheses); 8842 CHECK_PARSE_BOOL(SpacesInSquareBrackets); 8843 CHECK_PARSE_BOOL(SpacesInAngles); 8844 CHECK_PARSE_BOOL(SpaceInEmptyParentheses); 8845 CHECK_PARSE_BOOL(SpacesInContainerLiterals); 8846 CHECK_PARSE_BOOL(SpacesInCStyleCastParentheses); 8847 CHECK_PARSE_BOOL(SpaceAfterCStyleCast); 8848 CHECK_PARSE_BOOL(SpaceBeforeAssignmentOperators); 8849 } 8850 8851 #undef CHECK_PARSE_BOOL 8852 8853 TEST_F(FormatTest, ParsesConfiguration) { 8854 FormatStyle Style = {}; 8855 Style.Language = FormatStyle::LK_Cpp; 8856 CHECK_PARSE("AccessModifierOffset: -1234", AccessModifierOffset, -1234); 8857 CHECK_PARSE("ConstructorInitializerIndentWidth: 1234", 8858 ConstructorInitializerIndentWidth, 1234u); 8859 CHECK_PARSE("ObjCBlockIndentWidth: 1234", ObjCBlockIndentWidth, 1234u); 8860 CHECK_PARSE("ColumnLimit: 1234", ColumnLimit, 1234u); 8861 CHECK_PARSE("MaxEmptyLinesToKeep: 1234", MaxEmptyLinesToKeep, 1234u); 8862 CHECK_PARSE("PenaltyBreakBeforeFirstCallParameter: 1234", 8863 PenaltyBreakBeforeFirstCallParameter, 1234u); 8864 CHECK_PARSE("PenaltyExcessCharacter: 1234", PenaltyExcessCharacter, 1234u); 8865 CHECK_PARSE("PenaltyReturnTypeOnItsOwnLine: 1234", 8866 PenaltyReturnTypeOnItsOwnLine, 1234u); 8867 CHECK_PARSE("SpacesBeforeTrailingComments: 1234", 8868 SpacesBeforeTrailingComments, 1234u); 8869 CHECK_PARSE("IndentWidth: 32", IndentWidth, 32u); 8870 CHECK_PARSE("ContinuationIndentWidth: 11", ContinuationIndentWidth, 11u); 8871 8872 Style.PointerAlignment = FormatStyle::PAS_Middle; 8873 CHECK_PARSE("PointerAlignment: Left", PointerAlignment, 8874 FormatStyle::PAS_Left); 8875 CHECK_PARSE("PointerAlignment: Right", PointerAlignment, 8876 FormatStyle::PAS_Right); 8877 CHECK_PARSE("PointerAlignment: Middle", PointerAlignment, 8878 FormatStyle::PAS_Middle); 8879 // For backward compatibility: 8880 CHECK_PARSE("PointerBindsToType: Left", PointerAlignment, 8881 FormatStyle::PAS_Left); 8882 CHECK_PARSE("PointerBindsToType: Right", PointerAlignment, 8883 FormatStyle::PAS_Right); 8884 CHECK_PARSE("PointerBindsToType: Middle", PointerAlignment, 8885 FormatStyle::PAS_Middle); 8886 8887 Style.Standard = FormatStyle::LS_Auto; 8888 CHECK_PARSE("Standard: Cpp03", Standard, FormatStyle::LS_Cpp03); 8889 CHECK_PARSE("Standard: Cpp11", Standard, FormatStyle::LS_Cpp11); 8890 CHECK_PARSE("Standard: C++03", Standard, FormatStyle::LS_Cpp03); 8891 CHECK_PARSE("Standard: C++11", Standard, FormatStyle::LS_Cpp11); 8892 CHECK_PARSE("Standard: Auto", Standard, FormatStyle::LS_Auto); 8893 8894 Style.BreakBeforeBinaryOperators = FormatStyle::BOS_All; 8895 CHECK_PARSE("BreakBeforeBinaryOperators: NonAssignment", 8896 BreakBeforeBinaryOperators, FormatStyle::BOS_NonAssignment); 8897 CHECK_PARSE("BreakBeforeBinaryOperators: None", BreakBeforeBinaryOperators, 8898 FormatStyle::BOS_None); 8899 CHECK_PARSE("BreakBeforeBinaryOperators: All", BreakBeforeBinaryOperators, 8900 FormatStyle::BOS_All); 8901 // For backward compatibility: 8902 CHECK_PARSE("BreakBeforeBinaryOperators: false", BreakBeforeBinaryOperators, 8903 FormatStyle::BOS_None); 8904 CHECK_PARSE("BreakBeforeBinaryOperators: true", BreakBeforeBinaryOperators, 8905 FormatStyle::BOS_All); 8906 8907 Style.UseTab = FormatStyle::UT_ForIndentation; 8908 CHECK_PARSE("UseTab: Never", UseTab, FormatStyle::UT_Never); 8909 CHECK_PARSE("UseTab: ForIndentation", UseTab, FormatStyle::UT_ForIndentation); 8910 CHECK_PARSE("UseTab: Always", UseTab, FormatStyle::UT_Always); 8911 // For backward compatibility: 8912 CHECK_PARSE("UseTab: false", UseTab, FormatStyle::UT_Never); 8913 CHECK_PARSE("UseTab: true", UseTab, FormatStyle::UT_Always); 8914 8915 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_Inline; 8916 CHECK_PARSE("AllowShortFunctionsOnASingleLine: None", 8917 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); 8918 CHECK_PARSE("AllowShortFunctionsOnASingleLine: Inline", 8919 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_Inline); 8920 CHECK_PARSE("AllowShortFunctionsOnASingleLine: Empty", 8921 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_Empty); 8922 CHECK_PARSE("AllowShortFunctionsOnASingleLine: All", 8923 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); 8924 // For backward compatibility: 8925 CHECK_PARSE("AllowShortFunctionsOnASingleLine: false", 8926 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_None); 8927 CHECK_PARSE("AllowShortFunctionsOnASingleLine: true", 8928 AllowShortFunctionsOnASingleLine, FormatStyle::SFS_All); 8929 8930 Style.SpaceBeforeParens = FormatStyle::SBPO_Always; 8931 CHECK_PARSE("SpaceBeforeParens: Never", SpaceBeforeParens, 8932 FormatStyle::SBPO_Never); 8933 CHECK_PARSE("SpaceBeforeParens: Always", SpaceBeforeParens, 8934 FormatStyle::SBPO_Always); 8935 CHECK_PARSE("SpaceBeforeParens: ControlStatements", SpaceBeforeParens, 8936 FormatStyle::SBPO_ControlStatements); 8937 // For backward compatibility: 8938 CHECK_PARSE("SpaceAfterControlStatementKeyword: false", SpaceBeforeParens, 8939 FormatStyle::SBPO_Never); 8940 CHECK_PARSE("SpaceAfterControlStatementKeyword: true", SpaceBeforeParens, 8941 FormatStyle::SBPO_ControlStatements); 8942 8943 Style.ColumnLimit = 123; 8944 FormatStyle BaseStyle = getLLVMStyle(); 8945 CHECK_PARSE("BasedOnStyle: LLVM", ColumnLimit, BaseStyle.ColumnLimit); 8946 CHECK_PARSE("BasedOnStyle: LLVM\nColumnLimit: 1234", ColumnLimit, 1234u); 8947 8948 Style.BreakBeforeBraces = FormatStyle::BS_Stroustrup; 8949 CHECK_PARSE("BreakBeforeBraces: Attach", BreakBeforeBraces, 8950 FormatStyle::BS_Attach); 8951 CHECK_PARSE("BreakBeforeBraces: Linux", BreakBeforeBraces, 8952 FormatStyle::BS_Linux); 8953 CHECK_PARSE("BreakBeforeBraces: Stroustrup", BreakBeforeBraces, 8954 FormatStyle::BS_Stroustrup); 8955 CHECK_PARSE("BreakBeforeBraces: Allman", BreakBeforeBraces, 8956 FormatStyle::BS_Allman); 8957 CHECK_PARSE("BreakBeforeBraces: GNU", BreakBeforeBraces, FormatStyle::BS_GNU); 8958 8959 Style.NamespaceIndentation = FormatStyle::NI_All; 8960 CHECK_PARSE("NamespaceIndentation: None", NamespaceIndentation, 8961 FormatStyle::NI_None); 8962 CHECK_PARSE("NamespaceIndentation: Inner", NamespaceIndentation, 8963 FormatStyle::NI_Inner); 8964 CHECK_PARSE("NamespaceIndentation: All", NamespaceIndentation, 8965 FormatStyle::NI_All); 8966 8967 Style.ForEachMacros.clear(); 8968 std::vector<std::string> BoostForeach; 8969 BoostForeach.push_back("BOOST_FOREACH"); 8970 CHECK_PARSE("ForEachMacros: [BOOST_FOREACH]", ForEachMacros, BoostForeach); 8971 std::vector<std::string> BoostAndQForeach; 8972 BoostAndQForeach.push_back("BOOST_FOREACH"); 8973 BoostAndQForeach.push_back("Q_FOREACH"); 8974 CHECK_PARSE("ForEachMacros: [BOOST_FOREACH, Q_FOREACH]", ForEachMacros, 8975 BoostAndQForeach); 8976 } 8977 8978 TEST_F(FormatTest, ParsesConfigurationWithLanguages) { 8979 FormatStyle Style = {}; 8980 Style.Language = FormatStyle::LK_Cpp; 8981 CHECK_PARSE("Language: Cpp\n" 8982 "IndentWidth: 12", 8983 IndentWidth, 12u); 8984 EXPECT_EQ(parseConfiguration("Language: JavaScript\n" 8985 "IndentWidth: 34", 8986 &Style), 8987 ParseError::Unsuitable); 8988 EXPECT_EQ(12u, Style.IndentWidth); 8989 CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); 8990 EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); 8991 8992 Style.Language = FormatStyle::LK_JavaScript; 8993 CHECK_PARSE("Language: JavaScript\n" 8994 "IndentWidth: 12", 8995 IndentWidth, 12u); 8996 CHECK_PARSE("IndentWidth: 23", IndentWidth, 23u); 8997 EXPECT_EQ(parseConfiguration("Language: Cpp\n" 8998 "IndentWidth: 34", 8999 &Style), 9000 ParseError::Unsuitable); 9001 EXPECT_EQ(23u, Style.IndentWidth); 9002 CHECK_PARSE("IndentWidth: 56", IndentWidth, 56u); 9003 EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); 9004 9005 CHECK_PARSE("BasedOnStyle: LLVM\n" 9006 "IndentWidth: 67", 9007 IndentWidth, 67u); 9008 9009 CHECK_PARSE("---\n" 9010 "Language: JavaScript\n" 9011 "IndentWidth: 12\n" 9012 "---\n" 9013 "Language: Cpp\n" 9014 "IndentWidth: 34\n" 9015 "...\n", 9016 IndentWidth, 12u); 9017 9018 Style.Language = FormatStyle::LK_Cpp; 9019 CHECK_PARSE("---\n" 9020 "Language: JavaScript\n" 9021 "IndentWidth: 12\n" 9022 "---\n" 9023 "Language: Cpp\n" 9024 "IndentWidth: 34\n" 9025 "...\n", 9026 IndentWidth, 34u); 9027 CHECK_PARSE("---\n" 9028 "IndentWidth: 78\n" 9029 "---\n" 9030 "Language: JavaScript\n" 9031 "IndentWidth: 56\n" 9032 "...\n", 9033 IndentWidth, 78u); 9034 9035 Style.ColumnLimit = 123; 9036 Style.IndentWidth = 234; 9037 Style.BreakBeforeBraces = FormatStyle::BS_Linux; 9038 Style.TabWidth = 345; 9039 EXPECT_FALSE(parseConfiguration("---\n" 9040 "IndentWidth: 456\n" 9041 "BreakBeforeBraces: Allman\n" 9042 "---\n" 9043 "Language: JavaScript\n" 9044 "IndentWidth: 111\n" 9045 "TabWidth: 111\n" 9046 "---\n" 9047 "Language: Cpp\n" 9048 "BreakBeforeBraces: Stroustrup\n" 9049 "TabWidth: 789\n" 9050 "...\n", 9051 &Style)); 9052 EXPECT_EQ(123u, Style.ColumnLimit); 9053 EXPECT_EQ(456u, Style.IndentWidth); 9054 EXPECT_EQ(FormatStyle::BS_Stroustrup, Style.BreakBeforeBraces); 9055 EXPECT_EQ(789u, Style.TabWidth); 9056 9057 EXPECT_EQ(parseConfiguration("---\n" 9058 "Language: JavaScript\n" 9059 "IndentWidth: 56\n" 9060 "---\n" 9061 "IndentWidth: 78\n" 9062 "...\n", 9063 &Style), 9064 ParseError::Error); 9065 EXPECT_EQ(parseConfiguration("---\n" 9066 "Language: JavaScript\n" 9067 "IndentWidth: 56\n" 9068 "---\n" 9069 "Language: JavaScript\n" 9070 "IndentWidth: 78\n" 9071 "...\n", 9072 &Style), 9073 ParseError::Error); 9074 9075 EXPECT_EQ(FormatStyle::LK_Cpp, Style.Language); 9076 } 9077 9078 #undef CHECK_PARSE 9079 9080 TEST_F(FormatTest, UsesLanguageForBasedOnStyle) { 9081 FormatStyle Style = {}; 9082 Style.Language = FormatStyle::LK_JavaScript; 9083 Style.BreakBeforeTernaryOperators = true; 9084 EXPECT_EQ(0, parseConfiguration("BasedOnStyle: Google", &Style).value()); 9085 EXPECT_FALSE(Style.BreakBeforeTernaryOperators); 9086 9087 Style.BreakBeforeTernaryOperators = true; 9088 EXPECT_EQ(0, parseConfiguration("---\n" 9089 "BasedOnStyle: Google\n" 9090 "---\n" 9091 "Language: JavaScript\n" 9092 "IndentWidth: 76\n" 9093 "...\n", &Style).value()); 9094 EXPECT_FALSE(Style.BreakBeforeTernaryOperators); 9095 EXPECT_EQ(76u, Style.IndentWidth); 9096 EXPECT_EQ(FormatStyle::LK_JavaScript, Style.Language); 9097 } 9098 9099 TEST_F(FormatTest, ConfigurationRoundTripTest) { 9100 FormatStyle Style = getLLVMStyle(); 9101 std::string YAML = configurationAsText(Style); 9102 FormatStyle ParsedStyle = {}; 9103 ParsedStyle.Language = FormatStyle::LK_Cpp; 9104 EXPECT_EQ(0, parseConfiguration(YAML, &ParsedStyle).value()); 9105 EXPECT_EQ(Style, ParsedStyle); 9106 } 9107 9108 TEST_F(FormatTest, WorksFor8bitEncodings) { 9109 EXPECT_EQ("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 \"\n" 9110 "\"\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \"\n" 9111 "\"\xe7\xe8\xec\xed\xfe\xfe \"\n" 9112 "\"\xef\xee\xf0\xf3...\"", 9113 format("\"\xce\xe4\xed\xe0\xe6\xe4\xfb \xe2 " 9114 "\xf1\xf2\xf3\xe4\xb8\xed\xf3\xfe \xe7\xe8\xec\xed\xfe\xfe " 9115 "\xef\xee\xf0\xf3...\"", 9116 getLLVMStyleWithColumns(12))); 9117 } 9118 9119 TEST_F(FormatTest, HandlesUTF8BOM) { 9120 EXPECT_EQ("\xef\xbb\xbf", format("\xef\xbb\xbf")); 9121 EXPECT_EQ("\xef\xbb\xbf#include <iostream>", 9122 format("\xef\xbb\xbf#include <iostream>")); 9123 EXPECT_EQ("\xef\xbb\xbf\n#include <iostream>", 9124 format("\xef\xbb\xbf\n#include <iostream>")); 9125 } 9126 9127 // FIXME: Encode Cyrillic and CJK characters below to appease MS compilers. 9128 #if !defined(_MSC_VER) 9129 9130 TEST_F(FormatTest, CountsUTF8CharactersProperly) { 9131 verifyFormat("\"Однажды в студёную зимнюю пору...\"", 9132 getLLVMStyleWithColumns(35)); 9133 verifyFormat("\"一 二 三 四 五 六 七 八 九 十\"", 9134 getLLVMStyleWithColumns(31)); 9135 verifyFormat("// Однажды в студёную зимнюю пору...", 9136 getLLVMStyleWithColumns(36)); 9137 verifyFormat("// 一 二 三 四 五 六 七 八 九 十", 9138 getLLVMStyleWithColumns(32)); 9139 verifyFormat("/* Однажды в студёную зимнюю пору... */", 9140 getLLVMStyleWithColumns(39)); 9141 verifyFormat("/* 一 二 三 四 五 六 七 八 九 十 */", 9142 getLLVMStyleWithColumns(35)); 9143 } 9144 9145 TEST_F(FormatTest, SplitsUTF8Strings) { 9146 // Non-printable characters' width is currently considered to be the length in 9147 // bytes in UTF8. The characters can be displayed in very different manner 9148 // (zero-width, single width with a substitution glyph, expanded to their code 9149 // (e.g. "<8d>"), so there's no single correct way to handle them. 9150 EXPECT_EQ("\"aaaaÄ\"\n" 9151 "\"\xc2\x8d\";", 9152 format("\"aaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); 9153 EXPECT_EQ("\"aaaaaaaÄ\"\n" 9154 "\"\xc2\x8d\";", 9155 format("\"aaaaaaaÄ\xc2\x8d\";", getLLVMStyleWithColumns(10))); 9156 EXPECT_EQ( 9157 "\"Однажды, в \"\n" 9158 "\"студёную \"\n" 9159 "\"зимнюю \"\n" 9160 "\"пору,\"", 9161 format("\"Однажды, в студёную зимнюю пору,\"", 9162 getLLVMStyleWithColumns(13))); 9163 EXPECT_EQ("\"一 二 三 \"\n" 9164 "\"四 五六 \"\n" 9165 "\"七 八 九 \"\n" 9166 "\"十\"", 9167 format("\"一 二 三 四 五六 七 八 九 十\"", 9168 getLLVMStyleWithColumns(11))); 9169 EXPECT_EQ("\"一\t二 \"\n" 9170 "\"\t三 \"\n" 9171 "\"四 五\t六 \"\n" 9172 "\"\t七 \"\n" 9173 "\"八九十\tqq\"", 9174 format("\"一\t二 \t三 四 五\t六 \t七 八九十\tqq\"", 9175 getLLVMStyleWithColumns(11))); 9176 } 9177 9178 9179 TEST_F(FormatTest, HandlesDoubleWidthCharsInMultiLineStrings) { 9180 EXPECT_EQ("const char *sssss =\n" 9181 " \"一二三四五六七八\\\n" 9182 " 九 十\";", 9183 format("const char *sssss = \"一二三四五六七八\\\n" 9184 " 九 十\";", 9185 getLLVMStyleWithColumns(30))); 9186 } 9187 9188 TEST_F(FormatTest, SplitsUTF8LineComments) { 9189 EXPECT_EQ("// aaaaÄ\xc2\x8d", 9190 format("// aaaaÄ\xc2\x8d", getLLVMStyleWithColumns(10))); 9191 EXPECT_EQ("// Я из лесу\n" 9192 "// вышел; был\n" 9193 "// сильный\n" 9194 "// мороз.", 9195 format("// Я из лесу вышел; был сильный мороз.", 9196 getLLVMStyleWithColumns(13))); 9197 EXPECT_EQ("// 一二三\n" 9198 "// 四五六七\n" 9199 "// 八 九\n" 9200 "// 十", 9201 format("// 一二三 四五六七 八 九 十", getLLVMStyleWithColumns(9))); 9202 } 9203 9204 TEST_F(FormatTest, SplitsUTF8BlockComments) { 9205 EXPECT_EQ("/* Гляжу,\n" 9206 " * поднимается\n" 9207 " * медленно в\n" 9208 " * гору\n" 9209 " * Лошадка,\n" 9210 " * везущая\n" 9211 " * хворосту\n" 9212 " * воз. */", 9213 format("/* Гляжу, поднимается медленно в гору\n" 9214 " * Лошадка, везущая хворосту воз. */", 9215 getLLVMStyleWithColumns(13))); 9216 EXPECT_EQ( 9217 "/* 一二三\n" 9218 " * 四五六七\n" 9219 " * 八 九\n" 9220 " * 十 */", 9221 format("/* 一二三 四五六七 八 九 十 */", getLLVMStyleWithColumns(9))); 9222 EXPECT_EQ("/* �������� ��������\n" 9223 " * ��������\n" 9224 " * ������-�� */", 9225 format("/* �������� �������� �������� ������-�� */", getLLVMStyleWithColumns(12))); 9226 } 9227 9228 #endif // _MSC_VER 9229 9230 TEST_F(FormatTest, ConstructorInitializerIndentWidth) { 9231 FormatStyle Style = getLLVMStyle(); 9232 9233 Style.ConstructorInitializerIndentWidth = 4; 9234 verifyFormat( 9235 "SomeClass::Constructor()\n" 9236 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 9237 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 9238 Style); 9239 9240 Style.ConstructorInitializerIndentWidth = 2; 9241 verifyFormat( 9242 "SomeClass::Constructor()\n" 9243 " : aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 9244 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 9245 Style); 9246 9247 Style.ConstructorInitializerIndentWidth = 0; 9248 verifyFormat( 9249 "SomeClass::Constructor()\n" 9250 ": aaaaaaaaaaaaa(aaaaaaaaaaaaaa), aaaaaaaaaaaaa(aaaaaaaaaaaaaa),\n" 9251 " aaaaaaaaaaaaa(aaaaaaaaaaaaaa) {}", 9252 Style); 9253 } 9254 9255 TEST_F(FormatTest, BreakConstructorInitializersBeforeComma) { 9256 FormatStyle Style = getLLVMStyle(); 9257 Style.BreakConstructorInitializersBeforeComma = true; 9258 Style.ConstructorInitializerIndentWidth = 4; 9259 verifyFormat("SomeClass::Constructor()\n" 9260 " : a(a)\n" 9261 " , b(b)\n" 9262 " , c(c) {}", 9263 Style); 9264 verifyFormat("SomeClass::Constructor()\n" 9265 " : a(a) {}", 9266 Style); 9267 9268 Style.ColumnLimit = 0; 9269 verifyFormat("SomeClass::Constructor()\n" 9270 " : a(a) {}", 9271 Style); 9272 verifyFormat("SomeClass::Constructor()\n" 9273 " : a(a)\n" 9274 " , b(b)\n" 9275 " , c(c) {}", 9276 Style); 9277 verifyFormat("SomeClass::Constructor()\n" 9278 " : a(a) {\n" 9279 " foo();\n" 9280 " bar();\n" 9281 "}", 9282 Style); 9283 9284 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; 9285 verifyFormat("SomeClass::Constructor()\n" 9286 " : a(a)\n" 9287 " , b(b)\n" 9288 " , c(c) {\n}", 9289 Style); 9290 verifyFormat("SomeClass::Constructor()\n" 9291 " : a(a) {\n}", 9292 Style); 9293 9294 Style.ColumnLimit = 80; 9295 Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_All; 9296 Style.ConstructorInitializerIndentWidth = 2; 9297 verifyFormat("SomeClass::Constructor()\n" 9298 " : a(a)\n" 9299 " , b(b)\n" 9300 " , c(c) {}", 9301 Style); 9302 9303 Style.ConstructorInitializerIndentWidth = 0; 9304 verifyFormat("SomeClass::Constructor()\n" 9305 ": a(a)\n" 9306 ", b(b)\n" 9307 ", c(c) {}", 9308 Style); 9309 9310 Style.ConstructorInitializerAllOnOneLineOrOnePerLine = true; 9311 Style.ConstructorInitializerIndentWidth = 4; 9312 verifyFormat("SomeClass::Constructor() : aaaaaaaa(aaaaaaaa) {}", Style); 9313 verifyFormat( 9314 "SomeClass::Constructor() : aaaaa(aaaaa), aaaaa(aaaaa), aaaaa(aaaaa)\n", 9315 Style); 9316 verifyFormat( 9317 "SomeClass::Constructor()\n" 9318 " : aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa), aaaaaaaa(aaaaaaaa) {}", 9319 Style); 9320 Style.ConstructorInitializerIndentWidth = 4; 9321 Style.ColumnLimit = 60; 9322 verifyFormat("SomeClass::Constructor()\n" 9323 " : aaaaaaaa(aaaaaaaa)\n" 9324 " , aaaaaaaa(aaaaaaaa)\n" 9325 " , aaaaaaaa(aaaaaaaa) {}", 9326 Style); 9327 } 9328 9329 TEST_F(FormatTest, Destructors) { 9330 verifyFormat("void F(int &i) { i.~int(); }"); 9331 verifyFormat("void F(int &i) { i->~int(); }"); 9332 } 9333 9334 TEST_F(FormatTest, FormatsWithWebKitStyle) { 9335 FormatStyle Style = getWebKitStyle(); 9336 9337 // Don't indent in outer namespaces. 9338 verifyFormat("namespace outer {\n" 9339 "int i;\n" 9340 "namespace inner {\n" 9341 " int i;\n" 9342 "} // namespace inner\n" 9343 "} // namespace outer\n" 9344 "namespace other_outer {\n" 9345 "int i;\n" 9346 "}", 9347 Style); 9348 9349 // Don't indent case labels. 9350 verifyFormat("switch (variable) {\n" 9351 "case 1:\n" 9352 "case 2:\n" 9353 " doSomething();\n" 9354 " break;\n" 9355 "default:\n" 9356 " ++variable;\n" 9357 "}", 9358 Style); 9359 9360 // Wrap before binary operators. 9361 EXPECT_EQ( 9362 "void f()\n" 9363 "{\n" 9364 " if (aaaaaaaaaaaaaaaa\n" 9365 " && bbbbbbbbbbbbbbbbbbbbbbbb\n" 9366 " && (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 9367 " return;\n" 9368 "}", 9369 format( 9370 "void f() {\n" 9371 "if (aaaaaaaaaaaaaaaa\n" 9372 "&& bbbbbbbbbbbbbbbbbbbbbbbb\n" 9373 "&& (cccccccccccccccccccccccccc || dddddddddddddddddddd))\n" 9374 "return;\n" 9375 "}", 9376 Style)); 9377 9378 // Allow functions on a single line. 9379 verifyFormat("void f() { return; }", Style); 9380 9381 // Constructor initializers are formatted one per line with the "," on the 9382 // new line. 9383 verifyFormat("Constructor()\n" 9384 " : aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaaaaaaaaaaaaaaa)\n" 9385 " , aaaaaaaaaaaaaaaaaaaaaaaa(aaaaaaaaaaaaaa, // break\n" 9386 " aaaaaaaaaaaaaa)\n" 9387 " , aaaaaaaaaaaaaaaaaaaaaaa()\n" 9388 "{\n" 9389 "}", 9390 Style); 9391 verifyFormat("SomeClass::Constructor()\n" 9392 " : a(a)\n" 9393 "{\n" 9394 "}", 9395 Style); 9396 EXPECT_EQ("SomeClass::Constructor()\n" 9397 " : a(a)\n" 9398 "{\n" 9399 "}", 9400 format("SomeClass::Constructor():a(a){}", Style)); 9401 verifyFormat("SomeClass::Constructor()\n" 9402 " : a(a)\n" 9403 " , b(b)\n" 9404 " , c(c)\n" 9405 "{\n" 9406 "}", Style); 9407 verifyFormat("SomeClass::Constructor()\n" 9408 " : a(a)\n" 9409 "{\n" 9410 " foo();\n" 9411 " bar();\n" 9412 "}", 9413 Style); 9414 9415 // Access specifiers should be aligned left. 9416 verifyFormat("class C {\n" 9417 "public:\n" 9418 " int i;\n" 9419 "};", 9420 Style); 9421 9422 // Do not align comments. 9423 verifyFormat("int a; // Do not\n" 9424 "double b; // align comments.", 9425 Style); 9426 9427 // Do not align operands. 9428 EXPECT_EQ("ASSERT(aaaa\n" 9429 " || bbbb);", 9430 format("ASSERT ( aaaa\n||bbbb);", Style)); 9431 9432 // Accept input's line breaks. 9433 EXPECT_EQ("if (aaaaaaaaaaaaaaa\n" 9434 " || bbbbbbbbbbbbbbb) {\n" 9435 " i++;\n" 9436 "}", 9437 format("if (aaaaaaaaaaaaaaa\n" 9438 "|| bbbbbbbbbbbbbbb) { i++; }", 9439 Style)); 9440 EXPECT_EQ("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) {\n" 9441 " i++;\n" 9442 "}", 9443 format("if (aaaaaaaaaaaaaaa || bbbbbbbbbbbbbbb) { i++; }", Style)); 9444 9445 // Don't automatically break all macro definitions (llvm.org/PR17842). 9446 verifyFormat("#define aNumber 10", Style); 9447 // However, generally keep the line breaks that the user authored. 9448 EXPECT_EQ("#define aNumber \\\n" 9449 " 10", 9450 format("#define aNumber \\\n" 9451 " 10", 9452 Style)); 9453 9454 // Keep empty and one-element array literals on a single line. 9455 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[]\n" 9456 " copyItems:YES];", 9457 format("NSArray*a=[[NSArray alloc] initWithArray:@[]\n" 9458 "copyItems:YES];", 9459 Style)); 9460 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\" ]\n" 9461 " copyItems:YES];", 9462 format("NSArray*a=[[NSArray alloc]initWithArray:@[ @\"a\" ]\n" 9463 " copyItems:YES];", 9464 Style)); 9465 // FIXME: This does not seem right, there should be more indentation before 9466 // the array literal's entries. Nested blocks have the same problem. 9467 EXPECT_EQ("NSArray* a = [[NSArray alloc] initWithArray:@[\n" 9468 " @\"a\",\n" 9469 " @\"a\"\n" 9470 "]\n" 9471 " copyItems:YES];", 9472 format("NSArray* a = [[NSArray alloc] initWithArray:@[\n" 9473 " @\"a\",\n" 9474 " @\"a\"\n" 9475 " ]\n" 9476 " copyItems:YES];", 9477 Style)); 9478 EXPECT_EQ( 9479 "NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" 9480 " copyItems:YES];", 9481 format("NSArray* a = [[NSArray alloc] initWithArray:@[ @\"a\", @\"a\" ]\n" 9482 " copyItems:YES];", 9483 Style)); 9484 9485 verifyFormat("[self.a b:c c:d];", Style); 9486 EXPECT_EQ("[self.a b:c\n" 9487 " c:d];", 9488 format("[self.a b:c\n" 9489 "c:d];", 9490 Style)); 9491 } 9492 9493 TEST_F(FormatTest, FormatsLambdas) { 9494 verifyFormat("int c = [b]() mutable { return [&b] { return b++; }(); }();\n"); 9495 verifyFormat("int c = [&] { [=] { return b++; }(); }();\n"); 9496 verifyFormat("int c = [&, &a, a] { [=, c, &d] { return b++; }(); }();\n"); 9497 verifyFormat("int c = [&a, &a, a] { [=, a, b, &c] { return b++; }(); }();\n"); 9498 verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] { return b++; }(); }}\n"); 9499 verifyFormat("auto c = {[&a, &a, a] { [=, a, b, &c] {}(); }}\n"); 9500 verifyFormat("void f() {\n" 9501 " other(x.begin(), x.end(), [&](int, int) { return 1; });\n" 9502 "}\n"); 9503 verifyFormat("void f() {\n" 9504 " other(x.begin(), //\n" 9505 " x.end(), //\n" 9506 " [&](int, int) { return 1; });\n" 9507 "}\n"); 9508 verifyFormat("SomeFunction([]() { // A cool function...\n" 9509 " return 43;\n" 9510 "});"); 9511 EXPECT_EQ("SomeFunction([]() {\n" 9512 "#define A a\n" 9513 " return 43;\n" 9514 "});", 9515 format("SomeFunction([](){\n" 9516 "#define A a\n" 9517 "return 43;\n" 9518 "});")); 9519 verifyFormat("void f() {\n" 9520 " SomeFunction([](decltype(x), A *a) {});\n" 9521 "}"); 9522 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa(\n" 9523 " [](const aaaaaaaaaa &a) { return a; });"); 9524 verifyFormat("string abc = SomeFunction(aaaaaaaaaaaaa, aaaaa, []() {\n" 9525 " SomeOtherFunctioooooooooooooooooooooooooon();\n" 9526 "});"); 9527 verifyFormat("Constructor()\n" 9528 " : Field([] { // comment\n" 9529 " int i;\n" 9530 " }) {}"); 9531 9532 // Lambdas with return types. 9533 verifyFormat("int c = []() -> int { return 2; }();\n"); 9534 verifyFormat("int c = []() -> vector<int> { return {2}; }();\n"); 9535 verifyFormat("Foo([]() -> std::vector<int> { return {2}; }());"); 9536 verifyGoogleFormat("auto a = [&b, c](D* d) -> D* {};"); 9537 verifyGoogleFormat("auto a = [&b, c](D* d) -> pair<D*, D*> {};"); 9538 verifyGoogleFormat("auto a = [&b, c](D* d) -> D& {};"); 9539 verifyGoogleFormat("auto a = [&b, c](D* d) -> const D* {};"); 9540 verifyFormat("auto aaaaaaaa = [](int i, // break for some reason\n" 9541 " int j) -> int {\n" 9542 " return ffffffffffffffffffffffffffffffffffffffffffff(i * j);\n" 9543 "};"); 9544 verifyFormat( 9545 "aaaaaaaaaaaaaaaaaaaaaa(\n" 9546 " [](aaaaaaaaaaaaaaaaaaaaaaaaaaa &aaa) -> aaaaaaaaaaaaaaaa {\n" 9547 " return aaaaaaaaaaaaaaaaa;\n" 9548 " });", 9549 getLLVMStyleWithColumns(70)); 9550 9551 // Multiple lambdas in the same parentheses change indentation rules. 9552 verifyFormat("SomeFunction(\n" 9553 " []() {\n" 9554 " int i = 42;\n" 9555 " return i;\n" 9556 " },\n" 9557 " []() {\n" 9558 " int j = 43;\n" 9559 " return j;\n" 9560 " });"); 9561 9562 // More complex introducers. 9563 verifyFormat("return [i, args...] {};"); 9564 9565 // Not lambdas. 9566 verifyFormat("constexpr char hello[]{\"hello\"};"); 9567 verifyFormat("double &operator[](int i) { return 0; }\n" 9568 "int i;"); 9569 verifyFormat("std::unique_ptr<int[]> foo() {}"); 9570 verifyFormat("int i = a[a][a]->f();"); 9571 verifyFormat("int i = (*b)[a]->f();"); 9572 9573 // Other corner cases. 9574 verifyFormat("void f() {\n" 9575 " bar([]() {} // Did not respect SpacesBeforeTrailingComments\n" 9576 " );\n" 9577 "}"); 9578 9579 // Lambdas created through weird macros. 9580 verifyFormat("void f() {\n" 9581 " MACRO((const AA &a) { return 1; });\n" 9582 "}"); 9583 9584 verifyFormat("if (blah_blah(whatever, whatever, [] {\n" 9585 " doo_dah();\n" 9586 " doo_dah();\n" 9587 " })) {\n" 9588 "}"); 9589 verifyFormat("auto lambda = []() {\n" 9590 " int a = 2\n" 9591 "#if A\n" 9592 " + 2\n" 9593 "#endif\n" 9594 " ;\n" 9595 "};"); 9596 } 9597 9598 TEST_F(FormatTest, FormatsBlocks) { 9599 FormatStyle ShortBlocks = getLLVMStyle(); 9600 ShortBlocks.AllowShortBlocksOnASingleLine = true; 9601 verifyFormat("int (^Block)(int, int);", ShortBlocks); 9602 verifyFormat("int (^Block1)(int, int) = ^(int i, int j)", ShortBlocks); 9603 verifyFormat("void (^block)(int) = ^(id test) { int i; };", ShortBlocks); 9604 verifyFormat("void (^block)(int) = ^(int test) { int i; };", ShortBlocks); 9605 verifyFormat("void (^block)(int) = ^id(int test) { int i; };", ShortBlocks); 9606 verifyFormat("void (^block)(int) = ^int(int test) { int i; };", ShortBlocks); 9607 9608 verifyFormat("foo(^{ bar(); });", ShortBlocks); 9609 verifyFormat("foo(a, ^{ bar(); });", ShortBlocks); 9610 verifyFormat("{ void (^block)(Object *x); }", ShortBlocks); 9611 9612 verifyFormat("[operation setCompletionBlock:^{\n" 9613 " [self onOperationDone];\n" 9614 "}];"); 9615 verifyFormat("int i = {[operation setCompletionBlock:^{\n" 9616 " [self onOperationDone];\n" 9617 "}]};"); 9618 verifyFormat("[operation setCompletionBlock:^(int *i) {\n" 9619 " f();\n" 9620 "}];"); 9621 verifyFormat("int a = [operation block:^int(int *i) {\n" 9622 " return 1;\n" 9623 "}];"); 9624 verifyFormat("[myObject doSomethingWith:arg1\n" 9625 " aaa:^int(int *a) {\n" 9626 " return 1;\n" 9627 " }\n" 9628 " bbb:f(a * bbbbbbbb)];"); 9629 9630 verifyFormat("[operation setCompletionBlock:^{\n" 9631 " [self.delegate newDataAvailable];\n" 9632 "}];", 9633 getLLVMStyleWithColumns(60)); 9634 verifyFormat("dispatch_async(_fileIOQueue, ^{\n" 9635 " NSString *path = [self sessionFilePath];\n" 9636 " if (path) {\n" 9637 " // ...\n" 9638 " }\n" 9639 "});"); 9640 verifyFormat("[[SessionService sharedService]\n" 9641 " loadWindowWithCompletionBlock:^(SessionWindow *window) {\n" 9642 " if (window) {\n" 9643 " [self windowDidLoad:window];\n" 9644 " } else {\n" 9645 " [self errorLoadingWindow];\n" 9646 " }\n" 9647 " }];"); 9648 verifyFormat("void (^largeBlock)(void) = ^{\n" 9649 " // ...\n" 9650 "};\n", 9651 getLLVMStyleWithColumns(40)); 9652 verifyFormat("[[SessionService sharedService]\n" 9653 " loadWindowWithCompletionBlock: //\n" 9654 " ^(SessionWindow *window) {\n" 9655 " if (window) {\n" 9656 " [self windowDidLoad:window];\n" 9657 " } else {\n" 9658 " [self errorLoadingWindow];\n" 9659 " }\n" 9660 " }];", 9661 getLLVMStyleWithColumns(60)); 9662 verifyFormat("[myObject doSomethingWith:arg1\n" 9663 " firstBlock:^(Foo *a) {\n" 9664 " // ...\n" 9665 " int i;\n" 9666 " }\n" 9667 " secondBlock:^(Bar *b) {\n" 9668 " // ...\n" 9669 " int i;\n" 9670 " }\n" 9671 " thirdBlock:^Foo(Bar *b) {\n" 9672 " // ...\n" 9673 " int i;\n" 9674 " }];"); 9675 verifyFormat("[myObject doSomethingWith:arg1\n" 9676 " firstBlock:-1\n" 9677 " secondBlock:^(Bar *b) {\n" 9678 " // ...\n" 9679 " int i;\n" 9680 " }];"); 9681 9682 verifyFormat("f(^{\n" 9683 " @autoreleasepool {\n" 9684 " if (a) {\n" 9685 " g();\n" 9686 " }\n" 9687 " }\n" 9688 "});"); 9689 verifyFormat("Block b = ^int *(A *a, B *b) {}"); 9690 9691 FormatStyle FourIndent = getLLVMStyle(); 9692 FourIndent.ObjCBlockIndentWidth = 4; 9693 verifyFormat("[operation setCompletionBlock:^{\n" 9694 " [self onOperationDone];\n" 9695 "}];", 9696 FourIndent); 9697 } 9698 9699 TEST_F(FormatTest, SupportsCRLF) { 9700 EXPECT_EQ("int a;\r\n" 9701 "int b;\r\n" 9702 "int c;\r\n", 9703 format("int a;\r\n" 9704 " int b;\r\n" 9705 " int c;\r\n", 9706 getLLVMStyle())); 9707 EXPECT_EQ("int a;\r\n" 9708 "int b;\r\n" 9709 "int c;\r\n", 9710 format("int a;\r\n" 9711 " int b;\n" 9712 " int c;\r\n", 9713 getLLVMStyle())); 9714 EXPECT_EQ("int a;\n" 9715 "int b;\n" 9716 "int c;\n", 9717 format("int a;\r\n" 9718 " int b;\n" 9719 " int c;\n", 9720 getLLVMStyle())); 9721 EXPECT_EQ("\"aaaaaaa \"\r\n" 9722 "\"bbbbbbb\";\r\n", 9723 format("\"aaaaaaa bbbbbbb\";\r\n", getLLVMStyleWithColumns(10))); 9724 EXPECT_EQ("#define A \\\r\n" 9725 " b; \\\r\n" 9726 " c; \\\r\n" 9727 " d;\r\n", 9728 format("#define A \\\r\n" 9729 " b; \\\r\n" 9730 " c; d; \r\n", 9731 getGoogleStyle())); 9732 9733 EXPECT_EQ("/*\r\n" 9734 "multi line block comments\r\n" 9735 "should not introduce\r\n" 9736 "an extra carriage return\r\n" 9737 "*/\r\n", 9738 format("/*\r\n" 9739 "multi line block comments\r\n" 9740 "should not introduce\r\n" 9741 "an extra carriage return\r\n" 9742 "*/\r\n")); 9743 } 9744 9745 TEST_F(FormatTest, MunchSemicolonAfterBlocks) { 9746 verifyFormat("MY_CLASS(C) {\n" 9747 " int i;\n" 9748 " int j;\n" 9749 "};"); 9750 } 9751 9752 TEST_F(FormatTest, ConfigurableContinuationIndentWidth) { 9753 FormatStyle TwoIndent = getLLVMStyleWithColumns(15); 9754 TwoIndent.ContinuationIndentWidth = 2; 9755 9756 EXPECT_EQ("int i =\n" 9757 " longFunction(\n" 9758 " arg);", 9759 format("int i = longFunction(arg);", TwoIndent)); 9760 9761 FormatStyle SixIndent = getLLVMStyleWithColumns(20); 9762 SixIndent.ContinuationIndentWidth = 6; 9763 9764 EXPECT_EQ("int i =\n" 9765 " longFunction(\n" 9766 " arg);", 9767 format("int i = longFunction(arg);", SixIndent)); 9768 } 9769 9770 TEST_F(FormatTest, SpacesInAngles) { 9771 FormatStyle Spaces = getLLVMStyle(); 9772 Spaces.SpacesInAngles = true; 9773 9774 verifyFormat("static_cast< int >(arg);", Spaces); 9775 verifyFormat("template < typename T0, typename T1 > void f() {}", Spaces); 9776 verifyFormat("f< int, float >();", Spaces); 9777 verifyFormat("template <> g() {}", Spaces); 9778 verifyFormat("template < std::vector< int > > f() {}", Spaces); 9779 9780 Spaces.Standard = FormatStyle::LS_Cpp03; 9781 Spaces.SpacesInAngles = true; 9782 verifyFormat("A< A< int > >();", Spaces); 9783 9784 Spaces.SpacesInAngles = false; 9785 verifyFormat("A<A<int> >();", Spaces); 9786 9787 Spaces.Standard = FormatStyle::LS_Cpp11; 9788 Spaces.SpacesInAngles = true; 9789 verifyFormat("A< A< int > >();", Spaces); 9790 9791 Spaces.SpacesInAngles = false; 9792 verifyFormat("A<A<int>>();", Spaces); 9793 } 9794 9795 TEST_F(FormatTest, TripleAngleBrackets) { 9796 verifyFormat("f<<<1, 1>>>();"); 9797 verifyFormat("f<<<1, 1, 1, s>>>();"); 9798 verifyFormat("f<<<a, b, c, d>>>();"); 9799 EXPECT_EQ("f<<<1, 1>>>();", 9800 format("f <<< 1, 1 >>> ();")); 9801 verifyFormat("f<param><<<1, 1>>>();"); 9802 verifyFormat("f<1><<<1, 1>>>();"); 9803 EXPECT_EQ("f<param><<<1, 1>>>();", 9804 format("f< param > <<< 1, 1 >>> ();")); 9805 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 9806 "aaaaaaaaaaa<<<\n 1, 1>>>();"); 9807 } 9808 9809 TEST_F(FormatTest, MergeLessLessAtEnd) { 9810 verifyFormat("<<"); 9811 EXPECT_EQ("< < <", format("\\\n<<<")); 9812 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 9813 "aaallvm::outs() <<"); 9814 verifyFormat("aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" 9815 "aaaallvm::outs()\n <<"); 9816 } 9817 9818 TEST_F(FormatTest, HandleUnbalancedImplicitBracesAcrossPPBranches) { 9819 std::string code = "#if A\n" 9820 "#if B\n" 9821 "a.\n" 9822 "#endif\n" 9823 " a = 1;\n" 9824 "#else\n" 9825 "#endif\n" 9826 "#if C\n" 9827 "#else\n" 9828 "#endif\n"; 9829 EXPECT_EQ(code, format(code)); 9830 } 9831 9832 TEST_F(FormatTest, HandleConflictMarkers) { 9833 // Git/SVN conflict markers. 9834 EXPECT_EQ("int a;\n" 9835 "void f() {\n" 9836 " callme(some(parameter1,\n" 9837 "<<<<<<< text by the vcs\n" 9838 " parameter2),\n" 9839 "||||||| text by the vcs\n" 9840 " parameter2),\n" 9841 " parameter3,\n" 9842 "======= text by the vcs\n" 9843 " parameter2, parameter3),\n" 9844 ">>>>>>> text by the vcs\n" 9845 " otherparameter);\n", 9846 format("int a;\n" 9847 "void f() {\n" 9848 " callme(some(parameter1,\n" 9849 "<<<<<<< text by the vcs\n" 9850 " parameter2),\n" 9851 "||||||| text by the vcs\n" 9852 " parameter2),\n" 9853 " parameter3,\n" 9854 "======= text by the vcs\n" 9855 " parameter2,\n" 9856 " parameter3),\n" 9857 ">>>>>>> text by the vcs\n" 9858 " otherparameter);\n")); 9859 9860 // Perforce markers. 9861 EXPECT_EQ("void f() {\n" 9862 " function(\n" 9863 ">>>> text by the vcs\n" 9864 " parameter,\n" 9865 "==== text by the vcs\n" 9866 " parameter,\n" 9867 "==== text by the vcs\n" 9868 " parameter,\n" 9869 "<<<< text by the vcs\n" 9870 " parameter);\n", 9871 format("void f() {\n" 9872 " function(\n" 9873 ">>>> text by the vcs\n" 9874 " parameter,\n" 9875 "==== text by the vcs\n" 9876 " parameter,\n" 9877 "==== text by the vcs\n" 9878 " parameter,\n" 9879 "<<<< text by the vcs\n" 9880 " parameter);\n")); 9881 9882 EXPECT_EQ("<<<<<<<\n" 9883 "|||||||\n" 9884 "=======\n" 9885 ">>>>>>>", 9886 format("<<<<<<<\n" 9887 "|||||||\n" 9888 "=======\n" 9889 ">>>>>>>")); 9890 9891 EXPECT_EQ("<<<<<<<\n" 9892 "|||||||\n" 9893 "int i;\n" 9894 "=======\n" 9895 ">>>>>>>", 9896 format("<<<<<<<\n" 9897 "|||||||\n" 9898 "int i;\n" 9899 "=======\n" 9900 ">>>>>>>")); 9901 9902 // FIXME: Handle parsing of macros around conflict markers correctly: 9903 EXPECT_EQ("#define Macro \\\n" 9904 "<<<<<<<\n" 9905 "Something \\\n" 9906 "|||||||\n" 9907 "Else \\\n" 9908 "=======\n" 9909 "Other \\\n" 9910 ">>>>>>>\n" 9911 " End int i;\n", 9912 format("#define Macro \\\n" 9913 "<<<<<<<\n" 9914 " Something \\\n" 9915 "|||||||\n" 9916 " Else \\\n" 9917 "=======\n" 9918 " Other \\\n" 9919 ">>>>>>>\n" 9920 " End\n" 9921 "int i;\n")); 9922 } 9923 9924 TEST_F(FormatTest, DisableRegions) { 9925 EXPECT_EQ("int i;\n" 9926 "// clang-format off\n" 9927 " int j;\n" 9928 "// clang-format on\n" 9929 "int k;", 9930 format(" int i;\n" 9931 " // clang-format off\n" 9932 " int j;\n" 9933 " // clang-format on\n" 9934 " int k;")); 9935 EXPECT_EQ("int i;\n" 9936 "/* clang-format off */\n" 9937 " int j;\n" 9938 "/* clang-format on */\n" 9939 "int k;", 9940 format(" int i;\n" 9941 " /* clang-format off */\n" 9942 " int j;\n" 9943 " /* clang-format on */\n" 9944 " int k;")); 9945 } 9946 9947 TEST_F(FormatTest, DoNotCrashOnInvalidInput) { 9948 format("? ) ="); 9949 } 9950 9951 } // end namespace tooling 9952 } // end namespace clang 9953