1 //== RangeConstraintManager.cpp - Manage range constraints.------*- C++ -*--==// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 // 9 // This file defines RangeConstraintManager, a class that tracks simple 10 // equality and inequality constraints on symbolic values of ProgramState. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "clang/Basic/JsonSupport.h" 15 #include "clang/StaticAnalyzer/Core/PathSensitive/APSIntType.h" 16 #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h" 17 #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramStateTrait.h" 18 #include "clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h" 19 #include "clang/StaticAnalyzer/Core/PathSensitive/SValVisitor.h" 20 #include "llvm/ADT/FoldingSet.h" 21 #include "llvm/ADT/ImmutableSet.h" 22 #include "llvm/ADT/STLExtras.h" 23 #include "llvm/ADT/StringExtras.h" 24 #include "llvm/ADT/SmallSet.h" 25 #include "llvm/Support/Compiler.h" 26 #include "llvm/Support/raw_ostream.h" 27 #include <algorithm> 28 #include <iterator> 29 30 using namespace clang; 31 using namespace ento; 32 33 // This class can be extended with other tables which will help to reason 34 // about ranges more precisely. 35 class OperatorRelationsTable { 36 static_assert(BO_LT < BO_GT && BO_GT < BO_LE && BO_LE < BO_GE && 37 BO_GE < BO_EQ && BO_EQ < BO_NE, 38 "This class relies on operators order. Rework it otherwise."); 39 40 public: 41 enum TriStateKind { 42 False = 0, 43 True, 44 Unknown, 45 }; 46 47 private: 48 // CmpOpTable holds states which represent the corresponding range for 49 // branching an exploded graph. We can reason about the branch if there is 50 // a previously known fact of the existence of a comparison expression with 51 // operands used in the current expression. 52 // E.g. assuming (x < y) is true that means (x != y) is surely true. 53 // if (x previous_operation y) // < | != | > 54 // if (x operation y) // != | > | < 55 // tristate // True | Unknown | False 56 // 57 // CmpOpTable represents next: 58 // __|< |> |<=|>=|==|!=|UnknownX2| 59 // < |1 |0 |* |0 |0 |* |1 | 60 // > |0 |1 |0 |* |0 |* |1 | 61 // <=|1 |0 |1 |* |1 |* |0 | 62 // >=|0 |1 |* |1 |1 |* |0 | 63 // ==|0 |0 |* |* |1 |0 |1 | 64 // !=|1 |1 |* |* |0 |1 |0 | 65 // 66 // Columns stands for a previous operator. 67 // Rows stands for a current operator. 68 // Each row has exactly two `Unknown` cases. 69 // UnknownX2 means that both `Unknown` previous operators are met in code, 70 // and there is a special column for that, for example: 71 // if (x >= y) 72 // if (x != y) 73 // if (x <= y) 74 // False only 75 static constexpr size_t CmpOpCount = BO_NE - BO_LT + 1; 76 const TriStateKind CmpOpTable[CmpOpCount][CmpOpCount + 1] = { 77 // < > <= >= == != UnknownX2 78 {True, False, Unknown, False, False, Unknown, True}, // < 79 {False, True, False, Unknown, False, Unknown, True}, // > 80 {True, False, True, Unknown, True, Unknown, False}, // <= 81 {False, True, Unknown, True, True, Unknown, False}, // >= 82 {False, False, Unknown, Unknown, True, False, True}, // == 83 {True, True, Unknown, Unknown, False, True, False}, // != 84 }; 85 86 static size_t getIndexFromOp(BinaryOperatorKind OP) { 87 return static_cast<size_t>(OP - BO_LT); 88 } 89 90 public: 91 constexpr size_t getCmpOpCount() const { return CmpOpCount; } 92 93 static BinaryOperatorKind getOpFromIndex(size_t Index) { 94 return static_cast<BinaryOperatorKind>(Index + BO_LT); 95 } 96 97 TriStateKind getCmpOpState(BinaryOperatorKind CurrentOP, 98 BinaryOperatorKind QueriedOP) const { 99 return CmpOpTable[getIndexFromOp(CurrentOP)][getIndexFromOp(QueriedOP)]; 100 } 101 102 TriStateKind getCmpOpStateForUnknownX2(BinaryOperatorKind CurrentOP) const { 103 return CmpOpTable[getIndexFromOp(CurrentOP)][CmpOpCount]; 104 } 105 }; 106 107 //===----------------------------------------------------------------------===// 108 // RangeSet implementation 109 //===----------------------------------------------------------------------===// 110 111 RangeSet::ContainerType RangeSet::Factory::EmptySet{}; 112 113 RangeSet RangeSet::Factory::add(RangeSet Original, Range Element) { 114 ContainerType Result; 115 Result.reserve(Original.size() + 1); 116 117 const_iterator Lower = llvm::lower_bound(Original, Element); 118 Result.insert(Result.end(), Original.begin(), Lower); 119 Result.push_back(Element); 120 Result.insert(Result.end(), Lower, Original.end()); 121 122 return makePersistent(std::move(Result)); 123 } 124 125 RangeSet RangeSet::Factory::add(RangeSet Original, const llvm::APSInt &Point) { 126 return add(Original, Range(Point)); 127 } 128 129 RangeSet RangeSet::Factory::getRangeSet(Range From) { 130 ContainerType Result; 131 Result.push_back(From); 132 return makePersistent(std::move(Result)); 133 } 134 135 RangeSet RangeSet::Factory::makePersistent(ContainerType &&From) { 136 llvm::FoldingSetNodeID ID; 137 void *InsertPos; 138 139 From.Profile(ID); 140 ContainerType *Result = Cache.FindNodeOrInsertPos(ID, InsertPos); 141 142 if (!Result) { 143 // It is cheaper to fully construct the resulting range on stack 144 // and move it to the freshly allocated buffer if we don't have 145 // a set like this already. 146 Result = construct(std::move(From)); 147 Cache.InsertNode(Result, InsertPos); 148 } 149 150 return Result; 151 } 152 153 RangeSet::ContainerType *RangeSet::Factory::construct(ContainerType &&From) { 154 void *Buffer = Arena.Allocate(); 155 return new (Buffer) ContainerType(std::move(From)); 156 } 157 158 RangeSet RangeSet::Factory::add(RangeSet LHS, RangeSet RHS) { 159 ContainerType Result; 160 std::merge(LHS.begin(), LHS.end(), RHS.begin(), RHS.end(), 161 std::back_inserter(Result)); 162 return makePersistent(std::move(Result)); 163 } 164 165 const llvm::APSInt &RangeSet::getMinValue() const { 166 assert(!isEmpty()); 167 return begin()->From(); 168 } 169 170 const llvm::APSInt &RangeSet::getMaxValue() const { 171 assert(!isEmpty()); 172 return std::prev(end())->To(); 173 } 174 175 bool RangeSet::containsImpl(llvm::APSInt &Point) const { 176 if (isEmpty() || !pin(Point)) 177 return false; 178 179 Range Dummy(Point); 180 const_iterator It = llvm::upper_bound(*this, Dummy); 181 if (It == begin()) 182 return false; 183 184 return std::prev(It)->Includes(Point); 185 } 186 187 bool RangeSet::pin(llvm::APSInt &Point) const { 188 APSIntType Type(getMinValue()); 189 if (Type.testInRange(Point, true) != APSIntType::RTR_Within) 190 return false; 191 192 Type.apply(Point); 193 return true; 194 } 195 196 bool RangeSet::pin(llvm::APSInt &Lower, llvm::APSInt &Upper) const { 197 // This function has nine cases, the cartesian product of range-testing 198 // both the upper and lower bounds against the symbol's type. 199 // Each case requires a different pinning operation. 200 // The function returns false if the described range is entirely outside 201 // the range of values for the associated symbol. 202 APSIntType Type(getMinValue()); 203 APSIntType::RangeTestResultKind LowerTest = Type.testInRange(Lower, true); 204 APSIntType::RangeTestResultKind UpperTest = Type.testInRange(Upper, true); 205 206 switch (LowerTest) { 207 case APSIntType::RTR_Below: 208 switch (UpperTest) { 209 case APSIntType::RTR_Below: 210 // The entire range is outside the symbol's set of possible values. 211 // If this is a conventionally-ordered range, the state is infeasible. 212 if (Lower <= Upper) 213 return false; 214 215 // However, if the range wraps around, it spans all possible values. 216 Lower = Type.getMinValue(); 217 Upper = Type.getMaxValue(); 218 break; 219 case APSIntType::RTR_Within: 220 // The range starts below what's possible but ends within it. Pin. 221 Lower = Type.getMinValue(); 222 Type.apply(Upper); 223 break; 224 case APSIntType::RTR_Above: 225 // The range spans all possible values for the symbol. Pin. 226 Lower = Type.getMinValue(); 227 Upper = Type.getMaxValue(); 228 break; 229 } 230 break; 231 case APSIntType::RTR_Within: 232 switch (UpperTest) { 233 case APSIntType::RTR_Below: 234 // The range wraps around, but all lower values are not possible. 235 Type.apply(Lower); 236 Upper = Type.getMaxValue(); 237 break; 238 case APSIntType::RTR_Within: 239 // The range may or may not wrap around, but both limits are valid. 240 Type.apply(Lower); 241 Type.apply(Upper); 242 break; 243 case APSIntType::RTR_Above: 244 // The range starts within what's possible but ends above it. Pin. 245 Type.apply(Lower); 246 Upper = Type.getMaxValue(); 247 break; 248 } 249 break; 250 case APSIntType::RTR_Above: 251 switch (UpperTest) { 252 case APSIntType::RTR_Below: 253 // The range wraps but is outside the symbol's set of possible values. 254 return false; 255 case APSIntType::RTR_Within: 256 // The range starts above what's possible but ends within it (wrap). 257 Lower = Type.getMinValue(); 258 Type.apply(Upper); 259 break; 260 case APSIntType::RTR_Above: 261 // The entire range is outside the symbol's set of possible values. 262 // If this is a conventionally-ordered range, the state is infeasible. 263 if (Lower <= Upper) 264 return false; 265 266 // However, if the range wraps around, it spans all possible values. 267 Lower = Type.getMinValue(); 268 Upper = Type.getMaxValue(); 269 break; 270 } 271 break; 272 } 273 274 return true; 275 } 276 277 RangeSet RangeSet::Factory::intersect(RangeSet What, llvm::APSInt Lower, 278 llvm::APSInt Upper) { 279 if (What.isEmpty() || !What.pin(Lower, Upper)) 280 return getEmptySet(); 281 282 ContainerType DummyContainer; 283 284 if (Lower <= Upper) { 285 // [Lower, Upper] is a regular range. 286 // 287 // Shortcut: check that there is even a possibility of the intersection 288 // by checking the two following situations: 289 // 290 // <---[ What ]---[------]------> 291 // Lower Upper 292 // -or- 293 // <----[------]----[ What ]----> 294 // Lower Upper 295 if (What.getMaxValue() < Lower || Upper < What.getMinValue()) 296 return getEmptySet(); 297 298 DummyContainer.push_back( 299 Range(ValueFactory.getValue(Lower), ValueFactory.getValue(Upper))); 300 } else { 301 // [Lower, Upper] is an inverted range, i.e. [MIN, Upper] U [Lower, MAX] 302 // 303 // Shortcut: check that there is even a possibility of the intersection 304 // by checking the following situation: 305 // 306 // <------]---[ What ]---[------> 307 // Upper Lower 308 if (What.getMaxValue() < Lower && Upper < What.getMinValue()) 309 return getEmptySet(); 310 311 DummyContainer.push_back( 312 Range(ValueFactory.getMinValue(Upper), ValueFactory.getValue(Upper))); 313 DummyContainer.push_back( 314 Range(ValueFactory.getValue(Lower), ValueFactory.getMaxValue(Lower))); 315 } 316 317 return intersect(*What.Impl, DummyContainer); 318 } 319 320 RangeSet RangeSet::Factory::intersect(const RangeSet::ContainerType &LHS, 321 const RangeSet::ContainerType &RHS) { 322 ContainerType Result; 323 Result.reserve(std::max(LHS.size(), RHS.size())); 324 325 const_iterator First = LHS.begin(), Second = RHS.begin(), 326 FirstEnd = LHS.end(), SecondEnd = RHS.end(); 327 328 const auto SwapIterators = [&First, &FirstEnd, &Second, &SecondEnd]() { 329 std::swap(First, Second); 330 std::swap(FirstEnd, SecondEnd); 331 }; 332 333 // If we ran out of ranges in one set, but not in the other, 334 // it means that those elements are definitely not in the 335 // intersection. 336 while (First != FirstEnd && Second != SecondEnd) { 337 // We want to keep the following invariant at all times: 338 // 339 // ----[ First ----------------------> 340 // --------[ Second -----------------> 341 if (Second->From() < First->From()) 342 SwapIterators(); 343 344 // Loop where the invariant holds: 345 do { 346 // Check for the following situation: 347 // 348 // ----[ First ]---------------------> 349 // ---------------[ Second ]---------> 350 // 351 // which means that... 352 if (Second->From() > First->To()) { 353 // ...First is not in the intersection. 354 // 355 // We should move on to the next range after First and break out of the 356 // loop because the invariant might not be true. 357 ++First; 358 break; 359 } 360 361 // We have a guaranteed intersection at this point! 362 // And this is the current situation: 363 // 364 // ----[ First ]-----------------> 365 // -------[ Second ------------------> 366 // 367 // Additionally, it definitely starts with Second->From(). 368 const llvm::APSInt &IntersectionStart = Second->From(); 369 370 // It is important to know which of the two ranges' ends 371 // is greater. That "longer" range might have some other 372 // intersections, while the "shorter" range might not. 373 if (Second->To() > First->To()) { 374 // Here we make a decision to keep First as the "longer" 375 // range. 376 SwapIterators(); 377 } 378 379 // At this point, we have the following situation: 380 // 381 // ---- First ]--------------------> 382 // ---- Second ]--[ Second+1 ----------> 383 // 384 // We don't know the relationship between First->From and 385 // Second->From and we don't know whether Second+1 intersects 386 // with First. 387 // 388 // However, we know that [IntersectionStart, Second->To] is 389 // a part of the intersection... 390 Result.push_back(Range(IntersectionStart, Second->To())); 391 ++Second; 392 // ...and that the invariant will hold for a valid Second+1 393 // because First->From <= Second->To < (Second+1)->From. 394 } while (Second != SecondEnd); 395 } 396 397 if (Result.empty()) 398 return getEmptySet(); 399 400 return makePersistent(std::move(Result)); 401 } 402 403 RangeSet RangeSet::Factory::intersect(RangeSet LHS, RangeSet RHS) { 404 // Shortcut: let's see if the intersection is even possible. 405 if (LHS.isEmpty() || RHS.isEmpty() || LHS.getMaxValue() < RHS.getMinValue() || 406 RHS.getMaxValue() < LHS.getMinValue()) 407 return getEmptySet(); 408 409 return intersect(*LHS.Impl, *RHS.Impl); 410 } 411 412 RangeSet RangeSet::Factory::intersect(RangeSet LHS, llvm::APSInt Point) { 413 if (LHS.containsImpl(Point)) 414 return getRangeSet(ValueFactory.getValue(Point)); 415 416 return getEmptySet(); 417 } 418 419 RangeSet RangeSet::Factory::negate(RangeSet What) { 420 if (What.isEmpty()) 421 return getEmptySet(); 422 423 const llvm::APSInt SampleValue = What.getMinValue(); 424 const llvm::APSInt &MIN = ValueFactory.getMinValue(SampleValue); 425 const llvm::APSInt &MAX = ValueFactory.getMaxValue(SampleValue); 426 427 ContainerType Result; 428 Result.reserve(What.size() + (SampleValue == MIN)); 429 430 // Handle a special case for MIN value. 431 const_iterator It = What.begin(); 432 const_iterator End = What.end(); 433 434 const llvm::APSInt &From = It->From(); 435 const llvm::APSInt &To = It->To(); 436 437 if (From == MIN) { 438 // If the range [From, To] is [MIN, MAX], then result is also [MIN, MAX]. 439 if (To == MAX) { 440 return What; 441 } 442 443 const_iterator Last = std::prev(End); 444 445 // Try to find and unite the following ranges: 446 // [MIN, MIN] & [MIN + 1, N] => [MIN, N]. 447 if (Last->To() == MAX) { 448 // It means that in the original range we have ranges 449 // [MIN, A], ... , [B, MAX] 450 // And the result should be [MIN, -B], ..., [-A, MAX] 451 Result.emplace_back(MIN, ValueFactory.getValue(-Last->From())); 452 // We already negated Last, so we can skip it. 453 End = Last; 454 } else { 455 // Add a separate range for the lowest value. 456 Result.emplace_back(MIN, MIN); 457 } 458 459 // Skip adding the second range in case when [From, To] are [MIN, MIN]. 460 if (To != MIN) { 461 Result.emplace_back(ValueFactory.getValue(-To), MAX); 462 } 463 464 // Skip the first range in the loop. 465 ++It; 466 } 467 468 // Negate all other ranges. 469 for (; It != End; ++It) { 470 // Negate int values. 471 const llvm::APSInt &NewFrom = ValueFactory.getValue(-It->To()); 472 const llvm::APSInt &NewTo = ValueFactory.getValue(-It->From()); 473 474 // Add a negated range. 475 Result.emplace_back(NewFrom, NewTo); 476 } 477 478 llvm::sort(Result); 479 return makePersistent(std::move(Result)); 480 } 481 482 RangeSet RangeSet::Factory::deletePoint(RangeSet From, 483 const llvm::APSInt &Point) { 484 if (!From.contains(Point)) 485 return From; 486 487 llvm::APSInt Upper = Point; 488 llvm::APSInt Lower = Point; 489 490 ++Upper; 491 --Lower; 492 493 // Notice that the lower bound is greater than the upper bound. 494 return intersect(From, Upper, Lower); 495 } 496 497 LLVM_DUMP_METHOD void Range::dump(raw_ostream &OS) const { 498 OS << '[' << toString(From(), 10) << ", " << toString(To(), 10) << ']'; 499 } 500 LLVM_DUMP_METHOD void Range::dump() const { dump(llvm::errs()); } 501 502 LLVM_DUMP_METHOD void RangeSet::dump(raw_ostream &OS) const { 503 OS << "{ "; 504 llvm::interleaveComma(*this, OS, [&OS](const Range &R) { R.dump(OS); }); 505 OS << " }"; 506 } 507 LLVM_DUMP_METHOD void RangeSet::dump() const { dump(llvm::errs()); } 508 509 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(SymbolSet, SymbolRef) 510 511 namespace { 512 class EquivalenceClass; 513 } // end anonymous namespace 514 515 REGISTER_MAP_WITH_PROGRAMSTATE(ClassMap, SymbolRef, EquivalenceClass) 516 REGISTER_MAP_WITH_PROGRAMSTATE(ClassMembers, EquivalenceClass, SymbolSet) 517 REGISTER_MAP_WITH_PROGRAMSTATE(ConstraintRange, EquivalenceClass, RangeSet) 518 519 REGISTER_SET_FACTORY_WITH_PROGRAMSTATE(ClassSet, EquivalenceClass) 520 REGISTER_MAP_WITH_PROGRAMSTATE(DisequalityMap, EquivalenceClass, ClassSet) 521 522 namespace { 523 /// This class encapsulates a set of symbols equal to each other. 524 /// 525 /// The main idea of the approach requiring such classes is in narrowing 526 /// and sharing constraints between symbols within the class. Also we can 527 /// conclude that there is no practical need in storing constraints for 528 /// every member of the class separately. 529 /// 530 /// Main terminology: 531 /// 532 /// * "Equivalence class" is an object of this class, which can be efficiently 533 /// compared to other classes. It represents the whole class without 534 /// storing the actual in it. The members of the class however can be 535 /// retrieved from the state. 536 /// 537 /// * "Class members" are the symbols corresponding to the class. This means 538 /// that A == B for every member symbols A and B from the class. Members of 539 /// each class are stored in the state. 540 /// 541 /// * "Trivial class" is a class that has and ever had only one same symbol. 542 /// 543 /// * "Merge operation" merges two classes into one. It is the main operation 544 /// to produce non-trivial classes. 545 /// If, at some point, we can assume that two symbols from two distinct 546 /// classes are equal, we can merge these classes. 547 class EquivalenceClass : public llvm::FoldingSetNode { 548 public: 549 /// Find equivalence class for the given symbol in the given state. 550 LLVM_NODISCARD static inline EquivalenceClass find(ProgramStateRef State, 551 SymbolRef Sym); 552 553 /// Merge classes for the given symbols and return a new state. 554 LLVM_NODISCARD static inline ProgramStateRef merge(RangeSet::Factory &F, 555 ProgramStateRef State, 556 SymbolRef First, 557 SymbolRef Second); 558 // Merge this class with the given class and return a new state. 559 LLVM_NODISCARD inline ProgramStateRef 560 merge(RangeSet::Factory &F, ProgramStateRef State, EquivalenceClass Other); 561 562 /// Return a set of class members for the given state. 563 LLVM_NODISCARD inline SymbolSet getClassMembers(ProgramStateRef State) const; 564 565 /// Return true if the current class is trivial in the given state. 566 /// A class is trivial if and only if there is not any member relations stored 567 /// to it in State/ClassMembers. 568 /// An equivalence class with one member might seem as it does not hold any 569 /// meaningful information, i.e. that is a tautology. However, during the 570 /// removal of dead symbols we do not remove classes with one member for 571 /// resource and performance reasons. Consequently, a class with one member is 572 /// not necessarily trivial. It could happen that we have a class with two 573 /// members and then during the removal of dead symbols we remove one of its 574 /// members. In this case, the class is still non-trivial (it still has the 575 /// mappings in ClassMembers), even though it has only one member. 576 LLVM_NODISCARD inline bool isTrivial(ProgramStateRef State) const; 577 578 /// Return true if the current class is trivial and its only member is dead. 579 LLVM_NODISCARD inline bool isTriviallyDead(ProgramStateRef State, 580 SymbolReaper &Reaper) const; 581 582 LLVM_NODISCARD static inline ProgramStateRef 583 markDisequal(RangeSet::Factory &F, ProgramStateRef State, SymbolRef First, 584 SymbolRef Second); 585 LLVM_NODISCARD static inline ProgramStateRef 586 markDisequal(RangeSet::Factory &F, ProgramStateRef State, 587 EquivalenceClass First, EquivalenceClass Second); 588 LLVM_NODISCARD inline ProgramStateRef 589 markDisequal(RangeSet::Factory &F, ProgramStateRef State, 590 EquivalenceClass Other) const; 591 LLVM_NODISCARD static inline ClassSet 592 getDisequalClasses(ProgramStateRef State, SymbolRef Sym); 593 LLVM_NODISCARD inline ClassSet 594 getDisequalClasses(ProgramStateRef State) const; 595 LLVM_NODISCARD inline ClassSet 596 getDisequalClasses(DisequalityMapTy Map, ClassSet::Factory &Factory) const; 597 598 LLVM_NODISCARD static inline Optional<bool> areEqual(ProgramStateRef State, 599 EquivalenceClass First, 600 EquivalenceClass Second); 601 LLVM_NODISCARD static inline Optional<bool> 602 areEqual(ProgramStateRef State, SymbolRef First, SymbolRef Second); 603 604 /// Iterate over all symbols and try to simplify them. 605 LLVM_NODISCARD static inline ProgramStateRef simplify(SValBuilder &SVB, 606 RangeSet::Factory &F, 607 ProgramStateRef State, 608 EquivalenceClass Class); 609 610 void dumpToStream(ProgramStateRef State, raw_ostream &os) const; 611 LLVM_DUMP_METHOD void dump(ProgramStateRef State) const { 612 dumpToStream(State, llvm::errs()); 613 } 614 615 /// Check equivalence data for consistency. 616 LLVM_NODISCARD LLVM_ATTRIBUTE_UNUSED static bool 617 isClassDataConsistent(ProgramStateRef State); 618 619 LLVM_NODISCARD QualType getType() const { 620 return getRepresentativeSymbol()->getType(); 621 } 622 623 EquivalenceClass() = delete; 624 EquivalenceClass(const EquivalenceClass &) = default; 625 EquivalenceClass &operator=(const EquivalenceClass &) = delete; 626 EquivalenceClass(EquivalenceClass &&) = default; 627 EquivalenceClass &operator=(EquivalenceClass &&) = delete; 628 629 bool operator==(const EquivalenceClass &Other) const { 630 return ID == Other.ID; 631 } 632 bool operator<(const EquivalenceClass &Other) const { return ID < Other.ID; } 633 bool operator!=(const EquivalenceClass &Other) const { 634 return !operator==(Other); 635 } 636 637 static void Profile(llvm::FoldingSetNodeID &ID, uintptr_t CID) { 638 ID.AddInteger(CID); 639 } 640 641 void Profile(llvm::FoldingSetNodeID &ID) const { Profile(ID, this->ID); } 642 643 private: 644 /* implicit */ EquivalenceClass(SymbolRef Sym) 645 : ID(reinterpret_cast<uintptr_t>(Sym)) {} 646 647 /// This function is intended to be used ONLY within the class. 648 /// The fact that ID is a pointer to a symbol is an implementation detail 649 /// and should stay that way. 650 /// In the current implementation, we use it to retrieve the only member 651 /// of the trivial class. 652 SymbolRef getRepresentativeSymbol() const { 653 return reinterpret_cast<SymbolRef>(ID); 654 } 655 static inline SymbolSet::Factory &getMembersFactory(ProgramStateRef State); 656 657 inline ProgramStateRef mergeImpl(RangeSet::Factory &F, ProgramStateRef State, 658 SymbolSet Members, EquivalenceClass Other, 659 SymbolSet OtherMembers); 660 661 static inline bool 662 addToDisequalityInfo(DisequalityMapTy &Info, ConstraintRangeTy &Constraints, 663 RangeSet::Factory &F, ProgramStateRef State, 664 EquivalenceClass First, EquivalenceClass Second); 665 666 /// This is a unique identifier of the class. 667 uintptr_t ID; 668 }; 669 670 //===----------------------------------------------------------------------===// 671 // Constraint functions 672 //===----------------------------------------------------------------------===// 673 674 LLVM_NODISCARD LLVM_ATTRIBUTE_UNUSED bool 675 areFeasible(ConstraintRangeTy Constraints) { 676 return llvm::none_of( 677 Constraints, 678 [](const std::pair<EquivalenceClass, RangeSet> &ClassConstraint) { 679 return ClassConstraint.second.isEmpty(); 680 }); 681 } 682 683 LLVM_NODISCARD inline const RangeSet *getConstraint(ProgramStateRef State, 684 EquivalenceClass Class) { 685 return State->get<ConstraintRange>(Class); 686 } 687 688 LLVM_NODISCARD inline const RangeSet *getConstraint(ProgramStateRef State, 689 SymbolRef Sym) { 690 return getConstraint(State, EquivalenceClass::find(State, Sym)); 691 } 692 693 LLVM_NODISCARD ProgramStateRef setConstraint(ProgramStateRef State, 694 EquivalenceClass Class, 695 RangeSet Constraint) { 696 return State->set<ConstraintRange>(Class, Constraint); 697 } 698 699 LLVM_NODISCARD ProgramStateRef setConstraints(ProgramStateRef State, 700 ConstraintRangeTy Constraints) { 701 return State->set<ConstraintRange>(Constraints); 702 } 703 704 //===----------------------------------------------------------------------===// 705 // Equality/diseqiality abstraction 706 //===----------------------------------------------------------------------===// 707 708 /// A small helper function for detecting symbolic (dis)equality. 709 /// 710 /// Equality check can have different forms (like a == b or a - b) and this 711 /// class encapsulates those away if the only thing the user wants to check - 712 /// whether it's equality/diseqiality or not. 713 /// 714 /// \returns true if assuming this Sym to be true means equality of operands 715 /// false if it means disequality of operands 716 /// None otherwise 717 Optional<bool> meansEquality(const SymSymExpr *Sym) { 718 switch (Sym->getOpcode()) { 719 case BO_Sub: 720 // This case is: A - B != 0 -> disequality check. 721 return false; 722 case BO_EQ: 723 // This case is: A == B != 0 -> equality check. 724 return true; 725 case BO_NE: 726 // This case is: A != B != 0 -> diseqiality check. 727 return false; 728 default: 729 return llvm::None; 730 } 731 } 732 733 //===----------------------------------------------------------------------===// 734 // Intersection functions 735 //===----------------------------------------------------------------------===// 736 737 template <class SecondTy, class... RestTy> 738 LLVM_NODISCARD inline RangeSet intersect(RangeSet::Factory &F, RangeSet Head, 739 SecondTy Second, RestTy... Tail); 740 741 template <class... RangeTy> struct IntersectionTraits; 742 743 template <class... TailTy> struct IntersectionTraits<RangeSet, TailTy...> { 744 // Found RangeSet, no need to check any further 745 using Type = RangeSet; 746 }; 747 748 template <> struct IntersectionTraits<> { 749 // We ran out of types, and we didn't find any RangeSet, so the result should 750 // be optional. 751 using Type = Optional<RangeSet>; 752 }; 753 754 template <class OptionalOrPointer, class... TailTy> 755 struct IntersectionTraits<OptionalOrPointer, TailTy...> { 756 // If current type is Optional or a raw pointer, we should keep looking. 757 using Type = typename IntersectionTraits<TailTy...>::Type; 758 }; 759 760 template <class EndTy> 761 LLVM_NODISCARD inline EndTy intersect(RangeSet::Factory &F, EndTy End) { 762 // If the list contains only RangeSet or Optional<RangeSet>, simply return 763 // that range set. 764 return End; 765 } 766 767 LLVM_NODISCARD LLVM_ATTRIBUTE_UNUSED inline Optional<RangeSet> 768 intersect(RangeSet::Factory &F, const RangeSet *End) { 769 // This is an extraneous conversion from a raw pointer into Optional<RangeSet> 770 if (End) { 771 return *End; 772 } 773 return llvm::None; 774 } 775 776 template <class... RestTy> 777 LLVM_NODISCARD inline RangeSet intersect(RangeSet::Factory &F, RangeSet Head, 778 RangeSet Second, RestTy... Tail) { 779 // Here we call either the <RangeSet,RangeSet,...> or <RangeSet,...> version 780 // of the function and can be sure that the result is RangeSet. 781 return intersect(F, F.intersect(Head, Second), Tail...); 782 } 783 784 template <class SecondTy, class... RestTy> 785 LLVM_NODISCARD inline RangeSet intersect(RangeSet::Factory &F, RangeSet Head, 786 SecondTy Second, RestTy... Tail) { 787 if (Second) { 788 // Here we call the <RangeSet,RangeSet,...> version of the function... 789 return intersect(F, Head, *Second, Tail...); 790 } 791 // ...and here it is either <RangeSet,RangeSet,...> or <RangeSet,...>, which 792 // means that the result is definitely RangeSet. 793 return intersect(F, Head, Tail...); 794 } 795 796 /// Main generic intersect function. 797 /// It intersects all of the given range sets. If some of the given arguments 798 /// don't hold a range set (nullptr or llvm::None), the function will skip them. 799 /// 800 /// Available representations for the arguments are: 801 /// * RangeSet 802 /// * Optional<RangeSet> 803 /// * RangeSet * 804 /// Pointer to a RangeSet is automatically assumed to be nullable and will get 805 /// checked as well as the optional version. If this behaviour is undesired, 806 /// please dereference the pointer in the call. 807 /// 808 /// Return type depends on the arguments' types. If we can be sure in compile 809 /// time that there will be a range set as a result, the returning type is 810 /// simply RangeSet, in other cases we have to back off to Optional<RangeSet>. 811 /// 812 /// Please, prefer optional range sets to raw pointers. If the last argument is 813 /// a raw pointer and all previous arguments are None, it will cost one 814 /// additional check to convert RangeSet * into Optional<RangeSet>. 815 template <class HeadTy, class SecondTy, class... RestTy> 816 LLVM_NODISCARD inline 817 typename IntersectionTraits<HeadTy, SecondTy, RestTy...>::Type 818 intersect(RangeSet::Factory &F, HeadTy Head, SecondTy Second, 819 RestTy... Tail) { 820 if (Head) { 821 return intersect(F, *Head, Second, Tail...); 822 } 823 return intersect(F, Second, Tail...); 824 } 825 826 //===----------------------------------------------------------------------===// 827 // Symbolic reasoning logic 828 //===----------------------------------------------------------------------===// 829 830 /// A little component aggregating all of the reasoning we have about 831 /// the ranges of symbolic expressions. 832 /// 833 /// Even when we don't know the exact values of the operands, we still 834 /// can get a pretty good estimate of the result's range. 835 class SymbolicRangeInferrer 836 : public SymExprVisitor<SymbolicRangeInferrer, RangeSet> { 837 public: 838 template <class SourceType> 839 static RangeSet inferRange(RangeSet::Factory &F, ProgramStateRef State, 840 SourceType Origin) { 841 SymbolicRangeInferrer Inferrer(F, State); 842 return Inferrer.infer(Origin); 843 } 844 845 RangeSet VisitSymExpr(SymbolRef Sym) { 846 // If we got to this function, the actual type of the symbolic 847 // expression is not supported for advanced inference. 848 // In this case, we simply backoff to the default "let's simply 849 // infer the range from the expression's type". 850 return infer(Sym->getType()); 851 } 852 853 RangeSet VisitSymIntExpr(const SymIntExpr *Sym) { 854 return VisitBinaryOperator(Sym); 855 } 856 857 RangeSet VisitIntSymExpr(const IntSymExpr *Sym) { 858 return VisitBinaryOperator(Sym); 859 } 860 861 RangeSet VisitSymSymExpr(const SymSymExpr *Sym) { 862 return intersect( 863 RangeFactory, 864 // If Sym is (dis)equality, we might have some information 865 // on that in our equality classes data structure. 866 getRangeForEqualities(Sym), 867 // And we should always check what we can get from the operands. 868 VisitBinaryOperator(Sym)); 869 } 870 871 private: 872 SymbolicRangeInferrer(RangeSet::Factory &F, ProgramStateRef S) 873 : ValueFactory(F.getValueFactory()), RangeFactory(F), State(S) {} 874 875 /// Infer range information from the given integer constant. 876 /// 877 /// It's not a real "inference", but is here for operating with 878 /// sub-expressions in a more polymorphic manner. 879 RangeSet inferAs(const llvm::APSInt &Val, QualType) { 880 return {RangeFactory, Val}; 881 } 882 883 /// Infer range information from symbol in the context of the given type. 884 RangeSet inferAs(SymbolRef Sym, QualType DestType) { 885 QualType ActualType = Sym->getType(); 886 // Check that we can reason about the symbol at all. 887 if (ActualType->isIntegralOrEnumerationType() || 888 Loc::isLocType(ActualType)) { 889 return infer(Sym); 890 } 891 // Otherwise, let's simply infer from the destination type. 892 // We couldn't figure out nothing else about that expression. 893 return infer(DestType); 894 } 895 896 RangeSet infer(SymbolRef Sym) { 897 return intersect( 898 RangeFactory, 899 // Of course, we should take the constraint directly associated with 900 // this symbol into consideration. 901 getConstraint(State, Sym), 902 // If Sym is a difference of symbols A - B, then maybe we have range 903 // set stored for B - A. 904 // 905 // If we have range set stored for both A - B and B - A then 906 // calculate the effective range set by intersecting the range set 907 // for A - B and the negated range set of B - A. 908 getRangeForNegatedSub(Sym), 909 // If Sym is a comparison expression (except <=>), 910 // find any other comparisons with the same operands. 911 // See function description. 912 getRangeForComparisonSymbol(Sym), 913 // Apart from the Sym itself, we can infer quite a lot if we look 914 // into subexpressions of Sym. 915 Visit(Sym)); 916 } 917 918 RangeSet infer(EquivalenceClass Class) { 919 if (const RangeSet *AssociatedConstraint = getConstraint(State, Class)) 920 return *AssociatedConstraint; 921 922 return infer(Class.getType()); 923 } 924 925 /// Infer range information solely from the type. 926 RangeSet infer(QualType T) { 927 // Lazily generate a new RangeSet representing all possible values for the 928 // given symbol type. 929 RangeSet Result(RangeFactory, ValueFactory.getMinValue(T), 930 ValueFactory.getMaxValue(T)); 931 932 // References are known to be non-zero. 933 if (T->isReferenceType()) 934 return assumeNonZero(Result, T); 935 936 return Result; 937 } 938 939 template <class BinarySymExprTy> 940 RangeSet VisitBinaryOperator(const BinarySymExprTy *Sym) { 941 // TODO #1: VisitBinaryOperator implementation might not make a good 942 // use of the inferred ranges. In this case, we might be calculating 943 // everything for nothing. This being said, we should introduce some 944 // sort of laziness mechanism here. 945 // 946 // TODO #2: We didn't go into the nested expressions before, so it 947 // might cause us spending much more time doing the inference. 948 // This can be a problem for deeply nested expressions that are 949 // involved in conditions and get tested continuously. We definitely 950 // need to address this issue and introduce some sort of caching 951 // in here. 952 QualType ResultType = Sym->getType(); 953 return VisitBinaryOperator(inferAs(Sym->getLHS(), ResultType), 954 Sym->getOpcode(), 955 inferAs(Sym->getRHS(), ResultType), ResultType); 956 } 957 958 RangeSet VisitBinaryOperator(RangeSet LHS, BinaryOperator::Opcode Op, 959 RangeSet RHS, QualType T) { 960 switch (Op) { 961 case BO_Or: 962 return VisitBinaryOperator<BO_Or>(LHS, RHS, T); 963 case BO_And: 964 return VisitBinaryOperator<BO_And>(LHS, RHS, T); 965 case BO_Rem: 966 return VisitBinaryOperator<BO_Rem>(LHS, RHS, T); 967 default: 968 return infer(T); 969 } 970 } 971 972 //===----------------------------------------------------------------------===// 973 // Ranges and operators 974 //===----------------------------------------------------------------------===// 975 976 /// Return a rough approximation of the given range set. 977 /// 978 /// For the range set: 979 /// { [x_0, y_0], [x_1, y_1], ... , [x_N, y_N] } 980 /// it will return the range [x_0, y_N]. 981 static Range fillGaps(RangeSet Origin) { 982 assert(!Origin.isEmpty()); 983 return {Origin.getMinValue(), Origin.getMaxValue()}; 984 } 985 986 /// Try to convert given range into the given type. 987 /// 988 /// It will return llvm::None only when the trivial conversion is possible. 989 llvm::Optional<Range> convert(const Range &Origin, APSIntType To) { 990 if (To.testInRange(Origin.From(), false) != APSIntType::RTR_Within || 991 To.testInRange(Origin.To(), false) != APSIntType::RTR_Within) { 992 return llvm::None; 993 } 994 return Range(ValueFactory.Convert(To, Origin.From()), 995 ValueFactory.Convert(To, Origin.To())); 996 } 997 998 template <BinaryOperator::Opcode Op> 999 RangeSet VisitBinaryOperator(RangeSet LHS, RangeSet RHS, QualType T) { 1000 // We should propagate information about unfeasbility of one of the 1001 // operands to the resulting range. 1002 if (LHS.isEmpty() || RHS.isEmpty()) { 1003 return RangeFactory.getEmptySet(); 1004 } 1005 1006 Range CoarseLHS = fillGaps(LHS); 1007 Range CoarseRHS = fillGaps(RHS); 1008 1009 APSIntType ResultType = ValueFactory.getAPSIntType(T); 1010 1011 // We need to convert ranges to the resulting type, so we can compare values 1012 // and combine them in a meaningful (in terms of the given operation) way. 1013 auto ConvertedCoarseLHS = convert(CoarseLHS, ResultType); 1014 auto ConvertedCoarseRHS = convert(CoarseRHS, ResultType); 1015 1016 // It is hard to reason about ranges when conversion changes 1017 // borders of the ranges. 1018 if (!ConvertedCoarseLHS || !ConvertedCoarseRHS) { 1019 return infer(T); 1020 } 1021 1022 return VisitBinaryOperator<Op>(*ConvertedCoarseLHS, *ConvertedCoarseRHS, T); 1023 } 1024 1025 template <BinaryOperator::Opcode Op> 1026 RangeSet VisitBinaryOperator(Range LHS, Range RHS, QualType T) { 1027 return infer(T); 1028 } 1029 1030 /// Return a symmetrical range for the given range and type. 1031 /// 1032 /// If T is signed, return the smallest range [-x..x] that covers the original 1033 /// range, or [-min(T), max(T)] if the aforementioned symmetric range doesn't 1034 /// exist due to original range covering min(T)). 1035 /// 1036 /// If T is unsigned, return the smallest range [0..x] that covers the 1037 /// original range. 1038 Range getSymmetricalRange(Range Origin, QualType T) { 1039 APSIntType RangeType = ValueFactory.getAPSIntType(T); 1040 1041 if (RangeType.isUnsigned()) { 1042 return Range(ValueFactory.getMinValue(RangeType), Origin.To()); 1043 } 1044 1045 if (Origin.From().isMinSignedValue()) { 1046 // If mini is a minimal signed value, absolute value of it is greater 1047 // than the maximal signed value. In order to avoid these 1048 // complications, we simply return the whole range. 1049 return {ValueFactory.getMinValue(RangeType), 1050 ValueFactory.getMaxValue(RangeType)}; 1051 } 1052 1053 // At this point, we are sure that the type is signed and we can safely 1054 // use unary - operator. 1055 // 1056 // While calculating absolute maximum, we can use the following formula 1057 // because of these reasons: 1058 // * If From >= 0 then To >= From and To >= -From. 1059 // AbsMax == To == max(To, -From) 1060 // * If To <= 0 then -From >= -To and -From >= From. 1061 // AbsMax == -From == max(-From, To) 1062 // * Otherwise, From <= 0, To >= 0, and 1063 // AbsMax == max(abs(From), abs(To)) 1064 llvm::APSInt AbsMax = std::max(-Origin.From(), Origin.To()); 1065 1066 // Intersection is guaranteed to be non-empty. 1067 return {ValueFactory.getValue(-AbsMax), ValueFactory.getValue(AbsMax)}; 1068 } 1069 1070 /// Return a range set subtracting zero from \p Domain. 1071 RangeSet assumeNonZero(RangeSet Domain, QualType T) { 1072 APSIntType IntType = ValueFactory.getAPSIntType(T); 1073 return RangeFactory.deletePoint(Domain, IntType.getZeroValue()); 1074 } 1075 1076 // FIXME: Once SValBuilder supports unary minus, we should use SValBuilder to 1077 // obtain the negated symbolic expression instead of constructing the 1078 // symbol manually. This will allow us to support finding ranges of not 1079 // only negated SymSymExpr-type expressions, but also of other, simpler 1080 // expressions which we currently do not know how to negate. 1081 Optional<RangeSet> getRangeForNegatedSub(SymbolRef Sym) { 1082 if (const SymSymExpr *SSE = dyn_cast<SymSymExpr>(Sym)) { 1083 if (SSE->getOpcode() == BO_Sub) { 1084 QualType T = Sym->getType(); 1085 1086 // Do not negate unsigned ranges 1087 if (!T->isUnsignedIntegerOrEnumerationType() && 1088 !T->isSignedIntegerOrEnumerationType()) 1089 return llvm::None; 1090 1091 SymbolManager &SymMgr = State->getSymbolManager(); 1092 SymbolRef NegatedSym = 1093 SymMgr.getSymSymExpr(SSE->getRHS(), BO_Sub, SSE->getLHS(), T); 1094 1095 if (const RangeSet *NegatedRange = getConstraint(State, NegatedSym)) { 1096 return RangeFactory.negate(*NegatedRange); 1097 } 1098 } 1099 } 1100 return llvm::None; 1101 } 1102 1103 // Returns ranges only for binary comparison operators (except <=>) 1104 // when left and right operands are symbolic values. 1105 // Finds any other comparisons with the same operands. 1106 // Then do logical calculations and refuse impossible branches. 1107 // E.g. (x < y) and (x > y) at the same time are impossible. 1108 // E.g. (x >= y) and (x != y) at the same time makes (x > y) true only. 1109 // E.g. (x == y) and (y == x) are just reversed but the same. 1110 // It covers all possible combinations (see CmpOpTable description). 1111 // Note that `x` and `y` can also stand for subexpressions, 1112 // not only for actual symbols. 1113 Optional<RangeSet> getRangeForComparisonSymbol(SymbolRef Sym) { 1114 const auto *SSE = dyn_cast<SymSymExpr>(Sym); 1115 if (!SSE) 1116 return llvm::None; 1117 1118 const BinaryOperatorKind CurrentOP = SSE->getOpcode(); 1119 1120 // We currently do not support <=> (C++20). 1121 if (!BinaryOperator::isComparisonOp(CurrentOP) || (CurrentOP == BO_Cmp)) 1122 return llvm::None; 1123 1124 static const OperatorRelationsTable CmpOpTable{}; 1125 1126 const SymExpr *LHS = SSE->getLHS(); 1127 const SymExpr *RHS = SSE->getRHS(); 1128 QualType T = SSE->getType(); 1129 1130 SymbolManager &SymMgr = State->getSymbolManager(); 1131 1132 // We use this variable to store the last queried operator (`QueriedOP`) 1133 // for which the `getCmpOpState` returned with `Unknown`. If there are two 1134 // different OPs that returned `Unknown` then we have to query the special 1135 // `UnknownX2` column. We assume that `getCmpOpState(CurrentOP, CurrentOP)` 1136 // never returns `Unknown`, so `CurrentOP` is a good initial value. 1137 BinaryOperatorKind LastQueriedOpToUnknown = CurrentOP; 1138 1139 // Loop goes through all of the columns exept the last one ('UnknownX2'). 1140 // We treat `UnknownX2` column separately at the end of the loop body. 1141 for (size_t i = 0; i < CmpOpTable.getCmpOpCount(); ++i) { 1142 1143 // Let's find an expression e.g. (x < y). 1144 BinaryOperatorKind QueriedOP = OperatorRelationsTable::getOpFromIndex(i); 1145 const SymSymExpr *SymSym = SymMgr.getSymSymExpr(LHS, QueriedOP, RHS, T); 1146 const RangeSet *QueriedRangeSet = getConstraint(State, SymSym); 1147 1148 // If ranges were not previously found, 1149 // try to find a reversed expression (y > x). 1150 if (!QueriedRangeSet) { 1151 const BinaryOperatorKind ROP = 1152 BinaryOperator::reverseComparisonOp(QueriedOP); 1153 SymSym = SymMgr.getSymSymExpr(RHS, ROP, LHS, T); 1154 QueriedRangeSet = getConstraint(State, SymSym); 1155 } 1156 1157 if (!QueriedRangeSet || QueriedRangeSet->isEmpty()) 1158 continue; 1159 1160 const llvm::APSInt *ConcreteValue = QueriedRangeSet->getConcreteValue(); 1161 const bool isInFalseBranch = 1162 ConcreteValue ? (*ConcreteValue == 0) : false; 1163 1164 // If it is a false branch, we shall be guided by opposite operator, 1165 // because the table is made assuming we are in the true branch. 1166 // E.g. when (x <= y) is false, then (x > y) is true. 1167 if (isInFalseBranch) 1168 QueriedOP = BinaryOperator::negateComparisonOp(QueriedOP); 1169 1170 OperatorRelationsTable::TriStateKind BranchState = 1171 CmpOpTable.getCmpOpState(CurrentOP, QueriedOP); 1172 1173 if (BranchState == OperatorRelationsTable::Unknown) { 1174 if (LastQueriedOpToUnknown != CurrentOP && 1175 LastQueriedOpToUnknown != QueriedOP) { 1176 // If we got the Unknown state for both different operators. 1177 // if (x <= y) // assume true 1178 // if (x != y) // assume true 1179 // if (x < y) // would be also true 1180 // Get a state from `UnknownX2` column. 1181 BranchState = CmpOpTable.getCmpOpStateForUnknownX2(CurrentOP); 1182 } else { 1183 LastQueriedOpToUnknown = QueriedOP; 1184 continue; 1185 } 1186 } 1187 1188 return (BranchState == OperatorRelationsTable::True) ? getTrueRange(T) 1189 : getFalseRange(T); 1190 } 1191 1192 return llvm::None; 1193 } 1194 1195 Optional<RangeSet> getRangeForEqualities(const SymSymExpr *Sym) { 1196 Optional<bool> Equality = meansEquality(Sym); 1197 1198 if (!Equality) 1199 return llvm::None; 1200 1201 if (Optional<bool> AreEqual = 1202 EquivalenceClass::areEqual(State, Sym->getLHS(), Sym->getRHS())) { 1203 // Here we cover two cases at once: 1204 // * if Sym is equality and its operands are known to be equal -> true 1205 // * if Sym is disequality and its operands are disequal -> true 1206 if (*AreEqual == *Equality) { 1207 return getTrueRange(Sym->getType()); 1208 } 1209 // Opposite combinations result in false. 1210 return getFalseRange(Sym->getType()); 1211 } 1212 1213 return llvm::None; 1214 } 1215 1216 RangeSet getTrueRange(QualType T) { 1217 RangeSet TypeRange = infer(T); 1218 return assumeNonZero(TypeRange, T); 1219 } 1220 1221 RangeSet getFalseRange(QualType T) { 1222 const llvm::APSInt &Zero = ValueFactory.getValue(0, T); 1223 return RangeSet(RangeFactory, Zero); 1224 } 1225 1226 BasicValueFactory &ValueFactory; 1227 RangeSet::Factory &RangeFactory; 1228 ProgramStateRef State; 1229 }; 1230 1231 //===----------------------------------------------------------------------===// 1232 // Range-based reasoning about symbolic operations 1233 //===----------------------------------------------------------------------===// 1234 1235 template <> 1236 RangeSet SymbolicRangeInferrer::VisitBinaryOperator<BO_Or>(Range LHS, Range RHS, 1237 QualType T) { 1238 APSIntType ResultType = ValueFactory.getAPSIntType(T); 1239 llvm::APSInt Zero = ResultType.getZeroValue(); 1240 1241 bool IsLHSPositiveOrZero = LHS.From() >= Zero; 1242 bool IsRHSPositiveOrZero = RHS.From() >= Zero; 1243 1244 bool IsLHSNegative = LHS.To() < Zero; 1245 bool IsRHSNegative = RHS.To() < Zero; 1246 1247 // Check if both ranges have the same sign. 1248 if ((IsLHSPositiveOrZero && IsRHSPositiveOrZero) || 1249 (IsLHSNegative && IsRHSNegative)) { 1250 // The result is definitely greater or equal than any of the operands. 1251 const llvm::APSInt &Min = std::max(LHS.From(), RHS.From()); 1252 1253 // We estimate maximal value for positives as the maximal value for the 1254 // given type. For negatives, we estimate it with -1 (e.g. 0x11111111). 1255 // 1256 // TODO: We basically, limit the resulting range from below, but don't do 1257 // anything with the upper bound. 1258 // 1259 // For positive operands, it can be done as follows: for the upper 1260 // bound of LHS and RHS we calculate the most significant bit set. 1261 // Let's call it the N-th bit. Then we can estimate the maximal 1262 // number to be 2^(N+1)-1, i.e. the number with all the bits up to 1263 // the N-th bit set. 1264 const llvm::APSInt &Max = IsLHSNegative 1265 ? ValueFactory.getValue(--Zero) 1266 : ValueFactory.getMaxValue(ResultType); 1267 1268 return {RangeFactory, ValueFactory.getValue(Min), Max}; 1269 } 1270 1271 // Otherwise, let's check if at least one of the operands is negative. 1272 if (IsLHSNegative || IsRHSNegative) { 1273 // This means that the result is definitely negative as well. 1274 return {RangeFactory, ValueFactory.getMinValue(ResultType), 1275 ValueFactory.getValue(--Zero)}; 1276 } 1277 1278 RangeSet DefaultRange = infer(T); 1279 1280 // It is pretty hard to reason about operands with different signs 1281 // (and especially with possibly different signs). We simply check if it 1282 // can be zero. In order to conclude that the result could not be zero, 1283 // at least one of the operands should be definitely not zero itself. 1284 if (!LHS.Includes(Zero) || !RHS.Includes(Zero)) { 1285 return assumeNonZero(DefaultRange, T); 1286 } 1287 1288 // Nothing much else to do here. 1289 return DefaultRange; 1290 } 1291 1292 template <> 1293 RangeSet SymbolicRangeInferrer::VisitBinaryOperator<BO_And>(Range LHS, 1294 Range RHS, 1295 QualType T) { 1296 APSIntType ResultType = ValueFactory.getAPSIntType(T); 1297 llvm::APSInt Zero = ResultType.getZeroValue(); 1298 1299 bool IsLHSPositiveOrZero = LHS.From() >= Zero; 1300 bool IsRHSPositiveOrZero = RHS.From() >= Zero; 1301 1302 bool IsLHSNegative = LHS.To() < Zero; 1303 bool IsRHSNegative = RHS.To() < Zero; 1304 1305 // Check if both ranges have the same sign. 1306 if ((IsLHSPositiveOrZero && IsRHSPositiveOrZero) || 1307 (IsLHSNegative && IsRHSNegative)) { 1308 // The result is definitely less or equal than any of the operands. 1309 const llvm::APSInt &Max = std::min(LHS.To(), RHS.To()); 1310 1311 // We conservatively estimate lower bound to be the smallest positive 1312 // or negative value corresponding to the sign of the operands. 1313 const llvm::APSInt &Min = IsLHSNegative 1314 ? ValueFactory.getMinValue(ResultType) 1315 : ValueFactory.getValue(Zero); 1316 1317 return {RangeFactory, Min, Max}; 1318 } 1319 1320 // Otherwise, let's check if at least one of the operands is positive. 1321 if (IsLHSPositiveOrZero || IsRHSPositiveOrZero) { 1322 // This makes result definitely positive. 1323 // 1324 // We can also reason about a maximal value by finding the maximal 1325 // value of the positive operand. 1326 const llvm::APSInt &Max = IsLHSPositiveOrZero ? LHS.To() : RHS.To(); 1327 1328 // The minimal value on the other hand is much harder to reason about. 1329 // The only thing we know for sure is that the result is positive. 1330 return {RangeFactory, ValueFactory.getValue(Zero), 1331 ValueFactory.getValue(Max)}; 1332 } 1333 1334 // Nothing much else to do here. 1335 return infer(T); 1336 } 1337 1338 template <> 1339 RangeSet SymbolicRangeInferrer::VisitBinaryOperator<BO_Rem>(Range LHS, 1340 Range RHS, 1341 QualType T) { 1342 llvm::APSInt Zero = ValueFactory.getAPSIntType(T).getZeroValue(); 1343 1344 Range ConservativeRange = getSymmetricalRange(RHS, T); 1345 1346 llvm::APSInt Max = ConservativeRange.To(); 1347 llvm::APSInt Min = ConservativeRange.From(); 1348 1349 if (Max == Zero) { 1350 // It's an undefined behaviour to divide by 0 and it seems like we know 1351 // for sure that RHS is 0. Let's say that the resulting range is 1352 // simply infeasible for that matter. 1353 return RangeFactory.getEmptySet(); 1354 } 1355 1356 // At this point, our conservative range is closed. The result, however, 1357 // couldn't be greater than the RHS' maximal absolute value. Because of 1358 // this reason, we turn the range into open (or half-open in case of 1359 // unsigned integers). 1360 // 1361 // While we operate on integer values, an open interval (a, b) can be easily 1362 // represented by the closed interval [a + 1, b - 1]. And this is exactly 1363 // what we do next. 1364 // 1365 // If we are dealing with unsigned case, we shouldn't move the lower bound. 1366 if (Min.isSigned()) { 1367 ++Min; 1368 } 1369 --Max; 1370 1371 bool IsLHSPositiveOrZero = LHS.From() >= Zero; 1372 bool IsRHSPositiveOrZero = RHS.From() >= Zero; 1373 1374 // Remainder operator results with negative operands is implementation 1375 // defined. Positive cases are much easier to reason about though. 1376 if (IsLHSPositiveOrZero && IsRHSPositiveOrZero) { 1377 // If maximal value of LHS is less than maximal value of RHS, 1378 // the result won't get greater than LHS.To(). 1379 Max = std::min(LHS.To(), Max); 1380 // We want to check if it is a situation similar to the following: 1381 // 1382 // <------------|---[ LHS ]--------[ RHS ]-----> 1383 // -INF 0 +INF 1384 // 1385 // In this situation, we can conclude that (LHS / RHS) == 0 and 1386 // (LHS % RHS) == LHS. 1387 Min = LHS.To() < RHS.From() ? LHS.From() : Zero; 1388 } 1389 1390 // Nevertheless, the symmetrical range for RHS is a conservative estimate 1391 // for any sign of either LHS, or RHS. 1392 return {RangeFactory, ValueFactory.getValue(Min), ValueFactory.getValue(Max)}; 1393 } 1394 1395 //===----------------------------------------------------------------------===// 1396 // Constraint manager implementation details 1397 //===----------------------------------------------------------------------===// 1398 1399 class RangeConstraintManager : public RangedConstraintManager { 1400 public: 1401 RangeConstraintManager(ExprEngine *EE, SValBuilder &SVB) 1402 : RangedConstraintManager(EE, SVB), F(getBasicVals()) {} 1403 1404 //===------------------------------------------------------------------===// 1405 // Implementation for interface from ConstraintManager. 1406 //===------------------------------------------------------------------===// 1407 1408 bool haveEqualConstraints(ProgramStateRef S1, 1409 ProgramStateRef S2) const override { 1410 // NOTE: ClassMembers are as simple as back pointers for ClassMap, 1411 // so comparing constraint ranges and class maps should be 1412 // sufficient. 1413 return S1->get<ConstraintRange>() == S2->get<ConstraintRange>() && 1414 S1->get<ClassMap>() == S2->get<ClassMap>(); 1415 } 1416 1417 bool canReasonAbout(SVal X) const override; 1418 1419 ConditionTruthVal checkNull(ProgramStateRef State, SymbolRef Sym) override; 1420 1421 const llvm::APSInt *getSymVal(ProgramStateRef State, 1422 SymbolRef Sym) const override; 1423 1424 ProgramStateRef removeDeadBindings(ProgramStateRef State, 1425 SymbolReaper &SymReaper) override; 1426 1427 void printJson(raw_ostream &Out, ProgramStateRef State, const char *NL = "\n", 1428 unsigned int Space = 0, bool IsDot = false) const override; 1429 void printConstraints(raw_ostream &Out, ProgramStateRef State, 1430 const char *NL = "\n", unsigned int Space = 0, 1431 bool IsDot = false) const; 1432 void printEquivalenceClasses(raw_ostream &Out, ProgramStateRef State, 1433 const char *NL = "\n", unsigned int Space = 0, 1434 bool IsDot = false) const; 1435 void printDisequalities(raw_ostream &Out, ProgramStateRef State, 1436 const char *NL = "\n", unsigned int Space = 0, 1437 bool IsDot = false) const; 1438 1439 //===------------------------------------------------------------------===// 1440 // Implementation for interface from RangedConstraintManager. 1441 //===------------------------------------------------------------------===// 1442 1443 ProgramStateRef assumeSymNE(ProgramStateRef State, SymbolRef Sym, 1444 const llvm::APSInt &V, 1445 const llvm::APSInt &Adjustment) override; 1446 1447 ProgramStateRef assumeSymEQ(ProgramStateRef State, SymbolRef Sym, 1448 const llvm::APSInt &V, 1449 const llvm::APSInt &Adjustment) override; 1450 1451 ProgramStateRef assumeSymLT(ProgramStateRef State, SymbolRef Sym, 1452 const llvm::APSInt &V, 1453 const llvm::APSInt &Adjustment) override; 1454 1455 ProgramStateRef assumeSymGT(ProgramStateRef State, SymbolRef Sym, 1456 const llvm::APSInt &V, 1457 const llvm::APSInt &Adjustment) override; 1458 1459 ProgramStateRef assumeSymLE(ProgramStateRef State, SymbolRef Sym, 1460 const llvm::APSInt &V, 1461 const llvm::APSInt &Adjustment) override; 1462 1463 ProgramStateRef assumeSymGE(ProgramStateRef State, SymbolRef Sym, 1464 const llvm::APSInt &V, 1465 const llvm::APSInt &Adjustment) override; 1466 1467 ProgramStateRef assumeSymWithinInclusiveRange( 1468 ProgramStateRef State, SymbolRef Sym, const llvm::APSInt &From, 1469 const llvm::APSInt &To, const llvm::APSInt &Adjustment) override; 1470 1471 ProgramStateRef assumeSymOutsideInclusiveRange( 1472 ProgramStateRef State, SymbolRef Sym, const llvm::APSInt &From, 1473 const llvm::APSInt &To, const llvm::APSInt &Adjustment) override; 1474 1475 private: 1476 RangeSet::Factory F; 1477 1478 RangeSet getRange(ProgramStateRef State, SymbolRef Sym); 1479 RangeSet getRange(ProgramStateRef State, EquivalenceClass Class); 1480 ProgramStateRef setRange(ProgramStateRef State, SymbolRef Sym, 1481 RangeSet Range); 1482 ProgramStateRef setRange(ProgramStateRef State, EquivalenceClass Class, 1483 RangeSet Range); 1484 1485 RangeSet getSymLTRange(ProgramStateRef St, SymbolRef Sym, 1486 const llvm::APSInt &Int, 1487 const llvm::APSInt &Adjustment); 1488 RangeSet getSymGTRange(ProgramStateRef St, SymbolRef Sym, 1489 const llvm::APSInt &Int, 1490 const llvm::APSInt &Adjustment); 1491 RangeSet getSymLERange(ProgramStateRef St, SymbolRef Sym, 1492 const llvm::APSInt &Int, 1493 const llvm::APSInt &Adjustment); 1494 RangeSet getSymLERange(llvm::function_ref<RangeSet()> RS, 1495 const llvm::APSInt &Int, 1496 const llvm::APSInt &Adjustment); 1497 RangeSet getSymGERange(ProgramStateRef St, SymbolRef Sym, 1498 const llvm::APSInt &Int, 1499 const llvm::APSInt &Adjustment); 1500 }; 1501 1502 //===----------------------------------------------------------------------===// 1503 // Constraint assignment logic 1504 //===----------------------------------------------------------------------===// 1505 1506 /// ConstraintAssignorBase is a small utility class that unifies visitor 1507 /// for ranges with a visitor for constraints (rangeset/range/constant). 1508 /// 1509 /// It is designed to have one derived class, but generally it can have more. 1510 /// Derived class can control which types we handle by defining methods of the 1511 /// following form: 1512 /// 1513 /// bool handle${SYMBOL}To${CONSTRAINT}(const SYMBOL *Sym, 1514 /// CONSTRAINT Constraint); 1515 /// 1516 /// where SYMBOL is the type of the symbol (e.g. SymSymExpr, SymbolCast, etc.) 1517 /// CONSTRAINT is the type of constraint (RangeSet/Range/Const) 1518 /// return value signifies whether we should try other handle methods 1519 /// (i.e. false would mean to stop right after calling this method) 1520 template <class Derived> class ConstraintAssignorBase { 1521 public: 1522 using Const = const llvm::APSInt &; 1523 1524 #define DISPATCH(CLASS) return assign##CLASS##Impl(cast<CLASS>(Sym), Constraint) 1525 1526 #define ASSIGN(CLASS, TO, SYM, CONSTRAINT) \ 1527 if (!static_cast<Derived *>(this)->assign##CLASS##To##TO(SYM, CONSTRAINT)) \ 1528 return false 1529 1530 void assign(SymbolRef Sym, RangeSet Constraint) { 1531 assignImpl(Sym, Constraint); 1532 } 1533 1534 bool assignImpl(SymbolRef Sym, RangeSet Constraint) { 1535 switch (Sym->getKind()) { 1536 #define SYMBOL(Id, Parent) \ 1537 case SymExpr::Id##Kind: \ 1538 DISPATCH(Id); 1539 #include "clang/StaticAnalyzer/Core/PathSensitive/Symbols.def" 1540 } 1541 llvm_unreachable("Unknown SymExpr kind!"); 1542 } 1543 1544 #define DEFAULT_ASSIGN(Id) \ 1545 bool assign##Id##To##RangeSet(const Id *Sym, RangeSet Constraint) { \ 1546 return true; \ 1547 } \ 1548 bool assign##Id##To##Range(const Id *Sym, Range Constraint) { return true; } \ 1549 bool assign##Id##To##Const(const Id *Sym, Const Constraint) { return true; } 1550 1551 // When we dispatch for constraint types, we first try to check 1552 // if the new constraint is the constant and try the corresponding 1553 // assignor methods. If it didn't interrupt, we can proceed to the 1554 // range, and finally to the range set. 1555 #define CONSTRAINT_DISPATCH(Id) \ 1556 if (const llvm::APSInt *Const = Constraint.getConcreteValue()) { \ 1557 ASSIGN(Id, Const, Sym, *Const); \ 1558 } \ 1559 if (Constraint.size() == 1) { \ 1560 ASSIGN(Id, Range, Sym, *Constraint.begin()); \ 1561 } \ 1562 ASSIGN(Id, RangeSet, Sym, Constraint) 1563 1564 // Our internal assign method first tries to call assignor methods for all 1565 // constraint types that apply. And if not interrupted, continues with its 1566 // parent class. 1567 #define SYMBOL(Id, Parent) \ 1568 bool assign##Id##Impl(const Id *Sym, RangeSet Constraint) { \ 1569 CONSTRAINT_DISPATCH(Id); \ 1570 DISPATCH(Parent); \ 1571 } \ 1572 DEFAULT_ASSIGN(Id) 1573 #define ABSTRACT_SYMBOL(Id, Parent) SYMBOL(Id, Parent) 1574 #include "clang/StaticAnalyzer/Core/PathSensitive/Symbols.def" 1575 1576 // Default implementations for the top class that doesn't have parents. 1577 bool assignSymExprImpl(const SymExpr *Sym, RangeSet Constraint) { 1578 CONSTRAINT_DISPATCH(SymExpr); 1579 return true; 1580 } 1581 DEFAULT_ASSIGN(SymExpr); 1582 1583 #undef DISPATCH 1584 #undef CONSTRAINT_DISPATCH 1585 #undef DEFAULT_ASSIGN 1586 #undef ASSIGN 1587 }; 1588 1589 /// A little component aggregating all of the reasoning we have about 1590 /// assigning new constraints to symbols. 1591 /// 1592 /// The main purpose of this class is to associate constraints to symbols, 1593 /// and impose additional constraints on other symbols, when we can imply 1594 /// them. 1595 /// 1596 /// It has a nice symmetry with SymbolicRangeInferrer. When the latter 1597 /// can provide more precise ranges by looking into the operands of the 1598 /// expression in question, ConstraintAssignor looks into the operands 1599 /// to see if we can imply more from the new constraint. 1600 class ConstraintAssignor : public ConstraintAssignorBase<ConstraintAssignor> { 1601 public: 1602 template <class ClassOrSymbol> 1603 LLVM_NODISCARD static ProgramStateRef 1604 assign(ProgramStateRef State, SValBuilder &Builder, RangeSet::Factory &F, 1605 ClassOrSymbol CoS, RangeSet NewConstraint) { 1606 if (!State || NewConstraint.isEmpty()) 1607 return nullptr; 1608 1609 ConstraintAssignor Assignor{State, Builder, F}; 1610 return Assignor.assign(CoS, NewConstraint); 1611 } 1612 1613 /// Handle expressions like: a % b != 0. 1614 template <typename SymT> 1615 bool handleRemainderOp(const SymT *Sym, RangeSet Constraint) { 1616 if (Sym->getOpcode() != BO_Rem) 1617 return true; 1618 // a % b != 0 implies that a != 0. 1619 if (!Constraint.containsZero()) { 1620 SVal SymSVal = Builder.makeSymbolVal(Sym->getLHS()); 1621 if (auto NonLocSymSVal = SymSVal.getAs<nonloc::SymbolVal>()) { 1622 State = State->assume(*NonLocSymSVal, true); 1623 if (!State) 1624 return false; 1625 } 1626 } 1627 return true; 1628 } 1629 1630 inline bool assignSymExprToConst(const SymExpr *Sym, Const Constraint); 1631 inline bool assignSymIntExprToRangeSet(const SymIntExpr *Sym, 1632 RangeSet Constraint) { 1633 return handleRemainderOp(Sym, Constraint); 1634 } 1635 inline bool assignSymSymExprToRangeSet(const SymSymExpr *Sym, 1636 RangeSet Constraint); 1637 1638 private: 1639 ConstraintAssignor(ProgramStateRef State, SValBuilder &Builder, 1640 RangeSet::Factory &F) 1641 : State(State), Builder(Builder), RangeFactory(F) {} 1642 using Base = ConstraintAssignorBase<ConstraintAssignor>; 1643 1644 /// Base method for handling new constraints for symbols. 1645 LLVM_NODISCARD ProgramStateRef assign(SymbolRef Sym, RangeSet NewConstraint) { 1646 // All constraints are actually associated with equivalence classes, and 1647 // that's what we are going to do first. 1648 State = assign(EquivalenceClass::find(State, Sym), NewConstraint); 1649 if (!State) 1650 return nullptr; 1651 1652 // And after that we can check what other things we can get from this 1653 // constraint. 1654 Base::assign(Sym, NewConstraint); 1655 return State; 1656 } 1657 1658 /// Base method for handling new constraints for classes. 1659 LLVM_NODISCARD ProgramStateRef assign(EquivalenceClass Class, 1660 RangeSet NewConstraint) { 1661 // There is a chance that we might need to update constraints for the 1662 // classes that are known to be disequal to Class. 1663 // 1664 // In order for this to be even possible, the new constraint should 1665 // be simply a constant because we can't reason about range disequalities. 1666 if (const llvm::APSInt *Point = NewConstraint.getConcreteValue()) { 1667 1668 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 1669 ConstraintRangeTy::Factory &CF = State->get_context<ConstraintRange>(); 1670 1671 // Add new constraint. 1672 Constraints = CF.add(Constraints, Class, NewConstraint); 1673 1674 for (EquivalenceClass DisequalClass : Class.getDisequalClasses(State)) { 1675 RangeSet UpdatedConstraint = SymbolicRangeInferrer::inferRange( 1676 RangeFactory, State, DisequalClass); 1677 1678 UpdatedConstraint = RangeFactory.deletePoint(UpdatedConstraint, *Point); 1679 1680 // If we end up with at least one of the disequal classes to be 1681 // constrained with an empty range-set, the state is infeasible. 1682 if (UpdatedConstraint.isEmpty()) 1683 return nullptr; 1684 1685 Constraints = CF.add(Constraints, DisequalClass, UpdatedConstraint); 1686 } 1687 assert(areFeasible(Constraints) && "Constraint manager shouldn't produce " 1688 "a state with infeasible constraints"); 1689 1690 return setConstraints(State, Constraints); 1691 } 1692 1693 return setConstraint(State, Class, NewConstraint); 1694 } 1695 1696 ProgramStateRef trackDisequality(ProgramStateRef State, SymbolRef LHS, 1697 SymbolRef RHS) { 1698 return EquivalenceClass::markDisequal(RangeFactory, State, LHS, RHS); 1699 } 1700 1701 ProgramStateRef trackEquality(ProgramStateRef State, SymbolRef LHS, 1702 SymbolRef RHS) { 1703 return EquivalenceClass::merge(RangeFactory, State, LHS, RHS); 1704 } 1705 1706 LLVM_NODISCARD Optional<bool> interpreteAsBool(RangeSet Constraint) { 1707 assert(!Constraint.isEmpty() && "Empty ranges shouldn't get here"); 1708 1709 if (Constraint.getConcreteValue()) 1710 return !Constraint.getConcreteValue()->isZero(); 1711 1712 if (!Constraint.containsZero()) 1713 return true; 1714 1715 return llvm::None; 1716 } 1717 1718 ProgramStateRef State; 1719 SValBuilder &Builder; 1720 RangeSet::Factory &RangeFactory; 1721 }; 1722 1723 1724 bool ConstraintAssignor::assignSymExprToConst(const SymExpr *Sym, 1725 const llvm::APSInt &Constraint) { 1726 llvm::SmallSet<EquivalenceClass, 4> SimplifiedClasses; 1727 // Iterate over all equivalence classes and try to simplify them. 1728 ClassMembersTy Members = State->get<ClassMembers>(); 1729 for (std::pair<EquivalenceClass, SymbolSet> ClassToSymbolSet : Members) { 1730 EquivalenceClass Class = ClassToSymbolSet.first; 1731 State = EquivalenceClass::simplify(Builder, RangeFactory, State, Class); 1732 if (!State) 1733 return false; 1734 SimplifiedClasses.insert(Class); 1735 } 1736 1737 // Trivial equivalence classes (those that have only one symbol member) are 1738 // not stored in the State. Thus, we must skim through the constraints as 1739 // well. And we try to simplify symbols in the constraints. 1740 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 1741 for (std::pair<EquivalenceClass, RangeSet> ClassConstraint : Constraints) { 1742 EquivalenceClass Class = ClassConstraint.first; 1743 if (SimplifiedClasses.count(Class)) // Already simplified. 1744 continue; 1745 State = EquivalenceClass::simplify(Builder, RangeFactory, State, Class); 1746 if (!State) 1747 return false; 1748 } 1749 1750 // We may have trivial equivalence classes in the disequality info as 1751 // well, and we need to simplify them. 1752 DisequalityMapTy DisequalityInfo = State->get<DisequalityMap>(); 1753 for (std::pair<EquivalenceClass, ClassSet> DisequalityEntry : 1754 DisequalityInfo) { 1755 EquivalenceClass Class = DisequalityEntry.first; 1756 ClassSet DisequalClasses = DisequalityEntry.second; 1757 State = EquivalenceClass::simplify(Builder, RangeFactory, State, Class); 1758 if (!State) 1759 return false; 1760 } 1761 1762 return true; 1763 } 1764 1765 bool ConstraintAssignor::assignSymSymExprToRangeSet(const SymSymExpr *Sym, 1766 RangeSet Constraint) { 1767 if (!handleRemainderOp(Sym, Constraint)) 1768 return false; 1769 1770 Optional<bool> ConstraintAsBool = interpreteAsBool(Constraint); 1771 1772 if (!ConstraintAsBool) 1773 return true; 1774 1775 if (Optional<bool> Equality = meansEquality(Sym)) { 1776 // Here we cover two cases: 1777 // * if Sym is equality and the new constraint is true -> Sym's operands 1778 // should be marked as equal 1779 // * if Sym is disequality and the new constraint is false -> Sym's 1780 // operands should be also marked as equal 1781 if (*Equality == *ConstraintAsBool) { 1782 State = trackEquality(State, Sym->getLHS(), Sym->getRHS()); 1783 } else { 1784 // Other combinations leave as with disequal operands. 1785 State = trackDisequality(State, Sym->getLHS(), Sym->getRHS()); 1786 } 1787 1788 if (!State) 1789 return false; 1790 } 1791 1792 return true; 1793 } 1794 1795 } // end anonymous namespace 1796 1797 std::unique_ptr<ConstraintManager> 1798 ento::CreateRangeConstraintManager(ProgramStateManager &StMgr, 1799 ExprEngine *Eng) { 1800 return std::make_unique<RangeConstraintManager>(Eng, StMgr.getSValBuilder()); 1801 } 1802 1803 ConstraintMap ento::getConstraintMap(ProgramStateRef State) { 1804 ConstraintMap::Factory &F = State->get_context<ConstraintMap>(); 1805 ConstraintMap Result = F.getEmptyMap(); 1806 1807 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 1808 for (std::pair<EquivalenceClass, RangeSet> ClassConstraint : Constraints) { 1809 EquivalenceClass Class = ClassConstraint.first; 1810 SymbolSet ClassMembers = Class.getClassMembers(State); 1811 assert(!ClassMembers.isEmpty() && 1812 "Class must always have at least one member!"); 1813 1814 SymbolRef Representative = *ClassMembers.begin(); 1815 Result = F.add(Result, Representative, ClassConstraint.second); 1816 } 1817 1818 return Result; 1819 } 1820 1821 //===----------------------------------------------------------------------===// 1822 // EqualityClass implementation details 1823 //===----------------------------------------------------------------------===// 1824 1825 LLVM_DUMP_METHOD void EquivalenceClass::dumpToStream(ProgramStateRef State, 1826 raw_ostream &os) const { 1827 SymbolSet ClassMembers = getClassMembers(State); 1828 for (const SymbolRef &MemberSym : ClassMembers) { 1829 MemberSym->dump(); 1830 os << "\n"; 1831 } 1832 } 1833 1834 inline EquivalenceClass EquivalenceClass::find(ProgramStateRef State, 1835 SymbolRef Sym) { 1836 assert(State && "State should not be null"); 1837 assert(Sym && "Symbol should not be null"); 1838 // We store far from all Symbol -> Class mappings 1839 if (const EquivalenceClass *NontrivialClass = State->get<ClassMap>(Sym)) 1840 return *NontrivialClass; 1841 1842 // This is a trivial class of Sym. 1843 return Sym; 1844 } 1845 1846 inline ProgramStateRef EquivalenceClass::merge(RangeSet::Factory &F, 1847 ProgramStateRef State, 1848 SymbolRef First, 1849 SymbolRef Second) { 1850 EquivalenceClass FirstClass = find(State, First); 1851 EquivalenceClass SecondClass = find(State, Second); 1852 1853 return FirstClass.merge(F, State, SecondClass); 1854 } 1855 1856 inline ProgramStateRef EquivalenceClass::merge(RangeSet::Factory &F, 1857 ProgramStateRef State, 1858 EquivalenceClass Other) { 1859 // It is already the same class. 1860 if (*this == Other) 1861 return State; 1862 1863 // FIXME: As of now, we support only equivalence classes of the same type. 1864 // This limitation is connected to the lack of explicit casts in 1865 // our symbolic expression model. 1866 // 1867 // That means that for `int x` and `char y` we don't distinguish 1868 // between these two very different cases: 1869 // * `x == y` 1870 // * `(char)x == y` 1871 // 1872 // The moment we introduce symbolic casts, this restriction can be 1873 // lifted. 1874 if (getType() != Other.getType()) 1875 return State; 1876 1877 SymbolSet Members = getClassMembers(State); 1878 SymbolSet OtherMembers = Other.getClassMembers(State); 1879 1880 // We estimate the size of the class by the height of tree containing 1881 // its members. Merging is not a trivial operation, so it's easier to 1882 // merge the smaller class into the bigger one. 1883 if (Members.getHeight() >= OtherMembers.getHeight()) { 1884 return mergeImpl(F, State, Members, Other, OtherMembers); 1885 } else { 1886 return Other.mergeImpl(F, State, OtherMembers, *this, Members); 1887 } 1888 } 1889 1890 inline ProgramStateRef 1891 EquivalenceClass::mergeImpl(RangeSet::Factory &RangeFactory, 1892 ProgramStateRef State, SymbolSet MyMembers, 1893 EquivalenceClass Other, SymbolSet OtherMembers) { 1894 // Essentially what we try to recreate here is some kind of union-find 1895 // data structure. It does have certain limitations due to persistence 1896 // and the need to remove elements from classes. 1897 // 1898 // In this setting, EquialityClass object is the representative of the class 1899 // or the parent element. ClassMap is a mapping of class members to their 1900 // parent. Unlike the union-find structure, they all point directly to the 1901 // class representative because we don't have an opportunity to actually do 1902 // path compression when dealing with immutability. This means that we 1903 // compress paths every time we do merges. It also means that we lose 1904 // the main amortized complexity benefit from the original data structure. 1905 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 1906 ConstraintRangeTy::Factory &CRF = State->get_context<ConstraintRange>(); 1907 1908 // 1. If the merged classes have any constraints associated with them, we 1909 // need to transfer them to the class we have left. 1910 // 1911 // Intersection here makes perfect sense because both of these constraints 1912 // must hold for the whole new class. 1913 if (Optional<RangeSet> NewClassConstraint = 1914 intersect(RangeFactory, getConstraint(State, *this), 1915 getConstraint(State, Other))) { 1916 // NOTE: Essentially, NewClassConstraint should NEVER be infeasible because 1917 // range inferrer shouldn't generate ranges incompatible with 1918 // equivalence classes. However, at the moment, due to imperfections 1919 // in the solver, it is possible and the merge function can also 1920 // return infeasible states aka null states. 1921 if (NewClassConstraint->isEmpty()) 1922 // Infeasible state 1923 return nullptr; 1924 1925 // No need in tracking constraints of a now-dissolved class. 1926 Constraints = CRF.remove(Constraints, Other); 1927 // Assign new constraints for this class. 1928 Constraints = CRF.add(Constraints, *this, *NewClassConstraint); 1929 1930 assert(areFeasible(Constraints) && "Constraint manager shouldn't produce " 1931 "a state with infeasible constraints"); 1932 1933 State = State->set<ConstraintRange>(Constraints); 1934 } 1935 1936 // 2. Get ALL equivalence-related maps 1937 ClassMapTy Classes = State->get<ClassMap>(); 1938 ClassMapTy::Factory &CMF = State->get_context<ClassMap>(); 1939 1940 ClassMembersTy Members = State->get<ClassMembers>(); 1941 ClassMembersTy::Factory &MF = State->get_context<ClassMembers>(); 1942 1943 DisequalityMapTy DisequalityInfo = State->get<DisequalityMap>(); 1944 DisequalityMapTy::Factory &DF = State->get_context<DisequalityMap>(); 1945 1946 ClassSet::Factory &CF = State->get_context<ClassSet>(); 1947 SymbolSet::Factory &F = getMembersFactory(State); 1948 1949 // 2. Merge members of the Other class into the current class. 1950 SymbolSet NewClassMembers = MyMembers; 1951 for (SymbolRef Sym : OtherMembers) { 1952 NewClassMembers = F.add(NewClassMembers, Sym); 1953 // *this is now the class for all these new symbols. 1954 Classes = CMF.add(Classes, Sym, *this); 1955 } 1956 1957 // 3. Adjust member mapping. 1958 // 1959 // No need in tracking members of a now-dissolved class. 1960 Members = MF.remove(Members, Other); 1961 // Now only the current class is mapped to all the symbols. 1962 Members = MF.add(Members, *this, NewClassMembers); 1963 1964 // 4. Update disequality relations 1965 ClassSet DisequalToOther = Other.getDisequalClasses(DisequalityInfo, CF); 1966 // We are about to merge two classes but they are already known to be 1967 // non-equal. This is a contradiction. 1968 if (DisequalToOther.contains(*this)) 1969 return nullptr; 1970 1971 if (!DisequalToOther.isEmpty()) { 1972 ClassSet DisequalToThis = getDisequalClasses(DisequalityInfo, CF); 1973 DisequalityInfo = DF.remove(DisequalityInfo, Other); 1974 1975 for (EquivalenceClass DisequalClass : DisequalToOther) { 1976 DisequalToThis = CF.add(DisequalToThis, DisequalClass); 1977 1978 // Disequality is a symmetric relation meaning that if 1979 // DisequalToOther not null then the set for DisequalClass is not 1980 // empty and has at least Other. 1981 ClassSet OriginalSetLinkedToOther = 1982 *DisequalityInfo.lookup(DisequalClass); 1983 1984 // Other will be eliminated and we should replace it with the bigger 1985 // united class. 1986 ClassSet NewSet = CF.remove(OriginalSetLinkedToOther, Other); 1987 NewSet = CF.add(NewSet, *this); 1988 1989 DisequalityInfo = DF.add(DisequalityInfo, DisequalClass, NewSet); 1990 } 1991 1992 DisequalityInfo = DF.add(DisequalityInfo, *this, DisequalToThis); 1993 State = State->set<DisequalityMap>(DisequalityInfo); 1994 } 1995 1996 // 5. Update the state 1997 State = State->set<ClassMap>(Classes); 1998 State = State->set<ClassMembers>(Members); 1999 2000 return State; 2001 } 2002 2003 inline SymbolSet::Factory & 2004 EquivalenceClass::getMembersFactory(ProgramStateRef State) { 2005 return State->get_context<SymbolSet>(); 2006 } 2007 2008 SymbolSet EquivalenceClass::getClassMembers(ProgramStateRef State) const { 2009 if (const SymbolSet *Members = State->get<ClassMembers>(*this)) 2010 return *Members; 2011 2012 // This class is trivial, so we need to construct a set 2013 // with just that one symbol from the class. 2014 SymbolSet::Factory &F = getMembersFactory(State); 2015 return F.add(F.getEmptySet(), getRepresentativeSymbol()); 2016 } 2017 2018 bool EquivalenceClass::isTrivial(ProgramStateRef State) const { 2019 return State->get<ClassMembers>(*this) == nullptr; 2020 } 2021 2022 bool EquivalenceClass::isTriviallyDead(ProgramStateRef State, 2023 SymbolReaper &Reaper) const { 2024 return isTrivial(State) && Reaper.isDead(getRepresentativeSymbol()); 2025 } 2026 2027 inline ProgramStateRef EquivalenceClass::markDisequal(RangeSet::Factory &RF, 2028 ProgramStateRef State, 2029 SymbolRef First, 2030 SymbolRef Second) { 2031 return markDisequal(RF, State, find(State, First), find(State, Second)); 2032 } 2033 2034 inline ProgramStateRef EquivalenceClass::markDisequal(RangeSet::Factory &RF, 2035 ProgramStateRef State, 2036 EquivalenceClass First, 2037 EquivalenceClass Second) { 2038 return First.markDisequal(RF, State, Second); 2039 } 2040 2041 inline ProgramStateRef 2042 EquivalenceClass::markDisequal(RangeSet::Factory &RF, ProgramStateRef State, 2043 EquivalenceClass Other) const { 2044 // If we know that two classes are equal, we can only produce an infeasible 2045 // state. 2046 if (*this == Other) { 2047 return nullptr; 2048 } 2049 2050 DisequalityMapTy DisequalityInfo = State->get<DisequalityMap>(); 2051 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 2052 2053 // Disequality is a symmetric relation, so if we mark A as disequal to B, 2054 // we should also mark B as disequalt to A. 2055 if (!addToDisequalityInfo(DisequalityInfo, Constraints, RF, State, *this, 2056 Other) || 2057 !addToDisequalityInfo(DisequalityInfo, Constraints, RF, State, Other, 2058 *this)) 2059 return nullptr; 2060 2061 assert(areFeasible(Constraints) && "Constraint manager shouldn't produce " 2062 "a state with infeasible constraints"); 2063 2064 State = State->set<DisequalityMap>(DisequalityInfo); 2065 State = State->set<ConstraintRange>(Constraints); 2066 2067 return State; 2068 } 2069 2070 inline bool EquivalenceClass::addToDisequalityInfo( 2071 DisequalityMapTy &Info, ConstraintRangeTy &Constraints, 2072 RangeSet::Factory &RF, ProgramStateRef State, EquivalenceClass First, 2073 EquivalenceClass Second) { 2074 2075 // 1. Get all of the required factories. 2076 DisequalityMapTy::Factory &F = State->get_context<DisequalityMap>(); 2077 ClassSet::Factory &CF = State->get_context<ClassSet>(); 2078 ConstraintRangeTy::Factory &CRF = State->get_context<ConstraintRange>(); 2079 2080 // 2. Add Second to the set of classes disequal to First. 2081 const ClassSet *CurrentSet = Info.lookup(First); 2082 ClassSet NewSet = CurrentSet ? *CurrentSet : CF.getEmptySet(); 2083 NewSet = CF.add(NewSet, Second); 2084 2085 Info = F.add(Info, First, NewSet); 2086 2087 // 3. If Second is known to be a constant, we can delete this point 2088 // from the constraint asociated with First. 2089 // 2090 // So, if Second == 10, it means that First != 10. 2091 // At the same time, the same logic does not apply to ranges. 2092 if (const RangeSet *SecondConstraint = Constraints.lookup(Second)) 2093 if (const llvm::APSInt *Point = SecondConstraint->getConcreteValue()) { 2094 2095 RangeSet FirstConstraint = SymbolicRangeInferrer::inferRange( 2096 RF, State, First.getRepresentativeSymbol()); 2097 2098 FirstConstraint = RF.deletePoint(FirstConstraint, *Point); 2099 2100 // If the First class is about to be constrained with an empty 2101 // range-set, the state is infeasible. 2102 if (FirstConstraint.isEmpty()) 2103 return false; 2104 2105 Constraints = CRF.add(Constraints, First, FirstConstraint); 2106 } 2107 2108 return true; 2109 } 2110 2111 inline Optional<bool> EquivalenceClass::areEqual(ProgramStateRef State, 2112 SymbolRef FirstSym, 2113 SymbolRef SecondSym) { 2114 return EquivalenceClass::areEqual(State, find(State, FirstSym), 2115 find(State, SecondSym)); 2116 } 2117 2118 inline Optional<bool> EquivalenceClass::areEqual(ProgramStateRef State, 2119 EquivalenceClass First, 2120 EquivalenceClass Second) { 2121 // The same equivalence class => symbols are equal. 2122 if (First == Second) 2123 return true; 2124 2125 // Let's check if we know anything about these two classes being not equal to 2126 // each other. 2127 ClassSet DisequalToFirst = First.getDisequalClasses(State); 2128 if (DisequalToFirst.contains(Second)) 2129 return false; 2130 2131 // It is not clear. 2132 return llvm::None; 2133 } 2134 2135 // Re-evaluate an SVal with top-level `State->assume` logic. 2136 LLVM_NODISCARD ProgramStateRef reAssume(ProgramStateRef State, 2137 const RangeSet *Constraint, 2138 SVal TheValue) { 2139 if (!Constraint) 2140 return State; 2141 2142 const auto DefinedVal = TheValue.castAs<DefinedSVal>(); 2143 2144 // If the SVal is 0, we can simply interpret that as `false`. 2145 if (Constraint->encodesFalseRange()) 2146 return State->assume(DefinedVal, false); 2147 2148 // If the constraint does not encode 0 then we can interpret that as `true` 2149 // AND as a Range(Set). 2150 if (Constraint->encodesTrueRange()) { 2151 State = State->assume(DefinedVal, true); 2152 if (!State) 2153 return nullptr; 2154 // Fall through, re-assume based on the range values as well. 2155 } 2156 // Overestimate the individual Ranges with the RangeSet' lowest and 2157 // highest values. 2158 return State->assumeInclusiveRange(DefinedVal, Constraint->getMinValue(), 2159 Constraint->getMaxValue(), true); 2160 } 2161 2162 // Iterate over all symbols and try to simplify them. Once a symbol is 2163 // simplified then we check if we can merge the simplified symbol's equivalence 2164 // class to this class. This way, we simplify not just the symbols but the 2165 // classes as well: we strive to keep the number of the classes to be the 2166 // absolute minimum. 2167 LLVM_NODISCARD ProgramStateRef 2168 EquivalenceClass::simplify(SValBuilder &SVB, RangeSet::Factory &F, 2169 ProgramStateRef State, EquivalenceClass Class) { 2170 SymbolSet ClassMembers = Class.getClassMembers(State); 2171 for (const SymbolRef &MemberSym : ClassMembers) { 2172 2173 const SVal SimplifiedMemberVal = simplifyToSVal(State, MemberSym); 2174 const SymbolRef SimplifiedMemberSym = SimplifiedMemberVal.getAsSymbol(); 2175 2176 // The symbol is collapsed to a constant, check if the current State is 2177 // still feasible. 2178 if (const auto CI = SimplifiedMemberVal.getAs<nonloc::ConcreteInt>()) { 2179 const llvm::APSInt &SV = CI->getValue(); 2180 const RangeSet *ClassConstraint = getConstraint(State, Class); 2181 // We have found a contradiction. 2182 if (ClassConstraint && !ClassConstraint->contains(SV)) 2183 return nullptr; 2184 } 2185 2186 if (SimplifiedMemberSym && MemberSym != SimplifiedMemberSym) { 2187 // The simplified symbol should be the member of the original Class, 2188 // however, it might be in another existing class at the moment. We 2189 // have to merge these classes. 2190 ProgramStateRef OldState = State; 2191 State = merge(F, State, MemberSym, SimplifiedMemberSym); 2192 if (!State) 2193 return nullptr; 2194 // No state change, no merge happened actually. 2195 if (OldState == State) 2196 continue; 2197 2198 assert(find(State, MemberSym) == find(State, SimplifiedMemberSym)); 2199 2200 // Query the class constraint again b/c that may have changed during the 2201 // merge above. 2202 const RangeSet *ClassConstraint = getConstraint(State, Class); 2203 2204 // Re-evaluate an SVal with top-level `State->assume`, this ignites 2205 // a RECURSIVE algorithm that will reach a FIXPOINT. 2206 // 2207 // About performance and complexity: Let us assume that in a State we 2208 // have N non-trivial equivalence classes and that all constraints and 2209 // disequality info is related to non-trivial classes. In the worst case, 2210 // we can simplify only one symbol of one class in each iteration. 2211 // 2212 // The number of the equivalence classes can decrease only, because the 2213 // algorithm does a merge operation optionally. 2214 // ASSUMPTION G: Let us assume that the 2215 // number of symbols in one class cannot grow because we replace the old 2216 // symbol with the simplified one. 2217 // If assumption G holds then we need N iterations in this case to reach 2218 // the fixpoint. Thus, the steps needed to be done in the worst case is 2219 // proportional to N*N. 2220 // This worst case scenario can be extended to that case when we have 2221 // trivial classes in the constraints and in the disequality map. This 2222 // case can be reduced to the case with a State where there are only 2223 // non-trivial classes. This is because a merge operation on two trivial 2224 // classes results in one non-trivial class. 2225 // 2226 // Empirical measurements show that if we relax assumption G (i.e. if we 2227 // do not replace the complex symbol just add the simplified one) then 2228 // the runtime and memory consumption does not grow noticeably. 2229 State = reAssume(State, ClassConstraint, SimplifiedMemberVal); 2230 if (!State) 2231 return nullptr; 2232 } 2233 } 2234 return State; 2235 } 2236 2237 inline ClassSet EquivalenceClass::getDisequalClasses(ProgramStateRef State, 2238 SymbolRef Sym) { 2239 return find(State, Sym).getDisequalClasses(State); 2240 } 2241 2242 inline ClassSet 2243 EquivalenceClass::getDisequalClasses(ProgramStateRef State) const { 2244 return getDisequalClasses(State->get<DisequalityMap>(), 2245 State->get_context<ClassSet>()); 2246 } 2247 2248 inline ClassSet 2249 EquivalenceClass::getDisequalClasses(DisequalityMapTy Map, 2250 ClassSet::Factory &Factory) const { 2251 if (const ClassSet *DisequalClasses = Map.lookup(*this)) 2252 return *DisequalClasses; 2253 2254 return Factory.getEmptySet(); 2255 } 2256 2257 bool EquivalenceClass::isClassDataConsistent(ProgramStateRef State) { 2258 ClassMembersTy Members = State->get<ClassMembers>(); 2259 2260 for (std::pair<EquivalenceClass, SymbolSet> ClassMembersPair : Members) { 2261 for (SymbolRef Member : ClassMembersPair.second) { 2262 // Every member of the class should have a mapping back to the class. 2263 if (find(State, Member) == ClassMembersPair.first) { 2264 continue; 2265 } 2266 2267 return false; 2268 } 2269 } 2270 2271 DisequalityMapTy Disequalities = State->get<DisequalityMap>(); 2272 for (std::pair<EquivalenceClass, ClassSet> DisequalityInfo : Disequalities) { 2273 EquivalenceClass Class = DisequalityInfo.first; 2274 ClassSet DisequalClasses = DisequalityInfo.second; 2275 2276 // There is no use in keeping empty sets in the map. 2277 if (DisequalClasses.isEmpty()) 2278 return false; 2279 2280 // Disequality is symmetrical, i.e. for every Class A and B that A != B, 2281 // B != A should also be true. 2282 for (EquivalenceClass DisequalClass : DisequalClasses) { 2283 const ClassSet *DisequalToDisequalClasses = 2284 Disequalities.lookup(DisequalClass); 2285 2286 // It should be a set of at least one element: Class 2287 if (!DisequalToDisequalClasses || 2288 !DisequalToDisequalClasses->contains(Class)) 2289 return false; 2290 } 2291 } 2292 2293 return true; 2294 } 2295 2296 //===----------------------------------------------------------------------===// 2297 // RangeConstraintManager implementation 2298 //===----------------------------------------------------------------------===// 2299 2300 bool RangeConstraintManager::canReasonAbout(SVal X) const { 2301 Optional<nonloc::SymbolVal> SymVal = X.getAs<nonloc::SymbolVal>(); 2302 if (SymVal && SymVal->isExpression()) { 2303 const SymExpr *SE = SymVal->getSymbol(); 2304 2305 if (const SymIntExpr *SIE = dyn_cast<SymIntExpr>(SE)) { 2306 switch (SIE->getOpcode()) { 2307 // We don't reason yet about bitwise-constraints on symbolic values. 2308 case BO_And: 2309 case BO_Or: 2310 case BO_Xor: 2311 return false; 2312 // We don't reason yet about these arithmetic constraints on 2313 // symbolic values. 2314 case BO_Mul: 2315 case BO_Div: 2316 case BO_Rem: 2317 case BO_Shl: 2318 case BO_Shr: 2319 return false; 2320 // All other cases. 2321 default: 2322 return true; 2323 } 2324 } 2325 2326 if (const SymSymExpr *SSE = dyn_cast<SymSymExpr>(SE)) { 2327 // FIXME: Handle <=> here. 2328 if (BinaryOperator::isEqualityOp(SSE->getOpcode()) || 2329 BinaryOperator::isRelationalOp(SSE->getOpcode())) { 2330 // We handle Loc <> Loc comparisons, but not (yet) NonLoc <> NonLoc. 2331 // We've recently started producing Loc <> NonLoc comparisons (that 2332 // result from casts of one of the operands between eg. intptr_t and 2333 // void *), but we can't reason about them yet. 2334 if (Loc::isLocType(SSE->getLHS()->getType())) { 2335 return Loc::isLocType(SSE->getRHS()->getType()); 2336 } 2337 } 2338 } 2339 2340 return false; 2341 } 2342 2343 return true; 2344 } 2345 2346 ConditionTruthVal RangeConstraintManager::checkNull(ProgramStateRef State, 2347 SymbolRef Sym) { 2348 const RangeSet *Ranges = getConstraint(State, Sym); 2349 2350 // If we don't have any information about this symbol, it's underconstrained. 2351 if (!Ranges) 2352 return ConditionTruthVal(); 2353 2354 // If we have a concrete value, see if it's zero. 2355 if (const llvm::APSInt *Value = Ranges->getConcreteValue()) 2356 return *Value == 0; 2357 2358 BasicValueFactory &BV = getBasicVals(); 2359 APSIntType IntType = BV.getAPSIntType(Sym->getType()); 2360 llvm::APSInt Zero = IntType.getZeroValue(); 2361 2362 // Check if zero is in the set of possible values. 2363 if (!Ranges->contains(Zero)) 2364 return false; 2365 2366 // Zero is a possible value, but it is not the /only/ possible value. 2367 return ConditionTruthVal(); 2368 } 2369 2370 const llvm::APSInt *RangeConstraintManager::getSymVal(ProgramStateRef St, 2371 SymbolRef Sym) const { 2372 const RangeSet *T = getConstraint(St, Sym); 2373 return T ? T->getConcreteValue() : nullptr; 2374 } 2375 2376 //===----------------------------------------------------------------------===// 2377 // Remove dead symbols from existing constraints 2378 //===----------------------------------------------------------------------===// 2379 2380 /// Scan all symbols referenced by the constraints. If the symbol is not alive 2381 /// as marked in LSymbols, mark it as dead in DSymbols. 2382 ProgramStateRef 2383 RangeConstraintManager::removeDeadBindings(ProgramStateRef State, 2384 SymbolReaper &SymReaper) { 2385 ClassMembersTy ClassMembersMap = State->get<ClassMembers>(); 2386 ClassMembersTy NewClassMembersMap = ClassMembersMap; 2387 ClassMembersTy::Factory &EMFactory = State->get_context<ClassMembers>(); 2388 SymbolSet::Factory &SetFactory = State->get_context<SymbolSet>(); 2389 2390 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 2391 ConstraintRangeTy NewConstraints = Constraints; 2392 ConstraintRangeTy::Factory &ConstraintFactory = 2393 State->get_context<ConstraintRange>(); 2394 2395 ClassMapTy Map = State->get<ClassMap>(); 2396 ClassMapTy NewMap = Map; 2397 ClassMapTy::Factory &ClassFactory = State->get_context<ClassMap>(); 2398 2399 DisequalityMapTy Disequalities = State->get<DisequalityMap>(); 2400 DisequalityMapTy::Factory &DisequalityFactory = 2401 State->get_context<DisequalityMap>(); 2402 ClassSet::Factory &ClassSetFactory = State->get_context<ClassSet>(); 2403 2404 bool ClassMapChanged = false; 2405 bool MembersMapChanged = false; 2406 bool ConstraintMapChanged = false; 2407 bool DisequalitiesChanged = false; 2408 2409 auto removeDeadClass = [&](EquivalenceClass Class) { 2410 // Remove associated constraint ranges. 2411 Constraints = ConstraintFactory.remove(Constraints, Class); 2412 ConstraintMapChanged = true; 2413 2414 // Update disequality information to not hold any information on the 2415 // removed class. 2416 ClassSet DisequalClasses = 2417 Class.getDisequalClasses(Disequalities, ClassSetFactory); 2418 if (!DisequalClasses.isEmpty()) { 2419 for (EquivalenceClass DisequalClass : DisequalClasses) { 2420 ClassSet DisequalToDisequalSet = 2421 DisequalClass.getDisequalClasses(Disequalities, ClassSetFactory); 2422 // DisequalToDisequalSet is guaranteed to be non-empty for consistent 2423 // disequality info. 2424 assert(!DisequalToDisequalSet.isEmpty()); 2425 ClassSet NewSet = ClassSetFactory.remove(DisequalToDisequalSet, Class); 2426 2427 // No need in keeping an empty set. 2428 if (NewSet.isEmpty()) { 2429 Disequalities = 2430 DisequalityFactory.remove(Disequalities, DisequalClass); 2431 } else { 2432 Disequalities = 2433 DisequalityFactory.add(Disequalities, DisequalClass, NewSet); 2434 } 2435 } 2436 // Remove the data for the class 2437 Disequalities = DisequalityFactory.remove(Disequalities, Class); 2438 DisequalitiesChanged = true; 2439 } 2440 }; 2441 2442 // 1. Let's see if dead symbols are trivial and have associated constraints. 2443 for (std::pair<EquivalenceClass, RangeSet> ClassConstraintPair : 2444 Constraints) { 2445 EquivalenceClass Class = ClassConstraintPair.first; 2446 if (Class.isTriviallyDead(State, SymReaper)) { 2447 // If this class is trivial, we can remove its constraints right away. 2448 removeDeadClass(Class); 2449 } 2450 } 2451 2452 // 2. We don't need to track classes for dead symbols. 2453 for (std::pair<SymbolRef, EquivalenceClass> SymbolClassPair : Map) { 2454 SymbolRef Sym = SymbolClassPair.first; 2455 2456 if (SymReaper.isDead(Sym)) { 2457 ClassMapChanged = true; 2458 NewMap = ClassFactory.remove(NewMap, Sym); 2459 } 2460 } 2461 2462 // 3. Remove dead members from classes and remove dead non-trivial classes 2463 // and their constraints. 2464 for (std::pair<EquivalenceClass, SymbolSet> ClassMembersPair : 2465 ClassMembersMap) { 2466 EquivalenceClass Class = ClassMembersPair.first; 2467 SymbolSet LiveMembers = ClassMembersPair.second; 2468 bool MembersChanged = false; 2469 2470 for (SymbolRef Member : ClassMembersPair.second) { 2471 if (SymReaper.isDead(Member)) { 2472 MembersChanged = true; 2473 LiveMembers = SetFactory.remove(LiveMembers, Member); 2474 } 2475 } 2476 2477 // Check if the class changed. 2478 if (!MembersChanged) 2479 continue; 2480 2481 MembersMapChanged = true; 2482 2483 if (LiveMembers.isEmpty()) { 2484 // The class is dead now, we need to wipe it out of the members map... 2485 NewClassMembersMap = EMFactory.remove(NewClassMembersMap, Class); 2486 2487 // ...and remove all of its constraints. 2488 removeDeadClass(Class); 2489 } else { 2490 // We need to change the members associated with the class. 2491 NewClassMembersMap = 2492 EMFactory.add(NewClassMembersMap, Class, LiveMembers); 2493 } 2494 } 2495 2496 // 4. Update the state with new maps. 2497 // 2498 // Here we try to be humble and update a map only if it really changed. 2499 if (ClassMapChanged) 2500 State = State->set<ClassMap>(NewMap); 2501 2502 if (MembersMapChanged) 2503 State = State->set<ClassMembers>(NewClassMembersMap); 2504 2505 if (ConstraintMapChanged) 2506 State = State->set<ConstraintRange>(Constraints); 2507 2508 if (DisequalitiesChanged) 2509 State = State->set<DisequalityMap>(Disequalities); 2510 2511 assert(EquivalenceClass::isClassDataConsistent(State)); 2512 2513 return State; 2514 } 2515 2516 RangeSet RangeConstraintManager::getRange(ProgramStateRef State, 2517 SymbolRef Sym) { 2518 return SymbolicRangeInferrer::inferRange(F, State, Sym); 2519 } 2520 2521 ProgramStateRef RangeConstraintManager::setRange(ProgramStateRef State, 2522 SymbolRef Sym, 2523 RangeSet Range) { 2524 return ConstraintAssignor::assign(State, getSValBuilder(), F, Sym, Range); 2525 } 2526 2527 //===------------------------------------------------------------------------=== 2528 // assumeSymX methods: protected interface for RangeConstraintManager. 2529 //===------------------------------------------------------------------------===/ 2530 2531 // The syntax for ranges below is mathematical, using [x, y] for closed ranges 2532 // and (x, y) for open ranges. These ranges are modular, corresponding with 2533 // a common treatment of C integer overflow. This means that these methods 2534 // do not have to worry about overflow; RangeSet::Intersect can handle such a 2535 // "wraparound" range. 2536 // As an example, the range [UINT_MAX-1, 3) contains five values: UINT_MAX-1, 2537 // UINT_MAX, 0, 1, and 2. 2538 2539 ProgramStateRef 2540 RangeConstraintManager::assumeSymNE(ProgramStateRef St, SymbolRef Sym, 2541 const llvm::APSInt &Int, 2542 const llvm::APSInt &Adjustment) { 2543 // Before we do any real work, see if the value can even show up. 2544 APSIntType AdjustmentType(Adjustment); 2545 if (AdjustmentType.testInRange(Int, true) != APSIntType::RTR_Within) 2546 return St; 2547 2548 llvm::APSInt Point = AdjustmentType.convert(Int) - Adjustment; 2549 RangeSet New = getRange(St, Sym); 2550 New = F.deletePoint(New, Point); 2551 2552 return setRange(St, Sym, New); 2553 } 2554 2555 ProgramStateRef 2556 RangeConstraintManager::assumeSymEQ(ProgramStateRef St, SymbolRef Sym, 2557 const llvm::APSInt &Int, 2558 const llvm::APSInt &Adjustment) { 2559 // Before we do any real work, see if the value can even show up. 2560 APSIntType AdjustmentType(Adjustment); 2561 if (AdjustmentType.testInRange(Int, true) != APSIntType::RTR_Within) 2562 return nullptr; 2563 2564 // [Int-Adjustment, Int-Adjustment] 2565 llvm::APSInt AdjInt = AdjustmentType.convert(Int) - Adjustment; 2566 RangeSet New = getRange(St, Sym); 2567 New = F.intersect(New, AdjInt); 2568 2569 return setRange(St, Sym, New); 2570 } 2571 2572 RangeSet RangeConstraintManager::getSymLTRange(ProgramStateRef St, 2573 SymbolRef Sym, 2574 const llvm::APSInt &Int, 2575 const llvm::APSInt &Adjustment) { 2576 // Before we do any real work, see if the value can even show up. 2577 APSIntType AdjustmentType(Adjustment); 2578 switch (AdjustmentType.testInRange(Int, true)) { 2579 case APSIntType::RTR_Below: 2580 return F.getEmptySet(); 2581 case APSIntType::RTR_Within: 2582 break; 2583 case APSIntType::RTR_Above: 2584 return getRange(St, Sym); 2585 } 2586 2587 // Special case for Int == Min. This is always false. 2588 llvm::APSInt ComparisonVal = AdjustmentType.convert(Int); 2589 llvm::APSInt Min = AdjustmentType.getMinValue(); 2590 if (ComparisonVal == Min) 2591 return F.getEmptySet(); 2592 2593 llvm::APSInt Lower = Min - Adjustment; 2594 llvm::APSInt Upper = ComparisonVal - Adjustment; 2595 --Upper; 2596 2597 RangeSet Result = getRange(St, Sym); 2598 return F.intersect(Result, Lower, Upper); 2599 } 2600 2601 ProgramStateRef 2602 RangeConstraintManager::assumeSymLT(ProgramStateRef St, SymbolRef Sym, 2603 const llvm::APSInt &Int, 2604 const llvm::APSInt &Adjustment) { 2605 RangeSet New = getSymLTRange(St, Sym, Int, Adjustment); 2606 return setRange(St, Sym, New); 2607 } 2608 2609 RangeSet RangeConstraintManager::getSymGTRange(ProgramStateRef St, 2610 SymbolRef Sym, 2611 const llvm::APSInt &Int, 2612 const llvm::APSInt &Adjustment) { 2613 // Before we do any real work, see if the value can even show up. 2614 APSIntType AdjustmentType(Adjustment); 2615 switch (AdjustmentType.testInRange(Int, true)) { 2616 case APSIntType::RTR_Below: 2617 return getRange(St, Sym); 2618 case APSIntType::RTR_Within: 2619 break; 2620 case APSIntType::RTR_Above: 2621 return F.getEmptySet(); 2622 } 2623 2624 // Special case for Int == Max. This is always false. 2625 llvm::APSInt ComparisonVal = AdjustmentType.convert(Int); 2626 llvm::APSInt Max = AdjustmentType.getMaxValue(); 2627 if (ComparisonVal == Max) 2628 return F.getEmptySet(); 2629 2630 llvm::APSInt Lower = ComparisonVal - Adjustment; 2631 llvm::APSInt Upper = Max - Adjustment; 2632 ++Lower; 2633 2634 RangeSet SymRange = getRange(St, Sym); 2635 return F.intersect(SymRange, Lower, Upper); 2636 } 2637 2638 ProgramStateRef 2639 RangeConstraintManager::assumeSymGT(ProgramStateRef St, SymbolRef Sym, 2640 const llvm::APSInt &Int, 2641 const llvm::APSInt &Adjustment) { 2642 RangeSet New = getSymGTRange(St, Sym, Int, Adjustment); 2643 return setRange(St, Sym, New); 2644 } 2645 2646 RangeSet RangeConstraintManager::getSymGERange(ProgramStateRef St, 2647 SymbolRef Sym, 2648 const llvm::APSInt &Int, 2649 const llvm::APSInt &Adjustment) { 2650 // Before we do any real work, see if the value can even show up. 2651 APSIntType AdjustmentType(Adjustment); 2652 switch (AdjustmentType.testInRange(Int, true)) { 2653 case APSIntType::RTR_Below: 2654 return getRange(St, Sym); 2655 case APSIntType::RTR_Within: 2656 break; 2657 case APSIntType::RTR_Above: 2658 return F.getEmptySet(); 2659 } 2660 2661 // Special case for Int == Min. This is always feasible. 2662 llvm::APSInt ComparisonVal = AdjustmentType.convert(Int); 2663 llvm::APSInt Min = AdjustmentType.getMinValue(); 2664 if (ComparisonVal == Min) 2665 return getRange(St, Sym); 2666 2667 llvm::APSInt Max = AdjustmentType.getMaxValue(); 2668 llvm::APSInt Lower = ComparisonVal - Adjustment; 2669 llvm::APSInt Upper = Max - Adjustment; 2670 2671 RangeSet SymRange = getRange(St, Sym); 2672 return F.intersect(SymRange, Lower, Upper); 2673 } 2674 2675 ProgramStateRef 2676 RangeConstraintManager::assumeSymGE(ProgramStateRef St, SymbolRef Sym, 2677 const llvm::APSInt &Int, 2678 const llvm::APSInt &Adjustment) { 2679 RangeSet New = getSymGERange(St, Sym, Int, Adjustment); 2680 return setRange(St, Sym, New); 2681 } 2682 2683 RangeSet 2684 RangeConstraintManager::getSymLERange(llvm::function_ref<RangeSet()> RS, 2685 const llvm::APSInt &Int, 2686 const llvm::APSInt &Adjustment) { 2687 // Before we do any real work, see if the value can even show up. 2688 APSIntType AdjustmentType(Adjustment); 2689 switch (AdjustmentType.testInRange(Int, true)) { 2690 case APSIntType::RTR_Below: 2691 return F.getEmptySet(); 2692 case APSIntType::RTR_Within: 2693 break; 2694 case APSIntType::RTR_Above: 2695 return RS(); 2696 } 2697 2698 // Special case for Int == Max. This is always feasible. 2699 llvm::APSInt ComparisonVal = AdjustmentType.convert(Int); 2700 llvm::APSInt Max = AdjustmentType.getMaxValue(); 2701 if (ComparisonVal == Max) 2702 return RS(); 2703 2704 llvm::APSInt Min = AdjustmentType.getMinValue(); 2705 llvm::APSInt Lower = Min - Adjustment; 2706 llvm::APSInt Upper = ComparisonVal - Adjustment; 2707 2708 RangeSet Default = RS(); 2709 return F.intersect(Default, Lower, Upper); 2710 } 2711 2712 RangeSet RangeConstraintManager::getSymLERange(ProgramStateRef St, 2713 SymbolRef Sym, 2714 const llvm::APSInt &Int, 2715 const llvm::APSInt &Adjustment) { 2716 return getSymLERange([&] { return getRange(St, Sym); }, Int, Adjustment); 2717 } 2718 2719 ProgramStateRef 2720 RangeConstraintManager::assumeSymLE(ProgramStateRef St, SymbolRef Sym, 2721 const llvm::APSInt &Int, 2722 const llvm::APSInt &Adjustment) { 2723 RangeSet New = getSymLERange(St, Sym, Int, Adjustment); 2724 return setRange(St, Sym, New); 2725 } 2726 2727 ProgramStateRef RangeConstraintManager::assumeSymWithinInclusiveRange( 2728 ProgramStateRef State, SymbolRef Sym, const llvm::APSInt &From, 2729 const llvm::APSInt &To, const llvm::APSInt &Adjustment) { 2730 RangeSet New = getSymGERange(State, Sym, From, Adjustment); 2731 if (New.isEmpty()) 2732 return nullptr; 2733 RangeSet Out = getSymLERange([&] { return New; }, To, Adjustment); 2734 return setRange(State, Sym, Out); 2735 } 2736 2737 ProgramStateRef RangeConstraintManager::assumeSymOutsideInclusiveRange( 2738 ProgramStateRef State, SymbolRef Sym, const llvm::APSInt &From, 2739 const llvm::APSInt &To, const llvm::APSInt &Adjustment) { 2740 RangeSet RangeLT = getSymLTRange(State, Sym, From, Adjustment); 2741 RangeSet RangeGT = getSymGTRange(State, Sym, To, Adjustment); 2742 RangeSet New(F.add(RangeLT, RangeGT)); 2743 return setRange(State, Sym, New); 2744 } 2745 2746 //===----------------------------------------------------------------------===// 2747 // Pretty-printing. 2748 //===----------------------------------------------------------------------===// 2749 2750 void RangeConstraintManager::printJson(raw_ostream &Out, ProgramStateRef State, 2751 const char *NL, unsigned int Space, 2752 bool IsDot) const { 2753 printConstraints(Out, State, NL, Space, IsDot); 2754 printEquivalenceClasses(Out, State, NL, Space, IsDot); 2755 printDisequalities(Out, State, NL, Space, IsDot); 2756 } 2757 2758 static std::string toString(const SymbolRef &Sym) { 2759 std::string S; 2760 llvm::raw_string_ostream O(S); 2761 Sym->dumpToStream(O); 2762 return O.str(); 2763 } 2764 2765 void RangeConstraintManager::printConstraints(raw_ostream &Out, 2766 ProgramStateRef State, 2767 const char *NL, 2768 unsigned int Space, 2769 bool IsDot) const { 2770 ConstraintRangeTy Constraints = State->get<ConstraintRange>(); 2771 2772 Indent(Out, Space, IsDot) << "\"constraints\": "; 2773 if (Constraints.isEmpty()) { 2774 Out << "null," << NL; 2775 return; 2776 } 2777 2778 std::map<std::string, RangeSet> OrderedConstraints; 2779 for (std::pair<EquivalenceClass, RangeSet> P : Constraints) { 2780 SymbolSet ClassMembers = P.first.getClassMembers(State); 2781 for (const SymbolRef &ClassMember : ClassMembers) { 2782 bool insertion_took_place; 2783 std::tie(std::ignore, insertion_took_place) = 2784 OrderedConstraints.insert({toString(ClassMember), P.second}); 2785 assert(insertion_took_place && 2786 "two symbols should not have the same dump"); 2787 } 2788 } 2789 2790 ++Space; 2791 Out << '[' << NL; 2792 bool First = true; 2793 for (std::pair<std::string, RangeSet> P : OrderedConstraints) { 2794 if (First) { 2795 First = false; 2796 } else { 2797 Out << ','; 2798 Out << NL; 2799 } 2800 Indent(Out, Space, IsDot) 2801 << "{ \"symbol\": \"" << P.first << "\", \"range\": \""; 2802 P.second.dump(Out); 2803 Out << "\" }"; 2804 } 2805 Out << NL; 2806 2807 --Space; 2808 Indent(Out, Space, IsDot) << "]," << NL; 2809 } 2810 2811 static std::string toString(ProgramStateRef State, EquivalenceClass Class) { 2812 SymbolSet ClassMembers = Class.getClassMembers(State); 2813 llvm::SmallVector<SymbolRef, 8> ClassMembersSorted(ClassMembers.begin(), 2814 ClassMembers.end()); 2815 llvm::sort(ClassMembersSorted, 2816 [](const SymbolRef &LHS, const SymbolRef &RHS) { 2817 return toString(LHS) < toString(RHS); 2818 }); 2819 2820 bool FirstMember = true; 2821 2822 std::string Str; 2823 llvm::raw_string_ostream Out(Str); 2824 Out << "[ "; 2825 for (SymbolRef ClassMember : ClassMembersSorted) { 2826 if (FirstMember) 2827 FirstMember = false; 2828 else 2829 Out << ", "; 2830 Out << "\"" << ClassMember << "\""; 2831 } 2832 Out << " ]"; 2833 return Out.str(); 2834 } 2835 2836 void RangeConstraintManager::printEquivalenceClasses(raw_ostream &Out, 2837 ProgramStateRef State, 2838 const char *NL, 2839 unsigned int Space, 2840 bool IsDot) const { 2841 ClassMembersTy Members = State->get<ClassMembers>(); 2842 2843 Indent(Out, Space, IsDot) << "\"equivalence_classes\": "; 2844 if (Members.isEmpty()) { 2845 Out << "null," << NL; 2846 return; 2847 } 2848 2849 std::set<std::string> MembersStr; 2850 for (std::pair<EquivalenceClass, SymbolSet> ClassToSymbolSet : Members) 2851 MembersStr.insert(toString(State, ClassToSymbolSet.first)); 2852 2853 ++Space; 2854 Out << '[' << NL; 2855 bool FirstClass = true; 2856 for (const std::string &Str : MembersStr) { 2857 if (FirstClass) { 2858 FirstClass = false; 2859 } else { 2860 Out << ','; 2861 Out << NL; 2862 } 2863 Indent(Out, Space, IsDot); 2864 Out << Str; 2865 } 2866 Out << NL; 2867 2868 --Space; 2869 Indent(Out, Space, IsDot) << "]," << NL; 2870 } 2871 2872 void RangeConstraintManager::printDisequalities(raw_ostream &Out, 2873 ProgramStateRef State, 2874 const char *NL, 2875 unsigned int Space, 2876 bool IsDot) const { 2877 DisequalityMapTy Disequalities = State->get<DisequalityMap>(); 2878 2879 Indent(Out, Space, IsDot) << "\"disequality_info\": "; 2880 if (Disequalities.isEmpty()) { 2881 Out << "null," << NL; 2882 return; 2883 } 2884 2885 // Transform the disequality info to an ordered map of 2886 // [string -> (ordered set of strings)] 2887 using EqClassesStrTy = std::set<std::string>; 2888 using DisequalityInfoStrTy = std::map<std::string, EqClassesStrTy>; 2889 DisequalityInfoStrTy DisequalityInfoStr; 2890 for (std::pair<EquivalenceClass, ClassSet> ClassToDisEqSet : Disequalities) { 2891 EquivalenceClass Class = ClassToDisEqSet.first; 2892 ClassSet DisequalClasses = ClassToDisEqSet.second; 2893 EqClassesStrTy MembersStr; 2894 for (EquivalenceClass DisEqClass : DisequalClasses) 2895 MembersStr.insert(toString(State, DisEqClass)); 2896 DisequalityInfoStr.insert({toString(State, Class), MembersStr}); 2897 } 2898 2899 ++Space; 2900 Out << '[' << NL; 2901 bool FirstClass = true; 2902 for (std::pair<std::string, EqClassesStrTy> ClassToDisEqSet : 2903 DisequalityInfoStr) { 2904 const std::string &Class = ClassToDisEqSet.first; 2905 if (FirstClass) { 2906 FirstClass = false; 2907 } else { 2908 Out << ','; 2909 Out << NL; 2910 } 2911 Indent(Out, Space, IsDot) << "{" << NL; 2912 unsigned int DisEqSpace = Space + 1; 2913 Indent(Out, DisEqSpace, IsDot) << "\"class\": "; 2914 Out << Class; 2915 const EqClassesStrTy &DisequalClasses = ClassToDisEqSet.second; 2916 if (!DisequalClasses.empty()) { 2917 Out << "," << NL; 2918 Indent(Out, DisEqSpace, IsDot) << "\"disequal_to\": [" << NL; 2919 unsigned int DisEqClassSpace = DisEqSpace + 1; 2920 Indent(Out, DisEqClassSpace, IsDot); 2921 bool FirstDisEqClass = true; 2922 for (const std::string &DisEqClass : DisequalClasses) { 2923 if (FirstDisEqClass) { 2924 FirstDisEqClass = false; 2925 } else { 2926 Out << ',' << NL; 2927 Indent(Out, DisEqClassSpace, IsDot); 2928 } 2929 Out << DisEqClass; 2930 } 2931 Out << "]" << NL; 2932 } 2933 Indent(Out, Space, IsDot) << "}"; 2934 } 2935 Out << NL; 2936 2937 --Space; 2938 Indent(Out, Space, IsDot) << "]," << NL; 2939 } 2940