1 //===- BugReporterVisitors.cpp - Helpers for reporting bugs ---------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8 //
9 //  This file defines a set of BugReporter "visitors" which can be used to
10 //  enhance the diagnostics reported for a bug.
11 //
12 //===----------------------------------------------------------------------===//
13 
14 #include "clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h"
15 #include "clang/AST/ASTContext.h"
16 #include "clang/AST/Decl.h"
17 #include "clang/AST/DeclBase.h"
18 #include "clang/AST/DeclCXX.h"
19 #include "clang/AST/Expr.h"
20 #include "clang/AST/ExprCXX.h"
21 #include "clang/AST/ExprObjC.h"
22 #include "clang/AST/Stmt.h"
23 #include "clang/AST/Type.h"
24 #include "clang/ASTMatchers/ASTMatchFinder.h"
25 #include "clang/Analysis/Analyses/Dominators.h"
26 #include "clang/Analysis/AnalysisDeclContext.h"
27 #include "clang/Analysis/CFG.h"
28 #include "clang/Analysis/CFGStmtMap.h"
29 #include "clang/Analysis/PathDiagnostic.h"
30 #include "clang/Analysis/ProgramPoint.h"
31 #include "clang/Basic/IdentifierTable.h"
32 #include "clang/Basic/LLVM.h"
33 #include "clang/Basic/SourceLocation.h"
34 #include "clang/Basic/SourceManager.h"
35 #include "clang/Lex/Lexer.h"
36 #include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
37 #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
38 #include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h"
39 #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
40 #include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h"
41 #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
42 #include "clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h"
43 #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
44 #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState_Fwd.h"
45 #include "clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h"
46 #include "clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h"
47 #include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h"
48 #include "clang/StaticAnalyzer/Core/PathSensitive/SubEngine.h"
49 #include "llvm/ADT/ArrayRef.h"
50 #include "llvm/ADT/None.h"
51 #include "llvm/ADT/Optional.h"
52 #include "llvm/ADT/STLExtras.h"
53 #include "llvm/ADT/SmallPtrSet.h"
54 #include "llvm/ADT/SmallString.h"
55 #include "llvm/ADT/SmallVector.h"
56 #include "llvm/ADT/StringExtras.h"
57 #include "llvm/ADT/StringRef.h"
58 #include "llvm/Support/Casting.h"
59 #include "llvm/Support/ErrorHandling.h"
60 #include "llvm/Support/raw_ostream.h"
61 #include <cassert>
62 #include <deque>
63 #include <memory>
64 #include <string>
65 #include <utility>
66 
67 using namespace clang;
68 using namespace ento;
69 
70 //===----------------------------------------------------------------------===//
71 // Utility functions.
72 //===----------------------------------------------------------------------===//
73 
74 static const Expr *peelOffPointerArithmetic(const BinaryOperator *B) {
75   if (B->isAdditiveOp() && B->getType()->isPointerType()) {
76     if (B->getLHS()->getType()->isPointerType()) {
77       return B->getLHS();
78     } else if (B->getRHS()->getType()->isPointerType()) {
79       return B->getRHS();
80     }
81   }
82   return nullptr;
83 }
84 
85 /// Given that expression S represents a pointer that would be dereferenced,
86 /// try to find a sub-expression from which the pointer came from.
87 /// This is used for tracking down origins of a null or undefined value:
88 /// "this is null because that is null because that is null" etc.
89 /// We wipe away field and element offsets because they merely add offsets.
90 /// We also wipe away all casts except lvalue-to-rvalue casts, because the
91 /// latter represent an actual pointer dereference; however, we remove
92 /// the final lvalue-to-rvalue cast before returning from this function
93 /// because it demonstrates more clearly from where the pointer rvalue was
94 /// loaded. Examples:
95 ///   x->y.z      ==>  x (lvalue)
96 ///   foo()->y.z  ==>  foo() (rvalue)
97 const Expr *bugreporter::getDerefExpr(const Stmt *S) {
98   const auto *E = dyn_cast<Expr>(S);
99   if (!E)
100     return nullptr;
101 
102   while (true) {
103     if (const auto *CE = dyn_cast<CastExpr>(E)) {
104       if (CE->getCastKind() == CK_LValueToRValue) {
105         // This cast represents the load we're looking for.
106         break;
107       }
108       E = CE->getSubExpr();
109     } else if (const auto *B = dyn_cast<BinaryOperator>(E)) {
110       // Pointer arithmetic: '*(x + 2)' -> 'x') etc.
111       if (const Expr *Inner = peelOffPointerArithmetic(B)) {
112         E = Inner;
113       } else {
114         // Probably more arithmetic can be pattern-matched here,
115         // but for now give up.
116         break;
117       }
118     } else if (const auto *U = dyn_cast<UnaryOperator>(E)) {
119       if (U->getOpcode() == UO_Deref || U->getOpcode() == UO_AddrOf ||
120           (U->isIncrementDecrementOp() && U->getType()->isPointerType())) {
121         // Operators '*' and '&' don't actually mean anything.
122         // We look at casts instead.
123         E = U->getSubExpr();
124       } else {
125         // Probably more arithmetic can be pattern-matched here,
126         // but for now give up.
127         break;
128       }
129     }
130     // Pattern match for a few useful cases: a[0], p->f, *p etc.
131     else if (const auto *ME = dyn_cast<MemberExpr>(E)) {
132       E = ME->getBase();
133     } else if (const auto *IvarRef = dyn_cast<ObjCIvarRefExpr>(E)) {
134       E = IvarRef->getBase();
135     } else if (const auto *AE = dyn_cast<ArraySubscriptExpr>(E)) {
136       E = AE->getBase();
137     } else if (const auto *PE = dyn_cast<ParenExpr>(E)) {
138       E = PE->getSubExpr();
139     } else if (const auto *FE = dyn_cast<FullExpr>(E)) {
140       E = FE->getSubExpr();
141     } else {
142       // Other arbitrary stuff.
143       break;
144     }
145   }
146 
147   // Special case: remove the final lvalue-to-rvalue cast, but do not recurse
148   // deeper into the sub-expression. This way we return the lvalue from which
149   // our pointer rvalue was loaded.
150   if (const auto *CE = dyn_cast<ImplicitCastExpr>(E))
151     if (CE->getCastKind() == CK_LValueToRValue)
152       E = CE->getSubExpr();
153 
154   return E;
155 }
156 
157 /// Comparing internal representations of symbolic values (via
158 /// SVal::operator==()) is a valid way to check if the value was updated,
159 /// unless it's a LazyCompoundVal that may have a different internal
160 /// representation every time it is loaded from the state. In this function we
161 /// do an approximate comparison for lazy compound values, checking that they
162 /// are the immediate snapshots of the tracked region's bindings within the
163 /// node's respective states but not really checking that these snapshots
164 /// actually contain the same set of bindings.
165 static bool hasVisibleUpdate(const ExplodedNode *LeftNode, SVal LeftVal,
166                              const ExplodedNode *RightNode, SVal RightVal) {
167   if (LeftVal == RightVal)
168     return true;
169 
170   const auto LLCV = LeftVal.getAs<nonloc::LazyCompoundVal>();
171   if (!LLCV)
172     return false;
173 
174   const auto RLCV = RightVal.getAs<nonloc::LazyCompoundVal>();
175   if (!RLCV)
176     return false;
177 
178   return LLCV->getRegion() == RLCV->getRegion() &&
179     LLCV->getStore() == LeftNode->getState()->getStore() &&
180     RLCV->getStore() == RightNode->getState()->getStore();
181 }
182 
183 static Optional<SVal> getSValForVar(const Expr *CondVarExpr,
184                                     const ExplodedNode *N) {
185   ProgramStateRef State = N->getState();
186   const LocationContext *LCtx = N->getLocationContext();
187 
188   assert(CondVarExpr);
189   CondVarExpr = CondVarExpr->IgnoreImpCasts();
190 
191   // The declaration of the value may rely on a pointer so take its l-value.
192   // FIXME: As seen in VisitCommonDeclRefExpr, sometimes DeclRefExpr may
193   // evaluate to a FieldRegion when it refers to a declaration of a lambda
194   // capture variable. We most likely need to duplicate that logic here.
195   if (const auto *DRE = dyn_cast<DeclRefExpr>(CondVarExpr))
196     if (const auto *VD = dyn_cast<VarDecl>(DRE->getDecl()))
197       return State->getSVal(State->getLValue(VD, LCtx));
198 
199   if (const auto *ME = dyn_cast<MemberExpr>(CondVarExpr))
200     if (const auto *FD = dyn_cast<FieldDecl>(ME->getMemberDecl()))
201       if (auto FieldL = State->getSVal(ME, LCtx).getAs<Loc>())
202         return State->getRawSVal(*FieldL, FD->getType());
203 
204   return None;
205 }
206 
207 static Optional<const llvm::APSInt *>
208 getConcreteIntegerValue(const Expr *CondVarExpr, const ExplodedNode *N) {
209 
210   if (Optional<SVal> V = getSValForVar(CondVarExpr, N))
211     if (auto CI = V->getAs<nonloc::ConcreteInt>())
212       return &CI->getValue();
213   return None;
214 }
215 
216 static bool isVarAnInterestingCondition(const Expr *CondVarExpr,
217                                         const ExplodedNode *N,
218                                         const PathSensitiveBugReport *B) {
219   // Even if this condition is marked as interesting, it isn't *that*
220   // interesting if it didn't happen in a nested stackframe, the user could just
221   // follow the arrows.
222   if (!B->getErrorNode()->getStackFrame()->isParentOf(N->getStackFrame()))
223     return false;
224 
225   if (Optional<SVal> V = getSValForVar(CondVarExpr, N))
226     if (Optional<bugreporter::TrackingKind> K = B->getInterestingnessKind(*V))
227       return *K == bugreporter::TrackingKind::Condition;
228 
229   return false;
230 }
231 
232 static bool isInterestingExpr(const Expr *E, const ExplodedNode *N,
233                               const PathSensitiveBugReport *B) {
234   if (Optional<SVal> V = getSValForVar(E, N))
235     return B->getInterestingnessKind(*V).hasValue();
236   return false;
237 }
238 
239 /// \return name of the macro inside the location \p Loc.
240 static StringRef getMacroName(SourceLocation Loc,
241     BugReporterContext &BRC) {
242   return Lexer::getImmediateMacroName(
243       Loc,
244       BRC.getSourceManager(),
245       BRC.getASTContext().getLangOpts());
246 }
247 
248 /// \return Whether given spelling location corresponds to an expansion
249 /// of a function-like macro.
250 static bool isFunctionMacroExpansion(SourceLocation Loc,
251                                 const SourceManager &SM) {
252   if (!Loc.isMacroID())
253     return false;
254   while (SM.isMacroArgExpansion(Loc))
255     Loc = SM.getImmediateExpansionRange(Loc).getBegin();
256   std::pair<FileID, unsigned> TLInfo = SM.getDecomposedLoc(Loc);
257   SrcMgr::SLocEntry SE = SM.getSLocEntry(TLInfo.first);
258   const SrcMgr::ExpansionInfo &EInfo = SE.getExpansion();
259   return EInfo.isFunctionMacroExpansion();
260 }
261 
262 /// \return Whether \c RegionOfInterest was modified at \p N,
263 /// where \p ValueAfter is \c RegionOfInterest's value at the end of the
264 /// stack frame.
265 static bool wasRegionOfInterestModifiedAt(const SubRegion *RegionOfInterest,
266                                           const ExplodedNode *N,
267                                           SVal ValueAfter) {
268   ProgramStateRef State = N->getState();
269   ProgramStateManager &Mgr = N->getState()->getStateManager();
270 
271   if (!N->getLocationAs<PostStore>() && !N->getLocationAs<PostInitializer>() &&
272       !N->getLocationAs<PostStmt>())
273     return false;
274 
275   // Writing into region of interest.
276   if (auto PS = N->getLocationAs<PostStmt>())
277     if (auto *BO = PS->getStmtAs<BinaryOperator>())
278       if (BO->isAssignmentOp() && RegionOfInterest->isSubRegionOf(
279                                       N->getSVal(BO->getLHS()).getAsRegion()))
280         return true;
281 
282   // SVal after the state is possibly different.
283   SVal ValueAtN = N->getState()->getSVal(RegionOfInterest);
284   if (!Mgr.getSValBuilder()
285            .areEqual(State, ValueAtN, ValueAfter)
286            .isConstrainedTrue() &&
287       (!ValueAtN.isUndef() || !ValueAfter.isUndef()))
288     return true;
289 
290   return false;
291 }
292 
293 //===----------------------------------------------------------------------===//
294 // Implementation of BugReporterVisitor.
295 //===----------------------------------------------------------------------===//
296 
297 PathDiagnosticPieceRef BugReporterVisitor::getEndPath(BugReporterContext &,
298                                                       const ExplodedNode *,
299                                                       PathSensitiveBugReport &) {
300   return nullptr;
301 }
302 
303 void BugReporterVisitor::finalizeVisitor(BugReporterContext &,
304                                          const ExplodedNode *,
305                                          PathSensitiveBugReport &) {}
306 
307 PathDiagnosticPieceRef
308 BugReporterVisitor::getDefaultEndPath(const BugReporterContext &BRC,
309                                       const ExplodedNode *EndPathNode,
310                                       const PathSensitiveBugReport &BR) {
311   PathDiagnosticLocation L = BR.getLocation();
312   const auto &Ranges = BR.getRanges();
313 
314   // Only add the statement itself as a range if we didn't specify any
315   // special ranges for this report.
316   auto P = std::make_shared<PathDiagnosticEventPiece>(
317       L, BR.getDescription(), Ranges.begin() == Ranges.end());
318   for (SourceRange Range : Ranges)
319     P->addRange(Range);
320 
321   return P;
322 }
323 
324 //===----------------------------------------------------------------------===//
325 // Implementation of NoStoreFuncVisitor.
326 //===----------------------------------------------------------------------===//
327 
328 namespace {
329 
330 /// Put a diagnostic on return statement of all inlined functions
331 /// for which  the region of interest \p RegionOfInterest was passed into,
332 /// but not written inside, and it has caused an undefined read or a null
333 /// pointer dereference outside.
334 class NoStoreFuncVisitor final : public BugReporterVisitor {
335   const SubRegion *RegionOfInterest;
336   MemRegionManager &MmrMgr;
337   const SourceManager &SM;
338   const PrintingPolicy &PP;
339   bugreporter::TrackingKind TKind;
340 
341   /// Recursion limit for dereferencing fields when looking for the
342   /// region of interest.
343   /// The limit of two indicates that we will dereference fields only once.
344   static const unsigned DEREFERENCE_LIMIT = 2;
345 
346   /// Frames writing into \c RegionOfInterest.
347   /// This visitor generates a note only if a function does not write into
348   /// a region of interest. This information is not immediately available
349   /// by looking at the node associated with the exit from the function
350   /// (usually the return statement). To avoid recomputing the same information
351   /// many times (going up the path for each node and checking whether the
352   /// region was written into) we instead lazily compute the
353   /// stack frames along the path which write into the region of interest.
354   llvm::SmallPtrSet<const StackFrameContext *, 32> FramesModifyingRegion;
355   llvm::SmallPtrSet<const StackFrameContext *, 32> FramesModifyingCalculated;
356 
357   using RegionVector = SmallVector<const MemRegion *, 5>;
358 
359 public:
360   NoStoreFuncVisitor(const SubRegion *R, bugreporter::TrackingKind TKind)
361       : RegionOfInterest(R), MmrMgr(*R->getMemRegionManager()),
362         SM(MmrMgr.getContext().getSourceManager()),
363         PP(MmrMgr.getContext().getPrintingPolicy()), TKind(TKind) {}
364 
365   void Profile(llvm::FoldingSetNodeID &ID) const override {
366     static int Tag = 0;
367     ID.AddPointer(&Tag);
368     ID.AddPointer(RegionOfInterest);
369   }
370 
371   void *getTag() const {
372     static int Tag = 0;
373     return static_cast<void *>(&Tag);
374   }
375 
376   PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
377                                    BugReporterContext &BR,
378                                    PathSensitiveBugReport &R) override;
379 
380 private:
381   /// Attempts to find the region of interest in a given record decl,
382   /// by either following the base classes or fields.
383   /// Dereferences fields up to a given recursion limit.
384   /// Note that \p Vec is passed by value, leading to quadratic copying cost,
385   /// but it's OK in practice since its length is limited to DEREFERENCE_LIMIT.
386   /// \return A chain fields leading to the region of interest or None.
387   const Optional<RegionVector>
388   findRegionOfInterestInRecord(const RecordDecl *RD, ProgramStateRef State,
389                                const MemRegion *R, const RegionVector &Vec = {},
390                                int depth = 0);
391 
392   /// Check and lazily calculate whether the region of interest is
393   /// modified in the stack frame to which \p N belongs.
394   /// The calculation is cached in FramesModifyingRegion.
395   bool isRegionOfInterestModifiedInFrame(const ExplodedNode *N) {
396     const LocationContext *Ctx = N->getLocationContext();
397     const StackFrameContext *SCtx = Ctx->getStackFrame();
398     if (!FramesModifyingCalculated.count(SCtx))
399       findModifyingFrames(N);
400     return FramesModifyingRegion.count(SCtx);
401   }
402 
403   /// Write to \c FramesModifyingRegion all stack frames along
404   /// the path in the current stack frame which modify \c RegionOfInterest.
405   void findModifyingFrames(const ExplodedNode *N);
406 
407   /// Consume the information on the no-store stack frame in order to
408   /// either emit a note or suppress the report enirely.
409   /// \return Diagnostics piece for region not modified in the current function,
410   /// if it decides to emit one.
411   PathDiagnosticPieceRef
412   maybeEmitNote(PathSensitiveBugReport &R, const CallEvent &Call,
413                 const ExplodedNode *N, const RegionVector &FieldChain,
414                 const MemRegion *MatchedRegion, StringRef FirstElement,
415                 bool FirstIsReferenceType, unsigned IndirectionLevel);
416 
417   /// Pretty-print region \p MatchedRegion to \p os.
418   /// \return Whether printing succeeded.
419   bool prettyPrintRegionName(StringRef FirstElement, bool FirstIsReferenceType,
420                              const MemRegion *MatchedRegion,
421                              const RegionVector &FieldChain,
422                              int IndirectionLevel,
423                              llvm::raw_svector_ostream &os);
424 
425   /// Print first item in the chain, return new separator.
426   static StringRef prettyPrintFirstElement(StringRef FirstElement,
427                                            bool MoreItemsExpected,
428                                            int IndirectionLevel,
429                                            llvm::raw_svector_ostream &os);
430 };
431 
432 } // end of anonymous namespace
433 
434 /// \return Whether the method declaration \p Parent
435 /// syntactically has a binary operation writing into the ivar \p Ivar.
436 static bool potentiallyWritesIntoIvar(const Decl *Parent,
437                                       const ObjCIvarDecl *Ivar) {
438   using namespace ast_matchers;
439   const char *IvarBind = "Ivar";
440   if (!Parent || !Parent->hasBody())
441     return false;
442   StatementMatcher WriteIntoIvarM = binaryOperator(
443       hasOperatorName("="),
444       hasLHS(ignoringParenImpCasts(
445           objcIvarRefExpr(hasDeclaration(equalsNode(Ivar))).bind(IvarBind))));
446   StatementMatcher ParentM = stmt(hasDescendant(WriteIntoIvarM));
447   auto Matches = match(ParentM, *Parent->getBody(), Parent->getASTContext());
448   for (BoundNodes &Match : Matches) {
449     auto IvarRef = Match.getNodeAs<ObjCIvarRefExpr>(IvarBind);
450     if (IvarRef->isFreeIvar())
451       return true;
452 
453     const Expr *Base = IvarRef->getBase();
454     if (const auto *ICE = dyn_cast<ImplicitCastExpr>(Base))
455       Base = ICE->getSubExpr();
456 
457     if (const auto *DRE = dyn_cast<DeclRefExpr>(Base))
458       if (const auto *ID = dyn_cast<ImplicitParamDecl>(DRE->getDecl()))
459         if (ID->getParameterKind() == ImplicitParamDecl::ObjCSelf)
460           return true;
461 
462     return false;
463   }
464   return false;
465 }
466 
467 /// Get parameters associated with runtime definition in order
468 /// to get the correct parameter name.
469 static ArrayRef<ParmVarDecl *> getCallParameters(CallEventRef<> Call) {
470   // Use runtime definition, if available.
471   RuntimeDefinition RD = Call->getRuntimeDefinition();
472   if (const auto *FD = dyn_cast_or_null<FunctionDecl>(RD.getDecl()))
473     return FD->parameters();
474   if (const auto *MD = dyn_cast_or_null<ObjCMethodDecl>(RD.getDecl()))
475     return MD->parameters();
476 
477   return Call->parameters();
478 }
479 
480 /// \return whether \p Ty points to a const type, or is a const reference.
481 static bool isPointerToConst(QualType Ty) {
482   return !Ty->getPointeeType().isNull() &&
483          Ty->getPointeeType().getCanonicalType().isConstQualified();
484 }
485 
486 /// Attempts to find the region of interest in a given CXX decl,
487 /// by either following the base classes or fields.
488 /// Dereferences fields up to a given recursion limit.
489 /// Note that \p Vec is passed by value, leading to quadratic copying cost,
490 /// but it's OK in practice since its length is limited to DEREFERENCE_LIMIT.
491 /// \return A chain fields leading to the region of interest or None.
492 const Optional<NoStoreFuncVisitor::RegionVector>
493 NoStoreFuncVisitor::findRegionOfInterestInRecord(
494     const RecordDecl *RD, ProgramStateRef State, const MemRegion *R,
495     const NoStoreFuncVisitor::RegionVector &Vec /* = {} */,
496     int depth /* = 0 */) {
497 
498   if (depth == DEREFERENCE_LIMIT) // Limit the recursion depth.
499     return None;
500 
501   if (const auto *RDX = dyn_cast<CXXRecordDecl>(RD))
502     if (!RDX->hasDefinition())
503       return None;
504 
505   // Recursively examine the base classes.
506   // Note that following base classes does not increase the recursion depth.
507   if (const auto *RDX = dyn_cast<CXXRecordDecl>(RD))
508     for (const auto II : RDX->bases())
509       if (const RecordDecl *RRD = II.getType()->getAsRecordDecl())
510         if (Optional<RegionVector> Out =
511                 findRegionOfInterestInRecord(RRD, State, R, Vec, depth))
512           return Out;
513 
514   for (const FieldDecl *I : RD->fields()) {
515     QualType FT = I->getType();
516     const FieldRegion *FR = MmrMgr.getFieldRegion(I, cast<SubRegion>(R));
517     const SVal V = State->getSVal(FR);
518     const MemRegion *VR = V.getAsRegion();
519 
520     RegionVector VecF = Vec;
521     VecF.push_back(FR);
522 
523     if (RegionOfInterest == VR)
524       return VecF;
525 
526     if (const RecordDecl *RRD = FT->getAsRecordDecl())
527       if (auto Out =
528               findRegionOfInterestInRecord(RRD, State, FR, VecF, depth + 1))
529         return Out;
530 
531     QualType PT = FT->getPointeeType();
532     if (PT.isNull() || PT->isVoidType() || !VR)
533       continue;
534 
535     if (const RecordDecl *RRD = PT->getAsRecordDecl())
536       if (Optional<RegionVector> Out =
537               findRegionOfInterestInRecord(RRD, State, VR, VecF, depth + 1))
538         return Out;
539   }
540 
541   return None;
542 }
543 
544 PathDiagnosticPieceRef
545 NoStoreFuncVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BR,
546                               PathSensitiveBugReport &R) {
547 
548   const LocationContext *Ctx = N->getLocationContext();
549   const StackFrameContext *SCtx = Ctx->getStackFrame();
550   ProgramStateRef State = N->getState();
551   auto CallExitLoc = N->getLocationAs<CallExitBegin>();
552 
553   // No diagnostic if region was modified inside the frame.
554   if (!CallExitLoc || isRegionOfInterestModifiedInFrame(N))
555     return nullptr;
556 
557   CallEventRef<> Call =
558       BR.getStateManager().getCallEventManager().getCaller(SCtx, State);
559 
560   // Region of interest corresponds to an IVar, exiting a method
561   // which could have written into that IVar, but did not.
562   if (const auto *MC = dyn_cast<ObjCMethodCall>(Call)) {
563     if (const auto *IvarR = dyn_cast<ObjCIvarRegion>(RegionOfInterest)) {
564       const MemRegion *SelfRegion = MC->getReceiverSVal().getAsRegion();
565       if (RegionOfInterest->isSubRegionOf(SelfRegion) &&
566           potentiallyWritesIntoIvar(Call->getRuntimeDefinition().getDecl(),
567                                     IvarR->getDecl()))
568         return maybeEmitNote(R, *Call, N, {}, SelfRegion, "self",
569                              /*FirstIsReferenceType=*/false, 1);
570     }
571   }
572 
573   if (const auto *CCall = dyn_cast<CXXConstructorCall>(Call)) {
574     const MemRegion *ThisR = CCall->getCXXThisVal().getAsRegion();
575     if (RegionOfInterest->isSubRegionOf(ThisR) &&
576         !CCall->getDecl()->isImplicit())
577       return maybeEmitNote(R, *Call, N, {}, ThisR, "this",
578                            /*FirstIsReferenceType=*/false, 1);
579 
580     // Do not generate diagnostics for not modified parameters in
581     // constructors.
582     return nullptr;
583   }
584 
585   ArrayRef<ParmVarDecl *> parameters = getCallParameters(Call);
586   for (unsigned I = 0; I < Call->getNumArgs() && I < parameters.size(); ++I) {
587     const ParmVarDecl *PVD = parameters[I];
588     SVal V = Call->getArgSVal(I);
589     bool ParamIsReferenceType = PVD->getType()->isReferenceType();
590     std::string ParamName = PVD->getNameAsString();
591 
592     int IndirectionLevel = 1;
593     QualType T = PVD->getType();
594     while (const MemRegion *MR = V.getAsRegion()) {
595       if (RegionOfInterest->isSubRegionOf(MR) && !isPointerToConst(T))
596         return maybeEmitNote(R, *Call, N, {}, MR, ParamName,
597                              ParamIsReferenceType, IndirectionLevel);
598 
599       QualType PT = T->getPointeeType();
600       if (PT.isNull() || PT->isVoidType())
601         break;
602 
603       if (const RecordDecl *RD = PT->getAsRecordDecl())
604         if (Optional<RegionVector> P =
605                 findRegionOfInterestInRecord(RD, State, MR))
606           return maybeEmitNote(R, *Call, N, *P, RegionOfInterest, ParamName,
607                                ParamIsReferenceType, IndirectionLevel);
608 
609       V = State->getSVal(MR, PT);
610       T = PT;
611       IndirectionLevel++;
612     }
613   }
614 
615   return nullptr;
616 }
617 
618 void NoStoreFuncVisitor::findModifyingFrames(const ExplodedNode *N) {
619   assert(N->getLocationAs<CallExitBegin>());
620   ProgramStateRef LastReturnState = N->getState();
621   SVal ValueAtReturn = LastReturnState->getSVal(RegionOfInterest);
622   const LocationContext *Ctx = N->getLocationContext();
623   const StackFrameContext *OriginalSCtx = Ctx->getStackFrame();
624 
625   do {
626     ProgramStateRef State = N->getState();
627     auto CallExitLoc = N->getLocationAs<CallExitBegin>();
628     if (CallExitLoc) {
629       LastReturnState = State;
630       ValueAtReturn = LastReturnState->getSVal(RegionOfInterest);
631     }
632 
633     FramesModifyingCalculated.insert(N->getLocationContext()->getStackFrame());
634 
635     if (wasRegionOfInterestModifiedAt(RegionOfInterest, N, ValueAtReturn)) {
636       const StackFrameContext *SCtx = N->getStackFrame();
637       while (!SCtx->inTopFrame()) {
638         auto p = FramesModifyingRegion.insert(SCtx);
639         if (!p.second)
640           break; // Frame and all its parents already inserted.
641         SCtx = SCtx->getParent()->getStackFrame();
642       }
643     }
644 
645     // Stop calculation at the call to the current function.
646     if (auto CE = N->getLocationAs<CallEnter>())
647       if (CE->getCalleeContext() == OriginalSCtx)
648         break;
649 
650     N = N->getFirstPred();
651   } while (N);
652 }
653 
654 static llvm::StringLiteral WillBeUsedForACondition =
655     ", which participates in a condition later";
656 
657 PathDiagnosticPieceRef NoStoreFuncVisitor::maybeEmitNote(
658     PathSensitiveBugReport &R, const CallEvent &Call, const ExplodedNode *N,
659     const RegionVector &FieldChain, const MemRegion *MatchedRegion,
660     StringRef FirstElement, bool FirstIsReferenceType,
661     unsigned IndirectionLevel) {
662   // Optimistically suppress uninitialized value bugs that result
663   // from system headers having a chance to initialize the value
664   // but failing to do so. It's too unlikely a system header's fault.
665   // It's much more likely a situation in which the function has a failure
666   // mode that the user decided not to check. If we want to hunt such
667   // omitted checks, we should provide an explicit function-specific note
668   // describing the precondition under which the function isn't supposed to
669   // initialize its out-parameter, and additionally check that such
670   // precondition can actually be fulfilled on the current path.
671   if (Call.isInSystemHeader()) {
672     // We make an exception for system header functions that have no branches.
673     // Such functions unconditionally fail to initialize the variable.
674     // If they call other functions that have more paths within them,
675     // this suppression would still apply when we visit these inner functions.
676     // One common example of a standard function that doesn't ever initialize
677     // its out parameter is operator placement new; it's up to the follow-up
678     // constructor (if any) to initialize the memory.
679     if (!N->getStackFrame()->getCFG()->isLinear())
680       R.markInvalid(getTag(), nullptr);
681     return nullptr;
682   }
683 
684   PathDiagnosticLocation L =
685       PathDiagnosticLocation::create(N->getLocation(), SM);
686 
687   // For now this shouldn't trigger, but once it does (as we add more
688   // functions to the body farm), we'll need to decide if these reports
689   // are worth suppressing as well.
690   if (!L.hasValidLocation())
691     return nullptr;
692 
693   SmallString<256> sbuf;
694   llvm::raw_svector_ostream os(sbuf);
695   os << "Returning without writing to '";
696 
697   // Do not generate the note if failed to pretty-print.
698   if (!prettyPrintRegionName(FirstElement, FirstIsReferenceType, MatchedRegion,
699                              FieldChain, IndirectionLevel, os))
700     return nullptr;
701 
702   os << "'";
703   if (TKind == bugreporter::TrackingKind::Condition)
704     os << WillBeUsedForACondition;
705   return std::make_shared<PathDiagnosticEventPiece>(L, os.str());
706 }
707 
708 bool NoStoreFuncVisitor::prettyPrintRegionName(StringRef FirstElement,
709                                                bool FirstIsReferenceType,
710                                                const MemRegion *MatchedRegion,
711                                                const RegionVector &FieldChain,
712                                                int IndirectionLevel,
713                                                llvm::raw_svector_ostream &os) {
714 
715   if (FirstIsReferenceType)
716     IndirectionLevel--;
717 
718   RegionVector RegionSequence;
719 
720   // Add the regions in the reverse order, then reverse the resulting array.
721   assert(RegionOfInterest->isSubRegionOf(MatchedRegion));
722   const MemRegion *R = RegionOfInterest;
723   while (R != MatchedRegion) {
724     RegionSequence.push_back(R);
725     R = cast<SubRegion>(R)->getSuperRegion();
726   }
727   std::reverse(RegionSequence.begin(), RegionSequence.end());
728   RegionSequence.append(FieldChain.begin(), FieldChain.end());
729 
730   StringRef Sep;
731   for (const MemRegion *R : RegionSequence) {
732 
733     // Just keep going up to the base region.
734     // Element regions may appear due to casts.
735     if (isa<CXXBaseObjectRegion>(R) || isa<CXXTempObjectRegion>(R))
736       continue;
737 
738     if (Sep.empty())
739       Sep = prettyPrintFirstElement(FirstElement,
740                                     /*MoreItemsExpected=*/true,
741                                     IndirectionLevel, os);
742 
743     os << Sep;
744 
745     // Can only reasonably pretty-print DeclRegions.
746     if (!isa<DeclRegion>(R))
747       return false;
748 
749     const auto *DR = cast<DeclRegion>(R);
750     Sep = DR->getValueType()->isAnyPointerType() ? "->" : ".";
751     DR->getDecl()->getDeclName().print(os, PP);
752   }
753 
754   if (Sep.empty())
755     prettyPrintFirstElement(FirstElement,
756                             /*MoreItemsExpected=*/false, IndirectionLevel, os);
757   return true;
758 }
759 
760 StringRef NoStoreFuncVisitor::prettyPrintFirstElement(
761     StringRef FirstElement, bool MoreItemsExpected, int IndirectionLevel,
762     llvm::raw_svector_ostream &os) {
763   StringRef Out = ".";
764 
765   if (IndirectionLevel > 0 && MoreItemsExpected) {
766     IndirectionLevel--;
767     Out = "->";
768   }
769 
770   if (IndirectionLevel > 0 && MoreItemsExpected)
771     os << "(";
772 
773   for (int i = 0; i < IndirectionLevel; i++)
774     os << "*";
775   os << FirstElement;
776 
777   if (IndirectionLevel > 0 && MoreItemsExpected)
778     os << ")";
779 
780   return Out;
781 }
782 
783 //===----------------------------------------------------------------------===//
784 // Implementation of MacroNullReturnSuppressionVisitor.
785 //===----------------------------------------------------------------------===//
786 
787 namespace {
788 
789 /// Suppress null-pointer-dereference bugs where dereferenced null was returned
790 /// the macro.
791 class MacroNullReturnSuppressionVisitor final : public BugReporterVisitor {
792   const SubRegion *RegionOfInterest;
793   const SVal ValueAtDereference;
794 
795   // Do not invalidate the reports where the value was modified
796   // after it got assigned to from the macro.
797   bool WasModified = false;
798 
799 public:
800   MacroNullReturnSuppressionVisitor(const SubRegion *R, const SVal V)
801       : RegionOfInterest(R), ValueAtDereference(V) {}
802 
803   PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
804                                    BugReporterContext &BRC,
805                                    PathSensitiveBugReport &BR) override {
806     if (WasModified)
807       return nullptr;
808 
809     auto BugPoint = BR.getErrorNode()->getLocation().getAs<StmtPoint>();
810     if (!BugPoint)
811       return nullptr;
812 
813     const SourceManager &SMgr = BRC.getSourceManager();
814     if (auto Loc = matchAssignment(N)) {
815       if (isFunctionMacroExpansion(*Loc, SMgr)) {
816         std::string MacroName = getMacroName(*Loc, BRC);
817         SourceLocation BugLoc = BugPoint->getStmt()->getBeginLoc();
818         if (!BugLoc.isMacroID() || getMacroName(BugLoc, BRC) != MacroName)
819           BR.markInvalid(getTag(), MacroName.c_str());
820       }
821     }
822 
823     if (wasRegionOfInterestModifiedAt(RegionOfInterest, N, ValueAtDereference))
824       WasModified = true;
825 
826     return nullptr;
827   }
828 
829   static void addMacroVisitorIfNecessary(
830         const ExplodedNode *N, const MemRegion *R,
831         bool EnableNullFPSuppression, PathSensitiveBugReport &BR,
832         const SVal V) {
833     AnalyzerOptions &Options = N->getState()->getAnalysisManager().options;
834     if (EnableNullFPSuppression &&
835         Options.ShouldSuppressNullReturnPaths && V.getAs<Loc>())
836       BR.addVisitor(std::make_unique<MacroNullReturnSuppressionVisitor>(
837               R->getAs<SubRegion>(), V));
838   }
839 
840   void* getTag() const {
841     static int Tag = 0;
842     return static_cast<void *>(&Tag);
843   }
844 
845   void Profile(llvm::FoldingSetNodeID &ID) const override {
846     ID.AddPointer(getTag());
847   }
848 
849 private:
850   /// \return Source location of right hand side of an assignment
851   /// into \c RegionOfInterest, empty optional if none found.
852   Optional<SourceLocation> matchAssignment(const ExplodedNode *N) {
853     const Stmt *S = N->getStmtForDiagnostics();
854     ProgramStateRef State = N->getState();
855     auto *LCtx = N->getLocationContext();
856     if (!S)
857       return None;
858 
859     if (const auto *DS = dyn_cast<DeclStmt>(S)) {
860       if (const auto *VD = dyn_cast<VarDecl>(DS->getSingleDecl()))
861         if (const Expr *RHS = VD->getInit())
862           if (RegionOfInterest->isSubRegionOf(
863                   State->getLValue(VD, LCtx).getAsRegion()))
864             return RHS->getBeginLoc();
865     } else if (const auto *BO = dyn_cast<BinaryOperator>(S)) {
866       const MemRegion *R = N->getSVal(BO->getLHS()).getAsRegion();
867       const Expr *RHS = BO->getRHS();
868       if (BO->isAssignmentOp() && RegionOfInterest->isSubRegionOf(R)) {
869         return RHS->getBeginLoc();
870       }
871     }
872     return None;
873   }
874 };
875 
876 } // end of anonymous namespace
877 
878 namespace {
879 
880 /// Emits an extra note at the return statement of an interesting stack frame.
881 ///
882 /// The returned value is marked as an interesting value, and if it's null,
883 /// adds a visitor to track where it became null.
884 ///
885 /// This visitor is intended to be used when another visitor discovers that an
886 /// interesting value comes from an inlined function call.
887 class ReturnVisitor : public BugReporterVisitor {
888   const StackFrameContext *CalleeSFC;
889   enum {
890     Initial,
891     MaybeUnsuppress,
892     Satisfied
893   } Mode = Initial;
894 
895   bool EnableNullFPSuppression;
896   bool ShouldInvalidate = true;
897   AnalyzerOptions& Options;
898   bugreporter::TrackingKind TKind;
899 
900 public:
901   ReturnVisitor(const StackFrameContext *Frame, bool Suppressed,
902                 AnalyzerOptions &Options, bugreporter::TrackingKind TKind)
903       : CalleeSFC(Frame), EnableNullFPSuppression(Suppressed),
904         Options(Options), TKind(TKind) {}
905 
906   static void *getTag() {
907     static int Tag = 0;
908     return static_cast<void *>(&Tag);
909   }
910 
911   void Profile(llvm::FoldingSetNodeID &ID) const override {
912     ID.AddPointer(ReturnVisitor::getTag());
913     ID.AddPointer(CalleeSFC);
914     ID.AddBoolean(EnableNullFPSuppression);
915   }
916 
917   /// Adds a ReturnVisitor if the given statement represents a call that was
918   /// inlined.
919   ///
920   /// This will search back through the ExplodedGraph, starting from the given
921   /// node, looking for when the given statement was processed. If it turns out
922   /// the statement is a call that was inlined, we add the visitor to the
923   /// bug report, so it can print a note later.
924   static void addVisitorIfNecessary(const ExplodedNode *Node, const Stmt *S,
925                                     PathSensitiveBugReport &BR,
926                                     bool InEnableNullFPSuppression,
927                                     bugreporter::TrackingKind TKind) {
928     if (!CallEvent::isCallStmt(S))
929       return;
930 
931     // First, find when we processed the statement.
932     // If we work with a 'CXXNewExpr' that is going to be purged away before
933     // its call take place. We would catch that purge in the last condition
934     // as a 'StmtPoint' so we have to bypass it.
935     const bool BypassCXXNewExprEval = isa<CXXNewExpr>(S);
936 
937     // This is moving forward when we enter into another context.
938     const StackFrameContext *CurrentSFC = Node->getStackFrame();
939 
940     do {
941       // If that is satisfied we found our statement as an inlined call.
942       if (Optional<CallExitEnd> CEE = Node->getLocationAs<CallExitEnd>())
943         if (CEE->getCalleeContext()->getCallSite() == S)
944           break;
945 
946       // Try to move forward to the end of the call-chain.
947       Node = Node->getFirstPred();
948       if (!Node)
949         break;
950 
951       const StackFrameContext *PredSFC = Node->getStackFrame();
952 
953       // If that is satisfied we found our statement.
954       // FIXME: This code currently bypasses the call site for the
955       //        conservatively evaluated allocator.
956       if (!BypassCXXNewExprEval)
957         if (Optional<StmtPoint> SP = Node->getLocationAs<StmtPoint>())
958           // See if we do not enter into another context.
959           if (SP->getStmt() == S && CurrentSFC == PredSFC)
960             break;
961 
962       CurrentSFC = PredSFC;
963     } while (Node->getStackFrame() == CurrentSFC);
964 
965     // Next, step over any post-statement checks.
966     while (Node && Node->getLocation().getAs<PostStmt>())
967       Node = Node->getFirstPred();
968     if (!Node)
969       return;
970 
971     // Finally, see if we inlined the call.
972     Optional<CallExitEnd> CEE = Node->getLocationAs<CallExitEnd>();
973     if (!CEE)
974       return;
975 
976     const StackFrameContext *CalleeContext = CEE->getCalleeContext();
977     if (CalleeContext->getCallSite() != S)
978       return;
979 
980     // Check the return value.
981     ProgramStateRef State = Node->getState();
982     SVal RetVal = Node->getSVal(S);
983 
984     // Handle cases where a reference is returned and then immediately used.
985     if (cast<Expr>(S)->isGLValue())
986       if (Optional<Loc> LValue = RetVal.getAs<Loc>())
987         RetVal = State->getSVal(*LValue);
988 
989     // See if the return value is NULL. If so, suppress the report.
990     AnalyzerOptions &Options = State->getAnalysisManager().options;
991 
992     bool EnableNullFPSuppression = false;
993     if (InEnableNullFPSuppression &&
994         Options.ShouldSuppressNullReturnPaths)
995       if (Optional<Loc> RetLoc = RetVal.getAs<Loc>())
996         EnableNullFPSuppression = State->isNull(*RetLoc).isConstrainedTrue();
997 
998     BR.addVisitor(std::make_unique<ReturnVisitor>(CalleeContext,
999                                                    EnableNullFPSuppression,
1000                                                    Options, TKind));
1001   }
1002 
1003   PathDiagnosticPieceRef visitNodeInitial(const ExplodedNode *N,
1004                                           BugReporterContext &BRC,
1005                                           PathSensitiveBugReport &BR) {
1006     // Only print a message at the interesting return statement.
1007     if (N->getLocationContext() != CalleeSFC)
1008       return nullptr;
1009 
1010     Optional<StmtPoint> SP = N->getLocationAs<StmtPoint>();
1011     if (!SP)
1012       return nullptr;
1013 
1014     const auto *Ret = dyn_cast<ReturnStmt>(SP->getStmt());
1015     if (!Ret)
1016       return nullptr;
1017 
1018     // Okay, we're at the right return statement, but do we have the return
1019     // value available?
1020     ProgramStateRef State = N->getState();
1021     SVal V = State->getSVal(Ret, CalleeSFC);
1022     if (V.isUnknownOrUndef())
1023       return nullptr;
1024 
1025     // Don't print any more notes after this one.
1026     Mode = Satisfied;
1027 
1028     const Expr *RetE = Ret->getRetValue();
1029     assert(RetE && "Tracking a return value for a void function");
1030 
1031     // Handle cases where a reference is returned and then immediately used.
1032     Optional<Loc> LValue;
1033     if (RetE->isGLValue()) {
1034       if ((LValue = V.getAs<Loc>())) {
1035         SVal RValue = State->getRawSVal(*LValue, RetE->getType());
1036         if (RValue.getAs<DefinedSVal>())
1037           V = RValue;
1038       }
1039     }
1040 
1041     // Ignore aggregate rvalues.
1042     if (V.getAs<nonloc::LazyCompoundVal>() ||
1043         V.getAs<nonloc::CompoundVal>())
1044       return nullptr;
1045 
1046     RetE = RetE->IgnoreParenCasts();
1047 
1048     // Let's track the return value.
1049     bugreporter::trackExpressionValue(
1050         N, RetE, BR, TKind, EnableNullFPSuppression);
1051 
1052     // Build an appropriate message based on the return value.
1053     SmallString<64> Msg;
1054     llvm::raw_svector_ostream Out(Msg);
1055 
1056     bool WouldEventBeMeaningless = false;
1057 
1058     if (State->isNull(V).isConstrainedTrue()) {
1059       if (V.getAs<Loc>()) {
1060 
1061         // If we have counter-suppression enabled, make sure we keep visiting
1062         // future nodes. We want to emit a path note as well, in case
1063         // the report is resurrected as valid later on.
1064         if (EnableNullFPSuppression &&
1065             Options.ShouldAvoidSuppressingNullArgumentPaths)
1066           Mode = MaybeUnsuppress;
1067 
1068         if (RetE->getType()->isObjCObjectPointerType()) {
1069           Out << "Returning nil";
1070         } else {
1071           Out << "Returning null pointer";
1072         }
1073       } else {
1074         Out << "Returning zero";
1075       }
1076 
1077     } else {
1078       if (auto CI = V.getAs<nonloc::ConcreteInt>()) {
1079         Out << "Returning the value " << CI->getValue();
1080       } else {
1081         // There is nothing interesting about returning a value, when it is
1082         // plain value without any constraints, and the function is guaranteed
1083         // to return that every time. We could use CFG::isLinear() here, but
1084         // constexpr branches are obvious to the compiler, not necesserily to
1085         // the programmer.
1086         if (N->getCFG().size() == 3)
1087           WouldEventBeMeaningless = true;
1088 
1089         if (V.getAs<Loc>())
1090           Out << "Returning pointer";
1091         else
1092           Out << "Returning value";
1093       }
1094     }
1095 
1096     if (LValue) {
1097       if (const MemRegion *MR = LValue->getAsRegion()) {
1098         if (MR->canPrintPretty()) {
1099           Out << " (reference to ";
1100           MR->printPretty(Out);
1101           Out << ")";
1102         }
1103       }
1104     } else {
1105       // FIXME: We should have a more generalized location printing mechanism.
1106       if (const auto *DR = dyn_cast<DeclRefExpr>(RetE))
1107         if (const auto *DD = dyn_cast<DeclaratorDecl>(DR->getDecl()))
1108           Out << " (loaded from '" << *DD << "')";
1109     }
1110 
1111     PathDiagnosticLocation L(Ret, BRC.getSourceManager(), CalleeSFC);
1112     if (!L.isValid() || !L.asLocation().isValid())
1113       return nullptr;
1114 
1115     if (TKind == bugreporter::TrackingKind::Condition)
1116       Out << WillBeUsedForACondition;
1117 
1118     auto EventPiece = std::make_shared<PathDiagnosticEventPiece>(L, Out.str());
1119 
1120     // If we determined that the note is meaningless, make it prunable, and
1121     // don't mark the stackframe interesting.
1122     if (WouldEventBeMeaningless)
1123       EventPiece->setPrunable(true);
1124     else
1125       BR.markInteresting(CalleeSFC);
1126 
1127     return EventPiece;
1128   }
1129 
1130   PathDiagnosticPieceRef visitNodeMaybeUnsuppress(const ExplodedNode *N,
1131                                                   BugReporterContext &BRC,
1132                                                   PathSensitiveBugReport &BR) {
1133     assert(Options.ShouldAvoidSuppressingNullArgumentPaths);
1134 
1135     // Are we at the entry node for this call?
1136     Optional<CallEnter> CE = N->getLocationAs<CallEnter>();
1137     if (!CE)
1138       return nullptr;
1139 
1140     if (CE->getCalleeContext() != CalleeSFC)
1141       return nullptr;
1142 
1143     Mode = Satisfied;
1144 
1145     // Don't automatically suppress a report if one of the arguments is
1146     // known to be a null pointer. Instead, start tracking /that/ null
1147     // value back to its origin.
1148     ProgramStateManager &StateMgr = BRC.getStateManager();
1149     CallEventManager &CallMgr = StateMgr.getCallEventManager();
1150 
1151     ProgramStateRef State = N->getState();
1152     CallEventRef<> Call = CallMgr.getCaller(CalleeSFC, State);
1153     for (unsigned I = 0, E = Call->getNumArgs(); I != E; ++I) {
1154       Optional<Loc> ArgV = Call->getArgSVal(I).getAs<Loc>();
1155       if (!ArgV)
1156         continue;
1157 
1158       const Expr *ArgE = Call->getArgExpr(I);
1159       if (!ArgE)
1160         continue;
1161 
1162       // Is it possible for this argument to be non-null?
1163       if (!State->isNull(*ArgV).isConstrainedTrue())
1164         continue;
1165 
1166       if (trackExpressionValue(N, ArgE, BR, TKind, EnableNullFPSuppression))
1167         ShouldInvalidate = false;
1168 
1169       // If we /can't/ track the null pointer, we should err on the side of
1170       // false negatives, and continue towards marking this report invalid.
1171       // (We will still look at the other arguments, though.)
1172     }
1173 
1174     return nullptr;
1175   }
1176 
1177   PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
1178                                    BugReporterContext &BRC,
1179                                    PathSensitiveBugReport &BR) override {
1180     switch (Mode) {
1181     case Initial:
1182       return visitNodeInitial(N, BRC, BR);
1183     case MaybeUnsuppress:
1184       return visitNodeMaybeUnsuppress(N, BRC, BR);
1185     case Satisfied:
1186       return nullptr;
1187     }
1188 
1189     llvm_unreachable("Invalid visit mode!");
1190   }
1191 
1192   void finalizeVisitor(BugReporterContext &, const ExplodedNode *,
1193                        PathSensitiveBugReport &BR) override {
1194     if (EnableNullFPSuppression && ShouldInvalidate)
1195       BR.markInvalid(ReturnVisitor::getTag(), CalleeSFC);
1196   }
1197 };
1198 
1199 } // end of anonymous namespace
1200 
1201 //===----------------------------------------------------------------------===//
1202 // Implementation of FindLastStoreBRVisitor.
1203 //===----------------------------------------------------------------------===//
1204 
1205 void FindLastStoreBRVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
1206   static int tag = 0;
1207   ID.AddPointer(&tag);
1208   ID.AddPointer(R);
1209   ID.Add(V);
1210   ID.AddInteger(static_cast<int>(TKind));
1211   ID.AddBoolean(EnableNullFPSuppression);
1212 }
1213 
1214 /// Returns true if \p N represents the DeclStmt declaring and initializing
1215 /// \p VR.
1216 static bool isInitializationOfVar(const ExplodedNode *N, const VarRegion *VR) {
1217   Optional<PostStmt> P = N->getLocationAs<PostStmt>();
1218   if (!P)
1219     return false;
1220 
1221   const DeclStmt *DS = P->getStmtAs<DeclStmt>();
1222   if (!DS)
1223     return false;
1224 
1225   if (DS->getSingleDecl() != VR->getDecl())
1226     return false;
1227 
1228   const MemSpaceRegion *VarSpace = VR->getMemorySpace();
1229   const auto *FrameSpace = dyn_cast<StackSpaceRegion>(VarSpace);
1230   if (!FrameSpace) {
1231     // If we ever directly evaluate global DeclStmts, this assertion will be
1232     // invalid, but this still seems preferable to silently accepting an
1233     // initialization that may be for a path-sensitive variable.
1234     assert(VR->getDecl()->isStaticLocal() && "non-static stackless VarRegion");
1235     return true;
1236   }
1237 
1238   assert(VR->getDecl()->hasLocalStorage());
1239   const LocationContext *LCtx = N->getLocationContext();
1240   return FrameSpace->getStackFrame() == LCtx->getStackFrame();
1241 }
1242 
1243 /// Show diagnostics for initializing or declaring a region \p R with a bad value.
1244 static void showBRDiagnostics(const char *action, llvm::raw_svector_ostream &os,
1245                               const MemRegion *R, SVal V, const DeclStmt *DS) {
1246   if (R->canPrintPretty()) {
1247     R->printPretty(os);
1248     os << " ";
1249   }
1250 
1251   if (V.getAs<loc::ConcreteInt>()) {
1252     bool b = false;
1253     if (R->isBoundable()) {
1254       if (const auto *TR = dyn_cast<TypedValueRegion>(R)) {
1255         if (TR->getValueType()->isObjCObjectPointerType()) {
1256           os << action << "nil";
1257           b = true;
1258         }
1259       }
1260     }
1261     if (!b)
1262       os << action << "a null pointer value";
1263 
1264   } else if (auto CVal = V.getAs<nonloc::ConcreteInt>()) {
1265     os << action << CVal->getValue();
1266   } else if (DS) {
1267     if (V.isUndef()) {
1268       if (isa<VarRegion>(R)) {
1269         const auto *VD = cast<VarDecl>(DS->getSingleDecl());
1270         if (VD->getInit()) {
1271           os << (R->canPrintPretty() ? "initialized" : "Initializing")
1272             << " to a garbage value";
1273         } else {
1274           os << (R->canPrintPretty() ? "declared" : "Declaring")
1275             << " without an initial value";
1276         }
1277       }
1278     } else {
1279       os << (R->canPrintPretty() ? "initialized" : "Initialized")
1280         << " here";
1281     }
1282   }
1283 }
1284 
1285 /// Display diagnostics for passing bad region as a parameter.
1286 static void showBRParamDiagnostics(llvm::raw_svector_ostream& os,
1287     const VarRegion *VR,
1288     SVal V) {
1289   const auto *Param = cast<ParmVarDecl>(VR->getDecl());
1290 
1291   os << "Passing ";
1292 
1293   if (V.getAs<loc::ConcreteInt>()) {
1294     if (Param->getType()->isObjCObjectPointerType())
1295       os << "nil object reference";
1296     else
1297       os << "null pointer value";
1298   } else if (V.isUndef()) {
1299     os << "uninitialized value";
1300   } else if (auto CI = V.getAs<nonloc::ConcreteInt>()) {
1301     os << "the value " << CI->getValue();
1302   } else {
1303     os << "value";
1304   }
1305 
1306   // Printed parameter indexes are 1-based, not 0-based.
1307   unsigned Idx = Param->getFunctionScopeIndex() + 1;
1308   os << " via " << Idx << llvm::getOrdinalSuffix(Idx) << " parameter";
1309   if (VR->canPrintPretty()) {
1310     os << " ";
1311     VR->printPretty(os);
1312   }
1313 }
1314 
1315 /// Show default diagnostics for storing bad region.
1316 static void showBRDefaultDiagnostics(llvm::raw_svector_ostream &os,
1317                                      const MemRegion *R, SVal V) {
1318   if (V.getAs<loc::ConcreteInt>()) {
1319     bool b = false;
1320     if (R->isBoundable()) {
1321       if (const auto *TR = dyn_cast<TypedValueRegion>(R)) {
1322         if (TR->getValueType()->isObjCObjectPointerType()) {
1323           os << "nil object reference stored";
1324           b = true;
1325         }
1326       }
1327     }
1328     if (!b) {
1329       if (R->canPrintPretty())
1330         os << "Null pointer value stored";
1331       else
1332         os << "Storing null pointer value";
1333     }
1334 
1335   } else if (V.isUndef()) {
1336     if (R->canPrintPretty())
1337       os << "Uninitialized value stored";
1338     else
1339       os << "Storing uninitialized value";
1340 
1341   } else if (auto CV = V.getAs<nonloc::ConcreteInt>()) {
1342     if (R->canPrintPretty())
1343       os << "The value " << CV->getValue() << " is assigned";
1344     else
1345       os << "Assigning " << CV->getValue();
1346 
1347   } else {
1348     if (R->canPrintPretty())
1349       os << "Value assigned";
1350     else
1351       os << "Assigning value";
1352   }
1353 
1354   if (R->canPrintPretty()) {
1355     os << " to ";
1356     R->printPretty(os);
1357   }
1358 }
1359 
1360 PathDiagnosticPieceRef
1361 FindLastStoreBRVisitor::VisitNode(const ExplodedNode *Succ,
1362                                   BugReporterContext &BRC,
1363                                   PathSensitiveBugReport &BR) {
1364   if (Satisfied)
1365     return nullptr;
1366 
1367   const ExplodedNode *StoreSite = nullptr;
1368   const ExplodedNode *Pred = Succ->getFirstPred();
1369   const Expr *InitE = nullptr;
1370   bool IsParam = false;
1371 
1372   // First see if we reached the declaration of the region.
1373   if (const auto *VR = dyn_cast<VarRegion>(R)) {
1374     if (isInitializationOfVar(Pred, VR)) {
1375       StoreSite = Pred;
1376       InitE = VR->getDecl()->getInit();
1377     }
1378   }
1379 
1380   // If this is a post initializer expression, initializing the region, we
1381   // should track the initializer expression.
1382   if (Optional<PostInitializer> PIP = Pred->getLocationAs<PostInitializer>()) {
1383     const MemRegion *FieldReg = (const MemRegion *)PIP->getLocationValue();
1384     if (FieldReg == R) {
1385       StoreSite = Pred;
1386       InitE = PIP->getInitializer()->getInit();
1387     }
1388   }
1389 
1390   // Otherwise, see if this is the store site:
1391   // (1) Succ has this binding and Pred does not, i.e. this is
1392   //     where the binding first occurred.
1393   // (2) Succ has this binding and is a PostStore node for this region, i.e.
1394   //     the same binding was re-assigned here.
1395   if (!StoreSite) {
1396     if (Succ->getState()->getSVal(R) != V)
1397       return nullptr;
1398 
1399     if (hasVisibleUpdate(Pred, Pred->getState()->getSVal(R), Succ, V)) {
1400       Optional<PostStore> PS = Succ->getLocationAs<PostStore>();
1401       if (!PS || PS->getLocationValue() != R)
1402         return nullptr;
1403     }
1404 
1405     StoreSite = Succ;
1406 
1407     // If this is an assignment expression, we can track the value
1408     // being assigned.
1409     if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>())
1410       if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>())
1411         if (BO->isAssignmentOp())
1412           InitE = BO->getRHS();
1413 
1414     // If this is a call entry, the variable should be a parameter.
1415     // FIXME: Handle CXXThisRegion as well. (This is not a priority because
1416     // 'this' should never be NULL, but this visitor isn't just for NULL and
1417     // UndefinedVal.)
1418     if (Optional<CallEnter> CE = Succ->getLocationAs<CallEnter>()) {
1419       if (const auto *VR = dyn_cast<VarRegion>(R)) {
1420 
1421         const auto *Param = cast<ParmVarDecl>(VR->getDecl());
1422 
1423         ProgramStateManager &StateMgr = BRC.getStateManager();
1424         CallEventManager &CallMgr = StateMgr.getCallEventManager();
1425 
1426         CallEventRef<> Call = CallMgr.getCaller(CE->getCalleeContext(),
1427                                                 Succ->getState());
1428         InitE = Call->getArgExpr(Param->getFunctionScopeIndex());
1429         IsParam = true;
1430       }
1431     }
1432 
1433     // If this is a CXXTempObjectRegion, the Expr responsible for its creation
1434     // is wrapped inside of it.
1435     if (const auto *TmpR = dyn_cast<CXXTempObjectRegion>(R))
1436       InitE = TmpR->getExpr();
1437   }
1438 
1439   if (!StoreSite)
1440     return nullptr;
1441   Satisfied = true;
1442 
1443   // If we have an expression that provided the value, try to track where it
1444   // came from.
1445   if (InitE) {
1446     if (!IsParam)
1447       InitE = InitE->IgnoreParenCasts();
1448 
1449     bugreporter::trackExpressionValue(
1450         StoreSite, InitE, BR, TKind, EnableNullFPSuppression);
1451   }
1452 
1453   if (TKind == TrackingKind::Condition &&
1454       !OriginSFC->isParentOf(StoreSite->getStackFrame()))
1455     return nullptr;
1456 
1457   // Okay, we've found the binding. Emit an appropriate message.
1458   SmallString<256> sbuf;
1459   llvm::raw_svector_ostream os(sbuf);
1460 
1461   if (Optional<PostStmt> PS = StoreSite->getLocationAs<PostStmt>()) {
1462     const Stmt *S = PS->getStmt();
1463     const char *action = nullptr;
1464     const auto *DS = dyn_cast<DeclStmt>(S);
1465     const auto *VR = dyn_cast<VarRegion>(R);
1466 
1467     if (DS) {
1468       action = R->canPrintPretty() ? "initialized to " :
1469                                      "Initializing to ";
1470     } else if (isa<BlockExpr>(S)) {
1471       action = R->canPrintPretty() ? "captured by block as " :
1472                                      "Captured by block as ";
1473       if (VR) {
1474         // See if we can get the BlockVarRegion.
1475         ProgramStateRef State = StoreSite->getState();
1476         SVal V = StoreSite->getSVal(S);
1477         if (const auto *BDR =
1478               dyn_cast_or_null<BlockDataRegion>(V.getAsRegion())) {
1479           if (const VarRegion *OriginalR = BDR->getOriginalRegion(VR)) {
1480             if (auto KV = State->getSVal(OriginalR).getAs<KnownSVal>())
1481               BR.addVisitor(std::make_unique<FindLastStoreBRVisitor>(
1482                   *KV, OriginalR, EnableNullFPSuppression, TKind, OriginSFC));
1483           }
1484         }
1485       }
1486     }
1487     if (action)
1488       showBRDiagnostics(action, os, R, V, DS);
1489 
1490   } else if (StoreSite->getLocation().getAs<CallEnter>()) {
1491     if (const auto *VR = dyn_cast<VarRegion>(R))
1492       showBRParamDiagnostics(os, VR, V);
1493   }
1494 
1495   if (os.str().empty())
1496     showBRDefaultDiagnostics(os, R, V);
1497 
1498   if (TKind == bugreporter::TrackingKind::Condition)
1499     os << WillBeUsedForACondition;
1500 
1501   // Construct a new PathDiagnosticPiece.
1502   ProgramPoint P = StoreSite->getLocation();
1503   PathDiagnosticLocation L;
1504   if (P.getAs<CallEnter>() && InitE)
1505     L = PathDiagnosticLocation(InitE, BRC.getSourceManager(),
1506                                P.getLocationContext());
1507 
1508   if (!L.isValid() || !L.asLocation().isValid())
1509     L = PathDiagnosticLocation::create(P, BRC.getSourceManager());
1510 
1511   if (!L.isValid() || !L.asLocation().isValid())
1512     return nullptr;
1513 
1514   return std::make_shared<PathDiagnosticEventPiece>(L, os.str());
1515 }
1516 
1517 //===----------------------------------------------------------------------===//
1518 // Implementation of TrackConstraintBRVisitor.
1519 //===----------------------------------------------------------------------===//
1520 
1521 void TrackConstraintBRVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
1522   static int tag = 0;
1523   ID.AddPointer(&tag);
1524   ID.AddBoolean(Assumption);
1525   ID.Add(Constraint);
1526 }
1527 
1528 /// Return the tag associated with this visitor.  This tag will be used
1529 /// to make all PathDiagnosticPieces created by this visitor.
1530 const char *TrackConstraintBRVisitor::getTag() {
1531   return "TrackConstraintBRVisitor";
1532 }
1533 
1534 bool TrackConstraintBRVisitor::isUnderconstrained(const ExplodedNode *N) const {
1535   if (IsZeroCheck)
1536     return N->getState()->isNull(Constraint).isUnderconstrained();
1537   return (bool)N->getState()->assume(Constraint, !Assumption);
1538 }
1539 
1540 PathDiagnosticPieceRef TrackConstraintBRVisitor::VisitNode(
1541     const ExplodedNode *N, BugReporterContext &BRC, PathSensitiveBugReport &) {
1542   const ExplodedNode *PrevN = N->getFirstPred();
1543   if (IsSatisfied)
1544     return nullptr;
1545 
1546   // Start tracking after we see the first state in which the value is
1547   // constrained.
1548   if (!IsTrackingTurnedOn)
1549     if (!isUnderconstrained(N))
1550       IsTrackingTurnedOn = true;
1551   if (!IsTrackingTurnedOn)
1552     return nullptr;
1553 
1554   // Check if in the previous state it was feasible for this constraint
1555   // to *not* be true.
1556   if (isUnderconstrained(PrevN)) {
1557     IsSatisfied = true;
1558 
1559     // As a sanity check, make sure that the negation of the constraint
1560     // was infeasible in the current state.  If it is feasible, we somehow
1561     // missed the transition point.
1562     assert(!isUnderconstrained(N));
1563 
1564     // We found the transition point for the constraint.  We now need to
1565     // pretty-print the constraint. (work-in-progress)
1566     SmallString<64> sbuf;
1567     llvm::raw_svector_ostream os(sbuf);
1568 
1569     if (Constraint.getAs<Loc>()) {
1570       os << "Assuming pointer value is ";
1571       os << (Assumption ? "non-null" : "null");
1572     }
1573 
1574     if (os.str().empty())
1575       return nullptr;
1576 
1577     // Construct a new PathDiagnosticPiece.
1578     ProgramPoint P = N->getLocation();
1579     PathDiagnosticLocation L =
1580       PathDiagnosticLocation::create(P, BRC.getSourceManager());
1581     if (!L.isValid())
1582       return nullptr;
1583 
1584     auto X = std::make_shared<PathDiagnosticEventPiece>(L, os.str());
1585     X->setTag(getTag());
1586     return std::move(X);
1587   }
1588 
1589   return nullptr;
1590 }
1591 
1592 //===----------------------------------------------------------------------===//
1593 // Implementation of SuppressInlineDefensiveChecksVisitor.
1594 //===----------------------------------------------------------------------===//
1595 
1596 SuppressInlineDefensiveChecksVisitor::
1597 SuppressInlineDefensiveChecksVisitor(DefinedSVal Value, const ExplodedNode *N)
1598     : V(Value) {
1599   // Check if the visitor is disabled.
1600   AnalyzerOptions &Options = N->getState()->getAnalysisManager().options;
1601   if (!Options.ShouldSuppressInlinedDefensiveChecks)
1602     IsSatisfied = true;
1603 
1604   assert(N->getState()->isNull(V).isConstrainedTrue() &&
1605          "The visitor only tracks the cases where V is constrained to 0");
1606 }
1607 
1608 void SuppressInlineDefensiveChecksVisitor::Profile(
1609     llvm::FoldingSetNodeID &ID) const {
1610   static int id = 0;
1611   ID.AddPointer(&id);
1612   ID.Add(V);
1613 }
1614 
1615 const char *SuppressInlineDefensiveChecksVisitor::getTag() {
1616   return "IDCVisitor";
1617 }
1618 
1619 PathDiagnosticPieceRef
1620 SuppressInlineDefensiveChecksVisitor::VisitNode(const ExplodedNode *Succ,
1621                                                 BugReporterContext &BRC,
1622                                                 PathSensitiveBugReport &BR) {
1623   const ExplodedNode *Pred = Succ->getFirstPred();
1624   if (IsSatisfied)
1625     return nullptr;
1626 
1627   // Start tracking after we see the first state in which the value is null.
1628   if (!IsTrackingTurnedOn)
1629     if (Succ->getState()->isNull(V).isConstrainedTrue())
1630       IsTrackingTurnedOn = true;
1631   if (!IsTrackingTurnedOn)
1632     return nullptr;
1633 
1634   // Check if in the previous state it was feasible for this value
1635   // to *not* be null.
1636   if (!Pred->getState()->isNull(V).isConstrainedTrue()) {
1637     IsSatisfied = true;
1638 
1639     assert(Succ->getState()->isNull(V).isConstrainedTrue());
1640 
1641     // Check if this is inlined defensive checks.
1642     const LocationContext *CurLC =Succ->getLocationContext();
1643     const LocationContext *ReportLC = BR.getErrorNode()->getLocationContext();
1644     if (CurLC != ReportLC && !CurLC->isParentOf(ReportLC)) {
1645       BR.markInvalid("Suppress IDC", CurLC);
1646       return nullptr;
1647     }
1648 
1649     // Treat defensive checks in function-like macros as if they were an inlined
1650     // defensive check. If the bug location is not in a macro and the
1651     // terminator for the current location is in a macro then suppress the
1652     // warning.
1653     auto BugPoint = BR.getErrorNode()->getLocation().getAs<StmtPoint>();
1654 
1655     if (!BugPoint)
1656       return nullptr;
1657 
1658     ProgramPoint CurPoint = Succ->getLocation();
1659     const Stmt *CurTerminatorStmt = nullptr;
1660     if (auto BE = CurPoint.getAs<BlockEdge>()) {
1661       CurTerminatorStmt = BE->getSrc()->getTerminator().getStmt();
1662     } else if (auto SP = CurPoint.getAs<StmtPoint>()) {
1663       const Stmt *CurStmt = SP->getStmt();
1664       if (!CurStmt->getBeginLoc().isMacroID())
1665         return nullptr;
1666 
1667       CFGStmtMap *Map = CurLC->getAnalysisDeclContext()->getCFGStmtMap();
1668       CurTerminatorStmt = Map->getBlock(CurStmt)->getTerminatorStmt();
1669     } else {
1670       return nullptr;
1671     }
1672 
1673     if (!CurTerminatorStmt)
1674       return nullptr;
1675 
1676     SourceLocation TerminatorLoc = CurTerminatorStmt->getBeginLoc();
1677     if (TerminatorLoc.isMacroID()) {
1678       SourceLocation BugLoc = BugPoint->getStmt()->getBeginLoc();
1679 
1680       // Suppress reports unless we are in that same macro.
1681       if (!BugLoc.isMacroID() ||
1682           getMacroName(BugLoc, BRC) != getMacroName(TerminatorLoc, BRC)) {
1683         BR.markInvalid("Suppress Macro IDC", CurLC);
1684       }
1685       return nullptr;
1686     }
1687   }
1688   return nullptr;
1689 }
1690 
1691 //===----------------------------------------------------------------------===//
1692 // TrackControlDependencyCondBRVisitor.
1693 //===----------------------------------------------------------------------===//
1694 
1695 namespace {
1696 /// Tracks the expressions that are a control dependency of the node that was
1697 /// supplied to the constructor.
1698 /// For example:
1699 ///
1700 ///   cond = 1;
1701 ///   if (cond)
1702 ///     10 / 0;
1703 ///
1704 /// An error is emitted at line 3. This visitor realizes that the branch
1705 /// on line 2 is a control dependency of line 3, and tracks it's condition via
1706 /// trackExpressionValue().
1707 class TrackControlDependencyCondBRVisitor final : public BugReporterVisitor {
1708   const ExplodedNode *Origin;
1709   ControlDependencyCalculator ControlDeps;
1710   llvm::SmallSet<const CFGBlock *, 32> VisitedBlocks;
1711 
1712 public:
1713   TrackControlDependencyCondBRVisitor(const ExplodedNode *O)
1714   : Origin(O), ControlDeps(&O->getCFG()) {}
1715 
1716   void Profile(llvm::FoldingSetNodeID &ID) const override {
1717     static int x = 0;
1718     ID.AddPointer(&x);
1719   }
1720 
1721   PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
1722                                    BugReporterContext &BRC,
1723                                    PathSensitiveBugReport &BR) override;
1724 };
1725 } // end of anonymous namespace
1726 
1727 static std::shared_ptr<PathDiagnosticEventPiece>
1728 constructDebugPieceForTrackedCondition(const Expr *Cond,
1729                                        const ExplodedNode *N,
1730                                        BugReporterContext &BRC) {
1731 
1732   if (BRC.getAnalyzerOptions().AnalysisDiagOpt == PD_NONE ||
1733       !BRC.getAnalyzerOptions().ShouldTrackConditionsDebug)
1734     return nullptr;
1735 
1736   std::string ConditionText = Lexer::getSourceText(
1737       CharSourceRange::getTokenRange(Cond->getSourceRange()),
1738                                      BRC.getSourceManager(),
1739                                      BRC.getASTContext().getLangOpts());
1740 
1741   return std::make_shared<PathDiagnosticEventPiece>(
1742       PathDiagnosticLocation::createBegin(
1743           Cond, BRC.getSourceManager(), N->getLocationContext()),
1744           (Twine() + "Tracking condition '" + ConditionText + "'").str());
1745 }
1746 
1747 static bool isAssertlikeBlock(const CFGBlock *B, ASTContext &Context) {
1748   if (B->succ_size() != 2)
1749     return false;
1750 
1751   const CFGBlock *Then = B->succ_begin()->getReachableBlock();
1752   const CFGBlock *Else = (B->succ_begin() + 1)->getReachableBlock();
1753 
1754   if (!Then || !Else)
1755     return false;
1756 
1757   if (Then->isInevitablySinking() != Else->isInevitablySinking())
1758     return true;
1759 
1760   // For the following condition the following CFG would be built:
1761   //
1762   //                          ------------->
1763   //                         /              \
1764   //                       [B1] -> [B2] -> [B3] -> [sink]
1765   // assert(A && B || C);            \       \
1766   //                                  -----------> [go on with the execution]
1767   //
1768   // It so happens that CFGBlock::getTerminatorCondition returns 'A' for block
1769   // B1, 'A && B' for B2, and 'A && B || C' for B3. Let's check whether we
1770   // reached the end of the condition!
1771   if (const Stmt *ElseCond = Else->getTerminatorCondition())
1772     if (const auto *BinOp = dyn_cast<BinaryOperator>(ElseCond))
1773       if (BinOp->isLogicalOp())
1774         return isAssertlikeBlock(Else, Context);
1775 
1776   return false;
1777 }
1778 
1779 PathDiagnosticPieceRef
1780 TrackControlDependencyCondBRVisitor::VisitNode(const ExplodedNode *N,
1781                                                BugReporterContext &BRC,
1782                                                PathSensitiveBugReport &BR) {
1783   // We can only reason about control dependencies within the same stack frame.
1784   if (Origin->getStackFrame() != N->getStackFrame())
1785     return nullptr;
1786 
1787   CFGBlock *NB = const_cast<CFGBlock *>(N->getCFGBlock());
1788 
1789   // Skip if we already inspected this block.
1790   if (!VisitedBlocks.insert(NB).second)
1791     return nullptr;
1792 
1793   CFGBlock *OriginB = const_cast<CFGBlock *>(Origin->getCFGBlock());
1794 
1795   // TODO: Cache CFGBlocks for each ExplodedNode.
1796   if (!OriginB || !NB)
1797     return nullptr;
1798 
1799   if (isAssertlikeBlock(NB, BRC.getASTContext()))
1800     return nullptr;
1801 
1802   if (ControlDeps.isControlDependent(OriginB, NB)) {
1803     // We don't really want to explain for range loops. Evidence suggests that
1804     // the only thing that leads to is the addition of calls to operator!=.
1805     if (isa<CXXForRangeStmt>(NB->getTerminator()))
1806       return nullptr;
1807 
1808     if (const Expr *Condition = NB->getLastCondition()) {
1809       // Keeping track of the already tracked conditions on a visitor level
1810       // isn't sufficient, because a new visitor is created for each tracked
1811       // expression, hence the BugReport level set.
1812       if (BR.addTrackedCondition(N)) {
1813         bugreporter::trackExpressionValue(
1814             N, Condition, BR, bugreporter::TrackingKind::Condition,
1815             /*EnableNullFPSuppression=*/false);
1816         return constructDebugPieceForTrackedCondition(Condition, N, BRC);
1817       }
1818     }
1819   }
1820 
1821   return nullptr;
1822 }
1823 
1824 //===----------------------------------------------------------------------===//
1825 // Implementation of trackExpressionValue.
1826 //===----------------------------------------------------------------------===//
1827 
1828 static const MemRegion *getLocationRegionIfReference(const Expr *E,
1829                                                      const ExplodedNode *N) {
1830   if (const auto *DR = dyn_cast<DeclRefExpr>(E)) {
1831     if (const auto *VD = dyn_cast<VarDecl>(DR->getDecl())) {
1832       if (!VD->getType()->isReferenceType())
1833         return nullptr;
1834       ProgramStateManager &StateMgr = N->getState()->getStateManager();
1835       MemRegionManager &MRMgr = StateMgr.getRegionManager();
1836       return MRMgr.getVarRegion(VD, N->getLocationContext());
1837     }
1838   }
1839 
1840   // FIXME: This does not handle other kinds of null references,
1841   // for example, references from FieldRegions:
1842   //   struct Wrapper { int &ref; };
1843   //   Wrapper w = { *(int *)0 };
1844   //   w.ref = 1;
1845 
1846   return nullptr;
1847 }
1848 
1849 /// \return A subexpression of {@code Ex} which represents the
1850 /// expression-of-interest.
1851 static const Expr *peelOffOuterExpr(const Expr *Ex,
1852                                     const ExplodedNode *N) {
1853   Ex = Ex->IgnoreParenCasts();
1854   if (const auto *FE = dyn_cast<FullExpr>(Ex))
1855     return peelOffOuterExpr(FE->getSubExpr(), N);
1856   if (const auto *OVE = dyn_cast<OpaqueValueExpr>(Ex))
1857     return peelOffOuterExpr(OVE->getSourceExpr(), N);
1858   if (const auto *POE = dyn_cast<PseudoObjectExpr>(Ex)) {
1859     const auto *PropRef = dyn_cast<ObjCPropertyRefExpr>(POE->getSyntacticForm());
1860     if (PropRef && PropRef->isMessagingGetter()) {
1861       const Expr *GetterMessageSend =
1862           POE->getSemanticExpr(POE->getNumSemanticExprs() - 1);
1863       assert(isa<ObjCMessageExpr>(GetterMessageSend->IgnoreParenCasts()));
1864       return peelOffOuterExpr(GetterMessageSend, N);
1865     }
1866   }
1867 
1868   // Peel off the ternary operator.
1869   if (const auto *CO = dyn_cast<ConditionalOperator>(Ex)) {
1870     // Find a node where the branching occurred and find out which branch
1871     // we took (true/false) by looking at the ExplodedGraph.
1872     const ExplodedNode *NI = N;
1873     do {
1874       ProgramPoint ProgPoint = NI->getLocation();
1875       if (Optional<BlockEdge> BE = ProgPoint.getAs<BlockEdge>()) {
1876         const CFGBlock *srcBlk = BE->getSrc();
1877         if (const Stmt *term = srcBlk->getTerminatorStmt()) {
1878           if (term == CO) {
1879             bool TookTrueBranch = (*(srcBlk->succ_begin()) == BE->getDst());
1880             if (TookTrueBranch)
1881               return peelOffOuterExpr(CO->getTrueExpr(), N);
1882             else
1883               return peelOffOuterExpr(CO->getFalseExpr(), N);
1884           }
1885         }
1886       }
1887       NI = NI->getFirstPred();
1888     } while (NI);
1889   }
1890 
1891   if (auto *BO = dyn_cast<BinaryOperator>(Ex))
1892     if (const Expr *SubEx = peelOffPointerArithmetic(BO))
1893       return peelOffOuterExpr(SubEx, N);
1894 
1895   if (auto *UO = dyn_cast<UnaryOperator>(Ex)) {
1896     if (UO->getOpcode() == UO_LNot)
1897       return peelOffOuterExpr(UO->getSubExpr(), N);
1898 
1899     // FIXME: There's a hack in our Store implementation that always computes
1900     // field offsets around null pointers as if they are always equal to 0.
1901     // The idea here is to report accesses to fields as null dereferences
1902     // even though the pointer value that's being dereferenced is actually
1903     // the offset of the field rather than exactly 0.
1904     // See the FIXME in StoreManager's getLValueFieldOrIvar() method.
1905     // This code interacts heavily with this hack; otherwise the value
1906     // would not be null at all for most fields, so we'd be unable to track it.
1907     if (UO->getOpcode() == UO_AddrOf && UO->getSubExpr()->isLValue())
1908       if (const Expr *DerefEx = bugreporter::getDerefExpr(UO->getSubExpr()))
1909         return peelOffOuterExpr(DerefEx, N);
1910   }
1911 
1912   return Ex;
1913 }
1914 
1915 /// Find the ExplodedNode where the lvalue (the value of 'Ex')
1916 /// was computed.
1917 static const ExplodedNode* findNodeForExpression(const ExplodedNode *N,
1918                                                  const Expr *Inner) {
1919   while (N) {
1920     if (N->getStmtForDiagnostics() == Inner)
1921       return N;
1922     N = N->getFirstPred();
1923   }
1924   return N;
1925 }
1926 
1927 bool bugreporter::trackExpressionValue(const ExplodedNode *InputNode,
1928                                        const Expr *E,
1929                                        PathSensitiveBugReport &report,
1930                                        bugreporter::TrackingKind TKind,
1931                                        bool EnableNullFPSuppression) {
1932 
1933   if (!E || !InputNode)
1934     return false;
1935 
1936   const Expr *Inner = peelOffOuterExpr(E, InputNode);
1937   const ExplodedNode *LVNode = findNodeForExpression(InputNode, Inner);
1938   if (!LVNode)
1939     return false;
1940 
1941   ProgramStateRef LVState = LVNode->getState();
1942   const StackFrameContext *SFC = LVNode->getStackFrame();
1943 
1944   // We only track expressions if we believe that they are important. Chances
1945   // are good that control dependencies to the tracking point are also improtant
1946   // because of this, let's explain why we believe control reached this point.
1947   // TODO: Shouldn't we track control dependencies of every bug location, rather
1948   // than only tracked expressions?
1949   if (LVState->getAnalysisManager().getAnalyzerOptions().ShouldTrackConditions)
1950     report.addVisitor(std::make_unique<TrackControlDependencyCondBRVisitor>(
1951           InputNode));
1952 
1953   // The message send could be nil due to the receiver being nil.
1954   // At this point in the path, the receiver should be live since we are at the
1955   // message send expr. If it is nil, start tracking it.
1956   if (const Expr *Receiver = NilReceiverBRVisitor::getNilReceiver(Inner, LVNode))
1957     trackExpressionValue(
1958         LVNode, Receiver, report, TKind, EnableNullFPSuppression);
1959 
1960   // Track the index if this is an array subscript.
1961   if (const auto *Arr = dyn_cast<ArraySubscriptExpr>(Inner))
1962     trackExpressionValue(
1963         LVNode, Arr->getIdx(), report, TKind, /*EnableNullFPSuppression*/false);
1964 
1965   // See if the expression we're interested refers to a variable.
1966   // If so, we can track both its contents and constraints on its value.
1967   if (ExplodedGraph::isInterestingLValueExpr(Inner)) {
1968     SVal LVal = LVNode->getSVal(Inner);
1969 
1970     const MemRegion *RR = getLocationRegionIfReference(Inner, LVNode);
1971     bool LVIsNull = LVState->isNull(LVal).isConstrainedTrue();
1972 
1973     // If this is a C++ reference to a null pointer, we are tracking the
1974     // pointer. In addition, we should find the store at which the reference
1975     // got initialized.
1976     if (RR && !LVIsNull)
1977       if (auto KV = LVal.getAs<KnownSVal>())
1978         report.addVisitor(std::make_unique<FindLastStoreBRVisitor>(
1979             *KV, RR, EnableNullFPSuppression, TKind, SFC));
1980 
1981     // In case of C++ references, we want to differentiate between a null
1982     // reference and reference to null pointer.
1983     // If the LVal is null, check if we are dealing with null reference.
1984     // For those, we want to track the location of the reference.
1985     const MemRegion *R = (RR && LVIsNull) ? RR :
1986         LVNode->getSVal(Inner).getAsRegion();
1987 
1988     if (R) {
1989 
1990       // Mark both the variable region and its contents as interesting.
1991       SVal V = LVState->getRawSVal(loc::MemRegionVal(R));
1992       report.addVisitor(
1993           std::make_unique<NoStoreFuncVisitor>(cast<SubRegion>(R), TKind));
1994 
1995       MacroNullReturnSuppressionVisitor::addMacroVisitorIfNecessary(
1996           LVNode, R, EnableNullFPSuppression, report, V);
1997 
1998       report.markInteresting(V, TKind);
1999       report.addVisitor(std::make_unique<UndefOrNullArgVisitor>(R));
2000 
2001       // If the contents are symbolic and null, find out when they became null.
2002       if (V.getAsLocSymbol(/*IncludeBaseRegions=*/true))
2003         if (LVState->isNull(V).isConstrainedTrue())
2004           report.addVisitor(std::make_unique<TrackConstraintBRVisitor>(
2005               V.castAs<DefinedSVal>(), false));
2006 
2007       // Add visitor, which will suppress inline defensive checks.
2008       if (auto DV = V.getAs<DefinedSVal>())
2009         if (!DV->isZeroConstant() && LVState->isNull(*DV).isConstrainedTrue() &&
2010             EnableNullFPSuppression)
2011           report.addVisitor(
2012               std::make_unique<SuppressInlineDefensiveChecksVisitor>(*DV,
2013                                                                       LVNode));
2014 
2015       if (auto KV = V.getAs<KnownSVal>())
2016         report.addVisitor(std::make_unique<FindLastStoreBRVisitor>(
2017             *KV, R, EnableNullFPSuppression, TKind, SFC));
2018       return true;
2019     }
2020   }
2021 
2022   // If the expression is not an "lvalue expression", we can still
2023   // track the constraints on its contents.
2024   SVal V = LVState->getSValAsScalarOrLoc(Inner, LVNode->getLocationContext());
2025 
2026   ReturnVisitor::addVisitorIfNecessary(
2027     LVNode, Inner, report, EnableNullFPSuppression, TKind);
2028 
2029   // Is it a symbolic value?
2030   if (auto L = V.getAs<loc::MemRegionVal>()) {
2031     report.addVisitor(std::make_unique<UndefOrNullArgVisitor>(L->getRegion()));
2032 
2033     // FIXME: this is a hack for fixing a later crash when attempting to
2034     // dereference a void* pointer.
2035     // We should not try to dereference pointers at all when we don't care
2036     // what is written inside the pointer.
2037     bool CanDereference = true;
2038     if (const auto *SR = L->getRegionAs<SymbolicRegion>()) {
2039       if (SR->getSymbol()->getType()->getPointeeType()->isVoidType())
2040         CanDereference = false;
2041     } else if (L->getRegionAs<AllocaRegion>())
2042       CanDereference = false;
2043 
2044     // At this point we are dealing with the region's LValue.
2045     // However, if the rvalue is a symbolic region, we should track it as well.
2046     // Try to use the correct type when looking up the value.
2047     SVal RVal;
2048     if (ExplodedGraph::isInterestingLValueExpr(Inner))
2049       RVal = LVState->getRawSVal(L.getValue(), Inner->getType());
2050     else if (CanDereference)
2051       RVal = LVState->getSVal(L->getRegion());
2052 
2053     if (CanDereference)
2054       if (auto KV = RVal.getAs<KnownSVal>())
2055         report.addVisitor(std::make_unique<FindLastStoreBRVisitor>(
2056             *KV, L->getRegion(), EnableNullFPSuppression, TKind, SFC));
2057 
2058     const MemRegion *RegionRVal = RVal.getAsRegion();
2059     if (RegionRVal && isa<SymbolicRegion>(RegionRVal)) {
2060       report.markInteresting(RegionRVal, TKind);
2061       report.addVisitor(std::make_unique<TrackConstraintBRVisitor>(
2062             loc::MemRegionVal(RegionRVal), /*assumption=*/false));
2063     }
2064   }
2065   return true;
2066 }
2067 
2068 //===----------------------------------------------------------------------===//
2069 // Implementation of NulReceiverBRVisitor.
2070 //===----------------------------------------------------------------------===//
2071 
2072 const Expr *NilReceiverBRVisitor::getNilReceiver(const Stmt *S,
2073                                                  const ExplodedNode *N) {
2074   const auto *ME = dyn_cast<ObjCMessageExpr>(S);
2075   if (!ME)
2076     return nullptr;
2077   if (const Expr *Receiver = ME->getInstanceReceiver()) {
2078     ProgramStateRef state = N->getState();
2079     SVal V = N->getSVal(Receiver);
2080     if (state->isNull(V).isConstrainedTrue())
2081       return Receiver;
2082   }
2083   return nullptr;
2084 }
2085 
2086 PathDiagnosticPieceRef
2087 NilReceiverBRVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
2088                                 PathSensitiveBugReport &BR) {
2089   Optional<PreStmt> P = N->getLocationAs<PreStmt>();
2090   if (!P)
2091     return nullptr;
2092 
2093   const Stmt *S = P->getStmt();
2094   const Expr *Receiver = getNilReceiver(S, N);
2095   if (!Receiver)
2096     return nullptr;
2097 
2098   llvm::SmallString<256> Buf;
2099   llvm::raw_svector_ostream OS(Buf);
2100 
2101   if (const auto *ME = dyn_cast<ObjCMessageExpr>(S)) {
2102     OS << "'";
2103     ME->getSelector().print(OS);
2104     OS << "' not called";
2105   }
2106   else {
2107     OS << "No method is called";
2108   }
2109   OS << " because the receiver is nil";
2110 
2111   // The receiver was nil, and hence the method was skipped.
2112   // Register a BugReporterVisitor to issue a message telling us how
2113   // the receiver was null.
2114   bugreporter::trackExpressionValue(
2115       N, Receiver, BR, bugreporter::TrackingKind::Thorough,
2116       /*EnableNullFPSuppression*/ false);
2117   // Issue a message saying that the method was skipped.
2118   PathDiagnosticLocation L(Receiver, BRC.getSourceManager(),
2119                                      N->getLocationContext());
2120   return std::make_shared<PathDiagnosticEventPiece>(L, OS.str());
2121 }
2122 
2123 //===----------------------------------------------------------------------===//
2124 // Visitor that tries to report interesting diagnostics from conditions.
2125 //===----------------------------------------------------------------------===//
2126 
2127 /// Return the tag associated with this visitor.  This tag will be used
2128 /// to make all PathDiagnosticPieces created by this visitor.
2129 const char *ConditionBRVisitor::getTag() { return "ConditionBRVisitor"; }
2130 
2131 PathDiagnosticPieceRef
2132 ConditionBRVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
2133                               PathSensitiveBugReport &BR) {
2134   auto piece = VisitNodeImpl(N, BRC, BR);
2135   if (piece) {
2136     piece->setTag(getTag());
2137     if (auto *ev = dyn_cast<PathDiagnosticEventPiece>(piece.get()))
2138       ev->setPrunable(true, /* override */ false);
2139   }
2140   return piece;
2141 }
2142 
2143 PathDiagnosticPieceRef
2144 ConditionBRVisitor::VisitNodeImpl(const ExplodedNode *N,
2145                                   BugReporterContext &BRC,
2146                                   PathSensitiveBugReport &BR) {
2147   ProgramPoint ProgPoint = N->getLocation();
2148   const std::pair<const ProgramPointTag *, const ProgramPointTag *> &Tags =
2149       ExprEngine::geteagerlyAssumeBinOpBifurcationTags();
2150 
2151   // If an assumption was made on a branch, it should be caught
2152   // here by looking at the state transition.
2153   if (Optional<BlockEdge> BE = ProgPoint.getAs<BlockEdge>()) {
2154     const CFGBlock *SrcBlock = BE->getSrc();
2155     if (const Stmt *Term = SrcBlock->getTerminatorStmt()) {
2156       // If the tag of the previous node is 'Eagerly Assume...' the current
2157       // 'BlockEdge' has the same constraint information. We do not want to
2158       // report the value as it is just an assumption on the predecessor node
2159       // which will be caught in the next VisitNode() iteration as a 'PostStmt'.
2160       const ProgramPointTag *PreviousNodeTag =
2161           N->getFirstPred()->getLocation().getTag();
2162       if (PreviousNodeTag == Tags.first || PreviousNodeTag == Tags.second)
2163         return nullptr;
2164 
2165       return VisitTerminator(Term, N, SrcBlock, BE->getDst(), BR, BRC);
2166     }
2167     return nullptr;
2168   }
2169 
2170   if (Optional<PostStmt> PS = ProgPoint.getAs<PostStmt>()) {
2171     const ProgramPointTag *CurrentNodeTag = PS->getTag();
2172     if (CurrentNodeTag != Tags.first && CurrentNodeTag != Tags.second)
2173       return nullptr;
2174 
2175     bool TookTrue = CurrentNodeTag == Tags.first;
2176     return VisitTrueTest(cast<Expr>(PS->getStmt()), BRC, BR, N, TookTrue);
2177   }
2178 
2179   return nullptr;
2180 }
2181 
2182 PathDiagnosticPieceRef ConditionBRVisitor::VisitTerminator(
2183     const Stmt *Term, const ExplodedNode *N, const CFGBlock *srcBlk,
2184     const CFGBlock *dstBlk, PathSensitiveBugReport &R,
2185     BugReporterContext &BRC) {
2186   const Expr *Cond = nullptr;
2187 
2188   // In the code below, Term is a CFG terminator and Cond is a branch condition
2189   // expression upon which the decision is made on this terminator.
2190   //
2191   // For example, in "if (x == 0)", the "if (x == 0)" statement is a terminator,
2192   // and "x == 0" is the respective condition.
2193   //
2194   // Another example: in "if (x && y)", we've got two terminators and two
2195   // conditions due to short-circuit nature of operator "&&":
2196   // 1. The "if (x && y)" statement is a terminator,
2197   //    and "y" is the respective condition.
2198   // 2. Also "x && ..." is another terminator,
2199   //    and "x" is its condition.
2200 
2201   switch (Term->getStmtClass()) {
2202   // FIXME: Stmt::SwitchStmtClass is worth handling, however it is a bit
2203   // more tricky because there are more than two branches to account for.
2204   default:
2205     return nullptr;
2206   case Stmt::IfStmtClass:
2207     Cond = cast<IfStmt>(Term)->getCond();
2208     break;
2209   case Stmt::ConditionalOperatorClass:
2210     Cond = cast<ConditionalOperator>(Term)->getCond();
2211     break;
2212   case Stmt::BinaryOperatorClass:
2213     // When we encounter a logical operator (&& or ||) as a CFG terminator,
2214     // then the condition is actually its LHS; otherwise, we'd encounter
2215     // the parent, such as if-statement, as a terminator.
2216     const auto *BO = cast<BinaryOperator>(Term);
2217     assert(BO->isLogicalOp() &&
2218            "CFG terminator is not a short-circuit operator!");
2219     Cond = BO->getLHS();
2220     break;
2221   }
2222 
2223   Cond = Cond->IgnoreParens();
2224 
2225   // However, when we encounter a logical operator as a branch condition,
2226   // then the condition is actually its RHS, because LHS would be
2227   // the condition for the logical operator terminator.
2228   while (const auto *InnerBO = dyn_cast<BinaryOperator>(Cond)) {
2229     if (!InnerBO->isLogicalOp())
2230       break;
2231     Cond = InnerBO->getRHS()->IgnoreParens();
2232   }
2233 
2234   assert(Cond);
2235   assert(srcBlk->succ_size() == 2);
2236   const bool TookTrue = *(srcBlk->succ_begin()) == dstBlk;
2237   return VisitTrueTest(Cond, BRC, R, N, TookTrue);
2238 }
2239 
2240 PathDiagnosticPieceRef
2241 ConditionBRVisitor::VisitTrueTest(const Expr *Cond, BugReporterContext &BRC,
2242                                   PathSensitiveBugReport &R,
2243                                   const ExplodedNode *N, bool TookTrue) {
2244   ProgramStateRef CurrentState = N->getState();
2245   ProgramStateRef PrevState = N->getFirstPred()->getState();
2246   const LocationContext *LCtx = N->getLocationContext();
2247 
2248   // If the constraint information is changed between the current and the
2249   // previous program state we assuming the newly seen constraint information.
2250   // If we cannot evaluate the condition (and the constraints are the same)
2251   // the analyzer has no information about the value and just assuming it.
2252   bool IsAssuming =
2253       !BRC.getStateManager().haveEqualConstraints(CurrentState, PrevState) ||
2254       CurrentState->getSVal(Cond, LCtx).isUnknownOrUndef();
2255 
2256   // These will be modified in code below, but we need to preserve the original
2257   //  values in case we want to throw the generic message.
2258   const Expr *CondTmp = Cond;
2259   bool TookTrueTmp = TookTrue;
2260 
2261   while (true) {
2262     CondTmp = CondTmp->IgnoreParenCasts();
2263     switch (CondTmp->getStmtClass()) {
2264       default:
2265         break;
2266       case Stmt::BinaryOperatorClass:
2267         if (auto P = VisitTrueTest(Cond, cast<BinaryOperator>(CondTmp),
2268                                    BRC, R, N, TookTrueTmp, IsAssuming))
2269           return P;
2270         break;
2271       case Stmt::DeclRefExprClass:
2272         if (auto P = VisitTrueTest(Cond, cast<DeclRefExpr>(CondTmp),
2273                                    BRC, R, N, TookTrueTmp, IsAssuming))
2274           return P;
2275         break;
2276       case Stmt::MemberExprClass:
2277         if (auto P = VisitTrueTest(Cond, cast<MemberExpr>(CondTmp),
2278                                    BRC, R, N, TookTrueTmp, IsAssuming))
2279           return P;
2280         break;
2281       case Stmt::UnaryOperatorClass: {
2282         const auto *UO = cast<UnaryOperator>(CondTmp);
2283         if (UO->getOpcode() == UO_LNot) {
2284           TookTrueTmp = !TookTrueTmp;
2285           CondTmp = UO->getSubExpr();
2286           continue;
2287         }
2288         break;
2289       }
2290     }
2291     break;
2292   }
2293 
2294   // Condition too complex to explain? Just say something so that the user
2295   // knew we've made some path decision at this point.
2296   // If it is too complex and we know the evaluation of the condition do not
2297   // repeat the note from 'BugReporter.cpp'
2298   if (!IsAssuming)
2299     return nullptr;
2300 
2301   PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
2302   if (!Loc.isValid() || !Loc.asLocation().isValid())
2303     return nullptr;
2304 
2305   return std::make_shared<PathDiagnosticEventPiece>(
2306       Loc, TookTrue ? GenericTrueMessage : GenericFalseMessage);
2307 }
2308 
2309 bool ConditionBRVisitor::patternMatch(const Expr *Ex,
2310                                       const Expr *ParentEx,
2311                                       raw_ostream &Out,
2312                                       BugReporterContext &BRC,
2313                                       PathSensitiveBugReport &report,
2314                                       const ExplodedNode *N,
2315                                       Optional<bool> &prunable,
2316                                       bool IsSameFieldName) {
2317   const Expr *OriginalExpr = Ex;
2318   Ex = Ex->IgnoreParenCasts();
2319 
2320   if (isa<GNUNullExpr>(Ex) || isa<ObjCBoolLiteralExpr>(Ex) ||
2321       isa<CXXBoolLiteralExpr>(Ex) || isa<IntegerLiteral>(Ex) ||
2322       isa<FloatingLiteral>(Ex)) {
2323     // Use heuristics to determine if the expression is a macro
2324     // expanding to a literal and if so, use the macro's name.
2325     SourceLocation BeginLoc = OriginalExpr->getBeginLoc();
2326     SourceLocation EndLoc = OriginalExpr->getEndLoc();
2327     if (BeginLoc.isMacroID() && EndLoc.isMacroID()) {
2328       const SourceManager &SM = BRC.getSourceManager();
2329       const LangOptions &LO = BRC.getASTContext().getLangOpts();
2330       if (Lexer::isAtStartOfMacroExpansion(BeginLoc, SM, LO) &&
2331           Lexer::isAtEndOfMacroExpansion(EndLoc, SM, LO)) {
2332         CharSourceRange R = Lexer::getAsCharRange({BeginLoc, EndLoc}, SM, LO);
2333         Out << Lexer::getSourceText(R, SM, LO);
2334         return false;
2335       }
2336     }
2337   }
2338 
2339   if (const auto *DR = dyn_cast<DeclRefExpr>(Ex)) {
2340     const bool quotes = isa<VarDecl>(DR->getDecl());
2341     if (quotes) {
2342       Out << '\'';
2343       const LocationContext *LCtx = N->getLocationContext();
2344       const ProgramState *state = N->getState().get();
2345       if (const MemRegion *R = state->getLValue(cast<VarDecl>(DR->getDecl()),
2346                                                 LCtx).getAsRegion()) {
2347         if (report.isInteresting(R))
2348           prunable = false;
2349         else {
2350           const ProgramState *state = N->getState().get();
2351           SVal V = state->getSVal(R);
2352           if (report.isInteresting(V))
2353             prunable = false;
2354         }
2355       }
2356     }
2357     Out << DR->getDecl()->getDeclName().getAsString();
2358     if (quotes)
2359       Out << '\'';
2360     return quotes;
2361   }
2362 
2363   if (const auto *IL = dyn_cast<IntegerLiteral>(Ex)) {
2364     QualType OriginalTy = OriginalExpr->getType();
2365     if (OriginalTy->isPointerType()) {
2366       if (IL->getValue() == 0) {
2367         Out << "null";
2368         return false;
2369       }
2370     }
2371     else if (OriginalTy->isObjCObjectPointerType()) {
2372       if (IL->getValue() == 0) {
2373         Out << "nil";
2374         return false;
2375       }
2376     }
2377 
2378     Out << IL->getValue();
2379     return false;
2380   }
2381 
2382   if (const auto *ME = dyn_cast<MemberExpr>(Ex)) {
2383     if (!IsSameFieldName)
2384       Out << "field '" << ME->getMemberDecl()->getName() << '\'';
2385     else
2386       Out << '\''
2387           << Lexer::getSourceText(
2388                  CharSourceRange::getTokenRange(Ex->getSourceRange()),
2389                  BRC.getSourceManager(), BRC.getASTContext().getLangOpts(), 0)
2390           << '\'';
2391   }
2392 
2393   return false;
2394 }
2395 
2396 PathDiagnosticPieceRef ConditionBRVisitor::VisitTrueTest(
2397     const Expr *Cond, const BinaryOperator *BExpr, BugReporterContext &BRC,
2398     PathSensitiveBugReport &R, const ExplodedNode *N, bool TookTrue,
2399     bool IsAssuming) {
2400   bool shouldInvert = false;
2401   Optional<bool> shouldPrune;
2402 
2403   // Check if the field name of the MemberExprs is ambiguous. Example:
2404   // " 'a.d' is equal to 'h.d' " in 'test/Analysis/null-deref-path-notes.cpp'.
2405   bool IsSameFieldName = false;
2406   const auto *LhsME = dyn_cast<MemberExpr>(BExpr->getLHS()->IgnoreParenCasts());
2407   const auto *RhsME = dyn_cast<MemberExpr>(BExpr->getRHS()->IgnoreParenCasts());
2408 
2409   if (LhsME && RhsME)
2410     IsSameFieldName =
2411         LhsME->getMemberDecl()->getName() == RhsME->getMemberDecl()->getName();
2412 
2413   SmallString<128> LhsString, RhsString;
2414   {
2415     llvm::raw_svector_ostream OutLHS(LhsString), OutRHS(RhsString);
2416     const bool isVarLHS = patternMatch(BExpr->getLHS(), BExpr, OutLHS, BRC, R,
2417                                        N, shouldPrune, IsSameFieldName);
2418     const bool isVarRHS = patternMatch(BExpr->getRHS(), BExpr, OutRHS, BRC, R,
2419                                        N, shouldPrune, IsSameFieldName);
2420 
2421     shouldInvert = !isVarLHS && isVarRHS;
2422   }
2423 
2424   BinaryOperator::Opcode Op = BExpr->getOpcode();
2425 
2426   if (BinaryOperator::isAssignmentOp(Op)) {
2427     // For assignment operators, all that we care about is that the LHS
2428     // evaluates to "true" or "false".
2429     return VisitConditionVariable(LhsString, BExpr->getLHS(), BRC, R, N,
2430                                   TookTrue);
2431   }
2432 
2433   // For non-assignment operations, we require that we can understand
2434   // both the LHS and RHS.
2435   if (LhsString.empty() || RhsString.empty() ||
2436       !BinaryOperator::isComparisonOp(Op) || Op == BO_Cmp)
2437     return nullptr;
2438 
2439   // Should we invert the strings if the LHS is not a variable name?
2440   SmallString<256> buf;
2441   llvm::raw_svector_ostream Out(buf);
2442   Out << (IsAssuming ? "Assuming " : "")
2443       << (shouldInvert ? RhsString : LhsString) << " is ";
2444 
2445   // Do we need to invert the opcode?
2446   if (shouldInvert)
2447     switch (Op) {
2448       default: break;
2449       case BO_LT: Op = BO_GT; break;
2450       case BO_GT: Op = BO_LT; break;
2451       case BO_LE: Op = BO_GE; break;
2452       case BO_GE: Op = BO_LE; break;
2453     }
2454 
2455   if (!TookTrue)
2456     switch (Op) {
2457       case BO_EQ: Op = BO_NE; break;
2458       case BO_NE: Op = BO_EQ; break;
2459       case BO_LT: Op = BO_GE; break;
2460       case BO_GT: Op = BO_LE; break;
2461       case BO_LE: Op = BO_GT; break;
2462       case BO_GE: Op = BO_LT; break;
2463       default:
2464         return nullptr;
2465     }
2466 
2467   switch (Op) {
2468     case BO_EQ:
2469       Out << "equal to ";
2470       break;
2471     case BO_NE:
2472       Out << "not equal to ";
2473       break;
2474     default:
2475       Out << BinaryOperator::getOpcodeStr(Op) << ' ';
2476       break;
2477   }
2478 
2479   Out << (shouldInvert ? LhsString : RhsString);
2480   const LocationContext *LCtx = N->getLocationContext();
2481   const SourceManager &SM = BRC.getSourceManager();
2482 
2483   if (isVarAnInterestingCondition(BExpr->getLHS(), N, &R) ||
2484       isVarAnInterestingCondition(BExpr->getRHS(), N, &R))
2485     Out << WillBeUsedForACondition;
2486 
2487   // Convert 'field ...' to 'Field ...' if it is a MemberExpr.
2488   std::string Message = Out.str();
2489   Message[0] = toupper(Message[0]);
2490 
2491   // If we know the value create a pop-up note to the value part of 'BExpr'.
2492   if (!IsAssuming) {
2493     PathDiagnosticLocation Loc;
2494     if (!shouldInvert) {
2495       if (LhsME && LhsME->getMemberLoc().isValid())
2496         Loc = PathDiagnosticLocation(LhsME->getMemberLoc(), SM);
2497       else
2498         Loc = PathDiagnosticLocation(BExpr->getLHS(), SM, LCtx);
2499     } else {
2500       if (RhsME && RhsME->getMemberLoc().isValid())
2501         Loc = PathDiagnosticLocation(RhsME->getMemberLoc(), SM);
2502       else
2503         Loc = PathDiagnosticLocation(BExpr->getRHS(), SM, LCtx);
2504     }
2505 
2506     return std::make_shared<PathDiagnosticPopUpPiece>(Loc, Message);
2507   }
2508 
2509   PathDiagnosticLocation Loc(Cond, SM, LCtx);
2510   auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Message);
2511   if (shouldPrune.hasValue())
2512     event->setPrunable(shouldPrune.getValue());
2513   return event;
2514 }
2515 
2516 PathDiagnosticPieceRef ConditionBRVisitor::VisitConditionVariable(
2517     StringRef LhsString, const Expr *CondVarExpr, BugReporterContext &BRC,
2518     PathSensitiveBugReport &report, const ExplodedNode *N, bool TookTrue) {
2519   // FIXME: If there's already a constraint tracker for this variable,
2520   // we shouldn't emit anything here (c.f. the double note in
2521   // test/Analysis/inlining/path-notes.c)
2522   SmallString<256> buf;
2523   llvm::raw_svector_ostream Out(buf);
2524   Out << "Assuming " << LhsString << " is ";
2525 
2526   if (!printValue(CondVarExpr, Out, N, TookTrue, /*IsAssuming=*/true))
2527     return nullptr;
2528 
2529   const LocationContext *LCtx = N->getLocationContext();
2530   PathDiagnosticLocation Loc(CondVarExpr, BRC.getSourceManager(), LCtx);
2531 
2532   if (isVarAnInterestingCondition(CondVarExpr, N, &report))
2533     Out << WillBeUsedForACondition;
2534 
2535   auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Out.str());
2536 
2537   if (isInterestingExpr(CondVarExpr, N, &report))
2538     event->setPrunable(false);
2539 
2540   return event;
2541 }
2542 
2543 PathDiagnosticPieceRef ConditionBRVisitor::VisitTrueTest(
2544     const Expr *Cond, const DeclRefExpr *DRE, BugReporterContext &BRC,
2545     PathSensitiveBugReport &report, const ExplodedNode *N, bool TookTrue,
2546     bool IsAssuming) {
2547   const auto *VD = dyn_cast<VarDecl>(DRE->getDecl());
2548   if (!VD)
2549     return nullptr;
2550 
2551   SmallString<256> Buf;
2552   llvm::raw_svector_ostream Out(Buf);
2553 
2554   Out << (IsAssuming ? "Assuming '" : "'") << VD->getDeclName() << "' is ";
2555 
2556   if (!printValue(DRE, Out, N, TookTrue, IsAssuming))
2557     return nullptr;
2558 
2559   const LocationContext *LCtx = N->getLocationContext();
2560 
2561   if (isVarAnInterestingCondition(DRE, N, &report))
2562     Out << WillBeUsedForACondition;
2563 
2564   // If we know the value create a pop-up note to the 'DRE'.
2565   if (!IsAssuming) {
2566     PathDiagnosticLocation Loc(DRE, BRC.getSourceManager(), LCtx);
2567     return std::make_shared<PathDiagnosticPopUpPiece>(Loc, Out.str());
2568   }
2569 
2570   PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
2571   auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Out.str());
2572 
2573   if (isInterestingExpr(DRE, N, &report))
2574     event->setPrunable(false);
2575 
2576   return std::move(event);
2577 }
2578 
2579 PathDiagnosticPieceRef ConditionBRVisitor::VisitTrueTest(
2580     const Expr *Cond, const MemberExpr *ME, BugReporterContext &BRC,
2581     PathSensitiveBugReport &report, const ExplodedNode *N, bool TookTrue,
2582     bool IsAssuming) {
2583   SmallString<256> Buf;
2584   llvm::raw_svector_ostream Out(Buf);
2585 
2586   Out << (IsAssuming ? "Assuming field '" : "Field '")
2587       << ME->getMemberDecl()->getName() << "' is ";
2588 
2589   if (!printValue(ME, Out, N, TookTrue, IsAssuming))
2590     return nullptr;
2591 
2592   const LocationContext *LCtx = N->getLocationContext();
2593   PathDiagnosticLocation Loc;
2594 
2595   // If we know the value create a pop-up note to the member of the MemberExpr.
2596   if (!IsAssuming && ME->getMemberLoc().isValid())
2597     Loc = PathDiagnosticLocation(ME->getMemberLoc(), BRC.getSourceManager());
2598   else
2599     Loc = PathDiagnosticLocation(Cond, BRC.getSourceManager(), LCtx);
2600 
2601   if (!Loc.isValid() || !Loc.asLocation().isValid())
2602     return nullptr;
2603 
2604   if (isVarAnInterestingCondition(ME, N, &report))
2605     Out << WillBeUsedForACondition;
2606 
2607   // If we know the value create a pop-up note.
2608   if (!IsAssuming)
2609     return std::make_shared<PathDiagnosticPopUpPiece>(Loc, Out.str());
2610 
2611   auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Out.str());
2612   if (isInterestingExpr(ME, N, &report))
2613     event->setPrunable(false);
2614   return event;
2615 }
2616 
2617 bool ConditionBRVisitor::printValue(const Expr *CondVarExpr, raw_ostream &Out,
2618                                     const ExplodedNode *N, bool TookTrue,
2619                                     bool IsAssuming) {
2620   QualType Ty = CondVarExpr->getType();
2621 
2622   if (Ty->isPointerType()) {
2623     Out << (TookTrue ? "non-null" : "null");
2624     return true;
2625   }
2626 
2627   if (Ty->isObjCObjectPointerType()) {
2628     Out << (TookTrue ? "non-nil" : "nil");
2629     return true;
2630   }
2631 
2632   if (!Ty->isIntegralOrEnumerationType())
2633     return false;
2634 
2635   Optional<const llvm::APSInt *> IntValue;
2636   if (!IsAssuming)
2637     IntValue = getConcreteIntegerValue(CondVarExpr, N);
2638 
2639   if (IsAssuming || !IntValue.hasValue()) {
2640     if (Ty->isBooleanType())
2641       Out << (TookTrue ? "true" : "false");
2642     else
2643       Out << (TookTrue ? "not equal to 0" : "0");
2644   } else {
2645     if (Ty->isBooleanType())
2646       Out << (IntValue.getValue()->getBoolValue() ? "true" : "false");
2647     else
2648       Out << *IntValue.getValue();
2649   }
2650 
2651   return true;
2652 }
2653 
2654 constexpr llvm::StringLiteral ConditionBRVisitor::GenericTrueMessage;
2655 constexpr llvm::StringLiteral ConditionBRVisitor::GenericFalseMessage;
2656 
2657 bool ConditionBRVisitor::isPieceMessageGeneric(
2658     const PathDiagnosticPiece *Piece) {
2659   return Piece->getString() == GenericTrueMessage ||
2660          Piece->getString() == GenericFalseMessage;
2661 }
2662 
2663 //===----------------------------------------------------------------------===//
2664 // Implementation of LikelyFalsePositiveSuppressionBRVisitor.
2665 //===----------------------------------------------------------------------===//
2666 
2667 void LikelyFalsePositiveSuppressionBRVisitor::finalizeVisitor(
2668     BugReporterContext &BRC, const ExplodedNode *N,
2669     PathSensitiveBugReport &BR) {
2670   // Here we suppress false positives coming from system headers. This list is
2671   // based on known issues.
2672   const AnalyzerOptions &Options = BRC.getAnalyzerOptions();
2673   const Decl *D = N->getLocationContext()->getDecl();
2674 
2675   if (AnalysisDeclContext::isInStdNamespace(D)) {
2676     // Skip reports within the 'std' namespace. Although these can sometimes be
2677     // the user's fault, we currently don't report them very well, and
2678     // Note that this will not help for any other data structure libraries, like
2679     // TR1, Boost, or llvm/ADT.
2680     if (Options.ShouldSuppressFromCXXStandardLibrary) {
2681       BR.markInvalid(getTag(), nullptr);
2682       return;
2683     } else {
2684       // If the complete 'std' suppression is not enabled, suppress reports
2685       // from the 'std' namespace that are known to produce false positives.
2686 
2687       // The analyzer issues a false use-after-free when std::list::pop_front
2688       // or std::list::pop_back are called multiple times because we cannot
2689       // reason about the internal invariants of the data structure.
2690       if (const auto *MD = dyn_cast<CXXMethodDecl>(D)) {
2691         const CXXRecordDecl *CD = MD->getParent();
2692         if (CD->getName() == "list") {
2693           BR.markInvalid(getTag(), nullptr);
2694           return;
2695         }
2696       }
2697 
2698       // The analyzer issues a false positive when the constructor of
2699       // std::__independent_bits_engine from algorithms is used.
2700       if (const auto *MD = dyn_cast<CXXConstructorDecl>(D)) {
2701         const CXXRecordDecl *CD = MD->getParent();
2702         if (CD->getName() == "__independent_bits_engine") {
2703           BR.markInvalid(getTag(), nullptr);
2704           return;
2705         }
2706       }
2707 
2708       for (const LocationContext *LCtx = N->getLocationContext(); LCtx;
2709            LCtx = LCtx->getParent()) {
2710         const auto *MD = dyn_cast<CXXMethodDecl>(LCtx->getDecl());
2711         if (!MD)
2712           continue;
2713 
2714         const CXXRecordDecl *CD = MD->getParent();
2715         // The analyzer issues a false positive on
2716         //   std::basic_string<uint8_t> v; v.push_back(1);
2717         // and
2718         //   std::u16string s; s += u'a';
2719         // because we cannot reason about the internal invariants of the
2720         // data structure.
2721         if (CD->getName() == "basic_string") {
2722           BR.markInvalid(getTag(), nullptr);
2723           return;
2724         }
2725 
2726         // The analyzer issues a false positive on
2727         //    std::shared_ptr<int> p(new int(1)); p = nullptr;
2728         // because it does not reason properly about temporary destructors.
2729         if (CD->getName() == "shared_ptr") {
2730           BR.markInvalid(getTag(), nullptr);
2731           return;
2732         }
2733       }
2734     }
2735   }
2736 
2737   // Skip reports within the sys/queue.h macros as we do not have the ability to
2738   // reason about data structure shapes.
2739   const SourceManager &SM = BRC.getSourceManager();
2740   FullSourceLoc Loc = BR.getLocation().asLocation();
2741   while (Loc.isMacroID()) {
2742     Loc = Loc.getSpellingLoc();
2743     if (SM.getFilename(Loc).endswith("sys/queue.h")) {
2744       BR.markInvalid(getTag(), nullptr);
2745       return;
2746     }
2747   }
2748 }
2749 
2750 //===----------------------------------------------------------------------===//
2751 // Implementation of UndefOrNullArgVisitor.
2752 //===----------------------------------------------------------------------===//
2753 
2754 PathDiagnosticPieceRef
2755 UndefOrNullArgVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
2756                                  PathSensitiveBugReport &BR) {
2757   ProgramStateRef State = N->getState();
2758   ProgramPoint ProgLoc = N->getLocation();
2759 
2760   // We are only interested in visiting CallEnter nodes.
2761   Optional<CallEnter> CEnter = ProgLoc.getAs<CallEnter>();
2762   if (!CEnter)
2763     return nullptr;
2764 
2765   // Check if one of the arguments is the region the visitor is tracking.
2766   CallEventManager &CEMgr = BRC.getStateManager().getCallEventManager();
2767   CallEventRef<> Call = CEMgr.getCaller(CEnter->getCalleeContext(), State);
2768   unsigned Idx = 0;
2769   ArrayRef<ParmVarDecl *> parms = Call->parameters();
2770 
2771   for (const auto ParamDecl : parms) {
2772     const MemRegion *ArgReg = Call->getArgSVal(Idx).getAsRegion();
2773     ++Idx;
2774 
2775     // Are we tracking the argument or its subregion?
2776     if ( !ArgReg || !R->isSubRegionOf(ArgReg->StripCasts()))
2777       continue;
2778 
2779     // Check the function parameter type.
2780     assert(ParamDecl && "Formal parameter has no decl?");
2781     QualType T = ParamDecl->getType();
2782 
2783     if (!(T->isAnyPointerType() || T->isReferenceType())) {
2784       // Function can only change the value passed in by address.
2785       continue;
2786     }
2787 
2788     // If it is a const pointer value, the function does not intend to
2789     // change the value.
2790     if (T->getPointeeType().isConstQualified())
2791       continue;
2792 
2793     // Mark the call site (LocationContext) as interesting if the value of the
2794     // argument is undefined or '0'/'NULL'.
2795     SVal BoundVal = State->getSVal(R);
2796     if (BoundVal.isUndef() || BoundVal.isZeroConstant()) {
2797       BR.markInteresting(CEnter->getCalleeContext());
2798       return nullptr;
2799     }
2800   }
2801   return nullptr;
2802 }
2803 
2804 //===----------------------------------------------------------------------===//
2805 // Implementation of FalsePositiveRefutationBRVisitor.
2806 //===----------------------------------------------------------------------===//
2807 
2808 FalsePositiveRefutationBRVisitor::FalsePositiveRefutationBRVisitor()
2809     : Constraints(ConstraintRangeTy::Factory().getEmptyMap()) {}
2810 
2811 void FalsePositiveRefutationBRVisitor::finalizeVisitor(
2812     BugReporterContext &BRC, const ExplodedNode *EndPathNode,
2813     PathSensitiveBugReport &BR) {
2814   // Collect new constraints
2815   VisitNode(EndPathNode, BRC, BR);
2816 
2817   // Create a refutation manager
2818   llvm::SMTSolverRef RefutationSolver = llvm::CreateZ3Solver();
2819   ASTContext &Ctx = BRC.getASTContext();
2820 
2821   // Add constraints to the solver
2822   for (const auto &I : Constraints) {
2823     const SymbolRef Sym = I.first;
2824     auto RangeIt = I.second.begin();
2825 
2826     llvm::SMTExprRef Constraints = SMTConv::getRangeExpr(
2827         RefutationSolver, Ctx, Sym, RangeIt->From(), RangeIt->To(),
2828         /*InRange=*/true);
2829     while ((++RangeIt) != I.second.end()) {
2830       Constraints = RefutationSolver->mkOr(
2831           Constraints, SMTConv::getRangeExpr(RefutationSolver, Ctx, Sym,
2832                                              RangeIt->From(), RangeIt->To(),
2833                                              /*InRange=*/true));
2834     }
2835 
2836     RefutationSolver->addConstraint(Constraints);
2837   }
2838 
2839   // And check for satisfiability
2840   Optional<bool> isSat = RefutationSolver->check();
2841   if (!isSat.hasValue())
2842     return;
2843 
2844   if (!isSat.getValue())
2845     BR.markInvalid("Infeasible constraints", EndPathNode->getLocationContext());
2846 }
2847 
2848 PathDiagnosticPieceRef FalsePositiveRefutationBRVisitor::VisitNode(
2849     const ExplodedNode *N, BugReporterContext &, PathSensitiveBugReport &) {
2850   // Collect new constraints
2851   const ConstraintRangeTy &NewCs = N->getState()->get<ConstraintRange>();
2852   ConstraintRangeTy::Factory &CF =
2853       N->getState()->get_context<ConstraintRange>();
2854 
2855   // Add constraints if we don't have them yet
2856   for (auto const &C : NewCs) {
2857     const SymbolRef &Sym = C.first;
2858     if (!Constraints.contains(Sym)) {
2859       Constraints = CF.add(Constraints, Sym, C.second);
2860     }
2861   }
2862 
2863   return nullptr;
2864 }
2865 
2866 void FalsePositiveRefutationBRVisitor::Profile(
2867     llvm::FoldingSetNodeID &ID) const {
2868   static int Tag = 0;
2869   ID.AddPointer(&Tag);
2870 }
2871 
2872 //===----------------------------------------------------------------------===//
2873 // Implementation of TagVisitor.
2874 //===----------------------------------------------------------------------===//
2875 
2876 int NoteTag::Kind = 0;
2877 
2878 void TagVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
2879   static int Tag = 0;
2880   ID.AddPointer(&Tag);
2881 }
2882 
2883 PathDiagnosticPieceRef TagVisitor::VisitNode(const ExplodedNode *N,
2884                                              BugReporterContext &BRC,
2885                                              PathSensitiveBugReport &R) {
2886   ProgramPoint PP = N->getLocation();
2887   const NoteTag *T = dyn_cast_or_null<NoteTag>(PP.getTag());
2888   if (!T)
2889     return nullptr;
2890 
2891   if (Optional<std::string> Msg = T->generateMessage(BRC, R)) {
2892     PathDiagnosticLocation Loc =
2893         PathDiagnosticLocation::create(PP, BRC.getSourceManager());
2894     auto Piece = std::make_shared<PathDiagnosticEventPiece>(Loc, *Msg);
2895     Piece->setPrunable(T->isPrunable());
2896     return Piece;
2897   }
2898 
2899   return nullptr;
2900 }
2901