19f103a1aSEugene Zelenko //===- BugReporterVisitors.cpp - Helpers for reporting bugs ---------------===//
2fa0734ecSArgyrios Kyrtzidis //
32946cd70SChandler Carruth // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
42946cd70SChandler Carruth // See https://llvm.org/LICENSE.txt for license information.
52946cd70SChandler Carruth // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6fa0734ecSArgyrios Kyrtzidis //
7fa0734ecSArgyrios Kyrtzidis //===----------------------------------------------------------------------===//
8fa0734ecSArgyrios Kyrtzidis //
9fa0734ecSArgyrios Kyrtzidis // This file defines a set of BugReporter "visitors" which can be used to
10fa0734ecSArgyrios Kyrtzidis // enhance the diagnostics reported for a bug.
11fa0734ecSArgyrios Kyrtzidis //
12fa0734ecSArgyrios Kyrtzidis //===----------------------------------------------------------------------===//
139f103a1aSEugene Zelenko
140c3a7c20SGeorge Karpenkov #include "clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h"
159f103a1aSEugene Zelenko #include "clang/AST/ASTContext.h"
169f103a1aSEugene Zelenko #include "clang/AST/Decl.h"
179f103a1aSEugene Zelenko #include "clang/AST/DeclBase.h"
189f103a1aSEugene Zelenko #include "clang/AST/DeclCXX.h"
19fa0734ecSArgyrios Kyrtzidis #include "clang/AST/Expr.h"
209f103a1aSEugene Zelenko #include "clang/AST/ExprCXX.h"
21fa0734ecSArgyrios Kyrtzidis #include "clang/AST/ExprObjC.h"
229f103a1aSEugene Zelenko #include "clang/AST/Stmt.h"
239f103a1aSEugene Zelenko #include "clang/AST/Type.h"
24b293c6bbSGeorge Karpenkov #include "clang/ASTMatchers/ASTMatchFinder.h"
25258e5e45SKristof Umann #include "clang/Analysis/Analyses/Dominators.h"
269f103a1aSEugene Zelenko #include "clang/Analysis/AnalysisDeclContext.h"
279f103a1aSEugene Zelenko #include "clang/Analysis/CFG.h"
284be27d4dSDevin Coughlin #include "clang/Analysis/CFGStmtMap.h"
29f0bb45faSArtem Dergachev #include "clang/Analysis/PathDiagnostic.h"
309f103a1aSEugene Zelenko #include "clang/Analysis/ProgramPoint.h"
319f103a1aSEugene Zelenko #include "clang/Basic/IdentifierTable.h"
329f103a1aSEugene Zelenko #include "clang/Basic/LLVM.h"
339f103a1aSEugene Zelenko #include "clang/Basic/SourceLocation.h"
349f103a1aSEugene Zelenko #include "clang/Basic/SourceManager.h"
3540c74c6dSAnna Zaks #include "clang/Lex/Lexer.h"
369f103a1aSEugene Zelenko #include "clang/StaticAnalyzer/Core/AnalyzerOptions.h"
37f8cbac4bSTed Kremenek #include "clang/StaticAnalyzer/Core/BugReporter/BugReporter.h"
389f103a1aSEugene Zelenko #include "clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h"
395d4ec363SAnna Zaks #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
403a02247dSChandler Carruth #include "clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h"
413a02247dSChandler Carruth #include "clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h"
429f103a1aSEugene Zelenko #include "clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h"
433a02247dSChandler Carruth #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h"
449f103a1aSEugene Zelenko #include "clang/StaticAnalyzer/Core/PathSensitive/ProgramState_Fwd.h"
45766a189dSMikhail R. Gadelha #include "clang/StaticAnalyzer/Core/PathSensitive/SMTConv.h"
469f103a1aSEugene Zelenko #include "clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h"
479f103a1aSEugene Zelenko #include "clang/StaticAnalyzer/Core/PathSensitive/SVals.h"
489f103a1aSEugene Zelenko #include "llvm/ADT/ArrayRef.h"
499f103a1aSEugene Zelenko #include "llvm/ADT/None.h"
509f103a1aSEugene Zelenko #include "llvm/ADT/Optional.h"
519f103a1aSEugene Zelenko #include "llvm/ADT/STLExtras.h"
529f103a1aSEugene Zelenko #include "llvm/ADT/SmallPtrSet.h"
534903802fSBenjamin Kramer #include "llvm/ADT/SmallString.h"
549f103a1aSEugene Zelenko #include "llvm/ADT/SmallVector.h"
55106b037aSJordan Rose #include "llvm/ADT/StringExtras.h"
569f103a1aSEugene Zelenko #include "llvm/ADT/StringRef.h"
579f103a1aSEugene Zelenko #include "llvm/Support/Casting.h"
589f103a1aSEugene Zelenko #include "llvm/Support/ErrorHandling.h"
59444a1304SBenjamin Kramer #include "llvm/Support/raw_ostream.h"
609f103a1aSEugene Zelenko #include <cassert>
619f103a1aSEugene Zelenko #include <deque>
629f103a1aSEugene Zelenko #include <memory>
639f103a1aSEugene Zelenko #include <string>
649f103a1aSEugene Zelenko #include <utility>
65fa0734ecSArgyrios Kyrtzidis
66fa0734ecSArgyrios Kyrtzidis using namespace clang;
67fa0734ecSArgyrios Kyrtzidis using namespace ento;
680cc3100bSValeriy Savchenko using namespace bugreporter;
69fa0734ecSArgyrios Kyrtzidis
70fa0734ecSArgyrios Kyrtzidis //===----------------------------------------------------------------------===//
71fa0734ecSArgyrios Kyrtzidis // Utility functions.
72fa0734ecSArgyrios Kyrtzidis //===----------------------------------------------------------------------===//
73fa0734ecSArgyrios Kyrtzidis
peelOffPointerArithmetic(const BinaryOperator * B)7495f9a68bSArtem Dergachev static const Expr *peelOffPointerArithmetic(const BinaryOperator *B) {
7595f9a68bSArtem Dergachev if (B->isAdditiveOp() && B->getType()->isPointerType()) {
7695f9a68bSArtem Dergachev if (B->getLHS()->getType()->isPointerType()) {
7795f9a68bSArtem Dergachev return B->getLHS();
7895f9a68bSArtem Dergachev } else if (B->getRHS()->getType()->isPointerType()) {
7995f9a68bSArtem Dergachev return B->getRHS();
8095f9a68bSArtem Dergachev }
8195f9a68bSArtem Dergachev }
8295f9a68bSArtem Dergachev return nullptr;
8395f9a68bSArtem Dergachev }
8495f9a68bSArtem Dergachev
85fd8e5762SKristóf Umann /// \return A subexpression of @c Ex which represents the
86fd8e5762SKristóf Umann /// expression-of-interest.
87fd8e5762SKristóf Umann static const Expr *peelOffOuterExpr(const Expr *Ex, const ExplodedNode *N);
88fd8e5762SKristóf Umann
892064e822SArtem Dergachev /// Given that expression S represents a pointer that would be dereferenced,
902064e822SArtem Dergachev /// try to find a sub-expression from which the pointer came from.
912064e822SArtem Dergachev /// This is used for tracking down origins of a null or undefined value:
922064e822SArtem Dergachev /// "this is null because that is null because that is null" etc.
932064e822SArtem Dergachev /// We wipe away field and element offsets because they merely add offsets.
942064e822SArtem Dergachev /// We also wipe away all casts except lvalue-to-rvalue casts, because the
952064e822SArtem Dergachev /// latter represent an actual pointer dereference; however, we remove
962064e822SArtem Dergachev /// the final lvalue-to-rvalue cast before returning from this function
972064e822SArtem Dergachev /// because it demonstrates more clearly from where the pointer rvalue was
982064e822SArtem Dergachev /// loaded. Examples:
992064e822SArtem Dergachev /// x->y.z ==> x (lvalue)
1002064e822SArtem Dergachev /// foo()->y.z ==> foo() (rvalue)
getDerefExpr(const Stmt * S)101c362edadSJordan Rose const Expr *bugreporter::getDerefExpr(const Stmt *S) {
1029f103a1aSEugene Zelenko const auto *E = dyn_cast<Expr>(S);
103c362edadSJordan Rose if (!E)
1040dbb783cSCraig Topper return nullptr;
105fa0734ecSArgyrios Kyrtzidis
106170641b0STed Kremenek while (true) {
1079f103a1aSEugene Zelenko if (const auto *CE = dyn_cast<CastExpr>(E)) {
1082064e822SArtem Dergachev if (CE->getCastKind() == CK_LValueToRValue) {
1092064e822SArtem Dergachev // This cast represents the load we're looking for.
110170641b0STed Kremenek break;
111170641b0STed Kremenek }
1122064e822SArtem Dergachev E = CE->getSubExpr();
1139f103a1aSEugene Zelenko } else if (const auto *B = dyn_cast<BinaryOperator>(E)) {
1148c800615SArtem Dergachev // Pointer arithmetic: '*(x + 2)' -> 'x') etc.
11595f9a68bSArtem Dergachev if (const Expr *Inner = peelOffPointerArithmetic(B)) {
11695f9a68bSArtem Dergachev E = Inner;
1178c800615SArtem Dergachev } else {
1182064e822SArtem Dergachev // Probably more arithmetic can be pattern-matched here,
1192064e822SArtem Dergachev // but for now give up.
1202064e822SArtem Dergachev break;
1218c800615SArtem Dergachev }
1229f103a1aSEugene Zelenko } else if (const auto *U = dyn_cast<UnaryOperator>(E)) {
1238c800615SArtem Dergachev if (U->getOpcode() == UO_Deref || U->getOpcode() == UO_AddrOf ||
1248c800615SArtem Dergachev (U->isIncrementDecrementOp() && U->getType()->isPointerType())) {
1252064e822SArtem Dergachev // Operators '*' and '&' don't actually mean anything.
1262064e822SArtem Dergachev // We look at casts instead.
1272064e822SArtem Dergachev E = U->getSubExpr();
1282064e822SArtem Dergachev } else {
1292064e822SArtem Dergachev // Probably more arithmetic can be pattern-matched here,
1302064e822SArtem Dergachev // but for now give up.
1312064e822SArtem Dergachev break;
1322064e822SArtem Dergachev }
1332064e822SArtem Dergachev }
1342064e822SArtem Dergachev // Pattern match for a few useful cases: a[0], p->f, *p etc.
1359f103a1aSEugene Zelenko else if (const auto *ME = dyn_cast<MemberExpr>(E)) {
1362064e822SArtem Dergachev E = ME->getBase();
1379f103a1aSEugene Zelenko } else if (const auto *IvarRef = dyn_cast<ObjCIvarRefExpr>(E)) {
1382064e822SArtem Dergachev E = IvarRef->getBase();
1399f103a1aSEugene Zelenko } else if (const auto *AE = dyn_cast<ArraySubscriptExpr>(E)) {
1402064e822SArtem Dergachev E = AE->getBase();
1419f103a1aSEugene Zelenko } else if (const auto *PE = dyn_cast<ParenExpr>(E)) {
1422064e822SArtem Dergachev E = PE->getSubExpr();
1437c44da27SBill Wendling } else if (const auto *FE = dyn_cast<FullExpr>(E)) {
1447c44da27SBill Wendling E = FE->getSubExpr();
1452064e822SArtem Dergachev } else {
1462064e822SArtem Dergachev // Other arbitrary stuff.
1472064e822SArtem Dergachev break;
1482064e822SArtem Dergachev }
1492064e822SArtem Dergachev }
150fa0734ecSArgyrios Kyrtzidis
1512064e822SArtem Dergachev // Special case: remove the final lvalue-to-rvalue cast, but do not recurse
1522064e822SArtem Dergachev // deeper into the sub-expression. This way we return the lvalue from which
1532064e822SArtem Dergachev // our pointer rvalue was loaded.
1549f103a1aSEugene Zelenko if (const auto *CE = dyn_cast<ImplicitCastExpr>(E))
1552064e822SArtem Dergachev if (CE->getCastKind() == CK_LValueToRValue)
1562064e822SArtem Dergachev E = CE->getSubExpr();
1572064e822SArtem Dergachev
1582064e822SArtem Dergachev return E;
159fa0734ecSArgyrios Kyrtzidis }
160fa0734ecSArgyrios Kyrtzidis
161ab582386SValeriy Savchenko static const MemRegion *
getLocationRegionIfReference(const Expr * E,const ExplodedNode * N,bool LookingForReference=true)162ab582386SValeriy Savchenko getLocationRegionIfReference(const Expr *E, const ExplodedNode *N,
163ab582386SValeriy Savchenko bool LookingForReference = true) {
164ab582386SValeriy Savchenko if (const auto *DR = dyn_cast<DeclRefExpr>(E)) {
165ab582386SValeriy Savchenko if (const auto *VD = dyn_cast<VarDecl>(DR->getDecl())) {
166ab582386SValeriy Savchenko if (LookingForReference && !VD->getType()->isReferenceType())
167ab582386SValeriy Savchenko return nullptr;
168ab582386SValeriy Savchenko return N->getState()
169ab582386SValeriy Savchenko ->getLValue(VD, N->getLocationContext())
170ab582386SValeriy Savchenko .getAsRegion();
171ab582386SValeriy Savchenko }
172ab582386SValeriy Savchenko }
173ab582386SValeriy Savchenko
174ab582386SValeriy Savchenko // FIXME: This does not handle other kinds of null references,
175ab582386SValeriy Savchenko // for example, references from FieldRegions:
176ab582386SValeriy Savchenko // struct Wrapper { int &ref; };
177ab582386SValeriy Savchenko // Wrapper w = { *(int *)0 };
178ab582386SValeriy Savchenko // w.ref = 1;
179ab582386SValeriy Savchenko
180ab582386SValeriy Savchenko return nullptr;
181ab582386SValeriy Savchenko }
182ab582386SValeriy Savchenko
1833bd63ae3SAdam Balogh /// Comparing internal representations of symbolic values (via
1843bd63ae3SAdam Balogh /// SVal::operator==()) is a valid way to check if the value was updated,
1853bd63ae3SAdam Balogh /// unless it's a LazyCompoundVal that may have a different internal
1863bd63ae3SAdam Balogh /// representation every time it is loaded from the state. In this function we
1873bd63ae3SAdam Balogh /// do an approximate comparison for lazy compound values, checking that they
1883bd63ae3SAdam Balogh /// are the immediate snapshots of the tracked region's bindings within the
1893bd63ae3SAdam Balogh /// node's respective states but not really checking that these snapshots
1903bd63ae3SAdam Balogh /// actually contain the same set of bindings.
hasVisibleUpdate(const ExplodedNode * LeftNode,SVal LeftVal,const ExplodedNode * RightNode,SVal RightVal)191ba2ea93aSBenjamin Kramer static bool hasVisibleUpdate(const ExplodedNode *LeftNode, SVal LeftVal,
1923bd63ae3SAdam Balogh const ExplodedNode *RightNode, SVal RightVal) {
1933bd63ae3SAdam Balogh if (LeftVal == RightVal)
1943bd63ae3SAdam Balogh return true;
1953bd63ae3SAdam Balogh
1963bd63ae3SAdam Balogh const auto LLCV = LeftVal.getAs<nonloc::LazyCompoundVal>();
1973bd63ae3SAdam Balogh if (!LLCV)
1983bd63ae3SAdam Balogh return false;
1993bd63ae3SAdam Balogh
2003bd63ae3SAdam Balogh const auto RLCV = RightVal.getAs<nonloc::LazyCompoundVal>();
2013bd63ae3SAdam Balogh if (!RLCV)
2023bd63ae3SAdam Balogh return false;
2033bd63ae3SAdam Balogh
2043bd63ae3SAdam Balogh return LLCV->getRegion() == RLCV->getRegion() &&
2053bd63ae3SAdam Balogh LLCV->getStore() == LeftNode->getState()->getStore() &&
2063bd63ae3SAdam Balogh RLCV->getStore() == RightNode->getState()->getStore();
2073bd63ae3SAdam Balogh }
2083bd63ae3SAdam Balogh
getSValForVar(const Expr * CondVarExpr,const ExplodedNode * N)20949ac7eceSKristof Umann static Optional<SVal> getSValForVar(const Expr *CondVarExpr,
21049ac7eceSKristof Umann const ExplodedNode *N) {
2114b0184b2SCsaba Dabis ProgramStateRef State = N->getState();
2124b0184b2SCsaba Dabis const LocationContext *LCtx = N->getLocationContext();
2134b0184b2SCsaba Dabis
21449ac7eceSKristof Umann assert(CondVarExpr);
21549ac7eceSKristof Umann CondVarExpr = CondVarExpr->IgnoreImpCasts();
21649ac7eceSKristof Umann
2174b0184b2SCsaba Dabis // The declaration of the value may rely on a pointer so take its l-value.
21849ac7eceSKristof Umann // FIXME: As seen in VisitCommonDeclRefExpr, sometimes DeclRefExpr may
21949ac7eceSKristof Umann // evaluate to a FieldRegion when it refers to a declaration of a lambda
22049ac7eceSKristof Umann // capture variable. We most likely need to duplicate that logic here.
22149ac7eceSKristof Umann if (const auto *DRE = dyn_cast<DeclRefExpr>(CondVarExpr))
22249ac7eceSKristof Umann if (const auto *VD = dyn_cast<VarDecl>(DRE->getDecl()))
22349ac7eceSKristof Umann return State->getSVal(State->getLValue(VD, LCtx));
22449ac7eceSKristof Umann
22549ac7eceSKristof Umann if (const auto *ME = dyn_cast<MemberExpr>(CondVarExpr))
22649ac7eceSKristof Umann if (const auto *FD = dyn_cast<FieldDecl>(ME->getMemberDecl()))
22749ac7eceSKristof Umann if (auto FieldL = State->getSVal(ME, LCtx).getAs<Loc>())
22849ac7eceSKristof Umann return State->getRawSVal(*FieldL, FD->getType());
22949ac7eceSKristof Umann
23049ac7eceSKristof Umann return None;
2314b0184b2SCsaba Dabis }
2324b0184b2SCsaba Dabis
23349ac7eceSKristof Umann static Optional<const llvm::APSInt *>
getConcreteIntegerValue(const Expr * CondVarExpr,const ExplodedNode * N)23449ac7eceSKristof Umann getConcreteIntegerValue(const Expr *CondVarExpr, const ExplodedNode *N) {
23549ac7eceSKristof Umann
23649ac7eceSKristof Umann if (Optional<SVal> V = getSValForVar(CondVarExpr, N))
23749ac7eceSKristof Umann if (auto CI = V->getAs<nonloc::ConcreteInt>())
23849ac7eceSKristof Umann return &CI->getValue();
23949ac7eceSKristof Umann return None;
24049ac7eceSKristof Umann }
24149ac7eceSKristof Umann
isVarAnInterestingCondition(const Expr * CondVarExpr,const ExplodedNode * N,const PathSensitiveBugReport * B)242d9a81ccfSKristof Umann static bool isVarAnInterestingCondition(const Expr *CondVarExpr,
243d9a81ccfSKristof Umann const ExplodedNode *N,
2442f169e7cSArtem Dergachev const PathSensitiveBugReport *B) {
245d9a81ccfSKristof Umann // Even if this condition is marked as interesting, it isn't *that*
246d9a81ccfSKristof Umann // interesting if it didn't happen in a nested stackframe, the user could just
247d9a81ccfSKristof Umann // follow the arrows.
248d9a81ccfSKristof Umann if (!B->getErrorNode()->getStackFrame()->isParentOf(N->getStackFrame()))
249d9a81ccfSKristof Umann return false;
250d9a81ccfSKristof Umann
251d9a81ccfSKristof Umann if (Optional<SVal> V = getSValForVar(CondVarExpr, N))
252d9a81ccfSKristof Umann if (Optional<bugreporter::TrackingKind> K = B->getInterestingnessKind(*V))
253d9a81ccfSKristof Umann return *K == bugreporter::TrackingKind::Condition;
254d9a81ccfSKristof Umann
255d9a81ccfSKristof Umann return false;
256d9a81ccfSKristof Umann }
257d9a81ccfSKristof Umann
isInterestingExpr(const Expr * E,const ExplodedNode * N,const PathSensitiveBugReport * B)25849ac7eceSKristof Umann static bool isInterestingExpr(const Expr *E, const ExplodedNode *N,
2592f169e7cSArtem Dergachev const PathSensitiveBugReport *B) {
26049ac7eceSKristof Umann if (Optional<SVal> V = getSValForVar(E, N))
261064a08cdSKazu Hirata return B->getInterestingnessKind(*V).has_value();
26249ac7eceSKristof Umann return false;
2634b0184b2SCsaba Dabis }
2644b0184b2SCsaba Dabis
2659ff09d49SKristof Umann /// \return name of the macro inside the location \p Loc.
getMacroName(SourceLocation Loc,BugReporterContext & BRC)2669ff09d49SKristof Umann static StringRef getMacroName(SourceLocation Loc,
2679ff09d49SKristof Umann BugReporterContext &BRC) {
2689ff09d49SKristof Umann return Lexer::getImmediateMacroName(
2699ff09d49SKristof Umann Loc,
2709ff09d49SKristof Umann BRC.getSourceManager(),
2719ff09d49SKristof Umann BRC.getASTContext().getLangOpts());
2729ff09d49SKristof Umann }
2739ff09d49SKristof Umann
2749ff09d49SKristof Umann /// \return Whether given spelling location corresponds to an expansion
2759ff09d49SKristof Umann /// of a function-like macro.
isFunctionMacroExpansion(SourceLocation Loc,const SourceManager & SM)2769ff09d49SKristof Umann static bool isFunctionMacroExpansion(SourceLocation Loc,
2779ff09d49SKristof Umann const SourceManager &SM) {
2789ff09d49SKristof Umann if (!Loc.isMacroID())
2799ff09d49SKristof Umann return false;
2809ff09d49SKristof Umann while (SM.isMacroArgExpansion(Loc))
2819ff09d49SKristof Umann Loc = SM.getImmediateExpansionRange(Loc).getBegin();
2829ff09d49SKristof Umann std::pair<FileID, unsigned> TLInfo = SM.getDecomposedLoc(Loc);
2839ff09d49SKristof Umann SrcMgr::SLocEntry SE = SM.getSLocEntry(TLInfo.first);
2849ff09d49SKristof Umann const SrcMgr::ExpansionInfo &EInfo = SE.getExpansion();
2859ff09d49SKristof Umann return EInfo.isFunctionMacroExpansion();
2869ff09d49SKristof Umann }
2879ff09d49SKristof Umann
2889ff09d49SKristof Umann /// \return Whether \c RegionOfInterest was modified at \p N,
2899ff09d49SKristof Umann /// where \p ValueAfter is \c RegionOfInterest's value at the end of the
2909ff09d49SKristof Umann /// stack frame.
wasRegionOfInterestModifiedAt(const SubRegion * RegionOfInterest,const ExplodedNode * N,SVal ValueAfter)2919ff09d49SKristof Umann static bool wasRegionOfInterestModifiedAt(const SubRegion *RegionOfInterest,
2929ff09d49SKristof Umann const ExplodedNode *N,
2939ff09d49SKristof Umann SVal ValueAfter) {
2949ff09d49SKristof Umann ProgramStateRef State = N->getState();
2959ff09d49SKristof Umann ProgramStateManager &Mgr = N->getState()->getStateManager();
2969ff09d49SKristof Umann
2979ff09d49SKristof Umann if (!N->getLocationAs<PostStore>() && !N->getLocationAs<PostInitializer>() &&
2989ff09d49SKristof Umann !N->getLocationAs<PostStmt>())
2999ff09d49SKristof Umann return false;
3009ff09d49SKristof Umann
3019ff09d49SKristof Umann // Writing into region of interest.
3029ff09d49SKristof Umann if (auto PS = N->getLocationAs<PostStmt>())
3039ff09d49SKristof Umann if (auto *BO = PS->getStmtAs<BinaryOperator>())
3049ff09d49SKristof Umann if (BO->isAssignmentOp() && RegionOfInterest->isSubRegionOf(
3059ff09d49SKristof Umann N->getSVal(BO->getLHS()).getAsRegion()))
3069ff09d49SKristof Umann return true;
3079ff09d49SKristof Umann
3089ff09d49SKristof Umann // SVal after the state is possibly different.
3099ff09d49SKristof Umann SVal ValueAtN = N->getState()->getSVal(RegionOfInterest);
3109ff09d49SKristof Umann if (!Mgr.getSValBuilder()
3119ff09d49SKristof Umann .areEqual(State, ValueAtN, ValueAfter)
3129ff09d49SKristof Umann .isConstrainedTrue() &&
3139ff09d49SKristof Umann (!ValueAtN.isUndef() || !ValueAfter.isUndef()))
3149ff09d49SKristof Umann return true;
3159ff09d49SKristof Umann
3169ff09d49SKristof Umann return false;
3179ff09d49SKristof Umann }
3189ff09d49SKristof Umann
319fa0734ecSArgyrios Kyrtzidis //===----------------------------------------------------------------------===//
3204cc6d72bSKristof Umann // Implementation of BugReporterVisitor.
321fa0734ecSArgyrios Kyrtzidis //===----------------------------------------------------------------------===//
32288255cc5SAnna Zaks
getEndPath(BugReporterContext &,const ExplodedNode *,PathSensitiveBugReport &)3236d716ef1SKristof Umann PathDiagnosticPieceRef BugReporterVisitor::getEndPath(BugReporterContext &,
3246d716ef1SKristof Umann const ExplodedNode *,
3252f169e7cSArtem Dergachev PathSensitiveBugReport &) {
3260dbb783cSCraig Topper return nullptr;
32788255cc5SAnna Zaks }
32888255cc5SAnna Zaks
finalizeVisitor(BugReporterContext &,const ExplodedNode *,PathSensitiveBugReport &)3296d716ef1SKristof Umann void BugReporterVisitor::finalizeVisitor(BugReporterContext &,
3302f169e7cSArtem Dergachev const ExplodedNode *,
3312f169e7cSArtem Dergachev PathSensitiveBugReport &) {}
3325ec0a261SGeorge Karpenkov
333f9d75bedSKristof Umann PathDiagnosticPieceRef
getDefaultEndPath(const BugReporterContext & BRC,const ExplodedNode * EndPathNode,const PathSensitiveBugReport & BR)334f9d75bedSKristof Umann BugReporterVisitor::getDefaultEndPath(const BugReporterContext &BRC,
335f9d75bedSKristof Umann const ExplodedNode *EndPathNode,
3362f169e7cSArtem Dergachev const PathSensitiveBugReport &BR) {
3376b85f8e9SArtem Dergachev PathDiagnosticLocation L = BR.getLocation();
338b4ef6683SBenjamin Kramer const auto &Ranges = BR.getRanges();
33988255cc5SAnna Zaks
34088255cc5SAnna Zaks // Only add the statement itself as a range if we didn't specify any
34188255cc5SAnna Zaks // special ranges for this report.
34270ec1dd1SGeorge Karpenkov auto P = std::make_shared<PathDiagnosticEventPiece>(
343b4ef6683SBenjamin Kramer L, BR.getDescription(), Ranges.begin() == Ranges.end());
344e335f259SCraig Topper for (SourceRange Range : Ranges)
345b4ef6683SBenjamin Kramer P->addRange(Range);
34688255cc5SAnna Zaks
34770ec1dd1SGeorge Karpenkov return P;
34888255cc5SAnna Zaks }
34988255cc5SAnna Zaks
3509ff09d49SKristof Umann //===----------------------------------------------------------------------===//
351c019142aSKristóf Umann // Implementation of NoStateChangeFuncVisitor.
352c019142aSKristóf Umann //===----------------------------------------------------------------------===//
353c019142aSKristóf Umann
isModifiedInFrame(const ExplodedNode * N)354c019142aSKristóf Umann bool NoStateChangeFuncVisitor::isModifiedInFrame(const ExplodedNode *N) {
355c019142aSKristóf Umann const LocationContext *Ctx = N->getLocationContext();
356c019142aSKristóf Umann const StackFrameContext *SCtx = Ctx->getStackFrame();
357c019142aSKristóf Umann if (!FramesModifyingCalculated.count(SCtx))
358c019142aSKristóf Umann findModifyingFrames(N);
359c019142aSKristóf Umann return FramesModifying.count(SCtx);
360c019142aSKristóf Umann }
361c019142aSKristóf Umann
markFrameAsModifying(const StackFrameContext * SCtx)3620213d7ecSKristóf Umann void NoStateChangeFuncVisitor::markFrameAsModifying(
3630213d7ecSKristóf Umann const StackFrameContext *SCtx) {
364b9e57e03SJessica Paquette while (!SCtx->inTopFrame()) {
365b9e57e03SJessica Paquette auto p = FramesModifying.insert(SCtx);
366b9e57e03SJessica Paquette if (!p.second)
367b9e57e03SJessica Paquette break; // Frame and all its parents already inserted.
3680213d7ecSKristóf Umann
369b9e57e03SJessica Paquette SCtx = SCtx->getParent()->getStackFrame();
370b9e57e03SJessica Paquette }
371b9e57e03SJessica Paquette }
372a375bfb5SKristóf Umann
getMatchingCallExitEnd(const ExplodedNode * N)3730213d7ecSKristóf Umann static const ExplodedNode *getMatchingCallExitEnd(const ExplodedNode *N) {
3740213d7ecSKristóf Umann assert(N->getLocationAs<CallEnter>());
3750213d7ecSKristóf Umann // The stackframe of the callee is only found in the nodes succeeding
3760213d7ecSKristóf Umann // the CallEnter node. CallEnter's stack frame refers to the caller.
3770213d7ecSKristóf Umann const StackFrameContext *OrigSCtx = N->getFirstSucc()->getStackFrame();
378a375bfb5SKristóf Umann
3790213d7ecSKristóf Umann // Similarly, the nodes preceding CallExitEnd refer to the callee's stack
3800213d7ecSKristóf Umann // frame.
3810213d7ecSKristóf Umann auto IsMatchingCallExitEnd = [OrigSCtx](const ExplodedNode *N) {
3820213d7ecSKristóf Umann return N->getLocationAs<CallExitEnd>() &&
3830213d7ecSKristóf Umann OrigSCtx == N->getFirstPred()->getStackFrame();
3840213d7ecSKristóf Umann };
3850213d7ecSKristóf Umann while (N && !IsMatchingCallExitEnd(N)) {
3860213d7ecSKristóf Umann assert(N->succ_size() <= 1 &&
3870213d7ecSKristóf Umann "This function is to be used on the trimmed ExplodedGraph!");
3880213d7ecSKristóf Umann N = N->getFirstSucc();
3890213d7ecSKristóf Umann }
3900213d7ecSKristóf Umann return N;
3910213d7ecSKristóf Umann }
3920213d7ecSKristóf Umann
findModifyingFrames(const ExplodedNode * const CallExitBeginN)3930213d7ecSKristóf Umann void NoStateChangeFuncVisitor::findModifyingFrames(
3940213d7ecSKristóf Umann const ExplodedNode *const CallExitBeginN) {
3950213d7ecSKristóf Umann
3960213d7ecSKristóf Umann assert(CallExitBeginN->getLocationAs<CallExitBegin>());
3970213d7ecSKristóf Umann
3980213d7ecSKristóf Umann const StackFrameContext *const OriginalSCtx =
3990213d7ecSKristóf Umann CallExitBeginN->getLocationContext()->getStackFrame();
4000213d7ecSKristóf Umann
4010213d7ecSKristóf Umann const ExplodedNode *CurrCallExitBeginN = CallExitBeginN;
4020213d7ecSKristóf Umann const StackFrameContext *CurrentSCtx = OriginalSCtx;
4030213d7ecSKristóf Umann
4040213d7ecSKristóf Umann for (const ExplodedNode *CurrN = CallExitBeginN; CurrN;
4050213d7ecSKristóf Umann CurrN = CurrN->getFirstPred()) {
4060213d7ecSKristóf Umann // Found a new inlined call.
4070213d7ecSKristóf Umann if (CurrN->getLocationAs<CallExitBegin>()) {
4080213d7ecSKristóf Umann CurrCallExitBeginN = CurrN;
4090213d7ecSKristóf Umann CurrentSCtx = CurrN->getStackFrame();
4100213d7ecSKristóf Umann FramesModifyingCalculated.insert(CurrentSCtx);
4110213d7ecSKristóf Umann // We won't see a change in between two identical exploded nodes: skip.
4120213d7ecSKristóf Umann continue;
4130213d7ecSKristóf Umann }
4140213d7ecSKristóf Umann
4150213d7ecSKristóf Umann if (auto CE = CurrN->getLocationAs<CallEnter>()) {
4160213d7ecSKristóf Umann if (const ExplodedNode *CallExitEndN = getMatchingCallExitEnd(CurrN))
4170213d7ecSKristóf Umann if (wasModifiedInFunction(CurrN, CallExitEndN))
4180213d7ecSKristóf Umann markFrameAsModifying(CurrentSCtx);
4190213d7ecSKristóf Umann
4200213d7ecSKristóf Umann // We exited this inlined call, lets actualize the stack frame.
4210213d7ecSKristóf Umann CurrentSCtx = CurrN->getStackFrame();
4220213d7ecSKristóf Umann
4230213d7ecSKristóf Umann // Stop calculating at the current function, but always regard it as
4240213d7ecSKristóf Umann // modifying, so we can avoid notes like this:
4250213d7ecSKristóf Umann // void f(Foo &F) {
4260213d7ecSKristóf Umann // F.field = 0; // note: 0 assigned to 'F.field'
4270213d7ecSKristóf Umann // // note: returning without writing to 'F.field'
4280213d7ecSKristóf Umann // }
4290213d7ecSKristóf Umann if (CE->getCalleeContext() == OriginalSCtx) {
4300213d7ecSKristóf Umann markFrameAsModifying(CurrentSCtx);
4310213d7ecSKristóf Umann break;
4320213d7ecSKristóf Umann }
4330213d7ecSKristóf Umann }
4340213d7ecSKristóf Umann
4350213d7ecSKristóf Umann if (wasModifiedBeforeCallExit(CurrN, CurrCallExitBeginN))
4360213d7ecSKristóf Umann markFrameAsModifying(CurrentSCtx);
4370213d7ecSKristóf Umann }
438c019142aSKristóf Umann }
439c019142aSKristóf Umann
VisitNode(const ExplodedNode * N,BugReporterContext & BR,PathSensitiveBugReport & R)440c019142aSKristóf Umann PathDiagnosticPieceRef NoStateChangeFuncVisitor::VisitNode(
441c019142aSKristóf Umann const ExplodedNode *N, BugReporterContext &BR, PathSensitiveBugReport &R) {
442c019142aSKristóf Umann
443c019142aSKristóf Umann const LocationContext *Ctx = N->getLocationContext();
444c019142aSKristóf Umann const StackFrameContext *SCtx = Ctx->getStackFrame();
445c019142aSKristóf Umann ProgramStateRef State = N->getState();
446c019142aSKristóf Umann auto CallExitLoc = N->getLocationAs<CallExitBegin>();
447c019142aSKristóf Umann
448c019142aSKristóf Umann // No diagnostic if region was modified inside the frame.
449c019142aSKristóf Umann if (!CallExitLoc || isModifiedInFrame(N))
450c019142aSKristóf Umann return nullptr;
451c019142aSKristóf Umann
452c019142aSKristóf Umann CallEventRef<> Call =
453c019142aSKristóf Umann BR.getStateManager().getCallEventManager().getCaller(SCtx, State);
454c019142aSKristóf Umann
455c019142aSKristóf Umann // Optimistically suppress uninitialized value bugs that result
456c019142aSKristóf Umann // from system headers having a chance to initialize the value
457c019142aSKristóf Umann // but failing to do so. It's too unlikely a system header's fault.
458c019142aSKristóf Umann // It's much more likely a situation in which the function has a failure
459c019142aSKristóf Umann // mode that the user decided not to check. If we want to hunt such
460c019142aSKristóf Umann // omitted checks, we should provide an explicit function-specific note
461c019142aSKristóf Umann // describing the precondition under which the function isn't supposed to
462c019142aSKristóf Umann // initialize its out-parameter, and additionally check that such
463c019142aSKristóf Umann // precondition can actually be fulfilled on the current path.
464c019142aSKristóf Umann if (Call->isInSystemHeader()) {
465c019142aSKristóf Umann // We make an exception for system header functions that have no branches.
466c019142aSKristóf Umann // Such functions unconditionally fail to initialize the variable.
467c019142aSKristóf Umann // If they call other functions that have more paths within them,
468c019142aSKristóf Umann // this suppression would still apply when we visit these inner functions.
469c019142aSKristóf Umann // One common example of a standard function that doesn't ever initialize
470c019142aSKristóf Umann // its out parameter is operator placement new; it's up to the follow-up
471c019142aSKristóf Umann // constructor (if any) to initialize the memory.
472c019142aSKristóf Umann if (!N->getStackFrame()->getCFG()->isLinear()) {
473c019142aSKristóf Umann static int i = 0;
474c019142aSKristóf Umann R.markInvalid(&i, nullptr);
475c019142aSKristóf Umann }
476c019142aSKristóf Umann return nullptr;
477c019142aSKristóf Umann }
478c019142aSKristóf Umann
479c019142aSKristóf Umann if (const auto *MC = dyn_cast<ObjCMethodCall>(Call)) {
480c019142aSKristóf Umann // If we failed to construct a piece for self, we still want to check
481c019142aSKristóf Umann // whether the entity of interest is in a parameter.
482c019142aSKristóf Umann if (PathDiagnosticPieceRef Piece = maybeEmitNoteForObjCSelf(R, *MC, N))
483c019142aSKristóf Umann return Piece;
484c019142aSKristóf Umann }
485c019142aSKristóf Umann
486c019142aSKristóf Umann if (const auto *CCall = dyn_cast<CXXConstructorCall>(Call)) {
487c019142aSKristóf Umann // Do not generate diagnostics for not modified parameters in
488c019142aSKristóf Umann // constructors.
489c019142aSKristóf Umann return maybeEmitNoteForCXXThis(R, *CCall, N);
490c019142aSKristóf Umann }
491c019142aSKristóf Umann
492c019142aSKristóf Umann return maybeEmitNoteForParameters(R, *Call, N);
493c019142aSKristóf Umann }
494c019142aSKristóf Umann
495c019142aSKristóf Umann //===----------------------------------------------------------------------===//
4969ff09d49SKristof Umann // Implementation of NoStoreFuncVisitor.
4979ff09d49SKristof Umann //===----------------------------------------------------------------------===//
498bccd6ec3SGeorge Karpenkov
4995090904dSJordan Rose namespace {
500e15451a9SGeorge Karpenkov /// Put a diagnostic on return statement of all inlined functions
501e15451a9SGeorge Karpenkov /// for which the region of interest \p RegionOfInterest was passed into,
502e15451a9SGeorge Karpenkov /// but not written inside, and it has caused an undefined read or a null
503e15451a9SGeorge Karpenkov /// pointer dereference outside.
504c019142aSKristóf Umann class NoStoreFuncVisitor final : public NoStateChangeFuncVisitor {
505e15451a9SGeorge Karpenkov const SubRegion *RegionOfInterest;
5061d08c51eSGeorge Karpenkov MemRegionManager &MmrMgr;
5078a0f890eSGeorge Karpenkov const SourceManager &SM;
5088a0f890eSGeorge Karpenkov const PrintingPolicy &PP;
5091d08c51eSGeorge Karpenkov
5101d08c51eSGeorge Karpenkov /// Recursion limit for dereferencing fields when looking for the
5111d08c51eSGeorge Karpenkov /// region of interest.
5121d08c51eSGeorge Karpenkov /// The limit of two indicates that we will dereference fields only once.
5131d08c51eSGeorge Karpenkov static const unsigned DEREFERENCE_LIMIT = 2;
514e15451a9SGeorge Karpenkov
5151d08c51eSGeorge Karpenkov using RegionVector = SmallVector<const MemRegion *, 5>;
5169ff09d49SKristof Umann
517e15451a9SGeorge Karpenkov public:
NoStoreFuncVisitor(const SubRegion * R,bugreporter::TrackingKind TKind)518da648ab8SKristof Umann NoStoreFuncVisitor(const SubRegion *R, bugreporter::TrackingKind TKind)
519c019142aSKristóf Umann : NoStateChangeFuncVisitor(TKind), RegionOfInterest(R),
520c019142aSKristóf Umann MmrMgr(R->getMemRegionManager()),
5211d08c51eSGeorge Karpenkov SM(MmrMgr.getContext().getSourceManager()),
522c019142aSKristóf Umann PP(MmrMgr.getContext().getPrintingPolicy()) {}
523e15451a9SGeorge Karpenkov
Profile(llvm::FoldingSetNodeID & ID) const524e15451a9SGeorge Karpenkov void Profile(llvm::FoldingSetNodeID &ID) const override {
525e15451a9SGeorge Karpenkov static int Tag = 0;
526e15451a9SGeorge Karpenkov ID.AddPointer(&Tag);
5271d08c51eSGeorge Karpenkov ID.AddPointer(RegionOfInterest);
528e15451a9SGeorge Karpenkov }
529e15451a9SGeorge Karpenkov
530e15451a9SGeorge Karpenkov private:
531c019142aSKristóf Umann /// \return Whether \c RegionOfInterest was modified at \p CurrN compared to
532c019142aSKristóf Umann /// the value it holds in \p CallExitBeginN.
533*3f3930a4SKazu Hirata bool wasModifiedBeforeCallExit(const ExplodedNode *CurrN,
534c019142aSKristóf Umann const ExplodedNode *CallExitBeginN) override;
535c019142aSKristóf Umann
5369ff09d49SKristof Umann /// Attempts to find the region of interest in a given record decl,
5371d08c51eSGeorge Karpenkov /// by either following the base classes or fields.
5381d08c51eSGeorge Karpenkov /// Dereferences fields up to a given recursion limit.
5391d08c51eSGeorge Karpenkov /// Note that \p Vec is passed by value, leading to quadratic copying cost,
5401d08c51eSGeorge Karpenkov /// but it's OK in practice since its length is limited to DEREFERENCE_LIMIT.
5411d08c51eSGeorge Karpenkov /// \return A chain fields leading to the region of interest or None.
5421d08c51eSGeorge Karpenkov const Optional<RegionVector>
5431d08c51eSGeorge Karpenkov findRegionOfInterestInRecord(const RecordDecl *RD, ProgramStateRef State,
5449ff09d49SKristof Umann const MemRegion *R, const RegionVector &Vec = {},
5459ff09d49SKristof Umann int depth = 0);
5461d08c51eSGeorge Karpenkov
547c019142aSKristóf Umann // Region of interest corresponds to an IVar, exiting a method
548c019142aSKristóf Umann // which could have written into that IVar, but did not.
54995a932fbSKazu Hirata PathDiagnosticPieceRef maybeEmitNoteForObjCSelf(PathSensitiveBugReport &R,
550c019142aSKristóf Umann const ObjCMethodCall &Call,
55195a932fbSKazu Hirata const ExplodedNode *N) final;
5521d08c51eSGeorge Karpenkov
55395a932fbSKazu Hirata PathDiagnosticPieceRef maybeEmitNoteForCXXThis(PathSensitiveBugReport &R,
554c019142aSKristóf Umann const CXXConstructorCall &Call,
55595a932fbSKazu Hirata const ExplodedNode *N) final;
556c019142aSKristóf Umann
55795a932fbSKazu Hirata PathDiagnosticPieceRef
558c019142aSKristóf Umann maybeEmitNoteForParameters(PathSensitiveBugReport &R, const CallEvent &Call,
55995a932fbSKazu Hirata const ExplodedNode *N) final;
5609ff09d49SKristof Umann
5619ff09d49SKristof Umann /// Consume the information on the no-store stack frame in order to
5629ff09d49SKristof Umann /// either emit a note or suppress the report enirely.
5639ff09d49SKristof Umann /// \return Diagnostics piece for region not modified in the current function,
5649ff09d49SKristof Umann /// if it decides to emit one.
5656d716ef1SKristof Umann PathDiagnosticPieceRef
5662f169e7cSArtem Dergachev maybeEmitNote(PathSensitiveBugReport &R, const CallEvent &Call,
5672f169e7cSArtem Dergachev const ExplodedNode *N, const RegionVector &FieldChain,
5682f169e7cSArtem Dergachev const MemRegion *MatchedRegion, StringRef FirstElement,
5692f169e7cSArtem Dergachev bool FirstIsReferenceType, unsigned IndirectionLevel);
5709ff09d49SKristof Umann
571c019142aSKristóf Umann bool prettyPrintRegionName(const RegionVector &FieldChain,
5729ff09d49SKristof Umann const MemRegion *MatchedRegion,
573c019142aSKristóf Umann StringRef FirstElement, bool FirstIsReferenceType,
574c019142aSKristóf Umann unsigned IndirectionLevel,
5759ff09d49SKristof Umann llvm::raw_svector_ostream &os);
5769ff09d49SKristof Umann
577c019142aSKristóf Umann StringRef prettyPrintFirstElement(StringRef FirstElement,
5789ff09d49SKristof Umann bool MoreItemsExpected,
5799ff09d49SKristof Umann int IndirectionLevel,
5809ff09d49SKristof Umann llvm::raw_svector_ostream &os);
5819ff09d49SKristof Umann };
582c019142aSKristóf Umann } // namespace
583b293c6bbSGeorge Karpenkov
584b293c6bbSGeorge Karpenkov /// \return Whether the method declaration \p Parent
585b293c6bbSGeorge Karpenkov /// syntactically has a binary operation writing into the ivar \p Ivar.
potentiallyWritesIntoIvar(const Decl * Parent,const ObjCIvarDecl * Ivar)5869ff09d49SKristof Umann static bool potentiallyWritesIntoIvar(const Decl *Parent,
587b293c6bbSGeorge Karpenkov const ObjCIvarDecl *Ivar) {
588b293c6bbSGeorge Karpenkov using namespace ast_matchers;
5891d08c51eSGeorge Karpenkov const char *IvarBind = "Ivar";
5901d08c51eSGeorge Karpenkov if (!Parent || !Parent->hasBody())
591b293c6bbSGeorge Karpenkov return false;
592b293c6bbSGeorge Karpenkov StatementMatcher WriteIntoIvarM = binaryOperator(
5931d08c51eSGeorge Karpenkov hasOperatorName("="),
5941d08c51eSGeorge Karpenkov hasLHS(ignoringParenImpCasts(
5951d08c51eSGeorge Karpenkov objcIvarRefExpr(hasDeclaration(equalsNode(Ivar))).bind(IvarBind))));
596b293c6bbSGeorge Karpenkov StatementMatcher ParentM = stmt(hasDescendant(WriteIntoIvarM));
597b293c6bbSGeorge Karpenkov auto Matches = match(ParentM, *Parent->getBody(), Parent->getASTContext());
5981d08c51eSGeorge Karpenkov for (BoundNodes &Match : Matches) {
5991d08c51eSGeorge Karpenkov auto IvarRef = Match.getNodeAs<ObjCIvarRefExpr>(IvarBind);
6001d08c51eSGeorge Karpenkov if (IvarRef->isFreeIvar())
6011d08c51eSGeorge Karpenkov return true;
6021d08c51eSGeorge Karpenkov
6031d08c51eSGeorge Karpenkov const Expr *Base = IvarRef->getBase();
6041d08c51eSGeorge Karpenkov if (const auto *ICE = dyn_cast<ImplicitCastExpr>(Base))
6051d08c51eSGeorge Karpenkov Base = ICE->getSubExpr();
6061d08c51eSGeorge Karpenkov
6071d08c51eSGeorge Karpenkov if (const auto *DRE = dyn_cast<DeclRefExpr>(Base))
6081d08c51eSGeorge Karpenkov if (const auto *ID = dyn_cast<ImplicitParamDecl>(DRE->getDecl()))
6091d08c51eSGeorge Karpenkov if (ID->getParameterKind() == ImplicitParamDecl::ObjCSelf)
6101d08c51eSGeorge Karpenkov return true;
6111d08c51eSGeorge Karpenkov
6121d08c51eSGeorge Karpenkov return false;
6131d08c51eSGeorge Karpenkov }
6141d08c51eSGeorge Karpenkov return false;
615b293c6bbSGeorge Karpenkov }
616b293c6bbSGeorge Karpenkov
6179ff09d49SKristof Umann /// Attempts to find the region of interest in a given CXX decl,
6189ff09d49SKristof Umann /// by either following the base classes or fields.
6199ff09d49SKristof Umann /// Dereferences fields up to a given recursion limit.
6209ff09d49SKristof Umann /// Note that \p Vec is passed by value, leading to quadratic copying cost,
6219ff09d49SKristof Umann /// but it's OK in practice since its length is limited to DEREFERENCE_LIMIT.
6229ff09d49SKristof Umann /// \return A chain fields leading to the region of interest or None.
6239ff09d49SKristof Umann const Optional<NoStoreFuncVisitor::RegionVector>
findRegionOfInterestInRecord(const RecordDecl * RD,ProgramStateRef State,const MemRegion * R,const NoStoreFuncVisitor::RegionVector & Vec,int depth)6249ff09d49SKristof Umann NoStoreFuncVisitor::findRegionOfInterestInRecord(
6259ff09d49SKristof Umann const RecordDecl *RD, ProgramStateRef State, const MemRegion *R,
6269ff09d49SKristof Umann const NoStoreFuncVisitor::RegionVector &Vec /* = {} */,
6279ff09d49SKristof Umann int depth /* = 0 */) {
6289ff09d49SKristof Umann
6299ff09d49SKristof Umann if (depth == DEREFERENCE_LIMIT) // Limit the recursion depth.
6309ff09d49SKristof Umann return None;
6319ff09d49SKristof Umann
6329ff09d49SKristof Umann if (const auto *RDX = dyn_cast<CXXRecordDecl>(RD))
6339ff09d49SKristof Umann if (!RDX->hasDefinition())
6349ff09d49SKristof Umann return None;
6359ff09d49SKristof Umann
6369ff09d49SKristof Umann // Recursively examine the base classes.
6379ff09d49SKristof Umann // Note that following base classes does not increase the recursion depth.
6389ff09d49SKristof Umann if (const auto *RDX = dyn_cast<CXXRecordDecl>(RD))
63970d592d6SMark de Wever for (const auto &II : RDX->bases())
6409ff09d49SKristof Umann if (const RecordDecl *RRD = II.getType()->getAsRecordDecl())
6419ff09d49SKristof Umann if (Optional<RegionVector> Out =
6429ff09d49SKristof Umann findRegionOfInterestInRecord(RRD, State, R, Vec, depth))
6439ff09d49SKristof Umann return Out;
6449ff09d49SKristof Umann
6459ff09d49SKristof Umann for (const FieldDecl *I : RD->fields()) {
6469ff09d49SKristof Umann QualType FT = I->getType();
6479ff09d49SKristof Umann const FieldRegion *FR = MmrMgr.getFieldRegion(I, cast<SubRegion>(R));
6489ff09d49SKristof Umann const SVal V = State->getSVal(FR);
6499ff09d49SKristof Umann const MemRegion *VR = V.getAsRegion();
6509ff09d49SKristof Umann
6519ff09d49SKristof Umann RegionVector VecF = Vec;
6529ff09d49SKristof Umann VecF.push_back(FR);
6539ff09d49SKristof Umann
6549ff09d49SKristof Umann if (RegionOfInterest == VR)
6559ff09d49SKristof Umann return VecF;
6569ff09d49SKristof Umann
6579ff09d49SKristof Umann if (const RecordDecl *RRD = FT->getAsRecordDecl())
6589ff09d49SKristof Umann if (auto Out =
6599ff09d49SKristof Umann findRegionOfInterestInRecord(RRD, State, FR, VecF, depth + 1))
6609ff09d49SKristof Umann return Out;
6619ff09d49SKristof Umann
6629ff09d49SKristof Umann QualType PT = FT->getPointeeType();
6639ff09d49SKristof Umann if (PT.isNull() || PT->isVoidType() || !VR)
6649ff09d49SKristof Umann continue;
6659ff09d49SKristof Umann
6669ff09d49SKristof Umann if (const RecordDecl *RRD = PT->getAsRecordDecl())
6679ff09d49SKristof Umann if (Optional<RegionVector> Out =
6689ff09d49SKristof Umann findRegionOfInterestInRecord(RRD, State, VR, VecF, depth + 1))
6699ff09d49SKristof Umann return Out;
6709ff09d49SKristof Umann }
6719ff09d49SKristof Umann
6729ff09d49SKristof Umann return None;
6739ff09d49SKristof Umann }
6749ff09d49SKristof Umann
6752f169e7cSArtem Dergachev PathDiagnosticPieceRef
maybeEmitNoteForObjCSelf(PathSensitiveBugReport & R,const ObjCMethodCall & Call,const ExplodedNode * N)676c019142aSKristóf Umann NoStoreFuncVisitor::maybeEmitNoteForObjCSelf(PathSensitiveBugReport &R,
677c019142aSKristóf Umann const ObjCMethodCall &Call,
678c019142aSKristóf Umann const ExplodedNode *N) {
6799ff09d49SKristof Umann if (const auto *IvarR = dyn_cast<ObjCIvarRegion>(RegionOfInterest)) {
680c019142aSKristóf Umann const MemRegion *SelfRegion = Call.getReceiverSVal().getAsRegion();
6819ff09d49SKristof Umann if (RegionOfInterest->isSubRegionOf(SelfRegion) &&
682c019142aSKristóf Umann potentiallyWritesIntoIvar(Call.getRuntimeDefinition().getDecl(),
6839ff09d49SKristof Umann IvarR->getDecl()))
684c019142aSKristóf Umann return maybeEmitNote(R, Call, N, {}, SelfRegion, "self",
6859ff09d49SKristof Umann /*FirstIsReferenceType=*/false, 1);
6869ff09d49SKristof Umann }
687c019142aSKristóf Umann return nullptr;
6889ff09d49SKristof Umann }
6899ff09d49SKristof Umann
690c019142aSKristóf Umann PathDiagnosticPieceRef
maybeEmitNoteForCXXThis(PathSensitiveBugReport & R,const CXXConstructorCall & Call,const ExplodedNode * N)691c019142aSKristóf Umann NoStoreFuncVisitor::maybeEmitNoteForCXXThis(PathSensitiveBugReport &R,
692c019142aSKristóf Umann const CXXConstructorCall &Call,
693c019142aSKristóf Umann const ExplodedNode *N) {
694c019142aSKristóf Umann const MemRegion *ThisR = Call.getCXXThisVal().getAsRegion();
695c019142aSKristóf Umann if (RegionOfInterest->isSubRegionOf(ThisR) && !Call.getDecl()->isImplicit())
696c019142aSKristóf Umann return maybeEmitNote(R, Call, N, {}, ThisR, "this",
6979ff09d49SKristof Umann /*FirstIsReferenceType=*/false, 1);
6989ff09d49SKristof Umann
6999ff09d49SKristof Umann // Do not generate diagnostics for not modified parameters in
7009ff09d49SKristof Umann // constructors.
7019ff09d49SKristof Umann return nullptr;
7029ff09d49SKristof Umann }
7039ff09d49SKristof Umann
704c019142aSKristóf Umann /// \return whether \p Ty points to a const type, or is a const reference.
isPointerToConst(QualType Ty)705c019142aSKristóf Umann static bool isPointerToConst(QualType Ty) {
706c019142aSKristóf Umann return !Ty->getPointeeType().isNull() &&
707c019142aSKristóf Umann Ty->getPointeeType().getCanonicalType().isConstQualified();
708c019142aSKristóf Umann }
709c019142aSKristóf Umann
maybeEmitNoteForParameters(PathSensitiveBugReport & R,const CallEvent & Call,const ExplodedNode * N)710c019142aSKristóf Umann PathDiagnosticPieceRef NoStoreFuncVisitor::maybeEmitNoteForParameters(
711c019142aSKristóf Umann PathSensitiveBugReport &R, const CallEvent &Call, const ExplodedNode *N) {
712c019142aSKristóf Umann ArrayRef<ParmVarDecl *> Parameters = Call.parameters();
713c019142aSKristóf Umann for (unsigned I = 0; I < Call.getNumArgs() && I < Parameters.size(); ++I) {
714c019142aSKristóf Umann const ParmVarDecl *PVD = Parameters[I];
715c019142aSKristóf Umann SVal V = Call.getArgSVal(I);
7169ff09d49SKristof Umann bool ParamIsReferenceType = PVD->getType()->isReferenceType();
7179ff09d49SKristof Umann std::string ParamName = PVD->getNameAsString();
7189ff09d49SKristof Umann
719c019142aSKristóf Umann unsigned IndirectionLevel = 1;
7209ff09d49SKristof Umann QualType T = PVD->getType();
7219ff09d49SKristof Umann while (const MemRegion *MR = V.getAsRegion()) {
7229ff09d49SKristof Umann if (RegionOfInterest->isSubRegionOf(MR) && !isPointerToConst(T))
723c019142aSKristóf Umann return maybeEmitNote(R, Call, N, {}, MR, ParamName,
7249ff09d49SKristof Umann ParamIsReferenceType, IndirectionLevel);
7259ff09d49SKristof Umann
7269ff09d49SKristof Umann QualType PT = T->getPointeeType();
7279ff09d49SKristof Umann if (PT.isNull() || PT->isVoidType())
7289ff09d49SKristof Umann break;
7299ff09d49SKristof Umann
730c019142aSKristóf Umann ProgramStateRef State = N->getState();
731c019142aSKristóf Umann
7329ff09d49SKristof Umann if (const RecordDecl *RD = PT->getAsRecordDecl())
7339ff09d49SKristof Umann if (Optional<RegionVector> P =
7349ff09d49SKristof Umann findRegionOfInterestInRecord(RD, State, MR))
735c019142aSKristóf Umann return maybeEmitNote(R, Call, N, *P, RegionOfInterest, ParamName,
7369ff09d49SKristof Umann ParamIsReferenceType, IndirectionLevel);
7379ff09d49SKristof Umann
7389ff09d49SKristof Umann V = State->getSVal(MR, PT);
7399ff09d49SKristof Umann T = PT;
7409ff09d49SKristof Umann IndirectionLevel++;
7419ff09d49SKristof Umann }
7429ff09d49SKristof Umann }
7439ff09d49SKristof Umann
7449ff09d49SKristof Umann return nullptr;
7459ff09d49SKristof Umann }
7469ff09d49SKristof Umann
wasModifiedBeforeCallExit(const ExplodedNode * CurrN,const ExplodedNode * CallExitBeginN)747c019142aSKristóf Umann bool NoStoreFuncVisitor::wasModifiedBeforeCallExit(
748c019142aSKristóf Umann const ExplodedNode *CurrN, const ExplodedNode *CallExitBeginN) {
749c019142aSKristóf Umann return ::wasRegionOfInterestModifiedAt(
750c019142aSKristóf Umann RegionOfInterest, CurrN,
751c019142aSKristóf Umann CallExitBeginN->getState()->getSVal(RegionOfInterest));
752e15451a9SGeorge Karpenkov }
753e15451a9SGeorge Karpenkov
754da648ab8SKristof Umann static llvm::StringLiteral WillBeUsedForACondition =
755da648ab8SKristof Umann ", which participates in a condition later";
756da648ab8SKristof Umann
maybeEmitNote(PathSensitiveBugReport & R,const CallEvent & Call,const ExplodedNode * N,const RegionVector & FieldChain,const MemRegion * MatchedRegion,StringRef FirstElement,bool FirstIsReferenceType,unsigned IndirectionLevel)7576d716ef1SKristof Umann PathDiagnosticPieceRef NoStoreFuncVisitor::maybeEmitNote(
7582f169e7cSArtem Dergachev PathSensitiveBugReport &R, const CallEvent &Call, const ExplodedNode *N,
7595c6fc36dSArtem Dergachev const RegionVector &FieldChain, const MemRegion *MatchedRegion,
7605c6fc36dSArtem Dergachev StringRef FirstElement, bool FirstIsReferenceType,
7615c6fc36dSArtem Dergachev unsigned IndirectionLevel) {
7621d08c51eSGeorge Karpenkov
7632c2d0b6eSGeorge Karpenkov PathDiagnosticLocation L =
7642c2d0b6eSGeorge Karpenkov PathDiagnosticLocation::create(N->getLocation(), SM);
7651d08c51eSGeorge Karpenkov
766727d6ca3SArtem Dergachev // For now this shouldn't trigger, but once it does (as we add more
767727d6ca3SArtem Dergachev // functions to the body farm), we'll need to decide if these reports
768727d6ca3SArtem Dergachev // are worth suppressing as well.
769e2a8e431SArtem Dergachev if (!L.hasValidLocation())
770e2a8e431SArtem Dergachev return nullptr;
771e2a8e431SArtem Dergachev
772e15451a9SGeorge Karpenkov SmallString<256> sbuf;
773e15451a9SGeorge Karpenkov llvm::raw_svector_ostream os(sbuf);
7741d08c51eSGeorge Karpenkov os << "Returning without writing to '";
77509c31b1cSGeorge Karpenkov
77609c31b1cSGeorge Karpenkov // Do not generate the note if failed to pretty-print.
777c019142aSKristóf Umann if (!prettyPrintRegionName(FieldChain, MatchedRegion, FirstElement,
778c019142aSKristóf Umann FirstIsReferenceType, IndirectionLevel, os))
77909c31b1cSGeorge Karpenkov return nullptr;
780e15451a9SGeorge Karpenkov
781e15451a9SGeorge Karpenkov os << "'";
782da648ab8SKristof Umann if (TKind == bugreporter::TrackingKind::Condition)
783da648ab8SKristof Umann os << WillBeUsedForACondition;
784e15451a9SGeorge Karpenkov return std::make_shared<PathDiagnosticEventPiece>(L, os.str());
785e15451a9SGeorge Karpenkov }
786e15451a9SGeorge Karpenkov
prettyPrintRegionName(const RegionVector & FieldChain,const MemRegion * MatchedRegion,StringRef FirstElement,bool FirstIsReferenceType,unsigned IndirectionLevel,llvm::raw_svector_ostream & os)787c019142aSKristóf Umann bool NoStoreFuncVisitor::prettyPrintRegionName(const RegionVector &FieldChain,
7881d08c51eSGeorge Karpenkov const MemRegion *MatchedRegion,
789c019142aSKristóf Umann StringRef FirstElement,
790c019142aSKristóf Umann bool FirstIsReferenceType,
791c019142aSKristóf Umann unsigned IndirectionLevel,
7921d08c51eSGeorge Karpenkov llvm::raw_svector_ostream &os) {
793e15451a9SGeorge Karpenkov
7941d08c51eSGeorge Karpenkov if (FirstIsReferenceType)
7951d08c51eSGeorge Karpenkov IndirectionLevel--;
7961d08c51eSGeorge Karpenkov
7971d08c51eSGeorge Karpenkov RegionVector RegionSequence;
7981d08c51eSGeorge Karpenkov
7991d08c51eSGeorge Karpenkov // Add the regions in the reverse order, then reverse the resulting array.
8001d08c51eSGeorge Karpenkov assert(RegionOfInterest->isSubRegionOf(MatchedRegion));
801e15451a9SGeorge Karpenkov const MemRegion *R = RegionOfInterest;
8021d08c51eSGeorge Karpenkov while (R != MatchedRegion) {
8031d08c51eSGeorge Karpenkov RegionSequence.push_back(R);
804294016b8SCraig Topper R = cast<SubRegion>(R)->getSuperRegion();
805e15451a9SGeorge Karpenkov }
8061d08c51eSGeorge Karpenkov std::reverse(RegionSequence.begin(), RegionSequence.end());
8071d08c51eSGeorge Karpenkov RegionSequence.append(FieldChain.begin(), FieldChain.end());
808e15451a9SGeorge Karpenkov
8091d08c51eSGeorge Karpenkov StringRef Sep;
8101d08c51eSGeorge Karpenkov for (const MemRegion *R : RegionSequence) {
811e15451a9SGeorge Karpenkov
8121d08c51eSGeorge Karpenkov // Just keep going up to the base region.
81309c31b1cSGeorge Karpenkov // Element regions may appear due to casts.
81416be17adSBalazs Benics if (isa<CXXBaseObjectRegion, CXXTempObjectRegion>(R))
8151d08c51eSGeorge Karpenkov continue;
816e15451a9SGeorge Karpenkov
8171d08c51eSGeorge Karpenkov if (Sep.empty())
8181d08c51eSGeorge Karpenkov Sep = prettyPrintFirstElement(FirstElement,
8191d08c51eSGeorge Karpenkov /*MoreItemsExpected=*/true,
8201d08c51eSGeorge Karpenkov IndirectionLevel, os);
821e15451a9SGeorge Karpenkov
8221d08c51eSGeorge Karpenkov os << Sep;
8231d08c51eSGeorge Karpenkov
82409c31b1cSGeorge Karpenkov // Can only reasonably pretty-print DeclRegions.
82509c31b1cSGeorge Karpenkov if (!isa<DeclRegion>(R))
82609c31b1cSGeorge Karpenkov return false;
82709c31b1cSGeorge Karpenkov
8281d08c51eSGeorge Karpenkov const auto *DR = cast<DeclRegion>(R);
8291d08c51eSGeorge Karpenkov Sep = DR->getValueType()->isAnyPointerType() ? "->" : ".";
8301d08c51eSGeorge Karpenkov DR->getDecl()->getDeclName().print(os, PP);
8311d08c51eSGeorge Karpenkov }
8321d08c51eSGeorge Karpenkov
8331d08c51eSGeorge Karpenkov if (Sep.empty())
8341d08c51eSGeorge Karpenkov prettyPrintFirstElement(FirstElement,
8359ff09d49SKristof Umann /*MoreItemsExpected=*/false, IndirectionLevel, os);
83609c31b1cSGeorge Karpenkov return true;
8371d08c51eSGeorge Karpenkov }
8381d08c51eSGeorge Karpenkov
prettyPrintFirstElement(StringRef FirstElement,bool MoreItemsExpected,int IndirectionLevel,llvm::raw_svector_ostream & os)8399ff09d49SKristof Umann StringRef NoStoreFuncVisitor::prettyPrintFirstElement(
8409ff09d49SKristof Umann StringRef FirstElement, bool MoreItemsExpected, int IndirectionLevel,
8411d08c51eSGeorge Karpenkov llvm::raw_svector_ostream &os) {
8421d08c51eSGeorge Karpenkov StringRef Out = ".";
8431d08c51eSGeorge Karpenkov
8441d08c51eSGeorge Karpenkov if (IndirectionLevel > 0 && MoreItemsExpected) {
8451d08c51eSGeorge Karpenkov IndirectionLevel--;
8461d08c51eSGeorge Karpenkov Out = "->";
8471d08c51eSGeorge Karpenkov }
8481d08c51eSGeorge Karpenkov
8491d08c51eSGeorge Karpenkov if (IndirectionLevel > 0 && MoreItemsExpected)
850e15451a9SGeorge Karpenkov os << "(";
8511d08c51eSGeorge Karpenkov
852e15451a9SGeorge Karpenkov for (int i = 0; i < IndirectionLevel; i++)
853e15451a9SGeorge Karpenkov os << "*";
8541d08c51eSGeorge Karpenkov os << FirstElement;
8551d08c51eSGeorge Karpenkov
8561d08c51eSGeorge Karpenkov if (IndirectionLevel > 0 && MoreItemsExpected)
857e15451a9SGeorge Karpenkov os << ")";
858e15451a9SGeorge Karpenkov
8591d08c51eSGeorge Karpenkov return Out;
860e15451a9SGeorge Karpenkov }
861e15451a9SGeorge Karpenkov
8629ff09d49SKristof Umann //===----------------------------------------------------------------------===//
8639ff09d49SKristof Umann // Implementation of MacroNullReturnSuppressionVisitor.
8649ff09d49SKristof Umann //===----------------------------------------------------------------------===//
8654cc6d72bSKristof Umann
8664cc6d72bSKristof Umann namespace {
8674cc6d72bSKristof Umann
868bccd6ec3SGeorge Karpenkov /// Suppress null-pointer-dereference bugs where dereferenced null was returned
869bccd6ec3SGeorge Karpenkov /// the macro.
87070ec1dd1SGeorge Karpenkov class MacroNullReturnSuppressionVisitor final : public BugReporterVisitor {
8714316afbbSGeorge Karpenkov const SubRegion *RegionOfInterest;
872bccd6ec3SGeorge Karpenkov const SVal ValueAtDereference;
873bccd6ec3SGeorge Karpenkov
874bccd6ec3SGeorge Karpenkov // Do not invalidate the reports where the value was modified
875bccd6ec3SGeorge Karpenkov // after it got assigned to from the macro.
876bccd6ec3SGeorge Karpenkov bool WasModified = false;
8774316afbbSGeorge Karpenkov
8784316afbbSGeorge Karpenkov public:
MacroNullReturnSuppressionVisitor(const SubRegion * R,const SVal V)8796d716ef1SKristof Umann MacroNullReturnSuppressionVisitor(const SubRegion *R, const SVal V)
8806d716ef1SKristof Umann : RegionOfInterest(R), ValueAtDereference(V) {}
8814316afbbSGeorge Karpenkov
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)8826d716ef1SKristof Umann PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
8834316afbbSGeorge Karpenkov BugReporterContext &BRC,
8842f169e7cSArtem Dergachev PathSensitiveBugReport &BR) override {
885bccd6ec3SGeorge Karpenkov if (WasModified)
886bccd6ec3SGeorge Karpenkov return nullptr;
887bccd6ec3SGeorge Karpenkov
8884316afbbSGeorge Karpenkov auto BugPoint = BR.getErrorNode()->getLocation().getAs<StmtPoint>();
8894316afbbSGeorge Karpenkov if (!BugPoint)
8904316afbbSGeorge Karpenkov return nullptr;
8914316afbbSGeorge Karpenkov
8924316afbbSGeorge Karpenkov const SourceManager &SMgr = BRC.getSourceManager();
893c82d457dSGeorge Karpenkov if (auto Loc = matchAssignment(N)) {
8944316afbbSGeorge Karpenkov if (isFunctionMacroExpansion(*Loc, SMgr)) {
895adcd0268SBenjamin Kramer std::string MacroName = std::string(getMacroName(*Loc, BRC));
896f2ceec48SStephen Kelly SourceLocation BugLoc = BugPoint->getStmt()->getBeginLoc();
8974316afbbSGeorge Karpenkov if (!BugLoc.isMacroID() || getMacroName(BugLoc, BRC) != MacroName)
8984316afbbSGeorge Karpenkov BR.markInvalid(getTag(), MacroName.c_str());
8994316afbbSGeorge Karpenkov }
9004316afbbSGeorge Karpenkov }
901bccd6ec3SGeorge Karpenkov
902bccd6ec3SGeorge Karpenkov if (wasRegionOfInterestModifiedAt(RegionOfInterest, N, ValueAtDereference))
903bccd6ec3SGeorge Karpenkov WasModified = true;
904bccd6ec3SGeorge Karpenkov
9054316afbbSGeorge Karpenkov return nullptr;
9064316afbbSGeorge Karpenkov }
9074316afbbSGeorge Karpenkov
addMacroVisitorIfNecessary(const ExplodedNode * N,const MemRegion * R,bool EnableNullFPSuppression,PathSensitiveBugReport & BR,const SVal V)9084316afbbSGeorge Karpenkov static void addMacroVisitorIfNecessary(
9094316afbbSGeorge Karpenkov const ExplodedNode *N, const MemRegion *R,
9102f169e7cSArtem Dergachev bool EnableNullFPSuppression, PathSensitiveBugReport &BR,
9114316afbbSGeorge Karpenkov const SVal V) {
9128a0f890eSGeorge Karpenkov AnalyzerOptions &Options = N->getState()->getAnalysisManager().options;
91392d03c20SValeriy Savchenko if (EnableNullFPSuppression && Options.ShouldSuppressNullReturnPaths &&
91496ccb690SBalazs Benics isa<Loc>(V))
91592d03c20SValeriy Savchenko BR.addVisitor<MacroNullReturnSuppressionVisitor>(R->getAs<SubRegion>(),
91692d03c20SValeriy Savchenko V);
917bccd6ec3SGeorge Karpenkov }
918bccd6ec3SGeorge Karpenkov
getTag() const919bccd6ec3SGeorge Karpenkov void* getTag() const {
920bccd6ec3SGeorge Karpenkov static int Tag = 0;
921bccd6ec3SGeorge Karpenkov return static_cast<void *>(&Tag);
922bccd6ec3SGeorge Karpenkov }
923bccd6ec3SGeorge Karpenkov
Profile(llvm::FoldingSetNodeID & ID) const924bccd6ec3SGeorge Karpenkov void Profile(llvm::FoldingSetNodeID &ID) const override {
925bccd6ec3SGeorge Karpenkov ID.AddPointer(getTag());
9264316afbbSGeorge Karpenkov }
9274316afbbSGeorge Karpenkov
9284316afbbSGeorge Karpenkov private:
9294316afbbSGeorge Karpenkov /// \return Source location of right hand side of an assignment
9304316afbbSGeorge Karpenkov /// into \c RegionOfInterest, empty optional if none found.
matchAssignment(const ExplodedNode * N)931c82d457dSGeorge Karpenkov Optional<SourceLocation> matchAssignment(const ExplodedNode *N) {
9326b85f8e9SArtem Dergachev const Stmt *S = N->getStmtForDiagnostics();
9334316afbbSGeorge Karpenkov ProgramStateRef State = N->getState();
9344316afbbSGeorge Karpenkov auto *LCtx = N->getLocationContext();
9354316afbbSGeorge Karpenkov if (!S)
9364316afbbSGeorge Karpenkov return None;
9374316afbbSGeorge Karpenkov
9389f103a1aSEugene Zelenko if (const auto *DS = dyn_cast<DeclStmt>(S)) {
9399f103a1aSEugene Zelenko if (const auto *VD = dyn_cast<VarDecl>(DS->getSingleDecl()))
9404316afbbSGeorge Karpenkov if (const Expr *RHS = VD->getInit())
9414316afbbSGeorge Karpenkov if (RegionOfInterest->isSubRegionOf(
9424316afbbSGeorge Karpenkov State->getLValue(VD, LCtx).getAsRegion()))
943f2ceec48SStephen Kelly return RHS->getBeginLoc();
9449f103a1aSEugene Zelenko } else if (const auto *BO = dyn_cast<BinaryOperator>(S)) {
9454316afbbSGeorge Karpenkov const MemRegion *R = N->getSVal(BO->getLHS()).getAsRegion();
9464316afbbSGeorge Karpenkov const Expr *RHS = BO->getRHS();
9474316afbbSGeorge Karpenkov if (BO->isAssignmentOp() && RegionOfInterest->isSubRegionOf(R)) {
948f2ceec48SStephen Kelly return RHS->getBeginLoc();
9494316afbbSGeorge Karpenkov }
9504316afbbSGeorge Karpenkov }
9514316afbbSGeorge Karpenkov return None;
9524316afbbSGeorge Karpenkov }
9534316afbbSGeorge Karpenkov };
9544316afbbSGeorge Karpenkov
9554cc6d72bSKristof Umann } // end of anonymous namespace
9564cc6d72bSKristof Umann
9574cc6d72bSKristof Umann namespace {
9584cc6d72bSKristof Umann
9595090904dSJordan Rose /// Emits an extra note at the return statement of an interesting stack frame.
9605090904dSJordan Rose ///
9615090904dSJordan Rose /// The returned value is marked as an interesting value, and if it's null,
9625090904dSJordan Rose /// adds a visitor to track where it became null.
9635090904dSJordan Rose ///
9645090904dSJordan Rose /// This visitor is intended to be used when another visitor discovers that an
9655090904dSJordan Rose /// interesting value comes from an inlined function call.
966f853d260SValeriy Savchenko class ReturnVisitor : public TrackingBugReporterVisitor {
96746929df7SKristof Umann const StackFrameContext *CalleeSFC;
968ec44ac6aSJordan Rose enum {
969ec44ac6aSJordan Rose Initial,
9705ca39546SJordan Rose MaybeUnsuppress,
971ec44ac6aSJordan Rose Satisfied
9729f103a1aSEugene Zelenko } Mode = Initial;
97305fb371eSAnna Zaks
97405fb371eSAnna Zaks bool EnableNullFPSuppression;
975cd45bef2SGeorge Karpenkov bool ShouldInvalidate = true;
976a9791424SGeorge Karpenkov AnalyzerOptions& Options;
9773f7c66d5SKristof Umann bugreporter::TrackingKind TKind;
978ec44ac6aSJordan Rose
9795090904dSJordan Rose public:
ReturnVisitor(TrackerRef ParentTracker,const StackFrameContext * Frame,bool Suppressed,AnalyzerOptions & Options,bugreporter::TrackingKind TKind)980f853d260SValeriy Savchenko ReturnVisitor(TrackerRef ParentTracker, const StackFrameContext *Frame,
981f853d260SValeriy Savchenko bool Suppressed, AnalyzerOptions &Options,
982f853d260SValeriy Savchenko bugreporter::TrackingKind TKind)
983f853d260SValeriy Savchenko : TrackingBugReporterVisitor(ParentTracker), CalleeSFC(Frame),
984f853d260SValeriy Savchenko EnableNullFPSuppression(Suppressed), Options(Options), TKind(TKind) {}
9855090904dSJordan Rose
getTag()98652de8eecSJordan Rose static void *getTag() {
9875090904dSJordan Rose static int Tag = 0;
98852de8eecSJordan Rose return static_cast<void *>(&Tag);
98952de8eecSJordan Rose }
99052de8eecSJordan Rose
Profile(llvm::FoldingSetNodeID & ID) const991fb6b25b5SCraig Topper void Profile(llvm::FoldingSetNodeID &ID) const override {
99252de8eecSJordan Rose ID.AddPointer(ReturnVisitor::getTag());
99346929df7SKristof Umann ID.AddPointer(CalleeSFC);
99405fb371eSAnna Zaks ID.AddBoolean(EnableNullFPSuppression);
9955090904dSJordan Rose }
9965090904dSJordan Rose
visitNodeInitial(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)9976d716ef1SKristof Umann PathDiagnosticPieceRef visitNodeInitial(const ExplodedNode *N,
9986d716ef1SKristof Umann BugReporterContext &BRC,
9992f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
10005090904dSJordan Rose // Only print a message at the interesting return statement.
100146929df7SKristof Umann if (N->getLocationContext() != CalleeSFC)
10020dbb783cSCraig Topper return nullptr;
10035090904dSJordan Rose
100487396b9bSDavid Blaikie Optional<StmtPoint> SP = N->getLocationAs<StmtPoint>();
10055090904dSJordan Rose if (!SP)
10060dbb783cSCraig Topper return nullptr;
10075090904dSJordan Rose
10089f103a1aSEugene Zelenko const auto *Ret = dyn_cast<ReturnStmt>(SP->getStmt());
10095090904dSJordan Rose if (!Ret)
10100dbb783cSCraig Topper return nullptr;
10115090904dSJordan Rose
10125090904dSJordan Rose // Okay, we're at the right return statement, but do we have the return
10135090904dSJordan Rose // value available?
10145090904dSJordan Rose ProgramStateRef State = N->getState();
101546929df7SKristof Umann SVal V = State->getSVal(Ret, CalleeSFC);
10165090904dSJordan Rose if (V.isUnknownOrUndef())
10170dbb783cSCraig Topper return nullptr;
10185090904dSJordan Rose
10195090904dSJordan Rose // Don't print any more notes after this one.
1020ec44ac6aSJordan Rose Mode = Satisfied;
10215090904dSJordan Rose
1022801916baSJordan Rose const Expr *RetE = Ret->getRetValue();
1023801916baSJordan Rose assert(RetE && "Tracking a return value for a void function");
1024801916baSJordan Rose
1025801916baSJordan Rose // Handle cases where a reference is returned and then immediately used.
1026801916baSJordan Rose Optional<Loc> LValue;
1027801916baSJordan Rose if (RetE->isGLValue()) {
1028801916baSJordan Rose if ((LValue = V.getAs<Loc>())) {
1029801916baSJordan Rose SVal RValue = State->getRawSVal(*LValue, RetE->getType());
103096ccb690SBalazs Benics if (isa<DefinedSVal>(RValue))
1031801916baSJordan Rose V = RValue;
1032801916baSJordan Rose }
1033801916baSJordan Rose }
1034801916baSJordan Rose
10354a7bf49bSJordan Rose // Ignore aggregate rvalues.
103696ccb690SBalazs Benics if (isa<nonloc::LazyCompoundVal, nonloc::CompoundVal>(V))
10370dbb783cSCraig Topper return nullptr;
10384a7bf49bSJordan Rose
10395090904dSJordan Rose RetE = RetE->IgnoreParenCasts();
10405090904dSJordan Rose
10413f7c66d5SKristof Umann // Let's track the return value.
1042f853d260SValeriy Savchenko getParentTracker().track(RetE, N, {TKind, EnableNullFPSuppression});
10435090904dSJordan Rose
104452de8eecSJordan Rose // Build an appropriate message based on the return value.
104552de8eecSJordan Rose SmallString<64> Msg;
104652de8eecSJordan Rose llvm::raw_svector_ostream Out(Msg);
104752de8eecSJordan Rose
104846929df7SKristof Umann bool WouldEventBeMeaningless = false;
104946929df7SKristof Umann
1050baa78cc6SGeorge Karpenkov if (State->isNull(V).isConstrainedTrue()) {
105196ccb690SBalazs Benics if (isa<Loc>(V)) {
1052baa78cc6SGeorge Karpenkov
10535ca39546SJordan Rose // If we have counter-suppression enabled, make sure we keep visiting
10545ca39546SJordan Rose // future nodes. We want to emit a path note as well, in case
105552de8eecSJordan Rose // the report is resurrected as valid later on.
1056a9791424SGeorge Karpenkov if (EnableNullFPSuppression &&
1057549f9cd4SKristof Umann Options.ShouldAvoidSuppressingNullArgumentPaths)
10585ca39546SJordan Rose Mode = MaybeUnsuppress;
105952de8eecSJordan Rose
1060baa78cc6SGeorge Karpenkov if (RetE->getType()->isObjCObjectPointerType()) {
10615090904dSJordan Rose Out << "Returning nil";
1062baa78cc6SGeorge Karpenkov } else {
10635090904dSJordan Rose Out << "Returning null pointer";
1064baa78cc6SGeorge Karpenkov }
10655090904dSJordan Rose } else {
10665090904dSJordan Rose Out << "Returning zero";
10675090904dSJordan Rose }
10685090904dSJordan Rose
1069baa78cc6SGeorge Karpenkov } else {
1070baa78cc6SGeorge Karpenkov if (auto CI = V.getAs<nonloc::ConcreteInt>()) {
1071baa78cc6SGeorge Karpenkov Out << "Returning the value " << CI->getValue();
1072baa78cc6SGeorge Karpenkov } else {
107346929df7SKristof Umann // There is nothing interesting about returning a value, when it is
107446929df7SKristof Umann // plain value without any constraints, and the function is guaranteed
107546929df7SKristof Umann // to return that every time. We could use CFG::isLinear() here, but
107646929df7SKristof Umann // constexpr branches are obvious to the compiler, not necesserily to
107746929df7SKristof Umann // the programmer.
107846929df7SKristof Umann if (N->getCFG().size() == 3)
107946929df7SKristof Umann WouldEventBeMeaningless = true;
108046929df7SKristof Umann
108196ccb690SBalazs Benics Out << (isa<Loc>(V) ? "Returning pointer" : "Returning value");
1082baa78cc6SGeorge Karpenkov }
1083baa78cc6SGeorge Karpenkov }
1084baa78cc6SGeorge Karpenkov
1085801916baSJordan Rose if (LValue) {
1086801916baSJordan Rose if (const MemRegion *MR = LValue->getAsRegion()) {
1087801916baSJordan Rose if (MR->canPrintPretty()) {
10886cea7d9eSAnna Zaks Out << " (reference to ";
1089801916baSJordan Rose MR->printPretty(Out);
10906cea7d9eSAnna Zaks Out << ")";
1091801916baSJordan Rose }
1092801916baSJordan Rose }
1093801916baSJordan Rose } else {
10945090904dSJordan Rose // FIXME: We should have a more generalized location printing mechanism.
10959f103a1aSEugene Zelenko if (const auto *DR = dyn_cast<DeclRefExpr>(RetE))
10969f103a1aSEugene Zelenko if (const auto *DD = dyn_cast<DeclaratorDecl>(DR->getDecl()))
10975090904dSJordan Rose Out << " (loaded from '" << *DD << "')";
1098801916baSJordan Rose }
10995090904dSJordan Rose
110046929df7SKristof Umann PathDiagnosticLocation L(Ret, BRC.getSourceManager(), CalleeSFC);
1101b40d14f3SDevin Coughlin if (!L.isValid() || !L.asLocation().isValid())
1102b40d14f3SDevin Coughlin return nullptr;
1103b40d14f3SDevin Coughlin
1104da648ab8SKristof Umann if (TKind == bugreporter::TrackingKind::Condition)
1105da648ab8SKristof Umann Out << WillBeUsedForACondition;
1106da648ab8SKristof Umann
110746929df7SKristof Umann auto EventPiece = std::make_shared<PathDiagnosticEventPiece>(L, Out.str());
110846929df7SKristof Umann
110946929df7SKristof Umann // If we determined that the note is meaningless, make it prunable, and
111046929df7SKristof Umann // don't mark the stackframe interesting.
111146929df7SKristof Umann if (WouldEventBeMeaningless)
111246929df7SKristof Umann EventPiece->setPrunable(true);
111346929df7SKristof Umann else
111446929df7SKristof Umann BR.markInteresting(CalleeSFC);
111546929df7SKristof Umann
111646929df7SKristof Umann return EventPiece;
11175090904dSJordan Rose }
1118ec44ac6aSJordan Rose
visitNodeMaybeUnsuppress(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)11196d716ef1SKristof Umann PathDiagnosticPieceRef visitNodeMaybeUnsuppress(const ExplodedNode *N,
11206d716ef1SKristof Umann BugReporterContext &BRC,
11212f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
1122549f9cd4SKristof Umann assert(Options.ShouldAvoidSuppressingNullArgumentPaths);
11235ca39546SJordan Rose
1124ec44ac6aSJordan Rose // Are we at the entry node for this call?
112587396b9bSDavid Blaikie Optional<CallEnter> CE = N->getLocationAs<CallEnter>();
1126ec44ac6aSJordan Rose if (!CE)
11270dbb783cSCraig Topper return nullptr;
1128ec44ac6aSJordan Rose
112946929df7SKristof Umann if (CE->getCalleeContext() != CalleeSFC)
11300dbb783cSCraig Topper return nullptr;
1131ec44ac6aSJordan Rose
1132ec44ac6aSJordan Rose Mode = Satisfied;
1133ec44ac6aSJordan Rose
1134ec44ac6aSJordan Rose // Don't automatically suppress a report if one of the arguments is
1135ec44ac6aSJordan Rose // known to be a null pointer. Instead, start tracking /that/ null
1136ec44ac6aSJordan Rose // value back to its origin.
1137ec44ac6aSJordan Rose ProgramStateManager &StateMgr = BRC.getStateManager();
1138ec44ac6aSJordan Rose CallEventManager &CallMgr = StateMgr.getCallEventManager();
1139ec44ac6aSJordan Rose
1140ec44ac6aSJordan Rose ProgramStateRef State = N->getState();
114146929df7SKristof Umann CallEventRef<> Call = CallMgr.getCaller(CalleeSFC, State);
1142ec44ac6aSJordan Rose for (unsigned I = 0, E = Call->getNumArgs(); I != E; ++I) {
11435ca39546SJordan Rose Optional<Loc> ArgV = Call->getArgSVal(I).getAs<Loc>();
11445ca39546SJordan Rose if (!ArgV)
1145ec44ac6aSJordan Rose continue;
1146ec44ac6aSJordan Rose
1147ec44ac6aSJordan Rose const Expr *ArgE = Call->getArgExpr(I);
1148ec44ac6aSJordan Rose if (!ArgE)
1149ec44ac6aSJordan Rose continue;
1150ec44ac6aSJordan Rose
1151ec44ac6aSJordan Rose // Is it possible for this argument to be non-null?
1152ee47a5bdSJordan Rose if (!State->isNull(*ArgV).isConstrainedTrue())
1153ec44ac6aSJordan Rose continue;
1154ec44ac6aSJordan Rose
1155f853d260SValeriy Savchenko if (getParentTracker()
1156f853d260SValeriy Savchenko .track(ArgE, N, {TKind, EnableNullFPSuppression})
1157f853d260SValeriy Savchenko .FoundSomethingToTrack)
1158cd45bef2SGeorge Karpenkov ShouldInvalidate = false;
1159ec44ac6aSJordan Rose
1160ec44ac6aSJordan Rose // If we /can't/ track the null pointer, we should err on the side of
1161ec44ac6aSJordan Rose // false negatives, and continue towards marking this report invalid.
1162ec44ac6aSJordan Rose // (We will still look at the other arguments, though.)
1163ec44ac6aSJordan Rose }
1164ec44ac6aSJordan Rose
11650dbb783cSCraig Topper return nullptr;
1166ec44ac6aSJordan Rose }
1167ec44ac6aSJordan Rose
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)11686d716ef1SKristof Umann PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
1169ec44ac6aSJordan Rose BugReporterContext &BRC,
11702f169e7cSArtem Dergachev PathSensitiveBugReport &BR) override {
1171ec44ac6aSJordan Rose switch (Mode) {
1172ec44ac6aSJordan Rose case Initial:
1173c82d457dSGeorge Karpenkov return visitNodeInitial(N, BRC, BR);
11745ca39546SJordan Rose case MaybeUnsuppress:
1175c82d457dSGeorge Karpenkov return visitNodeMaybeUnsuppress(N, BRC, BR);
1176ec44ac6aSJordan Rose case Satisfied:
11770dbb783cSCraig Topper return nullptr;
1178ec44ac6aSJordan Rose }
1179ec44ac6aSJordan Rose
1180ec44ac6aSJordan Rose llvm_unreachable("Invalid visit mode!");
1181ec44ac6aSJordan Rose }
11825ca39546SJordan Rose
finalizeVisitor(BugReporterContext &,const ExplodedNode *,PathSensitiveBugReport & BR)1183c82d457dSGeorge Karpenkov void finalizeVisitor(BugReporterContext &, const ExplodedNode *,
11842f169e7cSArtem Dergachev PathSensitiveBugReport &BR) override {
1185cd45bef2SGeorge Karpenkov if (EnableNullFPSuppression && ShouldInvalidate)
118646929df7SKristof Umann BR.markInvalid(ReturnVisitor::getTag(), CalleeSFC);
11875ca39546SJordan Rose }
11885090904dSJordan Rose };
11895090904dSJordan Rose
11904cc6d72bSKristof Umann } // end of anonymous namespace
11914cc6d72bSKristof Umann
11924cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
119387a5c4d3SValeriy Savchenko // StoreSiteFinder
11944cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
11955090904dSJordan Rose
119687a5c4d3SValeriy Savchenko /// Finds last store into the given region,
119787a5c4d3SValeriy Savchenko /// which is different from a given symbolic value.
119887a5c4d3SValeriy Savchenko class StoreSiteFinder final : public TrackingBugReporterVisitor {
119987a5c4d3SValeriy Savchenko const MemRegion *R;
120087a5c4d3SValeriy Savchenko SVal V;
120187a5c4d3SValeriy Savchenko bool Satisfied = false;
120287a5c4d3SValeriy Savchenko
1203bbebf38bSValeriy Savchenko TrackingOptions Options;
120487a5c4d3SValeriy Savchenko const StackFrameContext *OriginSFC;
120587a5c4d3SValeriy Savchenko
120687a5c4d3SValeriy Savchenko public:
120787a5c4d3SValeriy Savchenko /// \param V We're searching for the store where \c R received this value.
120887a5c4d3SValeriy Savchenko /// \param R The region we're tracking.
1209ae691648SSimon Pilgrim /// \param Options Tracking behavior options.
121087a5c4d3SValeriy Savchenko /// \param OriginSFC Only adds notes when the last store happened in a
121187a5c4d3SValeriy Savchenko /// different stackframe to this one. Disregarded if the tracking kind
121287a5c4d3SValeriy Savchenko /// is thorough.
121387a5c4d3SValeriy Savchenko /// This is useful, because for non-tracked regions, notes about
121487a5c4d3SValeriy Savchenko /// changes to its value in a nested stackframe could be pruned, and
121587a5c4d3SValeriy Savchenko /// this visitor can prevent that without polluting the bugpath too
121687a5c4d3SValeriy Savchenko /// much.
StoreSiteFinder(bugreporter::TrackerRef ParentTracker,KnownSVal V,const MemRegion * R,TrackingOptions Options,const StackFrameContext * OriginSFC=nullptr)121787a5c4d3SValeriy Savchenko StoreSiteFinder(bugreporter::TrackerRef ParentTracker, KnownSVal V,
1218bbebf38bSValeriy Savchenko const MemRegion *R, TrackingOptions Options,
121987a5c4d3SValeriy Savchenko const StackFrameContext *OriginSFC = nullptr)
1220bbebf38bSValeriy Savchenko : TrackingBugReporterVisitor(ParentTracker), R(R), V(V), Options(Options),
122187a5c4d3SValeriy Savchenko OriginSFC(OriginSFC) {
122287a5c4d3SValeriy Savchenko assert(R);
122387a5c4d3SValeriy Savchenko }
122487a5c4d3SValeriy Savchenko
122587a5c4d3SValeriy Savchenko void Profile(llvm::FoldingSetNodeID &ID) const override;
122687a5c4d3SValeriy Savchenko
122787a5c4d3SValeriy Savchenko PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
122887a5c4d3SValeriy Savchenko BugReporterContext &BRC,
122987a5c4d3SValeriy Savchenko PathSensitiveBugReport &BR) override;
123087a5c4d3SValeriy Savchenko };
123187a5c4d3SValeriy Savchenko
Profile(llvm::FoldingSetNodeID & ID) const123287a5c4d3SValeriy Savchenko void StoreSiteFinder::Profile(llvm::FoldingSetNodeID &ID) const {
1233fa0734ecSArgyrios Kyrtzidis static int tag = 0;
1234fa0734ecSArgyrios Kyrtzidis ID.AddPointer(&tag);
1235fa0734ecSArgyrios Kyrtzidis ID.AddPointer(R);
1236fa0734ecSArgyrios Kyrtzidis ID.Add(V);
1237bbebf38bSValeriy Savchenko ID.AddInteger(static_cast<int>(Options.Kind));
1238bbebf38bSValeriy Savchenko ID.AddBoolean(Options.EnableNullFPSuppression);
1239fa0734ecSArgyrios Kyrtzidis }
1240fa0734ecSArgyrios Kyrtzidis
1241320fbf05SJordan Rose /// Returns true if \p N represents the DeclStmt declaring and initializing
1242320fbf05SJordan Rose /// \p VR.
isInitializationOfVar(const ExplodedNode * N,const VarRegion * VR)1243320fbf05SJordan Rose static bool isInitializationOfVar(const ExplodedNode *N, const VarRegion *VR) {
1244320fbf05SJordan Rose Optional<PostStmt> P = N->getLocationAs<PostStmt>();
1245320fbf05SJordan Rose if (!P)
1246320fbf05SJordan Rose return false;
1247320fbf05SJordan Rose
1248320fbf05SJordan Rose const DeclStmt *DS = P->getStmtAs<DeclStmt>();
1249320fbf05SJordan Rose if (!DS)
1250320fbf05SJordan Rose return false;
1251320fbf05SJordan Rose
1252320fbf05SJordan Rose if (DS->getSingleDecl() != VR->getDecl())
1253320fbf05SJordan Rose return false;
1254320fbf05SJordan Rose
1255320fbf05SJordan Rose const MemSpaceRegion *VarSpace = VR->getMemorySpace();
12569f103a1aSEugene Zelenko const auto *FrameSpace = dyn_cast<StackSpaceRegion>(VarSpace);
1257320fbf05SJordan Rose if (!FrameSpace) {
1258320fbf05SJordan Rose // If we ever directly evaluate global DeclStmts, this assertion will be
1259320fbf05SJordan Rose // invalid, but this still seems preferable to silently accepting an
1260320fbf05SJordan Rose // initialization that may be for a path-sensitive variable.
1261320fbf05SJordan Rose assert(VR->getDecl()->isStaticLocal() && "non-static stackless VarRegion");
1262320fbf05SJordan Rose return true;
1263320fbf05SJordan Rose }
1264320fbf05SJordan Rose
1265320fbf05SJordan Rose assert(VR->getDecl()->hasLocalStorage());
1266320fbf05SJordan Rose const LocationContext *LCtx = N->getLocationContext();
1267dd18b11bSGeorge Karpenkov return FrameSpace->getStackFrame() == LCtx->getStackFrame();
1268320fbf05SJordan Rose }
1269320fbf05SJordan Rose
isObjCPointer(const MemRegion * R)127016f7a952SValeriy Savchenko static bool isObjCPointer(const MemRegion *R) {
127116f7a952SValeriy Savchenko if (R->isBoundable())
127216f7a952SValeriy Savchenko if (const auto *TR = dyn_cast<TypedValueRegion>(R))
127316f7a952SValeriy Savchenko return TR->getValueType()->isObjCObjectPointerType();
127416f7a952SValeriy Savchenko
127516f7a952SValeriy Savchenko return false;
127616f7a952SValeriy Savchenko }
127716f7a952SValeriy Savchenko
isObjCPointer(const ValueDecl * D)127816f7a952SValeriy Savchenko static bool isObjCPointer(const ValueDecl *D) {
127916f7a952SValeriy Savchenko return D->getType()->isObjCObjectPointerType();
128016f7a952SValeriy Savchenko }
128116f7a952SValeriy Savchenko
128257dc6b7cSGeorge Karpenkov /// Show diagnostics for initializing or declaring a region \p R with a bad value.
showBRDiagnostics(llvm::raw_svector_ostream & OS,StoreInfo SI)128316f7a952SValeriy Savchenko static void showBRDiagnostics(llvm::raw_svector_ostream &OS, StoreInfo SI) {
128416f7a952SValeriy Savchenko const bool HasPrefix = SI.Dest->canPrintPretty();
128516f7a952SValeriy Savchenko
128616f7a952SValeriy Savchenko if (HasPrefix) {
128716f7a952SValeriy Savchenko SI.Dest->printPretty(OS);
128816f7a952SValeriy Savchenko OS << " ";
128957dc6b7cSGeorge Karpenkov }
129057dc6b7cSGeorge Karpenkov
129116f7a952SValeriy Savchenko const char *Action = nullptr;
129257dc6b7cSGeorge Karpenkov
129316f7a952SValeriy Savchenko switch (SI.StoreKind) {
129416f7a952SValeriy Savchenko case StoreInfo::Initialization:
129516f7a952SValeriy Savchenko Action = HasPrefix ? "initialized to " : "Initializing to ";
129616f7a952SValeriy Savchenko break;
129716f7a952SValeriy Savchenko case StoreInfo::BlockCapture:
129816f7a952SValeriy Savchenko Action = HasPrefix ? "captured by block as " : "Captured by block as ";
129916f7a952SValeriy Savchenko break;
130016f7a952SValeriy Savchenko default:
130116f7a952SValeriy Savchenko llvm_unreachable("Unexpected store kind");
130216f7a952SValeriy Savchenko }
130316f7a952SValeriy Savchenko
130496ccb690SBalazs Benics if (isa<loc::ConcreteInt>(SI.Value)) {
130516f7a952SValeriy Savchenko OS << Action << (isObjCPointer(SI.Dest) ? "nil" : "a null pointer value");
130616f7a952SValeriy Savchenko
130716f7a952SValeriy Savchenko } else if (auto CVal = SI.Value.getAs<nonloc::ConcreteInt>()) {
130816f7a952SValeriy Savchenko OS << Action << CVal->getValue();
130916f7a952SValeriy Savchenko
131016f7a952SValeriy Savchenko } else if (SI.Origin && SI.Origin->canPrintPretty()) {
131116f7a952SValeriy Savchenko OS << Action << "the value of ";
131216f7a952SValeriy Savchenko SI.Origin->printPretty(OS);
131316f7a952SValeriy Savchenko
131416f7a952SValeriy Savchenko } else if (SI.StoreKind == StoreInfo::Initialization) {
131516f7a952SValeriy Savchenko // We don't need to check here, all these conditions were
131616f7a952SValeriy Savchenko // checked by StoreSiteFinder, when it figured out that it is
131716f7a952SValeriy Savchenko // initialization.
131816f7a952SValeriy Savchenko const auto *DS =
131916f7a952SValeriy Savchenko cast<DeclStmt>(SI.StoreSite->getLocationAs<PostStmt>()->getStmt());
132016f7a952SValeriy Savchenko
132116f7a952SValeriy Savchenko if (SI.Value.isUndef()) {
132216f7a952SValeriy Savchenko if (isa<VarRegion>(SI.Dest)) {
13239f103a1aSEugene Zelenko const auto *VD = cast<VarDecl>(DS->getSingleDecl());
132416f7a952SValeriy Savchenko
132557dc6b7cSGeorge Karpenkov if (VD->getInit()) {
132616f7a952SValeriy Savchenko OS << (HasPrefix ? "initialized" : "Initializing")
132757dc6b7cSGeorge Karpenkov << " to a garbage value";
132857dc6b7cSGeorge Karpenkov } else {
132916f7a952SValeriy Savchenko OS << (HasPrefix ? "declared" : "Declaring")
133057dc6b7cSGeorge Karpenkov << " without an initial value";
133157dc6b7cSGeorge Karpenkov }
133257dc6b7cSGeorge Karpenkov }
133357dc6b7cSGeorge Karpenkov } else {
133416f7a952SValeriy Savchenko OS << (HasPrefix ? "initialized" : "Initialized") << " here";
133557dc6b7cSGeorge Karpenkov }
133657dc6b7cSGeorge Karpenkov }
133757dc6b7cSGeorge Karpenkov }
133857dc6b7cSGeorge Karpenkov
133957dc6b7cSGeorge Karpenkov /// Display diagnostics for passing bad region as a parameter.
showBRParamDiagnostics(llvm::raw_svector_ostream & OS,StoreInfo SI)134016f7a952SValeriy Savchenko static void showBRParamDiagnostics(llvm::raw_svector_ostream &OS,
134116f7a952SValeriy Savchenko StoreInfo SI) {
134216f7a952SValeriy Savchenko const auto *VR = cast<VarRegion>(SI.Dest);
134357dc6b7cSGeorge Karpenkov const auto *Param = cast<ParmVarDecl>(VR->getDecl());
134457dc6b7cSGeorge Karpenkov
134516f7a952SValeriy Savchenko OS << "Passing ";
134657dc6b7cSGeorge Karpenkov
134796ccb690SBalazs Benics if (isa<loc::ConcreteInt>(SI.Value)) {
134816f7a952SValeriy Savchenko OS << (isObjCPointer(Param) ? "nil object reference"
134916f7a952SValeriy Savchenko : "null pointer value");
135016f7a952SValeriy Savchenko
135116f7a952SValeriy Savchenko } else if (SI.Value.isUndef()) {
135216f7a952SValeriy Savchenko OS << "uninitialized value";
135316f7a952SValeriy Savchenko
135416f7a952SValeriy Savchenko } else if (auto CI = SI.Value.getAs<nonloc::ConcreteInt>()) {
135516f7a952SValeriy Savchenko OS << "the value " << CI->getValue();
135616f7a952SValeriy Savchenko
135716f7a952SValeriy Savchenko } else if (SI.Origin && SI.Origin->canPrintPretty()) {
135816f7a952SValeriy Savchenko SI.Origin->printPretty(OS);
135916f7a952SValeriy Savchenko
136057dc6b7cSGeorge Karpenkov } else {
136116f7a952SValeriy Savchenko OS << "value";
136257dc6b7cSGeorge Karpenkov }
136357dc6b7cSGeorge Karpenkov
136457dc6b7cSGeorge Karpenkov // Printed parameter indexes are 1-based, not 0-based.
136557dc6b7cSGeorge Karpenkov unsigned Idx = Param->getFunctionScopeIndex() + 1;
136616f7a952SValeriy Savchenko OS << " via " << Idx << llvm::getOrdinalSuffix(Idx) << " parameter";
136757dc6b7cSGeorge Karpenkov if (VR->canPrintPretty()) {
136816f7a952SValeriy Savchenko OS << " ";
136916f7a952SValeriy Savchenko VR->printPretty(OS);
137057dc6b7cSGeorge Karpenkov }
137157dc6b7cSGeorge Karpenkov }
137257dc6b7cSGeorge Karpenkov
137357dc6b7cSGeorge Karpenkov /// Show default diagnostics for storing bad region.
showBRDefaultDiagnostics(llvm::raw_svector_ostream & OS,StoreInfo SI)137416f7a952SValeriy Savchenko static void showBRDefaultDiagnostics(llvm::raw_svector_ostream &OS,
137516f7a952SValeriy Savchenko StoreInfo SI) {
137616f7a952SValeriy Savchenko const bool HasSuffix = SI.Dest->canPrintPretty();
137757dc6b7cSGeorge Karpenkov
137896ccb690SBalazs Benics if (isa<loc::ConcreteInt>(SI.Value)) {
137916f7a952SValeriy Savchenko OS << (isObjCPointer(SI.Dest) ? "nil object reference stored"
138016f7a952SValeriy Savchenko : (HasSuffix ? "Null pointer value stored"
138116f7a952SValeriy Savchenko : "Storing null pointer value"));
138257dc6b7cSGeorge Karpenkov
138316f7a952SValeriy Savchenko } else if (SI.Value.isUndef()) {
138416f7a952SValeriy Savchenko OS << (HasSuffix ? "Uninitialized value stored"
138516f7a952SValeriy Savchenko : "Storing uninitialized value");
138657dc6b7cSGeorge Karpenkov
138716f7a952SValeriy Savchenko } else if (auto CV = SI.Value.getAs<nonloc::ConcreteInt>()) {
138816f7a952SValeriy Savchenko if (HasSuffix)
138916f7a952SValeriy Savchenko OS << "The value " << CV->getValue() << " is assigned";
139016f7a952SValeriy Savchenko else
139116f7a952SValeriy Savchenko OS << "Assigning " << CV->getValue();
139216f7a952SValeriy Savchenko
139316f7a952SValeriy Savchenko } else if (SI.Origin && SI.Origin->canPrintPretty()) {
139416f7a952SValeriy Savchenko if (HasSuffix) {
139516f7a952SValeriy Savchenko OS << "The value of ";
139616f7a952SValeriy Savchenko SI.Origin->printPretty(OS);
139716f7a952SValeriy Savchenko OS << " is assigned";
139857dc6b7cSGeorge Karpenkov } else {
139916f7a952SValeriy Savchenko OS << "Assigning the value of ";
140016f7a952SValeriy Savchenko SI.Origin->printPretty(OS);
1401ab582386SValeriy Savchenko }
1402ab582386SValeriy Savchenko
1403ab582386SValeriy Savchenko } else {
140416f7a952SValeriy Savchenko OS << (HasSuffix ? "Value assigned" : "Assigning value");
140557dc6b7cSGeorge Karpenkov }
140657dc6b7cSGeorge Karpenkov
140716f7a952SValeriy Savchenko if (HasSuffix) {
140816f7a952SValeriy Savchenko OS << " to ";
140916f7a952SValeriy Savchenko SI.Dest->printPretty(OS);
141057dc6b7cSGeorge Karpenkov }
141157dc6b7cSGeorge Karpenkov }
141257dc6b7cSGeorge Karpenkov
VisitNode(const ExplodedNode * Succ,BugReporterContext & BRC,PathSensitiveBugReport & BR)141387a5c4d3SValeriy Savchenko PathDiagnosticPieceRef StoreSiteFinder::VisitNode(const ExplodedNode *Succ,
14142f169e7cSArtem Dergachev BugReporterContext &BRC,
14152f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
1416e3cf1717STed Kremenek if (Satisfied)
14170dbb783cSCraig Topper return nullptr;
1418fa0734ecSArgyrios Kyrtzidis
14190dbb783cSCraig Topper const ExplodedNode *StoreSite = nullptr;
1420c82d457dSGeorge Karpenkov const ExplodedNode *Pred = Succ->getFirstPred();
14210dbb783cSCraig Topper const Expr *InitE = nullptr;
1422199fdd82SJordan Rose bool IsParam = false;
1423adec516fSJordan Rose
142472c5515bSJordan Rose // First see if we reached the declaration of the region.
14259f103a1aSEugene Zelenko if (const auto *VR = dyn_cast<VarRegion>(R)) {
1426320fbf05SJordan Rose if (isInitializationOfVar(Pred, VR)) {
142772c5515bSJordan Rose StoreSite = Pred;
14285090904dSJordan Rose InitE = VR->getDecl()->getInit();
142972c5515bSJordan Rose }
143072c5515bSJordan Rose }
1431fa0734ecSArgyrios Kyrtzidis
1432ece622abSAnna Zaks // If this is a post initializer expression, initializing the region, we
1433ece622abSAnna Zaks // should track the initializer expression.
1434ece622abSAnna Zaks if (Optional<PostInitializer> PIP = Pred->getLocationAs<PostInitializer>()) {
1435ece622abSAnna Zaks const MemRegion *FieldReg = (const MemRegion *)PIP->getLocationValue();
14363f7c66d5SKristof Umann if (FieldReg == R) {
1437ece622abSAnna Zaks StoreSite = Pred;
1438ece622abSAnna Zaks InitE = PIP->getInitializer()->getInit();
1439ece622abSAnna Zaks }
1440ece622abSAnna Zaks }
1441ece622abSAnna Zaks
1442f7f32d52SJordan Rose // Otherwise, see if this is the store site:
1443f7f32d52SJordan Rose // (1) Succ has this binding and Pred does not, i.e. this is
144472c5515bSJordan Rose // where the binding first occurred.
1445f7f32d52SJordan Rose // (2) Succ has this binding and is a PostStore node for this region, i.e.
1446f7f32d52SJordan Rose // the same binding was re-assigned here.
144772c5515bSJordan Rose if (!StoreSite) {
144872c5515bSJordan Rose if (Succ->getState()->getSVal(R) != V)
14490dbb783cSCraig Topper return nullptr;
1450f7f32d52SJordan Rose
14513bd63ae3SAdam Balogh if (hasVisibleUpdate(Pred, Pred->getState()->getSVal(R), Succ, V)) {
1452f7f32d52SJordan Rose Optional<PostStore> PS = Succ->getLocationAs<PostStore>();
1453f7f32d52SJordan Rose if (!PS || PS->getLocationValue() != R)
14540dbb783cSCraig Topper return nullptr;
1455f7f32d52SJordan Rose }
145672c5515bSJordan Rose
145772c5515bSJordan Rose StoreSite = Succ;
145872c5515bSJordan Rose
14595090904dSJordan Rose // If this is an assignment expression, we can track the value
14605090904dSJordan Rose // being assigned.
146187396b9bSDavid Blaikie if (Optional<PostStmt> P = Succ->getLocationAs<PostStmt>())
146272c5515bSJordan Rose if (const BinaryOperator *BO = P->getStmtAs<BinaryOperator>())
14635090904dSJordan Rose if (BO->isAssignmentOp())
14645090904dSJordan Rose InitE = BO->getRHS();
1465106b037aSJordan Rose
1466106b037aSJordan Rose // If this is a call entry, the variable should be a parameter.
1467106b037aSJordan Rose // FIXME: Handle CXXThisRegion as well. (This is not a priority because
1468106b037aSJordan Rose // 'this' should never be NULL, but this visitor isn't just for NULL and
1469106b037aSJordan Rose // UndefinedVal.)
147087396b9bSDavid Blaikie if (Optional<CallEnter> CE = Succ->getLocationAs<CallEnter>()) {
14719f103a1aSEugene Zelenko if (const auto *VR = dyn_cast<VarRegion>(R)) {
14723bd63ae3SAdam Balogh
1473ab2cec8bSArtem Dergachev if (const auto *Param = dyn_cast<ParmVarDecl>(VR->getDecl())) {
1474106b037aSJordan Rose ProgramStateManager &StateMgr = BRC.getStateManager();
1475106b037aSJordan Rose CallEventManager &CallMgr = StateMgr.getCallEventManager();
1476106b037aSJordan Rose
1477106b037aSJordan Rose CallEventRef<> Call = CallMgr.getCaller(CE->getCalleeContext(),
1478106b037aSJordan Rose Succ->getState());
1479106b037aSJordan Rose InitE = Call->getArgExpr(Param->getFunctionScopeIndex());
1480ab2cec8bSArtem Dergachev } else {
1481ab2cec8bSArtem Dergachev // Handle Objective-C 'self'.
1482ab2cec8bSArtem Dergachev assert(isa<ImplicitParamDecl>(VR->getDecl()));
1483ab2cec8bSArtem Dergachev InitE = cast<ObjCMessageExpr>(CE->getCalleeContext()->getCallSite())
1484ab2cec8bSArtem Dergachev ->getInstanceReceiver()->IgnoreParenCasts();
1485ab2cec8bSArtem Dergachev }
1486199fdd82SJordan Rose IsParam = true;
1487106b037aSJordan Rose }
14885090904dSJordan Rose }
1489e9989bd4SAnna Zaks
1490e9989bd4SAnna Zaks // If this is a CXXTempObjectRegion, the Expr responsible for its creation
1491e9989bd4SAnna Zaks // is wrapped inside of it.
14929f103a1aSEugene Zelenko if (const auto *TmpR = dyn_cast<CXXTempObjectRegion>(R))
1493e9989bd4SAnna Zaks InitE = TmpR->getExpr();
14949db5f52cSTed Kremenek }
14955090904dSJordan Rose
149672c5515bSJordan Rose if (!StoreSite)
14970dbb783cSCraig Topper return nullptr;
1498b8ac93c7SKristof Umann
1499e3cf1717STed Kremenek Satisfied = true;
15005090904dSJordan Rose
15014ac7cba4SJordan Rose // If we have an expression that provided the value, try to track where it
15024ac7cba4SJordan Rose // came from.
15035090904dSJordan Rose if (InitE) {
1504199fdd82SJordan Rose if (!IsParam)
15055090904dSJordan Rose InitE = InitE->IgnoreParenCasts();
15060df9c8c5SKristof Umann
1507bbebf38bSValeriy Savchenko getParentTracker().track(InitE, StoreSite, Options);
1508ab582386SValeriy Savchenko }
1509ab582386SValeriy Savchenko
1510ab582386SValeriy Savchenko // Let's try to find the region where the value came from.
1511ab582386SValeriy Savchenko const MemRegion *OldRegion = nullptr;
1512ab582386SValeriy Savchenko
1513ab582386SValeriy Savchenko // If we have init expression, it might be simply a reference
1514ab582386SValeriy Savchenko // to a variable, so we can use it.
1515ab582386SValeriy Savchenko if (InitE) {
1516ab582386SValeriy Savchenko // That region might still be not exactly what we are looking for.
1517ab582386SValeriy Savchenko // In situations like `int &ref = val;`, we can't say that
1518ab582386SValeriy Savchenko // `ref` is initialized with `val`, rather refers to `val`.
1519ab582386SValeriy Savchenko //
1520ab582386SValeriy Savchenko // In order, to mitigate situations like this, we check if the last
1521ab582386SValeriy Savchenko // stored value in that region is the value that we track.
1522ab582386SValeriy Savchenko //
1523ab582386SValeriy Savchenko // TODO: support other situations better.
1524ab582386SValeriy Savchenko if (const MemRegion *Candidate =
1525ab582386SValeriy Savchenko getLocationRegionIfReference(InitE, Succ, false)) {
1526ab582386SValeriy Savchenko const StoreManager &SM = BRC.getStateManager().getStoreManager();
1527ab582386SValeriy Savchenko
1528ab582386SValeriy Savchenko // Here we traverse the graph up to find the last node where the
1529ab582386SValeriy Savchenko // candidate region is still in the store.
1530ab582386SValeriy Savchenko for (const ExplodedNode *N = StoreSite; N; N = N->getFirstPred()) {
1531ab582386SValeriy Savchenko if (SM.includedInBindings(N->getState()->getStore(), Candidate)) {
1532ab582386SValeriy Savchenko // And if it was bound to the target value, we can use it.
1533ab582386SValeriy Savchenko if (N->getState()->getSVal(Candidate) == V) {
1534ab582386SValeriy Savchenko OldRegion = Candidate;
1535ab582386SValeriy Savchenko }
1536ab582386SValeriy Savchenko break;
1537ab582386SValeriy Savchenko }
1538ab582386SValeriy Savchenko }
1539ab582386SValeriy Savchenko }
1540ab582386SValeriy Savchenko }
1541ab582386SValeriy Savchenko
1542ab582386SValeriy Savchenko // Otherwise, if the current region does indeed contain the value
1543ab582386SValeriy Savchenko // we are looking for, we can look for a region where this value
1544ab582386SValeriy Savchenko // was before.
1545ab582386SValeriy Savchenko //
1546ab582386SValeriy Savchenko // It can be useful for situations like:
1547ab582386SValeriy Savchenko // new = identity(old)
1548ab582386SValeriy Savchenko // where the analyzer knows that 'identity' returns the value of its
1549ab582386SValeriy Savchenko // first argument.
1550ab582386SValeriy Savchenko //
1551ab582386SValeriy Savchenko // NOTE: If the region R is not a simple var region, it can contain
1552ab582386SValeriy Savchenko // V in one of its subregions.
1553ab582386SValeriy Savchenko if (!OldRegion && StoreSite->getState()->getSVal(R) == V) {
1554ab582386SValeriy Savchenko // Let's go up the graph to find the node where the region is
1555ab582386SValeriy Savchenko // bound to V.
1556ab582386SValeriy Savchenko const ExplodedNode *NodeWithoutBinding = StoreSite->getFirstPred();
1557ab582386SValeriy Savchenko for (;
1558ab582386SValeriy Savchenko NodeWithoutBinding && NodeWithoutBinding->getState()->getSVal(R) == V;
1559ab582386SValeriy Savchenko NodeWithoutBinding = NodeWithoutBinding->getFirstPred()) {
1560ab582386SValeriy Savchenko }
1561ab582386SValeriy Savchenko
1562ab582386SValeriy Savchenko if (NodeWithoutBinding) {
1563ab582386SValeriy Savchenko // Let's try to find a unique binding for the value in that node.
1564ab582386SValeriy Savchenko // We want to use this to find unique bindings because of the following
1565ab582386SValeriy Savchenko // situations:
1566ab582386SValeriy Savchenko // b = a;
1567ab582386SValeriy Savchenko // c = identity(b);
1568ab582386SValeriy Savchenko //
1569ab582386SValeriy Savchenko // Telling the user that the value of 'a' is assigned to 'c', while
1570ab582386SValeriy Savchenko // correct, can be confusing.
1571ab582386SValeriy Savchenko StoreManager::FindUniqueBinding FB(V.getAsLocSymbol());
1572ab582386SValeriy Savchenko BRC.getStateManager().iterBindings(NodeWithoutBinding->getState(), FB);
1573ab582386SValeriy Savchenko if (FB)
1574ab582386SValeriy Savchenko OldRegion = FB.getRegion();
1575ab582386SValeriy Savchenko }
1576baa78cc6SGeorge Karpenkov }
1577fa0734ecSArgyrios Kyrtzidis
1578bbebf38bSValeriy Savchenko if (Options.Kind == TrackingKind::Condition && OriginSFC &&
1579967583bcSKristof Umann !OriginSFC->isParentOf(StoreSite->getStackFrame()))
1580967583bcSKristof Umann return nullptr;
1581967583bcSKristof Umann
158272c5515bSJordan Rose // Okay, we've found the binding. Emit an appropriate message.
15832c1dd271SDylan Noblesmith SmallString<256> sbuf;
1584fa0734ecSArgyrios Kyrtzidis llvm::raw_svector_ostream os(sbuf);
1585fa0734ecSArgyrios Kyrtzidis
1586bbebf38bSValeriy Savchenko StoreInfo SI = {StoreInfo::Assignment, // default kind
1587bbebf38bSValeriy Savchenko StoreSite,
1588bbebf38bSValeriy Savchenko InitE,
1589bbebf38bSValeriy Savchenko V,
1590bbebf38bSValeriy Savchenko R,
1591bbebf38bSValeriy Savchenko OldRegion};
1592bbebf38bSValeriy Savchenko
159387396b9bSDavid Blaikie if (Optional<PostStmt> PS = StoreSite->getLocationAs<PostStmt>()) {
15948ae67871STed Kremenek const Stmt *S = PS->getStmt();
15959f103a1aSEugene Zelenko const auto *DS = dyn_cast<DeclStmt>(S);
15969f103a1aSEugene Zelenko const auto *VR = dyn_cast<VarRegion>(R);
1597fa0734ecSArgyrios Kyrtzidis
15988ae67871STed Kremenek if (DS) {
1599bbebf38bSValeriy Savchenko SI.StoreKind = StoreInfo::Initialization;
16008ae67871STed Kremenek } else if (isa<BlockExpr>(S)) {
1601bbebf38bSValeriy Savchenko SI.StoreKind = StoreInfo::BlockCapture;
16028ae67871STed Kremenek if (VR) {
16038ae67871STed Kremenek // See if we can get the BlockVarRegion.
16048ae67871STed Kremenek ProgramStateRef State = StoreSite->getState();
1605d703ec94SGeorge Karpenkov SVal V = StoreSite->getSVal(S);
16069f103a1aSEugene Zelenko if (const auto *BDR =
16078ae67871STed Kremenek dyn_cast_or_null<BlockDataRegion>(V.getAsRegion())) {
16088ae67871STed Kremenek if (const VarRegion *OriginalR = BDR->getOriginalRegion(VR)) {
1609bbebf38bSValeriy Savchenko getParentTracker().track(State->getSVal(OriginalR), OriginalR,
1610bbebf38bSValeriy Savchenko Options, OriginSFC);
1611fa0734ecSArgyrios Kyrtzidis }
16128ae67871STed Kremenek }
16138ae67871STed Kremenek }
16148ae67871STed Kremenek }
1615bbebf38bSValeriy Savchenko } else if (SI.StoreSite->getLocation().getAs<CallEnter>() &&
1616bbebf38bSValeriy Savchenko isa<VarRegion>(SI.Dest)) {
1617bbebf38bSValeriy Savchenko SI.StoreKind = StoreInfo::CallArgument;
1618106b037aSJordan Rose }
1619106b037aSJordan Rose
1620bbebf38bSValeriy Savchenko return getParentTracker().handle(SI, BRC, Options);
1621fa0734ecSArgyrios Kyrtzidis }
1622fa0734ecSArgyrios Kyrtzidis
16234cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
16244cc6d72bSKristof Umann // Implementation of TrackConstraintBRVisitor.
16254cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
16264cc6d72bSKristof Umann
Profile(llvm::FoldingSetNodeID & ID) const1627f86615caSAnna Zaks void TrackConstraintBRVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
1628fa0734ecSArgyrios Kyrtzidis static int tag = 0;
1629fa0734ecSArgyrios Kyrtzidis ID.AddPointer(&tag);
1630fa0734ecSArgyrios Kyrtzidis ID.AddBoolean(Assumption);
1631fa0734ecSArgyrios Kyrtzidis ID.Add(Constraint);
1632fa0734ecSArgyrios Kyrtzidis }
1633fa0734ecSArgyrios Kyrtzidis
1634a5958869STed Kremenek /// Return the tag associated with this visitor. This tag will be used
1635a5958869STed Kremenek /// to make all PathDiagnosticPieces created by this visitor.
getTag()1636a5958869STed Kremenek const char *TrackConstraintBRVisitor::getTag() {
1637a5958869STed Kremenek return "TrackConstraintBRVisitor";
1638a5958869STed Kremenek }
1639a5958869STed Kremenek
isUnderconstrained(const ExplodedNode * N) const1640ee47a5bdSJordan Rose bool TrackConstraintBRVisitor::isUnderconstrained(const ExplodedNode *N) const {
1641ee47a5bdSJordan Rose if (IsZeroCheck)
1642ee47a5bdSJordan Rose return N->getState()->isNull(Constraint).isUnderconstrained();
1643507f1bc3SRafael Espindola return (bool)N->getState()->assume(Constraint, !Assumption);
1644ee47a5bdSJordan Rose }
1645ee47a5bdSJordan Rose
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport &)16462f169e7cSArtem Dergachev PathDiagnosticPieceRef TrackConstraintBRVisitor::VisitNode(
16472f169e7cSArtem Dergachev const ExplodedNode *N, BugReporterContext &BRC, PathSensitiveBugReport &) {
1648c82d457dSGeorge Karpenkov const ExplodedNode *PrevN = N->getFirstPred();
1649ee47a5bdSJordan Rose if (IsSatisfied)
16500dbb783cSCraig Topper return nullptr;
1651fa0734ecSArgyrios Kyrtzidis
165254f4d01bSAnna Zaks // Start tracking after we see the first state in which the value is
165354f4d01bSAnna Zaks // constrained.
165454f4d01bSAnna Zaks if (!IsTrackingTurnedOn)
165554f4d01bSAnna Zaks if (!isUnderconstrained(N))
165654f4d01bSAnna Zaks IsTrackingTurnedOn = true;
165754f4d01bSAnna Zaks if (!IsTrackingTurnedOn)
16580dbb783cSCraig Topper return nullptr;
165954f4d01bSAnna Zaks
1660fa0734ecSArgyrios Kyrtzidis // Check if in the previous state it was feasible for this constraint
1661fa0734ecSArgyrios Kyrtzidis // to *not* be true.
1662ee47a5bdSJordan Rose if (isUnderconstrained(PrevN)) {
1663ee47a5bdSJordan Rose IsSatisfied = true;
1664fa0734ecSArgyrios Kyrtzidis
1665d8e5a0c4SZarko Todorovski // At this point, the negation of the constraint should be infeasible. If it
1666d8e5a0c4SZarko Todorovski // is feasible, make sure that the negation of the constrainti was
1667d8e5a0c4SZarko Todorovski // infeasible in the current state. If it is feasible, we somehow missed
1668d8e5a0c4SZarko Todorovski // the transition point.
166954f4d01bSAnna Zaks assert(!isUnderconstrained(N));
1670fa0734ecSArgyrios Kyrtzidis
1671fa0734ecSArgyrios Kyrtzidis // We found the transition point for the constraint. We now need to
1672fa0734ecSArgyrios Kyrtzidis // pretty-print the constraint. (work-in-progress)
1673ee47a5bdSJordan Rose SmallString<64> sbuf;
1674ee47a5bdSJordan Rose llvm::raw_svector_ostream os(sbuf);
1675fa0734ecSArgyrios Kyrtzidis
167696ccb690SBalazs Benics if (isa<Loc>(Constraint)) {
1677fa0734ecSArgyrios Kyrtzidis os << "Assuming pointer value is ";
1678fa0734ecSArgyrios Kyrtzidis os << (Assumption ? "non-null" : "null");
1679fa0734ecSArgyrios Kyrtzidis }
1680fa0734ecSArgyrios Kyrtzidis
1681fa0734ecSArgyrios Kyrtzidis if (os.str().empty())
16820dbb783cSCraig Topper return nullptr;
1683fa0734ecSArgyrios Kyrtzidis
1684fa0734ecSArgyrios Kyrtzidis // Construct a new PathDiagnosticPiece.
1685921f0492SAnna Zaks ProgramPoint P = N->getLocation();
1686f68c0a2fSArtem Dergachev
1687f68c0a2fSArtem Dergachev // If this node already have a specialized note, it's probably better
1688f68c0a2fSArtem Dergachev // than our generic note.
1689f68c0a2fSArtem Dergachev // FIXME: This only looks for note tags, not for other ways to add a note.
1690f68c0a2fSArtem Dergachev if (isa_and_nonnull<NoteTag>(P.getTag()))
1691f68c0a2fSArtem Dergachev return nullptr;
1692f68c0a2fSArtem Dergachev
1693de8c5eddSAnna Zaks PathDiagnosticLocation L =
1694de8c5eddSAnna Zaks PathDiagnosticLocation::create(P, BRC.getSourceManager());
1695921f0492SAnna Zaks if (!L.isValid())
16960dbb783cSCraig Topper return nullptr;
1697a5958869STed Kremenek
16980a0c275fSDavid Blaikie auto X = std::make_shared<PathDiagnosticEventPiece>(L, os.str());
1699a5958869STed Kremenek X->setTag(getTag());
17000a0c275fSDavid Blaikie return std::move(X);
1701fa0734ecSArgyrios Kyrtzidis }
1702fa0734ecSArgyrios Kyrtzidis
17030dbb783cSCraig Topper return nullptr;
1704fa0734ecSArgyrios Kyrtzidis }
1705fa0734ecSArgyrios Kyrtzidis
17064cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
17074cc6d72bSKristof Umann // Implementation of SuppressInlineDefensiveChecksVisitor.
17084cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
17094cc6d72bSKristof Umann
17108d7c8a4dSAnna Zaks SuppressInlineDefensiveChecksVisitor::
SuppressInlineDefensiveChecksVisitor(DefinedSVal Value,const ExplodedNode * N)17118d7c8a4dSAnna Zaks SuppressInlineDefensiveChecksVisitor(DefinedSVal Value, const ExplodedNode *N)
17129f103a1aSEugene Zelenko : V(Value) {
1713313b101eSAnna Zaks // Check if the visitor is disabled.
17148a0f890eSGeorge Karpenkov AnalyzerOptions &Options = N->getState()->getAnalysisManager().options;
1715549f9cd4SKristof Umann if (!Options.ShouldSuppressInlinedDefensiveChecks)
1716313b101eSAnna Zaks IsSatisfied = true;
17178d7c8a4dSAnna Zaks }
17188d7c8a4dSAnna Zaks
Profile(llvm::FoldingSetNodeID & ID) const17199f103a1aSEugene Zelenko void SuppressInlineDefensiveChecksVisitor::Profile(
17209f103a1aSEugene Zelenko llvm::FoldingSetNodeID &ID) const {
17218d7c8a4dSAnna Zaks static int id = 0;
17228d7c8a4dSAnna Zaks ID.AddPointer(&id);
17238d7c8a4dSAnna Zaks ID.Add(V);
17248d7c8a4dSAnna Zaks }
17258d7c8a4dSAnna Zaks
getTag()17268d7c8a4dSAnna Zaks const char *SuppressInlineDefensiveChecksVisitor::getTag() {
17278d7c8a4dSAnna Zaks return "IDCVisitor";
17288d7c8a4dSAnna Zaks }
17298d7c8a4dSAnna Zaks
17302f169e7cSArtem Dergachev PathDiagnosticPieceRef
VisitNode(const ExplodedNode * Succ,BugReporterContext & BRC,PathSensitiveBugReport & BR)17312f169e7cSArtem Dergachev SuppressInlineDefensiveChecksVisitor::VisitNode(const ExplodedNode *Succ,
17322f169e7cSArtem Dergachev BugReporterContext &BRC,
17332f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
1734c82d457dSGeorge Karpenkov const ExplodedNode *Pred = Succ->getFirstPred();
17358d7c8a4dSAnna Zaks if (IsSatisfied)
17360dbb783cSCraig Topper return nullptr;
17376fe2fc63SAnna Zaks
17382672a4ccSAnna Zaks // Start tracking after we see the first state in which the value is null.
17392672a4ccSAnna Zaks if (!IsTrackingTurnedOn)
17402672a4ccSAnna Zaks if (Succ->getState()->isNull(V).isConstrainedTrue())
17412672a4ccSAnna Zaks IsTrackingTurnedOn = true;
17422672a4ccSAnna Zaks if (!IsTrackingTurnedOn)
17430dbb783cSCraig Topper return nullptr;
17442672a4ccSAnna Zaks
17458d7c8a4dSAnna Zaks // Check if in the previous state it was feasible for this value
17468d7c8a4dSAnna Zaks // to *not* be null.
1747e4da37e8SArtem Dergachev if (!Pred->getState()->isNull(V).isConstrainedTrue() &&
1748e4da37e8SArtem Dergachev Succ->getState()->isNull(V).isConstrainedTrue()) {
17498d7c8a4dSAnna Zaks IsSatisfied = true;
17508d7c8a4dSAnna Zaks
17515497d1a5SAnna Zaks // Check if this is inlined defensive checks.
17525497d1a5SAnna Zaks const LocationContext *CurLC = Succ->getLocationContext();
17538d7c8a4dSAnna Zaks const LocationContext *ReportLC = BR.getErrorNode()->getLocationContext();
175407c451faSDevin Coughlin if (CurLC != ReportLC && !CurLC->isParentOf(ReportLC)) {
17558d7c8a4dSAnna Zaks BR.markInvalid("Suppress IDC", CurLC);
175607c451faSDevin Coughlin return nullptr;
175707c451faSDevin Coughlin }
175807c451faSDevin Coughlin
175907c451faSDevin Coughlin // Treat defensive checks in function-like macros as if they were an inlined
17604be27d4dSDevin Coughlin // defensive check. If the bug location is not in a macro and the
17614be27d4dSDevin Coughlin // terminator for the current location is in a macro then suppress the
17624be27d4dSDevin Coughlin // warning.
176307c451faSDevin Coughlin auto BugPoint = BR.getErrorNode()->getLocation().getAs<StmtPoint>();
176407c451faSDevin Coughlin
17654be27d4dSDevin Coughlin if (!BugPoint)
176607c451faSDevin Coughlin return nullptr;
176707c451faSDevin Coughlin
17684be27d4dSDevin Coughlin ProgramPoint CurPoint = Succ->getLocation();
17694be27d4dSDevin Coughlin const Stmt *CurTerminatorStmt = nullptr;
17704be27d4dSDevin Coughlin if (auto BE = CurPoint.getAs<BlockEdge>()) {
17714be27d4dSDevin Coughlin CurTerminatorStmt = BE->getSrc()->getTerminator().getStmt();
17724be27d4dSDevin Coughlin } else if (auto SP = CurPoint.getAs<StmtPoint>()) {
17734be27d4dSDevin Coughlin const Stmt *CurStmt = SP->getStmt();
1774f2ceec48SStephen Kelly if (!CurStmt->getBeginLoc().isMacroID())
17754be27d4dSDevin Coughlin return nullptr;
17764be27d4dSDevin Coughlin
17774be27d4dSDevin Coughlin CFGStmtMap *Map = CurLC->getAnalysisDeclContext()->getCFGStmtMap();
17784e53032dSArtem Dergachev CurTerminatorStmt = Map->getBlock(CurStmt)->getTerminatorStmt();
17794be27d4dSDevin Coughlin } else {
17804be27d4dSDevin Coughlin return nullptr;
17814be27d4dSDevin Coughlin }
17824be27d4dSDevin Coughlin
17834be27d4dSDevin Coughlin if (!CurTerminatorStmt)
17844be27d4dSDevin Coughlin return nullptr;
17854be27d4dSDevin Coughlin
1786f2ceec48SStephen Kelly SourceLocation TerminatorLoc = CurTerminatorStmt->getBeginLoc();
17874be27d4dSDevin Coughlin if (TerminatorLoc.isMacroID()) {
1788f2ceec48SStephen Kelly SourceLocation BugLoc = BugPoint->getStmt()->getBeginLoc();
178977dfbf21SGeorge Karpenkov
179077dfbf21SGeorge Karpenkov // Suppress reports unless we are in that same macro.
179177dfbf21SGeorge Karpenkov if (!BugLoc.isMacroID() ||
179277dfbf21SGeorge Karpenkov getMacroName(BugLoc, BRC) != getMacroName(TerminatorLoc, BRC)) {
179307c451faSDevin Coughlin BR.markInvalid("Suppress Macro IDC", CurLC);
179477dfbf21SGeorge Karpenkov }
179507c451faSDevin Coughlin return nullptr;
179607c451faSDevin Coughlin }
179707c451faSDevin Coughlin }
17980dbb783cSCraig Topper return nullptr;
17998d7c8a4dSAnna Zaks }
18008d7c8a4dSAnna Zaks
18014cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
1802258e5e45SKristof Umann // TrackControlDependencyCondBRVisitor.
1803258e5e45SKristof Umann //===----------------------------------------------------------------------===//
1804258e5e45SKristof Umann
1805258e5e45SKristof Umann namespace {
1806258e5e45SKristof Umann /// Tracks the expressions that are a control dependency of the node that was
1807258e5e45SKristof Umann /// supplied to the constructor.
1808258e5e45SKristof Umann /// For example:
1809258e5e45SKristof Umann ///
1810258e5e45SKristof Umann /// cond = 1;
1811258e5e45SKristof Umann /// if (cond)
1812258e5e45SKristof Umann /// 10 / 0;
1813258e5e45SKristof Umann ///
1814258e5e45SKristof Umann /// An error is emitted at line 3. This visitor realizes that the branch
1815258e5e45SKristof Umann /// on line 2 is a control dependency of line 3, and tracks it's condition via
1816258e5e45SKristof Umann /// trackExpressionValue().
181751d4704dSValeriy Savchenko class TrackControlDependencyCondBRVisitor final
181851d4704dSValeriy Savchenko : public TrackingBugReporterVisitor {
1819258e5e45SKristof Umann const ExplodedNode *Origin;
1820258e5e45SKristof Umann ControlDependencyCalculator ControlDeps;
1821258e5e45SKristof Umann llvm::SmallSet<const CFGBlock *, 32> VisitedBlocks;
1822258e5e45SKristof Umann
1823258e5e45SKristof Umann public:
TrackControlDependencyCondBRVisitor(TrackerRef ParentTracker,const ExplodedNode * O)182451d4704dSValeriy Savchenko TrackControlDependencyCondBRVisitor(TrackerRef ParentTracker,
182551d4704dSValeriy Savchenko const ExplodedNode *O)
182651d4704dSValeriy Savchenko : TrackingBugReporterVisitor(ParentTracker), Origin(O),
182751d4704dSValeriy Savchenko ControlDeps(&O->getCFG()) {}
1828258e5e45SKristof Umann
Profile(llvm::FoldingSetNodeID & ID) const1829258e5e45SKristof Umann void Profile(llvm::FoldingSetNodeID &ID) const override {
1830258e5e45SKristof Umann static int x = 0;
1831258e5e45SKristof Umann ID.AddPointer(&x);
1832258e5e45SKristof Umann }
1833258e5e45SKristof Umann
18346d716ef1SKristof Umann PathDiagnosticPieceRef VisitNode(const ExplodedNode *N,
1835258e5e45SKristof Umann BugReporterContext &BRC,
18362f169e7cSArtem Dergachev PathSensitiveBugReport &BR) override;
1837258e5e45SKristof Umann };
1838258e5e45SKristof Umann } // end of anonymous namespace
1839258e5e45SKristof Umann
1840b5574560SKristof Umann static std::shared_ptr<PathDiagnosticEventPiece>
constructDebugPieceForTrackedCondition(const Expr * Cond,const ExplodedNode * N,BugReporterContext & BRC)1841b5574560SKristof Umann constructDebugPieceForTrackedCondition(const Expr *Cond,
1842b5574560SKristof Umann const ExplodedNode *N,
1843b5574560SKristof Umann BugReporterContext &BRC) {
1844b5574560SKristof Umann
1845b5574560SKristof Umann if (BRC.getAnalyzerOptions().AnalysisDiagOpt == PD_NONE ||
1846b5574560SKristof Umann !BRC.getAnalyzerOptions().ShouldTrackConditionsDebug)
1847b5574560SKristof Umann return nullptr;
1848b5574560SKristof Umann
1849adcd0268SBenjamin Kramer std::string ConditionText = std::string(Lexer::getSourceText(
1850b5574560SKristof Umann CharSourceRange::getTokenRange(Cond->getSourceRange()),
1851adcd0268SBenjamin Kramer BRC.getSourceManager(), BRC.getASTContext().getLangOpts()));
1852b5574560SKristof Umann
1853b5574560SKristof Umann return std::make_shared<PathDiagnosticEventPiece>(
1854b5574560SKristof Umann PathDiagnosticLocation::createBegin(
1855b5574560SKristof Umann Cond, BRC.getSourceManager(), N->getLocationContext()),
1856b5574560SKristof Umann (Twine() + "Tracking condition '" + ConditionText + "'").str());
1857b5574560SKristof Umann }
1858b5574560SKristof Umann
isAssertlikeBlock(const CFGBlock * B,ASTContext & Context)1859dd53bdbfSKristof Umann static bool isAssertlikeBlock(const CFGBlock *B, ASTContext &Context) {
1860dd53bdbfSKristof Umann if (B->succ_size() != 2)
1861dd53bdbfSKristof Umann return false;
1862dd53bdbfSKristof Umann
1863dd53bdbfSKristof Umann const CFGBlock *Then = B->succ_begin()->getReachableBlock();
1864dd53bdbfSKristof Umann const CFGBlock *Else = (B->succ_begin() + 1)->getReachableBlock();
1865dd53bdbfSKristof Umann
1866dd53bdbfSKristof Umann if (!Then || !Else)
1867dd53bdbfSKristof Umann return false;
1868dd53bdbfSKristof Umann
1869dd53bdbfSKristof Umann if (Then->isInevitablySinking() != Else->isInevitablySinking())
1870dd53bdbfSKristof Umann return true;
1871dd53bdbfSKristof Umann
1872dd53bdbfSKristof Umann // For the following condition the following CFG would be built:
1873dd53bdbfSKristof Umann //
1874dd53bdbfSKristof Umann // ------------->
1875dd53bdbfSKristof Umann // / \
1876dd53bdbfSKristof Umann // [B1] -> [B2] -> [B3] -> [sink]
1877dd53bdbfSKristof Umann // assert(A && B || C); \ \
1878dd53bdbfSKristof Umann // -----------> [go on with the execution]
1879dd53bdbfSKristof Umann //
1880dd53bdbfSKristof Umann // It so happens that CFGBlock::getTerminatorCondition returns 'A' for block
1881dd53bdbfSKristof Umann // B1, 'A && B' for B2, and 'A && B || C' for B3. Let's check whether we
1882dd53bdbfSKristof Umann // reached the end of the condition!
1883dd53bdbfSKristof Umann if (const Stmt *ElseCond = Else->getTerminatorCondition())
1884032e1fdcSKristof Umann if (const auto *BinOp = dyn_cast<BinaryOperator>(ElseCond))
1885032e1fdcSKristof Umann if (BinOp->isLogicalOp())
1886dd53bdbfSKristof Umann return isAssertlikeBlock(Else, Context);
1887dd53bdbfSKristof Umann
1888dd53bdbfSKristof Umann return false;
1889dd53bdbfSKristof Umann }
1890dd53bdbfSKristof Umann
18912f169e7cSArtem Dergachev PathDiagnosticPieceRef
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)18922f169e7cSArtem Dergachev TrackControlDependencyCondBRVisitor::VisitNode(const ExplodedNode *N,
18932f169e7cSArtem Dergachev BugReporterContext &BRC,
18942f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
1895258e5e45SKristof Umann // We can only reason about control dependencies within the same stack frame.
1896258e5e45SKristof Umann if (Origin->getStackFrame() != N->getStackFrame())
1897258e5e45SKristof Umann return nullptr;
1898258e5e45SKristof Umann
1899dd53bdbfSKristof Umann CFGBlock *NB = const_cast<CFGBlock *>(N->getCFGBlock());
1900258e5e45SKristof Umann
1901258e5e45SKristof Umann // Skip if we already inspected this block.
1902258e5e45SKristof Umann if (!VisitedBlocks.insert(NB).second)
1903258e5e45SKristof Umann return nullptr;
1904258e5e45SKristof Umann
1905dd53bdbfSKristof Umann CFGBlock *OriginB = const_cast<CFGBlock *>(Origin->getCFGBlock());
1906258e5e45SKristof Umann
1907258e5e45SKristof Umann // TODO: Cache CFGBlocks for each ExplodedNode.
1908258e5e45SKristof Umann if (!OriginB || !NB)
1909258e5e45SKristof Umann return nullptr;
1910258e5e45SKristof Umann
1911dd53bdbfSKristof Umann if (isAssertlikeBlock(NB, BRC.getASTContext()))
1912dd53bdbfSKristof Umann return nullptr;
1913dd53bdbfSKristof Umann
1914258e5e45SKristof Umann if (ControlDeps.isControlDependent(OriginB, NB)) {
191558eb033aSKristof Umann // We don't really want to explain for range loops. Evidence suggests that
191658eb033aSKristof Umann // the only thing that leads to is the addition of calls to operator!=.
1917b8ac93c7SKristof Umann if (llvm::isa_and_nonnull<CXXForRangeStmt>(NB->getTerminatorStmt()))
191858eb033aSKristof Umann return nullptr;
191958eb033aSKristof Umann
1920258e5e45SKristof Umann if (const Expr *Condition = NB->getLastCondition()) {
1921fd8e5762SKristóf Umann
1922fd8e5762SKristóf Umann // If we can't retrieve a sensible condition, just bail out.
1923fd8e5762SKristóf Umann const Expr *InnerExpr = peelOffOuterExpr(Condition, N);
1924fd8e5762SKristóf Umann if (!InnerExpr)
1925fd8e5762SKristóf Umann return nullptr;
1926fd8e5762SKristóf Umann
1927fd8e5762SKristóf Umann // If the condition was a function call, we likely won't gain much from
1928fd8e5762SKristóf Umann // tracking it either. Evidence suggests that it will mostly trigger in
1929fd8e5762SKristóf Umann // scenarios like this:
1930fd8e5762SKristóf Umann //
1931fd8e5762SKristóf Umann // void f(int *x) {
1932fd8e5762SKristóf Umann // x = nullptr;
1933fd8e5762SKristóf Umann // if (alwaysTrue()) // We don't need a whole lot of explanation
1934fd8e5762SKristóf Umann // // here, the function name is good enough.
1935fd8e5762SKristóf Umann // *x = 5;
1936fd8e5762SKristóf Umann // }
1937fd8e5762SKristóf Umann //
1938fd8e5762SKristóf Umann // Its easy to create a counterexample where this heuristic would make us
1939fd8e5762SKristóf Umann // lose valuable information, but we've never really seen one in practice.
1940fd8e5762SKristóf Umann if (isa<CallExpr>(InnerExpr))
1941fd8e5762SKristóf Umann return nullptr;
1942fd8e5762SKristóf Umann
1943258e5e45SKristof Umann // Keeping track of the already tracked conditions on a visitor level
1944258e5e45SKristof Umann // isn't sufficient, because a new visitor is created for each tracked
1945258e5e45SKristof Umann // expression, hence the BugReport level set.
1946258e5e45SKristof Umann if (BR.addTrackedCondition(N)) {
1947fd8e5762SKristóf Umann getParentTracker().track(InnerExpr, N,
194851d4704dSValeriy Savchenko {bugreporter::TrackingKind::Condition,
194951d4704dSValeriy Savchenko /*EnableNullFPSuppression=*/false});
1950b5574560SKristof Umann return constructDebugPieceForTrackedCondition(Condition, N, BRC);
1951258e5e45SKristof Umann }
1952258e5e45SKristof Umann }
1953258e5e45SKristof Umann }
1954258e5e45SKristof Umann
1955258e5e45SKristof Umann return nullptr;
1956258e5e45SKristof Umann }
1957258e5e45SKristof Umann
1958258e5e45SKristof Umann //===----------------------------------------------------------------------===//
19594cc6d72bSKristof Umann // Implementation of trackExpressionValue.
19604cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
19614cc6d72bSKristof Umann
peelOffOuterExpr(const Expr * Ex,const ExplodedNode * N)1962fd8e5762SKristóf Umann static const Expr *peelOffOuterExpr(const Expr *Ex, const ExplodedNode *N) {
1963fd8e5762SKristóf Umann
1964bd8f60d6SAnna Zaks Ex = Ex->IgnoreParenCasts();
19657c44da27SBill Wendling if (const auto *FE = dyn_cast<FullExpr>(Ex))
19667c44da27SBill Wendling return peelOffOuterExpr(FE->getSubExpr(), N);
19679f103a1aSEugene Zelenko if (const auto *OVE = dyn_cast<OpaqueValueExpr>(Ex))
1968b5d2fe8aSAnna Zaks return peelOffOuterExpr(OVE->getSourceExpr(), N);
19699f103a1aSEugene Zelenko if (const auto *POE = dyn_cast<PseudoObjectExpr>(Ex)) {
19709f103a1aSEugene Zelenko const auto *PropRef = dyn_cast<ObjCPropertyRefExpr>(POE->getSyntacticForm());
1971ebaa56bbSDevin Coughlin if (PropRef && PropRef->isMessagingGetter()) {
1972803ee031SDevin Coughlin const Expr *GetterMessageSend =
1973803ee031SDevin Coughlin POE->getSemanticExpr(POE->getNumSemanticExprs() - 1);
1974719238b7SDevin Coughlin assert(isa<ObjCMessageExpr>(GetterMessageSend->IgnoreParenCasts()));
1975803ee031SDevin Coughlin return peelOffOuterExpr(GetterMessageSend, N);
1976ebaa56bbSDevin Coughlin }
1977ebaa56bbSDevin Coughlin }
1978bd8f60d6SAnna Zaks
1979bd8f60d6SAnna Zaks // Peel off the ternary operator.
19809f103a1aSEugene Zelenko if (const auto *CO = dyn_cast<ConditionalOperator>(Ex)) {
1981f6a24ce4SAlp Toker // Find a node where the branching occurred and find out which branch
1982d3254b44SAnna Zaks // we took (true/false) by looking at the ExplodedGraph.
1983d3254b44SAnna Zaks const ExplodedNode *NI = N;
1984ede0983fSAnna Zaks do {
1985d3254b44SAnna Zaks ProgramPoint ProgPoint = NI->getLocation();
1986d3254b44SAnna Zaks if (Optional<BlockEdge> BE = ProgPoint.getAs<BlockEdge>()) {
1987d3254b44SAnna Zaks const CFGBlock *srcBlk = BE->getSrc();
19884e53032dSArtem Dergachev if (const Stmt *term = srcBlk->getTerminatorStmt()) {
1989d3254b44SAnna Zaks if (term == CO) {
1990d3254b44SAnna Zaks bool TookTrueBranch = (*(srcBlk->succ_begin()) == BE->getDst());
1991d3254b44SAnna Zaks if (TookTrueBranch)
1992b5d2fe8aSAnna Zaks return peelOffOuterExpr(CO->getTrueExpr(), N);
1993d3254b44SAnna Zaks else
1994d3254b44SAnna Zaks return peelOffOuterExpr(CO->getFalseExpr(), N);
1995bd8f60d6SAnna Zaks }
1996d3254b44SAnna Zaks }
1997d3254b44SAnna Zaks }
1998d3254b44SAnna Zaks NI = NI->getFirstPred();
1999d3254b44SAnna Zaks } while (NI);
2000bd8f60d6SAnna Zaks }
200195f9a68bSArtem Dergachev
200295f9a68bSArtem Dergachev if (auto *BO = dyn_cast<BinaryOperator>(Ex))
200395f9a68bSArtem Dergachev if (const Expr *SubEx = peelOffPointerArithmetic(BO))
200495f9a68bSArtem Dergachev return peelOffOuterExpr(SubEx, N);
200595f9a68bSArtem Dergachev
20064b9bb7ceSGeorge Karpenkov if (auto *UO = dyn_cast<UnaryOperator>(Ex)) {
2007b5dd3ccdSGeorge Karpenkov if (UO->getOpcode() == UO_LNot)
2008b5dd3ccdSGeorge Karpenkov return peelOffOuterExpr(UO->getSubExpr(), N);
2009b5dd3ccdSGeorge Karpenkov
201037de8888SArtem Dergachev // FIXME: There's a hack in our Store implementation that always computes
201137de8888SArtem Dergachev // field offsets around null pointers as if they are always equal to 0.
201237de8888SArtem Dergachev // The idea here is to report accesses to fields as null dereferences
201337de8888SArtem Dergachev // even though the pointer value that's being dereferenced is actually
201437de8888SArtem Dergachev // the offset of the field rather than exactly 0.
201537de8888SArtem Dergachev // See the FIXME in StoreManager's getLValueFieldOrIvar() method.
201637de8888SArtem Dergachev // This code interacts heavily with this hack; otherwise the value
201737de8888SArtem Dergachev // would not be null at all for most fields, so we'd be unable to track it.
20184b9bb7ceSGeorge Karpenkov if (UO->getOpcode() == UO_AddrOf && UO->getSubExpr()->isLValue())
20194b9bb7ceSGeorge Karpenkov if (const Expr *DerefEx = bugreporter::getDerefExpr(UO->getSubExpr()))
20204b9bb7ceSGeorge Karpenkov return peelOffOuterExpr(DerefEx, N);
20214b9bb7ceSGeorge Karpenkov }
20224b9bb7ceSGeorge Karpenkov
2023c41f3798SGeorge Karpenkov return Ex;
2024c41f3798SGeorge Karpenkov }
2025c41f3798SGeorge Karpenkov
20264b9bb7ceSGeorge Karpenkov /// Find the ExplodedNode where the lvalue (the value of 'Ex')
20274b9bb7ceSGeorge Karpenkov /// was computed.
findNodeForExpression(const ExplodedNode * N,const Expr * Inner)20284b9bb7ceSGeorge Karpenkov static const ExplodedNode* findNodeForExpression(const ExplodedNode *N,
20294b9bb7ceSGeorge Karpenkov const Expr *Inner) {
20304b9bb7ceSGeorge Karpenkov while (N) {
20316b85f8e9SArtem Dergachev if (N->getStmtForDiagnostics() == Inner)
20324b9bb7ceSGeorge Karpenkov return N;
20334b9bb7ceSGeorge Karpenkov N = N->getFirstPred();
20344b9bb7ceSGeorge Karpenkov }
20354b9bb7ceSGeorge Karpenkov return N;
20364b9bb7ceSGeorge Karpenkov }
20374b9bb7ceSGeorge Karpenkov
20380cc3100bSValeriy Savchenko //===----------------------------------------------------------------------===//
20390cc3100bSValeriy Savchenko // Tracker implementation
20400cc3100bSValeriy Savchenko //===----------------------------------------------------------------------===//
20410cc3100bSValeriy Savchenko
constructNote(StoreInfo SI,BugReporterContext & BRC,StringRef NodeText)204216f7a952SValeriy Savchenko PathDiagnosticPieceRef StoreHandler::constructNote(StoreInfo SI,
204316f7a952SValeriy Savchenko BugReporterContext &BRC,
204416f7a952SValeriy Savchenko StringRef NodeText) {
2045bbebf38bSValeriy Savchenko // Construct a new PathDiagnosticPiece.
2046bbebf38bSValeriy Savchenko ProgramPoint P = SI.StoreSite->getLocation();
2047bbebf38bSValeriy Savchenko PathDiagnosticLocation L;
2048bbebf38bSValeriy Savchenko if (P.getAs<CallEnter>() && SI.SourceOfTheValue)
2049bbebf38bSValeriy Savchenko L = PathDiagnosticLocation(SI.SourceOfTheValue, BRC.getSourceManager(),
2050bbebf38bSValeriy Savchenko P.getLocationContext());
2051bbebf38bSValeriy Savchenko
2052bbebf38bSValeriy Savchenko if (!L.isValid() || !L.asLocation().isValid())
2053bbebf38bSValeriy Savchenko L = PathDiagnosticLocation::create(P, BRC.getSourceManager());
2054bbebf38bSValeriy Savchenko
2055bbebf38bSValeriy Savchenko if (!L.isValid() || !L.asLocation().isValid())
2056bbebf38bSValeriy Savchenko return nullptr;
2057bbebf38bSValeriy Savchenko
205816f7a952SValeriy Savchenko return std::make_shared<PathDiagnosticEventPiece>(L, NodeText);
205916f7a952SValeriy Savchenko }
206016f7a952SValeriy Savchenko
206116f7a952SValeriy Savchenko class DefaultStoreHandler final : public StoreHandler {
206216f7a952SValeriy Savchenko public:
206316f7a952SValeriy Savchenko using StoreHandler::StoreHandler;
206416f7a952SValeriy Savchenko
handle(StoreInfo SI,BugReporterContext & BRC,TrackingOptions Opts)206516f7a952SValeriy Savchenko PathDiagnosticPieceRef handle(StoreInfo SI, BugReporterContext &BRC,
206616f7a952SValeriy Savchenko TrackingOptions Opts) override {
206716f7a952SValeriy Savchenko // Okay, we've found the binding. Emit an appropriate message.
206816f7a952SValeriy Savchenko SmallString<256> Buffer;
206916f7a952SValeriy Savchenko llvm::raw_svector_ostream OS(Buffer);
207016f7a952SValeriy Savchenko
207116f7a952SValeriy Savchenko switch (SI.StoreKind) {
207216f7a952SValeriy Savchenko case StoreInfo::Initialization:
207316f7a952SValeriy Savchenko case StoreInfo::BlockCapture:
207416f7a952SValeriy Savchenko showBRDiagnostics(OS, SI);
207516f7a952SValeriy Savchenko break;
207616f7a952SValeriy Savchenko case StoreInfo::CallArgument:
207716f7a952SValeriy Savchenko showBRParamDiagnostics(OS, SI);
207816f7a952SValeriy Savchenko break;
207916f7a952SValeriy Savchenko case StoreInfo::Assignment:
208016f7a952SValeriy Savchenko showBRDefaultDiagnostics(OS, SI);
208116f7a952SValeriy Savchenko break;
208216f7a952SValeriy Savchenko }
208316f7a952SValeriy Savchenko
208416f7a952SValeriy Savchenko if (Opts.Kind == bugreporter::TrackingKind::Condition)
208516f7a952SValeriy Savchenko OS << WillBeUsedForACondition;
208616f7a952SValeriy Savchenko
208716f7a952SValeriy Savchenko return constructNote(SI, BRC, OS.str());
2088bbebf38bSValeriy Savchenko }
2089bbebf38bSValeriy Savchenko };
2090bbebf38bSValeriy Savchenko
209185f475c9SValeriy Savchenko class ControlDependencyHandler final : public ExpressionHandler {
209285f475c9SValeriy Savchenko public:
209385f475c9SValeriy Savchenko using ExpressionHandler::ExpressionHandler;
209485f475c9SValeriy Savchenko
handle(const Expr * Inner,const ExplodedNode * InputNode,const ExplodedNode * LVNode,TrackingOptions Opts)209585f475c9SValeriy Savchenko Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
209685f475c9SValeriy Savchenko const ExplodedNode *LVNode,
209785f475c9SValeriy Savchenko TrackingOptions Opts) override {
209885f475c9SValeriy Savchenko PathSensitiveBugReport &Report = getParentTracker().getReport();
209985f475c9SValeriy Savchenko
210085f475c9SValeriy Savchenko // We only track expressions if we believe that they are important. Chances
210185f475c9SValeriy Savchenko // are good that control dependencies to the tracking point are also
210285f475c9SValeriy Savchenko // important because of this, let's explain why we believe control reached
210385f475c9SValeriy Savchenko // this point.
210485f475c9SValeriy Savchenko // TODO: Shouldn't we track control dependencies of every bug location,
210585f475c9SValeriy Savchenko // rather than only tracked expressions?
210685f475c9SValeriy Savchenko if (LVNode->getState()
210785f475c9SValeriy Savchenko ->getAnalysisManager()
210885f475c9SValeriy Savchenko .getAnalyzerOptions()
210985f475c9SValeriy Savchenko .ShouldTrackConditions) {
211085f475c9SValeriy Savchenko Report.addVisitor<TrackControlDependencyCondBRVisitor>(
211185f475c9SValeriy Savchenko &getParentTracker(), InputNode);
211285f475c9SValeriy Savchenko return {/*FoundSomethingToTrack=*/true};
211385f475c9SValeriy Savchenko }
211485f475c9SValeriy Savchenko
211585f475c9SValeriy Savchenko return {};
211685f475c9SValeriy Savchenko }
211785f475c9SValeriy Savchenko };
211885f475c9SValeriy Savchenko
21191639dcb2SValeriy Savchenko class NilReceiverHandler final : public ExpressionHandler {
21201639dcb2SValeriy Savchenko public:
21211639dcb2SValeriy Savchenko using ExpressionHandler::ExpressionHandler;
21221639dcb2SValeriy Savchenko
handle(const Expr * Inner,const ExplodedNode * InputNode,const ExplodedNode * LVNode,TrackingOptions Opts)21231639dcb2SValeriy Savchenko Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
21241639dcb2SValeriy Savchenko const ExplodedNode *LVNode,
21251639dcb2SValeriy Savchenko TrackingOptions Opts) override {
21261639dcb2SValeriy Savchenko // The message send could be nil due to the receiver being nil.
21271639dcb2SValeriy Savchenko // At this point in the path, the receiver should be live since we are at
21281639dcb2SValeriy Savchenko // the message send expr. If it is nil, start tracking it.
21291639dcb2SValeriy Savchenko if (const Expr *Receiver =
21301639dcb2SValeriy Savchenko NilReceiverBRVisitor::getNilReceiver(Inner, LVNode))
21311639dcb2SValeriy Savchenko return getParentTracker().track(Receiver, LVNode, Opts);
21321639dcb2SValeriy Savchenko
21331639dcb2SValeriy Savchenko return {};
21341639dcb2SValeriy Savchenko }
21351639dcb2SValeriy Savchenko };
21361639dcb2SValeriy Savchenko
213740cb73bdSValeriy Savchenko class ArrayIndexHandler final : public ExpressionHandler {
213840cb73bdSValeriy Savchenko public:
213940cb73bdSValeriy Savchenko using ExpressionHandler::ExpressionHandler;
214040cb73bdSValeriy Savchenko
handle(const Expr * Inner,const ExplodedNode * InputNode,const ExplodedNode * LVNode,TrackingOptions Opts)214140cb73bdSValeriy Savchenko Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
214240cb73bdSValeriy Savchenko const ExplodedNode *LVNode,
214340cb73bdSValeriy Savchenko TrackingOptions Opts) override {
214440cb73bdSValeriy Savchenko // Track the index if this is an array subscript.
214540cb73bdSValeriy Savchenko if (const auto *Arr = dyn_cast<ArraySubscriptExpr>(Inner))
214640cb73bdSValeriy Savchenko return getParentTracker().track(
214740cb73bdSValeriy Savchenko Arr->getIdx(), LVNode,
214840cb73bdSValeriy Savchenko {Opts.Kind, /*EnableNullFPSuppression*/ false});
214940cb73bdSValeriy Savchenko
215040cb73bdSValeriy Savchenko return {};
215140cb73bdSValeriy Savchenko }
215240cb73bdSValeriy Savchenko };
215340cb73bdSValeriy Savchenko
21542e490676SValeriy Savchenko // TODO: extract it into more handlers
21552e490676SValeriy Savchenko class InterestingLValueHandler final : public ExpressionHandler {
2156967c06b3SValeriy Savchenko public:
2157967c06b3SValeriy Savchenko using ExpressionHandler::ExpressionHandler;
2158967c06b3SValeriy Savchenko
handle(const Expr * Inner,const ExplodedNode * InputNode,const ExplodedNode * LVNode,TrackingOptions Opts)2159967c06b3SValeriy Savchenko Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
2160967c06b3SValeriy Savchenko const ExplodedNode *LVNode,
2161967c06b3SValeriy Savchenko TrackingOptions Opts) override {
2162967c06b3SValeriy Savchenko ProgramStateRef LVState = LVNode->getState();
2163967c06b3SValeriy Savchenko const StackFrameContext *SFC = LVNode->getStackFrame();
2164967c06b3SValeriy Savchenko PathSensitiveBugReport &Report = getParentTracker().getReport();
2165967c06b3SValeriy Savchenko Tracker::Result Result;
2166967c06b3SValeriy Savchenko
2167967c06b3SValeriy Savchenko // See if the expression we're interested refers to a variable.
2168967c06b3SValeriy Savchenko // If so, we can track both its contents and constraints on its value.
2169967c06b3SValeriy Savchenko if (ExplodedGraph::isInterestingLValueExpr(Inner)) {
2170967c06b3SValeriy Savchenko SVal LVal = LVNode->getSVal(Inner);
2171967c06b3SValeriy Savchenko
2172967c06b3SValeriy Savchenko const MemRegion *RR = getLocationRegionIfReference(Inner, LVNode);
2173967c06b3SValeriy Savchenko bool LVIsNull = LVState->isNull(LVal).isConstrainedTrue();
2174967c06b3SValeriy Savchenko
2175967c06b3SValeriy Savchenko // If this is a C++ reference to a null pointer, we are tracking the
2176967c06b3SValeriy Savchenko // pointer. In addition, we should find the store at which the reference
2177967c06b3SValeriy Savchenko // got initialized.
2178967c06b3SValeriy Savchenko if (RR && !LVIsNull)
2179967c06b3SValeriy Savchenko Result.combineWith(getParentTracker().track(LVal, RR, Opts, SFC));
2180967c06b3SValeriy Savchenko
2181967c06b3SValeriy Savchenko // In case of C++ references, we want to differentiate between a null
2182967c06b3SValeriy Savchenko // reference and reference to null pointer.
2183967c06b3SValeriy Savchenko // If the LVal is null, check if we are dealing with null reference.
2184967c06b3SValeriy Savchenko // For those, we want to track the location of the reference.
2185967c06b3SValeriy Savchenko const MemRegion *R =
2186967c06b3SValeriy Savchenko (RR && LVIsNull) ? RR : LVNode->getSVal(Inner).getAsRegion();
2187967c06b3SValeriy Savchenko
2188967c06b3SValeriy Savchenko if (R) {
2189967c06b3SValeriy Savchenko
2190967c06b3SValeriy Savchenko // Mark both the variable region and its contents as interesting.
2191967c06b3SValeriy Savchenko SVal V = LVState->getRawSVal(loc::MemRegionVal(R));
2192967c06b3SValeriy Savchenko Report.addVisitor<NoStoreFuncVisitor>(cast<SubRegion>(R), Opts.Kind);
2193967c06b3SValeriy Savchenko
2194967c06b3SValeriy Savchenko // When we got here, we do have something to track, and we will
2195967c06b3SValeriy Savchenko // interrupt.
2196967c06b3SValeriy Savchenko Result.FoundSomethingToTrack = true;
2197967c06b3SValeriy Savchenko Result.WasInterrupted = true;
2198967c06b3SValeriy Savchenko
2199967c06b3SValeriy Savchenko MacroNullReturnSuppressionVisitor::addMacroVisitorIfNecessary(
2200967c06b3SValeriy Savchenko LVNode, R, Opts.EnableNullFPSuppression, Report, V);
2201967c06b3SValeriy Savchenko
2202967c06b3SValeriy Savchenko Report.markInteresting(V, Opts.Kind);
2203967c06b3SValeriy Savchenko Report.addVisitor<UndefOrNullArgVisitor>(R);
2204967c06b3SValeriy Savchenko
2205967c06b3SValeriy Savchenko // If the contents are symbolic and null, find out when they became
2206967c06b3SValeriy Savchenko // null.
2207967c06b3SValeriy Savchenko if (V.getAsLocSymbol(/*IncludeBaseRegions=*/true))
2208967c06b3SValeriy Savchenko if (LVState->isNull(V).isConstrainedTrue())
2209967c06b3SValeriy Savchenko Report.addVisitor<TrackConstraintBRVisitor>(V.castAs<DefinedSVal>(),
2210967c06b3SValeriy Savchenko false);
2211967c06b3SValeriy Savchenko
2212967c06b3SValeriy Savchenko // Add visitor, which will suppress inline defensive checks.
2213967c06b3SValeriy Savchenko if (auto DV = V.getAs<DefinedSVal>())
2214967c06b3SValeriy Savchenko if (!DV->isZeroConstant() && Opts.EnableNullFPSuppression)
2215967c06b3SValeriy Savchenko // Note that LVNode may be too late (i.e., too far from the
2216967c06b3SValeriy Savchenko // InputNode) because the lvalue may have been computed before the
2217967c06b3SValeriy Savchenko // inlined call was evaluated. InputNode may as well be too early
2218967c06b3SValeriy Savchenko // here, because the symbol is already dead; this, however, is fine
2219967c06b3SValeriy Savchenko // because we can still find the node in which it collapsed to null
2220967c06b3SValeriy Savchenko // previously.
2221967c06b3SValeriy Savchenko Report.addVisitor<SuppressInlineDefensiveChecksVisitor>(*DV,
2222967c06b3SValeriy Savchenko InputNode);
2223967c06b3SValeriy Savchenko getParentTracker().track(V, R, Opts, SFC);
22242e490676SValeriy Savchenko }
22252e490676SValeriy Savchenko }
2226967c06b3SValeriy Savchenko
2227967c06b3SValeriy Savchenko return Result;
2228967c06b3SValeriy Savchenko }
22292e490676SValeriy Savchenko };
22302e490676SValeriy Savchenko
22316e6a26b8SValeriy Savchenko /// Adds a ReturnVisitor if the given statement represents a call that was
22326e6a26b8SValeriy Savchenko /// inlined.
22336e6a26b8SValeriy Savchenko ///
22346e6a26b8SValeriy Savchenko /// This will search back through the ExplodedGraph, starting from the given
22356e6a26b8SValeriy Savchenko /// node, looking for when the given statement was processed. If it turns out
22366e6a26b8SValeriy Savchenko /// the statement is a call that was inlined, we add the visitor to the
22376e6a26b8SValeriy Savchenko /// bug report, so it can print a note later.
22386e6a26b8SValeriy Savchenko class InlinedFunctionCallHandler final : public ExpressionHandler {
22396e6a26b8SValeriy Savchenko using ExpressionHandler::ExpressionHandler;
22406e6a26b8SValeriy Savchenko
handle(const Expr * E,const ExplodedNode * InputNode,const ExplodedNode * ExprNode,TrackingOptions Opts)22416e6a26b8SValeriy Savchenko Tracker::Result handle(const Expr *E, const ExplodedNode *InputNode,
22426e6a26b8SValeriy Savchenko const ExplodedNode *ExprNode,
22436e6a26b8SValeriy Savchenko TrackingOptions Opts) override {
22446e6a26b8SValeriy Savchenko if (!CallEvent::isCallStmt(E))
22456e6a26b8SValeriy Savchenko return {};
22466e6a26b8SValeriy Savchenko
22476e6a26b8SValeriy Savchenko // First, find when we processed the statement.
22486e6a26b8SValeriy Savchenko // If we work with a 'CXXNewExpr' that is going to be purged away before
22496e6a26b8SValeriy Savchenko // its call take place. We would catch that purge in the last condition
22506e6a26b8SValeriy Savchenko // as a 'StmtPoint' so we have to bypass it.
22516e6a26b8SValeriy Savchenko const bool BypassCXXNewExprEval = isa<CXXNewExpr>(E);
22526e6a26b8SValeriy Savchenko
22536e6a26b8SValeriy Savchenko // This is moving forward when we enter into another context.
22546e6a26b8SValeriy Savchenko const StackFrameContext *CurrentSFC = ExprNode->getStackFrame();
22556e6a26b8SValeriy Savchenko
22566e6a26b8SValeriy Savchenko do {
22576e6a26b8SValeriy Savchenko // If that is satisfied we found our statement as an inlined call.
22586e6a26b8SValeriy Savchenko if (Optional<CallExitEnd> CEE = ExprNode->getLocationAs<CallExitEnd>())
22596e6a26b8SValeriy Savchenko if (CEE->getCalleeContext()->getCallSite() == E)
22606e6a26b8SValeriy Savchenko break;
22616e6a26b8SValeriy Savchenko
22626e6a26b8SValeriy Savchenko // Try to move forward to the end of the call-chain.
22636e6a26b8SValeriy Savchenko ExprNode = ExprNode->getFirstPred();
22646e6a26b8SValeriy Savchenko if (!ExprNode)
22656e6a26b8SValeriy Savchenko break;
22666e6a26b8SValeriy Savchenko
22676e6a26b8SValeriy Savchenko const StackFrameContext *PredSFC = ExprNode->getStackFrame();
22686e6a26b8SValeriy Savchenko
22696e6a26b8SValeriy Savchenko // If that is satisfied we found our statement.
22706e6a26b8SValeriy Savchenko // FIXME: This code currently bypasses the call site for the
22716e6a26b8SValeriy Savchenko // conservatively evaluated allocator.
22726e6a26b8SValeriy Savchenko if (!BypassCXXNewExprEval)
22736e6a26b8SValeriy Savchenko if (Optional<StmtPoint> SP = ExprNode->getLocationAs<StmtPoint>())
22746e6a26b8SValeriy Savchenko // See if we do not enter into another context.
22756e6a26b8SValeriy Savchenko if (SP->getStmt() == E && CurrentSFC == PredSFC)
22766e6a26b8SValeriy Savchenko break;
22776e6a26b8SValeriy Savchenko
22786e6a26b8SValeriy Savchenko CurrentSFC = PredSFC;
22796e6a26b8SValeriy Savchenko } while (ExprNode->getStackFrame() == CurrentSFC);
22806e6a26b8SValeriy Savchenko
22816e6a26b8SValeriy Savchenko // Next, step over any post-statement checks.
22826e6a26b8SValeriy Savchenko while (ExprNode && ExprNode->getLocation().getAs<PostStmt>())
22836e6a26b8SValeriy Savchenko ExprNode = ExprNode->getFirstPred();
22846e6a26b8SValeriy Savchenko if (!ExprNode)
22856e6a26b8SValeriy Savchenko return {};
22866e6a26b8SValeriy Savchenko
22876e6a26b8SValeriy Savchenko // Finally, see if we inlined the call.
22886e6a26b8SValeriy Savchenko Optional<CallExitEnd> CEE = ExprNode->getLocationAs<CallExitEnd>();
22896e6a26b8SValeriy Savchenko if (!CEE)
22906e6a26b8SValeriy Savchenko return {};
22916e6a26b8SValeriy Savchenko
22926e6a26b8SValeriy Savchenko const StackFrameContext *CalleeContext = CEE->getCalleeContext();
22936e6a26b8SValeriy Savchenko if (CalleeContext->getCallSite() != E)
22946e6a26b8SValeriy Savchenko return {};
22956e6a26b8SValeriy Savchenko
22966e6a26b8SValeriy Savchenko // Check the return value.
22976e6a26b8SValeriy Savchenko ProgramStateRef State = ExprNode->getState();
22986e6a26b8SValeriy Savchenko SVal RetVal = ExprNode->getSVal(E);
22996e6a26b8SValeriy Savchenko
23006e6a26b8SValeriy Savchenko // Handle cases where a reference is returned and then immediately used.
23016e6a26b8SValeriy Savchenko if (cast<Expr>(E)->isGLValue())
23026e6a26b8SValeriy Savchenko if (Optional<Loc> LValue = RetVal.getAs<Loc>())
23036e6a26b8SValeriy Savchenko RetVal = State->getSVal(*LValue);
23046e6a26b8SValeriy Savchenko
23056e6a26b8SValeriy Savchenko // See if the return value is NULL. If so, suppress the report.
23066e6a26b8SValeriy Savchenko AnalyzerOptions &Options = State->getAnalysisManager().options;
23076e6a26b8SValeriy Savchenko
23086e6a26b8SValeriy Savchenko bool EnableNullFPSuppression = false;
23096e6a26b8SValeriy Savchenko if (Opts.EnableNullFPSuppression && Options.ShouldSuppressNullReturnPaths)
23106e6a26b8SValeriy Savchenko if (Optional<Loc> RetLoc = RetVal.getAs<Loc>())
23116e6a26b8SValeriy Savchenko EnableNullFPSuppression = State->isNull(*RetLoc).isConstrainedTrue();
23126e6a26b8SValeriy Savchenko
23136e6a26b8SValeriy Savchenko PathSensitiveBugReport &Report = getParentTracker().getReport();
23146e6a26b8SValeriy Savchenko Report.addVisitor<ReturnVisitor>(&getParentTracker(), CalleeContext,
23156e6a26b8SValeriy Savchenko EnableNullFPSuppression, Options,
23166e6a26b8SValeriy Savchenko Opts.Kind);
23176e6a26b8SValeriy Savchenko return {true};
23186e6a26b8SValeriy Savchenko }
23196e6a26b8SValeriy Savchenko };
23206e6a26b8SValeriy Savchenko
23212e490676SValeriy Savchenko class DefaultExpressionHandler final : public ExpressionHandler {
23222e490676SValeriy Savchenko public:
23232e490676SValeriy Savchenko using ExpressionHandler::ExpressionHandler;
23242e490676SValeriy Savchenko
handle(const Expr * Inner,const ExplodedNode * InputNode,const ExplodedNode * LVNode,TrackingOptions Opts)23252e490676SValeriy Savchenko Tracker::Result handle(const Expr *Inner, const ExplodedNode *InputNode,
23262e490676SValeriy Savchenko const ExplodedNode *LVNode,
23272e490676SValeriy Savchenko TrackingOptions Opts) override {
23282e490676SValeriy Savchenko ProgramStateRef LVState = LVNode->getState();
23292e490676SValeriy Savchenko const StackFrameContext *SFC = LVNode->getStackFrame();
23302e490676SValeriy Savchenko PathSensitiveBugReport &Report = getParentTracker().getReport();
23312e490676SValeriy Savchenko Tracker::Result Result;
2332967c06b3SValeriy Savchenko
2333967c06b3SValeriy Savchenko // If the expression is not an "lvalue expression", we can still
2334967c06b3SValeriy Savchenko // track the constraints on its contents.
2335967c06b3SValeriy Savchenko SVal V = LVState->getSValAsScalarOrLoc(Inner, LVNode->getLocationContext());
2336967c06b3SValeriy Savchenko
2337967c06b3SValeriy Savchenko // Is it a symbolic value?
2338967c06b3SValeriy Savchenko if (auto L = V.getAs<loc::MemRegionVal>()) {
2339967c06b3SValeriy Savchenko // FIXME: this is a hack for fixing a later crash when attempting to
2340967c06b3SValeriy Savchenko // dereference a void* pointer.
2341967c06b3SValeriy Savchenko // We should not try to dereference pointers at all when we don't care
2342967c06b3SValeriy Savchenko // what is written inside the pointer.
2343967c06b3SValeriy Savchenko bool CanDereference = true;
2344967c06b3SValeriy Savchenko if (const auto *SR = L->getRegionAs<SymbolicRegion>()) {
2345967c06b3SValeriy Savchenko if (SR->getSymbol()->getType()->getPointeeType()->isVoidType())
2346967c06b3SValeriy Savchenko CanDereference = false;
2347967c06b3SValeriy Savchenko } else if (L->getRegionAs<AllocaRegion>())
2348967c06b3SValeriy Savchenko CanDereference = false;
2349967c06b3SValeriy Savchenko
2350967c06b3SValeriy Savchenko // At this point we are dealing with the region's LValue.
2351967c06b3SValeriy Savchenko // However, if the rvalue is a symbolic region, we should track it as
2352967c06b3SValeriy Savchenko // well. Try to use the correct type when looking up the value.
2353967c06b3SValeriy Savchenko SVal RVal;
2354967c06b3SValeriy Savchenko if (ExplodedGraph::isInterestingLValueExpr(Inner))
2355ca4af13eSKazu Hirata RVal = LVState->getRawSVal(*L, Inner->getType());
2356967c06b3SValeriy Savchenko else if (CanDereference)
2357967c06b3SValeriy Savchenko RVal = LVState->getSVal(L->getRegion());
2358967c06b3SValeriy Savchenko
2359967c06b3SValeriy Savchenko if (CanDereference) {
2360967c06b3SValeriy Savchenko Report.addVisitor<UndefOrNullArgVisitor>(L->getRegion());
2361967c06b3SValeriy Savchenko Result.FoundSomethingToTrack = true;
2362967c06b3SValeriy Savchenko
2363967c06b3SValeriy Savchenko if (auto KV = RVal.getAs<KnownSVal>())
2364967c06b3SValeriy Savchenko Result.combineWith(
2365967c06b3SValeriy Savchenko getParentTracker().track(*KV, L->getRegion(), Opts, SFC));
2366967c06b3SValeriy Savchenko }
2367967c06b3SValeriy Savchenko
2368967c06b3SValeriy Savchenko const MemRegion *RegionRVal = RVal.getAsRegion();
2369967c06b3SValeriy Savchenko if (isa_and_nonnull<SymbolicRegion>(RegionRVal)) {
2370967c06b3SValeriy Savchenko Report.markInteresting(RegionRVal, Opts.Kind);
2371967c06b3SValeriy Savchenko Report.addVisitor<TrackConstraintBRVisitor>(
2372967c06b3SValeriy Savchenko loc::MemRegionVal(RegionRVal),
2373967c06b3SValeriy Savchenko /*assumption=*/false);
2374967c06b3SValeriy Savchenko Result.FoundSomethingToTrack = true;
2375967c06b3SValeriy Savchenko }
2376967c06b3SValeriy Savchenko }
2377967c06b3SValeriy Savchenko
2378967c06b3SValeriy Savchenko return Result;
2379967c06b3SValeriy Savchenko }
2380967c06b3SValeriy Savchenko };
2381967c06b3SValeriy Savchenko
23823fc8d943SValeriy Savchenko /// Attempts to add visitors to track an RValue expression back to its point of
23833fc8d943SValeriy Savchenko /// origin.
23843fc8d943SValeriy Savchenko class PRValueHandler final : public ExpressionHandler {
23853fc8d943SValeriy Savchenko public:
23863fc8d943SValeriy Savchenko using ExpressionHandler::ExpressionHandler;
23873fc8d943SValeriy Savchenko
handle(const Expr * E,const ExplodedNode * InputNode,const ExplodedNode * ExprNode,TrackingOptions Opts)23883fc8d943SValeriy Savchenko Tracker::Result handle(const Expr *E, const ExplodedNode *InputNode,
23893fc8d943SValeriy Savchenko const ExplodedNode *ExprNode,
23903fc8d943SValeriy Savchenko TrackingOptions Opts) override {
23913fc8d943SValeriy Savchenko if (!E->isPRValue())
23923fc8d943SValeriy Savchenko return {};
23933fc8d943SValeriy Savchenko
23943fc8d943SValeriy Savchenko const ExplodedNode *RVNode = findNodeForExpression(ExprNode, E);
23953fc8d943SValeriy Savchenko if (!RVNode)
23963fc8d943SValeriy Savchenko return {};
23973fc8d943SValeriy Savchenko
23983fc8d943SValeriy Savchenko ProgramStateRef RVState = RVNode->getState();
23993fc8d943SValeriy Savchenko SVal V = RVState->getSValAsScalarOrLoc(E, RVNode->getLocationContext());
24003fc8d943SValeriy Savchenko const auto *BO = dyn_cast<BinaryOperator>(E);
24013fc8d943SValeriy Savchenko
24023fc8d943SValeriy Savchenko if (!BO || !BO->isMultiplicativeOp() || !V.isZeroConstant())
24033fc8d943SValeriy Savchenko return {};
24043fc8d943SValeriy Savchenko
24053fc8d943SValeriy Savchenko SVal RHSV = RVState->getSVal(BO->getRHS(), RVNode->getLocationContext());
24063fc8d943SValeriy Savchenko SVal LHSV = RVState->getSVal(BO->getLHS(), RVNode->getLocationContext());
24073fc8d943SValeriy Savchenko
24083fc8d943SValeriy Savchenko // Track both LHS and RHS of a multiplication.
24093fc8d943SValeriy Savchenko Tracker::Result CombinedResult;
24103fc8d943SValeriy Savchenko Tracker &Parent = getParentTracker();
24113fc8d943SValeriy Savchenko
24123fc8d943SValeriy Savchenko const auto track = [&CombinedResult, &Parent, ExprNode, Opts](Expr *Inner) {
24133fc8d943SValeriy Savchenko CombinedResult.combineWith(Parent.track(Inner, ExprNode, Opts));
24143fc8d943SValeriy Savchenko };
24153fc8d943SValeriy Savchenko
24163fc8d943SValeriy Savchenko if (BO->getOpcode() == BO_Mul) {
24173fc8d943SValeriy Savchenko if (LHSV.isZeroConstant())
24183fc8d943SValeriy Savchenko track(BO->getLHS());
24193fc8d943SValeriy Savchenko if (RHSV.isZeroConstant())
24203fc8d943SValeriy Savchenko track(BO->getRHS());
24213fc8d943SValeriy Savchenko } else { // Track only the LHS of a division or a modulo.
24223fc8d943SValeriy Savchenko if (LHSV.isZeroConstant())
24233fc8d943SValeriy Savchenko track(BO->getLHS());
24243fc8d943SValeriy Savchenko }
24253fc8d943SValeriy Savchenko
24263fc8d943SValeriy Savchenko return CombinedResult;
24273fc8d943SValeriy Savchenko }
24283fc8d943SValeriy Savchenko };
24293fc8d943SValeriy Savchenko
Tracker(PathSensitiveBugReport & Report)24300cc3100bSValeriy Savchenko Tracker::Tracker(PathSensitiveBugReport &Report) : Report(Report) {
2431bbebf38bSValeriy Savchenko // Default expression handlers.
243285f475c9SValeriy Savchenko addLowPriorityHandler<ControlDependencyHandler>();
24331639dcb2SValeriy Savchenko addLowPriorityHandler<NilReceiverHandler>();
243440cb73bdSValeriy Savchenko addLowPriorityHandler<ArrayIndexHandler>();
24352e490676SValeriy Savchenko addLowPriorityHandler<InterestingLValueHandler>();
24366e6a26b8SValeriy Savchenko addLowPriorityHandler<InlinedFunctionCallHandler>();
243785f475c9SValeriy Savchenko addLowPriorityHandler<DefaultExpressionHandler>();
24383fc8d943SValeriy Savchenko addLowPriorityHandler<PRValueHandler>();
2439bbebf38bSValeriy Savchenko // Default store handlers.
2440bbebf38bSValeriy Savchenko addHighPriorityHandler<DefaultStoreHandler>();
24410cc3100bSValeriy Savchenko }
24420cc3100bSValeriy Savchenko
track(const Expr * E,const ExplodedNode * N,TrackingOptions Opts)24430cc3100bSValeriy Savchenko Tracker::Result Tracker::track(const Expr *E, const ExplodedNode *N,
24440cc3100bSValeriy Savchenko TrackingOptions Opts) {
24450cc3100bSValeriy Savchenko if (!E || !N)
24460cc3100bSValeriy Savchenko return {};
24470cc3100bSValeriy Savchenko
24480cc3100bSValeriy Savchenko const Expr *Inner = peelOffOuterExpr(E, N);
24490cc3100bSValeriy Savchenko const ExplodedNode *LVNode = findNodeForExpression(N, Inner);
24500cc3100bSValeriy Savchenko if (!LVNode)
24510cc3100bSValeriy Savchenko return {};
24520cc3100bSValeriy Savchenko
24530cc3100bSValeriy Savchenko Result CombinedResult;
24540cc3100bSValeriy Savchenko // Iterate through the handlers in the order according to their priorities.
24550cc3100bSValeriy Savchenko for (ExpressionHandlerPtr &Handler : ExpressionHandlers) {
24560cc3100bSValeriy Savchenko CombinedResult.combineWith(Handler->handle(Inner, N, LVNode, Opts));
245740cb73bdSValeriy Savchenko if (CombinedResult.WasInterrupted) {
245840cb73bdSValeriy Savchenko // There is no need to confuse our users here.
245940cb73bdSValeriy Savchenko // We got interrupted, but our users don't need to know about it.
246040cb73bdSValeriy Savchenko CombinedResult.WasInterrupted = false;
24610cc3100bSValeriy Savchenko break;
24620cc3100bSValeriy Savchenko }
246340cb73bdSValeriy Savchenko }
24640cc3100bSValeriy Savchenko
24650cc3100bSValeriy Savchenko return CombinedResult;
24660cc3100bSValeriy Savchenko }
24670cc3100bSValeriy Savchenko
track(SVal V,const MemRegion * R,TrackingOptions Opts,const StackFrameContext * Origin)24680cc3100bSValeriy Savchenko Tracker::Result Tracker::track(SVal V, const MemRegion *R, TrackingOptions Opts,
24690cc3100bSValeriy Savchenko const StackFrameContext *Origin) {
2470967c06b3SValeriy Savchenko if (auto KV = V.getAs<KnownSVal>()) {
2471bbebf38bSValeriy Savchenko Report.addVisitor<StoreSiteFinder>(this, *KV, R, Opts, Origin);
2472967c06b3SValeriy Savchenko return {true};
2473967c06b3SValeriy Savchenko }
24740cc3100bSValeriy Savchenko return {};
24750cc3100bSValeriy Savchenko }
24760cc3100bSValeriy Savchenko
handle(StoreInfo SI,BugReporterContext & BRC,TrackingOptions Opts)2477bbebf38bSValeriy Savchenko PathDiagnosticPieceRef Tracker::handle(StoreInfo SI, BugReporterContext &BRC,
2478bbebf38bSValeriy Savchenko TrackingOptions Opts) {
24790cc3100bSValeriy Savchenko // Iterate through the handlers in the order according to their priorities.
24800cc3100bSValeriy Savchenko for (StoreHandlerPtr &Handler : StoreHandlers) {
2481bbebf38bSValeriy Savchenko if (PathDiagnosticPieceRef Result = Handler->handle(SI, BRC, Opts))
24820cc3100bSValeriy Savchenko // If the handler produced a non-null piece, return it.
24830cc3100bSValeriy Savchenko // There is no need in asking other handlers.
24840cc3100bSValeriy Savchenko return Result;
24850cc3100bSValeriy Savchenko }
24860cc3100bSValeriy Savchenko return {};
24870cc3100bSValeriy Savchenko }
24880cc3100bSValeriy Savchenko
trackExpressionValue(const ExplodedNode * InputNode,const Expr * E,PathSensitiveBugReport & Report,TrackingOptions Opts)2489b2cf0063SGeorge Karpenkov bool bugreporter::trackExpressionValue(const ExplodedNode *InputNode,
24902f169e7cSArtem Dergachev const Expr *E,
249157006d2fSValeriy Savchenko
249257006d2fSValeriy Savchenko PathSensitiveBugReport &Report,
249357006d2fSValeriy Savchenko TrackingOptions Opts) {
249457006d2fSValeriy Savchenko return Tracker::create(Report)
249557006d2fSValeriy Savchenko ->track(E, InputNode, Opts)
2496967c06b3SValeriy Savchenko .FoundSomethingToTrack;
2497f86615caSAnna Zaks }
2498fa0734ecSArgyrios Kyrtzidis
trackStoredValue(KnownSVal V,const MemRegion * R,PathSensitiveBugReport & Report,TrackingOptions Opts,const StackFrameContext * Origin)2499b6bcf953SValeriy Savchenko void bugreporter::trackStoredValue(KnownSVal V, const MemRegion *R,
2500b6bcf953SValeriy Savchenko PathSensitiveBugReport &Report,
2501b6bcf953SValeriy Savchenko TrackingOptions Opts,
2502b6bcf953SValeriy Savchenko const StackFrameContext *Origin) {
2503b6bcf953SValeriy Savchenko Tracker::create(Report)->track(V, R, Opts, Origin);
2504b6bcf953SValeriy Savchenko }
2505b6bcf953SValeriy Savchenko
25064cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
25074cc6d72bSKristof Umann // Implementation of NulReceiverBRVisitor.
25084cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
25094cc6d72bSKristof Umann
getNilReceiver(const Stmt * S,const ExplodedNode * N)25108e492c23SAnna Zaks const Expr *NilReceiverBRVisitor::getNilReceiver(const Stmt *S,
25118e492c23SAnna Zaks const ExplodedNode *N) {
25129f103a1aSEugene Zelenko const auto *ME = dyn_cast<ObjCMessageExpr>(S);
251305fb371eSAnna Zaks if (!ME)
25140dbb783cSCraig Topper return nullptr;
25158e492c23SAnna Zaks if (const Expr *Receiver = ME->getInstanceReceiver()) {
25168e492c23SAnna Zaks ProgramStateRef state = N->getState();
2517d703ec94SGeorge Karpenkov SVal V = N->getSVal(Receiver);
25188e492c23SAnna Zaks if (state->isNull(V).isConstrainedTrue())
25198e492c23SAnna Zaks return Receiver;
25208e492c23SAnna Zaks }
25210dbb783cSCraig Topper return nullptr;
2522fa0734ecSArgyrios Kyrtzidis }
2523fa0734ecSArgyrios Kyrtzidis
25242f169e7cSArtem Dergachev PathDiagnosticPieceRef
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)25252f169e7cSArtem Dergachev NilReceiverBRVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
25262f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
252722fa6eccSAnna Zaks Optional<PreStmt> P = N->getLocationAs<PreStmt>();
2528fa0734ecSArgyrios Kyrtzidis if (!P)
25290dbb783cSCraig Topper return nullptr;
253005fb371eSAnna Zaks
2531d51ad8c1STed Kremenek const Stmt *S = P->getStmt();
2532d51ad8c1STed Kremenek const Expr *Receiver = getNilReceiver(S, N);
2533fa0734ecSArgyrios Kyrtzidis if (!Receiver)
25340dbb783cSCraig Topper return nullptr;
2535ee47a5bdSJordan Rose
2536d51ad8c1STed Kremenek llvm::SmallString<256> Buf;
2537d51ad8c1STed Kremenek llvm::raw_svector_ostream OS(Buf);
2538d51ad8c1STed Kremenek
25399f103a1aSEugene Zelenko if (const auto *ME = dyn_cast<ObjCMessageExpr>(S)) {
2540b190f974SAaron Ballman OS << "'";
2541b190f974SAaron Ballman ME->getSelector().print(OS);
2542b190f974SAaron Ballman OS << "' not called";
2543d51ad8c1STed Kremenek }
2544d51ad8c1STed Kremenek else {
2545d51ad8c1STed Kremenek OS << "No method is called";
2546d51ad8c1STed Kremenek }
2547d51ad8c1STed Kremenek OS << " because the receiver is nil";
2548d51ad8c1STed Kremenek
2549fa0734ecSArgyrios Kyrtzidis // The receiver was nil, and hence the method was skipped.
2550fa0734ecSArgyrios Kyrtzidis // Register a BugReporterVisitor to issue a message telling us how
2551fa0734ecSArgyrios Kyrtzidis // the receiver was null.
255257006d2fSValeriy Savchenko bugreporter::trackExpressionValue(N, Receiver, BR,
255357006d2fSValeriy Savchenko {bugreporter::TrackingKind::Thorough,
255457006d2fSValeriy Savchenko /*EnableNullFPSuppression*/ false});
2555fa0734ecSArgyrios Kyrtzidis // Issue a message saying that the method was skipped.
25563a769bd9SAnna Zaks PathDiagnosticLocation L(Receiver, BRC.getSourceManager(),
25573a769bd9SAnna Zaks N->getLocationContext());
25580a0c275fSDavid Blaikie return std::make_shared<PathDiagnosticEventPiece>(L, OS.str());
2559fa0734ecSArgyrios Kyrtzidis }
2560fa0734ecSArgyrios Kyrtzidis
25614cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
256254d45675STed Kremenek // Visitor that tries to report interesting diagnostics from conditions.
256354d45675STed Kremenek //===----------------------------------------------------------------------===//
2564a5958869STed Kremenek
2565a5958869STed Kremenek /// Return the tag associated with this visitor. This tag will be used
2566a5958869STed Kremenek /// to make all PathDiagnosticPieces created by this visitor.
getTag()25676d716ef1SKristof Umann const char *ConditionBRVisitor::getTag() { return "ConditionBRVisitor"; }
2568a5958869STed Kremenek
25692f169e7cSArtem Dergachev PathDiagnosticPieceRef
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)25702f169e7cSArtem Dergachev ConditionBRVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
25712f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
2572c82d457dSGeorge Karpenkov auto piece = VisitNodeImpl(N, BRC, BR);
2573a5958869STed Kremenek if (piece) {
2574a5958869STed Kremenek piece->setTag(getTag());
25750a0c275fSDavid Blaikie if (auto *ev = dyn_cast<PathDiagnosticEventPiece>(piece.get()))
25761e809b4cSTed Kremenek ev->setPrunable(true, /* override */ false);
2577a5958869STed Kremenek }
25782429c6ffSTed Kremenek return piece;
25792429c6ffSTed Kremenek }
25802429c6ffSTed Kremenek
25816d716ef1SKristof Umann PathDiagnosticPieceRef
VisitNodeImpl(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)25820a0c275fSDavid Blaikie ConditionBRVisitor::VisitNodeImpl(const ExplodedNode *N,
25832f169e7cSArtem Dergachev BugReporterContext &BRC,
25842f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
25854b0184b2SCsaba Dabis ProgramPoint ProgPoint = N->getLocation();
25864b0184b2SCsaba Dabis const std::pair<const ProgramPointTag *, const ProgramPointTag *> &Tags =
25874b0184b2SCsaba Dabis ExprEngine::geteagerlyAssumeBinOpBifurcationTags();
2588667417efSTed Kremenek
258954d45675STed Kremenek // If an assumption was made on a branch, it should be caught
259054d45675STed Kremenek // here by looking at the state transition.
25914b0184b2SCsaba Dabis if (Optional<BlockEdge> BE = ProgPoint.getAs<BlockEdge>()) {
25924b0184b2SCsaba Dabis const CFGBlock *SrcBlock = BE->getSrc();
25934b0184b2SCsaba Dabis if (const Stmt *Term = SrcBlock->getTerminatorStmt()) {
25944b0184b2SCsaba Dabis // If the tag of the previous node is 'Eagerly Assume...' the current
25954b0184b2SCsaba Dabis // 'BlockEdge' has the same constraint information. We do not want to
25964b0184b2SCsaba Dabis // report the value as it is just an assumption on the predecessor node
25974b0184b2SCsaba Dabis // which will be caught in the next VisitNode() iteration as a 'PostStmt'.
25984b0184b2SCsaba Dabis const ProgramPointTag *PreviousNodeTag =
25994b0184b2SCsaba Dabis N->getFirstPred()->getLocation().getTag();
26004b0184b2SCsaba Dabis if (PreviousNodeTag == Tags.first || PreviousNodeTag == Tags.second)
26014b0184b2SCsaba Dabis return nullptr;
26024b0184b2SCsaba Dabis
26034b0184b2SCsaba Dabis return VisitTerminator(Term, N, SrcBlock, BE->getDst(), BR, BRC);
26044b0184b2SCsaba Dabis }
26050dbb783cSCraig Topper return nullptr;
260654d45675STed Kremenek }
260754d45675STed Kremenek
26084b0184b2SCsaba Dabis if (Optional<PostStmt> PS = ProgPoint.getAs<PostStmt>()) {
26094b0184b2SCsaba Dabis const ProgramPointTag *CurrentNodeTag = PS->getTag();
26104b0184b2SCsaba Dabis if (CurrentNodeTag != Tags.first && CurrentNodeTag != Tags.second)
26110dbb783cSCraig Topper return nullptr;
26124b0184b2SCsaba Dabis
26134b0184b2SCsaba Dabis bool TookTrue = CurrentNodeTag == Tags.first;
26144b0184b2SCsaba Dabis return VisitTrueTest(cast<Expr>(PS->getStmt()), BRC, BR, N, TookTrue);
261554d45675STed Kremenek }
261654d45675STed Kremenek
26170dbb783cSCraig Topper return nullptr;
261854d45675STed Kremenek }
261954d45675STed Kremenek
VisitTerminator(const Stmt * Term,const ExplodedNode * N,const CFGBlock * srcBlk,const CFGBlock * dstBlk,PathSensitiveBugReport & R,BugReporterContext & BRC)26206d716ef1SKristof Umann PathDiagnosticPieceRef ConditionBRVisitor::VisitTerminator(
26210a0c275fSDavid Blaikie const Stmt *Term, const ExplodedNode *N, const CFGBlock *srcBlk,
26222f169e7cSArtem Dergachev const CFGBlock *dstBlk, PathSensitiveBugReport &R,
26232f169e7cSArtem Dergachev BugReporterContext &BRC) {
26240dbb783cSCraig Topper const Expr *Cond = nullptr;
262554d45675STed Kremenek
26269cb5614cSArtem Dergachev // In the code below, Term is a CFG terminator and Cond is a branch condition
26279cb5614cSArtem Dergachev // expression upon which the decision is made on this terminator.
26289cb5614cSArtem Dergachev //
26299cb5614cSArtem Dergachev // For example, in "if (x == 0)", the "if (x == 0)" statement is a terminator,
26309cb5614cSArtem Dergachev // and "x == 0" is the respective condition.
26319cb5614cSArtem Dergachev //
26329cb5614cSArtem Dergachev // Another example: in "if (x && y)", we've got two terminators and two
26339cb5614cSArtem Dergachev // conditions due to short-circuit nature of operator "&&":
26349cb5614cSArtem Dergachev // 1. The "if (x && y)" statement is a terminator,
26359cb5614cSArtem Dergachev // and "y" is the respective condition.
26369cb5614cSArtem Dergachev // 2. Also "x && ..." is another terminator,
26379cb5614cSArtem Dergachev // and "x" is its condition.
26389cb5614cSArtem Dergachev
263954d45675STed Kremenek switch (Term->getStmtClass()) {
26409cb5614cSArtem Dergachev // FIXME: Stmt::SwitchStmtClass is worth handling, however it is a bit
26419cb5614cSArtem Dergachev // more tricky because there are more than two branches to account for.
264254d45675STed Kremenek default:
26430dbb783cSCraig Topper return nullptr;
264454d45675STed Kremenek case Stmt::IfStmtClass:
264554d45675STed Kremenek Cond = cast<IfStmt>(Term)->getCond();
264654d45675STed Kremenek break;
264754d45675STed Kremenek case Stmt::ConditionalOperatorClass:
264854d45675STed Kremenek Cond = cast<ConditionalOperator>(Term)->getCond();
264954d45675STed Kremenek break;
26509cb5614cSArtem Dergachev case Stmt::BinaryOperatorClass:
26519cb5614cSArtem Dergachev // When we encounter a logical operator (&& or ||) as a CFG terminator,
26522c51880aSSimon Pilgrim // then the condition is actually its LHS; otherwise, we'd encounter
26539cb5614cSArtem Dergachev // the parent, such as if-statement, as a terminator.
26549cb5614cSArtem Dergachev const auto *BO = cast<BinaryOperator>(Term);
26559cb5614cSArtem Dergachev assert(BO->isLogicalOp() &&
26569cb5614cSArtem Dergachev "CFG terminator is not a short-circuit operator!");
26579cb5614cSArtem Dergachev Cond = BO->getLHS();
26589cb5614cSArtem Dergachev break;
26599cb5614cSArtem Dergachev }
26609cb5614cSArtem Dergachev
2661cf0b4e32SCsaba Dabis Cond = Cond->IgnoreParens();
2662cf0b4e32SCsaba Dabis
26639cb5614cSArtem Dergachev // However, when we encounter a logical operator as a branch condition,
26649cb5614cSArtem Dergachev // then the condition is actually its RHS, because LHS would be
26659cb5614cSArtem Dergachev // the condition for the logical operator terminator.
26669cb5614cSArtem Dergachev while (const auto *InnerBO = dyn_cast<BinaryOperator>(Cond)) {
26679cb5614cSArtem Dergachev if (!InnerBO->isLogicalOp())
26689cb5614cSArtem Dergachev break;
26699cb5614cSArtem Dergachev Cond = InnerBO->getRHS()->IgnoreParens();
267054d45675STed Kremenek }
267154d45675STed Kremenek
267254d45675STed Kremenek assert(Cond);
267354d45675STed Kremenek assert(srcBlk->succ_size() == 2);
26744b0184b2SCsaba Dabis const bool TookTrue = *(srcBlk->succ_begin()) == dstBlk;
26754b0184b2SCsaba Dabis return VisitTrueTest(Cond, BRC, R, N, TookTrue);
267654d45675STed Kremenek }
267754d45675STed Kremenek
26786d716ef1SKristof Umann PathDiagnosticPieceRef
VisitTrueTest(const Expr * Cond,BugReporterContext & BRC,PathSensitiveBugReport & R,const ExplodedNode * N,bool TookTrue)26794b0184b2SCsaba Dabis ConditionBRVisitor::VisitTrueTest(const Expr *Cond, BugReporterContext &BRC,
26802f169e7cSArtem Dergachev PathSensitiveBugReport &R,
26812f169e7cSArtem Dergachev const ExplodedNode *N, bool TookTrue) {
26829ea2f907SCsaba Dabis ProgramStateRef CurrentState = N->getState();
26834b0184b2SCsaba Dabis ProgramStateRef PrevState = N->getFirstPred()->getState();
26849ea2f907SCsaba Dabis const LocationContext *LCtx = N->getLocationContext();
26859ea2f907SCsaba Dabis
26869ea2f907SCsaba Dabis // If the constraint information is changed between the current and the
26879ea2f907SCsaba Dabis // previous program state we assuming the newly seen constraint information.
26889ea2f907SCsaba Dabis // If we cannot evaluate the condition (and the constraints are the same)
26899ea2f907SCsaba Dabis // the analyzer has no information about the value and just assuming it.
26904b0184b2SCsaba Dabis bool IsAssuming =
26914b0184b2SCsaba Dabis !BRC.getStateManager().haveEqualConstraints(CurrentState, PrevState) ||
26924b0184b2SCsaba Dabis CurrentState->getSVal(Cond, LCtx).isUnknownOrUndef();
26939ea2f907SCsaba Dabis
26940c33406aSArtem Dergachev // These will be modified in code below, but we need to preserve the original
26950c33406aSArtem Dergachev // values in case we want to throw the generic message.
26960c33406aSArtem Dergachev const Expr *CondTmp = Cond;
26974b0184b2SCsaba Dabis bool TookTrueTmp = TookTrue;
269854d45675STed Kremenek
2699667417efSTed Kremenek while (true) {
27000c33406aSArtem Dergachev CondTmp = CondTmp->IgnoreParenCasts();
27010c33406aSArtem Dergachev switch (CondTmp->getStmtClass()) {
270254d45675STed Kremenek default:
27030c33406aSArtem Dergachev break;
2704667417efSTed Kremenek case Stmt::BinaryOperatorClass:
27050a0c275fSDavid Blaikie if (auto P = VisitTrueTest(Cond, cast<BinaryOperator>(CondTmp),
27064b0184b2SCsaba Dabis BRC, R, N, TookTrueTmp, IsAssuming))
27070c33406aSArtem Dergachev return P;
27080c33406aSArtem Dergachev break;
270954d45675STed Kremenek case Stmt::DeclRefExprClass:
27100a0c275fSDavid Blaikie if (auto P = VisitTrueTest(Cond, cast<DeclRefExpr>(CondTmp),
27114b0184b2SCsaba Dabis BRC, R, N, TookTrueTmp, IsAssuming))
27120c33406aSArtem Dergachev return P;
27130c33406aSArtem Dergachev break;
2714d1f0ec3fSCsaba Dabis case Stmt::MemberExprClass:
2715d1f0ec3fSCsaba Dabis if (auto P = VisitTrueTest(Cond, cast<MemberExpr>(CondTmp),
2716d1f0ec3fSCsaba Dabis BRC, R, N, TookTrueTmp, IsAssuming))
2717d1f0ec3fSCsaba Dabis return P;
2718d1f0ec3fSCsaba Dabis break;
271954d45675STed Kremenek case Stmt::UnaryOperatorClass: {
27209f103a1aSEugene Zelenko const auto *UO = cast<UnaryOperator>(CondTmp);
272154d45675STed Kremenek if (UO->getOpcode() == UO_LNot) {
27224b0184b2SCsaba Dabis TookTrueTmp = !TookTrueTmp;
27230c33406aSArtem Dergachev CondTmp = UO->getSubExpr();
272454d45675STed Kremenek continue;
272554d45675STed Kremenek }
27260c33406aSArtem Dergachev break;
27270c33406aSArtem Dergachev }
27280c33406aSArtem Dergachev }
27290c33406aSArtem Dergachev break;
27300c33406aSArtem Dergachev }
27310c33406aSArtem Dergachev
27320c33406aSArtem Dergachev // Condition too complex to explain? Just say something so that the user
27330c33406aSArtem Dergachev // knew we've made some path decision at this point.
27344b0184b2SCsaba Dabis // If it is too complex and we know the evaluation of the condition do not
27354b0184b2SCsaba Dabis // repeat the note from 'BugReporter.cpp'
27364b0184b2SCsaba Dabis if (!IsAssuming)
27374b0184b2SCsaba Dabis return nullptr;
27384b0184b2SCsaba Dabis
27390c33406aSArtem Dergachev PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
27400c33406aSArtem Dergachev if (!Loc.isValid() || !Loc.asLocation().isValid())
27410dbb783cSCraig Topper return nullptr;
27420c33406aSArtem Dergachev
27430a0c275fSDavid Blaikie return std::make_shared<PathDiagnosticEventPiece>(
27444b0184b2SCsaba Dabis Loc, TookTrue ? GenericTrueMessage : GenericFalseMessage);
2745667417efSTed Kremenek }
2746667417efSTed Kremenek
patternMatch(const Expr * Ex,const Expr * ParentEx,raw_ostream & Out,BugReporterContext & BRC,PathSensitiveBugReport & report,const ExplodedNode * N,Optional<bool> & prunable,bool IsSameFieldName)274740c74c6dSAnna Zaks bool ConditionBRVisitor::patternMatch(const Expr *Ex,
274840c74c6dSAnna Zaks const Expr *ParentEx,
274940c74c6dSAnna Zaks raw_ostream &Out,
27501e809b4cSTed Kremenek BugReporterContext &BRC,
27512f169e7cSArtem Dergachev PathSensitiveBugReport &report,
27521e809b4cSTed Kremenek const ExplodedNode *N,
2753d1f0ec3fSCsaba Dabis Optional<bool> &prunable,
2754d1f0ec3fSCsaba Dabis bool IsSameFieldName) {
2755667417efSTed Kremenek const Expr *OriginalExpr = Ex;
2756667417efSTed Kremenek Ex = Ex->IgnoreParenCasts();
2757667417efSTed Kremenek
275816be17adSBalazs Benics if (isa<GNUNullExpr, ObjCBoolLiteralExpr, CXXBoolLiteralExpr, IntegerLiteral,
275916be17adSBalazs Benics FloatingLiteral>(Ex)) {
2760a746f2b7SArtem Dergachev // Use heuristics to determine if the expression is a macro
2761a746f2b7SArtem Dergachev // expanding to a literal and if so, use the macro's name.
2762a746f2b7SArtem Dergachev SourceLocation BeginLoc = OriginalExpr->getBeginLoc();
2763a746f2b7SArtem Dergachev SourceLocation EndLoc = OriginalExpr->getEndLoc();
2764a746f2b7SArtem Dergachev if (BeginLoc.isMacroID() && EndLoc.isMacroID()) {
2765fc76d855SKristof Umann const SourceManager &SM = BRC.getSourceManager();
2766a746f2b7SArtem Dergachev const LangOptions &LO = BRC.getASTContext().getLangOpts();
2767a746f2b7SArtem Dergachev if (Lexer::isAtStartOfMacroExpansion(BeginLoc, SM, LO) &&
2768a746f2b7SArtem Dergachev Lexer::isAtEndOfMacroExpansion(EndLoc, SM, LO)) {
2769a746f2b7SArtem Dergachev CharSourceRange R = Lexer::getAsCharRange({BeginLoc, EndLoc}, SM, LO);
2770a746f2b7SArtem Dergachev Out << Lexer::getSourceText(R, SM, LO);
277140c74c6dSAnna Zaks return false;
277240c74c6dSAnna Zaks }
277340c74c6dSAnna Zaks }
2774a746f2b7SArtem Dergachev }
277540c74c6dSAnna Zaks
27769f103a1aSEugene Zelenko if (const auto *DR = dyn_cast<DeclRefExpr>(Ex)) {
277731fdb616STed Kremenek const bool quotes = isa<VarDecl>(DR->getDecl());
27781e809b4cSTed Kremenek if (quotes) {
277931fdb616STed Kremenek Out << '\'';
27801e809b4cSTed Kremenek const LocationContext *LCtx = N->getLocationContext();
2781f994cef8SAlp Toker const ProgramState *state = N->getState().get();
27821e809b4cSTed Kremenek if (const MemRegion *R = state->getLValue(cast<VarDecl>(DR->getDecl()),
27831e809b4cSTed Kremenek LCtx).getAsRegion()) {
27841e809b4cSTed Kremenek if (report.isInteresting(R))
27851e809b4cSTed Kremenek prunable = false;
27861e809b4cSTed Kremenek else {
2787f994cef8SAlp Toker const ProgramState *state = N->getState().get();
27881e809b4cSTed Kremenek SVal V = state->getSVal(R);
27891e809b4cSTed Kremenek if (report.isInteresting(V))
27901e809b4cSTed Kremenek prunable = false;
27911e809b4cSTed Kremenek }
27921e809b4cSTed Kremenek }
27931e809b4cSTed Kremenek }
279431fdb616STed Kremenek Out << DR->getDecl()->getDeclName().getAsString();
279531fdb616STed Kremenek if (quotes)
279631fdb616STed Kremenek Out << '\'';
279731fdb616STed Kremenek return quotes;
2798667417efSTed Kremenek }
2799667417efSTed Kremenek
28009f103a1aSEugene Zelenko if (const auto *IL = dyn_cast<IntegerLiteral>(Ex)) {
2801667417efSTed Kremenek QualType OriginalTy = OriginalExpr->getType();
2802667417efSTed Kremenek if (OriginalTy->isPointerType()) {
2803667417efSTed Kremenek if (IL->getValue() == 0) {
2804667417efSTed Kremenek Out << "null";
280531fdb616STed Kremenek return false;
2806667417efSTed Kremenek }
2807667417efSTed Kremenek }
2808667417efSTed Kremenek else if (OriginalTy->isObjCObjectPointerType()) {
2809667417efSTed Kremenek if (IL->getValue() == 0) {
2810667417efSTed Kremenek Out << "nil";
281131fdb616STed Kremenek return false;
2812667417efSTed Kremenek }
2813667417efSTed Kremenek }
2814667417efSTed Kremenek
2815667417efSTed Kremenek Out << IL->getValue();
281631fdb616STed Kremenek return false;
2817667417efSTed Kremenek }
281831fdb616STed Kremenek
2819d1f0ec3fSCsaba Dabis if (const auto *ME = dyn_cast<MemberExpr>(Ex)) {
2820d1f0ec3fSCsaba Dabis if (!IsSameFieldName)
2821d1f0ec3fSCsaba Dabis Out << "field '" << ME->getMemberDecl()->getName() << '\'';
2822d1f0ec3fSCsaba Dabis else
2823d1f0ec3fSCsaba Dabis Out << '\''
2824d1f0ec3fSCsaba Dabis << Lexer::getSourceText(
2825d1f0ec3fSCsaba Dabis CharSourceRange::getTokenRange(Ex->getSourceRange()),
2826298367eeSKazu Hirata BRC.getSourceManager(), BRC.getASTContext().getLangOpts(),
2827298367eeSKazu Hirata nullptr)
2828d1f0ec3fSCsaba Dabis << '\'';
2829d1f0ec3fSCsaba Dabis }
2830d1f0ec3fSCsaba Dabis
283131fdb616STed Kremenek return false;
2832667417efSTed Kremenek }
2833667417efSTed Kremenek
VisitTrueTest(const Expr * Cond,const BinaryOperator * BExpr,BugReporterContext & BRC,PathSensitiveBugReport & R,const ExplodedNode * N,bool TookTrue,bool IsAssuming)28346d716ef1SKristof Umann PathDiagnosticPieceRef ConditionBRVisitor::VisitTrueTest(
28354b0184b2SCsaba Dabis const Expr *Cond, const BinaryOperator *BExpr, BugReporterContext &BRC,
28362f169e7cSArtem Dergachev PathSensitiveBugReport &R, const ExplodedNode *N, bool TookTrue,
28372f169e7cSArtem Dergachev bool IsAssuming) {
283831fdb616STed Kremenek bool shouldInvert = false;
283905785d16SDavid Blaikie Optional<bool> shouldPrune;
284031fdb616STed Kremenek
2841d1f0ec3fSCsaba Dabis // Check if the field name of the MemberExprs is ambiguous. Example:
2842d1f0ec3fSCsaba Dabis // " 'a.d' is equal to 'h.d' " in 'test/Analysis/null-deref-path-notes.cpp'.
2843d1f0ec3fSCsaba Dabis bool IsSameFieldName = false;
2844124ef7fcSCsaba Dabis const auto *LhsME = dyn_cast<MemberExpr>(BExpr->getLHS()->IgnoreParenCasts());
2845124ef7fcSCsaba Dabis const auto *RhsME = dyn_cast<MemberExpr>(BExpr->getRHS()->IgnoreParenCasts());
2846124ef7fcSCsaba Dabis
2847124ef7fcSCsaba Dabis if (LhsME && RhsME)
2848124ef7fcSCsaba Dabis IsSameFieldName =
2849124ef7fcSCsaba Dabis LhsME->getMemberDecl()->getName() == RhsME->getMemberDecl()->getName();
2850d1f0ec3fSCsaba Dabis
28512c1dd271SDylan Noblesmith SmallString<128> LhsString, RhsString;
2852667417efSTed Kremenek {
2853667417efSTed Kremenek llvm::raw_svector_ostream OutLHS(LhsString), OutRHS(RhsString);
2854d1f0ec3fSCsaba Dabis const bool isVarLHS = patternMatch(BExpr->getLHS(), BExpr, OutLHS, BRC, R,
2855d1f0ec3fSCsaba Dabis N, shouldPrune, IsSameFieldName);
2856d1f0ec3fSCsaba Dabis const bool isVarRHS = patternMatch(BExpr->getRHS(), BExpr, OutRHS, BRC, R,
2857d1f0ec3fSCsaba Dabis N, shouldPrune, IsSameFieldName);
285831fdb616STed Kremenek
285931fdb616STed Kremenek shouldInvert = !isVarLHS && isVarRHS;
2860667417efSTed Kremenek }
2861667417efSTed Kremenek
28625799cdddSTed Kremenek BinaryOperator::Opcode Op = BExpr->getOpcode();
28635799cdddSTed Kremenek
28645799cdddSTed Kremenek if (BinaryOperator::isAssignmentOp(Op)) {
28655799cdddSTed Kremenek // For assignment operators, all that we care about is that the LHS
28665799cdddSTed Kremenek // evaluates to "true" or "false".
28674b0184b2SCsaba Dabis return VisitConditionVariable(LhsString, BExpr->getLHS(), BRC, R, N,
28684b0184b2SCsaba Dabis TookTrue);
28695799cdddSTed Kremenek }
28705799cdddSTed Kremenek
28715799cdddSTed Kremenek // For non-assignment operations, we require that we can understand
28725799cdddSTed Kremenek // both the LHS and RHS.
2873e692cfa3SJordan Rose if (LhsString.empty() || RhsString.empty() ||
2874c70f1d63SRichard Smith !BinaryOperator::isComparisonOp(Op) || Op == BO_Cmp)
28750dbb783cSCraig Topper return nullptr;
2876667417efSTed Kremenek
287731fdb616STed Kremenek // Should we invert the strings if the LHS is not a variable name?
28782c1dd271SDylan Noblesmith SmallString<256> buf;
2879667417efSTed Kremenek llvm::raw_svector_ostream Out(buf);
28804b0184b2SCsaba Dabis Out << (IsAssuming ? "Assuming " : "")
28814b0184b2SCsaba Dabis << (shouldInvert ? RhsString : LhsString) << " is ";
2882667417efSTed Kremenek
2883667417efSTed Kremenek // Do we need to invert the opcode?
288431fdb616STed Kremenek if (shouldInvert)
288531fdb616STed Kremenek switch (Op) {
288631fdb616STed Kremenek default: break;
288731fdb616STed Kremenek case BO_LT: Op = BO_GT; break;
288831fdb616STed Kremenek case BO_GT: Op = BO_LT; break;
288931fdb616STed Kremenek case BO_LE: Op = BO_GE; break;
289031fdb616STed Kremenek case BO_GE: Op = BO_LE; break;
289131fdb616STed Kremenek }
289231fdb616STed Kremenek
28934b0184b2SCsaba Dabis if (!TookTrue)
2894667417efSTed Kremenek switch (Op) {
2895667417efSTed Kremenek case BO_EQ: Op = BO_NE; break;
2896667417efSTed Kremenek case BO_NE: Op = BO_EQ; break;
2897667417efSTed Kremenek case BO_LT: Op = BO_GE; break;
2898667417efSTed Kremenek case BO_GT: Op = BO_LE; break;
2899667417efSTed Kremenek case BO_LE: Op = BO_GT; break;
290001401a54STed Kremenek case BO_GE: Op = BO_LT; break;
2901667417efSTed Kremenek default:
29020dbb783cSCraig Topper return nullptr;
2903667417efSTed Kremenek }
2904667417efSTed Kremenek
2905a1745c24STed Kremenek switch (Op) {
2906667417efSTed Kremenek case BO_EQ:
2907667417efSTed Kremenek Out << "equal to ";
2908667417efSTed Kremenek break;
2909667417efSTed Kremenek case BO_NE:
2910667417efSTed Kremenek Out << "not equal to ";
2911667417efSTed Kremenek break;
2912667417efSTed Kremenek default:
2913667417efSTed Kremenek Out << BinaryOperator::getOpcodeStr(Op) << ' ';
2914667417efSTed Kremenek break;
2915667417efSTed Kremenek }
2916667417efSTed Kremenek
291731fdb616STed Kremenek Out << (shouldInvert ? LhsString : RhsString);
29181e809b4cSTed Kremenek const LocationContext *LCtx = N->getLocationContext();
2919124ef7fcSCsaba Dabis const SourceManager &SM = BRC.getSourceManager();
29204b0184b2SCsaba Dabis
2921d9a81ccfSKristof Umann if (isVarAnInterestingCondition(BExpr->getLHS(), N, &R) ||
2922d9a81ccfSKristof Umann isVarAnInterestingCondition(BExpr->getRHS(), N, &R))
2923d9a81ccfSKristof Umann Out << WillBeUsedForACondition;
2924d9a81ccfSKristof Umann
2925d1f0ec3fSCsaba Dabis // Convert 'field ...' to 'Field ...' if it is a MemberExpr.
2926adcd0268SBenjamin Kramer std::string Message = std::string(Out.str());
2927d1f0ec3fSCsaba Dabis Message[0] = toupper(Message[0]);
2928d1f0ec3fSCsaba Dabis
2929124ef7fcSCsaba Dabis // If we know the value create a pop-up note to the value part of 'BExpr'.
2930124ef7fcSCsaba Dabis if (!IsAssuming) {
2931124ef7fcSCsaba Dabis PathDiagnosticLocation Loc;
2932124ef7fcSCsaba Dabis if (!shouldInvert) {
2933124ef7fcSCsaba Dabis if (LhsME && LhsME->getMemberLoc().isValid())
2934124ef7fcSCsaba Dabis Loc = PathDiagnosticLocation(LhsME->getMemberLoc(), SM);
2935124ef7fcSCsaba Dabis else
2936124ef7fcSCsaba Dabis Loc = PathDiagnosticLocation(BExpr->getLHS(), SM, LCtx);
2937124ef7fcSCsaba Dabis } else {
2938124ef7fcSCsaba Dabis if (RhsME && RhsME->getMemberLoc().isValid())
2939124ef7fcSCsaba Dabis Loc = PathDiagnosticLocation(RhsME->getMemberLoc(), SM);
2940124ef7fcSCsaba Dabis else
2941124ef7fcSCsaba Dabis Loc = PathDiagnosticLocation(BExpr->getRHS(), SM, LCtx);
2942124ef7fcSCsaba Dabis }
29434b0184b2SCsaba Dabis
2944124ef7fcSCsaba Dabis return std::make_shared<PathDiagnosticPopUpPiece>(Loc, Message);
2945124ef7fcSCsaba Dabis }
2946124ef7fcSCsaba Dabis
2947124ef7fcSCsaba Dabis PathDiagnosticLocation Loc(Cond, SM, LCtx);
2948d1f0ec3fSCsaba Dabis auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Message);
294997afce08SKazu Hirata if (shouldPrune)
2950cb2c8f69SKazu Hirata event->setPrunable(shouldPrune.value());
29511e809b4cSTed Kremenek return event;
2952667417efSTed Kremenek }
295354d45675STed Kremenek
VisitConditionVariable(StringRef LhsString,const Expr * CondVarExpr,BugReporterContext & BRC,PathSensitiveBugReport & report,const ExplodedNode * N,bool TookTrue)29546d716ef1SKristof Umann PathDiagnosticPieceRef ConditionBRVisitor::VisitConditionVariable(
29554b0184b2SCsaba Dabis StringRef LhsString, const Expr *CondVarExpr, BugReporterContext &BRC,
29562f169e7cSArtem Dergachev PathSensitiveBugReport &report, const ExplodedNode *N, bool TookTrue) {
29573eb3cd45SJordan Rose // FIXME: If there's already a constraint tracker for this variable,
29583eb3cd45SJordan Rose // we shouldn't emit anything here (c.f. the double note in
29593eb3cd45SJordan Rose // test/Analysis/inlining/path-notes.c)
29602c1dd271SDylan Noblesmith SmallString<256> buf;
29615799cdddSTed Kremenek llvm::raw_svector_ostream Out(buf);
29625799cdddSTed Kremenek Out << "Assuming " << LhsString << " is ";
29635799cdddSTed Kremenek
29649942a996SCsaba Dabis if (!printValue(CondVarExpr, Out, N, TookTrue, /*IsAssuming=*/true))
29650dbb783cSCraig Topper return nullptr;
29665799cdddSTed Kremenek
29671e809b4cSTed Kremenek const LocationContext *LCtx = N->getLocationContext();
29681e809b4cSTed Kremenek PathDiagnosticLocation Loc(CondVarExpr, BRC.getSourceManager(), LCtx);
296949ac7eceSKristof Umann
2970d9a81ccfSKristof Umann if (isVarAnInterestingCondition(CondVarExpr, N, &report))
2971d9a81ccfSKristof Umann Out << WillBeUsedForACondition;
2972d9a81ccfSKristof Umann
29730a0c275fSDavid Blaikie auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Out.str());
29741e809b4cSTed Kremenek
297549ac7eceSKristof Umann if (isInterestingExpr(CondVarExpr, N, &report))
29761e809b4cSTed Kremenek event->setPrunable(false);
29771e809b4cSTed Kremenek
29781e809b4cSTed Kremenek return event;
29795799cdddSTed Kremenek }
29805799cdddSTed Kremenek
VisitTrueTest(const Expr * Cond,const DeclRefExpr * DRE,BugReporterContext & BRC,PathSensitiveBugReport & report,const ExplodedNode * N,bool TookTrue,bool IsAssuming)29816d716ef1SKristof Umann PathDiagnosticPieceRef ConditionBRVisitor::VisitTrueTest(
29824b0184b2SCsaba Dabis const Expr *Cond, const DeclRefExpr *DRE, BugReporterContext &BRC,
29832f169e7cSArtem Dergachev PathSensitiveBugReport &report, const ExplodedNode *N, bool TookTrue,
29842f169e7cSArtem Dergachev bool IsAssuming) {
29854b0184b2SCsaba Dabis const auto *VD = dyn_cast<VarDecl>(DRE->getDecl());
298654d45675STed Kremenek if (!VD)
29870dbb783cSCraig Topper return nullptr;
298854d45675STed Kremenek
29892c1dd271SDylan Noblesmith SmallString<256> Buf;
299054d45675STed Kremenek llvm::raw_svector_ostream Out(Buf);
299154d45675STed Kremenek
29924b0184b2SCsaba Dabis Out << (IsAssuming ? "Assuming '" : "'") << VD->getDeclName() << "' is ";
299354d45675STed Kremenek
29949942a996SCsaba Dabis if (!printValue(DRE, Out, N, TookTrue, IsAssuming))
29950dbb783cSCraig Topper return nullptr;
299654d45675STed Kremenek
29971e809b4cSTed Kremenek const LocationContext *LCtx = N->getLocationContext();
29981e809b4cSTed Kremenek
2999d9a81ccfSKristof Umann if (isVarAnInterestingCondition(DRE, N, &report))
3000d9a81ccfSKristof Umann Out << WillBeUsedForACondition;
3001d9a81ccfSKristof Umann
3002124ef7fcSCsaba Dabis // If we know the value create a pop-up note to the 'DRE'.
3003124ef7fcSCsaba Dabis if (!IsAssuming) {
3004124ef7fcSCsaba Dabis PathDiagnosticLocation Loc(DRE, BRC.getSourceManager(), LCtx);
30054b0184b2SCsaba Dabis return std::make_shared<PathDiagnosticPopUpPiece>(Loc, Out.str());
3006124ef7fcSCsaba Dabis }
30074b0184b2SCsaba Dabis
3008124ef7fcSCsaba Dabis PathDiagnosticLocation Loc(Cond, BRC.getSourceManager(), LCtx);
30094b0184b2SCsaba Dabis auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Out.str());
301049ac7eceSKristof Umann
301149ac7eceSKristof Umann if (isInterestingExpr(DRE, N, &report))
30121e809b4cSTed Kremenek event->setPrunable(false);
301349ac7eceSKristof Umann
30140a0c275fSDavid Blaikie return std::move(event);
301554d45675STed Kremenek }
3016a2bbac3fSTed Kremenek
VisitTrueTest(const Expr * Cond,const MemberExpr * ME,BugReporterContext & BRC,PathSensitiveBugReport & report,const ExplodedNode * N,bool TookTrue,bool IsAssuming)30176d716ef1SKristof Umann PathDiagnosticPieceRef ConditionBRVisitor::VisitTrueTest(
3018d1f0ec3fSCsaba Dabis const Expr *Cond, const MemberExpr *ME, BugReporterContext &BRC,
30192f169e7cSArtem Dergachev PathSensitiveBugReport &report, const ExplodedNode *N, bool TookTrue,
30202f169e7cSArtem Dergachev bool IsAssuming) {
3021d1f0ec3fSCsaba Dabis SmallString<256> Buf;
3022d1f0ec3fSCsaba Dabis llvm::raw_svector_ostream Out(Buf);
3023d1f0ec3fSCsaba Dabis
3024d1f0ec3fSCsaba Dabis Out << (IsAssuming ? "Assuming field '" : "Field '")
3025d1f0ec3fSCsaba Dabis << ME->getMemberDecl()->getName() << "' is ";
3026d1f0ec3fSCsaba Dabis
3027d1f0ec3fSCsaba Dabis if (!printValue(ME, Out, N, TookTrue, IsAssuming))
3028d1f0ec3fSCsaba Dabis return nullptr;
3029d1f0ec3fSCsaba Dabis
3030d1f0ec3fSCsaba Dabis const LocationContext *LCtx = N->getLocationContext();
3031124ef7fcSCsaba Dabis PathDiagnosticLocation Loc;
3032124ef7fcSCsaba Dabis
3033124ef7fcSCsaba Dabis // If we know the value create a pop-up note to the member of the MemberExpr.
3034124ef7fcSCsaba Dabis if (!IsAssuming && ME->getMemberLoc().isValid())
3035124ef7fcSCsaba Dabis Loc = PathDiagnosticLocation(ME->getMemberLoc(), BRC.getSourceManager());
3036124ef7fcSCsaba Dabis else
3037124ef7fcSCsaba Dabis Loc = PathDiagnosticLocation(Cond, BRC.getSourceManager(), LCtx);
3038124ef7fcSCsaba Dabis
3039d1f0ec3fSCsaba Dabis if (!Loc.isValid() || !Loc.asLocation().isValid())
3040d1f0ec3fSCsaba Dabis return nullptr;
3041d1f0ec3fSCsaba Dabis
3042d9a81ccfSKristof Umann if (isVarAnInterestingCondition(ME, N, &report))
3043d9a81ccfSKristof Umann Out << WillBeUsedForACondition;
3044d9a81ccfSKristof Umann
3045d9a81ccfSKristof Umann // If we know the value create a pop-up note.
3046d1f0ec3fSCsaba Dabis if (!IsAssuming)
3047d1f0ec3fSCsaba Dabis return std::make_shared<PathDiagnosticPopUpPiece>(Loc, Out.str());
3048d1f0ec3fSCsaba Dabis
304949ac7eceSKristof Umann auto event = std::make_shared<PathDiagnosticEventPiece>(Loc, Out.str());
305049ac7eceSKristof Umann if (isInterestingExpr(ME, N, &report))
305149ac7eceSKristof Umann event->setPrunable(false);
305249ac7eceSKristof Umann return event;
3053d1f0ec3fSCsaba Dabis }
3054d1f0ec3fSCsaba Dabis
printValue(const Expr * CondVarExpr,raw_ostream & Out,const ExplodedNode * N,bool TookTrue,bool IsAssuming)30559942a996SCsaba Dabis bool ConditionBRVisitor::printValue(const Expr *CondVarExpr, raw_ostream &Out,
30569942a996SCsaba Dabis const ExplodedNode *N, bool TookTrue,
30579942a996SCsaba Dabis bool IsAssuming) {
30589942a996SCsaba Dabis QualType Ty = CondVarExpr->getType();
30599942a996SCsaba Dabis
30609942a996SCsaba Dabis if (Ty->isPointerType()) {
30619942a996SCsaba Dabis Out << (TookTrue ? "non-null" : "null");
30629942a996SCsaba Dabis return true;
30639942a996SCsaba Dabis }
30649942a996SCsaba Dabis
30659942a996SCsaba Dabis if (Ty->isObjCObjectPointerType()) {
30669942a996SCsaba Dabis Out << (TookTrue ? "non-nil" : "nil");
30679942a996SCsaba Dabis return true;
30689942a996SCsaba Dabis }
30699942a996SCsaba Dabis
30709942a996SCsaba Dabis if (!Ty->isIntegralOrEnumerationType())
30719942a996SCsaba Dabis return false;
30729942a996SCsaba Dabis
30739942a996SCsaba Dabis Optional<const llvm::APSInt *> IntValue;
30749942a996SCsaba Dabis if (!IsAssuming)
30759942a996SCsaba Dabis IntValue = getConcreteIntegerValue(CondVarExpr, N);
30769942a996SCsaba Dabis
3077452db157SKazu Hirata if (IsAssuming || !IntValue) {
30782e896b8bSCsaba Dabis if (Ty->isBooleanType())
30792e896b8bSCsaba Dabis Out << (TookTrue ? "true" : "false");
30802e896b8bSCsaba Dabis else
30819942a996SCsaba Dabis Out << (TookTrue ? "not equal to 0" : "0");
30822e896b8bSCsaba Dabis } else {
30832e896b8bSCsaba Dabis if (Ty->isBooleanType())
3084cb2c8f69SKazu Hirata Out << (IntValue.value()->getBoolValue() ? "true" : "false");
30859942a996SCsaba Dabis else
3086cb2c8f69SKazu Hirata Out << *IntValue.value();
30872e896b8bSCsaba Dabis }
30889942a996SCsaba Dabis
30899942a996SCsaba Dabis return true;
30909942a996SCsaba Dabis }
30919942a996SCsaba Dabis
309249ac7eceSKristof Umann constexpr llvm::StringLiteral ConditionBRVisitor::GenericTrueMessage;
309349ac7eceSKristof Umann constexpr llvm::StringLiteral ConditionBRVisitor::GenericFalseMessage;
3094602e6256SArtem Dergachev
isPieceMessageGeneric(const PathDiagnosticPiece * Piece)30950c33406aSArtem Dergachev bool ConditionBRVisitor::isPieceMessageGeneric(
30960c33406aSArtem Dergachev const PathDiagnosticPiece *Piece) {
30970c33406aSArtem Dergachev return Piece->getString() == GenericTrueMessage ||
30980c33406aSArtem Dergachev Piece->getString() == GenericFalseMessage;
30990c33406aSArtem Dergachev }
31000c33406aSArtem Dergachev
31014cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
31024cc6d72bSKristof Umann // Implementation of LikelyFalsePositiveSuppressionBRVisitor.
31034cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
31044cc6d72bSKristof Umann
finalizeVisitor(BugReporterContext & BRC,const ExplodedNode * N,PathSensitiveBugReport & BR)31055ec0a261SGeorge Karpenkov void LikelyFalsePositiveSuppressionBRVisitor::finalizeVisitor(
31062f169e7cSArtem Dergachev BugReporterContext &BRC, const ExplodedNode *N,
31072f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
3108d11ef1aaSJordan Rose // Here we suppress false positives coming from system headers. This list is
3109be608303SAnna Zaks // based on known issues.
3110fc76d855SKristof Umann const AnalyzerOptions &Options = BRC.getAnalyzerOptions();
3111a42fb525SAnna Zaks const Decl *D = N->getLocationContext()->getDecl();
3112be608303SAnna Zaks
31139165df12SDevin Coughlin if (AnalysisDeclContext::isInStdNamespace(D)) {
3114d11ef1aaSJordan Rose // Skip reports within the 'std' namespace. Although these can sometimes be
3115d11ef1aaSJordan Rose // the user's fault, we currently don't report them very well, and
3116d11ef1aaSJordan Rose // Note that this will not help for any other data structure libraries, like
3117d11ef1aaSJordan Rose // TR1, Boost, or llvm/ADT.
3118549f9cd4SKristof Umann if (Options.ShouldSuppressFromCXXStandardLibrary) {
31190dbb783cSCraig Topper BR.markInvalid(getTag(), nullptr);
31205ec0a261SGeorge Karpenkov return;
3121a42fb525SAnna Zaks } else {
31222c4555adSEric Christopher // If the complete 'std' suppression is not enabled, suppress reports
3123a42fb525SAnna Zaks // from the 'std' namespace that are known to produce false positives.
3124a42fb525SAnna Zaks
3125a42fb525SAnna Zaks // The analyzer issues a false use-after-free when std::list::pop_front
3126a42fb525SAnna Zaks // or std::list::pop_back are called multiple times because we cannot
3127a42fb525SAnna Zaks // reason about the internal invariants of the data structure.
31289f103a1aSEugene Zelenko if (const auto *MD = dyn_cast<CXXMethodDecl>(D)) {
3129e0ad1040SAnna Zaks const CXXRecordDecl *CD = MD->getParent();
3130e0ad1040SAnna Zaks if (CD->getName() == "list") {
31310dbb783cSCraig Topper BR.markInvalid(getTag(), nullptr);
31325ec0a261SGeorge Karpenkov return;
3133a42fb525SAnna Zaks }
3134d11ef1aaSJordan Rose }
31354c56c226SJordan Rose
3136ac4c8a63SAnna Zaks // The analyzer issues a false positive when the constructor of
3137ac4c8a63SAnna Zaks // std::__independent_bits_engine from algorithms is used.
31389f103a1aSEugene Zelenko if (const auto *MD = dyn_cast<CXXConstructorDecl>(D)) {
3139ac4c8a63SAnna Zaks const CXXRecordDecl *CD = MD->getParent();
3140ac4c8a63SAnna Zaks if (CD->getName() == "__independent_bits_engine") {
3141ac4c8a63SAnna Zaks BR.markInvalid(getTag(), nullptr);
31425ec0a261SGeorge Karpenkov return;
3143ac4c8a63SAnna Zaks }
3144ac4c8a63SAnna Zaks }
3145ac4c8a63SAnna Zaks
3146c7d0acafSJordan Rose for (const LocationContext *LCtx = N->getLocationContext(); LCtx;
3147c7d0acafSJordan Rose LCtx = LCtx->getParent()) {
31489f103a1aSEugene Zelenko const auto *MD = dyn_cast<CXXMethodDecl>(LCtx->getDecl());
31494c56c226SJordan Rose if (!MD)
3150c7d0acafSJordan Rose continue;
31514c56c226SJordan Rose
3152830d2f77SAnna Zaks const CXXRecordDecl *CD = MD->getParent();
31530a53fdf0SDevin Coughlin // The analyzer issues a false positive on
31540a53fdf0SDevin Coughlin // std::basic_string<uint8_t> v; v.push_back(1);
31550a53fdf0SDevin Coughlin // and
31560a53fdf0SDevin Coughlin // std::u16string s; s += u'a';
31570a53fdf0SDevin Coughlin // because we cannot reason about the internal invariants of the
31580a53fdf0SDevin Coughlin // data structure.
3159830d2f77SAnna Zaks if (CD->getName() == "basic_string") {
31600dbb783cSCraig Topper BR.markInvalid(getTag(), nullptr);
31615ec0a261SGeorge Karpenkov return;
3162830d2f77SAnna Zaks }
31630a53fdf0SDevin Coughlin
31640a53fdf0SDevin Coughlin // The analyzer issues a false positive on
31650a53fdf0SDevin Coughlin // std::shared_ptr<int> p(new int(1)); p = nullptr;
31660a53fdf0SDevin Coughlin // because it does not reason properly about temporary destructors.
31670a53fdf0SDevin Coughlin if (CD->getName() == "shared_ptr") {
31680a53fdf0SDevin Coughlin BR.markInvalid(getTag(), nullptr);
31695ec0a261SGeorge Karpenkov return;
31700a53fdf0SDevin Coughlin }
3171c7d0acafSJordan Rose }
3172d11ef1aaSJordan Rose }
3173e0ad1040SAnna Zaks }
3174d11ef1aaSJordan Rose
3175be608303SAnna Zaks // Skip reports within the sys/queue.h macros as we do not have the ability to
3176be608303SAnna Zaks // reason about data structure shapes.
3177fc76d855SKristof Umann const SourceManager &SM = BRC.getSourceManager();
31782f169e7cSArtem Dergachev FullSourceLoc Loc = BR.getLocation().asLocation();
3179be608303SAnna Zaks while (Loc.isMacroID()) {
31803feb2cd5SAnna Zaks Loc = Loc.getSpellingLoc();
31813feb2cd5SAnna Zaks if (SM.getFilename(Loc).endswith("sys/queue.h")) {
31820dbb783cSCraig Topper BR.markInvalid(getTag(), nullptr);
31835ec0a261SGeorge Karpenkov return;
3184be608303SAnna Zaks }
3185be608303SAnna Zaks }
3186be608303SAnna Zaks }
3187be608303SAnna Zaks
31884cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
31894cc6d72bSKristof Umann // Implementation of UndefOrNullArgVisitor.
31904cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
31914cc6d72bSKristof Umann
31922f169e7cSArtem Dergachev PathDiagnosticPieceRef
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & BR)31932f169e7cSArtem Dergachev UndefOrNullArgVisitor::VisitNode(const ExplodedNode *N, BugReporterContext &BRC,
31942f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
31955d4ec363SAnna Zaks ProgramStateRef State = N->getState();
31965d4ec363SAnna Zaks ProgramPoint ProgLoc = N->getLocation();
31975d4ec363SAnna Zaks
31985d4ec363SAnna Zaks // We are only interested in visiting CallEnter nodes.
319987396b9bSDavid Blaikie Optional<CallEnter> CEnter = ProgLoc.getAs<CallEnter>();
32005d4ec363SAnna Zaks if (!CEnter)
32010dbb783cSCraig Topper return nullptr;
32025d4ec363SAnna Zaks
32035d4ec363SAnna Zaks // Check if one of the arguments is the region the visitor is tracking.
32045d4ec363SAnna Zaks CallEventManager &CEMgr = BRC.getStateManager().getCallEventManager();
32055d4ec363SAnna Zaks CallEventRef<> Call = CEMgr.getCaller(CEnter->getCalleeContext(), State);
32065d4ec363SAnna Zaks unsigned Idx = 0;
32072ff16004STed Kremenek ArrayRef<ParmVarDecl *> parms = Call->parameters();
32082ff16004STed Kremenek
32099f103a1aSEugene Zelenko for (const auto ParamDecl : parms) {
32105d4ec363SAnna Zaks const MemRegion *ArgReg = Call->getArgSVal(Idx).getAsRegion();
32119f103a1aSEugene Zelenko ++Idx;
32125d4ec363SAnna Zaks
3213e663b809SAnna Zaks // Are we tracking the argument or its subregion?
3214cf9ff896SGeorge Karpenkov if ( !ArgReg || !R->isSubRegionOf(ArgReg->StripCasts()))
321507a821fbSAnna Zaks continue;
32165d4ec363SAnna Zaks
32175d4ec363SAnna Zaks // Check the function parameter type.
32185d4ec363SAnna Zaks assert(ParamDecl && "Formal parameter has no decl?");
32195d4ec363SAnna Zaks QualType T = ParamDecl->getType();
32205d4ec363SAnna Zaks
32215d4ec363SAnna Zaks if (!(T->isAnyPointerType() || T->isReferenceType())) {
32225d4ec363SAnna Zaks // Function can only change the value passed in by address.
322307a821fbSAnna Zaks continue;
32245d4ec363SAnna Zaks }
32255d4ec363SAnna Zaks
32265d4ec363SAnna Zaks // If it is a const pointer value, the function does not intend to
32275d4ec363SAnna Zaks // change the value.
32285d4ec363SAnna Zaks if (T->getPointeeType().isConstQualified())
322907a821fbSAnna Zaks continue;
32305d4ec363SAnna Zaks
32315d4ec363SAnna Zaks // Mark the call site (LocationContext) as interesting if the value of the
32325d4ec363SAnna Zaks // argument is undefined or '0'/'NULL'.
3233e663b809SAnna Zaks SVal BoundVal = State->getSVal(R);
32345d4ec363SAnna Zaks if (BoundVal.isUndef() || BoundVal.isZeroConstant()) {
32355d4ec363SAnna Zaks BR.markInteresting(CEnter->getCalleeContext());
32360dbb783cSCraig Topper return nullptr;
32375d4ec363SAnna Zaks }
32385d4ec363SAnna Zaks }
32390dbb783cSCraig Topper return nullptr;
32405d4ec363SAnna Zaks }
3241f57f90dfSDevin Coughlin
32424cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
32434cc6d72bSKristof Umann // Implementation of FalsePositiveRefutationBRVisitor.
32444cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
32454cc6d72bSKristof Umann
FalsePositiveRefutationBRVisitor()324638049a51SMikhail R. Gadelha FalsePositiveRefutationBRVisitor::FalsePositiveRefutationBRVisitor()
3247b13d9878SValeriy Savchenko : Constraints(ConstraintMap::Factory().getEmptyMap()) {}
324838049a51SMikhail R. Gadelha
finalizeVisitor(BugReporterContext & BRC,const ExplodedNode * EndPathNode,PathSensitiveBugReport & BR)324938049a51SMikhail R. Gadelha void FalsePositiveRefutationBRVisitor::finalizeVisitor(
32502f169e7cSArtem Dergachev BugReporterContext &BRC, const ExplodedNode *EndPathNode,
32512f169e7cSArtem Dergachev PathSensitiveBugReport &BR) {
325238049a51SMikhail R. Gadelha // Collect new constraints
3253de361df3SBalazs Benics addConstraints(EndPathNode, /*OverwriteConstraintsOnExistingSyms=*/true);
325438049a51SMikhail R. Gadelha
32555c3d032eSMikhail R. Gadelha // Create a refutation manager
3256db695c83SMikhail R. Gadelha llvm::SMTSolverRef RefutationSolver = llvm::CreateZ3Solver();
32575c3d032eSMikhail R. Gadelha ASTContext &Ctx = BRC.getASTContext();
32585c3d032eSMikhail R. Gadelha
32595c3d032eSMikhail R. Gadelha // Add constraints to the solver
32605c3d032eSMikhail R. Gadelha for (const auto &I : Constraints) {
326132ce136eSMikhail R. Gadelha const SymbolRef Sym = I.first;
326232ce136eSMikhail R. Gadelha auto RangeIt = I.second.begin();
32635c3d032eSMikhail R. Gadelha
3264de361df3SBalazs Benics llvm::SMTExprRef SMTConstraints = SMTConv::getRangeExpr(
326532ce136eSMikhail R. Gadelha RefutationSolver, Ctx, Sym, RangeIt->From(), RangeIt->To(),
326632ce136eSMikhail R. Gadelha /*InRange=*/true);
326732ce136eSMikhail R. Gadelha while ((++RangeIt) != I.second.end()) {
3268de361df3SBalazs Benics SMTConstraints = RefutationSolver->mkOr(
3269de361df3SBalazs Benics SMTConstraints, SMTConv::getRangeExpr(RefutationSolver, Ctx, Sym,
327032ce136eSMikhail R. Gadelha RangeIt->From(), RangeIt->To(),
32715c3d032eSMikhail R. Gadelha /*InRange=*/true));
32725c3d032eSMikhail R. Gadelha }
327332ce136eSMikhail R. Gadelha
3274de361df3SBalazs Benics RefutationSolver->addConstraint(SMTConstraints);
32755c3d032eSMikhail R. Gadelha }
32765c3d032eSMikhail R. Gadelha
32775c3d032eSMikhail R. Gadelha // And check for satisfiability
3278de361df3SBalazs Benics Optional<bool> IsSAT = RefutationSolver->check();
327997afce08SKazu Hirata if (!IsSAT)
3280766a189dSMikhail R. Gadelha return;
3281766a189dSMikhail R. Gadelha
3282cb2c8f69SKazu Hirata if (!IsSAT.value())
328338049a51SMikhail R. Gadelha BR.markInvalid("Infeasible constraints", EndPathNode->getLocationContext());
328438049a51SMikhail R. Gadelha }
328538049a51SMikhail R. Gadelha
addConstraints(const ExplodedNode * N,bool OverwriteConstraintsOnExistingSyms)3286de361df3SBalazs Benics void FalsePositiveRefutationBRVisitor::addConstraints(
3287de361df3SBalazs Benics const ExplodedNode *N, bool OverwriteConstraintsOnExistingSyms) {
328838049a51SMikhail R. Gadelha // Collect new constraints
3289b13d9878SValeriy Savchenko ConstraintMap NewCs = getConstraintMap(N->getState());
3290b13d9878SValeriy Savchenko ConstraintMap::Factory &CF = N->getState()->get_context<ConstraintMap>();
32915c3d032eSMikhail R. Gadelha
32925c3d032eSMikhail R. Gadelha // Add constraints if we don't have them yet
32935c3d032eSMikhail R. Gadelha for (auto const &C : NewCs) {
32945c3d032eSMikhail R. Gadelha const SymbolRef &Sym = C.first;
32955c3d032eSMikhail R. Gadelha if (!Constraints.contains(Sym)) {
3296de361df3SBalazs Benics // This symbol is new, just add the constraint.
3297de361df3SBalazs Benics Constraints = CF.add(Constraints, Sym, C.second);
3298de361df3SBalazs Benics } else if (OverwriteConstraintsOnExistingSyms) {
3299de361df3SBalazs Benics // Overwrite the associated constraint of the Symbol.
3300de361df3SBalazs Benics Constraints = CF.remove(Constraints, Sym);
33015c3d032eSMikhail R. Gadelha Constraints = CF.add(Constraints, Sym, C.second);
33025c3d032eSMikhail R. Gadelha }
33035c3d032eSMikhail R. Gadelha }
3304de361df3SBalazs Benics }
33058cd2ee1fSMikhail R. Gadelha
VisitNode(const ExplodedNode * N,BugReporterContext &,PathSensitiveBugReport &)3306de361df3SBalazs Benics PathDiagnosticPieceRef FalsePositiveRefutationBRVisitor::VisitNode(
3307de361df3SBalazs Benics const ExplodedNode *N, BugReporterContext &, PathSensitiveBugReport &) {
3308de361df3SBalazs Benics addConstraints(N, /*OverwriteConstraintsOnExistingSyms=*/false);
33098cd2ee1fSMikhail R. Gadelha return nullptr;
33108cd2ee1fSMikhail R. Gadelha }
33118cd2ee1fSMikhail R. Gadelha
Profile(llvm::FoldingSetNodeID & ID) const33124cc6d72bSKristof Umann void FalsePositiveRefutationBRVisitor::Profile(
33134cc6d72bSKristof Umann llvm::FoldingSetNodeID &ID) const {
33144cc6d72bSKristof Umann static int Tag = 0;
33154cc6d72bSKristof Umann ID.AddPointer(&Tag);
33164cc6d72bSKristof Umann }
33174cc6d72bSKristof Umann
33184cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
33194cc6d72bSKristof Umann // Implementation of TagVisitor.
33204cc6d72bSKristof Umann //===----------------------------------------------------------------------===//
33214cc6d72bSKristof Umann
33220a7dd5a2SArtem Dergachev int NoteTag::Kind = 0;
33230a7dd5a2SArtem Dergachev
Profile(llvm::FoldingSetNodeID & ID) const33240a7dd5a2SArtem Dergachev void TagVisitor::Profile(llvm::FoldingSetNodeID &ID) const {
33250a7dd5a2SArtem Dergachev static int Tag = 0;
33260a7dd5a2SArtem Dergachev ID.AddPointer(&Tag);
33270a7dd5a2SArtem Dergachev }
33280a7dd5a2SArtem Dergachev
VisitNode(const ExplodedNode * N,BugReporterContext & BRC,PathSensitiveBugReport & R)33296d716ef1SKristof Umann PathDiagnosticPieceRef TagVisitor::VisitNode(const ExplodedNode *N,
33306d716ef1SKristof Umann BugReporterContext &BRC,
33312f169e7cSArtem Dergachev PathSensitiveBugReport &R) {
33320a7dd5a2SArtem Dergachev ProgramPoint PP = N->getLocation();
33330a7dd5a2SArtem Dergachev const NoteTag *T = dyn_cast_or_null<NoteTag>(PP.getTag());
33340a7dd5a2SArtem Dergachev if (!T)
33350a7dd5a2SArtem Dergachev return nullptr;
33360a7dd5a2SArtem Dergachev
33370a7dd5a2SArtem Dergachev if (Optional<std::string> Msg = T->generateMessage(BRC, R)) {
33380a7dd5a2SArtem Dergachev PathDiagnosticLocation Loc =
33390a7dd5a2SArtem Dergachev PathDiagnosticLocation::create(PP, BRC.getSourceManager());
3340ef0aab31SArtem Dergachev auto Piece = std::make_shared<PathDiagnosticEventPiece>(Loc, *Msg);
3341ef0aab31SArtem Dergachev Piece->setPrunable(T->isPrunable());
3342ef0aab31SArtem Dergachev return Piece;
33430a7dd5a2SArtem Dergachev }
33440a7dd5a2SArtem Dergachev
33450a7dd5a2SArtem Dergachev return nullptr;
33460a7dd5a2SArtem Dergachev }
3347