1 //== Nullabilityhecker.cpp - Nullability checker ----------------*- C++ -*--==//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 //
10 // This checker tries to find nullability violations. There are several kinds of
11 // possible violations:
12 // * Null pointer is passed to a pointer which has a _Nonnull type.
13 // * Null pointer is returned from a function which has a _Nonnull return type.
14 // * Nullable pointer is passed to a pointer which has a _Nonnull type.
15 // * Nullable pointer is returned from a function which has a _Nonnull return
16 //   type.
17 // * Nullable pointer is dereferenced.
18 //
19 // This checker propagates the nullability information of the pointers and looks
20 // for the patterns that are described above. Explicit casts are trusted and are
21 // considered a way to suppress false positives for this checker. The other way
22 // to suppress warnings would be to add asserts or guarding if statements to the
23 // code. In addition to the nullability propagation this checker also uses some
24 // heuristics to suppress potential false positives.
25 //
26 //===----------------------------------------------------------------------===//
27 
28 #include "ClangSACheckers.h"
29 #include "llvm/Support/Path.h"
30 #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
31 #include "clang/StaticAnalyzer/Core/Checker.h"
32 #include "clang/StaticAnalyzer/Core/CheckerManager.h"
33 #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
34 #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
35 
36 using namespace clang;
37 using namespace ento;
38 
39 namespace {
40 // Do not reorder! The getMostNullable method relies on the order.
41 // Optimization: Most pointers expected to be unspecified. When a symbol has an
42 // unspecified or nonnull type non of the rules would indicate any problem for
43 // that symbol. For this reason only nullable and contradicted nullability are
44 // stored for a symbol. When a symbol is already contradicted, it can not be
45 // casted back to nullable.
46 enum class Nullability : char {
47   Contradicted, // Tracked nullability is contradicted by an explicit cast. Do
48                 // not report any nullability related issue for this symbol.
49                 // This nullability is propagated agressively to avoid false
50                 // positive results. See the comment on getMostNullable method.
51   Nullable,
52   Unspecified,
53   Nonnull
54 };
55 
56 /// Returns the most nullable nullability. This is used for message expressions
57 /// like [reciever method], where the nullability of this expression is either
58 /// the nullability of the receiver or the nullability of the return type of the
59 /// method, depending on which is more nullable. Contradicted is considered to
60 /// be the most nullable, to avoid false positive results.
61 Nullability getMostNullable(Nullability Lhs, Nullability Rhs) {
62   return static_cast<Nullability>(
63       std::min(static_cast<char>(Lhs), static_cast<char>(Rhs)));
64 }
65 
66 const char *getNullabilityString(Nullability Nullab) {
67   switch (Nullab) {
68   case Nullability::Contradicted:
69     return "contradicted";
70   case Nullability::Nullable:
71     return "nullable";
72   case Nullability::Unspecified:
73     return "unspecified";
74   case Nullability::Nonnull:
75     return "nonnull";
76   }
77   llvm_unreachable("Unexpected enumeration.");
78   return "";
79 }
80 
81 // These enums are used as an index to ErrorMessages array.
82 enum class ErrorKind : int {
83   NilAssignedToNonnull,
84   NilPassedToNonnull,
85   NilReturnedToNonnull,
86   NullableAssignedToNonnull,
87   NullableReturnedToNonnull,
88   NullableDereferenced,
89   NullablePassedToNonnull
90 };
91 
92 const char *const ErrorMessages[] = {
93     "Null is assigned to a pointer which is expected to have non-null value",
94     "Null passed to a callee that requires a non-null argument",
95     "Null is returned from a function that is expected to return a non-null "
96     "value",
97     "Nullable pointer is assigned to a pointer which is expected to have "
98     "non-null value",
99     "Nullable pointer is returned from a function that is expected to return a "
100     "non-null value",
101     "Nullable pointer is dereferenced",
102     "Nullable pointer is passed to a callee that requires a non-null argument"};
103 
104 class NullabilityChecker
105     : public Checker<check::Bind, check::PreCall, check::PreStmt<ReturnStmt>,
106                      check::PostCall, check::PostStmt<ExplicitCastExpr>,
107                      check::PostObjCMessage, check::DeadSymbols,
108                      check::Event<ImplicitNullDerefEvent>> {
109   mutable std::unique_ptr<BugType> BT;
110 
111 public:
112   void checkBind(SVal L, SVal V, const Stmt *S, CheckerContext &C) const;
113   void checkPostStmt(const ExplicitCastExpr *CE, CheckerContext &C) const;
114   void checkPreStmt(const ReturnStmt *S, CheckerContext &C) const;
115   void checkPostObjCMessage(const ObjCMethodCall &M, CheckerContext &C) const;
116   void checkPostCall(const CallEvent &Call, CheckerContext &C) const;
117   void checkPreCall(const CallEvent &Call, CheckerContext &C) const;
118   void checkDeadSymbols(SymbolReaper &SR, CheckerContext &C) const;
119   void checkEvent(ImplicitNullDerefEvent Event) const;
120 
121   void printState(raw_ostream &Out, ProgramStateRef State, const char *NL,
122                   const char *Sep) const override;
123 
124   struct NullabilityChecksFilter {
125     DefaultBool CheckNullPassedToNonnull;
126     DefaultBool CheckNullReturnedFromNonnull;
127     DefaultBool CheckNullableDereferenced;
128     DefaultBool CheckNullablePassedToNonnull;
129     DefaultBool CheckNullableReturnedFromNonnull;
130 
131     CheckName CheckNameNullPassedToNonnull;
132     CheckName CheckNameNullReturnedFromNonnull;
133     CheckName CheckNameNullableDereferenced;
134     CheckName CheckNameNullablePassedToNonnull;
135     CheckName CheckNameNullableReturnedFromNonnull;
136   };
137 
138   NullabilityChecksFilter Filter;
139   // When set to false no nullability information will be tracked in
140   // NullabilityMap. It is possible to catch errors like passing a null pointer
141   // to a callee that expects nonnull argument without the information that is
142   // stroed in the NullabilityMap. This is an optimization.
143   DefaultBool NeedTracking;
144 
145 private:
146   class NullabilityBugVisitor
147       : public BugReporterVisitorImpl<NullabilityBugVisitor> {
148   public:
149     NullabilityBugVisitor(const MemRegion *M) : Region(M) {}
150 
151     void Profile(llvm::FoldingSetNodeID &ID) const override {
152       static int X = 0;
153       ID.AddPointer(&X);
154       ID.AddPointer(Region);
155     }
156 
157     PathDiagnosticPiece *VisitNode(const ExplodedNode *N,
158                                    const ExplodedNode *PrevN,
159                                    BugReporterContext &BRC,
160                                    BugReport &BR) override;
161 
162   private:
163     // The tracked region.
164     const MemRegion *Region;
165   };
166 
167   /// When any of the nonnull arguments of the analyzed function is null, do not
168   /// report anything and turn off the check.
169   ///
170   /// When \p SuppressPath is set to true, no more bugs will be reported on this
171   /// path by this checker.
172   void reportBugIfPreconditionHolds(ErrorKind Error, ExplodedNode *N,
173                                     const MemRegion *Region, CheckerContext &C,
174                                     const Stmt *ValueExpr = nullptr,
175                                     bool SuppressPath = false) const;
176 
177   void reportBug(ErrorKind Error, ExplodedNode *N, const MemRegion *Region,
178                  BugReporter &BR, const Stmt *ValueExpr = nullptr) const {
179     if (!BT)
180       BT.reset(new BugType(this, "Nullability", "Memory error"));
181     const char *Msg = ErrorMessages[static_cast<int>(Error)];
182     std::unique_ptr<BugReport> R(new BugReport(*BT, Msg, N));
183     if (Region) {
184       R->markInteresting(Region);
185       R->addVisitor(llvm::make_unique<NullabilityBugVisitor>(Region));
186     }
187     if (ValueExpr) {
188       R->addRange(ValueExpr->getSourceRange());
189       if (Error == ErrorKind::NilAssignedToNonnull ||
190           Error == ErrorKind::NilPassedToNonnull ||
191           Error == ErrorKind::NilReturnedToNonnull)
192         bugreporter::trackNullOrUndefValue(N, ValueExpr, *R);
193     }
194     BR.emitReport(std::move(R));
195   }
196 
197   /// If an SVal wraps a region that should be tracked, it will return a pointer
198   /// to the wrapped region. Otherwise it will return a nullptr.
199   const SymbolicRegion *getTrackRegion(SVal Val,
200                                        bool CheckSuperRegion = false) const;
201 };
202 
203 class NullabilityState {
204 public:
205   NullabilityState(Nullability Nullab, const Stmt *Source = nullptr)
206       : Nullab(Nullab), Source(Source) {}
207 
208   const Stmt *getNullabilitySource() const { return Source; }
209 
210   Nullability getValue() const { return Nullab; }
211 
212   void Profile(llvm::FoldingSetNodeID &ID) const {
213     ID.AddInteger(static_cast<char>(Nullab));
214     ID.AddPointer(Source);
215   }
216 
217   void print(raw_ostream &Out) const {
218     Out << getNullabilityString(Nullab) << "\n";
219   }
220 
221 private:
222   Nullability Nullab;
223   // Source is the expression which determined the nullability. For example in a
224   // message like [nullable nonnull_returning] has nullable nullability, because
225   // the receiver is nullable. Here the receiver will be the source of the
226   // nullability. This is useful information when the diagnostics are generated.
227   const Stmt *Source;
228 };
229 
230 bool operator==(NullabilityState Lhs, NullabilityState Rhs) {
231   return Lhs.getValue() == Rhs.getValue() &&
232          Lhs.getNullabilitySource() == Rhs.getNullabilitySource();
233 }
234 
235 } // end anonymous namespace
236 
237 REGISTER_MAP_WITH_PROGRAMSTATE(NullabilityMap, const MemRegion *,
238                                NullabilityState)
239 
240 // If the nullability precondition of a function is violated, we should not
241 // report nullability related issues on that path. For this reason once a
242 // precondition is not met on a path, this checker will be esentially turned off
243 // for the rest of the analysis. We do not want to generate a sink node however,
244 // so this checker would not lead to reduced coverage.
245 REGISTER_TRAIT_WITH_PROGRAMSTATE(PreconditionViolated, bool)
246 
247 enum class NullConstraint { IsNull, IsNotNull, Unknown };
248 
249 static NullConstraint getNullConstraint(DefinedOrUnknownSVal Val,
250                                         ProgramStateRef State) {
251   ConditionTruthVal Nullness = State->isNull(Val);
252   if (Nullness.isConstrainedFalse())
253     return NullConstraint::IsNotNull;
254   if (Nullness.isConstrainedTrue())
255     return NullConstraint::IsNull;
256   return NullConstraint::Unknown;
257 }
258 
259 const SymbolicRegion *
260 NullabilityChecker::getTrackRegion(SVal Val, bool CheckSuperRegion) const {
261   if (!NeedTracking)
262     return nullptr;
263 
264   auto RegionSVal = Val.getAs<loc::MemRegionVal>();
265   if (!RegionSVal)
266     return nullptr;
267 
268   const MemRegion *Region = RegionSVal->getRegion();
269 
270   if (CheckSuperRegion) {
271     if (auto FieldReg = Region->getAs<FieldRegion>())
272       return dyn_cast<SymbolicRegion>(FieldReg->getSuperRegion());
273     if (auto ElementReg = Region->getAs<ElementRegion>())
274       return dyn_cast<SymbolicRegion>(ElementReg->getSuperRegion());
275   }
276 
277   return dyn_cast<SymbolicRegion>(Region);
278 }
279 
280 PathDiagnosticPiece *NullabilityChecker::NullabilityBugVisitor::VisitNode(
281     const ExplodedNode *N, const ExplodedNode *PrevN, BugReporterContext &BRC,
282     BugReport &BR) {
283   ProgramStateRef State = N->getState();
284   ProgramStateRef StatePrev = PrevN->getState();
285 
286   const NullabilityState *TrackedNullab = State->get<NullabilityMap>(Region);
287   const NullabilityState *TrackedNullabPrev =
288       StatePrev->get<NullabilityMap>(Region);
289   if (!TrackedNullab)
290     return nullptr;
291 
292   if (TrackedNullabPrev &&
293       TrackedNullabPrev->getValue() == TrackedNullab->getValue())
294     return nullptr;
295 
296   // Retrieve the associated statement.
297   const Stmt *S = TrackedNullab->getNullabilitySource();
298   if (!S) {
299     ProgramPoint ProgLoc = N->getLocation();
300     if (Optional<StmtPoint> SP = ProgLoc.getAs<StmtPoint>()) {
301       S = SP->getStmt();
302     }
303   }
304 
305   if (!S)
306     return nullptr;
307 
308   std::string InfoText =
309       (llvm::Twine("Nullability '") +
310        getNullabilityString(TrackedNullab->getValue()) + "' is infered")
311           .str();
312 
313   // Generate the extra diagnostic.
314   PathDiagnosticLocation Pos(S, BRC.getSourceManager(),
315                              N->getLocationContext());
316   return new PathDiagnosticEventPiece(Pos, InfoText, true, nullptr);
317 }
318 
319 static Nullability getNullabilityAnnotation(QualType Type) {
320   const auto *AttrType = Type->getAs<AttributedType>();
321   if (!AttrType)
322     return Nullability::Unspecified;
323   if (AttrType->getAttrKind() == AttributedType::attr_nullable)
324     return Nullability::Nullable;
325   else if (AttrType->getAttrKind() == AttributedType::attr_nonnull)
326     return Nullability::Nonnull;
327   return Nullability::Unspecified;
328 }
329 
330 template <typename ParamVarDeclRange>
331 static bool
332 checkParamsForPreconditionViolation(const ParamVarDeclRange &Params,
333                                     ProgramStateRef State,
334                                     const LocationContext *LocCtxt) {
335   for (const auto *ParamDecl : Params) {
336     if (ParamDecl->isParameterPack())
337       break;
338 
339     if (getNullabilityAnnotation(ParamDecl->getType()) != Nullability::Nonnull)
340       continue;
341 
342     auto RegVal = State->getLValue(ParamDecl, LocCtxt)
343                       .template getAs<loc::MemRegionVal>();
344     if (!RegVal)
345       continue;
346 
347     auto ParamValue = State->getSVal(RegVal->getRegion())
348                           .template getAs<DefinedOrUnknownSVal>();
349     if (!ParamValue)
350       continue;
351 
352     if (getNullConstraint(*ParamValue, State) == NullConstraint::IsNull) {
353       return true;
354     }
355   }
356   return false;
357 }
358 
359 static bool checkPreconditionViolation(ProgramStateRef State, ExplodedNode *N,
360                                        CheckerContext &C) {
361   if (State->get<PreconditionViolated>())
362     return true;
363 
364   const LocationContext *LocCtxt = C.getLocationContext();
365   const Decl *D = LocCtxt->getDecl();
366   if (!D)
367     return false;
368 
369   if (const auto *BlockD = dyn_cast<BlockDecl>(D)) {
370     if (checkParamsForPreconditionViolation(BlockD->parameters(), State,
371                                             LocCtxt)) {
372       if (!N->isSink())
373         C.addTransition(State->set<PreconditionViolated>(true), N);
374       return true;
375     }
376     return false;
377   }
378 
379   if (const auto *FuncDecl = dyn_cast<FunctionDecl>(D)) {
380     if (checkParamsForPreconditionViolation(FuncDecl->parameters(), State,
381                                             LocCtxt)) {
382       if (!N->isSink())
383         C.addTransition(State->set<PreconditionViolated>(true), N);
384       return true;
385     }
386     return false;
387   }
388   return false;
389 }
390 
391 void NullabilityChecker::reportBugIfPreconditionHolds(
392     ErrorKind Error, ExplodedNode *N, const MemRegion *Region,
393     CheckerContext &C, const Stmt *ValueExpr, bool SuppressPath) const {
394   ProgramStateRef OriginalState = N->getState();
395 
396   if (checkPreconditionViolation(OriginalState, N, C))
397     return;
398   if (SuppressPath) {
399     OriginalState = OriginalState->set<PreconditionViolated>(true);
400     N = C.addTransition(OriginalState, N);
401   }
402 
403   reportBug(Error, N, Region, C.getBugReporter(), ValueExpr);
404 }
405 
406 /// Cleaning up the program state.
407 void NullabilityChecker::checkDeadSymbols(SymbolReaper &SR,
408                                           CheckerContext &C) const {
409   if (!SR.hasDeadSymbols())
410     return;
411 
412   ProgramStateRef State = C.getState();
413   NullabilityMapTy Nullabilities = State->get<NullabilityMap>();
414   for (NullabilityMapTy::iterator I = Nullabilities.begin(),
415                                   E = Nullabilities.end();
416        I != E; ++I) {
417     const auto *Region = I->first->getAs<SymbolicRegion>();
418     assert(Region && "Non-symbolic region is tracked.");
419     if (SR.isDead(Region->getSymbol())) {
420       State = State->remove<NullabilityMap>(I->first);
421     }
422   }
423   // When one of the nonnull arguments are constrained to be null, nullability
424   // preconditions are violated. It is not enough to check this only when we
425   // actually report an error, because at that time interesting symbols might be
426   // reaped.
427   if (checkPreconditionViolation(State, C.getPredecessor(), C))
428     return;
429   C.addTransition(State);
430 }
431 
432 /// This callback triggers when a pointer is dereferenced and the analyzer does
433 /// not know anything about the value of that pointer. When that pointer is
434 /// nullable, this code emits a warning.
435 void NullabilityChecker::checkEvent(ImplicitNullDerefEvent Event) const {
436   if (Event.SinkNode->getState()->get<PreconditionViolated>())
437     return;
438 
439   const MemRegion *Region =
440       getTrackRegion(Event.Location, /*CheckSuperregion=*/true);
441   if (!Region)
442     return;
443 
444   ProgramStateRef State = Event.SinkNode->getState();
445   const NullabilityState *TrackedNullability =
446       State->get<NullabilityMap>(Region);
447 
448   if (!TrackedNullability)
449     return;
450 
451   if (Filter.CheckNullableDereferenced &&
452       TrackedNullability->getValue() == Nullability::Nullable) {
453     BugReporter &BR = *Event.BR;
454     // Do not suppress errors on defensive code paths, because dereferencing
455     // a nullable pointer is always an error.
456     if (Event.IsDirectDereference)
457       reportBug(ErrorKind::NullableDereferenced, Event.SinkNode, Region, BR);
458     else
459       reportBug(ErrorKind::NullablePassedToNonnull, Event.SinkNode, Region, BR);
460   }
461 }
462 
463 /// This method check when nullable pointer or null value is returned from a
464 /// function that has nonnull return type.
465 ///
466 /// TODO: when nullability preconditons are violated, it is ok to violate the
467 /// nullability postconditons (i.e.: when one of the nonnull parameters are null
468 /// this check should not report any nullability related issue).
469 void NullabilityChecker::checkPreStmt(const ReturnStmt *S,
470                                       CheckerContext &C) const {
471   auto RetExpr = S->getRetValue();
472   if (!RetExpr)
473     return;
474 
475   if (!RetExpr->getType()->isAnyPointerType())
476     return;
477 
478   ProgramStateRef State = C.getState();
479   if (State->get<PreconditionViolated>())
480     return;
481 
482   auto RetSVal =
483       State->getSVal(S, C.getLocationContext()).getAs<DefinedOrUnknownSVal>();
484   if (!RetSVal)
485     return;
486 
487   AnalysisDeclContext *DeclCtxt =
488       C.getLocationContext()->getAnalysisDeclContext();
489   const FunctionType *FuncType = DeclCtxt->getDecl()->getFunctionType();
490   if (!FuncType)
491     return;
492 
493   NullConstraint Nullness = getNullConstraint(*RetSVal, State);
494 
495   Nullability StaticNullability =
496       getNullabilityAnnotation(FuncType->getReturnType());
497 
498   if (Filter.CheckNullReturnedFromNonnull &&
499       Nullness == NullConstraint::IsNull &&
500       StaticNullability == Nullability::Nonnull) {
501     static CheckerProgramPointTag Tag(this, "NullReturnedFromNonnull");
502     ExplodedNode *N = C.generateSink(State, C.getPredecessor(), &Tag);
503     reportBugIfPreconditionHolds(ErrorKind::NilReturnedToNonnull, N, nullptr, C,
504                                  RetExpr);
505     return;
506   }
507 
508   const MemRegion *Region = getTrackRegion(*RetSVal);
509   if (!Region)
510     return;
511 
512   const NullabilityState *TrackedNullability =
513       State->get<NullabilityMap>(Region);
514   if (TrackedNullability) {
515     Nullability TrackedNullabValue = TrackedNullability->getValue();
516     if (Filter.CheckNullableReturnedFromNonnull &&
517         Nullness != NullConstraint::IsNotNull &&
518         TrackedNullabValue == Nullability::Nullable &&
519         StaticNullability == Nullability::Nonnull) {
520       static CheckerProgramPointTag Tag(this, "NullableReturnedFromNonnull");
521       ExplodedNode *N = C.addTransition(State, C.getPredecessor(), &Tag);
522       reportBugIfPreconditionHolds(ErrorKind::NullableReturnedToNonnull, N,
523                                    Region, C);
524     }
525     return;
526   }
527   if (StaticNullability == Nullability::Nullable) {
528     State = State->set<NullabilityMap>(Region,
529                                        NullabilityState(StaticNullability, S));
530     C.addTransition(State);
531   }
532 }
533 
534 /// This callback warns when a nullable pointer or a null value is passed to a
535 /// function that expects its argument to be nonnull.
536 void NullabilityChecker::checkPreCall(const CallEvent &Call,
537                                       CheckerContext &C) const {
538   if (!Call.getDecl())
539     return;
540 
541   ProgramStateRef State = C.getState();
542   if (State->get<PreconditionViolated>())
543     return;
544 
545   ProgramStateRef OrigState = State;
546 
547   unsigned Idx = 0;
548   for (const ParmVarDecl *Param : Call.parameters()) {
549     if (Param->isParameterPack())
550       break;
551 
552     const Expr *ArgExpr = nullptr;
553     if (Idx < Call.getNumArgs())
554       ArgExpr = Call.getArgExpr(Idx);
555     auto ArgSVal = Call.getArgSVal(Idx++).getAs<DefinedOrUnknownSVal>();
556     if (!ArgSVal)
557       continue;
558 
559     if (!Param->getType()->isAnyPointerType() &&
560         !Param->getType()->isReferenceType())
561       continue;
562 
563     NullConstraint Nullness = getNullConstraint(*ArgSVal, State);
564 
565     Nullability ParamNullability = getNullabilityAnnotation(Param->getType());
566     Nullability ArgStaticNullability =
567         getNullabilityAnnotation(ArgExpr->getType());
568 
569     if (Filter.CheckNullPassedToNonnull && Nullness == NullConstraint::IsNull &&
570         ArgStaticNullability != Nullability::Nonnull &&
571         ParamNullability == Nullability::Nonnull) {
572       ExplodedNode *N = C.generateSink(State);
573       reportBugIfPreconditionHolds(ErrorKind::NilPassedToNonnull, N, nullptr, C,
574                                    ArgExpr);
575       return;
576     }
577 
578     const MemRegion *Region = getTrackRegion(*ArgSVal);
579     if (!Region)
580       continue;
581 
582     const NullabilityState *TrackedNullability =
583         State->get<NullabilityMap>(Region);
584 
585     if (TrackedNullability) {
586       if (Nullness == NullConstraint::IsNotNull ||
587           TrackedNullability->getValue() != Nullability::Nullable)
588         continue;
589 
590       if (Filter.CheckNullablePassedToNonnull &&
591           ParamNullability == Nullability::Nonnull) {
592         ExplodedNode *N = C.addTransition(State);
593         reportBugIfPreconditionHolds(ErrorKind::NullablePassedToNonnull, N,
594                                      Region, C, ArgExpr, /*SuppressPath=*/true);
595         return;
596       }
597       if (Filter.CheckNullableDereferenced &&
598           Param->getType()->isReferenceType()) {
599         ExplodedNode *N = C.addTransition(State);
600         reportBugIfPreconditionHolds(ErrorKind::NullableDereferenced, N, Region,
601                                      C, ArgExpr, /*SuppressPath=*/true);
602         return;
603       }
604       continue;
605     }
606     // No tracked nullability yet.
607     if (ArgStaticNullability != Nullability::Nullable)
608       continue;
609     State = State->set<NullabilityMap>(
610         Region, NullabilityState(ArgStaticNullability, ArgExpr));
611   }
612   if (State != OrigState)
613     C.addTransition(State);
614 }
615 
616 /// Suppress the nullability warnings for some functions.
617 void NullabilityChecker::checkPostCall(const CallEvent &Call,
618                                        CheckerContext &C) const {
619   auto Decl = Call.getDecl();
620   if (!Decl)
621     return;
622   // ObjC Messages handles in a different callback.
623   if (Call.getKind() == CE_ObjCMessage)
624     return;
625   const FunctionType *FuncType = Decl->getFunctionType();
626   if (!FuncType)
627     return;
628   QualType ReturnType = FuncType->getReturnType();
629   if (!ReturnType->isAnyPointerType())
630     return;
631   ProgramStateRef State = C.getState();
632   if (State->get<PreconditionViolated>())
633     return;
634 
635   const MemRegion *Region = getTrackRegion(Call.getReturnValue());
636   if (!Region)
637     return;
638 
639   // CG headers are misannotated. Do not warn for symbols that are the results
640   // of CG calls.
641   const SourceManager &SM = C.getSourceManager();
642   StringRef FilePath = SM.getFilename(SM.getSpellingLoc(Decl->getLocStart()));
643   if (llvm::sys::path::filename(FilePath).startswith("CG")) {
644     State = State->set<NullabilityMap>(Region, Nullability::Contradicted);
645     C.addTransition(State);
646     return;
647   }
648 
649   const NullabilityState *TrackedNullability =
650       State->get<NullabilityMap>(Region);
651 
652   if (!TrackedNullability &&
653       getNullabilityAnnotation(ReturnType) == Nullability::Nullable) {
654     State = State->set<NullabilityMap>(Region, Nullability::Nullable);
655     C.addTransition(State);
656   }
657 }
658 
659 static Nullability getReceiverNullability(const ObjCMethodCall &M,
660                                           ProgramStateRef State) {
661   if (M.isReceiverSelfOrSuper()) {
662     // For super and super class receivers we assume that the receiver is
663     // nonnull.
664     return Nullability::Nonnull;
665   }
666   // Otherwise look up nullability in the state.
667   SVal Receiver = M.getReceiverSVal();
668   if (auto DefOrUnknown = Receiver.getAs<DefinedOrUnknownSVal>()) {
669     // If the receiver is constrained to be nonnull, assume that it is nonnull
670     // regardless of its type.
671     NullConstraint Nullness = getNullConstraint(*DefOrUnknown, State);
672     if (Nullness == NullConstraint::IsNotNull)
673       return Nullability::Nonnull;
674   }
675   auto ValueRegionSVal = Receiver.getAs<loc::MemRegionVal>();
676   if (ValueRegionSVal) {
677     const MemRegion *SelfRegion = ValueRegionSVal->getRegion();
678     assert(SelfRegion);
679 
680     const NullabilityState *TrackedSelfNullability =
681         State->get<NullabilityMap>(SelfRegion);
682     if (TrackedSelfNullability)
683       return TrackedSelfNullability->getValue();
684   }
685   return Nullability::Unspecified;
686 }
687 
688 /// Calculate the nullability of the result of a message expr based on the
689 /// nullability of the receiver, the nullability of the return value, and the
690 /// constraints.
691 void NullabilityChecker::checkPostObjCMessage(const ObjCMethodCall &M,
692                                               CheckerContext &C) const {
693   auto Decl = M.getDecl();
694   if (!Decl)
695     return;
696   QualType RetType = Decl->getReturnType();
697   if (!RetType->isAnyPointerType())
698     return;
699 
700   ProgramStateRef State = C.getState();
701   if (State->get<PreconditionViolated>())
702     return;
703 
704   const MemRegion *ReturnRegion = getTrackRegion(M.getReturnValue());
705   if (!ReturnRegion)
706     return;
707 
708   auto Interface = Decl->getClassInterface();
709   auto Name = Interface ? Interface->getName() : "";
710   // In order to reduce the noise in the diagnostics generated by this checker,
711   // some framework and programming style based heuristics are used. These
712   // heuristics are for Cocoa APIs which have NS prefix.
713   if (Name.startswith("NS")) {
714     // Developers rely on dynamic invariants such as an item should be available
715     // in a collection, or a collection is not empty often. Those invariants can
716     // not be inferred by any static analysis tool. To not to bother the users
717     // with too many false positives, every item retrieval function should be
718     // ignored for collections. The instance methods of dictionaries in Cocoa
719     // are either item retrieval related or not interesting nullability wise.
720     // Using this fact, to keep the code easier to read just ignore the return
721     // value of every instance method of dictionaries.
722     if (M.isInstanceMessage() && Name.find("Dictionary") != StringRef::npos) {
723       State =
724           State->set<NullabilityMap>(ReturnRegion, Nullability::Contradicted);
725       C.addTransition(State);
726       return;
727     }
728     // For similar reasons ignore some methods of Cocoa arrays.
729     StringRef FirstSelectorSlot = M.getSelector().getNameForSlot(0);
730     if (Name.find("Array") != StringRef::npos &&
731         (FirstSelectorSlot == "firstObject" ||
732          FirstSelectorSlot == "lastObject")) {
733       State =
734           State->set<NullabilityMap>(ReturnRegion, Nullability::Contradicted);
735       C.addTransition(State);
736       return;
737     }
738 
739     // Encoding related methods of string should not fail when lossless
740     // encodings are used. Using lossless encodings is so frequent that ignoring
741     // this class of methods reduced the emitted diagnostics by about 30% on
742     // some projects (and all of that was false positives).
743     if (Name.find("String") != StringRef::npos) {
744       for (auto Param : M.parameters()) {
745         if (Param->getName() == "encoding") {
746           State = State->set<NullabilityMap>(ReturnRegion,
747                                              Nullability::Contradicted);
748           C.addTransition(State);
749           return;
750         }
751       }
752     }
753   }
754 
755   const ObjCMessageExpr *Message = M.getOriginExpr();
756   Nullability SelfNullability = getReceiverNullability(M, State);
757 
758   const NullabilityState *NullabilityOfReturn =
759       State->get<NullabilityMap>(ReturnRegion);
760 
761   if (NullabilityOfReturn) {
762     // When we have a nullability tracked for the return value, the nullability
763     // of the expression will be the most nullable of the receiver and the
764     // return value.
765     Nullability RetValTracked = NullabilityOfReturn->getValue();
766     Nullability ComputedNullab =
767         getMostNullable(RetValTracked, SelfNullability);
768     if (ComputedNullab != RetValTracked &&
769         ComputedNullab != Nullability::Unspecified) {
770       const Stmt *NullabilitySource =
771           ComputedNullab == RetValTracked
772               ? NullabilityOfReturn->getNullabilitySource()
773               : Message->getInstanceReceiver();
774       State = State->set<NullabilityMap>(
775           ReturnRegion, NullabilityState(ComputedNullab, NullabilitySource));
776       C.addTransition(State);
777     }
778     return;
779   }
780 
781   // No tracked information. Use static type information for return value.
782   Nullability RetNullability = getNullabilityAnnotation(RetType);
783 
784   // Properties might be computed. For this reason the static analyzer creates a
785   // new symbol each time an unknown property  is read. To avoid false pozitives
786   // do not treat unknown properties as nullable, even when they explicitly
787   // marked nullable.
788   if (M.getMessageKind() == OCM_PropertyAccess && !C.wasInlined)
789     RetNullability = Nullability::Nonnull;
790 
791   Nullability ComputedNullab = getMostNullable(RetNullability, SelfNullability);
792   if (ComputedNullab == Nullability::Nullable) {
793     const Stmt *NullabilitySource = ComputedNullab == RetNullability
794                                         ? Message
795                                         : Message->getInstanceReceiver();
796     State = State->set<NullabilityMap>(
797         ReturnRegion, NullabilityState(ComputedNullab, NullabilitySource));
798     C.addTransition(State);
799   }
800 }
801 
802 /// Explicit casts are trusted. If there is a disagreement in the nullability
803 /// annotations in the destination and the source or '0' is casted to nonnull
804 /// track the value as having contraditory nullability. This will allow users to
805 /// suppress warnings.
806 void NullabilityChecker::checkPostStmt(const ExplicitCastExpr *CE,
807                                        CheckerContext &C) const {
808   QualType OriginType = CE->getSubExpr()->getType();
809   QualType DestType = CE->getType();
810   if (!OriginType->isAnyPointerType())
811     return;
812   if (!DestType->isAnyPointerType())
813     return;
814 
815   ProgramStateRef State = C.getState();
816   if (State->get<PreconditionViolated>())
817     return;
818 
819   Nullability DestNullability = getNullabilityAnnotation(DestType);
820 
821   // No explicit nullability in the destination type, so this cast does not
822   // change the nullability.
823   if (DestNullability == Nullability::Unspecified)
824     return;
825 
826   auto RegionSVal =
827       State->getSVal(CE, C.getLocationContext()).getAs<DefinedOrUnknownSVal>();
828   const MemRegion *Region = getTrackRegion(*RegionSVal);
829   if (!Region)
830     return;
831 
832   // When 0 is converted to nonnull mark it as contradicted.
833   if (DestNullability == Nullability::Nonnull) {
834     NullConstraint Nullness = getNullConstraint(*RegionSVal, State);
835     if (Nullness == NullConstraint::IsNull) {
836       State = State->set<NullabilityMap>(Region, Nullability::Contradicted);
837       C.addTransition(State);
838       return;
839     }
840   }
841 
842   const NullabilityState *TrackedNullability =
843       State->get<NullabilityMap>(Region);
844 
845   if (!TrackedNullability) {
846     if (DestNullability != Nullability::Nullable)
847       return;
848     State = State->set<NullabilityMap>(Region,
849                                        NullabilityState(DestNullability, CE));
850     C.addTransition(State);
851     return;
852   }
853 
854   if (TrackedNullability->getValue() != DestNullability &&
855       TrackedNullability->getValue() != Nullability::Contradicted) {
856     State = State->set<NullabilityMap>(Region, Nullability::Contradicted);
857     C.addTransition(State);
858   }
859 }
860 
861 /// Propagate the nullability information through binds and warn when nullable
862 /// pointer or null symbol is assigned to a pointer with a nonnull type.
863 void NullabilityChecker::checkBind(SVal L, SVal V, const Stmt *S,
864                                    CheckerContext &C) const {
865   const TypedValueRegion *TVR =
866       dyn_cast_or_null<TypedValueRegion>(L.getAsRegion());
867   if (!TVR)
868     return;
869 
870   QualType LocType = TVR->getValueType();
871   if (!LocType->isAnyPointerType())
872     return;
873 
874   ProgramStateRef State = C.getState();
875   if (State->get<PreconditionViolated>())
876     return;
877 
878   auto ValDefOrUnknown = V.getAs<DefinedOrUnknownSVal>();
879   if (!ValDefOrUnknown)
880     return;
881 
882   NullConstraint RhsNullness = getNullConstraint(*ValDefOrUnknown, State);
883 
884   Nullability ValNullability = Nullability::Unspecified;
885   if (SymbolRef Sym = ValDefOrUnknown->getAsSymbol())
886     ValNullability = getNullabilityAnnotation(Sym->getType());
887 
888   Nullability LocNullability = getNullabilityAnnotation(LocType);
889   if (Filter.CheckNullPassedToNonnull &&
890       RhsNullness == NullConstraint::IsNull &&
891       ValNullability != Nullability::Nonnull &&
892       LocNullability == Nullability::Nonnull) {
893     static CheckerProgramPointTag Tag(this, "NullPassedToNonnull");
894     ExplodedNode *N = C.generateSink(State, C.getPredecessor(), &Tag);
895     reportBugIfPreconditionHolds(ErrorKind::NilAssignedToNonnull, N, nullptr, C,
896                                  S);
897     return;
898   }
899   // Intentionally missing case: '0' is bound to a reference. It is handled by
900   // the DereferenceChecker.
901 
902   const MemRegion *ValueRegion = getTrackRegion(*ValDefOrUnknown);
903   if (!ValueRegion)
904     return;
905 
906   const NullabilityState *TrackedNullability =
907       State->get<NullabilityMap>(ValueRegion);
908 
909   if (TrackedNullability) {
910     if (RhsNullness == NullConstraint::IsNotNull ||
911         TrackedNullability->getValue() != Nullability::Nullable)
912       return;
913     if (Filter.CheckNullablePassedToNonnull &&
914         LocNullability == Nullability::Nonnull) {
915       static CheckerProgramPointTag Tag(this, "NullablePassedToNonnull");
916       ExplodedNode *N = C.addTransition(State, C.getPredecessor(), &Tag);
917       reportBugIfPreconditionHolds(ErrorKind::NullableAssignedToNonnull, N,
918                                    ValueRegion, C);
919     }
920     return;
921   }
922 
923   const auto *BinOp = dyn_cast<BinaryOperator>(S);
924 
925   if (ValNullability == Nullability::Nullable) {
926     // Trust the static information of the value more than the static
927     // information on the location.
928     const Stmt *NullabilitySource = BinOp ? BinOp->getRHS() : S;
929     State = State->set<NullabilityMap>(
930         ValueRegion, NullabilityState(ValNullability, NullabilitySource));
931     C.addTransition(State);
932     return;
933   }
934 
935   if (LocNullability == Nullability::Nullable) {
936     const Stmt *NullabilitySource = BinOp ? BinOp->getLHS() : S;
937     State = State->set<NullabilityMap>(
938         ValueRegion, NullabilityState(LocNullability, NullabilitySource));
939     C.addTransition(State);
940   }
941 }
942 
943 void NullabilityChecker::printState(raw_ostream &Out, ProgramStateRef State,
944                                     const char *NL, const char *Sep) const {
945 
946   NullabilityMapTy B = State->get<NullabilityMap>();
947 
948   if (B.isEmpty())
949     return;
950 
951   Out << Sep << NL;
952 
953   for (NullabilityMapTy::iterator I = B.begin(), E = B.end(); I != E; ++I) {
954     Out << I->first << " : ";
955     I->second.print(Out);
956     Out << NL;
957   }
958 }
959 
960 #define REGISTER_CHECKER(name, trackingRequired)                               \
961   void ento::register##name##Checker(CheckerManager &mgr) {                    \
962     NullabilityChecker *checker = mgr.registerChecker<NullabilityChecker>();   \
963     checker->Filter.Check##name = true;                                        \
964     checker->Filter.CheckName##name = mgr.getCurrentCheckName();               \
965     checker->NeedTracking = checker->NeedTracking || trackingRequired;         \
966   }
967 
968 // The checks are likely to be turned on by default and it is possible to do
969 // them without tracking any nullability related information. As an optimization
970 // no nullability information will be tracked when only these two checks are
971 // enables.
972 REGISTER_CHECKER(NullPassedToNonnull, false)
973 REGISTER_CHECKER(NullReturnedFromNonnull, false)
974 
975 REGISTER_CHECKER(NullableDereferenced, true)
976 REGISTER_CHECKER(NullablePassedToNonnull, true)
977 REGISTER_CHECKER(NullableReturnedFromNonnull, true)
978