1d99bd55aSTed Kremenek //=== CastSizeChecker.cpp ---------------------------------------*- C++ -*-===//
2d99bd55aSTed Kremenek //
3d99bd55aSTed Kremenek //                     The LLVM Compiler Infrastructure
4d99bd55aSTed Kremenek //
5d99bd55aSTed Kremenek // This file is distributed under the University of Illinois Open Source
6d99bd55aSTed Kremenek // License. See LICENSE.TXT for details.
7d99bd55aSTed Kremenek //
8d99bd55aSTed Kremenek //===----------------------------------------------------------------------===//
9d99bd55aSTed Kremenek //
10d99bd55aSTed Kremenek // CastSizeChecker checks when casting a malloc'ed symbolic region to type T,
11d99bd55aSTed Kremenek // whether the size of the symbolic region is a multiple of the size of T.
12d99bd55aSTed Kremenek //
13d99bd55aSTed Kremenek //===----------------------------------------------------------------------===//
148b089064SArgyrios Kyrtzidis #include "ClangSACheckers.h"
153a02247dSChandler Carruth #include "clang/AST/CharUnits.h"
163a02247dSChandler Carruth #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
176a5674ffSArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/Checker.h"
188b089064SArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/CheckerManager.h"
198b089064SArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
20d99bd55aSTed Kremenek 
21d99bd55aSTed Kremenek using namespace clang;
22d99bd55aSTed Kremenek using namespace ento;
23d99bd55aSTed Kremenek 
24d99bd55aSTed Kremenek namespace {
256a5674ffSArgyrios Kyrtzidis class CastSizeChecker : public Checker< check::PreStmt<CastExpr> > {
26b8984329SAhmed Charles   mutable std::unique_ptr<BuiltinBug> BT;
27b8984329SAhmed Charles 
28d99bd55aSTed Kremenek public:
298b089064SArgyrios Kyrtzidis   void checkPreStmt(const CastExpr *CE, CheckerContext &C) const;
30d99bd55aSTed Kremenek };
31d99bd55aSTed Kremenek }
32d99bd55aSTed Kremenek 
3397d2c9caSJordan Rose /// Check if we are casting to a struct with a flexible array at the end.
3497d2c9caSJordan Rose /// \code
3597d2c9caSJordan Rose /// struct foo {
3697d2c9caSJordan Rose ///   size_t len;
3797d2c9caSJordan Rose ///   struct bar data[];
3897d2c9caSJordan Rose /// };
3997d2c9caSJordan Rose /// \endcode
4097d2c9caSJordan Rose /// or
4197d2c9caSJordan Rose /// \code
4297d2c9caSJordan Rose /// struct foo {
4397d2c9caSJordan Rose ///   size_t len;
4497d2c9caSJordan Rose ///   struct bar data[0];
4597d2c9caSJordan Rose /// }
4697d2c9caSJordan Rose /// \endcode
4797d2c9caSJordan Rose /// In these cases it is also valid to allocate size of struct foo + a multiple
4897d2c9caSJordan Rose /// of struct bar.
4997d2c9caSJordan Rose static bool evenFlexibleArraySize(ASTContext &Ctx, CharUnits RegionSize,
5097d2c9caSJordan Rose                                   CharUnits TypeSize, QualType ToPointeeTy) {
5197d2c9caSJordan Rose   const RecordType *RT = ToPointeeTy->getAs<RecordType>();
5297d2c9caSJordan Rose   if (!RT)
5397d2c9caSJordan Rose     return false;
5497d2c9caSJordan Rose 
5597d2c9caSJordan Rose   const RecordDecl *RD = RT->getDecl();
5697d2c9caSJordan Rose   RecordDecl::field_iterator Iter(RD->field_begin());
5797d2c9caSJordan Rose   RecordDecl::field_iterator End(RD->field_end());
580dbb783cSCraig Topper   const FieldDecl *Last = nullptr;
5997d2c9caSJordan Rose   for (; Iter != End; ++Iter)
6097d2c9caSJordan Rose     Last = *Iter;
6197d2c9caSJordan Rose   assert(Last && "empty structs should already be handled");
6297d2c9caSJordan Rose 
6397d2c9caSJordan Rose   const Type *ElemType = Last->getType()->getArrayElementTypeNoTypeQual();
6497d2c9caSJordan Rose   CharUnits FlexSize;
6597d2c9caSJordan Rose   if (const ConstantArrayType *ArrayTy =
6697d2c9caSJordan Rose         Ctx.getAsConstantArrayType(Last->getType())) {
6797d2c9caSJordan Rose     FlexSize = Ctx.getTypeSizeInChars(ElemType);
6897d2c9caSJordan Rose     if (ArrayTy->getSize() == 1 && TypeSize > FlexSize)
6997d2c9caSJordan Rose       TypeSize -= FlexSize;
7097d2c9caSJordan Rose     else if (ArrayTy->getSize() != 0)
7197d2c9caSJordan Rose       return false;
7297d2c9caSJordan Rose   } else if (RD->hasFlexibleArrayMember()) {
7397d2c9caSJordan Rose     FlexSize = Ctx.getTypeSizeInChars(ElemType);
7497d2c9caSJordan Rose   } else {
7597d2c9caSJordan Rose     return false;
7697d2c9caSJordan Rose   }
7797d2c9caSJordan Rose 
7897d2c9caSJordan Rose   if (FlexSize.isZero())
7997d2c9caSJordan Rose     return false;
8097d2c9caSJordan Rose 
8197d2c9caSJordan Rose   CharUnits Left = RegionSize - TypeSize;
8297d2c9caSJordan Rose   if (Left.isNegative())
8397d2c9caSJordan Rose     return false;
8497d2c9caSJordan Rose 
859c10490eSAlexander Kornienko   return Left % FlexSize == 0;
8697d2c9caSJordan Rose }
8797d2c9caSJordan Rose 
888b089064SArgyrios Kyrtzidis void CastSizeChecker::checkPreStmt(const CastExpr *CE,CheckerContext &C) const {
89d99bd55aSTed Kremenek   const Expr *E = CE->getSubExpr();
90d99bd55aSTed Kremenek   ASTContext &Ctx = C.getASTContext();
91d99bd55aSTed Kremenek   QualType ToTy = Ctx.getCanonicalType(CE->getType());
92424cec97SJohn McCall   const PointerType *ToPTy = dyn_cast<PointerType>(ToTy.getTypePtr());
93d99bd55aSTed Kremenek 
94d99bd55aSTed Kremenek   if (!ToPTy)
95d99bd55aSTed Kremenek     return;
96d99bd55aSTed Kremenek 
97d99bd55aSTed Kremenek   QualType ToPointeeTy = ToPTy->getPointeeType();
98d99bd55aSTed Kremenek 
99d99bd55aSTed Kremenek   // Only perform the check if 'ToPointeeTy' is a complete type.
100d99bd55aSTed Kremenek   if (ToPointeeTy->isIncompleteType())
101d99bd55aSTed Kremenek     return;
102d99bd55aSTed Kremenek 
10349b1e38eSTed Kremenek   ProgramStateRef state = C.getState();
104632e3b7eSTed Kremenek   const MemRegion *R = state->getSVal(E, C.getLocationContext()).getAsRegion();
1050dbb783cSCraig Topper   if (!R)
106d99bd55aSTed Kremenek     return;
107d99bd55aSTed Kremenek 
108d99bd55aSTed Kremenek   const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R);
1090dbb783cSCraig Topper   if (!SR)
110d99bd55aSTed Kremenek     return;
111d99bd55aSTed Kremenek 
112d99bd55aSTed Kremenek   SValBuilder &svalBuilder = C.getSValBuilder();
113d99bd55aSTed Kremenek   SVal extent = SR->getExtent(svalBuilder);
114d99bd55aSTed Kremenek   const llvm::APSInt *extentInt = svalBuilder.getKnownValue(state, extent);
115d99bd55aSTed Kremenek   if (!extentInt)
116d99bd55aSTed Kremenek     return;
117d99bd55aSTed Kremenek 
118d99bd55aSTed Kremenek   CharUnits regionSize = CharUnits::fromQuantity(extentInt->getSExtValue());
119d99bd55aSTed Kremenek   CharUnits typeSize = C.getASTContext().getTypeSizeInChars(ToPointeeTy);
120d99bd55aSTed Kremenek 
121d99bd55aSTed Kremenek   // Ignore void, and a few other un-sizeable types.
122d99bd55aSTed Kremenek   if (typeSize.isZero())
123d99bd55aSTed Kremenek     return;
124d99bd55aSTed Kremenek 
12597d2c9caSJordan Rose   if (regionSize % typeSize == 0)
12697d2c9caSJordan Rose     return;
12797d2c9caSJordan Rose 
12897d2c9caSJordan Rose   if (evenFlexibleArraySize(Ctx, regionSize, typeSize, ToPointeeTy))
12997d2c9caSJordan Rose     return;
13097d2c9caSJordan Rose 
131e39bd407SDevin Coughlin   if (ExplodedNode *errorNode = C.generateErrorNode()) {
132d99bd55aSTed Kremenek     if (!BT)
13397d2c9caSJordan Rose       BT.reset(new BuiltinBug(this, "Cast region with wrong size.",
13497d2c9caSJordan Rose                                     "Cast a region whose size is not a multiple"
13597d2c9caSJordan Rose                                     " of the destination type size."));
1368d3a7a56SAaron Ballman     auto R = llvm::make_unique<BugReport>(*BT, BT->getDescription(), errorNode);
137d99bd55aSTed Kremenek     R->addRange(CE->getSourceRange());
1388d3a7a56SAaron Ballman     C.emitReport(std::move(R));
139d99bd55aSTed Kremenek   }
140d99bd55aSTed Kremenek }
141d99bd55aSTed Kremenek 
1428b089064SArgyrios Kyrtzidis void ento::registerCastSizeChecker(CheckerManager &mgr) {
143*d69e0129SArtem Dergachev   // PR31226: C++ is more complicated than what this checker currently supports.
144*d69e0129SArtem Dergachev   // There are derived-to-base casts, there are different rules for 0-size
145*d69e0129SArtem Dergachev   // structures, no flexible arrays, etc.
146*d69e0129SArtem Dergachev   // FIXME: Disabled on C++ for now.
147*d69e0129SArtem Dergachev   if (!mgr.getLangOpts().CPlusPlus)
1488b089064SArgyrios Kyrtzidis     mgr.registerChecker<CastSizeChecker>();
149d99bd55aSTed Kremenek }
150