1d99bd55aSTed Kremenek //=== CastSizeChecker.cpp ---------------------------------------*- C++ -*-===// 2d99bd55aSTed Kremenek // 32946cd70SChandler Carruth // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 42946cd70SChandler Carruth // See https://llvm.org/LICENSE.txt for license information. 52946cd70SChandler Carruth // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6d99bd55aSTed Kremenek // 7d99bd55aSTed Kremenek //===----------------------------------------------------------------------===// 8d99bd55aSTed Kremenek // 9d99bd55aSTed Kremenek // CastSizeChecker checks when casting a malloc'ed symbolic region to type T, 10d99bd55aSTed Kremenek // whether the size of the symbolic region is a multiple of the size of T. 11d99bd55aSTed Kremenek // 12d99bd55aSTed Kremenek //===----------------------------------------------------------------------===// 13*601687bfSCharusso 143a02247dSChandler Carruth #include "clang/AST/CharUnits.h" 15*601687bfSCharusso #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" 163a02247dSChandler Carruth #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" 176a5674ffSArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/Checker.h" 188b089064SArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/CheckerManager.h" 198b089064SArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" 20*601687bfSCharusso #include "clang/StaticAnalyzer/Core/PathSensitive/DynamicSize.h" 21d99bd55aSTed Kremenek 22d99bd55aSTed Kremenek using namespace clang; 23d99bd55aSTed Kremenek using namespace ento; 24d99bd55aSTed Kremenek 25d99bd55aSTed Kremenek namespace { 266a5674ffSArgyrios Kyrtzidis class CastSizeChecker : public Checker< check::PreStmt<CastExpr> > { 27b8984329SAhmed Charles mutable std::unique_ptr<BuiltinBug> BT; 28b8984329SAhmed Charles 29d99bd55aSTed Kremenek public: 308b089064SArgyrios Kyrtzidis void checkPreStmt(const CastExpr *CE, CheckerContext &C) const; 31d99bd55aSTed Kremenek }; 32d99bd55aSTed Kremenek } 33d99bd55aSTed Kremenek 3497d2c9caSJordan Rose /// Check if we are casting to a struct with a flexible array at the end. 3597d2c9caSJordan Rose /// \code 3697d2c9caSJordan Rose /// struct foo { 3797d2c9caSJordan Rose /// size_t len; 3897d2c9caSJordan Rose /// struct bar data[]; 3997d2c9caSJordan Rose /// }; 4097d2c9caSJordan Rose /// \endcode 4197d2c9caSJordan Rose /// or 4297d2c9caSJordan Rose /// \code 4397d2c9caSJordan Rose /// struct foo { 4497d2c9caSJordan Rose /// size_t len; 4597d2c9caSJordan Rose /// struct bar data[0]; 4697d2c9caSJordan Rose /// } 4797d2c9caSJordan Rose /// \endcode 4897d2c9caSJordan Rose /// In these cases it is also valid to allocate size of struct foo + a multiple 4997d2c9caSJordan Rose /// of struct bar. 5097d2c9caSJordan Rose static bool evenFlexibleArraySize(ASTContext &Ctx, CharUnits RegionSize, 5197d2c9caSJordan Rose CharUnits TypeSize, QualType ToPointeeTy) { 5297d2c9caSJordan Rose const RecordType *RT = ToPointeeTy->getAs<RecordType>(); 5397d2c9caSJordan Rose if (!RT) 5497d2c9caSJordan Rose return false; 5597d2c9caSJordan Rose 5697d2c9caSJordan Rose const RecordDecl *RD = RT->getDecl(); 5797d2c9caSJordan Rose RecordDecl::field_iterator Iter(RD->field_begin()); 5897d2c9caSJordan Rose RecordDecl::field_iterator End(RD->field_end()); 590dbb783cSCraig Topper const FieldDecl *Last = nullptr; 6097d2c9caSJordan Rose for (; Iter != End; ++Iter) 6197d2c9caSJordan Rose Last = *Iter; 6297d2c9caSJordan Rose assert(Last && "empty structs should already be handled"); 6397d2c9caSJordan Rose 6497d2c9caSJordan Rose const Type *ElemType = Last->getType()->getArrayElementTypeNoTypeQual(); 6597d2c9caSJordan Rose CharUnits FlexSize; 6697d2c9caSJordan Rose if (const ConstantArrayType *ArrayTy = 6797d2c9caSJordan Rose Ctx.getAsConstantArrayType(Last->getType())) { 6897d2c9caSJordan Rose FlexSize = Ctx.getTypeSizeInChars(ElemType); 6997d2c9caSJordan Rose if (ArrayTy->getSize() == 1 && TypeSize > FlexSize) 7097d2c9caSJordan Rose TypeSize -= FlexSize; 7197d2c9caSJordan Rose else if (ArrayTy->getSize() != 0) 7297d2c9caSJordan Rose return false; 7397d2c9caSJordan Rose } else if (RD->hasFlexibleArrayMember()) { 7497d2c9caSJordan Rose FlexSize = Ctx.getTypeSizeInChars(ElemType); 7597d2c9caSJordan Rose } else { 7697d2c9caSJordan Rose return false; 7797d2c9caSJordan Rose } 7897d2c9caSJordan Rose 7997d2c9caSJordan Rose if (FlexSize.isZero()) 8097d2c9caSJordan Rose return false; 8197d2c9caSJordan Rose 8297d2c9caSJordan Rose CharUnits Left = RegionSize - TypeSize; 8397d2c9caSJordan Rose if (Left.isNegative()) 8497d2c9caSJordan Rose return false; 8597d2c9caSJordan Rose 869c10490eSAlexander Kornienko return Left % FlexSize == 0; 8797d2c9caSJordan Rose } 8897d2c9caSJordan Rose 898b089064SArgyrios Kyrtzidis void CastSizeChecker::checkPreStmt(const CastExpr *CE,CheckerContext &C) const { 90d99bd55aSTed Kremenek const Expr *E = CE->getSubExpr(); 91d99bd55aSTed Kremenek ASTContext &Ctx = C.getASTContext(); 92d99bd55aSTed Kremenek QualType ToTy = Ctx.getCanonicalType(CE->getType()); 93424cec97SJohn McCall const PointerType *ToPTy = dyn_cast<PointerType>(ToTy.getTypePtr()); 94d99bd55aSTed Kremenek 95d99bd55aSTed Kremenek if (!ToPTy) 96d99bd55aSTed Kremenek return; 97d99bd55aSTed Kremenek 98d99bd55aSTed Kremenek QualType ToPointeeTy = ToPTy->getPointeeType(); 99d99bd55aSTed Kremenek 100d99bd55aSTed Kremenek // Only perform the check if 'ToPointeeTy' is a complete type. 101d99bd55aSTed Kremenek if (ToPointeeTy->isIncompleteType()) 102d99bd55aSTed Kremenek return; 103d99bd55aSTed Kremenek 10449b1e38eSTed Kremenek ProgramStateRef state = C.getState(); 105d703ec94SGeorge Karpenkov const MemRegion *R = C.getSVal(E).getAsRegion(); 1060dbb783cSCraig Topper if (!R) 107d99bd55aSTed Kremenek return; 108d99bd55aSTed Kremenek 109d99bd55aSTed Kremenek const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); 1100dbb783cSCraig Topper if (!SR) 111d99bd55aSTed Kremenek return; 112d99bd55aSTed Kremenek 113d99bd55aSTed Kremenek SValBuilder &svalBuilder = C.getSValBuilder(); 114*601687bfSCharusso 115*601687bfSCharusso DefinedOrUnknownSVal Size = getDynamicSize(state, SR, svalBuilder); 116*601687bfSCharusso const llvm::APSInt *SizeInt = svalBuilder.getKnownValue(state, Size); 117*601687bfSCharusso if (!SizeInt) 118d99bd55aSTed Kremenek return; 119d99bd55aSTed Kremenek 120*601687bfSCharusso CharUnits regionSize = CharUnits::fromQuantity(SizeInt->getZExtValue()); 121d99bd55aSTed Kremenek CharUnits typeSize = C.getASTContext().getTypeSizeInChars(ToPointeeTy); 122d99bd55aSTed Kremenek 123d99bd55aSTed Kremenek // Ignore void, and a few other un-sizeable types. 124d99bd55aSTed Kremenek if (typeSize.isZero()) 125d99bd55aSTed Kremenek return; 126d99bd55aSTed Kremenek 12797d2c9caSJordan Rose if (regionSize % typeSize == 0) 12897d2c9caSJordan Rose return; 12997d2c9caSJordan Rose 13097d2c9caSJordan Rose if (evenFlexibleArraySize(Ctx, regionSize, typeSize, ToPointeeTy)) 13197d2c9caSJordan Rose return; 13297d2c9caSJordan Rose 133e39bd407SDevin Coughlin if (ExplodedNode *errorNode = C.generateErrorNode()) { 134d99bd55aSTed Kremenek if (!BT) 13597d2c9caSJordan Rose BT.reset(new BuiltinBug(this, "Cast region with wrong size.", 13697d2c9caSJordan Rose "Cast a region whose size is not a multiple" 13797d2c9caSJordan Rose " of the destination type size.")); 1382f169e7cSArtem Dergachev auto R = std::make_unique<PathSensitiveBugReport>(*BT, BT->getDescription(), 1392f169e7cSArtem Dergachev errorNode); 140d99bd55aSTed Kremenek R->addRange(CE->getSourceRange()); 1418d3a7a56SAaron Ballman C.emitReport(std::move(R)); 142d99bd55aSTed Kremenek } 143d99bd55aSTed Kremenek } 144d99bd55aSTed Kremenek 1458b089064SArgyrios Kyrtzidis void ento::registerCastSizeChecker(CheckerManager &mgr) { 146058a7a45SKristof Umann mgr.registerChecker<CastSizeChecker>(); 147058a7a45SKristof Umann } 148058a7a45SKristof Umann 149058a7a45SKristof Umann bool ento::shouldRegisterCastSizeChecker(const LangOptions &LO) { 150d69e0129SArtem Dergachev // PR31226: C++ is more complicated than what this checker currently supports. 151d69e0129SArtem Dergachev // There are derived-to-base casts, there are different rules for 0-size 152d69e0129SArtem Dergachev // structures, no flexible arrays, etc. 153d69e0129SArtem Dergachev // FIXME: Disabled on C++ for now. 154058a7a45SKristof Umann return !LO.CPlusPlus; 155d99bd55aSTed Kremenek } 156