1d99bd55aSTed Kremenek //=== CastSizeChecker.cpp ---------------------------------------*- C++ -*-===// 2d99bd55aSTed Kremenek // 3*2946cd70SChandler Carruth // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4*2946cd70SChandler Carruth // See https://llvm.org/LICENSE.txt for license information. 5*2946cd70SChandler Carruth // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6d99bd55aSTed Kremenek // 7d99bd55aSTed Kremenek //===----------------------------------------------------------------------===// 8d99bd55aSTed Kremenek // 9d99bd55aSTed Kremenek // CastSizeChecker checks when casting a malloc'ed symbolic region to type T, 10d99bd55aSTed Kremenek // whether the size of the symbolic region is a multiple of the size of T. 11d99bd55aSTed Kremenek // 12d99bd55aSTed Kremenek //===----------------------------------------------------------------------===// 1376a21502SKristof Umann #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h" 143a02247dSChandler Carruth #include "clang/AST/CharUnits.h" 153a02247dSChandler Carruth #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h" 166a5674ffSArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/Checker.h" 178b089064SArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/CheckerManager.h" 188b089064SArgyrios Kyrtzidis #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h" 19d99bd55aSTed Kremenek 20d99bd55aSTed Kremenek using namespace clang; 21d99bd55aSTed Kremenek using namespace ento; 22d99bd55aSTed Kremenek 23d99bd55aSTed Kremenek namespace { 246a5674ffSArgyrios Kyrtzidis class CastSizeChecker : public Checker< check::PreStmt<CastExpr> > { 25b8984329SAhmed Charles mutable std::unique_ptr<BuiltinBug> BT; 26b8984329SAhmed Charles 27d99bd55aSTed Kremenek public: 288b089064SArgyrios Kyrtzidis void checkPreStmt(const CastExpr *CE, CheckerContext &C) const; 29d99bd55aSTed Kremenek }; 30d99bd55aSTed Kremenek } 31d99bd55aSTed Kremenek 3297d2c9caSJordan Rose /// Check if we are casting to a struct with a flexible array at the end. 3397d2c9caSJordan Rose /// \code 3497d2c9caSJordan Rose /// struct foo { 3597d2c9caSJordan Rose /// size_t len; 3697d2c9caSJordan Rose /// struct bar data[]; 3797d2c9caSJordan Rose /// }; 3897d2c9caSJordan Rose /// \endcode 3997d2c9caSJordan Rose /// or 4097d2c9caSJordan Rose /// \code 4197d2c9caSJordan Rose /// struct foo { 4297d2c9caSJordan Rose /// size_t len; 4397d2c9caSJordan Rose /// struct bar data[0]; 4497d2c9caSJordan Rose /// } 4597d2c9caSJordan Rose /// \endcode 4697d2c9caSJordan Rose /// In these cases it is also valid to allocate size of struct foo + a multiple 4797d2c9caSJordan Rose /// of struct bar. 4897d2c9caSJordan Rose static bool evenFlexibleArraySize(ASTContext &Ctx, CharUnits RegionSize, 4997d2c9caSJordan Rose CharUnits TypeSize, QualType ToPointeeTy) { 5097d2c9caSJordan Rose const RecordType *RT = ToPointeeTy->getAs<RecordType>(); 5197d2c9caSJordan Rose if (!RT) 5297d2c9caSJordan Rose return false; 5397d2c9caSJordan Rose 5497d2c9caSJordan Rose const RecordDecl *RD = RT->getDecl(); 5597d2c9caSJordan Rose RecordDecl::field_iterator Iter(RD->field_begin()); 5697d2c9caSJordan Rose RecordDecl::field_iterator End(RD->field_end()); 570dbb783cSCraig Topper const FieldDecl *Last = nullptr; 5897d2c9caSJordan Rose for (; Iter != End; ++Iter) 5997d2c9caSJordan Rose Last = *Iter; 6097d2c9caSJordan Rose assert(Last && "empty structs should already be handled"); 6197d2c9caSJordan Rose 6297d2c9caSJordan Rose const Type *ElemType = Last->getType()->getArrayElementTypeNoTypeQual(); 6397d2c9caSJordan Rose CharUnits FlexSize; 6497d2c9caSJordan Rose if (const ConstantArrayType *ArrayTy = 6597d2c9caSJordan Rose Ctx.getAsConstantArrayType(Last->getType())) { 6697d2c9caSJordan Rose FlexSize = Ctx.getTypeSizeInChars(ElemType); 6797d2c9caSJordan Rose if (ArrayTy->getSize() == 1 && TypeSize > FlexSize) 6897d2c9caSJordan Rose TypeSize -= FlexSize; 6997d2c9caSJordan Rose else if (ArrayTy->getSize() != 0) 7097d2c9caSJordan Rose return false; 7197d2c9caSJordan Rose } else if (RD->hasFlexibleArrayMember()) { 7297d2c9caSJordan Rose FlexSize = Ctx.getTypeSizeInChars(ElemType); 7397d2c9caSJordan Rose } else { 7497d2c9caSJordan Rose return false; 7597d2c9caSJordan Rose } 7697d2c9caSJordan Rose 7797d2c9caSJordan Rose if (FlexSize.isZero()) 7897d2c9caSJordan Rose return false; 7997d2c9caSJordan Rose 8097d2c9caSJordan Rose CharUnits Left = RegionSize - TypeSize; 8197d2c9caSJordan Rose if (Left.isNegative()) 8297d2c9caSJordan Rose return false; 8397d2c9caSJordan Rose 849c10490eSAlexander Kornienko return Left % FlexSize == 0; 8597d2c9caSJordan Rose } 8697d2c9caSJordan Rose 878b089064SArgyrios Kyrtzidis void CastSizeChecker::checkPreStmt(const CastExpr *CE,CheckerContext &C) const { 88d99bd55aSTed Kremenek const Expr *E = CE->getSubExpr(); 89d99bd55aSTed Kremenek ASTContext &Ctx = C.getASTContext(); 90d99bd55aSTed Kremenek QualType ToTy = Ctx.getCanonicalType(CE->getType()); 91424cec97SJohn McCall const PointerType *ToPTy = dyn_cast<PointerType>(ToTy.getTypePtr()); 92d99bd55aSTed Kremenek 93d99bd55aSTed Kremenek if (!ToPTy) 94d99bd55aSTed Kremenek return; 95d99bd55aSTed Kremenek 96d99bd55aSTed Kremenek QualType ToPointeeTy = ToPTy->getPointeeType(); 97d99bd55aSTed Kremenek 98d99bd55aSTed Kremenek // Only perform the check if 'ToPointeeTy' is a complete type. 99d99bd55aSTed Kremenek if (ToPointeeTy->isIncompleteType()) 100d99bd55aSTed Kremenek return; 101d99bd55aSTed Kremenek 10249b1e38eSTed Kremenek ProgramStateRef state = C.getState(); 103d703ec94SGeorge Karpenkov const MemRegion *R = C.getSVal(E).getAsRegion(); 1040dbb783cSCraig Topper if (!R) 105d99bd55aSTed Kremenek return; 106d99bd55aSTed Kremenek 107d99bd55aSTed Kremenek const SymbolicRegion *SR = dyn_cast<SymbolicRegion>(R); 1080dbb783cSCraig Topper if (!SR) 109d99bd55aSTed Kremenek return; 110d99bd55aSTed Kremenek 111d99bd55aSTed Kremenek SValBuilder &svalBuilder = C.getSValBuilder(); 112d99bd55aSTed Kremenek SVal extent = SR->getExtent(svalBuilder); 113d99bd55aSTed Kremenek const llvm::APSInt *extentInt = svalBuilder.getKnownValue(state, extent); 114d99bd55aSTed Kremenek if (!extentInt) 115d99bd55aSTed Kremenek return; 116d99bd55aSTed Kremenek 117d99bd55aSTed Kremenek CharUnits regionSize = CharUnits::fromQuantity(extentInt->getSExtValue()); 118d99bd55aSTed Kremenek CharUnits typeSize = C.getASTContext().getTypeSizeInChars(ToPointeeTy); 119d99bd55aSTed Kremenek 120d99bd55aSTed Kremenek // Ignore void, and a few other un-sizeable types. 121d99bd55aSTed Kremenek if (typeSize.isZero()) 122d99bd55aSTed Kremenek return; 123d99bd55aSTed Kremenek 12497d2c9caSJordan Rose if (regionSize % typeSize == 0) 12597d2c9caSJordan Rose return; 12697d2c9caSJordan Rose 12797d2c9caSJordan Rose if (evenFlexibleArraySize(Ctx, regionSize, typeSize, ToPointeeTy)) 12897d2c9caSJordan Rose return; 12997d2c9caSJordan Rose 130e39bd407SDevin Coughlin if (ExplodedNode *errorNode = C.generateErrorNode()) { 131d99bd55aSTed Kremenek if (!BT) 13297d2c9caSJordan Rose BT.reset(new BuiltinBug(this, "Cast region with wrong size.", 13397d2c9caSJordan Rose "Cast a region whose size is not a multiple" 13497d2c9caSJordan Rose " of the destination type size.")); 1358d3a7a56SAaron Ballman auto R = llvm::make_unique<BugReport>(*BT, BT->getDescription(), errorNode); 136d99bd55aSTed Kremenek R->addRange(CE->getSourceRange()); 1378d3a7a56SAaron Ballman C.emitReport(std::move(R)); 138d99bd55aSTed Kremenek } 139d99bd55aSTed Kremenek } 140d99bd55aSTed Kremenek 1418b089064SArgyrios Kyrtzidis void ento::registerCastSizeChecker(CheckerManager &mgr) { 142d69e0129SArtem Dergachev // PR31226: C++ is more complicated than what this checker currently supports. 143d69e0129SArtem Dergachev // There are derived-to-base casts, there are different rules for 0-size 144d69e0129SArtem Dergachev // structures, no flexible arrays, etc. 145d69e0129SArtem Dergachev // FIXME: Disabled on C++ for now. 146d69e0129SArtem Dergachev if (!mgr.getLangOpts().CPlusPlus) 1478b089064SArgyrios Kyrtzidis mgr.registerChecker<CastSizeChecker>(); 148d99bd55aSTed Kremenek } 149