1 //===--- SemaExprMember.cpp - Semantic Analysis for Expressions -----------===//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 //
10 //  This file implements semantic analysis member access expressions.
11 //
12 //===----------------------------------------------------------------------===//
13 #include "clang/Sema/Overload.h"
14 #include "clang/AST/ASTLambda.h"
15 #include "clang/AST/DeclCXX.h"
16 #include "clang/AST/DeclObjC.h"
17 #include "clang/AST/DeclTemplate.h"
18 #include "clang/AST/ExprCXX.h"
19 #include "clang/AST/ExprObjC.h"
20 #include "clang/Lex/Preprocessor.h"
21 #include "clang/Sema/Lookup.h"
22 #include "clang/Sema/Scope.h"
23 #include "clang/Sema/ScopeInfo.h"
24 #include "clang/Sema/SemaInternal.h"
25 
26 using namespace clang;
27 using namespace sema;
28 
29 typedef llvm::SmallPtrSet<const CXXRecordDecl*, 4> BaseSet;
30 
31 /// Determines if the given class is provably not derived from all of
32 /// the prospective base classes.
33 static bool isProvablyNotDerivedFrom(Sema &SemaRef, CXXRecordDecl *Record,
34                                      const BaseSet &Bases) {
35   auto BaseIsNotInSet = [&Bases](const CXXRecordDecl *Base) {
36     return !Bases.count(Base->getCanonicalDecl());
37   };
38   return BaseIsNotInSet(Record) && Record->forallBases(BaseIsNotInSet);
39 }
40 
41 enum IMAKind {
42   /// The reference is definitely not an instance member access.
43   IMA_Static,
44 
45   /// The reference may be an implicit instance member access.
46   IMA_Mixed,
47 
48   /// The reference may be to an instance member, but it might be invalid if
49   /// so, because the context is not an instance method.
50   IMA_Mixed_StaticContext,
51 
52   /// The reference may be to an instance member, but it is invalid if
53   /// so, because the context is from an unrelated class.
54   IMA_Mixed_Unrelated,
55 
56   /// The reference is definitely an implicit instance member access.
57   IMA_Instance,
58 
59   /// The reference may be to an unresolved using declaration.
60   IMA_Unresolved,
61 
62   /// The reference is a contextually-permitted abstract member reference.
63   IMA_Abstract,
64 
65   /// The reference may be to an unresolved using declaration and the
66   /// context is not an instance method.
67   IMA_Unresolved_StaticContext,
68 
69   // The reference refers to a field which is not a member of the containing
70   // class, which is allowed because we're in C++11 mode and the context is
71   // unevaluated.
72   IMA_Field_Uneval_Context,
73 
74   /// All possible referrents are instance members and the current
75   /// context is not an instance method.
76   IMA_Error_StaticContext,
77 
78   /// All possible referrents are instance members of an unrelated
79   /// class.
80   IMA_Error_Unrelated
81 };
82 
83 /// The given lookup names class member(s) and is not being used for
84 /// an address-of-member expression.  Classify the type of access
85 /// according to whether it's possible that this reference names an
86 /// instance member.  This is best-effort in dependent contexts; it is okay to
87 /// conservatively answer "yes", in which case some errors will simply
88 /// not be caught until template-instantiation.
89 static IMAKind ClassifyImplicitMemberAccess(Sema &SemaRef,
90                                             const LookupResult &R) {
91   assert(!R.empty() && (*R.begin())->isCXXClassMember());
92 
93   DeclContext *DC = SemaRef.getFunctionLevelDeclContext();
94 
95   bool isStaticContext = SemaRef.CXXThisTypeOverride.isNull() &&
96     (!isa<CXXMethodDecl>(DC) || cast<CXXMethodDecl>(DC)->isStatic());
97 
98   if (R.isUnresolvableResult())
99     return isStaticContext ? IMA_Unresolved_StaticContext : IMA_Unresolved;
100 
101   // Collect all the declaring classes of instance members we find.
102   bool hasNonInstance = false;
103   bool isField = false;
104   BaseSet Classes;
105   for (NamedDecl *D : R) {
106     // Look through any using decls.
107     D = D->getUnderlyingDecl();
108 
109     if (D->isCXXInstanceMember()) {
110       isField |= isa<FieldDecl>(D) || isa<MSPropertyDecl>(D) ||
111                  isa<IndirectFieldDecl>(D);
112 
113       CXXRecordDecl *R = cast<CXXRecordDecl>(D->getDeclContext());
114       Classes.insert(R->getCanonicalDecl());
115     } else
116       hasNonInstance = true;
117   }
118 
119   // If we didn't find any instance members, it can't be an implicit
120   // member reference.
121   if (Classes.empty())
122     return IMA_Static;
123 
124   // C++11 [expr.prim.general]p12:
125   //   An id-expression that denotes a non-static data member or non-static
126   //   member function of a class can only be used:
127   //   (...)
128   //   - if that id-expression denotes a non-static data member and it
129   //     appears in an unevaluated operand.
130   //
131   // This rule is specific to C++11.  However, we also permit this form
132   // in unevaluated inline assembly operands, like the operand to a SIZE.
133   IMAKind AbstractInstanceResult = IMA_Static; // happens to be 'false'
134   assert(!AbstractInstanceResult);
135   switch (SemaRef.ExprEvalContexts.back().Context) {
136   case Sema::ExpressionEvaluationContext::Unevaluated:
137   case Sema::ExpressionEvaluationContext::UnevaluatedList:
138     if (isField && SemaRef.getLangOpts().CPlusPlus11)
139       AbstractInstanceResult = IMA_Field_Uneval_Context;
140     break;
141 
142   case Sema::ExpressionEvaluationContext::UnevaluatedAbstract:
143     AbstractInstanceResult = IMA_Abstract;
144     break;
145 
146   case Sema::ExpressionEvaluationContext::DiscardedStatement:
147   case Sema::ExpressionEvaluationContext::ConstantEvaluated:
148   case Sema::ExpressionEvaluationContext::PotentiallyEvaluated:
149   case Sema::ExpressionEvaluationContext::PotentiallyEvaluatedIfUsed:
150     break;
151   }
152 
153   // If the current context is not an instance method, it can't be
154   // an implicit member reference.
155   if (isStaticContext) {
156     if (hasNonInstance)
157       return IMA_Mixed_StaticContext;
158 
159     return AbstractInstanceResult ? AbstractInstanceResult
160                                   : IMA_Error_StaticContext;
161   }
162 
163   CXXRecordDecl *contextClass;
164   if (CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(DC))
165     contextClass = MD->getParent()->getCanonicalDecl();
166   else
167     contextClass = cast<CXXRecordDecl>(DC);
168 
169   // [class.mfct.non-static]p3:
170   // ...is used in the body of a non-static member function of class X,
171   // if name lookup (3.4.1) resolves the name in the id-expression to a
172   // non-static non-type member of some class C [...]
173   // ...if C is not X or a base class of X, the class member access expression
174   // is ill-formed.
175   if (R.getNamingClass() &&
176       contextClass->getCanonicalDecl() !=
177         R.getNamingClass()->getCanonicalDecl()) {
178     // If the naming class is not the current context, this was a qualified
179     // member name lookup, and it's sufficient to check that we have the naming
180     // class as a base class.
181     Classes.clear();
182     Classes.insert(R.getNamingClass()->getCanonicalDecl());
183   }
184 
185   // If we can prove that the current context is unrelated to all the
186   // declaring classes, it can't be an implicit member reference (in
187   // which case it's an error if any of those members are selected).
188   if (isProvablyNotDerivedFrom(SemaRef, contextClass, Classes))
189     return hasNonInstance ? IMA_Mixed_Unrelated :
190            AbstractInstanceResult ? AbstractInstanceResult :
191                                     IMA_Error_Unrelated;
192 
193   return (hasNonInstance ? IMA_Mixed : IMA_Instance);
194 }
195 
196 /// Diagnose a reference to a field with no object available.
197 static void diagnoseInstanceReference(Sema &SemaRef,
198                                       const CXXScopeSpec &SS,
199                                       NamedDecl *Rep,
200                                       const DeclarationNameInfo &nameInfo) {
201   SourceLocation Loc = nameInfo.getLoc();
202   SourceRange Range(Loc);
203   if (SS.isSet()) Range.setBegin(SS.getRange().getBegin());
204 
205   // Look through using shadow decls and aliases.
206   Rep = Rep->getUnderlyingDecl();
207 
208   DeclContext *FunctionLevelDC = SemaRef.getFunctionLevelDeclContext();
209   CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(FunctionLevelDC);
210   CXXRecordDecl *ContextClass = Method ? Method->getParent() : nullptr;
211   CXXRecordDecl *RepClass = dyn_cast<CXXRecordDecl>(Rep->getDeclContext());
212 
213   bool InStaticMethod = Method && Method->isStatic();
214   bool IsField = isa<FieldDecl>(Rep) || isa<IndirectFieldDecl>(Rep);
215 
216   if (IsField && InStaticMethod)
217     // "invalid use of member 'x' in static member function"
218     SemaRef.Diag(Loc, diag::err_invalid_member_use_in_static_method)
219         << Range << nameInfo.getName();
220   else if (ContextClass && RepClass && SS.isEmpty() && !InStaticMethod &&
221            !RepClass->Equals(ContextClass) && RepClass->Encloses(ContextClass))
222     // Unqualified lookup in a non-static member function found a member of an
223     // enclosing class.
224     SemaRef.Diag(Loc, diag::err_nested_non_static_member_use)
225       << IsField << RepClass << nameInfo.getName() << ContextClass << Range;
226   else if (IsField)
227     SemaRef.Diag(Loc, diag::err_invalid_non_static_member_use)
228       << nameInfo.getName() << Range;
229   else
230     SemaRef.Diag(Loc, diag::err_member_call_without_object)
231       << Range;
232 }
233 
234 /// Builds an expression which might be an implicit member expression.
235 ExprResult
236 Sema::BuildPossibleImplicitMemberExpr(const CXXScopeSpec &SS,
237                                       SourceLocation TemplateKWLoc,
238                                       LookupResult &R,
239                                 const TemplateArgumentListInfo *TemplateArgs,
240                                       const Scope *S) {
241   switch (ClassifyImplicitMemberAccess(*this, R)) {
242   case IMA_Instance:
243     return BuildImplicitMemberExpr(SS, TemplateKWLoc, R, TemplateArgs, true, S);
244 
245   case IMA_Mixed:
246   case IMA_Mixed_Unrelated:
247   case IMA_Unresolved:
248     return BuildImplicitMemberExpr(SS, TemplateKWLoc, R, TemplateArgs, false,
249                                    S);
250 
251   case IMA_Field_Uneval_Context:
252     Diag(R.getNameLoc(), diag::warn_cxx98_compat_non_static_member_use)
253       << R.getLookupNameInfo().getName();
254     // Fall through.
255   case IMA_Static:
256   case IMA_Abstract:
257   case IMA_Mixed_StaticContext:
258   case IMA_Unresolved_StaticContext:
259     if (TemplateArgs || TemplateKWLoc.isValid())
260       return BuildTemplateIdExpr(SS, TemplateKWLoc, R, false, TemplateArgs);
261     return BuildDeclarationNameExpr(SS, R, false);
262 
263   case IMA_Error_StaticContext:
264   case IMA_Error_Unrelated:
265     diagnoseInstanceReference(*this, SS, R.getRepresentativeDecl(),
266                               R.getLookupNameInfo());
267     return ExprError();
268   }
269 
270   llvm_unreachable("unexpected instance member access kind");
271 }
272 
273 /// Determine whether input char is from rgba component set.
274 static bool
275 IsRGBA(char c) {
276   switch (c) {
277   case 'r':
278   case 'g':
279   case 'b':
280   case 'a':
281     return true;
282   default:
283     return false;
284   }
285 }
286 
287 // OpenCL v1.1, s6.1.7
288 // The component swizzle length must be in accordance with the acceptable
289 // vector sizes.
290 static bool IsValidOpenCLComponentSwizzleLength(unsigned len)
291 {
292   return (len >= 1 && len <= 4) || len == 8 || len == 16;
293 }
294 
295 /// Check an ext-vector component access expression.
296 ///
297 /// VK should be set in advance to the value kind of the base
298 /// expression.
299 static QualType
300 CheckExtVectorComponent(Sema &S, QualType baseType, ExprValueKind &VK,
301                         SourceLocation OpLoc, const IdentifierInfo *CompName,
302                         SourceLocation CompLoc) {
303   // FIXME: Share logic with ExtVectorElementExpr::containsDuplicateElements,
304   // see FIXME there.
305   //
306   // FIXME: This logic can be greatly simplified by splitting it along
307   // halving/not halving and reworking the component checking.
308   const ExtVectorType *vecType = baseType->getAs<ExtVectorType>();
309 
310   // The vector accessor can't exceed the number of elements.
311   const char *compStr = CompName->getNameStart();
312 
313   // This flag determines whether or not the component is one of the four
314   // special names that indicate a subset of exactly half the elements are
315   // to be selected.
316   bool HalvingSwizzle = false;
317 
318   // This flag determines whether or not CompName has an 's' char prefix,
319   // indicating that it is a string of hex values to be used as vector indices.
320   bool HexSwizzle = (*compStr == 's' || *compStr == 'S') && compStr[1];
321 
322   bool HasRepeated = false;
323   bool HasIndex[16] = {};
324 
325   int Idx;
326 
327   // Check that we've found one of the special components, or that the component
328   // names must come from the same set.
329   if (!strcmp(compStr, "hi") || !strcmp(compStr, "lo") ||
330       !strcmp(compStr, "even") || !strcmp(compStr, "odd")) {
331     HalvingSwizzle = true;
332   } else if (!HexSwizzle &&
333              (Idx = vecType->getPointAccessorIdx(*compStr)) != -1) {
334     bool HasRGBA = IsRGBA(*compStr);
335     do {
336       // Ensure that xyzw and rgba components don't intermingle.
337       if (HasRGBA != IsRGBA(*compStr))
338         break;
339       if (HasIndex[Idx]) HasRepeated = true;
340       HasIndex[Idx] = true;
341       compStr++;
342     } while (*compStr && (Idx = vecType->getPointAccessorIdx(*compStr)) != -1);
343 
344     // Emit a warning if an rgba selector is used earlier than OpenCL 2.2
345     if (HasRGBA || (*compStr && IsRGBA(*compStr))) {
346       if (S.getLangOpts().OpenCL && S.getLangOpts().OpenCLVersion < 220) {
347         const char *DiagBegin = HasRGBA ? CompName->getNameStart() : compStr;
348         S.Diag(OpLoc, diag::ext_opencl_ext_vector_type_rgba_selector)
349           << StringRef(DiagBegin, 1)
350           << S.getLangOpts().OpenCLVersion << SourceRange(CompLoc);
351       }
352     }
353   } else {
354     if (HexSwizzle) compStr++;
355     while ((Idx = vecType->getNumericAccessorIdx(*compStr)) != -1) {
356       if (HasIndex[Idx]) HasRepeated = true;
357       HasIndex[Idx] = true;
358       compStr++;
359     }
360   }
361 
362   if (!HalvingSwizzle && *compStr) {
363     // We didn't get to the end of the string. This means the component names
364     // didn't come from the same set *or* we encountered an illegal name.
365     S.Diag(OpLoc, diag::err_ext_vector_component_name_illegal)
366       << StringRef(compStr, 1) << SourceRange(CompLoc);
367     return QualType();
368   }
369 
370   // Ensure no component accessor exceeds the width of the vector type it
371   // operates on.
372   if (!HalvingSwizzle) {
373     compStr = CompName->getNameStart();
374 
375     if (HexSwizzle)
376       compStr++;
377 
378     while (*compStr) {
379       if (!vecType->isAccessorWithinNumElements(*compStr++, HexSwizzle)) {
380         S.Diag(OpLoc, diag::err_ext_vector_component_exceeds_length)
381           << baseType << SourceRange(CompLoc);
382         return QualType();
383       }
384     }
385   }
386 
387   if (!HalvingSwizzle) {
388     unsigned SwizzleLength = CompName->getLength();
389 
390     if (HexSwizzle)
391       SwizzleLength--;
392 
393     if (IsValidOpenCLComponentSwizzleLength(SwizzleLength) == false) {
394       S.Diag(OpLoc, diag::err_opencl_ext_vector_component_invalid_length)
395         << SwizzleLength << SourceRange(CompLoc);
396       return QualType();
397     }
398   }
399 
400   // The component accessor looks fine - now we need to compute the actual type.
401   // The vector type is implied by the component accessor. For example,
402   // vec4.b is a float, vec4.xy is a vec2, vec4.rgb is a vec3, etc.
403   // vec4.s0 is a float, vec4.s23 is a vec3, etc.
404   // vec4.hi, vec4.lo, vec4.e, and vec4.o all return vec2.
405   unsigned CompSize = HalvingSwizzle ? (vecType->getNumElements() + 1) / 2
406                                      : CompName->getLength();
407   if (HexSwizzle)
408     CompSize--;
409 
410   if (CompSize == 1)
411     return vecType->getElementType();
412 
413   if (HasRepeated) VK = VK_RValue;
414 
415   QualType VT = S.Context.getExtVectorType(vecType->getElementType(), CompSize);
416   // Now look up the TypeDefDecl from the vector type. Without this,
417   // diagostics look bad. We want extended vector types to appear built-in.
418   for (Sema::ExtVectorDeclsType::iterator
419          I = S.ExtVectorDecls.begin(S.getExternalSource()),
420          E = S.ExtVectorDecls.end();
421        I != E; ++I) {
422     if ((*I)->getUnderlyingType() == VT)
423       return S.Context.getTypedefType(*I);
424   }
425 
426   return VT; // should never get here (a typedef type should always be found).
427 }
428 
429 static Decl *FindGetterSetterNameDeclFromProtocolList(const ObjCProtocolDecl*PDecl,
430                                                 IdentifierInfo *Member,
431                                                 const Selector &Sel,
432                                                 ASTContext &Context) {
433   if (Member)
434     if (ObjCPropertyDecl *PD = PDecl->FindPropertyDeclaration(
435             Member, ObjCPropertyQueryKind::OBJC_PR_query_instance))
436       return PD;
437   if (ObjCMethodDecl *OMD = PDecl->getInstanceMethod(Sel))
438     return OMD;
439 
440   for (const auto *I : PDecl->protocols()) {
441     if (Decl *D = FindGetterSetterNameDeclFromProtocolList(I, Member, Sel,
442                                                            Context))
443       return D;
444   }
445   return nullptr;
446 }
447 
448 static Decl *FindGetterSetterNameDecl(const ObjCObjectPointerType *QIdTy,
449                                       IdentifierInfo *Member,
450                                       const Selector &Sel,
451                                       ASTContext &Context) {
452   // Check protocols on qualified interfaces.
453   Decl *GDecl = nullptr;
454   for (const auto *I : QIdTy->quals()) {
455     if (Member)
456       if (ObjCPropertyDecl *PD = I->FindPropertyDeclaration(
457               Member, ObjCPropertyQueryKind::OBJC_PR_query_instance)) {
458         GDecl = PD;
459         break;
460       }
461     // Also must look for a getter or setter name which uses property syntax.
462     if (ObjCMethodDecl *OMD = I->getInstanceMethod(Sel)) {
463       GDecl = OMD;
464       break;
465     }
466   }
467   if (!GDecl) {
468     for (const auto *I : QIdTy->quals()) {
469       // Search in the protocol-qualifier list of current protocol.
470       GDecl = FindGetterSetterNameDeclFromProtocolList(I, Member, Sel, Context);
471       if (GDecl)
472         return GDecl;
473     }
474   }
475   return GDecl;
476 }
477 
478 ExprResult
479 Sema::ActOnDependentMemberExpr(Expr *BaseExpr, QualType BaseType,
480                                bool IsArrow, SourceLocation OpLoc,
481                                const CXXScopeSpec &SS,
482                                SourceLocation TemplateKWLoc,
483                                NamedDecl *FirstQualifierInScope,
484                                const DeclarationNameInfo &NameInfo,
485                                const TemplateArgumentListInfo *TemplateArgs) {
486   // Even in dependent contexts, try to diagnose base expressions with
487   // obviously wrong types, e.g.:
488   //
489   // T* t;
490   // t.f;
491   //
492   // In Obj-C++, however, the above expression is valid, since it could be
493   // accessing the 'f' property if T is an Obj-C interface. The extra check
494   // allows this, while still reporting an error if T is a struct pointer.
495   if (!IsArrow) {
496     const PointerType *PT = BaseType->getAs<PointerType>();
497     if (PT && (!getLangOpts().ObjC1 ||
498                PT->getPointeeType()->isRecordType())) {
499       assert(BaseExpr && "cannot happen with implicit member accesses");
500       Diag(OpLoc, diag::err_typecheck_member_reference_struct_union)
501         << BaseType << BaseExpr->getSourceRange() << NameInfo.getSourceRange();
502       return ExprError();
503     }
504   }
505 
506   assert(BaseType->isDependentType() ||
507          NameInfo.getName().isDependentName() ||
508          isDependentScopeSpecifier(SS));
509 
510   // Get the type being accessed in BaseType.  If this is an arrow, the BaseExpr
511   // must have pointer type, and the accessed type is the pointee.
512   return CXXDependentScopeMemberExpr::Create(
513       Context, BaseExpr, BaseType, IsArrow, OpLoc,
514       SS.getWithLocInContext(Context), TemplateKWLoc, FirstQualifierInScope,
515       NameInfo, TemplateArgs);
516 }
517 
518 /// We know that the given qualified member reference points only to
519 /// declarations which do not belong to the static type of the base
520 /// expression.  Diagnose the problem.
521 static void DiagnoseQualifiedMemberReference(Sema &SemaRef,
522                                              Expr *BaseExpr,
523                                              QualType BaseType,
524                                              const CXXScopeSpec &SS,
525                                              NamedDecl *rep,
526                                        const DeclarationNameInfo &nameInfo) {
527   // If this is an implicit member access, use a different set of
528   // diagnostics.
529   if (!BaseExpr)
530     return diagnoseInstanceReference(SemaRef, SS, rep, nameInfo);
531 
532   SemaRef.Diag(nameInfo.getLoc(), diag::err_qualified_member_of_unrelated)
533     << SS.getRange() << rep << BaseType;
534 }
535 
536 // Check whether the declarations we found through a nested-name
537 // specifier in a member expression are actually members of the base
538 // type.  The restriction here is:
539 //
540 //   C++ [expr.ref]p2:
541 //     ... In these cases, the id-expression shall name a
542 //     member of the class or of one of its base classes.
543 //
544 // So it's perfectly legitimate for the nested-name specifier to name
545 // an unrelated class, and for us to find an overload set including
546 // decls from classes which are not superclasses, as long as the decl
547 // we actually pick through overload resolution is from a superclass.
548 bool Sema::CheckQualifiedMemberReference(Expr *BaseExpr,
549                                          QualType BaseType,
550                                          const CXXScopeSpec &SS,
551                                          const LookupResult &R) {
552   CXXRecordDecl *BaseRecord =
553     cast_or_null<CXXRecordDecl>(computeDeclContext(BaseType));
554   if (!BaseRecord) {
555     // We can't check this yet because the base type is still
556     // dependent.
557     assert(BaseType->isDependentType());
558     return false;
559   }
560 
561   for (LookupResult::iterator I = R.begin(), E = R.end(); I != E; ++I) {
562     // If this is an implicit member reference and we find a
563     // non-instance member, it's not an error.
564     if (!BaseExpr && !(*I)->isCXXInstanceMember())
565       return false;
566 
567     // Note that we use the DC of the decl, not the underlying decl.
568     DeclContext *DC = (*I)->getDeclContext();
569     while (DC->isTransparentContext())
570       DC = DC->getParent();
571 
572     if (!DC->isRecord())
573       continue;
574 
575     CXXRecordDecl *MemberRecord = cast<CXXRecordDecl>(DC)->getCanonicalDecl();
576     if (BaseRecord->getCanonicalDecl() == MemberRecord ||
577         !BaseRecord->isProvablyNotDerivedFrom(MemberRecord))
578       return false;
579   }
580 
581   DiagnoseQualifiedMemberReference(*this, BaseExpr, BaseType, SS,
582                                    R.getRepresentativeDecl(),
583                                    R.getLookupNameInfo());
584   return true;
585 }
586 
587 namespace {
588 
589 // Callback to only accept typo corrections that are either a ValueDecl or a
590 // FunctionTemplateDecl and are declared in the current record or, for a C++
591 // classes, one of its base classes.
592 class RecordMemberExprValidatorCCC : public CorrectionCandidateCallback {
593 public:
594   explicit RecordMemberExprValidatorCCC(const RecordType *RTy)
595       : Record(RTy->getDecl()) {
596     // Don't add bare keywords to the consumer since they will always fail
597     // validation by virtue of not being associated with any decls.
598     WantTypeSpecifiers = false;
599     WantExpressionKeywords = false;
600     WantCXXNamedCasts = false;
601     WantFunctionLikeCasts = false;
602     WantRemainingKeywords = false;
603   }
604 
605   bool ValidateCandidate(const TypoCorrection &candidate) override {
606     NamedDecl *ND = candidate.getCorrectionDecl();
607     // Don't accept candidates that cannot be member functions, constants,
608     // variables, or templates.
609     if (!ND || !(isa<ValueDecl>(ND) || isa<FunctionTemplateDecl>(ND)))
610       return false;
611 
612     // Accept candidates that occur in the current record.
613     if (Record->containsDecl(ND))
614       return true;
615 
616     if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(Record)) {
617       // Accept candidates that occur in any of the current class' base classes.
618       for (const auto &BS : RD->bases()) {
619         if (const RecordType *BSTy =
620                 dyn_cast_or_null<RecordType>(BS.getType().getTypePtrOrNull())) {
621           if (BSTy->getDecl()->containsDecl(ND))
622             return true;
623         }
624       }
625     }
626 
627     return false;
628   }
629 
630 private:
631   const RecordDecl *const Record;
632 };
633 
634 }
635 
636 static bool LookupMemberExprInRecord(Sema &SemaRef, LookupResult &R,
637                                      Expr *BaseExpr,
638                                      const RecordType *RTy,
639                                      SourceLocation OpLoc, bool IsArrow,
640                                      CXXScopeSpec &SS, bool HasTemplateArgs,
641                                      TypoExpr *&TE) {
642   SourceRange BaseRange = BaseExpr ? BaseExpr->getSourceRange() : SourceRange();
643   RecordDecl *RDecl = RTy->getDecl();
644   if (!SemaRef.isThisOutsideMemberFunctionBody(QualType(RTy, 0)) &&
645       SemaRef.RequireCompleteType(OpLoc, QualType(RTy, 0),
646                                   diag::err_typecheck_incomplete_tag,
647                                   BaseRange))
648     return true;
649 
650   if (HasTemplateArgs) {
651     // LookupTemplateName doesn't expect these both to exist simultaneously.
652     QualType ObjectType = SS.isSet() ? QualType() : QualType(RTy, 0);
653 
654     bool MOUS;
655     SemaRef.LookupTemplateName(R, nullptr, SS, ObjectType, false, MOUS);
656     return false;
657   }
658 
659   DeclContext *DC = RDecl;
660   if (SS.isSet()) {
661     // If the member name was a qualified-id, look into the
662     // nested-name-specifier.
663     DC = SemaRef.computeDeclContext(SS, false);
664 
665     if (SemaRef.RequireCompleteDeclContext(SS, DC)) {
666       SemaRef.Diag(SS.getRange().getEnd(), diag::err_typecheck_incomplete_tag)
667           << SS.getRange() << DC;
668       return true;
669     }
670 
671     assert(DC && "Cannot handle non-computable dependent contexts in lookup");
672 
673     if (!isa<TypeDecl>(DC)) {
674       SemaRef.Diag(R.getNameLoc(), diag::err_qualified_member_nonclass)
675           << DC << SS.getRange();
676       return true;
677     }
678   }
679 
680   // The record definition is complete, now look up the member.
681   SemaRef.LookupQualifiedName(R, DC, SS);
682 
683   if (!R.empty())
684     return false;
685 
686   DeclarationName Typo = R.getLookupName();
687   SourceLocation TypoLoc = R.getNameLoc();
688 
689   struct QueryState {
690     Sema &SemaRef;
691     DeclarationNameInfo NameInfo;
692     Sema::LookupNameKind LookupKind;
693     Sema::RedeclarationKind Redecl;
694   };
695   QueryState Q = {R.getSema(), R.getLookupNameInfo(), R.getLookupKind(),
696                   R.isForRedeclaration() ? Sema::ForRedeclaration
697                                          : Sema::NotForRedeclaration};
698   TE = SemaRef.CorrectTypoDelayed(
699       R.getLookupNameInfo(), R.getLookupKind(), nullptr, &SS,
700       llvm::make_unique<RecordMemberExprValidatorCCC>(RTy),
701       [=, &SemaRef](const TypoCorrection &TC) {
702         if (TC) {
703           assert(!TC.isKeyword() &&
704                  "Got a keyword as a correction for a member!");
705           bool DroppedSpecifier =
706               TC.WillReplaceSpecifier() &&
707               Typo.getAsString() == TC.getAsString(SemaRef.getLangOpts());
708           SemaRef.diagnoseTypo(TC, SemaRef.PDiag(diag::err_no_member_suggest)
709                                        << Typo << DC << DroppedSpecifier
710                                        << SS.getRange());
711         } else {
712           SemaRef.Diag(TypoLoc, diag::err_no_member) << Typo << DC << BaseRange;
713         }
714       },
715       [=](Sema &SemaRef, TypoExpr *TE, TypoCorrection TC) mutable {
716         LookupResult R(Q.SemaRef, Q.NameInfo, Q.LookupKind, Q.Redecl);
717         R.clear(); // Ensure there's no decls lingering in the shared state.
718         R.suppressDiagnostics();
719         R.setLookupName(TC.getCorrection());
720         for (NamedDecl *ND : TC)
721           R.addDecl(ND);
722         R.resolveKind();
723         return SemaRef.BuildMemberReferenceExpr(
724             BaseExpr, BaseExpr->getType(), OpLoc, IsArrow, SS, SourceLocation(),
725             nullptr, R, nullptr, nullptr);
726       },
727       Sema::CTK_ErrorRecovery, DC);
728 
729   return false;
730 }
731 
732 static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
733                                    ExprResult &BaseExpr, bool &IsArrow,
734                                    SourceLocation OpLoc, CXXScopeSpec &SS,
735                                    Decl *ObjCImpDecl, bool HasTemplateArgs);
736 
737 ExprResult
738 Sema::BuildMemberReferenceExpr(Expr *Base, QualType BaseType,
739                                SourceLocation OpLoc, bool IsArrow,
740                                CXXScopeSpec &SS,
741                                SourceLocation TemplateKWLoc,
742                                NamedDecl *FirstQualifierInScope,
743                                const DeclarationNameInfo &NameInfo,
744                                const TemplateArgumentListInfo *TemplateArgs,
745                                const Scope *S,
746                                ActOnMemberAccessExtraArgs *ExtraArgs) {
747   if (BaseType->isDependentType() ||
748       (SS.isSet() && isDependentScopeSpecifier(SS)))
749     return ActOnDependentMemberExpr(Base, BaseType,
750                                     IsArrow, OpLoc,
751                                     SS, TemplateKWLoc, FirstQualifierInScope,
752                                     NameInfo, TemplateArgs);
753 
754   LookupResult R(*this, NameInfo, LookupMemberName);
755 
756   // Implicit member accesses.
757   if (!Base) {
758     TypoExpr *TE = nullptr;
759     QualType RecordTy = BaseType;
760     if (IsArrow) RecordTy = RecordTy->getAs<PointerType>()->getPointeeType();
761     if (LookupMemberExprInRecord(*this, R, nullptr,
762                                  RecordTy->getAs<RecordType>(), OpLoc, IsArrow,
763                                  SS, TemplateArgs != nullptr, TE))
764       return ExprError();
765     if (TE)
766       return TE;
767 
768   // Explicit member accesses.
769   } else {
770     ExprResult BaseResult = Base;
771     ExprResult Result = LookupMemberExpr(
772         *this, R, BaseResult, IsArrow, OpLoc, SS,
773         ExtraArgs ? ExtraArgs->ObjCImpDecl : nullptr,
774         TemplateArgs != nullptr);
775 
776     if (BaseResult.isInvalid())
777       return ExprError();
778     Base = BaseResult.get();
779 
780     if (Result.isInvalid())
781       return ExprError();
782 
783     if (Result.get())
784       return Result;
785 
786     // LookupMemberExpr can modify Base, and thus change BaseType
787     BaseType = Base->getType();
788   }
789 
790   return BuildMemberReferenceExpr(Base, BaseType,
791                                   OpLoc, IsArrow, SS, TemplateKWLoc,
792                                   FirstQualifierInScope, R, TemplateArgs, S,
793                                   false, ExtraArgs);
794 }
795 
796 ExprResult
797 Sema::BuildAnonymousStructUnionMemberReference(const CXXScopeSpec &SS,
798                                                SourceLocation loc,
799                                                IndirectFieldDecl *indirectField,
800                                                DeclAccessPair foundDecl,
801                                                Expr *baseObjectExpr,
802                                                SourceLocation opLoc) {
803   // First, build the expression that refers to the base object.
804 
805   bool baseObjectIsPointer = false;
806   Qualifiers baseQuals;
807 
808   // Case 1:  the base of the indirect field is not a field.
809   VarDecl *baseVariable = indirectField->getVarDecl();
810   CXXScopeSpec EmptySS;
811   if (baseVariable) {
812     assert(baseVariable->getType()->isRecordType());
813 
814     // In principle we could have a member access expression that
815     // accesses an anonymous struct/union that's a static member of
816     // the base object's class.  However, under the current standard,
817     // static data members cannot be anonymous structs or unions.
818     // Supporting this is as easy as building a MemberExpr here.
819     assert(!baseObjectExpr && "anonymous struct/union is static data member?");
820 
821     DeclarationNameInfo baseNameInfo(DeclarationName(), loc);
822 
823     ExprResult result
824       = BuildDeclarationNameExpr(EmptySS, baseNameInfo, baseVariable);
825     if (result.isInvalid()) return ExprError();
826 
827     baseObjectExpr = result.get();
828     baseObjectIsPointer = false;
829     baseQuals = baseObjectExpr->getType().getQualifiers();
830 
831     // Case 2: the base of the indirect field is a field and the user
832     // wrote a member expression.
833   } else if (baseObjectExpr) {
834     // The caller provided the base object expression. Determine
835     // whether its a pointer and whether it adds any qualifiers to the
836     // anonymous struct/union fields we're looking into.
837     QualType objectType = baseObjectExpr->getType();
838 
839     if (const PointerType *ptr = objectType->getAs<PointerType>()) {
840       baseObjectIsPointer = true;
841       objectType = ptr->getPointeeType();
842     } else {
843       baseObjectIsPointer = false;
844     }
845     baseQuals = objectType.getQualifiers();
846 
847     // Case 3: the base of the indirect field is a field and we should
848     // build an implicit member access.
849   } else {
850     // We've found a member of an anonymous struct/union that is
851     // inside a non-anonymous struct/union, so in a well-formed
852     // program our base object expression is "this".
853     QualType ThisTy = getCurrentThisType();
854     if (ThisTy.isNull()) {
855       Diag(loc, diag::err_invalid_member_use_in_static_method)
856         << indirectField->getDeclName();
857       return ExprError();
858     }
859 
860     // Our base object expression is "this".
861     CheckCXXThisCapture(loc);
862     baseObjectExpr
863       = new (Context) CXXThisExpr(loc, ThisTy, /*isImplicit=*/ true);
864     baseObjectIsPointer = true;
865     baseQuals = ThisTy->castAs<PointerType>()->getPointeeType().getQualifiers();
866   }
867 
868   // Build the implicit member references to the field of the
869   // anonymous struct/union.
870   Expr *result = baseObjectExpr;
871   IndirectFieldDecl::chain_iterator
872   FI = indirectField->chain_begin(), FEnd = indirectField->chain_end();
873 
874   // Build the first member access in the chain with full information.
875   if (!baseVariable) {
876     FieldDecl *field = cast<FieldDecl>(*FI);
877 
878     // Make a nameInfo that properly uses the anonymous name.
879     DeclarationNameInfo memberNameInfo(field->getDeclName(), loc);
880 
881     result = BuildFieldReferenceExpr(result, baseObjectIsPointer,
882                                      SourceLocation(), EmptySS, field,
883                                      foundDecl, memberNameInfo).get();
884     if (!result)
885       return ExprError();
886 
887     // FIXME: check qualified member access
888   }
889 
890   // In all cases, we should now skip the first declaration in the chain.
891   ++FI;
892 
893   while (FI != FEnd) {
894     FieldDecl *field = cast<FieldDecl>(*FI++);
895 
896     // FIXME: these are somewhat meaningless
897     DeclarationNameInfo memberNameInfo(field->getDeclName(), loc);
898     DeclAccessPair fakeFoundDecl =
899         DeclAccessPair::make(field, field->getAccess());
900 
901     result =
902         BuildFieldReferenceExpr(result, /*isarrow*/ false, SourceLocation(),
903                                 (FI == FEnd ? SS : EmptySS), field,
904                                 fakeFoundDecl, memberNameInfo)
905             .get();
906   }
907 
908   return result;
909 }
910 
911 static ExprResult
912 BuildMSPropertyRefExpr(Sema &S, Expr *BaseExpr, bool IsArrow,
913                        const CXXScopeSpec &SS,
914                        MSPropertyDecl *PD,
915                        const DeclarationNameInfo &NameInfo) {
916   // Property names are always simple identifiers and therefore never
917   // require any interesting additional storage.
918   return new (S.Context) MSPropertyRefExpr(BaseExpr, PD, IsArrow,
919                                            S.Context.PseudoObjectTy, VK_LValue,
920                                            SS.getWithLocInContext(S.Context),
921                                            NameInfo.getLoc());
922 }
923 
924 /// \brief Build a MemberExpr AST node.
925 static MemberExpr *BuildMemberExpr(
926     Sema &SemaRef, ASTContext &C, Expr *Base, bool isArrow,
927     SourceLocation OpLoc, const CXXScopeSpec &SS, SourceLocation TemplateKWLoc,
928     ValueDecl *Member, DeclAccessPair FoundDecl,
929     const DeclarationNameInfo &MemberNameInfo, QualType Ty, ExprValueKind VK,
930     ExprObjectKind OK, const TemplateArgumentListInfo *TemplateArgs = nullptr) {
931   assert((!isArrow || Base->isRValue()) && "-> base must be a pointer rvalue");
932   MemberExpr *E = MemberExpr::Create(
933       C, Base, isArrow, OpLoc, SS.getWithLocInContext(C), TemplateKWLoc, Member,
934       FoundDecl, MemberNameInfo, TemplateArgs, Ty, VK, OK);
935   SemaRef.MarkMemberReferenced(E);
936   return E;
937 }
938 
939 /// \brief Determine if the given scope is within a function-try-block handler.
940 static bool IsInFnTryBlockHandler(const Scope *S) {
941   // Walk the scope stack until finding a FnTryCatchScope, or leave the
942   // function scope. If a FnTryCatchScope is found, check whether the TryScope
943   // flag is set. If it is not, it's a function-try-block handler.
944   for (; S != S->getFnParent(); S = S->getParent()) {
945     if (S->getFlags() & Scope::FnTryCatchScope)
946       return (S->getFlags() & Scope::TryScope) != Scope::TryScope;
947   }
948   return false;
949 }
950 
951 static VarDecl *
952 getVarTemplateSpecialization(Sema &S, VarTemplateDecl *VarTempl,
953                       const TemplateArgumentListInfo *TemplateArgs,
954                       const DeclarationNameInfo &MemberNameInfo,
955                       SourceLocation TemplateKWLoc) {
956 
957   if (!TemplateArgs) {
958     S.Diag(MemberNameInfo.getBeginLoc(), diag::err_template_decl_ref)
959         << /*Variable template*/ 1 << MemberNameInfo.getName()
960         << MemberNameInfo.getSourceRange();
961 
962     S.Diag(VarTempl->getLocation(), diag::note_template_decl_here);
963 
964     return nullptr;
965   }
966   DeclResult VDecl = S.CheckVarTemplateId(
967       VarTempl, TemplateKWLoc, MemberNameInfo.getLoc(), *TemplateArgs);
968   if (VDecl.isInvalid())
969     return nullptr;
970   VarDecl *Var = cast<VarDecl>(VDecl.get());
971   if (!Var->getTemplateSpecializationKind())
972     Var->setTemplateSpecializationKind(TSK_ImplicitInstantiation,
973                                        MemberNameInfo.getLoc());
974   return Var;
975 }
976 
977 ExprResult
978 Sema::BuildMemberReferenceExpr(Expr *BaseExpr, QualType BaseExprType,
979                                SourceLocation OpLoc, bool IsArrow,
980                                const CXXScopeSpec &SS,
981                                SourceLocation TemplateKWLoc,
982                                NamedDecl *FirstQualifierInScope,
983                                LookupResult &R,
984                                const TemplateArgumentListInfo *TemplateArgs,
985                                const Scope *S,
986                                bool SuppressQualifierCheck,
987                                ActOnMemberAccessExtraArgs *ExtraArgs) {
988   QualType BaseType = BaseExprType;
989   if (IsArrow) {
990     assert(BaseType->isPointerType());
991     BaseType = BaseType->castAs<PointerType>()->getPointeeType();
992   }
993   R.setBaseObjectType(BaseType);
994 
995   // C++1z [expr.ref]p2:
996   //   For the first option (dot) the first expression shall be a glvalue [...]
997   if (!IsArrow && BaseExpr && BaseExpr->isRValue()) {
998     ExprResult Converted = TemporaryMaterializationConversion(BaseExpr);
999     if (Converted.isInvalid())
1000       return ExprError();
1001     BaseExpr = Converted.get();
1002   }
1003 
1004 
1005   const DeclarationNameInfo &MemberNameInfo = R.getLookupNameInfo();
1006   DeclarationName MemberName = MemberNameInfo.getName();
1007   SourceLocation MemberLoc = MemberNameInfo.getLoc();
1008 
1009   if (R.isAmbiguous())
1010     return ExprError();
1011 
1012   // [except.handle]p10: Referring to any non-static member or base class of an
1013   // object in the handler for a function-try-block of a constructor or
1014   // destructor for that object results in undefined behavior.
1015   const auto *FD = getCurFunctionDecl();
1016   if (S && BaseExpr && FD &&
1017       (isa<CXXDestructorDecl>(FD) || isa<CXXConstructorDecl>(FD)) &&
1018       isa<CXXThisExpr>(BaseExpr->IgnoreImpCasts()) &&
1019       IsInFnTryBlockHandler(S))
1020     Diag(MemberLoc, diag::warn_cdtor_function_try_handler_mem_expr)
1021         << isa<CXXDestructorDecl>(FD);
1022 
1023   if (R.empty()) {
1024     // Rederive where we looked up.
1025     DeclContext *DC = (SS.isSet()
1026                        ? computeDeclContext(SS, false)
1027                        : BaseType->getAs<RecordType>()->getDecl());
1028 
1029     if (ExtraArgs) {
1030       ExprResult RetryExpr;
1031       if (!IsArrow && BaseExpr) {
1032         SFINAETrap Trap(*this, true);
1033         ParsedType ObjectType;
1034         bool MayBePseudoDestructor = false;
1035         RetryExpr = ActOnStartCXXMemberReference(getCurScope(), BaseExpr,
1036                                                  OpLoc, tok::arrow, ObjectType,
1037                                                  MayBePseudoDestructor);
1038         if (RetryExpr.isUsable() && !Trap.hasErrorOccurred()) {
1039           CXXScopeSpec TempSS(SS);
1040           RetryExpr = ActOnMemberAccessExpr(
1041               ExtraArgs->S, RetryExpr.get(), OpLoc, tok::arrow, TempSS,
1042               TemplateKWLoc, ExtraArgs->Id, ExtraArgs->ObjCImpDecl);
1043         }
1044         if (Trap.hasErrorOccurred())
1045           RetryExpr = ExprError();
1046       }
1047       if (RetryExpr.isUsable()) {
1048         Diag(OpLoc, diag::err_no_member_overloaded_arrow)
1049           << MemberName << DC << FixItHint::CreateReplacement(OpLoc, "->");
1050         return RetryExpr;
1051       }
1052     }
1053 
1054     Diag(R.getNameLoc(), diag::err_no_member)
1055       << MemberName << DC
1056       << (BaseExpr ? BaseExpr->getSourceRange() : SourceRange());
1057     return ExprError();
1058   }
1059 
1060   // Diagnose lookups that find only declarations from a non-base
1061   // type.  This is possible for either qualified lookups (which may
1062   // have been qualified with an unrelated type) or implicit member
1063   // expressions (which were found with unqualified lookup and thus
1064   // may have come from an enclosing scope).  Note that it's okay for
1065   // lookup to find declarations from a non-base type as long as those
1066   // aren't the ones picked by overload resolution.
1067   if ((SS.isSet() || !BaseExpr ||
1068        (isa<CXXThisExpr>(BaseExpr) &&
1069         cast<CXXThisExpr>(BaseExpr)->isImplicit())) &&
1070       !SuppressQualifierCheck &&
1071       CheckQualifiedMemberReference(BaseExpr, BaseType, SS, R))
1072     return ExprError();
1073 
1074   // Construct an unresolved result if we in fact got an unresolved
1075   // result.
1076   if (R.isOverloadedResult() || R.isUnresolvableResult()) {
1077     // Suppress any lookup-related diagnostics; we'll do these when we
1078     // pick a member.
1079     R.suppressDiagnostics();
1080 
1081     UnresolvedMemberExpr *MemExpr
1082       = UnresolvedMemberExpr::Create(Context, R.isUnresolvableResult(),
1083                                      BaseExpr, BaseExprType,
1084                                      IsArrow, OpLoc,
1085                                      SS.getWithLocInContext(Context),
1086                                      TemplateKWLoc, MemberNameInfo,
1087                                      TemplateArgs, R.begin(), R.end());
1088 
1089     return MemExpr;
1090   }
1091 
1092   assert(R.isSingleResult());
1093   DeclAccessPair FoundDecl = R.begin().getPair();
1094   NamedDecl *MemberDecl = R.getFoundDecl();
1095 
1096   // FIXME: diagnose the presence of template arguments now.
1097 
1098   // If the decl being referenced had an error, return an error for this
1099   // sub-expr without emitting another error, in order to avoid cascading
1100   // error cases.
1101   if (MemberDecl->isInvalidDecl())
1102     return ExprError();
1103 
1104   // Handle the implicit-member-access case.
1105   if (!BaseExpr) {
1106     // If this is not an instance member, convert to a non-member access.
1107     if (!MemberDecl->isCXXInstanceMember()) {
1108       // If this is a variable template, get the instantiated variable
1109       // declaration corresponding to the supplied template arguments
1110       // (while emitting diagnostics as necessary) that will be referenced
1111       // by this expression.
1112       assert((!TemplateArgs || isa<VarTemplateDecl>(MemberDecl)) &&
1113              "How did we get template arguments here sans a variable template");
1114       if (isa<VarTemplateDecl>(MemberDecl)) {
1115         MemberDecl = getVarTemplateSpecialization(
1116             *this, cast<VarTemplateDecl>(MemberDecl), TemplateArgs,
1117             R.getLookupNameInfo(), TemplateKWLoc);
1118         if (!MemberDecl)
1119           return ExprError();
1120       }
1121       return BuildDeclarationNameExpr(SS, R.getLookupNameInfo(), MemberDecl,
1122                                       FoundDecl, TemplateArgs);
1123     }
1124     SourceLocation Loc = R.getNameLoc();
1125     if (SS.getRange().isValid())
1126       Loc = SS.getRange().getBegin();
1127     CheckCXXThisCapture(Loc);
1128     BaseExpr = new (Context) CXXThisExpr(Loc, BaseExprType,/*isImplicit=*/true);
1129   }
1130 
1131   // Check the use of this member.
1132   if (DiagnoseUseOfDecl(MemberDecl, MemberLoc))
1133     return ExprError();
1134 
1135   if (FieldDecl *FD = dyn_cast<FieldDecl>(MemberDecl))
1136     return BuildFieldReferenceExpr(BaseExpr, IsArrow, OpLoc, SS, FD, FoundDecl,
1137                                    MemberNameInfo);
1138 
1139   if (MSPropertyDecl *PD = dyn_cast<MSPropertyDecl>(MemberDecl))
1140     return BuildMSPropertyRefExpr(*this, BaseExpr, IsArrow, SS, PD,
1141                                   MemberNameInfo);
1142 
1143   if (IndirectFieldDecl *FD = dyn_cast<IndirectFieldDecl>(MemberDecl))
1144     // We may have found a field within an anonymous union or struct
1145     // (C++ [class.union]).
1146     return BuildAnonymousStructUnionMemberReference(SS, MemberLoc, FD,
1147                                                     FoundDecl, BaseExpr,
1148                                                     OpLoc);
1149 
1150   if (VarDecl *Var = dyn_cast<VarDecl>(MemberDecl)) {
1151     return BuildMemberExpr(*this, Context, BaseExpr, IsArrow, OpLoc, SS,
1152                            TemplateKWLoc, Var, FoundDecl, MemberNameInfo,
1153                            Var->getType().getNonReferenceType(), VK_LValue,
1154                            OK_Ordinary);
1155   }
1156 
1157   if (CXXMethodDecl *MemberFn = dyn_cast<CXXMethodDecl>(MemberDecl)) {
1158     ExprValueKind valueKind;
1159     QualType type;
1160     if (MemberFn->isInstance()) {
1161       valueKind = VK_RValue;
1162       type = Context.BoundMemberTy;
1163     } else {
1164       valueKind = VK_LValue;
1165       type = MemberFn->getType();
1166     }
1167 
1168     return BuildMemberExpr(*this, Context, BaseExpr, IsArrow, OpLoc, SS,
1169                            TemplateKWLoc, MemberFn, FoundDecl, MemberNameInfo,
1170                            type, valueKind, OK_Ordinary);
1171   }
1172   assert(!isa<FunctionDecl>(MemberDecl) && "member function not C++ method?");
1173 
1174   if (EnumConstantDecl *Enum = dyn_cast<EnumConstantDecl>(MemberDecl)) {
1175     return BuildMemberExpr(*this, Context, BaseExpr, IsArrow, OpLoc, SS,
1176                            TemplateKWLoc, Enum, FoundDecl, MemberNameInfo,
1177                            Enum->getType(), VK_RValue, OK_Ordinary);
1178   }
1179   if (VarTemplateDecl *VarTempl = dyn_cast<VarTemplateDecl>(MemberDecl)) {
1180     if (VarDecl *Var = getVarTemplateSpecialization(
1181             *this, VarTempl, TemplateArgs, MemberNameInfo, TemplateKWLoc))
1182       return BuildMemberExpr(*this, Context, BaseExpr, IsArrow, OpLoc, SS,
1183                              TemplateKWLoc, Var, FoundDecl, MemberNameInfo,
1184                              Var->getType().getNonReferenceType(), VK_LValue,
1185                              OK_Ordinary);
1186     return ExprError();
1187   }
1188 
1189   // We found something that we didn't expect. Complain.
1190   if (isa<TypeDecl>(MemberDecl))
1191     Diag(MemberLoc, diag::err_typecheck_member_reference_type)
1192       << MemberName << BaseType << int(IsArrow);
1193   else
1194     Diag(MemberLoc, diag::err_typecheck_member_reference_unknown)
1195       << MemberName << BaseType << int(IsArrow);
1196 
1197   Diag(MemberDecl->getLocation(), diag::note_member_declared_here)
1198     << MemberName;
1199   R.suppressDiagnostics();
1200   return ExprError();
1201 }
1202 
1203 /// Given that normal member access failed on the given expression,
1204 /// and given that the expression's type involves builtin-id or
1205 /// builtin-Class, decide whether substituting in the redefinition
1206 /// types would be profitable.  The redefinition type is whatever
1207 /// this translation unit tried to typedef to id/Class;  we store
1208 /// it to the side and then re-use it in places like this.
1209 static bool ShouldTryAgainWithRedefinitionType(Sema &S, ExprResult &base) {
1210   const ObjCObjectPointerType *opty
1211     = base.get()->getType()->getAs<ObjCObjectPointerType>();
1212   if (!opty) return false;
1213 
1214   const ObjCObjectType *ty = opty->getObjectType();
1215 
1216   QualType redef;
1217   if (ty->isObjCId()) {
1218     redef = S.Context.getObjCIdRedefinitionType();
1219   } else if (ty->isObjCClass()) {
1220     redef = S.Context.getObjCClassRedefinitionType();
1221   } else {
1222     return false;
1223   }
1224 
1225   // Do the substitution as long as the redefinition type isn't just a
1226   // possibly-qualified pointer to builtin-id or builtin-Class again.
1227   opty = redef->getAs<ObjCObjectPointerType>();
1228   if (opty && !opty->getObjectType()->getInterface())
1229     return false;
1230 
1231   base = S.ImpCastExprToType(base.get(), redef, CK_BitCast);
1232   return true;
1233 }
1234 
1235 static bool isRecordType(QualType T) {
1236   return T->isRecordType();
1237 }
1238 static bool isPointerToRecordType(QualType T) {
1239   if (const PointerType *PT = T->getAs<PointerType>())
1240     return PT->getPointeeType()->isRecordType();
1241   return false;
1242 }
1243 
1244 /// Perform conversions on the LHS of a member access expression.
1245 ExprResult
1246 Sema::PerformMemberExprBaseConversion(Expr *Base, bool IsArrow) {
1247   if (IsArrow && !Base->getType()->isFunctionType())
1248     return DefaultFunctionArrayLvalueConversion(Base);
1249 
1250   return CheckPlaceholderExpr(Base);
1251 }
1252 
1253 /// Look up the given member of the given non-type-dependent
1254 /// expression.  This can return in one of two ways:
1255 ///  * If it returns a sentinel null-but-valid result, the caller will
1256 ///    assume that lookup was performed and the results written into
1257 ///    the provided structure.  It will take over from there.
1258 ///  * Otherwise, the returned expression will be produced in place of
1259 ///    an ordinary member expression.
1260 ///
1261 /// The ObjCImpDecl bit is a gross hack that will need to be properly
1262 /// fixed for ObjC++.
1263 static ExprResult LookupMemberExpr(Sema &S, LookupResult &R,
1264                                    ExprResult &BaseExpr, bool &IsArrow,
1265                                    SourceLocation OpLoc, CXXScopeSpec &SS,
1266                                    Decl *ObjCImpDecl, bool HasTemplateArgs) {
1267   assert(BaseExpr.get() && "no base expression");
1268 
1269   // Perform default conversions.
1270   BaseExpr = S.PerformMemberExprBaseConversion(BaseExpr.get(), IsArrow);
1271   if (BaseExpr.isInvalid())
1272     return ExprError();
1273 
1274   QualType BaseType = BaseExpr.get()->getType();
1275   assert(!BaseType->isDependentType());
1276 
1277   DeclarationName MemberName = R.getLookupName();
1278   SourceLocation MemberLoc = R.getNameLoc();
1279 
1280   // For later type-checking purposes, turn arrow accesses into dot
1281   // accesses.  The only access type we support that doesn't follow
1282   // the C equivalence "a->b === (*a).b" is ObjC property accesses,
1283   // and those never use arrows, so this is unaffected.
1284   if (IsArrow) {
1285     if (const PointerType *Ptr = BaseType->getAs<PointerType>())
1286       BaseType = Ptr->getPointeeType();
1287     else if (const ObjCObjectPointerType *Ptr
1288                = BaseType->getAs<ObjCObjectPointerType>())
1289       BaseType = Ptr->getPointeeType();
1290     else if (BaseType->isRecordType()) {
1291       // Recover from arrow accesses to records, e.g.:
1292       //   struct MyRecord foo;
1293       //   foo->bar
1294       // This is actually well-formed in C++ if MyRecord has an
1295       // overloaded operator->, but that should have been dealt with
1296       // by now--or a diagnostic message already issued if a problem
1297       // was encountered while looking for the overloaded operator->.
1298       if (!S.getLangOpts().CPlusPlus) {
1299         S.Diag(OpLoc, diag::err_typecheck_member_reference_suggestion)
1300           << BaseType << int(IsArrow) << BaseExpr.get()->getSourceRange()
1301           << FixItHint::CreateReplacement(OpLoc, ".");
1302       }
1303       IsArrow = false;
1304     } else if (BaseType->isFunctionType()) {
1305       goto fail;
1306     } else {
1307       S.Diag(MemberLoc, diag::err_typecheck_member_reference_arrow)
1308         << BaseType << BaseExpr.get()->getSourceRange();
1309       return ExprError();
1310     }
1311   }
1312 
1313   // Handle field access to simple records.
1314   if (const RecordType *RTy = BaseType->getAs<RecordType>()) {
1315     TypoExpr *TE = nullptr;
1316     if (LookupMemberExprInRecord(S, R, BaseExpr.get(), RTy,
1317                                  OpLoc, IsArrow, SS, HasTemplateArgs, TE))
1318       return ExprError();
1319 
1320     // Returning valid-but-null is how we indicate to the caller that
1321     // the lookup result was filled in. If typo correction was attempted and
1322     // failed, the lookup result will have been cleared--that combined with the
1323     // valid-but-null ExprResult will trigger the appropriate diagnostics.
1324     return ExprResult(TE);
1325   }
1326 
1327   // Handle ivar access to Objective-C objects.
1328   if (const ObjCObjectType *OTy = BaseType->getAs<ObjCObjectType>()) {
1329     if (!SS.isEmpty() && !SS.isInvalid()) {
1330       S.Diag(SS.getRange().getBegin(), diag::err_qualified_objc_access)
1331         << 1 << SS.getScopeRep()
1332         << FixItHint::CreateRemoval(SS.getRange());
1333       SS.clear();
1334     }
1335 
1336     IdentifierInfo *Member = MemberName.getAsIdentifierInfo();
1337 
1338     // There are three cases for the base type:
1339     //   - builtin id (qualified or unqualified)
1340     //   - builtin Class (qualified or unqualified)
1341     //   - an interface
1342     ObjCInterfaceDecl *IDecl = OTy->getInterface();
1343     if (!IDecl) {
1344       if (S.getLangOpts().ObjCAutoRefCount &&
1345           (OTy->isObjCId() || OTy->isObjCClass()))
1346         goto fail;
1347       // There's an implicit 'isa' ivar on all objects.
1348       // But we only actually find it this way on objects of type 'id',
1349       // apparently.
1350       if (OTy->isObjCId() && Member->isStr("isa"))
1351         return new (S.Context) ObjCIsaExpr(BaseExpr.get(), IsArrow, MemberLoc,
1352                                            OpLoc, S.Context.getObjCClassType());
1353       if (ShouldTryAgainWithRedefinitionType(S, BaseExpr))
1354         return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1355                                 ObjCImpDecl, HasTemplateArgs);
1356       goto fail;
1357     }
1358 
1359     if (S.RequireCompleteType(OpLoc, BaseType,
1360                               diag::err_typecheck_incomplete_tag,
1361                               BaseExpr.get()))
1362       return ExprError();
1363 
1364     ObjCInterfaceDecl *ClassDeclared = nullptr;
1365     ObjCIvarDecl *IV = IDecl->lookupInstanceVariable(Member, ClassDeclared);
1366 
1367     if (!IV) {
1368       // Attempt to correct for typos in ivar names.
1369       auto Validator = llvm::make_unique<DeclFilterCCC<ObjCIvarDecl>>();
1370       Validator->IsObjCIvarLookup = IsArrow;
1371       if (TypoCorrection Corrected = S.CorrectTypo(
1372               R.getLookupNameInfo(), Sema::LookupMemberName, nullptr, nullptr,
1373               std::move(Validator), Sema::CTK_ErrorRecovery, IDecl)) {
1374         IV = Corrected.getCorrectionDeclAs<ObjCIvarDecl>();
1375         S.diagnoseTypo(
1376             Corrected,
1377             S.PDiag(diag::err_typecheck_member_reference_ivar_suggest)
1378                 << IDecl->getDeclName() << MemberName);
1379 
1380         // Figure out the class that declares the ivar.
1381         assert(!ClassDeclared);
1382 
1383         Decl *D = cast<Decl>(IV->getDeclContext());
1384         if (auto *Category = dyn_cast<ObjCCategoryDecl>(D))
1385           D = Category->getClassInterface();
1386 
1387         if (auto *Implementation = dyn_cast<ObjCImplementationDecl>(D))
1388           ClassDeclared = Implementation->getClassInterface();
1389         else if (auto *Interface = dyn_cast<ObjCInterfaceDecl>(D))
1390           ClassDeclared = Interface;
1391 
1392         assert(ClassDeclared && "cannot query interface");
1393       } else {
1394         if (IsArrow &&
1395             IDecl->FindPropertyDeclaration(
1396                 Member, ObjCPropertyQueryKind::OBJC_PR_query_instance)) {
1397           S.Diag(MemberLoc, diag::err_property_found_suggest)
1398               << Member << BaseExpr.get()->getType()
1399               << FixItHint::CreateReplacement(OpLoc, ".");
1400           return ExprError();
1401         }
1402 
1403         S.Diag(MemberLoc, diag::err_typecheck_member_reference_ivar)
1404             << IDecl->getDeclName() << MemberName
1405             << BaseExpr.get()->getSourceRange();
1406         return ExprError();
1407       }
1408     }
1409 
1410     assert(ClassDeclared);
1411 
1412     // If the decl being referenced had an error, return an error for this
1413     // sub-expr without emitting another error, in order to avoid cascading
1414     // error cases.
1415     if (IV->isInvalidDecl())
1416       return ExprError();
1417 
1418     // Check whether we can reference this field.
1419     if (S.DiagnoseUseOfDecl(IV, MemberLoc))
1420       return ExprError();
1421     if (IV->getAccessControl() != ObjCIvarDecl::Public &&
1422         IV->getAccessControl() != ObjCIvarDecl::Package) {
1423       ObjCInterfaceDecl *ClassOfMethodDecl = nullptr;
1424       if (ObjCMethodDecl *MD = S.getCurMethodDecl())
1425         ClassOfMethodDecl =  MD->getClassInterface();
1426       else if (ObjCImpDecl && S.getCurFunctionDecl()) {
1427         // Case of a c-function declared inside an objc implementation.
1428         // FIXME: For a c-style function nested inside an objc implementation
1429         // class, there is no implementation context available, so we pass
1430         // down the context as argument to this routine. Ideally, this context
1431         // need be passed down in the AST node and somehow calculated from the
1432         // AST for a function decl.
1433         if (ObjCImplementationDecl *IMPD =
1434               dyn_cast<ObjCImplementationDecl>(ObjCImpDecl))
1435           ClassOfMethodDecl = IMPD->getClassInterface();
1436         else if (ObjCCategoryImplDecl* CatImplClass =
1437                    dyn_cast<ObjCCategoryImplDecl>(ObjCImpDecl))
1438           ClassOfMethodDecl = CatImplClass->getClassInterface();
1439       }
1440       if (!S.getLangOpts().DebuggerSupport) {
1441         if (IV->getAccessControl() == ObjCIvarDecl::Private) {
1442           if (!declaresSameEntity(ClassDeclared, IDecl) ||
1443               !declaresSameEntity(ClassOfMethodDecl, ClassDeclared))
1444             S.Diag(MemberLoc, diag::err_private_ivar_access)
1445               << IV->getDeclName();
1446         } else if (!IDecl->isSuperClassOf(ClassOfMethodDecl))
1447           // @protected
1448           S.Diag(MemberLoc, diag::err_protected_ivar_access)
1449               << IV->getDeclName();
1450       }
1451     }
1452     bool warn = true;
1453     if (S.getLangOpts().ObjCWeak) {
1454       Expr *BaseExp = BaseExpr.get()->IgnoreParenImpCasts();
1455       if (UnaryOperator *UO = dyn_cast<UnaryOperator>(BaseExp))
1456         if (UO->getOpcode() == UO_Deref)
1457           BaseExp = UO->getSubExpr()->IgnoreParenCasts();
1458 
1459       if (DeclRefExpr *DE = dyn_cast<DeclRefExpr>(BaseExp))
1460         if (DE->getType().getObjCLifetime() == Qualifiers::OCL_Weak) {
1461           S.Diag(DE->getLocation(), diag::err_arc_weak_ivar_access);
1462           warn = false;
1463         }
1464     }
1465     if (warn) {
1466       if (ObjCMethodDecl *MD = S.getCurMethodDecl()) {
1467         ObjCMethodFamily MF = MD->getMethodFamily();
1468         warn = (MF != OMF_init && MF != OMF_dealloc &&
1469                 MF != OMF_finalize &&
1470                 !S.IvarBacksCurrentMethodAccessor(IDecl, MD, IV));
1471       }
1472       if (warn)
1473         S.Diag(MemberLoc, diag::warn_direct_ivar_access) << IV->getDeclName();
1474     }
1475 
1476     ObjCIvarRefExpr *Result = new (S.Context) ObjCIvarRefExpr(
1477         IV, IV->getUsageType(BaseType), MemberLoc, OpLoc, BaseExpr.get(),
1478         IsArrow);
1479 
1480     if (IV->getType().getObjCLifetime() == Qualifiers::OCL_Weak) {
1481       if (!S.Diags.isIgnored(diag::warn_arc_repeated_use_of_weak, MemberLoc))
1482         S.recordUseOfEvaluatedWeak(Result);
1483     }
1484 
1485     return Result;
1486   }
1487 
1488   // Objective-C property access.
1489   const ObjCObjectPointerType *OPT;
1490   if (!IsArrow && (OPT = BaseType->getAs<ObjCObjectPointerType>())) {
1491     if (!SS.isEmpty() && !SS.isInvalid()) {
1492       S.Diag(SS.getRange().getBegin(), diag::err_qualified_objc_access)
1493           << 0 << SS.getScopeRep() << FixItHint::CreateRemoval(SS.getRange());
1494       SS.clear();
1495     }
1496 
1497     // This actually uses the base as an r-value.
1498     BaseExpr = S.DefaultLvalueConversion(BaseExpr.get());
1499     if (BaseExpr.isInvalid())
1500       return ExprError();
1501 
1502     assert(S.Context.hasSameUnqualifiedType(BaseType,
1503                                             BaseExpr.get()->getType()));
1504 
1505     IdentifierInfo *Member = MemberName.getAsIdentifierInfo();
1506 
1507     const ObjCObjectType *OT = OPT->getObjectType();
1508 
1509     // id, with and without qualifiers.
1510     if (OT->isObjCId()) {
1511       // Check protocols on qualified interfaces.
1512       Selector Sel = S.PP.getSelectorTable().getNullarySelector(Member);
1513       if (Decl *PMDecl =
1514               FindGetterSetterNameDecl(OPT, Member, Sel, S.Context)) {
1515         if (ObjCPropertyDecl *PD = dyn_cast<ObjCPropertyDecl>(PMDecl)) {
1516           // Check the use of this declaration
1517           if (S.DiagnoseUseOfDecl(PD, MemberLoc))
1518             return ExprError();
1519 
1520           return new (S.Context)
1521               ObjCPropertyRefExpr(PD, S.Context.PseudoObjectTy, VK_LValue,
1522                                   OK_ObjCProperty, MemberLoc, BaseExpr.get());
1523         }
1524 
1525         if (ObjCMethodDecl *OMD = dyn_cast<ObjCMethodDecl>(PMDecl)) {
1526           // Check the use of this method.
1527           if (S.DiagnoseUseOfDecl(OMD, MemberLoc))
1528             return ExprError();
1529           Selector SetterSel =
1530             SelectorTable::constructSetterSelector(S.PP.getIdentifierTable(),
1531                                                    S.PP.getSelectorTable(),
1532                                                    Member);
1533           ObjCMethodDecl *SMD = nullptr;
1534           if (Decl *SDecl = FindGetterSetterNameDecl(OPT,
1535                                                      /*Property id*/ nullptr,
1536                                                      SetterSel, S.Context))
1537             SMD = dyn_cast<ObjCMethodDecl>(SDecl);
1538 
1539           return new (S.Context)
1540               ObjCPropertyRefExpr(OMD, SMD, S.Context.PseudoObjectTy, VK_LValue,
1541                                   OK_ObjCProperty, MemberLoc, BaseExpr.get());
1542         }
1543       }
1544       // Use of id.member can only be for a property reference. Do not
1545       // use the 'id' redefinition in this case.
1546       if (IsArrow && ShouldTryAgainWithRedefinitionType(S, BaseExpr))
1547         return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1548                                 ObjCImpDecl, HasTemplateArgs);
1549 
1550       return ExprError(S.Diag(MemberLoc, diag::err_property_not_found)
1551                          << MemberName << BaseType);
1552     }
1553 
1554     // 'Class', unqualified only.
1555     if (OT->isObjCClass()) {
1556       // Only works in a method declaration (??!).
1557       ObjCMethodDecl *MD = S.getCurMethodDecl();
1558       if (!MD) {
1559         if (ShouldTryAgainWithRedefinitionType(S, BaseExpr))
1560           return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1561                                   ObjCImpDecl, HasTemplateArgs);
1562 
1563         goto fail;
1564       }
1565 
1566       // Also must look for a getter name which uses property syntax.
1567       Selector Sel = S.PP.getSelectorTable().getNullarySelector(Member);
1568       ObjCInterfaceDecl *IFace = MD->getClassInterface();
1569       ObjCMethodDecl *Getter;
1570       if ((Getter = IFace->lookupClassMethod(Sel))) {
1571         // Check the use of this method.
1572         if (S.DiagnoseUseOfDecl(Getter, MemberLoc))
1573           return ExprError();
1574       } else
1575         Getter = IFace->lookupPrivateMethod(Sel, false);
1576       // If we found a getter then this may be a valid dot-reference, we
1577       // will look for the matching setter, in case it is needed.
1578       Selector SetterSel =
1579         SelectorTable::constructSetterSelector(S.PP.getIdentifierTable(),
1580                                                S.PP.getSelectorTable(),
1581                                                Member);
1582       ObjCMethodDecl *Setter = IFace->lookupClassMethod(SetterSel);
1583       if (!Setter) {
1584         // If this reference is in an @implementation, also check for 'private'
1585         // methods.
1586         Setter = IFace->lookupPrivateMethod(SetterSel, false);
1587       }
1588 
1589       if (Setter && S.DiagnoseUseOfDecl(Setter, MemberLoc))
1590         return ExprError();
1591 
1592       if (Getter || Setter) {
1593         return new (S.Context) ObjCPropertyRefExpr(
1594             Getter, Setter, S.Context.PseudoObjectTy, VK_LValue,
1595             OK_ObjCProperty, MemberLoc, BaseExpr.get());
1596       }
1597 
1598       if (ShouldTryAgainWithRedefinitionType(S, BaseExpr))
1599         return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1600                                 ObjCImpDecl, HasTemplateArgs);
1601 
1602       return ExprError(S.Diag(MemberLoc, diag::err_property_not_found)
1603                          << MemberName << BaseType);
1604     }
1605 
1606     // Normal property access.
1607     return S.HandleExprPropertyRefExpr(OPT, BaseExpr.get(), OpLoc, MemberName,
1608                                        MemberLoc, SourceLocation(), QualType(),
1609                                        false);
1610   }
1611 
1612   // Handle 'field access' to vectors, such as 'V.xx'.
1613   if (BaseType->isExtVectorType()) {
1614     // FIXME: this expr should store IsArrow.
1615     IdentifierInfo *Member = MemberName.getAsIdentifierInfo();
1616     ExprValueKind VK;
1617     if (IsArrow)
1618       VK = VK_LValue;
1619     else {
1620       if (PseudoObjectExpr *POE = dyn_cast<PseudoObjectExpr>(BaseExpr.get()))
1621         VK = POE->getSyntacticForm()->getValueKind();
1622       else
1623         VK = BaseExpr.get()->getValueKind();
1624     }
1625     QualType ret = CheckExtVectorComponent(S, BaseType, VK, OpLoc,
1626                                            Member, MemberLoc);
1627     if (ret.isNull())
1628       return ExprError();
1629 
1630     return new (S.Context)
1631         ExtVectorElementExpr(ret, VK, BaseExpr.get(), *Member, MemberLoc);
1632   }
1633 
1634   // Adjust builtin-sel to the appropriate redefinition type if that's
1635   // not just a pointer to builtin-sel again.
1636   if (IsArrow && BaseType->isSpecificBuiltinType(BuiltinType::ObjCSel) &&
1637       !S.Context.getObjCSelRedefinitionType()->isObjCSelType()) {
1638     BaseExpr = S.ImpCastExprToType(
1639         BaseExpr.get(), S.Context.getObjCSelRedefinitionType(), CK_BitCast);
1640     return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1641                             ObjCImpDecl, HasTemplateArgs);
1642   }
1643 
1644   // Failure cases.
1645  fail:
1646 
1647   // Recover from dot accesses to pointers, e.g.:
1648   //   type *foo;
1649   //   foo.bar
1650   // This is actually well-formed in two cases:
1651   //   - 'type' is an Objective C type
1652   //   - 'bar' is a pseudo-destructor name which happens to refer to
1653   //     the appropriate pointer type
1654   if (const PointerType *Ptr = BaseType->getAs<PointerType>()) {
1655     if (!IsArrow && Ptr->getPointeeType()->isRecordType() &&
1656         MemberName.getNameKind() != DeclarationName::CXXDestructorName) {
1657       S.Diag(OpLoc, diag::err_typecheck_member_reference_suggestion)
1658           << BaseType << int(IsArrow) << BaseExpr.get()->getSourceRange()
1659           << FixItHint::CreateReplacement(OpLoc, "->");
1660 
1661       // Recurse as an -> access.
1662       IsArrow = true;
1663       return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1664                               ObjCImpDecl, HasTemplateArgs);
1665     }
1666   }
1667 
1668   // If the user is trying to apply -> or . to a function name, it's probably
1669   // because they forgot parentheses to call that function.
1670   if (S.tryToRecoverWithCall(
1671           BaseExpr, S.PDiag(diag::err_member_reference_needs_call),
1672           /*complain*/ false,
1673           IsArrow ? &isPointerToRecordType : &isRecordType)) {
1674     if (BaseExpr.isInvalid())
1675       return ExprError();
1676     BaseExpr = S.DefaultFunctionArrayConversion(BaseExpr.get());
1677     return LookupMemberExpr(S, R, BaseExpr, IsArrow, OpLoc, SS,
1678                             ObjCImpDecl, HasTemplateArgs);
1679   }
1680 
1681   S.Diag(OpLoc, diag::err_typecheck_member_reference_struct_union)
1682     << BaseType << BaseExpr.get()->getSourceRange() << MemberLoc;
1683 
1684   return ExprError();
1685 }
1686 
1687 /// The main callback when the parser finds something like
1688 ///   expression . [nested-name-specifier] identifier
1689 ///   expression -> [nested-name-specifier] identifier
1690 /// where 'identifier' encompasses a fairly broad spectrum of
1691 /// possibilities, including destructor and operator references.
1692 ///
1693 /// \param OpKind either tok::arrow or tok::period
1694 /// \param ObjCImpDecl the current Objective-C \@implementation
1695 ///   decl; this is an ugly hack around the fact that Objective-C
1696 ///   \@implementations aren't properly put in the context chain
1697 ExprResult Sema::ActOnMemberAccessExpr(Scope *S, Expr *Base,
1698                                        SourceLocation OpLoc,
1699                                        tok::TokenKind OpKind,
1700                                        CXXScopeSpec &SS,
1701                                        SourceLocation TemplateKWLoc,
1702                                        UnqualifiedId &Id,
1703                                        Decl *ObjCImpDecl) {
1704   if (SS.isSet() && SS.isInvalid())
1705     return ExprError();
1706 
1707   // Warn about the explicit constructor calls Microsoft extension.
1708   if (getLangOpts().MicrosoftExt &&
1709       Id.getKind() == UnqualifiedId::IK_ConstructorName)
1710     Diag(Id.getSourceRange().getBegin(),
1711          diag::ext_ms_explicit_constructor_call);
1712 
1713   TemplateArgumentListInfo TemplateArgsBuffer;
1714 
1715   // Decompose the name into its component parts.
1716   DeclarationNameInfo NameInfo;
1717   const TemplateArgumentListInfo *TemplateArgs;
1718   DecomposeUnqualifiedId(Id, TemplateArgsBuffer,
1719                          NameInfo, TemplateArgs);
1720 
1721   DeclarationName Name = NameInfo.getName();
1722   bool IsArrow = (OpKind == tok::arrow);
1723 
1724   NamedDecl *FirstQualifierInScope
1725     = (!SS.isSet() ? nullptr : FindFirstQualifierInScope(S, SS.getScopeRep()));
1726 
1727   // This is a postfix expression, so get rid of ParenListExprs.
1728   ExprResult Result = MaybeConvertParenListExprToParenExpr(S, Base);
1729   if (Result.isInvalid()) return ExprError();
1730   Base = Result.get();
1731 
1732   if (Base->getType()->isDependentType() || Name.isDependentName() ||
1733       isDependentScopeSpecifier(SS)) {
1734     return ActOnDependentMemberExpr(Base, Base->getType(), IsArrow, OpLoc, SS,
1735                                     TemplateKWLoc, FirstQualifierInScope,
1736                                     NameInfo, TemplateArgs);
1737   }
1738 
1739   ActOnMemberAccessExtraArgs ExtraArgs = {S, Id, ObjCImpDecl};
1740   return BuildMemberReferenceExpr(Base, Base->getType(), OpLoc, IsArrow, SS,
1741                                   TemplateKWLoc, FirstQualifierInScope,
1742                                   NameInfo, TemplateArgs, S, &ExtraArgs);
1743 }
1744 
1745 ExprResult
1746 Sema::BuildFieldReferenceExpr(Expr *BaseExpr, bool IsArrow,
1747                               SourceLocation OpLoc, const CXXScopeSpec &SS,
1748                               FieldDecl *Field, DeclAccessPair FoundDecl,
1749                               const DeclarationNameInfo &MemberNameInfo) {
1750   // x.a is an l-value if 'a' has a reference type. Otherwise:
1751   // x.a is an l-value/x-value/pr-value if the base is (and note
1752   //   that *x is always an l-value), except that if the base isn't
1753   //   an ordinary object then we must have an rvalue.
1754   ExprValueKind VK = VK_LValue;
1755   ExprObjectKind OK = OK_Ordinary;
1756   if (!IsArrow) {
1757     if (BaseExpr->getObjectKind() == OK_Ordinary)
1758       VK = BaseExpr->getValueKind();
1759     else
1760       VK = VK_RValue;
1761   }
1762   if (VK != VK_RValue && Field->isBitField())
1763     OK = OK_BitField;
1764 
1765   // Figure out the type of the member; see C99 6.5.2.3p3, C++ [expr.ref]
1766   QualType MemberType = Field->getType();
1767   if (const ReferenceType *Ref = MemberType->getAs<ReferenceType>()) {
1768     MemberType = Ref->getPointeeType();
1769     VK = VK_LValue;
1770   } else {
1771     QualType BaseType = BaseExpr->getType();
1772     if (IsArrow) BaseType = BaseType->getAs<PointerType>()->getPointeeType();
1773 
1774     Qualifiers BaseQuals = BaseType.getQualifiers();
1775 
1776     // GC attributes are never picked up by members.
1777     BaseQuals.removeObjCGCAttr();
1778 
1779     // CVR attributes from the base are picked up by members,
1780     // except that 'mutable' members don't pick up 'const'.
1781     if (Field->isMutable()) BaseQuals.removeConst();
1782 
1783     Qualifiers MemberQuals =
1784         Context.getCanonicalType(MemberType).getQualifiers();
1785 
1786     assert(!MemberQuals.hasAddressSpace());
1787 
1788     Qualifiers Combined = BaseQuals + MemberQuals;
1789     if (Combined != MemberQuals)
1790       MemberType = Context.getQualifiedType(MemberType, Combined);
1791   }
1792 
1793   UnusedPrivateFields.remove(Field);
1794 
1795   ExprResult Base = PerformObjectMemberConversion(BaseExpr, SS.getScopeRep(),
1796                                                   FoundDecl, Field);
1797   if (Base.isInvalid())
1798     return ExprError();
1799 
1800   // Build a reference to a private copy for non-static data members in
1801   // non-static member functions, privatized by OpenMP constructs.
1802   if (getLangOpts().OpenMP && IsArrow &&
1803       !CurContext->isDependentContext() &&
1804       isa<CXXThisExpr>(Base.get()->IgnoreParenImpCasts())) {
1805     if (auto *PrivateCopy = IsOpenMPCapturedDecl(Field)) {
1806       return getOpenMPCapturedExpr(PrivateCopy, VK, OK,
1807                                    MemberNameInfo.getLoc());
1808     }
1809   }
1810 
1811   return BuildMemberExpr(*this, Context, Base.get(), IsArrow, OpLoc, SS,
1812                          /*TemplateKWLoc=*/SourceLocation(), Field, FoundDecl,
1813                          MemberNameInfo, MemberType, VK, OK);
1814 }
1815 
1816 /// Builds an implicit member access expression.  The current context
1817 /// is known to be an instance method, and the given unqualified lookup
1818 /// set is known to contain only instance members, at least one of which
1819 /// is from an appropriate type.
1820 ExprResult
1821 Sema::BuildImplicitMemberExpr(const CXXScopeSpec &SS,
1822                               SourceLocation TemplateKWLoc,
1823                               LookupResult &R,
1824                               const TemplateArgumentListInfo *TemplateArgs,
1825                               bool IsKnownInstance, const Scope *S) {
1826   assert(!R.empty() && !R.isAmbiguous());
1827 
1828   SourceLocation loc = R.getNameLoc();
1829 
1830   // If this is known to be an instance access, go ahead and build an
1831   // implicit 'this' expression now.
1832   // 'this' expression now.
1833   QualType ThisTy = getCurrentThisType();
1834   assert(!ThisTy.isNull() && "didn't correctly pre-flight capture of 'this'");
1835 
1836   Expr *baseExpr = nullptr; // null signifies implicit access
1837   if (IsKnownInstance) {
1838     SourceLocation Loc = R.getNameLoc();
1839     if (SS.getRange().isValid())
1840       Loc = SS.getRange().getBegin();
1841     CheckCXXThisCapture(Loc);
1842     baseExpr = new (Context) CXXThisExpr(loc, ThisTy, /*isImplicit=*/true);
1843   }
1844 
1845   return BuildMemberReferenceExpr(baseExpr, ThisTy,
1846                                   /*OpLoc*/ SourceLocation(),
1847                                   /*IsArrow*/ true,
1848                                   SS, TemplateKWLoc,
1849                                   /*FirstQualifierInScope*/ nullptr,
1850                                   R, TemplateArgs, S);
1851 }
1852