1 //===--- SemaDecl.cpp - Semantic Analysis for Declarations ----------------===//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 //
10 //  This file implements semantic analysis for declarations.
11 //
12 //===----------------------------------------------------------------------===//
13 
14 #include "TypeLocBuilder.h"
15 #include "clang/AST/ASTConsumer.h"
16 #include "clang/AST/ASTContext.h"
17 #include "clang/AST/ASTLambda.h"
18 #include "clang/AST/CXXInheritance.h"
19 #include "clang/AST/CharUnits.h"
20 #include "clang/AST/CommentDiagnostic.h"
21 #include "clang/AST/DeclCXX.h"
22 #include "clang/AST/DeclObjC.h"
23 #include "clang/AST/DeclTemplate.h"
24 #include "clang/AST/EvaluatedExprVisitor.h"
25 #include "clang/AST/ExprCXX.h"
26 #include "clang/AST/StmtCXX.h"
27 #include "clang/Basic/Builtins.h"
28 #include "clang/Basic/PartialDiagnostic.h"
29 #include "clang/Basic/SourceManager.h"
30 #include "clang/Basic/TargetInfo.h"
31 #include "clang/Lex/HeaderSearch.h" // TODO: Sema shouldn't depend on Lex
32 #include "clang/Lex/Lexer.h" // TODO: Extract static functions to fix layering.
33 #include "clang/Lex/ModuleLoader.h" // TODO: Sema shouldn't depend on Lex
34 #include "clang/Lex/Preprocessor.h" // Included for isCodeCompletionEnabled()
35 #include "clang/Sema/CXXFieldCollector.h"
36 #include "clang/Sema/DeclSpec.h"
37 #include "clang/Sema/DelayedDiagnostic.h"
38 #include "clang/Sema/Initialization.h"
39 #include "clang/Sema/Lookup.h"
40 #include "clang/Sema/ParsedTemplate.h"
41 #include "clang/Sema/Scope.h"
42 #include "clang/Sema/ScopeInfo.h"
43 #include "clang/Sema/SemaInternal.h"
44 #include "clang/Sema/Template.h"
45 #include "llvm/ADT/SmallString.h"
46 #include "llvm/ADT/Triple.h"
47 #include <algorithm>
48 #include <cstring>
49 #include <functional>
50 
51 using namespace clang;
52 using namespace sema;
53 
54 Sema::DeclGroupPtrTy Sema::ConvertDeclToDeclGroup(Decl *Ptr, Decl *OwnedType) {
55   if (OwnedType) {
56     Decl *Group[2] = { OwnedType, Ptr };
57     return DeclGroupPtrTy::make(DeclGroupRef::Create(Context, Group, 2));
58   }
59 
60   return DeclGroupPtrTy::make(DeclGroupRef(Ptr));
61 }
62 
63 namespace {
64 
65 class TypeNameValidatorCCC : public CorrectionCandidateCallback {
66  public:
67    TypeNameValidatorCCC(bool AllowInvalid, bool WantClass = false,
68                         bool AllowTemplates = false,
69                         bool AllowNonTemplates = true)
70        : AllowInvalidDecl(AllowInvalid), WantClassName(WantClass),
71          AllowTemplates(AllowTemplates), AllowNonTemplates(AllowNonTemplates) {
72      WantExpressionKeywords = false;
73      WantCXXNamedCasts = false;
74      WantRemainingKeywords = false;
75   }
76 
77   bool ValidateCandidate(const TypoCorrection &candidate) override {
78     if (NamedDecl *ND = candidate.getCorrectionDecl()) {
79       if (!AllowInvalidDecl && ND->isInvalidDecl())
80         return false;
81 
82       if (getAsTypeTemplateDecl(ND))
83         return AllowTemplates;
84 
85       bool IsType = isa<TypeDecl>(ND) || isa<ObjCInterfaceDecl>(ND);
86       if (!IsType)
87         return false;
88 
89       if (AllowNonTemplates)
90         return true;
91 
92       // An injected-class-name of a class template (specialization) is valid
93       // as a template or as a non-template.
94       if (AllowTemplates) {
95         auto *RD = dyn_cast<CXXRecordDecl>(ND);
96         if (!RD || !RD->isInjectedClassName())
97           return false;
98         RD = cast<CXXRecordDecl>(RD->getDeclContext());
99         return RD->getDescribedClassTemplate() ||
100                isa<ClassTemplateSpecializationDecl>(RD);
101       }
102 
103       return false;
104     }
105 
106     return !WantClassName && candidate.isKeyword();
107   }
108 
109  private:
110   bool AllowInvalidDecl;
111   bool WantClassName;
112   bool AllowTemplates;
113   bool AllowNonTemplates;
114 };
115 
116 } // end anonymous namespace
117 
118 /// \brief Determine whether the token kind starts a simple-type-specifier.
119 bool Sema::isSimpleTypeSpecifier(tok::TokenKind Kind) const {
120   switch (Kind) {
121   // FIXME: Take into account the current language when deciding whether a
122   // token kind is a valid type specifier
123   case tok::kw_short:
124   case tok::kw_long:
125   case tok::kw___int64:
126   case tok::kw___int128:
127   case tok::kw_signed:
128   case tok::kw_unsigned:
129   case tok::kw_void:
130   case tok::kw_char:
131   case tok::kw_int:
132   case tok::kw_half:
133   case tok::kw_float:
134   case tok::kw_double:
135   case tok::kw__Float16:
136   case tok::kw___float128:
137   case tok::kw_wchar_t:
138   case tok::kw_bool:
139   case tok::kw___underlying_type:
140   case tok::kw___auto_type:
141     return true;
142 
143   case tok::annot_typename:
144   case tok::kw_char16_t:
145   case tok::kw_char32_t:
146   case tok::kw_typeof:
147   case tok::annot_decltype:
148   case tok::kw_decltype:
149     return getLangOpts().CPlusPlus;
150 
151   default:
152     break;
153   }
154 
155   return false;
156 }
157 
158 namespace {
159 enum class UnqualifiedTypeNameLookupResult {
160   NotFound,
161   FoundNonType,
162   FoundType
163 };
164 } // end anonymous namespace
165 
166 /// \brief Tries to perform unqualified lookup of the type decls in bases for
167 /// dependent class.
168 /// \return \a NotFound if no any decls is found, \a FoundNotType if found not a
169 /// type decl, \a FoundType if only type decls are found.
170 static UnqualifiedTypeNameLookupResult
171 lookupUnqualifiedTypeNameInBase(Sema &S, const IdentifierInfo &II,
172                                 SourceLocation NameLoc,
173                                 const CXXRecordDecl *RD) {
174   if (!RD->hasDefinition())
175     return UnqualifiedTypeNameLookupResult::NotFound;
176   // Look for type decls in base classes.
177   UnqualifiedTypeNameLookupResult FoundTypeDecl =
178       UnqualifiedTypeNameLookupResult::NotFound;
179   for (const auto &Base : RD->bases()) {
180     const CXXRecordDecl *BaseRD = nullptr;
181     if (auto *BaseTT = Base.getType()->getAs<TagType>())
182       BaseRD = BaseTT->getAsCXXRecordDecl();
183     else if (auto *TST = Base.getType()->getAs<TemplateSpecializationType>()) {
184       // Look for type decls in dependent base classes that have known primary
185       // templates.
186       if (!TST || !TST->isDependentType())
187         continue;
188       auto *TD = TST->getTemplateName().getAsTemplateDecl();
189       if (!TD)
190         continue;
191       if (auto *BasePrimaryTemplate =
192           dyn_cast_or_null<CXXRecordDecl>(TD->getTemplatedDecl())) {
193         if (BasePrimaryTemplate->getCanonicalDecl() != RD->getCanonicalDecl())
194           BaseRD = BasePrimaryTemplate;
195         else if (auto *CTD = dyn_cast<ClassTemplateDecl>(TD)) {
196           if (const ClassTemplatePartialSpecializationDecl *PS =
197                   CTD->findPartialSpecialization(Base.getType()))
198             if (PS->getCanonicalDecl() != RD->getCanonicalDecl())
199               BaseRD = PS;
200         }
201       }
202     }
203     if (BaseRD) {
204       for (NamedDecl *ND : BaseRD->lookup(&II)) {
205         if (!isa<TypeDecl>(ND))
206           return UnqualifiedTypeNameLookupResult::FoundNonType;
207         FoundTypeDecl = UnqualifiedTypeNameLookupResult::FoundType;
208       }
209       if (FoundTypeDecl == UnqualifiedTypeNameLookupResult::NotFound) {
210         switch (lookupUnqualifiedTypeNameInBase(S, II, NameLoc, BaseRD)) {
211         case UnqualifiedTypeNameLookupResult::FoundNonType:
212           return UnqualifiedTypeNameLookupResult::FoundNonType;
213         case UnqualifiedTypeNameLookupResult::FoundType:
214           FoundTypeDecl = UnqualifiedTypeNameLookupResult::FoundType;
215           break;
216         case UnqualifiedTypeNameLookupResult::NotFound:
217           break;
218         }
219       }
220     }
221   }
222 
223   return FoundTypeDecl;
224 }
225 
226 static ParsedType recoverFromTypeInKnownDependentBase(Sema &S,
227                                                       const IdentifierInfo &II,
228                                                       SourceLocation NameLoc) {
229   // Lookup in the parent class template context, if any.
230   const CXXRecordDecl *RD = nullptr;
231   UnqualifiedTypeNameLookupResult FoundTypeDecl =
232       UnqualifiedTypeNameLookupResult::NotFound;
233   for (DeclContext *DC = S.CurContext;
234        DC && FoundTypeDecl == UnqualifiedTypeNameLookupResult::NotFound;
235        DC = DC->getParent()) {
236     // Look for type decls in dependent base classes that have known primary
237     // templates.
238     RD = dyn_cast<CXXRecordDecl>(DC);
239     if (RD && RD->getDescribedClassTemplate())
240       FoundTypeDecl = lookupUnqualifiedTypeNameInBase(S, II, NameLoc, RD);
241   }
242   if (FoundTypeDecl != UnqualifiedTypeNameLookupResult::FoundType)
243     return nullptr;
244 
245   // We found some types in dependent base classes.  Recover as if the user
246   // wrote 'typename MyClass::II' instead of 'II'.  We'll fully resolve the
247   // lookup during template instantiation.
248   S.Diag(NameLoc, diag::ext_found_via_dependent_bases_lookup) << &II;
249 
250   ASTContext &Context = S.Context;
251   auto *NNS = NestedNameSpecifier::Create(Context, nullptr, false,
252                                           cast<Type>(Context.getRecordType(RD)));
253   QualType T = Context.getDependentNameType(ETK_Typename, NNS, &II);
254 
255   CXXScopeSpec SS;
256   SS.MakeTrivial(Context, NNS, SourceRange(NameLoc));
257 
258   TypeLocBuilder Builder;
259   DependentNameTypeLoc DepTL = Builder.push<DependentNameTypeLoc>(T);
260   DepTL.setNameLoc(NameLoc);
261   DepTL.setElaboratedKeywordLoc(SourceLocation());
262   DepTL.setQualifierLoc(SS.getWithLocInContext(Context));
263   return S.CreateParsedType(T, Builder.getTypeSourceInfo(Context, T));
264 }
265 
266 /// \brief If the identifier refers to a type name within this scope,
267 /// return the declaration of that type.
268 ///
269 /// This routine performs ordinary name lookup of the identifier II
270 /// within the given scope, with optional C++ scope specifier SS, to
271 /// determine whether the name refers to a type. If so, returns an
272 /// opaque pointer (actually a QualType) corresponding to that
273 /// type. Otherwise, returns NULL.
274 ParsedType Sema::getTypeName(const IdentifierInfo &II, SourceLocation NameLoc,
275                              Scope *S, CXXScopeSpec *SS,
276                              bool isClassName, bool HasTrailingDot,
277                              ParsedType ObjectTypePtr,
278                              bool IsCtorOrDtorName,
279                              bool WantNontrivialTypeSourceInfo,
280                              bool IsClassTemplateDeductionContext,
281                              IdentifierInfo **CorrectedII) {
282   // FIXME: Consider allowing this outside C++1z mode as an extension.
283   bool AllowDeducedTemplate = IsClassTemplateDeductionContext &&
284                               getLangOpts().CPlusPlus1z && !IsCtorOrDtorName &&
285                               !isClassName && !HasTrailingDot;
286 
287   // Determine where we will perform name lookup.
288   DeclContext *LookupCtx = nullptr;
289   if (ObjectTypePtr) {
290     QualType ObjectType = ObjectTypePtr.get();
291     if (ObjectType->isRecordType())
292       LookupCtx = computeDeclContext(ObjectType);
293   } else if (SS && SS->isNotEmpty()) {
294     LookupCtx = computeDeclContext(*SS, false);
295 
296     if (!LookupCtx) {
297       if (isDependentScopeSpecifier(*SS)) {
298         // C++ [temp.res]p3:
299         //   A qualified-id that refers to a type and in which the
300         //   nested-name-specifier depends on a template-parameter (14.6.2)
301         //   shall be prefixed by the keyword typename to indicate that the
302         //   qualified-id denotes a type, forming an
303         //   elaborated-type-specifier (7.1.5.3).
304         //
305         // We therefore do not perform any name lookup if the result would
306         // refer to a member of an unknown specialization.
307         if (!isClassName && !IsCtorOrDtorName)
308           return nullptr;
309 
310         // We know from the grammar that this name refers to a type,
311         // so build a dependent node to describe the type.
312         if (WantNontrivialTypeSourceInfo)
313           return ActOnTypenameType(S, SourceLocation(), *SS, II, NameLoc).get();
314 
315         NestedNameSpecifierLoc QualifierLoc = SS->getWithLocInContext(Context);
316         QualType T = CheckTypenameType(ETK_None, SourceLocation(), QualifierLoc,
317                                        II, NameLoc);
318         return ParsedType::make(T);
319       }
320 
321       return nullptr;
322     }
323 
324     if (!LookupCtx->isDependentContext() &&
325         RequireCompleteDeclContext(*SS, LookupCtx))
326       return nullptr;
327   }
328 
329   // FIXME: LookupNestedNameSpecifierName isn't the right kind of
330   // lookup for class-names.
331   LookupNameKind Kind = isClassName ? LookupNestedNameSpecifierName :
332                                       LookupOrdinaryName;
333   LookupResult Result(*this, &II, NameLoc, Kind);
334   if (LookupCtx) {
335     // Perform "qualified" name lookup into the declaration context we
336     // computed, which is either the type of the base of a member access
337     // expression or the declaration context associated with a prior
338     // nested-name-specifier.
339     LookupQualifiedName(Result, LookupCtx);
340 
341     if (ObjectTypePtr && Result.empty()) {
342       // C++ [basic.lookup.classref]p3:
343       //   If the unqualified-id is ~type-name, the type-name is looked up
344       //   in the context of the entire postfix-expression. If the type T of
345       //   the object expression is of a class type C, the type-name is also
346       //   looked up in the scope of class C. At least one of the lookups shall
347       //   find a name that refers to (possibly cv-qualified) T.
348       LookupName(Result, S);
349     }
350   } else {
351     // Perform unqualified name lookup.
352     LookupName(Result, S);
353 
354     // For unqualified lookup in a class template in MSVC mode, look into
355     // dependent base classes where the primary class template is known.
356     if (Result.empty() && getLangOpts().MSVCCompat && (!SS || SS->isEmpty())) {
357       if (ParsedType TypeInBase =
358               recoverFromTypeInKnownDependentBase(*this, II, NameLoc))
359         return TypeInBase;
360     }
361   }
362 
363   NamedDecl *IIDecl = nullptr;
364   switch (Result.getResultKind()) {
365   case LookupResult::NotFound:
366   case LookupResult::NotFoundInCurrentInstantiation:
367     if (CorrectedII) {
368       TypoCorrection Correction =
369           CorrectTypo(Result.getLookupNameInfo(), Kind, S, SS,
370                       llvm::make_unique<TypeNameValidatorCCC>(
371                           true, isClassName, AllowDeducedTemplate),
372                       CTK_ErrorRecovery);
373       IdentifierInfo *NewII = Correction.getCorrectionAsIdentifierInfo();
374       TemplateTy Template;
375       bool MemberOfUnknownSpecialization;
376       UnqualifiedId TemplateName;
377       TemplateName.setIdentifier(NewII, NameLoc);
378       NestedNameSpecifier *NNS = Correction.getCorrectionSpecifier();
379       CXXScopeSpec NewSS, *NewSSPtr = SS;
380       if (SS && NNS) {
381         NewSS.MakeTrivial(Context, NNS, SourceRange(NameLoc));
382         NewSSPtr = &NewSS;
383       }
384       if (Correction && (NNS || NewII != &II) &&
385           // Ignore a correction to a template type as the to-be-corrected
386           // identifier is not a template (typo correction for template names
387           // is handled elsewhere).
388           !(getLangOpts().CPlusPlus && NewSSPtr &&
389             isTemplateName(S, *NewSSPtr, false, TemplateName, nullptr, false,
390                            Template, MemberOfUnknownSpecialization))) {
391         ParsedType Ty = getTypeName(*NewII, NameLoc, S, NewSSPtr,
392                                     isClassName, HasTrailingDot, ObjectTypePtr,
393                                     IsCtorOrDtorName,
394                                     WantNontrivialTypeSourceInfo,
395                                     IsClassTemplateDeductionContext);
396         if (Ty) {
397           diagnoseTypo(Correction,
398                        PDiag(diag::err_unknown_type_or_class_name_suggest)
399                          << Result.getLookupName() << isClassName);
400           if (SS && NNS)
401             SS->MakeTrivial(Context, NNS, SourceRange(NameLoc));
402           *CorrectedII = NewII;
403           return Ty;
404         }
405       }
406     }
407     // If typo correction failed or was not performed, fall through
408     LLVM_FALLTHROUGH;
409   case LookupResult::FoundOverloaded:
410   case LookupResult::FoundUnresolvedValue:
411     Result.suppressDiagnostics();
412     return nullptr;
413 
414   case LookupResult::Ambiguous:
415     // Recover from type-hiding ambiguities by hiding the type.  We'll
416     // do the lookup again when looking for an object, and we can
417     // diagnose the error then.  If we don't do this, then the error
418     // about hiding the type will be immediately followed by an error
419     // that only makes sense if the identifier was treated like a type.
420     if (Result.getAmbiguityKind() == LookupResult::AmbiguousTagHiding) {
421       Result.suppressDiagnostics();
422       return nullptr;
423     }
424 
425     // Look to see if we have a type anywhere in the list of results.
426     for (LookupResult::iterator Res = Result.begin(), ResEnd = Result.end();
427          Res != ResEnd; ++Res) {
428       if (isa<TypeDecl>(*Res) || isa<ObjCInterfaceDecl>(*Res) ||
429           (AllowDeducedTemplate && getAsTypeTemplateDecl(*Res))) {
430         if (!IIDecl ||
431             (*Res)->getLocation().getRawEncoding() <
432               IIDecl->getLocation().getRawEncoding())
433           IIDecl = *Res;
434       }
435     }
436 
437     if (!IIDecl) {
438       // None of the entities we found is a type, so there is no way
439       // to even assume that the result is a type. In this case, don't
440       // complain about the ambiguity. The parser will either try to
441       // perform this lookup again (e.g., as an object name), which
442       // will produce the ambiguity, or will complain that it expected
443       // a type name.
444       Result.suppressDiagnostics();
445       return nullptr;
446     }
447 
448     // We found a type within the ambiguous lookup; diagnose the
449     // ambiguity and then return that type. This might be the right
450     // answer, or it might not be, but it suppresses any attempt to
451     // perform the name lookup again.
452     break;
453 
454   case LookupResult::Found:
455     IIDecl = Result.getFoundDecl();
456     break;
457   }
458 
459   assert(IIDecl && "Didn't find decl");
460 
461   QualType T;
462   if (TypeDecl *TD = dyn_cast<TypeDecl>(IIDecl)) {
463     // C++ [class.qual]p2: A lookup that would find the injected-class-name
464     // instead names the constructors of the class, except when naming a class.
465     // This is ill-formed when we're not actually forming a ctor or dtor name.
466     auto *LookupRD = dyn_cast_or_null<CXXRecordDecl>(LookupCtx);
467     auto *FoundRD = dyn_cast<CXXRecordDecl>(TD);
468     if (!isClassName && !IsCtorOrDtorName && LookupRD && FoundRD &&
469         FoundRD->isInjectedClassName() &&
470         declaresSameEntity(LookupRD, cast<Decl>(FoundRD->getParent())))
471       Diag(NameLoc, diag::err_out_of_line_qualified_id_type_names_constructor)
472           << &II << /*Type*/1;
473 
474     DiagnoseUseOfDecl(IIDecl, NameLoc);
475 
476     T = Context.getTypeDeclType(TD);
477     MarkAnyDeclReferenced(TD->getLocation(), TD, /*OdrUse=*/false);
478   } else if (ObjCInterfaceDecl *IDecl = dyn_cast<ObjCInterfaceDecl>(IIDecl)) {
479     (void)DiagnoseUseOfDecl(IDecl, NameLoc);
480     if (!HasTrailingDot)
481       T = Context.getObjCInterfaceType(IDecl);
482   } else if (AllowDeducedTemplate) {
483     if (auto *TD = getAsTypeTemplateDecl(IIDecl))
484       T = Context.getDeducedTemplateSpecializationType(TemplateName(TD),
485                                                        QualType(), false);
486   }
487 
488   if (T.isNull()) {
489     // If it's not plausibly a type, suppress diagnostics.
490     Result.suppressDiagnostics();
491     return nullptr;
492   }
493 
494   // NOTE: avoid constructing an ElaboratedType(Loc) if this is a
495   // constructor or destructor name (in such a case, the scope specifier
496   // will be attached to the enclosing Expr or Decl node).
497   if (SS && SS->isNotEmpty() && !IsCtorOrDtorName &&
498       !isa<ObjCInterfaceDecl>(IIDecl)) {
499     if (WantNontrivialTypeSourceInfo) {
500       // Construct a type with type-source information.
501       TypeLocBuilder Builder;
502       Builder.pushTypeSpec(T).setNameLoc(NameLoc);
503 
504       T = getElaboratedType(ETK_None, *SS, T);
505       ElaboratedTypeLoc ElabTL = Builder.push<ElaboratedTypeLoc>(T);
506       ElabTL.setElaboratedKeywordLoc(SourceLocation());
507       ElabTL.setQualifierLoc(SS->getWithLocInContext(Context));
508       return CreateParsedType(T, Builder.getTypeSourceInfo(Context, T));
509     } else {
510       T = getElaboratedType(ETK_None, *SS, T);
511     }
512   }
513 
514   return ParsedType::make(T);
515 }
516 
517 // Builds a fake NNS for the given decl context.
518 static NestedNameSpecifier *
519 synthesizeCurrentNestedNameSpecifier(ASTContext &Context, DeclContext *DC) {
520   for (;; DC = DC->getLookupParent()) {
521     DC = DC->getPrimaryContext();
522     auto *ND = dyn_cast<NamespaceDecl>(DC);
523     if (ND && !ND->isInline() && !ND->isAnonymousNamespace())
524       return NestedNameSpecifier::Create(Context, nullptr, ND);
525     else if (auto *RD = dyn_cast<CXXRecordDecl>(DC))
526       return NestedNameSpecifier::Create(Context, nullptr, RD->isTemplateDecl(),
527                                          RD->getTypeForDecl());
528     else if (isa<TranslationUnitDecl>(DC))
529       return NestedNameSpecifier::GlobalSpecifier(Context);
530   }
531   llvm_unreachable("something isn't in TU scope?");
532 }
533 
534 /// Find the parent class with dependent bases of the innermost enclosing method
535 /// context. Do not look for enclosing CXXRecordDecls directly, or we will end
536 /// up allowing unqualified dependent type names at class-level, which MSVC
537 /// correctly rejects.
538 static const CXXRecordDecl *
539 findRecordWithDependentBasesOfEnclosingMethod(const DeclContext *DC) {
540   for (; DC && DC->isDependentContext(); DC = DC->getLookupParent()) {
541     DC = DC->getPrimaryContext();
542     if (const auto *MD = dyn_cast<CXXMethodDecl>(DC))
543       if (MD->getParent()->hasAnyDependentBases())
544         return MD->getParent();
545   }
546   return nullptr;
547 }
548 
549 ParsedType Sema::ActOnMSVCUnknownTypeName(const IdentifierInfo &II,
550                                           SourceLocation NameLoc,
551                                           bool IsTemplateTypeArg) {
552   assert(getLangOpts().MSVCCompat && "shouldn't be called in non-MSVC mode");
553 
554   NestedNameSpecifier *NNS = nullptr;
555   if (IsTemplateTypeArg && getCurScope()->isTemplateParamScope()) {
556     // If we weren't able to parse a default template argument, delay lookup
557     // until instantiation time by making a non-dependent DependentTypeName. We
558     // pretend we saw a NestedNameSpecifier referring to the current scope, and
559     // lookup is retried.
560     // FIXME: This hurts our diagnostic quality, since we get errors like "no
561     // type named 'Foo' in 'current_namespace'" when the user didn't write any
562     // name specifiers.
563     NNS = synthesizeCurrentNestedNameSpecifier(Context, CurContext);
564     Diag(NameLoc, diag::ext_ms_delayed_template_argument) << &II;
565   } else if (const CXXRecordDecl *RD =
566                  findRecordWithDependentBasesOfEnclosingMethod(CurContext)) {
567     // Build a DependentNameType that will perform lookup into RD at
568     // instantiation time.
569     NNS = NestedNameSpecifier::Create(Context, nullptr, RD->isTemplateDecl(),
570                                       RD->getTypeForDecl());
571 
572     // Diagnose that this identifier was undeclared, and retry the lookup during
573     // template instantiation.
574     Diag(NameLoc, diag::ext_undeclared_unqual_id_with_dependent_base) << &II
575                                                                       << RD;
576   } else {
577     // This is not a situation that we should recover from.
578     return ParsedType();
579   }
580 
581   QualType T = Context.getDependentNameType(ETK_None, NNS, &II);
582 
583   // Build type location information.  We synthesized the qualifier, so we have
584   // to build a fake NestedNameSpecifierLoc.
585   NestedNameSpecifierLocBuilder NNSLocBuilder;
586   NNSLocBuilder.MakeTrivial(Context, NNS, SourceRange(NameLoc));
587   NestedNameSpecifierLoc QualifierLoc = NNSLocBuilder.getWithLocInContext(Context);
588 
589   TypeLocBuilder Builder;
590   DependentNameTypeLoc DepTL = Builder.push<DependentNameTypeLoc>(T);
591   DepTL.setNameLoc(NameLoc);
592   DepTL.setElaboratedKeywordLoc(SourceLocation());
593   DepTL.setQualifierLoc(QualifierLoc);
594   return CreateParsedType(T, Builder.getTypeSourceInfo(Context, T));
595 }
596 
597 /// isTagName() - This method is called *for error recovery purposes only*
598 /// to determine if the specified name is a valid tag name ("struct foo").  If
599 /// so, this returns the TST for the tag corresponding to it (TST_enum,
600 /// TST_union, TST_struct, TST_interface, TST_class).  This is used to diagnose
601 /// cases in C where the user forgot to specify the tag.
602 DeclSpec::TST Sema::isTagName(IdentifierInfo &II, Scope *S) {
603   // Do a tag name lookup in this scope.
604   LookupResult R(*this, &II, SourceLocation(), LookupTagName);
605   LookupName(R, S, false);
606   R.suppressDiagnostics();
607   if (R.getResultKind() == LookupResult::Found)
608     if (const TagDecl *TD = R.getAsSingle<TagDecl>()) {
609       switch (TD->getTagKind()) {
610       case TTK_Struct: return DeclSpec::TST_struct;
611       case TTK_Interface: return DeclSpec::TST_interface;
612       case TTK_Union:  return DeclSpec::TST_union;
613       case TTK_Class:  return DeclSpec::TST_class;
614       case TTK_Enum:   return DeclSpec::TST_enum;
615       }
616     }
617 
618   return DeclSpec::TST_unspecified;
619 }
620 
621 /// isMicrosoftMissingTypename - In Microsoft mode, within class scope,
622 /// if a CXXScopeSpec's type is equal to the type of one of the base classes
623 /// then downgrade the missing typename error to a warning.
624 /// This is needed for MSVC compatibility; Example:
625 /// @code
626 /// template<class T> class A {
627 /// public:
628 ///   typedef int TYPE;
629 /// };
630 /// template<class T> class B : public A<T> {
631 /// public:
632 ///   A<T>::TYPE a; // no typename required because A<T> is a base class.
633 /// };
634 /// @endcode
635 bool Sema::isMicrosoftMissingTypename(const CXXScopeSpec *SS, Scope *S) {
636   if (CurContext->isRecord()) {
637     if (SS->getScopeRep()->getKind() == NestedNameSpecifier::Super)
638       return true;
639 
640     const Type *Ty = SS->getScopeRep()->getAsType();
641 
642     CXXRecordDecl *RD = cast<CXXRecordDecl>(CurContext);
643     for (const auto &Base : RD->bases())
644       if (Ty && Context.hasSameUnqualifiedType(QualType(Ty, 1), Base.getType()))
645         return true;
646     return S->isFunctionPrototypeScope();
647   }
648   return CurContext->isFunctionOrMethod() || S->isFunctionPrototypeScope();
649 }
650 
651 void Sema::DiagnoseUnknownTypeName(IdentifierInfo *&II,
652                                    SourceLocation IILoc,
653                                    Scope *S,
654                                    CXXScopeSpec *SS,
655                                    ParsedType &SuggestedType,
656                                    bool IsTemplateName) {
657   // Don't report typename errors for editor placeholders.
658   if (II->isEditorPlaceholder())
659     return;
660   // We don't have anything to suggest (yet).
661   SuggestedType = nullptr;
662 
663   // There may have been a typo in the name of the type. Look up typo
664   // results, in case we have something that we can suggest.
665   if (TypoCorrection Corrected =
666           CorrectTypo(DeclarationNameInfo(II, IILoc), LookupOrdinaryName, S, SS,
667                       llvm::make_unique<TypeNameValidatorCCC>(
668                           false, false, IsTemplateName, !IsTemplateName),
669                       CTK_ErrorRecovery)) {
670     // FIXME: Support error recovery for the template-name case.
671     bool CanRecover = !IsTemplateName;
672     if (Corrected.isKeyword()) {
673       // We corrected to a keyword.
674       diagnoseTypo(Corrected,
675                    PDiag(IsTemplateName ? diag::err_no_template_suggest
676                                         : diag::err_unknown_typename_suggest)
677                        << II);
678       II = Corrected.getCorrectionAsIdentifierInfo();
679     } else {
680       // We found a similarly-named type or interface; suggest that.
681       if (!SS || !SS->isSet()) {
682         diagnoseTypo(Corrected,
683                      PDiag(IsTemplateName ? diag::err_no_template_suggest
684                                           : diag::err_unknown_typename_suggest)
685                          << II, CanRecover);
686       } else if (DeclContext *DC = computeDeclContext(*SS, false)) {
687         std::string CorrectedStr(Corrected.getAsString(getLangOpts()));
688         bool DroppedSpecifier = Corrected.WillReplaceSpecifier() &&
689                                 II->getName().equals(CorrectedStr);
690         diagnoseTypo(Corrected,
691                      PDiag(IsTemplateName
692                                ? diag::err_no_member_template_suggest
693                                : diag::err_unknown_nested_typename_suggest)
694                          << II << DC << DroppedSpecifier << SS->getRange(),
695                      CanRecover);
696       } else {
697         llvm_unreachable("could not have corrected a typo here");
698       }
699 
700       if (!CanRecover)
701         return;
702 
703       CXXScopeSpec tmpSS;
704       if (Corrected.getCorrectionSpecifier())
705         tmpSS.MakeTrivial(Context, Corrected.getCorrectionSpecifier(),
706                           SourceRange(IILoc));
707       // FIXME: Support class template argument deduction here.
708       SuggestedType =
709           getTypeName(*Corrected.getCorrectionAsIdentifierInfo(), IILoc, S,
710                       tmpSS.isSet() ? &tmpSS : SS, false, false, nullptr,
711                       /*IsCtorOrDtorName=*/false,
712                       /*NonTrivialTypeSourceInfo=*/true);
713     }
714     return;
715   }
716 
717   if (getLangOpts().CPlusPlus && !IsTemplateName) {
718     // See if II is a class template that the user forgot to pass arguments to.
719     UnqualifiedId Name;
720     Name.setIdentifier(II, IILoc);
721     CXXScopeSpec EmptySS;
722     TemplateTy TemplateResult;
723     bool MemberOfUnknownSpecialization;
724     if (isTemplateName(S, SS ? *SS : EmptySS, /*hasTemplateKeyword=*/false,
725                        Name, nullptr, true, TemplateResult,
726                        MemberOfUnknownSpecialization) == TNK_Type_template) {
727       TemplateName TplName = TemplateResult.get();
728       Diag(IILoc, diag::err_template_missing_args)
729         << (int)getTemplateNameKindForDiagnostics(TplName) << TplName;
730       if (TemplateDecl *TplDecl = TplName.getAsTemplateDecl()) {
731         Diag(TplDecl->getLocation(), diag::note_template_decl_here)
732           << TplDecl->getTemplateParameters()->getSourceRange();
733       }
734       return;
735     }
736   }
737 
738   // FIXME: Should we move the logic that tries to recover from a missing tag
739   // (struct, union, enum) from Parser::ParseImplicitInt here, instead?
740 
741   if (!SS || (!SS->isSet() && !SS->isInvalid()))
742     Diag(IILoc, IsTemplateName ? diag::err_no_template
743                                : diag::err_unknown_typename)
744         << II;
745   else if (DeclContext *DC = computeDeclContext(*SS, false))
746     Diag(IILoc, IsTemplateName ? diag::err_no_member_template
747                                : diag::err_typename_nested_not_found)
748         << II << DC << SS->getRange();
749   else if (isDependentScopeSpecifier(*SS)) {
750     unsigned DiagID = diag::err_typename_missing;
751     if (getLangOpts().MSVCCompat && isMicrosoftMissingTypename(SS, S))
752       DiagID = diag::ext_typename_missing;
753 
754     Diag(SS->getRange().getBegin(), DiagID)
755       << SS->getScopeRep() << II->getName()
756       << SourceRange(SS->getRange().getBegin(), IILoc)
757       << FixItHint::CreateInsertion(SS->getRange().getBegin(), "typename ");
758     SuggestedType = ActOnTypenameType(S, SourceLocation(),
759                                       *SS, *II, IILoc).get();
760   } else {
761     assert(SS && SS->isInvalid() &&
762            "Invalid scope specifier has already been diagnosed");
763   }
764 }
765 
766 /// \brief Determine whether the given result set contains either a type name
767 /// or
768 static bool isResultTypeOrTemplate(LookupResult &R, const Token &NextToken) {
769   bool CheckTemplate = R.getSema().getLangOpts().CPlusPlus &&
770                        NextToken.is(tok::less);
771 
772   for (LookupResult::iterator I = R.begin(), IEnd = R.end(); I != IEnd; ++I) {
773     if (isa<TypeDecl>(*I) || isa<ObjCInterfaceDecl>(*I))
774       return true;
775 
776     if (CheckTemplate && isa<TemplateDecl>(*I))
777       return true;
778   }
779 
780   return false;
781 }
782 
783 static bool isTagTypeWithMissingTag(Sema &SemaRef, LookupResult &Result,
784                                     Scope *S, CXXScopeSpec &SS,
785                                     IdentifierInfo *&Name,
786                                     SourceLocation NameLoc) {
787   LookupResult R(SemaRef, Name, NameLoc, Sema::LookupTagName);
788   SemaRef.LookupParsedName(R, S, &SS);
789   if (TagDecl *Tag = R.getAsSingle<TagDecl>()) {
790     StringRef FixItTagName;
791     switch (Tag->getTagKind()) {
792       case TTK_Class:
793         FixItTagName = "class ";
794         break;
795 
796       case TTK_Enum:
797         FixItTagName = "enum ";
798         break;
799 
800       case TTK_Struct:
801         FixItTagName = "struct ";
802         break;
803 
804       case TTK_Interface:
805         FixItTagName = "__interface ";
806         break;
807 
808       case TTK_Union:
809         FixItTagName = "union ";
810         break;
811     }
812 
813     StringRef TagName = FixItTagName.drop_back();
814     SemaRef.Diag(NameLoc, diag::err_use_of_tag_name_without_tag)
815       << Name << TagName << SemaRef.getLangOpts().CPlusPlus
816       << FixItHint::CreateInsertion(NameLoc, FixItTagName);
817 
818     for (LookupResult::iterator I = Result.begin(), IEnd = Result.end();
819          I != IEnd; ++I)
820       SemaRef.Diag((*I)->getLocation(), diag::note_decl_hiding_tag_type)
821         << Name << TagName;
822 
823     // Replace lookup results with just the tag decl.
824     Result.clear(Sema::LookupTagName);
825     SemaRef.LookupParsedName(Result, S, &SS);
826     return true;
827   }
828 
829   return false;
830 }
831 
832 /// Build a ParsedType for a simple-type-specifier with a nested-name-specifier.
833 static ParsedType buildNestedType(Sema &S, CXXScopeSpec &SS,
834                                   QualType T, SourceLocation NameLoc) {
835   ASTContext &Context = S.Context;
836 
837   TypeLocBuilder Builder;
838   Builder.pushTypeSpec(T).setNameLoc(NameLoc);
839 
840   T = S.getElaboratedType(ETK_None, SS, T);
841   ElaboratedTypeLoc ElabTL = Builder.push<ElaboratedTypeLoc>(T);
842   ElabTL.setElaboratedKeywordLoc(SourceLocation());
843   ElabTL.setQualifierLoc(SS.getWithLocInContext(Context));
844   return S.CreateParsedType(T, Builder.getTypeSourceInfo(Context, T));
845 }
846 
847 Sema::NameClassification
848 Sema::ClassifyName(Scope *S, CXXScopeSpec &SS, IdentifierInfo *&Name,
849                    SourceLocation NameLoc, const Token &NextToken,
850                    bool IsAddressOfOperand,
851                    std::unique_ptr<CorrectionCandidateCallback> CCC) {
852   DeclarationNameInfo NameInfo(Name, NameLoc);
853   ObjCMethodDecl *CurMethod = getCurMethodDecl();
854 
855   if (NextToken.is(tok::coloncolon)) {
856     NestedNameSpecInfo IdInfo(Name, NameLoc, NextToken.getLocation());
857     BuildCXXNestedNameSpecifier(S, IdInfo, false, SS, nullptr, false);
858   } else if (getLangOpts().CPlusPlus && SS.isSet() &&
859              isCurrentClassName(*Name, S, &SS)) {
860     // Per [class.qual]p2, this names the constructors of SS, not the
861     // injected-class-name. We don't have a classification for that.
862     // There's not much point caching this result, since the parser
863     // will reject it later.
864     return NameClassification::Unknown();
865   }
866 
867   LookupResult Result(*this, Name, NameLoc, LookupOrdinaryName);
868   LookupParsedName(Result, S, &SS, !CurMethod);
869 
870   // For unqualified lookup in a class template in MSVC mode, look into
871   // dependent base classes where the primary class template is known.
872   if (Result.empty() && SS.isEmpty() && getLangOpts().MSVCCompat) {
873     if (ParsedType TypeInBase =
874             recoverFromTypeInKnownDependentBase(*this, *Name, NameLoc))
875       return TypeInBase;
876   }
877 
878   // Perform lookup for Objective-C instance variables (including automatically
879   // synthesized instance variables), if we're in an Objective-C method.
880   // FIXME: This lookup really, really needs to be folded in to the normal
881   // unqualified lookup mechanism.
882   if (!SS.isSet() && CurMethod && !isResultTypeOrTemplate(Result, NextToken)) {
883     ExprResult E = LookupInObjCMethod(Result, S, Name, true);
884     if (E.get() || E.isInvalid())
885       return E;
886   }
887 
888   bool SecondTry = false;
889   bool IsFilteredTemplateName = false;
890 
891 Corrected:
892   switch (Result.getResultKind()) {
893   case LookupResult::NotFound:
894     // If an unqualified-id is followed by a '(', then we have a function
895     // call.
896     if (!SS.isSet() && NextToken.is(tok::l_paren)) {
897       // In C++, this is an ADL-only call.
898       // FIXME: Reference?
899       if (getLangOpts().CPlusPlus)
900         return BuildDeclarationNameExpr(SS, Result, /*ADL=*/true);
901 
902       // C90 6.3.2.2:
903       //   If the expression that precedes the parenthesized argument list in a
904       //   function call consists solely of an identifier, and if no
905       //   declaration is visible for this identifier, the identifier is
906       //   implicitly declared exactly as if, in the innermost block containing
907       //   the function call, the declaration
908       //
909       //     extern int identifier ();
910       //
911       //   appeared.
912       //
913       // We also allow this in C99 as an extension.
914       if (NamedDecl *D = ImplicitlyDefineFunction(NameLoc, *Name, S)) {
915         Result.addDecl(D);
916         Result.resolveKind();
917         return BuildDeclarationNameExpr(SS, Result, /*ADL=*/false);
918       }
919     }
920 
921     // In C, we first see whether there is a tag type by the same name, in
922     // which case it's likely that the user just forgot to write "enum",
923     // "struct", or "union".
924     if (!getLangOpts().CPlusPlus && !SecondTry &&
925         isTagTypeWithMissingTag(*this, Result, S, SS, Name, NameLoc)) {
926       break;
927     }
928 
929     // Perform typo correction to determine if there is another name that is
930     // close to this name.
931     if (!SecondTry && CCC) {
932       SecondTry = true;
933       if (TypoCorrection Corrected = CorrectTypo(Result.getLookupNameInfo(),
934                                                  Result.getLookupKind(), S,
935                                                  &SS, std::move(CCC),
936                                                  CTK_ErrorRecovery)) {
937         unsigned UnqualifiedDiag = diag::err_undeclared_var_use_suggest;
938         unsigned QualifiedDiag = diag::err_no_member_suggest;
939 
940         NamedDecl *FirstDecl = Corrected.getFoundDecl();
941         NamedDecl *UnderlyingFirstDecl = Corrected.getCorrectionDecl();
942         if (getLangOpts().CPlusPlus && NextToken.is(tok::less) &&
943             UnderlyingFirstDecl && isa<TemplateDecl>(UnderlyingFirstDecl)) {
944           UnqualifiedDiag = diag::err_no_template_suggest;
945           QualifiedDiag = diag::err_no_member_template_suggest;
946         } else if (UnderlyingFirstDecl &&
947                    (isa<TypeDecl>(UnderlyingFirstDecl) ||
948                     isa<ObjCInterfaceDecl>(UnderlyingFirstDecl) ||
949                     isa<ObjCCompatibleAliasDecl>(UnderlyingFirstDecl))) {
950           UnqualifiedDiag = diag::err_unknown_typename_suggest;
951           QualifiedDiag = diag::err_unknown_nested_typename_suggest;
952         }
953 
954         if (SS.isEmpty()) {
955           diagnoseTypo(Corrected, PDiag(UnqualifiedDiag) << Name);
956         } else {// FIXME: is this even reachable? Test it.
957           std::string CorrectedStr(Corrected.getAsString(getLangOpts()));
958           bool DroppedSpecifier = Corrected.WillReplaceSpecifier() &&
959                                   Name->getName().equals(CorrectedStr);
960           diagnoseTypo(Corrected, PDiag(QualifiedDiag)
961                                     << Name << computeDeclContext(SS, false)
962                                     << DroppedSpecifier << SS.getRange());
963         }
964 
965         // Update the name, so that the caller has the new name.
966         Name = Corrected.getCorrectionAsIdentifierInfo();
967 
968         // Typo correction corrected to a keyword.
969         if (Corrected.isKeyword())
970           return Name;
971 
972         // Also update the LookupResult...
973         // FIXME: This should probably go away at some point
974         Result.clear();
975         Result.setLookupName(Corrected.getCorrection());
976         if (FirstDecl)
977           Result.addDecl(FirstDecl);
978 
979         // If we found an Objective-C instance variable, let
980         // LookupInObjCMethod build the appropriate expression to
981         // reference the ivar.
982         // FIXME: This is a gross hack.
983         if (ObjCIvarDecl *Ivar = Result.getAsSingle<ObjCIvarDecl>()) {
984           Result.clear();
985           ExprResult E(LookupInObjCMethod(Result, S, Ivar->getIdentifier()));
986           return E;
987         }
988 
989         goto Corrected;
990       }
991     }
992 
993     // We failed to correct; just fall through and let the parser deal with it.
994     Result.suppressDiagnostics();
995     return NameClassification::Unknown();
996 
997   case LookupResult::NotFoundInCurrentInstantiation: {
998     // We performed name lookup into the current instantiation, and there were
999     // dependent bases, so we treat this result the same way as any other
1000     // dependent nested-name-specifier.
1001 
1002     // C++ [temp.res]p2:
1003     //   A name used in a template declaration or definition and that is
1004     //   dependent on a template-parameter is assumed not to name a type
1005     //   unless the applicable name lookup finds a type name or the name is
1006     //   qualified by the keyword typename.
1007     //
1008     // FIXME: If the next token is '<', we might want to ask the parser to
1009     // perform some heroics to see if we actually have a
1010     // template-argument-list, which would indicate a missing 'template'
1011     // keyword here.
1012     return ActOnDependentIdExpression(SS, /*TemplateKWLoc=*/SourceLocation(),
1013                                       NameInfo, IsAddressOfOperand,
1014                                       /*TemplateArgs=*/nullptr);
1015   }
1016 
1017   case LookupResult::Found:
1018   case LookupResult::FoundOverloaded:
1019   case LookupResult::FoundUnresolvedValue:
1020     break;
1021 
1022   case LookupResult::Ambiguous:
1023     if (getLangOpts().CPlusPlus && NextToken.is(tok::less) &&
1024         hasAnyAcceptableTemplateNames(Result)) {
1025       // C++ [temp.local]p3:
1026       //   A lookup that finds an injected-class-name (10.2) can result in an
1027       //   ambiguity in certain cases (for example, if it is found in more than
1028       //   one base class). If all of the injected-class-names that are found
1029       //   refer to specializations of the same class template, and if the name
1030       //   is followed by a template-argument-list, the reference refers to the
1031       //   class template itself and not a specialization thereof, and is not
1032       //   ambiguous.
1033       //
1034       // This filtering can make an ambiguous result into an unambiguous one,
1035       // so try again after filtering out template names.
1036       FilterAcceptableTemplateNames(Result);
1037       if (!Result.isAmbiguous()) {
1038         IsFilteredTemplateName = true;
1039         break;
1040       }
1041     }
1042 
1043     // Diagnose the ambiguity and return an error.
1044     return NameClassification::Error();
1045   }
1046 
1047   if (getLangOpts().CPlusPlus && NextToken.is(tok::less) &&
1048       (IsFilteredTemplateName || hasAnyAcceptableTemplateNames(Result))) {
1049     // C++ [temp.names]p3:
1050     //   After name lookup (3.4) finds that a name is a template-name or that
1051     //   an operator-function-id or a literal- operator-id refers to a set of
1052     //   overloaded functions any member of which is a function template if
1053     //   this is followed by a <, the < is always taken as the delimiter of a
1054     //   template-argument-list and never as the less-than operator.
1055     if (!IsFilteredTemplateName)
1056       FilterAcceptableTemplateNames(Result);
1057 
1058     if (!Result.empty()) {
1059       bool IsFunctionTemplate;
1060       bool IsVarTemplate;
1061       TemplateName Template;
1062       if (Result.end() - Result.begin() > 1) {
1063         IsFunctionTemplate = true;
1064         Template = Context.getOverloadedTemplateName(Result.begin(),
1065                                                      Result.end());
1066       } else {
1067         TemplateDecl *TD
1068           = cast<TemplateDecl>((*Result.begin())->getUnderlyingDecl());
1069         IsFunctionTemplate = isa<FunctionTemplateDecl>(TD);
1070         IsVarTemplate = isa<VarTemplateDecl>(TD);
1071 
1072         if (SS.isSet() && !SS.isInvalid())
1073           Template = Context.getQualifiedTemplateName(SS.getScopeRep(),
1074                                                     /*TemplateKeyword=*/false,
1075                                                       TD);
1076         else
1077           Template = TemplateName(TD);
1078       }
1079 
1080       if (IsFunctionTemplate) {
1081         // Function templates always go through overload resolution, at which
1082         // point we'll perform the various checks (e.g., accessibility) we need
1083         // to based on which function we selected.
1084         Result.suppressDiagnostics();
1085 
1086         return NameClassification::FunctionTemplate(Template);
1087       }
1088 
1089       return IsVarTemplate ? NameClassification::VarTemplate(Template)
1090                            : NameClassification::TypeTemplate(Template);
1091     }
1092   }
1093 
1094   NamedDecl *FirstDecl = (*Result.begin())->getUnderlyingDecl();
1095   if (TypeDecl *Type = dyn_cast<TypeDecl>(FirstDecl)) {
1096     DiagnoseUseOfDecl(Type, NameLoc);
1097     MarkAnyDeclReferenced(Type->getLocation(), Type, /*OdrUse=*/false);
1098     QualType T = Context.getTypeDeclType(Type);
1099     if (SS.isNotEmpty())
1100       return buildNestedType(*this, SS, T, NameLoc);
1101     return ParsedType::make(T);
1102   }
1103 
1104   ObjCInterfaceDecl *Class = dyn_cast<ObjCInterfaceDecl>(FirstDecl);
1105   if (!Class) {
1106     // FIXME: It's unfortunate that we don't have a Type node for handling this.
1107     if (ObjCCompatibleAliasDecl *Alias =
1108             dyn_cast<ObjCCompatibleAliasDecl>(FirstDecl))
1109       Class = Alias->getClassInterface();
1110   }
1111 
1112   if (Class) {
1113     DiagnoseUseOfDecl(Class, NameLoc);
1114 
1115     if (NextToken.is(tok::period)) {
1116       // Interface. <something> is parsed as a property reference expression.
1117       // Just return "unknown" as a fall-through for now.
1118       Result.suppressDiagnostics();
1119       return NameClassification::Unknown();
1120     }
1121 
1122     QualType T = Context.getObjCInterfaceType(Class);
1123     return ParsedType::make(T);
1124   }
1125 
1126   // We can have a type template here if we're classifying a template argument.
1127   if (isa<TemplateDecl>(FirstDecl) && !isa<FunctionTemplateDecl>(FirstDecl) &&
1128       !isa<VarTemplateDecl>(FirstDecl))
1129     return NameClassification::TypeTemplate(
1130         TemplateName(cast<TemplateDecl>(FirstDecl)));
1131 
1132   // Check for a tag type hidden by a non-type decl in a few cases where it
1133   // seems likely a type is wanted instead of the non-type that was found.
1134   bool NextIsOp = NextToken.isOneOf(tok::amp, tok::star);
1135   if ((NextToken.is(tok::identifier) ||
1136        (NextIsOp &&
1137         FirstDecl->getUnderlyingDecl()->isFunctionOrFunctionTemplate())) &&
1138       isTagTypeWithMissingTag(*this, Result, S, SS, Name, NameLoc)) {
1139     TypeDecl *Type = Result.getAsSingle<TypeDecl>();
1140     DiagnoseUseOfDecl(Type, NameLoc);
1141     QualType T = Context.getTypeDeclType(Type);
1142     if (SS.isNotEmpty())
1143       return buildNestedType(*this, SS, T, NameLoc);
1144     return ParsedType::make(T);
1145   }
1146 
1147   if (FirstDecl->isCXXClassMember())
1148     return BuildPossibleImplicitMemberExpr(SS, SourceLocation(), Result,
1149                                            nullptr, S);
1150 
1151   bool ADL = UseArgumentDependentLookup(SS, Result, NextToken.is(tok::l_paren));
1152   return BuildDeclarationNameExpr(SS, Result, ADL);
1153 }
1154 
1155 Sema::TemplateNameKindForDiagnostics
1156 Sema::getTemplateNameKindForDiagnostics(TemplateName Name) {
1157   auto *TD = Name.getAsTemplateDecl();
1158   if (!TD)
1159     return TemplateNameKindForDiagnostics::DependentTemplate;
1160   if (isa<ClassTemplateDecl>(TD))
1161     return TemplateNameKindForDiagnostics::ClassTemplate;
1162   if (isa<FunctionTemplateDecl>(TD))
1163     return TemplateNameKindForDiagnostics::FunctionTemplate;
1164   if (isa<VarTemplateDecl>(TD))
1165     return TemplateNameKindForDiagnostics::VarTemplate;
1166   if (isa<TypeAliasTemplateDecl>(TD))
1167     return TemplateNameKindForDiagnostics::AliasTemplate;
1168   if (isa<TemplateTemplateParmDecl>(TD))
1169     return TemplateNameKindForDiagnostics::TemplateTemplateParam;
1170   return TemplateNameKindForDiagnostics::DependentTemplate;
1171 }
1172 
1173 // Determines the context to return to after temporarily entering a
1174 // context.  This depends in an unnecessarily complicated way on the
1175 // exact ordering of callbacks from the parser.
1176 DeclContext *Sema::getContainingDC(DeclContext *DC) {
1177 
1178   // Functions defined inline within classes aren't parsed until we've
1179   // finished parsing the top-level class, so the top-level class is
1180   // the context we'll need to return to.
1181   // A Lambda call operator whose parent is a class must not be treated
1182   // as an inline member function.  A Lambda can be used legally
1183   // either as an in-class member initializer or a default argument.  These
1184   // are parsed once the class has been marked complete and so the containing
1185   // context would be the nested class (when the lambda is defined in one);
1186   // If the class is not complete, then the lambda is being used in an
1187   // ill-formed fashion (such as to specify the width of a bit-field, or
1188   // in an array-bound) - in which case we still want to return the
1189   // lexically containing DC (which could be a nested class).
1190   if (isa<FunctionDecl>(DC) && !isLambdaCallOperator(DC)) {
1191     DC = DC->getLexicalParent();
1192 
1193     // A function not defined within a class will always return to its
1194     // lexical context.
1195     if (!isa<CXXRecordDecl>(DC))
1196       return DC;
1197 
1198     // A C++ inline method/friend is parsed *after* the topmost class
1199     // it was declared in is fully parsed ("complete");  the topmost
1200     // class is the context we need to return to.
1201     while (CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(DC->getLexicalParent()))
1202       DC = RD;
1203 
1204     // Return the declaration context of the topmost class the inline method is
1205     // declared in.
1206     return DC;
1207   }
1208 
1209   return DC->getLexicalParent();
1210 }
1211 
1212 void Sema::PushDeclContext(Scope *S, DeclContext *DC) {
1213   assert(getContainingDC(DC) == CurContext &&
1214       "The next DeclContext should be lexically contained in the current one.");
1215   CurContext = DC;
1216   S->setEntity(DC);
1217 }
1218 
1219 void Sema::PopDeclContext() {
1220   assert(CurContext && "DeclContext imbalance!");
1221 
1222   CurContext = getContainingDC(CurContext);
1223   assert(CurContext && "Popped translation unit!");
1224 }
1225 
1226 Sema::SkippedDefinitionContext Sema::ActOnTagStartSkippedDefinition(Scope *S,
1227                                                                     Decl *D) {
1228   // Unlike PushDeclContext, the context to which we return is not necessarily
1229   // the containing DC of TD, because the new context will be some pre-existing
1230   // TagDecl definition instead of a fresh one.
1231   auto Result = static_cast<SkippedDefinitionContext>(CurContext);
1232   CurContext = cast<TagDecl>(D)->getDefinition();
1233   assert(CurContext && "skipping definition of undefined tag");
1234   // Start lookups from the parent of the current context; we don't want to look
1235   // into the pre-existing complete definition.
1236   S->setEntity(CurContext->getLookupParent());
1237   return Result;
1238 }
1239 
1240 void Sema::ActOnTagFinishSkippedDefinition(SkippedDefinitionContext Context) {
1241   CurContext = static_cast<decltype(CurContext)>(Context);
1242 }
1243 
1244 /// EnterDeclaratorContext - Used when we must lookup names in the context
1245 /// of a declarator's nested name specifier.
1246 ///
1247 void Sema::EnterDeclaratorContext(Scope *S, DeclContext *DC) {
1248   // C++0x [basic.lookup.unqual]p13:
1249   //   A name used in the definition of a static data member of class
1250   //   X (after the qualified-id of the static member) is looked up as
1251   //   if the name was used in a member function of X.
1252   // C++0x [basic.lookup.unqual]p14:
1253   //   If a variable member of a namespace is defined outside of the
1254   //   scope of its namespace then any name used in the definition of
1255   //   the variable member (after the declarator-id) is looked up as
1256   //   if the definition of the variable member occurred in its
1257   //   namespace.
1258   // Both of these imply that we should push a scope whose context
1259   // is the semantic context of the declaration.  We can't use
1260   // PushDeclContext here because that context is not necessarily
1261   // lexically contained in the current context.  Fortunately,
1262   // the containing scope should have the appropriate information.
1263 
1264   assert(!S->getEntity() && "scope already has entity");
1265 
1266 #ifndef NDEBUG
1267   Scope *Ancestor = S->getParent();
1268   while (!Ancestor->getEntity()) Ancestor = Ancestor->getParent();
1269   assert(Ancestor->getEntity() == CurContext && "ancestor context mismatch");
1270 #endif
1271 
1272   CurContext = DC;
1273   S->setEntity(DC);
1274 }
1275 
1276 void Sema::ExitDeclaratorContext(Scope *S) {
1277   assert(S->getEntity() == CurContext && "Context imbalance!");
1278 
1279   // Switch back to the lexical context.  The safety of this is
1280   // enforced by an assert in EnterDeclaratorContext.
1281   Scope *Ancestor = S->getParent();
1282   while (!Ancestor->getEntity()) Ancestor = Ancestor->getParent();
1283   CurContext = Ancestor->getEntity();
1284 
1285   // We don't need to do anything with the scope, which is going to
1286   // disappear.
1287 }
1288 
1289 void Sema::ActOnReenterFunctionContext(Scope* S, Decl *D) {
1290   // We assume that the caller has already called
1291   // ActOnReenterTemplateScope so getTemplatedDecl() works.
1292   FunctionDecl *FD = D->getAsFunction();
1293   if (!FD)
1294     return;
1295 
1296   // Same implementation as PushDeclContext, but enters the context
1297   // from the lexical parent, rather than the top-level class.
1298   assert(CurContext == FD->getLexicalParent() &&
1299     "The next DeclContext should be lexically contained in the current one.");
1300   CurContext = FD;
1301   S->setEntity(CurContext);
1302 
1303   for (unsigned P = 0, NumParams = FD->getNumParams(); P < NumParams; ++P) {
1304     ParmVarDecl *Param = FD->getParamDecl(P);
1305     // If the parameter has an identifier, then add it to the scope
1306     if (Param->getIdentifier()) {
1307       S->AddDecl(Param);
1308       IdResolver.AddDecl(Param);
1309     }
1310   }
1311 }
1312 
1313 void Sema::ActOnExitFunctionContext() {
1314   // Same implementation as PopDeclContext, but returns to the lexical parent,
1315   // rather than the top-level class.
1316   assert(CurContext && "DeclContext imbalance!");
1317   CurContext = CurContext->getLexicalParent();
1318   assert(CurContext && "Popped translation unit!");
1319 }
1320 
1321 /// \brief Determine whether we allow overloading of the function
1322 /// PrevDecl with another declaration.
1323 ///
1324 /// This routine determines whether overloading is possible, not
1325 /// whether some new function is actually an overload. It will return
1326 /// true in C++ (where we can always provide overloads) or, as an
1327 /// extension, in C when the previous function is already an
1328 /// overloaded function declaration or has the "overloadable"
1329 /// attribute.
1330 static bool AllowOverloadingOfFunction(LookupResult &Previous,
1331                                        ASTContext &Context,
1332                                        const FunctionDecl *New) {
1333   if (Context.getLangOpts().CPlusPlus)
1334     return true;
1335 
1336   if (Previous.getResultKind() == LookupResult::FoundOverloaded)
1337     return true;
1338 
1339   return Previous.getResultKind() == LookupResult::Found &&
1340          (Previous.getFoundDecl()->hasAttr<OverloadableAttr>() ||
1341           New->hasAttr<OverloadableAttr>());
1342 }
1343 
1344 /// Add this decl to the scope shadowed decl chains.
1345 void Sema::PushOnScopeChains(NamedDecl *D, Scope *S, bool AddToContext) {
1346   // Move up the scope chain until we find the nearest enclosing
1347   // non-transparent context. The declaration will be introduced into this
1348   // scope.
1349   while (S->getEntity() && S->getEntity()->isTransparentContext())
1350     S = S->getParent();
1351 
1352   // Add scoped declarations into their context, so that they can be
1353   // found later. Declarations without a context won't be inserted
1354   // into any context.
1355   if (AddToContext)
1356     CurContext->addDecl(D);
1357 
1358   // Out-of-line definitions shouldn't be pushed into scope in C++, unless they
1359   // are function-local declarations.
1360   if (getLangOpts().CPlusPlus && D->isOutOfLine() &&
1361       !D->getDeclContext()->getRedeclContext()->Equals(
1362         D->getLexicalDeclContext()->getRedeclContext()) &&
1363       !D->getLexicalDeclContext()->isFunctionOrMethod())
1364     return;
1365 
1366   // Template instantiations should also not be pushed into scope.
1367   if (isa<FunctionDecl>(D) &&
1368       cast<FunctionDecl>(D)->isFunctionTemplateSpecialization())
1369     return;
1370 
1371   // If this replaces anything in the current scope,
1372   IdentifierResolver::iterator I = IdResolver.begin(D->getDeclName()),
1373                                IEnd = IdResolver.end();
1374   for (; I != IEnd; ++I) {
1375     if (S->isDeclScope(*I) && D->declarationReplaces(*I)) {
1376       S->RemoveDecl(*I);
1377       IdResolver.RemoveDecl(*I);
1378 
1379       // Should only need to replace one decl.
1380       break;
1381     }
1382   }
1383 
1384   S->AddDecl(D);
1385 
1386   if (isa<LabelDecl>(D) && !cast<LabelDecl>(D)->isGnuLocal()) {
1387     // Implicitly-generated labels may end up getting generated in an order that
1388     // isn't strictly lexical, which breaks name lookup. Be careful to insert
1389     // the label at the appropriate place in the identifier chain.
1390     for (I = IdResolver.begin(D->getDeclName()); I != IEnd; ++I) {
1391       DeclContext *IDC = (*I)->getLexicalDeclContext()->getRedeclContext();
1392       if (IDC == CurContext) {
1393         if (!S->isDeclScope(*I))
1394           continue;
1395       } else if (IDC->Encloses(CurContext))
1396         break;
1397     }
1398 
1399     IdResolver.InsertDeclAfter(I, D);
1400   } else {
1401     IdResolver.AddDecl(D);
1402   }
1403 }
1404 
1405 void Sema::pushExternalDeclIntoScope(NamedDecl *D, DeclarationName Name) {
1406   if (IdResolver.tryAddTopLevelDecl(D, Name) && TUScope)
1407     TUScope->AddDecl(D);
1408 }
1409 
1410 bool Sema::isDeclInScope(NamedDecl *D, DeclContext *Ctx, Scope *S,
1411                          bool AllowInlineNamespace) {
1412   return IdResolver.isDeclInScope(D, Ctx, S, AllowInlineNamespace);
1413 }
1414 
1415 Scope *Sema::getScopeForDeclContext(Scope *S, DeclContext *DC) {
1416   DeclContext *TargetDC = DC->getPrimaryContext();
1417   do {
1418     if (DeclContext *ScopeDC = S->getEntity())
1419       if (ScopeDC->getPrimaryContext() == TargetDC)
1420         return S;
1421   } while ((S = S->getParent()));
1422 
1423   return nullptr;
1424 }
1425 
1426 static bool isOutOfScopePreviousDeclaration(NamedDecl *,
1427                                             DeclContext*,
1428                                             ASTContext&);
1429 
1430 /// Filters out lookup results that don't fall within the given scope
1431 /// as determined by isDeclInScope.
1432 void Sema::FilterLookupForScope(LookupResult &R, DeclContext *Ctx, Scope *S,
1433                                 bool ConsiderLinkage,
1434                                 bool AllowInlineNamespace) {
1435   LookupResult::Filter F = R.makeFilter();
1436   while (F.hasNext()) {
1437     NamedDecl *D = F.next();
1438 
1439     if (isDeclInScope(D, Ctx, S, AllowInlineNamespace))
1440       continue;
1441 
1442     if (ConsiderLinkage && isOutOfScopePreviousDeclaration(D, Ctx, Context))
1443       continue;
1444 
1445     F.erase();
1446   }
1447 
1448   F.done();
1449 }
1450 
1451 /// We've determined that \p New is a redeclaration of \p Old. Check that they
1452 /// have compatible owning modules.
1453 bool Sema::CheckRedeclarationModuleOwnership(NamedDecl *New, NamedDecl *Old) {
1454   // FIXME: The Modules TS is not clear about how friend declarations are
1455   // to be treated. It's not meaningful to have different owning modules for
1456   // linkage in redeclarations of the same entity, so for now allow the
1457   // redeclaration and change the owning modules to match.
1458   if (New->getFriendObjectKind() &&
1459       Old->getOwningModuleForLinkage() != New->getOwningModuleForLinkage()) {
1460     New->setLocalOwningModule(Old->getOwningModule());
1461     makeMergedDefinitionVisible(New);
1462     return false;
1463   }
1464 
1465   Module *NewM = New->getOwningModule();
1466   Module *OldM = Old->getOwningModule();
1467   if (NewM == OldM)
1468     return false;
1469 
1470   // FIXME: Check proclaimed-ownership-declarations here too.
1471   bool NewIsModuleInterface = NewM && NewM->Kind == Module::ModuleInterfaceUnit;
1472   bool OldIsModuleInterface = OldM && OldM->Kind == Module::ModuleInterfaceUnit;
1473   if (NewIsModuleInterface || OldIsModuleInterface) {
1474     // C++ Modules TS [basic.def.odr] 6.2/6.7 [sic]:
1475     //   if a declaration of D [...] appears in the purview of a module, all
1476     //   other such declarations shall appear in the purview of the same module
1477     Diag(New->getLocation(), diag::err_mismatched_owning_module)
1478       << New
1479       << NewIsModuleInterface
1480       << (NewIsModuleInterface ? NewM->getFullModuleName() : "")
1481       << OldIsModuleInterface
1482       << (OldIsModuleInterface ? OldM->getFullModuleName() : "");
1483     Diag(Old->getLocation(), diag::note_previous_declaration);
1484     New->setInvalidDecl();
1485     return true;
1486   }
1487 
1488   return false;
1489 }
1490 
1491 static bool isUsingDecl(NamedDecl *D) {
1492   return isa<UsingShadowDecl>(D) ||
1493          isa<UnresolvedUsingTypenameDecl>(D) ||
1494          isa<UnresolvedUsingValueDecl>(D);
1495 }
1496 
1497 /// Removes using shadow declarations from the lookup results.
1498 static void RemoveUsingDecls(LookupResult &R) {
1499   LookupResult::Filter F = R.makeFilter();
1500   while (F.hasNext())
1501     if (isUsingDecl(F.next()))
1502       F.erase();
1503 
1504   F.done();
1505 }
1506 
1507 /// \brief Check for this common pattern:
1508 /// @code
1509 /// class S {
1510 ///   S(const S&); // DO NOT IMPLEMENT
1511 ///   void operator=(const S&); // DO NOT IMPLEMENT
1512 /// };
1513 /// @endcode
1514 static bool IsDisallowedCopyOrAssign(const CXXMethodDecl *D) {
1515   // FIXME: Should check for private access too but access is set after we get
1516   // the decl here.
1517   if (D->doesThisDeclarationHaveABody())
1518     return false;
1519 
1520   if (const CXXConstructorDecl *CD = dyn_cast<CXXConstructorDecl>(D))
1521     return CD->isCopyConstructor();
1522   if (const CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(D))
1523     return Method->isCopyAssignmentOperator();
1524   return false;
1525 }
1526 
1527 // We need this to handle
1528 //
1529 // typedef struct {
1530 //   void *foo() { return 0; }
1531 // } A;
1532 //
1533 // When we see foo we don't know if after the typedef we will get 'A' or '*A'
1534 // for example. If 'A', foo will have external linkage. If we have '*A',
1535 // foo will have no linkage. Since we can't know until we get to the end
1536 // of the typedef, this function finds out if D might have non-external linkage.
1537 // Callers should verify at the end of the TU if it D has external linkage or
1538 // not.
1539 bool Sema::mightHaveNonExternalLinkage(const DeclaratorDecl *D) {
1540   const DeclContext *DC = D->getDeclContext();
1541   while (!DC->isTranslationUnit()) {
1542     if (const RecordDecl *RD = dyn_cast<RecordDecl>(DC)){
1543       if (!RD->hasNameForLinkage())
1544         return true;
1545     }
1546     DC = DC->getParent();
1547   }
1548 
1549   return !D->isExternallyVisible();
1550 }
1551 
1552 // FIXME: This needs to be refactored; some other isInMainFile users want
1553 // these semantics.
1554 static bool isMainFileLoc(const Sema &S, SourceLocation Loc) {
1555   if (S.TUKind != TU_Complete)
1556     return false;
1557   return S.SourceMgr.isInMainFile(Loc);
1558 }
1559 
1560 bool Sema::ShouldWarnIfUnusedFileScopedDecl(const DeclaratorDecl *D) const {
1561   assert(D);
1562 
1563   if (D->isInvalidDecl() || D->isUsed() || D->hasAttr<UnusedAttr>())
1564     return false;
1565 
1566   // Ignore all entities declared within templates, and out-of-line definitions
1567   // of members of class templates.
1568   if (D->getDeclContext()->isDependentContext() ||
1569       D->getLexicalDeclContext()->isDependentContext())
1570     return false;
1571 
1572   if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
1573     if (FD->getTemplateSpecializationKind() == TSK_ImplicitInstantiation)
1574       return false;
1575     // A non-out-of-line declaration of a member specialization was implicitly
1576     // instantiated; it's the out-of-line declaration that we're interested in.
1577     if (FD->getTemplateSpecializationKind() == TSK_ExplicitSpecialization &&
1578         FD->getMemberSpecializationInfo() && !FD->isOutOfLine())
1579       return false;
1580 
1581     if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) {
1582       if (MD->isVirtual() || IsDisallowedCopyOrAssign(MD))
1583         return false;
1584     } else {
1585       // 'static inline' functions are defined in headers; don't warn.
1586       if (FD->isInlined() && !isMainFileLoc(*this, FD->getLocation()))
1587         return false;
1588     }
1589 
1590     if (FD->doesThisDeclarationHaveABody() &&
1591         Context.DeclMustBeEmitted(FD))
1592       return false;
1593   } else if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
1594     // Constants and utility variables are defined in headers with internal
1595     // linkage; don't warn.  (Unlike functions, there isn't a convenient marker
1596     // like "inline".)
1597     if (!isMainFileLoc(*this, VD->getLocation()))
1598       return false;
1599 
1600     if (Context.DeclMustBeEmitted(VD))
1601       return false;
1602 
1603     if (VD->isStaticDataMember() &&
1604         VD->getTemplateSpecializationKind() == TSK_ImplicitInstantiation)
1605       return false;
1606     if (VD->isStaticDataMember() &&
1607         VD->getTemplateSpecializationKind() == TSK_ExplicitSpecialization &&
1608         VD->getMemberSpecializationInfo() && !VD->isOutOfLine())
1609       return false;
1610 
1611     if (VD->isInline() && !isMainFileLoc(*this, VD->getLocation()))
1612       return false;
1613   } else {
1614     return false;
1615   }
1616 
1617   // Only warn for unused decls internal to the translation unit.
1618   // FIXME: This seems like a bogus check; it suppresses -Wunused-function
1619   // for inline functions defined in the main source file, for instance.
1620   return mightHaveNonExternalLinkage(D);
1621 }
1622 
1623 void Sema::MarkUnusedFileScopedDecl(const DeclaratorDecl *D) {
1624   if (!D)
1625     return;
1626 
1627   if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
1628     const FunctionDecl *First = FD->getFirstDecl();
1629     if (FD != First && ShouldWarnIfUnusedFileScopedDecl(First))
1630       return; // First should already be in the vector.
1631   }
1632 
1633   if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
1634     const VarDecl *First = VD->getFirstDecl();
1635     if (VD != First && ShouldWarnIfUnusedFileScopedDecl(First))
1636       return; // First should already be in the vector.
1637   }
1638 
1639   if (ShouldWarnIfUnusedFileScopedDecl(D))
1640     UnusedFileScopedDecls.push_back(D);
1641 }
1642 
1643 static bool ShouldDiagnoseUnusedDecl(const NamedDecl *D) {
1644   if (D->isInvalidDecl())
1645     return false;
1646 
1647   bool Referenced = false;
1648   if (auto *DD = dyn_cast<DecompositionDecl>(D)) {
1649     // For a decomposition declaration, warn if none of the bindings are
1650     // referenced, instead of if the variable itself is referenced (which
1651     // it is, by the bindings' expressions).
1652     for (auto *BD : DD->bindings()) {
1653       if (BD->isReferenced()) {
1654         Referenced = true;
1655         break;
1656       }
1657     }
1658   } else if (!D->getDeclName()) {
1659     return false;
1660   } else if (D->isReferenced() || D->isUsed()) {
1661     Referenced = true;
1662   }
1663 
1664   if (Referenced || D->hasAttr<UnusedAttr>() ||
1665       D->hasAttr<ObjCPreciseLifetimeAttr>())
1666     return false;
1667 
1668   if (isa<LabelDecl>(D))
1669     return true;
1670 
1671   // Except for labels, we only care about unused decls that are local to
1672   // functions.
1673   bool WithinFunction = D->getDeclContext()->isFunctionOrMethod();
1674   if (const auto *R = dyn_cast<CXXRecordDecl>(D->getDeclContext()))
1675     // For dependent types, the diagnostic is deferred.
1676     WithinFunction =
1677         WithinFunction || (R->isLocalClass() && !R->isDependentType());
1678   if (!WithinFunction)
1679     return false;
1680 
1681   if (isa<TypedefNameDecl>(D))
1682     return true;
1683 
1684   // White-list anything that isn't a local variable.
1685   if (!isa<VarDecl>(D) || isa<ParmVarDecl>(D) || isa<ImplicitParamDecl>(D))
1686     return false;
1687 
1688   // Types of valid local variables should be complete, so this should succeed.
1689   if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
1690 
1691     // White-list anything with an __attribute__((unused)) type.
1692     const auto *Ty = VD->getType().getTypePtr();
1693 
1694     // Only look at the outermost level of typedef.
1695     if (const TypedefType *TT = Ty->getAs<TypedefType>()) {
1696       if (TT->getDecl()->hasAttr<UnusedAttr>())
1697         return false;
1698     }
1699 
1700     // If we failed to complete the type for some reason, or if the type is
1701     // dependent, don't diagnose the variable.
1702     if (Ty->isIncompleteType() || Ty->isDependentType())
1703       return false;
1704 
1705     // Look at the element type to ensure that the warning behaviour is
1706     // consistent for both scalars and arrays.
1707     Ty = Ty->getBaseElementTypeUnsafe();
1708 
1709     if (const TagType *TT = Ty->getAs<TagType>()) {
1710       const TagDecl *Tag = TT->getDecl();
1711       if (Tag->hasAttr<UnusedAttr>())
1712         return false;
1713 
1714       if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(Tag)) {
1715         if (!RD->hasTrivialDestructor() && !RD->hasAttr<WarnUnusedAttr>())
1716           return false;
1717 
1718         if (const Expr *Init = VD->getInit()) {
1719           if (const ExprWithCleanups *Cleanups =
1720                   dyn_cast<ExprWithCleanups>(Init))
1721             Init = Cleanups->getSubExpr();
1722           const CXXConstructExpr *Construct =
1723             dyn_cast<CXXConstructExpr>(Init);
1724           if (Construct && !Construct->isElidable()) {
1725             CXXConstructorDecl *CD = Construct->getConstructor();
1726             if (!CD->isTrivial() && !RD->hasAttr<WarnUnusedAttr>() &&
1727                 !VD->evaluateValue())
1728               return false;
1729           }
1730         }
1731       }
1732     }
1733 
1734     // TODO: __attribute__((unused)) templates?
1735   }
1736 
1737   return true;
1738 }
1739 
1740 static void GenerateFixForUnusedDecl(const NamedDecl *D, ASTContext &Ctx,
1741                                      FixItHint &Hint) {
1742   if (isa<LabelDecl>(D)) {
1743     SourceLocation AfterColon = Lexer::findLocationAfterToken(D->getLocEnd(),
1744                 tok::colon, Ctx.getSourceManager(), Ctx.getLangOpts(), true);
1745     if (AfterColon.isInvalid())
1746       return;
1747     Hint = FixItHint::CreateRemoval(CharSourceRange::
1748                                     getCharRange(D->getLocStart(), AfterColon));
1749   }
1750 }
1751 
1752 void Sema::DiagnoseUnusedNestedTypedefs(const RecordDecl *D) {
1753   if (D->getTypeForDecl()->isDependentType())
1754     return;
1755 
1756   for (auto *TmpD : D->decls()) {
1757     if (const auto *T = dyn_cast<TypedefNameDecl>(TmpD))
1758       DiagnoseUnusedDecl(T);
1759     else if(const auto *R = dyn_cast<RecordDecl>(TmpD))
1760       DiagnoseUnusedNestedTypedefs(R);
1761   }
1762 }
1763 
1764 /// DiagnoseUnusedDecl - Emit warnings about declarations that are not used
1765 /// unless they are marked attr(unused).
1766 void Sema::DiagnoseUnusedDecl(const NamedDecl *D) {
1767   if (!ShouldDiagnoseUnusedDecl(D))
1768     return;
1769 
1770   if (auto *TD = dyn_cast<TypedefNameDecl>(D)) {
1771     // typedefs can be referenced later on, so the diagnostics are emitted
1772     // at end-of-translation-unit.
1773     UnusedLocalTypedefNameCandidates.insert(TD);
1774     return;
1775   }
1776 
1777   FixItHint Hint;
1778   GenerateFixForUnusedDecl(D, Context, Hint);
1779 
1780   unsigned DiagID;
1781   if (isa<VarDecl>(D) && cast<VarDecl>(D)->isExceptionVariable())
1782     DiagID = diag::warn_unused_exception_param;
1783   else if (isa<LabelDecl>(D))
1784     DiagID = diag::warn_unused_label;
1785   else
1786     DiagID = diag::warn_unused_variable;
1787 
1788   Diag(D->getLocation(), DiagID) << D << Hint;
1789 }
1790 
1791 static void CheckPoppedLabel(LabelDecl *L, Sema &S) {
1792   // Verify that we have no forward references left.  If so, there was a goto
1793   // or address of a label taken, but no definition of it.  Label fwd
1794   // definitions are indicated with a null substmt which is also not a resolved
1795   // MS inline assembly label name.
1796   bool Diagnose = false;
1797   if (L->isMSAsmLabel())
1798     Diagnose = !L->isResolvedMSAsmLabel();
1799   else
1800     Diagnose = L->getStmt() == nullptr;
1801   if (Diagnose)
1802     S.Diag(L->getLocation(), diag::err_undeclared_label_use) <<L->getDeclName();
1803 }
1804 
1805 void Sema::ActOnPopScope(SourceLocation Loc, Scope *S) {
1806   S->mergeNRVOIntoParent();
1807 
1808   if (S->decl_empty()) return;
1809   assert((S->getFlags() & (Scope::DeclScope | Scope::TemplateParamScope)) &&
1810          "Scope shouldn't contain decls!");
1811 
1812   for (auto *TmpD : S->decls()) {
1813     assert(TmpD && "This decl didn't get pushed??");
1814 
1815     assert(isa<NamedDecl>(TmpD) && "Decl isn't NamedDecl?");
1816     NamedDecl *D = cast<NamedDecl>(TmpD);
1817 
1818     // Diagnose unused variables in this scope.
1819     if (!S->hasUnrecoverableErrorOccurred()) {
1820       DiagnoseUnusedDecl(D);
1821       if (const auto *RD = dyn_cast<RecordDecl>(D))
1822         DiagnoseUnusedNestedTypedefs(RD);
1823     }
1824 
1825     if (!D->getDeclName()) continue;
1826 
1827     // If this was a forward reference to a label, verify it was defined.
1828     if (LabelDecl *LD = dyn_cast<LabelDecl>(D))
1829       CheckPoppedLabel(LD, *this);
1830 
1831     // Remove this name from our lexical scope, and warn on it if we haven't
1832     // already.
1833     IdResolver.RemoveDecl(D);
1834     auto ShadowI = ShadowingDecls.find(D);
1835     if (ShadowI != ShadowingDecls.end()) {
1836       if (const auto *FD = dyn_cast<FieldDecl>(ShadowI->second)) {
1837         Diag(D->getLocation(), diag::warn_ctor_parm_shadows_field)
1838             << D << FD << FD->getParent();
1839         Diag(FD->getLocation(), diag::note_previous_declaration);
1840       }
1841       ShadowingDecls.erase(ShadowI);
1842     }
1843   }
1844 }
1845 
1846 /// \brief Look for an Objective-C class in the translation unit.
1847 ///
1848 /// \param Id The name of the Objective-C class we're looking for. If
1849 /// typo-correction fixes this name, the Id will be updated
1850 /// to the fixed name.
1851 ///
1852 /// \param IdLoc The location of the name in the translation unit.
1853 ///
1854 /// \param DoTypoCorrection If true, this routine will attempt typo correction
1855 /// if there is no class with the given name.
1856 ///
1857 /// \returns The declaration of the named Objective-C class, or NULL if the
1858 /// class could not be found.
1859 ObjCInterfaceDecl *Sema::getObjCInterfaceDecl(IdentifierInfo *&Id,
1860                                               SourceLocation IdLoc,
1861                                               bool DoTypoCorrection) {
1862   // The third "scope" argument is 0 since we aren't enabling lazy built-in
1863   // creation from this context.
1864   NamedDecl *IDecl = LookupSingleName(TUScope, Id, IdLoc, LookupOrdinaryName);
1865 
1866   if (!IDecl && DoTypoCorrection) {
1867     // Perform typo correction at the given location, but only if we
1868     // find an Objective-C class name.
1869     if (TypoCorrection C = CorrectTypo(
1870             DeclarationNameInfo(Id, IdLoc), LookupOrdinaryName, TUScope, nullptr,
1871             llvm::make_unique<DeclFilterCCC<ObjCInterfaceDecl>>(),
1872             CTK_ErrorRecovery)) {
1873       diagnoseTypo(C, PDiag(diag::err_undef_interface_suggest) << Id);
1874       IDecl = C.getCorrectionDeclAs<ObjCInterfaceDecl>();
1875       Id = IDecl->getIdentifier();
1876     }
1877   }
1878   ObjCInterfaceDecl *Def = dyn_cast_or_null<ObjCInterfaceDecl>(IDecl);
1879   // This routine must always return a class definition, if any.
1880   if (Def && Def->getDefinition())
1881       Def = Def->getDefinition();
1882   return Def;
1883 }
1884 
1885 /// getNonFieldDeclScope - Retrieves the innermost scope, starting
1886 /// from S, where a non-field would be declared. This routine copes
1887 /// with the difference between C and C++ scoping rules in structs and
1888 /// unions. For example, the following code is well-formed in C but
1889 /// ill-formed in C++:
1890 /// @code
1891 /// struct S6 {
1892 ///   enum { BAR } e;
1893 /// };
1894 ///
1895 /// void test_S6() {
1896 ///   struct S6 a;
1897 ///   a.e = BAR;
1898 /// }
1899 /// @endcode
1900 /// For the declaration of BAR, this routine will return a different
1901 /// scope. The scope S will be the scope of the unnamed enumeration
1902 /// within S6. In C++, this routine will return the scope associated
1903 /// with S6, because the enumeration's scope is a transparent
1904 /// context but structures can contain non-field names. In C, this
1905 /// routine will return the translation unit scope, since the
1906 /// enumeration's scope is a transparent context and structures cannot
1907 /// contain non-field names.
1908 Scope *Sema::getNonFieldDeclScope(Scope *S) {
1909   while (((S->getFlags() & Scope::DeclScope) == 0) ||
1910          (S->getEntity() && S->getEntity()->isTransparentContext()) ||
1911          (S->isClassScope() && !getLangOpts().CPlusPlus))
1912     S = S->getParent();
1913   return S;
1914 }
1915 
1916 /// \brief Looks up the declaration of "struct objc_super" and
1917 /// saves it for later use in building builtin declaration of
1918 /// objc_msgSendSuper and objc_msgSendSuper_stret. If no such
1919 /// pre-existing declaration exists no action takes place.
1920 static void LookupPredefedObjCSuperType(Sema &ThisSema, Scope *S,
1921                                         IdentifierInfo *II) {
1922   if (!II->isStr("objc_msgSendSuper"))
1923     return;
1924   ASTContext &Context = ThisSema.Context;
1925 
1926   LookupResult Result(ThisSema, &Context.Idents.get("objc_super"),
1927                       SourceLocation(), Sema::LookupTagName);
1928   ThisSema.LookupName(Result, S);
1929   if (Result.getResultKind() == LookupResult::Found)
1930     if (const TagDecl *TD = Result.getAsSingle<TagDecl>())
1931       Context.setObjCSuperType(Context.getTagDeclType(TD));
1932 }
1933 
1934 static StringRef getHeaderName(ASTContext::GetBuiltinTypeError Error) {
1935   switch (Error) {
1936   case ASTContext::GE_None:
1937     return "";
1938   case ASTContext::GE_Missing_stdio:
1939     return "stdio.h";
1940   case ASTContext::GE_Missing_setjmp:
1941     return "setjmp.h";
1942   case ASTContext::GE_Missing_ucontext:
1943     return "ucontext.h";
1944   }
1945   llvm_unreachable("unhandled error kind");
1946 }
1947 
1948 /// LazilyCreateBuiltin - The specified Builtin-ID was first used at
1949 /// file scope.  lazily create a decl for it. ForRedeclaration is true
1950 /// if we're creating this built-in in anticipation of redeclaring the
1951 /// built-in.
1952 NamedDecl *Sema::LazilyCreateBuiltin(IdentifierInfo *II, unsigned ID,
1953                                      Scope *S, bool ForRedeclaration,
1954                                      SourceLocation Loc) {
1955   LookupPredefedObjCSuperType(*this, S, II);
1956 
1957   ASTContext::GetBuiltinTypeError Error;
1958   QualType R = Context.GetBuiltinType(ID, Error);
1959   if (Error) {
1960     if (ForRedeclaration)
1961       Diag(Loc, diag::warn_implicit_decl_requires_sysheader)
1962           << getHeaderName(Error) << Context.BuiltinInfo.getName(ID);
1963     return nullptr;
1964   }
1965 
1966   if (!ForRedeclaration &&
1967       (Context.BuiltinInfo.isPredefinedLibFunction(ID) ||
1968        Context.BuiltinInfo.isHeaderDependentFunction(ID))) {
1969     Diag(Loc, diag::ext_implicit_lib_function_decl)
1970         << Context.BuiltinInfo.getName(ID) << R;
1971     if (Context.BuiltinInfo.getHeaderName(ID) &&
1972         !Diags.isIgnored(diag::ext_implicit_lib_function_decl, Loc))
1973       Diag(Loc, diag::note_include_header_or_declare)
1974           << Context.BuiltinInfo.getHeaderName(ID)
1975           << Context.BuiltinInfo.getName(ID);
1976   }
1977 
1978   if (R.isNull())
1979     return nullptr;
1980 
1981   DeclContext *Parent = Context.getTranslationUnitDecl();
1982   if (getLangOpts().CPlusPlus) {
1983     LinkageSpecDecl *CLinkageDecl =
1984         LinkageSpecDecl::Create(Context, Parent, Loc, Loc,
1985                                 LinkageSpecDecl::lang_c, false);
1986     CLinkageDecl->setImplicit();
1987     Parent->addDecl(CLinkageDecl);
1988     Parent = CLinkageDecl;
1989   }
1990 
1991   FunctionDecl *New = FunctionDecl::Create(Context,
1992                                            Parent,
1993                                            Loc, Loc, II, R, /*TInfo=*/nullptr,
1994                                            SC_Extern,
1995                                            false,
1996                                            R->isFunctionProtoType());
1997   New->setImplicit();
1998 
1999   // Create Decl objects for each parameter, adding them to the
2000   // FunctionDecl.
2001   if (const FunctionProtoType *FT = dyn_cast<FunctionProtoType>(R)) {
2002     SmallVector<ParmVarDecl*, 16> Params;
2003     for (unsigned i = 0, e = FT->getNumParams(); i != e; ++i) {
2004       ParmVarDecl *parm =
2005           ParmVarDecl::Create(Context, New, SourceLocation(), SourceLocation(),
2006                               nullptr, FT->getParamType(i), /*TInfo=*/nullptr,
2007                               SC_None, nullptr);
2008       parm->setScopeInfo(0, i);
2009       Params.push_back(parm);
2010     }
2011     New->setParams(Params);
2012   }
2013 
2014   AddKnownFunctionAttributes(New);
2015   RegisterLocallyScopedExternCDecl(New, S);
2016 
2017   // TUScope is the translation-unit scope to insert this function into.
2018   // FIXME: This is hideous. We need to teach PushOnScopeChains to
2019   // relate Scopes to DeclContexts, and probably eliminate CurContext
2020   // entirely, but we're not there yet.
2021   DeclContext *SavedContext = CurContext;
2022   CurContext = Parent;
2023   PushOnScopeChains(New, TUScope);
2024   CurContext = SavedContext;
2025   return New;
2026 }
2027 
2028 /// Typedef declarations don't have linkage, but they still denote the same
2029 /// entity if their types are the same.
2030 /// FIXME: This is notionally doing the same thing as ASTReaderDecl's
2031 /// isSameEntity.
2032 static void filterNonConflictingPreviousTypedefDecls(Sema &S,
2033                                                      TypedefNameDecl *Decl,
2034                                                      LookupResult &Previous) {
2035   // This is only interesting when modules are enabled.
2036   if (!S.getLangOpts().Modules && !S.getLangOpts().ModulesLocalVisibility)
2037     return;
2038 
2039   // Empty sets are uninteresting.
2040   if (Previous.empty())
2041     return;
2042 
2043   LookupResult::Filter Filter = Previous.makeFilter();
2044   while (Filter.hasNext()) {
2045     NamedDecl *Old = Filter.next();
2046 
2047     // Non-hidden declarations are never ignored.
2048     if (S.isVisible(Old))
2049       continue;
2050 
2051     // Declarations of the same entity are not ignored, even if they have
2052     // different linkages.
2053     if (auto *OldTD = dyn_cast<TypedefNameDecl>(Old)) {
2054       if (S.Context.hasSameType(OldTD->getUnderlyingType(),
2055                                 Decl->getUnderlyingType()))
2056         continue;
2057 
2058       // If both declarations give a tag declaration a typedef name for linkage
2059       // purposes, then they declare the same entity.
2060       if (OldTD->getAnonDeclWithTypedefName(/*AnyRedecl*/true) &&
2061           Decl->getAnonDeclWithTypedefName())
2062         continue;
2063     }
2064 
2065     Filter.erase();
2066   }
2067 
2068   Filter.done();
2069 }
2070 
2071 bool Sema::isIncompatibleTypedef(TypeDecl *Old, TypedefNameDecl *New) {
2072   QualType OldType;
2073   if (TypedefNameDecl *OldTypedef = dyn_cast<TypedefNameDecl>(Old))
2074     OldType = OldTypedef->getUnderlyingType();
2075   else
2076     OldType = Context.getTypeDeclType(Old);
2077   QualType NewType = New->getUnderlyingType();
2078 
2079   if (NewType->isVariablyModifiedType()) {
2080     // Must not redefine a typedef with a variably-modified type.
2081     int Kind = isa<TypeAliasDecl>(Old) ? 1 : 0;
2082     Diag(New->getLocation(), diag::err_redefinition_variably_modified_typedef)
2083       << Kind << NewType;
2084     if (Old->getLocation().isValid())
2085       notePreviousDefinition(Old, New->getLocation());
2086     New->setInvalidDecl();
2087     return true;
2088   }
2089 
2090   if (OldType != NewType &&
2091       !OldType->isDependentType() &&
2092       !NewType->isDependentType() &&
2093       !Context.hasSameType(OldType, NewType)) {
2094     int Kind = isa<TypeAliasDecl>(Old) ? 1 : 0;
2095     Diag(New->getLocation(), diag::err_redefinition_different_typedef)
2096       << Kind << NewType << OldType;
2097     if (Old->getLocation().isValid())
2098       notePreviousDefinition(Old, New->getLocation());
2099     New->setInvalidDecl();
2100     return true;
2101   }
2102   return false;
2103 }
2104 
2105 /// MergeTypedefNameDecl - We just parsed a typedef 'New' which has the
2106 /// same name and scope as a previous declaration 'Old'.  Figure out
2107 /// how to resolve this situation, merging decls or emitting
2108 /// diagnostics as appropriate. If there was an error, set New to be invalid.
2109 ///
2110 void Sema::MergeTypedefNameDecl(Scope *S, TypedefNameDecl *New,
2111                                 LookupResult &OldDecls) {
2112   // If the new decl is known invalid already, don't bother doing any
2113   // merging checks.
2114   if (New->isInvalidDecl()) return;
2115 
2116   // Allow multiple definitions for ObjC built-in typedefs.
2117   // FIXME: Verify the underlying types are equivalent!
2118   if (getLangOpts().ObjC1) {
2119     const IdentifierInfo *TypeID = New->getIdentifier();
2120     switch (TypeID->getLength()) {
2121     default: break;
2122     case 2:
2123       {
2124         if (!TypeID->isStr("id"))
2125           break;
2126         QualType T = New->getUnderlyingType();
2127         if (!T->isPointerType())
2128           break;
2129         if (!T->isVoidPointerType()) {
2130           QualType PT = T->getAs<PointerType>()->getPointeeType();
2131           if (!PT->isStructureType())
2132             break;
2133         }
2134         Context.setObjCIdRedefinitionType(T);
2135         // Install the built-in type for 'id', ignoring the current definition.
2136         New->setTypeForDecl(Context.getObjCIdType().getTypePtr());
2137         return;
2138       }
2139     case 5:
2140       if (!TypeID->isStr("Class"))
2141         break;
2142       Context.setObjCClassRedefinitionType(New->getUnderlyingType());
2143       // Install the built-in type for 'Class', ignoring the current definition.
2144       New->setTypeForDecl(Context.getObjCClassType().getTypePtr());
2145       return;
2146     case 3:
2147       if (!TypeID->isStr("SEL"))
2148         break;
2149       Context.setObjCSelRedefinitionType(New->getUnderlyingType());
2150       // Install the built-in type for 'SEL', ignoring the current definition.
2151       New->setTypeForDecl(Context.getObjCSelType().getTypePtr());
2152       return;
2153     }
2154     // Fall through - the typedef name was not a builtin type.
2155   }
2156 
2157   // Verify the old decl was also a type.
2158   TypeDecl *Old = OldDecls.getAsSingle<TypeDecl>();
2159   if (!Old) {
2160     Diag(New->getLocation(), diag::err_redefinition_different_kind)
2161       << New->getDeclName();
2162 
2163     NamedDecl *OldD = OldDecls.getRepresentativeDecl();
2164     if (OldD->getLocation().isValid())
2165       notePreviousDefinition(OldD, New->getLocation());
2166 
2167     return New->setInvalidDecl();
2168   }
2169 
2170   // If the old declaration is invalid, just give up here.
2171   if (Old->isInvalidDecl())
2172     return New->setInvalidDecl();
2173 
2174   if (auto *OldTD = dyn_cast<TypedefNameDecl>(Old)) {
2175     auto *OldTag = OldTD->getAnonDeclWithTypedefName(/*AnyRedecl*/true);
2176     auto *NewTag = New->getAnonDeclWithTypedefName();
2177     NamedDecl *Hidden = nullptr;
2178     if (OldTag && NewTag &&
2179         OldTag->getCanonicalDecl() != NewTag->getCanonicalDecl() &&
2180         !hasVisibleDefinition(OldTag, &Hidden)) {
2181       // There is a definition of this tag, but it is not visible. Use it
2182       // instead of our tag.
2183       New->setTypeForDecl(OldTD->getTypeForDecl());
2184       if (OldTD->isModed())
2185         New->setModedTypeSourceInfo(OldTD->getTypeSourceInfo(),
2186                                     OldTD->getUnderlyingType());
2187       else
2188         New->setTypeSourceInfo(OldTD->getTypeSourceInfo());
2189 
2190       // Make the old tag definition visible.
2191       makeMergedDefinitionVisible(Hidden);
2192 
2193       // If this was an unscoped enumeration, yank all of its enumerators
2194       // out of the scope.
2195       if (isa<EnumDecl>(NewTag)) {
2196         Scope *EnumScope = getNonFieldDeclScope(S);
2197         for (auto *D : NewTag->decls()) {
2198           auto *ED = cast<EnumConstantDecl>(D);
2199           assert(EnumScope->isDeclScope(ED));
2200           EnumScope->RemoveDecl(ED);
2201           IdResolver.RemoveDecl(ED);
2202           ED->getLexicalDeclContext()->removeDecl(ED);
2203         }
2204       }
2205     }
2206   }
2207 
2208   // If the typedef types are not identical, reject them in all languages and
2209   // with any extensions enabled.
2210   if (isIncompatibleTypedef(Old, New))
2211     return;
2212 
2213   // The types match.  Link up the redeclaration chain and merge attributes if
2214   // the old declaration was a typedef.
2215   if (TypedefNameDecl *Typedef = dyn_cast<TypedefNameDecl>(Old)) {
2216     New->setPreviousDecl(Typedef);
2217     mergeDeclAttributes(New, Old);
2218   }
2219 
2220   if (getLangOpts().MicrosoftExt)
2221     return;
2222 
2223   if (getLangOpts().CPlusPlus) {
2224     // C++ [dcl.typedef]p2:
2225     //   In a given non-class scope, a typedef specifier can be used to
2226     //   redefine the name of any type declared in that scope to refer
2227     //   to the type to which it already refers.
2228     if (!isa<CXXRecordDecl>(CurContext))
2229       return;
2230 
2231     // C++0x [dcl.typedef]p4:
2232     //   In a given class scope, a typedef specifier can be used to redefine
2233     //   any class-name declared in that scope that is not also a typedef-name
2234     //   to refer to the type to which it already refers.
2235     //
2236     // This wording came in via DR424, which was a correction to the
2237     // wording in DR56, which accidentally banned code like:
2238     //
2239     //   struct S {
2240     //     typedef struct A { } A;
2241     //   };
2242     //
2243     // in the C++03 standard. We implement the C++0x semantics, which
2244     // allow the above but disallow
2245     //
2246     //   struct S {
2247     //     typedef int I;
2248     //     typedef int I;
2249     //   };
2250     //
2251     // since that was the intent of DR56.
2252     if (!isa<TypedefNameDecl>(Old))
2253       return;
2254 
2255     Diag(New->getLocation(), diag::err_redefinition)
2256       << New->getDeclName();
2257     notePreviousDefinition(Old, New->getLocation());
2258     return New->setInvalidDecl();
2259   }
2260 
2261   // Modules always permit redefinition of typedefs, as does C11.
2262   if (getLangOpts().Modules || getLangOpts().C11)
2263     return;
2264 
2265   // If we have a redefinition of a typedef in C, emit a warning.  This warning
2266   // is normally mapped to an error, but can be controlled with
2267   // -Wtypedef-redefinition.  If either the original or the redefinition is
2268   // in a system header, don't emit this for compatibility with GCC.
2269   if (getDiagnostics().getSuppressSystemWarnings() &&
2270       // Some standard types are defined implicitly in Clang (e.g. OpenCL).
2271       (Old->isImplicit() ||
2272        Context.getSourceManager().isInSystemHeader(Old->getLocation()) ||
2273        Context.getSourceManager().isInSystemHeader(New->getLocation())))
2274     return;
2275 
2276   Diag(New->getLocation(), diag::ext_redefinition_of_typedef)
2277     << New->getDeclName();
2278   notePreviousDefinition(Old, New->getLocation());
2279 }
2280 
2281 /// DeclhasAttr - returns true if decl Declaration already has the target
2282 /// attribute.
2283 static bool DeclHasAttr(const Decl *D, const Attr *A) {
2284   const OwnershipAttr *OA = dyn_cast<OwnershipAttr>(A);
2285   const AnnotateAttr *Ann = dyn_cast<AnnotateAttr>(A);
2286   for (const auto *i : D->attrs())
2287     if (i->getKind() == A->getKind()) {
2288       if (Ann) {
2289         if (Ann->getAnnotation() == cast<AnnotateAttr>(i)->getAnnotation())
2290           return true;
2291         continue;
2292       }
2293       // FIXME: Don't hardcode this check
2294       if (OA && isa<OwnershipAttr>(i))
2295         return OA->getOwnKind() == cast<OwnershipAttr>(i)->getOwnKind();
2296       return true;
2297     }
2298 
2299   return false;
2300 }
2301 
2302 static bool isAttributeTargetADefinition(Decl *D) {
2303   if (VarDecl *VD = dyn_cast<VarDecl>(D))
2304     return VD->isThisDeclarationADefinition();
2305   if (TagDecl *TD = dyn_cast<TagDecl>(D))
2306     return TD->isCompleteDefinition() || TD->isBeingDefined();
2307   return true;
2308 }
2309 
2310 /// Merge alignment attributes from \p Old to \p New, taking into account the
2311 /// special semantics of C11's _Alignas specifier and C++11's alignas attribute.
2312 ///
2313 /// \return \c true if any attributes were added to \p New.
2314 static bool mergeAlignedAttrs(Sema &S, NamedDecl *New, Decl *Old) {
2315   // Look for alignas attributes on Old, and pick out whichever attribute
2316   // specifies the strictest alignment requirement.
2317   AlignedAttr *OldAlignasAttr = nullptr;
2318   AlignedAttr *OldStrictestAlignAttr = nullptr;
2319   unsigned OldAlign = 0;
2320   for (auto *I : Old->specific_attrs<AlignedAttr>()) {
2321     // FIXME: We have no way of representing inherited dependent alignments
2322     // in a case like:
2323     //   template<int A, int B> struct alignas(A) X;
2324     //   template<int A, int B> struct alignas(B) X {};
2325     // For now, we just ignore any alignas attributes which are not on the
2326     // definition in such a case.
2327     if (I->isAlignmentDependent())
2328       return false;
2329 
2330     if (I->isAlignas())
2331       OldAlignasAttr = I;
2332 
2333     unsigned Align = I->getAlignment(S.Context);
2334     if (Align > OldAlign) {
2335       OldAlign = Align;
2336       OldStrictestAlignAttr = I;
2337     }
2338   }
2339 
2340   // Look for alignas attributes on New.
2341   AlignedAttr *NewAlignasAttr = nullptr;
2342   unsigned NewAlign = 0;
2343   for (auto *I : New->specific_attrs<AlignedAttr>()) {
2344     if (I->isAlignmentDependent())
2345       return false;
2346 
2347     if (I->isAlignas())
2348       NewAlignasAttr = I;
2349 
2350     unsigned Align = I->getAlignment(S.Context);
2351     if (Align > NewAlign)
2352       NewAlign = Align;
2353   }
2354 
2355   if (OldAlignasAttr && NewAlignasAttr && OldAlign != NewAlign) {
2356     // Both declarations have 'alignas' attributes. We require them to match.
2357     // C++11 [dcl.align]p6 and C11 6.7.5/7 both come close to saying this, but
2358     // fall short. (If two declarations both have alignas, they must both match
2359     // every definition, and so must match each other if there is a definition.)
2360 
2361     // If either declaration only contains 'alignas(0)' specifiers, then it
2362     // specifies the natural alignment for the type.
2363     if (OldAlign == 0 || NewAlign == 0) {
2364       QualType Ty;
2365       if (ValueDecl *VD = dyn_cast<ValueDecl>(New))
2366         Ty = VD->getType();
2367       else
2368         Ty = S.Context.getTagDeclType(cast<TagDecl>(New));
2369 
2370       if (OldAlign == 0)
2371         OldAlign = S.Context.getTypeAlign(Ty);
2372       if (NewAlign == 0)
2373         NewAlign = S.Context.getTypeAlign(Ty);
2374     }
2375 
2376     if (OldAlign != NewAlign) {
2377       S.Diag(NewAlignasAttr->getLocation(), diag::err_alignas_mismatch)
2378         << (unsigned)S.Context.toCharUnitsFromBits(OldAlign).getQuantity()
2379         << (unsigned)S.Context.toCharUnitsFromBits(NewAlign).getQuantity();
2380       S.Diag(OldAlignasAttr->getLocation(), diag::note_previous_declaration);
2381     }
2382   }
2383 
2384   if (OldAlignasAttr && !NewAlignasAttr && isAttributeTargetADefinition(New)) {
2385     // C++11 [dcl.align]p6:
2386     //   if any declaration of an entity has an alignment-specifier,
2387     //   every defining declaration of that entity shall specify an
2388     //   equivalent alignment.
2389     // C11 6.7.5/7:
2390     //   If the definition of an object does not have an alignment
2391     //   specifier, any other declaration of that object shall also
2392     //   have no alignment specifier.
2393     S.Diag(New->getLocation(), diag::err_alignas_missing_on_definition)
2394       << OldAlignasAttr;
2395     S.Diag(OldAlignasAttr->getLocation(), diag::note_alignas_on_declaration)
2396       << OldAlignasAttr;
2397   }
2398 
2399   bool AnyAdded = false;
2400 
2401   // Ensure we have an attribute representing the strictest alignment.
2402   if (OldAlign > NewAlign) {
2403     AlignedAttr *Clone = OldStrictestAlignAttr->clone(S.Context);
2404     Clone->setInherited(true);
2405     New->addAttr(Clone);
2406     AnyAdded = true;
2407   }
2408 
2409   // Ensure we have an alignas attribute if the old declaration had one.
2410   if (OldAlignasAttr && !NewAlignasAttr &&
2411       !(AnyAdded && OldStrictestAlignAttr->isAlignas())) {
2412     AlignedAttr *Clone = OldAlignasAttr->clone(S.Context);
2413     Clone->setInherited(true);
2414     New->addAttr(Clone);
2415     AnyAdded = true;
2416   }
2417 
2418   return AnyAdded;
2419 }
2420 
2421 static bool mergeDeclAttribute(Sema &S, NamedDecl *D,
2422                                const InheritableAttr *Attr,
2423                                Sema::AvailabilityMergeKind AMK) {
2424   // This function copies an attribute Attr from a previous declaration to the
2425   // new declaration D if the new declaration doesn't itself have that attribute
2426   // yet or if that attribute allows duplicates.
2427   // If you're adding a new attribute that requires logic different from
2428   // "use explicit attribute on decl if present, else use attribute from
2429   // previous decl", for example if the attribute needs to be consistent
2430   // between redeclarations, you need to call a custom merge function here.
2431   InheritableAttr *NewAttr = nullptr;
2432   unsigned AttrSpellingListIndex = Attr->getSpellingListIndex();
2433   if (const auto *AA = dyn_cast<AvailabilityAttr>(Attr))
2434     NewAttr = S.mergeAvailabilityAttr(D, AA->getRange(), AA->getPlatform(),
2435                                       AA->isImplicit(), AA->getIntroduced(),
2436                                       AA->getDeprecated(),
2437                                       AA->getObsoleted(), AA->getUnavailable(),
2438                                       AA->getMessage(), AA->getStrict(),
2439                                       AA->getReplacement(), AMK,
2440                                       AttrSpellingListIndex);
2441   else if (const auto *VA = dyn_cast<VisibilityAttr>(Attr))
2442     NewAttr = S.mergeVisibilityAttr(D, VA->getRange(), VA->getVisibility(),
2443                                     AttrSpellingListIndex);
2444   else if (const auto *VA = dyn_cast<TypeVisibilityAttr>(Attr))
2445     NewAttr = S.mergeTypeVisibilityAttr(D, VA->getRange(), VA->getVisibility(),
2446                                         AttrSpellingListIndex);
2447   else if (const auto *ImportA = dyn_cast<DLLImportAttr>(Attr))
2448     NewAttr = S.mergeDLLImportAttr(D, ImportA->getRange(),
2449                                    AttrSpellingListIndex);
2450   else if (const auto *ExportA = dyn_cast<DLLExportAttr>(Attr))
2451     NewAttr = S.mergeDLLExportAttr(D, ExportA->getRange(),
2452                                    AttrSpellingListIndex);
2453   else if (const auto *FA = dyn_cast<FormatAttr>(Attr))
2454     NewAttr = S.mergeFormatAttr(D, FA->getRange(), FA->getType(),
2455                                 FA->getFormatIdx(), FA->getFirstArg(),
2456                                 AttrSpellingListIndex);
2457   else if (const auto *SA = dyn_cast<SectionAttr>(Attr))
2458     NewAttr = S.mergeSectionAttr(D, SA->getRange(), SA->getName(),
2459                                  AttrSpellingListIndex);
2460   else if (const auto *IA = dyn_cast<MSInheritanceAttr>(Attr))
2461     NewAttr = S.mergeMSInheritanceAttr(D, IA->getRange(), IA->getBestCase(),
2462                                        AttrSpellingListIndex,
2463                                        IA->getSemanticSpelling());
2464   else if (const auto *AA = dyn_cast<AlwaysInlineAttr>(Attr))
2465     NewAttr = S.mergeAlwaysInlineAttr(D, AA->getRange(),
2466                                       &S.Context.Idents.get(AA->getSpelling()),
2467                                       AttrSpellingListIndex);
2468   else if (S.getLangOpts().CUDA && isa<FunctionDecl>(D) &&
2469            (isa<CUDAHostAttr>(Attr) || isa<CUDADeviceAttr>(Attr) ||
2470             isa<CUDAGlobalAttr>(Attr))) {
2471     // CUDA target attributes are part of function signature for
2472     // overloading purposes and must not be merged.
2473     return false;
2474   } else if (const auto *MA = dyn_cast<MinSizeAttr>(Attr))
2475     NewAttr = S.mergeMinSizeAttr(D, MA->getRange(), AttrSpellingListIndex);
2476   else if (const auto *OA = dyn_cast<OptimizeNoneAttr>(Attr))
2477     NewAttr = S.mergeOptimizeNoneAttr(D, OA->getRange(), AttrSpellingListIndex);
2478   else if (const auto *InternalLinkageA = dyn_cast<InternalLinkageAttr>(Attr))
2479     NewAttr = S.mergeInternalLinkageAttr(
2480         D, InternalLinkageA->getRange(),
2481         &S.Context.Idents.get(InternalLinkageA->getSpelling()),
2482         AttrSpellingListIndex);
2483   else if (const auto *CommonA = dyn_cast<CommonAttr>(Attr))
2484     NewAttr = S.mergeCommonAttr(D, CommonA->getRange(),
2485                                 &S.Context.Idents.get(CommonA->getSpelling()),
2486                                 AttrSpellingListIndex);
2487   else if (isa<AlignedAttr>(Attr))
2488     // AlignedAttrs are handled separately, because we need to handle all
2489     // such attributes on a declaration at the same time.
2490     NewAttr = nullptr;
2491   else if ((isa<DeprecatedAttr>(Attr) || isa<UnavailableAttr>(Attr)) &&
2492            (AMK == Sema::AMK_Override ||
2493             AMK == Sema::AMK_ProtocolImplementation))
2494     NewAttr = nullptr;
2495   else if (const auto *UA = dyn_cast<UuidAttr>(Attr))
2496     NewAttr = S.mergeUuidAttr(D, UA->getRange(), AttrSpellingListIndex,
2497                               UA->getGuid());
2498   else if (Attr->duplicatesAllowed() || !DeclHasAttr(D, Attr))
2499     NewAttr = cast<InheritableAttr>(Attr->clone(S.Context));
2500 
2501   if (NewAttr) {
2502     NewAttr->setInherited(true);
2503     D->addAttr(NewAttr);
2504     if (isa<MSInheritanceAttr>(NewAttr))
2505       S.Consumer.AssignInheritanceModel(cast<CXXRecordDecl>(D));
2506     return true;
2507   }
2508 
2509   return false;
2510 }
2511 
2512 static const NamedDecl *getDefinition(const Decl *D) {
2513   if (const TagDecl *TD = dyn_cast<TagDecl>(D))
2514     return TD->getDefinition();
2515   if (const VarDecl *VD = dyn_cast<VarDecl>(D)) {
2516     const VarDecl *Def = VD->getDefinition();
2517     if (Def)
2518       return Def;
2519     return VD->getActingDefinition();
2520   }
2521   if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D))
2522     return FD->getDefinition();
2523   return nullptr;
2524 }
2525 
2526 static bool hasAttribute(const Decl *D, attr::Kind Kind) {
2527   for (const auto *Attribute : D->attrs())
2528     if (Attribute->getKind() == Kind)
2529       return true;
2530   return false;
2531 }
2532 
2533 /// checkNewAttributesAfterDef - If we already have a definition, check that
2534 /// there are no new attributes in this declaration.
2535 static void checkNewAttributesAfterDef(Sema &S, Decl *New, const Decl *Old) {
2536   if (!New->hasAttrs())
2537     return;
2538 
2539   const NamedDecl *Def = getDefinition(Old);
2540   if (!Def || Def == New)
2541     return;
2542 
2543   AttrVec &NewAttributes = New->getAttrs();
2544   for (unsigned I = 0, E = NewAttributes.size(); I != E;) {
2545     const Attr *NewAttribute = NewAttributes[I];
2546 
2547     if (isa<AliasAttr>(NewAttribute) || isa<IFuncAttr>(NewAttribute)) {
2548       if (FunctionDecl *FD = dyn_cast<FunctionDecl>(New)) {
2549         Sema::SkipBodyInfo SkipBody;
2550         S.CheckForFunctionRedefinition(FD, cast<FunctionDecl>(Def), &SkipBody);
2551 
2552         // If we're skipping this definition, drop the "alias" attribute.
2553         if (SkipBody.ShouldSkip) {
2554           NewAttributes.erase(NewAttributes.begin() + I);
2555           --E;
2556           continue;
2557         }
2558       } else {
2559         VarDecl *VD = cast<VarDecl>(New);
2560         unsigned Diag = cast<VarDecl>(Def)->isThisDeclarationADefinition() ==
2561                                 VarDecl::TentativeDefinition
2562                             ? diag::err_alias_after_tentative
2563                             : diag::err_redefinition;
2564         S.Diag(VD->getLocation(), Diag) << VD->getDeclName();
2565         if (Diag == diag::err_redefinition)
2566           S.notePreviousDefinition(Def, VD->getLocation());
2567         else
2568           S.Diag(Def->getLocation(), diag::note_previous_definition);
2569         VD->setInvalidDecl();
2570       }
2571       ++I;
2572       continue;
2573     }
2574 
2575     if (const VarDecl *VD = dyn_cast<VarDecl>(Def)) {
2576       // Tentative definitions are only interesting for the alias check above.
2577       if (VD->isThisDeclarationADefinition() != VarDecl::Definition) {
2578         ++I;
2579         continue;
2580       }
2581     }
2582 
2583     if (hasAttribute(Def, NewAttribute->getKind())) {
2584       ++I;
2585       continue; // regular attr merging will take care of validating this.
2586     }
2587 
2588     if (isa<C11NoReturnAttr>(NewAttribute)) {
2589       // C's _Noreturn is allowed to be added to a function after it is defined.
2590       ++I;
2591       continue;
2592     } else if (const AlignedAttr *AA = dyn_cast<AlignedAttr>(NewAttribute)) {
2593       if (AA->isAlignas()) {
2594         // C++11 [dcl.align]p6:
2595         //   if any declaration of an entity has an alignment-specifier,
2596         //   every defining declaration of that entity shall specify an
2597         //   equivalent alignment.
2598         // C11 6.7.5/7:
2599         //   If the definition of an object does not have an alignment
2600         //   specifier, any other declaration of that object shall also
2601         //   have no alignment specifier.
2602         S.Diag(Def->getLocation(), diag::err_alignas_missing_on_definition)
2603           << AA;
2604         S.Diag(NewAttribute->getLocation(), diag::note_alignas_on_declaration)
2605           << AA;
2606         NewAttributes.erase(NewAttributes.begin() + I);
2607         --E;
2608         continue;
2609       }
2610     }
2611 
2612     S.Diag(NewAttribute->getLocation(),
2613            diag::warn_attribute_precede_definition);
2614     S.Diag(Def->getLocation(), diag::note_previous_definition);
2615     NewAttributes.erase(NewAttributes.begin() + I);
2616     --E;
2617   }
2618 }
2619 
2620 /// mergeDeclAttributes - Copy attributes from the Old decl to the New one.
2621 void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old,
2622                                AvailabilityMergeKind AMK) {
2623   if (UsedAttr *OldAttr = Old->getMostRecentDecl()->getAttr<UsedAttr>()) {
2624     UsedAttr *NewAttr = OldAttr->clone(Context);
2625     NewAttr->setInherited(true);
2626     New->addAttr(NewAttr);
2627   }
2628 
2629   if (!Old->hasAttrs() && !New->hasAttrs())
2630     return;
2631 
2632   // Attributes declared post-definition are currently ignored.
2633   checkNewAttributesAfterDef(*this, New, Old);
2634 
2635   if (AsmLabelAttr *NewA = New->getAttr<AsmLabelAttr>()) {
2636     if (AsmLabelAttr *OldA = Old->getAttr<AsmLabelAttr>()) {
2637       if (OldA->getLabel() != NewA->getLabel()) {
2638         // This redeclaration changes __asm__ label.
2639         Diag(New->getLocation(), diag::err_different_asm_label);
2640         Diag(OldA->getLocation(), diag::note_previous_declaration);
2641       }
2642     } else if (Old->isUsed()) {
2643       // This redeclaration adds an __asm__ label to a declaration that has
2644       // already been ODR-used.
2645       Diag(New->getLocation(), diag::err_late_asm_label_name)
2646         << isa<FunctionDecl>(Old) << New->getAttr<AsmLabelAttr>()->getRange();
2647     }
2648   }
2649 
2650   // Re-declaration cannot add abi_tag's.
2651   if (const auto *NewAbiTagAttr = New->getAttr<AbiTagAttr>()) {
2652     if (const auto *OldAbiTagAttr = Old->getAttr<AbiTagAttr>()) {
2653       for (const auto &NewTag : NewAbiTagAttr->tags()) {
2654         if (std::find(OldAbiTagAttr->tags_begin(), OldAbiTagAttr->tags_end(),
2655                       NewTag) == OldAbiTagAttr->tags_end()) {
2656           Diag(NewAbiTagAttr->getLocation(),
2657                diag::err_new_abi_tag_on_redeclaration)
2658               << NewTag;
2659           Diag(OldAbiTagAttr->getLocation(), diag::note_previous_declaration);
2660         }
2661       }
2662     } else {
2663       Diag(NewAbiTagAttr->getLocation(), diag::err_abi_tag_on_redeclaration);
2664       Diag(Old->getLocation(), diag::note_previous_declaration);
2665     }
2666   }
2667 
2668   // This redeclaration adds a section attribute.
2669   if (New->hasAttr<SectionAttr>() && !Old->hasAttr<SectionAttr>()) {
2670     if (auto *VD = dyn_cast<VarDecl>(New)) {
2671       if (VD->isThisDeclarationADefinition() == VarDecl::DeclarationOnly) {
2672         Diag(New->getLocation(), diag::warn_attribute_section_on_redeclaration);
2673         Diag(Old->getLocation(), diag::note_previous_declaration);
2674       }
2675     }
2676   }
2677 
2678   if (!Old->hasAttrs())
2679     return;
2680 
2681   bool foundAny = New->hasAttrs();
2682 
2683   // Ensure that any moving of objects within the allocated map is done before
2684   // we process them.
2685   if (!foundAny) New->setAttrs(AttrVec());
2686 
2687   for (auto *I : Old->specific_attrs<InheritableAttr>()) {
2688     // Ignore deprecated/unavailable/availability attributes if requested.
2689     AvailabilityMergeKind LocalAMK = AMK_None;
2690     if (isa<DeprecatedAttr>(I) ||
2691         isa<UnavailableAttr>(I) ||
2692         isa<AvailabilityAttr>(I)) {
2693       switch (AMK) {
2694       case AMK_None:
2695         continue;
2696 
2697       case AMK_Redeclaration:
2698       case AMK_Override:
2699       case AMK_ProtocolImplementation:
2700         LocalAMK = AMK;
2701         break;
2702       }
2703     }
2704 
2705     // Already handled.
2706     if (isa<UsedAttr>(I))
2707       continue;
2708 
2709     if (mergeDeclAttribute(*this, New, I, LocalAMK))
2710       foundAny = true;
2711   }
2712 
2713   if (mergeAlignedAttrs(*this, New, Old))
2714     foundAny = true;
2715 
2716   if (!foundAny) New->dropAttrs();
2717 }
2718 
2719 /// mergeParamDeclAttributes - Copy attributes from the old parameter
2720 /// to the new one.
2721 static void mergeParamDeclAttributes(ParmVarDecl *newDecl,
2722                                      const ParmVarDecl *oldDecl,
2723                                      Sema &S) {
2724   // C++11 [dcl.attr.depend]p2:
2725   //   The first declaration of a function shall specify the
2726   //   carries_dependency attribute for its declarator-id if any declaration
2727   //   of the function specifies the carries_dependency attribute.
2728   const CarriesDependencyAttr *CDA = newDecl->getAttr<CarriesDependencyAttr>();
2729   if (CDA && !oldDecl->hasAttr<CarriesDependencyAttr>()) {
2730     S.Diag(CDA->getLocation(),
2731            diag::err_carries_dependency_missing_on_first_decl) << 1/*Param*/;
2732     // Find the first declaration of the parameter.
2733     // FIXME: Should we build redeclaration chains for function parameters?
2734     const FunctionDecl *FirstFD =
2735       cast<FunctionDecl>(oldDecl->getDeclContext())->getFirstDecl();
2736     const ParmVarDecl *FirstVD =
2737       FirstFD->getParamDecl(oldDecl->getFunctionScopeIndex());
2738     S.Diag(FirstVD->getLocation(),
2739            diag::note_carries_dependency_missing_first_decl) << 1/*Param*/;
2740   }
2741 
2742   if (!oldDecl->hasAttrs())
2743     return;
2744 
2745   bool foundAny = newDecl->hasAttrs();
2746 
2747   // Ensure that any moving of objects within the allocated map is
2748   // done before we process them.
2749   if (!foundAny) newDecl->setAttrs(AttrVec());
2750 
2751   for (const auto *I : oldDecl->specific_attrs<InheritableParamAttr>()) {
2752     if (!DeclHasAttr(newDecl, I)) {
2753       InheritableAttr *newAttr =
2754         cast<InheritableParamAttr>(I->clone(S.Context));
2755       newAttr->setInherited(true);
2756       newDecl->addAttr(newAttr);
2757       foundAny = true;
2758     }
2759   }
2760 
2761   if (!foundAny) newDecl->dropAttrs();
2762 }
2763 
2764 static void mergeParamDeclTypes(ParmVarDecl *NewParam,
2765                                 const ParmVarDecl *OldParam,
2766                                 Sema &S) {
2767   if (auto Oldnullability = OldParam->getType()->getNullability(S.Context)) {
2768     if (auto Newnullability = NewParam->getType()->getNullability(S.Context)) {
2769       if (*Oldnullability != *Newnullability) {
2770         S.Diag(NewParam->getLocation(), diag::warn_mismatched_nullability_attr)
2771           << DiagNullabilityKind(
2772                *Newnullability,
2773                ((NewParam->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
2774                 != 0))
2775           << DiagNullabilityKind(
2776                *Oldnullability,
2777                ((OldParam->getObjCDeclQualifier() & Decl::OBJC_TQ_CSNullability)
2778                 != 0));
2779         S.Diag(OldParam->getLocation(), diag::note_previous_declaration);
2780       }
2781     } else {
2782       QualType NewT = NewParam->getType();
2783       NewT = S.Context.getAttributedType(
2784                          AttributedType::getNullabilityAttrKind(*Oldnullability),
2785                          NewT, NewT);
2786       NewParam->setType(NewT);
2787     }
2788   }
2789 }
2790 
2791 namespace {
2792 
2793 /// Used in MergeFunctionDecl to keep track of function parameters in
2794 /// C.
2795 struct GNUCompatibleParamWarning {
2796   ParmVarDecl *OldParm;
2797   ParmVarDecl *NewParm;
2798   QualType PromotedType;
2799 };
2800 
2801 } // end anonymous namespace
2802 
2803 /// getSpecialMember - get the special member enum for a method.
2804 Sema::CXXSpecialMember Sema::getSpecialMember(const CXXMethodDecl *MD) {
2805   if (const CXXConstructorDecl *Ctor = dyn_cast<CXXConstructorDecl>(MD)) {
2806     if (Ctor->isDefaultConstructor())
2807       return Sema::CXXDefaultConstructor;
2808 
2809     if (Ctor->isCopyConstructor())
2810       return Sema::CXXCopyConstructor;
2811 
2812     if (Ctor->isMoveConstructor())
2813       return Sema::CXXMoveConstructor;
2814   } else if (isa<CXXDestructorDecl>(MD)) {
2815     return Sema::CXXDestructor;
2816   } else if (MD->isCopyAssignmentOperator()) {
2817     return Sema::CXXCopyAssignment;
2818   } else if (MD->isMoveAssignmentOperator()) {
2819     return Sema::CXXMoveAssignment;
2820   }
2821 
2822   return Sema::CXXInvalid;
2823 }
2824 
2825 // Determine whether the previous declaration was a definition, implicit
2826 // declaration, or a declaration.
2827 template <typename T>
2828 static std::pair<diag::kind, SourceLocation>
2829 getNoteDiagForInvalidRedeclaration(const T *Old, const T *New) {
2830   diag::kind PrevDiag;
2831   SourceLocation OldLocation = Old->getLocation();
2832   if (Old->isThisDeclarationADefinition())
2833     PrevDiag = diag::note_previous_definition;
2834   else if (Old->isImplicit()) {
2835     PrevDiag = diag::note_previous_implicit_declaration;
2836     if (OldLocation.isInvalid())
2837       OldLocation = New->getLocation();
2838   } else
2839     PrevDiag = diag::note_previous_declaration;
2840   return std::make_pair(PrevDiag, OldLocation);
2841 }
2842 
2843 /// canRedefineFunction - checks if a function can be redefined. Currently,
2844 /// only extern inline functions can be redefined, and even then only in
2845 /// GNU89 mode.
2846 static bool canRedefineFunction(const FunctionDecl *FD,
2847                                 const LangOptions& LangOpts) {
2848   return ((FD->hasAttr<GNUInlineAttr>() || LangOpts.GNUInline) &&
2849           !LangOpts.CPlusPlus &&
2850           FD->isInlineSpecified() &&
2851           FD->getStorageClass() == SC_Extern);
2852 }
2853 
2854 const AttributedType *Sema::getCallingConvAttributedType(QualType T) const {
2855   const AttributedType *AT = T->getAs<AttributedType>();
2856   while (AT && !AT->isCallingConv())
2857     AT = AT->getModifiedType()->getAs<AttributedType>();
2858   return AT;
2859 }
2860 
2861 template <typename T>
2862 static bool haveIncompatibleLanguageLinkages(const T *Old, const T *New) {
2863   const DeclContext *DC = Old->getDeclContext();
2864   if (DC->isRecord())
2865     return false;
2866 
2867   LanguageLinkage OldLinkage = Old->getLanguageLinkage();
2868   if (OldLinkage == CXXLanguageLinkage && New->isInExternCContext())
2869     return true;
2870   if (OldLinkage == CLanguageLinkage && New->isInExternCXXContext())
2871     return true;
2872   return false;
2873 }
2874 
2875 template<typename T> static bool isExternC(T *D) { return D->isExternC(); }
2876 static bool isExternC(VarTemplateDecl *) { return false; }
2877 
2878 /// \brief Check whether a redeclaration of an entity introduced by a
2879 /// using-declaration is valid, given that we know it's not an overload
2880 /// (nor a hidden tag declaration).
2881 template<typename ExpectedDecl>
2882 static bool checkUsingShadowRedecl(Sema &S, UsingShadowDecl *OldS,
2883                                    ExpectedDecl *New) {
2884   // C++11 [basic.scope.declarative]p4:
2885   //   Given a set of declarations in a single declarative region, each of
2886   //   which specifies the same unqualified name,
2887   //   -- they shall all refer to the same entity, or all refer to functions
2888   //      and function templates; or
2889   //   -- exactly one declaration shall declare a class name or enumeration
2890   //      name that is not a typedef name and the other declarations shall all
2891   //      refer to the same variable or enumerator, or all refer to functions
2892   //      and function templates; in this case the class name or enumeration
2893   //      name is hidden (3.3.10).
2894 
2895   // C++11 [namespace.udecl]p14:
2896   //   If a function declaration in namespace scope or block scope has the
2897   //   same name and the same parameter-type-list as a function introduced
2898   //   by a using-declaration, and the declarations do not declare the same
2899   //   function, the program is ill-formed.
2900 
2901   auto *Old = dyn_cast<ExpectedDecl>(OldS->getTargetDecl());
2902   if (Old &&
2903       !Old->getDeclContext()->getRedeclContext()->Equals(
2904           New->getDeclContext()->getRedeclContext()) &&
2905       !(isExternC(Old) && isExternC(New)))
2906     Old = nullptr;
2907 
2908   if (!Old) {
2909     S.Diag(New->getLocation(), diag::err_using_decl_conflict_reverse);
2910     S.Diag(OldS->getTargetDecl()->getLocation(), diag::note_using_decl_target);
2911     S.Diag(OldS->getUsingDecl()->getLocation(), diag::note_using_decl) << 0;
2912     return true;
2913   }
2914   return false;
2915 }
2916 
2917 static bool hasIdenticalPassObjectSizeAttrs(const FunctionDecl *A,
2918                                             const FunctionDecl *B) {
2919   assert(A->getNumParams() == B->getNumParams());
2920 
2921   auto AttrEq = [](const ParmVarDecl *A, const ParmVarDecl *B) {
2922     const auto *AttrA = A->getAttr<PassObjectSizeAttr>();
2923     const auto *AttrB = B->getAttr<PassObjectSizeAttr>();
2924     if (AttrA == AttrB)
2925       return true;
2926     return AttrA && AttrB && AttrA->getType() == AttrB->getType();
2927   };
2928 
2929   return std::equal(A->param_begin(), A->param_end(), B->param_begin(), AttrEq);
2930 }
2931 
2932 /// MergeFunctionDecl - We just parsed a function 'New' from
2933 /// declarator D which has the same name and scope as a previous
2934 /// declaration 'Old'.  Figure out how to resolve this situation,
2935 /// merging decls or emitting diagnostics as appropriate.
2936 ///
2937 /// In C++, New and Old must be declarations that are not
2938 /// overloaded. Use IsOverload to determine whether New and Old are
2939 /// overloaded, and to select the Old declaration that New should be
2940 /// merged with.
2941 ///
2942 /// Returns true if there was an error, false otherwise.
2943 bool Sema::MergeFunctionDecl(FunctionDecl *New, NamedDecl *&OldD,
2944                              Scope *S, bool MergeTypeWithOld) {
2945   // Verify the old decl was also a function.
2946   FunctionDecl *Old = OldD->getAsFunction();
2947   if (!Old) {
2948     if (UsingShadowDecl *Shadow = dyn_cast<UsingShadowDecl>(OldD)) {
2949       if (New->getFriendObjectKind()) {
2950         Diag(New->getLocation(), diag::err_using_decl_friend);
2951         Diag(Shadow->getTargetDecl()->getLocation(),
2952              diag::note_using_decl_target);
2953         Diag(Shadow->getUsingDecl()->getLocation(),
2954              diag::note_using_decl) << 0;
2955         return true;
2956       }
2957 
2958       // Check whether the two declarations might declare the same function.
2959       if (checkUsingShadowRedecl<FunctionDecl>(*this, Shadow, New))
2960         return true;
2961       OldD = Old = cast<FunctionDecl>(Shadow->getTargetDecl());
2962     } else {
2963       Diag(New->getLocation(), diag::err_redefinition_different_kind)
2964         << New->getDeclName();
2965       notePreviousDefinition(OldD, New->getLocation());
2966       return true;
2967     }
2968   }
2969 
2970   // If the old declaration is invalid, just give up here.
2971   if (Old->isInvalidDecl())
2972     return true;
2973 
2974   diag::kind PrevDiag;
2975   SourceLocation OldLocation;
2976   std::tie(PrevDiag, OldLocation) =
2977       getNoteDiagForInvalidRedeclaration(Old, New);
2978 
2979   // Don't complain about this if we're in GNU89 mode and the old function
2980   // is an extern inline function.
2981   // Don't complain about specializations. They are not supposed to have
2982   // storage classes.
2983   if (!isa<CXXMethodDecl>(New) && !isa<CXXMethodDecl>(Old) &&
2984       New->getStorageClass() == SC_Static &&
2985       Old->hasExternalFormalLinkage() &&
2986       !New->getTemplateSpecializationInfo() &&
2987       !canRedefineFunction(Old, getLangOpts())) {
2988     if (getLangOpts().MicrosoftExt) {
2989       Diag(New->getLocation(), diag::ext_static_non_static) << New;
2990       Diag(OldLocation, PrevDiag);
2991     } else {
2992       Diag(New->getLocation(), diag::err_static_non_static) << New;
2993       Diag(OldLocation, PrevDiag);
2994       return true;
2995     }
2996   }
2997 
2998   if (New->hasAttr<InternalLinkageAttr>() &&
2999       !Old->hasAttr<InternalLinkageAttr>()) {
3000     Diag(New->getLocation(), diag::err_internal_linkage_redeclaration)
3001         << New->getDeclName();
3002     notePreviousDefinition(Old, New->getLocation());
3003     New->dropAttr<InternalLinkageAttr>();
3004   }
3005 
3006   if (CheckRedeclarationModuleOwnership(New, Old))
3007     return true;
3008 
3009   if (!getLangOpts().CPlusPlus) {
3010     bool OldOvl = Old->hasAttr<OverloadableAttr>();
3011     if (OldOvl != New->hasAttr<OverloadableAttr>() && !Old->isImplicit()) {
3012       Diag(New->getLocation(), diag::err_attribute_overloadable_mismatch)
3013         << New << OldOvl;
3014 
3015       // Try our best to find a decl that actually has the overloadable
3016       // attribute for the note. In most cases (e.g. programs with only one
3017       // broken declaration/definition), this won't matter.
3018       //
3019       // FIXME: We could do this if we juggled some extra state in
3020       // OverloadableAttr, rather than just removing it.
3021       const Decl *DiagOld = Old;
3022       if (OldOvl) {
3023         auto OldIter = llvm::find_if(Old->redecls(), [](const Decl *D) {
3024           const auto *A = D->getAttr<OverloadableAttr>();
3025           return A && !A->isImplicit();
3026         });
3027         // If we've implicitly added *all* of the overloadable attrs to this
3028         // chain, emitting a "previous redecl" note is pointless.
3029         DiagOld = OldIter == Old->redecls_end() ? nullptr : *OldIter;
3030       }
3031 
3032       if (DiagOld)
3033         Diag(DiagOld->getLocation(),
3034              diag::note_attribute_overloadable_prev_overload)
3035           << OldOvl;
3036 
3037       if (OldOvl)
3038         New->addAttr(OverloadableAttr::CreateImplicit(Context));
3039       else
3040         New->dropAttr<OverloadableAttr>();
3041     }
3042   }
3043 
3044   // If a function is first declared with a calling convention, but is later
3045   // declared or defined without one, all following decls assume the calling
3046   // convention of the first.
3047   //
3048   // It's OK if a function is first declared without a calling convention,
3049   // but is later declared or defined with the default calling convention.
3050   //
3051   // To test if either decl has an explicit calling convention, we look for
3052   // AttributedType sugar nodes on the type as written.  If they are missing or
3053   // were canonicalized away, we assume the calling convention was implicit.
3054   //
3055   // Note also that we DO NOT return at this point, because we still have
3056   // other tests to run.
3057   QualType OldQType = Context.getCanonicalType(Old->getType());
3058   QualType NewQType = Context.getCanonicalType(New->getType());
3059   const FunctionType *OldType = cast<FunctionType>(OldQType);
3060   const FunctionType *NewType = cast<FunctionType>(NewQType);
3061   FunctionType::ExtInfo OldTypeInfo = OldType->getExtInfo();
3062   FunctionType::ExtInfo NewTypeInfo = NewType->getExtInfo();
3063   bool RequiresAdjustment = false;
3064 
3065   if (OldTypeInfo.getCC() != NewTypeInfo.getCC()) {
3066     FunctionDecl *First = Old->getFirstDecl();
3067     const FunctionType *FT =
3068         First->getType().getCanonicalType()->castAs<FunctionType>();
3069     FunctionType::ExtInfo FI = FT->getExtInfo();
3070     bool NewCCExplicit = getCallingConvAttributedType(New->getType());
3071     if (!NewCCExplicit) {
3072       // Inherit the CC from the previous declaration if it was specified
3073       // there but not here.
3074       NewTypeInfo = NewTypeInfo.withCallingConv(OldTypeInfo.getCC());
3075       RequiresAdjustment = true;
3076     } else {
3077       // Calling conventions aren't compatible, so complain.
3078       bool FirstCCExplicit = getCallingConvAttributedType(First->getType());
3079       Diag(New->getLocation(), diag::err_cconv_change)
3080         << FunctionType::getNameForCallConv(NewTypeInfo.getCC())
3081         << !FirstCCExplicit
3082         << (!FirstCCExplicit ? "" :
3083             FunctionType::getNameForCallConv(FI.getCC()));
3084 
3085       // Put the note on the first decl, since it is the one that matters.
3086       Diag(First->getLocation(), diag::note_previous_declaration);
3087       return true;
3088     }
3089   }
3090 
3091   // FIXME: diagnose the other way around?
3092   if (OldTypeInfo.getNoReturn() && !NewTypeInfo.getNoReturn()) {
3093     NewTypeInfo = NewTypeInfo.withNoReturn(true);
3094     RequiresAdjustment = true;
3095   }
3096 
3097   // Merge regparm attribute.
3098   if (OldTypeInfo.getHasRegParm() != NewTypeInfo.getHasRegParm() ||
3099       OldTypeInfo.getRegParm() != NewTypeInfo.getRegParm()) {
3100     if (NewTypeInfo.getHasRegParm()) {
3101       Diag(New->getLocation(), diag::err_regparm_mismatch)
3102         << NewType->getRegParmType()
3103         << OldType->getRegParmType();
3104       Diag(OldLocation, diag::note_previous_declaration);
3105       return true;
3106     }
3107 
3108     NewTypeInfo = NewTypeInfo.withRegParm(OldTypeInfo.getRegParm());
3109     RequiresAdjustment = true;
3110   }
3111 
3112   // Merge ns_returns_retained attribute.
3113   if (OldTypeInfo.getProducesResult() != NewTypeInfo.getProducesResult()) {
3114     if (NewTypeInfo.getProducesResult()) {
3115       Diag(New->getLocation(), diag::err_function_attribute_mismatch)
3116           << "'ns_returns_retained'";
3117       Diag(OldLocation, diag::note_previous_declaration);
3118       return true;
3119     }
3120 
3121     NewTypeInfo = NewTypeInfo.withProducesResult(true);
3122     RequiresAdjustment = true;
3123   }
3124 
3125   if (OldTypeInfo.getNoCallerSavedRegs() !=
3126       NewTypeInfo.getNoCallerSavedRegs()) {
3127     if (NewTypeInfo.getNoCallerSavedRegs()) {
3128       AnyX86NoCallerSavedRegistersAttr *Attr =
3129         New->getAttr<AnyX86NoCallerSavedRegistersAttr>();
3130       Diag(New->getLocation(), diag::err_function_attribute_mismatch) << Attr;
3131       Diag(OldLocation, diag::note_previous_declaration);
3132       return true;
3133     }
3134 
3135     NewTypeInfo = NewTypeInfo.withNoCallerSavedRegs(true);
3136     RequiresAdjustment = true;
3137   }
3138 
3139   if (RequiresAdjustment) {
3140     const FunctionType *AdjustedType = New->getType()->getAs<FunctionType>();
3141     AdjustedType = Context.adjustFunctionType(AdjustedType, NewTypeInfo);
3142     New->setType(QualType(AdjustedType, 0));
3143     NewQType = Context.getCanonicalType(New->getType());
3144     NewType = cast<FunctionType>(NewQType);
3145   }
3146 
3147   // If this redeclaration makes the function inline, we may need to add it to
3148   // UndefinedButUsed.
3149   if (!Old->isInlined() && New->isInlined() &&
3150       !New->hasAttr<GNUInlineAttr>() &&
3151       !getLangOpts().GNUInline &&
3152       Old->isUsed(false) &&
3153       !Old->isDefined() && !New->isThisDeclarationADefinition())
3154     UndefinedButUsed.insert(std::make_pair(Old->getCanonicalDecl(),
3155                                            SourceLocation()));
3156 
3157   // If this redeclaration makes it newly gnu_inline, we don't want to warn
3158   // about it.
3159   if (New->hasAttr<GNUInlineAttr>() &&
3160       Old->isInlined() && !Old->hasAttr<GNUInlineAttr>()) {
3161     UndefinedButUsed.erase(Old->getCanonicalDecl());
3162   }
3163 
3164   // If pass_object_size params don't match up perfectly, this isn't a valid
3165   // redeclaration.
3166   if (Old->getNumParams() > 0 && Old->getNumParams() == New->getNumParams() &&
3167       !hasIdenticalPassObjectSizeAttrs(Old, New)) {
3168     Diag(New->getLocation(), diag::err_different_pass_object_size_params)
3169         << New->getDeclName();
3170     Diag(OldLocation, PrevDiag) << Old << Old->getType();
3171     return true;
3172   }
3173 
3174   if (getLangOpts().CPlusPlus) {
3175     // C++1z [over.load]p2
3176     //   Certain function declarations cannot be overloaded:
3177     //     -- Function declarations that differ only in the return type,
3178     //        the exception specification, or both cannot be overloaded.
3179 
3180     // Check the exception specifications match. This may recompute the type of
3181     // both Old and New if it resolved exception specifications, so grab the
3182     // types again after this. Because this updates the type, we do this before
3183     // any of the other checks below, which may update the "de facto" NewQType
3184     // but do not necessarily update the type of New.
3185     if (CheckEquivalentExceptionSpec(Old, New))
3186       return true;
3187     OldQType = Context.getCanonicalType(Old->getType());
3188     NewQType = Context.getCanonicalType(New->getType());
3189 
3190     // Go back to the type source info to compare the declared return types,
3191     // per C++1y [dcl.type.auto]p13:
3192     //   Redeclarations or specializations of a function or function template
3193     //   with a declared return type that uses a placeholder type shall also
3194     //   use that placeholder, not a deduced type.
3195     QualType OldDeclaredReturnType =
3196         (Old->getTypeSourceInfo()
3197              ? Old->getTypeSourceInfo()->getType()->castAs<FunctionType>()
3198              : OldType)->getReturnType();
3199     QualType NewDeclaredReturnType =
3200         (New->getTypeSourceInfo()
3201              ? New->getTypeSourceInfo()->getType()->castAs<FunctionType>()
3202              : NewType)->getReturnType();
3203     if (!Context.hasSameType(OldDeclaredReturnType, NewDeclaredReturnType) &&
3204         !((NewQType->isDependentType() || OldQType->isDependentType()) &&
3205           New->isLocalExternDecl())) {
3206       QualType ResQT;
3207       if (NewDeclaredReturnType->isObjCObjectPointerType() &&
3208           OldDeclaredReturnType->isObjCObjectPointerType())
3209         ResQT = Context.mergeObjCGCQualifiers(NewQType, OldQType);
3210       if (ResQT.isNull()) {
3211         if (New->isCXXClassMember() && New->isOutOfLine())
3212           Diag(New->getLocation(), diag::err_member_def_does_not_match_ret_type)
3213               << New << New->getReturnTypeSourceRange();
3214         else
3215           Diag(New->getLocation(), diag::err_ovl_diff_return_type)
3216               << New->getReturnTypeSourceRange();
3217         Diag(OldLocation, PrevDiag) << Old << Old->getType()
3218                                     << Old->getReturnTypeSourceRange();
3219         return true;
3220       }
3221       else
3222         NewQType = ResQT;
3223     }
3224 
3225     QualType OldReturnType = OldType->getReturnType();
3226     QualType NewReturnType = cast<FunctionType>(NewQType)->getReturnType();
3227     if (OldReturnType != NewReturnType) {
3228       // If this function has a deduced return type and has already been
3229       // defined, copy the deduced value from the old declaration.
3230       AutoType *OldAT = Old->getReturnType()->getContainedAutoType();
3231       if (OldAT && OldAT->isDeduced()) {
3232         New->setType(
3233             SubstAutoType(New->getType(),
3234                           OldAT->isDependentType() ? Context.DependentTy
3235                                                    : OldAT->getDeducedType()));
3236         NewQType = Context.getCanonicalType(
3237             SubstAutoType(NewQType,
3238                           OldAT->isDependentType() ? Context.DependentTy
3239                                                    : OldAT->getDeducedType()));
3240       }
3241     }
3242 
3243     const CXXMethodDecl *OldMethod = dyn_cast<CXXMethodDecl>(Old);
3244     CXXMethodDecl *NewMethod = dyn_cast<CXXMethodDecl>(New);
3245     if (OldMethod && NewMethod) {
3246       // Preserve triviality.
3247       NewMethod->setTrivial(OldMethod->isTrivial());
3248 
3249       // MSVC allows explicit template specialization at class scope:
3250       // 2 CXXMethodDecls referring to the same function will be injected.
3251       // We don't want a redeclaration error.
3252       bool IsClassScopeExplicitSpecialization =
3253                               OldMethod->isFunctionTemplateSpecialization() &&
3254                               NewMethod->isFunctionTemplateSpecialization();
3255       bool isFriend = NewMethod->getFriendObjectKind();
3256 
3257       if (!isFriend && NewMethod->getLexicalDeclContext()->isRecord() &&
3258           !IsClassScopeExplicitSpecialization) {
3259         //    -- Member function declarations with the same name and the
3260         //       same parameter types cannot be overloaded if any of them
3261         //       is a static member function declaration.
3262         if (OldMethod->isStatic() != NewMethod->isStatic()) {
3263           Diag(New->getLocation(), diag::err_ovl_static_nonstatic_member);
3264           Diag(OldLocation, PrevDiag) << Old << Old->getType();
3265           return true;
3266         }
3267 
3268         // C++ [class.mem]p1:
3269         //   [...] A member shall not be declared twice in the
3270         //   member-specification, except that a nested class or member
3271         //   class template can be declared and then later defined.
3272         if (!inTemplateInstantiation()) {
3273           unsigned NewDiag;
3274           if (isa<CXXConstructorDecl>(OldMethod))
3275             NewDiag = diag::err_constructor_redeclared;
3276           else if (isa<CXXDestructorDecl>(NewMethod))
3277             NewDiag = diag::err_destructor_redeclared;
3278           else if (isa<CXXConversionDecl>(NewMethod))
3279             NewDiag = diag::err_conv_function_redeclared;
3280           else
3281             NewDiag = diag::err_member_redeclared;
3282 
3283           Diag(New->getLocation(), NewDiag);
3284         } else {
3285           Diag(New->getLocation(), diag::err_member_redeclared_in_instantiation)
3286             << New << New->getType();
3287         }
3288         Diag(OldLocation, PrevDiag) << Old << Old->getType();
3289         return true;
3290 
3291       // Complain if this is an explicit declaration of a special
3292       // member that was initially declared implicitly.
3293       //
3294       // As an exception, it's okay to befriend such methods in order
3295       // to permit the implicit constructor/destructor/operator calls.
3296       } else if (OldMethod->isImplicit()) {
3297         if (isFriend) {
3298           NewMethod->setImplicit();
3299         } else {
3300           Diag(NewMethod->getLocation(),
3301                diag::err_definition_of_implicitly_declared_member)
3302             << New << getSpecialMember(OldMethod);
3303           return true;
3304         }
3305       } else if (OldMethod->getFirstDecl()->isExplicitlyDefaulted() && !isFriend) {
3306         Diag(NewMethod->getLocation(),
3307              diag::err_definition_of_explicitly_defaulted_member)
3308           << getSpecialMember(OldMethod);
3309         return true;
3310       }
3311     }
3312 
3313     // C++11 [dcl.attr.noreturn]p1:
3314     //   The first declaration of a function shall specify the noreturn
3315     //   attribute if any declaration of that function specifies the noreturn
3316     //   attribute.
3317     const CXX11NoReturnAttr *NRA = New->getAttr<CXX11NoReturnAttr>();
3318     if (NRA && !Old->hasAttr<CXX11NoReturnAttr>()) {
3319       Diag(NRA->getLocation(), diag::err_noreturn_missing_on_first_decl);
3320       Diag(Old->getFirstDecl()->getLocation(),
3321            diag::note_noreturn_missing_first_decl);
3322     }
3323 
3324     // C++11 [dcl.attr.depend]p2:
3325     //   The first declaration of a function shall specify the
3326     //   carries_dependency attribute for its declarator-id if any declaration
3327     //   of the function specifies the carries_dependency attribute.
3328     const CarriesDependencyAttr *CDA = New->getAttr<CarriesDependencyAttr>();
3329     if (CDA && !Old->hasAttr<CarriesDependencyAttr>()) {
3330       Diag(CDA->getLocation(),
3331            diag::err_carries_dependency_missing_on_first_decl) << 0/*Function*/;
3332       Diag(Old->getFirstDecl()->getLocation(),
3333            diag::note_carries_dependency_missing_first_decl) << 0/*Function*/;
3334     }
3335 
3336     // (C++98 8.3.5p3):
3337     //   All declarations for a function shall agree exactly in both the
3338     //   return type and the parameter-type-list.
3339     // We also want to respect all the extended bits except noreturn.
3340 
3341     // noreturn should now match unless the old type info didn't have it.
3342     QualType OldQTypeForComparison = OldQType;
3343     if (!OldTypeInfo.getNoReturn() && NewTypeInfo.getNoReturn()) {
3344       auto *OldType = OldQType->castAs<FunctionProtoType>();
3345       const FunctionType *OldTypeForComparison
3346         = Context.adjustFunctionType(OldType, OldTypeInfo.withNoReturn(true));
3347       OldQTypeForComparison = QualType(OldTypeForComparison, 0);
3348       assert(OldQTypeForComparison.isCanonical());
3349     }
3350 
3351     if (haveIncompatibleLanguageLinkages(Old, New)) {
3352       // As a special case, retain the language linkage from previous
3353       // declarations of a friend function as an extension.
3354       //
3355       // This liberal interpretation of C++ [class.friend]p3 matches GCC/MSVC
3356       // and is useful because there's otherwise no way to specify language
3357       // linkage within class scope.
3358       //
3359       // Check cautiously as the friend object kind isn't yet complete.
3360       if (New->getFriendObjectKind() != Decl::FOK_None) {
3361         Diag(New->getLocation(), diag::ext_retained_language_linkage) << New;
3362         Diag(OldLocation, PrevDiag);
3363       } else {
3364         Diag(New->getLocation(), diag::err_different_language_linkage) << New;
3365         Diag(OldLocation, PrevDiag);
3366         return true;
3367       }
3368     }
3369 
3370     if (OldQTypeForComparison == NewQType)
3371       return MergeCompatibleFunctionDecls(New, Old, S, MergeTypeWithOld);
3372 
3373     if ((NewQType->isDependentType() || OldQType->isDependentType()) &&
3374         New->isLocalExternDecl()) {
3375       // It's OK if we couldn't merge types for a local function declaraton
3376       // if either the old or new type is dependent. We'll merge the types
3377       // when we instantiate the function.
3378       return false;
3379     }
3380 
3381     // Fall through for conflicting redeclarations and redefinitions.
3382   }
3383 
3384   // C: Function types need to be compatible, not identical. This handles
3385   // duplicate function decls like "void f(int); void f(enum X);" properly.
3386   if (!getLangOpts().CPlusPlus &&
3387       Context.typesAreCompatible(OldQType, NewQType)) {
3388     const FunctionType *OldFuncType = OldQType->getAs<FunctionType>();
3389     const FunctionType *NewFuncType = NewQType->getAs<FunctionType>();
3390     const FunctionProtoType *OldProto = nullptr;
3391     if (MergeTypeWithOld && isa<FunctionNoProtoType>(NewFuncType) &&
3392         (OldProto = dyn_cast<FunctionProtoType>(OldFuncType))) {
3393       // The old declaration provided a function prototype, but the
3394       // new declaration does not. Merge in the prototype.
3395       assert(!OldProto->hasExceptionSpec() && "Exception spec in C");
3396       SmallVector<QualType, 16> ParamTypes(OldProto->param_types());
3397       NewQType =
3398           Context.getFunctionType(NewFuncType->getReturnType(), ParamTypes,
3399                                   OldProto->getExtProtoInfo());
3400       New->setType(NewQType);
3401       New->setHasInheritedPrototype();
3402 
3403       // Synthesize parameters with the same types.
3404       SmallVector<ParmVarDecl*, 16> Params;
3405       for (const auto &ParamType : OldProto->param_types()) {
3406         ParmVarDecl *Param = ParmVarDecl::Create(Context, New, SourceLocation(),
3407                                                  SourceLocation(), nullptr,
3408                                                  ParamType, /*TInfo=*/nullptr,
3409                                                  SC_None, nullptr);
3410         Param->setScopeInfo(0, Params.size());
3411         Param->setImplicit();
3412         Params.push_back(Param);
3413       }
3414 
3415       New->setParams(Params);
3416     }
3417 
3418     return MergeCompatibleFunctionDecls(New, Old, S, MergeTypeWithOld);
3419   }
3420 
3421   // GNU C permits a K&R definition to follow a prototype declaration
3422   // if the declared types of the parameters in the K&R definition
3423   // match the types in the prototype declaration, even when the
3424   // promoted types of the parameters from the K&R definition differ
3425   // from the types in the prototype. GCC then keeps the types from
3426   // the prototype.
3427   //
3428   // If a variadic prototype is followed by a non-variadic K&R definition,
3429   // the K&R definition becomes variadic.  This is sort of an edge case, but
3430   // it's legal per the standard depending on how you read C99 6.7.5.3p15 and
3431   // C99 6.9.1p8.
3432   if (!getLangOpts().CPlusPlus &&
3433       Old->hasPrototype() && !New->hasPrototype() &&
3434       New->getType()->getAs<FunctionProtoType>() &&
3435       Old->getNumParams() == New->getNumParams()) {
3436     SmallVector<QualType, 16> ArgTypes;
3437     SmallVector<GNUCompatibleParamWarning, 16> Warnings;
3438     const FunctionProtoType *OldProto
3439       = Old->getType()->getAs<FunctionProtoType>();
3440     const FunctionProtoType *NewProto
3441       = New->getType()->getAs<FunctionProtoType>();
3442 
3443     // Determine whether this is the GNU C extension.
3444     QualType MergedReturn = Context.mergeTypes(OldProto->getReturnType(),
3445                                                NewProto->getReturnType());
3446     bool LooseCompatible = !MergedReturn.isNull();
3447     for (unsigned Idx = 0, End = Old->getNumParams();
3448          LooseCompatible && Idx != End; ++Idx) {
3449       ParmVarDecl *OldParm = Old->getParamDecl(Idx);
3450       ParmVarDecl *NewParm = New->getParamDecl(Idx);
3451       if (Context.typesAreCompatible(OldParm->getType(),
3452                                      NewProto->getParamType(Idx))) {
3453         ArgTypes.push_back(NewParm->getType());
3454       } else if (Context.typesAreCompatible(OldParm->getType(),
3455                                             NewParm->getType(),
3456                                             /*CompareUnqualified=*/true)) {
3457         GNUCompatibleParamWarning Warn = { OldParm, NewParm,
3458                                            NewProto->getParamType(Idx) };
3459         Warnings.push_back(Warn);
3460         ArgTypes.push_back(NewParm->getType());
3461       } else
3462         LooseCompatible = false;
3463     }
3464 
3465     if (LooseCompatible) {
3466       for (unsigned Warn = 0; Warn < Warnings.size(); ++Warn) {
3467         Diag(Warnings[Warn].NewParm->getLocation(),
3468              diag::ext_param_promoted_not_compatible_with_prototype)
3469           << Warnings[Warn].PromotedType
3470           << Warnings[Warn].OldParm->getType();
3471         if (Warnings[Warn].OldParm->getLocation().isValid())
3472           Diag(Warnings[Warn].OldParm->getLocation(),
3473                diag::note_previous_declaration);
3474       }
3475 
3476       if (MergeTypeWithOld)
3477         New->setType(Context.getFunctionType(MergedReturn, ArgTypes,
3478                                              OldProto->getExtProtoInfo()));
3479       return MergeCompatibleFunctionDecls(New, Old, S, MergeTypeWithOld);
3480     }
3481 
3482     // Fall through to diagnose conflicting types.
3483   }
3484 
3485   // A function that has already been declared has been redeclared or
3486   // defined with a different type; show an appropriate diagnostic.
3487 
3488   // If the previous declaration was an implicitly-generated builtin
3489   // declaration, then at the very least we should use a specialized note.
3490   unsigned BuiltinID;
3491   if (Old->isImplicit() && (BuiltinID = Old->getBuiltinID())) {
3492     // If it's actually a library-defined builtin function like 'malloc'
3493     // or 'printf', just warn about the incompatible redeclaration.
3494     if (Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID)) {
3495       Diag(New->getLocation(), diag::warn_redecl_library_builtin) << New;
3496       Diag(OldLocation, diag::note_previous_builtin_declaration)
3497         << Old << Old->getType();
3498 
3499       // If this is a global redeclaration, just forget hereafter
3500       // about the "builtin-ness" of the function.
3501       //
3502       // Doing this for local extern declarations is problematic.  If
3503       // the builtin declaration remains visible, a second invalid
3504       // local declaration will produce a hard error; if it doesn't
3505       // remain visible, a single bogus local redeclaration (which is
3506       // actually only a warning) could break all the downstream code.
3507       if (!New->getLexicalDeclContext()->isFunctionOrMethod())
3508         New->getIdentifier()->revertBuiltin();
3509 
3510       return false;
3511     }
3512 
3513     PrevDiag = diag::note_previous_builtin_declaration;
3514   }
3515 
3516   Diag(New->getLocation(), diag::err_conflicting_types) << New->getDeclName();
3517   Diag(OldLocation, PrevDiag) << Old << Old->getType();
3518   return true;
3519 }
3520 
3521 /// \brief Completes the merge of two function declarations that are
3522 /// known to be compatible.
3523 ///
3524 /// This routine handles the merging of attributes and other
3525 /// properties of function declarations from the old declaration to
3526 /// the new declaration, once we know that New is in fact a
3527 /// redeclaration of Old.
3528 ///
3529 /// \returns false
3530 bool Sema::MergeCompatibleFunctionDecls(FunctionDecl *New, FunctionDecl *Old,
3531                                         Scope *S, bool MergeTypeWithOld) {
3532   // Merge the attributes
3533   mergeDeclAttributes(New, Old);
3534 
3535   // Merge "pure" flag.
3536   if (Old->isPure())
3537     New->setPure();
3538 
3539   // Merge "used" flag.
3540   if (Old->getMostRecentDecl()->isUsed(false))
3541     New->setIsUsed();
3542 
3543   // Merge attributes from the parameters.  These can mismatch with K&R
3544   // declarations.
3545   if (New->getNumParams() == Old->getNumParams())
3546       for (unsigned i = 0, e = New->getNumParams(); i != e; ++i) {
3547         ParmVarDecl *NewParam = New->getParamDecl(i);
3548         ParmVarDecl *OldParam = Old->getParamDecl(i);
3549         mergeParamDeclAttributes(NewParam, OldParam, *this);
3550         mergeParamDeclTypes(NewParam, OldParam, *this);
3551       }
3552 
3553   if (getLangOpts().CPlusPlus)
3554     return MergeCXXFunctionDecl(New, Old, S);
3555 
3556   // Merge the function types so the we get the composite types for the return
3557   // and argument types. Per C11 6.2.7/4, only update the type if the old decl
3558   // was visible.
3559   QualType Merged = Context.mergeTypes(Old->getType(), New->getType());
3560   if (!Merged.isNull() && MergeTypeWithOld)
3561     New->setType(Merged);
3562 
3563   return false;
3564 }
3565 
3566 void Sema::mergeObjCMethodDecls(ObjCMethodDecl *newMethod,
3567                                 ObjCMethodDecl *oldMethod) {
3568   // Merge the attributes, including deprecated/unavailable
3569   AvailabilityMergeKind MergeKind =
3570     isa<ObjCProtocolDecl>(oldMethod->getDeclContext())
3571       ? AMK_ProtocolImplementation
3572       : isa<ObjCImplDecl>(newMethod->getDeclContext()) ? AMK_Redeclaration
3573                                                        : AMK_Override;
3574 
3575   mergeDeclAttributes(newMethod, oldMethod, MergeKind);
3576 
3577   // Merge attributes from the parameters.
3578   ObjCMethodDecl::param_const_iterator oi = oldMethod->param_begin(),
3579                                        oe = oldMethod->param_end();
3580   for (ObjCMethodDecl::param_iterator
3581          ni = newMethod->param_begin(), ne = newMethod->param_end();
3582        ni != ne && oi != oe; ++ni, ++oi)
3583     mergeParamDeclAttributes(*ni, *oi, *this);
3584 }
3585 
3586 static void diagnoseVarDeclTypeMismatch(Sema &S, VarDecl *New, VarDecl* Old) {
3587   assert(!S.Context.hasSameType(New->getType(), Old->getType()));
3588 
3589   S.Diag(New->getLocation(), New->isThisDeclarationADefinition()
3590          ? diag::err_redefinition_different_type
3591          : diag::err_redeclaration_different_type)
3592     << New->getDeclName() << New->getType() << Old->getType();
3593 
3594   diag::kind PrevDiag;
3595   SourceLocation OldLocation;
3596   std::tie(PrevDiag, OldLocation)
3597     = getNoteDiagForInvalidRedeclaration(Old, New);
3598   S.Diag(OldLocation, PrevDiag);
3599   New->setInvalidDecl();
3600 }
3601 
3602 /// MergeVarDeclTypes - We parsed a variable 'New' which has the same name and
3603 /// scope as a previous declaration 'Old'.  Figure out how to merge their types,
3604 /// emitting diagnostics as appropriate.
3605 ///
3606 /// Declarations using the auto type specifier (C++ [decl.spec.auto]) call back
3607 /// to here in AddInitializerToDecl. We can't check them before the initializer
3608 /// is attached.
3609 void Sema::MergeVarDeclTypes(VarDecl *New, VarDecl *Old,
3610                              bool MergeTypeWithOld) {
3611   if (New->isInvalidDecl() || Old->isInvalidDecl())
3612     return;
3613 
3614   QualType MergedT;
3615   if (getLangOpts().CPlusPlus) {
3616     if (New->getType()->isUndeducedType()) {
3617       // We don't know what the new type is until the initializer is attached.
3618       return;
3619     } else if (Context.hasSameType(New->getType(), Old->getType())) {
3620       // These could still be something that needs exception specs checked.
3621       return MergeVarDeclExceptionSpecs(New, Old);
3622     }
3623     // C++ [basic.link]p10:
3624     //   [...] the types specified by all declarations referring to a given
3625     //   object or function shall be identical, except that declarations for an
3626     //   array object can specify array types that differ by the presence or
3627     //   absence of a major array bound (8.3.4).
3628     else if (Old->getType()->isArrayType() && New->getType()->isArrayType()) {
3629       const ArrayType *OldArray = Context.getAsArrayType(Old->getType());
3630       const ArrayType *NewArray = Context.getAsArrayType(New->getType());
3631 
3632       // We are merging a variable declaration New into Old. If it has an array
3633       // bound, and that bound differs from Old's bound, we should diagnose the
3634       // mismatch.
3635       if (!NewArray->isIncompleteArrayType() && !NewArray->isDependentType()) {
3636         for (VarDecl *PrevVD = Old->getMostRecentDecl(); PrevVD;
3637              PrevVD = PrevVD->getPreviousDecl()) {
3638           const ArrayType *PrevVDTy = Context.getAsArrayType(PrevVD->getType());
3639           if (PrevVDTy->isIncompleteArrayType() || PrevVDTy->isDependentType())
3640             continue;
3641 
3642           if (!Context.hasSameType(NewArray, PrevVDTy))
3643             return diagnoseVarDeclTypeMismatch(*this, New, PrevVD);
3644         }
3645       }
3646 
3647       if (OldArray->isIncompleteArrayType() && NewArray->isArrayType()) {
3648         if (Context.hasSameType(OldArray->getElementType(),
3649                                 NewArray->getElementType()))
3650           MergedT = New->getType();
3651       }
3652       // FIXME: Check visibility. New is hidden but has a complete type. If New
3653       // has no array bound, it should not inherit one from Old, if Old is not
3654       // visible.
3655       else if (OldArray->isArrayType() && NewArray->isIncompleteArrayType()) {
3656         if (Context.hasSameType(OldArray->getElementType(),
3657                                 NewArray->getElementType()))
3658           MergedT = Old->getType();
3659       }
3660     }
3661     else if (New->getType()->isObjCObjectPointerType() &&
3662                Old->getType()->isObjCObjectPointerType()) {
3663       MergedT = Context.mergeObjCGCQualifiers(New->getType(),
3664                                               Old->getType());
3665     }
3666   } else {
3667     // C 6.2.7p2:
3668     //   All declarations that refer to the same object or function shall have
3669     //   compatible type.
3670     MergedT = Context.mergeTypes(New->getType(), Old->getType());
3671   }
3672   if (MergedT.isNull()) {
3673     // It's OK if we couldn't merge types if either type is dependent, for a
3674     // block-scope variable. In other cases (static data members of class
3675     // templates, variable templates, ...), we require the types to be
3676     // equivalent.
3677     // FIXME: The C++ standard doesn't say anything about this.
3678     if ((New->getType()->isDependentType() ||
3679          Old->getType()->isDependentType()) && New->isLocalVarDecl()) {
3680       // If the old type was dependent, we can't merge with it, so the new type
3681       // becomes dependent for now. We'll reproduce the original type when we
3682       // instantiate the TypeSourceInfo for the variable.
3683       if (!New->getType()->isDependentType() && MergeTypeWithOld)
3684         New->setType(Context.DependentTy);
3685       return;
3686     }
3687     return diagnoseVarDeclTypeMismatch(*this, New, Old);
3688   }
3689 
3690   // Don't actually update the type on the new declaration if the old
3691   // declaration was an extern declaration in a different scope.
3692   if (MergeTypeWithOld)
3693     New->setType(MergedT);
3694 }
3695 
3696 static bool mergeTypeWithPrevious(Sema &S, VarDecl *NewVD, VarDecl *OldVD,
3697                                   LookupResult &Previous) {
3698   // C11 6.2.7p4:
3699   //   For an identifier with internal or external linkage declared
3700   //   in a scope in which a prior declaration of that identifier is
3701   //   visible, if the prior declaration specifies internal or
3702   //   external linkage, the type of the identifier at the later
3703   //   declaration becomes the composite type.
3704   //
3705   // If the variable isn't visible, we do not merge with its type.
3706   if (Previous.isShadowed())
3707     return false;
3708 
3709   if (S.getLangOpts().CPlusPlus) {
3710     // C++11 [dcl.array]p3:
3711     //   If there is a preceding declaration of the entity in the same
3712     //   scope in which the bound was specified, an omitted array bound
3713     //   is taken to be the same as in that earlier declaration.
3714     return NewVD->isPreviousDeclInSameBlockScope() ||
3715            (!OldVD->getLexicalDeclContext()->isFunctionOrMethod() &&
3716             !NewVD->getLexicalDeclContext()->isFunctionOrMethod());
3717   } else {
3718     // If the old declaration was function-local, don't merge with its
3719     // type unless we're in the same function.
3720     return !OldVD->getLexicalDeclContext()->isFunctionOrMethod() ||
3721            OldVD->getLexicalDeclContext() == NewVD->getLexicalDeclContext();
3722   }
3723 }
3724 
3725 /// MergeVarDecl - We just parsed a variable 'New' which has the same name
3726 /// and scope as a previous declaration 'Old'.  Figure out how to resolve this
3727 /// situation, merging decls or emitting diagnostics as appropriate.
3728 ///
3729 /// Tentative definition rules (C99 6.9.2p2) are checked by
3730 /// FinalizeDeclaratorGroup. Unfortunately, we can't analyze tentative
3731 /// definitions here, since the initializer hasn't been attached.
3732 ///
3733 void Sema::MergeVarDecl(VarDecl *New, LookupResult &Previous) {
3734   // If the new decl is already invalid, don't do any other checking.
3735   if (New->isInvalidDecl())
3736     return;
3737 
3738   if (!shouldLinkPossiblyHiddenDecl(Previous, New))
3739     return;
3740 
3741   VarTemplateDecl *NewTemplate = New->getDescribedVarTemplate();
3742 
3743   // Verify the old decl was also a variable or variable template.
3744   VarDecl *Old = nullptr;
3745   VarTemplateDecl *OldTemplate = nullptr;
3746   if (Previous.isSingleResult()) {
3747     if (NewTemplate) {
3748       OldTemplate = dyn_cast<VarTemplateDecl>(Previous.getFoundDecl());
3749       Old = OldTemplate ? OldTemplate->getTemplatedDecl() : nullptr;
3750 
3751       if (auto *Shadow =
3752               dyn_cast<UsingShadowDecl>(Previous.getRepresentativeDecl()))
3753         if (checkUsingShadowRedecl<VarTemplateDecl>(*this, Shadow, NewTemplate))
3754           return New->setInvalidDecl();
3755     } else {
3756       Old = dyn_cast<VarDecl>(Previous.getFoundDecl());
3757 
3758       if (auto *Shadow =
3759               dyn_cast<UsingShadowDecl>(Previous.getRepresentativeDecl()))
3760         if (checkUsingShadowRedecl<VarDecl>(*this, Shadow, New))
3761           return New->setInvalidDecl();
3762     }
3763   }
3764   if (!Old) {
3765     Diag(New->getLocation(), diag::err_redefinition_different_kind)
3766         << New->getDeclName();
3767     notePreviousDefinition(Previous.getRepresentativeDecl(),
3768                            New->getLocation());
3769     return New->setInvalidDecl();
3770   }
3771 
3772   // Ensure the template parameters are compatible.
3773   if (NewTemplate &&
3774       !TemplateParameterListsAreEqual(NewTemplate->getTemplateParameters(),
3775                                       OldTemplate->getTemplateParameters(),
3776                                       /*Complain=*/true, TPL_TemplateMatch))
3777     return New->setInvalidDecl();
3778 
3779   // C++ [class.mem]p1:
3780   //   A member shall not be declared twice in the member-specification [...]
3781   //
3782   // Here, we need only consider static data members.
3783   if (Old->isStaticDataMember() && !New->isOutOfLine()) {
3784     Diag(New->getLocation(), diag::err_duplicate_member)
3785       << New->getIdentifier();
3786     Diag(Old->getLocation(), diag::note_previous_declaration);
3787     New->setInvalidDecl();
3788   }
3789 
3790   mergeDeclAttributes(New, Old);
3791   // Warn if an already-declared variable is made a weak_import in a subsequent
3792   // declaration
3793   if (New->hasAttr<WeakImportAttr>() &&
3794       Old->getStorageClass() == SC_None &&
3795       !Old->hasAttr<WeakImportAttr>()) {
3796     Diag(New->getLocation(), diag::warn_weak_import) << New->getDeclName();
3797     notePreviousDefinition(Old, New->getLocation());
3798     // Remove weak_import attribute on new declaration.
3799     New->dropAttr<WeakImportAttr>();
3800   }
3801 
3802   if (New->hasAttr<InternalLinkageAttr>() &&
3803       !Old->hasAttr<InternalLinkageAttr>()) {
3804     Diag(New->getLocation(), diag::err_internal_linkage_redeclaration)
3805         << New->getDeclName();
3806     notePreviousDefinition(Old, New->getLocation());
3807     New->dropAttr<InternalLinkageAttr>();
3808   }
3809 
3810   // Merge the types.
3811   VarDecl *MostRecent = Old->getMostRecentDecl();
3812   if (MostRecent != Old) {
3813     MergeVarDeclTypes(New, MostRecent,
3814                       mergeTypeWithPrevious(*this, New, MostRecent, Previous));
3815     if (New->isInvalidDecl())
3816       return;
3817   }
3818 
3819   MergeVarDeclTypes(New, Old, mergeTypeWithPrevious(*this, New, Old, Previous));
3820   if (New->isInvalidDecl())
3821     return;
3822 
3823   diag::kind PrevDiag;
3824   SourceLocation OldLocation;
3825   std::tie(PrevDiag, OldLocation) =
3826       getNoteDiagForInvalidRedeclaration(Old, New);
3827 
3828   // [dcl.stc]p8: Check if we have a non-static decl followed by a static.
3829   if (New->getStorageClass() == SC_Static &&
3830       !New->isStaticDataMember() &&
3831       Old->hasExternalFormalLinkage()) {
3832     if (getLangOpts().MicrosoftExt) {
3833       Diag(New->getLocation(), diag::ext_static_non_static)
3834           << New->getDeclName();
3835       Diag(OldLocation, PrevDiag);
3836     } else {
3837       Diag(New->getLocation(), diag::err_static_non_static)
3838           << New->getDeclName();
3839       Diag(OldLocation, PrevDiag);
3840       return New->setInvalidDecl();
3841     }
3842   }
3843   // C99 6.2.2p4:
3844   //   For an identifier declared with the storage-class specifier
3845   //   extern in a scope in which a prior declaration of that
3846   //   identifier is visible,23) if the prior declaration specifies
3847   //   internal or external linkage, the linkage of the identifier at
3848   //   the later declaration is the same as the linkage specified at
3849   //   the prior declaration. If no prior declaration is visible, or
3850   //   if the prior declaration specifies no linkage, then the
3851   //   identifier has external linkage.
3852   if (New->hasExternalStorage() && Old->hasLinkage())
3853     /* Okay */;
3854   else if (New->getCanonicalDecl()->getStorageClass() != SC_Static &&
3855            !New->isStaticDataMember() &&
3856            Old->getCanonicalDecl()->getStorageClass() == SC_Static) {
3857     Diag(New->getLocation(), diag::err_non_static_static) << New->getDeclName();
3858     Diag(OldLocation, PrevDiag);
3859     return New->setInvalidDecl();
3860   }
3861 
3862   // Check if extern is followed by non-extern and vice-versa.
3863   if (New->hasExternalStorage() &&
3864       !Old->hasLinkage() && Old->isLocalVarDeclOrParm()) {
3865     Diag(New->getLocation(), diag::err_extern_non_extern) << New->getDeclName();
3866     Diag(OldLocation, PrevDiag);
3867     return New->setInvalidDecl();
3868   }
3869   if (Old->hasLinkage() && New->isLocalVarDeclOrParm() &&
3870       !New->hasExternalStorage()) {
3871     Diag(New->getLocation(), diag::err_non_extern_extern) << New->getDeclName();
3872     Diag(OldLocation, PrevDiag);
3873     return New->setInvalidDecl();
3874   }
3875 
3876   if (CheckRedeclarationModuleOwnership(New, Old))
3877     return;
3878 
3879   // Variables with external linkage are analyzed in FinalizeDeclaratorGroup.
3880 
3881   // FIXME: The test for external storage here seems wrong? We still
3882   // need to check for mismatches.
3883   if (!New->hasExternalStorage() && !New->isFileVarDecl() &&
3884       // Don't complain about out-of-line definitions of static members.
3885       !(Old->getLexicalDeclContext()->isRecord() &&
3886         !New->getLexicalDeclContext()->isRecord())) {
3887     Diag(New->getLocation(), diag::err_redefinition) << New->getDeclName();
3888     Diag(OldLocation, PrevDiag);
3889     return New->setInvalidDecl();
3890   }
3891 
3892   if (New->isInline() && !Old->getMostRecentDecl()->isInline()) {
3893     if (VarDecl *Def = Old->getDefinition()) {
3894       // C++1z [dcl.fcn.spec]p4:
3895       //   If the definition of a variable appears in a translation unit before
3896       //   its first declaration as inline, the program is ill-formed.
3897       Diag(New->getLocation(), diag::err_inline_decl_follows_def) << New;
3898       Diag(Def->getLocation(), diag::note_previous_definition);
3899     }
3900   }
3901 
3902   // If this redeclaration makes the variable inline, we may need to add it to
3903   // UndefinedButUsed.
3904   if (!Old->isInline() && New->isInline() && Old->isUsed(false) &&
3905       !Old->getDefinition() && !New->isThisDeclarationADefinition())
3906     UndefinedButUsed.insert(std::make_pair(Old->getCanonicalDecl(),
3907                                            SourceLocation()));
3908 
3909   if (New->getTLSKind() != Old->getTLSKind()) {
3910     if (!Old->getTLSKind()) {
3911       Diag(New->getLocation(), diag::err_thread_non_thread) << New->getDeclName();
3912       Diag(OldLocation, PrevDiag);
3913     } else if (!New->getTLSKind()) {
3914       Diag(New->getLocation(), diag::err_non_thread_thread) << New->getDeclName();
3915       Diag(OldLocation, PrevDiag);
3916     } else {
3917       // Do not allow redeclaration to change the variable between requiring
3918       // static and dynamic initialization.
3919       // FIXME: GCC allows this, but uses the TLS keyword on the first
3920       // declaration to determine the kind. Do we need to be compatible here?
3921       Diag(New->getLocation(), diag::err_thread_thread_different_kind)
3922         << New->getDeclName() << (New->getTLSKind() == VarDecl::TLS_Dynamic);
3923       Diag(OldLocation, PrevDiag);
3924     }
3925   }
3926 
3927   // C++ doesn't have tentative definitions, so go right ahead and check here.
3928   if (getLangOpts().CPlusPlus &&
3929       New->isThisDeclarationADefinition() == VarDecl::Definition) {
3930     if (Old->isStaticDataMember() && Old->getCanonicalDecl()->isInline() &&
3931         Old->getCanonicalDecl()->isConstexpr()) {
3932       // This definition won't be a definition any more once it's been merged.
3933       Diag(New->getLocation(),
3934            diag::warn_deprecated_redundant_constexpr_static_def);
3935     } else if (VarDecl *Def = Old->getDefinition()) {
3936       if (checkVarDeclRedefinition(Def, New))
3937         return;
3938     }
3939   }
3940 
3941   if (haveIncompatibleLanguageLinkages(Old, New)) {
3942     Diag(New->getLocation(), diag::err_different_language_linkage) << New;
3943     Diag(OldLocation, PrevDiag);
3944     New->setInvalidDecl();
3945     return;
3946   }
3947 
3948   // Merge "used" flag.
3949   if (Old->getMostRecentDecl()->isUsed(false))
3950     New->setIsUsed();
3951 
3952   // Keep a chain of previous declarations.
3953   New->setPreviousDecl(Old);
3954   if (NewTemplate)
3955     NewTemplate->setPreviousDecl(OldTemplate);
3956 
3957   // Inherit access appropriately.
3958   New->setAccess(Old->getAccess());
3959   if (NewTemplate)
3960     NewTemplate->setAccess(New->getAccess());
3961 
3962   if (Old->isInline())
3963     New->setImplicitlyInline();
3964 }
3965 
3966 void Sema::notePreviousDefinition(const NamedDecl *Old, SourceLocation New) {
3967   SourceManager &SrcMgr = getSourceManager();
3968   auto FNewDecLoc = SrcMgr.getDecomposedLoc(New);
3969   auto FOldDecLoc = SrcMgr.getDecomposedLoc(Old->getLocation());
3970   auto *FNew = SrcMgr.getFileEntryForID(FNewDecLoc.first);
3971   auto *FOld = SrcMgr.getFileEntryForID(FOldDecLoc.first);
3972   auto &HSI = PP.getHeaderSearchInfo();
3973   StringRef HdrFilename =
3974       SrcMgr.getFilename(SrcMgr.getSpellingLoc(Old->getLocation()));
3975 
3976   auto noteFromModuleOrInclude = [&](Module *Mod,
3977                                      SourceLocation IncLoc) -> bool {
3978     // Redefinition errors with modules are common with non modular mapped
3979     // headers, example: a non-modular header H in module A that also gets
3980     // included directly in a TU. Pointing twice to the same header/definition
3981     // is confusing, try to get better diagnostics when modules is on.
3982     if (IncLoc.isValid()) {
3983       if (Mod) {
3984         Diag(IncLoc, diag::note_redefinition_modules_same_file)
3985             << HdrFilename.str() << Mod->getFullModuleName();
3986         if (!Mod->DefinitionLoc.isInvalid())
3987           Diag(Mod->DefinitionLoc, diag::note_defined_here)
3988               << Mod->getFullModuleName();
3989       } else {
3990         Diag(IncLoc, diag::note_redefinition_include_same_file)
3991             << HdrFilename.str();
3992       }
3993       return true;
3994     }
3995 
3996     return false;
3997   };
3998 
3999   // Is it the same file and same offset? Provide more information on why
4000   // this leads to a redefinition error.
4001   bool EmittedDiag = false;
4002   if (FNew == FOld && FNewDecLoc.second == FOldDecLoc.second) {
4003     SourceLocation OldIncLoc = SrcMgr.getIncludeLoc(FOldDecLoc.first);
4004     SourceLocation NewIncLoc = SrcMgr.getIncludeLoc(FNewDecLoc.first);
4005     EmittedDiag = noteFromModuleOrInclude(Old->getOwningModule(), OldIncLoc);
4006     EmittedDiag |= noteFromModuleOrInclude(getCurrentModule(), NewIncLoc);
4007 
4008     // If the header has no guards, emit a note suggesting one.
4009     if (FOld && !HSI.isFileMultipleIncludeGuarded(FOld))
4010       Diag(Old->getLocation(), diag::note_use_ifdef_guards);
4011 
4012     if (EmittedDiag)
4013       return;
4014   }
4015 
4016   // Redefinition coming from different files or couldn't do better above.
4017   Diag(Old->getLocation(), diag::note_previous_definition);
4018 }
4019 
4020 /// We've just determined that \p Old and \p New both appear to be definitions
4021 /// of the same variable. Either diagnose or fix the problem.
4022 bool Sema::checkVarDeclRedefinition(VarDecl *Old, VarDecl *New) {
4023   if (!hasVisibleDefinition(Old) &&
4024       (New->getFormalLinkage() == InternalLinkage ||
4025        New->isInline() ||
4026        New->getDescribedVarTemplate() ||
4027        New->getNumTemplateParameterLists() ||
4028        New->getDeclContext()->isDependentContext())) {
4029     // The previous definition is hidden, and multiple definitions are
4030     // permitted (in separate TUs). Demote this to a declaration.
4031     New->demoteThisDefinitionToDeclaration();
4032 
4033     // Make the canonical definition visible.
4034     if (auto *OldTD = Old->getDescribedVarTemplate())
4035       makeMergedDefinitionVisible(OldTD);
4036     makeMergedDefinitionVisible(Old);
4037     return false;
4038   } else {
4039     Diag(New->getLocation(), diag::err_redefinition) << New;
4040     notePreviousDefinition(Old, New->getLocation());
4041     New->setInvalidDecl();
4042     return true;
4043   }
4044 }
4045 
4046 /// ParsedFreeStandingDeclSpec - This method is invoked when a declspec with
4047 /// no declarator (e.g. "struct foo;") is parsed.
4048 Decl *
4049 Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, DeclSpec &DS,
4050                                  RecordDecl *&AnonRecord) {
4051   return ParsedFreeStandingDeclSpec(S, AS, DS, MultiTemplateParamsArg(), false,
4052                                     AnonRecord);
4053 }
4054 
4055 // The MS ABI changed between VS2013 and VS2015 with regard to numbers used to
4056 // disambiguate entities defined in different scopes.
4057 // While the VS2015 ABI fixes potential miscompiles, it is also breaks
4058 // compatibility.
4059 // We will pick our mangling number depending on which version of MSVC is being
4060 // targeted.
4061 static unsigned getMSManglingNumber(const LangOptions &LO, Scope *S) {
4062   return LO.isCompatibleWithMSVC(LangOptions::MSVC2015)
4063              ? S->getMSCurManglingNumber()
4064              : S->getMSLastManglingNumber();
4065 }
4066 
4067 void Sema::handleTagNumbering(const TagDecl *Tag, Scope *TagScope) {
4068   if (!Context.getLangOpts().CPlusPlus)
4069     return;
4070 
4071   if (isa<CXXRecordDecl>(Tag->getParent())) {
4072     // If this tag is the direct child of a class, number it if
4073     // it is anonymous.
4074     if (!Tag->getName().empty() || Tag->getTypedefNameForAnonDecl())
4075       return;
4076     MangleNumberingContext &MCtx =
4077         Context.getManglingNumberContext(Tag->getParent());
4078     Context.setManglingNumber(
4079         Tag, MCtx.getManglingNumber(
4080                  Tag, getMSManglingNumber(getLangOpts(), TagScope)));
4081     return;
4082   }
4083 
4084   // If this tag isn't a direct child of a class, number it if it is local.
4085   Decl *ManglingContextDecl;
4086   if (MangleNumberingContext *MCtx = getCurrentMangleNumberContext(
4087           Tag->getDeclContext(), ManglingContextDecl)) {
4088     Context.setManglingNumber(
4089         Tag, MCtx->getManglingNumber(
4090                  Tag, getMSManglingNumber(getLangOpts(), TagScope)));
4091   }
4092 }
4093 
4094 void Sema::setTagNameForLinkagePurposes(TagDecl *TagFromDeclSpec,
4095                                         TypedefNameDecl *NewTD) {
4096   if (TagFromDeclSpec->isInvalidDecl())
4097     return;
4098 
4099   // Do nothing if the tag already has a name for linkage purposes.
4100   if (TagFromDeclSpec->hasNameForLinkage())
4101     return;
4102 
4103   // A well-formed anonymous tag must always be a TUK_Definition.
4104   assert(TagFromDeclSpec->isThisDeclarationADefinition());
4105 
4106   // The type must match the tag exactly;  no qualifiers allowed.
4107   if (!Context.hasSameType(NewTD->getUnderlyingType(),
4108                            Context.getTagDeclType(TagFromDeclSpec))) {
4109     if (getLangOpts().CPlusPlus)
4110       Context.addTypedefNameForUnnamedTagDecl(TagFromDeclSpec, NewTD);
4111     return;
4112   }
4113 
4114   // If we've already computed linkage for the anonymous tag, then
4115   // adding a typedef name for the anonymous decl can change that
4116   // linkage, which might be a serious problem.  Diagnose this as
4117   // unsupported and ignore the typedef name.  TODO: we should
4118   // pursue this as a language defect and establish a formal rule
4119   // for how to handle it.
4120   if (TagFromDeclSpec->hasLinkageBeenComputed()) {
4121     Diag(NewTD->getLocation(), diag::err_typedef_changes_linkage);
4122 
4123     SourceLocation tagLoc = TagFromDeclSpec->getInnerLocStart();
4124     tagLoc = getLocForEndOfToken(tagLoc);
4125 
4126     llvm::SmallString<40> textToInsert;
4127     textToInsert += ' ';
4128     textToInsert += NewTD->getIdentifier()->getName();
4129     Diag(tagLoc, diag::note_typedef_changes_linkage)
4130         << FixItHint::CreateInsertion(tagLoc, textToInsert);
4131     return;
4132   }
4133 
4134   // Otherwise, set this is the anon-decl typedef for the tag.
4135   TagFromDeclSpec->setTypedefNameForAnonDecl(NewTD);
4136 }
4137 
4138 static unsigned GetDiagnosticTypeSpecifierID(DeclSpec::TST T) {
4139   switch (T) {
4140   case DeclSpec::TST_class:
4141     return 0;
4142   case DeclSpec::TST_struct:
4143     return 1;
4144   case DeclSpec::TST_interface:
4145     return 2;
4146   case DeclSpec::TST_union:
4147     return 3;
4148   case DeclSpec::TST_enum:
4149     return 4;
4150   default:
4151     llvm_unreachable("unexpected type specifier");
4152   }
4153 }
4154 
4155 /// ParsedFreeStandingDeclSpec - This method is invoked when a declspec with
4156 /// no declarator (e.g. "struct foo;") is parsed. It also accepts template
4157 /// parameters to cope with template friend declarations.
4158 Decl *
4159 Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, DeclSpec &DS,
4160                                  MultiTemplateParamsArg TemplateParams,
4161                                  bool IsExplicitInstantiation,
4162                                  RecordDecl *&AnonRecord) {
4163   Decl *TagD = nullptr;
4164   TagDecl *Tag = nullptr;
4165   if (DS.getTypeSpecType() == DeclSpec::TST_class ||
4166       DS.getTypeSpecType() == DeclSpec::TST_struct ||
4167       DS.getTypeSpecType() == DeclSpec::TST_interface ||
4168       DS.getTypeSpecType() == DeclSpec::TST_union ||
4169       DS.getTypeSpecType() == DeclSpec::TST_enum) {
4170     TagD = DS.getRepAsDecl();
4171 
4172     if (!TagD) // We probably had an error
4173       return nullptr;
4174 
4175     // Note that the above type specs guarantee that the
4176     // type rep is a Decl, whereas in many of the others
4177     // it's a Type.
4178     if (isa<TagDecl>(TagD))
4179       Tag = cast<TagDecl>(TagD);
4180     else if (ClassTemplateDecl *CTD = dyn_cast<ClassTemplateDecl>(TagD))
4181       Tag = CTD->getTemplatedDecl();
4182   }
4183 
4184   if (Tag) {
4185     handleTagNumbering(Tag, S);
4186     Tag->setFreeStanding();
4187     if (Tag->isInvalidDecl())
4188       return Tag;
4189   }
4190 
4191   if (unsigned TypeQuals = DS.getTypeQualifiers()) {
4192     // Enforce C99 6.7.3p2: "Types other than pointer types derived from object
4193     // or incomplete types shall not be restrict-qualified."
4194     if (TypeQuals & DeclSpec::TQ_restrict)
4195       Diag(DS.getRestrictSpecLoc(),
4196            diag::err_typecheck_invalid_restrict_not_pointer_noarg)
4197            << DS.getSourceRange();
4198   }
4199 
4200   if (DS.isInlineSpecified())
4201     Diag(DS.getInlineSpecLoc(), diag::err_inline_non_function)
4202         << getLangOpts().CPlusPlus1z;
4203 
4204   if (DS.isConstexprSpecified()) {
4205     // C++0x [dcl.constexpr]p1: constexpr can only be applied to declarations
4206     // and definitions of functions and variables.
4207     if (Tag)
4208       Diag(DS.getConstexprSpecLoc(), diag::err_constexpr_tag)
4209           << GetDiagnosticTypeSpecifierID(DS.getTypeSpecType());
4210     else
4211       Diag(DS.getConstexprSpecLoc(), diag::err_constexpr_no_declarators);
4212     // Don't emit warnings after this error.
4213     return TagD;
4214   }
4215 
4216   if (DS.isConceptSpecified()) {
4217     // C++ Concepts TS [dcl.spec.concept]p1: A concept definition refers to
4218     // either a function concept and its definition or a variable concept and
4219     // its initializer.
4220     Diag(DS.getConceptSpecLoc(), diag::err_concept_wrong_decl_kind);
4221     return TagD;
4222   }
4223 
4224   DiagnoseFunctionSpecifiers(DS);
4225 
4226   if (DS.isFriendSpecified()) {
4227     // If we're dealing with a decl but not a TagDecl, assume that
4228     // whatever routines created it handled the friendship aspect.
4229     if (TagD && !Tag)
4230       return nullptr;
4231     return ActOnFriendTypeDecl(S, DS, TemplateParams);
4232   }
4233 
4234   const CXXScopeSpec &SS = DS.getTypeSpecScope();
4235   bool IsExplicitSpecialization =
4236     !TemplateParams.empty() && TemplateParams.back()->size() == 0;
4237   if (Tag && SS.isNotEmpty() && !Tag->isCompleteDefinition() &&
4238       !IsExplicitInstantiation && !IsExplicitSpecialization &&
4239       !isa<ClassTemplatePartialSpecializationDecl>(Tag)) {
4240     // Per C++ [dcl.type.elab]p1, a class declaration cannot have a
4241     // nested-name-specifier unless it is an explicit instantiation
4242     // or an explicit specialization.
4243     //
4244     // FIXME: We allow class template partial specializations here too, per the
4245     // obvious intent of DR1819.
4246     //
4247     // Per C++ [dcl.enum]p1, an opaque-enum-declaration can't either.
4248     Diag(SS.getBeginLoc(), diag::err_standalone_class_nested_name_specifier)
4249         << GetDiagnosticTypeSpecifierID(DS.getTypeSpecType()) << SS.getRange();
4250     return nullptr;
4251   }
4252 
4253   // Track whether this decl-specifier declares anything.
4254   bool DeclaresAnything = true;
4255 
4256   // Handle anonymous struct definitions.
4257   if (RecordDecl *Record = dyn_cast_or_null<RecordDecl>(Tag)) {
4258     if (!Record->getDeclName() && Record->isCompleteDefinition() &&
4259         DS.getStorageClassSpec() != DeclSpec::SCS_typedef) {
4260       if (getLangOpts().CPlusPlus ||
4261           Record->getDeclContext()->isRecord()) {
4262         // If CurContext is a DeclContext that can contain statements,
4263         // RecursiveASTVisitor won't visit the decls that
4264         // BuildAnonymousStructOrUnion() will put into CurContext.
4265         // Also store them here so that they can be part of the
4266         // DeclStmt that gets created in this case.
4267         // FIXME: Also return the IndirectFieldDecls created by
4268         // BuildAnonymousStructOr union, for the same reason?
4269         if (CurContext->isFunctionOrMethod())
4270           AnonRecord = Record;
4271         return BuildAnonymousStructOrUnion(S, DS, AS, Record,
4272                                            Context.getPrintingPolicy());
4273       }
4274 
4275       DeclaresAnything = false;
4276     }
4277   }
4278 
4279   // C11 6.7.2.1p2:
4280   //   A struct-declaration that does not declare an anonymous structure or
4281   //   anonymous union shall contain a struct-declarator-list.
4282   //
4283   // This rule also existed in C89 and C99; the grammar for struct-declaration
4284   // did not permit a struct-declaration without a struct-declarator-list.
4285   if (!getLangOpts().CPlusPlus && CurContext->isRecord() &&
4286       DS.getStorageClassSpec() == DeclSpec::SCS_unspecified) {
4287     // Check for Microsoft C extension: anonymous struct/union member.
4288     // Handle 2 kinds of anonymous struct/union:
4289     //   struct STRUCT;
4290     //   union UNION;
4291     // and
4292     //   STRUCT_TYPE;  <- where STRUCT_TYPE is a typedef struct.
4293     //   UNION_TYPE;   <- where UNION_TYPE is a typedef union.
4294     if ((Tag && Tag->getDeclName()) ||
4295         DS.getTypeSpecType() == DeclSpec::TST_typename) {
4296       RecordDecl *Record = nullptr;
4297       if (Tag)
4298         Record = dyn_cast<RecordDecl>(Tag);
4299       else if (const RecordType *RT =
4300                    DS.getRepAsType().get()->getAsStructureType())
4301         Record = RT->getDecl();
4302       else if (const RecordType *UT = DS.getRepAsType().get()->getAsUnionType())
4303         Record = UT->getDecl();
4304 
4305       if (Record && getLangOpts().MicrosoftExt) {
4306         Diag(DS.getLocStart(), diag::ext_ms_anonymous_record)
4307           << Record->isUnion() << DS.getSourceRange();
4308         return BuildMicrosoftCAnonymousStruct(S, DS, Record);
4309       }
4310 
4311       DeclaresAnything = false;
4312     }
4313   }
4314 
4315   // Skip all the checks below if we have a type error.
4316   if (DS.getTypeSpecType() == DeclSpec::TST_error ||
4317       (TagD && TagD->isInvalidDecl()))
4318     return TagD;
4319 
4320   if (getLangOpts().CPlusPlus &&
4321       DS.getStorageClassSpec() != DeclSpec::SCS_typedef)
4322     if (EnumDecl *Enum = dyn_cast_or_null<EnumDecl>(Tag))
4323       if (Enum->enumerator_begin() == Enum->enumerator_end() &&
4324           !Enum->getIdentifier() && !Enum->isInvalidDecl())
4325         DeclaresAnything = false;
4326 
4327   if (!DS.isMissingDeclaratorOk()) {
4328     // Customize diagnostic for a typedef missing a name.
4329     if (DS.getStorageClassSpec() == DeclSpec::SCS_typedef)
4330       Diag(DS.getLocStart(), diag::ext_typedef_without_a_name)
4331         << DS.getSourceRange();
4332     else
4333       DeclaresAnything = false;
4334   }
4335 
4336   if (DS.isModulePrivateSpecified() &&
4337       Tag && Tag->getDeclContext()->isFunctionOrMethod())
4338     Diag(DS.getModulePrivateSpecLoc(), diag::err_module_private_local_class)
4339       << Tag->getTagKind()
4340       << FixItHint::CreateRemoval(DS.getModulePrivateSpecLoc());
4341 
4342   ActOnDocumentableDecl(TagD);
4343 
4344   // C 6.7/2:
4345   //   A declaration [...] shall declare at least a declarator [...], a tag,
4346   //   or the members of an enumeration.
4347   // C++ [dcl.dcl]p3:
4348   //   [If there are no declarators], and except for the declaration of an
4349   //   unnamed bit-field, the decl-specifier-seq shall introduce one or more
4350   //   names into the program, or shall redeclare a name introduced by a
4351   //   previous declaration.
4352   if (!DeclaresAnything) {
4353     // In C, we allow this as a (popular) extension / bug. Don't bother
4354     // producing further diagnostics for redundant qualifiers after this.
4355     Diag(DS.getLocStart(), diag::ext_no_declarators) << DS.getSourceRange();
4356     return TagD;
4357   }
4358 
4359   // C++ [dcl.stc]p1:
4360   //   If a storage-class-specifier appears in a decl-specifier-seq, [...] the
4361   //   init-declarator-list of the declaration shall not be empty.
4362   // C++ [dcl.fct.spec]p1:
4363   //   If a cv-qualifier appears in a decl-specifier-seq, the
4364   //   init-declarator-list of the declaration shall not be empty.
4365   //
4366   // Spurious qualifiers here appear to be valid in C.
4367   unsigned DiagID = diag::warn_standalone_specifier;
4368   if (getLangOpts().CPlusPlus)
4369     DiagID = diag::ext_standalone_specifier;
4370 
4371   // Note that a linkage-specification sets a storage class, but
4372   // 'extern "C" struct foo;' is actually valid and not theoretically
4373   // useless.
4374   if (DeclSpec::SCS SCS = DS.getStorageClassSpec()) {
4375     if (SCS == DeclSpec::SCS_mutable)
4376       // Since mutable is not a viable storage class specifier in C, there is
4377       // no reason to treat it as an extension. Instead, diagnose as an error.
4378       Diag(DS.getStorageClassSpecLoc(), diag::err_mutable_nonmember);
4379     else if (!DS.isExternInLinkageSpec() && SCS != DeclSpec::SCS_typedef)
4380       Diag(DS.getStorageClassSpecLoc(), DiagID)
4381         << DeclSpec::getSpecifierName(SCS);
4382   }
4383 
4384   if (DeclSpec::TSCS TSCS = DS.getThreadStorageClassSpec())
4385     Diag(DS.getThreadStorageClassSpecLoc(), DiagID)
4386       << DeclSpec::getSpecifierName(TSCS);
4387   if (DS.getTypeQualifiers()) {
4388     if (DS.getTypeQualifiers() & DeclSpec::TQ_const)
4389       Diag(DS.getConstSpecLoc(), DiagID) << "const";
4390     if (DS.getTypeQualifiers() & DeclSpec::TQ_volatile)
4391       Diag(DS.getConstSpecLoc(), DiagID) << "volatile";
4392     // Restrict is covered above.
4393     if (DS.getTypeQualifiers() & DeclSpec::TQ_atomic)
4394       Diag(DS.getAtomicSpecLoc(), DiagID) << "_Atomic";
4395     if (DS.getTypeQualifiers() & DeclSpec::TQ_unaligned)
4396       Diag(DS.getUnalignedSpecLoc(), DiagID) << "__unaligned";
4397   }
4398 
4399   // Warn about ignored type attributes, for example:
4400   // __attribute__((aligned)) struct A;
4401   // Attributes should be placed after tag to apply to type declaration.
4402   if (!DS.getAttributes().empty()) {
4403     DeclSpec::TST TypeSpecType = DS.getTypeSpecType();
4404     if (TypeSpecType == DeclSpec::TST_class ||
4405         TypeSpecType == DeclSpec::TST_struct ||
4406         TypeSpecType == DeclSpec::TST_interface ||
4407         TypeSpecType == DeclSpec::TST_union ||
4408         TypeSpecType == DeclSpec::TST_enum) {
4409       for (AttributeList* attrs = DS.getAttributes().getList(); attrs;
4410            attrs = attrs->getNext())
4411         Diag(attrs->getLoc(), diag::warn_declspec_attribute_ignored)
4412             << attrs->getName() << GetDiagnosticTypeSpecifierID(TypeSpecType);
4413     }
4414   }
4415 
4416   return TagD;
4417 }
4418 
4419 /// We are trying to inject an anonymous member into the given scope;
4420 /// check if there's an existing declaration that can't be overloaded.
4421 ///
4422 /// \return true if this is a forbidden redeclaration
4423 static bool CheckAnonMemberRedeclaration(Sema &SemaRef,
4424                                          Scope *S,
4425                                          DeclContext *Owner,
4426                                          DeclarationName Name,
4427                                          SourceLocation NameLoc,
4428                                          bool IsUnion) {
4429   LookupResult R(SemaRef, Name, NameLoc, Sema::LookupMemberName,
4430                  Sema::ForVisibleRedeclaration);
4431   if (!SemaRef.LookupName(R, S)) return false;
4432 
4433   // Pick a representative declaration.
4434   NamedDecl *PrevDecl = R.getRepresentativeDecl()->getUnderlyingDecl();
4435   assert(PrevDecl && "Expected a non-null Decl");
4436 
4437   if (!SemaRef.isDeclInScope(PrevDecl, Owner, S))
4438     return false;
4439 
4440   SemaRef.Diag(NameLoc, diag::err_anonymous_record_member_redecl)
4441     << IsUnion << Name;
4442   SemaRef.Diag(PrevDecl->getLocation(), diag::note_previous_declaration);
4443 
4444   return true;
4445 }
4446 
4447 /// InjectAnonymousStructOrUnionMembers - Inject the members of the
4448 /// anonymous struct or union AnonRecord into the owning context Owner
4449 /// and scope S. This routine will be invoked just after we realize
4450 /// that an unnamed union or struct is actually an anonymous union or
4451 /// struct, e.g.,
4452 ///
4453 /// @code
4454 /// union {
4455 ///   int i;
4456 ///   float f;
4457 /// }; // InjectAnonymousStructOrUnionMembers called here to inject i and
4458 ///    // f into the surrounding scope.x
4459 /// @endcode
4460 ///
4461 /// This routine is recursive, injecting the names of nested anonymous
4462 /// structs/unions into the owning context and scope as well.
4463 static bool
4464 InjectAnonymousStructOrUnionMembers(Sema &SemaRef, Scope *S, DeclContext *Owner,
4465                                     RecordDecl *AnonRecord, AccessSpecifier AS,
4466                                     SmallVectorImpl<NamedDecl *> &Chaining) {
4467   bool Invalid = false;
4468 
4469   // Look every FieldDecl and IndirectFieldDecl with a name.
4470   for (auto *D : AnonRecord->decls()) {
4471     if ((isa<FieldDecl>(D) || isa<IndirectFieldDecl>(D)) &&
4472         cast<NamedDecl>(D)->getDeclName()) {
4473       ValueDecl *VD = cast<ValueDecl>(D);
4474       if (CheckAnonMemberRedeclaration(SemaRef, S, Owner, VD->getDeclName(),
4475                                        VD->getLocation(),
4476                                        AnonRecord->isUnion())) {
4477         // C++ [class.union]p2:
4478         //   The names of the members of an anonymous union shall be
4479         //   distinct from the names of any other entity in the
4480         //   scope in which the anonymous union is declared.
4481         Invalid = true;
4482       } else {
4483         // C++ [class.union]p2:
4484         //   For the purpose of name lookup, after the anonymous union
4485         //   definition, the members of the anonymous union are
4486         //   considered to have been defined in the scope in which the
4487         //   anonymous union is declared.
4488         unsigned OldChainingSize = Chaining.size();
4489         if (IndirectFieldDecl *IF = dyn_cast<IndirectFieldDecl>(VD))
4490           Chaining.append(IF->chain_begin(), IF->chain_end());
4491         else
4492           Chaining.push_back(VD);
4493 
4494         assert(Chaining.size() >= 2);
4495         NamedDecl **NamedChain =
4496           new (SemaRef.Context)NamedDecl*[Chaining.size()];
4497         for (unsigned i = 0; i < Chaining.size(); i++)
4498           NamedChain[i] = Chaining[i];
4499 
4500         IndirectFieldDecl *IndirectField = IndirectFieldDecl::Create(
4501             SemaRef.Context, Owner, VD->getLocation(), VD->getIdentifier(),
4502             VD->getType(), {NamedChain, Chaining.size()});
4503 
4504         for (const auto *Attr : VD->attrs())
4505           IndirectField->addAttr(Attr->clone(SemaRef.Context));
4506 
4507         IndirectField->setAccess(AS);
4508         IndirectField->setImplicit();
4509         SemaRef.PushOnScopeChains(IndirectField, S);
4510 
4511         // That includes picking up the appropriate access specifier.
4512         if (AS != AS_none) IndirectField->setAccess(AS);
4513 
4514         Chaining.resize(OldChainingSize);
4515       }
4516     }
4517   }
4518 
4519   return Invalid;
4520 }
4521 
4522 /// StorageClassSpecToVarDeclStorageClass - Maps a DeclSpec::SCS to
4523 /// a VarDecl::StorageClass. Any error reporting is up to the caller:
4524 /// illegal input values are mapped to SC_None.
4525 static StorageClass
4526 StorageClassSpecToVarDeclStorageClass(const DeclSpec &DS) {
4527   DeclSpec::SCS StorageClassSpec = DS.getStorageClassSpec();
4528   assert(StorageClassSpec != DeclSpec::SCS_typedef &&
4529          "Parser allowed 'typedef' as storage class VarDecl.");
4530   switch (StorageClassSpec) {
4531   case DeclSpec::SCS_unspecified:    return SC_None;
4532   case DeclSpec::SCS_extern:
4533     if (DS.isExternInLinkageSpec())
4534       return SC_None;
4535     return SC_Extern;
4536   case DeclSpec::SCS_static:         return SC_Static;
4537   case DeclSpec::SCS_auto:           return SC_Auto;
4538   case DeclSpec::SCS_register:       return SC_Register;
4539   case DeclSpec::SCS_private_extern: return SC_PrivateExtern;
4540     // Illegal SCSs map to None: error reporting is up to the caller.
4541   case DeclSpec::SCS_mutable:        // Fall through.
4542   case DeclSpec::SCS_typedef:        return SC_None;
4543   }
4544   llvm_unreachable("unknown storage class specifier");
4545 }
4546 
4547 static SourceLocation findDefaultInitializer(const CXXRecordDecl *Record) {
4548   assert(Record->hasInClassInitializer());
4549 
4550   for (const auto *I : Record->decls()) {
4551     const auto *FD = dyn_cast<FieldDecl>(I);
4552     if (const auto *IFD = dyn_cast<IndirectFieldDecl>(I))
4553       FD = IFD->getAnonField();
4554     if (FD && FD->hasInClassInitializer())
4555       return FD->getLocation();
4556   }
4557 
4558   llvm_unreachable("couldn't find in-class initializer");
4559 }
4560 
4561 static void checkDuplicateDefaultInit(Sema &S, CXXRecordDecl *Parent,
4562                                       SourceLocation DefaultInitLoc) {
4563   if (!Parent->isUnion() || !Parent->hasInClassInitializer())
4564     return;
4565 
4566   S.Diag(DefaultInitLoc, diag::err_multiple_mem_union_initialization);
4567   S.Diag(findDefaultInitializer(Parent), diag::note_previous_initializer) << 0;
4568 }
4569 
4570 static void checkDuplicateDefaultInit(Sema &S, CXXRecordDecl *Parent,
4571                                       CXXRecordDecl *AnonUnion) {
4572   if (!Parent->isUnion() || !Parent->hasInClassInitializer())
4573     return;
4574 
4575   checkDuplicateDefaultInit(S, Parent, findDefaultInitializer(AnonUnion));
4576 }
4577 
4578 /// BuildAnonymousStructOrUnion - Handle the declaration of an
4579 /// anonymous structure or union. Anonymous unions are a C++ feature
4580 /// (C++ [class.union]) and a C11 feature; anonymous structures
4581 /// are a C11 feature and GNU C++ extension.
4582 Decl *Sema::BuildAnonymousStructOrUnion(Scope *S, DeclSpec &DS,
4583                                         AccessSpecifier AS,
4584                                         RecordDecl *Record,
4585                                         const PrintingPolicy &Policy) {
4586   DeclContext *Owner = Record->getDeclContext();
4587 
4588   // Diagnose whether this anonymous struct/union is an extension.
4589   if (Record->isUnion() && !getLangOpts().CPlusPlus && !getLangOpts().C11)
4590     Diag(Record->getLocation(), diag::ext_anonymous_union);
4591   else if (!Record->isUnion() && getLangOpts().CPlusPlus)
4592     Diag(Record->getLocation(), diag::ext_gnu_anonymous_struct);
4593   else if (!Record->isUnion() && !getLangOpts().C11)
4594     Diag(Record->getLocation(), diag::ext_c11_anonymous_struct);
4595 
4596   // C and C++ require different kinds of checks for anonymous
4597   // structs/unions.
4598   bool Invalid = false;
4599   if (getLangOpts().CPlusPlus) {
4600     const char *PrevSpec = nullptr;
4601     unsigned DiagID;
4602     if (Record->isUnion()) {
4603       // C++ [class.union]p6:
4604       //   Anonymous unions declared in a named namespace or in the
4605       //   global namespace shall be declared static.
4606       if (DS.getStorageClassSpec() != DeclSpec::SCS_static &&
4607           (isa<TranslationUnitDecl>(Owner) ||
4608            (isa<NamespaceDecl>(Owner) &&
4609             cast<NamespaceDecl>(Owner)->getDeclName()))) {
4610         Diag(Record->getLocation(), diag::err_anonymous_union_not_static)
4611           << FixItHint::CreateInsertion(Record->getLocation(), "static ");
4612 
4613         // Recover by adding 'static'.
4614         DS.SetStorageClassSpec(*this, DeclSpec::SCS_static, SourceLocation(),
4615                                PrevSpec, DiagID, Policy);
4616       }
4617       // C++ [class.union]p6:
4618       //   A storage class is not allowed in a declaration of an
4619       //   anonymous union in a class scope.
4620       else if (DS.getStorageClassSpec() != DeclSpec::SCS_unspecified &&
4621                isa<RecordDecl>(Owner)) {
4622         Diag(DS.getStorageClassSpecLoc(),
4623              diag::err_anonymous_union_with_storage_spec)
4624           << FixItHint::CreateRemoval(DS.getStorageClassSpecLoc());
4625 
4626         // Recover by removing the storage specifier.
4627         DS.SetStorageClassSpec(*this, DeclSpec::SCS_unspecified,
4628                                SourceLocation(),
4629                                PrevSpec, DiagID, Context.getPrintingPolicy());
4630       }
4631     }
4632 
4633     // Ignore const/volatile/restrict qualifiers.
4634     if (DS.getTypeQualifiers()) {
4635       if (DS.getTypeQualifiers() & DeclSpec::TQ_const)
4636         Diag(DS.getConstSpecLoc(), diag::ext_anonymous_struct_union_qualified)
4637           << Record->isUnion() << "const"
4638           << FixItHint::CreateRemoval(DS.getConstSpecLoc());
4639       if (DS.getTypeQualifiers() & DeclSpec::TQ_volatile)
4640         Diag(DS.getVolatileSpecLoc(),
4641              diag::ext_anonymous_struct_union_qualified)
4642           << Record->isUnion() << "volatile"
4643           << FixItHint::CreateRemoval(DS.getVolatileSpecLoc());
4644       if (DS.getTypeQualifiers() & DeclSpec::TQ_restrict)
4645         Diag(DS.getRestrictSpecLoc(),
4646              diag::ext_anonymous_struct_union_qualified)
4647           << Record->isUnion() << "restrict"
4648           << FixItHint::CreateRemoval(DS.getRestrictSpecLoc());
4649       if (DS.getTypeQualifiers() & DeclSpec::TQ_atomic)
4650         Diag(DS.getAtomicSpecLoc(),
4651              diag::ext_anonymous_struct_union_qualified)
4652           << Record->isUnion() << "_Atomic"
4653           << FixItHint::CreateRemoval(DS.getAtomicSpecLoc());
4654       if (DS.getTypeQualifiers() & DeclSpec::TQ_unaligned)
4655         Diag(DS.getUnalignedSpecLoc(),
4656              diag::ext_anonymous_struct_union_qualified)
4657           << Record->isUnion() << "__unaligned"
4658           << FixItHint::CreateRemoval(DS.getUnalignedSpecLoc());
4659 
4660       DS.ClearTypeQualifiers();
4661     }
4662 
4663     // C++ [class.union]p2:
4664     //   The member-specification of an anonymous union shall only
4665     //   define non-static data members. [Note: nested types and
4666     //   functions cannot be declared within an anonymous union. ]
4667     for (auto *Mem : Record->decls()) {
4668       if (auto *FD = dyn_cast<FieldDecl>(Mem)) {
4669         // C++ [class.union]p3:
4670         //   An anonymous union shall not have private or protected
4671         //   members (clause 11).
4672         assert(FD->getAccess() != AS_none);
4673         if (FD->getAccess() != AS_public) {
4674           Diag(FD->getLocation(), diag::err_anonymous_record_nonpublic_member)
4675             << Record->isUnion() << (FD->getAccess() == AS_protected);
4676           Invalid = true;
4677         }
4678 
4679         // C++ [class.union]p1
4680         //   An object of a class with a non-trivial constructor, a non-trivial
4681         //   copy constructor, a non-trivial destructor, or a non-trivial copy
4682         //   assignment operator cannot be a member of a union, nor can an
4683         //   array of such objects.
4684         if (CheckNontrivialField(FD))
4685           Invalid = true;
4686       } else if (Mem->isImplicit()) {
4687         // Any implicit members are fine.
4688       } else if (isa<TagDecl>(Mem) && Mem->getDeclContext() != Record) {
4689         // This is a type that showed up in an
4690         // elaborated-type-specifier inside the anonymous struct or
4691         // union, but which actually declares a type outside of the
4692         // anonymous struct or union. It's okay.
4693       } else if (auto *MemRecord = dyn_cast<RecordDecl>(Mem)) {
4694         if (!MemRecord->isAnonymousStructOrUnion() &&
4695             MemRecord->getDeclName()) {
4696           // Visual C++ allows type definition in anonymous struct or union.
4697           if (getLangOpts().MicrosoftExt)
4698             Diag(MemRecord->getLocation(), diag::ext_anonymous_record_with_type)
4699               << Record->isUnion();
4700           else {
4701             // This is a nested type declaration.
4702             Diag(MemRecord->getLocation(), diag::err_anonymous_record_with_type)
4703               << Record->isUnion();
4704             Invalid = true;
4705           }
4706         } else {
4707           // This is an anonymous type definition within another anonymous type.
4708           // This is a popular extension, provided by Plan9, MSVC and GCC, but
4709           // not part of standard C++.
4710           Diag(MemRecord->getLocation(),
4711                diag::ext_anonymous_record_with_anonymous_type)
4712             << Record->isUnion();
4713         }
4714       } else if (isa<AccessSpecDecl>(Mem)) {
4715         // Any access specifier is fine.
4716       } else if (isa<StaticAssertDecl>(Mem)) {
4717         // In C++1z, static_assert declarations are also fine.
4718       } else {
4719         // We have something that isn't a non-static data
4720         // member. Complain about it.
4721         unsigned DK = diag::err_anonymous_record_bad_member;
4722         if (isa<TypeDecl>(Mem))
4723           DK = diag::err_anonymous_record_with_type;
4724         else if (isa<FunctionDecl>(Mem))
4725           DK = diag::err_anonymous_record_with_function;
4726         else if (isa<VarDecl>(Mem))
4727           DK = diag::err_anonymous_record_with_static;
4728 
4729         // Visual C++ allows type definition in anonymous struct or union.
4730         if (getLangOpts().MicrosoftExt &&
4731             DK == diag::err_anonymous_record_with_type)
4732           Diag(Mem->getLocation(), diag::ext_anonymous_record_with_type)
4733             << Record->isUnion();
4734         else {
4735           Diag(Mem->getLocation(), DK) << Record->isUnion();
4736           Invalid = true;
4737         }
4738       }
4739     }
4740 
4741     // C++11 [class.union]p8 (DR1460):
4742     //   At most one variant member of a union may have a
4743     //   brace-or-equal-initializer.
4744     if (cast<CXXRecordDecl>(Record)->hasInClassInitializer() &&
4745         Owner->isRecord())
4746       checkDuplicateDefaultInit(*this, cast<CXXRecordDecl>(Owner),
4747                                 cast<CXXRecordDecl>(Record));
4748   }
4749 
4750   if (!Record->isUnion() && !Owner->isRecord()) {
4751     Diag(Record->getLocation(), diag::err_anonymous_struct_not_member)
4752       << getLangOpts().CPlusPlus;
4753     Invalid = true;
4754   }
4755 
4756   // Mock up a declarator.
4757   Declarator Dc(DS, Declarator::MemberContext);
4758   TypeSourceInfo *TInfo = GetTypeForDeclarator(Dc, S);
4759   assert(TInfo && "couldn't build declarator info for anonymous struct/union");
4760 
4761   // Create a declaration for this anonymous struct/union.
4762   NamedDecl *Anon = nullptr;
4763   if (RecordDecl *OwningClass = dyn_cast<RecordDecl>(Owner)) {
4764     Anon = FieldDecl::Create(Context, OwningClass,
4765                              DS.getLocStart(),
4766                              Record->getLocation(),
4767                              /*IdentifierInfo=*/nullptr,
4768                              Context.getTypeDeclType(Record),
4769                              TInfo,
4770                              /*BitWidth=*/nullptr, /*Mutable=*/false,
4771                              /*InitStyle=*/ICIS_NoInit);
4772     Anon->setAccess(AS);
4773     if (getLangOpts().CPlusPlus)
4774       FieldCollector->Add(cast<FieldDecl>(Anon));
4775   } else {
4776     DeclSpec::SCS SCSpec = DS.getStorageClassSpec();
4777     StorageClass SC = StorageClassSpecToVarDeclStorageClass(DS);
4778     if (SCSpec == DeclSpec::SCS_mutable) {
4779       // mutable can only appear on non-static class members, so it's always
4780       // an error here
4781       Diag(Record->getLocation(), diag::err_mutable_nonmember);
4782       Invalid = true;
4783       SC = SC_None;
4784     }
4785 
4786     Anon = VarDecl::Create(Context, Owner,
4787                            DS.getLocStart(),
4788                            Record->getLocation(), /*IdentifierInfo=*/nullptr,
4789                            Context.getTypeDeclType(Record),
4790                            TInfo, SC);
4791 
4792     // Default-initialize the implicit variable. This initialization will be
4793     // trivial in almost all cases, except if a union member has an in-class
4794     // initializer:
4795     //   union { int n = 0; };
4796     ActOnUninitializedDecl(Anon);
4797   }
4798   Anon->setImplicit();
4799 
4800   // Mark this as an anonymous struct/union type.
4801   Record->setAnonymousStructOrUnion(true);
4802 
4803   // Add the anonymous struct/union object to the current
4804   // context. We'll be referencing this object when we refer to one of
4805   // its members.
4806   Owner->addDecl(Anon);
4807 
4808   // Inject the members of the anonymous struct/union into the owning
4809   // context and into the identifier resolver chain for name lookup
4810   // purposes.
4811   SmallVector<NamedDecl*, 2> Chain;
4812   Chain.push_back(Anon);
4813 
4814   if (InjectAnonymousStructOrUnionMembers(*this, S, Owner, Record, AS, Chain))
4815     Invalid = true;
4816 
4817   if (VarDecl *NewVD = dyn_cast<VarDecl>(Anon)) {
4818     if (getLangOpts().CPlusPlus && NewVD->isStaticLocal()) {
4819       Decl *ManglingContextDecl;
4820       if (MangleNumberingContext *MCtx = getCurrentMangleNumberContext(
4821               NewVD->getDeclContext(), ManglingContextDecl)) {
4822         Context.setManglingNumber(
4823             NewVD, MCtx->getManglingNumber(
4824                        NewVD, getMSManglingNumber(getLangOpts(), S)));
4825         Context.setStaticLocalNumber(NewVD, MCtx->getStaticLocalNumber(NewVD));
4826       }
4827     }
4828   }
4829 
4830   if (Invalid)
4831     Anon->setInvalidDecl();
4832 
4833   return Anon;
4834 }
4835 
4836 /// BuildMicrosoftCAnonymousStruct - Handle the declaration of an
4837 /// Microsoft C anonymous structure.
4838 /// Ref: http://msdn.microsoft.com/en-us/library/z2cx9y4f.aspx
4839 /// Example:
4840 ///
4841 /// struct A { int a; };
4842 /// struct B { struct A; int b; };
4843 ///
4844 /// void foo() {
4845 ///   B var;
4846 ///   var.a = 3;
4847 /// }
4848 ///
4849 Decl *Sema::BuildMicrosoftCAnonymousStruct(Scope *S, DeclSpec &DS,
4850                                            RecordDecl *Record) {
4851   assert(Record && "expected a record!");
4852 
4853   // Mock up a declarator.
4854   Declarator Dc(DS, Declarator::TypeNameContext);
4855   TypeSourceInfo *TInfo = GetTypeForDeclarator(Dc, S);
4856   assert(TInfo && "couldn't build declarator info for anonymous struct");
4857 
4858   auto *ParentDecl = cast<RecordDecl>(CurContext);
4859   QualType RecTy = Context.getTypeDeclType(Record);
4860 
4861   // Create a declaration for this anonymous struct.
4862   NamedDecl *Anon = FieldDecl::Create(Context,
4863                              ParentDecl,
4864                              DS.getLocStart(),
4865                              DS.getLocStart(),
4866                              /*IdentifierInfo=*/nullptr,
4867                              RecTy,
4868                              TInfo,
4869                              /*BitWidth=*/nullptr, /*Mutable=*/false,
4870                              /*InitStyle=*/ICIS_NoInit);
4871   Anon->setImplicit();
4872 
4873   // Add the anonymous struct object to the current context.
4874   CurContext->addDecl(Anon);
4875 
4876   // Inject the members of the anonymous struct into the current
4877   // context and into the identifier resolver chain for name lookup
4878   // purposes.
4879   SmallVector<NamedDecl*, 2> Chain;
4880   Chain.push_back(Anon);
4881 
4882   RecordDecl *RecordDef = Record->getDefinition();
4883   if (RequireCompleteType(Anon->getLocation(), RecTy,
4884                           diag::err_field_incomplete) ||
4885       InjectAnonymousStructOrUnionMembers(*this, S, CurContext, RecordDef,
4886                                           AS_none, Chain)) {
4887     Anon->setInvalidDecl();
4888     ParentDecl->setInvalidDecl();
4889   }
4890 
4891   return Anon;
4892 }
4893 
4894 /// GetNameForDeclarator - Determine the full declaration name for the
4895 /// given Declarator.
4896 DeclarationNameInfo Sema::GetNameForDeclarator(Declarator &D) {
4897   return GetNameFromUnqualifiedId(D.getName());
4898 }
4899 
4900 /// \brief Retrieves the declaration name from a parsed unqualified-id.
4901 DeclarationNameInfo
4902 Sema::GetNameFromUnqualifiedId(const UnqualifiedId &Name) {
4903   DeclarationNameInfo NameInfo;
4904   NameInfo.setLoc(Name.StartLocation);
4905 
4906   switch (Name.getKind()) {
4907 
4908   case UnqualifiedId::IK_ImplicitSelfParam:
4909   case UnqualifiedId::IK_Identifier:
4910     NameInfo.setName(Name.Identifier);
4911     NameInfo.setLoc(Name.StartLocation);
4912     return NameInfo;
4913 
4914   case UnqualifiedId::IK_DeductionGuideName: {
4915     // C++ [temp.deduct.guide]p3:
4916     //   The simple-template-id shall name a class template specialization.
4917     //   The template-name shall be the same identifier as the template-name
4918     //   of the simple-template-id.
4919     // These together intend to imply that the template-name shall name a
4920     // class template.
4921     // FIXME: template<typename T> struct X {};
4922     //        template<typename T> using Y = X<T>;
4923     //        Y(int) -> Y<int>;
4924     //   satisfies these rules but does not name a class template.
4925     TemplateName TN = Name.TemplateName.get().get();
4926     auto *Template = TN.getAsTemplateDecl();
4927     if (!Template || !isa<ClassTemplateDecl>(Template)) {
4928       Diag(Name.StartLocation,
4929            diag::err_deduction_guide_name_not_class_template)
4930         << (int)getTemplateNameKindForDiagnostics(TN) << TN;
4931       if (Template)
4932         Diag(Template->getLocation(), diag::note_template_decl_here);
4933       return DeclarationNameInfo();
4934     }
4935 
4936     NameInfo.setName(
4937         Context.DeclarationNames.getCXXDeductionGuideName(Template));
4938     NameInfo.setLoc(Name.StartLocation);
4939     return NameInfo;
4940   }
4941 
4942   case UnqualifiedId::IK_OperatorFunctionId:
4943     NameInfo.setName(Context.DeclarationNames.getCXXOperatorName(
4944                                            Name.OperatorFunctionId.Operator));
4945     NameInfo.setLoc(Name.StartLocation);
4946     NameInfo.getInfo().CXXOperatorName.BeginOpNameLoc
4947       = Name.OperatorFunctionId.SymbolLocations[0];
4948     NameInfo.getInfo().CXXOperatorName.EndOpNameLoc
4949       = Name.EndLocation.getRawEncoding();
4950     return NameInfo;
4951 
4952   case UnqualifiedId::IK_LiteralOperatorId:
4953     NameInfo.setName(Context.DeclarationNames.getCXXLiteralOperatorName(
4954                                                            Name.Identifier));
4955     NameInfo.setLoc(Name.StartLocation);
4956     NameInfo.setCXXLiteralOperatorNameLoc(Name.EndLocation);
4957     return NameInfo;
4958 
4959   case UnqualifiedId::IK_ConversionFunctionId: {
4960     TypeSourceInfo *TInfo;
4961     QualType Ty = GetTypeFromParser(Name.ConversionFunctionId, &TInfo);
4962     if (Ty.isNull())
4963       return DeclarationNameInfo();
4964     NameInfo.setName(Context.DeclarationNames.getCXXConversionFunctionName(
4965                                                Context.getCanonicalType(Ty)));
4966     NameInfo.setLoc(Name.StartLocation);
4967     NameInfo.setNamedTypeInfo(TInfo);
4968     return NameInfo;
4969   }
4970 
4971   case UnqualifiedId::IK_ConstructorName: {
4972     TypeSourceInfo *TInfo;
4973     QualType Ty = GetTypeFromParser(Name.ConstructorName, &TInfo);
4974     if (Ty.isNull())
4975       return DeclarationNameInfo();
4976     NameInfo.setName(Context.DeclarationNames.getCXXConstructorName(
4977                                               Context.getCanonicalType(Ty)));
4978     NameInfo.setLoc(Name.StartLocation);
4979     NameInfo.setNamedTypeInfo(TInfo);
4980     return NameInfo;
4981   }
4982 
4983   case UnqualifiedId::IK_ConstructorTemplateId: {
4984     // In well-formed code, we can only have a constructor
4985     // template-id that refers to the current context, so go there
4986     // to find the actual type being constructed.
4987     CXXRecordDecl *CurClass = dyn_cast<CXXRecordDecl>(CurContext);
4988     if (!CurClass || CurClass->getIdentifier() != Name.TemplateId->Name)
4989       return DeclarationNameInfo();
4990 
4991     // Determine the type of the class being constructed.
4992     QualType CurClassType = Context.getTypeDeclType(CurClass);
4993 
4994     // FIXME: Check two things: that the template-id names the same type as
4995     // CurClassType, and that the template-id does not occur when the name
4996     // was qualified.
4997 
4998     NameInfo.setName(Context.DeclarationNames.getCXXConstructorName(
4999                                     Context.getCanonicalType(CurClassType)));
5000     NameInfo.setLoc(Name.StartLocation);
5001     // FIXME: should we retrieve TypeSourceInfo?
5002     NameInfo.setNamedTypeInfo(nullptr);
5003     return NameInfo;
5004   }
5005 
5006   case UnqualifiedId::IK_DestructorName: {
5007     TypeSourceInfo *TInfo;
5008     QualType Ty = GetTypeFromParser(Name.DestructorName, &TInfo);
5009     if (Ty.isNull())
5010       return DeclarationNameInfo();
5011     NameInfo.setName(Context.DeclarationNames.getCXXDestructorName(
5012                                               Context.getCanonicalType(Ty)));
5013     NameInfo.setLoc(Name.StartLocation);
5014     NameInfo.setNamedTypeInfo(TInfo);
5015     return NameInfo;
5016   }
5017 
5018   case UnqualifiedId::IK_TemplateId: {
5019     TemplateName TName = Name.TemplateId->Template.get();
5020     SourceLocation TNameLoc = Name.TemplateId->TemplateNameLoc;
5021     return Context.getNameForTemplate(TName, TNameLoc);
5022   }
5023 
5024   } // switch (Name.getKind())
5025 
5026   llvm_unreachable("Unknown name kind");
5027 }
5028 
5029 static QualType getCoreType(QualType Ty) {
5030   do {
5031     if (Ty->isPointerType() || Ty->isReferenceType())
5032       Ty = Ty->getPointeeType();
5033     else if (Ty->isArrayType())
5034       Ty = Ty->castAsArrayTypeUnsafe()->getElementType();
5035     else
5036       return Ty.withoutLocalFastQualifiers();
5037   } while (true);
5038 }
5039 
5040 /// hasSimilarParameters - Determine whether the C++ functions Declaration
5041 /// and Definition have "nearly" matching parameters. This heuristic is
5042 /// used to improve diagnostics in the case where an out-of-line function
5043 /// definition doesn't match any declaration within the class or namespace.
5044 /// Also sets Params to the list of indices to the parameters that differ
5045 /// between the declaration and the definition. If hasSimilarParameters
5046 /// returns true and Params is empty, then all of the parameters match.
5047 static bool hasSimilarParameters(ASTContext &Context,
5048                                      FunctionDecl *Declaration,
5049                                      FunctionDecl *Definition,
5050                                      SmallVectorImpl<unsigned> &Params) {
5051   Params.clear();
5052   if (Declaration->param_size() != Definition->param_size())
5053     return false;
5054   for (unsigned Idx = 0; Idx < Declaration->param_size(); ++Idx) {
5055     QualType DeclParamTy = Declaration->getParamDecl(Idx)->getType();
5056     QualType DefParamTy = Definition->getParamDecl(Idx)->getType();
5057 
5058     // The parameter types are identical
5059     if (Context.hasSameType(DefParamTy, DeclParamTy))
5060       continue;
5061 
5062     QualType DeclParamBaseTy = getCoreType(DeclParamTy);
5063     QualType DefParamBaseTy = getCoreType(DefParamTy);
5064     const IdentifierInfo *DeclTyName = DeclParamBaseTy.getBaseTypeIdentifier();
5065     const IdentifierInfo *DefTyName = DefParamBaseTy.getBaseTypeIdentifier();
5066 
5067     if (Context.hasSameUnqualifiedType(DeclParamBaseTy, DefParamBaseTy) ||
5068         (DeclTyName && DeclTyName == DefTyName))
5069       Params.push_back(Idx);
5070     else  // The two parameters aren't even close
5071       return false;
5072   }
5073 
5074   return true;
5075 }
5076 
5077 /// NeedsRebuildingInCurrentInstantiation - Checks whether the given
5078 /// declarator needs to be rebuilt in the current instantiation.
5079 /// Any bits of declarator which appear before the name are valid for
5080 /// consideration here.  That's specifically the type in the decl spec
5081 /// and the base type in any member-pointer chunks.
5082 static bool RebuildDeclaratorInCurrentInstantiation(Sema &S, Declarator &D,
5083                                                     DeclarationName Name) {
5084   // The types we specifically need to rebuild are:
5085   //   - typenames, typeofs, and decltypes
5086   //   - types which will become injected class names
5087   // Of course, we also need to rebuild any type referencing such a
5088   // type.  It's safest to just say "dependent", but we call out a
5089   // few cases here.
5090 
5091   DeclSpec &DS = D.getMutableDeclSpec();
5092   switch (DS.getTypeSpecType()) {
5093   case DeclSpec::TST_typename:
5094   case DeclSpec::TST_typeofType:
5095   case DeclSpec::TST_underlyingType:
5096   case DeclSpec::TST_atomic: {
5097     // Grab the type from the parser.
5098     TypeSourceInfo *TSI = nullptr;
5099     QualType T = S.GetTypeFromParser(DS.getRepAsType(), &TSI);
5100     if (T.isNull() || !T->isDependentType()) break;
5101 
5102     // Make sure there's a type source info.  This isn't really much
5103     // of a waste; most dependent types should have type source info
5104     // attached already.
5105     if (!TSI)
5106       TSI = S.Context.getTrivialTypeSourceInfo(T, DS.getTypeSpecTypeLoc());
5107 
5108     // Rebuild the type in the current instantiation.
5109     TSI = S.RebuildTypeInCurrentInstantiation(TSI, D.getIdentifierLoc(), Name);
5110     if (!TSI) return true;
5111 
5112     // Store the new type back in the decl spec.
5113     ParsedType LocType = S.CreateParsedType(TSI->getType(), TSI);
5114     DS.UpdateTypeRep(LocType);
5115     break;
5116   }
5117 
5118   case DeclSpec::TST_decltype:
5119   case DeclSpec::TST_typeofExpr: {
5120     Expr *E = DS.getRepAsExpr();
5121     ExprResult Result = S.RebuildExprInCurrentInstantiation(E);
5122     if (Result.isInvalid()) return true;
5123     DS.UpdateExprRep(Result.get());
5124     break;
5125   }
5126 
5127   default:
5128     // Nothing to do for these decl specs.
5129     break;
5130   }
5131 
5132   // It doesn't matter what order we do this in.
5133   for (unsigned I = 0, E = D.getNumTypeObjects(); I != E; ++I) {
5134     DeclaratorChunk &Chunk = D.getTypeObject(I);
5135 
5136     // The only type information in the declarator which can come
5137     // before the declaration name is the base type of a member
5138     // pointer.
5139     if (Chunk.Kind != DeclaratorChunk::MemberPointer)
5140       continue;
5141 
5142     // Rebuild the scope specifier in-place.
5143     CXXScopeSpec &SS = Chunk.Mem.Scope();
5144     if (S.RebuildNestedNameSpecifierInCurrentInstantiation(SS))
5145       return true;
5146   }
5147 
5148   return false;
5149 }
5150 
5151 Decl *Sema::ActOnDeclarator(Scope *S, Declarator &D) {
5152   D.setFunctionDefinitionKind(FDK_Declaration);
5153   Decl *Dcl = HandleDeclarator(S, D, MultiTemplateParamsArg());
5154 
5155   if (OriginalLexicalContext && OriginalLexicalContext->isObjCContainer() &&
5156       Dcl && Dcl->getDeclContext()->isFileContext())
5157     Dcl->setTopLevelDeclInObjCContainer();
5158 
5159   if (getLangOpts().OpenCL)
5160     setCurrentOpenCLExtensionForDecl(Dcl);
5161 
5162   return Dcl;
5163 }
5164 
5165 /// DiagnoseClassNameShadow - Implement C++ [class.mem]p13:
5166 ///   If T is the name of a class, then each of the following shall have a
5167 ///   name different from T:
5168 ///     - every static data member of class T;
5169 ///     - every member function of class T
5170 ///     - every member of class T that is itself a type;
5171 /// \returns true if the declaration name violates these rules.
5172 bool Sema::DiagnoseClassNameShadow(DeclContext *DC,
5173                                    DeclarationNameInfo NameInfo) {
5174   DeclarationName Name = NameInfo.getName();
5175 
5176   CXXRecordDecl *Record = dyn_cast<CXXRecordDecl>(DC);
5177   while (Record && Record->isAnonymousStructOrUnion())
5178     Record = dyn_cast<CXXRecordDecl>(Record->getParent());
5179   if (Record && Record->getIdentifier() && Record->getDeclName() == Name) {
5180     Diag(NameInfo.getLoc(), diag::err_member_name_of_class) << Name;
5181     return true;
5182   }
5183 
5184   return false;
5185 }
5186 
5187 /// \brief Diagnose a declaration whose declarator-id has the given
5188 /// nested-name-specifier.
5189 ///
5190 /// \param SS The nested-name-specifier of the declarator-id.
5191 ///
5192 /// \param DC The declaration context to which the nested-name-specifier
5193 /// resolves.
5194 ///
5195 /// \param Name The name of the entity being declared.
5196 ///
5197 /// \param Loc The location of the name of the entity being declared.
5198 ///
5199 /// \returns true if we cannot safely recover from this error, false otherwise.
5200 bool Sema::diagnoseQualifiedDeclaration(CXXScopeSpec &SS, DeclContext *DC,
5201                                         DeclarationName Name,
5202                                         SourceLocation Loc) {
5203   DeclContext *Cur = CurContext;
5204   while (isa<LinkageSpecDecl>(Cur) || isa<CapturedDecl>(Cur))
5205     Cur = Cur->getParent();
5206 
5207   // If the user provided a superfluous scope specifier that refers back to the
5208   // class in which the entity is already declared, diagnose and ignore it.
5209   //
5210   // class X {
5211   //   void X::f();
5212   // };
5213   //
5214   // Note, it was once ill-formed to give redundant qualification in all
5215   // contexts, but that rule was removed by DR482.
5216   if (Cur->Equals(DC)) {
5217     if (Cur->isRecord()) {
5218       Diag(Loc, LangOpts.MicrosoftExt ? diag::warn_member_extra_qualification
5219                                       : diag::err_member_extra_qualification)
5220         << Name << FixItHint::CreateRemoval(SS.getRange());
5221       SS.clear();
5222     } else {
5223       Diag(Loc, diag::warn_namespace_member_extra_qualification) << Name;
5224     }
5225     return false;
5226   }
5227 
5228   // Check whether the qualifying scope encloses the scope of the original
5229   // declaration.
5230   if (!Cur->Encloses(DC)) {
5231     if (Cur->isRecord())
5232       Diag(Loc, diag::err_member_qualification)
5233         << Name << SS.getRange();
5234     else if (isa<TranslationUnitDecl>(DC))
5235       Diag(Loc, diag::err_invalid_declarator_global_scope)
5236         << Name << SS.getRange();
5237     else if (isa<FunctionDecl>(Cur))
5238       Diag(Loc, diag::err_invalid_declarator_in_function)
5239         << Name << SS.getRange();
5240     else if (isa<BlockDecl>(Cur))
5241       Diag(Loc, diag::err_invalid_declarator_in_block)
5242         << Name << SS.getRange();
5243     else
5244       Diag(Loc, diag::err_invalid_declarator_scope)
5245       << Name << cast<NamedDecl>(Cur) << cast<NamedDecl>(DC) << SS.getRange();
5246 
5247     return true;
5248   }
5249 
5250   if (Cur->isRecord()) {
5251     // Cannot qualify members within a class.
5252     Diag(Loc, diag::err_member_qualification)
5253       << Name << SS.getRange();
5254     SS.clear();
5255 
5256     // C++ constructors and destructors with incorrect scopes can break
5257     // our AST invariants by having the wrong underlying types. If
5258     // that's the case, then drop this declaration entirely.
5259     if ((Name.getNameKind() == DeclarationName::CXXConstructorName ||
5260          Name.getNameKind() == DeclarationName::CXXDestructorName) &&
5261         !Context.hasSameType(Name.getCXXNameType(),
5262                              Context.getTypeDeclType(cast<CXXRecordDecl>(Cur))))
5263       return true;
5264 
5265     return false;
5266   }
5267 
5268   // C++11 [dcl.meaning]p1:
5269   //   [...] "The nested-name-specifier of the qualified declarator-id shall
5270   //   not begin with a decltype-specifer"
5271   NestedNameSpecifierLoc SpecLoc(SS.getScopeRep(), SS.location_data());
5272   while (SpecLoc.getPrefix())
5273     SpecLoc = SpecLoc.getPrefix();
5274   if (dyn_cast_or_null<DecltypeType>(
5275         SpecLoc.getNestedNameSpecifier()->getAsType()))
5276     Diag(Loc, diag::err_decltype_in_declarator)
5277       << SpecLoc.getTypeLoc().getSourceRange();
5278 
5279   return false;
5280 }
5281 
5282 NamedDecl *Sema::HandleDeclarator(Scope *S, Declarator &D,
5283                                   MultiTemplateParamsArg TemplateParamLists) {
5284   // TODO: consider using NameInfo for diagnostic.
5285   DeclarationNameInfo NameInfo = GetNameForDeclarator(D);
5286   DeclarationName Name = NameInfo.getName();
5287 
5288   // All of these full declarators require an identifier.  If it doesn't have
5289   // one, the ParsedFreeStandingDeclSpec action should be used.
5290   if (D.isDecompositionDeclarator()) {
5291     return ActOnDecompositionDeclarator(S, D, TemplateParamLists);
5292   } else if (!Name) {
5293     if (!D.isInvalidType())  // Reject this if we think it is valid.
5294       Diag(D.getDeclSpec().getLocStart(),
5295            diag::err_declarator_need_ident)
5296         << D.getDeclSpec().getSourceRange() << D.getSourceRange();
5297     return nullptr;
5298   } else if (DiagnoseUnexpandedParameterPack(NameInfo, UPPC_DeclarationType))
5299     return nullptr;
5300 
5301   // The scope passed in may not be a decl scope.  Zip up the scope tree until
5302   // we find one that is.
5303   while ((S->getFlags() & Scope::DeclScope) == 0 ||
5304          (S->getFlags() & Scope::TemplateParamScope) != 0)
5305     S = S->getParent();
5306 
5307   DeclContext *DC = CurContext;
5308   if (D.getCXXScopeSpec().isInvalid())
5309     D.setInvalidType();
5310   else if (D.getCXXScopeSpec().isSet()) {
5311     if (DiagnoseUnexpandedParameterPack(D.getCXXScopeSpec(),
5312                                         UPPC_DeclarationQualifier))
5313       return nullptr;
5314 
5315     bool EnteringContext = !D.getDeclSpec().isFriendSpecified();
5316     DC = computeDeclContext(D.getCXXScopeSpec(), EnteringContext);
5317     if (!DC || isa<EnumDecl>(DC)) {
5318       // If we could not compute the declaration context, it's because the
5319       // declaration context is dependent but does not refer to a class,
5320       // class template, or class template partial specialization. Complain
5321       // and return early, to avoid the coming semantic disaster.
5322       Diag(D.getIdentifierLoc(),
5323            diag::err_template_qualified_declarator_no_match)
5324         << D.getCXXScopeSpec().getScopeRep()
5325         << D.getCXXScopeSpec().getRange();
5326       return nullptr;
5327     }
5328     bool IsDependentContext = DC->isDependentContext();
5329 
5330     if (!IsDependentContext &&
5331         RequireCompleteDeclContext(D.getCXXScopeSpec(), DC))
5332       return nullptr;
5333 
5334     // If a class is incomplete, do not parse entities inside it.
5335     if (isa<CXXRecordDecl>(DC) && !cast<CXXRecordDecl>(DC)->hasDefinition()) {
5336       Diag(D.getIdentifierLoc(),
5337            diag::err_member_def_undefined_record)
5338         << Name << DC << D.getCXXScopeSpec().getRange();
5339       return nullptr;
5340     }
5341     if (!D.getDeclSpec().isFriendSpecified()) {
5342       if (diagnoseQualifiedDeclaration(D.getCXXScopeSpec(), DC,
5343                                       Name, D.getIdentifierLoc())) {
5344         if (DC->isRecord())
5345           return nullptr;
5346 
5347         D.setInvalidType();
5348       }
5349     }
5350 
5351     // Check whether we need to rebuild the type of the given
5352     // declaration in the current instantiation.
5353     if (EnteringContext && IsDependentContext &&
5354         TemplateParamLists.size() != 0) {
5355       ContextRAII SavedContext(*this, DC);
5356       if (RebuildDeclaratorInCurrentInstantiation(*this, D, Name))
5357         D.setInvalidType();
5358     }
5359   }
5360 
5361   TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
5362   QualType R = TInfo->getType();
5363 
5364   if (DiagnoseUnexpandedParameterPack(D.getIdentifierLoc(), TInfo,
5365                                       UPPC_DeclarationType))
5366     D.setInvalidType();
5367 
5368   LookupResult Previous(*this, NameInfo, LookupOrdinaryName,
5369                         forRedeclarationInCurContext());
5370 
5371   // See if this is a redefinition of a variable in the same scope.
5372   if (!D.getCXXScopeSpec().isSet()) {
5373     bool IsLinkageLookup = false;
5374     bool CreateBuiltins = false;
5375 
5376     // If the declaration we're planning to build will be a function
5377     // or object with linkage, then look for another declaration with
5378     // linkage (C99 6.2.2p4-5 and C++ [basic.link]p6).
5379     //
5380     // If the declaration we're planning to build will be declared with
5381     // external linkage in the translation unit, create any builtin with
5382     // the same name.
5383     if (D.getDeclSpec().getStorageClassSpec() == DeclSpec::SCS_typedef)
5384       /* Do nothing*/;
5385     else if (CurContext->isFunctionOrMethod() &&
5386              (D.getDeclSpec().getStorageClassSpec() == DeclSpec::SCS_extern ||
5387               R->isFunctionType())) {
5388       IsLinkageLookup = true;
5389       CreateBuiltins =
5390           CurContext->getEnclosingNamespaceContext()->isTranslationUnit();
5391     } else if (CurContext->getRedeclContext()->isTranslationUnit() &&
5392                D.getDeclSpec().getStorageClassSpec() != DeclSpec::SCS_static)
5393       CreateBuiltins = true;
5394 
5395     if (IsLinkageLookup) {
5396       Previous.clear(LookupRedeclarationWithLinkage);
5397       Previous.setRedeclarationKind(ForExternalRedeclaration);
5398     }
5399 
5400     LookupName(Previous, S, CreateBuiltins);
5401   } else { // Something like "int foo::x;"
5402     LookupQualifiedName(Previous, DC);
5403 
5404     // C++ [dcl.meaning]p1:
5405     //   When the declarator-id is qualified, the declaration shall refer to a
5406     //  previously declared member of the class or namespace to which the
5407     //  qualifier refers (or, in the case of a namespace, of an element of the
5408     //  inline namespace set of that namespace (7.3.1)) or to a specialization
5409     //  thereof; [...]
5410     //
5411     // Note that we already checked the context above, and that we do not have
5412     // enough information to make sure that Previous contains the declaration
5413     // we want to match. For example, given:
5414     //
5415     //   class X {
5416     //     void f();
5417     //     void f(float);
5418     //   };
5419     //
5420     //   void X::f(int) { } // ill-formed
5421     //
5422     // In this case, Previous will point to the overload set
5423     // containing the two f's declared in X, but neither of them
5424     // matches.
5425 
5426     // C++ [dcl.meaning]p1:
5427     //   [...] the member shall not merely have been introduced by a
5428     //   using-declaration in the scope of the class or namespace nominated by
5429     //   the nested-name-specifier of the declarator-id.
5430     RemoveUsingDecls(Previous);
5431   }
5432 
5433   if (Previous.isSingleResult() &&
5434       Previous.getFoundDecl()->isTemplateParameter()) {
5435     // Maybe we will complain about the shadowed template parameter.
5436     if (!D.isInvalidType())
5437       DiagnoseTemplateParameterShadow(D.getIdentifierLoc(),
5438                                       Previous.getFoundDecl());
5439 
5440     // Just pretend that we didn't see the previous declaration.
5441     Previous.clear();
5442   }
5443 
5444   if (!R->isFunctionType() && DiagnoseClassNameShadow(DC, NameInfo))
5445     // Forget that the previous declaration is the injected-class-name.
5446     Previous.clear();
5447 
5448   // In C++, the previous declaration we find might be a tag type
5449   // (class or enum). In this case, the new declaration will hide the
5450   // tag type. Note that this applies to functions, function templates, and
5451   // variables, but not to typedefs (C++ [dcl.typedef]p4) or variable templates.
5452   if (Previous.isSingleTagDecl() &&
5453       D.getDeclSpec().getStorageClassSpec() != DeclSpec::SCS_typedef &&
5454       (TemplateParamLists.size() == 0 || R->isFunctionType()))
5455     Previous.clear();
5456 
5457   // Check that there are no default arguments other than in the parameters
5458   // of a function declaration (C++ only).
5459   if (getLangOpts().CPlusPlus)
5460     CheckExtraCXXDefaultArguments(D);
5461 
5462   if (D.getDeclSpec().isConceptSpecified()) {
5463     // C++ Concepts TS [dcl.spec.concept]p1: The concept specifier shall be
5464     // applied only to the definition of a function template or variable
5465     // template, declared in namespace scope
5466     if (!TemplateParamLists.size()) {
5467       Diag(D.getDeclSpec().getConceptSpecLoc(),
5468            diag:: err_concept_wrong_decl_kind);
5469       return nullptr;
5470     }
5471 
5472     if (!DC->getRedeclContext()->isFileContext()) {
5473       Diag(D.getIdentifierLoc(),
5474            diag::err_concept_decls_may_only_appear_in_namespace_scope);
5475       return nullptr;
5476     }
5477   }
5478 
5479   NamedDecl *New;
5480 
5481   bool AddToScope = true;
5482   if (D.getDeclSpec().getStorageClassSpec() == DeclSpec::SCS_typedef) {
5483     if (TemplateParamLists.size()) {
5484       Diag(D.getIdentifierLoc(), diag::err_template_typedef);
5485       return nullptr;
5486     }
5487 
5488     New = ActOnTypedefDeclarator(S, D, DC, TInfo, Previous);
5489   } else if (R->isFunctionType()) {
5490     New = ActOnFunctionDeclarator(S, D, DC, TInfo, Previous,
5491                                   TemplateParamLists,
5492                                   AddToScope);
5493   } else {
5494     New = ActOnVariableDeclarator(S, D, DC, TInfo, Previous, TemplateParamLists,
5495                                   AddToScope);
5496   }
5497 
5498   if (!New)
5499     return nullptr;
5500 
5501   // If this has an identifier and is not a function template specialization,
5502   // add it to the scope stack.
5503   if (New->getDeclName() && AddToScope) {
5504     // Only make a locally-scoped extern declaration visible if it is the first
5505     // declaration of this entity. Qualified lookup for such an entity should
5506     // only find this declaration if there is no visible declaration of it.
5507     bool AddToContext = !D.isRedeclaration() || !New->isLocalExternDecl();
5508     PushOnScopeChains(New, S, AddToContext);
5509     if (!AddToContext)
5510       CurContext->addHiddenDecl(New);
5511   }
5512 
5513   if (isInOpenMPDeclareTargetContext())
5514     checkDeclIsAllowedInOpenMPTarget(nullptr, New);
5515 
5516   return New;
5517 }
5518 
5519 /// Helper method to turn variable array types into constant array
5520 /// types in certain situations which would otherwise be errors (for
5521 /// GCC compatibility).
5522 static QualType TryToFixInvalidVariablyModifiedType(QualType T,
5523                                                     ASTContext &Context,
5524                                                     bool &SizeIsNegative,
5525                                                     llvm::APSInt &Oversized) {
5526   // This method tries to turn a variable array into a constant
5527   // array even when the size isn't an ICE.  This is necessary
5528   // for compatibility with code that depends on gcc's buggy
5529   // constant expression folding, like struct {char x[(int)(char*)2];}
5530   SizeIsNegative = false;
5531   Oversized = 0;
5532 
5533   if (T->isDependentType())
5534     return QualType();
5535 
5536   QualifierCollector Qs;
5537   const Type *Ty = Qs.strip(T);
5538 
5539   if (const PointerType* PTy = dyn_cast<PointerType>(Ty)) {
5540     QualType Pointee = PTy->getPointeeType();
5541     QualType FixedType =
5542         TryToFixInvalidVariablyModifiedType(Pointee, Context, SizeIsNegative,
5543                                             Oversized);
5544     if (FixedType.isNull()) return FixedType;
5545     FixedType = Context.getPointerType(FixedType);
5546     return Qs.apply(Context, FixedType);
5547   }
5548   if (const ParenType* PTy = dyn_cast<ParenType>(Ty)) {
5549     QualType Inner = PTy->getInnerType();
5550     QualType FixedType =
5551         TryToFixInvalidVariablyModifiedType(Inner, Context, SizeIsNegative,
5552                                             Oversized);
5553     if (FixedType.isNull()) return FixedType;
5554     FixedType = Context.getParenType(FixedType);
5555     return Qs.apply(Context, FixedType);
5556   }
5557 
5558   const VariableArrayType* VLATy = dyn_cast<VariableArrayType>(T);
5559   if (!VLATy)
5560     return QualType();
5561   // FIXME: We should probably handle this case
5562   if (VLATy->getElementType()->isVariablyModifiedType())
5563     return QualType();
5564 
5565   llvm::APSInt Res;
5566   if (!VLATy->getSizeExpr() ||
5567       !VLATy->getSizeExpr()->EvaluateAsInt(Res, Context))
5568     return QualType();
5569 
5570   // Check whether the array size is negative.
5571   if (Res.isSigned() && Res.isNegative()) {
5572     SizeIsNegative = true;
5573     return QualType();
5574   }
5575 
5576   // Check whether the array is too large to be addressed.
5577   unsigned ActiveSizeBits
5578     = ConstantArrayType::getNumAddressingBits(Context, VLATy->getElementType(),
5579                                               Res);
5580   if (ActiveSizeBits > ConstantArrayType::getMaxSizeBits(Context)) {
5581     Oversized = Res;
5582     return QualType();
5583   }
5584 
5585   return Context.getConstantArrayType(VLATy->getElementType(),
5586                                       Res, ArrayType::Normal, 0);
5587 }
5588 
5589 static void
5590 FixInvalidVariablyModifiedTypeLoc(TypeLoc SrcTL, TypeLoc DstTL) {
5591   SrcTL = SrcTL.getUnqualifiedLoc();
5592   DstTL = DstTL.getUnqualifiedLoc();
5593   if (PointerTypeLoc SrcPTL = SrcTL.getAs<PointerTypeLoc>()) {
5594     PointerTypeLoc DstPTL = DstTL.castAs<PointerTypeLoc>();
5595     FixInvalidVariablyModifiedTypeLoc(SrcPTL.getPointeeLoc(),
5596                                       DstPTL.getPointeeLoc());
5597     DstPTL.setStarLoc(SrcPTL.getStarLoc());
5598     return;
5599   }
5600   if (ParenTypeLoc SrcPTL = SrcTL.getAs<ParenTypeLoc>()) {
5601     ParenTypeLoc DstPTL = DstTL.castAs<ParenTypeLoc>();
5602     FixInvalidVariablyModifiedTypeLoc(SrcPTL.getInnerLoc(),
5603                                       DstPTL.getInnerLoc());
5604     DstPTL.setLParenLoc(SrcPTL.getLParenLoc());
5605     DstPTL.setRParenLoc(SrcPTL.getRParenLoc());
5606     return;
5607   }
5608   ArrayTypeLoc SrcATL = SrcTL.castAs<ArrayTypeLoc>();
5609   ArrayTypeLoc DstATL = DstTL.castAs<ArrayTypeLoc>();
5610   TypeLoc SrcElemTL = SrcATL.getElementLoc();
5611   TypeLoc DstElemTL = DstATL.getElementLoc();
5612   DstElemTL.initializeFullCopy(SrcElemTL);
5613   DstATL.setLBracketLoc(SrcATL.getLBracketLoc());
5614   DstATL.setSizeExpr(SrcATL.getSizeExpr());
5615   DstATL.setRBracketLoc(SrcATL.getRBracketLoc());
5616 }
5617 
5618 /// Helper method to turn variable array types into constant array
5619 /// types in certain situations which would otherwise be errors (for
5620 /// GCC compatibility).
5621 static TypeSourceInfo*
5622 TryToFixInvalidVariablyModifiedTypeSourceInfo(TypeSourceInfo *TInfo,
5623                                               ASTContext &Context,
5624                                               bool &SizeIsNegative,
5625                                               llvm::APSInt &Oversized) {
5626   QualType FixedTy
5627     = TryToFixInvalidVariablyModifiedType(TInfo->getType(), Context,
5628                                           SizeIsNegative, Oversized);
5629   if (FixedTy.isNull())
5630     return nullptr;
5631   TypeSourceInfo *FixedTInfo = Context.getTrivialTypeSourceInfo(FixedTy);
5632   FixInvalidVariablyModifiedTypeLoc(TInfo->getTypeLoc(),
5633                                     FixedTInfo->getTypeLoc());
5634   return FixedTInfo;
5635 }
5636 
5637 /// \brief Register the given locally-scoped extern "C" declaration so
5638 /// that it can be found later for redeclarations. We include any extern "C"
5639 /// declaration that is not visible in the translation unit here, not just
5640 /// function-scope declarations.
5641 void
5642 Sema::RegisterLocallyScopedExternCDecl(NamedDecl *ND, Scope *S) {
5643   if (!getLangOpts().CPlusPlus &&
5644       ND->getLexicalDeclContext()->getRedeclContext()->isTranslationUnit())
5645     // Don't need to track declarations in the TU in C.
5646     return;
5647 
5648   // Note that we have a locally-scoped external with this name.
5649   Context.getExternCContextDecl()->makeDeclVisibleInContext(ND);
5650 }
5651 
5652 NamedDecl *Sema::findLocallyScopedExternCDecl(DeclarationName Name) {
5653   // FIXME: We can have multiple results via __attribute__((overloadable)).
5654   auto Result = Context.getExternCContextDecl()->lookup(Name);
5655   return Result.empty() ? nullptr : *Result.begin();
5656 }
5657 
5658 /// \brief Diagnose function specifiers on a declaration of an identifier that
5659 /// does not identify a function.
5660 void Sema::DiagnoseFunctionSpecifiers(const DeclSpec &DS) {
5661   // FIXME: We should probably indicate the identifier in question to avoid
5662   // confusion for constructs like "virtual int a(), b;"
5663   if (DS.isVirtualSpecified())
5664     Diag(DS.getVirtualSpecLoc(),
5665          diag::err_virtual_non_function);
5666 
5667   if (DS.isExplicitSpecified())
5668     Diag(DS.getExplicitSpecLoc(),
5669          diag::err_explicit_non_function);
5670 
5671   if (DS.isNoreturnSpecified())
5672     Diag(DS.getNoreturnSpecLoc(),
5673          diag::err_noreturn_non_function);
5674 }
5675 
5676 NamedDecl*
5677 Sema::ActOnTypedefDeclarator(Scope* S, Declarator& D, DeclContext* DC,
5678                              TypeSourceInfo *TInfo, LookupResult &Previous) {
5679   // Typedef declarators cannot be qualified (C++ [dcl.meaning]p1).
5680   if (D.getCXXScopeSpec().isSet()) {
5681     Diag(D.getIdentifierLoc(), diag::err_qualified_typedef_declarator)
5682       << D.getCXXScopeSpec().getRange();
5683     D.setInvalidType();
5684     // Pretend we didn't see the scope specifier.
5685     DC = CurContext;
5686     Previous.clear();
5687   }
5688 
5689   DiagnoseFunctionSpecifiers(D.getDeclSpec());
5690 
5691   if (D.getDeclSpec().isInlineSpecified())
5692     Diag(D.getDeclSpec().getInlineSpecLoc(), diag::err_inline_non_function)
5693         << getLangOpts().CPlusPlus1z;
5694   if (D.getDeclSpec().isConstexprSpecified())
5695     Diag(D.getDeclSpec().getConstexprSpecLoc(), diag::err_invalid_constexpr)
5696       << 1;
5697   if (D.getDeclSpec().isConceptSpecified())
5698     Diag(D.getDeclSpec().getConceptSpecLoc(),
5699          diag::err_concept_wrong_decl_kind);
5700 
5701   if (D.getName().Kind != UnqualifiedId::IK_Identifier) {
5702     if (D.getName().Kind == UnqualifiedId::IK_DeductionGuideName)
5703       Diag(D.getName().StartLocation,
5704            diag::err_deduction_guide_invalid_specifier)
5705           << "typedef";
5706     else
5707       Diag(D.getName().StartLocation, diag::err_typedef_not_identifier)
5708           << D.getName().getSourceRange();
5709     return nullptr;
5710   }
5711 
5712   TypedefDecl *NewTD = ParseTypedefDecl(S, D, TInfo->getType(), TInfo);
5713   if (!NewTD) return nullptr;
5714 
5715   // Handle attributes prior to checking for duplicates in MergeVarDecl
5716   ProcessDeclAttributes(S, NewTD, D);
5717 
5718   CheckTypedefForVariablyModifiedType(S, NewTD);
5719 
5720   bool Redeclaration = D.isRedeclaration();
5721   NamedDecl *ND = ActOnTypedefNameDecl(S, DC, NewTD, Previous, Redeclaration);
5722   D.setRedeclaration(Redeclaration);
5723   return ND;
5724 }
5725 
5726 void
5727 Sema::CheckTypedefForVariablyModifiedType(Scope *S, TypedefNameDecl *NewTD) {
5728   // C99 6.7.7p2: If a typedef name specifies a variably modified type
5729   // then it shall have block scope.
5730   // Note that variably modified types must be fixed before merging the decl so
5731   // that redeclarations will match.
5732   TypeSourceInfo *TInfo = NewTD->getTypeSourceInfo();
5733   QualType T = TInfo->getType();
5734   if (T->isVariablyModifiedType()) {
5735     getCurFunction()->setHasBranchProtectedScope();
5736 
5737     if (S->getFnParent() == nullptr) {
5738       bool SizeIsNegative;
5739       llvm::APSInt Oversized;
5740       TypeSourceInfo *FixedTInfo =
5741         TryToFixInvalidVariablyModifiedTypeSourceInfo(TInfo, Context,
5742                                                       SizeIsNegative,
5743                                                       Oversized);
5744       if (FixedTInfo) {
5745         Diag(NewTD->getLocation(), diag::warn_illegal_constant_array_size);
5746         NewTD->setTypeSourceInfo(FixedTInfo);
5747       } else {
5748         if (SizeIsNegative)
5749           Diag(NewTD->getLocation(), diag::err_typecheck_negative_array_size);
5750         else if (T->isVariableArrayType())
5751           Diag(NewTD->getLocation(), diag::err_vla_decl_in_file_scope);
5752         else if (Oversized.getBoolValue())
5753           Diag(NewTD->getLocation(), diag::err_array_too_large)
5754             << Oversized.toString(10);
5755         else
5756           Diag(NewTD->getLocation(), diag::err_vm_decl_in_file_scope);
5757         NewTD->setInvalidDecl();
5758       }
5759     }
5760   }
5761 }
5762 
5763 /// ActOnTypedefNameDecl - Perform semantic checking for a declaration which
5764 /// declares a typedef-name, either using the 'typedef' type specifier or via
5765 /// a C++0x [dcl.typedef]p2 alias-declaration: 'using T = A;'.
5766 NamedDecl*
5767 Sema::ActOnTypedefNameDecl(Scope *S, DeclContext *DC, TypedefNameDecl *NewTD,
5768                            LookupResult &Previous, bool &Redeclaration) {
5769 
5770   // Find the shadowed declaration before filtering for scope.
5771   NamedDecl *ShadowedDecl = getShadowedDeclaration(NewTD, Previous);
5772 
5773   // Merge the decl with the existing one if appropriate. If the decl is
5774   // in an outer scope, it isn't the same thing.
5775   FilterLookupForScope(Previous, DC, S, /*ConsiderLinkage*/false,
5776                        /*AllowInlineNamespace*/false);
5777   filterNonConflictingPreviousTypedefDecls(*this, NewTD, Previous);
5778   if (!Previous.empty()) {
5779     Redeclaration = true;
5780     MergeTypedefNameDecl(S, NewTD, Previous);
5781   }
5782 
5783   if (ShadowedDecl && !Redeclaration)
5784     CheckShadow(NewTD, ShadowedDecl, Previous);
5785 
5786   // If this is the C FILE type, notify the AST context.
5787   if (IdentifierInfo *II = NewTD->getIdentifier())
5788     if (!NewTD->isInvalidDecl() &&
5789         NewTD->getDeclContext()->getRedeclContext()->isTranslationUnit()) {
5790       if (II->isStr("FILE"))
5791         Context.setFILEDecl(NewTD);
5792       else if (II->isStr("jmp_buf"))
5793         Context.setjmp_bufDecl(NewTD);
5794       else if (II->isStr("sigjmp_buf"))
5795         Context.setsigjmp_bufDecl(NewTD);
5796       else if (II->isStr("ucontext_t"))
5797         Context.setucontext_tDecl(NewTD);
5798     }
5799 
5800   return NewTD;
5801 }
5802 
5803 /// \brief Determines whether the given declaration is an out-of-scope
5804 /// previous declaration.
5805 ///
5806 /// This routine should be invoked when name lookup has found a
5807 /// previous declaration (PrevDecl) that is not in the scope where a
5808 /// new declaration by the same name is being introduced. If the new
5809 /// declaration occurs in a local scope, previous declarations with
5810 /// linkage may still be considered previous declarations (C99
5811 /// 6.2.2p4-5, C++ [basic.link]p6).
5812 ///
5813 /// \param PrevDecl the previous declaration found by name
5814 /// lookup
5815 ///
5816 /// \param DC the context in which the new declaration is being
5817 /// declared.
5818 ///
5819 /// \returns true if PrevDecl is an out-of-scope previous declaration
5820 /// for a new delcaration with the same name.
5821 static bool
5822 isOutOfScopePreviousDeclaration(NamedDecl *PrevDecl, DeclContext *DC,
5823                                 ASTContext &Context) {
5824   if (!PrevDecl)
5825     return false;
5826 
5827   if (!PrevDecl->hasLinkage())
5828     return false;
5829 
5830   if (Context.getLangOpts().CPlusPlus) {
5831     // C++ [basic.link]p6:
5832     //   If there is a visible declaration of an entity with linkage
5833     //   having the same name and type, ignoring entities declared
5834     //   outside the innermost enclosing namespace scope, the block
5835     //   scope declaration declares that same entity and receives the
5836     //   linkage of the previous declaration.
5837     DeclContext *OuterContext = DC->getRedeclContext();
5838     if (!OuterContext->isFunctionOrMethod())
5839       // This rule only applies to block-scope declarations.
5840       return false;
5841 
5842     DeclContext *PrevOuterContext = PrevDecl->getDeclContext();
5843     if (PrevOuterContext->isRecord())
5844       // We found a member function: ignore it.
5845       return false;
5846 
5847     // Find the innermost enclosing namespace for the new and
5848     // previous declarations.
5849     OuterContext = OuterContext->getEnclosingNamespaceContext();
5850     PrevOuterContext = PrevOuterContext->getEnclosingNamespaceContext();
5851 
5852     // The previous declaration is in a different namespace, so it
5853     // isn't the same function.
5854     if (!OuterContext->Equals(PrevOuterContext))
5855       return false;
5856   }
5857 
5858   return true;
5859 }
5860 
5861 static void SetNestedNameSpecifier(DeclaratorDecl *DD, Declarator &D) {
5862   CXXScopeSpec &SS = D.getCXXScopeSpec();
5863   if (!SS.isSet()) return;
5864   DD->setQualifierInfo(SS.getWithLocInContext(DD->getASTContext()));
5865 }
5866 
5867 bool Sema::inferObjCARCLifetime(ValueDecl *decl) {
5868   QualType type = decl->getType();
5869   Qualifiers::ObjCLifetime lifetime = type.getObjCLifetime();
5870   if (lifetime == Qualifiers::OCL_Autoreleasing) {
5871     // Various kinds of declaration aren't allowed to be __autoreleasing.
5872     unsigned kind = -1U;
5873     if (VarDecl *var = dyn_cast<VarDecl>(decl)) {
5874       if (var->hasAttr<BlocksAttr>())
5875         kind = 0; // __block
5876       else if (!var->hasLocalStorage())
5877         kind = 1; // global
5878     } else if (isa<ObjCIvarDecl>(decl)) {
5879       kind = 3; // ivar
5880     } else if (isa<FieldDecl>(decl)) {
5881       kind = 2; // field
5882     }
5883 
5884     if (kind != -1U) {
5885       Diag(decl->getLocation(), diag::err_arc_autoreleasing_var)
5886         << kind;
5887     }
5888   } else if (lifetime == Qualifiers::OCL_None) {
5889     // Try to infer lifetime.
5890     if (!type->isObjCLifetimeType())
5891       return false;
5892 
5893     lifetime = type->getObjCARCImplicitLifetime();
5894     type = Context.getLifetimeQualifiedType(type, lifetime);
5895     decl->setType(type);
5896   }
5897 
5898   if (VarDecl *var = dyn_cast<VarDecl>(decl)) {
5899     // Thread-local variables cannot have lifetime.
5900     if (lifetime && lifetime != Qualifiers::OCL_ExplicitNone &&
5901         var->getTLSKind()) {
5902       Diag(var->getLocation(), diag::err_arc_thread_ownership)
5903         << var->getType();
5904       return true;
5905     }
5906   }
5907 
5908   return false;
5909 }
5910 
5911 static void checkAttributesAfterMerging(Sema &S, NamedDecl &ND) {
5912   // Ensure that an auto decl is deduced otherwise the checks below might cache
5913   // the wrong linkage.
5914   assert(S.ParsingInitForAutoVars.count(&ND) == 0);
5915 
5916   // 'weak' only applies to declarations with external linkage.
5917   if (WeakAttr *Attr = ND.getAttr<WeakAttr>()) {
5918     if (!ND.isExternallyVisible()) {
5919       S.Diag(Attr->getLocation(), diag::err_attribute_weak_static);
5920       ND.dropAttr<WeakAttr>();
5921     }
5922   }
5923   if (WeakRefAttr *Attr = ND.getAttr<WeakRefAttr>()) {
5924     if (ND.isExternallyVisible()) {
5925       S.Diag(Attr->getLocation(), diag::err_attribute_weakref_not_static);
5926       ND.dropAttr<WeakRefAttr>();
5927       ND.dropAttr<AliasAttr>();
5928     }
5929   }
5930 
5931   if (auto *VD = dyn_cast<VarDecl>(&ND)) {
5932     if (VD->hasInit()) {
5933       if (const auto *Attr = VD->getAttr<AliasAttr>()) {
5934         assert(VD->isThisDeclarationADefinition() &&
5935                !VD->isExternallyVisible() && "Broken AliasAttr handled late!");
5936         S.Diag(Attr->getLocation(), diag::err_alias_is_definition) << VD << 0;
5937         VD->dropAttr<AliasAttr>();
5938       }
5939     }
5940   }
5941 
5942   // 'selectany' only applies to externally visible variable declarations.
5943   // It does not apply to functions.
5944   if (SelectAnyAttr *Attr = ND.getAttr<SelectAnyAttr>()) {
5945     if (isa<FunctionDecl>(ND) || !ND.isExternallyVisible()) {
5946       S.Diag(Attr->getLocation(),
5947              diag::err_attribute_selectany_non_extern_data);
5948       ND.dropAttr<SelectAnyAttr>();
5949     }
5950   }
5951 
5952   if (const InheritableAttr *Attr = getDLLAttr(&ND)) {
5953     // dll attributes require external linkage. Static locals may have external
5954     // linkage but still cannot be explicitly imported or exported.
5955     auto *VD = dyn_cast<VarDecl>(&ND);
5956     if (!ND.isExternallyVisible() || (VD && VD->isStaticLocal())) {
5957       S.Diag(ND.getLocation(), diag::err_attribute_dll_not_extern)
5958         << &ND << Attr;
5959       ND.setInvalidDecl();
5960     }
5961   }
5962 
5963   // Virtual functions cannot be marked as 'notail'.
5964   if (auto *Attr = ND.getAttr<NotTailCalledAttr>())
5965     if (auto *MD = dyn_cast<CXXMethodDecl>(&ND))
5966       if (MD->isVirtual()) {
5967         S.Diag(ND.getLocation(),
5968                diag::err_invalid_attribute_on_virtual_function)
5969             << Attr;
5970         ND.dropAttr<NotTailCalledAttr>();
5971       }
5972 }
5973 
5974 static void checkDLLAttributeRedeclaration(Sema &S, NamedDecl *OldDecl,
5975                                            NamedDecl *NewDecl,
5976                                            bool IsSpecialization,
5977                                            bool IsDefinition) {
5978   if (OldDecl->isInvalidDecl())
5979     return;
5980 
5981   bool IsTemplate = false;
5982   if (TemplateDecl *OldTD = dyn_cast<TemplateDecl>(OldDecl)) {
5983     OldDecl = OldTD->getTemplatedDecl();
5984     IsTemplate = true;
5985     if (!IsSpecialization)
5986       IsDefinition = false;
5987   }
5988   if (TemplateDecl *NewTD = dyn_cast<TemplateDecl>(NewDecl)) {
5989     NewDecl = NewTD->getTemplatedDecl();
5990     IsTemplate = true;
5991   }
5992 
5993   if (!OldDecl || !NewDecl)
5994     return;
5995 
5996   const DLLImportAttr *OldImportAttr = OldDecl->getAttr<DLLImportAttr>();
5997   const DLLExportAttr *OldExportAttr = OldDecl->getAttr<DLLExportAttr>();
5998   const DLLImportAttr *NewImportAttr = NewDecl->getAttr<DLLImportAttr>();
5999   const DLLExportAttr *NewExportAttr = NewDecl->getAttr<DLLExportAttr>();
6000 
6001   // dllimport and dllexport are inheritable attributes so we have to exclude
6002   // inherited attribute instances.
6003   bool HasNewAttr = (NewImportAttr && !NewImportAttr->isInherited()) ||
6004                     (NewExportAttr && !NewExportAttr->isInherited());
6005 
6006   // A redeclaration is not allowed to add a dllimport or dllexport attribute,
6007   // the only exception being explicit specializations.
6008   // Implicitly generated declarations are also excluded for now because there
6009   // is no other way to switch these to use dllimport or dllexport.
6010   bool AddsAttr = !(OldImportAttr || OldExportAttr) && HasNewAttr;
6011 
6012   if (AddsAttr && !IsSpecialization && !OldDecl->isImplicit()) {
6013     // Allow with a warning for free functions and global variables.
6014     bool JustWarn = false;
6015     if (!OldDecl->isCXXClassMember()) {
6016       auto *VD = dyn_cast<VarDecl>(OldDecl);
6017       if (VD && !VD->getDescribedVarTemplate())
6018         JustWarn = true;
6019       auto *FD = dyn_cast<FunctionDecl>(OldDecl);
6020       if (FD && FD->getTemplatedKind() == FunctionDecl::TK_NonTemplate)
6021         JustWarn = true;
6022     }
6023 
6024     // We cannot change a declaration that's been used because IR has already
6025     // been emitted. Dllimported functions will still work though (modulo
6026     // address equality) as they can use the thunk.
6027     if (OldDecl->isUsed())
6028       if (!isa<FunctionDecl>(OldDecl) || !NewImportAttr)
6029         JustWarn = false;
6030 
6031     unsigned DiagID = JustWarn ? diag::warn_attribute_dll_redeclaration
6032                                : diag::err_attribute_dll_redeclaration;
6033     S.Diag(NewDecl->getLocation(), DiagID)
6034         << NewDecl
6035         << (NewImportAttr ? (const Attr *)NewImportAttr : NewExportAttr);
6036     S.Diag(OldDecl->getLocation(), diag::note_previous_declaration);
6037     if (!JustWarn) {
6038       NewDecl->setInvalidDecl();
6039       return;
6040     }
6041   }
6042 
6043   // A redeclaration is not allowed to drop a dllimport attribute, the only
6044   // exceptions being inline function definitions (except for function
6045   // templates), local extern declarations, qualified friend declarations or
6046   // special MSVC extension: in the last case, the declaration is treated as if
6047   // it were marked dllexport.
6048   bool IsInline = false, IsStaticDataMember = false, IsQualifiedFriend = false;
6049   bool IsMicrosoft = S.Context.getTargetInfo().getCXXABI().isMicrosoft();
6050   if (const auto *VD = dyn_cast<VarDecl>(NewDecl)) {
6051     // Ignore static data because out-of-line definitions are diagnosed
6052     // separately.
6053     IsStaticDataMember = VD->isStaticDataMember();
6054     IsDefinition = VD->isThisDeclarationADefinition(S.Context) !=
6055                    VarDecl::DeclarationOnly;
6056   } else if (const auto *FD = dyn_cast<FunctionDecl>(NewDecl)) {
6057     IsInline = FD->isInlined();
6058     IsQualifiedFriend = FD->getQualifier() &&
6059                         FD->getFriendObjectKind() == Decl::FOK_Declared;
6060   }
6061 
6062   if (OldImportAttr && !HasNewAttr &&
6063       (!IsInline || (IsMicrosoft && IsTemplate)) && !IsStaticDataMember &&
6064       !NewDecl->isLocalExternDecl() && !IsQualifiedFriend) {
6065     if (IsMicrosoft && IsDefinition) {
6066       S.Diag(NewDecl->getLocation(),
6067              diag::warn_redeclaration_without_import_attribute)
6068           << NewDecl;
6069       S.Diag(OldDecl->getLocation(), diag::note_previous_declaration);
6070       NewDecl->dropAttr<DLLImportAttr>();
6071       NewDecl->addAttr(::new (S.Context) DLLExportAttr(
6072           NewImportAttr->getRange(), S.Context,
6073           NewImportAttr->getSpellingListIndex()));
6074     } else {
6075       S.Diag(NewDecl->getLocation(),
6076              diag::warn_redeclaration_without_attribute_prev_attribute_ignored)
6077           << NewDecl << OldImportAttr;
6078       S.Diag(OldDecl->getLocation(), diag::note_previous_declaration);
6079       S.Diag(OldImportAttr->getLocation(), diag::note_previous_attribute);
6080       OldDecl->dropAttr<DLLImportAttr>();
6081       NewDecl->dropAttr<DLLImportAttr>();
6082     }
6083   } else if (IsInline && OldImportAttr && !IsMicrosoft) {
6084     // In MinGW, seeing a function declared inline drops the dllimport attribute.
6085     OldDecl->dropAttr<DLLImportAttr>();
6086     NewDecl->dropAttr<DLLImportAttr>();
6087     S.Diag(NewDecl->getLocation(),
6088            diag::warn_dllimport_dropped_from_inline_function)
6089         << NewDecl << OldImportAttr;
6090   }
6091 
6092   // A specialization of a class template member function is processed here
6093   // since it's a redeclaration. If the parent class is dllexport, the
6094   // specialization inherits that attribute. This doesn't happen automatically
6095   // since the parent class isn't instantiated until later.
6096   if (const CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(NewDecl)) {
6097     if (MD->getTemplatedKind() == FunctionDecl::TK_MemberSpecialization &&
6098         !NewImportAttr && !NewExportAttr) {
6099       if (const DLLExportAttr *ParentExportAttr =
6100               MD->getParent()->getAttr<DLLExportAttr>()) {
6101         DLLExportAttr *NewAttr = ParentExportAttr->clone(S.Context);
6102         NewAttr->setInherited(true);
6103         NewDecl->addAttr(NewAttr);
6104       }
6105     }
6106   }
6107 }
6108 
6109 /// Given that we are within the definition of the given function,
6110 /// will that definition behave like C99's 'inline', where the
6111 /// definition is discarded except for optimization purposes?
6112 static bool isFunctionDefinitionDiscarded(Sema &S, FunctionDecl *FD) {
6113   // Try to avoid calling GetGVALinkageForFunction.
6114 
6115   // All cases of this require the 'inline' keyword.
6116   if (!FD->isInlined()) return false;
6117 
6118   // This is only possible in C++ with the gnu_inline attribute.
6119   if (S.getLangOpts().CPlusPlus && !FD->hasAttr<GNUInlineAttr>())
6120     return false;
6121 
6122   // Okay, go ahead and call the relatively-more-expensive function.
6123   return S.Context.GetGVALinkageForFunction(FD) == GVA_AvailableExternally;
6124 }
6125 
6126 /// Determine whether a variable is extern "C" prior to attaching
6127 /// an initializer. We can't just call isExternC() here, because that
6128 /// will also compute and cache whether the declaration is externally
6129 /// visible, which might change when we attach the initializer.
6130 ///
6131 /// This can only be used if the declaration is known to not be a
6132 /// redeclaration of an internal linkage declaration.
6133 ///
6134 /// For instance:
6135 ///
6136 ///   auto x = []{};
6137 ///
6138 /// Attaching the initializer here makes this declaration not externally
6139 /// visible, because its type has internal linkage.
6140 ///
6141 /// FIXME: This is a hack.
6142 template<typename T>
6143 static bool isIncompleteDeclExternC(Sema &S, const T *D) {
6144   if (S.getLangOpts().CPlusPlus) {
6145     // In C++, the overloadable attribute negates the effects of extern "C".
6146     if (!D->isInExternCContext() || D->template hasAttr<OverloadableAttr>())
6147       return false;
6148 
6149     // So do CUDA's host/device attributes.
6150     if (S.getLangOpts().CUDA && (D->template hasAttr<CUDADeviceAttr>() ||
6151                                  D->template hasAttr<CUDAHostAttr>()))
6152       return false;
6153   }
6154   return D->isExternC();
6155 }
6156 
6157 static bool shouldConsiderLinkage(const VarDecl *VD) {
6158   const DeclContext *DC = VD->getDeclContext()->getRedeclContext();
6159   if (DC->isFunctionOrMethod() || isa<OMPDeclareReductionDecl>(DC))
6160     return VD->hasExternalStorage();
6161   if (DC->isFileContext())
6162     return true;
6163   if (DC->isRecord())
6164     return false;
6165   llvm_unreachable("Unexpected context");
6166 }
6167 
6168 static bool shouldConsiderLinkage(const FunctionDecl *FD) {
6169   const DeclContext *DC = FD->getDeclContext()->getRedeclContext();
6170   if (DC->isFileContext() || DC->isFunctionOrMethod() ||
6171       isa<OMPDeclareReductionDecl>(DC))
6172     return true;
6173   if (DC->isRecord())
6174     return false;
6175   llvm_unreachable("Unexpected context");
6176 }
6177 
6178 static bool hasParsedAttr(Scope *S, const AttributeList *AttrList,
6179                           AttributeList::Kind Kind) {
6180   for (const AttributeList *L = AttrList; L; L = L->getNext())
6181     if (L->getKind() == Kind)
6182       return true;
6183   return false;
6184 }
6185 
6186 static bool hasParsedAttr(Scope *S, const Declarator &PD,
6187                           AttributeList::Kind Kind) {
6188   // Check decl attributes on the DeclSpec.
6189   if (hasParsedAttr(S, PD.getDeclSpec().getAttributes().getList(), Kind))
6190     return true;
6191 
6192   // Walk the declarator structure, checking decl attributes that were in a type
6193   // position to the decl itself.
6194   for (unsigned I = 0, E = PD.getNumTypeObjects(); I != E; ++I) {
6195     if (hasParsedAttr(S, PD.getTypeObject(I).getAttrs(), Kind))
6196       return true;
6197   }
6198 
6199   // Finally, check attributes on the decl itself.
6200   return hasParsedAttr(S, PD.getAttributes(), Kind);
6201 }
6202 
6203 /// Adjust the \c DeclContext for a function or variable that might be a
6204 /// function-local external declaration.
6205 bool Sema::adjustContextForLocalExternDecl(DeclContext *&DC) {
6206   if (!DC->isFunctionOrMethod())
6207     return false;
6208 
6209   // If this is a local extern function or variable declared within a function
6210   // template, don't add it into the enclosing namespace scope until it is
6211   // instantiated; it might have a dependent type right now.
6212   if (DC->isDependentContext())
6213     return true;
6214 
6215   // C++11 [basic.link]p7:
6216   //   When a block scope declaration of an entity with linkage is not found to
6217   //   refer to some other declaration, then that entity is a member of the
6218   //   innermost enclosing namespace.
6219   //
6220   // Per C++11 [namespace.def]p6, the innermost enclosing namespace is a
6221   // semantically-enclosing namespace, not a lexically-enclosing one.
6222   while (!DC->isFileContext() && !isa<LinkageSpecDecl>(DC))
6223     DC = DC->getParent();
6224   return true;
6225 }
6226 
6227 /// \brief Returns true if given declaration has external C language linkage.
6228 static bool isDeclExternC(const Decl *D) {
6229   if (const auto *FD = dyn_cast<FunctionDecl>(D))
6230     return FD->isExternC();
6231   if (const auto *VD = dyn_cast<VarDecl>(D))
6232     return VD->isExternC();
6233 
6234   llvm_unreachable("Unknown type of decl!");
6235 }
6236 
6237 NamedDecl *Sema::ActOnVariableDeclarator(
6238     Scope *S, Declarator &D, DeclContext *DC, TypeSourceInfo *TInfo,
6239     LookupResult &Previous, MultiTemplateParamsArg TemplateParamLists,
6240     bool &AddToScope, ArrayRef<BindingDecl *> Bindings) {
6241   QualType R = TInfo->getType();
6242   DeclarationName Name = GetNameForDeclarator(D).getName();
6243 
6244   IdentifierInfo *II = Name.getAsIdentifierInfo();
6245 
6246   if (D.isDecompositionDeclarator()) {
6247     // Take the name of the first declarator as our name for diagnostic
6248     // purposes.
6249     auto &Decomp = D.getDecompositionDeclarator();
6250     if (!Decomp.bindings().empty()) {
6251       II = Decomp.bindings()[0].Name;
6252       Name = II;
6253     }
6254   } else if (!II) {
6255     Diag(D.getIdentifierLoc(), diag::err_bad_variable_name) << Name;
6256     return nullptr;
6257   }
6258 
6259   if (getLangOpts().OpenCL) {
6260     // OpenCL v2.0 s6.9.b - Image type can only be used as a function argument.
6261     // OpenCL v2.0 s6.13.16.1 - Pipe type can only be used as a function
6262     // argument.
6263     if (R->isImageType() || R->isPipeType()) {
6264       Diag(D.getIdentifierLoc(),
6265            diag::err_opencl_type_can_only_be_used_as_function_parameter)
6266           << R;
6267       D.setInvalidType();
6268       return nullptr;
6269     }
6270 
6271     // OpenCL v1.2 s6.9.r:
6272     // The event type cannot be used to declare a program scope variable.
6273     // OpenCL v2.0 s6.9.q:
6274     // The clk_event_t and reserve_id_t types cannot be declared in program scope.
6275     if (NULL == S->getParent()) {
6276       if (R->isReserveIDT() || R->isClkEventT() || R->isEventT()) {
6277         Diag(D.getIdentifierLoc(),
6278              diag::err_invalid_type_for_program_scope_var) << R;
6279         D.setInvalidType();
6280         return nullptr;
6281       }
6282     }
6283 
6284     // OpenCL v1.0 s6.8.a.3: Pointers to functions are not allowed.
6285     QualType NR = R;
6286     while (NR->isPointerType()) {
6287       if (NR->isFunctionPointerType()) {
6288         Diag(D.getIdentifierLoc(), diag::err_opencl_function_pointer);
6289         D.setInvalidType();
6290         break;
6291       }
6292       NR = NR->getPointeeType();
6293     }
6294 
6295     if (!getOpenCLOptions().isEnabled("cl_khr_fp16")) {
6296       // OpenCL v1.2 s6.1.1.1: reject declaring variables of the half and
6297       // half array type (unless the cl_khr_fp16 extension is enabled).
6298       if (Context.getBaseElementType(R)->isHalfType()) {
6299         Diag(D.getIdentifierLoc(), diag::err_opencl_half_declaration) << R;
6300         D.setInvalidType();
6301       }
6302     }
6303 
6304     if (R->isSamplerT()) {
6305       // OpenCL v1.2 s6.9.b p4:
6306       // The sampler type cannot be used with the __local and __global address
6307       // space qualifiers.
6308       if (R.getAddressSpace() == LangAS::opencl_local ||
6309           R.getAddressSpace() == LangAS::opencl_global) {
6310         Diag(D.getIdentifierLoc(), diag::err_wrong_sampler_addressspace);
6311       }
6312 
6313       // OpenCL v1.2 s6.12.14.1:
6314       // A global sampler must be declared with either the constant address
6315       // space qualifier or with the const qualifier.
6316       if (DC->isTranslationUnit() &&
6317           !(R.getAddressSpace() == LangAS::opencl_constant ||
6318           R.isConstQualified())) {
6319         Diag(D.getIdentifierLoc(), diag::err_opencl_nonconst_global_sampler);
6320         D.setInvalidType();
6321       }
6322     }
6323 
6324     // OpenCL v1.2 s6.9.r:
6325     // The event type cannot be used with the __local, __constant and __global
6326     // address space qualifiers.
6327     if (R->isEventT()) {
6328       if (R.getAddressSpace() != LangAS::opencl_private) {
6329         Diag(D.getLocStart(), diag::err_event_t_addr_space_qual);
6330         D.setInvalidType();
6331       }
6332     }
6333   }
6334 
6335   DeclSpec::SCS SCSpec = D.getDeclSpec().getStorageClassSpec();
6336   StorageClass SC = StorageClassSpecToVarDeclStorageClass(D.getDeclSpec());
6337 
6338   // dllimport globals without explicit storage class are treated as extern. We
6339   // have to change the storage class this early to get the right DeclContext.
6340   if (SC == SC_None && !DC->isRecord() &&
6341       hasParsedAttr(S, D, AttributeList::AT_DLLImport) &&
6342       !hasParsedAttr(S, D, AttributeList::AT_DLLExport))
6343     SC = SC_Extern;
6344 
6345   DeclContext *OriginalDC = DC;
6346   bool IsLocalExternDecl = SC == SC_Extern &&
6347                            adjustContextForLocalExternDecl(DC);
6348 
6349   if (SCSpec == DeclSpec::SCS_mutable) {
6350     // mutable can only appear on non-static class members, so it's always
6351     // an error here
6352     Diag(D.getIdentifierLoc(), diag::err_mutable_nonmember);
6353     D.setInvalidType();
6354     SC = SC_None;
6355   }
6356 
6357   if (getLangOpts().CPlusPlus11 && SCSpec == DeclSpec::SCS_register &&
6358       !D.getAsmLabel() && !getSourceManager().isInSystemMacro(
6359                               D.getDeclSpec().getStorageClassSpecLoc())) {
6360     // In C++11, the 'register' storage class specifier is deprecated.
6361     // Suppress the warning in system macros, it's used in macros in some
6362     // popular C system headers, such as in glibc's htonl() macro.
6363     Diag(D.getDeclSpec().getStorageClassSpecLoc(),
6364          getLangOpts().CPlusPlus1z ? diag::ext_register_storage_class
6365                                    : diag::warn_deprecated_register)
6366       << FixItHint::CreateRemoval(D.getDeclSpec().getStorageClassSpecLoc());
6367   }
6368 
6369   DiagnoseFunctionSpecifiers(D.getDeclSpec());
6370 
6371   if (!DC->isRecord() && S->getFnParent() == nullptr) {
6372     // C99 6.9p2: The storage-class specifiers auto and register shall not
6373     // appear in the declaration specifiers in an external declaration.
6374     // Global Register+Asm is a GNU extension we support.
6375     if (SC == SC_Auto || (SC == SC_Register && !D.getAsmLabel())) {
6376       Diag(D.getIdentifierLoc(), diag::err_typecheck_sclass_fscope);
6377       D.setInvalidType();
6378     }
6379   }
6380 
6381   bool IsMemberSpecialization = false;
6382   bool IsVariableTemplateSpecialization = false;
6383   bool IsPartialSpecialization = false;
6384   bool IsVariableTemplate = false;
6385   VarDecl *NewVD = nullptr;
6386   VarTemplateDecl *NewTemplate = nullptr;
6387   TemplateParameterList *TemplateParams = nullptr;
6388   if (!getLangOpts().CPlusPlus) {
6389     NewVD = VarDecl::Create(Context, DC, D.getLocStart(),
6390                             D.getIdentifierLoc(), II,
6391                             R, TInfo, SC);
6392 
6393     if (R->getContainedDeducedType())
6394       ParsingInitForAutoVars.insert(NewVD);
6395 
6396     if (D.isInvalidType())
6397       NewVD->setInvalidDecl();
6398   } else {
6399     bool Invalid = false;
6400 
6401     if (DC->isRecord() && !CurContext->isRecord()) {
6402       // This is an out-of-line definition of a static data member.
6403       switch (SC) {
6404       case SC_None:
6405         break;
6406       case SC_Static:
6407         Diag(D.getDeclSpec().getStorageClassSpecLoc(),
6408              diag::err_static_out_of_line)
6409           << FixItHint::CreateRemoval(D.getDeclSpec().getStorageClassSpecLoc());
6410         break;
6411       case SC_Auto:
6412       case SC_Register:
6413       case SC_Extern:
6414         // [dcl.stc] p2: The auto or register specifiers shall be applied only
6415         // to names of variables declared in a block or to function parameters.
6416         // [dcl.stc] p6: The extern specifier cannot be used in the declaration
6417         // of class members
6418 
6419         Diag(D.getDeclSpec().getStorageClassSpecLoc(),
6420              diag::err_storage_class_for_static_member)
6421           << FixItHint::CreateRemoval(D.getDeclSpec().getStorageClassSpecLoc());
6422         break;
6423       case SC_PrivateExtern:
6424         llvm_unreachable("C storage class in c++!");
6425       }
6426     }
6427 
6428     if (SC == SC_Static && CurContext->isRecord()) {
6429       if (const CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(DC)) {
6430         if (RD->isLocalClass())
6431           Diag(D.getIdentifierLoc(),
6432                diag::err_static_data_member_not_allowed_in_local_class)
6433             << Name << RD->getDeclName();
6434 
6435         // C++98 [class.union]p1: If a union contains a static data member,
6436         // the program is ill-formed. C++11 drops this restriction.
6437         if (RD->isUnion())
6438           Diag(D.getIdentifierLoc(),
6439                getLangOpts().CPlusPlus11
6440                  ? diag::warn_cxx98_compat_static_data_member_in_union
6441                  : diag::ext_static_data_member_in_union) << Name;
6442         // We conservatively disallow static data members in anonymous structs.
6443         else if (!RD->getDeclName())
6444           Diag(D.getIdentifierLoc(),
6445                diag::err_static_data_member_not_allowed_in_anon_struct)
6446             << Name << RD->isUnion();
6447       }
6448     }
6449 
6450     // Match up the template parameter lists with the scope specifier, then
6451     // determine whether we have a template or a template specialization.
6452     TemplateParams = MatchTemplateParametersToScopeSpecifier(
6453         D.getDeclSpec().getLocStart(), D.getIdentifierLoc(),
6454         D.getCXXScopeSpec(),
6455         D.getName().getKind() == UnqualifiedId::IK_TemplateId
6456             ? D.getName().TemplateId
6457             : nullptr,
6458         TemplateParamLists,
6459         /*never a friend*/ false, IsMemberSpecialization, Invalid);
6460 
6461     if (TemplateParams) {
6462       if (!TemplateParams->size() &&
6463           D.getName().getKind() != UnqualifiedId::IK_TemplateId) {
6464         // There is an extraneous 'template<>' for this variable. Complain
6465         // about it, but allow the declaration of the variable.
6466         Diag(TemplateParams->getTemplateLoc(),
6467              diag::err_template_variable_noparams)
6468           << II
6469           << SourceRange(TemplateParams->getTemplateLoc(),
6470                          TemplateParams->getRAngleLoc());
6471         TemplateParams = nullptr;
6472       } else {
6473         if (D.getName().getKind() == UnqualifiedId::IK_TemplateId) {
6474           // This is an explicit specialization or a partial specialization.
6475           // FIXME: Check that we can declare a specialization here.
6476           IsVariableTemplateSpecialization = true;
6477           IsPartialSpecialization = TemplateParams->size() > 0;
6478         } else { // if (TemplateParams->size() > 0)
6479           // This is a template declaration.
6480           IsVariableTemplate = true;
6481 
6482           // Check that we can declare a template here.
6483           if (CheckTemplateDeclScope(S, TemplateParams))
6484             return nullptr;
6485 
6486           // Only C++1y supports variable templates (N3651).
6487           Diag(D.getIdentifierLoc(),
6488                getLangOpts().CPlusPlus14
6489                    ? diag::warn_cxx11_compat_variable_template
6490                    : diag::ext_variable_template);
6491         }
6492       }
6493     } else {
6494       assert(
6495           (Invalid || D.getName().getKind() != UnqualifiedId::IK_TemplateId) &&
6496           "should have a 'template<>' for this decl");
6497     }
6498 
6499     if (IsVariableTemplateSpecialization) {
6500       SourceLocation TemplateKWLoc =
6501           TemplateParamLists.size() > 0
6502               ? TemplateParamLists[0]->getTemplateLoc()
6503               : SourceLocation();
6504       DeclResult Res = ActOnVarTemplateSpecialization(
6505           S, D, TInfo, TemplateKWLoc, TemplateParams, SC,
6506           IsPartialSpecialization);
6507       if (Res.isInvalid())
6508         return nullptr;
6509       NewVD = cast<VarDecl>(Res.get());
6510       AddToScope = false;
6511     } else if (D.isDecompositionDeclarator()) {
6512       NewVD = DecompositionDecl::Create(Context, DC, D.getLocStart(),
6513                                         D.getIdentifierLoc(), R, TInfo, SC,
6514                                         Bindings);
6515     } else
6516       NewVD = VarDecl::Create(Context, DC, D.getLocStart(),
6517                               D.getIdentifierLoc(), II, R, TInfo, SC);
6518 
6519     // If this is supposed to be a variable template, create it as such.
6520     if (IsVariableTemplate) {
6521       NewTemplate =
6522           VarTemplateDecl::Create(Context, DC, D.getIdentifierLoc(), Name,
6523                                   TemplateParams, NewVD);
6524       NewVD->setDescribedVarTemplate(NewTemplate);
6525     }
6526 
6527     // If this decl has an auto type in need of deduction, make a note of the
6528     // Decl so we can diagnose uses of it in its own initializer.
6529     if (R->getContainedDeducedType())
6530       ParsingInitForAutoVars.insert(NewVD);
6531 
6532     if (D.isInvalidType() || Invalid) {
6533       NewVD->setInvalidDecl();
6534       if (NewTemplate)
6535         NewTemplate->setInvalidDecl();
6536     }
6537 
6538     SetNestedNameSpecifier(NewVD, D);
6539 
6540     // If we have any template parameter lists that don't directly belong to
6541     // the variable (matching the scope specifier), store them.
6542     unsigned VDTemplateParamLists = TemplateParams ? 1 : 0;
6543     if (TemplateParamLists.size() > VDTemplateParamLists)
6544       NewVD->setTemplateParameterListsInfo(
6545           Context, TemplateParamLists.drop_back(VDTemplateParamLists));
6546 
6547     if (D.getDeclSpec().isConstexprSpecified()) {
6548       NewVD->setConstexpr(true);
6549       // C++1z [dcl.spec.constexpr]p1:
6550       //   A static data member declared with the constexpr specifier is
6551       //   implicitly an inline variable.
6552       if (NewVD->isStaticDataMember() && getLangOpts().CPlusPlus1z)
6553         NewVD->setImplicitlyInline();
6554     }
6555 
6556     if (D.getDeclSpec().isConceptSpecified()) {
6557       if (VarTemplateDecl *VTD = NewVD->getDescribedVarTemplate())
6558         VTD->setConcept();
6559 
6560       // C++ Concepts TS [dcl.spec.concept]p2: A concept definition shall not
6561       // be declared with the thread_local, inline, friend, or constexpr
6562       // specifiers, [...]
6563       if (D.getDeclSpec().getThreadStorageClassSpec() == TSCS_thread_local) {
6564         Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
6565              diag::err_concept_decl_invalid_specifiers)
6566             << 0 << 0;
6567         NewVD->setInvalidDecl(true);
6568       }
6569 
6570       if (D.getDeclSpec().isConstexprSpecified()) {
6571         Diag(D.getDeclSpec().getConstexprSpecLoc(),
6572              diag::err_concept_decl_invalid_specifiers)
6573             << 0 << 3;
6574         NewVD->setInvalidDecl(true);
6575       }
6576 
6577       // C++ Concepts TS [dcl.spec.concept]p1: The concept specifier shall be
6578       // applied only to the definition of a function template or variable
6579       // template, declared in namespace scope.
6580       if (IsVariableTemplateSpecialization) {
6581         Diag(D.getDeclSpec().getConceptSpecLoc(),
6582              diag::err_concept_specified_specialization)
6583             << (IsPartialSpecialization ? 2 : 1);
6584       }
6585 
6586       // C++ Concepts TS [dcl.spec.concept]p6: A variable concept has the
6587       // following restrictions:
6588       // - The declared type shall have the type bool.
6589       if (!Context.hasSameType(NewVD->getType(), Context.BoolTy) &&
6590           !NewVD->isInvalidDecl()) {
6591         Diag(D.getIdentifierLoc(), diag::err_variable_concept_bool_decl);
6592         NewVD->setInvalidDecl(true);
6593       }
6594     }
6595   }
6596 
6597   if (D.getDeclSpec().isInlineSpecified()) {
6598     if (!getLangOpts().CPlusPlus) {
6599       Diag(D.getDeclSpec().getInlineSpecLoc(), diag::err_inline_non_function)
6600           << 0;
6601     } else if (CurContext->isFunctionOrMethod()) {
6602       // 'inline' is not allowed on block scope variable declaration.
6603       Diag(D.getDeclSpec().getInlineSpecLoc(),
6604            diag::err_inline_declaration_block_scope) << Name
6605         << FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
6606     } else {
6607       Diag(D.getDeclSpec().getInlineSpecLoc(),
6608            getLangOpts().CPlusPlus1z ? diag::warn_cxx14_compat_inline_variable
6609                                      : diag::ext_inline_variable);
6610       NewVD->setInlineSpecified();
6611     }
6612   }
6613 
6614   // Set the lexical context. If the declarator has a C++ scope specifier, the
6615   // lexical context will be different from the semantic context.
6616   NewVD->setLexicalDeclContext(CurContext);
6617   if (NewTemplate)
6618     NewTemplate->setLexicalDeclContext(CurContext);
6619 
6620   if (IsLocalExternDecl) {
6621     if (D.isDecompositionDeclarator())
6622       for (auto *B : Bindings)
6623         B->setLocalExternDecl();
6624     else
6625       NewVD->setLocalExternDecl();
6626   }
6627 
6628   bool EmitTLSUnsupportedError = false;
6629   if (DeclSpec::TSCS TSCS = D.getDeclSpec().getThreadStorageClassSpec()) {
6630     // C++11 [dcl.stc]p4:
6631     //   When thread_local is applied to a variable of block scope the
6632     //   storage-class-specifier static is implied if it does not appear
6633     //   explicitly.
6634     // Core issue: 'static' is not implied if the variable is declared
6635     //   'extern'.
6636     if (NewVD->hasLocalStorage() &&
6637         (SCSpec != DeclSpec::SCS_unspecified ||
6638          TSCS != DeclSpec::TSCS_thread_local ||
6639          !DC->isFunctionOrMethod()))
6640       Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
6641            diag::err_thread_non_global)
6642         << DeclSpec::getSpecifierName(TSCS);
6643     else if (!Context.getTargetInfo().isTLSSupported()) {
6644       if (getLangOpts().CUDA || getLangOpts().OpenMPIsDevice) {
6645         // Postpone error emission until we've collected attributes required to
6646         // figure out whether it's a host or device variable and whether the
6647         // error should be ignored.
6648         EmitTLSUnsupportedError = true;
6649         // We still need to mark the variable as TLS so it shows up in AST with
6650         // proper storage class for other tools to use even if we're not going
6651         // to emit any code for it.
6652         NewVD->setTSCSpec(TSCS);
6653       } else
6654         Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
6655              diag::err_thread_unsupported);
6656     } else
6657       NewVD->setTSCSpec(TSCS);
6658   }
6659 
6660   // C99 6.7.4p3
6661   //   An inline definition of a function with external linkage shall
6662   //   not contain a definition of a modifiable object with static or
6663   //   thread storage duration...
6664   // We only apply this when the function is required to be defined
6665   // elsewhere, i.e. when the function is not 'extern inline'.  Note
6666   // that a local variable with thread storage duration still has to
6667   // be marked 'static'.  Also note that it's possible to get these
6668   // semantics in C++ using __attribute__((gnu_inline)).
6669   if (SC == SC_Static && S->getFnParent() != nullptr &&
6670       !NewVD->getType().isConstQualified()) {
6671     FunctionDecl *CurFD = getCurFunctionDecl();
6672     if (CurFD && isFunctionDefinitionDiscarded(*this, CurFD)) {
6673       Diag(D.getDeclSpec().getStorageClassSpecLoc(),
6674            diag::warn_static_local_in_extern_inline);
6675       MaybeSuggestAddingStaticToDecl(CurFD);
6676     }
6677   }
6678 
6679   if (D.getDeclSpec().isModulePrivateSpecified()) {
6680     if (IsVariableTemplateSpecialization)
6681       Diag(NewVD->getLocation(), diag::err_module_private_specialization)
6682           << (IsPartialSpecialization ? 1 : 0)
6683           << FixItHint::CreateRemoval(
6684                  D.getDeclSpec().getModulePrivateSpecLoc());
6685     else if (IsMemberSpecialization)
6686       Diag(NewVD->getLocation(), diag::err_module_private_specialization)
6687         << 2
6688         << FixItHint::CreateRemoval(D.getDeclSpec().getModulePrivateSpecLoc());
6689     else if (NewVD->hasLocalStorage())
6690       Diag(NewVD->getLocation(), diag::err_module_private_local)
6691         << 0 << NewVD->getDeclName()
6692         << SourceRange(D.getDeclSpec().getModulePrivateSpecLoc())
6693         << FixItHint::CreateRemoval(D.getDeclSpec().getModulePrivateSpecLoc());
6694     else {
6695       NewVD->setModulePrivate();
6696       if (NewTemplate)
6697         NewTemplate->setModulePrivate();
6698       for (auto *B : Bindings)
6699         B->setModulePrivate();
6700     }
6701   }
6702 
6703   // Handle attributes prior to checking for duplicates in MergeVarDecl
6704   ProcessDeclAttributes(S, NewVD, D);
6705 
6706   if (getLangOpts().CUDA || getLangOpts().OpenMPIsDevice) {
6707     if (EmitTLSUnsupportedError &&
6708         ((getLangOpts().CUDA && DeclAttrsMatchCUDAMode(getLangOpts(), NewVD)) ||
6709          (getLangOpts().OpenMPIsDevice &&
6710           NewVD->hasAttr<OMPDeclareTargetDeclAttr>())))
6711       Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
6712            diag::err_thread_unsupported);
6713     // CUDA B.2.5: "__shared__ and __constant__ variables have implied static
6714     // storage [duration]."
6715     if (SC == SC_None && S->getFnParent() != nullptr &&
6716         (NewVD->hasAttr<CUDASharedAttr>() ||
6717          NewVD->hasAttr<CUDAConstantAttr>())) {
6718       NewVD->setStorageClass(SC_Static);
6719     }
6720   }
6721 
6722   // Ensure that dllimport globals without explicit storage class are treated as
6723   // extern. The storage class is set above using parsed attributes. Now we can
6724   // check the VarDecl itself.
6725   assert(!NewVD->hasAttr<DLLImportAttr>() ||
6726          NewVD->getAttr<DLLImportAttr>()->isInherited() ||
6727          NewVD->isStaticDataMember() || NewVD->getStorageClass() != SC_None);
6728 
6729   // In auto-retain/release, infer strong retension for variables of
6730   // retainable type.
6731   if (getLangOpts().ObjCAutoRefCount && inferObjCARCLifetime(NewVD))
6732     NewVD->setInvalidDecl();
6733 
6734   // Handle GNU asm-label extension (encoded as an attribute).
6735   if (Expr *E = (Expr*)D.getAsmLabel()) {
6736     // The parser guarantees this is a string.
6737     StringLiteral *SE = cast<StringLiteral>(E);
6738     StringRef Label = SE->getString();
6739     if (S->getFnParent() != nullptr) {
6740       switch (SC) {
6741       case SC_None:
6742       case SC_Auto:
6743         Diag(E->getExprLoc(), diag::warn_asm_label_on_auto_decl) << Label;
6744         break;
6745       case SC_Register:
6746         // Local Named register
6747         if (!Context.getTargetInfo().isValidGCCRegisterName(Label) &&
6748             DeclAttrsMatchCUDAMode(getLangOpts(), getCurFunctionDecl()))
6749           Diag(E->getExprLoc(), diag::err_asm_unknown_register_name) << Label;
6750         break;
6751       case SC_Static:
6752       case SC_Extern:
6753       case SC_PrivateExtern:
6754         break;
6755       }
6756     } else if (SC == SC_Register) {
6757       // Global Named register
6758       if (DeclAttrsMatchCUDAMode(getLangOpts(), NewVD)) {
6759         const auto &TI = Context.getTargetInfo();
6760         bool HasSizeMismatch;
6761 
6762         if (!TI.isValidGCCRegisterName(Label))
6763           Diag(E->getExprLoc(), diag::err_asm_unknown_register_name) << Label;
6764         else if (!TI.validateGlobalRegisterVariable(Label,
6765                                                     Context.getTypeSize(R),
6766                                                     HasSizeMismatch))
6767           Diag(E->getExprLoc(), diag::err_asm_invalid_global_var_reg) << Label;
6768         else if (HasSizeMismatch)
6769           Diag(E->getExprLoc(), diag::err_asm_register_size_mismatch) << Label;
6770       }
6771 
6772       if (!R->isIntegralType(Context) && !R->isPointerType()) {
6773         Diag(D.getLocStart(), diag::err_asm_bad_register_type);
6774         NewVD->setInvalidDecl(true);
6775       }
6776     }
6777 
6778     NewVD->addAttr(::new (Context) AsmLabelAttr(SE->getStrTokenLoc(0),
6779                                                 Context, Label, 0));
6780   } else if (!ExtnameUndeclaredIdentifiers.empty()) {
6781     llvm::DenseMap<IdentifierInfo*,AsmLabelAttr*>::iterator I =
6782       ExtnameUndeclaredIdentifiers.find(NewVD->getIdentifier());
6783     if (I != ExtnameUndeclaredIdentifiers.end()) {
6784       if (isDeclExternC(NewVD)) {
6785         NewVD->addAttr(I->second);
6786         ExtnameUndeclaredIdentifiers.erase(I);
6787       } else
6788         Diag(NewVD->getLocation(), diag::warn_redefine_extname_not_applied)
6789             << /*Variable*/1 << NewVD;
6790     }
6791   }
6792 
6793   // Find the shadowed declaration before filtering for scope.
6794   NamedDecl *ShadowedDecl = D.getCXXScopeSpec().isEmpty()
6795                                 ? getShadowedDeclaration(NewVD, Previous)
6796                                 : nullptr;
6797 
6798   // Don't consider existing declarations that are in a different
6799   // scope and are out-of-semantic-context declarations (if the new
6800   // declaration has linkage).
6801   FilterLookupForScope(Previous, OriginalDC, S, shouldConsiderLinkage(NewVD),
6802                        D.getCXXScopeSpec().isNotEmpty() ||
6803                        IsMemberSpecialization ||
6804                        IsVariableTemplateSpecialization);
6805 
6806   // Check whether the previous declaration is in the same block scope. This
6807   // affects whether we merge types with it, per C++11 [dcl.array]p3.
6808   if (getLangOpts().CPlusPlus &&
6809       NewVD->isLocalVarDecl() && NewVD->hasExternalStorage())
6810     NewVD->setPreviousDeclInSameBlockScope(
6811         Previous.isSingleResult() && !Previous.isShadowed() &&
6812         isDeclInScope(Previous.getFoundDecl(), OriginalDC, S, false));
6813 
6814   if (!getLangOpts().CPlusPlus) {
6815     D.setRedeclaration(CheckVariableDeclaration(NewVD, Previous));
6816   } else {
6817     // If this is an explicit specialization of a static data member, check it.
6818     if (IsMemberSpecialization && !NewVD->isInvalidDecl() &&
6819         CheckMemberSpecialization(NewVD, Previous))
6820       NewVD->setInvalidDecl();
6821 
6822     // Merge the decl with the existing one if appropriate.
6823     if (!Previous.empty()) {
6824       if (Previous.isSingleResult() &&
6825           isa<FieldDecl>(Previous.getFoundDecl()) &&
6826           D.getCXXScopeSpec().isSet()) {
6827         // The user tried to define a non-static data member
6828         // out-of-line (C++ [dcl.meaning]p1).
6829         Diag(NewVD->getLocation(), diag::err_nonstatic_member_out_of_line)
6830           << D.getCXXScopeSpec().getRange();
6831         Previous.clear();
6832         NewVD->setInvalidDecl();
6833       }
6834     } else if (D.getCXXScopeSpec().isSet()) {
6835       // No previous declaration in the qualifying scope.
6836       Diag(D.getIdentifierLoc(), diag::err_no_member)
6837         << Name << computeDeclContext(D.getCXXScopeSpec(), true)
6838         << D.getCXXScopeSpec().getRange();
6839       NewVD->setInvalidDecl();
6840     }
6841 
6842     if (!IsVariableTemplateSpecialization)
6843       D.setRedeclaration(CheckVariableDeclaration(NewVD, Previous));
6844 
6845     // C++ Concepts TS [dcl.spec.concept]p7: A program shall not declare [...]
6846     // an explicit specialization (14.8.3) or a partial specialization of a
6847     // concept definition.
6848     if (IsVariableTemplateSpecialization &&
6849         !D.getDeclSpec().isConceptSpecified() && !Previous.empty() &&
6850         Previous.isSingleResult()) {
6851       NamedDecl *PreviousDecl = Previous.getFoundDecl();
6852       if (VarTemplateDecl *VarTmpl = dyn_cast<VarTemplateDecl>(PreviousDecl)) {
6853         if (VarTmpl->isConcept()) {
6854           Diag(NewVD->getLocation(), diag::err_concept_specialized)
6855               << 1                            /*variable*/
6856               << (IsPartialSpecialization ? 2 /*partially specialized*/
6857                                           : 1 /*explicitly specialized*/);
6858           Diag(VarTmpl->getLocation(), diag::note_previous_declaration);
6859           NewVD->setInvalidDecl();
6860         }
6861       }
6862     }
6863 
6864     if (NewTemplate) {
6865       VarTemplateDecl *PrevVarTemplate =
6866           NewVD->getPreviousDecl()
6867               ? NewVD->getPreviousDecl()->getDescribedVarTemplate()
6868               : nullptr;
6869 
6870       // Check the template parameter list of this declaration, possibly
6871       // merging in the template parameter list from the previous variable
6872       // template declaration.
6873       if (CheckTemplateParameterList(
6874               TemplateParams,
6875               PrevVarTemplate ? PrevVarTemplate->getTemplateParameters()
6876                               : nullptr,
6877               (D.getCXXScopeSpec().isSet() && DC && DC->isRecord() &&
6878                DC->isDependentContext())
6879                   ? TPC_ClassTemplateMember
6880                   : TPC_VarTemplate))
6881         NewVD->setInvalidDecl();
6882 
6883       // If we are providing an explicit specialization of a static variable
6884       // template, make a note of that.
6885       if (PrevVarTemplate &&
6886           PrevVarTemplate->getInstantiatedFromMemberTemplate())
6887         PrevVarTemplate->setMemberSpecialization();
6888     }
6889   }
6890 
6891   // Diagnose shadowed variables iff this isn't a redeclaration.
6892   if (ShadowedDecl && !D.isRedeclaration())
6893     CheckShadow(NewVD, ShadowedDecl, Previous);
6894 
6895   ProcessPragmaWeak(S, NewVD);
6896 
6897   // If this is the first declaration of an extern C variable, update
6898   // the map of such variables.
6899   if (NewVD->isFirstDecl() && !NewVD->isInvalidDecl() &&
6900       isIncompleteDeclExternC(*this, NewVD))
6901     RegisterLocallyScopedExternCDecl(NewVD, S);
6902 
6903   if (getLangOpts().CPlusPlus && NewVD->isStaticLocal()) {
6904     Decl *ManglingContextDecl;
6905     if (MangleNumberingContext *MCtx = getCurrentMangleNumberContext(
6906             NewVD->getDeclContext(), ManglingContextDecl)) {
6907       Context.setManglingNumber(
6908           NewVD, MCtx->getManglingNumber(
6909                      NewVD, getMSManglingNumber(getLangOpts(), S)));
6910       Context.setStaticLocalNumber(NewVD, MCtx->getStaticLocalNumber(NewVD));
6911     }
6912   }
6913 
6914   // Special handling of variable named 'main'.
6915   if (Name.getAsIdentifierInfo() && Name.getAsIdentifierInfo()->isStr("main") &&
6916       NewVD->getDeclContext()->getRedeclContext()->isTranslationUnit() &&
6917       !getLangOpts().Freestanding && !NewVD->getDescribedVarTemplate()) {
6918 
6919     // C++ [basic.start.main]p3
6920     // A program that declares a variable main at global scope is ill-formed.
6921     if (getLangOpts().CPlusPlus)
6922       Diag(D.getLocStart(), diag::err_main_global_variable);
6923 
6924     // In C, and external-linkage variable named main results in undefined
6925     // behavior.
6926     else if (NewVD->hasExternalFormalLinkage())
6927       Diag(D.getLocStart(), diag::warn_main_redefined);
6928   }
6929 
6930   if (D.isRedeclaration() && !Previous.empty()) {
6931     checkDLLAttributeRedeclaration(
6932         *this, dyn_cast<NamedDecl>(Previous.getRepresentativeDecl()), NewVD,
6933         IsMemberSpecialization, D.isFunctionDefinition());
6934   }
6935 
6936   if (NewTemplate) {
6937     if (NewVD->isInvalidDecl())
6938       NewTemplate->setInvalidDecl();
6939     ActOnDocumentableDecl(NewTemplate);
6940     return NewTemplate;
6941   }
6942 
6943   if (IsMemberSpecialization && !NewVD->isInvalidDecl())
6944     CompleteMemberSpecialization(NewVD, Previous);
6945 
6946   return NewVD;
6947 }
6948 
6949 /// Enum describing the %select options in diag::warn_decl_shadow.
6950 enum ShadowedDeclKind {
6951   SDK_Local,
6952   SDK_Global,
6953   SDK_StaticMember,
6954   SDK_Field,
6955   SDK_Typedef,
6956   SDK_Using
6957 };
6958 
6959 /// Determine what kind of declaration we're shadowing.
6960 static ShadowedDeclKind computeShadowedDeclKind(const NamedDecl *ShadowedDecl,
6961                                                 const DeclContext *OldDC) {
6962   if (isa<TypeAliasDecl>(ShadowedDecl))
6963     return SDK_Using;
6964   else if (isa<TypedefDecl>(ShadowedDecl))
6965     return SDK_Typedef;
6966   else if (isa<RecordDecl>(OldDC))
6967     return isa<FieldDecl>(ShadowedDecl) ? SDK_Field : SDK_StaticMember;
6968 
6969   return OldDC->isFileContext() ? SDK_Global : SDK_Local;
6970 }
6971 
6972 /// Return the location of the capture if the given lambda captures the given
6973 /// variable \p VD, or an invalid source location otherwise.
6974 static SourceLocation getCaptureLocation(const LambdaScopeInfo *LSI,
6975                                          const VarDecl *VD) {
6976   for (const LambdaScopeInfo::Capture &Capture : LSI->Captures) {
6977     if (Capture.isVariableCapture() && Capture.getVariable() == VD)
6978       return Capture.getLocation();
6979   }
6980   return SourceLocation();
6981 }
6982 
6983 static bool shouldWarnIfShadowedDecl(const DiagnosticsEngine &Diags,
6984                                      const LookupResult &R) {
6985   // Only diagnose if we're shadowing an unambiguous field or variable.
6986   if (R.getResultKind() != LookupResult::Found)
6987     return false;
6988 
6989   // Return false if warning is ignored.
6990   return !Diags.isIgnored(diag::warn_decl_shadow, R.getNameLoc());
6991 }
6992 
6993 /// \brief Return the declaration shadowed by the given variable \p D, or null
6994 /// if it doesn't shadow any declaration or shadowing warnings are disabled.
6995 NamedDecl *Sema::getShadowedDeclaration(const VarDecl *D,
6996                                         const LookupResult &R) {
6997   if (!shouldWarnIfShadowedDecl(Diags, R))
6998     return nullptr;
6999 
7000   // Don't diagnose declarations at file scope.
7001   if (D->hasGlobalStorage())
7002     return nullptr;
7003 
7004   NamedDecl *ShadowedDecl = R.getFoundDecl();
7005   return isa<VarDecl>(ShadowedDecl) || isa<FieldDecl>(ShadowedDecl)
7006              ? ShadowedDecl
7007              : nullptr;
7008 }
7009 
7010 /// \brief Return the declaration shadowed by the given typedef \p D, or null
7011 /// if it doesn't shadow any declaration or shadowing warnings are disabled.
7012 NamedDecl *Sema::getShadowedDeclaration(const TypedefNameDecl *D,
7013                                         const LookupResult &R) {
7014   // Don't warn if typedef declaration is part of a class
7015   if (D->getDeclContext()->isRecord())
7016     return nullptr;
7017 
7018   if (!shouldWarnIfShadowedDecl(Diags, R))
7019     return nullptr;
7020 
7021   NamedDecl *ShadowedDecl = R.getFoundDecl();
7022   return isa<TypedefNameDecl>(ShadowedDecl) ? ShadowedDecl : nullptr;
7023 }
7024 
7025 /// \brief Diagnose variable or built-in function shadowing.  Implements
7026 /// -Wshadow.
7027 ///
7028 /// This method is called whenever a VarDecl is added to a "useful"
7029 /// scope.
7030 ///
7031 /// \param ShadowedDecl the declaration that is shadowed by the given variable
7032 /// \param R the lookup of the name
7033 ///
7034 void Sema::CheckShadow(NamedDecl *D, NamedDecl *ShadowedDecl,
7035                        const LookupResult &R) {
7036   DeclContext *NewDC = D->getDeclContext();
7037 
7038   if (FieldDecl *FD = dyn_cast<FieldDecl>(ShadowedDecl)) {
7039     // Fields are not shadowed by variables in C++ static methods.
7040     if (CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(NewDC))
7041       if (MD->isStatic())
7042         return;
7043 
7044     // Fields shadowed by constructor parameters are a special case. Usually
7045     // the constructor initializes the field with the parameter.
7046     if (isa<CXXConstructorDecl>(NewDC))
7047       if (const auto PVD = dyn_cast<ParmVarDecl>(D)) {
7048         // Remember that this was shadowed so we can either warn about its
7049         // modification or its existence depending on warning settings.
7050         ShadowingDecls.insert({PVD->getCanonicalDecl(), FD});
7051         return;
7052       }
7053   }
7054 
7055   if (VarDecl *shadowedVar = dyn_cast<VarDecl>(ShadowedDecl))
7056     if (shadowedVar->isExternC()) {
7057       // For shadowing external vars, make sure that we point to the global
7058       // declaration, not a locally scoped extern declaration.
7059       for (auto I : shadowedVar->redecls())
7060         if (I->isFileVarDecl()) {
7061           ShadowedDecl = I;
7062           break;
7063         }
7064     }
7065 
7066   DeclContext *OldDC = ShadowedDecl->getDeclContext()->getRedeclContext();
7067 
7068   unsigned WarningDiag = diag::warn_decl_shadow;
7069   SourceLocation CaptureLoc;
7070   if (isa<VarDecl>(D) && isa<VarDecl>(ShadowedDecl) && NewDC &&
7071       isa<CXXMethodDecl>(NewDC)) {
7072     if (const auto *RD = dyn_cast<CXXRecordDecl>(NewDC->getParent())) {
7073       if (RD->isLambda() && OldDC->Encloses(NewDC->getLexicalParent())) {
7074         if (RD->getLambdaCaptureDefault() == LCD_None) {
7075           // Try to avoid warnings for lambdas with an explicit capture list.
7076           const auto *LSI = cast<LambdaScopeInfo>(getCurFunction());
7077           // Warn only when the lambda captures the shadowed decl explicitly.
7078           CaptureLoc = getCaptureLocation(LSI, cast<VarDecl>(ShadowedDecl));
7079           if (CaptureLoc.isInvalid())
7080             WarningDiag = diag::warn_decl_shadow_uncaptured_local;
7081         } else {
7082           // Remember that this was shadowed so we can avoid the warning if the
7083           // shadowed decl isn't captured and the warning settings allow it.
7084           cast<LambdaScopeInfo>(getCurFunction())
7085               ->ShadowingDecls.push_back(
7086                   {cast<VarDecl>(D), cast<VarDecl>(ShadowedDecl)});
7087           return;
7088         }
7089       }
7090 
7091       if (cast<VarDecl>(ShadowedDecl)->hasLocalStorage()) {
7092         // A variable can't shadow a local variable in an enclosing scope, if
7093         // they are separated by a non-capturing declaration context.
7094         for (DeclContext *ParentDC = NewDC;
7095              ParentDC && !ParentDC->Equals(OldDC);
7096              ParentDC = getLambdaAwareParentOfDeclContext(ParentDC)) {
7097           // Only block literals, captured statements, and lambda expressions
7098           // can capture; other scopes don't.
7099           if (!isa<BlockDecl>(ParentDC) && !isa<CapturedDecl>(ParentDC) &&
7100               !isLambdaCallOperator(ParentDC)) {
7101             return;
7102           }
7103         }
7104       }
7105     }
7106   }
7107 
7108   // Only warn about certain kinds of shadowing for class members.
7109   if (NewDC && NewDC->isRecord()) {
7110     // In particular, don't warn about shadowing non-class members.
7111     if (!OldDC->isRecord())
7112       return;
7113 
7114     // TODO: should we warn about static data members shadowing
7115     // static data members from base classes?
7116 
7117     // TODO: don't diagnose for inaccessible shadowed members.
7118     // This is hard to do perfectly because we might friend the
7119     // shadowing context, but that's just a false negative.
7120   }
7121 
7122 
7123   DeclarationName Name = R.getLookupName();
7124 
7125   // Emit warning and note.
7126   if (getSourceManager().isInSystemMacro(R.getNameLoc()))
7127     return;
7128   ShadowedDeclKind Kind = computeShadowedDeclKind(ShadowedDecl, OldDC);
7129   Diag(R.getNameLoc(), WarningDiag) << Name << Kind << OldDC;
7130   if (!CaptureLoc.isInvalid())
7131     Diag(CaptureLoc, diag::note_var_explicitly_captured_here)
7132         << Name << /*explicitly*/ 1;
7133   Diag(ShadowedDecl->getLocation(), diag::note_previous_declaration);
7134 }
7135 
7136 /// Diagnose shadowing for variables shadowed in the lambda record \p LambdaRD
7137 /// when these variables are captured by the lambda.
7138 void Sema::DiagnoseShadowingLambdaDecls(const LambdaScopeInfo *LSI) {
7139   for (const auto &Shadow : LSI->ShadowingDecls) {
7140     const VarDecl *ShadowedDecl = Shadow.ShadowedDecl;
7141     // Try to avoid the warning when the shadowed decl isn't captured.
7142     SourceLocation CaptureLoc = getCaptureLocation(LSI, ShadowedDecl);
7143     const DeclContext *OldDC = ShadowedDecl->getDeclContext();
7144     Diag(Shadow.VD->getLocation(), CaptureLoc.isInvalid()
7145                                        ? diag::warn_decl_shadow_uncaptured_local
7146                                        : diag::warn_decl_shadow)
7147         << Shadow.VD->getDeclName()
7148         << computeShadowedDeclKind(ShadowedDecl, OldDC) << OldDC;
7149     if (!CaptureLoc.isInvalid())
7150       Diag(CaptureLoc, diag::note_var_explicitly_captured_here)
7151           << Shadow.VD->getDeclName() << /*explicitly*/ 0;
7152     Diag(ShadowedDecl->getLocation(), diag::note_previous_declaration);
7153   }
7154 }
7155 
7156 /// \brief Check -Wshadow without the advantage of a previous lookup.
7157 void Sema::CheckShadow(Scope *S, VarDecl *D) {
7158   if (Diags.isIgnored(diag::warn_decl_shadow, D->getLocation()))
7159     return;
7160 
7161   LookupResult R(*this, D->getDeclName(), D->getLocation(),
7162                  Sema::LookupOrdinaryName, Sema::ForVisibleRedeclaration);
7163   LookupName(R, S);
7164   if (NamedDecl *ShadowedDecl = getShadowedDeclaration(D, R))
7165     CheckShadow(D, ShadowedDecl, R);
7166 }
7167 
7168 /// Check if 'E', which is an expression that is about to be modified, refers
7169 /// to a constructor parameter that shadows a field.
7170 void Sema::CheckShadowingDeclModification(Expr *E, SourceLocation Loc) {
7171   // Quickly ignore expressions that can't be shadowing ctor parameters.
7172   if (!getLangOpts().CPlusPlus || ShadowingDecls.empty())
7173     return;
7174   E = E->IgnoreParenImpCasts();
7175   auto *DRE = dyn_cast<DeclRefExpr>(E);
7176   if (!DRE)
7177     return;
7178   const NamedDecl *D = cast<NamedDecl>(DRE->getDecl()->getCanonicalDecl());
7179   auto I = ShadowingDecls.find(D);
7180   if (I == ShadowingDecls.end())
7181     return;
7182   const NamedDecl *ShadowedDecl = I->second;
7183   const DeclContext *OldDC = ShadowedDecl->getDeclContext();
7184   Diag(Loc, diag::warn_modifying_shadowing_decl) << D << OldDC;
7185   Diag(D->getLocation(), diag::note_var_declared_here) << D;
7186   Diag(ShadowedDecl->getLocation(), diag::note_previous_declaration);
7187 
7188   // Avoid issuing multiple warnings about the same decl.
7189   ShadowingDecls.erase(I);
7190 }
7191 
7192 /// Check for conflict between this global or extern "C" declaration and
7193 /// previous global or extern "C" declarations. This is only used in C++.
7194 template<typename T>
7195 static bool checkGlobalOrExternCConflict(
7196     Sema &S, const T *ND, bool IsGlobal, LookupResult &Previous) {
7197   assert(S.getLangOpts().CPlusPlus && "only C++ has extern \"C\"");
7198   NamedDecl *Prev = S.findLocallyScopedExternCDecl(ND->getDeclName());
7199 
7200   if (!Prev && IsGlobal && !isIncompleteDeclExternC(S, ND)) {
7201     // The common case: this global doesn't conflict with any extern "C"
7202     // declaration.
7203     return false;
7204   }
7205 
7206   if (Prev) {
7207     if (!IsGlobal || isIncompleteDeclExternC(S, ND)) {
7208       // Both the old and new declarations have C language linkage. This is a
7209       // redeclaration.
7210       Previous.clear();
7211       Previous.addDecl(Prev);
7212       return true;
7213     }
7214 
7215     // This is a global, non-extern "C" declaration, and there is a previous
7216     // non-global extern "C" declaration. Diagnose if this is a variable
7217     // declaration.
7218     if (!isa<VarDecl>(ND))
7219       return false;
7220   } else {
7221     // The declaration is extern "C". Check for any declaration in the
7222     // translation unit which might conflict.
7223     if (IsGlobal) {
7224       // We have already performed the lookup into the translation unit.
7225       IsGlobal = false;
7226       for (LookupResult::iterator I = Previous.begin(), E = Previous.end();
7227            I != E; ++I) {
7228         if (isa<VarDecl>(*I)) {
7229           Prev = *I;
7230           break;
7231         }
7232       }
7233     } else {
7234       DeclContext::lookup_result R =
7235           S.Context.getTranslationUnitDecl()->lookup(ND->getDeclName());
7236       for (DeclContext::lookup_result::iterator I = R.begin(), E = R.end();
7237            I != E; ++I) {
7238         if (isa<VarDecl>(*I)) {
7239           Prev = *I;
7240           break;
7241         }
7242         // FIXME: If we have any other entity with this name in global scope,
7243         // the declaration is ill-formed, but that is a defect: it breaks the
7244         // 'stat' hack, for instance. Only variables can have mangled name
7245         // clashes with extern "C" declarations, so only they deserve a
7246         // diagnostic.
7247       }
7248     }
7249 
7250     if (!Prev)
7251       return false;
7252   }
7253 
7254   // Use the first declaration's location to ensure we point at something which
7255   // is lexically inside an extern "C" linkage-spec.
7256   assert(Prev && "should have found a previous declaration to diagnose");
7257   if (FunctionDecl *FD = dyn_cast<FunctionDecl>(Prev))
7258     Prev = FD->getFirstDecl();
7259   else
7260     Prev = cast<VarDecl>(Prev)->getFirstDecl();
7261 
7262   S.Diag(ND->getLocation(), diag::err_extern_c_global_conflict)
7263     << IsGlobal << ND;
7264   S.Diag(Prev->getLocation(), diag::note_extern_c_global_conflict)
7265     << IsGlobal;
7266   return false;
7267 }
7268 
7269 /// Apply special rules for handling extern "C" declarations. Returns \c true
7270 /// if we have found that this is a redeclaration of some prior entity.
7271 ///
7272 /// Per C++ [dcl.link]p6:
7273 ///   Two declarations [for a function or variable] with C language linkage
7274 ///   with the same name that appear in different scopes refer to the same
7275 ///   [entity]. An entity with C language linkage shall not be declared with
7276 ///   the same name as an entity in global scope.
7277 template<typename T>
7278 static bool checkForConflictWithNonVisibleExternC(Sema &S, const T *ND,
7279                                                   LookupResult &Previous) {
7280   if (!S.getLangOpts().CPlusPlus) {
7281     // In C, when declaring a global variable, look for a corresponding 'extern'
7282     // variable declared in function scope. We don't need this in C++, because
7283     // we find local extern decls in the surrounding file-scope DeclContext.
7284     if (ND->getDeclContext()->getRedeclContext()->isTranslationUnit()) {
7285       if (NamedDecl *Prev = S.findLocallyScopedExternCDecl(ND->getDeclName())) {
7286         Previous.clear();
7287         Previous.addDecl(Prev);
7288         return true;
7289       }
7290     }
7291     return false;
7292   }
7293 
7294   // A declaration in the translation unit can conflict with an extern "C"
7295   // declaration.
7296   if (ND->getDeclContext()->getRedeclContext()->isTranslationUnit())
7297     return checkGlobalOrExternCConflict(S, ND, /*IsGlobal*/true, Previous);
7298 
7299   // An extern "C" declaration can conflict with a declaration in the
7300   // translation unit or can be a redeclaration of an extern "C" declaration
7301   // in another scope.
7302   if (isIncompleteDeclExternC(S,ND))
7303     return checkGlobalOrExternCConflict(S, ND, /*IsGlobal*/false, Previous);
7304 
7305   // Neither global nor extern "C": nothing to do.
7306   return false;
7307 }
7308 
7309 void Sema::CheckVariableDeclarationType(VarDecl *NewVD) {
7310   // If the decl is already known invalid, don't check it.
7311   if (NewVD->isInvalidDecl())
7312     return;
7313 
7314   TypeSourceInfo *TInfo = NewVD->getTypeSourceInfo();
7315   QualType T = TInfo->getType();
7316 
7317   // Defer checking an 'auto' type until its initializer is attached.
7318   if (T->isUndeducedType())
7319     return;
7320 
7321   if (NewVD->hasAttrs())
7322     CheckAlignasUnderalignment(NewVD);
7323 
7324   if (T->isObjCObjectType()) {
7325     Diag(NewVD->getLocation(), diag::err_statically_allocated_object)
7326       << FixItHint::CreateInsertion(NewVD->getLocation(), "*");
7327     T = Context.getObjCObjectPointerType(T);
7328     NewVD->setType(T);
7329   }
7330 
7331   // Emit an error if an address space was applied to decl with local storage.
7332   // This includes arrays of objects with address space qualifiers, but not
7333   // automatic variables that point to other address spaces.
7334   // ISO/IEC TR 18037 S5.1.2
7335   if (!getLangOpts().OpenCL && NewVD->hasLocalStorage() &&
7336       T.getAddressSpace() != LangAS::Default) {
7337     Diag(NewVD->getLocation(), diag::err_as_qualified_auto_decl) << 0;
7338     NewVD->setInvalidDecl();
7339     return;
7340   }
7341 
7342   // OpenCL v1.2 s6.8 - The static qualifier is valid only in program
7343   // scope.
7344   if (getLangOpts().OpenCLVersion == 120 &&
7345       !getOpenCLOptions().isEnabled("cl_clang_storage_class_specifiers") &&
7346       NewVD->isStaticLocal()) {
7347     Diag(NewVD->getLocation(), diag::err_static_function_scope);
7348     NewVD->setInvalidDecl();
7349     return;
7350   }
7351 
7352   if (getLangOpts().OpenCL) {
7353     // OpenCL v2.0 s6.12.5 - The __block storage type is not supported.
7354     if (NewVD->hasAttr<BlocksAttr>()) {
7355       Diag(NewVD->getLocation(), diag::err_opencl_block_storage_type);
7356       return;
7357     }
7358 
7359     if (T->isBlockPointerType()) {
7360       // OpenCL v2.0 s6.12.5 - Any block declaration must be const qualified and
7361       // can't use 'extern' storage class.
7362       if (!T.isConstQualified()) {
7363         Diag(NewVD->getLocation(), diag::err_opencl_invalid_block_declaration)
7364             << 0 /*const*/;
7365         NewVD->setInvalidDecl();
7366         return;
7367       }
7368       if (NewVD->hasExternalStorage()) {
7369         Diag(NewVD->getLocation(), diag::err_opencl_extern_block_declaration);
7370         NewVD->setInvalidDecl();
7371         return;
7372       }
7373     }
7374     // OpenCL v1.2 s6.5 - All program scope variables must be declared in the
7375     // __constant address space.
7376     // OpenCL v2.0 s6.5.1 - Variables defined at program scope and static
7377     // variables inside a function can also be declared in the global
7378     // address space.
7379     if (NewVD->isFileVarDecl() || NewVD->isStaticLocal() ||
7380         NewVD->hasExternalStorage()) {
7381       if (!T->isSamplerT() &&
7382           !(T.getAddressSpace() == LangAS::opencl_constant ||
7383             (T.getAddressSpace() == LangAS::opencl_global &&
7384              getLangOpts().OpenCLVersion == 200))) {
7385         int Scope = NewVD->isStaticLocal() | NewVD->hasExternalStorage() << 1;
7386         if (getLangOpts().OpenCLVersion == 200)
7387           Diag(NewVD->getLocation(), diag::err_opencl_global_invalid_addr_space)
7388               << Scope << "global or constant";
7389         else
7390           Diag(NewVD->getLocation(), diag::err_opencl_global_invalid_addr_space)
7391               << Scope << "constant";
7392         NewVD->setInvalidDecl();
7393         return;
7394       }
7395     } else {
7396       if (T.getAddressSpace() == LangAS::opencl_global) {
7397         Diag(NewVD->getLocation(), diag::err_opencl_function_variable)
7398             << 1 /*is any function*/ << "global";
7399         NewVD->setInvalidDecl();
7400         return;
7401       }
7402       if (T.getAddressSpace() == LangAS::opencl_constant ||
7403           T.getAddressSpace() == LangAS::opencl_local) {
7404         FunctionDecl *FD = getCurFunctionDecl();
7405         // OpenCL v1.1 s6.5.2 and s6.5.3: no local or constant variables
7406         // in functions.
7407         if (FD && !FD->hasAttr<OpenCLKernelAttr>()) {
7408           if (T.getAddressSpace() == LangAS::opencl_constant)
7409             Diag(NewVD->getLocation(), diag::err_opencl_function_variable)
7410                 << 0 /*non-kernel only*/ << "constant";
7411           else
7412             Diag(NewVD->getLocation(), diag::err_opencl_function_variable)
7413                 << 0 /*non-kernel only*/ << "local";
7414           NewVD->setInvalidDecl();
7415           return;
7416         }
7417         // OpenCL v2.0 s6.5.2 and s6.5.3: local and constant variables must be
7418         // in the outermost scope of a kernel function.
7419         if (FD && FD->hasAttr<OpenCLKernelAttr>()) {
7420           if (!getCurScope()->isFunctionScope()) {
7421             if (T.getAddressSpace() == LangAS::opencl_constant)
7422               Diag(NewVD->getLocation(), diag::err_opencl_addrspace_scope)
7423                   << "constant";
7424             else
7425               Diag(NewVD->getLocation(), diag::err_opencl_addrspace_scope)
7426                   << "local";
7427             NewVD->setInvalidDecl();
7428             return;
7429           }
7430         }
7431       } else if (T.getAddressSpace() != LangAS::opencl_private) {
7432         // Do not allow other address spaces on automatic variable.
7433         Diag(NewVD->getLocation(), diag::err_as_qualified_auto_decl) << 1;
7434         NewVD->setInvalidDecl();
7435         return;
7436       }
7437     }
7438   }
7439 
7440   if (NewVD->hasLocalStorage() && T.isObjCGCWeak()
7441       && !NewVD->hasAttr<BlocksAttr>()) {
7442     if (getLangOpts().getGC() != LangOptions::NonGC)
7443       Diag(NewVD->getLocation(), diag::warn_gc_attribute_weak_on_local);
7444     else {
7445       assert(!getLangOpts().ObjCAutoRefCount);
7446       Diag(NewVD->getLocation(), diag::warn_attribute_weak_on_local);
7447     }
7448   }
7449 
7450   bool isVM = T->isVariablyModifiedType();
7451   if (isVM || NewVD->hasAttr<CleanupAttr>() ||
7452       NewVD->hasAttr<BlocksAttr>())
7453     getCurFunction()->setHasBranchProtectedScope();
7454 
7455   if ((isVM && NewVD->hasLinkage()) ||
7456       (T->isVariableArrayType() && NewVD->hasGlobalStorage())) {
7457     bool SizeIsNegative;
7458     llvm::APSInt Oversized;
7459     TypeSourceInfo *FixedTInfo =
7460       TryToFixInvalidVariablyModifiedTypeSourceInfo(TInfo, Context,
7461                                                     SizeIsNegative, Oversized);
7462     if (!FixedTInfo && T->isVariableArrayType()) {
7463       const VariableArrayType *VAT = Context.getAsVariableArrayType(T);
7464       // FIXME: This won't give the correct result for
7465       // int a[10][n];
7466       SourceRange SizeRange = VAT->getSizeExpr()->getSourceRange();
7467 
7468       if (NewVD->isFileVarDecl())
7469         Diag(NewVD->getLocation(), diag::err_vla_decl_in_file_scope)
7470         << SizeRange;
7471       else if (NewVD->isStaticLocal())
7472         Diag(NewVD->getLocation(), diag::err_vla_decl_has_static_storage)
7473         << SizeRange;
7474       else
7475         Diag(NewVD->getLocation(), diag::err_vla_decl_has_extern_linkage)
7476         << SizeRange;
7477       NewVD->setInvalidDecl();
7478       return;
7479     }
7480 
7481     if (!FixedTInfo) {
7482       if (NewVD->isFileVarDecl())
7483         Diag(NewVD->getLocation(), diag::err_vm_decl_in_file_scope);
7484       else
7485         Diag(NewVD->getLocation(), diag::err_vm_decl_has_extern_linkage);
7486       NewVD->setInvalidDecl();
7487       return;
7488     }
7489 
7490     Diag(NewVD->getLocation(), diag::warn_illegal_constant_array_size);
7491     NewVD->setType(FixedTInfo->getType());
7492     NewVD->setTypeSourceInfo(FixedTInfo);
7493   }
7494 
7495   if (T->isVoidType()) {
7496     // C++98 [dcl.stc]p5: The extern specifier can be applied only to the names
7497     //                    of objects and functions.
7498     if (NewVD->isThisDeclarationADefinition() || getLangOpts().CPlusPlus) {
7499       Diag(NewVD->getLocation(), diag::err_typecheck_decl_incomplete_type)
7500         << T;
7501       NewVD->setInvalidDecl();
7502       return;
7503     }
7504   }
7505 
7506   if (!NewVD->hasLocalStorage() && NewVD->hasAttr<BlocksAttr>()) {
7507     Diag(NewVD->getLocation(), diag::err_block_on_nonlocal);
7508     NewVD->setInvalidDecl();
7509     return;
7510   }
7511 
7512   if (isVM && NewVD->hasAttr<BlocksAttr>()) {
7513     Diag(NewVD->getLocation(), diag::err_block_on_vm);
7514     NewVD->setInvalidDecl();
7515     return;
7516   }
7517 
7518   if (NewVD->isConstexpr() && !T->isDependentType() &&
7519       RequireLiteralType(NewVD->getLocation(), T,
7520                          diag::err_constexpr_var_non_literal)) {
7521     NewVD->setInvalidDecl();
7522     return;
7523   }
7524 }
7525 
7526 /// \brief Perform semantic checking on a newly-created variable
7527 /// declaration.
7528 ///
7529 /// This routine performs all of the type-checking required for a
7530 /// variable declaration once it has been built. It is used both to
7531 /// check variables after they have been parsed and their declarators
7532 /// have been translated into a declaration, and to check variables
7533 /// that have been instantiated from a template.
7534 ///
7535 /// Sets NewVD->isInvalidDecl() if an error was encountered.
7536 ///
7537 /// Returns true if the variable declaration is a redeclaration.
7538 bool Sema::CheckVariableDeclaration(VarDecl *NewVD, LookupResult &Previous) {
7539   CheckVariableDeclarationType(NewVD);
7540 
7541   // If the decl is already known invalid, don't check it.
7542   if (NewVD->isInvalidDecl())
7543     return false;
7544 
7545   // If we did not find anything by this name, look for a non-visible
7546   // extern "C" declaration with the same name.
7547   if (Previous.empty() &&
7548       checkForConflictWithNonVisibleExternC(*this, NewVD, Previous))
7549     Previous.setShadowed();
7550 
7551   if (!Previous.empty()) {
7552     MergeVarDecl(NewVD, Previous);
7553     return true;
7554   }
7555   return false;
7556 }
7557 
7558 namespace {
7559 struct FindOverriddenMethod {
7560   Sema *S;
7561   CXXMethodDecl *Method;
7562 
7563   /// Member lookup function that determines whether a given C++
7564   /// method overrides a method in a base class, to be used with
7565   /// CXXRecordDecl::lookupInBases().
7566   bool operator()(const CXXBaseSpecifier *Specifier, CXXBasePath &Path) {
7567     RecordDecl *BaseRecord =
7568         Specifier->getType()->getAs<RecordType>()->getDecl();
7569 
7570     DeclarationName Name = Method->getDeclName();
7571 
7572     // FIXME: Do we care about other names here too?
7573     if (Name.getNameKind() == DeclarationName::CXXDestructorName) {
7574       // We really want to find the base class destructor here.
7575       QualType T = S->Context.getTypeDeclType(BaseRecord);
7576       CanQualType CT = S->Context.getCanonicalType(T);
7577 
7578       Name = S->Context.DeclarationNames.getCXXDestructorName(CT);
7579     }
7580 
7581     for (Path.Decls = BaseRecord->lookup(Name); !Path.Decls.empty();
7582          Path.Decls = Path.Decls.slice(1)) {
7583       NamedDecl *D = Path.Decls.front();
7584       if (CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(D)) {
7585         if (MD->isVirtual() && !S->IsOverload(Method, MD, false))
7586           return true;
7587       }
7588     }
7589 
7590     return false;
7591   }
7592 };
7593 
7594 enum OverrideErrorKind { OEK_All, OEK_NonDeleted, OEK_Deleted };
7595 } // end anonymous namespace
7596 
7597 /// \brief Report an error regarding overriding, along with any relevant
7598 /// overriden methods.
7599 ///
7600 /// \param DiagID the primary error to report.
7601 /// \param MD the overriding method.
7602 /// \param OEK which overrides to include as notes.
7603 static void ReportOverrides(Sema& S, unsigned DiagID, const CXXMethodDecl *MD,
7604                             OverrideErrorKind OEK = OEK_All) {
7605   S.Diag(MD->getLocation(), DiagID) << MD->getDeclName();
7606   for (CXXMethodDecl::method_iterator I = MD->begin_overridden_methods(),
7607                                       E = MD->end_overridden_methods();
7608        I != E; ++I) {
7609     // This check (& the OEK parameter) could be replaced by a predicate, but
7610     // without lambdas that would be overkill. This is still nicer than writing
7611     // out the diag loop 3 times.
7612     if ((OEK == OEK_All) ||
7613         (OEK == OEK_NonDeleted && !(*I)->isDeleted()) ||
7614         (OEK == OEK_Deleted && (*I)->isDeleted()))
7615       S.Diag((*I)->getLocation(), diag::note_overridden_virtual_function);
7616   }
7617 }
7618 
7619 /// AddOverriddenMethods - See if a method overrides any in the base classes,
7620 /// and if so, check that it's a valid override and remember it.
7621 bool Sema::AddOverriddenMethods(CXXRecordDecl *DC, CXXMethodDecl *MD) {
7622   // Look for methods in base classes that this method might override.
7623   CXXBasePaths Paths;
7624   FindOverriddenMethod FOM;
7625   FOM.Method = MD;
7626   FOM.S = this;
7627   bool hasDeletedOverridenMethods = false;
7628   bool hasNonDeletedOverridenMethods = false;
7629   bool AddedAny = false;
7630   if (DC->lookupInBases(FOM, Paths)) {
7631     for (auto *I : Paths.found_decls()) {
7632       if (CXXMethodDecl *OldMD = dyn_cast<CXXMethodDecl>(I)) {
7633         MD->addOverriddenMethod(OldMD->getCanonicalDecl());
7634         if (!CheckOverridingFunctionReturnType(MD, OldMD) &&
7635             !CheckOverridingFunctionAttributes(MD, OldMD) &&
7636             !CheckOverridingFunctionExceptionSpec(MD, OldMD) &&
7637             !CheckIfOverriddenFunctionIsMarkedFinal(MD, OldMD)) {
7638           hasDeletedOverridenMethods |= OldMD->isDeleted();
7639           hasNonDeletedOverridenMethods |= !OldMD->isDeleted();
7640           AddedAny = true;
7641         }
7642       }
7643     }
7644   }
7645 
7646   if (hasDeletedOverridenMethods && !MD->isDeleted()) {
7647     ReportOverrides(*this, diag::err_non_deleted_override, MD, OEK_Deleted);
7648   }
7649   if (hasNonDeletedOverridenMethods && MD->isDeleted()) {
7650     ReportOverrides(*this, diag::err_deleted_override, MD, OEK_NonDeleted);
7651   }
7652 
7653   return AddedAny;
7654 }
7655 
7656 namespace {
7657   // Struct for holding all of the extra arguments needed by
7658   // DiagnoseInvalidRedeclaration to call Sema::ActOnFunctionDeclarator.
7659   struct ActOnFDArgs {
7660     Scope *S;
7661     Declarator &D;
7662     MultiTemplateParamsArg TemplateParamLists;
7663     bool AddToScope;
7664   };
7665 } // end anonymous namespace
7666 
7667 namespace {
7668 
7669 // Callback to only accept typo corrections that have a non-zero edit distance.
7670 // Also only accept corrections that have the same parent decl.
7671 class DifferentNameValidatorCCC : public CorrectionCandidateCallback {
7672  public:
7673   DifferentNameValidatorCCC(ASTContext &Context, FunctionDecl *TypoFD,
7674                             CXXRecordDecl *Parent)
7675       : Context(Context), OriginalFD(TypoFD),
7676         ExpectedParent(Parent ? Parent->getCanonicalDecl() : nullptr) {}
7677 
7678   bool ValidateCandidate(const TypoCorrection &candidate) override {
7679     if (candidate.getEditDistance() == 0)
7680       return false;
7681 
7682     SmallVector<unsigned, 1> MismatchedParams;
7683     for (TypoCorrection::const_decl_iterator CDecl = candidate.begin(),
7684                                           CDeclEnd = candidate.end();
7685          CDecl != CDeclEnd; ++CDecl) {
7686       FunctionDecl *FD = dyn_cast<FunctionDecl>(*CDecl);
7687 
7688       if (FD && !FD->hasBody() &&
7689           hasSimilarParameters(Context, FD, OriginalFD, MismatchedParams)) {
7690         if (CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD)) {
7691           CXXRecordDecl *Parent = MD->getParent();
7692           if (Parent && Parent->getCanonicalDecl() == ExpectedParent)
7693             return true;
7694         } else if (!ExpectedParent) {
7695           return true;
7696         }
7697       }
7698     }
7699 
7700     return false;
7701   }
7702 
7703  private:
7704   ASTContext &Context;
7705   FunctionDecl *OriginalFD;
7706   CXXRecordDecl *ExpectedParent;
7707 };
7708 
7709 } // end anonymous namespace
7710 
7711 void Sema::MarkTypoCorrectedFunctionDefinition(const NamedDecl *F) {
7712   TypoCorrectedFunctionDefinitions.insert(F);
7713 }
7714 
7715 /// \brief Generate diagnostics for an invalid function redeclaration.
7716 ///
7717 /// This routine handles generating the diagnostic messages for an invalid
7718 /// function redeclaration, including finding possible similar declarations
7719 /// or performing typo correction if there are no previous declarations with
7720 /// the same name.
7721 ///
7722 /// Returns a NamedDecl iff typo correction was performed and substituting in
7723 /// the new declaration name does not cause new errors.
7724 static NamedDecl *DiagnoseInvalidRedeclaration(
7725     Sema &SemaRef, LookupResult &Previous, FunctionDecl *NewFD,
7726     ActOnFDArgs &ExtraArgs, bool IsLocalFriend, Scope *S) {
7727   DeclarationName Name = NewFD->getDeclName();
7728   DeclContext *NewDC = NewFD->getDeclContext();
7729   SmallVector<unsigned, 1> MismatchedParams;
7730   SmallVector<std::pair<FunctionDecl *, unsigned>, 1> NearMatches;
7731   TypoCorrection Correction;
7732   bool IsDefinition = ExtraArgs.D.isFunctionDefinition();
7733   unsigned DiagMsg = IsLocalFriend ? diag::err_no_matching_local_friend
7734                                    : diag::err_member_decl_does_not_match;
7735   LookupResult Prev(SemaRef, Name, NewFD->getLocation(),
7736                     IsLocalFriend ? Sema::LookupLocalFriendName
7737                                   : Sema::LookupOrdinaryName,
7738                     Sema::ForVisibleRedeclaration);
7739 
7740   NewFD->setInvalidDecl();
7741   if (IsLocalFriend)
7742     SemaRef.LookupName(Prev, S);
7743   else
7744     SemaRef.LookupQualifiedName(Prev, NewDC);
7745   assert(!Prev.isAmbiguous() &&
7746          "Cannot have an ambiguity in previous-declaration lookup");
7747   CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(NewFD);
7748   if (!Prev.empty()) {
7749     for (LookupResult::iterator Func = Prev.begin(), FuncEnd = Prev.end();
7750          Func != FuncEnd; ++Func) {
7751       FunctionDecl *FD = dyn_cast<FunctionDecl>(*Func);
7752       if (FD &&
7753           hasSimilarParameters(SemaRef.Context, FD, NewFD, MismatchedParams)) {
7754         // Add 1 to the index so that 0 can mean the mismatch didn't
7755         // involve a parameter
7756         unsigned ParamNum =
7757             MismatchedParams.empty() ? 0 : MismatchedParams.front() + 1;
7758         NearMatches.push_back(std::make_pair(FD, ParamNum));
7759       }
7760     }
7761   // If the qualified name lookup yielded nothing, try typo correction
7762   } else if ((Correction = SemaRef.CorrectTypo(
7763                   Prev.getLookupNameInfo(), Prev.getLookupKind(), S,
7764                   &ExtraArgs.D.getCXXScopeSpec(),
7765                   llvm::make_unique<DifferentNameValidatorCCC>(
7766                       SemaRef.Context, NewFD, MD ? MD->getParent() : nullptr),
7767                   Sema::CTK_ErrorRecovery, IsLocalFriend ? nullptr : NewDC))) {
7768     // Set up everything for the call to ActOnFunctionDeclarator
7769     ExtraArgs.D.SetIdentifier(Correction.getCorrectionAsIdentifierInfo(),
7770                               ExtraArgs.D.getIdentifierLoc());
7771     Previous.clear();
7772     Previous.setLookupName(Correction.getCorrection());
7773     for (TypoCorrection::decl_iterator CDecl = Correction.begin(),
7774                                     CDeclEnd = Correction.end();
7775          CDecl != CDeclEnd; ++CDecl) {
7776       FunctionDecl *FD = dyn_cast<FunctionDecl>(*CDecl);
7777       if (FD && !FD->hasBody() &&
7778           hasSimilarParameters(SemaRef.Context, FD, NewFD, MismatchedParams)) {
7779         Previous.addDecl(FD);
7780       }
7781     }
7782     bool wasRedeclaration = ExtraArgs.D.isRedeclaration();
7783 
7784     NamedDecl *Result;
7785     // Retry building the function declaration with the new previous
7786     // declarations, and with errors suppressed.
7787     {
7788       // Trap errors.
7789       Sema::SFINAETrap Trap(SemaRef);
7790 
7791       // TODO: Refactor ActOnFunctionDeclarator so that we can call only the
7792       // pieces need to verify the typo-corrected C++ declaration and hopefully
7793       // eliminate the need for the parameter pack ExtraArgs.
7794       Result = SemaRef.ActOnFunctionDeclarator(
7795           ExtraArgs.S, ExtraArgs.D,
7796           Correction.getCorrectionDecl()->getDeclContext(),
7797           NewFD->getTypeSourceInfo(), Previous, ExtraArgs.TemplateParamLists,
7798           ExtraArgs.AddToScope);
7799 
7800       if (Trap.hasErrorOccurred())
7801         Result = nullptr;
7802     }
7803 
7804     if (Result) {
7805       // Determine which correction we picked.
7806       Decl *Canonical = Result->getCanonicalDecl();
7807       for (LookupResult::iterator I = Previous.begin(), E = Previous.end();
7808            I != E; ++I)
7809         if ((*I)->getCanonicalDecl() == Canonical)
7810           Correction.setCorrectionDecl(*I);
7811 
7812       // Let Sema know about the correction.
7813       SemaRef.MarkTypoCorrectedFunctionDefinition(Result);
7814       SemaRef.diagnoseTypo(
7815           Correction,
7816           SemaRef.PDiag(IsLocalFriend
7817                           ? diag::err_no_matching_local_friend_suggest
7818                           : diag::err_member_decl_does_not_match_suggest)
7819             << Name << NewDC << IsDefinition);
7820       return Result;
7821     }
7822 
7823     // Pretend the typo correction never occurred
7824     ExtraArgs.D.SetIdentifier(Name.getAsIdentifierInfo(),
7825                               ExtraArgs.D.getIdentifierLoc());
7826     ExtraArgs.D.setRedeclaration(wasRedeclaration);
7827     Previous.clear();
7828     Previous.setLookupName(Name);
7829   }
7830 
7831   SemaRef.Diag(NewFD->getLocation(), DiagMsg)
7832       << Name << NewDC << IsDefinition << NewFD->getLocation();
7833 
7834   bool NewFDisConst = false;
7835   if (CXXMethodDecl *NewMD = dyn_cast<CXXMethodDecl>(NewFD))
7836     NewFDisConst = NewMD->isConst();
7837 
7838   for (SmallVectorImpl<std::pair<FunctionDecl *, unsigned> >::iterator
7839        NearMatch = NearMatches.begin(), NearMatchEnd = NearMatches.end();
7840        NearMatch != NearMatchEnd; ++NearMatch) {
7841     FunctionDecl *FD = NearMatch->first;
7842     CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(FD);
7843     bool FDisConst = MD && MD->isConst();
7844     bool IsMember = MD || !IsLocalFriend;
7845 
7846     // FIXME: These notes are poorly worded for the local friend case.
7847     if (unsigned Idx = NearMatch->second) {
7848       ParmVarDecl *FDParam = FD->getParamDecl(Idx-1);
7849       SourceLocation Loc = FDParam->getTypeSpecStartLoc();
7850       if (Loc.isInvalid()) Loc = FD->getLocation();
7851       SemaRef.Diag(Loc, IsMember ? diag::note_member_def_close_param_match
7852                                  : diag::note_local_decl_close_param_match)
7853         << Idx << FDParam->getType()
7854         << NewFD->getParamDecl(Idx - 1)->getType();
7855     } else if (FDisConst != NewFDisConst) {
7856       SemaRef.Diag(FD->getLocation(), diag::note_member_def_close_const_match)
7857           << NewFDisConst << FD->getSourceRange().getEnd();
7858     } else
7859       SemaRef.Diag(FD->getLocation(),
7860                    IsMember ? diag::note_member_def_close_match
7861                             : diag::note_local_decl_close_match);
7862   }
7863   return nullptr;
7864 }
7865 
7866 static StorageClass getFunctionStorageClass(Sema &SemaRef, Declarator &D) {
7867   switch (D.getDeclSpec().getStorageClassSpec()) {
7868   default: llvm_unreachable("Unknown storage class!");
7869   case DeclSpec::SCS_auto:
7870   case DeclSpec::SCS_register:
7871   case DeclSpec::SCS_mutable:
7872     SemaRef.Diag(D.getDeclSpec().getStorageClassSpecLoc(),
7873                  diag::err_typecheck_sclass_func);
7874     D.getMutableDeclSpec().ClearStorageClassSpecs();
7875     D.setInvalidType();
7876     break;
7877   case DeclSpec::SCS_unspecified: break;
7878   case DeclSpec::SCS_extern:
7879     if (D.getDeclSpec().isExternInLinkageSpec())
7880       return SC_None;
7881     return SC_Extern;
7882   case DeclSpec::SCS_static: {
7883     if (SemaRef.CurContext->getRedeclContext()->isFunctionOrMethod()) {
7884       // C99 6.7.1p5:
7885       //   The declaration of an identifier for a function that has
7886       //   block scope shall have no explicit storage-class specifier
7887       //   other than extern
7888       // See also (C++ [dcl.stc]p4).
7889       SemaRef.Diag(D.getDeclSpec().getStorageClassSpecLoc(),
7890                    diag::err_static_block_func);
7891       break;
7892     } else
7893       return SC_Static;
7894   }
7895   case DeclSpec::SCS_private_extern: return SC_PrivateExtern;
7896   }
7897 
7898   // No explicit storage class has already been returned
7899   return SC_None;
7900 }
7901 
7902 static FunctionDecl* CreateNewFunctionDecl(Sema &SemaRef, Declarator &D,
7903                                            DeclContext *DC, QualType &R,
7904                                            TypeSourceInfo *TInfo,
7905                                            StorageClass SC,
7906                                            bool &IsVirtualOkay) {
7907   DeclarationNameInfo NameInfo = SemaRef.GetNameForDeclarator(D);
7908   DeclarationName Name = NameInfo.getName();
7909 
7910   FunctionDecl *NewFD = nullptr;
7911   bool isInline = D.getDeclSpec().isInlineSpecified();
7912 
7913   if (!SemaRef.getLangOpts().CPlusPlus) {
7914     // Determine whether the function was written with a
7915     // prototype. This true when:
7916     //   - there is a prototype in the declarator, or
7917     //   - the type R of the function is some kind of typedef or other non-
7918     //     attributed reference to a type name (which eventually refers to a
7919     //     function type).
7920     bool HasPrototype =
7921       (D.isFunctionDeclarator() && D.getFunctionTypeInfo().hasPrototype) ||
7922       (!R->getAsAdjusted<FunctionType>() && R->isFunctionProtoType());
7923 
7924     NewFD = FunctionDecl::Create(SemaRef.Context, DC,
7925                                  D.getLocStart(), NameInfo, R,
7926                                  TInfo, SC, isInline,
7927                                  HasPrototype, false);
7928     if (D.isInvalidType())
7929       NewFD->setInvalidDecl();
7930 
7931     return NewFD;
7932   }
7933 
7934   bool isExplicit = D.getDeclSpec().isExplicitSpecified();
7935   bool isConstexpr = D.getDeclSpec().isConstexprSpecified();
7936 
7937   // Check that the return type is not an abstract class type.
7938   // For record types, this is done by the AbstractClassUsageDiagnoser once
7939   // the class has been completely parsed.
7940   if (!DC->isRecord() &&
7941       SemaRef.RequireNonAbstractType(
7942           D.getIdentifierLoc(), R->getAs<FunctionType>()->getReturnType(),
7943           diag::err_abstract_type_in_decl, SemaRef.AbstractReturnType))
7944     D.setInvalidType();
7945 
7946   if (Name.getNameKind() == DeclarationName::CXXConstructorName) {
7947     // This is a C++ constructor declaration.
7948     assert(DC->isRecord() &&
7949            "Constructors can only be declared in a member context");
7950 
7951     R = SemaRef.CheckConstructorDeclarator(D, R, SC);
7952     return CXXConstructorDecl::Create(SemaRef.Context, cast<CXXRecordDecl>(DC),
7953                                       D.getLocStart(), NameInfo,
7954                                       R, TInfo, isExplicit, isInline,
7955                                       /*isImplicitlyDeclared=*/false,
7956                                       isConstexpr);
7957 
7958   } else if (Name.getNameKind() == DeclarationName::CXXDestructorName) {
7959     // This is a C++ destructor declaration.
7960     if (DC->isRecord()) {
7961       R = SemaRef.CheckDestructorDeclarator(D, R, SC);
7962       CXXRecordDecl *Record = cast<CXXRecordDecl>(DC);
7963       CXXDestructorDecl *NewDD = CXXDestructorDecl::Create(
7964                                         SemaRef.Context, Record,
7965                                         D.getLocStart(),
7966                                         NameInfo, R, TInfo, isInline,
7967                                         /*isImplicitlyDeclared=*/false);
7968 
7969       // If the class is complete, then we now create the implicit exception
7970       // specification. If the class is incomplete or dependent, we can't do
7971       // it yet.
7972       if (SemaRef.getLangOpts().CPlusPlus11 && !Record->isDependentType() &&
7973           Record->getDefinition() && !Record->isBeingDefined() &&
7974           R->getAs<FunctionProtoType>()->getExceptionSpecType() == EST_None) {
7975         SemaRef.AdjustDestructorExceptionSpec(Record, NewDD);
7976       }
7977 
7978       IsVirtualOkay = true;
7979       return NewDD;
7980 
7981     } else {
7982       SemaRef.Diag(D.getIdentifierLoc(), diag::err_destructor_not_member);
7983       D.setInvalidType();
7984 
7985       // Create a FunctionDecl to satisfy the function definition parsing
7986       // code path.
7987       return FunctionDecl::Create(SemaRef.Context, DC,
7988                                   D.getLocStart(),
7989                                   D.getIdentifierLoc(), Name, R, TInfo,
7990                                   SC, isInline,
7991                                   /*hasPrototype=*/true, isConstexpr);
7992     }
7993 
7994   } else if (Name.getNameKind() == DeclarationName::CXXConversionFunctionName) {
7995     if (!DC->isRecord()) {
7996       SemaRef.Diag(D.getIdentifierLoc(),
7997            diag::err_conv_function_not_member);
7998       return nullptr;
7999     }
8000 
8001     SemaRef.CheckConversionDeclarator(D, R, SC);
8002     IsVirtualOkay = true;
8003     return CXXConversionDecl::Create(SemaRef.Context, cast<CXXRecordDecl>(DC),
8004                                      D.getLocStart(), NameInfo,
8005                                      R, TInfo, isInline, isExplicit,
8006                                      isConstexpr, SourceLocation());
8007 
8008   } else if (Name.getNameKind() == DeclarationName::CXXDeductionGuideName) {
8009     SemaRef.CheckDeductionGuideDeclarator(D, R, SC);
8010 
8011     return CXXDeductionGuideDecl::Create(SemaRef.Context, DC, D.getLocStart(),
8012                                          isExplicit, NameInfo, R, TInfo,
8013                                          D.getLocEnd());
8014   } else if (DC->isRecord()) {
8015     // If the name of the function is the same as the name of the record,
8016     // then this must be an invalid constructor that has a return type.
8017     // (The parser checks for a return type and makes the declarator a
8018     // constructor if it has no return type).
8019     if (Name.getAsIdentifierInfo() &&
8020         Name.getAsIdentifierInfo() == cast<CXXRecordDecl>(DC)->getIdentifier()){
8021       SemaRef.Diag(D.getIdentifierLoc(), diag::err_constructor_return_type)
8022         << SourceRange(D.getDeclSpec().getTypeSpecTypeLoc())
8023         << SourceRange(D.getIdentifierLoc());
8024       return nullptr;
8025     }
8026 
8027     // This is a C++ method declaration.
8028     CXXMethodDecl *Ret = CXXMethodDecl::Create(SemaRef.Context,
8029                                                cast<CXXRecordDecl>(DC),
8030                                                D.getLocStart(), NameInfo, R,
8031                                                TInfo, SC, isInline,
8032                                                isConstexpr, SourceLocation());
8033     IsVirtualOkay = !Ret->isStatic();
8034     return Ret;
8035   } else {
8036     bool isFriend =
8037         SemaRef.getLangOpts().CPlusPlus && D.getDeclSpec().isFriendSpecified();
8038     if (!isFriend && SemaRef.CurContext->isRecord())
8039       return nullptr;
8040 
8041     // Determine whether the function was written with a
8042     // prototype. This true when:
8043     //   - we're in C++ (where every function has a prototype),
8044     return FunctionDecl::Create(SemaRef.Context, DC,
8045                                 D.getLocStart(),
8046                                 NameInfo, R, TInfo, SC, isInline,
8047                                 true/*HasPrototype*/, isConstexpr);
8048   }
8049 }
8050 
8051 enum OpenCLParamType {
8052   ValidKernelParam,
8053   PtrPtrKernelParam,
8054   PtrKernelParam,
8055   InvalidAddrSpacePtrKernelParam,
8056   InvalidKernelParam,
8057   RecordKernelParam
8058 };
8059 
8060 static OpenCLParamType getOpenCLKernelParameterType(Sema &S, QualType PT) {
8061   if (PT->isPointerType()) {
8062     QualType PointeeType = PT->getPointeeType();
8063     if (PointeeType->isPointerType())
8064       return PtrPtrKernelParam;
8065     if (PointeeType.getAddressSpace() == LangAS::opencl_generic ||
8066         PointeeType.getAddressSpace() == LangAS::opencl_private ||
8067         PointeeType.getAddressSpace() == LangAS::Default)
8068       return InvalidAddrSpacePtrKernelParam;
8069     return PtrKernelParam;
8070   }
8071 
8072   // TODO: Forbid the other integer types (size_t, ptrdiff_t...) when they can
8073   // be used as builtin types.
8074 
8075   if (PT->isImageType())
8076     return PtrKernelParam;
8077 
8078   if (PT->isBooleanType() || PT->isEventT() || PT->isReserveIDT())
8079     return InvalidKernelParam;
8080 
8081   // OpenCL extension spec v1.2 s9.5:
8082   // This extension adds support for half scalar and vector types as built-in
8083   // types that can be used for arithmetic operations, conversions etc.
8084   if (!S.getOpenCLOptions().isEnabled("cl_khr_fp16") && PT->isHalfType())
8085     return InvalidKernelParam;
8086 
8087   if (PT->isRecordType())
8088     return RecordKernelParam;
8089 
8090   return ValidKernelParam;
8091 }
8092 
8093 static void checkIsValidOpenCLKernelParameter(
8094   Sema &S,
8095   Declarator &D,
8096   ParmVarDecl *Param,
8097   llvm::SmallPtrSetImpl<const Type *> &ValidTypes) {
8098   QualType PT = Param->getType();
8099 
8100   // Cache the valid types we encounter to avoid rechecking structs that are
8101   // used again
8102   if (ValidTypes.count(PT.getTypePtr()))
8103     return;
8104 
8105   switch (getOpenCLKernelParameterType(S, PT)) {
8106   case PtrPtrKernelParam:
8107     // OpenCL v1.2 s6.9.a:
8108     // A kernel function argument cannot be declared as a
8109     // pointer to a pointer type.
8110     S.Diag(Param->getLocation(), diag::err_opencl_ptrptr_kernel_param);
8111     D.setInvalidType();
8112     return;
8113 
8114   case InvalidAddrSpacePtrKernelParam:
8115     // OpenCL v1.0 s6.5:
8116     // __kernel function arguments declared to be a pointer of a type can point
8117     // to one of the following address spaces only : __global, __local or
8118     // __constant.
8119     S.Diag(Param->getLocation(), diag::err_kernel_arg_address_space);
8120     D.setInvalidType();
8121     return;
8122 
8123     // OpenCL v1.2 s6.9.k:
8124     // Arguments to kernel functions in a program cannot be declared with the
8125     // built-in scalar types bool, half, size_t, ptrdiff_t, intptr_t, and
8126     // uintptr_t or a struct and/or union that contain fields declared to be
8127     // one of these built-in scalar types.
8128 
8129   case InvalidKernelParam:
8130     // OpenCL v1.2 s6.8 n:
8131     // A kernel function argument cannot be declared
8132     // of event_t type.
8133     // Do not diagnose half type since it is diagnosed as invalid argument
8134     // type for any function elsewhere.
8135     if (!PT->isHalfType())
8136       S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
8137     D.setInvalidType();
8138     return;
8139 
8140   case PtrKernelParam:
8141   case ValidKernelParam:
8142     ValidTypes.insert(PT.getTypePtr());
8143     return;
8144 
8145   case RecordKernelParam:
8146     break;
8147   }
8148 
8149   // Track nested structs we will inspect
8150   SmallVector<const Decl *, 4> VisitStack;
8151 
8152   // Track where we are in the nested structs. Items will migrate from
8153   // VisitStack to HistoryStack as we do the DFS for bad field.
8154   SmallVector<const FieldDecl *, 4> HistoryStack;
8155   HistoryStack.push_back(nullptr);
8156 
8157   const RecordDecl *PD = PT->castAs<RecordType>()->getDecl();
8158   VisitStack.push_back(PD);
8159 
8160   assert(VisitStack.back() && "First decl null?");
8161 
8162   do {
8163     const Decl *Next = VisitStack.pop_back_val();
8164     if (!Next) {
8165       assert(!HistoryStack.empty());
8166       // Found a marker, we have gone up a level
8167       if (const FieldDecl *Hist = HistoryStack.pop_back_val())
8168         ValidTypes.insert(Hist->getType().getTypePtr());
8169 
8170       continue;
8171     }
8172 
8173     // Adds everything except the original parameter declaration (which is not a
8174     // field itself) to the history stack.
8175     const RecordDecl *RD;
8176     if (const FieldDecl *Field = dyn_cast<FieldDecl>(Next)) {
8177       HistoryStack.push_back(Field);
8178       RD = Field->getType()->castAs<RecordType>()->getDecl();
8179     } else {
8180       RD = cast<RecordDecl>(Next);
8181     }
8182 
8183     // Add a null marker so we know when we've gone back up a level
8184     VisitStack.push_back(nullptr);
8185 
8186     for (const auto *FD : RD->fields()) {
8187       QualType QT = FD->getType();
8188 
8189       if (ValidTypes.count(QT.getTypePtr()))
8190         continue;
8191 
8192       OpenCLParamType ParamType = getOpenCLKernelParameterType(S, QT);
8193       if (ParamType == ValidKernelParam)
8194         continue;
8195 
8196       if (ParamType == RecordKernelParam) {
8197         VisitStack.push_back(FD);
8198         continue;
8199       }
8200 
8201       // OpenCL v1.2 s6.9.p:
8202       // Arguments to kernel functions that are declared to be a struct or union
8203       // do not allow OpenCL objects to be passed as elements of the struct or
8204       // union.
8205       if (ParamType == PtrKernelParam || ParamType == PtrPtrKernelParam ||
8206           ParamType == InvalidAddrSpacePtrKernelParam) {
8207         S.Diag(Param->getLocation(),
8208                diag::err_record_with_pointers_kernel_param)
8209           << PT->isUnionType()
8210           << PT;
8211       } else {
8212         S.Diag(Param->getLocation(), diag::err_bad_kernel_param_type) << PT;
8213       }
8214 
8215       S.Diag(PD->getLocation(), diag::note_within_field_of_type)
8216         << PD->getDeclName();
8217 
8218       // We have an error, now let's go back up through history and show where
8219       // the offending field came from
8220       for (ArrayRef<const FieldDecl *>::const_iterator
8221                I = HistoryStack.begin() + 1,
8222                E = HistoryStack.end();
8223            I != E; ++I) {
8224         const FieldDecl *OuterField = *I;
8225         S.Diag(OuterField->getLocation(), diag::note_within_field_of_type)
8226           << OuterField->getType();
8227       }
8228 
8229       S.Diag(FD->getLocation(), diag::note_illegal_field_declared_here)
8230         << QT->isPointerType()
8231         << QT;
8232       D.setInvalidType();
8233       return;
8234     }
8235   } while (!VisitStack.empty());
8236 }
8237 
8238 /// Find the DeclContext in which a tag is implicitly declared if we see an
8239 /// elaborated type specifier in the specified context, and lookup finds
8240 /// nothing.
8241 static DeclContext *getTagInjectionContext(DeclContext *DC) {
8242   while (!DC->isFileContext() && !DC->isFunctionOrMethod())
8243     DC = DC->getParent();
8244   return DC;
8245 }
8246 
8247 /// Find the Scope in which a tag is implicitly declared if we see an
8248 /// elaborated type specifier in the specified context, and lookup finds
8249 /// nothing.
8250 static Scope *getTagInjectionScope(Scope *S, const LangOptions &LangOpts) {
8251   while (S->isClassScope() ||
8252          (LangOpts.CPlusPlus &&
8253           S->isFunctionPrototypeScope()) ||
8254          ((S->getFlags() & Scope::DeclScope) == 0) ||
8255          (S->getEntity() && S->getEntity()->isTransparentContext()))
8256     S = S->getParent();
8257   return S;
8258 }
8259 
8260 NamedDecl*
8261 Sema::ActOnFunctionDeclarator(Scope *S, Declarator &D, DeclContext *DC,
8262                               TypeSourceInfo *TInfo, LookupResult &Previous,
8263                               MultiTemplateParamsArg TemplateParamLists,
8264                               bool &AddToScope) {
8265   QualType R = TInfo->getType();
8266 
8267   assert(R.getTypePtr()->isFunctionType());
8268 
8269   // TODO: consider using NameInfo for diagnostic.
8270   DeclarationNameInfo NameInfo = GetNameForDeclarator(D);
8271   DeclarationName Name = NameInfo.getName();
8272   StorageClass SC = getFunctionStorageClass(*this, D);
8273 
8274   if (DeclSpec::TSCS TSCS = D.getDeclSpec().getThreadStorageClassSpec())
8275     Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
8276          diag::err_invalid_thread)
8277       << DeclSpec::getSpecifierName(TSCS);
8278 
8279   if (D.isFirstDeclarationOfMember())
8280     adjustMemberFunctionCC(R, D.isStaticMember(), D.isCtorOrDtor(),
8281                            D.getIdentifierLoc());
8282 
8283   bool isFriend = false;
8284   FunctionTemplateDecl *FunctionTemplate = nullptr;
8285   bool isMemberSpecialization = false;
8286   bool isFunctionTemplateSpecialization = false;
8287 
8288   bool isDependentClassScopeExplicitSpecialization = false;
8289   bool HasExplicitTemplateArgs = false;
8290   TemplateArgumentListInfo TemplateArgs;
8291 
8292   bool isVirtualOkay = false;
8293 
8294   DeclContext *OriginalDC = DC;
8295   bool IsLocalExternDecl = adjustContextForLocalExternDecl(DC);
8296 
8297   FunctionDecl *NewFD = CreateNewFunctionDecl(*this, D, DC, R, TInfo, SC,
8298                                               isVirtualOkay);
8299   if (!NewFD) return nullptr;
8300 
8301   if (OriginalLexicalContext && OriginalLexicalContext->isObjCContainer())
8302     NewFD->setTopLevelDeclInObjCContainer();
8303 
8304   // Set the lexical context. If this is a function-scope declaration, or has a
8305   // C++ scope specifier, or is the object of a friend declaration, the lexical
8306   // context will be different from the semantic context.
8307   NewFD->setLexicalDeclContext(CurContext);
8308 
8309   if (IsLocalExternDecl)
8310     NewFD->setLocalExternDecl();
8311 
8312   if (getLangOpts().CPlusPlus) {
8313     bool isInline = D.getDeclSpec().isInlineSpecified();
8314     bool isVirtual = D.getDeclSpec().isVirtualSpecified();
8315     bool isExplicit = D.getDeclSpec().isExplicitSpecified();
8316     bool isConstexpr = D.getDeclSpec().isConstexprSpecified();
8317     bool isConcept = D.getDeclSpec().isConceptSpecified();
8318     isFriend = D.getDeclSpec().isFriendSpecified();
8319     if (isFriend && !isInline && D.isFunctionDefinition()) {
8320       // C++ [class.friend]p5
8321       //   A function can be defined in a friend declaration of a
8322       //   class . . . . Such a function is implicitly inline.
8323       NewFD->setImplicitlyInline();
8324     }
8325 
8326     // If this is a method defined in an __interface, and is not a constructor
8327     // or an overloaded operator, then set the pure flag (isVirtual will already
8328     // return true).
8329     if (const CXXRecordDecl *Parent =
8330           dyn_cast<CXXRecordDecl>(NewFD->getDeclContext())) {
8331       if (Parent->isInterface() && cast<CXXMethodDecl>(NewFD)->isUserProvided())
8332         NewFD->setPure(true);
8333 
8334       // C++ [class.union]p2
8335       //   A union can have member functions, but not virtual functions.
8336       if (isVirtual && Parent->isUnion())
8337         Diag(D.getDeclSpec().getVirtualSpecLoc(), diag::err_virtual_in_union);
8338     }
8339 
8340     SetNestedNameSpecifier(NewFD, D);
8341     isMemberSpecialization = false;
8342     isFunctionTemplateSpecialization = false;
8343     if (D.isInvalidType())
8344       NewFD->setInvalidDecl();
8345 
8346     // Match up the template parameter lists with the scope specifier, then
8347     // determine whether we have a template or a template specialization.
8348     bool Invalid = false;
8349     if (TemplateParameterList *TemplateParams =
8350             MatchTemplateParametersToScopeSpecifier(
8351                 D.getDeclSpec().getLocStart(), D.getIdentifierLoc(),
8352                 D.getCXXScopeSpec(),
8353                 D.getName().getKind() == UnqualifiedId::IK_TemplateId
8354                     ? D.getName().TemplateId
8355                     : nullptr,
8356                 TemplateParamLists, isFriend, isMemberSpecialization,
8357                 Invalid)) {
8358       if (TemplateParams->size() > 0) {
8359         // This is a function template
8360 
8361         // Check that we can declare a template here.
8362         if (CheckTemplateDeclScope(S, TemplateParams))
8363           NewFD->setInvalidDecl();
8364 
8365         // A destructor cannot be a template.
8366         if (Name.getNameKind() == DeclarationName::CXXDestructorName) {
8367           Diag(NewFD->getLocation(), diag::err_destructor_template);
8368           NewFD->setInvalidDecl();
8369         }
8370 
8371         // If we're adding a template to a dependent context, we may need to
8372         // rebuilding some of the types used within the template parameter list,
8373         // now that we know what the current instantiation is.
8374         if (DC->isDependentContext()) {
8375           ContextRAII SavedContext(*this, DC);
8376           if (RebuildTemplateParamsInCurrentInstantiation(TemplateParams))
8377             Invalid = true;
8378         }
8379 
8380         FunctionTemplate = FunctionTemplateDecl::Create(Context, DC,
8381                                                         NewFD->getLocation(),
8382                                                         Name, TemplateParams,
8383                                                         NewFD);
8384         FunctionTemplate->setLexicalDeclContext(CurContext);
8385         NewFD->setDescribedFunctionTemplate(FunctionTemplate);
8386 
8387         // For source fidelity, store the other template param lists.
8388         if (TemplateParamLists.size() > 1) {
8389           NewFD->setTemplateParameterListsInfo(Context,
8390                                                TemplateParamLists.drop_back(1));
8391         }
8392       } else {
8393         // This is a function template specialization.
8394         isFunctionTemplateSpecialization = true;
8395         // For source fidelity, store all the template param lists.
8396         if (TemplateParamLists.size() > 0)
8397           NewFD->setTemplateParameterListsInfo(Context, TemplateParamLists);
8398 
8399         // C++0x [temp.expl.spec]p20 forbids "template<> friend void foo(int);".
8400         if (isFriend) {
8401           // We want to remove the "template<>", found here.
8402           SourceRange RemoveRange = TemplateParams->getSourceRange();
8403 
8404           // If we remove the template<> and the name is not a
8405           // template-id, we're actually silently creating a problem:
8406           // the friend declaration will refer to an untemplated decl,
8407           // and clearly the user wants a template specialization.  So
8408           // we need to insert '<>' after the name.
8409           SourceLocation InsertLoc;
8410           if (D.getName().getKind() != UnqualifiedId::IK_TemplateId) {
8411             InsertLoc = D.getName().getSourceRange().getEnd();
8412             InsertLoc = getLocForEndOfToken(InsertLoc);
8413           }
8414 
8415           Diag(D.getIdentifierLoc(), diag::err_template_spec_decl_friend)
8416             << Name << RemoveRange
8417             << FixItHint::CreateRemoval(RemoveRange)
8418             << FixItHint::CreateInsertion(InsertLoc, "<>");
8419         }
8420       }
8421     }
8422     else {
8423       // All template param lists were matched against the scope specifier:
8424       // this is NOT (an explicit specialization of) a template.
8425       if (TemplateParamLists.size() > 0)
8426         // For source fidelity, store all the template param lists.
8427         NewFD->setTemplateParameterListsInfo(Context, TemplateParamLists);
8428     }
8429 
8430     if (Invalid) {
8431       NewFD->setInvalidDecl();
8432       if (FunctionTemplate)
8433         FunctionTemplate->setInvalidDecl();
8434     }
8435 
8436     // C++ [dcl.fct.spec]p5:
8437     //   The virtual specifier shall only be used in declarations of
8438     //   nonstatic class member functions that appear within a
8439     //   member-specification of a class declaration; see 10.3.
8440     //
8441     if (isVirtual && !NewFD->isInvalidDecl()) {
8442       if (!isVirtualOkay) {
8443         Diag(D.getDeclSpec().getVirtualSpecLoc(),
8444              diag::err_virtual_non_function);
8445       } else if (!CurContext->isRecord()) {
8446         // 'virtual' was specified outside of the class.
8447         Diag(D.getDeclSpec().getVirtualSpecLoc(),
8448              diag::err_virtual_out_of_class)
8449           << FixItHint::CreateRemoval(D.getDeclSpec().getVirtualSpecLoc());
8450       } else if (NewFD->getDescribedFunctionTemplate()) {
8451         // C++ [temp.mem]p3:
8452         //  A member function template shall not be virtual.
8453         Diag(D.getDeclSpec().getVirtualSpecLoc(),
8454              diag::err_virtual_member_function_template)
8455           << FixItHint::CreateRemoval(D.getDeclSpec().getVirtualSpecLoc());
8456       } else {
8457         // Okay: Add virtual to the method.
8458         NewFD->setVirtualAsWritten(true);
8459       }
8460 
8461       if (getLangOpts().CPlusPlus14 &&
8462           NewFD->getReturnType()->isUndeducedType())
8463         Diag(D.getDeclSpec().getVirtualSpecLoc(), diag::err_auto_fn_virtual);
8464     }
8465 
8466     if (getLangOpts().CPlusPlus14 &&
8467         (NewFD->isDependentContext() ||
8468          (isFriend && CurContext->isDependentContext())) &&
8469         NewFD->getReturnType()->isUndeducedType()) {
8470       // If the function template is referenced directly (for instance, as a
8471       // member of the current instantiation), pretend it has a dependent type.
8472       // This is not really justified by the standard, but is the only sane
8473       // thing to do.
8474       // FIXME: For a friend function, we have not marked the function as being
8475       // a friend yet, so 'isDependentContext' on the FD doesn't work.
8476       const FunctionProtoType *FPT =
8477           NewFD->getType()->castAs<FunctionProtoType>();
8478       QualType Result =
8479           SubstAutoType(FPT->getReturnType(), Context.DependentTy);
8480       NewFD->setType(Context.getFunctionType(Result, FPT->getParamTypes(),
8481                                              FPT->getExtProtoInfo()));
8482     }
8483 
8484     // C++ [dcl.fct.spec]p3:
8485     //  The inline specifier shall not appear on a block scope function
8486     //  declaration.
8487     if (isInline && !NewFD->isInvalidDecl()) {
8488       if (CurContext->isFunctionOrMethod()) {
8489         // 'inline' is not allowed on block scope function declaration.
8490         Diag(D.getDeclSpec().getInlineSpecLoc(),
8491              diag::err_inline_declaration_block_scope) << Name
8492           << FixItHint::CreateRemoval(D.getDeclSpec().getInlineSpecLoc());
8493       }
8494     }
8495 
8496     // C++ [dcl.fct.spec]p6:
8497     //  The explicit specifier shall be used only in the declaration of a
8498     //  constructor or conversion function within its class definition;
8499     //  see 12.3.1 and 12.3.2.
8500     if (isExplicit && !NewFD->isInvalidDecl() &&
8501         !isa<CXXDeductionGuideDecl>(NewFD)) {
8502       if (!CurContext->isRecord()) {
8503         // 'explicit' was specified outside of the class.
8504         Diag(D.getDeclSpec().getExplicitSpecLoc(),
8505              diag::err_explicit_out_of_class)
8506           << FixItHint::CreateRemoval(D.getDeclSpec().getExplicitSpecLoc());
8507       } else if (!isa<CXXConstructorDecl>(NewFD) &&
8508                  !isa<CXXConversionDecl>(NewFD)) {
8509         // 'explicit' was specified on a function that wasn't a constructor
8510         // or conversion function.
8511         Diag(D.getDeclSpec().getExplicitSpecLoc(),
8512              diag::err_explicit_non_ctor_or_conv_function)
8513           << FixItHint::CreateRemoval(D.getDeclSpec().getExplicitSpecLoc());
8514       }
8515     }
8516 
8517     if (isConstexpr) {
8518       // C++11 [dcl.constexpr]p2: constexpr functions and constexpr constructors
8519       // are implicitly inline.
8520       NewFD->setImplicitlyInline();
8521 
8522       // C++11 [dcl.constexpr]p3: functions declared constexpr are required to
8523       // be either constructors or to return a literal type. Therefore,
8524       // destructors cannot be declared constexpr.
8525       if (isa<CXXDestructorDecl>(NewFD))
8526         Diag(D.getDeclSpec().getConstexprSpecLoc(), diag::err_constexpr_dtor);
8527     }
8528 
8529     if (isConcept) {
8530       // This is a function concept.
8531       if (FunctionTemplateDecl *FTD = NewFD->getDescribedFunctionTemplate())
8532         FTD->setConcept();
8533 
8534       // C++ Concepts TS [dcl.spec.concept]p1: The concept specifier shall be
8535       // applied only to the definition of a function template [...]
8536       if (!D.isFunctionDefinition()) {
8537         Diag(D.getDeclSpec().getConceptSpecLoc(),
8538              diag::err_function_concept_not_defined);
8539         NewFD->setInvalidDecl();
8540       }
8541 
8542       // C++ Concepts TS [dcl.spec.concept]p1: [...] A function concept shall
8543       // have no exception-specification and is treated as if it were specified
8544       // with noexcept(true) (15.4). [...]
8545       if (const FunctionProtoType *FPT = R->getAs<FunctionProtoType>()) {
8546         if (FPT->hasExceptionSpec()) {
8547           SourceRange Range;
8548           if (D.isFunctionDeclarator())
8549             Range = D.getFunctionTypeInfo().getExceptionSpecRange();
8550           Diag(NewFD->getLocation(), diag::err_function_concept_exception_spec)
8551               << FixItHint::CreateRemoval(Range);
8552           NewFD->setInvalidDecl();
8553         } else {
8554           Context.adjustExceptionSpec(NewFD, EST_BasicNoexcept);
8555         }
8556 
8557         // C++ Concepts TS [dcl.spec.concept]p5: A function concept has the
8558         // following restrictions:
8559         // - The declared return type shall have the type bool.
8560         if (!Context.hasSameType(FPT->getReturnType(), Context.BoolTy)) {
8561           Diag(D.getIdentifierLoc(), diag::err_function_concept_bool_ret);
8562           NewFD->setInvalidDecl();
8563         }
8564 
8565         // C++ Concepts TS [dcl.spec.concept]p5: A function concept has the
8566         // following restrictions:
8567         // - The declaration's parameter list shall be equivalent to an empty
8568         //   parameter list.
8569         if (FPT->getNumParams() > 0 || FPT->isVariadic())
8570           Diag(NewFD->getLocation(), diag::err_function_concept_with_params);
8571       }
8572 
8573       // C++ Concepts TS [dcl.spec.concept]p2: Every concept definition is
8574       // implicity defined to be a constexpr declaration (implicitly inline)
8575       NewFD->setImplicitlyInline();
8576 
8577       // C++ Concepts TS [dcl.spec.concept]p2: A concept definition shall not
8578       // be declared with the thread_local, inline, friend, or constexpr
8579       // specifiers, [...]
8580       if (isInline) {
8581         Diag(D.getDeclSpec().getInlineSpecLoc(),
8582              diag::err_concept_decl_invalid_specifiers)
8583             << 1 << 1;
8584         NewFD->setInvalidDecl(true);
8585       }
8586 
8587       if (isFriend) {
8588         Diag(D.getDeclSpec().getFriendSpecLoc(),
8589              diag::err_concept_decl_invalid_specifiers)
8590             << 1 << 2;
8591         NewFD->setInvalidDecl(true);
8592       }
8593 
8594       if (isConstexpr) {
8595         Diag(D.getDeclSpec().getConstexprSpecLoc(),
8596              diag::err_concept_decl_invalid_specifiers)
8597             << 1 << 3;
8598         NewFD->setInvalidDecl(true);
8599       }
8600 
8601       // C++ Concepts TS [dcl.spec.concept]p1: The concept specifier shall be
8602       // applied only to the definition of a function template or variable
8603       // template, declared in namespace scope.
8604       if (isFunctionTemplateSpecialization) {
8605         Diag(D.getDeclSpec().getConceptSpecLoc(),
8606              diag::err_concept_specified_specialization) << 1;
8607         NewFD->setInvalidDecl(true);
8608         return NewFD;
8609       }
8610     }
8611 
8612     // If __module_private__ was specified, mark the function accordingly.
8613     if (D.getDeclSpec().isModulePrivateSpecified()) {
8614       if (isFunctionTemplateSpecialization) {
8615         SourceLocation ModulePrivateLoc
8616           = D.getDeclSpec().getModulePrivateSpecLoc();
8617         Diag(ModulePrivateLoc, diag::err_module_private_specialization)
8618           << 0
8619           << FixItHint::CreateRemoval(ModulePrivateLoc);
8620       } else {
8621         NewFD->setModulePrivate();
8622         if (FunctionTemplate)
8623           FunctionTemplate->setModulePrivate();
8624       }
8625     }
8626 
8627     if (isFriend) {
8628       if (FunctionTemplate) {
8629         FunctionTemplate->setObjectOfFriendDecl();
8630         FunctionTemplate->setAccess(AS_public);
8631       }
8632       NewFD->setObjectOfFriendDecl();
8633       NewFD->setAccess(AS_public);
8634     }
8635 
8636     // If a function is defined as defaulted or deleted, mark it as such now.
8637     // FIXME: Does this ever happen? ActOnStartOfFunctionDef forces the function
8638     // definition kind to FDK_Definition.
8639     switch (D.getFunctionDefinitionKind()) {
8640       case FDK_Declaration:
8641       case FDK_Definition:
8642         break;
8643 
8644       case FDK_Defaulted:
8645         NewFD->setDefaulted();
8646         break;
8647 
8648       case FDK_Deleted:
8649         NewFD->setDeletedAsWritten();
8650         break;
8651     }
8652 
8653     if (isa<CXXMethodDecl>(NewFD) && DC == CurContext &&
8654         D.isFunctionDefinition()) {
8655       // C++ [class.mfct]p2:
8656       //   A member function may be defined (8.4) in its class definition, in
8657       //   which case it is an inline member function (7.1.2)
8658       NewFD->setImplicitlyInline();
8659     }
8660 
8661     if (SC == SC_Static && isa<CXXMethodDecl>(NewFD) &&
8662         !CurContext->isRecord()) {
8663       // C++ [class.static]p1:
8664       //   A data or function member of a class may be declared static
8665       //   in a class definition, in which case it is a static member of
8666       //   the class.
8667 
8668       // Complain about the 'static' specifier if it's on an out-of-line
8669       // member function definition.
8670       Diag(D.getDeclSpec().getStorageClassSpecLoc(),
8671            diag::err_static_out_of_line)
8672         << FixItHint::CreateRemoval(D.getDeclSpec().getStorageClassSpecLoc());
8673     }
8674 
8675     // C++11 [except.spec]p15:
8676     //   A deallocation function with no exception-specification is treated
8677     //   as if it were specified with noexcept(true).
8678     const FunctionProtoType *FPT = R->getAs<FunctionProtoType>();
8679     if ((Name.getCXXOverloadedOperator() == OO_Delete ||
8680          Name.getCXXOverloadedOperator() == OO_Array_Delete) &&
8681         getLangOpts().CPlusPlus11 && FPT && !FPT->hasExceptionSpec())
8682       NewFD->setType(Context.getFunctionType(
8683           FPT->getReturnType(), FPT->getParamTypes(),
8684           FPT->getExtProtoInfo().withExceptionSpec(EST_BasicNoexcept)));
8685   }
8686 
8687   // Filter out previous declarations that don't match the scope.
8688   FilterLookupForScope(Previous, OriginalDC, S, shouldConsiderLinkage(NewFD),
8689                        D.getCXXScopeSpec().isNotEmpty() ||
8690                        isMemberSpecialization ||
8691                        isFunctionTemplateSpecialization);
8692 
8693   // Handle GNU asm-label extension (encoded as an attribute).
8694   if (Expr *E = (Expr*) D.getAsmLabel()) {
8695     // The parser guarantees this is a string.
8696     StringLiteral *SE = cast<StringLiteral>(E);
8697     NewFD->addAttr(::new (Context) AsmLabelAttr(SE->getStrTokenLoc(0), Context,
8698                                                 SE->getString(), 0));
8699   } else if (!ExtnameUndeclaredIdentifiers.empty()) {
8700     llvm::DenseMap<IdentifierInfo*,AsmLabelAttr*>::iterator I =
8701       ExtnameUndeclaredIdentifiers.find(NewFD->getIdentifier());
8702     if (I != ExtnameUndeclaredIdentifiers.end()) {
8703       if (isDeclExternC(NewFD)) {
8704         NewFD->addAttr(I->second);
8705         ExtnameUndeclaredIdentifiers.erase(I);
8706       } else
8707         Diag(NewFD->getLocation(), diag::warn_redefine_extname_not_applied)
8708             << /*Variable*/0 << NewFD;
8709     }
8710   }
8711 
8712   // Copy the parameter declarations from the declarator D to the function
8713   // declaration NewFD, if they are available.  First scavenge them into Params.
8714   SmallVector<ParmVarDecl*, 16> Params;
8715   unsigned FTIIdx;
8716   if (D.isFunctionDeclarator(FTIIdx)) {
8717     DeclaratorChunk::FunctionTypeInfo &FTI = D.getTypeObject(FTIIdx).Fun;
8718 
8719     // Check for C99 6.7.5.3p10 - foo(void) is a non-varargs
8720     // function that takes no arguments, not a function that takes a
8721     // single void argument.
8722     // We let through "const void" here because Sema::GetTypeForDeclarator
8723     // already checks for that case.
8724     if (FTIHasNonVoidParameters(FTI) && FTI.Params[0].Param) {
8725       for (unsigned i = 0, e = FTI.NumParams; i != e; ++i) {
8726         ParmVarDecl *Param = cast<ParmVarDecl>(FTI.Params[i].Param);
8727         assert(Param->getDeclContext() != NewFD && "Was set before ?");
8728         Param->setDeclContext(NewFD);
8729         Params.push_back(Param);
8730 
8731         if (Param->isInvalidDecl())
8732           NewFD->setInvalidDecl();
8733       }
8734     }
8735 
8736     if (!getLangOpts().CPlusPlus) {
8737       // In C, find all the tag declarations from the prototype and move them
8738       // into the function DeclContext. Remove them from the surrounding tag
8739       // injection context of the function, which is typically but not always
8740       // the TU.
8741       DeclContext *PrototypeTagContext =
8742           getTagInjectionContext(NewFD->getLexicalDeclContext());
8743       for (NamedDecl *NonParmDecl : FTI.getDeclsInPrototype()) {
8744         auto *TD = dyn_cast<TagDecl>(NonParmDecl);
8745 
8746         // We don't want to reparent enumerators. Look at their parent enum
8747         // instead.
8748         if (!TD) {
8749           if (auto *ECD = dyn_cast<EnumConstantDecl>(NonParmDecl))
8750             TD = cast<EnumDecl>(ECD->getDeclContext());
8751         }
8752         if (!TD)
8753           continue;
8754         DeclContext *TagDC = TD->getLexicalDeclContext();
8755         if (!TagDC->containsDecl(TD))
8756           continue;
8757         TagDC->removeDecl(TD);
8758         TD->setDeclContext(NewFD);
8759         NewFD->addDecl(TD);
8760 
8761         // Preserve the lexical DeclContext if it is not the surrounding tag
8762         // injection context of the FD. In this example, the semantic context of
8763         // E will be f and the lexical context will be S, while both the
8764         // semantic and lexical contexts of S will be f:
8765         //   void f(struct S { enum E { a } f; } s);
8766         if (TagDC != PrototypeTagContext)
8767           TD->setLexicalDeclContext(TagDC);
8768       }
8769     }
8770   } else if (const FunctionProtoType *FT = R->getAs<FunctionProtoType>()) {
8771     // When we're declaring a function with a typedef, typeof, etc as in the
8772     // following example, we'll need to synthesize (unnamed)
8773     // parameters for use in the declaration.
8774     //
8775     // @code
8776     // typedef void fn(int);
8777     // fn f;
8778     // @endcode
8779 
8780     // Synthesize a parameter for each argument type.
8781     for (const auto &AI : FT->param_types()) {
8782       ParmVarDecl *Param =
8783           BuildParmVarDeclForTypedef(NewFD, D.getIdentifierLoc(), AI);
8784       Param->setScopeInfo(0, Params.size());
8785       Params.push_back(Param);
8786     }
8787   } else {
8788     assert(R->isFunctionNoProtoType() && NewFD->getNumParams() == 0 &&
8789            "Should not need args for typedef of non-prototype fn");
8790   }
8791 
8792   // Finally, we know we have the right number of parameters, install them.
8793   NewFD->setParams(Params);
8794 
8795   if (D.getDeclSpec().isNoreturnSpecified())
8796     NewFD->addAttr(
8797         ::new(Context) C11NoReturnAttr(D.getDeclSpec().getNoreturnSpecLoc(),
8798                                        Context, 0));
8799 
8800   // Functions returning a variably modified type violate C99 6.7.5.2p2
8801   // because all functions have linkage.
8802   if (!NewFD->isInvalidDecl() &&
8803       NewFD->getReturnType()->isVariablyModifiedType()) {
8804     Diag(NewFD->getLocation(), diag::err_vm_func_decl);
8805     NewFD->setInvalidDecl();
8806   }
8807 
8808   // Apply an implicit SectionAttr if '#pragma clang section text' is active
8809   if (PragmaClangTextSection.Valid && D.isFunctionDefinition() &&
8810       !NewFD->hasAttr<SectionAttr>()) {
8811     NewFD->addAttr(PragmaClangTextSectionAttr::CreateImplicit(Context,
8812                                                  PragmaClangTextSection.SectionName,
8813                                                  PragmaClangTextSection.PragmaLocation));
8814   }
8815 
8816   // Apply an implicit SectionAttr if #pragma code_seg is active.
8817   if (CodeSegStack.CurrentValue && D.isFunctionDefinition() &&
8818       !NewFD->hasAttr<SectionAttr>()) {
8819     NewFD->addAttr(
8820         SectionAttr::CreateImplicit(Context, SectionAttr::Declspec_allocate,
8821                                     CodeSegStack.CurrentValue->getString(),
8822                                     CodeSegStack.CurrentPragmaLocation));
8823     if (UnifySection(CodeSegStack.CurrentValue->getString(),
8824                      ASTContext::PSF_Implicit | ASTContext::PSF_Execute |
8825                          ASTContext::PSF_Read,
8826                      NewFD))
8827       NewFD->dropAttr<SectionAttr>();
8828   }
8829 
8830   // Handle attributes.
8831   ProcessDeclAttributes(S, NewFD, D);
8832 
8833   if (getLangOpts().OpenCL) {
8834     // OpenCL v1.1 s6.5: Using an address space qualifier in a function return
8835     // type declaration will generate a compilation error.
8836     LangAS AddressSpace = NewFD->getReturnType().getAddressSpace();
8837     if (AddressSpace != LangAS::Default) {
8838       Diag(NewFD->getLocation(),
8839            diag::err_opencl_return_value_with_address_space);
8840       NewFD->setInvalidDecl();
8841     }
8842   }
8843 
8844   if (!getLangOpts().CPlusPlus) {
8845     // Perform semantic checking on the function declaration.
8846     if (!NewFD->isInvalidDecl() && NewFD->isMain())
8847       CheckMain(NewFD, D.getDeclSpec());
8848 
8849     if (!NewFD->isInvalidDecl() && NewFD->isMSVCRTEntryPoint())
8850       CheckMSVCRTEntryPoint(NewFD);
8851 
8852     if (!NewFD->isInvalidDecl())
8853       D.setRedeclaration(CheckFunctionDeclaration(S, NewFD, Previous,
8854                                                   isMemberSpecialization));
8855     else if (!Previous.empty())
8856       // Recover gracefully from an invalid redeclaration.
8857       D.setRedeclaration(true);
8858     assert((NewFD->isInvalidDecl() || !D.isRedeclaration() ||
8859             Previous.getResultKind() != LookupResult::FoundOverloaded) &&
8860            "previous declaration set still overloaded");
8861 
8862     // Diagnose no-prototype function declarations with calling conventions that
8863     // don't support variadic calls. Only do this in C and do it after merging
8864     // possibly prototyped redeclarations.
8865     const FunctionType *FT = NewFD->getType()->castAs<FunctionType>();
8866     if (isa<FunctionNoProtoType>(FT) && !D.isFunctionDefinition()) {
8867       CallingConv CC = FT->getExtInfo().getCC();
8868       if (!supportsVariadicCall(CC)) {
8869         // Windows system headers sometimes accidentally use stdcall without
8870         // (void) parameters, so we relax this to a warning.
8871         int DiagID =
8872             CC == CC_X86StdCall ? diag::warn_cconv_knr : diag::err_cconv_knr;
8873         Diag(NewFD->getLocation(), DiagID)
8874             << FunctionType::getNameForCallConv(CC);
8875       }
8876     }
8877   } else {
8878     // C++11 [replacement.functions]p3:
8879     //  The program's definitions shall not be specified as inline.
8880     //
8881     // N.B. We diagnose declarations instead of definitions per LWG issue 2340.
8882     //
8883     // Suppress the diagnostic if the function is __attribute__((used)), since
8884     // that forces an external definition to be emitted.
8885     if (D.getDeclSpec().isInlineSpecified() &&
8886         NewFD->isReplaceableGlobalAllocationFunction() &&
8887         !NewFD->hasAttr<UsedAttr>())
8888       Diag(D.getDeclSpec().getInlineSpecLoc(),
8889            diag::ext_operator_new_delete_declared_inline)
8890         << NewFD->getDeclName();
8891 
8892     // If the declarator is a template-id, translate the parser's template
8893     // argument list into our AST format.
8894     if (D.getName().getKind() == UnqualifiedId::IK_TemplateId) {
8895       TemplateIdAnnotation *TemplateId = D.getName().TemplateId;
8896       TemplateArgs.setLAngleLoc(TemplateId->LAngleLoc);
8897       TemplateArgs.setRAngleLoc(TemplateId->RAngleLoc);
8898       ASTTemplateArgsPtr TemplateArgsPtr(TemplateId->getTemplateArgs(),
8899                                          TemplateId->NumArgs);
8900       translateTemplateArguments(TemplateArgsPtr,
8901                                  TemplateArgs);
8902 
8903       HasExplicitTemplateArgs = true;
8904 
8905       if (NewFD->isInvalidDecl()) {
8906         HasExplicitTemplateArgs = false;
8907       } else if (FunctionTemplate) {
8908         // Function template with explicit template arguments.
8909         Diag(D.getIdentifierLoc(), diag::err_function_template_partial_spec)
8910           << SourceRange(TemplateId->LAngleLoc, TemplateId->RAngleLoc);
8911 
8912         HasExplicitTemplateArgs = false;
8913       } else {
8914         assert((isFunctionTemplateSpecialization ||
8915                 D.getDeclSpec().isFriendSpecified()) &&
8916                "should have a 'template<>' for this decl");
8917         // "friend void foo<>(int);" is an implicit specialization decl.
8918         isFunctionTemplateSpecialization = true;
8919       }
8920     } else if (isFriend && isFunctionTemplateSpecialization) {
8921       // This combination is only possible in a recovery case;  the user
8922       // wrote something like:
8923       //   template <> friend void foo(int);
8924       // which we're recovering from as if the user had written:
8925       //   friend void foo<>(int);
8926       // Go ahead and fake up a template id.
8927       HasExplicitTemplateArgs = true;
8928       TemplateArgs.setLAngleLoc(D.getIdentifierLoc());
8929       TemplateArgs.setRAngleLoc(D.getIdentifierLoc());
8930     }
8931 
8932     // We do not add HD attributes to specializations here because
8933     // they may have different constexpr-ness compared to their
8934     // templates and, after maybeAddCUDAHostDeviceAttrs() is applied,
8935     // may end up with different effective targets. Instead, a
8936     // specialization inherits its target attributes from its template
8937     // in the CheckFunctionTemplateSpecialization() call below.
8938     if (getLangOpts().CUDA & !isFunctionTemplateSpecialization)
8939       maybeAddCUDAHostDeviceAttrs(NewFD, Previous);
8940 
8941     // If it's a friend (and only if it's a friend), it's possible
8942     // that either the specialized function type or the specialized
8943     // template is dependent, and therefore matching will fail.  In
8944     // this case, don't check the specialization yet.
8945     bool InstantiationDependent = false;
8946     if (isFunctionTemplateSpecialization && isFriend &&
8947         (NewFD->getType()->isDependentType() || DC->isDependentContext() ||
8948          TemplateSpecializationType::anyDependentTemplateArguments(
8949             TemplateArgs,
8950             InstantiationDependent))) {
8951       assert(HasExplicitTemplateArgs &&
8952              "friend function specialization without template args");
8953       if (CheckDependentFunctionTemplateSpecialization(NewFD, TemplateArgs,
8954                                                        Previous))
8955         NewFD->setInvalidDecl();
8956     } else if (isFunctionTemplateSpecialization) {
8957       if (CurContext->isDependentContext() && CurContext->isRecord()
8958           && !isFriend) {
8959         isDependentClassScopeExplicitSpecialization = true;
8960         Diag(NewFD->getLocation(), getLangOpts().MicrosoftExt ?
8961           diag::ext_function_specialization_in_class :
8962           diag::err_function_specialization_in_class)
8963           << NewFD->getDeclName();
8964       } else if (CheckFunctionTemplateSpecialization(NewFD,
8965                                   (HasExplicitTemplateArgs ? &TemplateArgs
8966                                                            : nullptr),
8967                                                      Previous))
8968         NewFD->setInvalidDecl();
8969 
8970       // C++ [dcl.stc]p1:
8971       //   A storage-class-specifier shall not be specified in an explicit
8972       //   specialization (14.7.3)
8973       FunctionTemplateSpecializationInfo *Info =
8974           NewFD->getTemplateSpecializationInfo();
8975       if (Info && SC != SC_None) {
8976         if (SC != Info->getTemplate()->getTemplatedDecl()->getStorageClass())
8977           Diag(NewFD->getLocation(),
8978                diag::err_explicit_specialization_inconsistent_storage_class)
8979             << SC
8980             << FixItHint::CreateRemoval(
8981                                       D.getDeclSpec().getStorageClassSpecLoc());
8982 
8983         else
8984           Diag(NewFD->getLocation(),
8985                diag::ext_explicit_specialization_storage_class)
8986             << FixItHint::CreateRemoval(
8987                                       D.getDeclSpec().getStorageClassSpecLoc());
8988       }
8989     } else if (isMemberSpecialization && isa<CXXMethodDecl>(NewFD)) {
8990       if (CheckMemberSpecialization(NewFD, Previous))
8991           NewFD->setInvalidDecl();
8992     }
8993 
8994     // Perform semantic checking on the function declaration.
8995     if (!isDependentClassScopeExplicitSpecialization) {
8996       if (!NewFD->isInvalidDecl() && NewFD->isMain())
8997         CheckMain(NewFD, D.getDeclSpec());
8998 
8999       if (!NewFD->isInvalidDecl() && NewFD->isMSVCRTEntryPoint())
9000         CheckMSVCRTEntryPoint(NewFD);
9001 
9002       if (!NewFD->isInvalidDecl())
9003         D.setRedeclaration(CheckFunctionDeclaration(S, NewFD, Previous,
9004                                                     isMemberSpecialization));
9005       else if (!Previous.empty())
9006         // Recover gracefully from an invalid redeclaration.
9007         D.setRedeclaration(true);
9008     }
9009 
9010     assert((NewFD->isInvalidDecl() || !D.isRedeclaration() ||
9011             Previous.getResultKind() != LookupResult::FoundOverloaded) &&
9012            "previous declaration set still overloaded");
9013 
9014     NamedDecl *PrincipalDecl = (FunctionTemplate
9015                                 ? cast<NamedDecl>(FunctionTemplate)
9016                                 : NewFD);
9017 
9018     if (isFriend && NewFD->getPreviousDecl()) {
9019       AccessSpecifier Access = AS_public;
9020       if (!NewFD->isInvalidDecl())
9021         Access = NewFD->getPreviousDecl()->getAccess();
9022 
9023       NewFD->setAccess(Access);
9024       if (FunctionTemplate) FunctionTemplate->setAccess(Access);
9025     }
9026 
9027     if (NewFD->isOverloadedOperator() && !DC->isRecord() &&
9028         PrincipalDecl->isInIdentifierNamespace(Decl::IDNS_Ordinary))
9029       PrincipalDecl->setNonMemberOperator();
9030 
9031     // If we have a function template, check the template parameter
9032     // list. This will check and merge default template arguments.
9033     if (FunctionTemplate) {
9034       FunctionTemplateDecl *PrevTemplate =
9035                                      FunctionTemplate->getPreviousDecl();
9036       CheckTemplateParameterList(FunctionTemplate->getTemplateParameters(),
9037                        PrevTemplate ? PrevTemplate->getTemplateParameters()
9038                                     : nullptr,
9039                             D.getDeclSpec().isFriendSpecified()
9040                               ? (D.isFunctionDefinition()
9041                                    ? TPC_FriendFunctionTemplateDefinition
9042                                    : TPC_FriendFunctionTemplate)
9043                               : (D.getCXXScopeSpec().isSet() &&
9044                                  DC && DC->isRecord() &&
9045                                  DC->isDependentContext())
9046                                   ? TPC_ClassTemplateMember
9047                                   : TPC_FunctionTemplate);
9048     }
9049 
9050     if (NewFD->isInvalidDecl()) {
9051       // Ignore all the rest of this.
9052     } else if (!D.isRedeclaration()) {
9053       struct ActOnFDArgs ExtraArgs = { S, D, TemplateParamLists,
9054                                        AddToScope };
9055       // Fake up an access specifier if it's supposed to be a class member.
9056       if (isa<CXXRecordDecl>(NewFD->getDeclContext()))
9057         NewFD->setAccess(AS_public);
9058 
9059       // Qualified decls generally require a previous declaration.
9060       if (D.getCXXScopeSpec().isSet()) {
9061         // ...with the major exception of templated-scope or
9062         // dependent-scope friend declarations.
9063 
9064         // TODO: we currently also suppress this check in dependent
9065         // contexts because (1) the parameter depth will be off when
9066         // matching friend templates and (2) we might actually be
9067         // selecting a friend based on a dependent factor.  But there
9068         // are situations where these conditions don't apply and we
9069         // can actually do this check immediately.
9070         if (isFriend &&
9071             (TemplateParamLists.size() ||
9072              D.getCXXScopeSpec().getScopeRep()->isDependent() ||
9073              CurContext->isDependentContext())) {
9074           // ignore these
9075         } else {
9076           // The user tried to provide an out-of-line definition for a
9077           // function that is a member of a class or namespace, but there
9078           // was no such member function declared (C++ [class.mfct]p2,
9079           // C++ [namespace.memdef]p2). For example:
9080           //
9081           // class X {
9082           //   void f() const;
9083           // };
9084           //
9085           // void X::f() { } // ill-formed
9086           //
9087           // Complain about this problem, and attempt to suggest close
9088           // matches (e.g., those that differ only in cv-qualifiers and
9089           // whether the parameter types are references).
9090 
9091           if (NamedDecl *Result = DiagnoseInvalidRedeclaration(
9092                   *this, Previous, NewFD, ExtraArgs, false, nullptr)) {
9093             AddToScope = ExtraArgs.AddToScope;
9094             return Result;
9095           }
9096         }
9097 
9098         // Unqualified local friend declarations are required to resolve
9099         // to something.
9100       } else if (isFriend && cast<CXXRecordDecl>(CurContext)->isLocalClass()) {
9101         if (NamedDecl *Result = DiagnoseInvalidRedeclaration(
9102                 *this, Previous, NewFD, ExtraArgs, true, S)) {
9103           AddToScope = ExtraArgs.AddToScope;
9104           return Result;
9105         }
9106       }
9107     } else if (!D.isFunctionDefinition() &&
9108                isa<CXXMethodDecl>(NewFD) && NewFD->isOutOfLine() &&
9109                !isFriend && !isFunctionTemplateSpecialization &&
9110                !isMemberSpecialization) {
9111       // An out-of-line member function declaration must also be a
9112       // definition (C++ [class.mfct]p2).
9113       // Note that this is not the case for explicit specializations of
9114       // function templates or member functions of class templates, per
9115       // C++ [temp.expl.spec]p2. We also allow these declarations as an
9116       // extension for compatibility with old SWIG code which likes to
9117       // generate them.
9118       Diag(NewFD->getLocation(), diag::ext_out_of_line_declaration)
9119         << D.getCXXScopeSpec().getRange();
9120     }
9121   }
9122 
9123   ProcessPragmaWeak(S, NewFD);
9124   checkAttributesAfterMerging(*this, *NewFD);
9125 
9126   AddKnownFunctionAttributes(NewFD);
9127 
9128   if (NewFD->hasAttr<OverloadableAttr>() &&
9129       !NewFD->getType()->getAs<FunctionProtoType>()) {
9130     Diag(NewFD->getLocation(),
9131          diag::err_attribute_overloadable_no_prototype)
9132       << NewFD;
9133 
9134     // Turn this into a variadic function with no parameters.
9135     const FunctionType *FT = NewFD->getType()->getAs<FunctionType>();
9136     FunctionProtoType::ExtProtoInfo EPI(
9137         Context.getDefaultCallingConvention(true, false));
9138     EPI.Variadic = true;
9139     EPI.ExtInfo = FT->getExtInfo();
9140 
9141     QualType R = Context.getFunctionType(FT->getReturnType(), None, EPI);
9142     NewFD->setType(R);
9143   }
9144 
9145   // If there's a #pragma GCC visibility in scope, and this isn't a class
9146   // member, set the visibility of this function.
9147   if (!DC->isRecord() && NewFD->isExternallyVisible())
9148     AddPushedVisibilityAttribute(NewFD);
9149 
9150   // If there's a #pragma clang arc_cf_code_audited in scope, consider
9151   // marking the function.
9152   AddCFAuditedAttribute(NewFD);
9153 
9154   // If this is a function definition, check if we have to apply optnone due to
9155   // a pragma.
9156   if(D.isFunctionDefinition())
9157     AddRangeBasedOptnone(NewFD);
9158 
9159   // If this is the first declaration of an extern C variable, update
9160   // the map of such variables.
9161   if (NewFD->isFirstDecl() && !NewFD->isInvalidDecl() &&
9162       isIncompleteDeclExternC(*this, NewFD))
9163     RegisterLocallyScopedExternCDecl(NewFD, S);
9164 
9165   // Set this FunctionDecl's range up to the right paren.
9166   NewFD->setRangeEnd(D.getSourceRange().getEnd());
9167 
9168   if (D.isRedeclaration() && !Previous.empty()) {
9169     checkDLLAttributeRedeclaration(
9170         *this, dyn_cast<NamedDecl>(Previous.getRepresentativeDecl()), NewFD,
9171         isMemberSpecialization || isFunctionTemplateSpecialization,
9172         D.isFunctionDefinition());
9173   }
9174 
9175   if (getLangOpts().CUDA) {
9176     IdentifierInfo *II = NewFD->getIdentifier();
9177     if (II && II->isStr("cudaConfigureCall") && !NewFD->isInvalidDecl() &&
9178         NewFD->getDeclContext()->getRedeclContext()->isTranslationUnit()) {
9179       if (!R->getAs<FunctionType>()->getReturnType()->isScalarType())
9180         Diag(NewFD->getLocation(), diag::err_config_scalar_return);
9181 
9182       Context.setcudaConfigureCallDecl(NewFD);
9183     }
9184 
9185     // Variadic functions, other than a *declaration* of printf, are not allowed
9186     // in device-side CUDA code, unless someone passed
9187     // -fcuda-allow-variadic-functions.
9188     if (!getLangOpts().CUDAAllowVariadicFunctions && NewFD->isVariadic() &&
9189         (NewFD->hasAttr<CUDADeviceAttr>() ||
9190          NewFD->hasAttr<CUDAGlobalAttr>()) &&
9191         !(II && II->isStr("printf") && NewFD->isExternC() &&
9192           !D.isFunctionDefinition())) {
9193       Diag(NewFD->getLocation(), diag::err_variadic_device_fn);
9194     }
9195   }
9196 
9197   MarkUnusedFileScopedDecl(NewFD);
9198 
9199   if (getLangOpts().CPlusPlus) {
9200     if (FunctionTemplate) {
9201       if (NewFD->isInvalidDecl())
9202         FunctionTemplate->setInvalidDecl();
9203       return FunctionTemplate;
9204     }
9205 
9206     if (isMemberSpecialization && !NewFD->isInvalidDecl())
9207       CompleteMemberSpecialization(NewFD, Previous);
9208   }
9209 
9210   if (NewFD->hasAttr<OpenCLKernelAttr>()) {
9211     // OpenCL v1.2 s6.8 static is invalid for kernel functions.
9212     if ((getLangOpts().OpenCLVersion >= 120)
9213         && (SC == SC_Static)) {
9214       Diag(D.getIdentifierLoc(), diag::err_static_kernel);
9215       D.setInvalidType();
9216     }
9217 
9218     // OpenCL v1.2, s6.9 -- Kernels can only have return type void.
9219     if (!NewFD->getReturnType()->isVoidType()) {
9220       SourceRange RTRange = NewFD->getReturnTypeSourceRange();
9221       Diag(D.getIdentifierLoc(), diag::err_expected_kernel_void_return_type)
9222           << (RTRange.isValid() ? FixItHint::CreateReplacement(RTRange, "void")
9223                                 : FixItHint());
9224       D.setInvalidType();
9225     }
9226 
9227     llvm::SmallPtrSet<const Type *, 16> ValidTypes;
9228     for (auto Param : NewFD->parameters())
9229       checkIsValidOpenCLKernelParameter(*this, D, Param, ValidTypes);
9230   }
9231   for (const ParmVarDecl *Param : NewFD->parameters()) {
9232     QualType PT = Param->getType();
9233 
9234     // OpenCL 2.0 pipe restrictions forbids pipe packet types to be non-value
9235     // types.
9236     if (getLangOpts().OpenCLVersion >= 200) {
9237       if(const PipeType *PipeTy = PT->getAs<PipeType>()) {
9238         QualType ElemTy = PipeTy->getElementType();
9239           if (ElemTy->isReferenceType() || ElemTy->isPointerType()) {
9240             Diag(Param->getTypeSpecStartLoc(), diag::err_reference_pipe_type );
9241             D.setInvalidType();
9242           }
9243       }
9244     }
9245   }
9246 
9247   // Here we have an function template explicit specialization at class scope.
9248   // The actually specialization will be postponed to template instatiation
9249   // time via the ClassScopeFunctionSpecializationDecl node.
9250   if (isDependentClassScopeExplicitSpecialization) {
9251     ClassScopeFunctionSpecializationDecl *NewSpec =
9252                          ClassScopeFunctionSpecializationDecl::Create(
9253                                 Context, CurContext, SourceLocation(),
9254                                 cast<CXXMethodDecl>(NewFD),
9255                                 HasExplicitTemplateArgs, TemplateArgs);
9256     CurContext->addDecl(NewSpec);
9257     AddToScope = false;
9258   }
9259 
9260   return NewFD;
9261 }
9262 
9263 /// \brief Checks if the new declaration declared in dependent context must be
9264 /// put in the same redeclaration chain as the specified declaration.
9265 ///
9266 /// \param D Declaration that is checked.
9267 /// \param PrevDecl Previous declaration found with proper lookup method for the
9268 ///                 same declaration name.
9269 /// \returns True if D must be added to the redeclaration chain which PrevDecl
9270 ///          belongs to.
9271 ///
9272 bool Sema::shouldLinkDependentDeclWithPrevious(Decl *D, Decl *PrevDecl) {
9273   // Any declarations should be put into redeclaration chains except for
9274   // friend declaration in a dependent context that names a function in
9275   // namespace scope.
9276   //
9277   // This allows to compile code like:
9278   //
9279   //       void func();
9280   //       template<typename T> class C1 { friend void func() { } };
9281   //       template<typename T> class C2 { friend void func() { } };
9282   //
9283   // This code snippet is a valid code unless both templates are instantiated.
9284   return !(D->getLexicalDeclContext()->isDependentContext() &&
9285            D->getDeclContext()->isFileContext() &&
9286            D->getFriendObjectKind() != Decl::FOK_None);
9287 }
9288 
9289 /// \brief Perform semantic checking of a new function declaration.
9290 ///
9291 /// Performs semantic analysis of the new function declaration
9292 /// NewFD. This routine performs all semantic checking that does not
9293 /// require the actual declarator involved in the declaration, and is
9294 /// used both for the declaration of functions as they are parsed
9295 /// (called via ActOnDeclarator) and for the declaration of functions
9296 /// that have been instantiated via C++ template instantiation (called
9297 /// via InstantiateDecl).
9298 ///
9299 /// \param IsMemberSpecialization whether this new function declaration is
9300 /// a member specialization (that replaces any definition provided by the
9301 /// previous declaration).
9302 ///
9303 /// This sets NewFD->isInvalidDecl() to true if there was an error.
9304 ///
9305 /// \returns true if the function declaration is a redeclaration.
9306 bool Sema::CheckFunctionDeclaration(Scope *S, FunctionDecl *NewFD,
9307                                     LookupResult &Previous,
9308                                     bool IsMemberSpecialization) {
9309   assert(!NewFD->getReturnType()->isVariablyModifiedType() &&
9310          "Variably modified return types are not handled here");
9311 
9312   // Determine whether the type of this function should be merged with
9313   // a previous visible declaration. This never happens for functions in C++,
9314   // and always happens in C if the previous declaration was visible.
9315   bool MergeTypeWithPrevious = !getLangOpts().CPlusPlus &&
9316                                !Previous.isShadowed();
9317 
9318   bool Redeclaration = false;
9319   NamedDecl *OldDecl = nullptr;
9320   bool MayNeedOverloadableChecks = false;
9321 
9322   // Merge or overload the declaration with an existing declaration of
9323   // the same name, if appropriate.
9324   if (!Previous.empty()) {
9325     // Determine whether NewFD is an overload of PrevDecl or
9326     // a declaration that requires merging. If it's an overload,
9327     // there's no more work to do here; we'll just add the new
9328     // function to the scope.
9329     if (!AllowOverloadingOfFunction(Previous, Context, NewFD)) {
9330       NamedDecl *Candidate = Previous.getRepresentativeDecl();
9331       if (shouldLinkPossiblyHiddenDecl(Candidate, NewFD)) {
9332         Redeclaration = true;
9333         OldDecl = Candidate;
9334       }
9335     } else {
9336       MayNeedOverloadableChecks = true;
9337       switch (CheckOverload(S, NewFD, Previous, OldDecl,
9338                             /*NewIsUsingDecl*/ false)) {
9339       case Ovl_Match:
9340         Redeclaration = true;
9341         break;
9342 
9343       case Ovl_NonFunction:
9344         Redeclaration = true;
9345         break;
9346 
9347       case Ovl_Overload:
9348         Redeclaration = false;
9349         break;
9350       }
9351     }
9352   }
9353 
9354   // Check for a previous extern "C" declaration with this name.
9355   if (!Redeclaration &&
9356       checkForConflictWithNonVisibleExternC(*this, NewFD, Previous)) {
9357     if (!Previous.empty()) {
9358       // This is an extern "C" declaration with the same name as a previous
9359       // declaration, and thus redeclares that entity...
9360       Redeclaration = true;
9361       OldDecl = Previous.getFoundDecl();
9362       MergeTypeWithPrevious = false;
9363 
9364       // ... except in the presence of __attribute__((overloadable)).
9365       if (OldDecl->hasAttr<OverloadableAttr>() ||
9366           NewFD->hasAttr<OverloadableAttr>()) {
9367         if (IsOverload(NewFD, cast<FunctionDecl>(OldDecl), false)) {
9368           MayNeedOverloadableChecks = true;
9369           Redeclaration = false;
9370           OldDecl = nullptr;
9371         }
9372       }
9373     }
9374   }
9375 
9376   // C++11 [dcl.constexpr]p8:
9377   //   A constexpr specifier for a non-static member function that is not
9378   //   a constructor declares that member function to be const.
9379   //
9380   // This needs to be delayed until we know whether this is an out-of-line
9381   // definition of a static member function.
9382   //
9383   // This rule is not present in C++1y, so we produce a backwards
9384   // compatibility warning whenever it happens in C++11.
9385   CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(NewFD);
9386   if (!getLangOpts().CPlusPlus14 && MD && MD->isConstexpr() &&
9387       !MD->isStatic() && !isa<CXXConstructorDecl>(MD) &&
9388       (MD->getTypeQualifiers() & Qualifiers::Const) == 0) {
9389     CXXMethodDecl *OldMD = nullptr;
9390     if (OldDecl)
9391       OldMD = dyn_cast_or_null<CXXMethodDecl>(OldDecl->getAsFunction());
9392     if (!OldMD || !OldMD->isStatic()) {
9393       const FunctionProtoType *FPT =
9394         MD->getType()->castAs<FunctionProtoType>();
9395       FunctionProtoType::ExtProtoInfo EPI = FPT->getExtProtoInfo();
9396       EPI.TypeQuals |= Qualifiers::Const;
9397       MD->setType(Context.getFunctionType(FPT->getReturnType(),
9398                                           FPT->getParamTypes(), EPI));
9399 
9400       // Warn that we did this, if we're not performing template instantiation.
9401       // In that case, we'll have warned already when the template was defined.
9402       if (!inTemplateInstantiation()) {
9403         SourceLocation AddConstLoc;
9404         if (FunctionTypeLoc FTL = MD->getTypeSourceInfo()->getTypeLoc()
9405                 .IgnoreParens().getAs<FunctionTypeLoc>())
9406           AddConstLoc = getLocForEndOfToken(FTL.getRParenLoc());
9407 
9408         Diag(MD->getLocation(), diag::warn_cxx14_compat_constexpr_not_const)
9409           << FixItHint::CreateInsertion(AddConstLoc, " const");
9410       }
9411     }
9412   }
9413 
9414   if (Redeclaration) {
9415     // NewFD and OldDecl represent declarations that need to be
9416     // merged.
9417     if (MergeFunctionDecl(NewFD, OldDecl, S, MergeTypeWithPrevious)) {
9418       NewFD->setInvalidDecl();
9419       return Redeclaration;
9420     }
9421 
9422     Previous.clear();
9423     Previous.addDecl(OldDecl);
9424 
9425     if (FunctionTemplateDecl *OldTemplateDecl
9426                                   = dyn_cast<FunctionTemplateDecl>(OldDecl)) {
9427       NewFD->setPreviousDeclaration(OldTemplateDecl->getTemplatedDecl());
9428       FunctionTemplateDecl *NewTemplateDecl
9429         = NewFD->getDescribedFunctionTemplate();
9430       assert(NewTemplateDecl && "Template/non-template mismatch");
9431       if (CXXMethodDecl *Method
9432             = dyn_cast<CXXMethodDecl>(NewTemplateDecl->getTemplatedDecl())) {
9433         Method->setAccess(OldTemplateDecl->getAccess());
9434         NewTemplateDecl->setAccess(OldTemplateDecl->getAccess());
9435       }
9436 
9437       // If this is an explicit specialization of a member that is a function
9438       // template, mark it as a member specialization.
9439       if (IsMemberSpecialization &&
9440           NewTemplateDecl->getInstantiatedFromMemberTemplate()) {
9441         NewTemplateDecl->setMemberSpecialization();
9442         assert(OldTemplateDecl->isMemberSpecialization());
9443         // Explicit specializations of a member template do not inherit deleted
9444         // status from the parent member template that they are specializing.
9445         if (OldTemplateDecl->getTemplatedDecl()->isDeleted()) {
9446           FunctionDecl *const OldTemplatedDecl =
9447               OldTemplateDecl->getTemplatedDecl();
9448           // FIXME: This assert will not hold in the presence of modules.
9449           assert(OldTemplatedDecl->getCanonicalDecl() == OldTemplatedDecl);
9450           // FIXME: We need an update record for this AST mutation.
9451           OldTemplatedDecl->setDeletedAsWritten(false);
9452         }
9453       }
9454 
9455     } else {
9456       if (shouldLinkDependentDeclWithPrevious(NewFD, OldDecl)) {
9457         // This needs to happen first so that 'inline' propagates.
9458         NewFD->setPreviousDeclaration(cast<FunctionDecl>(OldDecl));
9459         if (isa<CXXMethodDecl>(NewFD))
9460           NewFD->setAccess(OldDecl->getAccess());
9461       }
9462     }
9463   } else if (!getLangOpts().CPlusPlus && MayNeedOverloadableChecks &&
9464              !NewFD->getAttr<OverloadableAttr>()) {
9465     assert((Previous.empty() ||
9466             llvm::any_of(Previous,
9467                          [](const NamedDecl *ND) {
9468                            return ND->hasAttr<OverloadableAttr>();
9469                          })) &&
9470            "Non-redecls shouldn't happen without overloadable present");
9471 
9472     auto OtherUnmarkedIter = llvm::find_if(Previous, [](const NamedDecl *ND) {
9473       const auto *FD = dyn_cast<FunctionDecl>(ND);
9474       return FD && !FD->hasAttr<OverloadableAttr>();
9475     });
9476 
9477     if (OtherUnmarkedIter != Previous.end()) {
9478       Diag(NewFD->getLocation(),
9479            diag::err_attribute_overloadable_multiple_unmarked_overloads);
9480       Diag((*OtherUnmarkedIter)->getLocation(),
9481            diag::note_attribute_overloadable_prev_overload)
9482           << false;
9483 
9484       NewFD->addAttr(OverloadableAttr::CreateImplicit(Context));
9485     }
9486   }
9487 
9488   // Semantic checking for this function declaration (in isolation).
9489 
9490   if (getLangOpts().CPlusPlus) {
9491     // C++-specific checks.
9492     if (CXXConstructorDecl *Constructor = dyn_cast<CXXConstructorDecl>(NewFD)) {
9493       CheckConstructor(Constructor);
9494     } else if (CXXDestructorDecl *Destructor =
9495                 dyn_cast<CXXDestructorDecl>(NewFD)) {
9496       CXXRecordDecl *Record = Destructor->getParent();
9497       QualType ClassType = Context.getTypeDeclType(Record);
9498 
9499       // FIXME: Shouldn't we be able to perform this check even when the class
9500       // type is dependent? Both gcc and edg can handle that.
9501       if (!ClassType->isDependentType()) {
9502         DeclarationName Name
9503           = Context.DeclarationNames.getCXXDestructorName(
9504                                         Context.getCanonicalType(ClassType));
9505         if (NewFD->getDeclName() != Name) {
9506           Diag(NewFD->getLocation(), diag::err_destructor_name);
9507           NewFD->setInvalidDecl();
9508           return Redeclaration;
9509         }
9510       }
9511     } else if (CXXConversionDecl *Conversion
9512                = dyn_cast<CXXConversionDecl>(NewFD)) {
9513       ActOnConversionDeclarator(Conversion);
9514     } else if (auto *Guide = dyn_cast<CXXDeductionGuideDecl>(NewFD)) {
9515       if (auto *TD = Guide->getDescribedFunctionTemplate())
9516         CheckDeductionGuideTemplate(TD);
9517 
9518       // A deduction guide is not on the list of entities that can be
9519       // explicitly specialized.
9520       if (Guide->getTemplateSpecializationKind() == TSK_ExplicitSpecialization)
9521         Diag(Guide->getLocStart(), diag::err_deduction_guide_specialized)
9522             << /*explicit specialization*/ 1;
9523     }
9524 
9525     // Find any virtual functions that this function overrides.
9526     if (CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(NewFD)) {
9527       if (!Method->isFunctionTemplateSpecialization() &&
9528           !Method->getDescribedFunctionTemplate() &&
9529           Method->isCanonicalDecl()) {
9530         if (AddOverriddenMethods(Method->getParent(), Method)) {
9531           // If the function was marked as "static", we have a problem.
9532           if (NewFD->getStorageClass() == SC_Static) {
9533             ReportOverrides(*this, diag::err_static_overrides_virtual, Method);
9534           }
9535         }
9536       }
9537 
9538       if (Method->isStatic())
9539         checkThisInStaticMemberFunctionType(Method);
9540     }
9541 
9542     // Extra checking for C++ overloaded operators (C++ [over.oper]).
9543     if (NewFD->isOverloadedOperator() &&
9544         CheckOverloadedOperatorDeclaration(NewFD)) {
9545       NewFD->setInvalidDecl();
9546       return Redeclaration;
9547     }
9548 
9549     // Extra checking for C++0x literal operators (C++0x [over.literal]).
9550     if (NewFD->getLiteralIdentifier() &&
9551         CheckLiteralOperatorDeclaration(NewFD)) {
9552       NewFD->setInvalidDecl();
9553       return Redeclaration;
9554     }
9555 
9556     // In C++, check default arguments now that we have merged decls. Unless
9557     // the lexical context is the class, because in this case this is done
9558     // during delayed parsing anyway.
9559     if (!CurContext->isRecord())
9560       CheckCXXDefaultArguments(NewFD);
9561 
9562     // If this function declares a builtin function, check the type of this
9563     // declaration against the expected type for the builtin.
9564     if (unsigned BuiltinID = NewFD->getBuiltinID()) {
9565       ASTContext::GetBuiltinTypeError Error;
9566       LookupPredefedObjCSuperType(*this, S, NewFD->getIdentifier());
9567       QualType T = Context.GetBuiltinType(BuiltinID, Error);
9568       // If the type of the builtin differs only in its exception
9569       // specification, that's OK.
9570       // FIXME: If the types do differ in this way, it would be better to
9571       // retain the 'noexcept' form of the type.
9572       if (!T.isNull() &&
9573           !Context.hasSameFunctionTypeIgnoringExceptionSpec(T,
9574                                                             NewFD->getType()))
9575         // The type of this function differs from the type of the builtin,
9576         // so forget about the builtin entirely.
9577         Context.BuiltinInfo.forgetBuiltin(BuiltinID, Context.Idents);
9578     }
9579 
9580     // If this function is declared as being extern "C", then check to see if
9581     // the function returns a UDT (class, struct, or union type) that is not C
9582     // compatible, and if it does, warn the user.
9583     // But, issue any diagnostic on the first declaration only.
9584     if (Previous.empty() && NewFD->isExternC()) {
9585       QualType R = NewFD->getReturnType();
9586       if (R->isIncompleteType() && !R->isVoidType())
9587         Diag(NewFD->getLocation(), diag::warn_return_value_udt_incomplete)
9588             << NewFD << R;
9589       else if (!R.isPODType(Context) && !R->isVoidType() &&
9590                !R->isObjCObjectPointerType())
9591         Diag(NewFD->getLocation(), diag::warn_return_value_udt) << NewFD << R;
9592     }
9593 
9594     // C++1z [dcl.fct]p6:
9595     //   [...] whether the function has a non-throwing exception-specification
9596     //   [is] part of the function type
9597     //
9598     // This results in an ABI break between C++14 and C++17 for functions whose
9599     // declared type includes an exception-specification in a parameter or
9600     // return type. (Exception specifications on the function itself are OK in
9601     // most cases, and exception specifications are not permitted in most other
9602     // contexts where they could make it into a mangling.)
9603     if (!getLangOpts().CPlusPlus1z && !NewFD->getPrimaryTemplate()) {
9604       auto HasNoexcept = [&](QualType T) -> bool {
9605         // Strip off declarator chunks that could be between us and a function
9606         // type. We don't need to look far, exception specifications are very
9607         // restricted prior to C++17.
9608         if (auto *RT = T->getAs<ReferenceType>())
9609           T = RT->getPointeeType();
9610         else if (T->isAnyPointerType())
9611           T = T->getPointeeType();
9612         else if (auto *MPT = T->getAs<MemberPointerType>())
9613           T = MPT->getPointeeType();
9614         if (auto *FPT = T->getAs<FunctionProtoType>())
9615           if (FPT->isNothrow(Context))
9616             return true;
9617         return false;
9618       };
9619 
9620       auto *FPT = NewFD->getType()->castAs<FunctionProtoType>();
9621       bool AnyNoexcept = HasNoexcept(FPT->getReturnType());
9622       for (QualType T : FPT->param_types())
9623         AnyNoexcept |= HasNoexcept(T);
9624       if (AnyNoexcept)
9625         Diag(NewFD->getLocation(),
9626              diag::warn_cxx17_compat_exception_spec_in_signature)
9627             << NewFD;
9628     }
9629 
9630     if (!Redeclaration && LangOpts.CUDA)
9631       checkCUDATargetOverload(NewFD, Previous);
9632   }
9633   return Redeclaration;
9634 }
9635 
9636 void Sema::CheckMain(FunctionDecl* FD, const DeclSpec& DS) {
9637   // C++11 [basic.start.main]p3:
9638   //   A program that [...] declares main to be inline, static or
9639   //   constexpr is ill-formed.
9640   // C11 6.7.4p4:  In a hosted environment, no function specifier(s) shall
9641   //   appear in a declaration of main.
9642   // static main is not an error under C99, but we should warn about it.
9643   // We accept _Noreturn main as an extension.
9644   if (FD->getStorageClass() == SC_Static)
9645     Diag(DS.getStorageClassSpecLoc(), getLangOpts().CPlusPlus
9646          ? diag::err_static_main : diag::warn_static_main)
9647       << FixItHint::CreateRemoval(DS.getStorageClassSpecLoc());
9648   if (FD->isInlineSpecified())
9649     Diag(DS.getInlineSpecLoc(), diag::err_inline_main)
9650       << FixItHint::CreateRemoval(DS.getInlineSpecLoc());
9651   if (DS.isNoreturnSpecified()) {
9652     SourceLocation NoreturnLoc = DS.getNoreturnSpecLoc();
9653     SourceRange NoreturnRange(NoreturnLoc, getLocForEndOfToken(NoreturnLoc));
9654     Diag(NoreturnLoc, diag::ext_noreturn_main);
9655     Diag(NoreturnLoc, diag::note_main_remove_noreturn)
9656       << FixItHint::CreateRemoval(NoreturnRange);
9657   }
9658   if (FD->isConstexpr()) {
9659     Diag(DS.getConstexprSpecLoc(), diag::err_constexpr_main)
9660       << FixItHint::CreateRemoval(DS.getConstexprSpecLoc());
9661     FD->setConstexpr(false);
9662   }
9663 
9664   if (getLangOpts().OpenCL) {
9665     Diag(FD->getLocation(), diag::err_opencl_no_main)
9666         << FD->hasAttr<OpenCLKernelAttr>();
9667     FD->setInvalidDecl();
9668     return;
9669   }
9670 
9671   QualType T = FD->getType();
9672   assert(T->isFunctionType() && "function decl is not of function type");
9673   const FunctionType* FT = T->castAs<FunctionType>();
9674 
9675   if (getLangOpts().GNUMode && !getLangOpts().CPlusPlus) {
9676     // In C with GNU extensions we allow main() to have non-integer return
9677     // type, but we should warn about the extension, and we disable the
9678     // implicit-return-zero rule.
9679 
9680     // GCC in C mode accepts qualified 'int'.
9681     if (Context.hasSameUnqualifiedType(FT->getReturnType(), Context.IntTy))
9682       FD->setHasImplicitReturnZero(true);
9683     else {
9684       Diag(FD->getTypeSpecStartLoc(), diag::ext_main_returns_nonint);
9685       SourceRange RTRange = FD->getReturnTypeSourceRange();
9686       if (RTRange.isValid())
9687         Diag(RTRange.getBegin(), diag::note_main_change_return_type)
9688             << FixItHint::CreateReplacement(RTRange, "int");
9689     }
9690   } else {
9691     // In C and C++, main magically returns 0 if you fall off the end;
9692     // set the flag which tells us that.
9693     // This is C++ [basic.start.main]p5 and C99 5.1.2.2.3.
9694 
9695     // All the standards say that main() should return 'int'.
9696     if (Context.hasSameType(FT->getReturnType(), Context.IntTy))
9697       FD->setHasImplicitReturnZero(true);
9698     else {
9699       // Otherwise, this is just a flat-out error.
9700       SourceRange RTRange = FD->getReturnTypeSourceRange();
9701       Diag(FD->getTypeSpecStartLoc(), diag::err_main_returns_nonint)
9702           << (RTRange.isValid() ? FixItHint::CreateReplacement(RTRange, "int")
9703                                 : FixItHint());
9704       FD->setInvalidDecl(true);
9705     }
9706   }
9707 
9708   // Treat protoless main() as nullary.
9709   if (isa<FunctionNoProtoType>(FT)) return;
9710 
9711   const FunctionProtoType* FTP = cast<const FunctionProtoType>(FT);
9712   unsigned nparams = FTP->getNumParams();
9713   assert(FD->getNumParams() == nparams);
9714 
9715   bool HasExtraParameters = (nparams > 3);
9716 
9717   if (FTP->isVariadic()) {
9718     Diag(FD->getLocation(), diag::ext_variadic_main);
9719     // FIXME: if we had information about the location of the ellipsis, we
9720     // could add a FixIt hint to remove it as a parameter.
9721   }
9722 
9723   // Darwin passes an undocumented fourth argument of type char**.  If
9724   // other platforms start sprouting these, the logic below will start
9725   // getting shifty.
9726   if (nparams == 4 && Context.getTargetInfo().getTriple().isOSDarwin())
9727     HasExtraParameters = false;
9728 
9729   if (HasExtraParameters) {
9730     Diag(FD->getLocation(), diag::err_main_surplus_args) << nparams;
9731     FD->setInvalidDecl(true);
9732     nparams = 3;
9733   }
9734 
9735   // FIXME: a lot of the following diagnostics would be improved
9736   // if we had some location information about types.
9737 
9738   QualType CharPP =
9739     Context.getPointerType(Context.getPointerType(Context.CharTy));
9740   QualType Expected[] = { Context.IntTy, CharPP, CharPP, CharPP };
9741 
9742   for (unsigned i = 0; i < nparams; ++i) {
9743     QualType AT = FTP->getParamType(i);
9744 
9745     bool mismatch = true;
9746 
9747     if (Context.hasSameUnqualifiedType(AT, Expected[i]))
9748       mismatch = false;
9749     else if (Expected[i] == CharPP) {
9750       // As an extension, the following forms are okay:
9751       //   char const **
9752       //   char const * const *
9753       //   char * const *
9754 
9755       QualifierCollector qs;
9756       const PointerType* PT;
9757       if ((PT = qs.strip(AT)->getAs<PointerType>()) &&
9758           (PT = qs.strip(PT->getPointeeType())->getAs<PointerType>()) &&
9759           Context.hasSameType(QualType(qs.strip(PT->getPointeeType()), 0),
9760                               Context.CharTy)) {
9761         qs.removeConst();
9762         mismatch = !qs.empty();
9763       }
9764     }
9765 
9766     if (mismatch) {
9767       Diag(FD->getLocation(), diag::err_main_arg_wrong) << i << Expected[i];
9768       // TODO: suggest replacing given type with expected type
9769       FD->setInvalidDecl(true);
9770     }
9771   }
9772 
9773   if (nparams == 1 && !FD->isInvalidDecl()) {
9774     Diag(FD->getLocation(), diag::warn_main_one_arg);
9775   }
9776 
9777   if (!FD->isInvalidDecl() && FD->getDescribedFunctionTemplate()) {
9778     Diag(FD->getLocation(), diag::err_mainlike_template_decl) << FD;
9779     FD->setInvalidDecl();
9780   }
9781 }
9782 
9783 void Sema::CheckMSVCRTEntryPoint(FunctionDecl *FD) {
9784   QualType T = FD->getType();
9785   assert(T->isFunctionType() && "function decl is not of function type");
9786   const FunctionType *FT = T->castAs<FunctionType>();
9787 
9788   // Set an implicit return of 'zero' if the function can return some integral,
9789   // enumeration, pointer or nullptr type.
9790   if (FT->getReturnType()->isIntegralOrEnumerationType() ||
9791       FT->getReturnType()->isAnyPointerType() ||
9792       FT->getReturnType()->isNullPtrType())
9793     // DllMain is exempt because a return value of zero means it failed.
9794     if (FD->getName() != "DllMain")
9795       FD->setHasImplicitReturnZero(true);
9796 
9797   if (!FD->isInvalidDecl() && FD->getDescribedFunctionTemplate()) {
9798     Diag(FD->getLocation(), diag::err_mainlike_template_decl) << FD;
9799     FD->setInvalidDecl();
9800   }
9801 }
9802 
9803 bool Sema::CheckForConstantInitializer(Expr *Init, QualType DclT) {
9804   // FIXME: Need strict checking.  In C89, we need to check for
9805   // any assignment, increment, decrement, function-calls, or
9806   // commas outside of a sizeof.  In C99, it's the same list,
9807   // except that the aforementioned are allowed in unevaluated
9808   // expressions.  Everything else falls under the
9809   // "may accept other forms of constant expressions" exception.
9810   // (We never end up here for C++, so the constant expression
9811   // rules there don't matter.)
9812   const Expr *Culprit;
9813   if (Init->isConstantInitializer(Context, false, &Culprit))
9814     return false;
9815   Diag(Culprit->getExprLoc(), diag::err_init_element_not_constant)
9816     << Culprit->getSourceRange();
9817   return true;
9818 }
9819 
9820 namespace {
9821   // Visits an initialization expression to see if OrigDecl is evaluated in
9822   // its own initialization and throws a warning if it does.
9823   class SelfReferenceChecker
9824       : public EvaluatedExprVisitor<SelfReferenceChecker> {
9825     Sema &S;
9826     Decl *OrigDecl;
9827     bool isRecordType;
9828     bool isPODType;
9829     bool isReferenceType;
9830 
9831     bool isInitList;
9832     llvm::SmallVector<unsigned, 4> InitFieldIndex;
9833 
9834   public:
9835     typedef EvaluatedExprVisitor<SelfReferenceChecker> Inherited;
9836 
9837     SelfReferenceChecker(Sema &S, Decl *OrigDecl) : Inherited(S.Context),
9838                                                     S(S), OrigDecl(OrigDecl) {
9839       isPODType = false;
9840       isRecordType = false;
9841       isReferenceType = false;
9842       isInitList = false;
9843       if (ValueDecl *VD = dyn_cast<ValueDecl>(OrigDecl)) {
9844         isPODType = VD->getType().isPODType(S.Context);
9845         isRecordType = VD->getType()->isRecordType();
9846         isReferenceType = VD->getType()->isReferenceType();
9847       }
9848     }
9849 
9850     // For most expressions, just call the visitor.  For initializer lists,
9851     // track the index of the field being initialized since fields are
9852     // initialized in order allowing use of previously initialized fields.
9853     void CheckExpr(Expr *E) {
9854       InitListExpr *InitList = dyn_cast<InitListExpr>(E);
9855       if (!InitList) {
9856         Visit(E);
9857         return;
9858       }
9859 
9860       // Track and increment the index here.
9861       isInitList = true;
9862       InitFieldIndex.push_back(0);
9863       for (auto Child : InitList->children()) {
9864         CheckExpr(cast<Expr>(Child));
9865         ++InitFieldIndex.back();
9866       }
9867       InitFieldIndex.pop_back();
9868     }
9869 
9870     // Returns true if MemberExpr is checked and no further checking is needed.
9871     // Returns false if additional checking is required.
9872     bool CheckInitListMemberExpr(MemberExpr *E, bool CheckReference) {
9873       llvm::SmallVector<FieldDecl*, 4> Fields;
9874       Expr *Base = E;
9875       bool ReferenceField = false;
9876 
9877       // Get the field memebers used.
9878       while (MemberExpr *ME = dyn_cast<MemberExpr>(Base)) {
9879         FieldDecl *FD = dyn_cast<FieldDecl>(ME->getMemberDecl());
9880         if (!FD)
9881           return false;
9882         Fields.push_back(FD);
9883         if (FD->getType()->isReferenceType())
9884           ReferenceField = true;
9885         Base = ME->getBase()->IgnoreParenImpCasts();
9886       }
9887 
9888       // Keep checking only if the base Decl is the same.
9889       DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Base);
9890       if (!DRE || DRE->getDecl() != OrigDecl)
9891         return false;
9892 
9893       // A reference field can be bound to an unininitialized field.
9894       if (CheckReference && !ReferenceField)
9895         return true;
9896 
9897       // Convert FieldDecls to their index number.
9898       llvm::SmallVector<unsigned, 4> UsedFieldIndex;
9899       for (const FieldDecl *I : llvm::reverse(Fields))
9900         UsedFieldIndex.push_back(I->getFieldIndex());
9901 
9902       // See if a warning is needed by checking the first difference in index
9903       // numbers.  If field being used has index less than the field being
9904       // initialized, then the use is safe.
9905       for (auto UsedIter = UsedFieldIndex.begin(),
9906                 UsedEnd = UsedFieldIndex.end(),
9907                 OrigIter = InitFieldIndex.begin(),
9908                 OrigEnd = InitFieldIndex.end();
9909            UsedIter != UsedEnd && OrigIter != OrigEnd; ++UsedIter, ++OrigIter) {
9910         if (*UsedIter < *OrigIter)
9911           return true;
9912         if (*UsedIter > *OrigIter)
9913           break;
9914       }
9915 
9916       // TODO: Add a different warning which will print the field names.
9917       HandleDeclRefExpr(DRE);
9918       return true;
9919     }
9920 
9921     // For most expressions, the cast is directly above the DeclRefExpr.
9922     // For conditional operators, the cast can be outside the conditional
9923     // operator if both expressions are DeclRefExpr's.
9924     void HandleValue(Expr *E) {
9925       E = E->IgnoreParens();
9926       if (DeclRefExpr* DRE = dyn_cast<DeclRefExpr>(E)) {
9927         HandleDeclRefExpr(DRE);
9928         return;
9929       }
9930 
9931       if (ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) {
9932         Visit(CO->getCond());
9933         HandleValue(CO->getTrueExpr());
9934         HandleValue(CO->getFalseExpr());
9935         return;
9936       }
9937 
9938       if (BinaryConditionalOperator *BCO =
9939               dyn_cast<BinaryConditionalOperator>(E)) {
9940         Visit(BCO->getCond());
9941         HandleValue(BCO->getFalseExpr());
9942         return;
9943       }
9944 
9945       if (OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) {
9946         HandleValue(OVE->getSourceExpr());
9947         return;
9948       }
9949 
9950       if (BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) {
9951         if (BO->getOpcode() == BO_Comma) {
9952           Visit(BO->getLHS());
9953           HandleValue(BO->getRHS());
9954           return;
9955         }
9956       }
9957 
9958       if (isa<MemberExpr>(E)) {
9959         if (isInitList) {
9960           if (CheckInitListMemberExpr(cast<MemberExpr>(E),
9961                                       false /*CheckReference*/))
9962             return;
9963         }
9964 
9965         Expr *Base = E->IgnoreParenImpCasts();
9966         while (MemberExpr *ME = dyn_cast<MemberExpr>(Base)) {
9967           // Check for static member variables and don't warn on them.
9968           if (!isa<FieldDecl>(ME->getMemberDecl()))
9969             return;
9970           Base = ME->getBase()->IgnoreParenImpCasts();
9971         }
9972         if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Base))
9973           HandleDeclRefExpr(DRE);
9974         return;
9975       }
9976 
9977       Visit(E);
9978     }
9979 
9980     // Reference types not handled in HandleValue are handled here since all
9981     // uses of references are bad, not just r-value uses.
9982     void VisitDeclRefExpr(DeclRefExpr *E) {
9983       if (isReferenceType)
9984         HandleDeclRefExpr(E);
9985     }
9986 
9987     void VisitImplicitCastExpr(ImplicitCastExpr *E) {
9988       if (E->getCastKind() == CK_LValueToRValue) {
9989         HandleValue(E->getSubExpr());
9990         return;
9991       }
9992 
9993       Inherited::VisitImplicitCastExpr(E);
9994     }
9995 
9996     void VisitMemberExpr(MemberExpr *E) {
9997       if (isInitList) {
9998         if (CheckInitListMemberExpr(E, true /*CheckReference*/))
9999           return;
10000       }
10001 
10002       // Don't warn on arrays since they can be treated as pointers.
10003       if (E->getType()->canDecayToPointerType()) return;
10004 
10005       // Warn when a non-static method call is followed by non-static member
10006       // field accesses, which is followed by a DeclRefExpr.
10007       CXXMethodDecl *MD = dyn_cast<CXXMethodDecl>(E->getMemberDecl());
10008       bool Warn = (MD && !MD->isStatic());
10009       Expr *Base = E->getBase()->IgnoreParenImpCasts();
10010       while (MemberExpr *ME = dyn_cast<MemberExpr>(Base)) {
10011         if (!isa<FieldDecl>(ME->getMemberDecl()))
10012           Warn = false;
10013         Base = ME->getBase()->IgnoreParenImpCasts();
10014       }
10015 
10016       if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(Base)) {
10017         if (Warn)
10018           HandleDeclRefExpr(DRE);
10019         return;
10020       }
10021 
10022       // The base of a MemberExpr is not a MemberExpr or a DeclRefExpr.
10023       // Visit that expression.
10024       Visit(Base);
10025     }
10026 
10027     void VisitCXXOperatorCallExpr(CXXOperatorCallExpr *E) {
10028       Expr *Callee = E->getCallee();
10029 
10030       if (isa<UnresolvedLookupExpr>(Callee))
10031         return Inherited::VisitCXXOperatorCallExpr(E);
10032 
10033       Visit(Callee);
10034       for (auto Arg: E->arguments())
10035         HandleValue(Arg->IgnoreParenImpCasts());
10036     }
10037 
10038     void VisitUnaryOperator(UnaryOperator *E) {
10039       // For POD record types, addresses of its own members are well-defined.
10040       if (E->getOpcode() == UO_AddrOf && isRecordType &&
10041           isa<MemberExpr>(E->getSubExpr()->IgnoreParens())) {
10042         if (!isPODType)
10043           HandleValue(E->getSubExpr());
10044         return;
10045       }
10046 
10047       if (E->isIncrementDecrementOp()) {
10048         HandleValue(E->getSubExpr());
10049         return;
10050       }
10051 
10052       Inherited::VisitUnaryOperator(E);
10053     }
10054 
10055     void VisitObjCMessageExpr(ObjCMessageExpr *E) {}
10056 
10057     void VisitCXXConstructExpr(CXXConstructExpr *E) {
10058       if (E->getConstructor()->isCopyConstructor()) {
10059         Expr *ArgExpr = E->getArg(0);
10060         if (InitListExpr *ILE = dyn_cast<InitListExpr>(ArgExpr))
10061           if (ILE->getNumInits() == 1)
10062             ArgExpr = ILE->getInit(0);
10063         if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(ArgExpr))
10064           if (ICE->getCastKind() == CK_NoOp)
10065             ArgExpr = ICE->getSubExpr();
10066         HandleValue(ArgExpr);
10067         return;
10068       }
10069       Inherited::VisitCXXConstructExpr(E);
10070     }
10071 
10072     void VisitCallExpr(CallExpr *E) {
10073       // Treat std::move as a use.
10074       if (E->isCallToStdMove()) {
10075         HandleValue(E->getArg(0));
10076         return;
10077       }
10078 
10079       Inherited::VisitCallExpr(E);
10080     }
10081 
10082     void VisitBinaryOperator(BinaryOperator *E) {
10083       if (E->isCompoundAssignmentOp()) {
10084         HandleValue(E->getLHS());
10085         Visit(E->getRHS());
10086         return;
10087       }
10088 
10089       Inherited::VisitBinaryOperator(E);
10090     }
10091 
10092     // A custom visitor for BinaryConditionalOperator is needed because the
10093     // regular visitor would check the condition and true expression separately
10094     // but both point to the same place giving duplicate diagnostics.
10095     void VisitBinaryConditionalOperator(BinaryConditionalOperator *E) {
10096       Visit(E->getCond());
10097       Visit(E->getFalseExpr());
10098     }
10099 
10100     void HandleDeclRefExpr(DeclRefExpr *DRE) {
10101       Decl* ReferenceDecl = DRE->getDecl();
10102       if (OrigDecl != ReferenceDecl) return;
10103       unsigned diag;
10104       if (isReferenceType) {
10105         diag = diag::warn_uninit_self_reference_in_reference_init;
10106       } else if (cast<VarDecl>(OrigDecl)->isStaticLocal()) {
10107         diag = diag::warn_static_self_reference_in_init;
10108       } else if (isa<TranslationUnitDecl>(OrigDecl->getDeclContext()) ||
10109                  isa<NamespaceDecl>(OrigDecl->getDeclContext()) ||
10110                  DRE->getDecl()->getType()->isRecordType()) {
10111         diag = diag::warn_uninit_self_reference_in_init;
10112       } else {
10113         // Local variables will be handled by the CFG analysis.
10114         return;
10115       }
10116 
10117       S.DiagRuntimeBehavior(DRE->getLocStart(), DRE,
10118                             S.PDiag(diag)
10119                               << DRE->getNameInfo().getName()
10120                               << OrigDecl->getLocation()
10121                               << DRE->getSourceRange());
10122     }
10123   };
10124 
10125   /// CheckSelfReference - Warns if OrigDecl is used in expression E.
10126   static void CheckSelfReference(Sema &S, Decl* OrigDecl, Expr *E,
10127                                  bool DirectInit) {
10128     // Parameters arguments are occassionially constructed with itself,
10129     // for instance, in recursive functions.  Skip them.
10130     if (isa<ParmVarDecl>(OrigDecl))
10131       return;
10132 
10133     E = E->IgnoreParens();
10134 
10135     // Skip checking T a = a where T is not a record or reference type.
10136     // Doing so is a way to silence uninitialized warnings.
10137     if (!DirectInit && !cast<VarDecl>(OrigDecl)->getType()->isRecordType())
10138       if (ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E))
10139         if (ICE->getCastKind() == CK_LValueToRValue)
10140           if (DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(ICE->getSubExpr()))
10141             if (DRE->getDecl() == OrigDecl)
10142               return;
10143 
10144     SelfReferenceChecker(S, OrigDecl).CheckExpr(E);
10145   }
10146 } // end anonymous namespace
10147 
10148 namespace {
10149   // Simple wrapper to add the name of a variable or (if no variable is
10150   // available) a DeclarationName into a diagnostic.
10151   struct VarDeclOrName {
10152     VarDecl *VDecl;
10153     DeclarationName Name;
10154 
10155     friend const Sema::SemaDiagnosticBuilder &
10156     operator<<(const Sema::SemaDiagnosticBuilder &Diag, VarDeclOrName VN) {
10157       return VN.VDecl ? Diag << VN.VDecl : Diag << VN.Name;
10158     }
10159   };
10160 } // end anonymous namespace
10161 
10162 QualType Sema::deduceVarTypeFromInitializer(VarDecl *VDecl,
10163                                             DeclarationName Name, QualType Type,
10164                                             TypeSourceInfo *TSI,
10165                                             SourceRange Range, bool DirectInit,
10166                                             Expr *Init) {
10167   bool IsInitCapture = !VDecl;
10168   assert((!VDecl || !VDecl->isInitCapture()) &&
10169          "init captures are expected to be deduced prior to initialization");
10170 
10171   VarDeclOrName VN{VDecl, Name};
10172 
10173   DeducedType *Deduced = Type->getContainedDeducedType();
10174   assert(Deduced && "deduceVarTypeFromInitializer for non-deduced type");
10175 
10176   // C++11 [dcl.spec.auto]p3
10177   if (!Init) {
10178     assert(VDecl && "no init for init capture deduction?");
10179     Diag(VDecl->getLocation(), diag::err_auto_var_requires_init)
10180       << VDecl->getDeclName() << Type;
10181     return QualType();
10182   }
10183 
10184   ArrayRef<Expr*> DeduceInits = Init;
10185   if (DirectInit) {
10186     if (auto *PL = dyn_cast_or_null<ParenListExpr>(Init))
10187       DeduceInits = PL->exprs();
10188   }
10189 
10190   if (isa<DeducedTemplateSpecializationType>(Deduced)) {
10191     assert(VDecl && "non-auto type for init capture deduction?");
10192     InitializedEntity Entity = InitializedEntity::InitializeVariable(VDecl);
10193     InitializationKind Kind = InitializationKind::CreateForInit(
10194         VDecl->getLocation(), DirectInit, Init);
10195     // FIXME: Initialization should not be taking a mutable list of inits.
10196     SmallVector<Expr*, 8> InitsCopy(DeduceInits.begin(), DeduceInits.end());
10197     return DeduceTemplateSpecializationFromInitializer(TSI, Entity, Kind,
10198                                                        InitsCopy);
10199   }
10200 
10201   if (DirectInit) {
10202     if (auto *IL = dyn_cast<InitListExpr>(Init))
10203       DeduceInits = IL->inits();
10204   }
10205 
10206   // Deduction only works if we have exactly one source expression.
10207   if (DeduceInits.empty()) {
10208     // It isn't possible to write this directly, but it is possible to
10209     // end up in this situation with "auto x(some_pack...);"
10210     Diag(Init->getLocStart(), IsInitCapture
10211                                   ? diag::err_init_capture_no_expression
10212                                   : diag::err_auto_var_init_no_expression)
10213         << VN << Type << Range;
10214     return QualType();
10215   }
10216 
10217   if (DeduceInits.size() > 1) {
10218     Diag(DeduceInits[1]->getLocStart(),
10219          IsInitCapture ? diag::err_init_capture_multiple_expressions
10220                        : diag::err_auto_var_init_multiple_expressions)
10221         << VN << Type << Range;
10222     return QualType();
10223   }
10224 
10225   Expr *DeduceInit = DeduceInits[0];
10226   if (DirectInit && isa<InitListExpr>(DeduceInit)) {
10227     Diag(Init->getLocStart(), IsInitCapture
10228                                   ? diag::err_init_capture_paren_braces
10229                                   : diag::err_auto_var_init_paren_braces)
10230         << isa<InitListExpr>(Init) << VN << Type << Range;
10231     return QualType();
10232   }
10233 
10234   // Expressions default to 'id' when we're in a debugger.
10235   bool DefaultedAnyToId = false;
10236   if (getLangOpts().DebuggerCastResultToId &&
10237       Init->getType() == Context.UnknownAnyTy && !IsInitCapture) {
10238     ExprResult Result = forceUnknownAnyToType(Init, Context.getObjCIdType());
10239     if (Result.isInvalid()) {
10240       return QualType();
10241     }
10242     Init = Result.get();
10243     DefaultedAnyToId = true;
10244   }
10245 
10246   // C++ [dcl.decomp]p1:
10247   //   If the assignment-expression [...] has array type A and no ref-qualifier
10248   //   is present, e has type cv A
10249   if (VDecl && isa<DecompositionDecl>(VDecl) &&
10250       Context.hasSameUnqualifiedType(Type, Context.getAutoDeductType()) &&
10251       DeduceInit->getType()->isConstantArrayType())
10252     return Context.getQualifiedType(DeduceInit->getType(),
10253                                     Type.getQualifiers());
10254 
10255   QualType DeducedType;
10256   if (DeduceAutoType(TSI, DeduceInit, DeducedType) == DAR_Failed) {
10257     if (!IsInitCapture)
10258       DiagnoseAutoDeductionFailure(VDecl, DeduceInit);
10259     else if (isa<InitListExpr>(Init))
10260       Diag(Range.getBegin(),
10261            diag::err_init_capture_deduction_failure_from_init_list)
10262           << VN
10263           << (DeduceInit->getType().isNull() ? TSI->getType()
10264                                              : DeduceInit->getType())
10265           << DeduceInit->getSourceRange();
10266     else
10267       Diag(Range.getBegin(), diag::err_init_capture_deduction_failure)
10268           << VN << TSI->getType()
10269           << (DeduceInit->getType().isNull() ? TSI->getType()
10270                                              : DeduceInit->getType())
10271           << DeduceInit->getSourceRange();
10272   }
10273 
10274   // Warn if we deduced 'id'. 'auto' usually implies type-safety, but using
10275   // 'id' instead of a specific object type prevents most of our usual
10276   // checks.
10277   // We only want to warn outside of template instantiations, though:
10278   // inside a template, the 'id' could have come from a parameter.
10279   if (!inTemplateInstantiation() && !DefaultedAnyToId && !IsInitCapture &&
10280       !DeducedType.isNull() && DeducedType->isObjCIdType()) {
10281     SourceLocation Loc = TSI->getTypeLoc().getBeginLoc();
10282     Diag(Loc, diag::warn_auto_var_is_id) << VN << Range;
10283   }
10284 
10285   return DeducedType;
10286 }
10287 
10288 bool Sema::DeduceVariableDeclarationType(VarDecl *VDecl, bool DirectInit,
10289                                          Expr *Init) {
10290   QualType DeducedType = deduceVarTypeFromInitializer(
10291       VDecl, VDecl->getDeclName(), VDecl->getType(), VDecl->getTypeSourceInfo(),
10292       VDecl->getSourceRange(), DirectInit, Init);
10293   if (DeducedType.isNull()) {
10294     VDecl->setInvalidDecl();
10295     return true;
10296   }
10297 
10298   VDecl->setType(DeducedType);
10299   assert(VDecl->isLinkageValid());
10300 
10301   // In ARC, infer lifetime.
10302   if (getLangOpts().ObjCAutoRefCount && inferObjCARCLifetime(VDecl))
10303     VDecl->setInvalidDecl();
10304 
10305   // If this is a redeclaration, check that the type we just deduced matches
10306   // the previously declared type.
10307   if (VarDecl *Old = VDecl->getPreviousDecl()) {
10308     // We never need to merge the type, because we cannot form an incomplete
10309     // array of auto, nor deduce such a type.
10310     MergeVarDeclTypes(VDecl, Old, /*MergeTypeWithPrevious*/ false);
10311   }
10312 
10313   // Check the deduced type is valid for a variable declaration.
10314   CheckVariableDeclarationType(VDecl);
10315   return VDecl->isInvalidDecl();
10316 }
10317 
10318 /// AddInitializerToDecl - Adds the initializer Init to the
10319 /// declaration dcl. If DirectInit is true, this is C++ direct
10320 /// initialization rather than copy initialization.
10321 void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) {
10322   // If there is no declaration, there was an error parsing it.  Just ignore
10323   // the initializer.
10324   if (!RealDecl || RealDecl->isInvalidDecl()) {
10325     CorrectDelayedTyposInExpr(Init, dyn_cast_or_null<VarDecl>(RealDecl));
10326     return;
10327   }
10328 
10329   if (CXXMethodDecl *Method = dyn_cast<CXXMethodDecl>(RealDecl)) {
10330     // Pure-specifiers are handled in ActOnPureSpecifier.
10331     Diag(Method->getLocation(), diag::err_member_function_initialization)
10332       << Method->getDeclName() << Init->getSourceRange();
10333     Method->setInvalidDecl();
10334     return;
10335   }
10336 
10337   VarDecl *VDecl = dyn_cast<VarDecl>(RealDecl);
10338   if (!VDecl) {
10339     assert(!isa<FieldDecl>(RealDecl) && "field init shouldn't get here");
10340     Diag(RealDecl->getLocation(), diag::err_illegal_initializer);
10341     RealDecl->setInvalidDecl();
10342     return;
10343   }
10344 
10345   // C++11 [decl.spec.auto]p6. Deduce the type which 'auto' stands in for.
10346   if (VDecl->getType()->isUndeducedType()) {
10347     // Attempt typo correction early so that the type of the init expression can
10348     // be deduced based on the chosen correction if the original init contains a
10349     // TypoExpr.
10350     ExprResult Res = CorrectDelayedTyposInExpr(Init, VDecl);
10351     if (!Res.isUsable()) {
10352       RealDecl->setInvalidDecl();
10353       return;
10354     }
10355     Init = Res.get();
10356 
10357     if (DeduceVariableDeclarationType(VDecl, DirectInit, Init))
10358       return;
10359   }
10360 
10361   // dllimport cannot be used on variable definitions.
10362   if (VDecl->hasAttr<DLLImportAttr>() && !VDecl->isStaticDataMember()) {
10363     Diag(VDecl->getLocation(), diag::err_attribute_dllimport_data_definition);
10364     VDecl->setInvalidDecl();
10365     return;
10366   }
10367 
10368   if (VDecl->isLocalVarDecl() && VDecl->hasExternalStorage()) {
10369     // C99 6.7.8p5. C++ has no such restriction, but that is a defect.
10370     Diag(VDecl->getLocation(), diag::err_block_extern_cant_init);
10371     VDecl->setInvalidDecl();
10372     return;
10373   }
10374 
10375   if (!VDecl->getType()->isDependentType()) {
10376     // A definition must end up with a complete type, which means it must be
10377     // complete with the restriction that an array type might be completed by
10378     // the initializer; note that later code assumes this restriction.
10379     QualType BaseDeclType = VDecl->getType();
10380     if (const ArrayType *Array = Context.getAsIncompleteArrayType(BaseDeclType))
10381       BaseDeclType = Array->getElementType();
10382     if (RequireCompleteType(VDecl->getLocation(), BaseDeclType,
10383                             diag::err_typecheck_decl_incomplete_type)) {
10384       RealDecl->setInvalidDecl();
10385       return;
10386     }
10387 
10388     // The variable can not have an abstract class type.
10389     if (RequireNonAbstractType(VDecl->getLocation(), VDecl->getType(),
10390                                diag::err_abstract_type_in_decl,
10391                                AbstractVariableType))
10392       VDecl->setInvalidDecl();
10393   }
10394 
10395   // If adding the initializer will turn this declaration into a definition,
10396   // and we already have a definition for this variable, diagnose or otherwise
10397   // handle the situation.
10398   VarDecl *Def;
10399   if ((Def = VDecl->getDefinition()) && Def != VDecl &&
10400       (!VDecl->isStaticDataMember() || VDecl->isOutOfLine()) &&
10401       !VDecl->isThisDeclarationADemotedDefinition() &&
10402       checkVarDeclRedefinition(Def, VDecl))
10403     return;
10404 
10405   if (getLangOpts().CPlusPlus) {
10406     // C++ [class.static.data]p4
10407     //   If a static data member is of const integral or const
10408     //   enumeration type, its declaration in the class definition can
10409     //   specify a constant-initializer which shall be an integral
10410     //   constant expression (5.19). In that case, the member can appear
10411     //   in integral constant expressions. The member shall still be
10412     //   defined in a namespace scope if it is used in the program and the
10413     //   namespace scope definition shall not contain an initializer.
10414     //
10415     // We already performed a redefinition check above, but for static
10416     // data members we also need to check whether there was an in-class
10417     // declaration with an initializer.
10418     if (VDecl->isStaticDataMember() && VDecl->getCanonicalDecl()->hasInit()) {
10419       Diag(Init->getExprLoc(), diag::err_static_data_member_reinitialization)
10420           << VDecl->getDeclName();
10421       Diag(VDecl->getCanonicalDecl()->getInit()->getExprLoc(),
10422            diag::note_previous_initializer)
10423           << 0;
10424       return;
10425     }
10426 
10427     if (VDecl->hasLocalStorage())
10428       getCurFunction()->setHasBranchProtectedScope();
10429 
10430     if (DiagnoseUnexpandedParameterPack(Init, UPPC_Initializer)) {
10431       VDecl->setInvalidDecl();
10432       return;
10433     }
10434   }
10435 
10436   // OpenCL 1.1 6.5.2: "Variables allocated in the __local address space inside
10437   // a kernel function cannot be initialized."
10438   if (VDecl->getType().getAddressSpace() == LangAS::opencl_local) {
10439     Diag(VDecl->getLocation(), diag::err_local_cant_init);
10440     VDecl->setInvalidDecl();
10441     return;
10442   }
10443 
10444   // Get the decls type and save a reference for later, since
10445   // CheckInitializerTypes may change it.
10446   QualType DclT = VDecl->getType(), SavT = DclT;
10447 
10448   // Expressions default to 'id' when we're in a debugger
10449   // and we are assigning it to a variable of Objective-C pointer type.
10450   if (getLangOpts().DebuggerCastResultToId && DclT->isObjCObjectPointerType() &&
10451       Init->getType() == Context.UnknownAnyTy) {
10452     ExprResult Result = forceUnknownAnyToType(Init, Context.getObjCIdType());
10453     if (Result.isInvalid()) {
10454       VDecl->setInvalidDecl();
10455       return;
10456     }
10457     Init = Result.get();
10458   }
10459 
10460   // Perform the initialization.
10461   ParenListExpr *CXXDirectInit = dyn_cast<ParenListExpr>(Init);
10462   if (!VDecl->isInvalidDecl()) {
10463     InitializedEntity Entity = InitializedEntity::InitializeVariable(VDecl);
10464     InitializationKind Kind = InitializationKind::CreateForInit(
10465         VDecl->getLocation(), DirectInit, Init);
10466 
10467     MultiExprArg Args = Init;
10468     if (CXXDirectInit)
10469       Args = MultiExprArg(CXXDirectInit->getExprs(),
10470                           CXXDirectInit->getNumExprs());
10471 
10472     // Try to correct any TypoExprs in the initialization arguments.
10473     for (size_t Idx = 0; Idx < Args.size(); ++Idx) {
10474       ExprResult Res = CorrectDelayedTyposInExpr(
10475           Args[Idx], VDecl, [this, Entity, Kind](Expr *E) {
10476             InitializationSequence Init(*this, Entity, Kind, MultiExprArg(E));
10477             return Init.Failed() ? ExprError() : E;
10478           });
10479       if (Res.isInvalid()) {
10480         VDecl->setInvalidDecl();
10481       } else if (Res.get() != Args[Idx]) {
10482         Args[Idx] = Res.get();
10483       }
10484     }
10485     if (VDecl->isInvalidDecl())
10486       return;
10487 
10488     InitializationSequence InitSeq(*this, Entity, Kind, Args,
10489                                    /*TopLevelOfInitList=*/false,
10490                                    /*TreatUnavailableAsInvalid=*/false);
10491     ExprResult Result = InitSeq.Perform(*this, Entity, Kind, Args, &DclT);
10492     if (Result.isInvalid()) {
10493       VDecl->setInvalidDecl();
10494       return;
10495     }
10496 
10497     Init = Result.getAs<Expr>();
10498   }
10499 
10500   // Check for self-references within variable initializers.
10501   // Variables declared within a function/method body (except for references)
10502   // are handled by a dataflow analysis.
10503   if (!VDecl->hasLocalStorage() || VDecl->getType()->isRecordType() ||
10504       VDecl->getType()->isReferenceType()) {
10505     CheckSelfReference(*this, RealDecl, Init, DirectInit);
10506   }
10507 
10508   // If the type changed, it means we had an incomplete type that was
10509   // completed by the initializer. For example:
10510   //   int ary[] = { 1, 3, 5 };
10511   // "ary" transitions from an IncompleteArrayType to a ConstantArrayType.
10512   if (!VDecl->isInvalidDecl() && (DclT != SavT))
10513     VDecl->setType(DclT);
10514 
10515   if (!VDecl->isInvalidDecl()) {
10516     checkUnsafeAssigns(VDecl->getLocation(), VDecl->getType(), Init);
10517 
10518     if (VDecl->hasAttr<BlocksAttr>())
10519       checkRetainCycles(VDecl, Init);
10520 
10521     // It is safe to assign a weak reference into a strong variable.
10522     // Although this code can still have problems:
10523     //   id x = self.weakProp;
10524     //   id y = self.weakProp;
10525     // we do not warn to warn spuriously when 'x' and 'y' are on separate
10526     // paths through the function. This should be revisited if
10527     // -Wrepeated-use-of-weak is made flow-sensitive.
10528     if ((VDecl->getType().getObjCLifetime() == Qualifiers::OCL_Strong ||
10529          VDecl->getType().isNonWeakInMRRWithObjCWeak(Context)) &&
10530         !Diags.isIgnored(diag::warn_arc_repeated_use_of_weak,
10531                          Init->getLocStart()))
10532       getCurFunction()->markSafeWeakUse(Init);
10533   }
10534 
10535   // The initialization is usually a full-expression.
10536   //
10537   // FIXME: If this is a braced initialization of an aggregate, it is not
10538   // an expression, and each individual field initializer is a separate
10539   // full-expression. For instance, in:
10540   //
10541   //   struct Temp { ~Temp(); };
10542   //   struct S { S(Temp); };
10543   //   struct T { S a, b; } t = { Temp(), Temp() }
10544   //
10545   // we should destroy the first Temp before constructing the second.
10546   ExprResult Result = ActOnFinishFullExpr(Init, VDecl->getLocation(),
10547                                           false,
10548                                           VDecl->isConstexpr());
10549   if (Result.isInvalid()) {
10550     VDecl->setInvalidDecl();
10551     return;
10552   }
10553   Init = Result.get();
10554 
10555   // Attach the initializer to the decl.
10556   VDecl->setInit(Init);
10557 
10558   if (VDecl->isLocalVarDecl()) {
10559     // Don't check the initializer if the declaration is malformed.
10560     if (VDecl->isInvalidDecl()) {
10561       // do nothing
10562 
10563     // OpenCL v1.2 s6.5.3: __constant locals must be constant-initialized.
10564     // This is true even in OpenCL C++.
10565     } else if (VDecl->getType().getAddressSpace() == LangAS::opencl_constant) {
10566       CheckForConstantInitializer(Init, DclT);
10567 
10568     // Otherwise, C++ does not restrict the initializer.
10569     } else if (getLangOpts().CPlusPlus) {
10570       // do nothing
10571 
10572     // C99 6.7.8p4: All the expressions in an initializer for an object that has
10573     // static storage duration shall be constant expressions or string literals.
10574     } else if (VDecl->getStorageClass() == SC_Static) {
10575       CheckForConstantInitializer(Init, DclT);
10576 
10577     // C89 is stricter than C99 for aggregate initializers.
10578     // C89 6.5.7p3: All the expressions [...] in an initializer list
10579     // for an object that has aggregate or union type shall be
10580     // constant expressions.
10581     } else if (!getLangOpts().C99 && VDecl->getType()->isAggregateType() &&
10582                isa<InitListExpr>(Init)) {
10583       const Expr *Culprit;
10584       if (!Init->isConstantInitializer(Context, false, &Culprit)) {
10585         Diag(Culprit->getExprLoc(),
10586              diag::ext_aggregate_init_not_constant)
10587           << Culprit->getSourceRange();
10588       }
10589     }
10590   } else if (VDecl->isStaticDataMember() && !VDecl->isInline() &&
10591              VDecl->getLexicalDeclContext()->isRecord()) {
10592     // This is an in-class initialization for a static data member, e.g.,
10593     //
10594     // struct S {
10595     //   static const int value = 17;
10596     // };
10597 
10598     // C++ [class.mem]p4:
10599     //   A member-declarator can contain a constant-initializer only
10600     //   if it declares a static member (9.4) of const integral or
10601     //   const enumeration type, see 9.4.2.
10602     //
10603     // C++11 [class.static.data]p3:
10604     //   If a non-volatile non-inline const static data member is of integral
10605     //   or enumeration type, its declaration in the class definition can
10606     //   specify a brace-or-equal-initializer in which every initializer-clause
10607     //   that is an assignment-expression is a constant expression. A static
10608     //   data member of literal type can be declared in the class definition
10609     //   with the constexpr specifier; if so, its declaration shall specify a
10610     //   brace-or-equal-initializer in which every initializer-clause that is
10611     //   an assignment-expression is a constant expression.
10612 
10613     // Do nothing on dependent types.
10614     if (DclT->isDependentType()) {
10615 
10616     // Allow any 'static constexpr' members, whether or not they are of literal
10617     // type. We separately check that every constexpr variable is of literal
10618     // type.
10619     } else if (VDecl->isConstexpr()) {
10620 
10621     // Require constness.
10622     } else if (!DclT.isConstQualified()) {
10623       Diag(VDecl->getLocation(), diag::err_in_class_initializer_non_const)
10624         << Init->getSourceRange();
10625       VDecl->setInvalidDecl();
10626 
10627     // We allow integer constant expressions in all cases.
10628     } else if (DclT->isIntegralOrEnumerationType()) {
10629       // Check whether the expression is a constant expression.
10630       SourceLocation Loc;
10631       if (getLangOpts().CPlusPlus11 && DclT.isVolatileQualified())
10632         // In C++11, a non-constexpr const static data member with an
10633         // in-class initializer cannot be volatile.
10634         Diag(VDecl->getLocation(), diag::err_in_class_initializer_volatile);
10635       else if (Init->isValueDependent())
10636         ; // Nothing to check.
10637       else if (Init->isIntegerConstantExpr(Context, &Loc))
10638         ; // Ok, it's an ICE!
10639       else if (Init->isEvaluatable(Context)) {
10640         // If we can constant fold the initializer through heroics, accept it,
10641         // but report this as a use of an extension for -pedantic.
10642         Diag(Loc, diag::ext_in_class_initializer_non_constant)
10643           << Init->getSourceRange();
10644       } else {
10645         // Otherwise, this is some crazy unknown case.  Report the issue at the
10646         // location provided by the isIntegerConstantExpr failed check.
10647         Diag(Loc, diag::err_in_class_initializer_non_constant)
10648           << Init->getSourceRange();
10649         VDecl->setInvalidDecl();
10650       }
10651 
10652     // We allow foldable floating-point constants as an extension.
10653     } else if (DclT->isFloatingType()) { // also permits complex, which is ok
10654       // In C++98, this is a GNU extension. In C++11, it is not, but we support
10655       // it anyway and provide a fixit to add the 'constexpr'.
10656       if (getLangOpts().CPlusPlus11) {
10657         Diag(VDecl->getLocation(),
10658              diag::ext_in_class_initializer_float_type_cxx11)
10659             << DclT << Init->getSourceRange();
10660         Diag(VDecl->getLocStart(),
10661              diag::note_in_class_initializer_float_type_cxx11)
10662             << FixItHint::CreateInsertion(VDecl->getLocStart(), "constexpr ");
10663       } else {
10664         Diag(VDecl->getLocation(), diag::ext_in_class_initializer_float_type)
10665           << DclT << Init->getSourceRange();
10666 
10667         if (!Init->isValueDependent() && !Init->isEvaluatable(Context)) {
10668           Diag(Init->getExprLoc(), diag::err_in_class_initializer_non_constant)
10669             << Init->getSourceRange();
10670           VDecl->setInvalidDecl();
10671         }
10672       }
10673 
10674     // Suggest adding 'constexpr' in C++11 for literal types.
10675     } else if (getLangOpts().CPlusPlus11 && DclT->isLiteralType(Context)) {
10676       Diag(VDecl->getLocation(), diag::err_in_class_initializer_literal_type)
10677         << DclT << Init->getSourceRange()
10678         << FixItHint::CreateInsertion(VDecl->getLocStart(), "constexpr ");
10679       VDecl->setConstexpr(true);
10680 
10681     } else {
10682       Diag(VDecl->getLocation(), diag::err_in_class_initializer_bad_type)
10683         << DclT << Init->getSourceRange();
10684       VDecl->setInvalidDecl();
10685     }
10686   } else if (VDecl->isFileVarDecl()) {
10687     // In C, extern is typically used to avoid tentative definitions when
10688     // declaring variables in headers, but adding an intializer makes it a
10689     // defintion. This is somewhat confusing, so GCC and Clang both warn on it.
10690     // In C++, extern is often used to give implictly static const variables
10691     // external linkage, so don't warn in that case. If selectany is present,
10692     // this might be header code intended for C and C++ inclusion, so apply the
10693     // C++ rules.
10694     if (VDecl->getStorageClass() == SC_Extern &&
10695         ((!getLangOpts().CPlusPlus && !VDecl->hasAttr<SelectAnyAttr>()) ||
10696          !Context.getBaseElementType(VDecl->getType()).isConstQualified()) &&
10697         !(getLangOpts().CPlusPlus && VDecl->isExternC()) &&
10698         !isTemplateInstantiation(VDecl->getTemplateSpecializationKind()))
10699       Diag(VDecl->getLocation(), diag::warn_extern_init);
10700 
10701     // C99 6.7.8p4. All file scoped initializers need to be constant.
10702     if (!getLangOpts().CPlusPlus && !VDecl->isInvalidDecl())
10703       CheckForConstantInitializer(Init, DclT);
10704   }
10705 
10706   // We will represent direct-initialization similarly to copy-initialization:
10707   //    int x(1);  -as-> int x = 1;
10708   //    ClassType x(a,b,c); -as-> ClassType x = ClassType(a,b,c);
10709   //
10710   // Clients that want to distinguish between the two forms, can check for
10711   // direct initializer using VarDecl::getInitStyle().
10712   // A major benefit is that clients that don't particularly care about which
10713   // exactly form was it (like the CodeGen) can handle both cases without
10714   // special case code.
10715 
10716   // C++ 8.5p11:
10717   // The form of initialization (using parentheses or '=') is generally
10718   // insignificant, but does matter when the entity being initialized has a
10719   // class type.
10720   if (CXXDirectInit) {
10721     assert(DirectInit && "Call-style initializer must be direct init.");
10722     VDecl->setInitStyle(VarDecl::CallInit);
10723   } else if (DirectInit) {
10724     // This must be list-initialization. No other way is direct-initialization.
10725     VDecl->setInitStyle(VarDecl::ListInit);
10726   }
10727 
10728   CheckCompleteVariableDeclaration(VDecl);
10729 }
10730 
10731 /// ActOnInitializerError - Given that there was an error parsing an
10732 /// initializer for the given declaration, try to return to some form
10733 /// of sanity.
10734 void Sema::ActOnInitializerError(Decl *D) {
10735   // Our main concern here is re-establishing invariants like "a
10736   // variable's type is either dependent or complete".
10737   if (!D || D->isInvalidDecl()) return;
10738 
10739   VarDecl *VD = dyn_cast<VarDecl>(D);
10740   if (!VD) return;
10741 
10742   // Bindings are not usable if we can't make sense of the initializer.
10743   if (auto *DD = dyn_cast<DecompositionDecl>(D))
10744     for (auto *BD : DD->bindings())
10745       BD->setInvalidDecl();
10746 
10747   // Auto types are meaningless if we can't make sense of the initializer.
10748   if (ParsingInitForAutoVars.count(D)) {
10749     D->setInvalidDecl();
10750     return;
10751   }
10752 
10753   QualType Ty = VD->getType();
10754   if (Ty->isDependentType()) return;
10755 
10756   // Require a complete type.
10757   if (RequireCompleteType(VD->getLocation(),
10758                           Context.getBaseElementType(Ty),
10759                           diag::err_typecheck_decl_incomplete_type)) {
10760     VD->setInvalidDecl();
10761     return;
10762   }
10763 
10764   // Require a non-abstract type.
10765   if (RequireNonAbstractType(VD->getLocation(), Ty,
10766                              diag::err_abstract_type_in_decl,
10767                              AbstractVariableType)) {
10768     VD->setInvalidDecl();
10769     return;
10770   }
10771 
10772   // Don't bother complaining about constructors or destructors,
10773   // though.
10774 }
10775 
10776 void Sema::ActOnUninitializedDecl(Decl *RealDecl) {
10777   // If there is no declaration, there was an error parsing it. Just ignore it.
10778   if (!RealDecl)
10779     return;
10780 
10781   if (VarDecl *Var = dyn_cast<VarDecl>(RealDecl)) {
10782     QualType Type = Var->getType();
10783 
10784     // C++1z [dcl.dcl]p1 grammar implies that an initializer is mandatory.
10785     if (isa<DecompositionDecl>(RealDecl)) {
10786       Diag(Var->getLocation(), diag::err_decomp_decl_requires_init) << Var;
10787       Var->setInvalidDecl();
10788       return;
10789     }
10790 
10791     if (Type->isUndeducedType() &&
10792         DeduceVariableDeclarationType(Var, false, nullptr))
10793       return;
10794 
10795     // C++11 [class.static.data]p3: A static data member can be declared with
10796     // the constexpr specifier; if so, its declaration shall specify
10797     // a brace-or-equal-initializer.
10798     // C++11 [dcl.constexpr]p1: The constexpr specifier shall be applied only to
10799     // the definition of a variable [...] or the declaration of a static data
10800     // member.
10801     if (Var->isConstexpr() && !Var->isThisDeclarationADefinition() &&
10802         !Var->isThisDeclarationADemotedDefinition()) {
10803       if (Var->isStaticDataMember()) {
10804         // C++1z removes the relevant rule; the in-class declaration is always
10805         // a definition there.
10806         if (!getLangOpts().CPlusPlus1z) {
10807           Diag(Var->getLocation(),
10808                diag::err_constexpr_static_mem_var_requires_init)
10809             << Var->getDeclName();
10810           Var->setInvalidDecl();
10811           return;
10812         }
10813       } else {
10814         Diag(Var->getLocation(), diag::err_invalid_constexpr_var_decl);
10815         Var->setInvalidDecl();
10816         return;
10817       }
10818     }
10819 
10820     // C++ Concepts TS [dcl.spec.concept]p1: [...]  A variable template
10821     // definition having the concept specifier is called a variable concept. A
10822     // concept definition refers to [...] a variable concept and its initializer.
10823     if (VarTemplateDecl *VTD = Var->getDescribedVarTemplate()) {
10824       if (VTD->isConcept()) {
10825         Diag(Var->getLocation(), diag::err_var_concept_not_initialized);
10826         Var->setInvalidDecl();
10827         return;
10828       }
10829     }
10830 
10831     // OpenCL v1.1 s6.5.3: variables declared in the constant address space must
10832     // be initialized.
10833     if (!Var->isInvalidDecl() &&
10834         Var->getType().getAddressSpace() == LangAS::opencl_constant &&
10835         Var->getStorageClass() != SC_Extern && !Var->getInit()) {
10836       Diag(Var->getLocation(), diag::err_opencl_constant_no_init);
10837       Var->setInvalidDecl();
10838       return;
10839     }
10840 
10841     switch (Var->isThisDeclarationADefinition()) {
10842     case VarDecl::Definition:
10843       if (!Var->isStaticDataMember() || !Var->getAnyInitializer())
10844         break;
10845 
10846       // We have an out-of-line definition of a static data member
10847       // that has an in-class initializer, so we type-check this like
10848       // a declaration.
10849       //
10850       // Fall through
10851 
10852     case VarDecl::DeclarationOnly:
10853       // It's only a declaration.
10854 
10855       // Block scope. C99 6.7p7: If an identifier for an object is
10856       // declared with no linkage (C99 6.2.2p6), the type for the
10857       // object shall be complete.
10858       if (!Type->isDependentType() && Var->isLocalVarDecl() &&
10859           !Var->hasLinkage() && !Var->isInvalidDecl() &&
10860           RequireCompleteType(Var->getLocation(), Type,
10861                               diag::err_typecheck_decl_incomplete_type))
10862         Var->setInvalidDecl();
10863 
10864       // Make sure that the type is not abstract.
10865       if (!Type->isDependentType() && !Var->isInvalidDecl() &&
10866           RequireNonAbstractType(Var->getLocation(), Type,
10867                                  diag::err_abstract_type_in_decl,
10868                                  AbstractVariableType))
10869         Var->setInvalidDecl();
10870       if (!Type->isDependentType() && !Var->isInvalidDecl() &&
10871           Var->getStorageClass() == SC_PrivateExtern) {
10872         Diag(Var->getLocation(), diag::warn_private_extern);
10873         Diag(Var->getLocation(), diag::note_private_extern);
10874       }
10875 
10876       return;
10877 
10878     case VarDecl::TentativeDefinition:
10879       // File scope. C99 6.9.2p2: A declaration of an identifier for an
10880       // object that has file scope without an initializer, and without a
10881       // storage-class specifier or with the storage-class specifier "static",
10882       // constitutes a tentative definition. Note: A tentative definition with
10883       // external linkage is valid (C99 6.2.2p5).
10884       if (!Var->isInvalidDecl()) {
10885         if (const IncompleteArrayType *ArrayT
10886                                     = Context.getAsIncompleteArrayType(Type)) {
10887           if (RequireCompleteType(Var->getLocation(),
10888                                   ArrayT->getElementType(),
10889                                   diag::err_illegal_decl_array_incomplete_type))
10890             Var->setInvalidDecl();
10891         } else if (Var->getStorageClass() == SC_Static) {
10892           // C99 6.9.2p3: If the declaration of an identifier for an object is
10893           // a tentative definition and has internal linkage (C99 6.2.2p3), the
10894           // declared type shall not be an incomplete type.
10895           // NOTE: code such as the following
10896           //     static struct s;
10897           //     struct s { int a; };
10898           // is accepted by gcc. Hence here we issue a warning instead of
10899           // an error and we do not invalidate the static declaration.
10900           // NOTE: to avoid multiple warnings, only check the first declaration.
10901           if (Var->isFirstDecl())
10902             RequireCompleteType(Var->getLocation(), Type,
10903                                 diag::ext_typecheck_decl_incomplete_type);
10904         }
10905       }
10906 
10907       // Record the tentative definition; we're done.
10908       if (!Var->isInvalidDecl())
10909         TentativeDefinitions.push_back(Var);
10910       return;
10911     }
10912 
10913     // Provide a specific diagnostic for uninitialized variable
10914     // definitions with incomplete array type.
10915     if (Type->isIncompleteArrayType()) {
10916       Diag(Var->getLocation(),
10917            diag::err_typecheck_incomplete_array_needs_initializer);
10918       Var->setInvalidDecl();
10919       return;
10920     }
10921 
10922     // Provide a specific diagnostic for uninitialized variable
10923     // definitions with reference type.
10924     if (Type->isReferenceType()) {
10925       Diag(Var->getLocation(), diag::err_reference_var_requires_init)
10926         << Var->getDeclName()
10927         << SourceRange(Var->getLocation(), Var->getLocation());
10928       Var->setInvalidDecl();
10929       return;
10930     }
10931 
10932     // Do not attempt to type-check the default initializer for a
10933     // variable with dependent type.
10934     if (Type->isDependentType())
10935       return;
10936 
10937     if (Var->isInvalidDecl())
10938       return;
10939 
10940     if (!Var->hasAttr<AliasAttr>()) {
10941       if (RequireCompleteType(Var->getLocation(),
10942                               Context.getBaseElementType(Type),
10943                               diag::err_typecheck_decl_incomplete_type)) {
10944         Var->setInvalidDecl();
10945         return;
10946       }
10947     } else {
10948       return;
10949     }
10950 
10951     // The variable can not have an abstract class type.
10952     if (RequireNonAbstractType(Var->getLocation(), Type,
10953                                diag::err_abstract_type_in_decl,
10954                                AbstractVariableType)) {
10955       Var->setInvalidDecl();
10956       return;
10957     }
10958 
10959     // Check for jumps past the implicit initializer.  C++0x
10960     // clarifies that this applies to a "variable with automatic
10961     // storage duration", not a "local variable".
10962     // C++11 [stmt.dcl]p3
10963     //   A program that jumps from a point where a variable with automatic
10964     //   storage duration is not in scope to a point where it is in scope is
10965     //   ill-formed unless the variable has scalar type, class type with a
10966     //   trivial default constructor and a trivial destructor, a cv-qualified
10967     //   version of one of these types, or an array of one of the preceding
10968     //   types and is declared without an initializer.
10969     if (getLangOpts().CPlusPlus && Var->hasLocalStorage()) {
10970       if (const RecordType *Record
10971             = Context.getBaseElementType(Type)->getAs<RecordType>()) {
10972         CXXRecordDecl *CXXRecord = cast<CXXRecordDecl>(Record->getDecl());
10973         // Mark the function for further checking even if the looser rules of
10974         // C++11 do not require such checks, so that we can diagnose
10975         // incompatibilities with C++98.
10976         if (!CXXRecord->isPOD())
10977           getCurFunction()->setHasBranchProtectedScope();
10978       }
10979     }
10980 
10981     // C++03 [dcl.init]p9:
10982     //   If no initializer is specified for an object, and the
10983     //   object is of (possibly cv-qualified) non-POD class type (or
10984     //   array thereof), the object shall be default-initialized; if
10985     //   the object is of const-qualified type, the underlying class
10986     //   type shall have a user-declared default
10987     //   constructor. Otherwise, if no initializer is specified for
10988     //   a non- static object, the object and its subobjects, if
10989     //   any, have an indeterminate initial value); if the object
10990     //   or any of its subobjects are of const-qualified type, the
10991     //   program is ill-formed.
10992     // C++0x [dcl.init]p11:
10993     //   If no initializer is specified for an object, the object is
10994     //   default-initialized; [...].
10995     InitializedEntity Entity = InitializedEntity::InitializeVariable(Var);
10996     InitializationKind Kind
10997       = InitializationKind::CreateDefault(Var->getLocation());
10998 
10999     InitializationSequence InitSeq(*this, Entity, Kind, None);
11000     ExprResult Init = InitSeq.Perform(*this, Entity, Kind, None);
11001     if (Init.isInvalid())
11002       Var->setInvalidDecl();
11003     else if (Init.get()) {
11004       Var->setInit(MaybeCreateExprWithCleanups(Init.get()));
11005       // This is important for template substitution.
11006       Var->setInitStyle(VarDecl::CallInit);
11007     }
11008 
11009     CheckCompleteVariableDeclaration(Var);
11010   }
11011 }
11012 
11013 void Sema::ActOnCXXForRangeDecl(Decl *D) {
11014   // If there is no declaration, there was an error parsing it. Ignore it.
11015   if (!D)
11016     return;
11017 
11018   VarDecl *VD = dyn_cast<VarDecl>(D);
11019   if (!VD) {
11020     Diag(D->getLocation(), diag::err_for_range_decl_must_be_var);
11021     D->setInvalidDecl();
11022     return;
11023   }
11024 
11025   VD->setCXXForRangeDecl(true);
11026 
11027   // for-range-declaration cannot be given a storage class specifier.
11028   int Error = -1;
11029   switch (VD->getStorageClass()) {
11030   case SC_None:
11031     break;
11032   case SC_Extern:
11033     Error = 0;
11034     break;
11035   case SC_Static:
11036     Error = 1;
11037     break;
11038   case SC_PrivateExtern:
11039     Error = 2;
11040     break;
11041   case SC_Auto:
11042     Error = 3;
11043     break;
11044   case SC_Register:
11045     Error = 4;
11046     break;
11047   }
11048   if (Error != -1) {
11049     Diag(VD->getOuterLocStart(), diag::err_for_range_storage_class)
11050       << VD->getDeclName() << Error;
11051     D->setInvalidDecl();
11052   }
11053 }
11054 
11055 StmtResult
11056 Sema::ActOnCXXForRangeIdentifier(Scope *S, SourceLocation IdentLoc,
11057                                  IdentifierInfo *Ident,
11058                                  ParsedAttributes &Attrs,
11059                                  SourceLocation AttrEnd) {
11060   // C++1y [stmt.iter]p1:
11061   //   A range-based for statement of the form
11062   //      for ( for-range-identifier : for-range-initializer ) statement
11063   //   is equivalent to
11064   //      for ( auto&& for-range-identifier : for-range-initializer ) statement
11065   DeclSpec DS(Attrs.getPool().getFactory());
11066 
11067   const char *PrevSpec;
11068   unsigned DiagID;
11069   DS.SetTypeSpecType(DeclSpec::TST_auto, IdentLoc, PrevSpec, DiagID,
11070                      getPrintingPolicy());
11071 
11072   Declarator D(DS, Declarator::ForContext);
11073   D.SetIdentifier(Ident, IdentLoc);
11074   D.takeAttributes(Attrs, AttrEnd);
11075 
11076   ParsedAttributes EmptyAttrs(Attrs.getPool().getFactory());
11077   D.AddTypeInfo(DeclaratorChunk::getReference(0, IdentLoc, /*lvalue*/false),
11078                 EmptyAttrs, IdentLoc);
11079   Decl *Var = ActOnDeclarator(S, D);
11080   cast<VarDecl>(Var)->setCXXForRangeDecl(true);
11081   FinalizeDeclaration(Var);
11082   return ActOnDeclStmt(FinalizeDeclaratorGroup(S, DS, Var), IdentLoc,
11083                        AttrEnd.isValid() ? AttrEnd : IdentLoc);
11084 }
11085 
11086 void Sema::CheckCompleteVariableDeclaration(VarDecl *var) {
11087   if (var->isInvalidDecl()) return;
11088 
11089   if (getLangOpts().OpenCL) {
11090     // OpenCL v2.0 s6.12.5 - Every block variable declaration must have an
11091     // initialiser
11092     if (var->getTypeSourceInfo()->getType()->isBlockPointerType() &&
11093         !var->hasInit()) {
11094       Diag(var->getLocation(), diag::err_opencl_invalid_block_declaration)
11095           << 1 /*Init*/;
11096       var->setInvalidDecl();
11097       return;
11098     }
11099   }
11100 
11101   // In Objective-C, don't allow jumps past the implicit initialization of a
11102   // local retaining variable.
11103   if (getLangOpts().ObjC1 &&
11104       var->hasLocalStorage()) {
11105     switch (var->getType().getObjCLifetime()) {
11106     case Qualifiers::OCL_None:
11107     case Qualifiers::OCL_ExplicitNone:
11108     case Qualifiers::OCL_Autoreleasing:
11109       break;
11110 
11111     case Qualifiers::OCL_Weak:
11112     case Qualifiers::OCL_Strong:
11113       getCurFunction()->setHasBranchProtectedScope();
11114       break;
11115     }
11116   }
11117 
11118   // Warn about externally-visible variables being defined without a
11119   // prior declaration.  We only want to do this for global
11120   // declarations, but we also specifically need to avoid doing it for
11121   // class members because the linkage of an anonymous class can
11122   // change if it's later given a typedef name.
11123   if (var->isThisDeclarationADefinition() &&
11124       var->getDeclContext()->getRedeclContext()->isFileContext() &&
11125       var->isExternallyVisible() && var->hasLinkage() &&
11126       !getDiagnostics().isIgnored(diag::warn_missing_variable_declarations,
11127                                   var->getLocation())) {
11128     // Find a previous declaration that's not a definition.
11129     VarDecl *prev = var->getPreviousDecl();
11130     while (prev && prev->isThisDeclarationADefinition())
11131       prev = prev->getPreviousDecl();
11132 
11133     if (!prev)
11134       Diag(var->getLocation(), diag::warn_missing_variable_declarations) << var;
11135   }
11136 
11137   // Cache the result of checking for constant initialization.
11138   Optional<bool> CacheHasConstInit;
11139   const Expr *CacheCulprit;
11140   auto checkConstInit = [&]() mutable {
11141     if (!CacheHasConstInit)
11142       CacheHasConstInit = var->getInit()->isConstantInitializer(
11143             Context, var->getType()->isReferenceType(), &CacheCulprit);
11144     return *CacheHasConstInit;
11145   };
11146 
11147   if (var->getTLSKind() == VarDecl::TLS_Static) {
11148     if (var->getType().isDestructedType()) {
11149       // GNU C++98 edits for __thread, [basic.start.term]p3:
11150       //   The type of an object with thread storage duration shall not
11151       //   have a non-trivial destructor.
11152       Diag(var->getLocation(), diag::err_thread_nontrivial_dtor);
11153       if (getLangOpts().CPlusPlus11)
11154         Diag(var->getLocation(), diag::note_use_thread_local);
11155     } else if (getLangOpts().CPlusPlus && var->hasInit()) {
11156       if (!checkConstInit()) {
11157         // GNU C++98 edits for __thread, [basic.start.init]p4:
11158         //   An object of thread storage duration shall not require dynamic
11159         //   initialization.
11160         // FIXME: Need strict checking here.
11161         Diag(CacheCulprit->getExprLoc(), diag::err_thread_dynamic_init)
11162           << CacheCulprit->getSourceRange();
11163         if (getLangOpts().CPlusPlus11)
11164           Diag(var->getLocation(), diag::note_use_thread_local);
11165       }
11166     }
11167   }
11168 
11169   // Apply section attributes and pragmas to global variables.
11170   bool GlobalStorage = var->hasGlobalStorage();
11171   if (GlobalStorage && var->isThisDeclarationADefinition() &&
11172       !inTemplateInstantiation()) {
11173     PragmaStack<StringLiteral *> *Stack = nullptr;
11174     int SectionFlags = ASTContext::PSF_Implicit | ASTContext::PSF_Read;
11175     if (var->getType().isConstQualified())
11176       Stack = &ConstSegStack;
11177     else if (!var->getInit()) {
11178       Stack = &BSSSegStack;
11179       SectionFlags |= ASTContext::PSF_Write;
11180     } else {
11181       Stack = &DataSegStack;
11182       SectionFlags |= ASTContext::PSF_Write;
11183     }
11184     if (Stack->CurrentValue && !var->hasAttr<SectionAttr>()) {
11185       var->addAttr(SectionAttr::CreateImplicit(
11186           Context, SectionAttr::Declspec_allocate,
11187           Stack->CurrentValue->getString(), Stack->CurrentPragmaLocation));
11188     }
11189     if (const SectionAttr *SA = var->getAttr<SectionAttr>())
11190       if (UnifySection(SA->getName(), SectionFlags, var))
11191         var->dropAttr<SectionAttr>();
11192 
11193     // Apply the init_seg attribute if this has an initializer.  If the
11194     // initializer turns out to not be dynamic, we'll end up ignoring this
11195     // attribute.
11196     if (CurInitSeg && var->getInit())
11197       var->addAttr(InitSegAttr::CreateImplicit(Context, CurInitSeg->getString(),
11198                                                CurInitSegLoc));
11199   }
11200 
11201   // All the following checks are C++ only.
11202   if (!getLangOpts().CPlusPlus) {
11203       // If this variable must be emitted, add it as an initializer for the
11204       // current module.
11205      if (Context.DeclMustBeEmitted(var) && !ModuleScopes.empty())
11206        Context.addModuleInitializer(ModuleScopes.back().Module, var);
11207      return;
11208   }
11209 
11210   if (auto *DD = dyn_cast<DecompositionDecl>(var))
11211     CheckCompleteDecompositionDeclaration(DD);
11212 
11213   QualType type = var->getType();
11214   if (type->isDependentType()) return;
11215 
11216   // __block variables might require us to capture a copy-initializer.
11217   if (var->hasAttr<BlocksAttr>()) {
11218     // It's currently invalid to ever have a __block variable with an
11219     // array type; should we diagnose that here?
11220 
11221     // Regardless, we don't want to ignore array nesting when
11222     // constructing this copy.
11223     if (type->isStructureOrClassType()) {
11224       EnterExpressionEvaluationContext scope(
11225           *this, ExpressionEvaluationContext::PotentiallyEvaluated);
11226       SourceLocation poi = var->getLocation();
11227       Expr *varRef =new (Context) DeclRefExpr(var, false, type, VK_LValue, poi);
11228       ExprResult result
11229         = PerformMoveOrCopyInitialization(
11230             InitializedEntity::InitializeBlock(poi, type, false),
11231             var, var->getType(), varRef, /*AllowNRVO=*/true);
11232       if (!result.isInvalid()) {
11233         result = MaybeCreateExprWithCleanups(result);
11234         Expr *init = result.getAs<Expr>();
11235         Context.setBlockVarCopyInits(var, init);
11236       }
11237     }
11238   }
11239 
11240   Expr *Init = var->getInit();
11241   bool IsGlobal = GlobalStorage && !var->isStaticLocal();
11242   QualType baseType = Context.getBaseElementType(type);
11243 
11244   if (Init && !Init->isValueDependent()) {
11245     if (var->isConstexpr()) {
11246       SmallVector<PartialDiagnosticAt, 8> Notes;
11247       if (!var->evaluateValue(Notes) || !var->isInitICE()) {
11248         SourceLocation DiagLoc = var->getLocation();
11249         // If the note doesn't add any useful information other than a source
11250         // location, fold it into the primary diagnostic.
11251         if (Notes.size() == 1 && Notes[0].second.getDiagID() ==
11252               diag::note_invalid_subexpr_in_const_expr) {
11253           DiagLoc = Notes[0].first;
11254           Notes.clear();
11255         }
11256         Diag(DiagLoc, diag::err_constexpr_var_requires_const_init)
11257           << var << Init->getSourceRange();
11258         for (unsigned I = 0, N = Notes.size(); I != N; ++I)
11259           Diag(Notes[I].first, Notes[I].second);
11260       }
11261     } else if (var->isUsableInConstantExpressions(Context)) {
11262       // Check whether the initializer of a const variable of integral or
11263       // enumeration type is an ICE now, since we can't tell whether it was
11264       // initialized by a constant expression if we check later.
11265       var->checkInitIsICE();
11266     }
11267 
11268     // Don't emit further diagnostics about constexpr globals since they
11269     // were just diagnosed.
11270     if (!var->isConstexpr() && GlobalStorage &&
11271             var->hasAttr<RequireConstantInitAttr>()) {
11272       // FIXME: Need strict checking in C++03 here.
11273       bool DiagErr = getLangOpts().CPlusPlus11
11274           ? !var->checkInitIsICE() : !checkConstInit();
11275       if (DiagErr) {
11276         auto attr = var->getAttr<RequireConstantInitAttr>();
11277         Diag(var->getLocation(), diag::err_require_constant_init_failed)
11278           << Init->getSourceRange();
11279         Diag(attr->getLocation(), diag::note_declared_required_constant_init_here)
11280           << attr->getRange();
11281         if (getLangOpts().CPlusPlus11) {
11282           APValue Value;
11283           SmallVector<PartialDiagnosticAt, 8> Notes;
11284           Init->EvaluateAsInitializer(Value, getASTContext(), var, Notes);
11285           for (auto &it : Notes)
11286             Diag(it.first, it.second);
11287         } else {
11288           Diag(CacheCulprit->getExprLoc(),
11289                diag::note_invalid_subexpr_in_const_expr)
11290               << CacheCulprit->getSourceRange();
11291         }
11292       }
11293     }
11294     else if (!var->isConstexpr() && IsGlobal &&
11295              !getDiagnostics().isIgnored(diag::warn_global_constructor,
11296                                     var->getLocation())) {
11297       // Warn about globals which don't have a constant initializer.  Don't
11298       // warn about globals with a non-trivial destructor because we already
11299       // warned about them.
11300       CXXRecordDecl *RD = baseType->getAsCXXRecordDecl();
11301       if (!(RD && !RD->hasTrivialDestructor())) {
11302         if (!checkConstInit())
11303           Diag(var->getLocation(), diag::warn_global_constructor)
11304             << Init->getSourceRange();
11305       }
11306     }
11307   }
11308 
11309   // Require the destructor.
11310   if (const RecordType *recordType = baseType->getAs<RecordType>())
11311     FinalizeVarWithDestructor(var, recordType);
11312 
11313   // If this variable must be emitted, add it as an initializer for the current
11314   // module.
11315   if (Context.DeclMustBeEmitted(var) && !ModuleScopes.empty())
11316     Context.addModuleInitializer(ModuleScopes.back().Module, var);
11317 }
11318 
11319 /// \brief Determines if a variable's alignment is dependent.
11320 static bool hasDependentAlignment(VarDecl *VD) {
11321   if (VD->getType()->isDependentType())
11322     return true;
11323   for (auto *I : VD->specific_attrs<AlignedAttr>())
11324     if (I->isAlignmentDependent())
11325       return true;
11326   return false;
11327 }
11328 
11329 /// FinalizeDeclaration - called by ParseDeclarationAfterDeclarator to perform
11330 /// any semantic actions necessary after any initializer has been attached.
11331 void Sema::FinalizeDeclaration(Decl *ThisDecl) {
11332   // Note that we are no longer parsing the initializer for this declaration.
11333   ParsingInitForAutoVars.erase(ThisDecl);
11334 
11335   VarDecl *VD = dyn_cast_or_null<VarDecl>(ThisDecl);
11336   if (!VD)
11337     return;
11338 
11339   // Apply an implicit SectionAttr if '#pragma clang section bss|data|rodata' is active
11340   if (VD->hasGlobalStorage() && VD->isThisDeclarationADefinition() &&
11341       !inTemplateInstantiation() && !VD->hasAttr<SectionAttr>()) {
11342     if (PragmaClangBSSSection.Valid)
11343       VD->addAttr(PragmaClangBSSSectionAttr::CreateImplicit(Context,
11344                                                             PragmaClangBSSSection.SectionName,
11345                                                             PragmaClangBSSSection.PragmaLocation));
11346     if (PragmaClangDataSection.Valid)
11347       VD->addAttr(PragmaClangDataSectionAttr::CreateImplicit(Context,
11348                                                              PragmaClangDataSection.SectionName,
11349                                                              PragmaClangDataSection.PragmaLocation));
11350     if (PragmaClangRodataSection.Valid)
11351       VD->addAttr(PragmaClangRodataSectionAttr::CreateImplicit(Context,
11352                                                                PragmaClangRodataSection.SectionName,
11353                                                                PragmaClangRodataSection.PragmaLocation));
11354   }
11355 
11356   if (auto *DD = dyn_cast<DecompositionDecl>(ThisDecl)) {
11357     for (auto *BD : DD->bindings()) {
11358       FinalizeDeclaration(BD);
11359     }
11360   }
11361 
11362   checkAttributesAfterMerging(*this, *VD);
11363 
11364   // Perform TLS alignment check here after attributes attached to the variable
11365   // which may affect the alignment have been processed. Only perform the check
11366   // if the target has a maximum TLS alignment (zero means no constraints).
11367   if (unsigned MaxAlign = Context.getTargetInfo().getMaxTLSAlign()) {
11368     // Protect the check so that it's not performed on dependent types and
11369     // dependent alignments (we can't determine the alignment in that case).
11370     if (VD->getTLSKind() && !hasDependentAlignment(VD) &&
11371         !VD->isInvalidDecl()) {
11372       CharUnits MaxAlignChars = Context.toCharUnitsFromBits(MaxAlign);
11373       if (Context.getDeclAlign(VD) > MaxAlignChars) {
11374         Diag(VD->getLocation(), diag::err_tls_var_aligned_over_maximum)
11375           << (unsigned)Context.getDeclAlign(VD).getQuantity() << VD
11376           << (unsigned)MaxAlignChars.getQuantity();
11377       }
11378     }
11379   }
11380 
11381   if (VD->isStaticLocal()) {
11382     if (FunctionDecl *FD =
11383             dyn_cast_or_null<FunctionDecl>(VD->getParentFunctionOrMethod())) {
11384       // Static locals inherit dll attributes from their function.
11385       if (Attr *A = getDLLAttr(FD)) {
11386         auto *NewAttr = cast<InheritableAttr>(A->clone(getASTContext()));
11387         NewAttr->setInherited(true);
11388         VD->addAttr(NewAttr);
11389       }
11390       // CUDA E.2.9.4: Within the body of a __device__ or __global__
11391       // function, only __shared__ variables may be declared with
11392       // static storage class.
11393       if (getLangOpts().CUDA && !VD->hasAttr<CUDASharedAttr>() &&
11394           CUDADiagIfDeviceCode(VD->getLocation(),
11395                                diag::err_device_static_local_var)
11396               << CurrentCUDATarget())
11397         VD->setInvalidDecl();
11398     }
11399   }
11400 
11401   // Perform check for initializers of device-side global variables.
11402   // CUDA allows empty constructors as initializers (see E.2.3.1, CUDA
11403   // 7.5). We must also apply the same checks to all __shared__
11404   // variables whether they are local or not. CUDA also allows
11405   // constant initializers for __constant__ and __device__ variables.
11406   if (getLangOpts().CUDA) {
11407     const Expr *Init = VD->getInit();
11408     if (Init && VD->hasGlobalStorage()) {
11409       if (VD->hasAttr<CUDADeviceAttr>() || VD->hasAttr<CUDAConstantAttr>() ||
11410           VD->hasAttr<CUDASharedAttr>()) {
11411         assert(!VD->isStaticLocal() || VD->hasAttr<CUDASharedAttr>());
11412         bool AllowedInit = false;
11413         if (const CXXConstructExpr *CE = dyn_cast<CXXConstructExpr>(Init))
11414           AllowedInit =
11415               isEmptyCudaConstructor(VD->getLocation(), CE->getConstructor());
11416         // We'll allow constant initializers even if it's a non-empty
11417         // constructor according to CUDA rules. This deviates from NVCC,
11418         // but allows us to handle things like constexpr constructors.
11419         if (!AllowedInit &&
11420             (VD->hasAttr<CUDADeviceAttr>() || VD->hasAttr<CUDAConstantAttr>()))
11421           AllowedInit = VD->getInit()->isConstantInitializer(
11422               Context, VD->getType()->isReferenceType());
11423 
11424         // Also make sure that destructor, if there is one, is empty.
11425         if (AllowedInit)
11426           if (CXXRecordDecl *RD = VD->getType()->getAsCXXRecordDecl())
11427             AllowedInit =
11428                 isEmptyCudaDestructor(VD->getLocation(), RD->getDestructor());
11429 
11430         if (!AllowedInit) {
11431           Diag(VD->getLocation(), VD->hasAttr<CUDASharedAttr>()
11432                                       ? diag::err_shared_var_init
11433                                       : diag::err_dynamic_var_init)
11434               << Init->getSourceRange();
11435           VD->setInvalidDecl();
11436         }
11437       } else {
11438         // This is a host-side global variable.  Check that the initializer is
11439         // callable from the host side.
11440         const FunctionDecl *InitFn = nullptr;
11441         if (const CXXConstructExpr *CE = dyn_cast<CXXConstructExpr>(Init)) {
11442           InitFn = CE->getConstructor();
11443         } else if (const CallExpr *CE = dyn_cast<CallExpr>(Init)) {
11444           InitFn = CE->getDirectCallee();
11445         }
11446         if (InitFn) {
11447           CUDAFunctionTarget InitFnTarget = IdentifyCUDATarget(InitFn);
11448           if (InitFnTarget != CFT_Host && InitFnTarget != CFT_HostDevice) {
11449             Diag(VD->getLocation(), diag::err_ref_bad_target_global_initializer)
11450                 << InitFnTarget << InitFn;
11451             Diag(InitFn->getLocation(), diag::note_previous_decl) << InitFn;
11452             VD->setInvalidDecl();
11453           }
11454         }
11455       }
11456     }
11457   }
11458 
11459   // Grab the dllimport or dllexport attribute off of the VarDecl.
11460   const InheritableAttr *DLLAttr = getDLLAttr(VD);
11461 
11462   // Imported static data members cannot be defined out-of-line.
11463   if (const auto *IA = dyn_cast_or_null<DLLImportAttr>(DLLAttr)) {
11464     if (VD->isStaticDataMember() && VD->isOutOfLine() &&
11465         VD->isThisDeclarationADefinition()) {
11466       // We allow definitions of dllimport class template static data members
11467       // with a warning.
11468       CXXRecordDecl *Context =
11469         cast<CXXRecordDecl>(VD->getFirstDecl()->getDeclContext());
11470       bool IsClassTemplateMember =
11471           isa<ClassTemplatePartialSpecializationDecl>(Context) ||
11472           Context->getDescribedClassTemplate();
11473 
11474       Diag(VD->getLocation(),
11475            IsClassTemplateMember
11476                ? diag::warn_attribute_dllimport_static_field_definition
11477                : diag::err_attribute_dllimport_static_field_definition);
11478       Diag(IA->getLocation(), diag::note_attribute);
11479       if (!IsClassTemplateMember)
11480         VD->setInvalidDecl();
11481     }
11482   }
11483 
11484   // dllimport/dllexport variables cannot be thread local, their TLS index
11485   // isn't exported with the variable.
11486   if (DLLAttr && VD->getTLSKind()) {
11487     auto *F = dyn_cast_or_null<FunctionDecl>(VD->getParentFunctionOrMethod());
11488     if (F && getDLLAttr(F)) {
11489       assert(VD->isStaticLocal());
11490       // But if this is a static local in a dlimport/dllexport function, the
11491       // function will never be inlined, which means the var would never be
11492       // imported, so having it marked import/export is safe.
11493     } else {
11494       Diag(VD->getLocation(), diag::err_attribute_dll_thread_local) << VD
11495                                                                     << DLLAttr;
11496       VD->setInvalidDecl();
11497     }
11498   }
11499 
11500   if (UsedAttr *Attr = VD->getAttr<UsedAttr>()) {
11501     if (!Attr->isInherited() && !VD->isThisDeclarationADefinition()) {
11502       Diag(Attr->getLocation(), diag::warn_attribute_ignored) << Attr;
11503       VD->dropAttr<UsedAttr>();
11504     }
11505   }
11506 
11507   const DeclContext *DC = VD->getDeclContext();
11508   // If there's a #pragma GCC visibility in scope, and this isn't a class
11509   // member, set the visibility of this variable.
11510   if (DC->getRedeclContext()->isFileContext() && VD->isExternallyVisible())
11511     AddPushedVisibilityAttribute(VD);
11512 
11513   // FIXME: Warn on unused var template partial specializations.
11514   if (VD->isFileVarDecl() && !isa<VarTemplatePartialSpecializationDecl>(VD))
11515     MarkUnusedFileScopedDecl(VD);
11516 
11517   // Now we have parsed the initializer and can update the table of magic
11518   // tag values.
11519   if (!VD->hasAttr<TypeTagForDatatypeAttr>() ||
11520       !VD->getType()->isIntegralOrEnumerationType())
11521     return;
11522 
11523   for (const auto *I : ThisDecl->specific_attrs<TypeTagForDatatypeAttr>()) {
11524     const Expr *MagicValueExpr = VD->getInit();
11525     if (!MagicValueExpr) {
11526       continue;
11527     }
11528     llvm::APSInt MagicValueInt;
11529     if (!MagicValueExpr->isIntegerConstantExpr(MagicValueInt, Context)) {
11530       Diag(I->getRange().getBegin(),
11531            diag::err_type_tag_for_datatype_not_ice)
11532         << LangOpts.CPlusPlus << MagicValueExpr->getSourceRange();
11533       continue;
11534     }
11535     if (MagicValueInt.getActiveBits() > 64) {
11536       Diag(I->getRange().getBegin(),
11537            diag::err_type_tag_for_datatype_too_large)
11538         << LangOpts.CPlusPlus << MagicValueExpr->getSourceRange();
11539       continue;
11540     }
11541     uint64_t MagicValue = MagicValueInt.getZExtValue();
11542     RegisterTypeTagForDatatype(I->getArgumentKind(),
11543                                MagicValue,
11544                                I->getMatchingCType(),
11545                                I->getLayoutCompatible(),
11546                                I->getMustBeNull());
11547   }
11548 }
11549 
11550 static bool hasDeducedAuto(DeclaratorDecl *DD) {
11551   auto *VD = dyn_cast<VarDecl>(DD);
11552   return VD && !VD->getType()->hasAutoForTrailingReturnType();
11553 }
11554 
11555 Sema::DeclGroupPtrTy Sema::FinalizeDeclaratorGroup(Scope *S, const DeclSpec &DS,
11556                                                    ArrayRef<Decl *> Group) {
11557   SmallVector<Decl*, 8> Decls;
11558 
11559   if (DS.isTypeSpecOwned())
11560     Decls.push_back(DS.getRepAsDecl());
11561 
11562   DeclaratorDecl *FirstDeclaratorInGroup = nullptr;
11563   DecompositionDecl *FirstDecompDeclaratorInGroup = nullptr;
11564   bool DiagnosedMultipleDecomps = false;
11565   DeclaratorDecl *FirstNonDeducedAutoInGroup = nullptr;
11566   bool DiagnosedNonDeducedAuto = false;
11567 
11568   for (unsigned i = 0, e = Group.size(); i != e; ++i) {
11569     if (Decl *D = Group[i]) {
11570       // For declarators, there are some additional syntactic-ish checks we need
11571       // to perform.
11572       if (auto *DD = dyn_cast<DeclaratorDecl>(D)) {
11573         if (!FirstDeclaratorInGroup)
11574           FirstDeclaratorInGroup = DD;
11575         if (!FirstDecompDeclaratorInGroup)
11576           FirstDecompDeclaratorInGroup = dyn_cast<DecompositionDecl>(D);
11577         if (!FirstNonDeducedAutoInGroup && DS.hasAutoTypeSpec() &&
11578             !hasDeducedAuto(DD))
11579           FirstNonDeducedAutoInGroup = DD;
11580 
11581         if (FirstDeclaratorInGroup != DD) {
11582           // A decomposition declaration cannot be combined with any other
11583           // declaration in the same group.
11584           if (FirstDecompDeclaratorInGroup && !DiagnosedMultipleDecomps) {
11585             Diag(FirstDecompDeclaratorInGroup->getLocation(),
11586                  diag::err_decomp_decl_not_alone)
11587                 << FirstDeclaratorInGroup->getSourceRange()
11588                 << DD->getSourceRange();
11589             DiagnosedMultipleDecomps = true;
11590           }
11591 
11592           // A declarator that uses 'auto' in any way other than to declare a
11593           // variable with a deduced type cannot be combined with any other
11594           // declarator in the same group.
11595           if (FirstNonDeducedAutoInGroup && !DiagnosedNonDeducedAuto) {
11596             Diag(FirstNonDeducedAutoInGroup->getLocation(),
11597                  diag::err_auto_non_deduced_not_alone)
11598                 << FirstNonDeducedAutoInGroup->getType()
11599                        ->hasAutoForTrailingReturnType()
11600                 << FirstDeclaratorInGroup->getSourceRange()
11601                 << DD->getSourceRange();
11602             DiagnosedNonDeducedAuto = true;
11603           }
11604         }
11605       }
11606 
11607       Decls.push_back(D);
11608     }
11609   }
11610 
11611   if (DeclSpec::isDeclRep(DS.getTypeSpecType())) {
11612     if (TagDecl *Tag = dyn_cast_or_null<TagDecl>(DS.getRepAsDecl())) {
11613       handleTagNumbering(Tag, S);
11614       if (FirstDeclaratorInGroup && !Tag->hasNameForLinkage() &&
11615           getLangOpts().CPlusPlus)
11616         Context.addDeclaratorForUnnamedTagDecl(Tag, FirstDeclaratorInGroup);
11617     }
11618   }
11619 
11620   return BuildDeclaratorGroup(Decls);
11621 }
11622 
11623 /// BuildDeclaratorGroup - convert a list of declarations into a declaration
11624 /// group, performing any necessary semantic checking.
11625 Sema::DeclGroupPtrTy
11626 Sema::BuildDeclaratorGroup(MutableArrayRef<Decl *> Group) {
11627   // C++14 [dcl.spec.auto]p7: (DR1347)
11628   //   If the type that replaces the placeholder type is not the same in each
11629   //   deduction, the program is ill-formed.
11630   if (Group.size() > 1) {
11631     QualType Deduced;
11632     VarDecl *DeducedDecl = nullptr;
11633     for (unsigned i = 0, e = Group.size(); i != e; ++i) {
11634       VarDecl *D = dyn_cast<VarDecl>(Group[i]);
11635       if (!D || D->isInvalidDecl())
11636         break;
11637       DeducedType *DT = D->getType()->getContainedDeducedType();
11638       if (!DT || DT->getDeducedType().isNull())
11639         continue;
11640       if (Deduced.isNull()) {
11641         Deduced = DT->getDeducedType();
11642         DeducedDecl = D;
11643       } else if (!Context.hasSameType(DT->getDeducedType(), Deduced)) {
11644         auto *AT = dyn_cast<AutoType>(DT);
11645         Diag(D->getTypeSourceInfo()->getTypeLoc().getBeginLoc(),
11646              diag::err_auto_different_deductions)
11647           << (AT ? (unsigned)AT->getKeyword() : 3)
11648           << Deduced << DeducedDecl->getDeclName()
11649           << DT->getDeducedType() << D->getDeclName()
11650           << DeducedDecl->getInit()->getSourceRange()
11651           << D->getInit()->getSourceRange();
11652         D->setInvalidDecl();
11653         break;
11654       }
11655     }
11656   }
11657 
11658   ActOnDocumentableDecls(Group);
11659 
11660   return DeclGroupPtrTy::make(
11661       DeclGroupRef::Create(Context, Group.data(), Group.size()));
11662 }
11663 
11664 void Sema::ActOnDocumentableDecl(Decl *D) {
11665   ActOnDocumentableDecls(D);
11666 }
11667 
11668 void Sema::ActOnDocumentableDecls(ArrayRef<Decl *> Group) {
11669   // Don't parse the comment if Doxygen diagnostics are ignored.
11670   if (Group.empty() || !Group[0])
11671     return;
11672 
11673   if (Diags.isIgnored(diag::warn_doc_param_not_found,
11674                       Group[0]->getLocation()) &&
11675       Diags.isIgnored(diag::warn_unknown_comment_command_name,
11676                       Group[0]->getLocation()))
11677     return;
11678 
11679   if (Group.size() >= 2) {
11680     // This is a decl group.  Normally it will contain only declarations
11681     // produced from declarator list.  But in case we have any definitions or
11682     // additional declaration references:
11683     //   'typedef struct S {} S;'
11684     //   'typedef struct S *S;'
11685     //   'struct S *pS;'
11686     // FinalizeDeclaratorGroup adds these as separate declarations.
11687     Decl *MaybeTagDecl = Group[0];
11688     if (MaybeTagDecl && isa<TagDecl>(MaybeTagDecl)) {
11689       Group = Group.slice(1);
11690     }
11691   }
11692 
11693   // See if there are any new comments that are not attached to a decl.
11694   ArrayRef<RawComment *> Comments = Context.getRawCommentList().getComments();
11695   if (!Comments.empty() &&
11696       !Comments.back()->isAttached()) {
11697     // There is at least one comment that not attached to a decl.
11698     // Maybe it should be attached to one of these decls?
11699     //
11700     // Note that this way we pick up not only comments that precede the
11701     // declaration, but also comments that *follow* the declaration -- thanks to
11702     // the lookahead in the lexer: we've consumed the semicolon and looked
11703     // ahead through comments.
11704     for (unsigned i = 0, e = Group.size(); i != e; ++i)
11705       Context.getCommentForDecl(Group[i], &PP);
11706   }
11707 }
11708 
11709 /// ActOnParamDeclarator - Called from Parser::ParseFunctionDeclarator()
11710 /// to introduce parameters into function prototype scope.
11711 Decl *Sema::ActOnParamDeclarator(Scope *S, Declarator &D) {
11712   const DeclSpec &DS = D.getDeclSpec();
11713 
11714   // Verify C99 6.7.5.3p2: The only SCS allowed is 'register'.
11715 
11716   // C++03 [dcl.stc]p2 also permits 'auto'.
11717   StorageClass SC = SC_None;
11718   if (DS.getStorageClassSpec() == DeclSpec::SCS_register) {
11719     SC = SC_Register;
11720   } else if (getLangOpts().CPlusPlus &&
11721              DS.getStorageClassSpec() == DeclSpec::SCS_auto) {
11722     SC = SC_Auto;
11723   } else if (DS.getStorageClassSpec() != DeclSpec::SCS_unspecified) {
11724     Diag(DS.getStorageClassSpecLoc(),
11725          diag::err_invalid_storage_class_in_func_decl);
11726     D.getMutableDeclSpec().ClearStorageClassSpecs();
11727   }
11728 
11729   if (DeclSpec::TSCS TSCS = DS.getThreadStorageClassSpec())
11730     Diag(DS.getThreadStorageClassSpecLoc(), diag::err_invalid_thread)
11731       << DeclSpec::getSpecifierName(TSCS);
11732   if (DS.isInlineSpecified())
11733     Diag(DS.getInlineSpecLoc(), diag::err_inline_non_function)
11734         << getLangOpts().CPlusPlus1z;
11735   if (DS.isConstexprSpecified())
11736     Diag(DS.getConstexprSpecLoc(), diag::err_invalid_constexpr)
11737       << 0;
11738   if (DS.isConceptSpecified())
11739     Diag(DS.getConceptSpecLoc(), diag::err_concept_wrong_decl_kind);
11740 
11741   DiagnoseFunctionSpecifiers(DS);
11742 
11743   TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
11744   QualType parmDeclType = TInfo->getType();
11745 
11746   if (getLangOpts().CPlusPlus) {
11747     // Check that there are no default arguments inside the type of this
11748     // parameter.
11749     CheckExtraCXXDefaultArguments(D);
11750 
11751     // Parameter declarators cannot be qualified (C++ [dcl.meaning]p1).
11752     if (D.getCXXScopeSpec().isSet()) {
11753       Diag(D.getIdentifierLoc(), diag::err_qualified_param_declarator)
11754         << D.getCXXScopeSpec().getRange();
11755       D.getCXXScopeSpec().clear();
11756     }
11757   }
11758 
11759   // Ensure we have a valid name
11760   IdentifierInfo *II = nullptr;
11761   if (D.hasName()) {
11762     II = D.getIdentifier();
11763     if (!II) {
11764       Diag(D.getIdentifierLoc(), diag::err_bad_parameter_name)
11765         << GetNameForDeclarator(D).getName();
11766       D.setInvalidType(true);
11767     }
11768   }
11769 
11770   // Check for redeclaration of parameters, e.g. int foo(int x, int x);
11771   if (II) {
11772     LookupResult R(*this, II, D.getIdentifierLoc(), LookupOrdinaryName,
11773                    ForVisibleRedeclaration);
11774     LookupName(R, S);
11775     if (R.isSingleResult()) {
11776       NamedDecl *PrevDecl = R.getFoundDecl();
11777       if (PrevDecl->isTemplateParameter()) {
11778         // Maybe we will complain about the shadowed template parameter.
11779         DiagnoseTemplateParameterShadow(D.getIdentifierLoc(), PrevDecl);
11780         // Just pretend that we didn't see the previous declaration.
11781         PrevDecl = nullptr;
11782       } else if (S->isDeclScope(PrevDecl)) {
11783         Diag(D.getIdentifierLoc(), diag::err_param_redefinition) << II;
11784         Diag(PrevDecl->getLocation(), diag::note_previous_declaration);
11785 
11786         // Recover by removing the name
11787         II = nullptr;
11788         D.SetIdentifier(nullptr, D.getIdentifierLoc());
11789         D.setInvalidType(true);
11790       }
11791     }
11792   }
11793 
11794   // Temporarily put parameter variables in the translation unit, not
11795   // the enclosing context.  This prevents them from accidentally
11796   // looking like class members in C++.
11797   ParmVarDecl *New = CheckParameter(Context.getTranslationUnitDecl(),
11798                                     D.getLocStart(),
11799                                     D.getIdentifierLoc(), II,
11800                                     parmDeclType, TInfo,
11801                                     SC);
11802 
11803   if (D.isInvalidType())
11804     New->setInvalidDecl();
11805 
11806   assert(S->isFunctionPrototypeScope());
11807   assert(S->getFunctionPrototypeDepth() >= 1);
11808   New->setScopeInfo(S->getFunctionPrototypeDepth() - 1,
11809                     S->getNextFunctionPrototypeIndex());
11810 
11811   // Add the parameter declaration into this scope.
11812   S->AddDecl(New);
11813   if (II)
11814     IdResolver.AddDecl(New);
11815 
11816   ProcessDeclAttributes(S, New, D);
11817 
11818   if (D.getDeclSpec().isModulePrivateSpecified())
11819     Diag(New->getLocation(), diag::err_module_private_local)
11820       << 1 << New->getDeclName()
11821       << SourceRange(D.getDeclSpec().getModulePrivateSpecLoc())
11822       << FixItHint::CreateRemoval(D.getDeclSpec().getModulePrivateSpecLoc());
11823 
11824   if (New->hasAttr<BlocksAttr>()) {
11825     Diag(New->getLocation(), diag::err_block_on_nonlocal);
11826   }
11827   return New;
11828 }
11829 
11830 /// \brief Synthesizes a variable for a parameter arising from a
11831 /// typedef.
11832 ParmVarDecl *Sema::BuildParmVarDeclForTypedef(DeclContext *DC,
11833                                               SourceLocation Loc,
11834                                               QualType T) {
11835   /* FIXME: setting StartLoc == Loc.
11836      Would it be worth to modify callers so as to provide proper source
11837      location for the unnamed parameters, embedding the parameter's type? */
11838   ParmVarDecl *Param = ParmVarDecl::Create(Context, DC, Loc, Loc, nullptr,
11839                                 T, Context.getTrivialTypeSourceInfo(T, Loc),
11840                                            SC_None, nullptr);
11841   Param->setImplicit();
11842   return Param;
11843 }
11844 
11845 void Sema::DiagnoseUnusedParameters(ArrayRef<ParmVarDecl *> Parameters) {
11846   // Don't diagnose unused-parameter errors in template instantiations; we
11847   // will already have done so in the template itself.
11848   if (inTemplateInstantiation())
11849     return;
11850 
11851   for (const ParmVarDecl *Parameter : Parameters) {
11852     if (!Parameter->isReferenced() && Parameter->getDeclName() &&
11853         !Parameter->hasAttr<UnusedAttr>()) {
11854       Diag(Parameter->getLocation(), diag::warn_unused_parameter)
11855         << Parameter->getDeclName();
11856     }
11857   }
11858 }
11859 
11860 void Sema::DiagnoseSizeOfParametersAndReturnValue(
11861     ArrayRef<ParmVarDecl *> Parameters, QualType ReturnTy, NamedDecl *D) {
11862   if (LangOpts.NumLargeByValueCopy == 0) // No check.
11863     return;
11864 
11865   // Warn if the return value is pass-by-value and larger than the specified
11866   // threshold.
11867   if (!ReturnTy->isDependentType() && ReturnTy.isPODType(Context)) {
11868     unsigned Size = Context.getTypeSizeInChars(ReturnTy).getQuantity();
11869     if (Size > LangOpts.NumLargeByValueCopy)
11870       Diag(D->getLocation(), diag::warn_return_value_size)
11871           << D->getDeclName() << Size;
11872   }
11873 
11874   // Warn if any parameter is pass-by-value and larger than the specified
11875   // threshold.
11876   for (const ParmVarDecl *Parameter : Parameters) {
11877     QualType T = Parameter->getType();
11878     if (T->isDependentType() || !T.isPODType(Context))
11879       continue;
11880     unsigned Size = Context.getTypeSizeInChars(T).getQuantity();
11881     if (Size > LangOpts.NumLargeByValueCopy)
11882       Diag(Parameter->getLocation(), diag::warn_parameter_size)
11883           << Parameter->getDeclName() << Size;
11884   }
11885 }
11886 
11887 ParmVarDecl *Sema::CheckParameter(DeclContext *DC, SourceLocation StartLoc,
11888                                   SourceLocation NameLoc, IdentifierInfo *Name,
11889                                   QualType T, TypeSourceInfo *TSInfo,
11890                                   StorageClass SC) {
11891   // In ARC, infer a lifetime qualifier for appropriate parameter types.
11892   if (getLangOpts().ObjCAutoRefCount &&
11893       T.getObjCLifetime() == Qualifiers::OCL_None &&
11894       T->isObjCLifetimeType()) {
11895 
11896     Qualifiers::ObjCLifetime lifetime;
11897 
11898     // Special cases for arrays:
11899     //   - if it's const, use __unsafe_unretained
11900     //   - otherwise, it's an error
11901     if (T->isArrayType()) {
11902       if (!T.isConstQualified()) {
11903         DelayedDiagnostics.add(
11904             sema::DelayedDiagnostic::makeForbiddenType(
11905             NameLoc, diag::err_arc_array_param_no_ownership, T, false));
11906       }
11907       lifetime = Qualifiers::OCL_ExplicitNone;
11908     } else {
11909       lifetime = T->getObjCARCImplicitLifetime();
11910     }
11911     T = Context.getLifetimeQualifiedType(T, lifetime);
11912   }
11913 
11914   ParmVarDecl *New = ParmVarDecl::Create(Context, DC, StartLoc, NameLoc, Name,
11915                                          Context.getAdjustedParameterType(T),
11916                                          TSInfo, SC, nullptr);
11917 
11918   // Parameters can not be abstract class types.
11919   // For record types, this is done by the AbstractClassUsageDiagnoser once
11920   // the class has been completely parsed.
11921   if (!CurContext->isRecord() &&
11922       RequireNonAbstractType(NameLoc, T, diag::err_abstract_type_in_decl,
11923                              AbstractParamType))
11924     New->setInvalidDecl();
11925 
11926   // Parameter declarators cannot be interface types. All ObjC objects are
11927   // passed by reference.
11928   if (T->isObjCObjectType()) {
11929     SourceLocation TypeEndLoc =
11930         getLocForEndOfToken(TSInfo->getTypeLoc().getLocEnd());
11931     Diag(NameLoc,
11932          diag::err_object_cannot_be_passed_returned_by_value) << 1 << T
11933       << FixItHint::CreateInsertion(TypeEndLoc, "*");
11934     T = Context.getObjCObjectPointerType(T);
11935     New->setType(T);
11936   }
11937 
11938   // ISO/IEC TR 18037 S6.7.3: "The type of an object with automatic storage
11939   // duration shall not be qualified by an address-space qualifier."
11940   // Since all parameters have automatic store duration, they can not have
11941   // an address space.
11942   if (T.getAddressSpace() != LangAS::Default &&
11943       // OpenCL allows function arguments declared to be an array of a type
11944       // to be qualified with an address space.
11945       !(getLangOpts().OpenCL &&
11946         (T->isArrayType() || T.getAddressSpace() == LangAS::opencl_private))) {
11947     Diag(NameLoc, diag::err_arg_with_address_space);
11948     New->setInvalidDecl();
11949   }
11950 
11951   return New;
11952 }
11953 
11954 void Sema::ActOnFinishKNRParamDeclarations(Scope *S, Declarator &D,
11955                                            SourceLocation LocAfterDecls) {
11956   DeclaratorChunk::FunctionTypeInfo &FTI = D.getFunctionTypeInfo();
11957 
11958   // Verify 6.9.1p6: 'every identifier in the identifier list shall be declared'
11959   // for a K&R function.
11960   if (!FTI.hasPrototype) {
11961     for (int i = FTI.NumParams; i != 0; /* decrement in loop */) {
11962       --i;
11963       if (FTI.Params[i].Param == nullptr) {
11964         SmallString<256> Code;
11965         llvm::raw_svector_ostream(Code)
11966             << "  int " << FTI.Params[i].Ident->getName() << ";\n";
11967         Diag(FTI.Params[i].IdentLoc, diag::ext_param_not_declared)
11968             << FTI.Params[i].Ident
11969             << FixItHint::CreateInsertion(LocAfterDecls, Code);
11970 
11971         // Implicitly declare the argument as type 'int' for lack of a better
11972         // type.
11973         AttributeFactory attrs;
11974         DeclSpec DS(attrs);
11975         const char* PrevSpec; // unused
11976         unsigned DiagID; // unused
11977         DS.SetTypeSpecType(DeclSpec::TST_int, FTI.Params[i].IdentLoc, PrevSpec,
11978                            DiagID, Context.getPrintingPolicy());
11979         // Use the identifier location for the type source range.
11980         DS.SetRangeStart(FTI.Params[i].IdentLoc);
11981         DS.SetRangeEnd(FTI.Params[i].IdentLoc);
11982         Declarator ParamD(DS, Declarator::KNRTypeListContext);
11983         ParamD.SetIdentifier(FTI.Params[i].Ident, FTI.Params[i].IdentLoc);
11984         FTI.Params[i].Param = ActOnParamDeclarator(S, ParamD);
11985       }
11986     }
11987   }
11988 }
11989 
11990 Decl *
11991 Sema::ActOnStartOfFunctionDef(Scope *FnBodyScope, Declarator &D,
11992                               MultiTemplateParamsArg TemplateParameterLists,
11993                               SkipBodyInfo *SkipBody) {
11994   assert(getCurFunctionDecl() == nullptr && "Function parsing confused");
11995   assert(D.isFunctionDeclarator() && "Not a function declarator!");
11996   Scope *ParentScope = FnBodyScope->getParent();
11997 
11998   D.setFunctionDefinitionKind(FDK_Definition);
11999   Decl *DP = HandleDeclarator(ParentScope, D, TemplateParameterLists);
12000   return ActOnStartOfFunctionDef(FnBodyScope, DP, SkipBody);
12001 }
12002 
12003 void Sema::ActOnFinishInlineFunctionDef(FunctionDecl *D) {
12004   Consumer.HandleInlineFunctionDefinition(D);
12005 }
12006 
12007 static bool ShouldWarnAboutMissingPrototype(const FunctionDecl *FD,
12008                              const FunctionDecl*& PossibleZeroParamPrototype) {
12009   // Don't warn about invalid declarations.
12010   if (FD->isInvalidDecl())
12011     return false;
12012 
12013   // Or declarations that aren't global.
12014   if (!FD->isGlobal())
12015     return false;
12016 
12017   // Don't warn about C++ member functions.
12018   if (isa<CXXMethodDecl>(FD))
12019     return false;
12020 
12021   // Don't warn about 'main'.
12022   if (FD->isMain())
12023     return false;
12024 
12025   // Don't warn about inline functions.
12026   if (FD->isInlined())
12027     return false;
12028 
12029   // Don't warn about function templates.
12030   if (FD->getDescribedFunctionTemplate())
12031     return false;
12032 
12033   // Don't warn about function template specializations.
12034   if (FD->isFunctionTemplateSpecialization())
12035     return false;
12036 
12037   // Don't warn for OpenCL kernels.
12038   if (FD->hasAttr<OpenCLKernelAttr>())
12039     return false;
12040 
12041   // Don't warn on explicitly deleted functions.
12042   if (FD->isDeleted())
12043     return false;
12044 
12045   bool MissingPrototype = true;
12046   for (const FunctionDecl *Prev = FD->getPreviousDecl();
12047        Prev; Prev = Prev->getPreviousDecl()) {
12048     // Ignore any declarations that occur in function or method
12049     // scope, because they aren't visible from the header.
12050     if (Prev->getLexicalDeclContext()->isFunctionOrMethod())
12051       continue;
12052 
12053     MissingPrototype = !Prev->getType()->isFunctionProtoType();
12054     if (FD->getNumParams() == 0)
12055       PossibleZeroParamPrototype = Prev;
12056     break;
12057   }
12058 
12059   return MissingPrototype;
12060 }
12061 
12062 void
12063 Sema::CheckForFunctionRedefinition(FunctionDecl *FD,
12064                                    const FunctionDecl *EffectiveDefinition,
12065                                    SkipBodyInfo *SkipBody) {
12066   const FunctionDecl *Definition = EffectiveDefinition;
12067   if (!Definition)
12068     if (!FD->isDefined(Definition))
12069       return;
12070 
12071   if (canRedefineFunction(Definition, getLangOpts()))
12072     return;
12073 
12074   // Don't emit an error when this is redefinition of a typo-corrected
12075   // definition.
12076   if (TypoCorrectedFunctionDefinitions.count(Definition))
12077     return;
12078 
12079   // If we don't have a visible definition of the function, and it's inline or
12080   // a template, skip the new definition.
12081   if (SkipBody && !hasVisibleDefinition(Definition) &&
12082       (Definition->getFormalLinkage() == InternalLinkage ||
12083        Definition->isInlined() ||
12084        Definition->getDescribedFunctionTemplate() ||
12085        Definition->getNumTemplateParameterLists())) {
12086     SkipBody->ShouldSkip = true;
12087     if (auto *TD = Definition->getDescribedFunctionTemplate())
12088       makeMergedDefinitionVisible(TD);
12089     makeMergedDefinitionVisible(const_cast<FunctionDecl*>(Definition));
12090     return;
12091   }
12092 
12093   if (getLangOpts().GNUMode && Definition->isInlineSpecified() &&
12094       Definition->getStorageClass() == SC_Extern)
12095     Diag(FD->getLocation(), diag::err_redefinition_extern_inline)
12096         << FD->getDeclName() << getLangOpts().CPlusPlus;
12097   else
12098     Diag(FD->getLocation(), diag::err_redefinition) << FD->getDeclName();
12099 
12100   Diag(Definition->getLocation(), diag::note_previous_definition);
12101   FD->setInvalidDecl();
12102 }
12103 
12104 static void RebuildLambdaScopeInfo(CXXMethodDecl *CallOperator,
12105                                    Sema &S) {
12106   CXXRecordDecl *const LambdaClass = CallOperator->getParent();
12107 
12108   LambdaScopeInfo *LSI = S.PushLambdaScope();
12109   LSI->CallOperator = CallOperator;
12110   LSI->Lambda = LambdaClass;
12111   LSI->ReturnType = CallOperator->getReturnType();
12112   const LambdaCaptureDefault LCD = LambdaClass->getLambdaCaptureDefault();
12113 
12114   if (LCD == LCD_None)
12115     LSI->ImpCaptureStyle = CapturingScopeInfo::ImpCap_None;
12116   else if (LCD == LCD_ByCopy)
12117     LSI->ImpCaptureStyle = CapturingScopeInfo::ImpCap_LambdaByval;
12118   else if (LCD == LCD_ByRef)
12119     LSI->ImpCaptureStyle = CapturingScopeInfo::ImpCap_LambdaByref;
12120   DeclarationNameInfo DNI = CallOperator->getNameInfo();
12121 
12122   LSI->IntroducerRange = DNI.getCXXOperatorNameRange();
12123   LSI->Mutable = !CallOperator->isConst();
12124 
12125   // Add the captures to the LSI so they can be noted as already
12126   // captured within tryCaptureVar.
12127   auto I = LambdaClass->field_begin();
12128   for (const auto &C : LambdaClass->captures()) {
12129     if (C.capturesVariable()) {
12130       VarDecl *VD = C.getCapturedVar();
12131       if (VD->isInitCapture())
12132         S.CurrentInstantiationScope->InstantiatedLocal(VD, VD);
12133       QualType CaptureType = VD->getType();
12134       const bool ByRef = C.getCaptureKind() == LCK_ByRef;
12135       LSI->addCapture(VD, /*IsBlock*/false, ByRef,
12136           /*RefersToEnclosingVariableOrCapture*/true, C.getLocation(),
12137           /*EllipsisLoc*/C.isPackExpansion()
12138                          ? C.getEllipsisLoc() : SourceLocation(),
12139           CaptureType, /*Expr*/ nullptr);
12140 
12141     } else if (C.capturesThis()) {
12142       LSI->addThisCapture(/*Nested*/ false, C.getLocation(),
12143                               /*Expr*/ nullptr,
12144                               C.getCaptureKind() == LCK_StarThis);
12145     } else {
12146       LSI->addVLATypeCapture(C.getLocation(), I->getType());
12147     }
12148     ++I;
12149   }
12150 }
12151 
12152 Decl *Sema::ActOnStartOfFunctionDef(Scope *FnBodyScope, Decl *D,
12153                                     SkipBodyInfo *SkipBody) {
12154   if (!D)
12155     return D;
12156   FunctionDecl *FD = nullptr;
12157 
12158   if (FunctionTemplateDecl *FunTmpl = dyn_cast<FunctionTemplateDecl>(D))
12159     FD = FunTmpl->getTemplatedDecl();
12160   else
12161     FD = cast<FunctionDecl>(D);
12162 
12163   // Check for defining attributes before the check for redefinition.
12164   if (const auto *Attr = FD->getAttr<AliasAttr>()) {
12165     Diag(Attr->getLocation(), diag::err_alias_is_definition) << FD << 0;
12166     FD->dropAttr<AliasAttr>();
12167     FD->setInvalidDecl();
12168   }
12169   if (const auto *Attr = FD->getAttr<IFuncAttr>()) {
12170     Diag(Attr->getLocation(), diag::err_alias_is_definition) << FD << 1;
12171     FD->dropAttr<IFuncAttr>();
12172     FD->setInvalidDecl();
12173   }
12174 
12175   // See if this is a redefinition. If 'will have body' is already set, then
12176   // these checks were already performed when it was set.
12177   if (!FD->willHaveBody() && !FD->isLateTemplateParsed()) {
12178     CheckForFunctionRedefinition(FD, nullptr, SkipBody);
12179 
12180     // If we're skipping the body, we're done. Don't enter the scope.
12181     if (SkipBody && SkipBody->ShouldSkip)
12182       return D;
12183   }
12184 
12185   // Mark this function as "will have a body eventually".  This lets users to
12186   // call e.g. isInlineDefinitionExternallyVisible while we're still parsing
12187   // this function.
12188   FD->setWillHaveBody();
12189 
12190   // If we are instantiating a generic lambda call operator, push
12191   // a LambdaScopeInfo onto the function stack.  But use the information
12192   // that's already been calculated (ActOnLambdaExpr) to prime the current
12193   // LambdaScopeInfo.
12194   // When the template operator is being specialized, the LambdaScopeInfo,
12195   // has to be properly restored so that tryCaptureVariable doesn't try
12196   // and capture any new variables. In addition when calculating potential
12197   // captures during transformation of nested lambdas, it is necessary to
12198   // have the LSI properly restored.
12199   if (isGenericLambdaCallOperatorSpecialization(FD)) {
12200     assert(inTemplateInstantiation() &&
12201            "There should be an active template instantiation on the stack "
12202            "when instantiating a generic lambda!");
12203     RebuildLambdaScopeInfo(cast<CXXMethodDecl>(D), *this);
12204   } else {
12205     // Enter a new function scope
12206     PushFunctionScope();
12207   }
12208 
12209   // Builtin functions cannot be defined.
12210   if (unsigned BuiltinID = FD->getBuiltinID()) {
12211     if (!Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID) &&
12212         !Context.BuiltinInfo.isPredefinedRuntimeFunction(BuiltinID)) {
12213       Diag(FD->getLocation(), diag::err_builtin_definition) << FD;
12214       FD->setInvalidDecl();
12215     }
12216   }
12217 
12218   // The return type of a function definition must be complete
12219   // (C99 6.9.1p3, C++ [dcl.fct]p6).
12220   QualType ResultType = FD->getReturnType();
12221   if (!ResultType->isDependentType() && !ResultType->isVoidType() &&
12222       !FD->isInvalidDecl() &&
12223       RequireCompleteType(FD->getLocation(), ResultType,
12224                           diag::err_func_def_incomplete_result))
12225     FD->setInvalidDecl();
12226 
12227   if (FnBodyScope)
12228     PushDeclContext(FnBodyScope, FD);
12229 
12230   // Check the validity of our function parameters
12231   CheckParmsForFunctionDef(FD->parameters(),
12232                            /*CheckParameterNames=*/true);
12233 
12234   // Add non-parameter declarations already in the function to the current
12235   // scope.
12236   if (FnBodyScope) {
12237     for (Decl *NPD : FD->decls()) {
12238       auto *NonParmDecl = dyn_cast<NamedDecl>(NPD);
12239       if (!NonParmDecl)
12240         continue;
12241       assert(!isa<ParmVarDecl>(NonParmDecl) &&
12242              "parameters should not be in newly created FD yet");
12243 
12244       // If the decl has a name, make it accessible in the current scope.
12245       if (NonParmDecl->getDeclName())
12246         PushOnScopeChains(NonParmDecl, FnBodyScope, /*AddToContext=*/false);
12247 
12248       // Similarly, dive into enums and fish their constants out, making them
12249       // accessible in this scope.
12250       if (auto *ED = dyn_cast<EnumDecl>(NonParmDecl)) {
12251         for (auto *EI : ED->enumerators())
12252           PushOnScopeChains(EI, FnBodyScope, /*AddToContext=*/false);
12253       }
12254     }
12255   }
12256 
12257   // Introduce our parameters into the function scope
12258   for (auto Param : FD->parameters()) {
12259     Param->setOwningFunction(FD);
12260 
12261     // If this has an identifier, add it to the scope stack.
12262     if (Param->getIdentifier() && FnBodyScope) {
12263       CheckShadow(FnBodyScope, Param);
12264 
12265       PushOnScopeChains(Param, FnBodyScope);
12266     }
12267   }
12268 
12269   // Ensure that the function's exception specification is instantiated.
12270   if (const FunctionProtoType *FPT = FD->getType()->getAs<FunctionProtoType>())
12271     ResolveExceptionSpec(D->getLocation(), FPT);
12272 
12273   // dllimport cannot be applied to non-inline function definitions.
12274   if (FD->hasAttr<DLLImportAttr>() && !FD->isInlined() &&
12275       !FD->isTemplateInstantiation()) {
12276     assert(!FD->hasAttr<DLLExportAttr>());
12277     Diag(FD->getLocation(), diag::err_attribute_dllimport_function_definition);
12278     FD->setInvalidDecl();
12279     return D;
12280   }
12281   // We want to attach documentation to original Decl (which might be
12282   // a function template).
12283   ActOnDocumentableDecl(D);
12284   if (getCurLexicalContext()->isObjCContainer() &&
12285       getCurLexicalContext()->getDeclKind() != Decl::ObjCCategoryImpl &&
12286       getCurLexicalContext()->getDeclKind() != Decl::ObjCImplementation)
12287     Diag(FD->getLocation(), diag::warn_function_def_in_objc_container);
12288 
12289   return D;
12290 }
12291 
12292 /// \brief Given the set of return statements within a function body,
12293 /// compute the variables that are subject to the named return value
12294 /// optimization.
12295 ///
12296 /// Each of the variables that is subject to the named return value
12297 /// optimization will be marked as NRVO variables in the AST, and any
12298 /// return statement that has a marked NRVO variable as its NRVO candidate can
12299 /// use the named return value optimization.
12300 ///
12301 /// This function applies a very simplistic algorithm for NRVO: if every return
12302 /// statement in the scope of a variable has the same NRVO candidate, that
12303 /// candidate is an NRVO variable.
12304 void Sema::computeNRVO(Stmt *Body, FunctionScopeInfo *Scope) {
12305   ReturnStmt **Returns = Scope->Returns.data();
12306 
12307   for (unsigned I = 0, E = Scope->Returns.size(); I != E; ++I) {
12308     if (const VarDecl *NRVOCandidate = Returns[I]->getNRVOCandidate()) {
12309       if (!NRVOCandidate->isNRVOVariable())
12310         Returns[I]->setNRVOCandidate(nullptr);
12311     }
12312   }
12313 }
12314 
12315 bool Sema::canDelayFunctionBody(const Declarator &D) {
12316   // We can't delay parsing the body of a constexpr function template (yet).
12317   if (D.getDeclSpec().isConstexprSpecified())
12318     return false;
12319 
12320   // We can't delay parsing the body of a function template with a deduced
12321   // return type (yet).
12322   if (D.getDeclSpec().hasAutoTypeSpec()) {
12323     // If the placeholder introduces a non-deduced trailing return type,
12324     // we can still delay parsing it.
12325     if (D.getNumTypeObjects()) {
12326       const auto &Outer = D.getTypeObject(D.getNumTypeObjects() - 1);
12327       if (Outer.Kind == DeclaratorChunk::Function &&
12328           Outer.Fun.hasTrailingReturnType()) {
12329         QualType Ty = GetTypeFromParser(Outer.Fun.getTrailingReturnType());
12330         return Ty.isNull() || !Ty->isUndeducedType();
12331       }
12332     }
12333     return false;
12334   }
12335 
12336   return true;
12337 }
12338 
12339 bool Sema::canSkipFunctionBody(Decl *D) {
12340   // We cannot skip the body of a function (or function template) which is
12341   // constexpr, since we may need to evaluate its body in order to parse the
12342   // rest of the file.
12343   // We cannot skip the body of a function with an undeduced return type,
12344   // because any callers of that function need to know the type.
12345   if (const FunctionDecl *FD = D->getAsFunction())
12346     if (FD->isConstexpr() || FD->getReturnType()->isUndeducedType())
12347       return false;
12348   return Consumer.shouldSkipFunctionBody(D);
12349 }
12350 
12351 Decl *Sema::ActOnSkippedFunctionBody(Decl *Decl) {
12352   if (FunctionDecl *FD = dyn_cast_or_null<FunctionDecl>(Decl))
12353     FD->setHasSkippedBody();
12354   else if (ObjCMethodDecl *MD = dyn_cast_or_null<ObjCMethodDecl>(Decl))
12355     MD->setHasSkippedBody();
12356   return Decl;
12357 }
12358 
12359 Decl *Sema::ActOnFinishFunctionBody(Decl *D, Stmt *BodyArg) {
12360   return ActOnFinishFunctionBody(D, BodyArg, false);
12361 }
12362 
12363 Decl *Sema::ActOnFinishFunctionBody(Decl *dcl, Stmt *Body,
12364                                     bool IsInstantiation) {
12365   FunctionDecl *FD = dcl ? dcl->getAsFunction() : nullptr;
12366 
12367   sema::AnalysisBasedWarnings::Policy WP = AnalysisWarnings.getDefaultPolicy();
12368   sema::AnalysisBasedWarnings::Policy *ActivePolicy = nullptr;
12369 
12370   if (getLangOpts().CoroutinesTS && getCurFunction()->isCoroutine())
12371     CheckCompletedCoroutineBody(FD, Body);
12372 
12373   if (FD) {
12374     FD->setBody(Body);
12375     FD->setWillHaveBody(false);
12376 
12377     if (getLangOpts().CPlusPlus14) {
12378       if (!FD->isInvalidDecl() && Body && !FD->isDependentContext() &&
12379           FD->getReturnType()->isUndeducedType()) {
12380         // If the function has a deduced result type but contains no 'return'
12381         // statements, the result type as written must be exactly 'auto', and
12382         // the deduced result type is 'void'.
12383         if (!FD->getReturnType()->getAs<AutoType>()) {
12384           Diag(dcl->getLocation(), diag::err_auto_fn_no_return_but_not_auto)
12385               << FD->getReturnType();
12386           FD->setInvalidDecl();
12387         } else {
12388           // Substitute 'void' for the 'auto' in the type.
12389           TypeLoc ResultType = getReturnTypeLoc(FD);
12390           Context.adjustDeducedFunctionResultType(
12391               FD, SubstAutoType(ResultType.getType(), Context.VoidTy));
12392         }
12393       }
12394     } else if (getLangOpts().CPlusPlus11 && isLambdaCallOperator(FD)) {
12395       // In C++11, we don't use 'auto' deduction rules for lambda call
12396       // operators because we don't support return type deduction.
12397       auto *LSI = getCurLambda();
12398       if (LSI->HasImplicitReturnType) {
12399         deduceClosureReturnType(*LSI);
12400 
12401         // C++11 [expr.prim.lambda]p4:
12402         //   [...] if there are no return statements in the compound-statement
12403         //   [the deduced type is] the type void
12404         QualType RetType =
12405             LSI->ReturnType.isNull() ? Context.VoidTy : LSI->ReturnType;
12406 
12407         // Update the return type to the deduced type.
12408         const FunctionProtoType *Proto =
12409             FD->getType()->getAs<FunctionProtoType>();
12410         FD->setType(Context.getFunctionType(RetType, Proto->getParamTypes(),
12411                                             Proto->getExtProtoInfo()));
12412       }
12413     }
12414 
12415     // If the function implicitly returns zero (like 'main') or is naked,
12416     // don't complain about missing return statements.
12417     if (FD->hasImplicitReturnZero() || FD->hasAttr<NakedAttr>())
12418       WP.disableCheckFallThrough();
12419 
12420     // MSVC permits the use of pure specifier (=0) on function definition,
12421     // defined at class scope, warn about this non-standard construct.
12422     if (getLangOpts().MicrosoftExt && FD->isPure() && FD->isCanonicalDecl())
12423       Diag(FD->getLocation(), diag::ext_pure_function_definition);
12424 
12425     if (!FD->isInvalidDecl()) {
12426       // Don't diagnose unused parameters of defaulted or deleted functions.
12427       if (!FD->isDeleted() && !FD->isDefaulted())
12428         DiagnoseUnusedParameters(FD->parameters());
12429       DiagnoseSizeOfParametersAndReturnValue(FD->parameters(),
12430                                              FD->getReturnType(), FD);
12431 
12432       // If this is a structor, we need a vtable.
12433       if (CXXConstructorDecl *Constructor = dyn_cast<CXXConstructorDecl>(FD))
12434         MarkVTableUsed(FD->getLocation(), Constructor->getParent());
12435       else if (CXXDestructorDecl *Destructor = dyn_cast<CXXDestructorDecl>(FD))
12436         MarkVTableUsed(FD->getLocation(), Destructor->getParent());
12437 
12438       // Try to apply the named return value optimization. We have to check
12439       // if we can do this here because lambdas keep return statements around
12440       // to deduce an implicit return type.
12441       if (getLangOpts().CPlusPlus && FD->getReturnType()->isRecordType() &&
12442           !FD->isDependentContext())
12443         computeNRVO(Body, getCurFunction());
12444     }
12445 
12446     // GNU warning -Wmissing-prototypes:
12447     //   Warn if a global function is defined without a previous
12448     //   prototype declaration. This warning is issued even if the
12449     //   definition itself provides a prototype. The aim is to detect
12450     //   global functions that fail to be declared in header files.
12451     const FunctionDecl *PossibleZeroParamPrototype = nullptr;
12452     if (ShouldWarnAboutMissingPrototype(FD, PossibleZeroParamPrototype)) {
12453       Diag(FD->getLocation(), diag::warn_missing_prototype) << FD;
12454 
12455       if (PossibleZeroParamPrototype) {
12456         // We found a declaration that is not a prototype,
12457         // but that could be a zero-parameter prototype
12458         if (TypeSourceInfo *TI =
12459                 PossibleZeroParamPrototype->getTypeSourceInfo()) {
12460           TypeLoc TL = TI->getTypeLoc();
12461           if (FunctionNoProtoTypeLoc FTL = TL.getAs<FunctionNoProtoTypeLoc>())
12462             Diag(PossibleZeroParamPrototype->getLocation(),
12463                  diag::note_declaration_not_a_prototype)
12464                 << PossibleZeroParamPrototype
12465                 << FixItHint::CreateInsertion(FTL.getRParenLoc(), "void");
12466         }
12467       }
12468 
12469       // GNU warning -Wstrict-prototypes
12470       //   Warn if K&R function is defined without a previous declaration.
12471       //   This warning is issued only if the definition itself does not provide
12472       //   a prototype. Only K&R definitions do not provide a prototype.
12473       //   An empty list in a function declarator that is part of a definition
12474       //   of that function specifies that the function has no parameters
12475       //   (C99 6.7.5.3p14)
12476       if (!FD->hasWrittenPrototype() && FD->getNumParams() > 0 &&
12477           !LangOpts.CPlusPlus) {
12478         TypeSourceInfo *TI = FD->getTypeSourceInfo();
12479         TypeLoc TL = TI->getTypeLoc();
12480         FunctionTypeLoc FTL = TL.getAsAdjusted<FunctionTypeLoc>();
12481         Diag(FTL.getLParenLoc(), diag::warn_strict_prototypes) << 2;
12482       }
12483     }
12484 
12485     if (auto *MD = dyn_cast<CXXMethodDecl>(FD)) {
12486       const CXXMethodDecl *KeyFunction;
12487       if (MD->isOutOfLine() && (MD = MD->getCanonicalDecl()) &&
12488           MD->isVirtual() &&
12489           (KeyFunction = Context.getCurrentKeyFunction(MD->getParent())) &&
12490           MD == KeyFunction->getCanonicalDecl()) {
12491         // Update the key-function state if necessary for this ABI.
12492         if (FD->isInlined() &&
12493             !Context.getTargetInfo().getCXXABI().canKeyFunctionBeInline()) {
12494           Context.setNonKeyFunction(MD);
12495 
12496           // If the newly-chosen key function is already defined, then we
12497           // need to mark the vtable as used retroactively.
12498           KeyFunction = Context.getCurrentKeyFunction(MD->getParent());
12499           const FunctionDecl *Definition;
12500           if (KeyFunction && KeyFunction->isDefined(Definition))
12501             MarkVTableUsed(Definition->getLocation(), MD->getParent(), true);
12502         } else {
12503           // We just defined they key function; mark the vtable as used.
12504           MarkVTableUsed(FD->getLocation(), MD->getParent(), true);
12505         }
12506       }
12507     }
12508 
12509     assert((FD == getCurFunctionDecl() || getCurLambda()->CallOperator == FD) &&
12510            "Function parsing confused");
12511   } else if (ObjCMethodDecl *MD = dyn_cast_or_null<ObjCMethodDecl>(dcl)) {
12512     assert(MD == getCurMethodDecl() && "Method parsing confused");
12513     MD->setBody(Body);
12514     if (!MD->isInvalidDecl()) {
12515       DiagnoseUnusedParameters(MD->parameters());
12516       DiagnoseSizeOfParametersAndReturnValue(MD->parameters(),
12517                                              MD->getReturnType(), MD);
12518 
12519       if (Body)
12520         computeNRVO(Body, getCurFunction());
12521     }
12522     if (getCurFunction()->ObjCShouldCallSuper) {
12523       Diag(MD->getLocEnd(), diag::warn_objc_missing_super_call)
12524         << MD->getSelector().getAsString();
12525       getCurFunction()->ObjCShouldCallSuper = false;
12526     }
12527     if (getCurFunction()->ObjCWarnForNoDesignatedInitChain) {
12528       const ObjCMethodDecl *InitMethod = nullptr;
12529       bool isDesignated =
12530           MD->isDesignatedInitializerForTheInterface(&InitMethod);
12531       assert(isDesignated && InitMethod);
12532       (void)isDesignated;
12533 
12534       auto superIsNSObject = [&](const ObjCMethodDecl *MD) {
12535         auto IFace = MD->getClassInterface();
12536         if (!IFace)
12537           return false;
12538         auto SuperD = IFace->getSuperClass();
12539         if (!SuperD)
12540           return false;
12541         return SuperD->getIdentifier() ==
12542             NSAPIObj->getNSClassId(NSAPI::ClassId_NSObject);
12543       };
12544       // Don't issue this warning for unavailable inits or direct subclasses
12545       // of NSObject.
12546       if (!MD->isUnavailable() && !superIsNSObject(MD)) {
12547         Diag(MD->getLocation(),
12548              diag::warn_objc_designated_init_missing_super_call);
12549         Diag(InitMethod->getLocation(),
12550              diag::note_objc_designated_init_marked_here);
12551       }
12552       getCurFunction()->ObjCWarnForNoDesignatedInitChain = false;
12553     }
12554     if (getCurFunction()->ObjCWarnForNoInitDelegation) {
12555       // Don't issue this warning for unavaialable inits.
12556       if (!MD->isUnavailable())
12557         Diag(MD->getLocation(),
12558              diag::warn_objc_secondary_init_missing_init_call);
12559       getCurFunction()->ObjCWarnForNoInitDelegation = false;
12560     }
12561   } else {
12562     return nullptr;
12563   }
12564 
12565   if (Body && getCurFunction()->HasPotentialAvailabilityViolations)
12566     DiagnoseUnguardedAvailabilityViolations(dcl);
12567 
12568   assert(!getCurFunction()->ObjCShouldCallSuper &&
12569          "This should only be set for ObjC methods, which should have been "
12570          "handled in the block above.");
12571 
12572   // Verify and clean out per-function state.
12573   if (Body && (!FD || !FD->isDefaulted())) {
12574     // C++ constructors that have function-try-blocks can't have return
12575     // statements in the handlers of that block. (C++ [except.handle]p14)
12576     // Verify this.
12577     if (FD && isa<CXXConstructorDecl>(FD) && isa<CXXTryStmt>(Body))
12578       DiagnoseReturnInConstructorExceptionHandler(cast<CXXTryStmt>(Body));
12579 
12580     // Verify that gotos and switch cases don't jump into scopes illegally.
12581     if (getCurFunction()->NeedsScopeChecking() &&
12582         !PP.isCodeCompletionEnabled())
12583       DiagnoseInvalidJumps(Body);
12584 
12585     if (CXXDestructorDecl *Destructor = dyn_cast<CXXDestructorDecl>(dcl)) {
12586       if (!Destructor->getParent()->isDependentType())
12587         CheckDestructor(Destructor);
12588 
12589       MarkBaseAndMemberDestructorsReferenced(Destructor->getLocation(),
12590                                              Destructor->getParent());
12591     }
12592 
12593     // If any errors have occurred, clear out any temporaries that may have
12594     // been leftover. This ensures that these temporaries won't be picked up for
12595     // deletion in some later function.
12596     if (getDiagnostics().hasErrorOccurred() ||
12597         getDiagnostics().getSuppressAllDiagnostics()) {
12598       DiscardCleanupsInEvaluationContext();
12599     }
12600     if (!getDiagnostics().hasUncompilableErrorOccurred() &&
12601         !isa<FunctionTemplateDecl>(dcl)) {
12602       // Since the body is valid, issue any analysis-based warnings that are
12603       // enabled.
12604       ActivePolicy = &WP;
12605     }
12606 
12607     if (!IsInstantiation && FD && FD->isConstexpr() && !FD->isInvalidDecl() &&
12608         (!CheckConstexprFunctionDecl(FD) ||
12609          !CheckConstexprFunctionBody(FD, Body)))
12610       FD->setInvalidDecl();
12611 
12612     if (FD && FD->hasAttr<NakedAttr>()) {
12613       for (const Stmt *S : Body->children()) {
12614         // Allow local register variables without initializer as they don't
12615         // require prologue.
12616         bool RegisterVariables = false;
12617         if (auto *DS = dyn_cast<DeclStmt>(S)) {
12618           for (const auto *Decl : DS->decls()) {
12619             if (const auto *Var = dyn_cast<VarDecl>(Decl)) {
12620               RegisterVariables =
12621                   Var->hasAttr<AsmLabelAttr>() && !Var->hasInit();
12622               if (!RegisterVariables)
12623                 break;
12624             }
12625           }
12626         }
12627         if (RegisterVariables)
12628           continue;
12629         if (!isa<AsmStmt>(S) && !isa<NullStmt>(S)) {
12630           Diag(S->getLocStart(), diag::err_non_asm_stmt_in_naked_function);
12631           Diag(FD->getAttr<NakedAttr>()->getLocation(), diag::note_attribute);
12632           FD->setInvalidDecl();
12633           break;
12634         }
12635       }
12636     }
12637 
12638     assert(ExprCleanupObjects.size() ==
12639                ExprEvalContexts.back().NumCleanupObjects &&
12640            "Leftover temporaries in function");
12641     assert(!Cleanup.exprNeedsCleanups() && "Unaccounted cleanups in function");
12642     assert(MaybeODRUseExprs.empty() &&
12643            "Leftover expressions for odr-use checking");
12644   }
12645 
12646   if (!IsInstantiation)
12647     PopDeclContext();
12648 
12649   PopFunctionScopeInfo(ActivePolicy, dcl);
12650   // If any errors have occurred, clear out any temporaries that may have
12651   // been leftover. This ensures that these temporaries won't be picked up for
12652   // deletion in some later function.
12653   if (getDiagnostics().hasErrorOccurred()) {
12654     DiscardCleanupsInEvaluationContext();
12655   }
12656 
12657   return dcl;
12658 }
12659 
12660 /// When we finish delayed parsing of an attribute, we must attach it to the
12661 /// relevant Decl.
12662 void Sema::ActOnFinishDelayedAttribute(Scope *S, Decl *D,
12663                                        ParsedAttributes &Attrs) {
12664   // Always attach attributes to the underlying decl.
12665   if (TemplateDecl *TD = dyn_cast<TemplateDecl>(D))
12666     D = TD->getTemplatedDecl();
12667   ProcessDeclAttributeList(S, D, Attrs.getList());
12668 
12669   if (CXXMethodDecl *Method = dyn_cast_or_null<CXXMethodDecl>(D))
12670     if (Method->isStatic())
12671       checkThisInStaticMemberFunctionAttributes(Method);
12672 }
12673 
12674 /// ImplicitlyDefineFunction - An undeclared identifier was used in a function
12675 /// call, forming a call to an implicitly defined function (per C99 6.5.1p2).
12676 NamedDecl *Sema::ImplicitlyDefineFunction(SourceLocation Loc,
12677                                           IdentifierInfo &II, Scope *S) {
12678   Scope *BlockScope = S;
12679   while (!BlockScope->isCompoundStmtScope() && BlockScope->getParent())
12680     BlockScope = BlockScope->getParent();
12681 
12682   // Before we produce a declaration for an implicitly defined
12683   // function, see whether there was a locally-scoped declaration of
12684   // this name as a function or variable. If so, use that
12685   // (non-visible) declaration, and complain about it.
12686   NamedDecl *ExternCPrev = findLocallyScopedExternCDecl(&II);
12687   if (ExternCPrev) {
12688     // We still need to inject the function into the enclosing block scope so
12689     // that later (non-call) uses can see it.
12690     PushOnScopeChains(ExternCPrev, BlockScope, /*AddToContext*/false);
12691 
12692     // C89 footnote 38:
12693     //   If in fact it is not defined as having type "function returning int",
12694     //   the behavior is undefined.
12695     if (!isa<FunctionDecl>(ExternCPrev) ||
12696         !Context.typesAreCompatible(
12697             cast<FunctionDecl>(ExternCPrev)->getType(),
12698             Context.getFunctionNoProtoType(Context.IntTy))) {
12699       Diag(Loc, diag::ext_use_out_of_scope_declaration)
12700           << ExternCPrev << !getLangOpts().C99;
12701       Diag(ExternCPrev->getLocation(), diag::note_previous_declaration);
12702       return ExternCPrev;
12703     }
12704   }
12705 
12706   // Extension in C99.  Legal in C90, but warn about it.
12707   // OpenCL v2.0 s6.9.u - Implicit function declaration is not supported.
12708   unsigned diag_id;
12709   if (II.getName().startswith("__builtin_"))
12710     diag_id = diag::warn_builtin_unknown;
12711   else if (getLangOpts().C99 || getLangOpts().OpenCL)
12712     diag_id = diag::ext_implicit_function_decl;
12713   else
12714     diag_id = diag::warn_implicit_function_decl;
12715   Diag(Loc, diag_id) << &II << getLangOpts().OpenCL;
12716 
12717   // If we found a prior declaration of this function, don't bother building
12718   // another one. We've already pushed that one into scope, so there's nothing
12719   // more to do.
12720   if (ExternCPrev)
12721     return ExternCPrev;
12722 
12723   // Because typo correction is expensive, only do it if the implicit
12724   // function declaration is going to be treated as an error.
12725   if (Diags.getDiagnosticLevel(diag_id, Loc) >= DiagnosticsEngine::Error) {
12726     TypoCorrection Corrected;
12727     if (S &&
12728         (Corrected = CorrectTypo(
12729              DeclarationNameInfo(&II, Loc), LookupOrdinaryName, S, nullptr,
12730              llvm::make_unique<DeclFilterCCC<FunctionDecl>>(), CTK_NonError)))
12731       diagnoseTypo(Corrected, PDiag(diag::note_function_suggestion),
12732                    /*ErrorRecovery*/false);
12733   }
12734 
12735   // Set a Declarator for the implicit definition: int foo();
12736   const char *Dummy;
12737   AttributeFactory attrFactory;
12738   DeclSpec DS(attrFactory);
12739   unsigned DiagID;
12740   bool Error = DS.SetTypeSpecType(DeclSpec::TST_int, Loc, Dummy, DiagID,
12741                                   Context.getPrintingPolicy());
12742   (void)Error; // Silence warning.
12743   assert(!Error && "Error setting up implicit decl!");
12744   SourceLocation NoLoc;
12745   Declarator D(DS, Declarator::BlockContext);
12746   D.AddTypeInfo(DeclaratorChunk::getFunction(/*HasProto=*/false,
12747                                              /*IsAmbiguous=*/false,
12748                                              /*LParenLoc=*/NoLoc,
12749                                              /*Params=*/nullptr,
12750                                              /*NumParams=*/0,
12751                                              /*EllipsisLoc=*/NoLoc,
12752                                              /*RParenLoc=*/NoLoc,
12753                                              /*TypeQuals=*/0,
12754                                              /*RefQualifierIsLvalueRef=*/true,
12755                                              /*RefQualifierLoc=*/NoLoc,
12756                                              /*ConstQualifierLoc=*/NoLoc,
12757                                              /*VolatileQualifierLoc=*/NoLoc,
12758                                              /*RestrictQualifierLoc=*/NoLoc,
12759                                              /*MutableLoc=*/NoLoc,
12760                                              EST_None,
12761                                              /*ESpecRange=*/SourceRange(),
12762                                              /*Exceptions=*/nullptr,
12763                                              /*ExceptionRanges=*/nullptr,
12764                                              /*NumExceptions=*/0,
12765                                              /*NoexceptExpr=*/nullptr,
12766                                              /*ExceptionSpecTokens=*/nullptr,
12767                                              /*DeclsInPrototype=*/None,
12768                                              Loc, Loc, D),
12769                 DS.getAttributes(),
12770                 SourceLocation());
12771   D.SetIdentifier(&II, Loc);
12772 
12773   // Insert this function into the enclosing block scope.
12774   FunctionDecl *FD = cast<FunctionDecl>(ActOnDeclarator(BlockScope, D));
12775   FD->setImplicit();
12776 
12777   AddKnownFunctionAttributes(FD);
12778 
12779   return FD;
12780 }
12781 
12782 /// \brief Adds any function attributes that we know a priori based on
12783 /// the declaration of this function.
12784 ///
12785 /// These attributes can apply both to implicitly-declared builtins
12786 /// (like __builtin___printf_chk) or to library-declared functions
12787 /// like NSLog or printf.
12788 ///
12789 /// We need to check for duplicate attributes both here and where user-written
12790 /// attributes are applied to declarations.
12791 void Sema::AddKnownFunctionAttributes(FunctionDecl *FD) {
12792   if (FD->isInvalidDecl())
12793     return;
12794 
12795   // If this is a built-in function, map its builtin attributes to
12796   // actual attributes.
12797   if (unsigned BuiltinID = FD->getBuiltinID()) {
12798     // Handle printf-formatting attributes.
12799     unsigned FormatIdx;
12800     bool HasVAListArg;
12801     if (Context.BuiltinInfo.isPrintfLike(BuiltinID, FormatIdx, HasVAListArg)) {
12802       if (!FD->hasAttr<FormatAttr>()) {
12803         const char *fmt = "printf";
12804         unsigned int NumParams = FD->getNumParams();
12805         if (FormatIdx < NumParams && // NumParams may be 0 (e.g. vfprintf)
12806             FD->getParamDecl(FormatIdx)->getType()->isObjCObjectPointerType())
12807           fmt = "NSString";
12808         FD->addAttr(FormatAttr::CreateImplicit(Context,
12809                                                &Context.Idents.get(fmt),
12810                                                FormatIdx+1,
12811                                                HasVAListArg ? 0 : FormatIdx+2,
12812                                                FD->getLocation()));
12813       }
12814     }
12815     if (Context.BuiltinInfo.isScanfLike(BuiltinID, FormatIdx,
12816                                              HasVAListArg)) {
12817      if (!FD->hasAttr<FormatAttr>())
12818        FD->addAttr(FormatAttr::CreateImplicit(Context,
12819                                               &Context.Idents.get("scanf"),
12820                                               FormatIdx+1,
12821                                               HasVAListArg ? 0 : FormatIdx+2,
12822                                               FD->getLocation()));
12823     }
12824 
12825     // Mark const if we don't care about errno and that is the only
12826     // thing preventing the function from being const. This allows
12827     // IRgen to use LLVM intrinsics for such functions.
12828     if (!getLangOpts().MathErrno &&
12829         Context.BuiltinInfo.isConstWithoutErrno(BuiltinID)) {
12830       if (!FD->hasAttr<ConstAttr>())
12831         FD->addAttr(ConstAttr::CreateImplicit(Context, FD->getLocation()));
12832     }
12833 
12834     if (Context.BuiltinInfo.isReturnsTwice(BuiltinID) &&
12835         !FD->hasAttr<ReturnsTwiceAttr>())
12836       FD->addAttr(ReturnsTwiceAttr::CreateImplicit(Context,
12837                                          FD->getLocation()));
12838     if (Context.BuiltinInfo.isNoThrow(BuiltinID) && !FD->hasAttr<NoThrowAttr>())
12839       FD->addAttr(NoThrowAttr::CreateImplicit(Context, FD->getLocation()));
12840     if (Context.BuiltinInfo.isPure(BuiltinID) && !FD->hasAttr<PureAttr>())
12841       FD->addAttr(PureAttr::CreateImplicit(Context, FD->getLocation()));
12842     if (Context.BuiltinInfo.isConst(BuiltinID) && !FD->hasAttr<ConstAttr>())
12843       FD->addAttr(ConstAttr::CreateImplicit(Context, FD->getLocation()));
12844     if (getLangOpts().CUDA && Context.BuiltinInfo.isTSBuiltin(BuiltinID) &&
12845         !FD->hasAttr<CUDADeviceAttr>() && !FD->hasAttr<CUDAHostAttr>()) {
12846       // Add the appropriate attribute, depending on the CUDA compilation mode
12847       // and which target the builtin belongs to. For example, during host
12848       // compilation, aux builtins are __device__, while the rest are __host__.
12849       if (getLangOpts().CUDAIsDevice !=
12850           Context.BuiltinInfo.isAuxBuiltinID(BuiltinID))
12851         FD->addAttr(CUDADeviceAttr::CreateImplicit(Context, FD->getLocation()));
12852       else
12853         FD->addAttr(CUDAHostAttr::CreateImplicit(Context, FD->getLocation()));
12854     }
12855   }
12856 
12857   // If C++ exceptions are enabled but we are told extern "C" functions cannot
12858   // throw, add an implicit nothrow attribute to any extern "C" function we come
12859   // across.
12860   if (getLangOpts().CXXExceptions && getLangOpts().ExternCNoUnwind &&
12861       FD->isExternC() && !FD->hasAttr<NoThrowAttr>()) {
12862     const auto *FPT = FD->getType()->getAs<FunctionProtoType>();
12863     if (!FPT || FPT->getExceptionSpecType() == EST_None)
12864       FD->addAttr(NoThrowAttr::CreateImplicit(Context, FD->getLocation()));
12865   }
12866 
12867   IdentifierInfo *Name = FD->getIdentifier();
12868   if (!Name)
12869     return;
12870   if ((!getLangOpts().CPlusPlus &&
12871        FD->getDeclContext()->isTranslationUnit()) ||
12872       (isa<LinkageSpecDecl>(FD->getDeclContext()) &&
12873        cast<LinkageSpecDecl>(FD->getDeclContext())->getLanguage() ==
12874        LinkageSpecDecl::lang_c)) {
12875     // Okay: this could be a libc/libm/Objective-C function we know
12876     // about.
12877   } else
12878     return;
12879 
12880   if (Name->isStr("asprintf") || Name->isStr("vasprintf")) {
12881     // FIXME: asprintf and vasprintf aren't C99 functions. Should they be
12882     // target-specific builtins, perhaps?
12883     if (!FD->hasAttr<FormatAttr>())
12884       FD->addAttr(FormatAttr::CreateImplicit(Context,
12885                                              &Context.Idents.get("printf"), 2,
12886                                              Name->isStr("vasprintf") ? 0 : 3,
12887                                              FD->getLocation()));
12888   }
12889 
12890   if (Name->isStr("__CFStringMakeConstantString")) {
12891     // We already have a __builtin___CFStringMakeConstantString,
12892     // but builds that use -fno-constant-cfstrings don't go through that.
12893     if (!FD->hasAttr<FormatArgAttr>())
12894       FD->addAttr(FormatArgAttr::CreateImplicit(Context, 1,
12895                                                 FD->getLocation()));
12896   }
12897 }
12898 
12899 TypedefDecl *Sema::ParseTypedefDecl(Scope *S, Declarator &D, QualType T,
12900                                     TypeSourceInfo *TInfo) {
12901   assert(D.getIdentifier() && "Wrong callback for declspec without declarator");
12902   assert(!T.isNull() && "GetTypeForDeclarator() returned null type");
12903 
12904   if (!TInfo) {
12905     assert(D.isInvalidType() && "no declarator info for valid type");
12906     TInfo = Context.getTrivialTypeSourceInfo(T);
12907   }
12908 
12909   // Scope manipulation handled by caller.
12910   TypedefDecl *NewTD = TypedefDecl::Create(Context, CurContext,
12911                                            D.getLocStart(),
12912                                            D.getIdentifierLoc(),
12913                                            D.getIdentifier(),
12914                                            TInfo);
12915 
12916   // Bail out immediately if we have an invalid declaration.
12917   if (D.isInvalidType()) {
12918     NewTD->setInvalidDecl();
12919     return NewTD;
12920   }
12921 
12922   if (D.getDeclSpec().isModulePrivateSpecified()) {
12923     if (CurContext->isFunctionOrMethod())
12924       Diag(NewTD->getLocation(), diag::err_module_private_local)
12925         << 2 << NewTD->getDeclName()
12926         << SourceRange(D.getDeclSpec().getModulePrivateSpecLoc())
12927         << FixItHint::CreateRemoval(D.getDeclSpec().getModulePrivateSpecLoc());
12928     else
12929       NewTD->setModulePrivate();
12930   }
12931 
12932   // C++ [dcl.typedef]p8:
12933   //   If the typedef declaration defines an unnamed class (or
12934   //   enum), the first typedef-name declared by the declaration
12935   //   to be that class type (or enum type) is used to denote the
12936   //   class type (or enum type) for linkage purposes only.
12937   // We need to check whether the type was declared in the declaration.
12938   switch (D.getDeclSpec().getTypeSpecType()) {
12939   case TST_enum:
12940   case TST_struct:
12941   case TST_interface:
12942   case TST_union:
12943   case TST_class: {
12944     TagDecl *tagFromDeclSpec = cast<TagDecl>(D.getDeclSpec().getRepAsDecl());
12945     setTagNameForLinkagePurposes(tagFromDeclSpec, NewTD);
12946     break;
12947   }
12948 
12949   default:
12950     break;
12951   }
12952 
12953   return NewTD;
12954 }
12955 
12956 /// \brief Check that this is a valid underlying type for an enum declaration.
12957 bool Sema::CheckEnumUnderlyingType(TypeSourceInfo *TI) {
12958   SourceLocation UnderlyingLoc = TI->getTypeLoc().getBeginLoc();
12959   QualType T = TI->getType();
12960 
12961   if (T->isDependentType())
12962     return false;
12963 
12964   if (const BuiltinType *BT = T->getAs<BuiltinType>())
12965     if (BT->isInteger())
12966       return false;
12967 
12968   Diag(UnderlyingLoc, diag::err_enum_invalid_underlying) << T;
12969   return true;
12970 }
12971 
12972 /// Check whether this is a valid redeclaration of a previous enumeration.
12973 /// \return true if the redeclaration was invalid.
12974 bool Sema::CheckEnumRedeclaration(
12975     SourceLocation EnumLoc, bool IsScoped, QualType EnumUnderlyingTy,
12976     bool EnumUnderlyingIsImplicit, const EnumDecl *Prev) {
12977   bool IsFixed = !EnumUnderlyingTy.isNull();
12978 
12979   if (IsScoped != Prev->isScoped()) {
12980     Diag(EnumLoc, diag::err_enum_redeclare_scoped_mismatch)
12981       << Prev->isScoped();
12982     Diag(Prev->getLocation(), diag::note_previous_declaration);
12983     return true;
12984   }
12985 
12986   if (IsFixed && Prev->isFixed()) {
12987     if (!EnumUnderlyingTy->isDependentType() &&
12988         !Prev->getIntegerType()->isDependentType() &&
12989         !Context.hasSameUnqualifiedType(EnumUnderlyingTy,
12990                                         Prev->getIntegerType())) {
12991       // TODO: Highlight the underlying type of the redeclaration.
12992       Diag(EnumLoc, diag::err_enum_redeclare_type_mismatch)
12993         << EnumUnderlyingTy << Prev->getIntegerType();
12994       Diag(Prev->getLocation(), diag::note_previous_declaration)
12995           << Prev->getIntegerTypeRange();
12996       return true;
12997     }
12998   } else if (IsFixed && !Prev->isFixed() && EnumUnderlyingIsImplicit) {
12999     ;
13000   } else if (!IsFixed && Prev->isFixed() && !Prev->getIntegerTypeSourceInfo()) {
13001     ;
13002   } else if (IsFixed != Prev->isFixed()) {
13003     Diag(EnumLoc, diag::err_enum_redeclare_fixed_mismatch)
13004       << Prev->isFixed();
13005     Diag(Prev->getLocation(), diag::note_previous_declaration);
13006     return true;
13007   }
13008 
13009   return false;
13010 }
13011 
13012 /// \brief Get diagnostic %select index for tag kind for
13013 /// redeclaration diagnostic message.
13014 /// WARNING: Indexes apply to particular diagnostics only!
13015 ///
13016 /// \returns diagnostic %select index.
13017 static unsigned getRedeclDiagFromTagKind(TagTypeKind Tag) {
13018   switch (Tag) {
13019   case TTK_Struct: return 0;
13020   case TTK_Interface: return 1;
13021   case TTK_Class:  return 2;
13022   default: llvm_unreachable("Invalid tag kind for redecl diagnostic!");
13023   }
13024 }
13025 
13026 /// \brief Determine if tag kind is a class-key compatible with
13027 /// class for redeclaration (class, struct, or __interface).
13028 ///
13029 /// \returns true iff the tag kind is compatible.
13030 static bool isClassCompatTagKind(TagTypeKind Tag)
13031 {
13032   return Tag == TTK_Struct || Tag == TTK_Class || Tag == TTK_Interface;
13033 }
13034 
13035 Sema::NonTagKind Sema::getNonTagTypeDeclKind(const Decl *PrevDecl,
13036                                              TagTypeKind TTK) {
13037   if (isa<TypedefDecl>(PrevDecl))
13038     return NTK_Typedef;
13039   else if (isa<TypeAliasDecl>(PrevDecl))
13040     return NTK_TypeAlias;
13041   else if (isa<ClassTemplateDecl>(PrevDecl))
13042     return NTK_Template;
13043   else if (isa<TypeAliasTemplateDecl>(PrevDecl))
13044     return NTK_TypeAliasTemplate;
13045   else if (isa<TemplateTemplateParmDecl>(PrevDecl))
13046     return NTK_TemplateTemplateArgument;
13047   switch (TTK) {
13048   case TTK_Struct:
13049   case TTK_Interface:
13050   case TTK_Class:
13051     return getLangOpts().CPlusPlus ? NTK_NonClass : NTK_NonStruct;
13052   case TTK_Union:
13053     return NTK_NonUnion;
13054   case TTK_Enum:
13055     return NTK_NonEnum;
13056   }
13057   llvm_unreachable("invalid TTK");
13058 }
13059 
13060 /// \brief Determine whether a tag with a given kind is acceptable
13061 /// as a redeclaration of the given tag declaration.
13062 ///
13063 /// \returns true if the new tag kind is acceptable, false otherwise.
13064 bool Sema::isAcceptableTagRedeclaration(const TagDecl *Previous,
13065                                         TagTypeKind NewTag, bool isDefinition,
13066                                         SourceLocation NewTagLoc,
13067                                         const IdentifierInfo *Name) {
13068   // C++ [dcl.type.elab]p3:
13069   //   The class-key or enum keyword present in the
13070   //   elaborated-type-specifier shall agree in kind with the
13071   //   declaration to which the name in the elaborated-type-specifier
13072   //   refers. This rule also applies to the form of
13073   //   elaborated-type-specifier that declares a class-name or
13074   //   friend class since it can be construed as referring to the
13075   //   definition of the class. Thus, in any
13076   //   elaborated-type-specifier, the enum keyword shall be used to
13077   //   refer to an enumeration (7.2), the union class-key shall be
13078   //   used to refer to a union (clause 9), and either the class or
13079   //   struct class-key shall be used to refer to a class (clause 9)
13080   //   declared using the class or struct class-key.
13081   TagTypeKind OldTag = Previous->getTagKind();
13082   if (!isDefinition || !isClassCompatTagKind(NewTag))
13083     if (OldTag == NewTag)
13084       return true;
13085 
13086   if (isClassCompatTagKind(OldTag) && isClassCompatTagKind(NewTag)) {
13087     // Warn about the struct/class tag mismatch.
13088     bool isTemplate = false;
13089     if (const CXXRecordDecl *Record = dyn_cast<CXXRecordDecl>(Previous))
13090       isTemplate = Record->getDescribedClassTemplate();
13091 
13092     if (inTemplateInstantiation()) {
13093       // In a template instantiation, do not offer fix-its for tag mismatches
13094       // since they usually mess up the template instead of fixing the problem.
13095       Diag(NewTagLoc, diag::warn_struct_class_tag_mismatch)
13096         << getRedeclDiagFromTagKind(NewTag) << isTemplate << Name
13097         << getRedeclDiagFromTagKind(OldTag);
13098       return true;
13099     }
13100 
13101     if (isDefinition) {
13102       // On definitions, check previous tags and issue a fix-it for each
13103       // one that doesn't match the current tag.
13104       if (Previous->getDefinition()) {
13105         // Don't suggest fix-its for redefinitions.
13106         return true;
13107       }
13108 
13109       bool previousMismatch = false;
13110       for (auto I : Previous->redecls()) {
13111         if (I->getTagKind() != NewTag) {
13112           if (!previousMismatch) {
13113             previousMismatch = true;
13114             Diag(NewTagLoc, diag::warn_struct_class_previous_tag_mismatch)
13115               << getRedeclDiagFromTagKind(NewTag) << isTemplate << Name
13116               << getRedeclDiagFromTagKind(I->getTagKind());
13117           }
13118           Diag(I->getInnerLocStart(), diag::note_struct_class_suggestion)
13119             << getRedeclDiagFromTagKind(NewTag)
13120             << FixItHint::CreateReplacement(I->getInnerLocStart(),
13121                  TypeWithKeyword::getTagTypeKindName(NewTag));
13122         }
13123       }
13124       return true;
13125     }
13126 
13127     // Check for a previous definition.  If current tag and definition
13128     // are same type, do nothing.  If no definition, but disagree with
13129     // with previous tag type, give a warning, but no fix-it.
13130     const TagDecl *Redecl = Previous->getDefinition() ?
13131                             Previous->getDefinition() : Previous;
13132     if (Redecl->getTagKind() == NewTag) {
13133       return true;
13134     }
13135 
13136     Diag(NewTagLoc, diag::warn_struct_class_tag_mismatch)
13137       << getRedeclDiagFromTagKind(NewTag) << isTemplate << Name
13138       << getRedeclDiagFromTagKind(OldTag);
13139     Diag(Redecl->getLocation(), diag::note_previous_use);
13140 
13141     // If there is a previous definition, suggest a fix-it.
13142     if (Previous->getDefinition()) {
13143         Diag(NewTagLoc, diag::note_struct_class_suggestion)
13144           << getRedeclDiagFromTagKind(Redecl->getTagKind())
13145           << FixItHint::CreateReplacement(SourceRange(NewTagLoc),
13146                TypeWithKeyword::getTagTypeKindName(Redecl->getTagKind()));
13147     }
13148 
13149     return true;
13150   }
13151   return false;
13152 }
13153 
13154 /// Add a minimal nested name specifier fixit hint to allow lookup of a tag name
13155 /// from an outer enclosing namespace or file scope inside a friend declaration.
13156 /// This should provide the commented out code in the following snippet:
13157 ///   namespace N {
13158 ///     struct X;
13159 ///     namespace M {
13160 ///       struct Y { friend struct /*N::*/ X; };
13161 ///     }
13162 ///   }
13163 static FixItHint createFriendTagNNSFixIt(Sema &SemaRef, NamedDecl *ND, Scope *S,
13164                                          SourceLocation NameLoc) {
13165   // While the decl is in a namespace, do repeated lookup of that name and see
13166   // if we get the same namespace back.  If we do not, continue until
13167   // translation unit scope, at which point we have a fully qualified NNS.
13168   SmallVector<IdentifierInfo *, 4> Namespaces;
13169   DeclContext *DC = ND->getDeclContext()->getRedeclContext();
13170   for (; !DC->isTranslationUnit(); DC = DC->getParent()) {
13171     // This tag should be declared in a namespace, which can only be enclosed by
13172     // other namespaces.  Bail if there's an anonymous namespace in the chain.
13173     NamespaceDecl *Namespace = dyn_cast<NamespaceDecl>(DC);
13174     if (!Namespace || Namespace->isAnonymousNamespace())
13175       return FixItHint();
13176     IdentifierInfo *II = Namespace->getIdentifier();
13177     Namespaces.push_back(II);
13178     NamedDecl *Lookup = SemaRef.LookupSingleName(
13179         S, II, NameLoc, Sema::LookupNestedNameSpecifierName);
13180     if (Lookup == Namespace)
13181       break;
13182   }
13183 
13184   // Once we have all the namespaces, reverse them to go outermost first, and
13185   // build an NNS.
13186   SmallString<64> Insertion;
13187   llvm::raw_svector_ostream OS(Insertion);
13188   if (DC->isTranslationUnit())
13189     OS << "::";
13190   std::reverse(Namespaces.begin(), Namespaces.end());
13191   for (auto *II : Namespaces)
13192     OS << II->getName() << "::";
13193   return FixItHint::CreateInsertion(NameLoc, Insertion);
13194 }
13195 
13196 /// \brief Determine whether a tag originally declared in context \p OldDC can
13197 /// be redeclared with an unqualfied name in \p NewDC (assuming name lookup
13198 /// found a declaration in \p OldDC as a previous decl, perhaps through a
13199 /// using-declaration).
13200 static bool isAcceptableTagRedeclContext(Sema &S, DeclContext *OldDC,
13201                                          DeclContext *NewDC) {
13202   OldDC = OldDC->getRedeclContext();
13203   NewDC = NewDC->getRedeclContext();
13204 
13205   if (OldDC->Equals(NewDC))
13206     return true;
13207 
13208   // In MSVC mode, we allow a redeclaration if the contexts are related (either
13209   // encloses the other).
13210   if (S.getLangOpts().MSVCCompat &&
13211       (OldDC->Encloses(NewDC) || NewDC->Encloses(OldDC)))
13212     return true;
13213 
13214   return false;
13215 }
13216 
13217 /// \brief This is invoked when we see 'struct foo' or 'struct {'.  In the
13218 /// former case, Name will be non-null.  In the later case, Name will be null.
13219 /// TagSpec indicates what kind of tag this is. TUK indicates whether this is a
13220 /// reference/declaration/definition of a tag.
13221 ///
13222 /// \param IsTypeSpecifier \c true if this is a type-specifier (or
13223 /// trailing-type-specifier) other than one in an alias-declaration.
13224 ///
13225 /// \param SkipBody If non-null, will be set to indicate if the caller should
13226 /// skip the definition of this tag and treat it as if it were a declaration.
13227 Decl *Sema::ActOnTag(Scope *S, unsigned TagSpec, TagUseKind TUK,
13228                      SourceLocation KWLoc, CXXScopeSpec &SS,
13229                      IdentifierInfo *Name, SourceLocation NameLoc,
13230                      AttributeList *Attr, AccessSpecifier AS,
13231                      SourceLocation ModulePrivateLoc,
13232                      MultiTemplateParamsArg TemplateParameterLists,
13233                      bool &OwnedDecl, bool &IsDependent,
13234                      SourceLocation ScopedEnumKWLoc,
13235                      bool ScopedEnumUsesClassTag,
13236                      TypeResult UnderlyingType,
13237                      bool IsTypeSpecifier, bool IsTemplateParamOrArg,
13238                      SkipBodyInfo *SkipBody) {
13239   // If this is not a definition, it must have a name.
13240   IdentifierInfo *OrigName = Name;
13241   assert((Name != nullptr || TUK == TUK_Definition) &&
13242          "Nameless record must be a definition!");
13243   assert(TemplateParameterLists.size() == 0 || TUK != TUK_Reference);
13244 
13245   OwnedDecl = false;
13246   TagTypeKind Kind = TypeWithKeyword::getTagTypeKindForTypeSpec(TagSpec);
13247   bool ScopedEnum = ScopedEnumKWLoc.isValid();
13248 
13249   // FIXME: Check member specializations more carefully.
13250   bool isMemberSpecialization = false;
13251   bool Invalid = false;
13252 
13253   // We only need to do this matching if we have template parameters
13254   // or a scope specifier, which also conveniently avoids this work
13255   // for non-C++ cases.
13256   if (TemplateParameterLists.size() > 0 ||
13257       (SS.isNotEmpty() && TUK != TUK_Reference)) {
13258     if (TemplateParameterList *TemplateParams =
13259             MatchTemplateParametersToScopeSpecifier(
13260                 KWLoc, NameLoc, SS, nullptr, TemplateParameterLists,
13261                 TUK == TUK_Friend, isMemberSpecialization, Invalid)) {
13262       if (Kind == TTK_Enum) {
13263         Diag(KWLoc, diag::err_enum_template);
13264         return nullptr;
13265       }
13266 
13267       if (TemplateParams->size() > 0) {
13268         // This is a declaration or definition of a class template (which may
13269         // be a member of another template).
13270 
13271         if (Invalid)
13272           return nullptr;
13273 
13274         OwnedDecl = false;
13275         DeclResult Result = CheckClassTemplate(S, TagSpec, TUK, KWLoc,
13276                                                SS, Name, NameLoc, Attr,
13277                                                TemplateParams, AS,
13278                                                ModulePrivateLoc,
13279                                                /*FriendLoc*/SourceLocation(),
13280                                                TemplateParameterLists.size()-1,
13281                                                TemplateParameterLists.data(),
13282                                                SkipBody);
13283         return Result.get();
13284       } else {
13285         // The "template<>" header is extraneous.
13286         Diag(TemplateParams->getTemplateLoc(), diag::err_template_tag_noparams)
13287           << TypeWithKeyword::getTagTypeKindName(Kind) << Name;
13288         isMemberSpecialization = true;
13289       }
13290     }
13291   }
13292 
13293   // Figure out the underlying type if this a enum declaration. We need to do
13294   // this early, because it's needed to detect if this is an incompatible
13295   // redeclaration.
13296   llvm::PointerUnion<const Type*, TypeSourceInfo*> EnumUnderlying;
13297   bool EnumUnderlyingIsImplicit = false;
13298 
13299   if (Kind == TTK_Enum) {
13300     if (UnderlyingType.isInvalid() || (!UnderlyingType.get() && ScopedEnum))
13301       // No underlying type explicitly specified, or we failed to parse the
13302       // type, default to int.
13303       EnumUnderlying = Context.IntTy.getTypePtr();
13304     else if (UnderlyingType.get()) {
13305       // C++0x 7.2p2: The type-specifier-seq of an enum-base shall name an
13306       // integral type; any cv-qualification is ignored.
13307       TypeSourceInfo *TI = nullptr;
13308       GetTypeFromParser(UnderlyingType.get(), &TI);
13309       EnumUnderlying = TI;
13310 
13311       if (CheckEnumUnderlyingType(TI))
13312         // Recover by falling back to int.
13313         EnumUnderlying = Context.IntTy.getTypePtr();
13314 
13315       if (DiagnoseUnexpandedParameterPack(TI->getTypeLoc().getBeginLoc(), TI,
13316                                           UPPC_FixedUnderlyingType))
13317         EnumUnderlying = Context.IntTy.getTypePtr();
13318 
13319     } else if (Context.getTargetInfo().getCXXABI().isMicrosoft()) {
13320       if (getLangOpts().MSVCCompat || TUK == TUK_Definition) {
13321         // Microsoft enums are always of int type.
13322         EnumUnderlying = Context.IntTy.getTypePtr();
13323         EnumUnderlyingIsImplicit = true;
13324       }
13325     }
13326   }
13327 
13328   DeclContext *SearchDC = CurContext;
13329   DeclContext *DC = CurContext;
13330   bool isStdBadAlloc = false;
13331   bool isStdAlignValT = false;
13332 
13333   RedeclarationKind Redecl = forRedeclarationInCurContext();
13334   if (TUK == TUK_Friend || TUK == TUK_Reference)
13335     Redecl = NotForRedeclaration;
13336 
13337   /// Create a new tag decl in C/ObjC. Since the ODR-like semantics for ObjC/C
13338   /// implemented asks for structural equivalence checking, the returned decl
13339   /// here is passed back to the parser, allowing the tag body to be parsed.
13340   auto createTagFromNewDecl = [&]() -> TagDecl * {
13341     assert(!getLangOpts().CPlusPlus && "not meant for C++ usage");
13342     // If there is an identifier, use the location of the identifier as the
13343     // location of the decl, otherwise use the location of the struct/union
13344     // keyword.
13345     SourceLocation Loc = NameLoc.isValid() ? NameLoc : KWLoc;
13346     TagDecl *New = nullptr;
13347 
13348     if (Kind == TTK_Enum) {
13349       New = EnumDecl::Create(Context, SearchDC, KWLoc, Loc, Name, nullptr,
13350                              ScopedEnum, ScopedEnumUsesClassTag,
13351                              !EnumUnderlying.isNull());
13352       // If this is an undefined enum, bail.
13353       if (TUK != TUK_Definition && !Invalid)
13354         return nullptr;
13355       if (EnumUnderlying) {
13356         EnumDecl *ED = cast<EnumDecl>(New);
13357         if (TypeSourceInfo *TI = EnumUnderlying.dyn_cast<TypeSourceInfo *>())
13358           ED->setIntegerTypeSourceInfo(TI);
13359         else
13360           ED->setIntegerType(QualType(EnumUnderlying.get<const Type *>(), 0));
13361         ED->setPromotionType(ED->getIntegerType());
13362       }
13363     } else { // struct/union
13364       New = RecordDecl::Create(Context, Kind, SearchDC, KWLoc, Loc, Name,
13365                                nullptr);
13366     }
13367 
13368     if (RecordDecl *RD = dyn_cast<RecordDecl>(New)) {
13369       // Add alignment attributes if necessary; these attributes are checked
13370       // when the ASTContext lays out the structure.
13371       //
13372       // It is important for implementing the correct semantics that this
13373       // happen here (in ActOnTag). The #pragma pack stack is
13374       // maintained as a result of parser callbacks which can occur at
13375       // many points during the parsing of a struct declaration (because
13376       // the #pragma tokens are effectively skipped over during the
13377       // parsing of the struct).
13378       if (TUK == TUK_Definition) {
13379         AddAlignmentAttributesForRecord(RD);
13380         AddMsStructLayoutForRecord(RD);
13381       }
13382     }
13383     New->setLexicalDeclContext(CurContext);
13384     return New;
13385   };
13386 
13387   LookupResult Previous(*this, Name, NameLoc, LookupTagName, Redecl);
13388   if (Name && SS.isNotEmpty()) {
13389     // We have a nested-name tag ('struct foo::bar').
13390 
13391     // Check for invalid 'foo::'.
13392     if (SS.isInvalid()) {
13393       Name = nullptr;
13394       goto CreateNewDecl;
13395     }
13396 
13397     // If this is a friend or a reference to a class in a dependent
13398     // context, don't try to make a decl for it.
13399     if (TUK == TUK_Friend || TUK == TUK_Reference) {
13400       DC = computeDeclContext(SS, false);
13401       if (!DC) {
13402         IsDependent = true;
13403         return nullptr;
13404       }
13405     } else {
13406       DC = computeDeclContext(SS, true);
13407       if (!DC) {
13408         Diag(SS.getRange().getBegin(), diag::err_dependent_nested_name_spec)
13409           << SS.getRange();
13410         return nullptr;
13411       }
13412     }
13413 
13414     if (RequireCompleteDeclContext(SS, DC))
13415       return nullptr;
13416 
13417     SearchDC = DC;
13418     // Look-up name inside 'foo::'.
13419     LookupQualifiedName(Previous, DC);
13420 
13421     if (Previous.isAmbiguous())
13422       return nullptr;
13423 
13424     if (Previous.empty()) {
13425       // Name lookup did not find anything. However, if the
13426       // nested-name-specifier refers to the current instantiation,
13427       // and that current instantiation has any dependent base
13428       // classes, we might find something at instantiation time: treat
13429       // this as a dependent elaborated-type-specifier.
13430       // But this only makes any sense for reference-like lookups.
13431       if (Previous.wasNotFoundInCurrentInstantiation() &&
13432           (TUK == TUK_Reference || TUK == TUK_Friend)) {
13433         IsDependent = true;
13434         return nullptr;
13435       }
13436 
13437       // A tag 'foo::bar' must already exist.
13438       Diag(NameLoc, diag::err_not_tag_in_scope)
13439         << Kind << Name << DC << SS.getRange();
13440       Name = nullptr;
13441       Invalid = true;
13442       goto CreateNewDecl;
13443     }
13444   } else if (Name) {
13445     // C++14 [class.mem]p14:
13446     //   If T is the name of a class, then each of the following shall have a
13447     //   name different from T:
13448     //    -- every member of class T that is itself a type
13449     if (TUK != TUK_Reference && TUK != TUK_Friend &&
13450         DiagnoseClassNameShadow(SearchDC, DeclarationNameInfo(Name, NameLoc)))
13451       return nullptr;
13452 
13453     // If this is a named struct, check to see if there was a previous forward
13454     // declaration or definition.
13455     // FIXME: We're looking into outer scopes here, even when we
13456     // shouldn't be. Doing so can result in ambiguities that we
13457     // shouldn't be diagnosing.
13458     LookupName(Previous, S);
13459 
13460     // When declaring or defining a tag, ignore ambiguities introduced
13461     // by types using'ed into this scope.
13462     if (Previous.isAmbiguous() &&
13463         (TUK == TUK_Definition || TUK == TUK_Declaration)) {
13464       LookupResult::Filter F = Previous.makeFilter();
13465       while (F.hasNext()) {
13466         NamedDecl *ND = F.next();
13467         if (!ND->getDeclContext()->getRedeclContext()->Equals(
13468                 SearchDC->getRedeclContext()))
13469           F.erase();
13470       }
13471       F.done();
13472     }
13473 
13474     // C++11 [namespace.memdef]p3:
13475     //   If the name in a friend declaration is neither qualified nor
13476     //   a template-id and the declaration is a function or an
13477     //   elaborated-type-specifier, the lookup to determine whether
13478     //   the entity has been previously declared shall not consider
13479     //   any scopes outside the innermost enclosing namespace.
13480     //
13481     // MSVC doesn't implement the above rule for types, so a friend tag
13482     // declaration may be a redeclaration of a type declared in an enclosing
13483     // scope.  They do implement this rule for friend functions.
13484     //
13485     // Does it matter that this should be by scope instead of by
13486     // semantic context?
13487     if (!Previous.empty() && TUK == TUK_Friend) {
13488       DeclContext *EnclosingNS = SearchDC->getEnclosingNamespaceContext();
13489       LookupResult::Filter F = Previous.makeFilter();
13490       bool FriendSawTagOutsideEnclosingNamespace = false;
13491       while (F.hasNext()) {
13492         NamedDecl *ND = F.next();
13493         DeclContext *DC = ND->getDeclContext()->getRedeclContext();
13494         if (DC->isFileContext() &&
13495             !EnclosingNS->Encloses(ND->getDeclContext())) {
13496           if (getLangOpts().MSVCCompat)
13497             FriendSawTagOutsideEnclosingNamespace = true;
13498           else
13499             F.erase();
13500         }
13501       }
13502       F.done();
13503 
13504       // Diagnose this MSVC extension in the easy case where lookup would have
13505       // unambiguously found something outside the enclosing namespace.
13506       if (Previous.isSingleResult() && FriendSawTagOutsideEnclosingNamespace) {
13507         NamedDecl *ND = Previous.getFoundDecl();
13508         Diag(NameLoc, diag::ext_friend_tag_redecl_outside_namespace)
13509             << createFriendTagNNSFixIt(*this, ND, S, NameLoc);
13510       }
13511     }
13512 
13513     // Note:  there used to be some attempt at recovery here.
13514     if (Previous.isAmbiguous())
13515       return nullptr;
13516 
13517     if (!getLangOpts().CPlusPlus && TUK != TUK_Reference) {
13518       // FIXME: This makes sure that we ignore the contexts associated
13519       // with C structs, unions, and enums when looking for a matching
13520       // tag declaration or definition. See the similar lookup tweak
13521       // in Sema::LookupName; is there a better way to deal with this?
13522       while (isa<RecordDecl>(SearchDC) || isa<EnumDecl>(SearchDC))
13523         SearchDC = SearchDC->getParent();
13524     }
13525   }
13526 
13527   if (Previous.isSingleResult() &&
13528       Previous.getFoundDecl()->isTemplateParameter()) {
13529     // Maybe we will complain about the shadowed template parameter.
13530     DiagnoseTemplateParameterShadow(NameLoc, Previous.getFoundDecl());
13531     // Just pretend that we didn't see the previous declaration.
13532     Previous.clear();
13533   }
13534 
13535   if (getLangOpts().CPlusPlus && Name && DC && StdNamespace &&
13536       DC->Equals(getStdNamespace())) {
13537     if (Name->isStr("bad_alloc")) {
13538       // This is a declaration of or a reference to "std::bad_alloc".
13539       isStdBadAlloc = true;
13540 
13541       // If std::bad_alloc has been implicitly declared (but made invisible to
13542       // name lookup), fill in this implicit declaration as the previous
13543       // declaration, so that the declarations get chained appropriately.
13544       if (Previous.empty() && StdBadAlloc)
13545         Previous.addDecl(getStdBadAlloc());
13546     } else if (Name->isStr("align_val_t")) {
13547       isStdAlignValT = true;
13548       if (Previous.empty() && StdAlignValT)
13549         Previous.addDecl(getStdAlignValT());
13550     }
13551   }
13552 
13553   // If we didn't find a previous declaration, and this is a reference
13554   // (or friend reference), move to the correct scope.  In C++, we
13555   // also need to do a redeclaration lookup there, just in case
13556   // there's a shadow friend decl.
13557   if (Name && Previous.empty() &&
13558       (TUK == TUK_Reference || TUK == TUK_Friend || IsTemplateParamOrArg)) {
13559     if (Invalid) goto CreateNewDecl;
13560     assert(SS.isEmpty());
13561 
13562     if (TUK == TUK_Reference || IsTemplateParamOrArg) {
13563       // C++ [basic.scope.pdecl]p5:
13564       //   -- for an elaborated-type-specifier of the form
13565       //
13566       //          class-key identifier
13567       //
13568       //      if the elaborated-type-specifier is used in the
13569       //      decl-specifier-seq or parameter-declaration-clause of a
13570       //      function defined in namespace scope, the identifier is
13571       //      declared as a class-name in the namespace that contains
13572       //      the declaration; otherwise, except as a friend
13573       //      declaration, the identifier is declared in the smallest
13574       //      non-class, non-function-prototype scope that contains the
13575       //      declaration.
13576       //
13577       // C99 6.7.2.3p8 has a similar (but not identical!) provision for
13578       // C structs and unions.
13579       //
13580       // It is an error in C++ to declare (rather than define) an enum
13581       // type, including via an elaborated type specifier.  We'll
13582       // diagnose that later; for now, declare the enum in the same
13583       // scope as we would have picked for any other tag type.
13584       //
13585       // GNU C also supports this behavior as part of its incomplete
13586       // enum types extension, while GNU C++ does not.
13587       //
13588       // Find the context where we'll be declaring the tag.
13589       // FIXME: We would like to maintain the current DeclContext as the
13590       // lexical context,
13591       SearchDC = getTagInjectionContext(SearchDC);
13592 
13593       // Find the scope where we'll be declaring the tag.
13594       S = getTagInjectionScope(S, getLangOpts());
13595     } else {
13596       assert(TUK == TUK_Friend);
13597       // C++ [namespace.memdef]p3:
13598       //   If a friend declaration in a non-local class first declares a
13599       //   class or function, the friend class or function is a member of
13600       //   the innermost enclosing namespace.
13601       SearchDC = SearchDC->getEnclosingNamespaceContext();
13602     }
13603 
13604     // In C++, we need to do a redeclaration lookup to properly
13605     // diagnose some problems.
13606     // FIXME: redeclaration lookup is also used (with and without C++) to find a
13607     // hidden declaration so that we don't get ambiguity errors when using a
13608     // type declared by an elaborated-type-specifier.  In C that is not correct
13609     // and we should instead merge compatible types found by lookup.
13610     if (getLangOpts().CPlusPlus) {
13611       Previous.setRedeclarationKind(forRedeclarationInCurContext());
13612       LookupQualifiedName(Previous, SearchDC);
13613     } else {
13614       Previous.setRedeclarationKind(forRedeclarationInCurContext());
13615       LookupName(Previous, S);
13616     }
13617   }
13618 
13619   // If we have a known previous declaration to use, then use it.
13620   if (Previous.empty() && SkipBody && SkipBody->Previous)
13621     Previous.addDecl(SkipBody->Previous);
13622 
13623   if (!Previous.empty()) {
13624     NamedDecl *PrevDecl = Previous.getFoundDecl();
13625     NamedDecl *DirectPrevDecl = Previous.getRepresentativeDecl();
13626 
13627     // It's okay to have a tag decl in the same scope as a typedef
13628     // which hides a tag decl in the same scope.  Finding this
13629     // insanity with a redeclaration lookup can only actually happen
13630     // in C++.
13631     //
13632     // This is also okay for elaborated-type-specifiers, which is
13633     // technically forbidden by the current standard but which is
13634     // okay according to the likely resolution of an open issue;
13635     // see http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#407
13636     if (getLangOpts().CPlusPlus) {
13637       if (TypedefNameDecl *TD = dyn_cast<TypedefNameDecl>(PrevDecl)) {
13638         if (const TagType *TT = TD->getUnderlyingType()->getAs<TagType>()) {
13639           TagDecl *Tag = TT->getDecl();
13640           if (Tag->getDeclName() == Name &&
13641               Tag->getDeclContext()->getRedeclContext()
13642                           ->Equals(TD->getDeclContext()->getRedeclContext())) {
13643             PrevDecl = Tag;
13644             Previous.clear();
13645             Previous.addDecl(Tag);
13646             Previous.resolveKind();
13647           }
13648         }
13649       }
13650     }
13651 
13652     // If this is a redeclaration of a using shadow declaration, it must
13653     // declare a tag in the same context. In MSVC mode, we allow a
13654     // redefinition if either context is within the other.
13655     if (auto *Shadow = dyn_cast<UsingShadowDecl>(DirectPrevDecl)) {
13656       auto *OldTag = dyn_cast<TagDecl>(PrevDecl);
13657       if (SS.isEmpty() && TUK != TUK_Reference && TUK != TUK_Friend &&
13658           isDeclInScope(Shadow, SearchDC, S, isMemberSpecialization) &&
13659           !(OldTag && isAcceptableTagRedeclContext(
13660                           *this, OldTag->getDeclContext(), SearchDC))) {
13661         Diag(KWLoc, diag::err_using_decl_conflict_reverse);
13662         Diag(Shadow->getTargetDecl()->getLocation(),
13663              diag::note_using_decl_target);
13664         Diag(Shadow->getUsingDecl()->getLocation(), diag::note_using_decl)
13665             << 0;
13666         // Recover by ignoring the old declaration.
13667         Previous.clear();
13668         goto CreateNewDecl;
13669       }
13670     }
13671 
13672     if (TagDecl *PrevTagDecl = dyn_cast<TagDecl>(PrevDecl)) {
13673       // If this is a use of a previous tag, or if the tag is already declared
13674       // in the same scope (so that the definition/declaration completes or
13675       // rementions the tag), reuse the decl.
13676       if (TUK == TUK_Reference || TUK == TUK_Friend ||
13677           isDeclInScope(DirectPrevDecl, SearchDC, S,
13678                         SS.isNotEmpty() || isMemberSpecialization)) {
13679         // Make sure that this wasn't declared as an enum and now used as a
13680         // struct or something similar.
13681         if (!isAcceptableTagRedeclaration(PrevTagDecl, Kind,
13682                                           TUK == TUK_Definition, KWLoc,
13683                                           Name)) {
13684           bool SafeToContinue
13685             = (PrevTagDecl->getTagKind() != TTK_Enum &&
13686                Kind != TTK_Enum);
13687           if (SafeToContinue)
13688             Diag(KWLoc, diag::err_use_with_wrong_tag)
13689               << Name
13690               << FixItHint::CreateReplacement(SourceRange(KWLoc),
13691                                               PrevTagDecl->getKindName());
13692           else
13693             Diag(KWLoc, diag::err_use_with_wrong_tag) << Name;
13694           Diag(PrevTagDecl->getLocation(), diag::note_previous_use);
13695 
13696           if (SafeToContinue)
13697             Kind = PrevTagDecl->getTagKind();
13698           else {
13699             // Recover by making this an anonymous redefinition.
13700             Name = nullptr;
13701             Previous.clear();
13702             Invalid = true;
13703           }
13704         }
13705 
13706         if (Kind == TTK_Enum && PrevTagDecl->getTagKind() == TTK_Enum) {
13707           const EnumDecl *PrevEnum = cast<EnumDecl>(PrevTagDecl);
13708 
13709           // If this is an elaborated-type-specifier for a scoped enumeration,
13710           // the 'class' keyword is not necessary and not permitted.
13711           if (TUK == TUK_Reference || TUK == TUK_Friend) {
13712             if (ScopedEnum)
13713               Diag(ScopedEnumKWLoc, diag::err_enum_class_reference)
13714                 << PrevEnum->isScoped()
13715                 << FixItHint::CreateRemoval(ScopedEnumKWLoc);
13716             return PrevTagDecl;
13717           }
13718 
13719           QualType EnumUnderlyingTy;
13720           if (TypeSourceInfo *TI = EnumUnderlying.dyn_cast<TypeSourceInfo*>())
13721             EnumUnderlyingTy = TI->getType().getUnqualifiedType();
13722           else if (const Type *T = EnumUnderlying.dyn_cast<const Type*>())
13723             EnumUnderlyingTy = QualType(T, 0);
13724 
13725           // All conflicts with previous declarations are recovered by
13726           // returning the previous declaration, unless this is a definition,
13727           // in which case we want the caller to bail out.
13728           if (CheckEnumRedeclaration(NameLoc.isValid() ? NameLoc : KWLoc,
13729                                      ScopedEnum, EnumUnderlyingTy,
13730                                      EnumUnderlyingIsImplicit, PrevEnum))
13731             return TUK == TUK_Declaration ? PrevTagDecl : nullptr;
13732         }
13733 
13734         // C++11 [class.mem]p1:
13735         //   A member shall not be declared twice in the member-specification,
13736         //   except that a nested class or member class template can be declared
13737         //   and then later defined.
13738         if (TUK == TUK_Declaration && PrevDecl->isCXXClassMember() &&
13739             S->isDeclScope(PrevDecl)) {
13740           Diag(NameLoc, diag::ext_member_redeclared);
13741           Diag(PrevTagDecl->getLocation(), diag::note_previous_declaration);
13742         }
13743 
13744         if (!Invalid) {
13745           // If this is a use, just return the declaration we found, unless
13746           // we have attributes.
13747           if (TUK == TUK_Reference || TUK == TUK_Friend) {
13748             if (Attr) {
13749               // FIXME: Diagnose these attributes. For now, we create a new
13750               // declaration to hold them.
13751             } else if (TUK == TUK_Reference &&
13752                        (PrevTagDecl->getFriendObjectKind() ==
13753                             Decl::FOK_Undeclared ||
13754                         PrevDecl->getOwningModule() != getCurrentModule()) &&
13755                        SS.isEmpty()) {
13756               // This declaration is a reference to an existing entity, but
13757               // has different visibility from that entity: it either makes
13758               // a friend visible or it makes a type visible in a new module.
13759               // In either case, create a new declaration. We only do this if
13760               // the declaration would have meant the same thing if no prior
13761               // declaration were found, that is, if it was found in the same
13762               // scope where we would have injected a declaration.
13763               if (!getTagInjectionContext(CurContext)->getRedeclContext()
13764                        ->Equals(PrevDecl->getDeclContext()->getRedeclContext()))
13765                 return PrevTagDecl;
13766               // This is in the injected scope, create a new declaration in
13767               // that scope.
13768               S = getTagInjectionScope(S, getLangOpts());
13769             } else {
13770               return PrevTagDecl;
13771             }
13772           }
13773 
13774           // Diagnose attempts to redefine a tag.
13775           if (TUK == TUK_Definition) {
13776             if (NamedDecl *Def = PrevTagDecl->getDefinition()) {
13777               // If we're defining a specialization and the previous definition
13778               // is from an implicit instantiation, don't emit an error
13779               // here; we'll catch this in the general case below.
13780               bool IsExplicitSpecializationAfterInstantiation = false;
13781               if (isMemberSpecialization) {
13782                 if (CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(Def))
13783                   IsExplicitSpecializationAfterInstantiation =
13784                     RD->getTemplateSpecializationKind() !=
13785                     TSK_ExplicitSpecialization;
13786                 else if (EnumDecl *ED = dyn_cast<EnumDecl>(Def))
13787                   IsExplicitSpecializationAfterInstantiation =
13788                     ED->getTemplateSpecializationKind() !=
13789                     TSK_ExplicitSpecialization;
13790               }
13791 
13792               // Note that clang allows ODR-like semantics for ObjC/C, i.e., do
13793               // not keep more that one definition around (merge them). However,
13794               // ensure the decl passes the structural compatibility check in
13795               // C11 6.2.7/1 (or 6.1.2.6/1 in C89).
13796               NamedDecl *Hidden = nullptr;
13797               if (SkipBody && !hasVisibleDefinition(Def, &Hidden)) {
13798                 // There is a definition of this tag, but it is not visible. We
13799                 // explicitly make use of C++'s one definition rule here, and
13800                 // assume that this definition is identical to the hidden one
13801                 // we already have. Make the existing definition visible and
13802                 // use it in place of this one.
13803                 if (!getLangOpts().CPlusPlus) {
13804                   // Postpone making the old definition visible until after we
13805                   // complete parsing the new one and do the structural
13806                   // comparison.
13807                   SkipBody->CheckSameAsPrevious = true;
13808                   SkipBody->New = createTagFromNewDecl();
13809                   SkipBody->Previous = Hidden;
13810                 } else {
13811                   SkipBody->ShouldSkip = true;
13812                   makeMergedDefinitionVisible(Hidden);
13813                 }
13814                 return Def;
13815               } else if (!IsExplicitSpecializationAfterInstantiation) {
13816                 // A redeclaration in function prototype scope in C isn't
13817                 // visible elsewhere, so merely issue a warning.
13818                 if (!getLangOpts().CPlusPlus && S->containedInPrototypeScope())
13819                   Diag(NameLoc, diag::warn_redefinition_in_param_list) << Name;
13820                 else
13821                   Diag(NameLoc, diag::err_redefinition) << Name;
13822                 notePreviousDefinition(Def,
13823                                        NameLoc.isValid() ? NameLoc : KWLoc);
13824                 // If this is a redefinition, recover by making this
13825                 // struct be anonymous, which will make any later
13826                 // references get the previous definition.
13827                 Name = nullptr;
13828                 Previous.clear();
13829                 Invalid = true;
13830               }
13831             } else {
13832               // If the type is currently being defined, complain
13833               // about a nested redefinition.
13834               auto *TD = Context.getTagDeclType(PrevTagDecl)->getAsTagDecl();
13835               if (TD->isBeingDefined()) {
13836                 Diag(NameLoc, diag::err_nested_redefinition) << Name;
13837                 Diag(PrevTagDecl->getLocation(),
13838                      diag::note_previous_definition);
13839                 Name = nullptr;
13840                 Previous.clear();
13841                 Invalid = true;
13842               }
13843             }
13844 
13845             // Okay, this is definition of a previously declared or referenced
13846             // tag. We're going to create a new Decl for it.
13847           }
13848 
13849           // Okay, we're going to make a redeclaration.  If this is some kind
13850           // of reference, make sure we build the redeclaration in the same DC
13851           // as the original, and ignore the current access specifier.
13852           if (TUK == TUK_Friend || TUK == TUK_Reference) {
13853             SearchDC = PrevTagDecl->getDeclContext();
13854             AS = AS_none;
13855           }
13856         }
13857         // If we get here we have (another) forward declaration or we
13858         // have a definition.  Just create a new decl.
13859 
13860       } else {
13861         // If we get here, this is a definition of a new tag type in a nested
13862         // scope, e.g. "struct foo; void bar() { struct foo; }", just create a
13863         // new decl/type.  We set PrevDecl to NULL so that the entities
13864         // have distinct types.
13865         Previous.clear();
13866       }
13867       // If we get here, we're going to create a new Decl. If PrevDecl
13868       // is non-NULL, it's a definition of the tag declared by
13869       // PrevDecl. If it's NULL, we have a new definition.
13870 
13871     // Otherwise, PrevDecl is not a tag, but was found with tag
13872     // lookup.  This is only actually possible in C++, where a few
13873     // things like templates still live in the tag namespace.
13874     } else {
13875       // Use a better diagnostic if an elaborated-type-specifier
13876       // found the wrong kind of type on the first
13877       // (non-redeclaration) lookup.
13878       if ((TUK == TUK_Reference || TUK == TUK_Friend) &&
13879           !Previous.isForRedeclaration()) {
13880         NonTagKind NTK = getNonTagTypeDeclKind(PrevDecl, Kind);
13881         Diag(NameLoc, diag::err_tag_reference_non_tag) << PrevDecl << NTK
13882                                                        << Kind;
13883         Diag(PrevDecl->getLocation(), diag::note_declared_at);
13884         Invalid = true;
13885 
13886       // Otherwise, only diagnose if the declaration is in scope.
13887       } else if (!isDeclInScope(DirectPrevDecl, SearchDC, S,
13888                                 SS.isNotEmpty() || isMemberSpecialization)) {
13889         // do nothing
13890 
13891       // Diagnose implicit declarations introduced by elaborated types.
13892       } else if (TUK == TUK_Reference || TUK == TUK_Friend) {
13893         NonTagKind NTK = getNonTagTypeDeclKind(PrevDecl, Kind);
13894         Diag(NameLoc, diag::err_tag_reference_conflict) << NTK;
13895         Diag(PrevDecl->getLocation(), diag::note_previous_decl) << PrevDecl;
13896         Invalid = true;
13897 
13898       // Otherwise it's a declaration.  Call out a particularly common
13899       // case here.
13900       } else if (TypedefNameDecl *TND = dyn_cast<TypedefNameDecl>(PrevDecl)) {
13901         unsigned Kind = 0;
13902         if (isa<TypeAliasDecl>(PrevDecl)) Kind = 1;
13903         Diag(NameLoc, diag::err_tag_definition_of_typedef)
13904           << Name << Kind << TND->getUnderlyingType();
13905         Diag(PrevDecl->getLocation(), diag::note_previous_decl) << PrevDecl;
13906         Invalid = true;
13907 
13908       // Otherwise, diagnose.
13909       } else {
13910         // The tag name clashes with something else in the target scope,
13911         // issue an error and recover by making this tag be anonymous.
13912         Diag(NameLoc, diag::err_redefinition_different_kind) << Name;
13913         notePreviousDefinition(PrevDecl, NameLoc);
13914         Name = nullptr;
13915         Invalid = true;
13916       }
13917 
13918       // The existing declaration isn't relevant to us; we're in a
13919       // new scope, so clear out the previous declaration.
13920       Previous.clear();
13921     }
13922   }
13923 
13924 CreateNewDecl:
13925 
13926   TagDecl *PrevDecl = nullptr;
13927   if (Previous.isSingleResult())
13928     PrevDecl = cast<TagDecl>(Previous.getFoundDecl());
13929 
13930   // If there is an identifier, use the location of the identifier as the
13931   // location of the decl, otherwise use the location of the struct/union
13932   // keyword.
13933   SourceLocation Loc = NameLoc.isValid() ? NameLoc : KWLoc;
13934 
13935   // Otherwise, create a new declaration. If there is a previous
13936   // declaration of the same entity, the two will be linked via
13937   // PrevDecl.
13938   TagDecl *New;
13939 
13940   bool IsForwardReference = false;
13941   if (Kind == TTK_Enum) {
13942     // FIXME: Tag decls should be chained to any simultaneous vardecls, e.g.:
13943     // enum X { A, B, C } D;    D should chain to X.
13944     New = EnumDecl::Create(Context, SearchDC, KWLoc, Loc, Name,
13945                            cast_or_null<EnumDecl>(PrevDecl), ScopedEnum,
13946                            ScopedEnumUsesClassTag, !EnumUnderlying.isNull());
13947 
13948     if (isStdAlignValT && (!StdAlignValT || getStdAlignValT()->isImplicit()))
13949       StdAlignValT = cast<EnumDecl>(New);
13950 
13951     // If this is an undefined enum, warn.
13952     if (TUK != TUK_Definition && !Invalid) {
13953       TagDecl *Def;
13954       if (!EnumUnderlyingIsImplicit &&
13955           (getLangOpts().CPlusPlus11 || getLangOpts().ObjC2) &&
13956           cast<EnumDecl>(New)->isFixed()) {
13957         // C++0x: 7.2p2: opaque-enum-declaration.
13958         // Conflicts are diagnosed above. Do nothing.
13959       }
13960       else if (PrevDecl && (Def = cast<EnumDecl>(PrevDecl)->getDefinition())) {
13961         Diag(Loc, diag::ext_forward_ref_enum_def)
13962           << New;
13963         Diag(Def->getLocation(), diag::note_previous_definition);
13964       } else {
13965         unsigned DiagID = diag::ext_forward_ref_enum;
13966         if (getLangOpts().MSVCCompat)
13967           DiagID = diag::ext_ms_forward_ref_enum;
13968         else if (getLangOpts().CPlusPlus)
13969           DiagID = diag::err_forward_ref_enum;
13970         Diag(Loc, DiagID);
13971 
13972         // If this is a forward-declared reference to an enumeration, make a
13973         // note of it; we won't actually be introducing the declaration into
13974         // the declaration context.
13975         if (TUK == TUK_Reference)
13976           IsForwardReference = true;
13977       }
13978     }
13979 
13980     if (EnumUnderlying) {
13981       EnumDecl *ED = cast<EnumDecl>(New);
13982       if (TypeSourceInfo *TI = EnumUnderlying.dyn_cast<TypeSourceInfo*>())
13983         ED->setIntegerTypeSourceInfo(TI);
13984       else
13985         ED->setIntegerType(QualType(EnumUnderlying.get<const Type*>(), 0));
13986       ED->setPromotionType(ED->getIntegerType());
13987     }
13988   } else {
13989     // struct/union/class
13990 
13991     // FIXME: Tag decls should be chained to any simultaneous vardecls, e.g.:
13992     // struct X { int A; } D;    D should chain to X.
13993     if (getLangOpts().CPlusPlus) {
13994       // FIXME: Look for a way to use RecordDecl for simple structs.
13995       New = CXXRecordDecl::Create(Context, Kind, SearchDC, KWLoc, Loc, Name,
13996                                   cast_or_null<CXXRecordDecl>(PrevDecl));
13997 
13998       if (isStdBadAlloc && (!StdBadAlloc || getStdBadAlloc()->isImplicit()))
13999         StdBadAlloc = cast<CXXRecordDecl>(New);
14000     } else
14001       New = RecordDecl::Create(Context, Kind, SearchDC, KWLoc, Loc, Name,
14002                                cast_or_null<RecordDecl>(PrevDecl));
14003   }
14004 
14005   // C++11 [dcl.type]p3:
14006   //   A type-specifier-seq shall not define a class or enumeration [...].
14007   if (getLangOpts().CPlusPlus && (IsTypeSpecifier || IsTemplateParamOrArg) &&
14008       TUK == TUK_Definition) {
14009     Diag(New->getLocation(), diag::err_type_defined_in_type_specifier)
14010       << Context.getTagDeclType(New);
14011     Invalid = true;
14012   }
14013 
14014   if (!Invalid && getLangOpts().CPlusPlus && TUK == TUK_Definition &&
14015       DC->getDeclKind() == Decl::Enum) {
14016     Diag(New->getLocation(), diag::err_type_defined_in_enum)
14017       << Context.getTagDeclType(New);
14018     Invalid = true;
14019   }
14020 
14021   // Maybe add qualifier info.
14022   if (SS.isNotEmpty()) {
14023     if (SS.isSet()) {
14024       // If this is either a declaration or a definition, check the
14025       // nested-name-specifier against the current context. We don't do this
14026       // for explicit specializations, because they have similar checking
14027       // (with more specific diagnostics) in the call to
14028       // CheckMemberSpecialization, below.
14029       if (!isMemberSpecialization &&
14030           (TUK == TUK_Definition || TUK == TUK_Declaration) &&
14031           diagnoseQualifiedDeclaration(SS, DC, OrigName, Loc))
14032         Invalid = true;
14033 
14034       New->setQualifierInfo(SS.getWithLocInContext(Context));
14035       if (TemplateParameterLists.size() > 0) {
14036         New->setTemplateParameterListsInfo(Context, TemplateParameterLists);
14037       }
14038     }
14039     else
14040       Invalid = true;
14041   }
14042 
14043   if (RecordDecl *RD = dyn_cast<RecordDecl>(New)) {
14044     // Add alignment attributes if necessary; these attributes are checked when
14045     // the ASTContext lays out the structure.
14046     //
14047     // It is important for implementing the correct semantics that this
14048     // happen here (in ActOnTag). The #pragma pack stack is
14049     // maintained as a result of parser callbacks which can occur at
14050     // many points during the parsing of a struct declaration (because
14051     // the #pragma tokens are effectively skipped over during the
14052     // parsing of the struct).
14053     if (TUK == TUK_Definition) {
14054       AddAlignmentAttributesForRecord(RD);
14055       AddMsStructLayoutForRecord(RD);
14056     }
14057   }
14058 
14059   if (ModulePrivateLoc.isValid()) {
14060     if (isMemberSpecialization)
14061       Diag(New->getLocation(), diag::err_module_private_specialization)
14062         << 2
14063         << FixItHint::CreateRemoval(ModulePrivateLoc);
14064     // __module_private__ does not apply to local classes. However, we only
14065     // diagnose this as an error when the declaration specifiers are
14066     // freestanding. Here, we just ignore the __module_private__.
14067     else if (!SearchDC->isFunctionOrMethod())
14068       New->setModulePrivate();
14069   }
14070 
14071   // If this is a specialization of a member class (of a class template),
14072   // check the specialization.
14073   if (isMemberSpecialization && CheckMemberSpecialization(New, Previous))
14074     Invalid = true;
14075 
14076   // If we're declaring or defining a tag in function prototype scope in C,
14077   // note that this type can only be used within the function and add it to
14078   // the list of decls to inject into the function definition scope.
14079   if ((Name || Kind == TTK_Enum) &&
14080       getNonFieldDeclScope(S)->isFunctionPrototypeScope()) {
14081     if (getLangOpts().CPlusPlus) {
14082       // C++ [dcl.fct]p6:
14083       //   Types shall not be defined in return or parameter types.
14084       if (TUK == TUK_Definition && !IsTypeSpecifier) {
14085         Diag(Loc, diag::err_type_defined_in_param_type)
14086             << Name;
14087         Invalid = true;
14088       }
14089     } else if (!PrevDecl) {
14090       Diag(Loc, diag::warn_decl_in_param_list) << Context.getTagDeclType(New);
14091     }
14092   }
14093 
14094   if (Invalid)
14095     New->setInvalidDecl();
14096 
14097   // Set the lexical context. If the tag has a C++ scope specifier, the
14098   // lexical context will be different from the semantic context.
14099   New->setLexicalDeclContext(CurContext);
14100 
14101   // Mark this as a friend decl if applicable.
14102   // In Microsoft mode, a friend declaration also acts as a forward
14103   // declaration so we always pass true to setObjectOfFriendDecl to make
14104   // the tag name visible.
14105   if (TUK == TUK_Friend)
14106     New->setObjectOfFriendDecl(getLangOpts().MSVCCompat);
14107 
14108   // Set the access specifier.
14109   if (!Invalid && SearchDC->isRecord())
14110     SetMemberAccessSpecifier(New, PrevDecl, AS);
14111 
14112   if (PrevDecl)
14113     CheckRedeclarationModuleOwnership(New, PrevDecl);
14114 
14115   if (TUK == TUK_Definition)
14116     New->startDefinition();
14117 
14118   if (Attr)
14119     ProcessDeclAttributeList(S, New, Attr);
14120   AddPragmaAttributes(S, New);
14121 
14122   // If this has an identifier, add it to the scope stack.
14123   if (TUK == TUK_Friend) {
14124     // We might be replacing an existing declaration in the lookup tables;
14125     // if so, borrow its access specifier.
14126     if (PrevDecl)
14127       New->setAccess(PrevDecl->getAccess());
14128 
14129     DeclContext *DC = New->getDeclContext()->getRedeclContext();
14130     DC->makeDeclVisibleInContext(New);
14131     if (Name) // can be null along some error paths
14132       if (Scope *EnclosingScope = getScopeForDeclContext(S, DC))
14133         PushOnScopeChains(New, EnclosingScope, /* AddToContext = */ false);
14134   } else if (Name) {
14135     S = getNonFieldDeclScope(S);
14136     PushOnScopeChains(New, S, !IsForwardReference);
14137     if (IsForwardReference)
14138       SearchDC->makeDeclVisibleInContext(New);
14139   } else {
14140     CurContext->addDecl(New);
14141   }
14142 
14143   // If this is the C FILE type, notify the AST context.
14144   if (IdentifierInfo *II = New->getIdentifier())
14145     if (!New->isInvalidDecl() &&
14146         New->getDeclContext()->getRedeclContext()->isTranslationUnit() &&
14147         II->isStr("FILE"))
14148       Context.setFILEDecl(New);
14149 
14150   if (PrevDecl)
14151     mergeDeclAttributes(New, PrevDecl);
14152 
14153   // If there's a #pragma GCC visibility in scope, set the visibility of this
14154   // record.
14155   AddPushedVisibilityAttribute(New);
14156 
14157   if (isMemberSpecialization && !New->isInvalidDecl())
14158     CompleteMemberSpecialization(New, Previous);
14159 
14160   OwnedDecl = true;
14161   // In C++, don't return an invalid declaration. We can't recover well from
14162   // the cases where we make the type anonymous.
14163   if (Invalid && getLangOpts().CPlusPlus) {
14164     if (New->isBeingDefined())
14165       if (auto RD = dyn_cast<RecordDecl>(New))
14166         RD->completeDefinition();
14167     return nullptr;
14168   } else {
14169     return New;
14170   }
14171 }
14172 
14173 void Sema::ActOnTagStartDefinition(Scope *S, Decl *TagD) {
14174   AdjustDeclIfTemplate(TagD);
14175   TagDecl *Tag = cast<TagDecl>(TagD);
14176 
14177   // Enter the tag context.
14178   PushDeclContext(S, Tag);
14179 
14180   ActOnDocumentableDecl(TagD);
14181 
14182   // If there's a #pragma GCC visibility in scope, set the visibility of this
14183   // record.
14184   AddPushedVisibilityAttribute(Tag);
14185 }
14186 
14187 bool Sema::ActOnDuplicateDefinition(DeclSpec &DS, Decl *Prev,
14188                                     SkipBodyInfo &SkipBody) {
14189   if (!hasStructuralCompatLayout(Prev, SkipBody.New))
14190     return false;
14191 
14192   // Make the previous decl visible.
14193   makeMergedDefinitionVisible(SkipBody.Previous);
14194   return true;
14195 }
14196 
14197 Decl *Sema::ActOnObjCContainerStartDefinition(Decl *IDecl) {
14198   assert(isa<ObjCContainerDecl>(IDecl) &&
14199          "ActOnObjCContainerStartDefinition - Not ObjCContainerDecl");
14200   DeclContext *OCD = cast<DeclContext>(IDecl);
14201   assert(getContainingDC(OCD) == CurContext &&
14202       "The next DeclContext should be lexically contained in the current one.");
14203   CurContext = OCD;
14204   return IDecl;
14205 }
14206 
14207 void Sema::ActOnStartCXXMemberDeclarations(Scope *S, Decl *TagD,
14208                                            SourceLocation FinalLoc,
14209                                            bool IsFinalSpelledSealed,
14210                                            SourceLocation LBraceLoc) {
14211   AdjustDeclIfTemplate(TagD);
14212   CXXRecordDecl *Record = cast<CXXRecordDecl>(TagD);
14213 
14214   FieldCollector->StartClass();
14215 
14216   if (!Record->getIdentifier())
14217     return;
14218 
14219   if (FinalLoc.isValid())
14220     Record->addAttr(new (Context)
14221                     FinalAttr(FinalLoc, Context, IsFinalSpelledSealed));
14222 
14223   // C++ [class]p2:
14224   //   [...] The class-name is also inserted into the scope of the
14225   //   class itself; this is known as the injected-class-name. For
14226   //   purposes of access checking, the injected-class-name is treated
14227   //   as if it were a public member name.
14228   CXXRecordDecl *InjectedClassName
14229     = CXXRecordDecl::Create(Context, Record->getTagKind(), CurContext,
14230                             Record->getLocStart(), Record->getLocation(),
14231                             Record->getIdentifier(),
14232                             /*PrevDecl=*/nullptr,
14233                             /*DelayTypeCreation=*/true);
14234   Context.getTypeDeclType(InjectedClassName, Record);
14235   InjectedClassName->setImplicit();
14236   InjectedClassName->setAccess(AS_public);
14237   if (ClassTemplateDecl *Template = Record->getDescribedClassTemplate())
14238       InjectedClassName->setDescribedClassTemplate(Template);
14239   PushOnScopeChains(InjectedClassName, S);
14240   assert(InjectedClassName->isInjectedClassName() &&
14241          "Broken injected-class-name");
14242 }
14243 
14244 void Sema::ActOnTagFinishDefinition(Scope *S, Decl *TagD,
14245                                     SourceRange BraceRange) {
14246   AdjustDeclIfTemplate(TagD);
14247   TagDecl *Tag = cast<TagDecl>(TagD);
14248   Tag->setBraceRange(BraceRange);
14249 
14250   // Make sure we "complete" the definition even it is invalid.
14251   if (Tag->isBeingDefined()) {
14252     assert(Tag->isInvalidDecl() && "We should already have completed it");
14253     if (RecordDecl *RD = dyn_cast<RecordDecl>(Tag))
14254       RD->completeDefinition();
14255   }
14256 
14257   if (isa<CXXRecordDecl>(Tag)) {
14258     FieldCollector->FinishClass();
14259   }
14260 
14261   // Exit this scope of this tag's definition.
14262   PopDeclContext();
14263 
14264   if (getCurLexicalContext()->isObjCContainer() &&
14265       Tag->getDeclContext()->isFileContext())
14266     Tag->setTopLevelDeclInObjCContainer();
14267 
14268   // Notify the consumer that we've defined a tag.
14269   if (!Tag->isInvalidDecl())
14270     Consumer.HandleTagDeclDefinition(Tag);
14271 }
14272 
14273 void Sema::ActOnObjCContainerFinishDefinition() {
14274   // Exit this scope of this interface definition.
14275   PopDeclContext();
14276 }
14277 
14278 void Sema::ActOnObjCTemporaryExitContainerContext(DeclContext *DC) {
14279   assert(DC == CurContext && "Mismatch of container contexts");
14280   OriginalLexicalContext = DC;
14281   ActOnObjCContainerFinishDefinition();
14282 }
14283 
14284 void Sema::ActOnObjCReenterContainerContext(DeclContext *DC) {
14285   ActOnObjCContainerStartDefinition(cast<Decl>(DC));
14286   OriginalLexicalContext = nullptr;
14287 }
14288 
14289 void Sema::ActOnTagDefinitionError(Scope *S, Decl *TagD) {
14290   AdjustDeclIfTemplate(TagD);
14291   TagDecl *Tag = cast<TagDecl>(TagD);
14292   Tag->setInvalidDecl();
14293 
14294   // Make sure we "complete" the definition even it is invalid.
14295   if (Tag->isBeingDefined()) {
14296     if (RecordDecl *RD = dyn_cast<RecordDecl>(Tag))
14297       RD->completeDefinition();
14298   }
14299 
14300   // We're undoing ActOnTagStartDefinition here, not
14301   // ActOnStartCXXMemberDeclarations, so we don't have to mess with
14302   // the FieldCollector.
14303 
14304   PopDeclContext();
14305 }
14306 
14307 // Note that FieldName may be null for anonymous bitfields.
14308 ExprResult Sema::VerifyBitField(SourceLocation FieldLoc,
14309                                 IdentifierInfo *FieldName,
14310                                 QualType FieldTy, bool IsMsStruct,
14311                                 Expr *BitWidth, bool *ZeroWidth) {
14312   // Default to true; that shouldn't confuse checks for emptiness
14313   if (ZeroWidth)
14314     *ZeroWidth = true;
14315 
14316   // C99 6.7.2.1p4 - verify the field type.
14317   // C++ 9.6p3: A bit-field shall have integral or enumeration type.
14318   if (!FieldTy->isDependentType() && !FieldTy->isIntegralOrEnumerationType()) {
14319     // Handle incomplete types with specific error.
14320     if (RequireCompleteType(FieldLoc, FieldTy, diag::err_field_incomplete))
14321       return ExprError();
14322     if (FieldName)
14323       return Diag(FieldLoc, diag::err_not_integral_type_bitfield)
14324         << FieldName << FieldTy << BitWidth->getSourceRange();
14325     return Diag(FieldLoc, diag::err_not_integral_type_anon_bitfield)
14326       << FieldTy << BitWidth->getSourceRange();
14327   } else if (DiagnoseUnexpandedParameterPack(const_cast<Expr *>(BitWidth),
14328                                              UPPC_BitFieldWidth))
14329     return ExprError();
14330 
14331   // If the bit-width is type- or value-dependent, don't try to check
14332   // it now.
14333   if (BitWidth->isValueDependent() || BitWidth->isTypeDependent())
14334     return BitWidth;
14335 
14336   llvm::APSInt Value;
14337   ExprResult ICE = VerifyIntegerConstantExpression(BitWidth, &Value);
14338   if (ICE.isInvalid())
14339     return ICE;
14340   BitWidth = ICE.get();
14341 
14342   if (Value != 0 && ZeroWidth)
14343     *ZeroWidth = false;
14344 
14345   // Zero-width bitfield is ok for anonymous field.
14346   if (Value == 0 && FieldName)
14347     return Diag(FieldLoc, diag::err_bitfield_has_zero_width) << FieldName;
14348 
14349   if (Value.isSigned() && Value.isNegative()) {
14350     if (FieldName)
14351       return Diag(FieldLoc, diag::err_bitfield_has_negative_width)
14352                << FieldName << Value.toString(10);
14353     return Diag(FieldLoc, diag::err_anon_bitfield_has_negative_width)
14354       << Value.toString(10);
14355   }
14356 
14357   if (!FieldTy->isDependentType()) {
14358     uint64_t TypeStorageSize = Context.getTypeSize(FieldTy);
14359     uint64_t TypeWidth = Context.getIntWidth(FieldTy);
14360     bool BitfieldIsOverwide = Value.ugt(TypeWidth);
14361 
14362     // Over-wide bitfields are an error in C or when using the MSVC bitfield
14363     // ABI.
14364     bool CStdConstraintViolation =
14365         BitfieldIsOverwide && !getLangOpts().CPlusPlus;
14366     bool MSBitfieldViolation =
14367         Value.ugt(TypeStorageSize) &&
14368         (IsMsStruct || Context.getTargetInfo().getCXXABI().isMicrosoft());
14369     if (CStdConstraintViolation || MSBitfieldViolation) {
14370       unsigned DiagWidth =
14371           CStdConstraintViolation ? TypeWidth : TypeStorageSize;
14372       if (FieldName)
14373         return Diag(FieldLoc, diag::err_bitfield_width_exceeds_type_width)
14374                << FieldName << (unsigned)Value.getZExtValue()
14375                << !CStdConstraintViolation << DiagWidth;
14376 
14377       return Diag(FieldLoc, diag::err_anon_bitfield_width_exceeds_type_width)
14378              << (unsigned)Value.getZExtValue() << !CStdConstraintViolation
14379              << DiagWidth;
14380     }
14381 
14382     // Warn on types where the user might conceivably expect to get all
14383     // specified bits as value bits: that's all integral types other than
14384     // 'bool'.
14385     if (BitfieldIsOverwide && !FieldTy->isBooleanType()) {
14386       if (FieldName)
14387         Diag(FieldLoc, diag::warn_bitfield_width_exceeds_type_width)
14388             << FieldName << (unsigned)Value.getZExtValue()
14389             << (unsigned)TypeWidth;
14390       else
14391         Diag(FieldLoc, diag::warn_anon_bitfield_width_exceeds_type_width)
14392             << (unsigned)Value.getZExtValue() << (unsigned)TypeWidth;
14393     }
14394   }
14395 
14396   return BitWidth;
14397 }
14398 
14399 /// ActOnField - Each field of a C struct/union is passed into this in order
14400 /// to create a FieldDecl object for it.
14401 Decl *Sema::ActOnField(Scope *S, Decl *TagD, SourceLocation DeclStart,
14402                        Declarator &D, Expr *BitfieldWidth) {
14403   FieldDecl *Res = HandleField(S, cast_or_null<RecordDecl>(TagD),
14404                                DeclStart, D, static_cast<Expr*>(BitfieldWidth),
14405                                /*InitStyle=*/ICIS_NoInit, AS_public);
14406   return Res;
14407 }
14408 
14409 /// HandleField - Analyze a field of a C struct or a C++ data member.
14410 ///
14411 FieldDecl *Sema::HandleField(Scope *S, RecordDecl *Record,
14412                              SourceLocation DeclStart,
14413                              Declarator &D, Expr *BitWidth,
14414                              InClassInitStyle InitStyle,
14415                              AccessSpecifier AS) {
14416   if (D.isDecompositionDeclarator()) {
14417     const DecompositionDeclarator &Decomp = D.getDecompositionDeclarator();
14418     Diag(Decomp.getLSquareLoc(), diag::err_decomp_decl_context)
14419       << Decomp.getSourceRange();
14420     return nullptr;
14421   }
14422 
14423   IdentifierInfo *II = D.getIdentifier();
14424   SourceLocation Loc = DeclStart;
14425   if (II) Loc = D.getIdentifierLoc();
14426 
14427   TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
14428   QualType T = TInfo->getType();
14429   if (getLangOpts().CPlusPlus) {
14430     CheckExtraCXXDefaultArguments(D);
14431 
14432     if (DiagnoseUnexpandedParameterPack(D.getIdentifierLoc(), TInfo,
14433                                         UPPC_DataMemberType)) {
14434       D.setInvalidType();
14435       T = Context.IntTy;
14436       TInfo = Context.getTrivialTypeSourceInfo(T, Loc);
14437     }
14438   }
14439 
14440   // TR 18037 does not allow fields to be declared with address spaces.
14441   if (T.getQualifiers().hasAddressSpace() ||
14442       T->isDependentAddressSpaceType() ||
14443       T->getBaseElementTypeUnsafe()->isDependentAddressSpaceType()) {
14444     Diag(Loc, diag::err_field_with_address_space);
14445     D.setInvalidType();
14446   }
14447 
14448   // OpenCL v1.2 s6.9b,r & OpenCL v2.0 s6.12.5 - The following types cannot be
14449   // used as structure or union field: image, sampler, event or block types.
14450   if (LangOpts.OpenCL && (T->isEventT() || T->isImageType() ||
14451                           T->isSamplerT() || T->isBlockPointerType())) {
14452     Diag(Loc, diag::err_opencl_type_struct_or_union_field) << T;
14453     D.setInvalidType();
14454   }
14455 
14456   DiagnoseFunctionSpecifiers(D.getDeclSpec());
14457 
14458   if (D.getDeclSpec().isInlineSpecified())
14459     Diag(D.getDeclSpec().getInlineSpecLoc(), diag::err_inline_non_function)
14460         << getLangOpts().CPlusPlus1z;
14461   if (DeclSpec::TSCS TSCS = D.getDeclSpec().getThreadStorageClassSpec())
14462     Diag(D.getDeclSpec().getThreadStorageClassSpecLoc(),
14463          diag::err_invalid_thread)
14464       << DeclSpec::getSpecifierName(TSCS);
14465 
14466   // Check to see if this name was declared as a member previously
14467   NamedDecl *PrevDecl = nullptr;
14468   LookupResult Previous(*this, II, Loc, LookupMemberName,
14469                         ForVisibleRedeclaration);
14470   LookupName(Previous, S);
14471   switch (Previous.getResultKind()) {
14472     case LookupResult::Found:
14473     case LookupResult::FoundUnresolvedValue:
14474       PrevDecl = Previous.getAsSingle<NamedDecl>();
14475       break;
14476 
14477     case LookupResult::FoundOverloaded:
14478       PrevDecl = Previous.getRepresentativeDecl();
14479       break;
14480 
14481     case LookupResult::NotFound:
14482     case LookupResult::NotFoundInCurrentInstantiation:
14483     case LookupResult::Ambiguous:
14484       break;
14485   }
14486   Previous.suppressDiagnostics();
14487 
14488   if (PrevDecl && PrevDecl->isTemplateParameter()) {
14489     // Maybe we will complain about the shadowed template parameter.
14490     DiagnoseTemplateParameterShadow(D.getIdentifierLoc(), PrevDecl);
14491     // Just pretend that we didn't see the previous declaration.
14492     PrevDecl = nullptr;
14493   }
14494 
14495   if (PrevDecl && !isDeclInScope(PrevDecl, Record, S))
14496     PrevDecl = nullptr;
14497 
14498   bool Mutable
14499     = (D.getDeclSpec().getStorageClassSpec() == DeclSpec::SCS_mutable);
14500   SourceLocation TSSL = D.getLocStart();
14501   FieldDecl *NewFD
14502     = CheckFieldDecl(II, T, TInfo, Record, Loc, Mutable, BitWidth, InitStyle,
14503                      TSSL, AS, PrevDecl, &D);
14504 
14505   if (NewFD->isInvalidDecl())
14506     Record->setInvalidDecl();
14507 
14508   if (D.getDeclSpec().isModulePrivateSpecified())
14509     NewFD->setModulePrivate();
14510 
14511   if (NewFD->isInvalidDecl() && PrevDecl) {
14512     // Don't introduce NewFD into scope; there's already something
14513     // with the same name in the same scope.
14514   } else if (II) {
14515     PushOnScopeChains(NewFD, S);
14516   } else
14517     Record->addDecl(NewFD);
14518 
14519   return NewFD;
14520 }
14521 
14522 /// \brief Build a new FieldDecl and check its well-formedness.
14523 ///
14524 /// This routine builds a new FieldDecl given the fields name, type,
14525 /// record, etc. \p PrevDecl should refer to any previous declaration
14526 /// with the same name and in the same scope as the field to be
14527 /// created.
14528 ///
14529 /// \returns a new FieldDecl.
14530 ///
14531 /// \todo The Declarator argument is a hack. It will be removed once
14532 FieldDecl *Sema::CheckFieldDecl(DeclarationName Name, QualType T,
14533                                 TypeSourceInfo *TInfo,
14534                                 RecordDecl *Record, SourceLocation Loc,
14535                                 bool Mutable, Expr *BitWidth,
14536                                 InClassInitStyle InitStyle,
14537                                 SourceLocation TSSL,
14538                                 AccessSpecifier AS, NamedDecl *PrevDecl,
14539                                 Declarator *D) {
14540   IdentifierInfo *II = Name.getAsIdentifierInfo();
14541   bool InvalidDecl = false;
14542   if (D) InvalidDecl = D->isInvalidType();
14543 
14544   // If we receive a broken type, recover by assuming 'int' and
14545   // marking this declaration as invalid.
14546   if (T.isNull()) {
14547     InvalidDecl = true;
14548     T = Context.IntTy;
14549   }
14550 
14551   QualType EltTy = Context.getBaseElementType(T);
14552   if (!EltTy->isDependentType()) {
14553     if (RequireCompleteType(Loc, EltTy, diag::err_field_incomplete)) {
14554       // Fields of incomplete type force their record to be invalid.
14555       Record->setInvalidDecl();
14556       InvalidDecl = true;
14557     } else {
14558       NamedDecl *Def;
14559       EltTy->isIncompleteType(&Def);
14560       if (Def && Def->isInvalidDecl()) {
14561         Record->setInvalidDecl();
14562         InvalidDecl = true;
14563       }
14564     }
14565   }
14566 
14567   // OpenCL v1.2 s6.9.c: bitfields are not supported.
14568   if (BitWidth && getLangOpts().OpenCL) {
14569     Diag(Loc, diag::err_opencl_bitfields);
14570     InvalidDecl = true;
14571   }
14572 
14573   // C99 6.7.2.1p8: A member of a structure or union may have any type other
14574   // than a variably modified type.
14575   if (!InvalidDecl && T->isVariablyModifiedType()) {
14576     bool SizeIsNegative;
14577     llvm::APSInt Oversized;
14578 
14579     TypeSourceInfo *FixedTInfo =
14580       TryToFixInvalidVariablyModifiedTypeSourceInfo(TInfo, Context,
14581                                                     SizeIsNegative,
14582                                                     Oversized);
14583     if (FixedTInfo) {
14584       Diag(Loc, diag::warn_illegal_constant_array_size);
14585       TInfo = FixedTInfo;
14586       T = FixedTInfo->getType();
14587     } else {
14588       if (SizeIsNegative)
14589         Diag(Loc, diag::err_typecheck_negative_array_size);
14590       else if (Oversized.getBoolValue())
14591         Diag(Loc, diag::err_array_too_large)
14592           << Oversized.toString(10);
14593       else
14594         Diag(Loc, diag::err_typecheck_field_variable_size);
14595       InvalidDecl = true;
14596     }
14597   }
14598 
14599   // Fields can not have abstract class types
14600   if (!InvalidDecl && RequireNonAbstractType(Loc, T,
14601                                              diag::err_abstract_type_in_decl,
14602                                              AbstractFieldType))
14603     InvalidDecl = true;
14604 
14605   bool ZeroWidth = false;
14606   if (InvalidDecl)
14607     BitWidth = nullptr;
14608   // If this is declared as a bit-field, check the bit-field.
14609   if (BitWidth) {
14610     BitWidth = VerifyBitField(Loc, II, T, Record->isMsStruct(Context), BitWidth,
14611                               &ZeroWidth).get();
14612     if (!BitWidth) {
14613       InvalidDecl = true;
14614       BitWidth = nullptr;
14615       ZeroWidth = false;
14616     }
14617   }
14618 
14619   // Check that 'mutable' is consistent with the type of the declaration.
14620   if (!InvalidDecl && Mutable) {
14621     unsigned DiagID = 0;
14622     if (T->isReferenceType())
14623       DiagID = getLangOpts().MSVCCompat ? diag::ext_mutable_reference
14624                                         : diag::err_mutable_reference;
14625     else if (T.isConstQualified())
14626       DiagID = diag::err_mutable_const;
14627 
14628     if (DiagID) {
14629       SourceLocation ErrLoc = Loc;
14630       if (D && D->getDeclSpec().getStorageClassSpecLoc().isValid())
14631         ErrLoc = D->getDeclSpec().getStorageClassSpecLoc();
14632       Diag(ErrLoc, DiagID);
14633       if (DiagID != diag::ext_mutable_reference) {
14634         Mutable = false;
14635         InvalidDecl = true;
14636       }
14637     }
14638   }
14639 
14640   // C++11 [class.union]p8 (DR1460):
14641   //   At most one variant member of a union may have a
14642   //   brace-or-equal-initializer.
14643   if (InitStyle != ICIS_NoInit)
14644     checkDuplicateDefaultInit(*this, cast<CXXRecordDecl>(Record), Loc);
14645 
14646   FieldDecl *NewFD = FieldDecl::Create(Context, Record, TSSL, Loc, II, T, TInfo,
14647                                        BitWidth, Mutable, InitStyle);
14648   if (InvalidDecl)
14649     NewFD->setInvalidDecl();
14650 
14651   if (PrevDecl && !isa<TagDecl>(PrevDecl)) {
14652     Diag(Loc, diag::err_duplicate_member) << II;
14653     Diag(PrevDecl->getLocation(), diag::note_previous_declaration);
14654     NewFD->setInvalidDecl();
14655   }
14656 
14657   if (!InvalidDecl && getLangOpts().CPlusPlus) {
14658     if (Record->isUnion()) {
14659       if (const RecordType *RT = EltTy->getAs<RecordType>()) {
14660         CXXRecordDecl* RDecl = cast<CXXRecordDecl>(RT->getDecl());
14661         if (RDecl->getDefinition()) {
14662           // C++ [class.union]p1: An object of a class with a non-trivial
14663           // constructor, a non-trivial copy constructor, a non-trivial
14664           // destructor, or a non-trivial copy assignment operator
14665           // cannot be a member of a union, nor can an array of such
14666           // objects.
14667           if (CheckNontrivialField(NewFD))
14668             NewFD->setInvalidDecl();
14669         }
14670       }
14671 
14672       // C++ [class.union]p1: If a union contains a member of reference type,
14673       // the program is ill-formed, except when compiling with MSVC extensions
14674       // enabled.
14675       if (EltTy->isReferenceType()) {
14676         Diag(NewFD->getLocation(), getLangOpts().MicrosoftExt ?
14677                                     diag::ext_union_member_of_reference_type :
14678                                     diag::err_union_member_of_reference_type)
14679           << NewFD->getDeclName() << EltTy;
14680         if (!getLangOpts().MicrosoftExt)
14681           NewFD->setInvalidDecl();
14682       }
14683     }
14684   }
14685 
14686   // FIXME: We need to pass in the attributes given an AST
14687   // representation, not a parser representation.
14688   if (D) {
14689     // FIXME: The current scope is almost... but not entirely... correct here.
14690     ProcessDeclAttributes(getCurScope(), NewFD, *D);
14691 
14692     if (NewFD->hasAttrs())
14693       CheckAlignasUnderalignment(NewFD);
14694   }
14695 
14696   // In auto-retain/release, infer strong retension for fields of
14697   // retainable type.
14698   if (getLangOpts().ObjCAutoRefCount && inferObjCARCLifetime(NewFD))
14699     NewFD->setInvalidDecl();
14700 
14701   if (T.isObjCGCWeak())
14702     Diag(Loc, diag::warn_attribute_weak_on_field);
14703 
14704   NewFD->setAccess(AS);
14705   return NewFD;
14706 }
14707 
14708 bool Sema::CheckNontrivialField(FieldDecl *FD) {
14709   assert(FD);
14710   assert(getLangOpts().CPlusPlus && "valid check only for C++");
14711 
14712   if (FD->isInvalidDecl() || FD->getType()->isDependentType())
14713     return false;
14714 
14715   QualType EltTy = Context.getBaseElementType(FD->getType());
14716   if (const RecordType *RT = EltTy->getAs<RecordType>()) {
14717     CXXRecordDecl *RDecl = cast<CXXRecordDecl>(RT->getDecl());
14718     if (RDecl->getDefinition()) {
14719       // We check for copy constructors before constructors
14720       // because otherwise we'll never get complaints about
14721       // copy constructors.
14722 
14723       CXXSpecialMember member = CXXInvalid;
14724       // We're required to check for any non-trivial constructors. Since the
14725       // implicit default constructor is suppressed if there are any
14726       // user-declared constructors, we just need to check that there is a
14727       // trivial default constructor and a trivial copy constructor. (We don't
14728       // worry about move constructors here, since this is a C++98 check.)
14729       if (RDecl->hasNonTrivialCopyConstructor())
14730         member = CXXCopyConstructor;
14731       else if (!RDecl->hasTrivialDefaultConstructor())
14732         member = CXXDefaultConstructor;
14733       else if (RDecl->hasNonTrivialCopyAssignment())
14734         member = CXXCopyAssignment;
14735       else if (RDecl->hasNonTrivialDestructor())
14736         member = CXXDestructor;
14737 
14738       if (member != CXXInvalid) {
14739         if (!getLangOpts().CPlusPlus11 &&
14740             getLangOpts().ObjCAutoRefCount && RDecl->hasObjectMember()) {
14741           // Objective-C++ ARC: it is an error to have a non-trivial field of
14742           // a union. However, system headers in Objective-C programs
14743           // occasionally have Objective-C lifetime objects within unions,
14744           // and rather than cause the program to fail, we make those
14745           // members unavailable.
14746           SourceLocation Loc = FD->getLocation();
14747           if (getSourceManager().isInSystemHeader(Loc)) {
14748             if (!FD->hasAttr<UnavailableAttr>())
14749               FD->addAttr(UnavailableAttr::CreateImplicit(Context, "",
14750                             UnavailableAttr::IR_ARCFieldWithOwnership, Loc));
14751             return false;
14752           }
14753         }
14754 
14755         Diag(FD->getLocation(), getLangOpts().CPlusPlus11 ?
14756                diag::warn_cxx98_compat_nontrivial_union_or_anon_struct_member :
14757                diag::err_illegal_union_or_anon_struct_member)
14758           << FD->getParent()->isUnion() << FD->getDeclName() << member;
14759         DiagnoseNontrivial(RDecl, member);
14760         return !getLangOpts().CPlusPlus11;
14761       }
14762     }
14763   }
14764 
14765   return false;
14766 }
14767 
14768 /// TranslateIvarVisibility - Translate visibility from a token ID to an
14769 ///  AST enum value.
14770 static ObjCIvarDecl::AccessControl
14771 TranslateIvarVisibility(tok::ObjCKeywordKind ivarVisibility) {
14772   switch (ivarVisibility) {
14773   default: llvm_unreachable("Unknown visitibility kind");
14774   case tok::objc_private: return ObjCIvarDecl::Private;
14775   case tok::objc_public: return ObjCIvarDecl::Public;
14776   case tok::objc_protected: return ObjCIvarDecl::Protected;
14777   case tok::objc_package: return ObjCIvarDecl::Package;
14778   }
14779 }
14780 
14781 /// ActOnIvar - Each ivar field of an objective-c class is passed into this
14782 /// in order to create an IvarDecl object for it.
14783 Decl *Sema::ActOnIvar(Scope *S,
14784                                 SourceLocation DeclStart,
14785                                 Declarator &D, Expr *BitfieldWidth,
14786                                 tok::ObjCKeywordKind Visibility) {
14787 
14788   IdentifierInfo *II = D.getIdentifier();
14789   Expr *BitWidth = (Expr*)BitfieldWidth;
14790   SourceLocation Loc = DeclStart;
14791   if (II) Loc = D.getIdentifierLoc();
14792 
14793   // FIXME: Unnamed fields can be handled in various different ways, for
14794   // example, unnamed unions inject all members into the struct namespace!
14795 
14796   TypeSourceInfo *TInfo = GetTypeForDeclarator(D, S);
14797   QualType T = TInfo->getType();
14798 
14799   if (BitWidth) {
14800     // 6.7.2.1p3, 6.7.2.1p4
14801     BitWidth = VerifyBitField(Loc, II, T, /*IsMsStruct*/false, BitWidth).get();
14802     if (!BitWidth)
14803       D.setInvalidType();
14804   } else {
14805     // Not a bitfield.
14806 
14807     // validate II.
14808 
14809   }
14810   if (T->isReferenceType()) {
14811     Diag(Loc, diag::err_ivar_reference_type);
14812     D.setInvalidType();
14813   }
14814   // C99 6.7.2.1p8: A member of a structure or union may have any type other
14815   // than a variably modified type.
14816   else if (T->isVariablyModifiedType()) {
14817     Diag(Loc, diag::err_typecheck_ivar_variable_size);
14818     D.setInvalidType();
14819   }
14820 
14821   // Get the visibility (access control) for this ivar.
14822   ObjCIvarDecl::AccessControl ac =
14823     Visibility != tok::objc_not_keyword ? TranslateIvarVisibility(Visibility)
14824                                         : ObjCIvarDecl::None;
14825   // Must set ivar's DeclContext to its enclosing interface.
14826   ObjCContainerDecl *EnclosingDecl = cast<ObjCContainerDecl>(CurContext);
14827   if (!EnclosingDecl || EnclosingDecl->isInvalidDecl())
14828     return nullptr;
14829   ObjCContainerDecl *EnclosingContext;
14830   if (ObjCImplementationDecl *IMPDecl =
14831       dyn_cast<ObjCImplementationDecl>(EnclosingDecl)) {
14832     if (LangOpts.ObjCRuntime.isFragile()) {
14833     // Case of ivar declared in an implementation. Context is that of its class.
14834       EnclosingContext = IMPDecl->getClassInterface();
14835       assert(EnclosingContext && "Implementation has no class interface!");
14836     }
14837     else
14838       EnclosingContext = EnclosingDecl;
14839   } else {
14840     if (ObjCCategoryDecl *CDecl =
14841         dyn_cast<ObjCCategoryDecl>(EnclosingDecl)) {
14842       if (LangOpts.ObjCRuntime.isFragile() || !CDecl->IsClassExtension()) {
14843         Diag(Loc, diag::err_misplaced_ivar) << CDecl->IsClassExtension();
14844         return nullptr;
14845       }
14846     }
14847     EnclosingContext = EnclosingDecl;
14848   }
14849 
14850   // Construct the decl.
14851   ObjCIvarDecl *NewID = ObjCIvarDecl::Create(Context, EnclosingContext,
14852                                              DeclStart, Loc, II, T,
14853                                              TInfo, ac, (Expr *)BitfieldWidth);
14854 
14855   if (II) {
14856     NamedDecl *PrevDecl = LookupSingleName(S, II, Loc, LookupMemberName,
14857                                            ForVisibleRedeclaration);
14858     if (PrevDecl && isDeclInScope(PrevDecl, EnclosingContext, S)
14859         && !isa<TagDecl>(PrevDecl)) {
14860       Diag(Loc, diag::err_duplicate_member) << II;
14861       Diag(PrevDecl->getLocation(), diag::note_previous_declaration);
14862       NewID->setInvalidDecl();
14863     }
14864   }
14865 
14866   // Process attributes attached to the ivar.
14867   ProcessDeclAttributes(S, NewID, D);
14868 
14869   if (D.isInvalidType())
14870     NewID->setInvalidDecl();
14871 
14872   // In ARC, infer 'retaining' for ivars of retainable type.
14873   if (getLangOpts().ObjCAutoRefCount && inferObjCARCLifetime(NewID))
14874     NewID->setInvalidDecl();
14875 
14876   if (D.getDeclSpec().isModulePrivateSpecified())
14877     NewID->setModulePrivate();
14878 
14879   if (II) {
14880     // FIXME: When interfaces are DeclContexts, we'll need to add
14881     // these to the interface.
14882     S->AddDecl(NewID);
14883     IdResolver.AddDecl(NewID);
14884   }
14885 
14886   if (LangOpts.ObjCRuntime.isNonFragile() &&
14887       !NewID->isInvalidDecl() && isa<ObjCInterfaceDecl>(EnclosingDecl))
14888     Diag(Loc, diag::warn_ivars_in_interface);
14889 
14890   return NewID;
14891 }
14892 
14893 /// ActOnLastBitfield - This routine handles synthesized bitfields rules for
14894 /// class and class extensions. For every class \@interface and class
14895 /// extension \@interface, if the last ivar is a bitfield of any type,
14896 /// then add an implicit `char :0` ivar to the end of that interface.
14897 void Sema::ActOnLastBitfield(SourceLocation DeclLoc,
14898                              SmallVectorImpl<Decl *> &AllIvarDecls) {
14899   if (LangOpts.ObjCRuntime.isFragile() || AllIvarDecls.empty())
14900     return;
14901 
14902   Decl *ivarDecl = AllIvarDecls[AllIvarDecls.size()-1];
14903   ObjCIvarDecl *Ivar = cast<ObjCIvarDecl>(ivarDecl);
14904 
14905   if (!Ivar->isBitField() || Ivar->getBitWidthValue(Context) == 0)
14906     return;
14907   ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(CurContext);
14908   if (!ID) {
14909     if (ObjCCategoryDecl *CD = dyn_cast<ObjCCategoryDecl>(CurContext)) {
14910       if (!CD->IsClassExtension())
14911         return;
14912     }
14913     // No need to add this to end of @implementation.
14914     else
14915       return;
14916   }
14917   // All conditions are met. Add a new bitfield to the tail end of ivars.
14918   llvm::APInt Zero(Context.getTypeSize(Context.IntTy), 0);
14919   Expr * BW = IntegerLiteral::Create(Context, Zero, Context.IntTy, DeclLoc);
14920 
14921   Ivar = ObjCIvarDecl::Create(Context, cast<ObjCContainerDecl>(CurContext),
14922                               DeclLoc, DeclLoc, nullptr,
14923                               Context.CharTy,
14924                               Context.getTrivialTypeSourceInfo(Context.CharTy,
14925                                                                DeclLoc),
14926                               ObjCIvarDecl::Private, BW,
14927                               true);
14928   AllIvarDecls.push_back(Ivar);
14929 }
14930 
14931 void Sema::ActOnFields(Scope *S, SourceLocation RecLoc, Decl *EnclosingDecl,
14932                        ArrayRef<Decl *> Fields, SourceLocation LBrac,
14933                        SourceLocation RBrac, AttributeList *Attr) {
14934   assert(EnclosingDecl && "missing record or interface decl");
14935 
14936   // If this is an Objective-C @implementation or category and we have
14937   // new fields here we should reset the layout of the interface since
14938   // it will now change.
14939   if (!Fields.empty() && isa<ObjCContainerDecl>(EnclosingDecl)) {
14940     ObjCContainerDecl *DC = cast<ObjCContainerDecl>(EnclosingDecl);
14941     switch (DC->getKind()) {
14942     default: break;
14943     case Decl::ObjCCategory:
14944       Context.ResetObjCLayout(cast<ObjCCategoryDecl>(DC)->getClassInterface());
14945       break;
14946     case Decl::ObjCImplementation:
14947       Context.
14948         ResetObjCLayout(cast<ObjCImplementationDecl>(DC)->getClassInterface());
14949       break;
14950     }
14951   }
14952 
14953   RecordDecl *Record = dyn_cast<RecordDecl>(EnclosingDecl);
14954 
14955   // Start counting up the number of named members; make sure to include
14956   // members of anonymous structs and unions in the total.
14957   unsigned NumNamedMembers = 0;
14958   if (Record) {
14959     for (const auto *I : Record->decls()) {
14960       if (const auto *IFD = dyn_cast<IndirectFieldDecl>(I))
14961         if (IFD->getDeclName())
14962           ++NumNamedMembers;
14963     }
14964   }
14965 
14966   // Verify that all the fields are okay.
14967   SmallVector<FieldDecl*, 32> RecFields;
14968 
14969   bool ObjCFieldLifetimeErrReported = false;
14970   for (ArrayRef<Decl *>::iterator i = Fields.begin(), end = Fields.end();
14971        i != end; ++i) {
14972     FieldDecl *FD = cast<FieldDecl>(*i);
14973 
14974     // Get the type for the field.
14975     const Type *FDTy = FD->getType().getTypePtr();
14976 
14977     if (!FD->isAnonymousStructOrUnion()) {
14978       // Remember all fields written by the user.
14979       RecFields.push_back(FD);
14980     }
14981 
14982     // If the field is already invalid for some reason, don't emit more
14983     // diagnostics about it.
14984     if (FD->isInvalidDecl()) {
14985       EnclosingDecl->setInvalidDecl();
14986       continue;
14987     }
14988 
14989     // C99 6.7.2.1p2:
14990     //   A structure or union shall not contain a member with
14991     //   incomplete or function type (hence, a structure shall not
14992     //   contain an instance of itself, but may contain a pointer to
14993     //   an instance of itself), except that the last member of a
14994     //   structure with more than one named member may have incomplete
14995     //   array type; such a structure (and any union containing,
14996     //   possibly recursively, a member that is such a structure)
14997     //   shall not be a member of a structure or an element of an
14998     //   array.
14999     if (FDTy->isFunctionType()) {
15000       // Field declared as a function.
15001       Diag(FD->getLocation(), diag::err_field_declared_as_function)
15002         << FD->getDeclName();
15003       FD->setInvalidDecl();
15004       EnclosingDecl->setInvalidDecl();
15005       continue;
15006     } else if (FDTy->isIncompleteArrayType() && Record &&
15007                ((i + 1 == Fields.end() && !Record->isUnion()) ||
15008                 ((getLangOpts().MicrosoftExt ||
15009                   getLangOpts().CPlusPlus) &&
15010                  (i + 1 == Fields.end() || Record->isUnion())))) {
15011       // Flexible array member.
15012       // Microsoft and g++ is more permissive regarding flexible array.
15013       // It will accept flexible array in union and also
15014       // as the sole element of a struct/class.
15015       unsigned DiagID = 0;
15016       if (Record->isUnion())
15017         DiagID = getLangOpts().MicrosoftExt
15018                      ? diag::ext_flexible_array_union_ms
15019                      : getLangOpts().CPlusPlus
15020                            ? diag::ext_flexible_array_union_gnu
15021                            : diag::err_flexible_array_union;
15022       else if (NumNamedMembers < 1)
15023         DiagID = getLangOpts().MicrosoftExt
15024                      ? diag::ext_flexible_array_empty_aggregate_ms
15025                      : getLangOpts().CPlusPlus
15026                            ? diag::ext_flexible_array_empty_aggregate_gnu
15027                            : diag::err_flexible_array_empty_aggregate;
15028 
15029       if (DiagID)
15030         Diag(FD->getLocation(), DiagID) << FD->getDeclName()
15031                                         << Record->getTagKind();
15032       // While the layout of types that contain virtual bases is not specified
15033       // by the C++ standard, both the Itanium and Microsoft C++ ABIs place
15034       // virtual bases after the derived members.  This would make a flexible
15035       // array member declared at the end of an object not adjacent to the end
15036       // of the type.
15037       if (CXXRecordDecl *RD = dyn_cast<CXXRecordDecl>(Record))
15038         if (RD->getNumVBases() != 0)
15039           Diag(FD->getLocation(), diag::err_flexible_array_virtual_base)
15040             << FD->getDeclName() << Record->getTagKind();
15041       if (!getLangOpts().C99)
15042         Diag(FD->getLocation(), diag::ext_c99_flexible_array_member)
15043           << FD->getDeclName() << Record->getTagKind();
15044 
15045       // If the element type has a non-trivial destructor, we would not
15046       // implicitly destroy the elements, so disallow it for now.
15047       //
15048       // FIXME: GCC allows this. We should probably either implicitly delete
15049       // the destructor of the containing class, or just allow this.
15050       QualType BaseElem = Context.getBaseElementType(FD->getType());
15051       if (!BaseElem->isDependentType() && BaseElem.isDestructedType()) {
15052         Diag(FD->getLocation(), diag::err_flexible_array_has_nontrivial_dtor)
15053           << FD->getDeclName() << FD->getType();
15054         FD->setInvalidDecl();
15055         EnclosingDecl->setInvalidDecl();
15056         continue;
15057       }
15058       // Okay, we have a legal flexible array member at the end of the struct.
15059       Record->setHasFlexibleArrayMember(true);
15060     } else if (!FDTy->isDependentType() &&
15061                RequireCompleteType(FD->getLocation(), FD->getType(),
15062                                    diag::err_field_incomplete)) {
15063       // Incomplete type
15064       FD->setInvalidDecl();
15065       EnclosingDecl->setInvalidDecl();
15066       continue;
15067     } else if (const RecordType *FDTTy = FDTy->getAs<RecordType>()) {
15068       if (Record && FDTTy->getDecl()->hasFlexibleArrayMember()) {
15069         // A type which contains a flexible array member is considered to be a
15070         // flexible array member.
15071         Record->setHasFlexibleArrayMember(true);
15072         if (!Record->isUnion()) {
15073           // If this is a struct/class and this is not the last element, reject
15074           // it.  Note that GCC supports variable sized arrays in the middle of
15075           // structures.
15076           if (i + 1 != Fields.end())
15077             Diag(FD->getLocation(), diag::ext_variable_sized_type_in_struct)
15078               << FD->getDeclName() << FD->getType();
15079           else {
15080             // We support flexible arrays at the end of structs in
15081             // other structs as an extension.
15082             Diag(FD->getLocation(), diag::ext_flexible_array_in_struct)
15083               << FD->getDeclName();
15084           }
15085         }
15086       }
15087       if (isa<ObjCContainerDecl>(EnclosingDecl) &&
15088           RequireNonAbstractType(FD->getLocation(), FD->getType(),
15089                                  diag::err_abstract_type_in_decl,
15090                                  AbstractIvarType)) {
15091         // Ivars can not have abstract class types
15092         FD->setInvalidDecl();
15093       }
15094       if (Record && FDTTy->getDecl()->hasObjectMember())
15095         Record->setHasObjectMember(true);
15096       if (Record && FDTTy->getDecl()->hasVolatileMember())
15097         Record->setHasVolatileMember(true);
15098     } else if (FDTy->isObjCObjectType()) {
15099       /// A field cannot be an Objective-c object
15100       Diag(FD->getLocation(), diag::err_statically_allocated_object)
15101         << FixItHint::CreateInsertion(FD->getLocation(), "*");
15102       QualType T = Context.getObjCObjectPointerType(FD->getType());
15103       FD->setType(T);
15104     } else if (getLangOpts().allowsNonTrivialObjCLifetimeQualifiers() &&
15105                Record && !ObjCFieldLifetimeErrReported &&
15106                (!getLangOpts().CPlusPlus || Record->isUnion())) {
15107       // It's an error in ARC or Weak if a field has lifetime.
15108       // We don't want to report this in a system header, though,
15109       // so we just make the field unavailable.
15110       // FIXME: that's really not sufficient; we need to make the type
15111       // itself invalid to, say, initialize or copy.
15112       QualType T = FD->getType();
15113       if (T.hasNonTrivialObjCLifetime()) {
15114         SourceLocation loc = FD->getLocation();
15115         if (getSourceManager().isInSystemHeader(loc)) {
15116           if (!FD->hasAttr<UnavailableAttr>()) {
15117             FD->addAttr(UnavailableAttr::CreateImplicit(Context, "",
15118                           UnavailableAttr::IR_ARCFieldWithOwnership, loc));
15119           }
15120         } else {
15121           Diag(FD->getLocation(), diag::err_arc_objc_object_in_tag)
15122             << T->isBlockPointerType() << Record->getTagKind();
15123         }
15124         ObjCFieldLifetimeErrReported = true;
15125       }
15126     } else if (getLangOpts().ObjC1 &&
15127                getLangOpts().getGC() != LangOptions::NonGC &&
15128                Record && !Record->hasObjectMember()) {
15129       if (FD->getType()->isObjCObjectPointerType() ||
15130           FD->getType().isObjCGCStrong())
15131         Record->setHasObjectMember(true);
15132       else if (Context.getAsArrayType(FD->getType())) {
15133         QualType BaseType = Context.getBaseElementType(FD->getType());
15134         if (BaseType->isRecordType() &&
15135             BaseType->getAs<RecordType>()->getDecl()->hasObjectMember())
15136           Record->setHasObjectMember(true);
15137         else if (BaseType->isObjCObjectPointerType() ||
15138                  BaseType.isObjCGCStrong())
15139                Record->setHasObjectMember(true);
15140       }
15141     }
15142     if (Record && FD->getType().isVolatileQualified())
15143       Record->setHasVolatileMember(true);
15144     // Keep track of the number of named members.
15145     if (FD->getIdentifier())
15146       ++NumNamedMembers;
15147   }
15148 
15149   // Okay, we successfully defined 'Record'.
15150   if (Record) {
15151     bool Completed = false;
15152     if (CXXRecordDecl *CXXRecord = dyn_cast<CXXRecordDecl>(Record)) {
15153       if (!CXXRecord->isInvalidDecl()) {
15154         // Set access bits correctly on the directly-declared conversions.
15155         for (CXXRecordDecl::conversion_iterator
15156                I = CXXRecord->conversion_begin(),
15157                E = CXXRecord->conversion_end(); I != E; ++I)
15158           I.setAccess((*I)->getAccess());
15159       }
15160 
15161       if (!CXXRecord->isDependentType()) {
15162         if (CXXRecord->hasUserDeclaredDestructor()) {
15163           // Adjust user-defined destructor exception spec.
15164           if (getLangOpts().CPlusPlus11)
15165             AdjustDestructorExceptionSpec(CXXRecord,
15166                                           CXXRecord->getDestructor());
15167         }
15168 
15169         if (!CXXRecord->isInvalidDecl()) {
15170           // Add any implicitly-declared members to this class.
15171           AddImplicitlyDeclaredMembersToClass(CXXRecord);
15172 
15173           // If we have virtual base classes, we may end up finding multiple
15174           // final overriders for a given virtual function. Check for this
15175           // problem now.
15176           if (CXXRecord->getNumVBases()) {
15177             CXXFinalOverriderMap FinalOverriders;
15178             CXXRecord->getFinalOverriders(FinalOverriders);
15179 
15180             for (CXXFinalOverriderMap::iterator M = FinalOverriders.begin(),
15181                                              MEnd = FinalOverriders.end();
15182                  M != MEnd; ++M) {
15183               for (OverridingMethods::iterator SO = M->second.begin(),
15184                                             SOEnd = M->second.end();
15185                    SO != SOEnd; ++SO) {
15186                 assert(SO->second.size() > 0 &&
15187                        "Virtual function without overridding functions?");
15188                 if (SO->second.size() == 1)
15189                   continue;
15190 
15191                 // C++ [class.virtual]p2:
15192                 //   In a derived class, if a virtual member function of a base
15193                 //   class subobject has more than one final overrider the
15194                 //   program is ill-formed.
15195                 Diag(Record->getLocation(), diag::err_multiple_final_overriders)
15196                   << (const NamedDecl *)M->first << Record;
15197                 Diag(M->first->getLocation(),
15198                      diag::note_overridden_virtual_function);
15199                 for (OverridingMethods::overriding_iterator
15200                           OM = SO->second.begin(),
15201                        OMEnd = SO->second.end();
15202                      OM != OMEnd; ++OM)
15203                   Diag(OM->Method->getLocation(), diag::note_final_overrider)
15204                     << (const NamedDecl *)M->first << OM->Method->getParent();
15205 
15206                 Record->setInvalidDecl();
15207               }
15208             }
15209             CXXRecord->completeDefinition(&FinalOverriders);
15210             Completed = true;
15211           }
15212         }
15213       }
15214     }
15215 
15216     if (!Completed)
15217       Record->completeDefinition();
15218 
15219     // We may have deferred checking for a deleted destructor. Check now.
15220     if (CXXRecordDecl *CXXRecord = dyn_cast<CXXRecordDecl>(Record)) {
15221       auto *Dtor = CXXRecord->getDestructor();
15222       if (Dtor && Dtor->isImplicit() &&
15223           ShouldDeleteSpecialMember(Dtor, CXXDestructor)) {
15224         CXXRecord->setImplicitDestructorIsDeleted();
15225         SetDeclDeleted(Dtor, CXXRecord->getLocation());
15226       }
15227     }
15228 
15229     if (Record->hasAttrs()) {
15230       CheckAlignasUnderalignment(Record);
15231 
15232       if (const MSInheritanceAttr *IA = Record->getAttr<MSInheritanceAttr>())
15233         checkMSInheritanceAttrOnDefinition(cast<CXXRecordDecl>(Record),
15234                                            IA->getRange(), IA->getBestCase(),
15235                                            IA->getSemanticSpelling());
15236     }
15237 
15238     // Check if the structure/union declaration is a type that can have zero
15239     // size in C. For C this is a language extension, for C++ it may cause
15240     // compatibility problems.
15241     bool CheckForZeroSize;
15242     if (!getLangOpts().CPlusPlus) {
15243       CheckForZeroSize = true;
15244     } else {
15245       // For C++ filter out types that cannot be referenced in C code.
15246       CXXRecordDecl *CXXRecord = cast<CXXRecordDecl>(Record);
15247       CheckForZeroSize =
15248           CXXRecord->getLexicalDeclContext()->isExternCContext() &&
15249           !CXXRecord->isDependentType() &&
15250           CXXRecord->isCLike();
15251     }
15252     if (CheckForZeroSize) {
15253       bool ZeroSize = true;
15254       bool IsEmpty = true;
15255       unsigned NonBitFields = 0;
15256       for (RecordDecl::field_iterator I = Record->field_begin(),
15257                                       E = Record->field_end();
15258            (NonBitFields == 0 || ZeroSize) && I != E; ++I) {
15259         IsEmpty = false;
15260         if (I->isUnnamedBitfield()) {
15261           if (I->getBitWidthValue(Context) > 0)
15262             ZeroSize = false;
15263         } else {
15264           ++NonBitFields;
15265           QualType FieldType = I->getType();
15266           if (FieldType->isIncompleteType() ||
15267               !Context.getTypeSizeInChars(FieldType).isZero())
15268             ZeroSize = false;
15269         }
15270       }
15271 
15272       // Empty structs are an extension in C (C99 6.7.2.1p7). They are
15273       // allowed in C++, but warn if its declaration is inside
15274       // extern "C" block.
15275       if (ZeroSize) {
15276         Diag(RecLoc, getLangOpts().CPlusPlus ?
15277                          diag::warn_zero_size_struct_union_in_extern_c :
15278                          diag::warn_zero_size_struct_union_compat)
15279           << IsEmpty << Record->isUnion() << (NonBitFields > 1);
15280       }
15281 
15282       // Structs without named members are extension in C (C99 6.7.2.1p7),
15283       // but are accepted by GCC.
15284       if (NonBitFields == 0 && !getLangOpts().CPlusPlus) {
15285         Diag(RecLoc, IsEmpty ? diag::ext_empty_struct_union :
15286                                diag::ext_no_named_members_in_struct_union)
15287           << Record->isUnion();
15288       }
15289     }
15290   } else {
15291     ObjCIvarDecl **ClsFields =
15292       reinterpret_cast<ObjCIvarDecl**>(RecFields.data());
15293     if (ObjCInterfaceDecl *ID = dyn_cast<ObjCInterfaceDecl>(EnclosingDecl)) {
15294       ID->setEndOfDefinitionLoc(RBrac);
15295       // Add ivar's to class's DeclContext.
15296       for (unsigned i = 0, e = RecFields.size(); i != e; ++i) {
15297         ClsFields[i]->setLexicalDeclContext(ID);
15298         ID->addDecl(ClsFields[i]);
15299       }
15300       // Must enforce the rule that ivars in the base classes may not be
15301       // duplicates.
15302       if (ID->getSuperClass())
15303         DiagnoseDuplicateIvars(ID, ID->getSuperClass());
15304     } else if (ObjCImplementationDecl *IMPDecl =
15305                   dyn_cast<ObjCImplementationDecl>(EnclosingDecl)) {
15306       assert(IMPDecl && "ActOnFields - missing ObjCImplementationDecl");
15307       for (unsigned I = 0, N = RecFields.size(); I != N; ++I)
15308         // Ivar declared in @implementation never belongs to the implementation.
15309         // Only it is in implementation's lexical context.
15310         ClsFields[I]->setLexicalDeclContext(IMPDecl);
15311       CheckImplementationIvars(IMPDecl, ClsFields, RecFields.size(), RBrac);
15312       IMPDecl->setIvarLBraceLoc(LBrac);
15313       IMPDecl->setIvarRBraceLoc(RBrac);
15314     } else if (ObjCCategoryDecl *CDecl =
15315                 dyn_cast<ObjCCategoryDecl>(EnclosingDecl)) {
15316       // case of ivars in class extension; all other cases have been
15317       // reported as errors elsewhere.
15318       // FIXME. Class extension does not have a LocEnd field.
15319       // CDecl->setLocEnd(RBrac);
15320       // Add ivar's to class extension's DeclContext.
15321       // Diagnose redeclaration of private ivars.
15322       ObjCInterfaceDecl *IDecl = CDecl->getClassInterface();
15323       for (unsigned i = 0, e = RecFields.size(); i != e; ++i) {
15324         if (IDecl) {
15325           if (const ObjCIvarDecl *ClsIvar =
15326               IDecl->getIvarDecl(ClsFields[i]->getIdentifier())) {
15327             Diag(ClsFields[i]->getLocation(),
15328                  diag::err_duplicate_ivar_declaration);
15329             Diag(ClsIvar->getLocation(), diag::note_previous_definition);
15330             continue;
15331           }
15332           for (const auto *Ext : IDecl->known_extensions()) {
15333             if (const ObjCIvarDecl *ClsExtIvar
15334                   = Ext->getIvarDecl(ClsFields[i]->getIdentifier())) {
15335               Diag(ClsFields[i]->getLocation(),
15336                    diag::err_duplicate_ivar_declaration);
15337               Diag(ClsExtIvar->getLocation(), diag::note_previous_definition);
15338               continue;
15339             }
15340           }
15341         }
15342         ClsFields[i]->setLexicalDeclContext(CDecl);
15343         CDecl->addDecl(ClsFields[i]);
15344       }
15345       CDecl->setIvarLBraceLoc(LBrac);
15346       CDecl->setIvarRBraceLoc(RBrac);
15347     }
15348   }
15349 
15350   if (Attr)
15351     ProcessDeclAttributeList(S, Record, Attr);
15352 }
15353 
15354 /// \brief Determine whether the given integral value is representable within
15355 /// the given type T.
15356 static bool isRepresentableIntegerValue(ASTContext &Context,
15357                                         llvm::APSInt &Value,
15358                                         QualType T) {
15359   assert(T->isIntegralType(Context) && "Integral type required!");
15360   unsigned BitWidth = Context.getIntWidth(T);
15361 
15362   if (Value.isUnsigned() || Value.isNonNegative()) {
15363     if (T->isSignedIntegerOrEnumerationType())
15364       --BitWidth;
15365     return Value.getActiveBits() <= BitWidth;
15366   }
15367   return Value.getMinSignedBits() <= BitWidth;
15368 }
15369 
15370 // \brief Given an integral type, return the next larger integral type
15371 // (or a NULL type of no such type exists).
15372 static QualType getNextLargerIntegralType(ASTContext &Context, QualType T) {
15373   // FIXME: Int128/UInt128 support, which also needs to be introduced into
15374   // enum checking below.
15375   assert(T->isIntegralType(Context) && "Integral type required!");
15376   const unsigned NumTypes = 4;
15377   QualType SignedIntegralTypes[NumTypes] = {
15378     Context.ShortTy, Context.IntTy, Context.LongTy, Context.LongLongTy
15379   };
15380   QualType UnsignedIntegralTypes[NumTypes] = {
15381     Context.UnsignedShortTy, Context.UnsignedIntTy, Context.UnsignedLongTy,
15382     Context.UnsignedLongLongTy
15383   };
15384 
15385   unsigned BitWidth = Context.getTypeSize(T);
15386   QualType *Types = T->isSignedIntegerOrEnumerationType()? SignedIntegralTypes
15387                                                         : UnsignedIntegralTypes;
15388   for (unsigned I = 0; I != NumTypes; ++I)
15389     if (Context.getTypeSize(Types[I]) > BitWidth)
15390       return Types[I];
15391 
15392   return QualType();
15393 }
15394 
15395 EnumConstantDecl *Sema::CheckEnumConstant(EnumDecl *Enum,
15396                                           EnumConstantDecl *LastEnumConst,
15397                                           SourceLocation IdLoc,
15398                                           IdentifierInfo *Id,
15399                                           Expr *Val) {
15400   unsigned IntWidth = Context.getTargetInfo().getIntWidth();
15401   llvm::APSInt EnumVal(IntWidth);
15402   QualType EltTy;
15403 
15404   if (Val && DiagnoseUnexpandedParameterPack(Val, UPPC_EnumeratorValue))
15405     Val = nullptr;
15406 
15407   if (Val)
15408     Val = DefaultLvalueConversion(Val).get();
15409 
15410   if (Val) {
15411     if (Enum->isDependentType() || Val->isTypeDependent())
15412       EltTy = Context.DependentTy;
15413     else {
15414       if (getLangOpts().CPlusPlus11 && Enum->isFixed() &&
15415           !getLangOpts().MSVCCompat) {
15416         // C++11 [dcl.enum]p5: If the underlying type is fixed, [...] the
15417         // constant-expression in the enumerator-definition shall be a converted
15418         // constant expression of the underlying type.
15419         EltTy = Enum->getIntegerType();
15420         ExprResult Converted =
15421           CheckConvertedConstantExpression(Val, EltTy, EnumVal,
15422                                            CCEK_Enumerator);
15423         if (Converted.isInvalid())
15424           Val = nullptr;
15425         else
15426           Val = Converted.get();
15427       } else if (!Val->isValueDependent() &&
15428                  !(Val = VerifyIntegerConstantExpression(Val,
15429                                                          &EnumVal).get())) {
15430         // C99 6.7.2.2p2: Make sure we have an integer constant expression.
15431       } else {
15432         if (Enum->isFixed()) {
15433           EltTy = Enum->getIntegerType();
15434 
15435           // In Obj-C and Microsoft mode, require the enumeration value to be
15436           // representable in the underlying type of the enumeration. In C++11,
15437           // we perform a non-narrowing conversion as part of converted constant
15438           // expression checking.
15439           if (!isRepresentableIntegerValue(Context, EnumVal, EltTy)) {
15440             if (getLangOpts().MSVCCompat) {
15441               Diag(IdLoc, diag::ext_enumerator_too_large) << EltTy;
15442               Val = ImpCastExprToType(Val, EltTy, CK_IntegralCast).get();
15443             } else
15444               Diag(IdLoc, diag::err_enumerator_too_large) << EltTy;
15445           } else
15446             Val = ImpCastExprToType(Val, EltTy,
15447                                     EltTy->isBooleanType() ?
15448                                     CK_IntegralToBoolean : CK_IntegralCast)
15449                     .get();
15450         } else if (getLangOpts().CPlusPlus) {
15451           // C++11 [dcl.enum]p5:
15452           //   If the underlying type is not fixed, the type of each enumerator
15453           //   is the type of its initializing value:
15454           //     - If an initializer is specified for an enumerator, the
15455           //       initializing value has the same type as the expression.
15456           EltTy = Val->getType();
15457         } else {
15458           // C99 6.7.2.2p2:
15459           //   The expression that defines the value of an enumeration constant
15460           //   shall be an integer constant expression that has a value
15461           //   representable as an int.
15462 
15463           // Complain if the value is not representable in an int.
15464           if (!isRepresentableIntegerValue(Context, EnumVal, Context.IntTy))
15465             Diag(IdLoc, diag::ext_enum_value_not_int)
15466               << EnumVal.toString(10) << Val->getSourceRange()
15467               << (EnumVal.isUnsigned() || EnumVal.isNonNegative());
15468           else if (!Context.hasSameType(Val->getType(), Context.IntTy)) {
15469             // Force the type of the expression to 'int'.
15470             Val = ImpCastExprToType(Val, Context.IntTy, CK_IntegralCast).get();
15471           }
15472           EltTy = Val->getType();
15473         }
15474       }
15475     }
15476   }
15477 
15478   if (!Val) {
15479     if (Enum->isDependentType())
15480       EltTy = Context.DependentTy;
15481     else if (!LastEnumConst) {
15482       // C++0x [dcl.enum]p5:
15483       //   If the underlying type is not fixed, the type of each enumerator
15484       //   is the type of its initializing value:
15485       //     - If no initializer is specified for the first enumerator, the
15486       //       initializing value has an unspecified integral type.
15487       //
15488       // GCC uses 'int' for its unspecified integral type, as does
15489       // C99 6.7.2.2p3.
15490       if (Enum->isFixed()) {
15491         EltTy = Enum->getIntegerType();
15492       }
15493       else {
15494         EltTy = Context.IntTy;
15495       }
15496     } else {
15497       // Assign the last value + 1.
15498       EnumVal = LastEnumConst->getInitVal();
15499       ++EnumVal;
15500       EltTy = LastEnumConst->getType();
15501 
15502       // Check for overflow on increment.
15503       if (EnumVal < LastEnumConst->getInitVal()) {
15504         // C++0x [dcl.enum]p5:
15505         //   If the underlying type is not fixed, the type of each enumerator
15506         //   is the type of its initializing value:
15507         //
15508         //     - Otherwise the type of the initializing value is the same as
15509         //       the type of the initializing value of the preceding enumerator
15510         //       unless the incremented value is not representable in that type,
15511         //       in which case the type is an unspecified integral type
15512         //       sufficient to contain the incremented value. If no such type
15513         //       exists, the program is ill-formed.
15514         QualType T = getNextLargerIntegralType(Context, EltTy);
15515         if (T.isNull() || Enum->isFixed()) {
15516           // There is no integral type larger enough to represent this
15517           // value. Complain, then allow the value to wrap around.
15518           EnumVal = LastEnumConst->getInitVal();
15519           EnumVal = EnumVal.zext(EnumVal.getBitWidth() * 2);
15520           ++EnumVal;
15521           if (Enum->isFixed())
15522             // When the underlying type is fixed, this is ill-formed.
15523             Diag(IdLoc, diag::err_enumerator_wrapped)
15524               << EnumVal.toString(10)
15525               << EltTy;
15526           else
15527             Diag(IdLoc, diag::ext_enumerator_increment_too_large)
15528               << EnumVal.toString(10);
15529         } else {
15530           EltTy = T;
15531         }
15532 
15533         // Retrieve the last enumerator's value, extent that type to the
15534         // type that is supposed to be large enough to represent the incremented
15535         // value, then increment.
15536         EnumVal = LastEnumConst->getInitVal();
15537         EnumVal.setIsSigned(EltTy->isSignedIntegerOrEnumerationType());
15538         EnumVal = EnumVal.zextOrTrunc(Context.getIntWidth(EltTy));
15539         ++EnumVal;
15540 
15541         // If we're not in C++, diagnose the overflow of enumerator values,
15542         // which in C99 means that the enumerator value is not representable in
15543         // an int (C99 6.7.2.2p2). However, we support GCC's extension that
15544         // permits enumerator values that are representable in some larger
15545         // integral type.
15546         if (!getLangOpts().CPlusPlus && !T.isNull())
15547           Diag(IdLoc, diag::warn_enum_value_overflow);
15548       } else if (!getLangOpts().CPlusPlus &&
15549                  !isRepresentableIntegerValue(Context, EnumVal, EltTy)) {
15550         // Enforce C99 6.7.2.2p2 even when we compute the next value.
15551         Diag(IdLoc, diag::ext_enum_value_not_int)
15552           << EnumVal.toString(10) << 1;
15553       }
15554     }
15555   }
15556 
15557   if (!EltTy->isDependentType()) {
15558     // Make the enumerator value match the signedness and size of the
15559     // enumerator's type.
15560     EnumVal = EnumVal.extOrTrunc(Context.getIntWidth(EltTy));
15561     EnumVal.setIsSigned(EltTy->isSignedIntegerOrEnumerationType());
15562   }
15563 
15564   return EnumConstantDecl::Create(Context, Enum, IdLoc, Id, EltTy,
15565                                   Val, EnumVal);
15566 }
15567 
15568 Sema::SkipBodyInfo Sema::shouldSkipAnonEnumBody(Scope *S, IdentifierInfo *II,
15569                                                 SourceLocation IILoc) {
15570   if (!(getLangOpts().Modules || getLangOpts().ModulesLocalVisibility) ||
15571       !getLangOpts().CPlusPlus)
15572     return SkipBodyInfo();
15573 
15574   // We have an anonymous enum definition. Look up the first enumerator to
15575   // determine if we should merge the definition with an existing one and
15576   // skip the body.
15577   NamedDecl *PrevDecl = LookupSingleName(S, II, IILoc, LookupOrdinaryName,
15578                                          forRedeclarationInCurContext());
15579   auto *PrevECD = dyn_cast_or_null<EnumConstantDecl>(PrevDecl);
15580   if (!PrevECD)
15581     return SkipBodyInfo();
15582 
15583   EnumDecl *PrevED = cast<EnumDecl>(PrevECD->getDeclContext());
15584   NamedDecl *Hidden;
15585   if (!PrevED->getDeclName() && !hasVisibleDefinition(PrevED, &Hidden)) {
15586     SkipBodyInfo Skip;
15587     Skip.Previous = Hidden;
15588     return Skip;
15589   }
15590 
15591   return SkipBodyInfo();
15592 }
15593 
15594 Decl *Sema::ActOnEnumConstant(Scope *S, Decl *theEnumDecl, Decl *lastEnumConst,
15595                               SourceLocation IdLoc, IdentifierInfo *Id,
15596                               AttributeList *Attr,
15597                               SourceLocation EqualLoc, Expr *Val) {
15598   EnumDecl *TheEnumDecl = cast<EnumDecl>(theEnumDecl);
15599   EnumConstantDecl *LastEnumConst =
15600     cast_or_null<EnumConstantDecl>(lastEnumConst);
15601 
15602   // The scope passed in may not be a decl scope.  Zip up the scope tree until
15603   // we find one that is.
15604   S = getNonFieldDeclScope(S);
15605 
15606   // Verify that there isn't already something declared with this name in this
15607   // scope.
15608   NamedDecl *PrevDecl = LookupSingleName(S, Id, IdLoc, LookupOrdinaryName,
15609                                          ForVisibleRedeclaration);
15610   if (PrevDecl && PrevDecl->isTemplateParameter()) {
15611     // Maybe we will complain about the shadowed template parameter.
15612     DiagnoseTemplateParameterShadow(IdLoc, PrevDecl);
15613     // Just pretend that we didn't see the previous declaration.
15614     PrevDecl = nullptr;
15615   }
15616 
15617   // C++ [class.mem]p15:
15618   // If T is the name of a class, then each of the following shall have a name
15619   // different from T:
15620   // - every enumerator of every member of class T that is an unscoped
15621   // enumerated type
15622   if (getLangOpts().CPlusPlus && !TheEnumDecl->isScoped())
15623     DiagnoseClassNameShadow(TheEnumDecl->getDeclContext(),
15624                             DeclarationNameInfo(Id, IdLoc));
15625 
15626   EnumConstantDecl *New =
15627     CheckEnumConstant(TheEnumDecl, LastEnumConst, IdLoc, Id, Val);
15628   if (!New)
15629     return nullptr;
15630 
15631   if (PrevDecl) {
15632     // When in C++, we may get a TagDecl with the same name; in this case the
15633     // enum constant will 'hide' the tag.
15634     assert((getLangOpts().CPlusPlus || !isa<TagDecl>(PrevDecl)) &&
15635            "Received TagDecl when not in C++!");
15636     if (!isa<TagDecl>(PrevDecl) && isDeclInScope(PrevDecl, CurContext, S)) {
15637       if (isa<EnumConstantDecl>(PrevDecl))
15638         Diag(IdLoc, diag::err_redefinition_of_enumerator) << Id;
15639       else
15640         Diag(IdLoc, diag::err_redefinition) << Id;
15641       notePreviousDefinition(PrevDecl, IdLoc);
15642       return nullptr;
15643     }
15644   }
15645 
15646   // Process attributes.
15647   if (Attr) ProcessDeclAttributeList(S, New, Attr);
15648   AddPragmaAttributes(S, New);
15649 
15650   // Register this decl in the current scope stack.
15651   New->setAccess(TheEnumDecl->getAccess());
15652   PushOnScopeChains(New, S);
15653 
15654   ActOnDocumentableDecl(New);
15655 
15656   return New;
15657 }
15658 
15659 // Returns true when the enum initial expression does not trigger the
15660 // duplicate enum warning.  A few common cases are exempted as follows:
15661 // Element2 = Element1
15662 // Element2 = Element1 + 1
15663 // Element2 = Element1 - 1
15664 // Where Element2 and Element1 are from the same enum.
15665 static bool ValidDuplicateEnum(EnumConstantDecl *ECD, EnumDecl *Enum) {
15666   Expr *InitExpr = ECD->getInitExpr();
15667   if (!InitExpr)
15668     return true;
15669   InitExpr = InitExpr->IgnoreImpCasts();
15670 
15671   if (BinaryOperator *BO = dyn_cast<BinaryOperator>(InitExpr)) {
15672     if (!BO->isAdditiveOp())
15673       return true;
15674     IntegerLiteral *IL = dyn_cast<IntegerLiteral>(BO->getRHS());
15675     if (!IL)
15676       return true;
15677     if (IL->getValue() != 1)
15678       return true;
15679 
15680     InitExpr = BO->getLHS();
15681   }
15682 
15683   // This checks if the elements are from the same enum.
15684   DeclRefExpr *DRE = dyn_cast<DeclRefExpr>(InitExpr);
15685   if (!DRE)
15686     return true;
15687 
15688   EnumConstantDecl *EnumConstant = dyn_cast<EnumConstantDecl>(DRE->getDecl());
15689   if (!EnumConstant)
15690     return true;
15691 
15692   if (cast<EnumDecl>(TagDecl::castFromDeclContext(ECD->getDeclContext())) !=
15693       Enum)
15694     return true;
15695 
15696   return false;
15697 }
15698 
15699 namespace {
15700 struct DupKey {
15701   int64_t val;
15702   bool isTombstoneOrEmptyKey;
15703   DupKey(int64_t val, bool isTombstoneOrEmptyKey)
15704     : val(val), isTombstoneOrEmptyKey(isTombstoneOrEmptyKey) {}
15705 };
15706 
15707 static DupKey GetDupKey(const llvm::APSInt& Val) {
15708   return DupKey(Val.isSigned() ? Val.getSExtValue() : Val.getZExtValue(),
15709                 false);
15710 }
15711 
15712 struct DenseMapInfoDupKey {
15713   static DupKey getEmptyKey() { return DupKey(0, true); }
15714   static DupKey getTombstoneKey() { return DupKey(1, true); }
15715   static unsigned getHashValue(const DupKey Key) {
15716     return (unsigned)(Key.val * 37);
15717   }
15718   static bool isEqual(const DupKey& LHS, const DupKey& RHS) {
15719     return LHS.isTombstoneOrEmptyKey == RHS.isTombstoneOrEmptyKey &&
15720            LHS.val == RHS.val;
15721   }
15722 };
15723 } // end anonymous namespace
15724 
15725 // Emits a warning when an element is implicitly set a value that
15726 // a previous element has already been set to.
15727 static void CheckForDuplicateEnumValues(Sema &S, ArrayRef<Decl *> Elements,
15728                                         EnumDecl *Enum,
15729                                         QualType EnumType) {
15730   if (S.Diags.isIgnored(diag::warn_duplicate_enum_values, Enum->getLocation()))
15731     return;
15732   // Avoid anonymous enums
15733   if (!Enum->getIdentifier())
15734     return;
15735 
15736   // Only check for small enums.
15737   if (Enum->getNumPositiveBits() > 63 || Enum->getNumNegativeBits() > 64)
15738     return;
15739 
15740   typedef SmallVector<EnumConstantDecl *, 3> ECDVector;
15741   typedef SmallVector<ECDVector *, 3> DuplicatesVector;
15742 
15743   typedef llvm::PointerUnion<EnumConstantDecl*, ECDVector*> DeclOrVector;
15744   typedef llvm::DenseMap<DupKey, DeclOrVector, DenseMapInfoDupKey>
15745           ValueToVectorMap;
15746 
15747   DuplicatesVector DupVector;
15748   ValueToVectorMap EnumMap;
15749 
15750   // Populate the EnumMap with all values represented by enum constants without
15751   // an initialier.
15752   for (unsigned i = 0, e = Elements.size(); i != e; ++i) {
15753     EnumConstantDecl *ECD = cast_or_null<EnumConstantDecl>(Elements[i]);
15754 
15755     // Null EnumConstantDecl means a previous diagnostic has been emitted for
15756     // this constant.  Skip this enum since it may be ill-formed.
15757     if (!ECD) {
15758       return;
15759     }
15760 
15761     if (ECD->getInitExpr())
15762       continue;
15763 
15764     DupKey Key = GetDupKey(ECD->getInitVal());
15765     DeclOrVector &Entry = EnumMap[Key];
15766 
15767     // First time encountering this value.
15768     if (Entry.isNull())
15769       Entry = ECD;
15770   }
15771 
15772   // Create vectors for any values that has duplicates.
15773   for (unsigned i = 0, e = Elements.size(); i != e; ++i) {
15774     EnumConstantDecl *ECD = cast<EnumConstantDecl>(Elements[i]);
15775     if (!ValidDuplicateEnum(ECD, Enum))
15776       continue;
15777 
15778     DupKey Key = GetDupKey(ECD->getInitVal());
15779 
15780     DeclOrVector& Entry = EnumMap[Key];
15781     if (Entry.isNull())
15782       continue;
15783 
15784     if (EnumConstantDecl *D = Entry.dyn_cast<EnumConstantDecl*>()) {
15785       // Ensure constants are different.
15786       if (D == ECD)
15787         continue;
15788 
15789       // Create new vector and push values onto it.
15790       ECDVector *Vec = new ECDVector();
15791       Vec->push_back(D);
15792       Vec->push_back(ECD);
15793 
15794       // Update entry to point to the duplicates vector.
15795       Entry = Vec;
15796 
15797       // Store the vector somewhere we can consult later for quick emission of
15798       // diagnostics.
15799       DupVector.push_back(Vec);
15800       continue;
15801     }
15802 
15803     ECDVector *Vec = Entry.get<ECDVector*>();
15804     // Make sure constants are not added more than once.
15805     if (*Vec->begin() == ECD)
15806       continue;
15807 
15808     Vec->push_back(ECD);
15809   }
15810 
15811   // Emit diagnostics.
15812   for (DuplicatesVector::iterator DupVectorIter = DupVector.begin(),
15813                                   DupVectorEnd = DupVector.end();
15814        DupVectorIter != DupVectorEnd; ++DupVectorIter) {
15815     ECDVector *Vec = *DupVectorIter;
15816     assert(Vec->size() > 1 && "ECDVector should have at least 2 elements.");
15817 
15818     // Emit warning for one enum constant.
15819     ECDVector::iterator I = Vec->begin();
15820     S.Diag((*I)->getLocation(), diag::warn_duplicate_enum_values)
15821       << (*I)->getName() << (*I)->getInitVal().toString(10)
15822       << (*I)->getSourceRange();
15823     ++I;
15824 
15825     // Emit one note for each of the remaining enum constants with
15826     // the same value.
15827     for (ECDVector::iterator E = Vec->end(); I != E; ++I)
15828       S.Diag((*I)->getLocation(), diag::note_duplicate_element)
15829         << (*I)->getName() << (*I)->getInitVal().toString(10)
15830         << (*I)->getSourceRange();
15831     delete Vec;
15832   }
15833 }
15834 
15835 bool Sema::IsValueInFlagEnum(const EnumDecl *ED, const llvm::APInt &Val,
15836                              bool AllowMask) const {
15837   assert(ED->isClosedFlag() && "looking for value in non-flag or open enum");
15838   assert(ED->isCompleteDefinition() && "expected enum definition");
15839 
15840   auto R = FlagBitsCache.insert(std::make_pair(ED, llvm::APInt()));
15841   llvm::APInt &FlagBits = R.first->second;
15842 
15843   if (R.second) {
15844     for (auto *E : ED->enumerators()) {
15845       const auto &EVal = E->getInitVal();
15846       // Only single-bit enumerators introduce new flag values.
15847       if (EVal.isPowerOf2())
15848         FlagBits = FlagBits.zextOrSelf(EVal.getBitWidth()) | EVal;
15849     }
15850   }
15851 
15852   // A value is in a flag enum if either its bits are a subset of the enum's
15853   // flag bits (the first condition) or we are allowing masks and the same is
15854   // true of its complement (the second condition). When masks are allowed, we
15855   // allow the common idiom of ~(enum1 | enum2) to be a valid enum value.
15856   //
15857   // While it's true that any value could be used as a mask, the assumption is
15858   // that a mask will have all of the insignificant bits set. Anything else is
15859   // likely a logic error.
15860   llvm::APInt FlagMask = ~FlagBits.zextOrTrunc(Val.getBitWidth());
15861   return !(FlagMask & Val) || (AllowMask && !(FlagMask & ~Val));
15862 }
15863 
15864 void Sema::ActOnEnumBody(SourceLocation EnumLoc, SourceRange BraceRange,
15865                          Decl *EnumDeclX,
15866                          ArrayRef<Decl *> Elements,
15867                          Scope *S, AttributeList *Attr) {
15868   EnumDecl *Enum = cast<EnumDecl>(EnumDeclX);
15869   QualType EnumType = Context.getTypeDeclType(Enum);
15870 
15871   if (Attr)
15872     ProcessDeclAttributeList(S, Enum, Attr);
15873 
15874   if (Enum->isDependentType()) {
15875     for (unsigned i = 0, e = Elements.size(); i != e; ++i) {
15876       EnumConstantDecl *ECD =
15877         cast_or_null<EnumConstantDecl>(Elements[i]);
15878       if (!ECD) continue;
15879 
15880       ECD->setType(EnumType);
15881     }
15882 
15883     Enum->completeDefinition(Context.DependentTy, Context.DependentTy, 0, 0);
15884     return;
15885   }
15886 
15887   // TODO: If the result value doesn't fit in an int, it must be a long or long
15888   // long value.  ISO C does not support this, but GCC does as an extension,
15889   // emit a warning.
15890   unsigned IntWidth = Context.getTargetInfo().getIntWidth();
15891   unsigned CharWidth = Context.getTargetInfo().getCharWidth();
15892   unsigned ShortWidth = Context.getTargetInfo().getShortWidth();
15893 
15894   // Verify that all the values are okay, compute the size of the values, and
15895   // reverse the list.
15896   unsigned NumNegativeBits = 0;
15897   unsigned NumPositiveBits = 0;
15898 
15899   // Keep track of whether all elements have type int.
15900   bool AllElementsInt = true;
15901 
15902   for (unsigned i = 0, e = Elements.size(); i != e; ++i) {
15903     EnumConstantDecl *ECD =
15904       cast_or_null<EnumConstantDecl>(Elements[i]);
15905     if (!ECD) continue;  // Already issued a diagnostic.
15906 
15907     const llvm::APSInt &InitVal = ECD->getInitVal();
15908 
15909     // Keep track of the size of positive and negative values.
15910     if (InitVal.isUnsigned() || InitVal.isNonNegative())
15911       NumPositiveBits = std::max(NumPositiveBits,
15912                                  (unsigned)InitVal.getActiveBits());
15913     else
15914       NumNegativeBits = std::max(NumNegativeBits,
15915                                  (unsigned)InitVal.getMinSignedBits());
15916 
15917     // Keep track of whether every enum element has type int (very commmon).
15918     if (AllElementsInt)
15919       AllElementsInt = ECD->getType() == Context.IntTy;
15920   }
15921 
15922   // Figure out the type that should be used for this enum.
15923   QualType BestType;
15924   unsigned BestWidth;
15925 
15926   // C++0x N3000 [conv.prom]p3:
15927   //   An rvalue of an unscoped enumeration type whose underlying
15928   //   type is not fixed can be converted to an rvalue of the first
15929   //   of the following types that can represent all the values of
15930   //   the enumeration: int, unsigned int, long int, unsigned long
15931   //   int, long long int, or unsigned long long int.
15932   // C99 6.4.4.3p2:
15933   //   An identifier declared as an enumeration constant has type int.
15934   // The C99 rule is modified by a gcc extension
15935   QualType BestPromotionType;
15936 
15937   bool Packed = Enum->hasAttr<PackedAttr>();
15938   // -fshort-enums is the equivalent to specifying the packed attribute on all
15939   // enum definitions.
15940   if (LangOpts.ShortEnums)
15941     Packed = true;
15942 
15943   if (Enum->isFixed()) {
15944     BestType = Enum->getIntegerType();
15945     if (BestType->isPromotableIntegerType())
15946       BestPromotionType = Context.getPromotedIntegerType(BestType);
15947     else
15948       BestPromotionType = BestType;
15949 
15950     BestWidth = Context.getIntWidth(BestType);
15951   }
15952   else if (NumNegativeBits) {
15953     // If there is a negative value, figure out the smallest integer type (of
15954     // int/long/longlong) that fits.
15955     // If it's packed, check also if it fits a char or a short.
15956     if (Packed && NumNegativeBits <= CharWidth && NumPositiveBits < CharWidth) {
15957       BestType = Context.SignedCharTy;
15958       BestWidth = CharWidth;
15959     } else if (Packed && NumNegativeBits <= ShortWidth &&
15960                NumPositiveBits < ShortWidth) {
15961       BestType = Context.ShortTy;
15962       BestWidth = ShortWidth;
15963     } else if (NumNegativeBits <= IntWidth && NumPositiveBits < IntWidth) {
15964       BestType = Context.IntTy;
15965       BestWidth = IntWidth;
15966     } else {
15967       BestWidth = Context.getTargetInfo().getLongWidth();
15968 
15969       if (NumNegativeBits <= BestWidth && NumPositiveBits < BestWidth) {
15970         BestType = Context.LongTy;
15971       } else {
15972         BestWidth = Context.getTargetInfo().getLongLongWidth();
15973 
15974         if (NumNegativeBits > BestWidth || NumPositiveBits >= BestWidth)
15975           Diag(Enum->getLocation(), diag::ext_enum_too_large);
15976         BestType = Context.LongLongTy;
15977       }
15978     }
15979     BestPromotionType = (BestWidth <= IntWidth ? Context.IntTy : BestType);
15980   } else {
15981     // If there is no negative value, figure out the smallest type that fits
15982     // all of the enumerator values.
15983     // If it's packed, check also if it fits a char or a short.
15984     if (Packed && NumPositiveBits <= CharWidth) {
15985       BestType = Context.UnsignedCharTy;
15986       BestPromotionType = Context.IntTy;
15987       BestWidth = CharWidth;
15988     } else if (Packed && NumPositiveBits <= ShortWidth) {
15989       BestType = Context.UnsignedShortTy;
15990       BestPromotionType = Context.IntTy;
15991       BestWidth = ShortWidth;
15992     } else if (NumPositiveBits <= IntWidth) {
15993       BestType = Context.UnsignedIntTy;
15994       BestWidth = IntWidth;
15995       BestPromotionType
15996         = (NumPositiveBits == BestWidth || !getLangOpts().CPlusPlus)
15997                            ? Context.UnsignedIntTy : Context.IntTy;
15998     } else if (NumPositiveBits <=
15999                (BestWidth = Context.getTargetInfo().getLongWidth())) {
16000       BestType = Context.UnsignedLongTy;
16001       BestPromotionType
16002         = (NumPositiveBits == BestWidth || !getLangOpts().CPlusPlus)
16003                            ? Context.UnsignedLongTy : Context.LongTy;
16004     } else {
16005       BestWidth = Context.getTargetInfo().getLongLongWidth();
16006       assert(NumPositiveBits <= BestWidth &&
16007              "How could an initializer get larger than ULL?");
16008       BestType = Context.UnsignedLongLongTy;
16009       BestPromotionType
16010         = (NumPositiveBits == BestWidth || !getLangOpts().CPlusPlus)
16011                            ? Context.UnsignedLongLongTy : Context.LongLongTy;
16012     }
16013   }
16014 
16015   // Loop over all of the enumerator constants, changing their types to match
16016   // the type of the enum if needed.
16017   for (auto *D : Elements) {
16018     auto *ECD = cast_or_null<EnumConstantDecl>(D);
16019     if (!ECD) continue;  // Already issued a diagnostic.
16020 
16021     // Standard C says the enumerators have int type, but we allow, as an
16022     // extension, the enumerators to be larger than int size.  If each
16023     // enumerator value fits in an int, type it as an int, otherwise type it the
16024     // same as the enumerator decl itself.  This means that in "enum { X = 1U }"
16025     // that X has type 'int', not 'unsigned'.
16026 
16027     // Determine whether the value fits into an int.
16028     llvm::APSInt InitVal = ECD->getInitVal();
16029 
16030     // If it fits into an integer type, force it.  Otherwise force it to match
16031     // the enum decl type.
16032     QualType NewTy;
16033     unsigned NewWidth;
16034     bool NewSign;
16035     if (!getLangOpts().CPlusPlus &&
16036         !Enum->isFixed() &&
16037         isRepresentableIntegerValue(Context, InitVal, Context.IntTy)) {
16038       NewTy = Context.IntTy;
16039       NewWidth = IntWidth;
16040       NewSign = true;
16041     } else if (ECD->getType() == BestType) {
16042       // Already the right type!
16043       if (getLangOpts().CPlusPlus)
16044         // C++ [dcl.enum]p4: Following the closing brace of an
16045         // enum-specifier, each enumerator has the type of its
16046         // enumeration.
16047         ECD->setType(EnumType);
16048       continue;
16049     } else {
16050       NewTy = BestType;
16051       NewWidth = BestWidth;
16052       NewSign = BestType->isSignedIntegerOrEnumerationType();
16053     }
16054 
16055     // Adjust the APSInt value.
16056     InitVal = InitVal.extOrTrunc(NewWidth);
16057     InitVal.setIsSigned(NewSign);
16058     ECD->setInitVal(InitVal);
16059 
16060     // Adjust the Expr initializer and type.
16061     if (ECD->getInitExpr() &&
16062         !Context.hasSameType(NewTy, ECD->getInitExpr()->getType()))
16063       ECD->setInitExpr(ImplicitCastExpr::Create(Context, NewTy,
16064                                                 CK_IntegralCast,
16065                                                 ECD->getInitExpr(),
16066                                                 /*base paths*/ nullptr,
16067                                                 VK_RValue));
16068     if (getLangOpts().CPlusPlus)
16069       // C++ [dcl.enum]p4: Following the closing brace of an
16070       // enum-specifier, each enumerator has the type of its
16071       // enumeration.
16072       ECD->setType(EnumType);
16073     else
16074       ECD->setType(NewTy);
16075   }
16076 
16077   Enum->completeDefinition(BestType, BestPromotionType,
16078                            NumPositiveBits, NumNegativeBits);
16079 
16080   CheckForDuplicateEnumValues(*this, Elements, Enum, EnumType);
16081 
16082   if (Enum->isClosedFlag()) {
16083     for (Decl *D : Elements) {
16084       EnumConstantDecl *ECD = cast_or_null<EnumConstantDecl>(D);
16085       if (!ECD) continue;  // Already issued a diagnostic.
16086 
16087       llvm::APSInt InitVal = ECD->getInitVal();
16088       if (InitVal != 0 && !InitVal.isPowerOf2() &&
16089           !IsValueInFlagEnum(Enum, InitVal, true))
16090         Diag(ECD->getLocation(), diag::warn_flag_enum_constant_out_of_range)
16091           << ECD << Enum;
16092     }
16093   }
16094 
16095   // Now that the enum type is defined, ensure it's not been underaligned.
16096   if (Enum->hasAttrs())
16097     CheckAlignasUnderalignment(Enum);
16098 }
16099 
16100 Decl *Sema::ActOnFileScopeAsmDecl(Expr *expr,
16101                                   SourceLocation StartLoc,
16102                                   SourceLocation EndLoc) {
16103   StringLiteral *AsmString = cast<StringLiteral>(expr);
16104 
16105   FileScopeAsmDecl *New = FileScopeAsmDecl::Create(Context, CurContext,
16106                                                    AsmString, StartLoc,
16107                                                    EndLoc);
16108   CurContext->addDecl(New);
16109   return New;
16110 }
16111 
16112 static void checkModuleImportContext(Sema &S, Module *M,
16113                                      SourceLocation ImportLoc, DeclContext *DC,
16114                                      bool FromInclude = false) {
16115   SourceLocation ExternCLoc;
16116 
16117   if (auto *LSD = dyn_cast<LinkageSpecDecl>(DC)) {
16118     switch (LSD->getLanguage()) {
16119     case LinkageSpecDecl::lang_c:
16120       if (ExternCLoc.isInvalid())
16121         ExternCLoc = LSD->getLocStart();
16122       break;
16123     case LinkageSpecDecl::lang_cxx:
16124       break;
16125     }
16126     DC = LSD->getParent();
16127   }
16128 
16129   while (isa<LinkageSpecDecl>(DC))
16130     DC = DC->getParent();
16131 
16132   if (!isa<TranslationUnitDecl>(DC)) {
16133     S.Diag(ImportLoc, (FromInclude && S.isModuleVisible(M))
16134                           ? diag::ext_module_import_not_at_top_level_noop
16135                           : diag::err_module_import_not_at_top_level_fatal)
16136         << M->getFullModuleName() << DC;
16137     S.Diag(cast<Decl>(DC)->getLocStart(),
16138            diag::note_module_import_not_at_top_level) << DC;
16139   } else if (!M->IsExternC && ExternCLoc.isValid()) {
16140     S.Diag(ImportLoc, diag::ext_module_import_in_extern_c)
16141       << M->getFullModuleName();
16142     S.Diag(ExternCLoc, diag::note_extern_c_begins_here);
16143   }
16144 }
16145 
16146 Sema::DeclGroupPtrTy Sema::ActOnModuleDecl(SourceLocation StartLoc,
16147                                            SourceLocation ModuleLoc,
16148                                            ModuleDeclKind MDK,
16149                                            ModuleIdPath Path) {
16150   assert(getLangOpts().ModulesTS &&
16151          "should only have module decl in modules TS");
16152 
16153   // A module implementation unit requires that we are not compiling a module
16154   // of any kind. A module interface unit requires that we are not compiling a
16155   // module map.
16156   switch (getLangOpts().getCompilingModule()) {
16157   case LangOptions::CMK_None:
16158     // It's OK to compile a module interface as a normal translation unit.
16159     break;
16160 
16161   case LangOptions::CMK_ModuleInterface:
16162     if (MDK != ModuleDeclKind::Implementation)
16163       break;
16164 
16165     // We were asked to compile a module interface unit but this is a module
16166     // implementation unit. That indicates the 'export' is missing.
16167     Diag(ModuleLoc, diag::err_module_interface_implementation_mismatch)
16168       << FixItHint::CreateInsertion(ModuleLoc, "export ");
16169     MDK = ModuleDeclKind::Interface;
16170     break;
16171 
16172   case LangOptions::CMK_ModuleMap:
16173     Diag(ModuleLoc, diag::err_module_decl_in_module_map_module);
16174     return nullptr;
16175   }
16176 
16177   assert(ModuleScopes.size() == 1 && "expected to be at global module scope");
16178 
16179   // FIXME: Most of this work should be done by the preprocessor rather than
16180   // here, in order to support macro import.
16181 
16182   // Only one module-declaration is permitted per source file.
16183   if (ModuleScopes.back().Module->Kind == Module::ModuleInterfaceUnit) {
16184     Diag(ModuleLoc, diag::err_module_redeclaration);
16185     Diag(VisibleModules.getImportLoc(ModuleScopes.back().Module),
16186          diag::note_prev_module_declaration);
16187     return nullptr;
16188   }
16189 
16190   // Flatten the dots in a module name. Unlike Clang's hierarchical module map
16191   // modules, the dots here are just another character that can appear in a
16192   // module name.
16193   std::string ModuleName;
16194   for (auto &Piece : Path) {
16195     if (!ModuleName.empty())
16196       ModuleName += ".";
16197     ModuleName += Piece.first->getName();
16198   }
16199 
16200   // If a module name was explicitly specified on the command line, it must be
16201   // correct.
16202   if (!getLangOpts().CurrentModule.empty() &&
16203       getLangOpts().CurrentModule != ModuleName) {
16204     Diag(Path.front().second, diag::err_current_module_name_mismatch)
16205         << SourceRange(Path.front().second, Path.back().second)
16206         << getLangOpts().CurrentModule;
16207     return nullptr;
16208   }
16209   const_cast<LangOptions&>(getLangOpts()).CurrentModule = ModuleName;
16210 
16211   auto &Map = PP.getHeaderSearchInfo().getModuleMap();
16212   Module *Mod;
16213 
16214   switch (MDK) {
16215   case ModuleDeclKind::Interface: {
16216     // We can't have parsed or imported a definition of this module or parsed a
16217     // module map defining it already.
16218     if (auto *M = Map.findModule(ModuleName)) {
16219       Diag(Path[0].second, diag::err_module_redefinition) << ModuleName;
16220       if (M->DefinitionLoc.isValid())
16221         Diag(M->DefinitionLoc, diag::note_prev_module_definition);
16222       else if (const auto *FE = M->getASTFile())
16223         Diag(M->DefinitionLoc, diag::note_prev_module_definition_from_ast_file)
16224             << FE->getName();
16225       Mod = M;
16226       break;
16227     }
16228 
16229     // Create a Module for the module that we're defining.
16230     Mod = Map.createModuleForInterfaceUnit(ModuleLoc, ModuleName,
16231                                            ModuleScopes.front().Module);
16232     assert(Mod && "module creation should not fail");
16233     break;
16234   }
16235 
16236   case ModuleDeclKind::Partition:
16237     // FIXME: Check we are in a submodule of the named module.
16238     return nullptr;
16239 
16240   case ModuleDeclKind::Implementation:
16241     std::pair<IdentifierInfo *, SourceLocation> ModuleNameLoc(
16242         PP.getIdentifierInfo(ModuleName), Path[0].second);
16243     Mod = getModuleLoader().loadModule(ModuleLoc, Path, Module::AllVisible,
16244                                        /*IsIncludeDirective=*/false);
16245     if (!Mod) {
16246       Diag(ModuleLoc, diag::err_module_not_defined) << ModuleName;
16247       // Create an empty module interface unit for error recovery.
16248       Mod = Map.createModuleForInterfaceUnit(ModuleLoc, ModuleName,
16249                                              ModuleScopes.front().Module);
16250     }
16251     break;
16252   }
16253 
16254   // Switch from the global module to the named module.
16255   ModuleScopes.back().Module = Mod;
16256   ModuleScopes.back().ModuleInterface = MDK != ModuleDeclKind::Implementation;
16257   VisibleModules.setVisible(Mod, ModuleLoc);
16258 
16259   // From now on, we have an owning module for all declarations we see.
16260   // However, those declarations are module-private unless explicitly
16261   // exported.
16262   auto *TU = Context.getTranslationUnitDecl();
16263   TU->setModuleOwnershipKind(Decl::ModuleOwnershipKind::ModulePrivate);
16264   TU->setLocalOwningModule(Mod);
16265 
16266   // FIXME: Create a ModuleDecl.
16267   return nullptr;
16268 }
16269 
16270 DeclResult Sema::ActOnModuleImport(SourceLocation StartLoc,
16271                                    SourceLocation ImportLoc,
16272                                    ModuleIdPath Path) {
16273   Module *Mod =
16274       getModuleLoader().loadModule(ImportLoc, Path, Module::AllVisible,
16275                                    /*IsIncludeDirective=*/false);
16276   if (!Mod)
16277     return true;
16278 
16279   VisibleModules.setVisible(Mod, ImportLoc);
16280 
16281   checkModuleImportContext(*this, Mod, ImportLoc, CurContext);
16282 
16283   // FIXME: we should support importing a submodule within a different submodule
16284   // of the same top-level module. Until we do, make it an error rather than
16285   // silently ignoring the import.
16286   // Import-from-implementation is valid in the Modules TS. FIXME: Should we
16287   // warn on a redundant import of the current module?
16288   if (Mod->getTopLevelModuleName() == getLangOpts().CurrentModule &&
16289       (getLangOpts().isCompilingModule() || !getLangOpts().ModulesTS))
16290     Diag(ImportLoc, getLangOpts().isCompilingModule()
16291                         ? diag::err_module_self_import
16292                         : diag::err_module_import_in_implementation)
16293         << Mod->getFullModuleName() << getLangOpts().CurrentModule;
16294 
16295   SmallVector<SourceLocation, 2> IdentifierLocs;
16296   Module *ModCheck = Mod;
16297   for (unsigned I = 0, N = Path.size(); I != N; ++I) {
16298     // If we've run out of module parents, just drop the remaining identifiers.
16299     // We need the length to be consistent.
16300     if (!ModCheck)
16301       break;
16302     ModCheck = ModCheck->Parent;
16303 
16304     IdentifierLocs.push_back(Path[I].second);
16305   }
16306 
16307   TranslationUnitDecl *TU = getASTContext().getTranslationUnitDecl();
16308   ImportDecl *Import = ImportDecl::Create(Context, TU, StartLoc,
16309                                           Mod, IdentifierLocs);
16310   if (!ModuleScopes.empty())
16311     Context.addModuleInitializer(ModuleScopes.back().Module, Import);
16312   TU->addDecl(Import);
16313   return Import;
16314 }
16315 
16316 void Sema::ActOnModuleInclude(SourceLocation DirectiveLoc, Module *Mod) {
16317   checkModuleImportContext(*this, Mod, DirectiveLoc, CurContext, true);
16318   BuildModuleInclude(DirectiveLoc, Mod);
16319 }
16320 
16321 void Sema::BuildModuleInclude(SourceLocation DirectiveLoc, Module *Mod) {
16322   // Determine whether we're in the #include buffer for a module. The #includes
16323   // in that buffer do not qualify as module imports; they're just an
16324   // implementation detail of us building the module.
16325   //
16326   // FIXME: Should we even get ActOnModuleInclude calls for those?
16327   bool IsInModuleIncludes =
16328       TUKind == TU_Module &&
16329       getSourceManager().isWrittenInMainFile(DirectiveLoc);
16330 
16331   bool ShouldAddImport = !IsInModuleIncludes;
16332 
16333   // If this module import was due to an inclusion directive, create an
16334   // implicit import declaration to capture it in the AST.
16335   if (ShouldAddImport) {
16336     TranslationUnitDecl *TU = getASTContext().getTranslationUnitDecl();
16337     ImportDecl *ImportD = ImportDecl::CreateImplicit(getASTContext(), TU,
16338                                                      DirectiveLoc, Mod,
16339                                                      DirectiveLoc);
16340     if (!ModuleScopes.empty())
16341       Context.addModuleInitializer(ModuleScopes.back().Module, ImportD);
16342     TU->addDecl(ImportD);
16343     Consumer.HandleImplicitImportDecl(ImportD);
16344   }
16345 
16346   getModuleLoader().makeModuleVisible(Mod, Module::AllVisible, DirectiveLoc);
16347   VisibleModules.setVisible(Mod, DirectiveLoc);
16348 }
16349 
16350 void Sema::ActOnModuleBegin(SourceLocation DirectiveLoc, Module *Mod) {
16351   checkModuleImportContext(*this, Mod, DirectiveLoc, CurContext, true);
16352 
16353   ModuleScopes.push_back({});
16354   ModuleScopes.back().Module = Mod;
16355   if (getLangOpts().ModulesLocalVisibility)
16356     ModuleScopes.back().OuterVisibleModules = std::move(VisibleModules);
16357 
16358   VisibleModules.setVisible(Mod, DirectiveLoc);
16359 
16360   // The enclosing context is now part of this module.
16361   // FIXME: Consider creating a child DeclContext to hold the entities
16362   // lexically within the module.
16363   if (getLangOpts().trackLocalOwningModule()) {
16364     for (auto *DC = CurContext; DC; DC = DC->getLexicalParent()) {
16365       cast<Decl>(DC)->setModuleOwnershipKind(
16366           getLangOpts().ModulesLocalVisibility
16367               ? Decl::ModuleOwnershipKind::VisibleWhenImported
16368               : Decl::ModuleOwnershipKind::Visible);
16369       cast<Decl>(DC)->setLocalOwningModule(Mod);
16370     }
16371   }
16372 }
16373 
16374 void Sema::ActOnModuleEnd(SourceLocation EomLoc, Module *Mod) {
16375   if (getLangOpts().ModulesLocalVisibility) {
16376     VisibleModules = std::move(ModuleScopes.back().OuterVisibleModules);
16377     // Leaving a module hides namespace names, so our visible namespace cache
16378     // is now out of date.
16379     VisibleNamespaceCache.clear();
16380   }
16381 
16382   assert(!ModuleScopes.empty() && ModuleScopes.back().Module == Mod &&
16383          "left the wrong module scope");
16384   ModuleScopes.pop_back();
16385 
16386   // We got to the end of processing a local module. Create an
16387   // ImportDecl as we would for an imported module.
16388   FileID File = getSourceManager().getFileID(EomLoc);
16389   SourceLocation DirectiveLoc;
16390   if (EomLoc == getSourceManager().getLocForEndOfFile(File)) {
16391     // We reached the end of a #included module header. Use the #include loc.
16392     assert(File != getSourceManager().getMainFileID() &&
16393            "end of submodule in main source file");
16394     DirectiveLoc = getSourceManager().getIncludeLoc(File);
16395   } else {
16396     // We reached an EOM pragma. Use the pragma location.
16397     DirectiveLoc = EomLoc;
16398   }
16399   BuildModuleInclude(DirectiveLoc, Mod);
16400 
16401   // Any further declarations are in whatever module we returned to.
16402   if (getLangOpts().trackLocalOwningModule()) {
16403     // The parser guarantees that this is the same context that we entered
16404     // the module within.
16405     for (auto *DC = CurContext; DC; DC = DC->getLexicalParent()) {
16406       cast<Decl>(DC)->setLocalOwningModule(getCurrentModule());
16407       if (!getCurrentModule())
16408         cast<Decl>(DC)->setModuleOwnershipKind(
16409             Decl::ModuleOwnershipKind::Unowned);
16410     }
16411   }
16412 }
16413 
16414 void Sema::createImplicitModuleImportForErrorRecovery(SourceLocation Loc,
16415                                                       Module *Mod) {
16416   // Bail if we're not allowed to implicitly import a module here.
16417   if (isSFINAEContext() || !getLangOpts().ModulesErrorRecovery ||
16418       VisibleModules.isVisible(Mod))
16419     return;
16420 
16421   // Create the implicit import declaration.
16422   TranslationUnitDecl *TU = getASTContext().getTranslationUnitDecl();
16423   ImportDecl *ImportD = ImportDecl::CreateImplicit(getASTContext(), TU,
16424                                                    Loc, Mod, Loc);
16425   TU->addDecl(ImportD);
16426   Consumer.HandleImplicitImportDecl(ImportD);
16427 
16428   // Make the module visible.
16429   getModuleLoader().makeModuleVisible(Mod, Module::AllVisible, Loc);
16430   VisibleModules.setVisible(Mod, Loc);
16431 }
16432 
16433 /// We have parsed the start of an export declaration, including the '{'
16434 /// (if present).
16435 Decl *Sema::ActOnStartExportDecl(Scope *S, SourceLocation ExportLoc,
16436                                  SourceLocation LBraceLoc) {
16437   ExportDecl *D = ExportDecl::Create(Context, CurContext, ExportLoc);
16438 
16439   // C++ Modules TS draft:
16440   //   An export-declaration shall appear in the purview of a module other than
16441   //   the global module.
16442   if (ModuleScopes.empty() || !ModuleScopes.back().ModuleInterface)
16443     Diag(ExportLoc, diag::err_export_not_in_module_interface);
16444 
16445   //   An export-declaration [...] shall not contain more than one
16446   //   export keyword.
16447   //
16448   // The intent here is that an export-declaration cannot appear within another
16449   // export-declaration.
16450   if (D->isExported())
16451     Diag(ExportLoc, diag::err_export_within_export);
16452 
16453   CurContext->addDecl(D);
16454   PushDeclContext(S, D);
16455   D->setModuleOwnershipKind(Decl::ModuleOwnershipKind::VisibleWhenImported);
16456   return D;
16457 }
16458 
16459 /// Complete the definition of an export declaration.
16460 Decl *Sema::ActOnFinishExportDecl(Scope *S, Decl *D, SourceLocation RBraceLoc) {
16461   auto *ED = cast<ExportDecl>(D);
16462   if (RBraceLoc.isValid())
16463     ED->setRBraceLoc(RBraceLoc);
16464 
16465   // FIXME: Diagnose export of internal-linkage declaration (including
16466   // anonymous namespace).
16467 
16468   PopDeclContext();
16469   return D;
16470 }
16471 
16472 void Sema::ActOnPragmaRedefineExtname(IdentifierInfo* Name,
16473                                       IdentifierInfo* AliasName,
16474                                       SourceLocation PragmaLoc,
16475                                       SourceLocation NameLoc,
16476                                       SourceLocation AliasNameLoc) {
16477   NamedDecl *PrevDecl = LookupSingleName(TUScope, Name, NameLoc,
16478                                          LookupOrdinaryName);
16479   AsmLabelAttr *Attr =
16480       AsmLabelAttr::CreateImplicit(Context, AliasName->getName(), AliasNameLoc);
16481 
16482   // If a declaration that:
16483   // 1) declares a function or a variable
16484   // 2) has external linkage
16485   // already exists, add a label attribute to it.
16486   if (PrevDecl && (isa<FunctionDecl>(PrevDecl) || isa<VarDecl>(PrevDecl))) {
16487     if (isDeclExternC(PrevDecl))
16488       PrevDecl->addAttr(Attr);
16489     else
16490       Diag(PrevDecl->getLocation(), diag::warn_redefine_extname_not_applied)
16491           << /*Variable*/(isa<FunctionDecl>(PrevDecl) ? 0 : 1) << PrevDecl;
16492   // Otherwise, add a label atttibute to ExtnameUndeclaredIdentifiers.
16493   } else
16494     (void)ExtnameUndeclaredIdentifiers.insert(std::make_pair(Name, Attr));
16495 }
16496 
16497 void Sema::ActOnPragmaWeakID(IdentifierInfo* Name,
16498                              SourceLocation PragmaLoc,
16499                              SourceLocation NameLoc) {
16500   Decl *PrevDecl = LookupSingleName(TUScope, Name, NameLoc, LookupOrdinaryName);
16501 
16502   if (PrevDecl) {
16503     PrevDecl->addAttr(WeakAttr::CreateImplicit(Context, PragmaLoc));
16504   } else {
16505     (void)WeakUndeclaredIdentifiers.insert(
16506       std::pair<IdentifierInfo*,WeakInfo>
16507         (Name, WeakInfo((IdentifierInfo*)nullptr, NameLoc)));
16508   }
16509 }
16510 
16511 void Sema::ActOnPragmaWeakAlias(IdentifierInfo* Name,
16512                                 IdentifierInfo* AliasName,
16513                                 SourceLocation PragmaLoc,
16514                                 SourceLocation NameLoc,
16515                                 SourceLocation AliasNameLoc) {
16516   Decl *PrevDecl = LookupSingleName(TUScope, AliasName, AliasNameLoc,
16517                                     LookupOrdinaryName);
16518   WeakInfo W = WeakInfo(Name, NameLoc);
16519 
16520   if (PrevDecl && (isa<FunctionDecl>(PrevDecl) || isa<VarDecl>(PrevDecl))) {
16521     if (!PrevDecl->hasAttr<AliasAttr>())
16522       if (NamedDecl *ND = dyn_cast<NamedDecl>(PrevDecl))
16523         DeclApplyPragmaWeak(TUScope, ND, W);
16524   } else {
16525     (void)WeakUndeclaredIdentifiers.insert(
16526       std::pair<IdentifierInfo*,WeakInfo>(AliasName, W));
16527   }
16528 }
16529 
16530 Decl *Sema::getObjCDeclContext() const {
16531   return (dyn_cast_or_null<ObjCContainerDecl>(CurContext));
16532 }
16533