1 //===--- SemaAttr.cpp - Semantic Analysis for Attributes ------------------===//
2 //
3 //                     The LLVM Compiler Infrastructure
4 //
5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details.
7 //
8 //===----------------------------------------------------------------------===//
9 //
10 // This file implements semantic analysis for non-trivial attributes and
11 // pragmas.
12 //
13 //===----------------------------------------------------------------------===//
14 
15 #include "clang/Sema/SemaInternal.h"
16 #include "clang/AST/ASTConsumer.h"
17 #include "clang/AST/Attr.h"
18 #include "clang/AST/Expr.h"
19 #include "clang/Basic/TargetInfo.h"
20 #include "clang/Lex/Preprocessor.h"
21 #include "clang/Sema/Lookup.h"
22 using namespace clang;
23 
24 //===----------------------------------------------------------------------===//
25 // Pragma 'pack' and 'options align'
26 //===----------------------------------------------------------------------===//
27 
28 namespace {
29   struct PackStackEntry {
30     // We just use a sentinel to represent when the stack is set to mac68k
31     // alignment.
32     static const unsigned kMac68kAlignmentSentinel = ~0U;
33 
34     unsigned Alignment;
35     IdentifierInfo *Name;
36   };
37 
38   /// PragmaPackStack - Simple class to wrap the stack used by #pragma
39   /// pack.
40   class PragmaPackStack {
41     typedef std::vector<PackStackEntry> stack_ty;
42 
43     /// Alignment - The current user specified alignment.
44     unsigned Alignment;
45 
46     /// Stack - Entries in the #pragma pack stack, consisting of saved
47     /// alignments and optional names.
48     stack_ty Stack;
49 
50   public:
51     PragmaPackStack() : Alignment(0) {}
52 
53     void setAlignment(unsigned A) { Alignment = A; }
54     unsigned getAlignment() { return Alignment; }
55 
56     /// push - Push the current alignment onto the stack, optionally
57     /// using the given \arg Name for the record, if non-zero.
58     void push(IdentifierInfo *Name) {
59       PackStackEntry PSE = { Alignment, Name };
60       Stack.push_back(PSE);
61     }
62 
63     /// pop - Pop a record from the stack and restore the current
64     /// alignment to the previous value. If \arg Name is non-zero then
65     /// the first such named record is popped, otherwise the top record
66     /// is popped. Returns true if the pop succeeded.
67     bool pop(IdentifierInfo *Name, bool IsReset);
68   };
69 }  // end anonymous namespace.
70 
71 bool PragmaPackStack::pop(IdentifierInfo *Name, bool IsReset) {
72   // If name is empty just pop top.
73   if (!Name) {
74     // An empty stack is a special case...
75     if (Stack.empty()) {
76       // If this isn't a reset, it is always an error.
77       if (!IsReset)
78         return false;
79 
80       // Otherwise, it is an error only if some alignment has been set.
81       if (!Alignment)
82         return false;
83 
84       // Otherwise, reset to the default alignment.
85       Alignment = 0;
86     } else {
87       Alignment = Stack.back().Alignment;
88       Stack.pop_back();
89     }
90 
91     return true;
92   }
93 
94   // Otherwise, find the named record.
95   for (unsigned i = Stack.size(); i != 0; ) {
96     --i;
97     if (Stack[i].Name == Name) {
98       // Found it, pop up to and including this record.
99       Alignment = Stack[i].Alignment;
100       Stack.erase(Stack.begin() + i, Stack.end());
101       return true;
102     }
103   }
104 
105   return false;
106 }
107 
108 
109 /// FreePackedContext - Deallocate and null out PackContext.
110 void Sema::FreePackedContext() {
111   delete static_cast<PragmaPackStack*>(PackContext);
112   PackContext = nullptr;
113 }
114 
115 void Sema::AddAlignmentAttributesForRecord(RecordDecl *RD) {
116   // If there is no pack context, we don't need any attributes.
117   if (!PackContext)
118     return;
119 
120   PragmaPackStack *Stack = static_cast<PragmaPackStack*>(PackContext);
121 
122   // Otherwise, check to see if we need a max field alignment attribute.
123   if (unsigned Alignment = Stack->getAlignment()) {
124     if (Alignment == PackStackEntry::kMac68kAlignmentSentinel)
125       RD->addAttr(AlignMac68kAttr::CreateImplicit(Context));
126     else
127       RD->addAttr(MaxFieldAlignmentAttr::CreateImplicit(Context,
128                                                         Alignment * 8));
129   }
130 }
131 
132 void Sema::AddMsStructLayoutForRecord(RecordDecl *RD) {
133   if (MSStructPragmaOn)
134     RD->addAttr(MSStructAttr::CreateImplicit(Context));
135 
136   // FIXME: We should merge AddAlignmentAttributesForRecord with
137   // AddMsStructLayoutForRecord into AddPragmaAttributesForRecord, which takes
138   // all active pragmas and applies them as attributes to class definitions.
139   if (VtorDispModeStack.back() != getLangOpts().VtorDispMode)
140     RD->addAttr(
141         MSVtorDispAttr::CreateImplicit(Context, VtorDispModeStack.back()));
142 }
143 
144 void Sema::ActOnPragmaOptionsAlign(PragmaOptionsAlignKind Kind,
145                                    SourceLocation PragmaLoc) {
146   if (!PackContext)
147     PackContext = new PragmaPackStack();
148 
149   PragmaPackStack *Context = static_cast<PragmaPackStack*>(PackContext);
150 
151   switch (Kind) {
152     // For all targets we support native and natural are the same.
153     //
154     // FIXME: This is not true on Darwin/PPC.
155   case POAK_Native:
156   case POAK_Power:
157   case POAK_Natural:
158     Context->push(nullptr);
159     Context->setAlignment(0);
160     break;
161 
162     // Note that '#pragma options align=packed' is not equivalent to attribute
163     // packed, it has a different precedence relative to attribute aligned.
164   case POAK_Packed:
165     Context->push(nullptr);
166     Context->setAlignment(1);
167     break;
168 
169   case POAK_Mac68k:
170     // Check if the target supports this.
171     if (!this->Context.getTargetInfo().hasAlignMac68kSupport()) {
172       Diag(PragmaLoc, diag::err_pragma_options_align_mac68k_target_unsupported);
173       return;
174     }
175     Context->push(nullptr);
176     Context->setAlignment(PackStackEntry::kMac68kAlignmentSentinel);
177     break;
178 
179   case POAK_Reset:
180     // Reset just pops the top of the stack, or resets the current alignment to
181     // default.
182     if (!Context->pop(nullptr, /*IsReset=*/true)) {
183       Diag(PragmaLoc, diag::warn_pragma_options_align_reset_failed)
184         << "stack empty";
185     }
186     break;
187   }
188 }
189 
190 void Sema::ActOnPragmaPack(PragmaPackKind Kind, IdentifierInfo *Name,
191                            Expr *alignment, SourceLocation PragmaLoc,
192                            SourceLocation LParenLoc, SourceLocation RParenLoc) {
193   Expr *Alignment = static_cast<Expr *>(alignment);
194 
195   // If specified then alignment must be a "small" power of two.
196   unsigned AlignmentVal = 0;
197   if (Alignment) {
198     llvm::APSInt Val;
199 
200     // pack(0) is like pack(), which just works out since that is what
201     // we use 0 for in PackAttr.
202     if (Alignment->isTypeDependent() ||
203         Alignment->isValueDependent() ||
204         !Alignment->isIntegerConstantExpr(Val, Context) ||
205         !(Val == 0 || Val.isPowerOf2()) ||
206         Val.getZExtValue() > 16) {
207       Diag(PragmaLoc, diag::warn_pragma_pack_invalid_alignment);
208       return; // Ignore
209     }
210 
211     AlignmentVal = (unsigned) Val.getZExtValue();
212   }
213 
214   if (!PackContext)
215     PackContext = new PragmaPackStack();
216 
217   PragmaPackStack *Context = static_cast<PragmaPackStack*>(PackContext);
218 
219   switch (Kind) {
220   case Sema::PPK_Default: // pack([n])
221     Context->setAlignment(AlignmentVal);
222     break;
223 
224   case Sema::PPK_Show: // pack(show)
225     // Show the current alignment, making sure to show the right value
226     // for the default.
227     AlignmentVal = Context->getAlignment();
228     // FIXME: This should come from the target.
229     if (AlignmentVal == 0)
230       AlignmentVal = 8;
231     if (AlignmentVal == PackStackEntry::kMac68kAlignmentSentinel)
232       Diag(PragmaLoc, diag::warn_pragma_pack_show) << "mac68k";
233     else
234       Diag(PragmaLoc, diag::warn_pragma_pack_show) << AlignmentVal;
235     break;
236 
237   case Sema::PPK_Push: // pack(push [, id] [, [n])
238     Context->push(Name);
239     // Set the new alignment if specified.
240     if (Alignment)
241       Context->setAlignment(AlignmentVal);
242     break;
243 
244   case Sema::PPK_Pop: // pack(pop [, id] [,  n])
245     // MSDN, C/C++ Preprocessor Reference > Pragma Directives > pack:
246     // "#pragma pack(pop, identifier, n) is undefined"
247     if (Alignment && Name)
248       Diag(PragmaLoc, diag::warn_pragma_pack_pop_identifer_and_alignment);
249 
250     // Do the pop.
251     if (!Context->pop(Name, /*IsReset=*/false)) {
252       // If a name was specified then failure indicates the name
253       // wasn't found. Otherwise failure indicates the stack was
254       // empty.
255       Diag(PragmaLoc, diag::warn_pragma_pop_failed)
256           << "pack" << (Name ? "no record matching name" : "stack empty");
257 
258       // FIXME: Warn about popping named records as MSVC does.
259     } else {
260       // Pop succeeded, set the new alignment if specified.
261       if (Alignment)
262         Context->setAlignment(AlignmentVal);
263     }
264     break;
265   }
266 }
267 
268 void Sema::ActOnPragmaMSStruct(PragmaMSStructKind Kind) {
269   MSStructPragmaOn = (Kind == PMSST_ON);
270 }
271 
272 void Sema::ActOnPragmaMSComment(SourceLocation CommentLoc,
273                                 PragmaMSCommentKind Kind, StringRef Arg) {
274   auto *PCD = PragmaCommentDecl::Create(
275       Context, Context.getTranslationUnitDecl(), CommentLoc, Kind, Arg);
276   Context.getTranslationUnitDecl()->addDecl(PCD);
277   Consumer.HandleTopLevelDecl(DeclGroupRef(PCD));
278 }
279 
280 void Sema::ActOnPragmaDetectMismatch(SourceLocation Loc, StringRef Name,
281                                      StringRef Value) {
282   auto *PDMD = PragmaDetectMismatchDecl::Create(
283       Context, Context.getTranslationUnitDecl(), Loc, Name, Value);
284   Context.getTranslationUnitDecl()->addDecl(PDMD);
285   Consumer.HandleTopLevelDecl(DeclGroupRef(PDMD));
286 }
287 
288 void Sema::ActOnPragmaMSPointersToMembers(
289     LangOptions::PragmaMSPointersToMembersKind RepresentationMethod,
290     SourceLocation PragmaLoc) {
291   MSPointerToMemberRepresentationMethod = RepresentationMethod;
292   ImplicitMSInheritanceAttrLoc = PragmaLoc;
293 }
294 
295 void Sema::ActOnPragmaMSVtorDisp(PragmaVtorDispKind Kind,
296                                  SourceLocation PragmaLoc,
297                                  MSVtorDispAttr::Mode Mode) {
298   switch (Kind) {
299   case PVDK_Set:
300     VtorDispModeStack.back() = Mode;
301     break;
302   case PVDK_Push:
303     VtorDispModeStack.push_back(Mode);
304     break;
305   case PVDK_Reset:
306     VtorDispModeStack.clear();
307     VtorDispModeStack.push_back(MSVtorDispAttr::Mode(LangOpts.VtorDispMode));
308     break;
309   case PVDK_Pop:
310     VtorDispModeStack.pop_back();
311     if (VtorDispModeStack.empty()) {
312       Diag(PragmaLoc, diag::warn_pragma_pop_failed) << "vtordisp"
313                                                     << "stack empty";
314       VtorDispModeStack.push_back(MSVtorDispAttr::Mode(LangOpts.VtorDispMode));
315     }
316     break;
317   }
318 }
319 
320 template<typename ValueType>
321 void Sema::PragmaStack<ValueType>::Act(SourceLocation PragmaLocation,
322                                        PragmaMsStackAction Action,
323                                        llvm::StringRef StackSlotLabel,
324                                        ValueType Value) {
325   if (Action == PSK_Reset) {
326     CurrentValue = nullptr;
327     return;
328   }
329   if (Action & PSK_Push)
330     Stack.push_back(Slot(StackSlotLabel, CurrentValue, CurrentPragmaLocation));
331   else if (Action & PSK_Pop) {
332     if (!StackSlotLabel.empty()) {
333       // If we've got a label, try to find it and jump there.
334       auto I = std::find_if(Stack.rbegin(), Stack.rend(),
335         [&](const Slot &x) { return x.StackSlotLabel == StackSlotLabel; });
336       // If we found the label so pop from there.
337       if (I != Stack.rend()) {
338         CurrentValue = I->Value;
339         CurrentPragmaLocation = I->PragmaLocation;
340         Stack.erase(std::prev(I.base()), Stack.end());
341       }
342     } else if (!Stack.empty()) {
343       // We don't have a label, just pop the last entry.
344       CurrentValue = Stack.back().Value;
345       CurrentPragmaLocation = Stack.back().PragmaLocation;
346       Stack.pop_back();
347     }
348   }
349   if (Action & PSK_Set) {
350     CurrentValue = Value;
351     CurrentPragmaLocation = PragmaLocation;
352   }
353 }
354 
355 bool Sema::UnifySection(StringRef SectionName,
356                         int SectionFlags,
357                         DeclaratorDecl *Decl) {
358   auto Section = Context.SectionInfos.find(SectionName);
359   if (Section == Context.SectionInfos.end()) {
360     Context.SectionInfos[SectionName] =
361         ASTContext::SectionInfo(Decl, SourceLocation(), SectionFlags);
362     return false;
363   }
364   // A pre-declared section takes precedence w/o diagnostic.
365   if (Section->second.SectionFlags == SectionFlags ||
366       !(Section->second.SectionFlags & ASTContext::PSF_Implicit))
367     return false;
368   auto OtherDecl = Section->second.Decl;
369   Diag(Decl->getLocation(), diag::err_section_conflict)
370       << Decl << OtherDecl;
371   Diag(OtherDecl->getLocation(), diag::note_declared_at)
372       << OtherDecl->getName();
373   if (auto A = Decl->getAttr<SectionAttr>())
374     if (A->isImplicit())
375       Diag(A->getLocation(), diag::note_pragma_entered_here);
376   if (auto A = OtherDecl->getAttr<SectionAttr>())
377     if (A->isImplicit())
378       Diag(A->getLocation(), diag::note_pragma_entered_here);
379   return true;
380 }
381 
382 bool Sema::UnifySection(StringRef SectionName,
383                         int SectionFlags,
384                         SourceLocation PragmaSectionLocation) {
385   auto Section = Context.SectionInfos.find(SectionName);
386   if (Section != Context.SectionInfos.end()) {
387     if (Section->second.SectionFlags == SectionFlags)
388       return false;
389     if (!(Section->second.SectionFlags & ASTContext::PSF_Implicit)) {
390       Diag(PragmaSectionLocation, diag::err_section_conflict)
391           << "this" << "a prior #pragma section";
392       Diag(Section->second.PragmaSectionLocation,
393            diag::note_pragma_entered_here);
394       return true;
395     }
396   }
397   Context.SectionInfos[SectionName] =
398       ASTContext::SectionInfo(nullptr, PragmaSectionLocation, SectionFlags);
399   return false;
400 }
401 
402 /// \brief Called on well formed \#pragma bss_seg().
403 void Sema::ActOnPragmaMSSeg(SourceLocation PragmaLocation,
404                             PragmaMsStackAction Action,
405                             llvm::StringRef StackSlotLabel,
406                             StringLiteral *SegmentName,
407                             llvm::StringRef PragmaName) {
408   PragmaStack<StringLiteral *> *Stack =
409     llvm::StringSwitch<PragmaStack<StringLiteral *> *>(PragmaName)
410         .Case("data_seg", &DataSegStack)
411         .Case("bss_seg", &BSSSegStack)
412         .Case("const_seg", &ConstSegStack)
413         .Case("code_seg", &CodeSegStack);
414   if (Action & PSK_Pop && Stack->Stack.empty())
415     Diag(PragmaLocation, diag::warn_pragma_pop_failed) << PragmaName
416         << "stack empty";
417   if (SegmentName &&
418       !checkSectionName(SegmentName->getLocStart(), SegmentName->getString()))
419     return;
420   Stack->Act(PragmaLocation, Action, StackSlotLabel, SegmentName);
421 }
422 
423 /// \brief Called on well formed \#pragma bss_seg().
424 void Sema::ActOnPragmaMSSection(SourceLocation PragmaLocation,
425                                 int SectionFlags, StringLiteral *SegmentName) {
426   UnifySection(SegmentName->getString(), SectionFlags, PragmaLocation);
427 }
428 
429 void Sema::ActOnPragmaMSInitSeg(SourceLocation PragmaLocation,
430                                 StringLiteral *SegmentName) {
431   // There's no stack to maintain, so we just have a current section.  When we
432   // see the default section, reset our current section back to null so we stop
433   // tacking on unnecessary attributes.
434   CurInitSeg = SegmentName->getString() == ".CRT$XCU" ? nullptr : SegmentName;
435   CurInitSegLoc = PragmaLocation;
436 }
437 
438 void Sema::ActOnPragmaUnused(const Token &IdTok, Scope *curScope,
439                              SourceLocation PragmaLoc) {
440 
441   IdentifierInfo *Name = IdTok.getIdentifierInfo();
442   LookupResult Lookup(*this, Name, IdTok.getLocation(), LookupOrdinaryName);
443   LookupParsedName(Lookup, curScope, nullptr, true);
444 
445   if (Lookup.empty()) {
446     Diag(PragmaLoc, diag::warn_pragma_unused_undeclared_var)
447       << Name << SourceRange(IdTok.getLocation());
448     return;
449   }
450 
451   VarDecl *VD = Lookup.getAsSingle<VarDecl>();
452   if (!VD) {
453     Diag(PragmaLoc, diag::warn_pragma_unused_expected_var_arg)
454       << Name << SourceRange(IdTok.getLocation());
455     return;
456   }
457 
458   // Warn if this was used before being marked unused.
459   if (VD->isUsed())
460     Diag(PragmaLoc, diag::warn_used_but_marked_unused) << Name;
461 
462   VD->addAttr(UnusedAttr::CreateImplicit(Context, UnusedAttr::GNU_unused,
463                                          IdTok.getLocation()));
464 }
465 
466 void Sema::AddCFAuditedAttribute(Decl *D) {
467   SourceLocation Loc = PP.getPragmaARCCFCodeAuditedLoc();
468   if (!Loc.isValid()) return;
469 
470   // Don't add a redundant or conflicting attribute.
471   if (D->hasAttr<CFAuditedTransferAttr>() ||
472       D->hasAttr<CFUnknownTransferAttr>())
473     return;
474 
475   D->addAttr(CFAuditedTransferAttr::CreateImplicit(Context, Loc));
476 }
477 
478 void Sema::ActOnPragmaOptimize(bool On, SourceLocation PragmaLoc) {
479   if(On)
480     OptimizeOffPragmaLocation = SourceLocation();
481   else
482     OptimizeOffPragmaLocation = PragmaLoc;
483 }
484 
485 void Sema::AddRangeBasedOptnone(FunctionDecl *FD) {
486   // In the future, check other pragmas if they're implemented (e.g. pragma
487   // optimize 0 will probably map to this functionality too).
488   if(OptimizeOffPragmaLocation.isValid())
489     AddOptnoneAttributeIfNoConflicts(FD, OptimizeOffPragmaLocation);
490 }
491 
492 void Sema::AddOptnoneAttributeIfNoConflicts(FunctionDecl *FD,
493                                             SourceLocation Loc) {
494   // Don't add a conflicting attribute. No diagnostic is needed.
495   if (FD->hasAttr<MinSizeAttr>() || FD->hasAttr<AlwaysInlineAttr>())
496     return;
497 
498   // Add attributes only if required. Optnone requires noinline as well, but if
499   // either is already present then don't bother adding them.
500   if (!FD->hasAttr<OptimizeNoneAttr>())
501     FD->addAttr(OptimizeNoneAttr::CreateImplicit(Context, Loc));
502   if (!FD->hasAttr<NoInlineAttr>())
503     FD->addAttr(NoInlineAttr::CreateImplicit(Context, Loc));
504 }
505 
506 typedef std::vector<std::pair<unsigned, SourceLocation> > VisStack;
507 enum : unsigned { NoVisibility = ~0U };
508 
509 void Sema::AddPushedVisibilityAttribute(Decl *D) {
510   if (!VisContext)
511     return;
512 
513   NamedDecl *ND = dyn_cast<NamedDecl>(D);
514   if (ND && ND->getExplicitVisibility(NamedDecl::VisibilityForValue))
515     return;
516 
517   VisStack *Stack = static_cast<VisStack*>(VisContext);
518   unsigned rawType = Stack->back().first;
519   if (rawType == NoVisibility) return;
520 
521   VisibilityAttr::VisibilityType type
522     = (VisibilityAttr::VisibilityType) rawType;
523   SourceLocation loc = Stack->back().second;
524 
525   D->addAttr(VisibilityAttr::CreateImplicit(Context, type, loc));
526 }
527 
528 /// FreeVisContext - Deallocate and null out VisContext.
529 void Sema::FreeVisContext() {
530   delete static_cast<VisStack*>(VisContext);
531   VisContext = nullptr;
532 }
533 
534 static void PushPragmaVisibility(Sema &S, unsigned type, SourceLocation loc) {
535   // Put visibility on stack.
536   if (!S.VisContext)
537     S.VisContext = new VisStack;
538 
539   VisStack *Stack = static_cast<VisStack*>(S.VisContext);
540   Stack->push_back(std::make_pair(type, loc));
541 }
542 
543 void Sema::ActOnPragmaVisibility(const IdentifierInfo* VisType,
544                                  SourceLocation PragmaLoc) {
545   if (VisType) {
546     // Compute visibility to use.
547     VisibilityAttr::VisibilityType T;
548     if (!VisibilityAttr::ConvertStrToVisibilityType(VisType->getName(), T)) {
549       Diag(PragmaLoc, diag::warn_attribute_unknown_visibility) << VisType;
550       return;
551     }
552     PushPragmaVisibility(*this, T, PragmaLoc);
553   } else {
554     PopPragmaVisibility(false, PragmaLoc);
555   }
556 }
557 
558 void Sema::ActOnPragmaFPContract(tok::OnOffSwitch OOS) {
559   switch (OOS) {
560   case tok::OOS_ON:
561     FPFeatures.fp_contract = 1;
562     break;
563   case tok::OOS_OFF:
564     FPFeatures.fp_contract = 0;
565     break;
566   case tok::OOS_DEFAULT:
567     FPFeatures.fp_contract = getLangOpts().DefaultFPContract;
568     break;
569   }
570 }
571 
572 void Sema::PushNamespaceVisibilityAttr(const VisibilityAttr *Attr,
573                                        SourceLocation Loc) {
574   // Visibility calculations will consider the namespace's visibility.
575   // Here we just want to note that we're in a visibility context
576   // which overrides any enclosing #pragma context, but doesn't itself
577   // contribute visibility.
578   PushPragmaVisibility(*this, NoVisibility, Loc);
579 }
580 
581 void Sema::PopPragmaVisibility(bool IsNamespaceEnd, SourceLocation EndLoc) {
582   if (!VisContext) {
583     Diag(EndLoc, diag::err_pragma_pop_visibility_mismatch);
584     return;
585   }
586 
587   // Pop visibility from stack
588   VisStack *Stack = static_cast<VisStack*>(VisContext);
589 
590   const std::pair<unsigned, SourceLocation> *Back = &Stack->back();
591   bool StartsWithPragma = Back->first != NoVisibility;
592   if (StartsWithPragma && IsNamespaceEnd) {
593     Diag(Back->second, diag::err_pragma_push_visibility_mismatch);
594     Diag(EndLoc, diag::note_surrounding_namespace_ends_here);
595 
596     // For better error recovery, eat all pushes inside the namespace.
597     do {
598       Stack->pop_back();
599       Back = &Stack->back();
600       StartsWithPragma = Back->first != NoVisibility;
601     } while (StartsWithPragma);
602   } else if (!StartsWithPragma && !IsNamespaceEnd) {
603     Diag(EndLoc, diag::err_pragma_pop_visibility_mismatch);
604     Diag(Back->second, diag::note_surrounding_namespace_starts_here);
605     return;
606   }
607 
608   Stack->pop_back();
609   // To simplify the implementation, never keep around an empty stack.
610   if (Stack->empty())
611     FreeVisContext();
612 }
613