1 //==- UninitializedValues.cpp - Find Uninitialized Values -------*- C++ --*-==// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // This file implements uninitialized values analysis for source-level CFGs. 11 // 12 //===----------------------------------------------------------------------===// 13 14 #include "clang/AST/ASTContext.h" 15 #include "clang/AST/Attr.h" 16 #include "clang/AST/Decl.h" 17 #include "clang/AST/StmtVisitor.h" 18 #include "clang/Analysis/Analyses/PostOrderCFGView.h" 19 #include "clang/Analysis/Analyses/UninitializedValues.h" 20 #include "clang/Analysis/AnalysisContext.h" 21 #include "clang/Analysis/CFG.h" 22 #include "clang/Analysis/DomainSpecific/ObjCNoReturn.h" 23 #include "llvm/ADT/DenseMap.h" 24 #include "llvm/ADT/Optional.h" 25 #include "llvm/ADT/PackedVector.h" 26 #include "llvm/ADT/SmallBitVector.h" 27 #include "llvm/ADT/SmallVector.h" 28 #include "llvm/Support/SaveAndRestore.h" 29 #include <utility> 30 31 using namespace clang; 32 33 #define DEBUG_LOGGING 0 34 35 static bool isTrackedVar(const VarDecl *vd, const DeclContext *dc) { 36 if (vd->isLocalVarDecl() && !vd->hasGlobalStorage() && 37 !vd->isExceptionVariable() && !vd->isInitCapture() && 38 vd->getDeclContext() == dc) { 39 QualType ty = vd->getType(); 40 return ty->isScalarType() || ty->isVectorType(); 41 } 42 return false; 43 } 44 45 //------------------------------------------------------------------------====// 46 // DeclToIndex: a mapping from Decls we track to value indices. 47 //====------------------------------------------------------------------------// 48 49 namespace { 50 class DeclToIndex { 51 llvm::DenseMap<const VarDecl *, unsigned> map; 52 public: 53 DeclToIndex() {} 54 55 /// Compute the actual mapping from declarations to bits. 56 void computeMap(const DeclContext &dc); 57 58 /// Return the number of declarations in the map. 59 unsigned size() const { return map.size(); } 60 61 /// Returns the bit vector index for a given declaration. 62 Optional<unsigned> getValueIndex(const VarDecl *d) const; 63 }; 64 } 65 66 void DeclToIndex::computeMap(const DeclContext &dc) { 67 unsigned count = 0; 68 DeclContext::specific_decl_iterator<VarDecl> I(dc.decls_begin()), 69 E(dc.decls_end()); 70 for ( ; I != E; ++I) { 71 const VarDecl *vd = *I; 72 if (isTrackedVar(vd, &dc)) 73 map[vd] = count++; 74 } 75 } 76 77 Optional<unsigned> DeclToIndex::getValueIndex(const VarDecl *d) const { 78 llvm::DenseMap<const VarDecl *, unsigned>::const_iterator I = map.find(d); 79 if (I == map.end()) 80 return None; 81 return I->second; 82 } 83 84 //------------------------------------------------------------------------====// 85 // CFGBlockValues: dataflow values for CFG blocks. 86 //====------------------------------------------------------------------------// 87 88 // These values are defined in such a way that a merge can be done using 89 // a bitwise OR. 90 enum Value { Unknown = 0x0, /* 00 */ 91 Initialized = 0x1, /* 01 */ 92 Uninitialized = 0x2, /* 10 */ 93 MayUninitialized = 0x3 /* 11 */ }; 94 95 static bool isUninitialized(const Value v) { 96 return v >= Uninitialized; 97 } 98 static bool isAlwaysUninit(const Value v) { 99 return v == Uninitialized; 100 } 101 102 namespace { 103 104 typedef llvm::PackedVector<Value, 2, llvm::SmallBitVector> ValueVector; 105 106 class CFGBlockValues { 107 const CFG &cfg; 108 SmallVector<ValueVector, 8> vals; 109 ValueVector scratch; 110 DeclToIndex declToIndex; 111 public: 112 CFGBlockValues(const CFG &cfg); 113 114 unsigned getNumEntries() const { return declToIndex.size(); } 115 116 void computeSetOfDeclarations(const DeclContext &dc); 117 ValueVector &getValueVector(const CFGBlock *block) { 118 return vals[block->getBlockID()]; 119 } 120 121 void setAllScratchValues(Value V); 122 void mergeIntoScratch(ValueVector const &source, bool isFirst); 123 bool updateValueVectorWithScratch(const CFGBlock *block); 124 125 bool hasNoDeclarations() const { 126 return declToIndex.size() == 0; 127 } 128 129 void resetScratch(); 130 131 ValueVector::reference operator[](const VarDecl *vd); 132 133 Value getValue(const CFGBlock *block, const CFGBlock *dstBlock, 134 const VarDecl *vd) { 135 const Optional<unsigned> &idx = declToIndex.getValueIndex(vd); 136 assert(idx.hasValue()); 137 return getValueVector(block)[idx.getValue()]; 138 } 139 }; 140 } // end anonymous namespace 141 142 CFGBlockValues::CFGBlockValues(const CFG &c) : cfg(c), vals(0) {} 143 144 void CFGBlockValues::computeSetOfDeclarations(const DeclContext &dc) { 145 declToIndex.computeMap(dc); 146 unsigned decls = declToIndex.size(); 147 scratch.resize(decls); 148 unsigned n = cfg.getNumBlockIDs(); 149 if (!n) 150 return; 151 vals.resize(n); 152 for (unsigned i = 0; i < n; ++i) 153 vals[i].resize(decls); 154 } 155 156 #if DEBUG_LOGGING 157 static void printVector(const CFGBlock *block, ValueVector &bv, 158 unsigned num) { 159 llvm::errs() << block->getBlockID() << " :"; 160 for (unsigned i = 0; i < bv.size(); ++i) { 161 llvm::errs() << ' ' << bv[i]; 162 } 163 llvm::errs() << " : " << num << '\n'; 164 } 165 #endif 166 167 void CFGBlockValues::setAllScratchValues(Value V) { 168 for (unsigned I = 0, E = scratch.size(); I != E; ++I) 169 scratch[I] = V; 170 } 171 172 void CFGBlockValues::mergeIntoScratch(ValueVector const &source, 173 bool isFirst) { 174 if (isFirst) 175 scratch = source; 176 else 177 scratch |= source; 178 } 179 180 bool CFGBlockValues::updateValueVectorWithScratch(const CFGBlock *block) { 181 ValueVector &dst = getValueVector(block); 182 bool changed = (dst != scratch); 183 if (changed) 184 dst = scratch; 185 #if DEBUG_LOGGING 186 printVector(block, scratch, 0); 187 #endif 188 return changed; 189 } 190 191 void CFGBlockValues::resetScratch() { 192 scratch.reset(); 193 } 194 195 ValueVector::reference CFGBlockValues::operator[](const VarDecl *vd) { 196 const Optional<unsigned> &idx = declToIndex.getValueIndex(vd); 197 assert(idx.hasValue()); 198 return scratch[idx.getValue()]; 199 } 200 201 //------------------------------------------------------------------------====// 202 // Worklist: worklist for dataflow analysis. 203 //====------------------------------------------------------------------------// 204 205 namespace { 206 class DataflowWorklist { 207 PostOrderCFGView::iterator PO_I, PO_E; 208 SmallVector<const CFGBlock *, 20> worklist; 209 llvm::BitVector enqueuedBlocks; 210 public: 211 DataflowWorklist(const CFG &cfg, PostOrderCFGView &view) 212 : PO_I(view.begin()), PO_E(view.end()), 213 enqueuedBlocks(cfg.getNumBlockIDs(), true) { 214 // Treat the first block as already analyzed. 215 if (PO_I != PO_E) { 216 assert(*PO_I == &cfg.getEntry()); 217 enqueuedBlocks[(*PO_I)->getBlockID()] = false; 218 ++PO_I; 219 } 220 } 221 222 void enqueueSuccessors(const CFGBlock *block); 223 const CFGBlock *dequeue(); 224 }; 225 } 226 227 void DataflowWorklist::enqueueSuccessors(const clang::CFGBlock *block) { 228 for (CFGBlock::const_succ_iterator I = block->succ_begin(), 229 E = block->succ_end(); I != E; ++I) { 230 const CFGBlock *Successor = *I; 231 if (!Successor || enqueuedBlocks[Successor->getBlockID()]) 232 continue; 233 worklist.push_back(Successor); 234 enqueuedBlocks[Successor->getBlockID()] = true; 235 } 236 } 237 238 const CFGBlock *DataflowWorklist::dequeue() { 239 const CFGBlock *B = nullptr; 240 241 // First dequeue from the worklist. This can represent 242 // updates along backedges that we want propagated as quickly as possible. 243 if (!worklist.empty()) 244 B = worklist.pop_back_val(); 245 246 // Next dequeue from the initial reverse post order. This is the 247 // theoretical ideal in the presence of no back edges. 248 else if (PO_I != PO_E) { 249 B = *PO_I; 250 ++PO_I; 251 } 252 else { 253 return nullptr; 254 } 255 256 assert(enqueuedBlocks[B->getBlockID()] == true); 257 enqueuedBlocks[B->getBlockID()] = false; 258 return B; 259 } 260 261 //------------------------------------------------------------------------====// 262 // Classification of DeclRefExprs as use or initialization. 263 //====------------------------------------------------------------------------// 264 265 namespace { 266 class FindVarResult { 267 const VarDecl *vd; 268 const DeclRefExpr *dr; 269 public: 270 FindVarResult(const VarDecl *vd, const DeclRefExpr *dr) : vd(vd), dr(dr) {} 271 272 const DeclRefExpr *getDeclRefExpr() const { return dr; } 273 const VarDecl *getDecl() const { return vd; } 274 }; 275 276 static const Expr *stripCasts(ASTContext &C, const Expr *Ex) { 277 while (Ex) { 278 Ex = Ex->IgnoreParenNoopCasts(C); 279 if (const CastExpr *CE = dyn_cast<CastExpr>(Ex)) { 280 if (CE->getCastKind() == CK_LValueBitCast) { 281 Ex = CE->getSubExpr(); 282 continue; 283 } 284 } 285 break; 286 } 287 return Ex; 288 } 289 290 /// If E is an expression comprising a reference to a single variable, find that 291 /// variable. 292 static FindVarResult findVar(const Expr *E, const DeclContext *DC) { 293 if (const DeclRefExpr *DRE = 294 dyn_cast<DeclRefExpr>(stripCasts(DC->getParentASTContext(), E))) 295 if (const VarDecl *VD = dyn_cast<VarDecl>(DRE->getDecl())) 296 if (isTrackedVar(VD, DC)) 297 return FindVarResult(VD, DRE); 298 return FindVarResult(nullptr, nullptr); 299 } 300 301 /// \brief Classify each DeclRefExpr as an initialization or a use. Any 302 /// DeclRefExpr which isn't explicitly classified will be assumed to have 303 /// escaped the analysis and will be treated as an initialization. 304 class ClassifyRefs : public StmtVisitor<ClassifyRefs> { 305 public: 306 enum Class { 307 Init, 308 Use, 309 SelfInit, 310 Ignore 311 }; 312 313 private: 314 const DeclContext *DC; 315 llvm::DenseMap<const DeclRefExpr*, Class> Classification; 316 317 bool isTrackedVar(const VarDecl *VD) const { 318 return ::isTrackedVar(VD, DC); 319 } 320 321 void classify(const Expr *E, Class C); 322 323 public: 324 ClassifyRefs(AnalysisDeclContext &AC) : DC(cast<DeclContext>(AC.getDecl())) {} 325 326 void VisitDeclStmt(DeclStmt *DS); 327 void VisitUnaryOperator(UnaryOperator *UO); 328 void VisitBinaryOperator(BinaryOperator *BO); 329 void VisitCallExpr(CallExpr *CE); 330 void VisitCastExpr(CastExpr *CE); 331 332 void operator()(Stmt *S) { Visit(S); } 333 334 Class get(const DeclRefExpr *DRE) const { 335 llvm::DenseMap<const DeclRefExpr*, Class>::const_iterator I 336 = Classification.find(DRE); 337 if (I != Classification.end()) 338 return I->second; 339 340 const VarDecl *VD = dyn_cast<VarDecl>(DRE->getDecl()); 341 if (!VD || !isTrackedVar(VD)) 342 return Ignore; 343 344 return Init; 345 } 346 }; 347 } 348 349 static const DeclRefExpr *getSelfInitExpr(VarDecl *VD) { 350 if (Expr *Init = VD->getInit()) { 351 const DeclRefExpr *DRE 352 = dyn_cast<DeclRefExpr>(stripCasts(VD->getASTContext(), Init)); 353 if (DRE && DRE->getDecl() == VD) 354 return DRE; 355 } 356 return nullptr; 357 } 358 359 void ClassifyRefs::classify(const Expr *E, Class C) { 360 // The result of a ?: could also be an lvalue. 361 E = E->IgnoreParens(); 362 if (const ConditionalOperator *CO = dyn_cast<ConditionalOperator>(E)) { 363 classify(CO->getTrueExpr(), C); 364 classify(CO->getFalseExpr(), C); 365 return; 366 } 367 368 if (const BinaryConditionalOperator *BCO = 369 dyn_cast<BinaryConditionalOperator>(E)) { 370 classify(BCO->getFalseExpr(), C); 371 return; 372 } 373 374 if (const OpaqueValueExpr *OVE = dyn_cast<OpaqueValueExpr>(E)) { 375 classify(OVE->getSourceExpr(), C); 376 return; 377 } 378 379 if (const BinaryOperator *BO = dyn_cast<BinaryOperator>(E)) { 380 if (BO->getOpcode() == BO_Comma) 381 classify(BO->getRHS(), C); 382 return; 383 } 384 385 FindVarResult Var = findVar(E, DC); 386 if (const DeclRefExpr *DRE = Var.getDeclRefExpr()) 387 Classification[DRE] = std::max(Classification[DRE], C); 388 } 389 390 void ClassifyRefs::VisitDeclStmt(DeclStmt *DS) { 391 for (auto *DI : DS->decls()) { 392 VarDecl *VD = dyn_cast<VarDecl>(DI); 393 if (VD && isTrackedVar(VD)) 394 if (const DeclRefExpr *DRE = getSelfInitExpr(VD)) 395 Classification[DRE] = SelfInit; 396 } 397 } 398 399 void ClassifyRefs::VisitBinaryOperator(BinaryOperator *BO) { 400 // Ignore the evaluation of a DeclRefExpr on the LHS of an assignment. If this 401 // is not a compound-assignment, we will treat it as initializing the variable 402 // when TransferFunctions visits it. A compound-assignment does not affect 403 // whether a variable is uninitialized, and there's no point counting it as a 404 // use. 405 if (BO->isCompoundAssignmentOp()) 406 classify(BO->getLHS(), Use); 407 else if (BO->getOpcode() == BO_Assign) 408 classify(BO->getLHS(), Ignore); 409 } 410 411 void ClassifyRefs::VisitUnaryOperator(UnaryOperator *UO) { 412 // Increment and decrement are uses despite there being no lvalue-to-rvalue 413 // conversion. 414 if (UO->isIncrementDecrementOp()) 415 classify(UO->getSubExpr(), Use); 416 } 417 418 void ClassifyRefs::VisitCallExpr(CallExpr *CE) { 419 // Classify arguments to std::move as used. 420 if (CE->getNumArgs() == 1) { 421 if (FunctionDecl *FD = CE->getDirectCallee()) { 422 if (FD->getIdentifier() && FD->getIdentifier()->isStr("move")) { 423 classify(CE->getArg(0), Use); 424 return; 425 } 426 } 427 } 428 429 // If a value is passed by const reference to a function, we should not assume 430 // that it is initialized by the call, and we conservatively do not assume 431 // that it is used. 432 for (CallExpr::arg_iterator I = CE->arg_begin(), E = CE->arg_end(); 433 I != E; ++I) 434 if ((*I)->getType().isConstQualified() && (*I)->isGLValue()) 435 classify(*I, Ignore); 436 } 437 438 void ClassifyRefs::VisitCastExpr(CastExpr *CE) { 439 if (CE->getCastKind() == CK_LValueToRValue) 440 classify(CE->getSubExpr(), Use); 441 else if (CStyleCastExpr *CSE = dyn_cast<CStyleCastExpr>(CE)) { 442 if (CSE->getType()->isVoidType()) { 443 // Squelch any detected load of an uninitialized value if 444 // we cast it to void. 445 // e.g. (void) x; 446 classify(CSE->getSubExpr(), Ignore); 447 } 448 } 449 } 450 451 //------------------------------------------------------------------------====// 452 // Transfer function for uninitialized values analysis. 453 //====------------------------------------------------------------------------// 454 455 namespace { 456 class TransferFunctions : public StmtVisitor<TransferFunctions> { 457 CFGBlockValues &vals; 458 const CFG &cfg; 459 const CFGBlock *block; 460 AnalysisDeclContext ∾ 461 const ClassifyRefs &classification; 462 ObjCNoReturn objCNoRet; 463 UninitVariablesHandler &handler; 464 465 public: 466 TransferFunctions(CFGBlockValues &vals, const CFG &cfg, 467 const CFGBlock *block, AnalysisDeclContext &ac, 468 const ClassifyRefs &classification, 469 UninitVariablesHandler &handler) 470 : vals(vals), cfg(cfg), block(block), ac(ac), 471 classification(classification), objCNoRet(ac.getASTContext()), 472 handler(handler) {} 473 474 void reportUse(const Expr *ex, const VarDecl *vd); 475 476 void VisitBinaryOperator(BinaryOperator *bo); 477 void VisitBlockExpr(BlockExpr *be); 478 void VisitCallExpr(CallExpr *ce); 479 void VisitDeclRefExpr(DeclRefExpr *dr); 480 void VisitDeclStmt(DeclStmt *ds); 481 void VisitObjCForCollectionStmt(ObjCForCollectionStmt *FS); 482 void VisitObjCMessageExpr(ObjCMessageExpr *ME); 483 484 bool isTrackedVar(const VarDecl *vd) { 485 return ::isTrackedVar(vd, cast<DeclContext>(ac.getDecl())); 486 } 487 488 FindVarResult findVar(const Expr *ex) { 489 return ::findVar(ex, cast<DeclContext>(ac.getDecl())); 490 } 491 492 UninitUse getUninitUse(const Expr *ex, const VarDecl *vd, Value v) { 493 UninitUse Use(ex, isAlwaysUninit(v)); 494 495 assert(isUninitialized(v)); 496 if (Use.getKind() == UninitUse::Always) 497 return Use; 498 499 // If an edge which leads unconditionally to this use did not initialize 500 // the variable, we can say something stronger than 'may be uninitialized': 501 // we can say 'either it's used uninitialized or you have dead code'. 502 // 503 // We track the number of successors of a node which have been visited, and 504 // visit a node once we have visited all of its successors. Only edges where 505 // the variable might still be uninitialized are followed. Since a variable 506 // can't transfer from being initialized to being uninitialized, this will 507 // trace out the subgraph which inevitably leads to the use and does not 508 // initialize the variable. We do not want to skip past loops, since their 509 // non-termination might be correlated with the initialization condition. 510 // 511 // For example: 512 // 513 // void f(bool a, bool b) { 514 // block1: int n; 515 // if (a) { 516 // block2: if (b) 517 // block3: n = 1; 518 // block4: } else if (b) { 519 // block5: while (!a) { 520 // block6: do_work(&a); 521 // n = 2; 522 // } 523 // } 524 // block7: if (a) 525 // block8: g(); 526 // block9: return n; 527 // } 528 // 529 // Starting from the maybe-uninitialized use in block 9: 530 // * Block 7 is not visited because we have only visited one of its two 531 // successors. 532 // * Block 8 is visited because we've visited its only successor. 533 // From block 8: 534 // * Block 7 is visited because we've now visited both of its successors. 535 // From block 7: 536 // * Blocks 1, 2, 4, 5, and 6 are not visited because we didn't visit all 537 // of their successors (we didn't visit 4, 3, 5, 6, and 5, respectively). 538 // * Block 3 is not visited because it initializes 'n'. 539 // Now the algorithm terminates, having visited blocks 7 and 8, and having 540 // found the frontier is blocks 2, 4, and 5. 541 // 542 // 'n' is definitely uninitialized for two edges into block 7 (from blocks 2 543 // and 4), so we report that any time either of those edges is taken (in 544 // each case when 'b == false'), 'n' is used uninitialized. 545 SmallVector<const CFGBlock*, 32> Queue; 546 SmallVector<unsigned, 32> SuccsVisited(cfg.getNumBlockIDs(), 0); 547 Queue.push_back(block); 548 // Specify that we've already visited all successors of the starting block. 549 // This has the dual purpose of ensuring we never add it to the queue, and 550 // of marking it as not being a candidate element of the frontier. 551 SuccsVisited[block->getBlockID()] = block->succ_size(); 552 while (!Queue.empty()) { 553 const CFGBlock *B = Queue.pop_back_val(); 554 555 // If the use is always reached from the entry block, make a note of that. 556 if (B == &cfg.getEntry()) 557 Use.setUninitAfterCall(); 558 559 for (CFGBlock::const_pred_iterator I = B->pred_begin(), E = B->pred_end(); 560 I != E; ++I) { 561 const CFGBlock *Pred = *I; 562 if (!Pred) 563 continue; 564 565 Value AtPredExit = vals.getValue(Pred, B, vd); 566 if (AtPredExit == Initialized) 567 // This block initializes the variable. 568 continue; 569 if (AtPredExit == MayUninitialized && 570 vals.getValue(B, nullptr, vd) == Uninitialized) { 571 // This block declares the variable (uninitialized), and is reachable 572 // from a block that initializes the variable. We can't guarantee to 573 // give an earlier location for the diagnostic (and it appears that 574 // this code is intended to be reachable) so give a diagnostic here 575 // and go no further down this path. 576 Use.setUninitAfterDecl(); 577 continue; 578 } 579 580 unsigned &SV = SuccsVisited[Pred->getBlockID()]; 581 if (!SV) { 582 // When visiting the first successor of a block, mark all NULL 583 // successors as having been visited. 584 for (CFGBlock::const_succ_iterator SI = Pred->succ_begin(), 585 SE = Pred->succ_end(); 586 SI != SE; ++SI) 587 if (!*SI) 588 ++SV; 589 } 590 591 if (++SV == Pred->succ_size()) 592 // All paths from this block lead to the use and don't initialize the 593 // variable. 594 Queue.push_back(Pred); 595 } 596 } 597 598 // Scan the frontier, looking for blocks where the variable was 599 // uninitialized. 600 for (CFG::const_iterator BI = cfg.begin(), BE = cfg.end(); BI != BE; ++BI) { 601 const CFGBlock *Block = *BI; 602 unsigned BlockID = Block->getBlockID(); 603 const Stmt *Term = Block->getTerminator(); 604 if (SuccsVisited[BlockID] && SuccsVisited[BlockID] < Block->succ_size() && 605 Term) { 606 // This block inevitably leads to the use. If we have an edge from here 607 // to a post-dominator block, and the variable is uninitialized on that 608 // edge, we have found a bug. 609 for (CFGBlock::const_succ_iterator I = Block->succ_begin(), 610 E = Block->succ_end(); I != E; ++I) { 611 const CFGBlock *Succ = *I; 612 if (Succ && SuccsVisited[Succ->getBlockID()] >= Succ->succ_size() && 613 vals.getValue(Block, Succ, vd) == Uninitialized) { 614 // Switch cases are a special case: report the label to the caller 615 // as the 'terminator', not the switch statement itself. Suppress 616 // situations where no label matched: we can't be sure that's 617 // possible. 618 if (isa<SwitchStmt>(Term)) { 619 const Stmt *Label = Succ->getLabel(); 620 if (!Label || !isa<SwitchCase>(Label)) 621 // Might not be possible. 622 continue; 623 UninitUse::Branch Branch; 624 Branch.Terminator = Label; 625 Branch.Output = 0; // Ignored. 626 Use.addUninitBranch(Branch); 627 } else { 628 UninitUse::Branch Branch; 629 Branch.Terminator = Term; 630 Branch.Output = I - Block->succ_begin(); 631 Use.addUninitBranch(Branch); 632 } 633 } 634 } 635 } 636 } 637 638 return Use; 639 } 640 }; 641 } 642 643 void TransferFunctions::reportUse(const Expr *ex, const VarDecl *vd) { 644 Value v = vals[vd]; 645 if (isUninitialized(v)) 646 handler.handleUseOfUninitVariable(vd, getUninitUse(ex, vd, v)); 647 } 648 649 void TransferFunctions::VisitObjCForCollectionStmt(ObjCForCollectionStmt *FS) { 650 // This represents an initialization of the 'element' value. 651 if (DeclStmt *DS = dyn_cast<DeclStmt>(FS->getElement())) { 652 const VarDecl *VD = cast<VarDecl>(DS->getSingleDecl()); 653 if (isTrackedVar(VD)) 654 vals[VD] = Initialized; 655 } 656 } 657 658 void TransferFunctions::VisitBlockExpr(BlockExpr *be) { 659 const BlockDecl *bd = be->getBlockDecl(); 660 for (const auto &I : bd->captures()) { 661 const VarDecl *vd = I.getVariable(); 662 if (!isTrackedVar(vd)) 663 continue; 664 if (I.isByRef()) { 665 vals[vd] = Initialized; 666 continue; 667 } 668 reportUse(be, vd); 669 } 670 } 671 672 void TransferFunctions::VisitCallExpr(CallExpr *ce) { 673 if (Decl *Callee = ce->getCalleeDecl()) { 674 if (Callee->hasAttr<ReturnsTwiceAttr>()) { 675 // After a call to a function like setjmp or vfork, any variable which is 676 // initialized anywhere within this function may now be initialized. For 677 // now, just assume such a call initializes all variables. FIXME: Only 678 // mark variables as initialized if they have an initializer which is 679 // reachable from here. 680 vals.setAllScratchValues(Initialized); 681 } 682 else if (Callee->hasAttr<AnalyzerNoReturnAttr>()) { 683 // Functions labeled like "analyzer_noreturn" are often used to denote 684 // "panic" functions that in special debug situations can still return, 685 // but for the most part should not be treated as returning. This is a 686 // useful annotation borrowed from the static analyzer that is useful for 687 // suppressing branch-specific false positives when we call one of these 688 // functions but keep pretending the path continues (when in reality the 689 // user doesn't care). 690 vals.setAllScratchValues(Unknown); 691 } 692 } 693 } 694 695 void TransferFunctions::VisitDeclRefExpr(DeclRefExpr *dr) { 696 switch (classification.get(dr)) { 697 case ClassifyRefs::Ignore: 698 break; 699 case ClassifyRefs::Use: 700 reportUse(dr, cast<VarDecl>(dr->getDecl())); 701 break; 702 case ClassifyRefs::Init: 703 vals[cast<VarDecl>(dr->getDecl())] = Initialized; 704 break; 705 case ClassifyRefs::SelfInit: 706 handler.handleSelfInit(cast<VarDecl>(dr->getDecl())); 707 break; 708 } 709 } 710 711 void TransferFunctions::VisitBinaryOperator(BinaryOperator *BO) { 712 if (BO->getOpcode() == BO_Assign) { 713 FindVarResult Var = findVar(BO->getLHS()); 714 if (const VarDecl *VD = Var.getDecl()) 715 vals[VD] = Initialized; 716 } 717 } 718 719 void TransferFunctions::VisitDeclStmt(DeclStmt *DS) { 720 for (auto *DI : DS->decls()) { 721 VarDecl *VD = dyn_cast<VarDecl>(DI); 722 if (VD && isTrackedVar(VD)) { 723 if (getSelfInitExpr(VD)) { 724 // If the initializer consists solely of a reference to itself, we 725 // explicitly mark the variable as uninitialized. This allows code 726 // like the following: 727 // 728 // int x = x; 729 // 730 // to deliberately leave a variable uninitialized. Different analysis 731 // clients can detect this pattern and adjust their reporting 732 // appropriately, but we need to continue to analyze subsequent uses 733 // of the variable. 734 vals[VD] = Uninitialized; 735 } else if (VD->getInit()) { 736 // Treat the new variable as initialized. 737 vals[VD] = Initialized; 738 } else { 739 // No initializer: the variable is now uninitialized. This matters 740 // for cases like: 741 // while (...) { 742 // int n; 743 // use(n); 744 // n = 0; 745 // } 746 // FIXME: Mark the variable as uninitialized whenever its scope is 747 // left, since its scope could be re-entered by a jump over the 748 // declaration. 749 vals[VD] = Uninitialized; 750 } 751 } 752 } 753 } 754 755 void TransferFunctions::VisitObjCMessageExpr(ObjCMessageExpr *ME) { 756 // If the Objective-C message expression is an implicit no-return that 757 // is not modeled in the CFG, set the tracked dataflow values to Unknown. 758 if (objCNoRet.isImplicitNoReturn(ME)) { 759 vals.setAllScratchValues(Unknown); 760 } 761 } 762 763 //------------------------------------------------------------------------====// 764 // High-level "driver" logic for uninitialized values analysis. 765 //====------------------------------------------------------------------------// 766 767 static bool runOnBlock(const CFGBlock *block, const CFG &cfg, 768 AnalysisDeclContext &ac, CFGBlockValues &vals, 769 const ClassifyRefs &classification, 770 llvm::BitVector &wasAnalyzed, 771 UninitVariablesHandler &handler) { 772 wasAnalyzed[block->getBlockID()] = true; 773 vals.resetScratch(); 774 // Merge in values of predecessor blocks. 775 bool isFirst = true; 776 for (CFGBlock::const_pred_iterator I = block->pred_begin(), 777 E = block->pred_end(); I != E; ++I) { 778 const CFGBlock *pred = *I; 779 if (!pred) 780 continue; 781 if (wasAnalyzed[pred->getBlockID()]) { 782 vals.mergeIntoScratch(vals.getValueVector(pred), isFirst); 783 isFirst = false; 784 } 785 } 786 // Apply the transfer function. 787 TransferFunctions tf(vals, cfg, block, ac, classification, handler); 788 for (CFGBlock::const_iterator I = block->begin(), E = block->end(); 789 I != E; ++I) { 790 if (Optional<CFGStmt> cs = I->getAs<CFGStmt>()) 791 tf.Visit(const_cast<Stmt*>(cs->getStmt())); 792 } 793 return vals.updateValueVectorWithScratch(block); 794 } 795 796 /// PruneBlocksHandler is a special UninitVariablesHandler that is used 797 /// to detect when a CFGBlock has any *potential* use of an uninitialized 798 /// variable. It is mainly used to prune out work during the final 799 /// reporting pass. 800 namespace { 801 struct PruneBlocksHandler : public UninitVariablesHandler { 802 PruneBlocksHandler(unsigned numBlocks) 803 : hadUse(numBlocks, false), hadAnyUse(false), 804 currentBlock(0) {} 805 806 virtual ~PruneBlocksHandler() {} 807 808 /// Records if a CFGBlock had a potential use of an uninitialized variable. 809 llvm::BitVector hadUse; 810 811 /// Records if any CFGBlock had a potential use of an uninitialized variable. 812 bool hadAnyUse; 813 814 /// The current block to scribble use information. 815 unsigned currentBlock; 816 817 void handleUseOfUninitVariable(const VarDecl *vd, 818 const UninitUse &use) override { 819 hadUse[currentBlock] = true; 820 hadAnyUse = true; 821 } 822 823 /// Called when the uninitialized variable analysis detects the 824 /// idiom 'int x = x'. All other uses of 'x' within the initializer 825 /// are handled by handleUseOfUninitVariable. 826 void handleSelfInit(const VarDecl *vd) override { 827 hadUse[currentBlock] = true; 828 hadAnyUse = true; 829 } 830 }; 831 } 832 833 void clang::runUninitializedVariablesAnalysis( 834 const DeclContext &dc, 835 const CFG &cfg, 836 AnalysisDeclContext &ac, 837 UninitVariablesHandler &handler, 838 UninitVariablesAnalysisStats &stats) { 839 CFGBlockValues vals(cfg); 840 vals.computeSetOfDeclarations(dc); 841 if (vals.hasNoDeclarations()) 842 return; 843 844 stats.NumVariablesAnalyzed = vals.getNumEntries(); 845 846 // Precompute which expressions are uses and which are initializations. 847 ClassifyRefs classification(ac); 848 cfg.VisitBlockStmts(classification); 849 850 // Mark all variables uninitialized at the entry. 851 const CFGBlock &entry = cfg.getEntry(); 852 ValueVector &vec = vals.getValueVector(&entry); 853 const unsigned n = vals.getNumEntries(); 854 for (unsigned j = 0; j < n ; ++j) { 855 vec[j] = Uninitialized; 856 } 857 858 // Proceed with the workist. 859 DataflowWorklist worklist(cfg, *ac.getAnalysis<PostOrderCFGView>()); 860 llvm::BitVector previouslyVisited(cfg.getNumBlockIDs()); 861 worklist.enqueueSuccessors(&cfg.getEntry()); 862 llvm::BitVector wasAnalyzed(cfg.getNumBlockIDs(), false); 863 wasAnalyzed[cfg.getEntry().getBlockID()] = true; 864 PruneBlocksHandler PBH(cfg.getNumBlockIDs()); 865 866 while (const CFGBlock *block = worklist.dequeue()) { 867 PBH.currentBlock = block->getBlockID(); 868 869 // Did the block change? 870 bool changed = runOnBlock(block, cfg, ac, vals, 871 classification, wasAnalyzed, PBH); 872 ++stats.NumBlockVisits; 873 if (changed || !previouslyVisited[block->getBlockID()]) 874 worklist.enqueueSuccessors(block); 875 previouslyVisited[block->getBlockID()] = true; 876 } 877 878 if (!PBH.hadAnyUse) 879 return; 880 881 // Run through the blocks one more time, and report uninitialized variables. 882 for (CFG::const_iterator BI = cfg.begin(), BE = cfg.end(); BI != BE; ++BI) { 883 const CFGBlock *block = *BI; 884 if (PBH.hadUse[block->getBlockID()]) { 885 runOnBlock(block, cfg, ac, vals, classification, wasAnalyzed, handler); 886 ++stats.NumBlockVisits; 887 } 888 } 889 } 890 891 UninitVariablesHandler::~UninitVariablesHandler() {} 892