1 // RUN: %check_clang_tidy %s cppcoreguidelines-pro-bounds-array-to-pointer-decay %t
2 #include <stddef.h>
3 
4 namespace gsl {
5 template <class T>
6 class array_view {
7 public:
8   template <class U, size_t N>
9   array_view(U (&arr)[N]);
10 };
11 }
12 
13 void pointerfun(int *p);
14 void arrayfun(int p[]);
15 void arrayviewfun(gsl::array_view<int> &p);
16 size_t s();
17 
18 void f() {
19   int a[5];
20   pointerfun(a);
21   // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
22   pointerfun((int *)a); // OK, explicit cast
23   arrayfun(a);
24   // CHECK-MESSAGES: :[[@LINE-1]]:12: warning: do not implicitly decay an array into a pointer
25 
26   pointerfun(a + s() - 10); // Convert to &a[g() - 10];
27   // CHECK-MESSAGES: :[[@LINE-1]]:14: warning: do not implicitly decay an array into a pointer
28 
29   gsl::array_view<int> av(a);
30   arrayviewfun(av); // OK
31 
32   int i = a[0];      // OK
33   int j = a[(1 + 2)];// OK
34   pointerfun(&a[0]); // OK
35 
36   for (auto &e : a) // OK, iteration internally decays array to pointer
37     e = 1;
38 }
39 
40 const char *g() {
41   return "clang"; // OK, decay string literal to pointer
42 }
43 const char *g2() {
44     return ("clang"); // OK, ParenExpr hides the literal-pointer decay
45 }
46 
47 void f2(void *const *);
48 void bug25362() {
49   void *a[2];
50   f2(static_cast<void *const*>(a)); // OK, explicit cast
51 }
52 
53 void issue31155(int i) {
54   const char *a = i ? "foo" : "bar";    // OK, decay string literal to pointer
55   const char *b = i ? "foo" : "foobar"; // OK, decay string literal to pointer
56 
57   char arr[1];
58   const char *c = i ? arr : "bar";
59   // CHECK-MESSAGES: :[[@LINE-1]]:23: warning: do not implicitly decay an array into a pointer
60   const char *d = i ? "foo" : arr;
61   // CHECK-MESSAGES: :[[@LINE-1]]:31: warning: do not implicitly decay an array into a pointer
62 }
63