1 //===- extra/modularize/Modularize.cpp - Check modularized headers --------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // Introduction 11 // 12 // This file implements a tool that checks whether a set of headers provides 13 // the consistent definitions required to use modules. It can also check an 14 // existing module map for full coverage of the headers in a directory tree. 15 // 16 // For example, in examining headers, it detects whether the same entity 17 // (say, a NULL macro or size_t typedef) is defined in multiple headers 18 // or whether a header produces different definitions under 19 // different circumstances. These conditions cause modules built from the 20 // headers to behave poorly, and should be fixed before introducing a module 21 // map. 22 // 23 // Modularize takes as input either one or more module maps (by default, 24 // "module.modulemap") or one or more text files contatining lists of headers 25 // to check. 26 // 27 // In the case of a module map, the module map must be well-formed in 28 // terms of syntax. Modularize will extract the header file names 29 // from the map. Only normal headers are checked, assuming headers 30 // marked "private", "textual", or "exclude" are not to be checked 31 // as a top-level include, assuming they either are included by 32 // other headers which are checked, or they are not suitable for 33 // modules. 34 // 35 // In the case of a file list, the list is a newline-separated list of headers 36 // to check with respect to each other. 37 // Lines beginning with '#' and empty lines are ignored. 38 // Header file names followed by a colon and other space-separated 39 // file names will include those extra files as dependencies. 40 // The file names can be relative or full paths, but must be on the 41 // same line. 42 // 43 // Modularize also accepts regular clang front-end arguments. 44 // 45 // Usage: modularize [(modularize options)] 46 // [(include-files_list)|(module map)]+ [(front-end-options) ...] 47 // 48 // Options: 49 // -prefix=(optional header path prefix) 50 // Note that unless a "-prefix (header path)" option is specified, 51 // non-absolute file paths in the header list file will be relative 52 // to the header list file directory. Use -prefix to specify a 53 // different directory. 54 // -module-map-path=(module map) 55 // Skip the checks, and instead act as a module.map generation 56 // assistant, generating a module map file based on the header list. 57 // An optional "-root-module=(rootName)" argument can specify a root 58 // module to be created in the generated module.map file. Note that 59 // you will likely need to edit this file to suit the needs of your 60 // headers. 61 // -root-module=(root module name) 62 // Specifies a root module to be created in the generated module.map 63 // file. 64 // -block-check-header-list-only 65 // Only warn if #include directives are inside extern or namespace 66 // blocks if the included header is in the header list. 67 // -no-coverage-check 68 // Don't do the coverage check. 69 // -coverage-check-only 70 // Only do the coverage check. 71 // 72 // Note that because modularize does not use the clang driver, 73 // you will likely need to pass in additional compiler front-end 74 // arguments to match those passed in by default by the driver. 75 // 76 // Note that by default, the modularize assumes .h files contain C++ source. 77 // If your .h files in the file list contain another language, you should 78 // append an appropriate -x option to your command line, i.e.: -x c 79 // 80 // Modularization Issue Checks 81 // 82 // In the process of checking headers for modularization issues, modularize 83 // will do normal parsing, reporting normal errors and warnings, 84 // but will also report special error messages like the following: 85 // 86 // error: '(symbol)' defined at multiple locations: 87 // (file):(row):(column) 88 // (file):(row):(column) 89 // 90 // error: header '(file)' has different contents depending on how it was 91 // included 92 // 93 // The latter might be followed by messages like the following: 94 // 95 // note: '(symbol)' in (file) at (row):(column) not always provided 96 // 97 // Checks will also be performed for macro expansions, defined(macro) 98 // expressions, and preprocessor conditional directives that evaluate 99 // inconsistently, and can produce error messages like the following: 100 // 101 // (...)/SubHeader.h:11:5: 102 // #if SYMBOL == 1 103 // ^ 104 // error: Macro instance 'SYMBOL' has different values in this header, 105 // depending on how it was included. 106 // 'SYMBOL' expanded to: '1' with respect to these inclusion paths: 107 // (...)/Header1.h 108 // (...)/SubHeader.h 109 // (...)/SubHeader.h:3:9: 110 // #define SYMBOL 1 111 // ^ 112 // Macro defined here. 113 // 'SYMBOL' expanded to: '2' with respect to these inclusion paths: 114 // (...)/Header2.h 115 // (...)/SubHeader.h 116 // (...)/SubHeader.h:7:9: 117 // #define SYMBOL 2 118 // ^ 119 // Macro defined here. 120 // 121 // Checks will also be performed for '#include' directives that are 122 // nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks, 123 // and can produce error message like the following: 124 // 125 // IncludeInExtern.h:2:3 126 // #include "Empty.h" 127 // ^ 128 // error: Include directive within extern "C" {}. 129 // IncludeInExtern.h:1:1 130 // extern "C" { 131 // ^ 132 // The "extern "C" {}" block is here. 133 // 134 // See PreprocessorTracker.cpp for additional details. 135 // 136 // Module Map Coverage Check 137 // 138 // The coverage check uses the Clang ModuleMap class to read and parse the 139 // module map file. Starting at the module map file directory, or just the 140 // include paths, if specified, it will collect the names of all the files it 141 // considers headers (no extension, .h, or .inc--if you need more, modify the 142 // isHeader function). It then compares the headers against those referenced 143 // in the module map, either explicitly named, or implicitly named via an 144 // umbrella directory or umbrella file, as parsed by the ModuleMap object. 145 // If headers are found which are not referenced or covered by an umbrella 146 // directory or file, warning messages will be produced, and this program 147 // will return an error code of 1. Other errors result in an error code of 2. 148 // If no problems are found, an error code of 0 is returned. 149 // 150 // Note that in the case of umbrella headers, this tool invokes the compiler 151 // to preprocess the file, and uses a callback to collect the header files 152 // included by the umbrella header or any of its nested includes. If any 153 // front end options are needed for these compiler invocations, these 154 // can be included on the command line after the module map file argument. 155 // 156 // Warning message have the form: 157 // 158 // warning: module.modulemap does not account for file: Level3A.h 159 // 160 // Note that for the case of the module map referencing a file that does 161 // not exist, the module map parser in Clang will (at the time of this 162 // writing) display an error message. 163 // 164 // Module Map Assistant - Module Map Generation 165 // 166 // Modularize also has an option ("-module-map-path=module.modulemap") that will 167 // skip the checks, and instead act as a module.modulemap generation assistant, 168 // generating a module map file based on the header list. An optional 169 // "-root-module=(rootName)" argument can specify a root module to be 170 // created in the generated module.modulemap file. Note that you will likely 171 // need to edit this file to suit the needs of your headers. 172 // 173 // An example command line for generating a module.modulemap file: 174 // 175 // modularize -module-map-path=module.modulemap -root-module=myroot \ 176 // headerlist.txt 177 // 178 // Note that if the headers in the header list have partial paths, sub-modules 179 // will be created for the subdirectires involved, assuming that the 180 // subdirectories contain headers to be grouped into a module, but still with 181 // individual modules for the headers in the subdirectory. 182 // 183 // See the ModuleAssistant.cpp file comments for additional details about the 184 // implementation of the assistant mode. 185 // 186 // Future directions: 187 // 188 // Basically, we want to add new checks for whatever we can check with respect 189 // to checking headers for module'ability. 190 // 191 // Some ideas: 192 // 193 // 1. Omit duplicate "not always provided" messages 194 // 195 // 2. Add options to disable any of the checks, in case 196 // there is some problem with them, or the messages get too verbose. 197 // 198 // 3. Try to figure out the preprocessor conditional directives that 199 // contribute to problems and tie them to the inconsistent definitions. 200 // 201 // 4. There are some legitimate uses of preprocessor macros that 202 // modularize will flag as errors, such as repeatedly #include'ing 203 // a file and using interleaving defined/undefined macros 204 // to change declarations in the included file. Is there a way 205 // to address this? Maybe have modularize accept a list of macros 206 // to ignore. Otherwise you can just exclude the file, after checking 207 // for legitimate errors. 208 // 209 // 5. What else? 210 // 211 // General clean-up and refactoring: 212 // 213 // 1. The Location class seems to be something that we might 214 // want to design to be applicable to a wider range of tools, and stick it 215 // somewhere into Tooling/ in mainline 216 // 217 //===----------------------------------------------------------------------===// 218 219 #include "Modularize.h" 220 #include "ModularizeUtilities.h" 221 #include "PreprocessorTracker.h" 222 #include "clang/AST/ASTConsumer.h" 223 #include "clang/AST/ASTContext.h" 224 #include "clang/AST/RecursiveASTVisitor.h" 225 #include "clang/Basic/SourceManager.h" 226 #include "clang/Driver/Options.h" 227 #include "clang/Frontend/CompilerInstance.h" 228 #include "clang/Frontend/FrontendActions.h" 229 #include "clang/Lex/Preprocessor.h" 230 #include "clang/Tooling/CompilationDatabase.h" 231 #include "clang/Tooling/Tooling.h" 232 #include "llvm/Option/Arg.h" 233 #include "llvm/Option/ArgList.h" 234 #include "llvm/Option/OptTable.h" 235 #include "llvm/Option/Option.h" 236 #include "llvm/Support/CommandLine.h" 237 #include "llvm/Support/FileSystem.h" 238 #include "llvm/Support/MemoryBuffer.h" 239 #include "llvm/Support/Path.h" 240 #include <algorithm> 241 #include <fstream> 242 #include <iterator> 243 #include <string> 244 #include <vector> 245 246 using namespace clang; 247 using namespace clang::driver; 248 using namespace clang::driver::options; 249 using namespace clang::tooling; 250 using namespace llvm; 251 using namespace llvm::opt; 252 using namespace Modularize; 253 254 // Option to specify a file name for a list of header files to check. 255 static cl::list<std::string> 256 ListFileNames(cl::Positional, cl::value_desc("list"), 257 cl::desc("<list of one or more header list files>"), 258 cl::CommaSeparated); 259 260 // Collect all other arguments, which will be passed to the front end. 261 static cl::list<std::string> 262 CC1Arguments(cl::ConsumeAfter, 263 cl::desc("<arguments to be passed to front end>...")); 264 265 // Option to specify a prefix to be prepended to the header names. 266 static cl::opt<std::string> HeaderPrefix( 267 "prefix", cl::init(""), 268 cl::desc( 269 "Prepend header file paths with this prefix." 270 " If not specified," 271 " the files are considered to be relative to the header list file.")); 272 273 // Option for assistant mode, telling modularize to output a module map 274 // based on the headers list, and where to put it. 275 static cl::opt<std::string> ModuleMapPath( 276 "module-map-path", cl::init(""), 277 cl::desc("Turn on module map output and specify output path or file name." 278 " If no path is specified and if prefix option is specified," 279 " use prefix for file path.")); 280 281 // Option for assistant mode, telling modularize to output a module map 282 // based on the headers list, and where to put it. 283 static cl::opt<std::string> 284 RootModule("root-module", cl::init(""), 285 cl::desc("Specify the name of the root module.")); 286 287 // Option for limiting the #include-inside-extern-or-namespace-block 288 // check to only those headers explicitly listed in the header list. 289 // This is a work-around for private includes that purposefully get 290 // included inside blocks. 291 static cl::opt<bool> 292 BlockCheckHeaderListOnly("block-check-header-list-only", cl::init(false), 293 cl::desc("Only warn if #include directives are inside extern or namespace" 294 " blocks if the included header is in the header list.")); 295 296 // Option for include paths for coverage check. 297 static cl::list<std::string> 298 IncludePaths("I", cl::desc("Include path for coverage check."), 299 cl::ZeroOrMore, cl::value_desc("path")); 300 301 // Option for just doing the coverage check. 302 static cl::opt<bool> 303 NoCoverageCheck("no-coverage-check", cl::init(false), 304 cl::desc("Don't do the coverage check.")); 305 306 // Option for just doing the coverage check. 307 static cl::opt<bool> 308 CoverageCheckOnly("coverage-check-only", cl::init(false), 309 cl::desc("Only do the coverage check.")); 310 311 // Save the program name for error messages. 312 const char *Argv0; 313 // Save the command line for comments. 314 std::string CommandLine; 315 316 // Helper function for finding the input file in an arguments list. 317 static std::string findInputFile(const CommandLineArguments &CLArgs) { 318 std::unique_ptr<OptTable> Opts(createDriverOptTable()); 319 const unsigned IncludedFlagsBitmask = options::CC1Option; 320 unsigned MissingArgIndex, MissingArgCount; 321 SmallVector<const char *, 256> Argv; 322 for (CommandLineArguments::const_iterator I = CLArgs.begin(), 323 E = CLArgs.end(); 324 I != E; ++I) 325 Argv.push_back(I->c_str()); 326 InputArgList Args = Opts->ParseArgs(Argv, MissingArgIndex, MissingArgCount, 327 IncludedFlagsBitmask); 328 std::vector<std::string> Inputs = Args.getAllArgValues(OPT_INPUT); 329 return ModularizeUtilities::getCanonicalPath(Inputs.back()); 330 } 331 332 // This arguments adjuster inserts "-include (file)" arguments for header 333 // dependencies. It also insertts a "-w" option and a "-x c++", 334 // if no other "-x" option is present. 335 static ArgumentsAdjuster 336 getModularizeArgumentsAdjuster(DependencyMap &Dependencies) { 337 return [&Dependencies](const CommandLineArguments &Args) { 338 std::string InputFile = findInputFile(Args); 339 DependentsVector &FileDependents = Dependencies[InputFile]; 340 CommandLineArguments NewArgs(Args); 341 if (int Count = FileDependents.size()) { 342 for (int Index = 0; Index < Count; ++Index) { 343 NewArgs.push_back("-include"); 344 std::string File(std::string("\"") + FileDependents[Index] + 345 std::string("\"")); 346 NewArgs.push_back(FileDependents[Index]); 347 } 348 } 349 // Ignore warnings. (Insert after "clang_tool" at beginning.) 350 NewArgs.insert(NewArgs.begin() + 1, "-w"); 351 // Since we are compiling .h files, assume C++ unless given a -x option. 352 if (std::find(NewArgs.begin(), NewArgs.end(), "-x") == NewArgs.end()) { 353 NewArgs.insert(NewArgs.begin() + 2, "-x"); 354 NewArgs.insert(NewArgs.begin() + 3, "c++"); 355 } 356 return NewArgs; 357 }; 358 } 359 360 // FIXME: The Location class seems to be something that we might 361 // want to design to be applicable to a wider range of tools, and stick it 362 // somewhere into Tooling/ in mainline 363 struct Location { 364 const FileEntry *File; 365 unsigned Line, Column; 366 367 Location() : File(), Line(), Column() {} 368 369 Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() { 370 Loc = SM.getExpansionLoc(Loc); 371 if (Loc.isInvalid()) 372 return; 373 374 std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc); 375 File = SM.getFileEntryForID(Decomposed.first); 376 if (!File) 377 return; 378 379 Line = SM.getLineNumber(Decomposed.first, Decomposed.second); 380 Column = SM.getColumnNumber(Decomposed.first, Decomposed.second); 381 } 382 383 operator bool() const { return File != nullptr; } 384 385 friend bool operator==(const Location &X, const Location &Y) { 386 return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column; 387 } 388 389 friend bool operator!=(const Location &X, const Location &Y) { 390 return !(X == Y); 391 } 392 393 friend bool operator<(const Location &X, const Location &Y) { 394 if (X.File != Y.File) 395 return X.File < Y.File; 396 if (X.Line != Y.Line) 397 return X.Line < Y.Line; 398 return X.Column < Y.Column; 399 } 400 friend bool operator>(const Location &X, const Location &Y) { return Y < X; } 401 friend bool operator<=(const Location &X, const Location &Y) { 402 return !(Y < X); 403 } 404 friend bool operator>=(const Location &X, const Location &Y) { 405 return !(X < Y); 406 } 407 }; 408 409 struct Entry { 410 enum EntryKind { 411 EK_Tag, 412 EK_Value, 413 EK_Macro, 414 415 EK_NumberOfKinds 416 } Kind; 417 418 Location Loc; 419 420 StringRef getKindName() { return getKindName(Kind); } 421 static StringRef getKindName(EntryKind kind); 422 }; 423 424 // Return a string representing the given kind. 425 StringRef Entry::getKindName(Entry::EntryKind kind) { 426 switch (kind) { 427 case EK_Tag: 428 return "tag"; 429 case EK_Value: 430 return "value"; 431 case EK_Macro: 432 return "macro"; 433 case EK_NumberOfKinds: 434 break; 435 } 436 llvm_unreachable("invalid Entry kind"); 437 } 438 439 struct HeaderEntry { 440 std::string Name; 441 Location Loc; 442 443 friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) { 444 return X.Loc == Y.Loc && X.Name == Y.Name; 445 } 446 friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) { 447 return !(X == Y); 448 } 449 friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) { 450 return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name); 451 } 452 friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) { 453 return Y < X; 454 } 455 friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) { 456 return !(Y < X); 457 } 458 friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) { 459 return !(X < Y); 460 } 461 }; 462 463 typedef std::vector<HeaderEntry> HeaderContents; 464 465 class EntityMap : public StringMap<SmallVector<Entry, 2> > { 466 public: 467 DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches; 468 469 void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) { 470 // Record this entity in its header. 471 HeaderEntry HE = { Name, Loc }; 472 CurHeaderContents[Loc.File].push_back(HE); 473 474 // Check whether we've seen this entry before. 475 SmallVector<Entry, 2> &Entries = (*this)[Name]; 476 for (unsigned I = 0, N = Entries.size(); I != N; ++I) { 477 if (Entries[I].Kind == Kind && Entries[I].Loc == Loc) 478 return; 479 } 480 481 // We have not seen this entry before; record it. 482 Entry E = { Kind, Loc }; 483 Entries.push_back(E); 484 } 485 486 void mergeCurHeaderContents() { 487 for (DenseMap<const FileEntry *, HeaderContents>::iterator 488 H = CurHeaderContents.begin(), 489 HEnd = CurHeaderContents.end(); 490 H != HEnd; ++H) { 491 // Sort contents. 492 std::sort(H->second.begin(), H->second.end()); 493 494 // Check whether we've seen this header before. 495 DenseMap<const FileEntry *, HeaderContents>::iterator KnownH = 496 AllHeaderContents.find(H->first); 497 if (KnownH == AllHeaderContents.end()) { 498 // We haven't seen this header before; record its contents. 499 AllHeaderContents.insert(*H); 500 continue; 501 } 502 503 // If the header contents are the same, we're done. 504 if (H->second == KnownH->second) 505 continue; 506 507 // Determine what changed. 508 std::set_symmetric_difference( 509 H->second.begin(), H->second.end(), KnownH->second.begin(), 510 KnownH->second.end(), 511 std::back_inserter(HeaderContentMismatches[H->first])); 512 } 513 514 CurHeaderContents.clear(); 515 } 516 517 private: 518 DenseMap<const FileEntry *, HeaderContents> CurHeaderContents; 519 DenseMap<const FileEntry *, HeaderContents> AllHeaderContents; 520 }; 521 522 class CollectEntitiesVisitor 523 : public RecursiveASTVisitor<CollectEntitiesVisitor> { 524 public: 525 CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities, 526 Preprocessor &PP, PreprocessorTracker &PPTracker, 527 int &HadErrors) 528 : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker), 529 HadErrors(HadErrors) {} 530 531 bool TraverseStmt(Stmt *S) { return true; } 532 bool TraverseType(QualType T) { return true; } 533 bool TraverseTypeLoc(TypeLoc TL) { return true; } 534 bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; } 535 bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) { 536 return true; 537 } 538 bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) { 539 return true; 540 } 541 bool TraverseTemplateName(TemplateName Template) { return true; } 542 bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; } 543 bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) { 544 return true; 545 } 546 bool TraverseTemplateArguments(const TemplateArgument *Args, 547 unsigned NumArgs) { 548 return true; 549 } 550 bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; } 551 bool TraverseLambdaCapture(LambdaCapture C) { return true; } 552 553 // Check 'extern "*" {}' block for #include directives. 554 bool VisitLinkageSpecDecl(LinkageSpecDecl *D) { 555 // Bail if not a block. 556 if (!D->hasBraces()) 557 return true; 558 SourceRange BlockRange = D->getSourceRange(); 559 const char *LinkageLabel; 560 switch (D->getLanguage()) { 561 case LinkageSpecDecl::lang_c: 562 LinkageLabel = "extern \"C\" {}"; 563 break; 564 case LinkageSpecDecl::lang_cxx: 565 LinkageLabel = "extern \"C++\" {}"; 566 break; 567 } 568 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel, 569 errs())) 570 HadErrors = 1; 571 return true; 572 } 573 574 // Check 'namespace (name) {}' block for #include directives. 575 bool VisitNamespaceDecl(const NamespaceDecl *D) { 576 SourceRange BlockRange = D->getSourceRange(); 577 std::string Label("namespace "); 578 Label += D->getName(); 579 Label += " {}"; 580 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(), 581 errs())) 582 HadErrors = 1; 583 return true; 584 } 585 586 // Collect definition entities. 587 bool VisitNamedDecl(NamedDecl *ND) { 588 // We only care about file-context variables. 589 if (!ND->getDeclContext()->isFileContext()) 590 return true; 591 592 // Skip declarations that tend to be properly multiply-declared. 593 if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) || 594 isa<NamespaceAliasDecl>(ND) || 595 isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) || 596 isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) || 597 isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) || 598 isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) || 599 (isa<TagDecl>(ND) && 600 !cast<TagDecl>(ND)->isThisDeclarationADefinition())) 601 return true; 602 603 // Skip anonymous declarations. 604 if (!ND->getDeclName()) 605 return true; 606 607 // Get the qualified name. 608 std::string Name; 609 llvm::raw_string_ostream OS(Name); 610 ND->printQualifiedName(OS); 611 OS.flush(); 612 if (Name.empty()) 613 return true; 614 615 Location Loc(SM, ND->getLocation()); 616 if (!Loc) 617 return true; 618 619 Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc); 620 return true; 621 } 622 623 private: 624 SourceManager &SM; 625 EntityMap &Entities; 626 Preprocessor &PP; 627 PreprocessorTracker &PPTracker; 628 int &HadErrors; 629 }; 630 631 class CollectEntitiesConsumer : public ASTConsumer { 632 public: 633 CollectEntitiesConsumer(EntityMap &Entities, 634 PreprocessorTracker &preprocessorTracker, 635 Preprocessor &PP, StringRef InFile, int &HadErrors) 636 : Entities(Entities), PPTracker(preprocessorTracker), PP(PP), 637 HadErrors(HadErrors) { 638 PPTracker.handlePreprocessorEntry(PP, InFile); 639 } 640 641 ~CollectEntitiesConsumer() override { PPTracker.handlePreprocessorExit(); } 642 643 void HandleTranslationUnit(ASTContext &Ctx) override { 644 SourceManager &SM = Ctx.getSourceManager(); 645 646 // Collect declared entities. 647 CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors) 648 .TraverseDecl(Ctx.getTranslationUnitDecl()); 649 650 // Collect macro definitions. 651 for (Preprocessor::macro_iterator M = PP.macro_begin(), 652 MEnd = PP.macro_end(); 653 M != MEnd; ++M) { 654 Location Loc(SM, M->second.getLatest()->getLocation()); 655 if (!Loc) 656 continue; 657 658 Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc); 659 } 660 661 // Merge header contents. 662 Entities.mergeCurHeaderContents(); 663 } 664 665 private: 666 EntityMap &Entities; 667 PreprocessorTracker &PPTracker; 668 Preprocessor &PP; 669 int &HadErrors; 670 }; 671 672 class CollectEntitiesAction : public SyntaxOnlyAction { 673 public: 674 CollectEntitiesAction(EntityMap &Entities, 675 PreprocessorTracker &preprocessorTracker, 676 int &HadErrors) 677 : Entities(Entities), PPTracker(preprocessorTracker), 678 HadErrors(HadErrors) {} 679 680 protected: 681 std::unique_ptr<clang::ASTConsumer> 682 CreateASTConsumer(CompilerInstance &CI, StringRef InFile) override { 683 return llvm::make_unique<CollectEntitiesConsumer>( 684 Entities, PPTracker, CI.getPreprocessor(), InFile, HadErrors); 685 } 686 687 private: 688 EntityMap &Entities; 689 PreprocessorTracker &PPTracker; 690 int &HadErrors; 691 }; 692 693 class ModularizeFrontendActionFactory : public FrontendActionFactory { 694 public: 695 ModularizeFrontendActionFactory(EntityMap &Entities, 696 PreprocessorTracker &preprocessorTracker, 697 int &HadErrors) 698 : Entities(Entities), PPTracker(preprocessorTracker), 699 HadErrors(HadErrors) {} 700 701 CollectEntitiesAction *create() override { 702 return new CollectEntitiesAction(Entities, PPTracker, HadErrors); 703 } 704 705 private: 706 EntityMap &Entities; 707 PreprocessorTracker &PPTracker; 708 int &HadErrors; 709 }; 710 711 int main(int Argc, const char **Argv) { 712 713 // Save program name for error messages. 714 Argv0 = Argv[0]; 715 716 // Save program arguments for use in module.modulemap comment. 717 CommandLine = sys::path::stem(sys::path::filename(Argv0)); 718 for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) { 719 CommandLine.append(" "); 720 CommandLine.append(Argv[ArgIndex]); 721 } 722 723 // This causes options to be parsed. 724 cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n"); 725 726 // No go if we have no header list file. 727 if (ListFileNames.size() == 0) { 728 cl::PrintHelpMessage(); 729 return 1; 730 } 731 732 std::unique_ptr<ModularizeUtilities> ModUtil; 733 int HadErrors = 0; 734 735 ModUtil.reset( 736 ModularizeUtilities::createModularizeUtilities( 737 ListFileNames, HeaderPrefix)); 738 739 // Get header file names and dependencies. 740 if (ModUtil->loadAllHeaderListsAndDependencies()) 741 HadErrors = 1; 742 743 // If we are in assistant mode, output the module map and quit. 744 if (ModuleMapPath.length() != 0) { 745 if (!createModuleMap(ModuleMapPath, ModUtil->HeaderFileNames, 746 ModUtil->Dependencies, HeaderPrefix, RootModule)) 747 return 1; // Failed. 748 return 0; // Success - Skip checks in assistant mode. 749 } 750 751 // If we're doing module maps. 752 if (!NoCoverageCheck && ModUtil->HasModuleMap) { 753 // Do coverage check. 754 if (ModUtil->doCoverageCheck(IncludePaths, CommandLine)) 755 HadErrors = 1; 756 } 757 758 // Bail early if only doing the coverage check. 759 if (CoverageCheckOnly) 760 return HadErrors; 761 762 // Create the compilation database. 763 SmallString<256> PathBuf; 764 sys::fs::current_path(PathBuf); 765 std::unique_ptr<CompilationDatabase> Compilations; 766 Compilations.reset( 767 new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments)); 768 769 // Create preprocessor tracker, to watch for macro and conditional problems. 770 std::unique_ptr<PreprocessorTracker> PPTracker( 771 PreprocessorTracker::create(ModUtil->HeaderFileNames, 772 BlockCheckHeaderListOnly)); 773 774 // Parse all of the headers, detecting duplicates. 775 EntityMap Entities; 776 ClangTool Tool(*Compilations, ModUtil->HeaderFileNames); 777 Tool.appendArgumentsAdjuster( 778 getModularizeArgumentsAdjuster(ModUtil->Dependencies)); 779 ModularizeFrontendActionFactory Factory(Entities, *PPTracker, HadErrors); 780 HadErrors |= Tool.run(&Factory); 781 782 // Create a place to save duplicate entity locations, separate bins per kind. 783 typedef SmallVector<Location, 8> LocationArray; 784 typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray; 785 EntryBinArray EntryBins; 786 int KindIndex; 787 for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) { 788 LocationArray Array; 789 EntryBins.push_back(Array); 790 } 791 792 // Check for the same entity being defined in multiple places. 793 for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end(); 794 E != EEnd; ++E) { 795 // If only one occurrence, exit early. 796 if (E->second.size() == 1) 797 continue; 798 // Clear entity locations. 799 for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end(); 800 CI != CE; ++CI) { 801 CI->clear(); 802 } 803 // Walk the entities of a single name, collecting the locations, 804 // separated into separate bins. 805 for (unsigned I = 0, N = E->second.size(); I != N; ++I) { 806 EntryBins[E->second[I].Kind].push_back(E->second[I].Loc); 807 } 808 // Report any duplicate entity definition errors. 809 int KindIndex = 0; 810 for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end(); 811 DI != DE; ++DI, ++KindIndex) { 812 int ECount = DI->size(); 813 // If only 1 occurrence of this entity, skip it, we only report duplicates. 814 if (ECount <= 1) 815 continue; 816 LocationArray::iterator FI = DI->begin(); 817 StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex); 818 errs() << "error: " << kindName << " '" << E->first() 819 << "' defined at multiple locations:\n"; 820 for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) { 821 errs() << " " << FI->File->getName() << ":" << FI->Line << ":" 822 << FI->Column << "\n"; 823 } 824 HadErrors = 1; 825 } 826 } 827 828 // Complain about macro instance in header files that differ based on how 829 // they are included. 830 if (PPTracker->reportInconsistentMacros(errs())) 831 HadErrors = 1; 832 833 // Complain about preprocessor conditional directives in header files that 834 // differ based on how they are included. 835 if (PPTracker->reportInconsistentConditionals(errs())) 836 HadErrors = 1; 837 838 // Complain about any headers that have contents that differ based on how 839 // they are included. 840 // FIXME: Could we provide information about which preprocessor conditionals 841 // are involved? 842 for (DenseMap<const FileEntry *, HeaderContents>::iterator 843 H = Entities.HeaderContentMismatches.begin(), 844 HEnd = Entities.HeaderContentMismatches.end(); 845 H != HEnd; ++H) { 846 if (H->second.empty()) { 847 errs() << "internal error: phantom header content mismatch\n"; 848 continue; 849 } 850 851 HadErrors = 1; 852 errs() << "error: header '" << H->first->getName() 853 << "' has different contents depending on how it was included.\n"; 854 for (unsigned I = 0, N = H->second.size(); I != N; ++I) { 855 errs() << "note: '" << H->second[I].Name << "' in " 856 << H->second[I].Loc.File->getName() << " at " 857 << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column 858 << " not always provided\n"; 859 } 860 } 861 862 return HadErrors; 863 } 864