1 //===- extra/modularize/Modularize.cpp - Check modularized headers --------===// 2 // 3 // The LLVM Compiler Infrastructure 4 // 5 // This file is distributed under the University of Illinois Open Source 6 // License. See LICENSE.TXT for details. 7 // 8 //===----------------------------------------------------------------------===// 9 // 10 // Introduction 11 // 12 // This file implements a tool that checks whether a set of headers provides 13 // the consistent definitions required to use modules. It can also check an 14 // existing module map for full coverage of the headers in a directory tree. 15 // 16 // For example, in examining headers, it detects whether the same entity 17 // (say, a NULL macro or size_t typedef) is defined in multiple headers 18 // or whether a header produces different definitions under 19 // different circumstances. These conditions cause modules built from the 20 // headers to behave poorly, and should be fixed before introducing a module 21 // map. 22 // 23 // Modularize takes as input either one or more module maps (by default, 24 // "module.modulemap") or one or more text files contatining lists of headers 25 // to check. 26 // 27 // In the case of a module map, the module map must be well-formed in 28 // terms of syntax. Modularize will extract the header file names 29 // from the map. Only normal headers are checked, assuming headers 30 // marked "private", "textual", or "exclude" are not to be checked 31 // as a top-level include, assuming they either are included by 32 // other headers which are checked, or they are not suitable for 33 // modules. 34 // 35 // In the case of a file list, the list is a newline-separated list of headers 36 // to check with respect to each other. 37 // Lines beginning with '#' and empty lines are ignored. 38 // Header file names followed by a colon and other space-separated 39 // file names will include those extra files as dependencies. 40 // The file names can be relative or full paths, but must be on the 41 // same line. 42 // 43 // Modularize also accepts regular clang front-end arguments. 44 // 45 // Usage: modularize [(modularize options)] 46 // [(include-files_list)|(module map)]+ [(front-end-options) ...] 47 // 48 // Options: 49 // -prefix (optional header path prefix) 50 // Note that unless a "-prefix (header path)" option is specified, 51 // non-absolute file paths in the header list file will be relative 52 // to the header list file directory. Use -prefix to specify a 53 // different directory. 54 // -module-map-path (module map) 55 // Skip the checks, and instead act as a module.map generation 56 // assistant, generating a module map file based on the header list. 57 // An optional "-root-module=(rootName)" argument can specify a root 58 // module to be created in the generated module.map file. Note that 59 // you will likely need to edit this file to suit the needs of your 60 // headers. 61 // -root-module (root module name) 62 // Specifies a root module to be created in the generated module.map 63 // file. 64 // -block-check-header-list-only 65 // Only warn if #include directives are inside extern or namespace 66 // blocks if the included header is in the header list. 67 // -no-coverage-check 68 // Don't do the coverage check. 69 // -coverage-check-only 70 // Only do the coverage check. 71 // 72 // Note that because modularize does not use the clang driver, 73 // you will likely need to pass in additional compiler front-end 74 // arguments to match those passed in by default by the driver. 75 // 76 // Note that by default, the underlying Clang front end assumes .h files 77 // contain C source. If your .h files in the file list contain C++ source, 78 // you should append the following to your command lines: -x c++ 79 // 80 // Modularization Issue Checks 81 // 82 // In the process of checking headers for modularization issues, modularize 83 // will do normal parsing, reporting normal errors and warnings, 84 // but will also report special error messages like the following: 85 // 86 // error: '(symbol)' defined at multiple locations: 87 // (file):(row):(column) 88 // (file):(row):(column) 89 // 90 // error: header '(file)' has different contents depending on how it was 91 // included 92 // 93 // The latter might be followed by messages like the following: 94 // 95 // note: '(symbol)' in (file) at (row):(column) not always provided 96 // 97 // Checks will also be performed for macro expansions, defined(macro) 98 // expressions, and preprocessor conditional directives that evaluate 99 // inconsistently, and can produce error messages like the following: 100 // 101 // (...)/SubHeader.h:11:5: 102 // #if SYMBOL == 1 103 // ^ 104 // error: Macro instance 'SYMBOL' has different values in this header, 105 // depending on how it was included. 106 // 'SYMBOL' expanded to: '1' with respect to these inclusion paths: 107 // (...)/Header1.h 108 // (...)/SubHeader.h 109 // (...)/SubHeader.h:3:9: 110 // #define SYMBOL 1 111 // ^ 112 // Macro defined here. 113 // 'SYMBOL' expanded to: '2' with respect to these inclusion paths: 114 // (...)/Header2.h 115 // (...)/SubHeader.h 116 // (...)/SubHeader.h:7:9: 117 // #define SYMBOL 2 118 // ^ 119 // Macro defined here. 120 // 121 // Checks will also be performed for '#include' directives that are 122 // nested inside 'extern "C/C++" {}' or 'namespace (name) {}' blocks, 123 // and can produce error message like the following: 124 // 125 // IncludeInExtern.h:2:3 126 // #include "Empty.h" 127 // ^ 128 // error: Include directive within extern "C" {}. 129 // IncludeInExtern.h:1:1 130 // extern "C" { 131 // ^ 132 // The "extern "C" {}" block is here. 133 // 134 // See PreprocessorTracker.cpp for additional details. 135 // 136 // Module Map Coverage Check 137 // 138 // The coverage check uses the Clang ModuleMap class to read and parse the 139 // module map file. Starting at the module map file directory, or just the 140 // include paths, if specified, it will collect the names of all the files it 141 // considers headers (no extension, .h, or .inc--if you need more, modify the 142 // isHeader function). It then compares the headers against those referenced 143 // in the module map, either explicitly named, or implicitly named via an 144 // umbrella directory or umbrella file, as parsed by the ModuleMap object. 145 // If headers are found which are not referenced or covered by an umbrella 146 // directory or file, warning messages will be produced, and this program 147 // will return an error code of 1. Other errors result in an error code of 2. 148 // If no problems are found, an error code of 0 is returned. 149 // 150 // Note that in the case of umbrella headers, this tool invokes the compiler 151 // to preprocess the file, and uses a callback to collect the header files 152 // included by the umbrella header or any of its nested includes. If any 153 // front end options are needed for these compiler invocations, these 154 // can be included on the command line after the module map file argument. 155 // 156 // Warning message have the form: 157 // 158 // warning: module.modulemap does not account for file: Level3A.h 159 // 160 // Note that for the case of the module map referencing a file that does 161 // not exist, the module map parser in Clang will (at the time of this 162 // writing) display an error message. 163 // 164 // Module Map Assistant - Module Map Generation 165 // 166 // Modularize also has an option ("-module-map-path=module.modulemap") that will 167 // skip the checks, and instead act as a module.modulemap generation assistant, 168 // generating a module map file based on the header list. An optional 169 // "-root-module=(rootName)" argument can specify a root module to be 170 // created in the generated module.modulemap file. Note that you will likely 171 // need to edit this file to suit the needs of your headers. 172 // 173 // An example command line for generating a module.modulemap file: 174 // 175 // modularize -module-map-path=module.modulemap -root-module=myroot \ 176 // headerlist.txt 177 // 178 // Note that if the headers in the header list have partial paths, sub-modules 179 // will be created for the subdirectires involved, assuming that the 180 // subdirectories contain headers to be grouped into a module, but still with 181 // individual modules for the headers in the subdirectory. 182 // 183 // See the ModuleAssistant.cpp file comments for additional details about the 184 // implementation of the assistant mode. 185 // 186 // Future directions: 187 // 188 // Basically, we want to add new checks for whatever we can check with respect 189 // to checking headers for module'ability. 190 // 191 // Some ideas: 192 // 193 // 1. Omit duplicate "not always provided" messages 194 // 195 // 2. Add options to disable any of the checks, in case 196 // there is some problem with them, or the messages get too verbose. 197 // 198 // 3. Try to figure out the preprocessor conditional directives that 199 // contribute to problems and tie them to the inconsistent definitions. 200 // 201 // 4. There are some legitimate uses of preprocessor macros that 202 // modularize will flag as errors, such as repeatedly #include'ing 203 // a file and using interleaving defined/undefined macros 204 // to change declarations in the included file. Is there a way 205 // to address this? Maybe have modularize accept a list of macros 206 // to ignore. Otherwise you can just exclude the file, after checking 207 // for legitimate errors. 208 // 209 // 5. What else? 210 // 211 // General clean-up and refactoring: 212 // 213 // 1. The Location class seems to be something that we might 214 // want to design to be applicable to a wider range of tools, and stick it 215 // somewhere into Tooling/ in mainline 216 // 217 //===----------------------------------------------------------------------===// 218 219 #include "Modularize.h" 220 #include "ModularizeUtilities.h" 221 #include "PreprocessorTracker.h" 222 #include "clang/AST/ASTConsumer.h" 223 #include "clang/AST/ASTContext.h" 224 #include "clang/AST/RecursiveASTVisitor.h" 225 #include "clang/Basic/SourceManager.h" 226 #include "clang/Driver/Options.h" 227 #include "clang/Frontend/CompilerInstance.h" 228 #include "clang/Frontend/FrontendActions.h" 229 #include "clang/Lex/Preprocessor.h" 230 #include "clang/Tooling/CompilationDatabase.h" 231 #include "clang/Tooling/Tooling.h" 232 #include "llvm/Option/Arg.h" 233 #include "llvm/Option/ArgList.h" 234 #include "llvm/Option/OptTable.h" 235 #include "llvm/Option/Option.h" 236 #include "llvm/Support/CommandLine.h" 237 #include "llvm/Support/FileSystem.h" 238 #include "llvm/Support/MemoryBuffer.h" 239 #include "llvm/Support/Path.h" 240 #include <algorithm> 241 #include <fstream> 242 #include <iterator> 243 #include <string> 244 #include <vector> 245 246 using namespace clang; 247 using namespace clang::driver; 248 using namespace clang::driver::options; 249 using namespace clang::tooling; 250 using namespace llvm; 251 using namespace llvm::opt; 252 using namespace Modularize; 253 254 // Option to specify a file name for a list of header files to check. 255 static cl::list<std::string> 256 ListFileNames(cl::Positional, cl::value_desc("list"), 257 cl::desc("<list of one or more header list files>"), 258 cl::CommaSeparated); 259 260 // Collect all other arguments, which will be passed to the front end. 261 static cl::list<std::string> 262 CC1Arguments(cl::ConsumeAfter, 263 cl::desc("<arguments to be passed to front end>...")); 264 265 // Option to specify a prefix to be prepended to the header names. 266 static cl::opt<std::string> HeaderPrefix( 267 "prefix", cl::init(""), 268 cl::desc( 269 "Prepend header file paths with this prefix." 270 " If not specified," 271 " the files are considered to be relative to the header list file.")); 272 273 // Option for assistant mode, telling modularize to output a module map 274 // based on the headers list, and where to put it. 275 static cl::opt<std::string> ModuleMapPath( 276 "module-map-path", cl::init(""), 277 cl::desc("Turn on module map output and specify output path or file name." 278 " If no path is specified and if prefix option is specified," 279 " use prefix for file path.")); 280 281 // Option for assistant mode, telling modularize to output a module map 282 // based on the headers list, and where to put it. 283 static cl::opt<std::string> 284 RootModule("root-module", cl::init(""), 285 cl::desc("Specify the name of the root module.")); 286 287 // Option for limiting the #include-inside-extern-or-namespace-block 288 // check to only those headers explicitly listed in the header list. 289 // This is a work-around for private includes that purposefully get 290 // included inside blocks. 291 static cl::opt<bool> 292 BlockCheckHeaderListOnly("block-check-header-list-only", cl::init(false), 293 cl::desc("Only warn if #include directives are inside extern or namespace" 294 " blocks if the included header is in the header list.")); 295 296 // Option for include paths for coverage check. 297 static cl::list<std::string> 298 IncludePaths("I", cl::desc("Include path for coverage check."), 299 cl::ZeroOrMore, cl::value_desc("path")); 300 301 // Option for just doing the coverage check. 302 static cl::opt<bool> 303 NoCoverageCheck("no-coverage-check", cl::init(false), 304 cl::desc("Don't do the coverage check.")); 305 306 // Option for just doing the coverage check. 307 static cl::opt<bool> 308 CoverageCheckOnly("coverage-check-only", cl::init(false), 309 cl::desc("Only do the coverage check.")); 310 311 // Save the program name for error messages. 312 const char *Argv0; 313 // Save the command line for comments. 314 std::string CommandLine; 315 316 // Helper function for finding the input file in an arguments list. 317 static std::string findInputFile(const CommandLineArguments &CLArgs) { 318 std::unique_ptr<OptTable> Opts(createDriverOptTable()); 319 const unsigned IncludedFlagsBitmask = options::CC1Option; 320 unsigned MissingArgIndex, MissingArgCount; 321 SmallVector<const char *, 256> Argv; 322 for (CommandLineArguments::const_iterator I = CLArgs.begin(), 323 E = CLArgs.end(); 324 I != E; ++I) 325 Argv.push_back(I->c_str()); 326 std::unique_ptr<InputArgList> Args( 327 Opts->ParseArgs(Argv.data(), Argv.data() + Argv.size(), MissingArgIndex, 328 MissingArgCount, IncludedFlagsBitmask)); 329 std::vector<std::string> Inputs = Args->getAllArgValues(OPT_INPUT); 330 return ModularizeUtilities::getCanonicalPath(Inputs.back()); 331 } 332 333 // This arguments adjuster inserts "-include (file)" arguments for header 334 // dependencies. 335 static ArgumentsAdjuster 336 getAddDependenciesAdjuster(DependencyMap &Dependencies) { 337 return [&Dependencies](const CommandLineArguments &Args) { 338 std::string InputFile = findInputFile(Args); 339 DependentsVector &FileDependents = Dependencies[InputFile]; 340 CommandLineArguments NewArgs(Args); 341 if (int Count = FileDependents.size()) { 342 for (int Index = 0; Index < Count; ++Index) { 343 NewArgs.push_back("-include"); 344 std::string File(std::string("\"") + FileDependents[Index] + 345 std::string("\"")); 346 NewArgs.push_back(FileDependents[Index]); 347 } 348 } 349 return NewArgs; 350 }; 351 } 352 353 // FIXME: The Location class seems to be something that we might 354 // want to design to be applicable to a wider range of tools, and stick it 355 // somewhere into Tooling/ in mainline 356 struct Location { 357 const FileEntry *File; 358 unsigned Line, Column; 359 360 Location() : File(), Line(), Column() {} 361 362 Location(SourceManager &SM, SourceLocation Loc) : File(), Line(), Column() { 363 Loc = SM.getExpansionLoc(Loc); 364 if (Loc.isInvalid()) 365 return; 366 367 std::pair<FileID, unsigned> Decomposed = SM.getDecomposedLoc(Loc); 368 File = SM.getFileEntryForID(Decomposed.first); 369 if (!File) 370 return; 371 372 Line = SM.getLineNumber(Decomposed.first, Decomposed.second); 373 Column = SM.getColumnNumber(Decomposed.first, Decomposed.second); 374 } 375 376 operator bool() const { return File != nullptr; } 377 378 friend bool operator==(const Location &X, const Location &Y) { 379 return X.File == Y.File && X.Line == Y.Line && X.Column == Y.Column; 380 } 381 382 friend bool operator!=(const Location &X, const Location &Y) { 383 return !(X == Y); 384 } 385 386 friend bool operator<(const Location &X, const Location &Y) { 387 if (X.File != Y.File) 388 return X.File < Y.File; 389 if (X.Line != Y.Line) 390 return X.Line < Y.Line; 391 return X.Column < Y.Column; 392 } 393 friend bool operator>(const Location &X, const Location &Y) { return Y < X; } 394 friend bool operator<=(const Location &X, const Location &Y) { 395 return !(Y < X); 396 } 397 friend bool operator>=(const Location &X, const Location &Y) { 398 return !(X < Y); 399 } 400 }; 401 402 struct Entry { 403 enum EntryKind { 404 EK_Tag, 405 EK_Value, 406 EK_Macro, 407 408 EK_NumberOfKinds 409 } Kind; 410 411 Location Loc; 412 413 StringRef getKindName() { return getKindName(Kind); } 414 static StringRef getKindName(EntryKind kind); 415 }; 416 417 // Return a string representing the given kind. 418 StringRef Entry::getKindName(Entry::EntryKind kind) { 419 switch (kind) { 420 case EK_Tag: 421 return "tag"; 422 case EK_Value: 423 return "value"; 424 case EK_Macro: 425 return "macro"; 426 case EK_NumberOfKinds: 427 break; 428 } 429 llvm_unreachable("invalid Entry kind"); 430 } 431 432 struct HeaderEntry { 433 std::string Name; 434 Location Loc; 435 436 friend bool operator==(const HeaderEntry &X, const HeaderEntry &Y) { 437 return X.Loc == Y.Loc && X.Name == Y.Name; 438 } 439 friend bool operator!=(const HeaderEntry &X, const HeaderEntry &Y) { 440 return !(X == Y); 441 } 442 friend bool operator<(const HeaderEntry &X, const HeaderEntry &Y) { 443 return X.Loc < Y.Loc || (X.Loc == Y.Loc && X.Name < Y.Name); 444 } 445 friend bool operator>(const HeaderEntry &X, const HeaderEntry &Y) { 446 return Y < X; 447 } 448 friend bool operator<=(const HeaderEntry &X, const HeaderEntry &Y) { 449 return !(Y < X); 450 } 451 friend bool operator>=(const HeaderEntry &X, const HeaderEntry &Y) { 452 return !(X < Y); 453 } 454 }; 455 456 typedef std::vector<HeaderEntry> HeaderContents; 457 458 class EntityMap : public StringMap<SmallVector<Entry, 2> > { 459 public: 460 DenseMap<const FileEntry *, HeaderContents> HeaderContentMismatches; 461 462 void add(const std::string &Name, enum Entry::EntryKind Kind, Location Loc) { 463 // Record this entity in its header. 464 HeaderEntry HE = { Name, Loc }; 465 CurHeaderContents[Loc.File].push_back(HE); 466 467 // Check whether we've seen this entry before. 468 SmallVector<Entry, 2> &Entries = (*this)[Name]; 469 for (unsigned I = 0, N = Entries.size(); I != N; ++I) { 470 if (Entries[I].Kind == Kind && Entries[I].Loc == Loc) 471 return; 472 } 473 474 // We have not seen this entry before; record it. 475 Entry E = { Kind, Loc }; 476 Entries.push_back(E); 477 } 478 479 void mergeCurHeaderContents() { 480 for (DenseMap<const FileEntry *, HeaderContents>::iterator 481 H = CurHeaderContents.begin(), 482 HEnd = CurHeaderContents.end(); 483 H != HEnd; ++H) { 484 // Sort contents. 485 std::sort(H->second.begin(), H->second.end()); 486 487 // Check whether we've seen this header before. 488 DenseMap<const FileEntry *, HeaderContents>::iterator KnownH = 489 AllHeaderContents.find(H->first); 490 if (KnownH == AllHeaderContents.end()) { 491 // We haven't seen this header before; record its contents. 492 AllHeaderContents.insert(*H); 493 continue; 494 } 495 496 // If the header contents are the same, we're done. 497 if (H->second == KnownH->second) 498 continue; 499 500 // Determine what changed. 501 std::set_symmetric_difference( 502 H->second.begin(), H->second.end(), KnownH->second.begin(), 503 KnownH->second.end(), 504 std::back_inserter(HeaderContentMismatches[H->first])); 505 } 506 507 CurHeaderContents.clear(); 508 } 509 510 private: 511 DenseMap<const FileEntry *, HeaderContents> CurHeaderContents; 512 DenseMap<const FileEntry *, HeaderContents> AllHeaderContents; 513 }; 514 515 class CollectEntitiesVisitor 516 : public RecursiveASTVisitor<CollectEntitiesVisitor> { 517 public: 518 CollectEntitiesVisitor(SourceManager &SM, EntityMap &Entities, 519 Preprocessor &PP, PreprocessorTracker &PPTracker, 520 int &HadErrors) 521 : SM(SM), Entities(Entities), PP(PP), PPTracker(PPTracker), 522 HadErrors(HadErrors) {} 523 524 bool TraverseStmt(Stmt *S) { return true; } 525 bool TraverseType(QualType T) { return true; } 526 bool TraverseTypeLoc(TypeLoc TL) { return true; } 527 bool TraverseNestedNameSpecifier(NestedNameSpecifier *NNS) { return true; } 528 bool TraverseNestedNameSpecifierLoc(NestedNameSpecifierLoc NNS) { 529 return true; 530 } 531 bool TraverseDeclarationNameInfo(DeclarationNameInfo NameInfo) { 532 return true; 533 } 534 bool TraverseTemplateName(TemplateName Template) { return true; } 535 bool TraverseTemplateArgument(const TemplateArgument &Arg) { return true; } 536 bool TraverseTemplateArgumentLoc(const TemplateArgumentLoc &ArgLoc) { 537 return true; 538 } 539 bool TraverseTemplateArguments(const TemplateArgument *Args, 540 unsigned NumArgs) { 541 return true; 542 } 543 bool TraverseConstructorInitializer(CXXCtorInitializer *Init) { return true; } 544 bool TraverseLambdaCapture(LambdaCapture C) { return true; } 545 546 // Check 'extern "*" {}' block for #include directives. 547 bool VisitLinkageSpecDecl(LinkageSpecDecl *D) { 548 // Bail if not a block. 549 if (!D->hasBraces()) 550 return true; 551 SourceRange BlockRange = D->getSourceRange(); 552 const char *LinkageLabel; 553 switch (D->getLanguage()) { 554 case LinkageSpecDecl::lang_c: 555 LinkageLabel = "extern \"C\" {}"; 556 break; 557 case LinkageSpecDecl::lang_cxx: 558 LinkageLabel = "extern \"C++\" {}"; 559 break; 560 } 561 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, LinkageLabel, 562 errs())) 563 HadErrors = 1; 564 return true; 565 } 566 567 // Check 'namespace (name) {}' block for #include directives. 568 bool VisitNamespaceDecl(const NamespaceDecl *D) { 569 SourceRange BlockRange = D->getSourceRange(); 570 std::string Label("namespace "); 571 Label += D->getName(); 572 Label += " {}"; 573 if (!PPTracker.checkForIncludesInBlock(PP, BlockRange, Label.c_str(), 574 errs())) 575 HadErrors = 1; 576 return true; 577 } 578 579 // Collect definition entities. 580 bool VisitNamedDecl(NamedDecl *ND) { 581 // We only care about file-context variables. 582 if (!ND->getDeclContext()->isFileContext()) 583 return true; 584 585 // Skip declarations that tend to be properly multiply-declared. 586 if (isa<NamespaceDecl>(ND) || isa<UsingDirectiveDecl>(ND) || 587 isa<NamespaceAliasDecl>(ND) || 588 isa<ClassTemplateSpecializationDecl>(ND) || isa<UsingDecl>(ND) || 589 isa<ClassTemplateDecl>(ND) || isa<TemplateTypeParmDecl>(ND) || 590 isa<TypeAliasTemplateDecl>(ND) || isa<UsingShadowDecl>(ND) || 591 isa<FunctionDecl>(ND) || isa<FunctionTemplateDecl>(ND) || 592 (isa<TagDecl>(ND) && 593 !cast<TagDecl>(ND)->isThisDeclarationADefinition())) 594 return true; 595 596 // Skip anonymous declarations. 597 if (!ND->getDeclName()) 598 return true; 599 600 // Get the qualified name. 601 std::string Name; 602 llvm::raw_string_ostream OS(Name); 603 ND->printQualifiedName(OS); 604 OS.flush(); 605 if (Name.empty()) 606 return true; 607 608 Location Loc(SM, ND->getLocation()); 609 if (!Loc) 610 return true; 611 612 Entities.add(Name, isa<TagDecl>(ND) ? Entry::EK_Tag : Entry::EK_Value, Loc); 613 return true; 614 } 615 616 private: 617 SourceManager &SM; 618 EntityMap &Entities; 619 Preprocessor &PP; 620 PreprocessorTracker &PPTracker; 621 int &HadErrors; 622 }; 623 624 class CollectEntitiesConsumer : public ASTConsumer { 625 public: 626 CollectEntitiesConsumer(EntityMap &Entities, 627 PreprocessorTracker &preprocessorTracker, 628 Preprocessor &PP, StringRef InFile, int &HadErrors) 629 : Entities(Entities), PPTracker(preprocessorTracker), PP(PP), 630 HadErrors(HadErrors) { 631 PPTracker.handlePreprocessorEntry(PP, InFile); 632 } 633 634 ~CollectEntitiesConsumer() override { PPTracker.handlePreprocessorExit(); } 635 636 void HandleTranslationUnit(ASTContext &Ctx) override { 637 SourceManager &SM = Ctx.getSourceManager(); 638 639 // Collect declared entities. 640 CollectEntitiesVisitor(SM, Entities, PP, PPTracker, HadErrors) 641 .TraverseDecl(Ctx.getTranslationUnitDecl()); 642 643 // Collect macro definitions. 644 for (Preprocessor::macro_iterator M = PP.macro_begin(), 645 MEnd = PP.macro_end(); 646 M != MEnd; ++M) { 647 Location Loc(SM, M->second->getLocation()); 648 if (!Loc) 649 continue; 650 651 Entities.add(M->first->getName().str(), Entry::EK_Macro, Loc); 652 } 653 654 // Merge header contents. 655 Entities.mergeCurHeaderContents(); 656 } 657 658 private: 659 EntityMap &Entities; 660 PreprocessorTracker &PPTracker; 661 Preprocessor &PP; 662 int &HadErrors; 663 }; 664 665 class CollectEntitiesAction : public SyntaxOnlyAction { 666 public: 667 CollectEntitiesAction(EntityMap &Entities, 668 PreprocessorTracker &preprocessorTracker, 669 int &HadErrors) 670 : Entities(Entities), PPTracker(preprocessorTracker), 671 HadErrors(HadErrors) {} 672 673 protected: 674 std::unique_ptr<clang::ASTConsumer> 675 CreateASTConsumer(CompilerInstance &CI, StringRef InFile) override { 676 return llvm::make_unique<CollectEntitiesConsumer>( 677 Entities, PPTracker, CI.getPreprocessor(), InFile, HadErrors); 678 } 679 680 private: 681 EntityMap &Entities; 682 PreprocessorTracker &PPTracker; 683 int &HadErrors; 684 }; 685 686 class ModularizeFrontendActionFactory : public FrontendActionFactory { 687 public: 688 ModularizeFrontendActionFactory(EntityMap &Entities, 689 PreprocessorTracker &preprocessorTracker, 690 int &HadErrors) 691 : Entities(Entities), PPTracker(preprocessorTracker), 692 HadErrors(HadErrors) {} 693 694 CollectEntitiesAction *create() override { 695 return new CollectEntitiesAction(Entities, PPTracker, HadErrors); 696 } 697 698 private: 699 EntityMap &Entities; 700 PreprocessorTracker &PPTracker; 701 int &HadErrors; 702 }; 703 704 int main(int Argc, const char **Argv) { 705 706 // Save program name for error messages. 707 Argv0 = Argv[0]; 708 709 // Save program arguments for use in module.modulemap comment. 710 CommandLine = sys::path::stem(sys::path::filename(Argv0)); 711 for (int ArgIndex = 1; ArgIndex < Argc; ArgIndex++) { 712 CommandLine.append(" "); 713 CommandLine.append(Argv[ArgIndex]); 714 } 715 716 // This causes options to be parsed. 717 cl::ParseCommandLineOptions(Argc, Argv, "modularize.\n"); 718 719 // No go if we have no header list file. 720 if (ListFileNames.size() == 0) { 721 cl::PrintHelpMessage(); 722 return 1; 723 } 724 725 std::unique_ptr<ModularizeUtilities> ModUtil; 726 int HadErrors = 0; 727 728 ModUtil.reset( 729 ModularizeUtilities::createModularizeUtilities( 730 ListFileNames, HeaderPrefix)); 731 732 // Get header file names and dependencies. 733 ModUtil->loadAllHeaderListsAndDependencies(); 734 735 736 // If we are in assistant mode, output the module map and quit. 737 if (ModuleMapPath.length() != 0) { 738 if (!createModuleMap(ModuleMapPath, ModUtil->HeaderFileNames, 739 ModUtil->Dependencies, HeaderPrefix, RootModule)) 740 return 1; // Failed. 741 return 0; // Success - Skip checks in assistant mode. 742 } 743 744 // If we're doing module maps. 745 if (!NoCoverageCheck && ModUtil->HasModuleMap) { 746 // Do coverage check. 747 if (ModUtil->doCoverageCheck(IncludePaths, CommandLine)) 748 HadErrors = 1; 749 } 750 751 // Bail early if only doing the coverage check. 752 if (CoverageCheckOnly) 753 return HadErrors; 754 755 // Create the compilation database. 756 SmallString<256> PathBuf; 757 sys::fs::current_path(PathBuf); 758 std::unique_ptr<CompilationDatabase> Compilations; 759 Compilations.reset( 760 new FixedCompilationDatabase(Twine(PathBuf), CC1Arguments)); 761 762 // Create preprocessor tracker, to watch for macro and conditional problems. 763 std::unique_ptr<PreprocessorTracker> PPTracker( 764 PreprocessorTracker::create(ModUtil->HeaderFileNames, 765 BlockCheckHeaderListOnly)); 766 767 // Parse all of the headers, detecting duplicates. 768 EntityMap Entities; 769 ClangTool Tool(*Compilations, ModUtil->HeaderFileNames); 770 Tool.appendArgumentsAdjuster(getAddDependenciesAdjuster(ModUtil->Dependencies)); 771 ModularizeFrontendActionFactory Factory(Entities, *PPTracker, HadErrors); 772 HadErrors |= Tool.run(&Factory); 773 774 // Create a place to save duplicate entity locations, separate bins per kind. 775 typedef SmallVector<Location, 8> LocationArray; 776 typedef SmallVector<LocationArray, Entry::EK_NumberOfKinds> EntryBinArray; 777 EntryBinArray EntryBins; 778 int KindIndex; 779 for (KindIndex = 0; KindIndex < Entry::EK_NumberOfKinds; ++KindIndex) { 780 LocationArray Array; 781 EntryBins.push_back(Array); 782 } 783 784 // Check for the same entity being defined in multiple places. 785 for (EntityMap::iterator E = Entities.begin(), EEnd = Entities.end(); 786 E != EEnd; ++E) { 787 // If only one occurrence, exit early. 788 if (E->second.size() == 1) 789 continue; 790 // Clear entity locations. 791 for (EntryBinArray::iterator CI = EntryBins.begin(), CE = EntryBins.end(); 792 CI != CE; ++CI) { 793 CI->clear(); 794 } 795 // Walk the entities of a single name, collecting the locations, 796 // separated into separate bins. 797 for (unsigned I = 0, N = E->second.size(); I != N; ++I) { 798 EntryBins[E->second[I].Kind].push_back(E->second[I].Loc); 799 } 800 // Report any duplicate entity definition errors. 801 int KindIndex = 0; 802 for (EntryBinArray::iterator DI = EntryBins.begin(), DE = EntryBins.end(); 803 DI != DE; ++DI, ++KindIndex) { 804 int ECount = DI->size(); 805 // If only 1 occurrence of this entity, skip it, we only report duplicates. 806 if (ECount <= 1) 807 continue; 808 LocationArray::iterator FI = DI->begin(); 809 StringRef kindName = Entry::getKindName((Entry::EntryKind)KindIndex); 810 errs() << "error: " << kindName << " '" << E->first() 811 << "' defined at multiple locations:\n"; 812 for (LocationArray::iterator FE = DI->end(); FI != FE; ++FI) { 813 errs() << " " << FI->File->getName() << ":" << FI->Line << ":" 814 << FI->Column << "\n"; 815 } 816 HadErrors = 1; 817 } 818 } 819 820 // Complain about macro instance in header files that differ based on how 821 // they are included. 822 if (PPTracker->reportInconsistentMacros(errs())) 823 HadErrors = 1; 824 825 // Complain about preprocessor conditional directives in header files that 826 // differ based on how they are included. 827 if (PPTracker->reportInconsistentConditionals(errs())) 828 HadErrors = 1; 829 830 // Complain about any headers that have contents that differ based on how 831 // they are included. 832 // FIXME: Could we provide information about which preprocessor conditionals 833 // are involved? 834 for (DenseMap<const FileEntry *, HeaderContents>::iterator 835 H = Entities.HeaderContentMismatches.begin(), 836 HEnd = Entities.HeaderContentMismatches.end(); 837 H != HEnd; ++H) { 838 if (H->second.empty()) { 839 errs() << "internal error: phantom header content mismatch\n"; 840 continue; 841 } 842 843 HadErrors = 1; 844 errs() << "error: header '" << H->first->getName() 845 << "' has different contents depending on how it was included.\n"; 846 for (unsigned I = 0, N = H->second.size(); I != N; ++I) { 847 errs() << "note: '" << H->second[I].Name << "' in " 848 << H->second[I].Loc.File->getName() << " at " 849 << H->second[I].Loc.Line << ":" << H->second[I].Loc.Column 850 << " not always provided\n"; 851 } 852 } 853 854 return HadErrors; 855 } 856