1 //===-- CodeCompleteTests.cpp -----------------------------------*- C++ -*-===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 9 #include "ASTSignals.h" 10 #include "Annotations.h" 11 #include "ClangdServer.h" 12 #include "CodeComplete.h" 13 #include "Compiler.h" 14 #include "Matchers.h" 15 #include "Protocol.h" 16 #include "Quality.h" 17 #include "SourceCode.h" 18 #include "SyncAPI.h" 19 #include "TestFS.h" 20 #include "TestIndex.h" 21 #include "TestTU.h" 22 #include "index/Index.h" 23 #include "index/MemIndex.h" 24 #include "support/Threading.h" 25 #include "clang/Sema/CodeCompleteConsumer.h" 26 #include "clang/Tooling/CompilationDatabase.h" 27 #include "llvm/Support/Error.h" 28 #include "llvm/Support/Path.h" 29 #include "llvm/Testing/Support/Annotations.h" 30 #include "llvm/Testing/Support/Error.h" 31 #include "gmock/gmock.h" 32 #include "gtest/gtest.h" 33 #include <condition_variable> 34 #include <functional> 35 #include <mutex> 36 #include <vector> 37 38 namespace clang { 39 namespace clangd { 40 41 namespace { 42 using ::llvm::Failed; 43 using ::testing::AllOf; 44 using ::testing::Contains; 45 using ::testing::ElementsAre; 46 using ::testing::Field; 47 using ::testing::HasSubstr; 48 using ::testing::IsEmpty; 49 using ::testing::Not; 50 using ::testing::UnorderedElementsAre; 51 using ContextKind = CodeCompletionContext::Kind; 52 53 // GMock helpers for matching completion items. 54 MATCHER_P(Named, Name, "") { return arg.Name == Name; } 55 MATCHER_P(MainFileRefs, Refs, "") { return arg.MainFileRefs == Refs; } 56 MATCHER_P(ScopeRefs, Refs, "") { return arg.ScopeRefsInFile == Refs; } 57 MATCHER_P(NameStartsWith, Prefix, "") { 58 return llvm::StringRef(arg.Name).startswith(Prefix); 59 } 60 MATCHER_P(Scope, S, "") { return arg.Scope == S; } 61 MATCHER_P(Qualifier, Q, "") { return arg.RequiredQualifier == Q; } 62 MATCHER_P(Labeled, Label, "") { 63 return arg.RequiredQualifier + arg.Name + arg.Signature == Label; 64 } 65 MATCHER_P(SigHelpLabeled, Label, "") { return arg.label == Label; } 66 MATCHER_P(Kind, K, "") { return arg.Kind == K; } 67 MATCHER_P(Doc, D, "") { 68 return arg.Documentation && arg.Documentation->asPlainText() == D; 69 } 70 MATCHER_P(ReturnType, D, "") { return arg.ReturnType == D; } 71 MATCHER_P(HasInclude, IncludeHeader, "") { 72 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader; 73 } 74 MATCHER_P(InsertInclude, IncludeHeader, "") { 75 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader && 76 bool(arg.Includes[0].Insertion); 77 } 78 MATCHER(InsertInclude, "") { 79 return !arg.Includes.empty() && bool(arg.Includes[0].Insertion); 80 } 81 MATCHER_P(SnippetSuffix, Text, "") { return arg.SnippetSuffix == Text; } 82 MATCHER_P(Origin, OriginSet, "") { return arg.Origin == OriginSet; } 83 MATCHER_P(Signature, S, "") { return arg.Signature == S; } 84 85 // Shorthand for Contains(Named(Name)). 86 Matcher<const std::vector<CodeCompletion> &> Has(std::string Name) { 87 return Contains(Named(std::move(Name))); 88 } 89 Matcher<const std::vector<CodeCompletion> &> Has(std::string Name, 90 CompletionItemKind K) { 91 return Contains(AllOf(Named(std::move(Name)), Kind(K))); 92 } 93 MATCHER(IsDocumented, "") { return arg.Documentation.hasValue(); } 94 MATCHER(Deprecated, "") { return arg.Deprecated; } 95 96 std::unique_ptr<SymbolIndex> memIndex(std::vector<Symbol> Symbols) { 97 SymbolSlab::Builder Slab; 98 for (const auto &Sym : Symbols) 99 Slab.insert(Sym); 100 return MemIndex::build(std::move(Slab).build(), RefSlab(), RelationSlab()); 101 } 102 103 // Runs code completion. 104 // If IndexSymbols is non-empty, an index will be built and passed to opts. 105 CodeCompleteResult completions(const TestTU &TU, Position Point, 106 std::vector<Symbol> IndexSymbols = {}, 107 clangd::CodeCompleteOptions Opts = {}) { 108 std::unique_ptr<SymbolIndex> OverrideIndex; 109 if (!IndexSymbols.empty()) { 110 assert(!Opts.Index && "both Index and IndexSymbols given!"); 111 OverrideIndex = memIndex(std::move(IndexSymbols)); 112 Opts.Index = OverrideIndex.get(); 113 } 114 115 MockFS FS; 116 auto Inputs = TU.inputs(FS); 117 IgnoreDiagnostics Diags; 118 auto CI = buildCompilerInvocation(Inputs, Diags); 119 if (!CI) { 120 ADD_FAILURE() << "Couldn't build CompilerInvocation"; 121 return {}; 122 } 123 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs, 124 /*InMemory=*/true, /*Callback=*/nullptr); 125 return codeComplete(testPath(TU.Filename), Point, Preamble.get(), Inputs, 126 Opts); 127 } 128 129 // Runs code completion. 130 CodeCompleteResult completions(llvm::StringRef Text, 131 std::vector<Symbol> IndexSymbols = {}, 132 clangd::CodeCompleteOptions Opts = {}, 133 PathRef FilePath = "foo.cpp") { 134 Annotations Test(Text); 135 auto TU = TestTU::withCode(Test.code()); 136 // To make sure our tests for completiopns inside templates work on Windows. 137 TU.Filename = FilePath.str(); 138 return completions(TU, Test.point(), std::move(IndexSymbols), 139 std::move(Opts)); 140 } 141 142 // Runs code completion without the clang parser. 143 CodeCompleteResult completionsNoCompile(llvm::StringRef Text, 144 std::vector<Symbol> IndexSymbols = {}, 145 clangd::CodeCompleteOptions Opts = {}, 146 PathRef FilePath = "foo.cpp") { 147 std::unique_ptr<SymbolIndex> OverrideIndex; 148 if (!IndexSymbols.empty()) { 149 assert(!Opts.Index && "both Index and IndexSymbols given!"); 150 OverrideIndex = memIndex(std::move(IndexSymbols)); 151 Opts.Index = OverrideIndex.get(); 152 } 153 154 MockFS FS; 155 Annotations Test(Text); 156 ParseInputs ParseInput{tooling::CompileCommand(), &FS, Test.code().str()}; 157 return codeComplete(FilePath, Test.point(), /*Preamble=*/nullptr, ParseInput, 158 Opts); 159 } 160 161 Symbol withReferences(int N, Symbol S) { 162 S.References = N; 163 return S; 164 } 165 166 TEST(DecisionForestRankingModel, NameMatchSanityTest) { 167 clangd::CodeCompleteOptions Opts; 168 Opts.RankingModel = CodeCompleteOptions::DecisionForest; 169 auto Results = completions( 170 R"cpp( 171 struct MemberAccess { 172 int ABG(); 173 int AlphaBetaGamma(); 174 }; 175 int func() { MemberAccess().ABG^ } 176 )cpp", 177 /*IndexSymbols=*/{}, Opts); 178 EXPECT_THAT(Results.Completions, 179 ElementsAre(Named("ABG"), Named("AlphaBetaGamma"))); 180 } 181 182 TEST(DecisionForestRankingModel, ReferencesAffectRanking) { 183 clangd::CodeCompleteOptions Opts; 184 Opts.RankingModel = CodeCompleteOptions::DecisionForest; 185 constexpr int NumReferences = 100000; 186 EXPECT_THAT( 187 completions("int main() { clang^ }", 188 {ns("clangA"), withReferences(NumReferences, func("clangD"))}, 189 Opts) 190 .Completions, 191 ElementsAre(Named("clangD"), Named("clangA"))); 192 EXPECT_THAT( 193 completions("int main() { clang^ }", 194 {withReferences(NumReferences, ns("clangA")), func("clangD")}, 195 Opts) 196 .Completions, 197 ElementsAre(Named("clangA"), Named("clangD"))); 198 } 199 200 TEST(DecisionForestRankingModel, DecisionForestScorerCallbackTest) { 201 clangd::CodeCompleteOptions Opts; 202 constexpr float MagicNumber = 1234.5678f; 203 Opts.RankingModel = CodeCompleteOptions::DecisionForest; 204 Opts.DecisionForestScorer = [&](const SymbolQualitySignals &, 205 const SymbolRelevanceSignals &, float Base) { 206 DecisionForestScores Scores; 207 Scores.Total = MagicNumber; 208 Scores.ExcludingName = MagicNumber; 209 return Scores; 210 }; 211 llvm::StringRef Code = "int func() { int xyz; xy^ }"; 212 auto Results = completions(Code, 213 /*IndexSymbols=*/{}, Opts); 214 ASSERT_EQ(Results.Completions.size(), 1u); 215 EXPECT_EQ(Results.Completions[0].Score.Total, MagicNumber); 216 EXPECT_EQ(Results.Completions[0].Score.ExcludingName, MagicNumber); 217 218 // Do not use DecisionForestScorer for heuristics model. 219 Opts.RankingModel = CodeCompleteOptions::Heuristics; 220 Results = completions(Code, 221 /*IndexSymbols=*/{}, Opts); 222 ASSERT_EQ(Results.Completions.size(), 1u); 223 EXPECT_NE(Results.Completions[0].Score.Total, MagicNumber); 224 EXPECT_NE(Results.Completions[0].Score.ExcludingName, MagicNumber); 225 } 226 227 TEST(CompletionTest, Limit) { 228 clangd::CodeCompleteOptions Opts; 229 Opts.Limit = 2; 230 auto Results = completions(R"cpp( 231 struct ClassWithMembers { 232 int AAA(); 233 int BBB(); 234 int CCC(); 235 }; 236 237 int main() { ClassWithMembers().^ } 238 )cpp", 239 /*IndexSymbols=*/{}, Opts); 240 241 EXPECT_TRUE(Results.HasMore); 242 EXPECT_THAT(Results.Completions, ElementsAre(Named("AAA"), Named("BBB"))); 243 } 244 245 TEST(CompletionTest, Filter) { 246 std::string Body = R"cpp( 247 #define MotorCar 248 int Car; 249 struct S { 250 int FooBar; 251 int FooBaz; 252 int Qux; 253 }; 254 )cpp"; 255 256 // Only items matching the fuzzy query are returned. 257 EXPECT_THAT(completions(Body + "int main() { S().Foba^ }").Completions, 258 AllOf(Has("FooBar"), Has("FooBaz"), Not(Has("Qux")))); 259 260 // Macros require prefix match, either from index or AST. 261 Symbol Sym = var("MotorCarIndex"); 262 Sym.SymInfo.Kind = index::SymbolKind::Macro; 263 EXPECT_THAT( 264 completions(Body + "int main() { C^ }", {Sym}).Completions, 265 AllOf(Has("Car"), Not(Has("MotorCar")), Not(Has("MotorCarIndex")))); 266 EXPECT_THAT(completions(Body + "int main() { M^ }", {Sym}).Completions, 267 AllOf(Has("MotorCar"), Has("MotorCarIndex"))); 268 } 269 270 void testAfterDotCompletion(clangd::CodeCompleteOptions Opts) { 271 auto Results = completions( 272 R"cpp( 273 int global_var; 274 275 int global_func(); 276 277 // Make sure this is not in preamble. 278 #define MACRO X 279 280 struct GlobalClass {}; 281 282 struct ClassWithMembers { 283 /// Doc for method. 284 int method(); 285 286 int field; 287 private: 288 int private_field; 289 }; 290 291 int test() { 292 struct LocalClass {}; 293 294 /// Doc for local_var. 295 int local_var; 296 297 ClassWithMembers().^ 298 } 299 )cpp", 300 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts); 301 302 EXPECT_TRUE(Results.RanParser); 303 // Class members. The only items that must be present in after-dot 304 // completion. 305 EXPECT_THAT(Results.Completions, 306 AllOf(Has("method"), Has("field"), Not(Has("ClassWithMembers")), 307 Not(Has("operator=")), Not(Has("~ClassWithMembers")))); 308 EXPECT_IFF(Opts.IncludeIneligibleResults, Results.Completions, 309 Has("private_field")); 310 // Global items. 311 EXPECT_THAT( 312 Results.Completions, 313 Not(AnyOf(Has("global_var"), Has("index_var"), Has("global_func"), 314 Has("global_func()"), Has("index_func"), Has("GlobalClass"), 315 Has("IndexClass"), Has("MACRO"), Has("LocalClass")))); 316 // There should be no code patterns (aka snippets) in after-dot 317 // completion. At least there aren't any we're aware of. 318 EXPECT_THAT(Results.Completions, 319 Not(Contains(Kind(CompletionItemKind::Snippet)))); 320 // Check documentation. 321 EXPECT_THAT(Results.Completions, Contains(IsDocumented())); 322 } 323 324 void testGlobalScopeCompletion(clangd::CodeCompleteOptions Opts) { 325 auto Results = completions( 326 R"cpp( 327 int global_var; 328 int global_func(); 329 330 // Make sure this is not in preamble. 331 #define MACRO X 332 333 struct GlobalClass {}; 334 335 struct ClassWithMembers { 336 /// Doc for method. 337 int method(); 338 }; 339 340 int test() { 341 struct LocalClass {}; 342 343 /// Doc for local_var. 344 int local_var; 345 346 ^ 347 } 348 )cpp", 349 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts); 350 351 EXPECT_TRUE(Results.RanParser); 352 // Class members. Should never be present in global completions. 353 EXPECT_THAT(Results.Completions, 354 Not(AnyOf(Has("method"), Has("method()"), Has("field")))); 355 // Global items. 356 EXPECT_THAT(Results.Completions, 357 AllOf(Has("global_var"), Has("index_var"), Has("global_func"), 358 Has("index_func" /* our fake symbol doesn't include () */), 359 Has("GlobalClass"), Has("IndexClass"))); 360 // A macro. 361 EXPECT_THAT(Results.Completions, Has("MACRO")); 362 // Local items. Must be present always. 363 EXPECT_THAT(Results.Completions, 364 AllOf(Has("local_var"), Has("LocalClass"), 365 Contains(Kind(CompletionItemKind::Snippet)))); 366 // Check documentation. 367 EXPECT_THAT(Results.Completions, Contains(IsDocumented())); 368 } 369 370 TEST(CompletionTest, CompletionOptions) { 371 auto Test = [&](const clangd::CodeCompleteOptions &Opts) { 372 testAfterDotCompletion(Opts); 373 testGlobalScopeCompletion(Opts); 374 }; 375 // We used to test every combination of options, but that got too slow (2^N). 376 auto Flags = { 377 &clangd::CodeCompleteOptions::IncludeIneligibleResults, 378 }; 379 // Test default options. 380 Test({}); 381 // Test with one flag flipped. 382 for (auto &F : Flags) { 383 clangd::CodeCompleteOptions O; 384 O.*F ^= true; 385 Test(O); 386 } 387 } 388 389 TEST(CompletionTest, Accessible) { 390 auto Internal = completions(R"cpp( 391 class Foo { 392 public: void pub(); 393 protected: void prot(); 394 private: void priv(); 395 }; 396 void Foo::pub() { this->^ } 397 )cpp"); 398 EXPECT_THAT(Internal.Completions, 399 AllOf(Has("priv"), Has("prot"), Has("pub"))); 400 401 auto External = completions(R"cpp( 402 class Foo { 403 public: void pub(); 404 protected: void prot(); 405 private: void priv(); 406 }; 407 void test() { 408 Foo F; 409 F.^ 410 } 411 )cpp"); 412 EXPECT_THAT(External.Completions, 413 AllOf(Has("pub"), Not(Has("prot")), Not(Has("priv")))); 414 } 415 416 TEST(CompletionTest, Qualifiers) { 417 auto Results = completions(R"cpp( 418 class Foo { 419 public: int foo() const; 420 int bar() const; 421 }; 422 class Bar : public Foo { 423 int foo() const; 424 }; 425 void test() { Bar().^ } 426 )cpp"); 427 EXPECT_THAT(Results.Completions, 428 Contains(AllOf(Qualifier(""), Named("bar")))); 429 // Hidden members are not shown. 430 EXPECT_THAT(Results.Completions, 431 Not(Contains(AllOf(Qualifier("Foo::"), Named("foo"))))); 432 // Private members are not shown. 433 EXPECT_THAT(Results.Completions, 434 Not(Contains(AllOf(Qualifier(""), Named("foo"))))); 435 } 436 437 TEST(CompletionTest, InjectedTypename) { 438 // These are suppressed when accessed as a member... 439 EXPECT_THAT(completions("struct X{}; void foo(){ X().^ }").Completions, 440 Not(Has("X"))); 441 EXPECT_THAT(completions("struct X{ void foo(){ this->^ } };").Completions, 442 Not(Has("X"))); 443 // ...but accessible in other, more useful cases. 444 EXPECT_THAT(completions("struct X{ void foo(){ ^ } };").Completions, 445 Has("X")); 446 EXPECT_THAT( 447 completions("struct Y{}; struct X:Y{ void foo(){ ^ } };").Completions, 448 Has("Y")); 449 EXPECT_THAT( 450 completions( 451 "template<class> struct Y{}; struct X:Y<int>{ void foo(){ ^ } };") 452 .Completions, 453 Has("Y")); 454 // This case is marginal (`using X::X` is useful), we allow it for now. 455 EXPECT_THAT(completions("struct X{}; void foo(){ X::^ }").Completions, 456 Has("X")); 457 } 458 459 TEST(CompletionTest, SkipInjectedWhenUnqualified) { 460 EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions, 461 ElementsAre(Named("X"), Named("~X"))); 462 } 463 464 TEST(CompletionTest, Snippets) { 465 clangd::CodeCompleteOptions Opts; 466 auto Results = completions( 467 R"cpp( 468 struct fake { 469 int a; 470 int f(int i, const float f) const; 471 }; 472 int main() { 473 fake f; 474 f.^ 475 } 476 )cpp", 477 /*IndexSymbols=*/{}, Opts); 478 EXPECT_THAT( 479 Results.Completions, 480 HasSubsequence(Named("a"), 481 SnippetSuffix("(${1:int i}, ${2:const float f})"))); 482 } 483 484 TEST(CompletionTest, NoSnippetsInUsings) { 485 clangd::CodeCompleteOptions Opts; 486 Opts.EnableSnippets = true; 487 auto Results = completions( 488 R"cpp( 489 namespace ns { 490 int func(int a, int b); 491 } 492 493 using ns::^; 494 )cpp", 495 /*IndexSymbols=*/{}, Opts); 496 EXPECT_THAT(Results.Completions, 497 ElementsAre(AllOf(Named("func"), Labeled("func(int a, int b)"), 498 SnippetSuffix("")))); 499 500 // Check index completions too. 501 auto Func = func("ns::func"); 502 Func.CompletionSnippetSuffix = "(${1:int a}, ${2: int b})"; 503 Func.Signature = "(int a, int b)"; 504 Func.ReturnType = "void"; 505 506 Results = completions(R"cpp( 507 namespace ns {} 508 using ns::^; 509 )cpp", 510 /*IndexSymbols=*/{Func}, Opts); 511 EXPECT_THAT(Results.Completions, 512 ElementsAre(AllOf(Named("func"), Labeled("func(int a, int b)"), 513 SnippetSuffix("")))); 514 515 // Check all-scopes completions too. 516 Opts.AllScopes = true; 517 Results = completions(R"cpp( 518 using ^; 519 )cpp", 520 /*IndexSymbols=*/{Func}, Opts); 521 EXPECT_THAT(Results.Completions, 522 Contains(AllOf(Named("func"), Labeled("ns::func(int a, int b)"), 523 SnippetSuffix("")))); 524 } 525 526 TEST(CompletionTest, Kinds) { 527 auto Results = completions( 528 R"cpp( 529 int variable; 530 struct Struct {}; 531 int function(); 532 // make sure MACRO is not included in preamble. 533 #define MACRO 10 534 int X = ^ 535 )cpp", 536 {func("indexFunction"), var("indexVariable"), cls("indexClass")}); 537 EXPECT_THAT(Results.Completions, 538 AllOf(Has("function", CompletionItemKind::Function), 539 Has("variable", CompletionItemKind::Variable), 540 Has("int", CompletionItemKind::Keyword), 541 Has("Struct", CompletionItemKind::Struct), 542 Has("MACRO", CompletionItemKind::Text), 543 Has("indexFunction", CompletionItemKind::Function), 544 Has("indexVariable", CompletionItemKind::Variable), 545 Has("indexClass", CompletionItemKind::Class))); 546 547 Results = completions("nam^"); 548 EXPECT_THAT(Results.Completions, 549 Has("namespace", CompletionItemKind::Snippet)); 550 551 // Members of anonymous unions are of kind 'field'. 552 Results = completions( 553 R"cpp( 554 struct X{ 555 union { 556 void *a; 557 }; 558 }; 559 auto u = X().^ 560 )cpp"); 561 EXPECT_THAT( 562 Results.Completions, 563 UnorderedElementsAre(AllOf(Named("a"), Kind(CompletionItemKind::Field)))); 564 565 // Completion kinds for templates should not be unknown. 566 Results = completions( 567 R"cpp( 568 template <class T> struct complete_class {}; 569 template <class T> void complete_function(); 570 template <class T> using complete_type_alias = int; 571 template <class T> int complete_variable = 10; 572 573 struct X { 574 template <class T> static int complete_static_member = 10; 575 576 static auto x = complete_^ 577 } 578 )cpp"); 579 EXPECT_THAT( 580 Results.Completions, 581 UnorderedElementsAre( 582 AllOf(Named("complete_class"), Kind(CompletionItemKind::Class)), 583 AllOf(Named("complete_function"), Kind(CompletionItemKind::Function)), 584 AllOf(Named("complete_type_alias"), 585 Kind(CompletionItemKind::Interface)), 586 AllOf(Named("complete_variable"), Kind(CompletionItemKind::Variable)), 587 AllOf(Named("complete_static_member"), 588 Kind(CompletionItemKind::Property)))); 589 590 Results = completions( 591 R"cpp( 592 enum Color { 593 Red 594 }; 595 Color u = ^ 596 )cpp"); 597 EXPECT_THAT( 598 Results.Completions, 599 Contains(AllOf(Named("Red"), Kind(CompletionItemKind::EnumMember)))); 600 } 601 602 TEST(CompletionTest, NoDuplicates) { 603 auto Results = completions( 604 R"cpp( 605 class Adapter { 606 }; 607 608 void f() { 609 Adapter^ 610 } 611 )cpp", 612 {cls("Adapter")}); 613 614 // Make sure there are no duplicate entries of 'Adapter'. 615 EXPECT_THAT(Results.Completions, ElementsAre(Named("Adapter"))); 616 } 617 618 TEST(CompletionTest, ScopedNoIndex) { 619 auto Results = completions( 620 R"cpp( 621 namespace fake { int BigBang, Babble, Box; }; 622 int main() { fake::ba^ } 623 ")cpp"); 624 // Babble is a better match than BigBang. Box doesn't match at all. 625 EXPECT_THAT(Results.Completions, 626 ElementsAre(Named("Babble"), Named("BigBang"))); 627 } 628 629 TEST(CompletionTest, Scoped) { 630 auto Results = completions( 631 R"cpp( 632 namespace fake { int Babble, Box; }; 633 int main() { fake::ba^ } 634 ")cpp", 635 {var("fake::BigBang")}); 636 EXPECT_THAT(Results.Completions, 637 ElementsAre(Named("Babble"), Named("BigBang"))); 638 } 639 640 TEST(CompletionTest, ScopedWithFilter) { 641 auto Results = completions( 642 R"cpp( 643 void f() { ns::x^ } 644 )cpp", 645 {cls("ns::XYZ"), func("ns::foo")}); 646 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Named("XYZ"))); 647 } 648 649 TEST(CompletionTest, ReferencesAffectRanking) { 650 auto Results = completions("int main() { abs^ }", {ns("absl"), func("absb")}); 651 EXPECT_THAT(Results.Completions, 652 HasSubsequence(Named("absb"), Named("absl"))); 653 Results = completions("int main() { abs^ }", 654 {withReferences(10000, ns("absl")), func("absb")}); 655 EXPECT_THAT(Results.Completions, 656 HasSubsequence(Named("absl"), Named("absb"))); 657 } 658 659 TEST(CompletionTest, ContextWords) { 660 auto Results = completions(R"cpp( 661 enum class Color { RED, YELLOW, BLUE }; 662 663 // (blank lines so the definition above isn't "context") 664 665 // "It was a yellow car," he said. "Big yellow car, new." 666 auto Finish = Color::^ 667 )cpp"); 668 // Yellow would normally sort last (alphabetic). 669 // But the recent mention should bump it up. 670 ASSERT_THAT(Results.Completions, 671 HasSubsequence(Named("YELLOW"), Named("BLUE"))); 672 } 673 674 TEST(CompletionTest, GlobalQualified) { 675 auto Results = completions( 676 R"cpp( 677 void f() { ::^ } 678 )cpp", 679 {cls("XYZ")}); 680 EXPECT_THAT(Results.Completions, 681 AllOf(Has("XYZ", CompletionItemKind::Class), 682 Has("f", CompletionItemKind::Function))); 683 } 684 685 TEST(CompletionTest, FullyQualified) { 686 auto Results = completions( 687 R"cpp( 688 namespace ns { void bar(); } 689 void f() { ::ns::^ } 690 )cpp", 691 {cls("ns::XYZ")}); 692 EXPECT_THAT(Results.Completions, 693 AllOf(Has("XYZ", CompletionItemKind::Class), 694 Has("bar", CompletionItemKind::Function))); 695 } 696 697 TEST(CompletionTest, SemaIndexMerge) { 698 auto Results = completions( 699 R"cpp( 700 namespace ns { int local; void both(); } 701 void f() { ::ns::^ } 702 )cpp", 703 {func("ns::both"), cls("ns::Index")}); 704 // We get results from both index and sema, with no duplicates. 705 EXPECT_THAT(Results.Completions, 706 UnorderedElementsAre( 707 AllOf(Named("local"), Origin(SymbolOrigin::AST)), 708 AllOf(Named("Index"), Origin(SymbolOrigin::Static)), 709 AllOf(Named("both"), 710 Origin(SymbolOrigin::AST | SymbolOrigin::Static)))); 711 } 712 713 TEST(CompletionTest, SemaIndexMergeWithLimit) { 714 clangd::CodeCompleteOptions Opts; 715 Opts.Limit = 1; 716 auto Results = completions( 717 R"cpp( 718 namespace ns { int local; void both(); } 719 void f() { ::ns::^ } 720 )cpp", 721 {func("ns::both"), cls("ns::Index")}, Opts); 722 EXPECT_EQ(Results.Completions.size(), Opts.Limit); 723 EXPECT_TRUE(Results.HasMore); 724 } 725 726 TEST(CompletionTest, IncludeInsertionPreprocessorIntegrationTests) { 727 TestTU TU; 728 TU.ExtraArgs.push_back("-I" + testPath("sub")); 729 TU.AdditionalFiles["sub/bar.h"] = ""; 730 auto BarURI = URI::create(testPath("sub/bar.h")).toString(); 731 732 Symbol Sym = cls("ns::X"); 733 Sym.CanonicalDeclaration.FileURI = BarURI.c_str(); 734 Sym.IncludeHeaders.emplace_back(BarURI, 1); 735 // Shorten include path based on search directory and insert. 736 Annotations Test("int main() { ns::^ }"); 737 TU.Code = Test.code().str(); 738 auto Results = completions(TU, Test.point(), {Sym}); 739 EXPECT_THAT(Results.Completions, 740 ElementsAre(AllOf(Named("X"), InsertInclude("\"bar.h\"")))); 741 // Can be disabled via option. 742 CodeCompleteOptions NoInsertion; 743 NoInsertion.InsertIncludes = CodeCompleteOptions::NeverInsert; 744 Results = completions(TU, Test.point(), {Sym}, NoInsertion); 745 EXPECT_THAT(Results.Completions, 746 ElementsAre(AllOf(Named("X"), Not(InsertInclude())))); 747 // Duplicate based on inclusions in preamble. 748 Test = Annotations(R"cpp( 749 #include "sub/bar.h" // not shortest, so should only match resolved. 750 int main() { ns::^ } 751 )cpp"); 752 TU.Code = Test.code().str(); 753 Results = completions(TU, Test.point(), {Sym}); 754 EXPECT_THAT(Results.Completions, ElementsAre(AllOf(Named("X"), Labeled("X"), 755 Not(InsertInclude())))); 756 } 757 758 TEST(CompletionTest, NoIncludeInsertionWhenDeclFoundInFile) { 759 Symbol SymX = cls("ns::X"); 760 Symbol SymY = cls("ns::Y"); 761 std::string BarHeader = testPath("bar.h"); 762 auto BarURI = URI::create(BarHeader).toString(); 763 SymX.CanonicalDeclaration.FileURI = BarURI.c_str(); 764 SymY.CanonicalDeclaration.FileURI = BarURI.c_str(); 765 SymX.IncludeHeaders.emplace_back("<bar>", 1); 766 SymY.IncludeHeaders.emplace_back("<bar>", 1); 767 // Shorten include path based on search directory and insert. 768 auto Results = completions(R"cpp( 769 namespace ns { 770 class X; 771 class Y {}; 772 } 773 int main() { ns::^ } 774 )cpp", 775 {SymX, SymY}); 776 EXPECT_THAT(Results.Completions, 777 ElementsAre(AllOf(Named("X"), Not(InsertInclude())), 778 AllOf(Named("Y"), Not(InsertInclude())))); 779 } 780 781 TEST(CompletionTest, IndexSuppressesPreambleCompletions) { 782 Annotations Test(R"cpp( 783 #include "bar.h" 784 namespace ns { int local; } 785 void f() { ns::^; } 786 void f2() { ns::preamble().$2^; } 787 )cpp"); 788 auto TU = TestTU::withCode(Test.code()); 789 TU.AdditionalFiles["bar.h"] = 790 R"cpp(namespace ns { struct preamble { int member; }; })cpp"; 791 792 clangd::CodeCompleteOptions Opts = {}; 793 auto I = memIndex({var("ns::index")}); 794 Opts.Index = I.get(); 795 auto WithIndex = completions(TU, Test.point(), {}, Opts); 796 EXPECT_THAT(WithIndex.Completions, 797 UnorderedElementsAre(Named("local"), Named("index"))); 798 auto ClassFromPreamble = completions(TU, Test.point("2"), {}, Opts); 799 EXPECT_THAT(ClassFromPreamble.Completions, Contains(Named("member"))); 800 801 Opts.Index = nullptr; 802 auto WithoutIndex = completions(TU, Test.point(), {}, Opts); 803 EXPECT_THAT(WithoutIndex.Completions, 804 UnorderedElementsAre(Named("local"), Named("preamble"))); 805 } 806 807 // This verifies that we get normal preprocessor completions in the preamble. 808 // This is a regression test for an old bug: if we override the preamble and 809 // try to complete inside it, clang kicks our completion point just outside the 810 // preamble, resulting in always getting top-level completions. 811 TEST(CompletionTest, CompletionInPreamble) { 812 auto Results = completions(R"cpp( 813 #ifnd^ef FOO_H_ 814 #define BAR_H_ 815 #include <bar.h> 816 int foo() {} 817 #endif 818 )cpp") 819 .Completions; 820 EXPECT_THAT(Results, ElementsAre(Named("ifndef"))); 821 } 822 823 TEST(CompletionTest, CompletionRecoveryASTType) { 824 auto Results = completions(R"cpp( 825 struct S { int member; }; 826 S overloaded(int); 827 void foo() { 828 // No overload matches, but we have recovery-expr with the correct type. 829 overloaded().^ 830 })cpp") 831 .Completions; 832 EXPECT_THAT(Results, ElementsAre(Named("member"))); 833 } 834 835 TEST(CompletionTest, DynamicIndexIncludeInsertion) { 836 MockFS FS; 837 MockCompilationDatabase CDB; 838 ClangdServer::Options Opts = ClangdServer::optsForTest(); 839 Opts.BuildDynamicSymbolIndex = true; 840 ClangdServer Server(CDB, FS, Opts); 841 842 FS.Files[testPath("foo_header.h")] = R"cpp( 843 #pragma once 844 struct Foo { 845 // Member doc 846 int foo(); 847 }; 848 )cpp"; 849 const std::string FileContent(R"cpp( 850 #include "foo_header.h" 851 int Foo::foo() { 852 return 42; 853 } 854 )cpp"); 855 Server.addDocument(testPath("foo_impl.cpp"), FileContent); 856 // Wait for the dynamic index being built. 857 ASSERT_TRUE(Server.blockUntilIdleForTest()); 858 859 auto File = testPath("foo.cpp"); 860 Annotations Test("Foo^ foo;"); 861 runAddDocument(Server, File, Test.code()); 862 auto CompletionList = 863 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {})); 864 865 EXPECT_THAT(CompletionList.Completions, 866 ElementsAre(AllOf(Named("Foo"), HasInclude("\"foo_header.h\""), 867 InsertInclude()))); 868 } 869 870 TEST(CompletionTest, DynamicIndexMultiFile) { 871 MockFS FS; 872 MockCompilationDatabase CDB; 873 auto Opts = ClangdServer::optsForTest(); 874 Opts.BuildDynamicSymbolIndex = true; 875 ClangdServer Server(CDB, FS, Opts); 876 877 FS.Files[testPath("foo.h")] = R"cpp( 878 namespace ns { class XYZ {}; void foo(int x) {} } 879 )cpp"; 880 runAddDocument(Server, testPath("foo.cpp"), R"cpp( 881 #include "foo.h" 882 )cpp"); 883 884 auto File = testPath("bar.cpp"); 885 Annotations Test(R"cpp( 886 namespace ns { 887 class XXX {}; 888 /// Doooc 889 void fooooo() {} 890 } 891 void f() { ns::^ } 892 )cpp"); 893 runAddDocument(Server, File, Test.code()); 894 895 auto Results = cantFail(runCodeComplete(Server, File, Test.point(), {})); 896 // "XYZ" and "foo" are not included in the file being completed but are still 897 // visible through the index. 898 EXPECT_THAT(Results.Completions, Has("XYZ", CompletionItemKind::Class)); 899 EXPECT_THAT(Results.Completions, Has("foo", CompletionItemKind::Function)); 900 EXPECT_THAT(Results.Completions, Has("XXX", CompletionItemKind::Class)); 901 EXPECT_THAT(Results.Completions, 902 Contains((Named("fooooo"), Kind(CompletionItemKind::Function), 903 Doc("Doooc"), ReturnType("void")))); 904 } 905 906 TEST(CompletionTest, Documentation) { 907 auto Results = completions( 908 R"cpp( 909 // Non-doxygen comment. 910 int foo(); 911 /// Doxygen comment. 912 /// \param int a 913 int bar(int a); 914 /* Multi-line 915 block comment 916 */ 917 int baz(); 918 919 int x = ^ 920 )cpp"); 921 EXPECT_THAT(Results.Completions, 922 Contains(AllOf(Named("foo"), Doc("Non-doxygen comment.")))); 923 EXPECT_THAT( 924 Results.Completions, 925 Contains(AllOf(Named("bar"), Doc("Doxygen comment.\n\\param int a")))); 926 EXPECT_THAT(Results.Completions, 927 Contains(AllOf(Named("baz"), Doc("Multi-line block comment")))); 928 } 929 930 TEST(CompletionTest, CommentsFromSystemHeaders) { 931 MockFS FS; 932 MockCompilationDatabase CDB; 933 934 auto Opts = ClangdServer::optsForTest(); 935 Opts.BuildDynamicSymbolIndex = true; 936 937 ClangdServer Server(CDB, FS, Opts); 938 939 FS.Files[testPath("foo.h")] = R"cpp( 940 #pragma GCC system_header 941 942 // This comment should be retained! 943 int foo(); 944 )cpp"; 945 946 auto File = testPath("foo.cpp"); 947 Annotations Test(R"cpp( 948 #include "foo.h" 949 int x = foo^ 950 )cpp"); 951 runAddDocument(Server, File, Test.code()); 952 auto CompletionList = 953 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {})); 954 955 EXPECT_THAT( 956 CompletionList.Completions, 957 Contains(AllOf(Named("foo"), Doc("This comment should be retained!")))); 958 } 959 960 TEST(CompletionTest, GlobalCompletionFiltering) { 961 962 Symbol Class = cls("XYZ"); 963 Class.Flags = static_cast<Symbol::SymbolFlag>( 964 Class.Flags & ~(Symbol::IndexedForCodeCompletion)); 965 Symbol Func = func("XYZ::foooo"); 966 Func.Flags = static_cast<Symbol::SymbolFlag>( 967 Func.Flags & ~(Symbol::IndexedForCodeCompletion)); 968 969 auto Results = completions(R"(// void f() { 970 XYZ::foooo^ 971 })", 972 {Class, Func}); 973 EXPECT_THAT(Results.Completions, IsEmpty()); 974 } 975 976 TEST(CodeCompleteTest, DisableTypoCorrection) { 977 auto Results = completions(R"cpp( 978 namespace clang { int v; } 979 void f() { clangd::^ 980 )cpp"); 981 EXPECT_TRUE(Results.Completions.empty()); 982 } 983 984 TEST(CodeCompleteTest, NoColonColonAtTheEnd) { 985 auto Results = completions(R"cpp( 986 namespace clang { } 987 void f() { 988 clan^ 989 } 990 )cpp"); 991 992 EXPECT_THAT(Results.Completions, Contains(Labeled("clang"))); 993 EXPECT_THAT(Results.Completions, Not(Contains(Labeled("clang::")))); 994 } 995 996 TEST(CompletionTest, BacktrackCrashes) { 997 // Sema calls code completion callbacks twice in these cases. 998 auto Results = completions(R"cpp( 999 namespace ns { 1000 struct FooBarBaz {}; 1001 } // namespace ns 1002 1003 int foo(ns::FooBar^ 1004 )cpp"); 1005 1006 EXPECT_THAT(Results.Completions, ElementsAre(Labeled("FooBarBaz"))); 1007 1008 // Check we don't crash in that case too. 1009 completions(R"cpp( 1010 struct FooBarBaz {}; 1011 void test() { 1012 if (FooBarBaz * x^) {} 1013 } 1014 )cpp"); 1015 } 1016 1017 TEST(CompletionTest, CompleteInMacroWithStringification) { 1018 auto Results = completions(R"cpp( 1019 void f(const char *, int x); 1020 #define F(x) f(#x, x) 1021 1022 namespace ns { 1023 int X; 1024 int Y; 1025 } // namespace ns 1026 1027 int f(int input_num) { 1028 F(ns::^) 1029 } 1030 )cpp"); 1031 1032 EXPECT_THAT(Results.Completions, 1033 UnorderedElementsAre(Named("X"), Named("Y"))); 1034 } 1035 1036 TEST(CompletionTest, CompleteInMacroAndNamespaceWithStringification) { 1037 auto Results = completions(R"cpp( 1038 void f(const char *, int x); 1039 #define F(x) f(#x, x) 1040 1041 namespace ns { 1042 int X; 1043 1044 int f(int input_num) { 1045 F(^) 1046 } 1047 } // namespace ns 1048 )cpp"); 1049 1050 EXPECT_THAT(Results.Completions, Contains(Named("X"))); 1051 } 1052 1053 TEST(CompletionTest, IgnoreCompleteInExcludedPPBranchWithRecoveryContext) { 1054 auto Results = completions(R"cpp( 1055 int bar(int param_in_bar) { 1056 } 1057 1058 int foo(int param_in_foo) { 1059 #if 0 1060 // In recovery mode, "param_in_foo" will also be suggested among many other 1061 // unrelated symbols; however, this is really a special case where this works. 1062 // If the #if block is outside of the function, "param_in_foo" is still 1063 // suggested, but "bar" and "foo" are missing. So the recovery mode doesn't 1064 // really provide useful results in excluded branches. 1065 par^ 1066 #endif 1067 } 1068 )cpp"); 1069 1070 EXPECT_TRUE(Results.Completions.empty()); 1071 } 1072 1073 TEST(CompletionTest, DefaultArgs) { 1074 clangd::CodeCompleteOptions Opts; 1075 std::string Context = R"cpp( 1076 int X(int A = 0); 1077 int Y(int A, int B = 0); 1078 int Z(int A, int B = 0, int C = 0, int D = 0); 1079 )cpp"; 1080 EXPECT_THAT(completions(Context + "int y = X^", {}, Opts).Completions, 1081 UnorderedElementsAre(Labeled("X(int A = 0)"))); 1082 EXPECT_THAT(completions(Context + "int y = Y^", {}, Opts).Completions, 1083 UnorderedElementsAre(AllOf(Labeled("Y(int A, int B = 0)"), 1084 SnippetSuffix("(${1:int A})")))); 1085 EXPECT_THAT(completions(Context + "int y = Z^", {}, Opts).Completions, 1086 UnorderedElementsAre( 1087 AllOf(Labeled("Z(int A, int B = 0, int C = 0, int D = 0)"), 1088 SnippetSuffix("(${1:int A})")))); 1089 } 1090 1091 TEST(CompletionTest, NoCrashWithTemplateParamsAndPreferredTypes) { 1092 auto Completions = completions(R"cpp( 1093 template <template <class> class TT> int foo() { 1094 int a = ^ 1095 } 1096 )cpp") 1097 .Completions; 1098 EXPECT_THAT(Completions, Contains(Named("TT"))); 1099 } 1100 1101 TEST(CompletionTest, NestedTemplateHeuristics) { 1102 auto Completions = completions(R"cpp( 1103 struct Plain { int xxx; }; 1104 template <typename T> class Templ { Plain ppp; }; 1105 template <typename T> void foo(Templ<T> &t) { 1106 // Formally ppp has DependentTy, because Templ may be specialized. 1107 // However we sholud be able to see into it using the primary template. 1108 t.ppp.^ 1109 } 1110 )cpp") 1111 .Completions; 1112 EXPECT_THAT(Completions, Contains(Named("xxx"))); 1113 } 1114 1115 TEST(CompletionTest, RecordCCResultCallback) { 1116 std::vector<CodeCompletion> RecordedCompletions; 1117 CodeCompleteOptions Opts; 1118 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC, 1119 const SymbolQualitySignals &, 1120 const SymbolRelevanceSignals &, 1121 float Score) { 1122 RecordedCompletions.push_back(CC); 1123 }; 1124 1125 completions("int xy1, xy2; int a = xy^", /*IndexSymbols=*/{}, Opts); 1126 EXPECT_THAT(RecordedCompletions, 1127 UnorderedElementsAre(Named("xy1"), Named("xy2"))); 1128 } 1129 1130 TEST(CompletionTest, ASTSignals) { 1131 struct Completion { 1132 std::string Name; 1133 unsigned MainFileRefs; 1134 unsigned ScopeRefsInFile; 1135 }; 1136 CodeCompleteOptions Opts; 1137 std::vector<Completion> RecordedCompletions; 1138 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC, 1139 const SymbolQualitySignals &, 1140 const SymbolRelevanceSignals &R, 1141 float Score) { 1142 RecordedCompletions.push_back({CC.Name, R.MainFileRefs, R.ScopeRefsInFile}); 1143 }; 1144 ASTSignals MainFileSignals; 1145 MainFileSignals.ReferencedSymbols[var("xy1").ID] = 3; 1146 MainFileSignals.ReferencedSymbols[var("xy2").ID] = 1; 1147 MainFileSignals.ReferencedSymbols[var("xyindex").ID] = 10; 1148 MainFileSignals.RelatedNamespaces["tar::"] = 5; 1149 MainFileSignals.RelatedNamespaces["bar::"] = 3; 1150 Opts.MainFileSignals = &MainFileSignals; 1151 Opts.AllScopes = true; 1152 completions( 1153 R"cpp( 1154 int xy1; 1155 int xy2; 1156 namespace bar { 1157 int xybar = 1; 1158 int a = xy^ 1159 } 1160 )cpp", 1161 /*IndexSymbols=*/{var("xyindex"), var("tar::xytar"), var("bar::xybar")}, 1162 Opts); 1163 EXPECT_THAT(RecordedCompletions, 1164 UnorderedElementsAre( 1165 AllOf(Named("xy1"), MainFileRefs(3u), ScopeRefs(0u)), 1166 AllOf(Named("xy2"), MainFileRefs(1u), ScopeRefs(0u)), 1167 AllOf(Named("xyindex"), MainFileRefs(10u), ScopeRefs(0u)), 1168 AllOf(Named("xytar"), MainFileRefs(0u), ScopeRefs(5u)), 1169 AllOf(/*both from sema and index*/ Named("xybar"), 1170 MainFileRefs(0u), ScopeRefs(3u)))); 1171 } 1172 1173 SignatureHelp signatures(llvm::StringRef Text, Position Point, 1174 std::vector<Symbol> IndexSymbols = {}) { 1175 std::unique_ptr<SymbolIndex> Index; 1176 if (!IndexSymbols.empty()) 1177 Index = memIndex(IndexSymbols); 1178 1179 auto TU = TestTU::withCode(Text); 1180 MockFS FS; 1181 auto Inputs = TU.inputs(FS); 1182 Inputs.Index = Index.get(); 1183 IgnoreDiagnostics Diags; 1184 auto CI = buildCompilerInvocation(Inputs, Diags); 1185 if (!CI) { 1186 ADD_FAILURE() << "Couldn't build CompilerInvocation"; 1187 return {}; 1188 } 1189 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs, 1190 /*InMemory=*/true, /*Callback=*/nullptr); 1191 if (!Preamble) { 1192 ADD_FAILURE() << "Couldn't build Preamble"; 1193 return {}; 1194 } 1195 return signatureHelp(testPath(TU.Filename), Point, *Preamble, Inputs); 1196 } 1197 1198 SignatureHelp signatures(llvm::StringRef Text, 1199 std::vector<Symbol> IndexSymbols = {}) { 1200 Annotations Test(Text); 1201 return signatures(Test.code(), Test.point(), std::move(IndexSymbols)); 1202 } 1203 1204 struct ExpectedParameter { 1205 std::string Text; 1206 std::pair<unsigned, unsigned> Offsets; 1207 }; 1208 MATCHER_P(ParamsAre, P, "") { 1209 if (P.size() != arg.parameters.size()) 1210 return false; 1211 for (unsigned I = 0; I < P.size(); ++I) { 1212 if (P[I].Text != arg.parameters[I].labelString || 1213 P[I].Offsets != arg.parameters[I].labelOffsets) 1214 return false; 1215 } 1216 return true; 1217 } 1218 MATCHER_P(SigDoc, Doc, "") { return arg.documentation == Doc; } 1219 1220 /// \p AnnotatedLabel is a signature label with ranges marking parameters, e.g. 1221 /// foo([[int p1]], [[double p2]]) -> void 1222 Matcher<SignatureInformation> Sig(llvm::StringRef AnnotatedLabel) { 1223 llvm::Annotations A(AnnotatedLabel); 1224 std::string Label = std::string(A.code()); 1225 std::vector<ExpectedParameter> Parameters; 1226 for (auto Range : A.ranges()) { 1227 Parameters.emplace_back(); 1228 1229 ExpectedParameter &P = Parameters.back(); 1230 P.Text = Label.substr(Range.Begin, Range.End - Range.Begin); 1231 P.Offsets.first = lspLength(llvm::StringRef(Label).substr(0, Range.Begin)); 1232 P.Offsets.second = lspLength(llvm::StringRef(Label).substr(1, Range.End)); 1233 } 1234 return AllOf(SigHelpLabeled(Label), ParamsAre(Parameters)); 1235 } 1236 1237 TEST(SignatureHelpTest, Overloads) { 1238 auto Results = signatures(R"cpp( 1239 void foo(int x, int y); 1240 void foo(int x, float y); 1241 void foo(float x, int y); 1242 void foo(float x, float y); 1243 void bar(int x, int y = 0); 1244 int main() { foo(^); } 1245 )cpp"); 1246 EXPECT_THAT(Results.signatures, 1247 UnorderedElementsAre(Sig("foo([[float x]], [[float y]]) -> void"), 1248 Sig("foo([[float x]], [[int y]]) -> void"), 1249 Sig("foo([[int x]], [[float y]]) -> void"), 1250 Sig("foo([[int x]], [[int y]]) -> void"))); 1251 // We always prefer the first signature. 1252 EXPECT_EQ(0, Results.activeSignature); 1253 EXPECT_EQ(0, Results.activeParameter); 1254 } 1255 1256 TEST(SignatureHelpTest, DefaultArgs) { 1257 auto Results = signatures(R"cpp( 1258 void bar(int x, int y = 0); 1259 void bar(float x = 0, int y = 42); 1260 int main() { bar(^ 1261 )cpp"); 1262 EXPECT_THAT(Results.signatures, 1263 UnorderedElementsAre( 1264 Sig("bar([[int x]], [[int y = 0]]) -> void"), 1265 Sig("bar([[float x = 0]], [[int y = 42]]) -> void"))); 1266 EXPECT_EQ(0, Results.activeSignature); 1267 EXPECT_EQ(0, Results.activeParameter); 1268 } 1269 1270 TEST(SignatureHelpTest, ActiveArg) { 1271 auto Results = signatures(R"cpp( 1272 int baz(int a, int b, int c); 1273 int main() { baz(baz(1,2,3), ^); } 1274 )cpp"); 1275 EXPECT_THAT(Results.signatures, 1276 ElementsAre(Sig("baz([[int a]], [[int b]], [[int c]]) -> int"))); 1277 EXPECT_EQ(0, Results.activeSignature); 1278 EXPECT_EQ(1, Results.activeParameter); 1279 } 1280 1281 TEST(SignatureHelpTest, OpeningParen) { 1282 llvm::StringLiteral Tests[] = { 1283 // Recursive function call. 1284 R"cpp( 1285 int foo(int a, int b, int c); 1286 int main() { 1287 foo(foo $p^( foo(10, 10, 10), ^ ))); 1288 })cpp", 1289 // Functional type cast. 1290 R"cpp( 1291 struct Foo { 1292 Foo(int a, int b, int c); 1293 }; 1294 int main() { 1295 Foo $p^( 10, ^ ); 1296 })cpp", 1297 // New expression. 1298 R"cpp( 1299 struct Foo { 1300 Foo(int a, int b, int c); 1301 }; 1302 int main() { 1303 new Foo $p^( 10, ^ ); 1304 })cpp", 1305 // Macro expansion. 1306 R"cpp( 1307 int foo(int a, int b, int c); 1308 #define FOO foo( 1309 1310 int main() { 1311 // Macro expansions. 1312 $p^FOO 10, ^ ); 1313 })cpp", 1314 // Macro arguments. 1315 R"cpp( 1316 int foo(int a, int b, int c); 1317 int main() { 1318 #define ID(X) X 1319 // FIXME: figure out why ID(foo (foo(10), )) doesn't work when preserving 1320 // the recovery expression. 1321 ID(foo $p^( 10, ^ )) 1322 })cpp", 1323 // Dependent args. 1324 R"cpp( 1325 int foo(int a, int b); 1326 template <typename T> void bar(T t) { 1327 foo$p^(t, ^t); 1328 })cpp", 1329 // Dependent args on templated func. 1330 R"cpp( 1331 template <typename T> 1332 int foo(T, T); 1333 template <typename T> void bar(T t) { 1334 foo$p^(t, ^t); 1335 })cpp", 1336 // Dependent args on member. 1337 R"cpp( 1338 struct Foo { int foo(int, int); }; 1339 template <typename T> void bar(T t) { 1340 Foo f; 1341 f.foo$p^(t, ^t); 1342 })cpp", 1343 // Dependent args on templated member. 1344 R"cpp( 1345 struct Foo { template <typename T> int foo(T, T); }; 1346 template <typename T> void bar(T t) { 1347 Foo f; 1348 f.foo$p^(t, ^t); 1349 })cpp", 1350 }; 1351 1352 for (auto Test : Tests) { 1353 Annotations Code(Test); 1354 EXPECT_EQ(signatures(Code.code(), Code.point()).argListStart, 1355 Code.point("p")) 1356 << "Test source:" << Test; 1357 } 1358 } 1359 1360 TEST(SignatureHelpTest, StalePreamble) { 1361 TestTU TU; 1362 TU.Code = ""; 1363 IgnoreDiagnostics Diags; 1364 MockFS FS; 1365 auto Inputs = TU.inputs(FS); 1366 auto CI = buildCompilerInvocation(Inputs, Diags); 1367 ASSERT_TRUE(CI); 1368 auto EmptyPreamble = buildPreamble(testPath(TU.Filename), *CI, Inputs, 1369 /*InMemory=*/true, /*Callback=*/nullptr); 1370 ASSERT_TRUE(EmptyPreamble); 1371 1372 TU.AdditionalFiles["a.h"] = "int foo(int x);"; 1373 const Annotations Test(R"cpp( 1374 #include "a.h" 1375 void bar() { foo(^2); })cpp"); 1376 TU.Code = Test.code().str(); 1377 auto Results = signatureHelp(testPath(TU.Filename), Test.point(), 1378 *EmptyPreamble, TU.inputs(FS)); 1379 EXPECT_THAT(Results.signatures, ElementsAre(Sig("foo([[int x]]) -> int"))); 1380 EXPECT_EQ(0, Results.activeSignature); 1381 EXPECT_EQ(0, Results.activeParameter); 1382 } 1383 1384 class IndexRequestCollector : public SymbolIndex { 1385 public: 1386 bool 1387 fuzzyFind(const FuzzyFindRequest &Req, 1388 llvm::function_ref<void(const Symbol &)> Callback) const override { 1389 std::unique_lock<std::mutex> Lock(Mut); 1390 Requests.push_back(Req); 1391 ReceivedRequestCV.notify_one(); 1392 return true; 1393 } 1394 1395 void lookup(const LookupRequest &, 1396 llvm::function_ref<void(const Symbol &)>) const override {} 1397 1398 bool refs(const RefsRequest &, 1399 llvm::function_ref<void(const Ref &)>) const override { 1400 return false; 1401 } 1402 1403 void relations(const RelationsRequest &, 1404 llvm::function_ref<void(const SymbolID &, const Symbol &)>) 1405 const override {} 1406 1407 llvm::unique_function<IndexContents(llvm::StringRef) const> 1408 indexedFiles() const override { 1409 return [](llvm::StringRef) { return IndexContents::None; }; 1410 } 1411 1412 // This is incorrect, but IndexRequestCollector is not an actual index and it 1413 // isn't used in production code. 1414 size_t estimateMemoryUsage() const override { return 0; } 1415 1416 const std::vector<FuzzyFindRequest> consumeRequests(size_t Num) const { 1417 std::unique_lock<std::mutex> Lock(Mut); 1418 EXPECT_TRUE(wait(Lock, ReceivedRequestCV, timeoutSeconds(30), 1419 [this, Num] { return Requests.size() == Num; })); 1420 auto Reqs = std::move(Requests); 1421 Requests = {}; 1422 return Reqs; 1423 } 1424 1425 private: 1426 // We need a mutex to handle async fuzzy find requests. 1427 mutable std::condition_variable ReceivedRequestCV; 1428 mutable std::mutex Mut; 1429 mutable std::vector<FuzzyFindRequest> Requests; 1430 }; 1431 1432 // Clients have to consume exactly Num requests. 1433 std::vector<FuzzyFindRequest> captureIndexRequests(llvm::StringRef Code, 1434 size_t Num = 1) { 1435 clangd::CodeCompleteOptions Opts; 1436 IndexRequestCollector Requests; 1437 Opts.Index = &Requests; 1438 completions(Code, {}, Opts); 1439 const auto Reqs = Requests.consumeRequests(Num); 1440 EXPECT_EQ(Reqs.size(), Num); 1441 return Reqs; 1442 } 1443 1444 TEST(CompletionTest, UnqualifiedIdQuery) { 1445 auto Requests = captureIndexRequests(R"cpp( 1446 namespace std {} 1447 using namespace std; 1448 namespace ns { 1449 void f() { 1450 vec^ 1451 } 1452 } 1453 )cpp"); 1454 1455 EXPECT_THAT(Requests, 1456 ElementsAre(Field(&FuzzyFindRequest::Scopes, 1457 UnorderedElementsAre("", "ns::", "std::")))); 1458 } 1459 1460 TEST(CompletionTest, EnclosingScopeComesFirst) { 1461 auto Requests = captureIndexRequests(R"cpp( 1462 namespace std {} 1463 using namespace std; 1464 namespace nx { 1465 namespace ns { 1466 namespace { 1467 void f() { 1468 vec^ 1469 } 1470 } 1471 } 1472 } 1473 )cpp"); 1474 1475 EXPECT_THAT(Requests, 1476 ElementsAre(Field( 1477 &FuzzyFindRequest::Scopes, 1478 UnorderedElementsAre("", "std::", "nx::ns::", "nx::")))); 1479 EXPECT_EQ(Requests[0].Scopes[0], "nx::ns::"); 1480 } 1481 1482 TEST(CompletionTest, ResolvedQualifiedIdQuery) { 1483 auto Requests = captureIndexRequests(R"cpp( 1484 namespace ns1 {} 1485 namespace ns2 {} // ignore 1486 namespace ns3 { namespace nns3 {} } 1487 namespace foo { 1488 using namespace ns1; 1489 using namespace ns3::nns3; 1490 } 1491 namespace ns { 1492 void f() { 1493 foo::^ 1494 } 1495 } 1496 )cpp"); 1497 1498 EXPECT_THAT(Requests, 1499 ElementsAre(Field( 1500 &FuzzyFindRequest::Scopes, 1501 UnorderedElementsAre("foo::", "ns1::", "ns3::nns3::")))); 1502 } 1503 1504 TEST(CompletionTest, UnresolvedQualifierIdQuery) { 1505 auto Requests = captureIndexRequests(R"cpp( 1506 namespace a {} 1507 using namespace a; 1508 namespace ns { 1509 void f() { 1510 bar::^ 1511 } 1512 } // namespace ns 1513 )cpp"); 1514 1515 EXPECT_THAT(Requests, 1516 ElementsAre(Field( 1517 &FuzzyFindRequest::Scopes, 1518 UnorderedElementsAre("a::bar::", "ns::bar::", "bar::")))); 1519 } 1520 1521 TEST(CompletionTest, UnresolvedNestedQualifierIdQuery) { 1522 auto Requests = captureIndexRequests(R"cpp( 1523 namespace a {} 1524 using namespace a; 1525 namespace ns { 1526 void f() { 1527 ::a::bar::^ 1528 } 1529 } // namespace ns 1530 )cpp"); 1531 1532 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, 1533 UnorderedElementsAre("a::bar::")))); 1534 } 1535 1536 TEST(CompletionTest, EmptyQualifiedQuery) { 1537 auto Requests = captureIndexRequests(R"cpp( 1538 namespace ns { 1539 void f() { 1540 ^ 1541 } 1542 } // namespace ns 1543 )cpp"); 1544 1545 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, 1546 UnorderedElementsAre("", "ns::")))); 1547 } 1548 1549 TEST(CompletionTest, GlobalQualifiedQuery) { 1550 auto Requests = captureIndexRequests(R"cpp( 1551 namespace ns { 1552 void f() { 1553 ::^ 1554 } 1555 } // namespace ns 1556 )cpp"); 1557 1558 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, 1559 UnorderedElementsAre("")))); 1560 } 1561 1562 TEST(CompletionTest, NoDuplicatedQueryScopes) { 1563 auto Requests = captureIndexRequests(R"cpp( 1564 namespace {} 1565 1566 namespace na { 1567 namespace {} 1568 namespace nb { 1569 ^ 1570 } // namespace nb 1571 } // namespace na 1572 )cpp"); 1573 1574 EXPECT_THAT(Requests, 1575 ElementsAre(Field(&FuzzyFindRequest::Scopes, 1576 UnorderedElementsAre("na::", "na::nb::", "")))); 1577 } 1578 1579 TEST(CompletionTest, NoIndexCompletionsInsideClasses) { 1580 auto Completions = completions( 1581 R"cpp( 1582 struct Foo { 1583 int SomeNameOfField; 1584 typedef int SomeNameOfTypedefField; 1585 }; 1586 1587 Foo::^)cpp", 1588 {func("::SomeNameInTheIndex"), func("::Foo::SomeNameInTheIndex")}); 1589 1590 EXPECT_THAT(Completions.Completions, 1591 AllOf(Contains(Labeled("SomeNameOfField")), 1592 Contains(Labeled("SomeNameOfTypedefField")), 1593 Not(Contains(Labeled("SomeNameInTheIndex"))))); 1594 } 1595 1596 TEST(CompletionTest, NoIndexCompletionsInsideDependentCode) { 1597 { 1598 auto Completions = completions( 1599 R"cpp( 1600 template <class T> 1601 void foo() { 1602 T::^ 1603 } 1604 )cpp", 1605 {func("::SomeNameInTheIndex")}); 1606 1607 EXPECT_THAT(Completions.Completions, 1608 Not(Contains(Labeled("SomeNameInTheIndex")))); 1609 } 1610 1611 { 1612 auto Completions = completions( 1613 R"cpp( 1614 template <class T> 1615 void foo() { 1616 T::template Y<int>::^ 1617 } 1618 )cpp", 1619 {func("::SomeNameInTheIndex")}); 1620 1621 EXPECT_THAT(Completions.Completions, 1622 Not(Contains(Labeled("SomeNameInTheIndex")))); 1623 } 1624 1625 { 1626 auto Completions = completions( 1627 R"cpp( 1628 template <class T> 1629 void foo() { 1630 T::foo::^ 1631 } 1632 )cpp", 1633 {func("::SomeNameInTheIndex")}); 1634 1635 EXPECT_THAT(Completions.Completions, 1636 Not(Contains(Labeled("SomeNameInTheIndex")))); 1637 } 1638 } 1639 1640 TEST(CompletionTest, OverloadBundling) { 1641 clangd::CodeCompleteOptions Opts; 1642 Opts.BundleOverloads = true; 1643 1644 std::string Context = R"cpp( 1645 struct X { 1646 // Overload with int 1647 int a(int); 1648 // Overload with bool 1649 int a(bool); 1650 int b(float); 1651 }; 1652 int GFuncC(int); 1653 int GFuncD(int); 1654 )cpp"; 1655 1656 // Member completions are bundled. 1657 EXPECT_THAT(completions(Context + "int y = X().^", {}, Opts).Completions, 1658 UnorderedElementsAre(Labeled("a(…)"), Labeled("b(float)"))); 1659 1660 // Non-member completions are bundled, including index+sema. 1661 Symbol NoArgsGFunc = func("GFuncC"); 1662 EXPECT_THAT( 1663 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions, 1664 UnorderedElementsAre(Labeled("GFuncC(…)"), Labeled("GFuncD(int)"))); 1665 1666 // Differences in header-to-insert suppress bundling. 1667 std::string DeclFile = URI::create(testPath("foo")).toString(); 1668 NoArgsGFunc.CanonicalDeclaration.FileURI = DeclFile.c_str(); 1669 NoArgsGFunc.IncludeHeaders.emplace_back("<foo>", 1); 1670 EXPECT_THAT( 1671 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions, 1672 UnorderedElementsAre(AllOf(Named("GFuncC"), InsertInclude("<foo>")), 1673 Labeled("GFuncC(int)"), Labeled("GFuncD(int)"))); 1674 1675 // Examine a bundled completion in detail. 1676 auto A = 1677 completions(Context + "int y = X().a^", {}, Opts).Completions.front(); 1678 EXPECT_EQ(A.Name, "a"); 1679 EXPECT_EQ(A.Signature, "(…)"); 1680 EXPECT_EQ(A.BundleSize, 2u); 1681 EXPECT_EQ(A.Kind, CompletionItemKind::Method); 1682 EXPECT_EQ(A.ReturnType, "int"); // All overloads return int. 1683 // For now we just return one of the doc strings arbitrarily. 1684 ASSERT_TRUE(A.Documentation); 1685 EXPECT_THAT( 1686 A.Documentation->asPlainText(), 1687 AnyOf(HasSubstr("Overload with int"), HasSubstr("Overload with bool"))); 1688 EXPECT_EQ(A.SnippetSuffix, "($0)"); 1689 } 1690 1691 TEST(CompletionTest, OverloadBundlingSameFileDifferentURI) { 1692 clangd::CodeCompleteOptions Opts; 1693 Opts.BundleOverloads = true; 1694 1695 Symbol SymX = sym("ns::X", index::SymbolKind::Function, "@F@\\0#"); 1696 Symbol SymY = sym("ns::X", index::SymbolKind::Function, "@F@\\0#I#"); 1697 std::string BarHeader = testPath("bar.h"); 1698 auto BarURI = URI::create(BarHeader).toString(); 1699 SymX.CanonicalDeclaration.FileURI = BarURI.c_str(); 1700 SymY.CanonicalDeclaration.FileURI = BarURI.c_str(); 1701 // The include header is different, but really it's the same file. 1702 SymX.IncludeHeaders.emplace_back("\"bar.h\"", 1); 1703 SymY.IncludeHeaders.emplace_back(BarURI.c_str(), 1); 1704 1705 auto Results = completions("void f() { ::ns::^ }", {SymX, SymY}, Opts); 1706 // Expect both results are bundled, despite the different-but-same 1707 // IncludeHeader. 1708 ASSERT_EQ(1u, Results.Completions.size()); 1709 const auto &R = Results.Completions.front(); 1710 EXPECT_EQ("X", R.Name); 1711 EXPECT_EQ(2u, R.BundleSize); 1712 } 1713 1714 TEST(CompletionTest, DocumentationFromChangedFileCrash) { 1715 MockFS FS; 1716 auto FooH = testPath("foo.h"); 1717 auto FooCpp = testPath("foo.cpp"); 1718 FS.Files[FooH] = R"cpp( 1719 // this is my documentation comment. 1720 int func(); 1721 )cpp"; 1722 FS.Files[FooCpp] = ""; 1723 1724 MockCompilationDatabase CDB; 1725 ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); 1726 1727 Annotations Source(R"cpp( 1728 #include "foo.h" 1729 int func() { 1730 // This makes sure we have func from header in the AST. 1731 } 1732 int a = fun^ 1733 )cpp"); 1734 Server.addDocument(FooCpp, Source.code(), "null", WantDiagnostics::Yes); 1735 // We need to wait for preamble to build. 1736 ASSERT_TRUE(Server.blockUntilIdleForTest()); 1737 1738 // Change the header file. Completion will reuse the old preamble! 1739 FS.Files[FooH] = R"cpp( 1740 int func(); 1741 )cpp"; 1742 1743 clangd::CodeCompleteOptions Opts; 1744 CodeCompleteResult Completions = 1745 cantFail(runCodeComplete(Server, FooCpp, Source.point(), Opts)); 1746 // We shouldn't crash. Unfortunately, current workaround is to not produce 1747 // comments for symbols from headers. 1748 EXPECT_THAT(Completions.Completions, 1749 Contains(AllOf(Not(IsDocumented()), Named("func")))); 1750 } 1751 1752 TEST(CompletionTest, NonDocComments) { 1753 const char *Text = R"cpp( 1754 // We ignore namespace comments, for rationale see CodeCompletionStrings.h. 1755 namespace comments_ns { 1756 } 1757 1758 // ------------------ 1759 int comments_foo(); 1760 1761 // A comment and a decl are separated by newlines. 1762 // Therefore, the comment shouldn't show up as doc comment. 1763 1764 int comments_bar(); 1765 1766 // this comment should be in the results. 1767 int comments_baz(); 1768 1769 1770 template <class T> 1771 struct Struct { 1772 int comments_qux(); 1773 int comments_quux(); 1774 }; 1775 1776 1777 // This comment should not be there. 1778 1779 template <class T> 1780 int Struct<T>::comments_qux() { 1781 } 1782 1783 // This comment **should** be in results. 1784 template <class T> 1785 int Struct<T>::comments_quux() { 1786 int a = comments^; 1787 } 1788 )cpp"; 1789 1790 // We should not get any of those comments in completion. 1791 EXPECT_THAT( 1792 completions(Text).Completions, 1793 UnorderedElementsAre(AllOf(Not(IsDocumented()), Named("comments_foo")), 1794 AllOf(IsDocumented(), Named("comments_baz")), 1795 AllOf(IsDocumented(), Named("comments_quux")), 1796 AllOf(Not(IsDocumented()), Named("comments_ns")), 1797 // FIXME(ibiryukov): the following items should have 1798 // empty documentation, since they are separated from 1799 // a comment with an empty line. Unfortunately, I 1800 // couldn't make Sema tests pass if we ignore those. 1801 AllOf(IsDocumented(), Named("comments_bar")), 1802 AllOf(IsDocumented(), Named("comments_qux")))); 1803 } 1804 1805 TEST(CompletionTest, CompleteOnInvalidLine) { 1806 auto FooCpp = testPath("foo.cpp"); 1807 1808 MockCompilationDatabase CDB; 1809 MockFS FS; 1810 FS.Files[FooCpp] = "// empty file"; 1811 1812 ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); 1813 // Run completion outside the file range. 1814 Position Pos; 1815 Pos.line = 100; 1816 Pos.character = 0; 1817 EXPECT_THAT_EXPECTED( 1818 runCodeComplete(Server, FooCpp, Pos, clangd::CodeCompleteOptions()), 1819 Failed()); 1820 } 1821 1822 TEST(CompletionTest, QualifiedNames) { 1823 auto Results = completions( 1824 R"cpp( 1825 namespace ns { int local; void both(); } 1826 void f() { ::ns::^ } 1827 )cpp", 1828 {func("ns::both"), cls("ns::Index")}); 1829 // We get results from both index and sema, with no duplicates. 1830 EXPECT_THAT( 1831 Results.Completions, 1832 UnorderedElementsAre(Scope("ns::"), Scope("ns::"), Scope("ns::"))); 1833 } 1834 1835 TEST(CompletionTest, Render) { 1836 CodeCompletion C; 1837 C.Name = "x"; 1838 C.Signature = "(bool) const"; 1839 C.SnippetSuffix = "(${0:bool})"; 1840 C.ReturnType = "int"; 1841 C.RequiredQualifier = "Foo::"; 1842 C.Scope = "ns::Foo::"; 1843 C.Documentation.emplace(); 1844 C.Documentation->addParagraph().appendText("This is ").appendCode("x()"); 1845 C.Includes.emplace_back(); 1846 auto &Include = C.Includes.back(); 1847 Include.Header = "\"foo.h\""; 1848 C.Kind = CompletionItemKind::Method; 1849 C.Score.Total = 1.0; 1850 C.Score.ExcludingName = .5; 1851 C.Origin = SymbolOrigin::AST | SymbolOrigin::Static; 1852 1853 CodeCompleteOptions Opts; 1854 Opts.IncludeIndicator.Insert = "^"; 1855 Opts.IncludeIndicator.NoInsert = ""; 1856 Opts.EnableSnippets = false; 1857 1858 auto R = C.render(Opts); 1859 EXPECT_EQ(R.label, "Foo::x(bool) const"); 1860 EXPECT_EQ(R.insertText, "Foo::x"); 1861 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText); 1862 EXPECT_EQ(R.filterText, "x"); 1863 EXPECT_EQ(R.detail, "int"); 1864 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\nThis is x()"); 1865 EXPECT_THAT(R.additionalTextEdits, IsEmpty()); 1866 EXPECT_EQ(R.sortText, sortText(1.0, "x")); 1867 EXPECT_FALSE(R.deprecated); 1868 EXPECT_EQ(R.score, .5f); 1869 1870 Opts.EnableSnippets = true; 1871 R = C.render(Opts); 1872 EXPECT_EQ(R.insertText, "Foo::x(${0:bool})"); 1873 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::Snippet); 1874 1875 Include.Insertion.emplace(); 1876 R = C.render(Opts); 1877 EXPECT_EQ(R.label, "^Foo::x(bool) const"); 1878 EXPECT_THAT(R.additionalTextEdits, Not(IsEmpty())); 1879 1880 Opts.ShowOrigins = true; 1881 R = C.render(Opts); 1882 EXPECT_EQ(R.label, "^[AS]Foo::x(bool) const"); 1883 1884 C.BundleSize = 2; 1885 R = C.render(Opts); 1886 EXPECT_EQ(R.detail, "[2 overloads]"); 1887 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\nThis is x()"); 1888 1889 C.Deprecated = true; 1890 R = C.render(Opts); 1891 EXPECT_TRUE(R.deprecated); 1892 1893 Opts.DocumentationFormat = MarkupKind::Markdown; 1894 R = C.render(Opts); 1895 EXPECT_EQ(R.documentation->value, "From `\"foo.h\"` \nThis is `x()`"); 1896 } 1897 1898 TEST(CompletionTest, IgnoreRecoveryResults) { 1899 auto Results = completions( 1900 R"cpp( 1901 namespace ns { int NotRecovered() { return 0; } } 1902 void f() { 1903 // Sema enters recovery mode first and then normal mode. 1904 if (auto x = ns::NotRecover^) 1905 } 1906 )cpp"); 1907 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Named("NotRecovered"))); 1908 } 1909 1910 TEST(CompletionTest, ScopeOfClassFieldInConstructorInitializer) { 1911 auto Results = completions( 1912 R"cpp( 1913 namespace ns { 1914 class X { public: X(); int x_; }; 1915 X::X() : x_^(0) {} 1916 } 1917 )cpp"); 1918 EXPECT_THAT(Results.Completions, 1919 UnorderedElementsAre(AllOf(Scope("ns::X::"), Named("x_")))); 1920 } 1921 1922 TEST(CompletionTest, CodeCompletionContext) { 1923 auto Results = completions( 1924 R"cpp( 1925 namespace ns { 1926 class X { public: X(); int x_; }; 1927 void f() { 1928 X x; 1929 x.^; 1930 } 1931 } 1932 )cpp"); 1933 1934 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess); 1935 } 1936 1937 TEST(CompletionTest, FixItForArrowToDot) { 1938 MockFS FS; 1939 MockCompilationDatabase CDB; 1940 1941 CodeCompleteOptions Opts; 1942 Opts.IncludeFixIts = true; 1943 const char *Code = 1944 R"cpp( 1945 class Auxilary { 1946 public: 1947 void AuxFunction(); 1948 }; 1949 class ClassWithPtr { 1950 public: 1951 void MemberFunction(); 1952 Auxilary* operator->() const; 1953 Auxilary* Aux; 1954 }; 1955 void f() { 1956 ClassWithPtr x; 1957 x[[->]]^; 1958 } 1959 )cpp"; 1960 auto Results = completions(Code, {}, Opts); 1961 EXPECT_EQ(Results.Completions.size(), 3u); 1962 1963 TextEdit ReplacementEdit; 1964 ReplacementEdit.range = Annotations(Code).range(); 1965 ReplacementEdit.newText = "."; 1966 for (const auto &C : Results.Completions) { 1967 EXPECT_TRUE(C.FixIts.size() == 1u || C.Name == "AuxFunction"); 1968 if (!C.FixIts.empty()) { 1969 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit)); 1970 } 1971 } 1972 } 1973 1974 TEST(CompletionTest, FixItForDotToArrow) { 1975 CodeCompleteOptions Opts; 1976 Opts.IncludeFixIts = true; 1977 const char *Code = 1978 R"cpp( 1979 class Auxilary { 1980 public: 1981 void AuxFunction(); 1982 }; 1983 class ClassWithPtr { 1984 public: 1985 void MemberFunction(); 1986 Auxilary* operator->() const; 1987 Auxilary* Aux; 1988 }; 1989 void f() { 1990 ClassWithPtr x; 1991 x[[.]]^; 1992 } 1993 )cpp"; 1994 auto Results = completions(Code, {}, Opts); 1995 EXPECT_EQ(Results.Completions.size(), 3u); 1996 1997 TextEdit ReplacementEdit; 1998 ReplacementEdit.range = Annotations(Code).range(); 1999 ReplacementEdit.newText = "->"; 2000 for (const auto &C : Results.Completions) { 2001 EXPECT_TRUE(C.FixIts.empty() || C.Name == "AuxFunction"); 2002 if (!C.FixIts.empty()) { 2003 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit)); 2004 } 2005 } 2006 } 2007 2008 TEST(CompletionTest, RenderWithFixItMerged) { 2009 TextEdit FixIt; 2010 FixIt.range.end.character = 5; 2011 FixIt.newText = "->"; 2012 2013 CodeCompletion C; 2014 C.Name = "x"; 2015 C.RequiredQualifier = "Foo::"; 2016 C.FixIts = {FixIt}; 2017 C.CompletionTokenRange.start.character = 5; 2018 2019 CodeCompleteOptions Opts; 2020 Opts.IncludeFixIts = true; 2021 2022 auto R = C.render(Opts); 2023 EXPECT_TRUE(R.textEdit); 2024 EXPECT_EQ(R.textEdit->newText, "->Foo::x"); 2025 EXPECT_TRUE(R.additionalTextEdits.empty()); 2026 } 2027 2028 TEST(CompletionTest, RenderWithFixItNonMerged) { 2029 TextEdit FixIt; 2030 FixIt.range.end.character = 4; 2031 FixIt.newText = "->"; 2032 2033 CodeCompletion C; 2034 C.Name = "x"; 2035 C.RequiredQualifier = "Foo::"; 2036 C.FixIts = {FixIt}; 2037 C.CompletionTokenRange.start.character = 5; 2038 2039 CodeCompleteOptions Opts; 2040 Opts.IncludeFixIts = true; 2041 2042 auto R = C.render(Opts); 2043 EXPECT_TRUE(R.textEdit); 2044 EXPECT_EQ(R.textEdit->newText, "Foo::x"); 2045 EXPECT_THAT(R.additionalTextEdits, UnorderedElementsAre(FixIt)); 2046 } 2047 2048 TEST(CompletionTest, CompletionTokenRange) { 2049 MockFS FS; 2050 MockCompilationDatabase CDB; 2051 TestTU TU; 2052 TU.AdditionalFiles["foo/abc/foo.h"] = ""; 2053 2054 constexpr const char *TestCodes[] = { 2055 R"cpp( 2056 class Auxilary { 2057 public: 2058 void AuxFunction(); 2059 }; 2060 void f() { 2061 Auxilary x; 2062 x.[[Aux]]^; 2063 } 2064 )cpp", 2065 R"cpp( 2066 class Auxilary { 2067 public: 2068 void AuxFunction(); 2069 }; 2070 void f() { 2071 Auxilary x; 2072 x.[[]]^; 2073 } 2074 )cpp", 2075 R"cpp( 2076 #include "foo/[[a^/]]foo.h" 2077 )cpp", 2078 R"cpp( 2079 #include "foo/abc/[[fo^o.h"]] 2080 )cpp", 2081 }; 2082 for (const auto &Text : TestCodes) { 2083 Annotations TestCode(Text); 2084 TU.Code = TestCode.code().str(); 2085 auto Results = completions(TU, TestCode.point()); 2086 if (Results.Completions.size() != 1) { 2087 ADD_FAILURE() << "Results.Completions.size() != 1" << Text; 2088 continue; 2089 } 2090 EXPECT_THAT(Results.Completions.front().CompletionTokenRange, 2091 TestCode.range()); 2092 } 2093 } 2094 2095 TEST(SignatureHelpTest, OverloadsOrdering) { 2096 const auto Results = signatures(R"cpp( 2097 void foo(int x); 2098 void foo(int x, float y); 2099 void foo(float x, int y); 2100 void foo(float x, float y); 2101 void foo(int x, int y = 0); 2102 int main() { foo(^); } 2103 )cpp"); 2104 EXPECT_THAT(Results.signatures, 2105 ElementsAre(Sig("foo([[int x]]) -> void"), 2106 Sig("foo([[int x]], [[int y = 0]]) -> void"), 2107 Sig("foo([[float x]], [[int y]]) -> void"), 2108 Sig("foo([[int x]], [[float y]]) -> void"), 2109 Sig("foo([[float x]], [[float y]]) -> void"))); 2110 // We always prefer the first signature. 2111 EXPECT_EQ(0, Results.activeSignature); 2112 EXPECT_EQ(0, Results.activeParameter); 2113 } 2114 2115 TEST(SignatureHelpTest, InstantiatedSignatures) { 2116 StringRef Sig0 = R"cpp( 2117 template <class T> 2118 void foo(T, T, T); 2119 2120 int main() { 2121 foo<int>(^); 2122 } 2123 )cpp"; 2124 2125 EXPECT_THAT(signatures(Sig0).signatures, 2126 ElementsAre(Sig("foo([[T]], [[T]], [[T]]) -> void"))); 2127 2128 StringRef Sig1 = R"cpp( 2129 template <class T> 2130 void foo(T, T, T); 2131 2132 int main() { 2133 foo(10, ^); 2134 })cpp"; 2135 2136 EXPECT_THAT(signatures(Sig1).signatures, 2137 ElementsAre(Sig("foo([[T]], [[T]], [[T]]) -> void"))); 2138 2139 StringRef Sig2 = R"cpp( 2140 template <class ...T> 2141 void foo(T...); 2142 2143 int main() { 2144 foo<int>(^); 2145 } 2146 )cpp"; 2147 2148 EXPECT_THAT(signatures(Sig2).signatures, 2149 ElementsAre(Sig("foo([[T...]]) -> void"))); 2150 2151 // It is debatable whether we should substitute the outer template parameter 2152 // ('T') in that case. Currently we don't substitute it in signature help, but 2153 // do substitute in code complete. 2154 // FIXME: make code complete and signature help consistent, figure out which 2155 // way is better. 2156 StringRef Sig3 = R"cpp( 2157 template <class T> 2158 struct X { 2159 template <class U> 2160 void foo(T, U); 2161 }; 2162 2163 int main() { 2164 X<int>().foo<double>(^) 2165 } 2166 )cpp"; 2167 2168 EXPECT_THAT(signatures(Sig3).signatures, 2169 ElementsAre(Sig("foo([[T]], [[U]]) -> void"))); 2170 } 2171 2172 TEST(SignatureHelpTest, IndexDocumentation) { 2173 Symbol Foo0 = sym("foo", index::SymbolKind::Function, "@F@\\0#"); 2174 Foo0.Documentation = "Doc from the index"; 2175 Symbol Foo1 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#"); 2176 Foo1.Documentation = "Doc from the index"; 2177 Symbol Foo2 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#I#"); 2178 2179 StringRef Sig0 = R"cpp( 2180 int foo(); 2181 int foo(double); 2182 2183 void test() { 2184 foo(^); 2185 } 2186 )cpp"; 2187 2188 EXPECT_THAT( 2189 signatures(Sig0, {Foo0}).signatures, 2190 ElementsAre(AllOf(Sig("foo() -> int"), SigDoc("Doc from the index")), 2191 AllOf(Sig("foo([[double]]) -> int"), SigDoc("")))); 2192 2193 StringRef Sig1 = R"cpp( 2194 int foo(); 2195 // Overriden doc from sema 2196 int foo(int); 2197 // Doc from sema 2198 int foo(int, int); 2199 2200 void test() { 2201 foo(^); 2202 } 2203 )cpp"; 2204 2205 EXPECT_THAT( 2206 signatures(Sig1, {Foo0, Foo1, Foo2}).signatures, 2207 ElementsAre( 2208 AllOf(Sig("foo() -> int"), SigDoc("Doc from the index")), 2209 AllOf(Sig("foo([[int]]) -> int"), SigDoc("Overriden doc from sema")), 2210 AllOf(Sig("foo([[int]], [[int]]) -> int"), SigDoc("Doc from sema")))); 2211 } 2212 2213 TEST(SignatureHelpTest, DynamicIndexDocumentation) { 2214 MockFS FS; 2215 MockCompilationDatabase CDB; 2216 ClangdServer::Options Opts = ClangdServer::optsForTest(); 2217 Opts.BuildDynamicSymbolIndex = true; 2218 ClangdServer Server(CDB, FS, Opts); 2219 2220 FS.Files[testPath("foo.h")] = R"cpp( 2221 struct Foo { 2222 // Member doc 2223 int foo(); 2224 }; 2225 )cpp"; 2226 Annotations FileContent(R"cpp( 2227 #include "foo.h" 2228 void test() { 2229 Foo f; 2230 f.foo(^); 2231 } 2232 )cpp"); 2233 auto File = testPath("test.cpp"); 2234 Server.addDocument(File, FileContent.code()); 2235 // Wait for the dynamic index being built. 2236 ASSERT_TRUE(Server.blockUntilIdleForTest()); 2237 EXPECT_THAT( 2238 llvm::cantFail(runSignatureHelp(Server, File, FileContent.point())) 2239 .signatures, 2240 ElementsAre(AllOf(Sig("foo() -> int"), SigDoc("Member doc")))); 2241 } 2242 2243 TEST(CompletionTest, CompletionFunctionArgsDisabled) { 2244 CodeCompleteOptions Opts; 2245 Opts.EnableSnippets = true; 2246 Opts.EnableFunctionArgSnippets = false; 2247 2248 { 2249 auto Results = completions( 2250 R"cpp( 2251 void xfoo(); 2252 void xfoo(int x, int y); 2253 void f() { xfo^ })cpp", 2254 {}, Opts); 2255 EXPECT_THAT( 2256 Results.Completions, 2257 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("()")), 2258 AllOf(Named("xfoo"), SnippetSuffix("($0)")))); 2259 } 2260 { 2261 auto Results = completions( 2262 R"cpp( 2263 void xbar(); 2264 void f() { xba^ })cpp", 2265 {}, Opts); 2266 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf( 2267 Named("xbar"), SnippetSuffix("()")))); 2268 } 2269 { 2270 Opts.BundleOverloads = true; 2271 auto Results = completions( 2272 R"cpp( 2273 void xfoo(); 2274 void xfoo(int x, int y); 2275 void f() { xfo^ })cpp", 2276 {}, Opts); 2277 EXPECT_THAT( 2278 Results.Completions, 2279 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("($0)")))); 2280 } 2281 { 2282 auto Results = completions( 2283 R"cpp( 2284 template <class T, class U> 2285 void xfoo(int a, U b); 2286 void f() { xfo^ })cpp", 2287 {}, Opts); 2288 EXPECT_THAT( 2289 Results.Completions, 2290 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("<$1>($0)")))); 2291 } 2292 { 2293 auto Results = completions( 2294 R"cpp( 2295 template <class T> 2296 class foo_class{}; 2297 template <class T> 2298 using foo_alias = T**; 2299 void f() { foo_^ })cpp", 2300 {}, Opts); 2301 EXPECT_THAT( 2302 Results.Completions, 2303 UnorderedElementsAre(AllOf(Named("foo_class"), SnippetSuffix("<$0>")), 2304 AllOf(Named("foo_alias"), SnippetSuffix("<$0>")))); 2305 } 2306 } 2307 2308 TEST(CompletionTest, SuggestOverrides) { 2309 constexpr const char *const Text(R"cpp( 2310 class A { 2311 public: 2312 virtual void vfunc(bool param); 2313 virtual void vfunc(bool param, int p); 2314 void func(bool param); 2315 }; 2316 class B : public A { 2317 virtual void ttt(bool param) const; 2318 void vfunc(bool param, int p) override; 2319 }; 2320 class C : public B { 2321 public: 2322 void vfunc(bool param) override; 2323 ^ 2324 }; 2325 )cpp"); 2326 const auto Results = completions(Text); 2327 EXPECT_THAT( 2328 Results.Completions, 2329 AllOf(Contains(AllOf(Labeled("void vfunc(bool param, int p) override"), 2330 NameStartsWith("vfunc"))), 2331 Contains(AllOf(Labeled("void ttt(bool param) const override"), 2332 NameStartsWith("ttt"))), 2333 Not(Contains(Labeled("void vfunc(bool param) override"))))); 2334 } 2335 2336 TEST(CompletionTest, OverridesNonIdentName) { 2337 // Check the completions call does not crash. 2338 completions(R"cpp( 2339 struct Base { 2340 virtual ~Base() = 0; 2341 virtual operator int() = 0; 2342 virtual Base& operator+(Base&) = 0; 2343 }; 2344 2345 struct Derived : Base { 2346 ^ 2347 }; 2348 )cpp"); 2349 } 2350 2351 TEST(GuessCompletionPrefix, Filters) { 2352 for (llvm::StringRef Case : { 2353 "[[scope::]][[ident]]^", 2354 "[[]][[]]^", 2355 "\n[[]][[]]^", 2356 "[[]][[ab]]^", 2357 "x.[[]][[ab]]^", 2358 "x.[[]][[]]^", 2359 "[[x::]][[ab]]^", 2360 "[[x::]][[]]^", 2361 "[[::x::]][[ab]]^", 2362 "some text [[scope::more::]][[identif]]^ier", 2363 "some text [[scope::]][[mor]]^e::identifier", 2364 "weird case foo::[[::bar::]][[baz]]^", 2365 "/* [[]][[]]^ */", 2366 }) { 2367 Annotations F(Case); 2368 auto Offset = cantFail(positionToOffset(F.code(), F.point())); 2369 auto ToStringRef = [&](Range R) { 2370 return F.code().slice(cantFail(positionToOffset(F.code(), R.start)), 2371 cantFail(positionToOffset(F.code(), R.end))); 2372 }; 2373 auto WantQualifier = ToStringRef(F.ranges()[0]), 2374 WantName = ToStringRef(F.ranges()[1]); 2375 2376 auto Prefix = guessCompletionPrefix(F.code(), Offset); 2377 // Even when components are empty, check their offsets are correct. 2378 EXPECT_EQ(WantQualifier, Prefix.Qualifier) << Case; 2379 EXPECT_EQ(WantQualifier.begin(), Prefix.Qualifier.begin()) << Case; 2380 EXPECT_EQ(WantName, Prefix.Name) << Case; 2381 EXPECT_EQ(WantName.begin(), Prefix.Name.begin()) << Case; 2382 } 2383 } 2384 2385 TEST(CompletionTest, EnableSpeculativeIndexRequest) { 2386 MockFS FS; 2387 MockCompilationDatabase CDB; 2388 ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); 2389 2390 auto File = testPath("foo.cpp"); 2391 Annotations Test(R"cpp( 2392 namespace ns1 { int abc; } 2393 namespace ns2 { int abc; } 2394 void f() { ns1::ab$1^; ns1::ab$2^; } 2395 void f2() { ns2::ab$3^; } 2396 )cpp"); 2397 runAddDocument(Server, File, Test.code()); 2398 clangd::CodeCompleteOptions Opts = {}; 2399 2400 IndexRequestCollector Requests; 2401 Opts.Index = &Requests; 2402 2403 auto CompleteAtPoint = [&](StringRef P) { 2404 cantFail(runCodeComplete(Server, File, Test.point(P), Opts)); 2405 }; 2406 2407 CompleteAtPoint("1"); 2408 auto Reqs1 = Requests.consumeRequests(1); 2409 ASSERT_EQ(Reqs1.size(), 1u); 2410 EXPECT_THAT(Reqs1[0].Scopes, UnorderedElementsAre("ns1::")); 2411 2412 CompleteAtPoint("2"); 2413 auto Reqs2 = Requests.consumeRequests(1); 2414 // Speculation succeeded. Used speculative index result. 2415 ASSERT_EQ(Reqs2.size(), 1u); 2416 EXPECT_EQ(Reqs2[0], Reqs1[0]); 2417 2418 CompleteAtPoint("3"); 2419 // Speculation failed. Sent speculative index request and the new index 2420 // request after sema. 2421 auto Reqs3 = Requests.consumeRequests(2); 2422 ASSERT_EQ(Reqs3.size(), 2u); 2423 } 2424 2425 TEST(CompletionTest, InsertTheMostPopularHeader) { 2426 std::string DeclFile = URI::create(testPath("foo")).toString(); 2427 Symbol Sym = func("Func"); 2428 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str(); 2429 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2); 2430 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000); 2431 2432 auto Results = completions("Fun^", {Sym}).Completions; 2433 assert(!Results.empty()); 2434 EXPECT_THAT(Results[0], AllOf(Named("Func"), InsertInclude("\"bar.h\""))); 2435 EXPECT_EQ(Results[0].Includes.size(), 2u); 2436 } 2437 2438 TEST(CompletionTest, NoInsertIncludeIfOnePresent) { 2439 Annotations Test(R"cpp( 2440 #include "foo.h" 2441 Fun^ 2442 )cpp"); 2443 auto TU = TestTU::withCode(Test.code()); 2444 TU.AdditionalFiles["foo.h"] = ""; 2445 2446 std::string DeclFile = URI::create(testPath("foo")).toString(); 2447 Symbol Sym = func("Func"); 2448 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str(); 2449 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2); 2450 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000); 2451 2452 EXPECT_THAT(completions(TU, Test.point(), {Sym}).Completions, 2453 UnorderedElementsAre(AllOf(Named("Func"), HasInclude("\"foo.h\""), 2454 Not(InsertInclude())))); 2455 } 2456 2457 TEST(CompletionTest, MergeMacrosFromIndexAndSema) { 2458 Symbol Sym; 2459 Sym.Name = "Clangd_Macro_Test"; 2460 Sym.ID = SymbolID("c:foo.cpp@8@macro@Clangd_Macro_Test"); 2461 Sym.SymInfo.Kind = index::SymbolKind::Macro; 2462 Sym.Flags |= Symbol::IndexedForCodeCompletion; 2463 EXPECT_THAT(completions("#define Clangd_Macro_Test\nClangd_Macro_T^", {Sym}) 2464 .Completions, 2465 UnorderedElementsAre(Named("Clangd_Macro_Test"))); 2466 } 2467 2468 TEST(CompletionTest, MacroFromPreamble) { 2469 Annotations Test(R"cpp(#define CLANGD_PREAMBLE_MAIN x 2470 2471 int x = 0; 2472 #define CLANGD_MAIN x 2473 void f() { CLANGD_^ } 2474 )cpp"); 2475 auto TU = TestTU::withCode(Test.code()); 2476 TU.HeaderCode = "#define CLANGD_PREAMBLE_HEADER x"; 2477 auto Results = completions(TU, Test.point(), {func("CLANGD_INDEX")}); 2478 // We should get results from the main file, including the preamble section. 2479 // However no results from included files (the index should cover them). 2480 EXPECT_THAT(Results.Completions, 2481 UnorderedElementsAre(Named("CLANGD_PREAMBLE_MAIN"), 2482 Named("CLANGD_MAIN"), 2483 Named("CLANGD_INDEX"))); 2484 } 2485 2486 TEST(CompletionTest, DeprecatedResults) { 2487 std::string Body = R"cpp( 2488 void TestClangd(); 2489 void TestClangc() __attribute__((deprecated("", ""))); 2490 )cpp"; 2491 2492 EXPECT_THAT( 2493 completions(Body + "int main() { TestClang^ }").Completions, 2494 UnorderedElementsAre(AllOf(Named("TestClangd"), Not(Deprecated())), 2495 AllOf(Named("TestClangc"), Deprecated()))); 2496 } 2497 2498 TEST(SignatureHelpTest, PartialSpec) { 2499 const auto Results = signatures(R"cpp( 2500 template <typename T> struct Foo {}; 2501 template <typename T> struct Foo<T*> { Foo(T); }; 2502 Foo<int*> F(^);)cpp"); 2503 EXPECT_THAT(Results.signatures, Contains(Sig("Foo([[T]])"))); 2504 EXPECT_EQ(0, Results.activeParameter); 2505 } 2506 2507 TEST(SignatureHelpTest, InsideArgument) { 2508 { 2509 const auto Results = signatures(R"cpp( 2510 void foo(int x); 2511 void foo(int x, int y); 2512 int main() { foo(1+^); } 2513 )cpp"); 2514 EXPECT_THAT(Results.signatures, 2515 ElementsAre(Sig("foo([[int x]]) -> void"), 2516 Sig("foo([[int x]], [[int y]]) -> void"))); 2517 EXPECT_EQ(0, Results.activeParameter); 2518 } 2519 { 2520 const auto Results = signatures(R"cpp( 2521 void foo(int x); 2522 void foo(int x, int y); 2523 int main() { foo(1^); } 2524 )cpp"); 2525 EXPECT_THAT(Results.signatures, 2526 ElementsAre(Sig("foo([[int x]]) -> void"), 2527 Sig("foo([[int x]], [[int y]]) -> void"))); 2528 EXPECT_EQ(0, Results.activeParameter); 2529 } 2530 { 2531 const auto Results = signatures(R"cpp( 2532 void foo(int x); 2533 void foo(int x, int y); 2534 int main() { foo(1^0); } 2535 )cpp"); 2536 EXPECT_THAT(Results.signatures, 2537 ElementsAre(Sig("foo([[int x]]) -> void"), 2538 Sig("foo([[int x]], [[int y]]) -> void"))); 2539 EXPECT_EQ(0, Results.activeParameter); 2540 } 2541 { 2542 const auto Results = signatures(R"cpp( 2543 void foo(int x); 2544 void foo(int x, int y); 2545 int bar(int x, int y); 2546 int main() { bar(foo(2, 3^)); } 2547 )cpp"); 2548 EXPECT_THAT(Results.signatures, 2549 ElementsAre(Sig("foo([[int x]], [[int y]]) -> void"))); 2550 EXPECT_EQ(1, Results.activeParameter); 2551 } 2552 } 2553 2554 TEST(SignatureHelpTest, ConstructorInitializeFields) { 2555 { 2556 const auto Results = signatures(R"cpp( 2557 struct A { 2558 A(int); 2559 }; 2560 struct B { 2561 B() : a_elem(^) {} 2562 A a_elem; 2563 }; 2564 )cpp"); 2565 EXPECT_THAT(Results.signatures, 2566 UnorderedElementsAre(Sig("A([[int]])"), Sig("A([[A &&]])"), 2567 Sig("A([[const A &]])"))); 2568 } 2569 { 2570 const auto Results = signatures(R"cpp( 2571 struct A { 2572 A(int); 2573 }; 2574 struct C { 2575 C(int); 2576 C(A); 2577 }; 2578 struct B { 2579 B() : c_elem(A(1^)) {} 2580 C c_elem; 2581 }; 2582 )cpp"); 2583 EXPECT_THAT(Results.signatures, 2584 UnorderedElementsAre(Sig("A([[int]])"), Sig("A([[A &&]])"), 2585 Sig("A([[const A &]])"))); 2586 } 2587 } 2588 2589 TEST(CompletionTest, IncludedCompletionKinds) { 2590 Annotations Test(R"cpp(#include "^)cpp"); 2591 auto TU = TestTU::withCode(Test.code()); 2592 TU.AdditionalFiles["sub/bar.h"] = ""; 2593 TU.ExtraArgs.push_back("-I" + testPath("sub")); 2594 2595 auto Results = completions(TU, Test.point()); 2596 EXPECT_THAT(Results.Completions, 2597 AllOf(Has("sub/", CompletionItemKind::Folder), 2598 Has("bar.h\"", CompletionItemKind::File))); 2599 } 2600 2601 TEST(CompletionTest, NoCrashAtNonAlphaIncludeHeader) { 2602 completions( 2603 R"cpp( 2604 #include "./^" 2605 )cpp"); 2606 } 2607 2608 TEST(CompletionTest, NoAllScopesCompletionWhenQualified) { 2609 clangd::CodeCompleteOptions Opts = {}; 2610 Opts.AllScopes = true; 2611 2612 auto Results = completions( 2613 R"cpp( 2614 void f() { na::Clangd^ } 2615 )cpp", 2616 {cls("na::ClangdA"), cls("nx::ClangdX"), cls("Clangd3")}, Opts); 2617 EXPECT_THAT(Results.Completions, 2618 UnorderedElementsAre( 2619 AllOf(Qualifier(""), Scope("na::"), Named("ClangdA")))); 2620 } 2621 2622 TEST(CompletionTest, AllScopesCompletion) { 2623 clangd::CodeCompleteOptions Opts = {}; 2624 Opts.AllScopes = true; 2625 2626 auto Results = completions( 2627 R"cpp( 2628 namespace na { 2629 void f() { Clangd^ } 2630 } 2631 )cpp", 2632 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"), 2633 cls("na::nb::Clangd4")}, 2634 Opts); 2635 EXPECT_THAT( 2636 Results.Completions, 2637 UnorderedElementsAre(AllOf(Qualifier("nx::"), Named("Clangd1")), 2638 AllOf(Qualifier("ny::"), Named("Clangd2")), 2639 AllOf(Qualifier(""), Scope(""), Named("Clangd3")), 2640 AllOf(Qualifier("nb::"), Named("Clangd4")))); 2641 } 2642 2643 TEST(CompletionTest, NoQualifierIfShadowed) { 2644 clangd::CodeCompleteOptions Opts = {}; 2645 Opts.AllScopes = true; 2646 2647 auto Results = completions(R"cpp( 2648 namespace nx { class Clangd1 {}; } 2649 using nx::Clangd1; 2650 void f() { Clangd^ } 2651 )cpp", 2652 {cls("nx::Clangd1"), cls("nx::Clangd2")}, Opts); 2653 // Although Clangd1 is from another namespace, Sema tells us it's in-scope and 2654 // needs no qualifier. 2655 EXPECT_THAT(Results.Completions, 2656 UnorderedElementsAre(AllOf(Qualifier(""), Named("Clangd1")), 2657 AllOf(Qualifier("nx::"), Named("Clangd2")))); 2658 } 2659 2660 TEST(CompletionTest, NoCompletionsForNewNames) { 2661 clangd::CodeCompleteOptions Opts; 2662 Opts.AllScopes = true; 2663 auto Results = completions(R"cpp( 2664 void f() { int n^ } 2665 )cpp", 2666 {cls("naber"), cls("nx::naber")}, Opts); 2667 EXPECT_THAT(Results.Completions, UnorderedElementsAre()); 2668 } 2669 2670 TEST(CompletionTest, Lambda) { 2671 clangd::CodeCompleteOptions Opts = {}; 2672 2673 auto Results = completions(R"cpp( 2674 void function() { 2675 auto Lambda = [](int a, const double &b) {return 1.f;}; 2676 Lam^ 2677 } 2678 )cpp", 2679 {}, Opts); 2680 2681 ASSERT_EQ(Results.Completions.size(), 1u); 2682 const auto &A = Results.Completions.front(); 2683 EXPECT_EQ(A.Name, "Lambda"); 2684 EXPECT_EQ(A.Signature, "(int a, const double &b) const"); 2685 EXPECT_EQ(A.Kind, CompletionItemKind::Variable); 2686 EXPECT_EQ(A.ReturnType, "float"); 2687 EXPECT_EQ(A.SnippetSuffix, "(${1:int a}, ${2:const double &b})"); 2688 } 2689 2690 TEST(CompletionTest, StructuredBinding) { 2691 clangd::CodeCompleteOptions Opts = {}; 2692 2693 auto Results = completions(R"cpp( 2694 struct S { 2695 using Float = float; 2696 int x; 2697 Float y; 2698 }; 2699 void function() { 2700 const auto &[xxx, yyy] = S{}; 2701 yyy^ 2702 } 2703 )cpp", 2704 {}, Opts); 2705 2706 ASSERT_EQ(Results.Completions.size(), 1u); 2707 const auto &A = Results.Completions.front(); 2708 EXPECT_EQ(A.Name, "yyy"); 2709 EXPECT_EQ(A.Kind, CompletionItemKind::Variable); 2710 EXPECT_EQ(A.ReturnType, "const Float"); 2711 } 2712 2713 TEST(CompletionTest, ObjectiveCMethodNoArguments) { 2714 auto Results = completions(R"objc( 2715 @interface Foo 2716 @property(nonatomic, setter=setXToIgnoreComplete:) int value; 2717 @end 2718 Foo *foo = [Foo new]; int y = [foo v^] 2719 )objc", 2720 /*IndexSymbols=*/{}, 2721 /*Opts=*/{}, "Foo.m"); 2722 2723 auto C = Results.Completions; 2724 EXPECT_THAT(C, ElementsAre(Named("value"))); 2725 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2726 EXPECT_THAT(C, ElementsAre(ReturnType("int"))); 2727 EXPECT_THAT(C, ElementsAre(Signature(""))); 2728 EXPECT_THAT(C, ElementsAre(SnippetSuffix(""))); 2729 } 2730 2731 TEST(CompletionTest, ObjectiveCMethodOneArgument) { 2732 auto Results = completions(R"objc( 2733 @interface Foo 2734 - (int)valueForCharacter:(char)c; 2735 @end 2736 Foo *foo = [Foo new]; int y = [foo v^] 2737 )objc", 2738 /*IndexSymbols=*/{}, 2739 /*Opts=*/{}, "Foo.m"); 2740 2741 auto C = Results.Completions; 2742 EXPECT_THAT(C, ElementsAre(Named("valueForCharacter:"))); 2743 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2744 EXPECT_THAT(C, ElementsAre(ReturnType("int"))); 2745 EXPECT_THAT(C, ElementsAre(Signature("(char)"))); 2746 EXPECT_THAT(C, ElementsAre(SnippetSuffix("${1:(char)}"))); 2747 } 2748 2749 TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromBeginning) { 2750 auto Results = completions(R"objc( 2751 @interface Foo 2752 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey; 2753 @end 2754 id val = [Foo foo^] 2755 )objc", 2756 /*IndexSymbols=*/{}, 2757 /*Opts=*/{}, "Foo.m"); 2758 2759 auto C = Results.Completions; 2760 EXPECT_THAT(C, ElementsAre(Named("fooWithValue:"))); 2761 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2762 EXPECT_THAT(C, ElementsAre(ReturnType("id"))); 2763 EXPECT_THAT(C, ElementsAre(Signature("(int) fooey:(unsigned int)"))); 2764 EXPECT_THAT( 2765 C, ElementsAre(SnippetSuffix("${1:(int)} fooey:${2:(unsigned int)}"))); 2766 } 2767 2768 TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromMiddle) { 2769 auto Results = completions(R"objc( 2770 @interface Foo 2771 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey; 2772 @end 2773 id val = [Foo fooWithValue:10 f^] 2774 )objc", 2775 /*IndexSymbols=*/{}, 2776 /*Opts=*/{}, "Foo.m"); 2777 2778 auto C = Results.Completions; 2779 EXPECT_THAT(C, ElementsAre(Named("fooey:"))); 2780 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2781 EXPECT_THAT(C, ElementsAre(ReturnType("id"))); 2782 EXPECT_THAT(C, ElementsAre(Signature("(unsigned int)"))); 2783 EXPECT_THAT(C, ElementsAre(SnippetSuffix("${1:(unsigned int)}"))); 2784 } 2785 2786 TEST(CompletionTest, CursorInSnippets) { 2787 clangd::CodeCompleteOptions Options; 2788 Options.EnableSnippets = true; 2789 auto Results = completions( 2790 R"cpp( 2791 void while_foo(int a, int b); 2792 void test() { 2793 whil^ 2794 })cpp", 2795 /*IndexSymbols=*/{}, Options); 2796 2797 // Last placeholder in code patterns should be $0 to put the cursor there. 2798 EXPECT_THAT(Results.Completions, 2799 Contains(AllOf( 2800 Named("while"), 2801 SnippetSuffix(" (${1:condition}) {\n${0:statements}\n}")))); 2802 // However, snippets for functions must *not* end with $0. 2803 EXPECT_THAT(Results.Completions, 2804 Contains(AllOf(Named("while_foo"), 2805 SnippetSuffix("(${1:int a}, ${2:int b})")))); 2806 } 2807 2808 TEST(CompletionTest, WorksWithNullType) { 2809 auto R = completions(R"cpp( 2810 int main() { 2811 for (auto [loopVar] : y ) { // y has to be unresolved. 2812 int z = loopV^; 2813 } 2814 } 2815 )cpp"); 2816 EXPECT_THAT(R.Completions, ElementsAre(Named("loopVar"))); 2817 } 2818 2819 TEST(CompletionTest, UsingDecl) { 2820 const char *Header(R"cpp( 2821 void foo(int); 2822 namespace std { 2823 using ::foo; 2824 })cpp"); 2825 const char *Source(R"cpp( 2826 void bar() { 2827 std::^; 2828 })cpp"); 2829 auto Index = TestTU::withHeaderCode(Header).index(); 2830 clangd::CodeCompleteOptions Opts; 2831 Opts.Index = Index.get(); 2832 Opts.AllScopes = true; 2833 auto R = completions(Source, {}, Opts); 2834 EXPECT_THAT(R.Completions, 2835 ElementsAre(AllOf(Scope("std::"), Named("foo"), 2836 Kind(CompletionItemKind::Reference)))); 2837 } 2838 2839 TEST(CompletionTest, ScopeIsUnresolved) { 2840 clangd::CodeCompleteOptions Opts = {}; 2841 Opts.AllScopes = true; 2842 2843 auto Results = completions(R"cpp( 2844 namespace a { 2845 void f() { b::X^ } 2846 } 2847 )cpp", 2848 {cls("a::b::XYZ")}, Opts); 2849 EXPECT_THAT(Results.Completions, 2850 UnorderedElementsAre(AllOf(Qualifier(""), Named("XYZ")))); 2851 } 2852 2853 TEST(CompletionTest, NestedScopeIsUnresolved) { 2854 clangd::CodeCompleteOptions Opts = {}; 2855 Opts.AllScopes = true; 2856 2857 auto Results = completions(R"cpp( 2858 namespace a { 2859 namespace b {} 2860 void f() { b::c::X^ } 2861 } 2862 )cpp", 2863 {cls("a::b::c::XYZ")}, Opts); 2864 EXPECT_THAT(Results.Completions, 2865 UnorderedElementsAre(AllOf(Qualifier(""), Named("XYZ")))); 2866 } 2867 2868 // Clang parser gets confused here and doesn't report the ns:: prefix. 2869 // Naive behavior is to insert it again. We examine the source and recover. 2870 TEST(CompletionTest, NamespaceDoubleInsertion) { 2871 clangd::CodeCompleteOptions Opts = {}; 2872 2873 auto Results = completions(R"cpp( 2874 namespace foo { 2875 namespace ns {} 2876 #define M(X) < X 2877 M(ns::ABC^ 2878 } 2879 )cpp", 2880 {cls("foo::ns::ABCDE")}, Opts); 2881 EXPECT_THAT(Results.Completions, 2882 UnorderedElementsAre(AllOf(Qualifier(""), Named("ABCDE")))); 2883 } 2884 2885 TEST(CompletionTest, DerivedMethodsAreAlwaysVisible) { 2886 // Despite the fact that base method matches the ref-qualifier better, 2887 // completion results should only include the derived method. 2888 auto Completions = completions(R"cpp( 2889 struct deque_base { 2890 float size(); 2891 double size() const; 2892 }; 2893 struct deque : deque_base { 2894 int size() const; 2895 }; 2896 2897 auto x = deque().^ 2898 )cpp") 2899 .Completions; 2900 EXPECT_THAT(Completions, 2901 ElementsAre(AllOf(ReturnType("int"), Named("size")))); 2902 } 2903 2904 TEST(CompletionTest, NoCrashWithIncompleteLambda) { 2905 auto Completions = completions("auto&& x = []{^").Completions; 2906 // The completion of x itself can cause a problem: in the code completion 2907 // callback, its type is not known, which affects the linkage calculation. 2908 // A bad linkage value gets cached, and subsequently updated. 2909 EXPECT_THAT(Completions, Contains(Named("x"))); 2910 2911 auto Signatures = signatures("auto x() { x(^").signatures; 2912 EXPECT_THAT(Signatures, Contains(Sig("x() -> auto"))); 2913 } 2914 2915 TEST(CompletionTest, DelayedTemplateParsing) { 2916 Annotations Test(R"cpp( 2917 int xxx; 2918 template <typename T> int foo() { return xx^; } 2919 )cpp"); 2920 auto TU = TestTU::withCode(Test.code()); 2921 // Even though delayed-template-parsing is on, we will disable it to provide 2922 // completion in templates. 2923 TU.ExtraArgs.push_back("-fdelayed-template-parsing"); 2924 2925 EXPECT_THAT(completions(TU, Test.point()).Completions, 2926 Contains(Named("xxx"))); 2927 } 2928 2929 TEST(CompletionTest, CompletionRange) { 2930 const char *WithRange = "auto x = [[abc]]^"; 2931 auto Completions = completions(WithRange); 2932 EXPECT_EQ(Completions.CompletionRange, Annotations(WithRange).range()); 2933 Completions = completionsNoCompile(WithRange); 2934 EXPECT_EQ(Completions.CompletionRange, Annotations(WithRange).range()); 2935 2936 const char *EmptyRange = "auto x = [[]]^"; 2937 Completions = completions(EmptyRange); 2938 EXPECT_EQ(Completions.CompletionRange, Annotations(EmptyRange).range()); 2939 Completions = completionsNoCompile(EmptyRange); 2940 EXPECT_EQ(Completions.CompletionRange, Annotations(EmptyRange).range()); 2941 2942 // Sema doesn't trigger at all here, while the no-sema completion runs 2943 // heuristics as normal and reports a range. It'd be nice to be consistent. 2944 const char *NoCompletion = "/* [[]]^ */"; 2945 Completions = completions(NoCompletion); 2946 EXPECT_EQ(Completions.CompletionRange, llvm::None); 2947 Completions = completionsNoCompile(NoCompletion); 2948 EXPECT_EQ(Completions.CompletionRange, Annotations(NoCompletion).range()); 2949 } 2950 2951 TEST(NoCompileCompletionTest, Basic) { 2952 auto Results = completionsNoCompile(R"cpp( 2953 void func() { 2954 int xyz; 2955 int abc; 2956 ^ 2957 } 2958 )cpp"); 2959 EXPECT_FALSE(Results.RanParser); 2960 EXPECT_THAT(Results.Completions, 2961 UnorderedElementsAre(Named("void"), Named("func"), Named("int"), 2962 Named("xyz"), Named("abc"))); 2963 } 2964 2965 TEST(NoCompileCompletionTest, WithFilter) { 2966 auto Results = completionsNoCompile(R"cpp( 2967 void func() { 2968 int sym1; 2969 int sym2; 2970 int xyz1; 2971 int xyz2; 2972 sy^ 2973 } 2974 )cpp"); 2975 EXPECT_THAT(Results.Completions, 2976 UnorderedElementsAre(Named("sym1"), Named("sym2"))); 2977 } 2978 2979 TEST(NoCompileCompletionTest, WithIndex) { 2980 std::vector<Symbol> Syms = {func("xxx"), func("a::xxx"), func("ns::b::xxx"), 2981 func("c::xxx"), func("ns::d::xxx")}; 2982 auto Results = completionsNoCompile( 2983 R"cpp( 2984 // Current-scopes, unqualified completion. 2985 using namespace a; 2986 namespace ns { 2987 using namespace b; 2988 void foo() { 2989 xx^ 2990 } 2991 } 2992 )cpp", 2993 Syms); 2994 EXPECT_THAT(Results.Completions, 2995 UnorderedElementsAre(AllOf(Qualifier(""), Scope("")), 2996 AllOf(Qualifier(""), Scope("a::")), 2997 AllOf(Qualifier(""), Scope("ns::b::")))); 2998 CodeCompleteOptions Opts; 2999 Opts.AllScopes = true; 3000 Results = completionsNoCompile( 3001 R"cpp( 3002 // All-scopes unqualified completion. 3003 using namespace a; 3004 namespace ns { 3005 using namespace b; 3006 void foo() { 3007 xx^ 3008 } 3009 } 3010 )cpp", 3011 Syms, Opts); 3012 EXPECT_THAT(Results.Completions, 3013 UnorderedElementsAre(AllOf(Qualifier(""), Scope("")), 3014 AllOf(Qualifier(""), Scope("a::")), 3015 AllOf(Qualifier(""), Scope("ns::b::")), 3016 AllOf(Qualifier("c::"), Scope("c::")), 3017 AllOf(Qualifier("d::"), Scope("ns::d::")))); 3018 Results = completionsNoCompile( 3019 R"cpp( 3020 // Qualified completion. 3021 using namespace a; 3022 namespace ns { 3023 using namespace b; 3024 void foo() { 3025 b::xx^ 3026 } 3027 } 3028 )cpp", 3029 Syms, Opts); 3030 EXPECT_THAT(Results.Completions, 3031 ElementsAre(AllOf(Qualifier(""), Scope("ns::b::")))); 3032 Results = completionsNoCompile( 3033 R"cpp( 3034 // Absolutely qualified completion. 3035 using namespace a; 3036 namespace ns { 3037 using namespace b; 3038 void foo() { 3039 ::a::xx^ 3040 } 3041 } 3042 )cpp", 3043 Syms, Opts); 3044 EXPECT_THAT(Results.Completions, 3045 ElementsAre(AllOf(Qualifier(""), Scope("a::")))); 3046 } 3047 3048 TEST(AllowImplicitCompletion, All) { 3049 const char *Yes[] = { 3050 "foo.^bar", 3051 "foo->^bar", 3052 "foo::^bar", 3053 " # include <^foo.h>", 3054 "#import <foo/^bar.h>", 3055 "#include_next \"^", 3056 }; 3057 const char *No[] = { 3058 "foo>^bar", 3059 "foo:^bar", 3060 "foo\n^bar", 3061 "#include <foo.h> //^", 3062 "#include \"foo.h\"^", 3063 "#error <^", 3064 "#<^", 3065 }; 3066 for (const char *Test : Yes) { 3067 llvm::Annotations A(Test); 3068 EXPECT_TRUE(allowImplicitCompletion(A.code(), A.point())) << Test; 3069 } 3070 for (const char *Test : No) { 3071 llvm::Annotations A(Test); 3072 EXPECT_FALSE(allowImplicitCompletion(A.code(), A.point())) << Test; 3073 } 3074 } 3075 3076 TEST(CompletionTest, FunctionArgsExist) { 3077 clangd::CodeCompleteOptions Opts; 3078 Opts.EnableSnippets = true; 3079 std::string Context = R"cpp( 3080 int foo(int A); 3081 int bar(); 3082 struct Object { 3083 Object(int B) {} 3084 }; 3085 template <typename T> 3086 struct Container { 3087 Container(int Size) {} 3088 }; 3089 )cpp"; 3090 EXPECT_THAT(completions(Context + "int y = fo^", {}, Opts).Completions, 3091 UnorderedElementsAre( 3092 AllOf(Labeled("foo(int A)"), SnippetSuffix("(${1:int A})")))); 3093 EXPECT_THAT( 3094 completions(Context + "int y = fo^(42)", {}, Opts).Completions, 3095 UnorderedElementsAre(AllOf(Labeled("foo(int A)"), SnippetSuffix("")))); 3096 // FIXME(kirillbobyrev): No snippet should be produced here. 3097 EXPECT_THAT(completions(Context + "int y = fo^o(42)", {}, Opts).Completions, 3098 UnorderedElementsAre( 3099 AllOf(Labeled("foo(int A)"), SnippetSuffix("(${1:int A})")))); 3100 EXPECT_THAT( 3101 completions(Context + "int y = ba^", {}, Opts).Completions, 3102 UnorderedElementsAre(AllOf(Labeled("bar()"), SnippetSuffix("()")))); 3103 EXPECT_THAT(completions(Context + "int y = ba^()", {}, Opts).Completions, 3104 UnorderedElementsAre(AllOf(Labeled("bar()"), SnippetSuffix("")))); 3105 EXPECT_THAT( 3106 completions(Context + "Object o = Obj^", {}, Opts).Completions, 3107 Contains(AllOf(Labeled("Object(int B)"), SnippetSuffix("(${1:int B})"), 3108 Kind(CompletionItemKind::Constructor)))); 3109 EXPECT_THAT(completions(Context + "Object o = Obj^()", {}, Opts).Completions, 3110 Contains(AllOf(Labeled("Object(int B)"), SnippetSuffix(""), 3111 Kind(CompletionItemKind::Constructor)))); 3112 EXPECT_THAT( 3113 completions(Context + "Container c = Cont^", {}, Opts).Completions, 3114 Contains(AllOf(Labeled("Container<typename T>(int Size)"), 3115 SnippetSuffix("<${1:typename T}>(${2:int Size})"), 3116 Kind(CompletionItemKind::Constructor)))); 3117 // FIXME(kirillbobyrev): It would be nice to still produce the template 3118 // snippet part: in this case it should be "<${1:typename T}>". 3119 EXPECT_THAT( 3120 completions(Context + "Container c = Cont^()", {}, Opts).Completions, 3121 Contains(AllOf(Labeled("Container<typename T>(int Size)"), 3122 SnippetSuffix(""), 3123 Kind(CompletionItemKind::Constructor)))); 3124 } 3125 3126 } // namespace 3127 } // namespace clangd 3128 } // namespace clang 3129