1 //===-- CodeCompleteTests.cpp -----------------------------------*- C++ -*-===// 2 // 3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. 4 // See https://llvm.org/LICENSE.txt for license information. 5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception 6 // 7 //===----------------------------------------------------------------------===// 8 9 #include "ASTSignals.h" 10 #include "Annotations.h" 11 #include "ClangdServer.h" 12 #include "CodeComplete.h" 13 #include "Compiler.h" 14 #include "Matchers.h" 15 #include "Protocol.h" 16 #include "Quality.h" 17 #include "SourceCode.h" 18 #include "SyncAPI.h" 19 #include "TestFS.h" 20 #include "TestIndex.h" 21 #include "TestTU.h" 22 #include "index/Index.h" 23 #include "index/MemIndex.h" 24 #include "support/Threading.h" 25 #include "clang/Sema/CodeCompleteConsumer.h" 26 #include "clang/Tooling/CompilationDatabase.h" 27 #include "llvm/ADT/StringRef.h" 28 #include "llvm/Support/Error.h" 29 #include "llvm/Support/Path.h" 30 #include "llvm/Testing/Support/Annotations.h" 31 #include "llvm/Testing/Support/Error.h" 32 #include "gmock/gmock.h" 33 #include "gtest/gtest.h" 34 #include <condition_variable> 35 #include <functional> 36 #include <mutex> 37 #include <vector> 38 39 namespace clang { 40 namespace clangd { 41 42 namespace { 43 using ::llvm::Failed; 44 using ::testing::AllOf; 45 using ::testing::Contains; 46 using ::testing::ElementsAre; 47 using ::testing::Field; 48 using ::testing::HasSubstr; 49 using ::testing::IsEmpty; 50 using ::testing::Not; 51 using ::testing::UnorderedElementsAre; 52 using ContextKind = CodeCompletionContext::Kind; 53 54 // GMock helpers for matching completion items. 55 MATCHER_P(Named, Name, "") { return arg.Name == Name; } 56 MATCHER_P(MainFileRefs, Refs, "") { return arg.MainFileRefs == Refs; } 57 MATCHER_P(ScopeRefs, Refs, "") { return arg.ScopeRefsInFile == Refs; } 58 MATCHER_P(NameStartsWith, Prefix, "") { 59 return llvm::StringRef(arg.Name).startswith(Prefix); 60 } 61 MATCHER_P(Scope, S, "") { return arg.Scope == S; } 62 MATCHER_P(Qualifier, Q, "") { return arg.RequiredQualifier == Q; } 63 MATCHER_P(Labeled, Label, "") { 64 return arg.RequiredQualifier + arg.Name + arg.Signature == Label; 65 } 66 MATCHER_P(SigHelpLabeled, Label, "") { return arg.label == Label; } 67 MATCHER_P(Kind, K, "") { return arg.Kind == K; } 68 MATCHER_P(Doc, D, "") { 69 return arg.Documentation && arg.Documentation->asPlainText() == D; 70 } 71 MATCHER_P(ReturnType, D, "") { return arg.ReturnType == D; } 72 MATCHER_P(HasInclude, IncludeHeader, "") { 73 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader; 74 } 75 MATCHER_P(InsertInclude, IncludeHeader, "") { 76 return !arg.Includes.empty() && arg.Includes[0].Header == IncludeHeader && 77 bool(arg.Includes[0].Insertion); 78 } 79 MATCHER(InsertInclude, "") { 80 return !arg.Includes.empty() && bool(arg.Includes[0].Insertion); 81 } 82 MATCHER_P(SnippetSuffix, Text, "") { return arg.SnippetSuffix == Text; } 83 MATCHER_P(Origin, OriginSet, "") { return arg.Origin == OriginSet; } 84 MATCHER_P(Signature, S, "") { return arg.Signature == S; } 85 86 // Shorthand for Contains(Named(Name)). 87 Matcher<const std::vector<CodeCompletion> &> Has(std::string Name) { 88 return Contains(Named(std::move(Name))); 89 } 90 Matcher<const std::vector<CodeCompletion> &> Has(std::string Name, 91 CompletionItemKind K) { 92 return Contains(AllOf(Named(std::move(Name)), Kind(K))); 93 } 94 MATCHER(IsDocumented, "") { return arg.Documentation.hasValue(); } 95 MATCHER(Deprecated, "") { return arg.Deprecated; } 96 97 std::unique_ptr<SymbolIndex> memIndex(std::vector<Symbol> Symbols) { 98 SymbolSlab::Builder Slab; 99 for (const auto &Sym : Symbols) 100 Slab.insert(Sym); 101 return MemIndex::build(std::move(Slab).build(), RefSlab(), RelationSlab()); 102 } 103 104 // Runs code completion. 105 // If IndexSymbols is non-empty, an index will be built and passed to opts. 106 CodeCompleteResult completions(const TestTU &TU, Position Point, 107 std::vector<Symbol> IndexSymbols = {}, 108 clangd::CodeCompleteOptions Opts = {}) { 109 std::unique_ptr<SymbolIndex> OverrideIndex; 110 if (!IndexSymbols.empty()) { 111 assert(!Opts.Index && "both Index and IndexSymbols given!"); 112 OverrideIndex = memIndex(std::move(IndexSymbols)); 113 Opts.Index = OverrideIndex.get(); 114 } 115 116 MockFS FS; 117 auto Inputs = TU.inputs(FS); 118 IgnoreDiagnostics Diags; 119 auto CI = buildCompilerInvocation(Inputs, Diags); 120 if (!CI) { 121 ADD_FAILURE() << "Couldn't build CompilerInvocation"; 122 return {}; 123 } 124 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs, 125 /*InMemory=*/true, /*Callback=*/nullptr); 126 return codeComplete(testPath(TU.Filename), Point, Preamble.get(), Inputs, 127 Opts); 128 } 129 130 // Runs code completion. 131 CodeCompleteResult completions(llvm::StringRef Text, 132 std::vector<Symbol> IndexSymbols = {}, 133 clangd::CodeCompleteOptions Opts = {}, 134 PathRef FilePath = "foo.cpp") { 135 Annotations Test(Text); 136 auto TU = TestTU::withCode(Test.code()); 137 // To make sure our tests for completiopns inside templates work on Windows. 138 TU.Filename = FilePath.str(); 139 return completions(TU, Test.point(), std::move(IndexSymbols), 140 std::move(Opts)); 141 } 142 143 // Runs code completion without the clang parser. 144 CodeCompleteResult completionsNoCompile(llvm::StringRef Text, 145 std::vector<Symbol> IndexSymbols = {}, 146 clangd::CodeCompleteOptions Opts = {}, 147 PathRef FilePath = "foo.cpp") { 148 std::unique_ptr<SymbolIndex> OverrideIndex; 149 if (!IndexSymbols.empty()) { 150 assert(!Opts.Index && "both Index and IndexSymbols given!"); 151 OverrideIndex = memIndex(std::move(IndexSymbols)); 152 Opts.Index = OverrideIndex.get(); 153 } 154 155 MockFS FS; 156 Annotations Test(Text); 157 ParseInputs ParseInput{tooling::CompileCommand(), &FS, Test.code().str()}; 158 return codeComplete(FilePath, Test.point(), /*Preamble=*/nullptr, ParseInput, 159 Opts); 160 } 161 162 Symbol withReferences(int N, Symbol S) { 163 S.References = N; 164 return S; 165 } 166 167 TEST(DecisionForestRankingModel, NameMatchSanityTest) { 168 clangd::CodeCompleteOptions Opts; 169 Opts.RankingModel = CodeCompleteOptions::DecisionForest; 170 auto Results = completions( 171 R"cpp( 172 struct MemberAccess { 173 int ABG(); 174 int AlphaBetaGamma(); 175 }; 176 int func() { MemberAccess().ABG^ } 177 )cpp", 178 /*IndexSymbols=*/{}, Opts); 179 EXPECT_THAT(Results.Completions, 180 ElementsAre(Named("ABG"), Named("AlphaBetaGamma"))); 181 } 182 183 TEST(DecisionForestRankingModel, ReferencesAffectRanking) { 184 clangd::CodeCompleteOptions Opts; 185 Opts.RankingModel = CodeCompleteOptions::DecisionForest; 186 constexpr int NumReferences = 100000; 187 EXPECT_THAT( 188 completions("int main() { clang^ }", 189 {ns("clangA"), withReferences(NumReferences, func("clangD"))}, 190 Opts) 191 .Completions, 192 ElementsAre(Named("clangD"), Named("clangA"))); 193 EXPECT_THAT( 194 completions("int main() { clang^ }", 195 {withReferences(NumReferences, ns("clangA")), func("clangD")}, 196 Opts) 197 .Completions, 198 ElementsAre(Named("clangA"), Named("clangD"))); 199 } 200 201 TEST(DecisionForestRankingModel, DecisionForestScorerCallbackTest) { 202 clangd::CodeCompleteOptions Opts; 203 constexpr float MagicNumber = 1234.5678f; 204 Opts.RankingModel = CodeCompleteOptions::DecisionForest; 205 Opts.DecisionForestScorer = [&](const SymbolQualitySignals &, 206 const SymbolRelevanceSignals &, float Base) { 207 DecisionForestScores Scores; 208 Scores.Total = MagicNumber; 209 Scores.ExcludingName = MagicNumber; 210 return Scores; 211 }; 212 llvm::StringRef Code = "int func() { int xyz; xy^ }"; 213 auto Results = completions(Code, 214 /*IndexSymbols=*/{}, Opts); 215 ASSERT_EQ(Results.Completions.size(), 1u); 216 EXPECT_EQ(Results.Completions[0].Score.Total, MagicNumber); 217 EXPECT_EQ(Results.Completions[0].Score.ExcludingName, MagicNumber); 218 219 // Do not use DecisionForestScorer for heuristics model. 220 Opts.RankingModel = CodeCompleteOptions::Heuristics; 221 Results = completions(Code, 222 /*IndexSymbols=*/{}, Opts); 223 ASSERT_EQ(Results.Completions.size(), 1u); 224 EXPECT_NE(Results.Completions[0].Score.Total, MagicNumber); 225 EXPECT_NE(Results.Completions[0].Score.ExcludingName, MagicNumber); 226 } 227 228 TEST(CompletionTest, Limit) { 229 clangd::CodeCompleteOptions Opts; 230 Opts.Limit = 2; 231 auto Results = completions(R"cpp( 232 struct ClassWithMembers { 233 int AAA(); 234 int BBB(); 235 int CCC(); 236 }; 237 238 int main() { ClassWithMembers().^ } 239 )cpp", 240 /*IndexSymbols=*/{}, Opts); 241 242 EXPECT_TRUE(Results.HasMore); 243 EXPECT_THAT(Results.Completions, ElementsAre(Named("AAA"), Named("BBB"))); 244 } 245 246 TEST(CompletionTest, Filter) { 247 std::string Body = R"cpp( 248 #define MotorCar 249 int Car; 250 struct S { 251 int FooBar; 252 int FooBaz; 253 int Qux; 254 }; 255 )cpp"; 256 257 // Only items matching the fuzzy query are returned. 258 EXPECT_THAT(completions(Body + "int main() { S().Foba^ }").Completions, 259 AllOf(Has("FooBar"), Has("FooBaz"), Not(Has("Qux")))); 260 261 // Macros require prefix match, either from index or AST. 262 Symbol Sym = var("MotorCarIndex"); 263 Sym.SymInfo.Kind = index::SymbolKind::Macro; 264 EXPECT_THAT( 265 completions(Body + "int main() { C^ }", {Sym}).Completions, 266 AllOf(Has("Car"), Not(Has("MotorCar")), Not(Has("MotorCarIndex")))); 267 EXPECT_THAT(completions(Body + "int main() { M^ }", {Sym}).Completions, 268 AllOf(Has("MotorCar"), Has("MotorCarIndex"))); 269 } 270 271 void testAfterDotCompletion(clangd::CodeCompleteOptions Opts) { 272 auto Results = completions( 273 R"cpp( 274 int global_var; 275 276 int global_func(); 277 278 // Make sure this is not in preamble. 279 #define MACRO X 280 281 struct GlobalClass {}; 282 283 struct ClassWithMembers { 284 /// Doc for method. 285 int method(); 286 287 int field; 288 private: 289 int private_field; 290 }; 291 292 int test() { 293 struct LocalClass {}; 294 295 /// Doc for local_var. 296 int local_var; 297 298 ClassWithMembers().^ 299 } 300 )cpp", 301 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts); 302 303 EXPECT_TRUE(Results.RanParser); 304 // Class members. The only items that must be present in after-dot 305 // completion. 306 EXPECT_THAT(Results.Completions, 307 AllOf(Has("method"), Has("field"), Not(Has("ClassWithMembers")), 308 Not(Has("operator=")), Not(Has("~ClassWithMembers")))); 309 EXPECT_IFF(Opts.IncludeIneligibleResults, Results.Completions, 310 Has("private_field")); 311 // Global items. 312 EXPECT_THAT( 313 Results.Completions, 314 Not(AnyOf(Has("global_var"), Has("index_var"), Has("global_func"), 315 Has("global_func()"), Has("index_func"), Has("GlobalClass"), 316 Has("IndexClass"), Has("MACRO"), Has("LocalClass")))); 317 // There should be no code patterns (aka snippets) in after-dot 318 // completion. At least there aren't any we're aware of. 319 EXPECT_THAT(Results.Completions, 320 Not(Contains(Kind(CompletionItemKind::Snippet)))); 321 // Check documentation. 322 EXPECT_THAT(Results.Completions, Contains(IsDocumented())); 323 } 324 325 void testGlobalScopeCompletion(clangd::CodeCompleteOptions Opts) { 326 auto Results = completions( 327 R"cpp( 328 int global_var; 329 int global_func(); 330 331 // Make sure this is not in preamble. 332 #define MACRO X 333 334 struct GlobalClass {}; 335 336 struct ClassWithMembers { 337 /// Doc for method. 338 int method(); 339 }; 340 341 int test() { 342 struct LocalClass {}; 343 344 /// Doc for local_var. 345 int local_var; 346 347 ^ 348 } 349 )cpp", 350 {cls("IndexClass"), var("index_var"), func("index_func")}, Opts); 351 352 EXPECT_TRUE(Results.RanParser); 353 // Class members. Should never be present in global completions. 354 EXPECT_THAT(Results.Completions, 355 Not(AnyOf(Has("method"), Has("method()"), Has("field")))); 356 // Global items. 357 EXPECT_THAT(Results.Completions, 358 AllOf(Has("global_var"), Has("index_var"), Has("global_func"), 359 Has("index_func" /* our fake symbol doesn't include () */), 360 Has("GlobalClass"), Has("IndexClass"))); 361 // A macro. 362 EXPECT_THAT(Results.Completions, Has("MACRO")); 363 // Local items. Must be present always. 364 EXPECT_THAT(Results.Completions, 365 AllOf(Has("local_var"), Has("LocalClass"), 366 Contains(Kind(CompletionItemKind::Snippet)))); 367 // Check documentation. 368 EXPECT_THAT(Results.Completions, Contains(IsDocumented())); 369 } 370 371 TEST(CompletionTest, CompletionOptions) { 372 auto Test = [&](const clangd::CodeCompleteOptions &Opts) { 373 testAfterDotCompletion(Opts); 374 testGlobalScopeCompletion(Opts); 375 }; 376 // We used to test every combination of options, but that got too slow (2^N). 377 auto Flags = { 378 &clangd::CodeCompleteOptions::IncludeIneligibleResults, 379 }; 380 // Test default options. 381 Test({}); 382 // Test with one flag flipped. 383 for (auto &F : Flags) { 384 clangd::CodeCompleteOptions O; 385 O.*F ^= true; 386 Test(O); 387 } 388 } 389 390 TEST(CompletionTest, Accessible) { 391 auto Internal = completions(R"cpp( 392 class Foo { 393 public: void pub(); 394 protected: void prot(); 395 private: void priv(); 396 }; 397 void Foo::pub() { this->^ } 398 )cpp"); 399 EXPECT_THAT(Internal.Completions, 400 AllOf(Has("priv"), Has("prot"), Has("pub"))); 401 402 auto External = completions(R"cpp( 403 class Foo { 404 public: void pub(); 405 protected: void prot(); 406 private: void priv(); 407 }; 408 void test() { 409 Foo F; 410 F.^ 411 } 412 )cpp"); 413 EXPECT_THAT(External.Completions, 414 AllOf(Has("pub"), Not(Has("prot")), Not(Has("priv")))); 415 } 416 417 TEST(CompletionTest, Qualifiers) { 418 auto Results = completions(R"cpp( 419 class Foo { 420 public: int foo() const; 421 int bar() const; 422 }; 423 class Bar : public Foo { 424 int foo() const; 425 }; 426 void test() { Bar().^ } 427 )cpp"); 428 EXPECT_THAT(Results.Completions, 429 Contains(AllOf(Qualifier(""), Named("bar")))); 430 // Hidden members are not shown. 431 EXPECT_THAT(Results.Completions, 432 Not(Contains(AllOf(Qualifier("Foo::"), Named("foo"))))); 433 // Private members are not shown. 434 EXPECT_THAT(Results.Completions, 435 Not(Contains(AllOf(Qualifier(""), Named("foo"))))); 436 } 437 438 TEST(CompletionTest, InjectedTypename) { 439 // These are suppressed when accessed as a member... 440 EXPECT_THAT(completions("struct X{}; void foo(){ X().^ }").Completions, 441 Not(Has("X"))); 442 EXPECT_THAT(completions("struct X{ void foo(){ this->^ } };").Completions, 443 Not(Has("X"))); 444 // ...but accessible in other, more useful cases. 445 EXPECT_THAT(completions("struct X{ void foo(){ ^ } };").Completions, 446 Has("X")); 447 EXPECT_THAT( 448 completions("struct Y{}; struct X:Y{ void foo(){ ^ } };").Completions, 449 Has("Y")); 450 EXPECT_THAT( 451 completions( 452 "template<class> struct Y{}; struct X:Y<int>{ void foo(){ ^ } };") 453 .Completions, 454 Has("Y")); 455 // This case is marginal (`using X::X` is useful), we allow it for now. 456 EXPECT_THAT(completions("struct X{}; void foo(){ X::^ }").Completions, 457 Has("X")); 458 } 459 460 TEST(CompletionTest, SkipInjectedWhenUnqualified) { 461 EXPECT_THAT(completions("struct X { void f() { X^ }};").Completions, 462 ElementsAre(Named("X"), Named("~X"))); 463 } 464 465 TEST(CompletionTest, Snippets) { 466 clangd::CodeCompleteOptions Opts; 467 auto Results = completions( 468 R"cpp( 469 struct fake { 470 int a; 471 int f(int i, const float f) const; 472 }; 473 int main() { 474 fake f; 475 f.^ 476 } 477 )cpp", 478 /*IndexSymbols=*/{}, Opts); 479 EXPECT_THAT( 480 Results.Completions, 481 HasSubsequence(Named("a"), 482 SnippetSuffix("(${1:int i}, ${2:const float f})"))); 483 } 484 485 TEST(CompletionTest, NoSnippetsInUsings) { 486 clangd::CodeCompleteOptions Opts; 487 Opts.EnableSnippets = true; 488 auto Results = completions( 489 R"cpp( 490 namespace ns { 491 int func(int a, int b); 492 } 493 494 using ns::^; 495 )cpp", 496 /*IndexSymbols=*/{}, Opts); 497 EXPECT_THAT(Results.Completions, 498 ElementsAre(AllOf(Named("func"), Labeled("func(int a, int b)"), 499 SnippetSuffix("")))); 500 501 // Check index completions too. 502 auto Func = func("ns::func"); 503 Func.CompletionSnippetSuffix = "(${1:int a}, ${2: int b})"; 504 Func.Signature = "(int a, int b)"; 505 Func.ReturnType = "void"; 506 507 Results = completions(R"cpp( 508 namespace ns {} 509 using ns::^; 510 )cpp", 511 /*IndexSymbols=*/{Func}, Opts); 512 EXPECT_THAT(Results.Completions, 513 ElementsAre(AllOf(Named("func"), Labeled("func(int a, int b)"), 514 SnippetSuffix("")))); 515 516 // Check all-scopes completions too. 517 Opts.AllScopes = true; 518 Results = completions(R"cpp( 519 using ^; 520 )cpp", 521 /*IndexSymbols=*/{Func}, Opts); 522 EXPECT_THAT(Results.Completions, 523 Contains(AllOf(Named("func"), Labeled("ns::func(int a, int b)"), 524 SnippetSuffix("")))); 525 } 526 527 TEST(CompletionTest, Kinds) { 528 auto Results = completions( 529 R"cpp( 530 int variable; 531 struct Struct {}; 532 int function(); 533 // make sure MACRO is not included in preamble. 534 #define MACRO 10 535 int X = ^ 536 )cpp", 537 {func("indexFunction"), var("indexVariable"), cls("indexClass")}); 538 EXPECT_THAT(Results.Completions, 539 AllOf(Has("function", CompletionItemKind::Function), 540 Has("variable", CompletionItemKind::Variable), 541 Has("int", CompletionItemKind::Keyword), 542 Has("Struct", CompletionItemKind::Struct), 543 Has("MACRO", CompletionItemKind::Text), 544 Has("indexFunction", CompletionItemKind::Function), 545 Has("indexVariable", CompletionItemKind::Variable), 546 Has("indexClass", CompletionItemKind::Class))); 547 548 Results = completions("nam^"); 549 EXPECT_THAT(Results.Completions, 550 Has("namespace", CompletionItemKind::Snippet)); 551 552 // Members of anonymous unions are of kind 'field'. 553 Results = completions( 554 R"cpp( 555 struct X{ 556 union { 557 void *a; 558 }; 559 }; 560 auto u = X().^ 561 )cpp"); 562 EXPECT_THAT( 563 Results.Completions, 564 UnorderedElementsAre(AllOf(Named("a"), Kind(CompletionItemKind::Field)))); 565 566 // Completion kinds for templates should not be unknown. 567 Results = completions( 568 R"cpp( 569 template <class T> struct complete_class {}; 570 template <class T> void complete_function(); 571 template <class T> using complete_type_alias = int; 572 template <class T> int complete_variable = 10; 573 574 struct X { 575 template <class T> static int complete_static_member = 10; 576 577 static auto x = complete_^ 578 } 579 )cpp"); 580 EXPECT_THAT( 581 Results.Completions, 582 UnorderedElementsAre( 583 AllOf(Named("complete_class"), Kind(CompletionItemKind::Class)), 584 AllOf(Named("complete_function"), Kind(CompletionItemKind::Function)), 585 AllOf(Named("complete_type_alias"), 586 Kind(CompletionItemKind::Interface)), 587 AllOf(Named("complete_variable"), Kind(CompletionItemKind::Variable)), 588 AllOf(Named("complete_static_member"), 589 Kind(CompletionItemKind::Property)))); 590 591 Results = completions( 592 R"cpp( 593 enum Color { 594 Red 595 }; 596 Color u = ^ 597 )cpp"); 598 EXPECT_THAT( 599 Results.Completions, 600 Contains(AllOf(Named("Red"), Kind(CompletionItemKind::EnumMember)))); 601 } 602 603 TEST(CompletionTest, NoDuplicates) { 604 auto Results = completions( 605 R"cpp( 606 class Adapter { 607 }; 608 609 void f() { 610 Adapter^ 611 } 612 )cpp", 613 {cls("Adapter")}); 614 615 // Make sure there are no duplicate entries of 'Adapter'. 616 EXPECT_THAT(Results.Completions, ElementsAre(Named("Adapter"))); 617 } 618 619 TEST(CompletionTest, ScopedNoIndex) { 620 auto Results = completions( 621 R"cpp( 622 namespace fake { int BigBang, Babble, Box; }; 623 int main() { fake::ba^ } 624 ")cpp"); 625 // Babble is a better match than BigBang. Box doesn't match at all. 626 EXPECT_THAT(Results.Completions, 627 ElementsAre(Named("Babble"), Named("BigBang"))); 628 } 629 630 TEST(CompletionTest, Scoped) { 631 auto Results = completions( 632 R"cpp( 633 namespace fake { int Babble, Box; }; 634 int main() { fake::ba^ } 635 ")cpp", 636 {var("fake::BigBang")}); 637 EXPECT_THAT(Results.Completions, 638 ElementsAre(Named("Babble"), Named("BigBang"))); 639 } 640 641 TEST(CompletionTest, ScopedWithFilter) { 642 auto Results = completions( 643 R"cpp( 644 void f() { ns::x^ } 645 )cpp", 646 {cls("ns::XYZ"), func("ns::foo")}); 647 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Named("XYZ"))); 648 } 649 650 TEST(CompletionTest, ReferencesAffectRanking) { 651 EXPECT_THAT(completions("int main() { abs^ }", {func("absA"), func("absB")}) 652 .Completions, 653 HasSubsequence(Named("absA"), Named("absB"))); 654 EXPECT_THAT(completions("int main() { abs^ }", 655 {func("absA"), withReferences(1000, func("absB"))}) 656 .Completions, 657 HasSubsequence(Named("absB"), Named("absA"))); 658 } 659 660 TEST(CompletionTest, ContextWords) { 661 auto Results = completions(R"cpp( 662 enum class Color { RED, YELLOW, BLUE }; 663 664 // (blank lines so the definition above isn't "context") 665 666 // "It was a yellow car," he said. "Big yellow car, new." 667 auto Finish = Color::^ 668 )cpp"); 669 // Yellow would normally sort last (alphabetic). 670 // But the recent mention should bump it up. 671 ASSERT_THAT(Results.Completions, 672 HasSubsequence(Named("YELLOW"), Named("BLUE"))); 673 } 674 675 TEST(CompletionTest, GlobalQualified) { 676 auto Results = completions( 677 R"cpp( 678 void f() { ::^ } 679 )cpp", 680 {cls("XYZ")}); 681 EXPECT_THAT(Results.Completions, 682 AllOf(Has("XYZ", CompletionItemKind::Class), 683 Has("f", CompletionItemKind::Function))); 684 } 685 686 TEST(CompletionTest, FullyQualified) { 687 auto Results = completions( 688 R"cpp( 689 namespace ns { void bar(); } 690 void f() { ::ns::^ } 691 )cpp", 692 {cls("ns::XYZ")}); 693 EXPECT_THAT(Results.Completions, 694 AllOf(Has("XYZ", CompletionItemKind::Class), 695 Has("bar", CompletionItemKind::Function))); 696 } 697 698 TEST(CompletionTest, SemaIndexMerge) { 699 auto Results = completions( 700 R"cpp( 701 namespace ns { int local; void both(); } 702 void f() { ::ns::^ } 703 )cpp", 704 {func("ns::both"), cls("ns::Index")}); 705 // We get results from both index and sema, with no duplicates. 706 EXPECT_THAT(Results.Completions, 707 UnorderedElementsAre( 708 AllOf(Named("local"), Origin(SymbolOrigin::AST)), 709 AllOf(Named("Index"), Origin(SymbolOrigin::Static)), 710 AllOf(Named("both"), 711 Origin(SymbolOrigin::AST | SymbolOrigin::Static)))); 712 } 713 714 TEST(CompletionTest, SemaIndexMergeWithLimit) { 715 clangd::CodeCompleteOptions Opts; 716 Opts.Limit = 1; 717 auto Results = completions( 718 R"cpp( 719 namespace ns { int local; void both(); } 720 void f() { ::ns::^ } 721 )cpp", 722 {func("ns::both"), cls("ns::Index")}, Opts); 723 EXPECT_EQ(Results.Completions.size(), Opts.Limit); 724 EXPECT_TRUE(Results.HasMore); 725 } 726 727 TEST(CompletionTest, IncludeInsertionPreprocessorIntegrationTests) { 728 TestTU TU; 729 TU.ExtraArgs.push_back("-I" + testPath("sub")); 730 TU.AdditionalFiles["sub/bar.h"] = ""; 731 auto BarURI = URI::create(testPath("sub/bar.h")).toString(); 732 733 Symbol Sym = cls("ns::X"); 734 Sym.CanonicalDeclaration.FileURI = BarURI.c_str(); 735 Sym.IncludeHeaders.emplace_back(BarURI, 1); 736 // Shorten include path based on search directory and insert. 737 Annotations Test("int main() { ns::^ }"); 738 TU.Code = Test.code().str(); 739 auto Results = completions(TU, Test.point(), {Sym}); 740 EXPECT_THAT(Results.Completions, 741 ElementsAre(AllOf(Named("X"), InsertInclude("\"bar.h\"")))); 742 // Can be disabled via option. 743 CodeCompleteOptions NoInsertion; 744 NoInsertion.InsertIncludes = CodeCompleteOptions::NeverInsert; 745 Results = completions(TU, Test.point(), {Sym}, NoInsertion); 746 EXPECT_THAT(Results.Completions, 747 ElementsAre(AllOf(Named("X"), Not(InsertInclude())))); 748 // Duplicate based on inclusions in preamble. 749 Test = Annotations(R"cpp( 750 #include "sub/bar.h" // not shortest, so should only match resolved. 751 int main() { ns::^ } 752 )cpp"); 753 TU.Code = Test.code().str(); 754 Results = completions(TU, Test.point(), {Sym}); 755 EXPECT_THAT(Results.Completions, ElementsAre(AllOf(Named("X"), Labeled("X"), 756 Not(InsertInclude())))); 757 } 758 759 TEST(CompletionTest, NoIncludeInsertionWhenDeclFoundInFile) { 760 Symbol SymX = cls("ns::X"); 761 Symbol SymY = cls("ns::Y"); 762 std::string BarHeader = testPath("bar.h"); 763 auto BarURI = URI::create(BarHeader).toString(); 764 SymX.CanonicalDeclaration.FileURI = BarURI.c_str(); 765 SymY.CanonicalDeclaration.FileURI = BarURI.c_str(); 766 SymX.IncludeHeaders.emplace_back("<bar>", 1); 767 SymY.IncludeHeaders.emplace_back("<bar>", 1); 768 // Shorten include path based on search directory and insert. 769 auto Results = completions(R"cpp( 770 namespace ns { 771 class X; 772 class Y {}; 773 } 774 int main() { ns::^ } 775 )cpp", 776 {SymX, SymY}); 777 EXPECT_THAT(Results.Completions, 778 ElementsAre(AllOf(Named("X"), Not(InsertInclude())), 779 AllOf(Named("Y"), Not(InsertInclude())))); 780 } 781 782 TEST(CompletionTest, IndexSuppressesPreambleCompletions) { 783 Annotations Test(R"cpp( 784 #include "bar.h" 785 namespace ns { int local; } 786 void f() { ns::^; } 787 void f2() { ns::preamble().$2^; } 788 )cpp"); 789 auto TU = TestTU::withCode(Test.code()); 790 TU.AdditionalFiles["bar.h"] = 791 R"cpp(namespace ns { struct preamble { int member; }; })cpp"; 792 793 clangd::CodeCompleteOptions Opts = {}; 794 auto I = memIndex({var("ns::index")}); 795 Opts.Index = I.get(); 796 auto WithIndex = completions(TU, Test.point(), {}, Opts); 797 EXPECT_THAT(WithIndex.Completions, 798 UnorderedElementsAre(Named("local"), Named("index"))); 799 auto ClassFromPreamble = completions(TU, Test.point("2"), {}, Opts); 800 EXPECT_THAT(ClassFromPreamble.Completions, Contains(Named("member"))); 801 802 Opts.Index = nullptr; 803 auto WithoutIndex = completions(TU, Test.point(), {}, Opts); 804 EXPECT_THAT(WithoutIndex.Completions, 805 UnorderedElementsAre(Named("local"), Named("preamble"))); 806 } 807 808 // This verifies that we get normal preprocessor completions in the preamble. 809 // This is a regression test for an old bug: if we override the preamble and 810 // try to complete inside it, clang kicks our completion point just outside the 811 // preamble, resulting in always getting top-level completions. 812 TEST(CompletionTest, CompletionInPreamble) { 813 auto Results = completions(R"cpp( 814 #ifnd^ef FOO_H_ 815 #define BAR_H_ 816 #include <bar.h> 817 int foo() {} 818 #endif 819 )cpp") 820 .Completions; 821 EXPECT_THAT(Results, ElementsAre(Named("ifndef"))); 822 } 823 824 TEST(CompletionTest, CompletionRecoveryASTType) { 825 auto Results = completions(R"cpp( 826 struct S { int member; }; 827 S overloaded(int); 828 void foo() { 829 // No overload matches, but we have recovery-expr with the correct type. 830 overloaded().^ 831 })cpp") 832 .Completions; 833 EXPECT_THAT(Results, ElementsAre(Named("member"))); 834 } 835 836 TEST(CompletionTest, DynamicIndexIncludeInsertion) { 837 MockFS FS; 838 MockCompilationDatabase CDB; 839 ClangdServer::Options Opts = ClangdServer::optsForTest(); 840 Opts.BuildDynamicSymbolIndex = true; 841 ClangdServer Server(CDB, FS, Opts); 842 843 FS.Files[testPath("foo_header.h")] = R"cpp( 844 #pragma once 845 struct Foo { 846 // Member doc 847 int foo(); 848 }; 849 )cpp"; 850 const std::string FileContent(R"cpp( 851 #include "foo_header.h" 852 int Foo::foo() { 853 return 42; 854 } 855 )cpp"); 856 Server.addDocument(testPath("foo_impl.cpp"), FileContent); 857 // Wait for the dynamic index being built. 858 ASSERT_TRUE(Server.blockUntilIdleForTest()); 859 860 auto File = testPath("foo.cpp"); 861 Annotations Test("Foo^ foo;"); 862 runAddDocument(Server, File, Test.code()); 863 auto CompletionList = 864 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {})); 865 866 EXPECT_THAT(CompletionList.Completions, 867 ElementsAre(AllOf(Named("Foo"), HasInclude("\"foo_header.h\""), 868 InsertInclude()))); 869 } 870 871 TEST(CompletionTest, DynamicIndexMultiFile) { 872 MockFS FS; 873 MockCompilationDatabase CDB; 874 auto Opts = ClangdServer::optsForTest(); 875 Opts.BuildDynamicSymbolIndex = true; 876 ClangdServer Server(CDB, FS, Opts); 877 878 FS.Files[testPath("foo.h")] = R"cpp( 879 namespace ns { class XYZ {}; void foo(int x) {} } 880 )cpp"; 881 runAddDocument(Server, testPath("foo.cpp"), R"cpp( 882 #include "foo.h" 883 )cpp"); 884 885 auto File = testPath("bar.cpp"); 886 Annotations Test(R"cpp( 887 namespace ns { 888 class XXX {}; 889 /// Doooc 890 void fooooo() {} 891 } 892 void f() { ns::^ } 893 )cpp"); 894 runAddDocument(Server, File, Test.code()); 895 896 auto Results = cantFail(runCodeComplete(Server, File, Test.point(), {})); 897 // "XYZ" and "foo" are not included in the file being completed but are still 898 // visible through the index. 899 EXPECT_THAT(Results.Completions, Has("XYZ", CompletionItemKind::Class)); 900 EXPECT_THAT(Results.Completions, Has("foo", CompletionItemKind::Function)); 901 EXPECT_THAT(Results.Completions, Has("XXX", CompletionItemKind::Class)); 902 EXPECT_THAT(Results.Completions, 903 Contains((Named("fooooo"), Kind(CompletionItemKind::Function), 904 Doc("Doooc"), ReturnType("void")))); 905 } 906 907 TEST(CompletionTest, Documentation) { 908 auto Results = completions( 909 R"cpp( 910 // Non-doxygen comment. 911 __attribute__((annotate("custom_annotation"))) int foo(); 912 /// Doxygen comment. 913 /// \param int a 914 int bar(int a); 915 /* Multi-line 916 block comment 917 */ 918 int baz(); 919 920 int x = ^ 921 )cpp"); 922 EXPECT_THAT(Results.Completions, 923 Contains(AllOf(Named("foo"), 924 Doc("Annotation: custom_annotation\nNon-doxygen comment.")))); 925 EXPECT_THAT( 926 Results.Completions, 927 Contains(AllOf(Named("bar"), Doc("Doxygen comment.\n\\param int a")))); 928 EXPECT_THAT(Results.Completions, 929 Contains(AllOf(Named("baz"), Doc("Multi-line block comment")))); 930 } 931 932 TEST(CompletionTest, CommentsFromSystemHeaders) { 933 MockFS FS; 934 MockCompilationDatabase CDB; 935 936 auto Opts = ClangdServer::optsForTest(); 937 Opts.BuildDynamicSymbolIndex = true; 938 939 ClangdServer Server(CDB, FS, Opts); 940 941 FS.Files[testPath("foo.h")] = R"cpp( 942 #pragma GCC system_header 943 944 // This comment should be retained! 945 int foo(); 946 )cpp"; 947 948 auto File = testPath("foo.cpp"); 949 Annotations Test(R"cpp( 950 #include "foo.h" 951 int x = foo^ 952 )cpp"); 953 runAddDocument(Server, File, Test.code()); 954 auto CompletionList = 955 llvm::cantFail(runCodeComplete(Server, File, Test.point(), {})); 956 957 EXPECT_THAT( 958 CompletionList.Completions, 959 Contains(AllOf(Named("foo"), Doc("This comment should be retained!")))); 960 } 961 962 TEST(CompletionTest, GlobalCompletionFiltering) { 963 964 Symbol Class = cls("XYZ"); 965 Class.Flags = static_cast<Symbol::SymbolFlag>( 966 Class.Flags & ~(Symbol::IndexedForCodeCompletion)); 967 Symbol Func = func("XYZ::foooo"); 968 Func.Flags = static_cast<Symbol::SymbolFlag>( 969 Func.Flags & ~(Symbol::IndexedForCodeCompletion)); 970 971 auto Results = completions(R"(// void f() { 972 XYZ::foooo^ 973 })", 974 {Class, Func}); 975 EXPECT_THAT(Results.Completions, IsEmpty()); 976 } 977 978 TEST(CodeCompleteTest, DisableTypoCorrection) { 979 auto Results = completions(R"cpp( 980 namespace clang { int v; } 981 void f() { clangd::^ 982 )cpp"); 983 EXPECT_TRUE(Results.Completions.empty()); 984 } 985 986 TEST(CodeCompleteTest, NoColonColonAtTheEnd) { 987 auto Results = completions(R"cpp( 988 namespace clang { } 989 void f() { 990 clan^ 991 } 992 )cpp"); 993 994 EXPECT_THAT(Results.Completions, Contains(Labeled("clang"))); 995 EXPECT_THAT(Results.Completions, Not(Contains(Labeled("clang::")))); 996 } 997 998 TEST(CompletionTest, BacktrackCrashes) { 999 // Sema calls code completion callbacks twice in these cases. 1000 auto Results = completions(R"cpp( 1001 namespace ns { 1002 struct FooBarBaz {}; 1003 } // namespace ns 1004 1005 int foo(ns::FooBar^ 1006 )cpp"); 1007 1008 EXPECT_THAT(Results.Completions, ElementsAre(Labeled("FooBarBaz"))); 1009 1010 // Check we don't crash in that case too. 1011 completions(R"cpp( 1012 struct FooBarBaz {}; 1013 void test() { 1014 if (FooBarBaz * x^) {} 1015 } 1016 )cpp"); 1017 } 1018 1019 TEST(CompletionTest, CompleteInMacroWithStringification) { 1020 auto Results = completions(R"cpp( 1021 void f(const char *, int x); 1022 #define F(x) f(#x, x) 1023 1024 namespace ns { 1025 int X; 1026 int Y; 1027 } // namespace ns 1028 1029 int f(int input_num) { 1030 F(ns::^) 1031 } 1032 )cpp"); 1033 1034 EXPECT_THAT(Results.Completions, 1035 UnorderedElementsAre(Named("X"), Named("Y"))); 1036 } 1037 1038 TEST(CompletionTest, CompleteInMacroAndNamespaceWithStringification) { 1039 auto Results = completions(R"cpp( 1040 void f(const char *, int x); 1041 #define F(x) f(#x, x) 1042 1043 namespace ns { 1044 int X; 1045 1046 int f(int input_num) { 1047 F(^) 1048 } 1049 } // namespace ns 1050 )cpp"); 1051 1052 EXPECT_THAT(Results.Completions, Contains(Named("X"))); 1053 } 1054 1055 TEST(CompletionTest, IgnoreCompleteInExcludedPPBranchWithRecoveryContext) { 1056 auto Results = completions(R"cpp( 1057 int bar(int param_in_bar) { 1058 } 1059 1060 int foo(int param_in_foo) { 1061 #if 0 1062 // In recovery mode, "param_in_foo" will also be suggested among many other 1063 // unrelated symbols; however, this is really a special case where this works. 1064 // If the #if block is outside of the function, "param_in_foo" is still 1065 // suggested, but "bar" and "foo" are missing. So the recovery mode doesn't 1066 // really provide useful results in excluded branches. 1067 par^ 1068 #endif 1069 } 1070 )cpp"); 1071 1072 EXPECT_TRUE(Results.Completions.empty()); 1073 } 1074 1075 TEST(CompletionTest, DefaultArgs) { 1076 clangd::CodeCompleteOptions Opts; 1077 std::string Context = R"cpp( 1078 int X(int A = 0); 1079 int Y(int A, int B = 0); 1080 int Z(int A, int B = 0, int C = 0, int D = 0); 1081 )cpp"; 1082 EXPECT_THAT(completions(Context + "int y = X^", {}, Opts).Completions, 1083 UnorderedElementsAre(Labeled("X(int A = 0)"))); 1084 EXPECT_THAT(completions(Context + "int y = Y^", {}, Opts).Completions, 1085 UnorderedElementsAre(AllOf(Labeled("Y(int A, int B = 0)"), 1086 SnippetSuffix("(${1:int A})")))); 1087 EXPECT_THAT(completions(Context + "int y = Z^", {}, Opts).Completions, 1088 UnorderedElementsAre( 1089 AllOf(Labeled("Z(int A, int B = 0, int C = 0, int D = 0)"), 1090 SnippetSuffix("(${1:int A})")))); 1091 } 1092 1093 TEST(CompletionTest, NoCrashWithTemplateParamsAndPreferredTypes) { 1094 auto Completions = completions(R"cpp( 1095 template <template <class> class TT> int foo() { 1096 int a = ^ 1097 } 1098 )cpp") 1099 .Completions; 1100 EXPECT_THAT(Completions, Contains(Named("TT"))); 1101 } 1102 1103 TEST(CompletionTest, NestedTemplateHeuristics) { 1104 auto Completions = completions(R"cpp( 1105 struct Plain { int xxx; }; 1106 template <typename T> class Templ { Plain ppp; }; 1107 template <typename T> void foo(Templ<T> &t) { 1108 // Formally ppp has DependentTy, because Templ may be specialized. 1109 // However we sholud be able to see into it using the primary template. 1110 t.ppp.^ 1111 } 1112 )cpp") 1113 .Completions; 1114 EXPECT_THAT(Completions, Contains(Named("xxx"))); 1115 } 1116 1117 TEST(CompletionTest, RecordCCResultCallback) { 1118 std::vector<CodeCompletion> RecordedCompletions; 1119 CodeCompleteOptions Opts; 1120 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC, 1121 const SymbolQualitySignals &, 1122 const SymbolRelevanceSignals &, 1123 float Score) { 1124 RecordedCompletions.push_back(CC); 1125 }; 1126 1127 completions("int xy1, xy2; int a = xy^", /*IndexSymbols=*/{}, Opts); 1128 EXPECT_THAT(RecordedCompletions, 1129 UnorderedElementsAre(Named("xy1"), Named("xy2"))); 1130 } 1131 1132 TEST(CompletionTest, ASTSignals) { 1133 struct Completion { 1134 std::string Name; 1135 unsigned MainFileRefs; 1136 unsigned ScopeRefsInFile; 1137 }; 1138 CodeCompleteOptions Opts; 1139 std::vector<Completion> RecordedCompletions; 1140 Opts.RecordCCResult = [&RecordedCompletions](const CodeCompletion &CC, 1141 const SymbolQualitySignals &, 1142 const SymbolRelevanceSignals &R, 1143 float Score) { 1144 RecordedCompletions.push_back({CC.Name, R.MainFileRefs, R.ScopeRefsInFile}); 1145 }; 1146 ASTSignals MainFileSignals; 1147 MainFileSignals.ReferencedSymbols[var("xy1").ID] = 3; 1148 MainFileSignals.ReferencedSymbols[var("xy2").ID] = 1; 1149 MainFileSignals.ReferencedSymbols[var("xyindex").ID] = 10; 1150 MainFileSignals.RelatedNamespaces["tar::"] = 5; 1151 MainFileSignals.RelatedNamespaces["bar::"] = 3; 1152 Opts.MainFileSignals = &MainFileSignals; 1153 Opts.AllScopes = true; 1154 completions( 1155 R"cpp( 1156 int xy1; 1157 int xy2; 1158 namespace bar { 1159 int xybar = 1; 1160 int a = xy^ 1161 } 1162 )cpp", 1163 /*IndexSymbols=*/{var("xyindex"), var("tar::xytar"), var("bar::xybar")}, 1164 Opts); 1165 EXPECT_THAT(RecordedCompletions, 1166 UnorderedElementsAre( 1167 AllOf(Named("xy1"), MainFileRefs(3u), ScopeRefs(0u)), 1168 AllOf(Named("xy2"), MainFileRefs(1u), ScopeRefs(0u)), 1169 AllOf(Named("xyindex"), MainFileRefs(10u), ScopeRefs(0u)), 1170 AllOf(Named("xytar"), MainFileRefs(0u), ScopeRefs(5u)), 1171 AllOf(/*both from sema and index*/ Named("xybar"), 1172 MainFileRefs(0u), ScopeRefs(3u)))); 1173 } 1174 1175 SignatureHelp 1176 signatures(llvm::StringRef Text, Position Point, 1177 std::vector<Symbol> IndexSymbols = {}, 1178 MarkupKind DocumentationFormat = MarkupKind::PlainText) { 1179 std::unique_ptr<SymbolIndex> Index; 1180 if (!IndexSymbols.empty()) 1181 Index = memIndex(IndexSymbols); 1182 1183 auto TU = TestTU::withCode(Text); 1184 MockFS FS; 1185 auto Inputs = TU.inputs(FS); 1186 Inputs.Index = Index.get(); 1187 IgnoreDiagnostics Diags; 1188 auto CI = buildCompilerInvocation(Inputs, Diags); 1189 if (!CI) { 1190 ADD_FAILURE() << "Couldn't build CompilerInvocation"; 1191 return {}; 1192 } 1193 auto Preamble = buildPreamble(testPath(TU.Filename), *CI, Inputs, 1194 /*InMemory=*/true, /*Callback=*/nullptr); 1195 if (!Preamble) { 1196 ADD_FAILURE() << "Couldn't build Preamble"; 1197 return {}; 1198 } 1199 return signatureHelp(testPath(TU.Filename), Point, *Preamble, Inputs, 1200 DocumentationFormat); 1201 } 1202 1203 SignatureHelp 1204 signatures(llvm::StringRef Text, std::vector<Symbol> IndexSymbols = {}, 1205 MarkupKind DocumentationFormat = MarkupKind::PlainText) { 1206 Annotations Test(Text); 1207 return signatures(Test.code(), Test.point(), std::move(IndexSymbols), 1208 DocumentationFormat); 1209 } 1210 1211 struct ExpectedParameter { 1212 std::string Text; 1213 std::pair<unsigned, unsigned> Offsets; 1214 }; 1215 MATCHER_P(ParamsAre, P, "") { 1216 if (P.size() != arg.parameters.size()) 1217 return false; 1218 for (unsigned I = 0; I < P.size(); ++I) { 1219 if (P[I].Text != arg.parameters[I].labelString || 1220 P[I].Offsets != arg.parameters[I].labelOffsets) 1221 return false; 1222 } 1223 return true; 1224 } 1225 MATCHER_P(SigDoc, Doc, "") { return arg.documentation.value == Doc; } 1226 1227 /// \p AnnotatedLabel is a signature label with ranges marking parameters, e.g. 1228 /// foo([[int p1]], [[double p2]]) -> void 1229 Matcher<SignatureInformation> Sig(llvm::StringRef AnnotatedLabel) { 1230 llvm::Annotations A(AnnotatedLabel); 1231 std::string Label = std::string(A.code()); 1232 std::vector<ExpectedParameter> Parameters; 1233 for (auto Range : A.ranges()) { 1234 Parameters.emplace_back(); 1235 1236 ExpectedParameter &P = Parameters.back(); 1237 P.Text = Label.substr(Range.Begin, Range.End - Range.Begin); 1238 P.Offsets.first = lspLength(llvm::StringRef(Label).substr(0, Range.Begin)); 1239 P.Offsets.second = lspLength(llvm::StringRef(Label).substr(1, Range.End)); 1240 } 1241 return AllOf(SigHelpLabeled(Label), ParamsAre(Parameters)); 1242 } 1243 1244 TEST(SignatureHelpTest, Overloads) { 1245 auto Results = signatures(R"cpp( 1246 void foo(int x, int y); 1247 void foo(int x, float y); 1248 void foo(float x, int y); 1249 void foo(float x, float y); 1250 void bar(int x, int y = 0); 1251 int main() { foo(^); } 1252 )cpp"); 1253 EXPECT_THAT(Results.signatures, 1254 UnorderedElementsAre(Sig("foo([[float x]], [[float y]]) -> void"), 1255 Sig("foo([[float x]], [[int y]]) -> void"), 1256 Sig("foo([[int x]], [[float y]]) -> void"), 1257 Sig("foo([[int x]], [[int y]]) -> void"))); 1258 // We always prefer the first signature. 1259 EXPECT_EQ(0, Results.activeSignature); 1260 EXPECT_EQ(0, Results.activeParameter); 1261 } 1262 1263 TEST(SignatureHelpTest, OverloadInitListRegression) { 1264 auto Results = signatures(R"cpp( 1265 struct A {int x;}; 1266 struct B {B(A);}; 1267 void f(); 1268 int main() { 1269 B b({1}); 1270 f(^); 1271 } 1272 )cpp"); 1273 EXPECT_THAT(Results.signatures, UnorderedElementsAre(Sig("f() -> void"))); 1274 } 1275 1276 TEST(SignatureHelpTest, DefaultArgs) { 1277 auto Results = signatures(R"cpp( 1278 void bar(int x, int y = 0); 1279 void bar(float x = 0, int y = 42); 1280 int main() { bar(^ 1281 )cpp"); 1282 EXPECT_THAT(Results.signatures, 1283 UnorderedElementsAre( 1284 Sig("bar([[int x]], [[int y = 0]]) -> void"), 1285 Sig("bar([[float x = 0]], [[int y = 42]]) -> void"))); 1286 EXPECT_EQ(0, Results.activeSignature); 1287 EXPECT_EQ(0, Results.activeParameter); 1288 } 1289 1290 TEST(SignatureHelpTest, ActiveArg) { 1291 auto Results = signatures(R"cpp( 1292 int baz(int a, int b, int c); 1293 int main() { baz(baz(1,2,3), ^); } 1294 )cpp"); 1295 EXPECT_THAT(Results.signatures, 1296 ElementsAre(Sig("baz([[int a]], [[int b]], [[int c]]) -> int"))); 1297 EXPECT_EQ(0, Results.activeSignature); 1298 EXPECT_EQ(1, Results.activeParameter); 1299 } 1300 1301 TEST(SignatureHelpTest, OpeningParen) { 1302 llvm::StringLiteral Tests[] = { 1303 // Recursive function call. 1304 R"cpp( 1305 int foo(int a, int b, int c); 1306 int main() { 1307 foo(foo $p^( foo(10, 10, 10), ^ ))); 1308 })cpp", 1309 // Functional type cast. 1310 R"cpp( 1311 struct Foo { 1312 Foo(int a, int b, int c); 1313 }; 1314 int main() { 1315 Foo $p^( 10, ^ ); 1316 })cpp", 1317 // New expression. 1318 R"cpp( 1319 struct Foo { 1320 Foo(int a, int b, int c); 1321 }; 1322 int main() { 1323 new Foo $p^( 10, ^ ); 1324 })cpp", 1325 // Macro expansion. 1326 R"cpp( 1327 int foo(int a, int b, int c); 1328 #define FOO foo( 1329 1330 int main() { 1331 // Macro expansions. 1332 $p^FOO 10, ^ ); 1333 })cpp", 1334 // Macro arguments. 1335 R"cpp( 1336 int foo(int a, int b, int c); 1337 int main() { 1338 #define ID(X) X 1339 // FIXME: figure out why ID(foo (foo(10), )) doesn't work when preserving 1340 // the recovery expression. 1341 ID(foo $p^( 10, ^ )) 1342 })cpp", 1343 // Dependent args. 1344 R"cpp( 1345 int foo(int a, int b); 1346 template <typename T> void bar(T t) { 1347 foo$p^(t, ^t); 1348 })cpp", 1349 // Dependent args on templated func. 1350 R"cpp( 1351 template <typename T> 1352 int foo(T, T); 1353 template <typename T> void bar(T t) { 1354 foo$p^(t, ^t); 1355 })cpp", 1356 // Dependent args on member. 1357 R"cpp( 1358 struct Foo { int foo(int, int); }; 1359 template <typename T> void bar(T t) { 1360 Foo f; 1361 f.foo$p^(t, ^t); 1362 })cpp", 1363 // Dependent args on templated member. 1364 R"cpp( 1365 struct Foo { template <typename T> int foo(T, T); }; 1366 template <typename T> void bar(T t) { 1367 Foo f; 1368 f.foo$p^(t, ^t); 1369 })cpp", 1370 }; 1371 1372 for (auto Test : Tests) { 1373 Annotations Code(Test); 1374 EXPECT_EQ(signatures(Code.code(), Code.point()).argListStart, 1375 Code.point("p")) 1376 << "Test source:" << Test; 1377 } 1378 } 1379 1380 TEST(SignatureHelpTest, StalePreamble) { 1381 TestTU TU; 1382 TU.Code = ""; 1383 IgnoreDiagnostics Diags; 1384 MockFS FS; 1385 auto Inputs = TU.inputs(FS); 1386 auto CI = buildCompilerInvocation(Inputs, Diags); 1387 ASSERT_TRUE(CI); 1388 auto EmptyPreamble = buildPreamble(testPath(TU.Filename), *CI, Inputs, 1389 /*InMemory=*/true, /*Callback=*/nullptr); 1390 ASSERT_TRUE(EmptyPreamble); 1391 1392 TU.AdditionalFiles["a.h"] = "int foo(int x);"; 1393 const Annotations Test(R"cpp( 1394 #include "a.h" 1395 void bar() { foo(^2); })cpp"); 1396 TU.Code = Test.code().str(); 1397 auto Results = 1398 signatureHelp(testPath(TU.Filename), Test.point(), *EmptyPreamble, 1399 TU.inputs(FS), MarkupKind::PlainText); 1400 EXPECT_THAT(Results.signatures, ElementsAre(Sig("foo([[int x]]) -> int"))); 1401 EXPECT_EQ(0, Results.activeSignature); 1402 EXPECT_EQ(0, Results.activeParameter); 1403 } 1404 1405 class IndexRequestCollector : public SymbolIndex { 1406 public: 1407 bool 1408 fuzzyFind(const FuzzyFindRequest &Req, 1409 llvm::function_ref<void(const Symbol &)> Callback) const override { 1410 std::unique_lock<std::mutex> Lock(Mut); 1411 Requests.push_back(Req); 1412 ReceivedRequestCV.notify_one(); 1413 return true; 1414 } 1415 1416 void lookup(const LookupRequest &, 1417 llvm::function_ref<void(const Symbol &)>) const override {} 1418 1419 bool refs(const RefsRequest &, 1420 llvm::function_ref<void(const Ref &)>) const override { 1421 return false; 1422 } 1423 1424 void relations(const RelationsRequest &, 1425 llvm::function_ref<void(const SymbolID &, const Symbol &)>) 1426 const override {} 1427 1428 llvm::unique_function<IndexContents(llvm::StringRef) const> 1429 indexedFiles() const override { 1430 return [](llvm::StringRef) { return IndexContents::None; }; 1431 } 1432 1433 // This is incorrect, but IndexRequestCollector is not an actual index and it 1434 // isn't used in production code. 1435 size_t estimateMemoryUsage() const override { return 0; } 1436 1437 const std::vector<FuzzyFindRequest> consumeRequests(size_t Num) const { 1438 std::unique_lock<std::mutex> Lock(Mut); 1439 EXPECT_TRUE(wait(Lock, ReceivedRequestCV, timeoutSeconds(30), 1440 [this, Num] { return Requests.size() == Num; })); 1441 auto Reqs = std::move(Requests); 1442 Requests = {}; 1443 return Reqs; 1444 } 1445 1446 private: 1447 // We need a mutex to handle async fuzzy find requests. 1448 mutable std::condition_variable ReceivedRequestCV; 1449 mutable std::mutex Mut; 1450 mutable std::vector<FuzzyFindRequest> Requests; 1451 }; 1452 1453 // Clients have to consume exactly Num requests. 1454 std::vector<FuzzyFindRequest> captureIndexRequests(llvm::StringRef Code, 1455 size_t Num = 1) { 1456 clangd::CodeCompleteOptions Opts; 1457 IndexRequestCollector Requests; 1458 Opts.Index = &Requests; 1459 completions(Code, {}, Opts); 1460 const auto Reqs = Requests.consumeRequests(Num); 1461 EXPECT_EQ(Reqs.size(), Num); 1462 return Reqs; 1463 } 1464 1465 TEST(CompletionTest, UnqualifiedIdQuery) { 1466 auto Requests = captureIndexRequests(R"cpp( 1467 namespace std {} 1468 using namespace std; 1469 namespace ns { 1470 void f() { 1471 vec^ 1472 } 1473 } 1474 )cpp"); 1475 1476 EXPECT_THAT(Requests, 1477 ElementsAre(Field(&FuzzyFindRequest::Scopes, 1478 UnorderedElementsAre("", "ns::", "std::")))); 1479 } 1480 1481 TEST(CompletionTest, EnclosingScopeComesFirst) { 1482 auto Requests = captureIndexRequests(R"cpp( 1483 namespace std {} 1484 using namespace std; 1485 namespace nx { 1486 namespace ns { 1487 namespace { 1488 void f() { 1489 vec^ 1490 } 1491 } 1492 } 1493 } 1494 )cpp"); 1495 1496 EXPECT_THAT(Requests, 1497 ElementsAre(Field( 1498 &FuzzyFindRequest::Scopes, 1499 UnorderedElementsAre("", "std::", "nx::ns::", "nx::")))); 1500 EXPECT_EQ(Requests[0].Scopes[0], "nx::ns::"); 1501 } 1502 1503 TEST(CompletionTest, ResolvedQualifiedIdQuery) { 1504 auto Requests = captureIndexRequests(R"cpp( 1505 namespace ns1 {} 1506 namespace ns2 {} // ignore 1507 namespace ns3 { namespace nns3 {} } 1508 namespace foo { 1509 using namespace ns1; 1510 using namespace ns3::nns3; 1511 } 1512 namespace ns { 1513 void f() { 1514 foo::^ 1515 } 1516 } 1517 )cpp"); 1518 1519 EXPECT_THAT(Requests, 1520 ElementsAre(Field( 1521 &FuzzyFindRequest::Scopes, 1522 UnorderedElementsAre("foo::", "ns1::", "ns3::nns3::")))); 1523 } 1524 1525 TEST(CompletionTest, UnresolvedQualifierIdQuery) { 1526 auto Requests = captureIndexRequests(R"cpp( 1527 namespace a {} 1528 using namespace a; 1529 namespace ns { 1530 void f() { 1531 bar::^ 1532 } 1533 } // namespace ns 1534 )cpp"); 1535 1536 EXPECT_THAT(Requests, 1537 ElementsAre(Field( 1538 &FuzzyFindRequest::Scopes, 1539 UnorderedElementsAre("a::bar::", "ns::bar::", "bar::")))); 1540 } 1541 1542 TEST(CompletionTest, UnresolvedNestedQualifierIdQuery) { 1543 auto Requests = captureIndexRequests(R"cpp( 1544 namespace a {} 1545 using namespace a; 1546 namespace ns { 1547 void f() { 1548 ::a::bar::^ 1549 } 1550 } // namespace ns 1551 )cpp"); 1552 1553 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, 1554 UnorderedElementsAre("a::bar::")))); 1555 } 1556 1557 TEST(CompletionTest, EmptyQualifiedQuery) { 1558 auto Requests = captureIndexRequests(R"cpp( 1559 namespace ns { 1560 void f() { 1561 ^ 1562 } 1563 } // namespace ns 1564 )cpp"); 1565 1566 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, 1567 UnorderedElementsAre("", "ns::")))); 1568 } 1569 1570 TEST(CompletionTest, GlobalQualifiedQuery) { 1571 auto Requests = captureIndexRequests(R"cpp( 1572 namespace ns { 1573 void f() { 1574 ::^ 1575 } 1576 } // namespace ns 1577 )cpp"); 1578 1579 EXPECT_THAT(Requests, ElementsAre(Field(&FuzzyFindRequest::Scopes, 1580 UnorderedElementsAre("")))); 1581 } 1582 1583 TEST(CompletionTest, NoDuplicatedQueryScopes) { 1584 auto Requests = captureIndexRequests(R"cpp( 1585 namespace {} 1586 1587 namespace na { 1588 namespace {} 1589 namespace nb { 1590 ^ 1591 } // namespace nb 1592 } // namespace na 1593 )cpp"); 1594 1595 EXPECT_THAT(Requests, 1596 ElementsAre(Field(&FuzzyFindRequest::Scopes, 1597 UnorderedElementsAre("na::", "na::nb::", "")))); 1598 } 1599 1600 TEST(CompletionTest, NoIndexCompletionsInsideClasses) { 1601 auto Completions = completions( 1602 R"cpp( 1603 struct Foo { 1604 int SomeNameOfField; 1605 typedef int SomeNameOfTypedefField; 1606 }; 1607 1608 Foo::^)cpp", 1609 {func("::SomeNameInTheIndex"), func("::Foo::SomeNameInTheIndex")}); 1610 1611 EXPECT_THAT(Completions.Completions, 1612 AllOf(Contains(Labeled("SomeNameOfField")), 1613 Contains(Labeled("SomeNameOfTypedefField")), 1614 Not(Contains(Labeled("SomeNameInTheIndex"))))); 1615 } 1616 1617 TEST(CompletionTest, NoIndexCompletionsInsideDependentCode) { 1618 { 1619 auto Completions = completions( 1620 R"cpp( 1621 template <class T> 1622 void foo() { 1623 T::^ 1624 } 1625 )cpp", 1626 {func("::SomeNameInTheIndex")}); 1627 1628 EXPECT_THAT(Completions.Completions, 1629 Not(Contains(Labeled("SomeNameInTheIndex")))); 1630 } 1631 1632 { 1633 auto Completions = completions( 1634 R"cpp( 1635 template <class T> 1636 void foo() { 1637 T::template Y<int>::^ 1638 } 1639 )cpp", 1640 {func("::SomeNameInTheIndex")}); 1641 1642 EXPECT_THAT(Completions.Completions, 1643 Not(Contains(Labeled("SomeNameInTheIndex")))); 1644 } 1645 1646 { 1647 auto Completions = completions( 1648 R"cpp( 1649 template <class T> 1650 void foo() { 1651 T::foo::^ 1652 } 1653 )cpp", 1654 {func("::SomeNameInTheIndex")}); 1655 1656 EXPECT_THAT(Completions.Completions, 1657 Not(Contains(Labeled("SomeNameInTheIndex")))); 1658 } 1659 } 1660 1661 TEST(CompletionTest, OverloadBundling) { 1662 clangd::CodeCompleteOptions Opts; 1663 Opts.BundleOverloads = true; 1664 1665 std::string Context = R"cpp( 1666 struct X { 1667 // Overload with int 1668 int a(int) __attribute__((deprecated("", ""))); 1669 // Overload with bool 1670 int a(bool); 1671 int b(float); 1672 1673 X(int); 1674 X(float); 1675 }; 1676 int GFuncC(int); 1677 int GFuncD(int); 1678 )cpp"; 1679 1680 // Member completions are bundled. 1681 EXPECT_THAT(completions(Context + "int y = X().^", {}, Opts).Completions, 1682 UnorderedElementsAre(Labeled("a(…)"), Labeled("b(float)"))); 1683 1684 // Constructor completions are bundled. 1685 EXPECT_THAT(completions(Context + "X z = X^", {}, Opts).Completions, 1686 UnorderedElementsAre(Labeled("X"), Labeled("X(…)"))); 1687 1688 // Non-member completions are bundled, including index+sema. 1689 Symbol NoArgsGFunc = func("GFuncC"); 1690 EXPECT_THAT( 1691 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions, 1692 UnorderedElementsAre(Labeled("GFuncC(…)"), Labeled("GFuncD(int)"))); 1693 1694 // Differences in header-to-insert suppress bundling. 1695 std::string DeclFile = URI::create(testPath("foo")).toString(); 1696 NoArgsGFunc.CanonicalDeclaration.FileURI = DeclFile.c_str(); 1697 NoArgsGFunc.IncludeHeaders.emplace_back("<foo>", 1); 1698 EXPECT_THAT( 1699 completions(Context + "int y = GFunc^", {NoArgsGFunc}, Opts).Completions, 1700 UnorderedElementsAre(AllOf(Named("GFuncC"), InsertInclude("<foo>")), 1701 Labeled("GFuncC(int)"), Labeled("GFuncD(int)"))); 1702 1703 // Examine a bundled completion in detail. 1704 auto A = 1705 completions(Context + "int y = X().a^", {}, Opts).Completions.front(); 1706 EXPECT_EQ(A.Name, "a"); 1707 EXPECT_EQ(A.Signature, "(…)"); 1708 EXPECT_EQ(A.BundleSize, 2u); 1709 EXPECT_EQ(A.Kind, CompletionItemKind::Method); 1710 EXPECT_EQ(A.ReturnType, "int"); // All overloads return int. 1711 // For now we just return one of the doc strings arbitrarily. 1712 ASSERT_TRUE(A.Documentation); 1713 ASSERT_FALSE(A.Deprecated); // Not all overloads deprecated. 1714 EXPECT_THAT( 1715 A.Documentation->asPlainText(), 1716 AnyOf(HasSubstr("Overload with int"), HasSubstr("Overload with bool"))); 1717 EXPECT_EQ(A.SnippetSuffix, "($0)"); 1718 } 1719 1720 TEST(CompletionTest, OverloadBundlingSameFileDifferentURI) { 1721 clangd::CodeCompleteOptions Opts; 1722 Opts.BundleOverloads = true; 1723 1724 Symbol SymX = sym("ns::X", index::SymbolKind::Function, "@F@\\0#"); 1725 Symbol SymY = sym("ns::X", index::SymbolKind::Function, "@F@\\0#I#"); 1726 std::string BarHeader = testPath("bar.h"); 1727 auto BarURI = URI::create(BarHeader).toString(); 1728 SymX.CanonicalDeclaration.FileURI = BarURI.c_str(); 1729 SymY.CanonicalDeclaration.FileURI = BarURI.c_str(); 1730 // The include header is different, but really it's the same file. 1731 SymX.IncludeHeaders.emplace_back("\"bar.h\"", 1); 1732 SymY.IncludeHeaders.emplace_back(BarURI.c_str(), 1); 1733 1734 auto Results = completions("void f() { ::ns::^ }", {SymX, SymY}, Opts); 1735 // Expect both results are bundled, despite the different-but-same 1736 // IncludeHeader. 1737 ASSERT_EQ(1u, Results.Completions.size()); 1738 const auto &R = Results.Completions.front(); 1739 EXPECT_EQ("X", R.Name); 1740 EXPECT_EQ(2u, R.BundleSize); 1741 } 1742 1743 TEST(CompletionTest, DocumentationFromChangedFileCrash) { 1744 MockFS FS; 1745 auto FooH = testPath("foo.h"); 1746 auto FooCpp = testPath("foo.cpp"); 1747 FS.Files[FooH] = R"cpp( 1748 // this is my documentation comment. 1749 int func(); 1750 )cpp"; 1751 FS.Files[FooCpp] = ""; 1752 1753 MockCompilationDatabase CDB; 1754 ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); 1755 1756 Annotations Source(R"cpp( 1757 #include "foo.h" 1758 int func() { 1759 // This makes sure we have func from header in the AST. 1760 } 1761 int a = fun^ 1762 )cpp"); 1763 Server.addDocument(FooCpp, Source.code(), "null", WantDiagnostics::Yes); 1764 // We need to wait for preamble to build. 1765 ASSERT_TRUE(Server.blockUntilIdleForTest()); 1766 1767 // Change the header file. Completion will reuse the old preamble! 1768 FS.Files[FooH] = R"cpp( 1769 int func(); 1770 )cpp"; 1771 1772 clangd::CodeCompleteOptions Opts; 1773 CodeCompleteResult Completions = 1774 cantFail(runCodeComplete(Server, FooCpp, Source.point(), Opts)); 1775 // We shouldn't crash. Unfortunately, current workaround is to not produce 1776 // comments for symbols from headers. 1777 EXPECT_THAT(Completions.Completions, 1778 Contains(AllOf(Not(IsDocumented()), Named("func")))); 1779 } 1780 1781 TEST(CompletionTest, NonDocComments) { 1782 const char *Text = R"cpp( 1783 // We ignore namespace comments, for rationale see CodeCompletionStrings.h. 1784 namespace comments_ns { 1785 } 1786 1787 // ------------------ 1788 int comments_foo(); 1789 1790 // A comment and a decl are separated by newlines. 1791 // Therefore, the comment shouldn't show up as doc comment. 1792 1793 int comments_bar(); 1794 1795 // this comment should be in the results. 1796 int comments_baz(); 1797 1798 1799 template <class T> 1800 struct Struct { 1801 int comments_qux(); 1802 int comments_quux(); 1803 }; 1804 1805 1806 // This comment should not be there. 1807 1808 template <class T> 1809 int Struct<T>::comments_qux() { 1810 } 1811 1812 // This comment **should** be in results. 1813 template <class T> 1814 int Struct<T>::comments_quux() { 1815 int a = comments^; 1816 } 1817 )cpp"; 1818 1819 // We should not get any of those comments in completion. 1820 EXPECT_THAT( 1821 completions(Text).Completions, 1822 UnorderedElementsAre(AllOf(Not(IsDocumented()), Named("comments_foo")), 1823 AllOf(IsDocumented(), Named("comments_baz")), 1824 AllOf(IsDocumented(), Named("comments_quux")), 1825 AllOf(Not(IsDocumented()), Named("comments_ns")), 1826 // FIXME(ibiryukov): the following items should have 1827 // empty documentation, since they are separated from 1828 // a comment with an empty line. Unfortunately, I 1829 // couldn't make Sema tests pass if we ignore those. 1830 AllOf(IsDocumented(), Named("comments_bar")), 1831 AllOf(IsDocumented(), Named("comments_qux")))); 1832 } 1833 1834 TEST(CompletionTest, CompleteOnInvalidLine) { 1835 auto FooCpp = testPath("foo.cpp"); 1836 1837 MockCompilationDatabase CDB; 1838 MockFS FS; 1839 FS.Files[FooCpp] = "// empty file"; 1840 1841 ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); 1842 // Run completion outside the file range. 1843 Position Pos; 1844 Pos.line = 100; 1845 Pos.character = 0; 1846 EXPECT_THAT_EXPECTED( 1847 runCodeComplete(Server, FooCpp, Pos, clangd::CodeCompleteOptions()), 1848 Failed()); 1849 } 1850 1851 TEST(CompletionTest, QualifiedNames) { 1852 auto Results = completions( 1853 R"cpp( 1854 namespace ns { int local; void both(); } 1855 void f() { ::ns::^ } 1856 )cpp", 1857 {func("ns::both"), cls("ns::Index")}); 1858 // We get results from both index and sema, with no duplicates. 1859 EXPECT_THAT( 1860 Results.Completions, 1861 UnorderedElementsAre(Scope("ns::"), Scope("ns::"), Scope("ns::"))); 1862 } 1863 1864 TEST(CompletionTest, Render) { 1865 CodeCompletion C; 1866 C.Name = "x"; 1867 C.Signature = "(bool) const"; 1868 C.SnippetSuffix = "(${0:bool})"; 1869 C.ReturnType = "int"; 1870 C.RequiredQualifier = "Foo::"; 1871 C.Scope = "ns::Foo::"; 1872 C.Documentation.emplace(); 1873 C.Documentation->addParagraph().appendText("This is ").appendCode("x()"); 1874 C.Includes.emplace_back(); 1875 auto &Include = C.Includes.back(); 1876 Include.Header = "\"foo.h\""; 1877 C.Kind = CompletionItemKind::Method; 1878 C.Score.Total = 1.0; 1879 C.Score.ExcludingName = .5; 1880 C.Origin = SymbolOrigin::AST | SymbolOrigin::Static; 1881 1882 CodeCompleteOptions Opts; 1883 Opts.IncludeIndicator.Insert = "^"; 1884 Opts.IncludeIndicator.NoInsert = ""; 1885 Opts.EnableSnippets = false; 1886 1887 auto R = C.render(Opts); 1888 EXPECT_EQ(R.label, "Foo::x(bool) const"); 1889 EXPECT_EQ(R.insertText, "Foo::x"); 1890 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText); 1891 EXPECT_EQ(R.filterText, "x"); 1892 EXPECT_EQ(R.detail, "int"); 1893 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\nThis is x()"); 1894 EXPECT_THAT(R.additionalTextEdits, IsEmpty()); 1895 EXPECT_EQ(R.sortText, sortText(1.0, "x")); 1896 EXPECT_FALSE(R.deprecated); 1897 EXPECT_EQ(R.score, .5f); 1898 1899 Opts.EnableSnippets = true; 1900 R = C.render(Opts); 1901 EXPECT_EQ(R.insertText, "Foo::x(${0:bool})"); 1902 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::Snippet); 1903 1904 C.SnippetSuffix = ""; 1905 R = C.render(Opts); 1906 EXPECT_EQ(R.insertText, "Foo::x"); 1907 EXPECT_EQ(R.insertTextFormat, InsertTextFormat::PlainText); 1908 1909 Include.Insertion.emplace(); 1910 R = C.render(Opts); 1911 EXPECT_EQ(R.label, "^Foo::x(bool) const"); 1912 EXPECT_THAT(R.additionalTextEdits, Not(IsEmpty())); 1913 1914 Opts.ShowOrigins = true; 1915 R = C.render(Opts); 1916 EXPECT_EQ(R.label, "^[AS]Foo::x(bool) const"); 1917 1918 C.BundleSize = 2; 1919 R = C.render(Opts); 1920 EXPECT_EQ(R.detail, "[2 overloads]"); 1921 EXPECT_EQ(R.documentation->value, "From \"foo.h\"\nThis is x()"); 1922 1923 C.Deprecated = true; 1924 R = C.render(Opts); 1925 EXPECT_TRUE(R.deprecated); 1926 1927 Opts.DocumentationFormat = MarkupKind::Markdown; 1928 R = C.render(Opts); 1929 EXPECT_EQ(R.documentation->value, "From `\"foo.h\"` \nThis is `x()`"); 1930 } 1931 1932 TEST(CompletionTest, IgnoreRecoveryResults) { 1933 auto Results = completions( 1934 R"cpp( 1935 namespace ns { int NotRecovered() { return 0; } } 1936 void f() { 1937 // Sema enters recovery mode first and then normal mode. 1938 if (auto x = ns::NotRecover^) 1939 } 1940 )cpp"); 1941 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Named("NotRecovered"))); 1942 } 1943 1944 TEST(CompletionTest, ScopeOfClassFieldInConstructorInitializer) { 1945 auto Results = completions( 1946 R"cpp( 1947 namespace ns { 1948 class X { public: X(); int x_; }; 1949 X::X() : x_^(0) {} 1950 } 1951 )cpp"); 1952 EXPECT_THAT(Results.Completions, 1953 UnorderedElementsAre(AllOf(Scope("ns::X::"), Named("x_")))); 1954 } 1955 1956 TEST(CompletionTest, CodeCompletionContext) { 1957 auto Results = completions( 1958 R"cpp( 1959 namespace ns { 1960 class X { public: X(); int x_; }; 1961 void f() { 1962 X x; 1963 x.^; 1964 } 1965 } 1966 )cpp"); 1967 1968 EXPECT_THAT(Results.Context, CodeCompletionContext::CCC_DotMemberAccess); 1969 } 1970 1971 TEST(CompletionTest, FixItForArrowToDot) { 1972 MockFS FS; 1973 MockCompilationDatabase CDB; 1974 1975 CodeCompleteOptions Opts; 1976 Opts.IncludeFixIts = true; 1977 const char *Code = 1978 R"cpp( 1979 class Auxilary { 1980 public: 1981 void AuxFunction(); 1982 }; 1983 class ClassWithPtr { 1984 public: 1985 void MemberFunction(); 1986 Auxilary* operator->() const; 1987 Auxilary* Aux; 1988 }; 1989 void f() { 1990 ClassWithPtr x; 1991 x[[->]]^; 1992 } 1993 )cpp"; 1994 auto Results = completions(Code, {}, Opts); 1995 EXPECT_EQ(Results.Completions.size(), 3u); 1996 1997 TextEdit ReplacementEdit; 1998 ReplacementEdit.range = Annotations(Code).range(); 1999 ReplacementEdit.newText = "."; 2000 for (const auto &C : Results.Completions) { 2001 EXPECT_TRUE(C.FixIts.size() == 1u || C.Name == "AuxFunction"); 2002 if (!C.FixIts.empty()) { 2003 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit)); 2004 } 2005 } 2006 } 2007 2008 TEST(CompletionTest, FixItForDotToArrow) { 2009 CodeCompleteOptions Opts; 2010 Opts.IncludeFixIts = true; 2011 const char *Code = 2012 R"cpp( 2013 class Auxilary { 2014 public: 2015 void AuxFunction(); 2016 }; 2017 class ClassWithPtr { 2018 public: 2019 void MemberFunction(); 2020 Auxilary* operator->() const; 2021 Auxilary* Aux; 2022 }; 2023 void f() { 2024 ClassWithPtr x; 2025 x[[.]]^; 2026 } 2027 )cpp"; 2028 auto Results = completions(Code, {}, Opts); 2029 EXPECT_EQ(Results.Completions.size(), 3u); 2030 2031 TextEdit ReplacementEdit; 2032 ReplacementEdit.range = Annotations(Code).range(); 2033 ReplacementEdit.newText = "->"; 2034 for (const auto &C : Results.Completions) { 2035 EXPECT_TRUE(C.FixIts.empty() || C.Name == "AuxFunction"); 2036 if (!C.FixIts.empty()) { 2037 EXPECT_THAT(C.FixIts, ElementsAre(ReplacementEdit)); 2038 } 2039 } 2040 } 2041 2042 TEST(CompletionTest, RenderWithFixItMerged) { 2043 TextEdit FixIt; 2044 FixIt.range.end.character = 5; 2045 FixIt.newText = "->"; 2046 2047 CodeCompletion C; 2048 C.Name = "x"; 2049 C.RequiredQualifier = "Foo::"; 2050 C.FixIts = {FixIt}; 2051 C.CompletionTokenRange.start.character = 5; 2052 2053 CodeCompleteOptions Opts; 2054 Opts.IncludeFixIts = true; 2055 2056 auto R = C.render(Opts); 2057 EXPECT_TRUE(R.textEdit); 2058 EXPECT_EQ(R.textEdit->newText, "->Foo::x"); 2059 EXPECT_TRUE(R.additionalTextEdits.empty()); 2060 } 2061 2062 TEST(CompletionTest, RenderWithFixItNonMerged) { 2063 TextEdit FixIt; 2064 FixIt.range.end.character = 4; 2065 FixIt.newText = "->"; 2066 2067 CodeCompletion C; 2068 C.Name = "x"; 2069 C.RequiredQualifier = "Foo::"; 2070 C.FixIts = {FixIt}; 2071 C.CompletionTokenRange.start.character = 5; 2072 2073 CodeCompleteOptions Opts; 2074 Opts.IncludeFixIts = true; 2075 2076 auto R = C.render(Opts); 2077 EXPECT_TRUE(R.textEdit); 2078 EXPECT_EQ(R.textEdit->newText, "Foo::x"); 2079 EXPECT_THAT(R.additionalTextEdits, UnorderedElementsAre(FixIt)); 2080 } 2081 2082 TEST(CompletionTest, CompletionTokenRange) { 2083 MockFS FS; 2084 MockCompilationDatabase CDB; 2085 TestTU TU; 2086 TU.AdditionalFiles["foo/abc/foo.h"] = ""; 2087 2088 constexpr const char *TestCodes[] = { 2089 R"cpp( 2090 class Auxilary { 2091 public: 2092 void AuxFunction(); 2093 }; 2094 void f() { 2095 Auxilary x; 2096 x.[[Aux]]^; 2097 } 2098 )cpp", 2099 R"cpp( 2100 class Auxilary { 2101 public: 2102 void AuxFunction(); 2103 }; 2104 void f() { 2105 Auxilary x; 2106 x.[[]]^; 2107 } 2108 )cpp", 2109 R"cpp( 2110 #include "foo/[[a^/]]foo.h" 2111 )cpp", 2112 R"cpp( 2113 #include "foo/abc/[[fo^o.h"]] 2114 )cpp", 2115 }; 2116 for (const auto &Text : TestCodes) { 2117 Annotations TestCode(Text); 2118 TU.Code = TestCode.code().str(); 2119 auto Results = completions(TU, TestCode.point()); 2120 if (Results.Completions.size() != 1) { 2121 ADD_FAILURE() << "Results.Completions.size() != 1" << Text; 2122 continue; 2123 } 2124 EXPECT_THAT(Results.Completions.front().CompletionTokenRange, 2125 TestCode.range()); 2126 } 2127 } 2128 2129 TEST(SignatureHelpTest, OverloadsOrdering) { 2130 const auto Results = signatures(R"cpp( 2131 void foo(int x); 2132 void foo(int x, float y); 2133 void foo(float x, int y); 2134 void foo(float x, float y); 2135 void foo(int x, int y = 0); 2136 int main() { foo(^); } 2137 )cpp"); 2138 EXPECT_THAT(Results.signatures, 2139 ElementsAre(Sig("foo([[int x]]) -> void"), 2140 Sig("foo([[int x]], [[int y = 0]]) -> void"), 2141 Sig("foo([[float x]], [[int y]]) -> void"), 2142 Sig("foo([[int x]], [[float y]]) -> void"), 2143 Sig("foo([[float x]], [[float y]]) -> void"))); 2144 // We always prefer the first signature. 2145 EXPECT_EQ(0, Results.activeSignature); 2146 EXPECT_EQ(0, Results.activeParameter); 2147 } 2148 2149 TEST(SignatureHelpTest, InstantiatedSignatures) { 2150 StringRef Sig0 = R"cpp( 2151 template <class T> 2152 void foo(T, T, T); 2153 2154 int main() { 2155 foo<int>(^); 2156 } 2157 )cpp"; 2158 2159 EXPECT_THAT(signatures(Sig0).signatures, 2160 ElementsAre(Sig("foo([[T]], [[T]], [[T]]) -> void"))); 2161 2162 StringRef Sig1 = R"cpp( 2163 template <class T> 2164 void foo(T, T, T); 2165 2166 int main() { 2167 foo(10, ^); 2168 })cpp"; 2169 2170 EXPECT_THAT(signatures(Sig1).signatures, 2171 ElementsAre(Sig("foo([[T]], [[T]], [[T]]) -> void"))); 2172 2173 StringRef Sig2 = R"cpp( 2174 template <class ...T> 2175 void foo(T...); 2176 2177 int main() { 2178 foo<int>(^); 2179 } 2180 )cpp"; 2181 2182 EXPECT_THAT(signatures(Sig2).signatures, 2183 ElementsAre(Sig("foo([[T...]]) -> void"))); 2184 2185 // It is debatable whether we should substitute the outer template parameter 2186 // ('T') in that case. Currently we don't substitute it in signature help, but 2187 // do substitute in code complete. 2188 // FIXME: make code complete and signature help consistent, figure out which 2189 // way is better. 2190 StringRef Sig3 = R"cpp( 2191 template <class T> 2192 struct X { 2193 template <class U> 2194 void foo(T, U); 2195 }; 2196 2197 int main() { 2198 X<int>().foo<double>(^) 2199 } 2200 )cpp"; 2201 2202 EXPECT_THAT(signatures(Sig3).signatures, 2203 ElementsAre(Sig("foo([[T]], [[U]]) -> void"))); 2204 } 2205 2206 TEST(SignatureHelpTest, IndexDocumentation) { 2207 Symbol Foo0 = sym("foo", index::SymbolKind::Function, "@F@\\0#"); 2208 Foo0.Documentation = "Doc from the index"; 2209 Symbol Foo1 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#"); 2210 Foo1.Documentation = "Doc from the index"; 2211 Symbol Foo2 = sym("foo", index::SymbolKind::Function, "@F@\\0#I#I#"); 2212 2213 StringRef Sig0 = R"cpp( 2214 int foo(); 2215 int foo(double); 2216 2217 void test() { 2218 foo(^); 2219 } 2220 )cpp"; 2221 2222 EXPECT_THAT( 2223 signatures(Sig0, {Foo0}).signatures, 2224 ElementsAre(AllOf(Sig("foo() -> int"), SigDoc("Doc from the index")), 2225 AllOf(Sig("foo([[double]]) -> int"), SigDoc("")))); 2226 2227 StringRef Sig1 = R"cpp( 2228 int foo(); 2229 // Overriden doc from sema 2230 int foo(int); 2231 // Doc from sema 2232 int foo(int, int); 2233 2234 void test() { 2235 foo(^); 2236 } 2237 )cpp"; 2238 2239 EXPECT_THAT( 2240 signatures(Sig1, {Foo0, Foo1, Foo2}).signatures, 2241 ElementsAre( 2242 AllOf(Sig("foo() -> int"), SigDoc("Doc from the index")), 2243 AllOf(Sig("foo([[int]]) -> int"), SigDoc("Overriden doc from sema")), 2244 AllOf(Sig("foo([[int]], [[int]]) -> int"), SigDoc("Doc from sema")))); 2245 } 2246 2247 TEST(SignatureHelpTest, DynamicIndexDocumentation) { 2248 MockFS FS; 2249 MockCompilationDatabase CDB; 2250 ClangdServer::Options Opts = ClangdServer::optsForTest(); 2251 Opts.BuildDynamicSymbolIndex = true; 2252 ClangdServer Server(CDB, FS, Opts); 2253 2254 FS.Files[testPath("foo.h")] = R"cpp( 2255 struct Foo { 2256 // Member doc 2257 int foo(); 2258 }; 2259 )cpp"; 2260 Annotations FileContent(R"cpp( 2261 #include "foo.h" 2262 void test() { 2263 Foo f; 2264 f.foo(^); 2265 } 2266 )cpp"); 2267 auto File = testPath("test.cpp"); 2268 Server.addDocument(File, FileContent.code()); 2269 // Wait for the dynamic index being built. 2270 ASSERT_TRUE(Server.blockUntilIdleForTest()); 2271 EXPECT_THAT(llvm::cantFail(runSignatureHelp(Server, File, FileContent.point(), 2272 MarkupKind::PlainText)) 2273 .signatures, 2274 ElementsAre(AllOf(Sig("foo() -> int"), SigDoc("Member doc")))); 2275 } 2276 2277 TEST(CompletionTest, CompletionFunctionArgsDisabled) { 2278 CodeCompleteOptions Opts; 2279 Opts.EnableSnippets = true; 2280 Opts.EnableFunctionArgSnippets = false; 2281 2282 { 2283 auto Results = completions( 2284 R"cpp( 2285 void xfoo(); 2286 void xfoo(int x, int y); 2287 void f() { xfo^ })cpp", 2288 {}, Opts); 2289 EXPECT_THAT( 2290 Results.Completions, 2291 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("()")), 2292 AllOf(Named("xfoo"), SnippetSuffix("($0)")))); 2293 } 2294 { 2295 auto Results = completions( 2296 R"cpp( 2297 void xbar(); 2298 void f() { xba^ })cpp", 2299 {}, Opts); 2300 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf( 2301 Named("xbar"), SnippetSuffix("()")))); 2302 } 2303 { 2304 Opts.BundleOverloads = true; 2305 auto Results = completions( 2306 R"cpp( 2307 void xfoo(); 2308 void xfoo(int x, int y); 2309 void f() { xfo^ })cpp", 2310 {}, Opts); 2311 EXPECT_THAT( 2312 Results.Completions, 2313 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("($0)")))); 2314 } 2315 { 2316 auto Results = completions( 2317 R"cpp( 2318 template <class T, class U> 2319 void xfoo(int a, U b); 2320 void f() { xfo^ })cpp", 2321 {}, Opts); 2322 EXPECT_THAT( 2323 Results.Completions, 2324 UnorderedElementsAre(AllOf(Named("xfoo"), SnippetSuffix("<$1>($0)")))); 2325 } 2326 { 2327 auto Results = completions( 2328 R"cpp( 2329 template <class T> 2330 class foo_class{}; 2331 template <class T> 2332 using foo_alias = T**; 2333 void f() { foo_^ })cpp", 2334 {}, Opts); 2335 EXPECT_THAT( 2336 Results.Completions, 2337 UnorderedElementsAre(AllOf(Named("foo_class"), SnippetSuffix("<$0>")), 2338 AllOf(Named("foo_alias"), SnippetSuffix("<$0>")))); 2339 } 2340 { 2341 auto Results = completions( 2342 R"cpp( 2343 #define FOO(x, y) x##f 2344 FO^ )cpp", 2345 {}, Opts); 2346 EXPECT_THAT(Results.Completions, UnorderedElementsAre(AllOf( 2347 Named("FOO"), SnippetSuffix("($0)")))); 2348 } 2349 } 2350 2351 TEST(CompletionTest, SuggestOverrides) { 2352 constexpr const char *const Text(R"cpp( 2353 class A { 2354 public: 2355 virtual void vfunc(bool param); 2356 virtual void vfunc(bool param, int p); 2357 void func(bool param); 2358 }; 2359 class B : public A { 2360 virtual void ttt(bool param) const; 2361 void vfunc(bool param, int p) override; 2362 }; 2363 class C : public B { 2364 public: 2365 void vfunc(bool param) override; 2366 ^ 2367 }; 2368 )cpp"); 2369 const auto Results = completions(Text); 2370 EXPECT_THAT( 2371 Results.Completions, 2372 AllOf(Contains(AllOf(Labeled("void vfunc(bool param, int p) override"), 2373 NameStartsWith("vfunc"))), 2374 Contains(AllOf(Labeled("void ttt(bool param) const override"), 2375 NameStartsWith("ttt"))), 2376 Not(Contains(Labeled("void vfunc(bool param) override"))))); 2377 } 2378 2379 TEST(CompletionTest, OverridesNonIdentName) { 2380 // Check the completions call does not crash. 2381 completions(R"cpp( 2382 struct Base { 2383 virtual ~Base() = 0; 2384 virtual operator int() = 0; 2385 virtual Base& operator+(Base&) = 0; 2386 }; 2387 2388 struct Derived : Base { 2389 ^ 2390 }; 2391 )cpp"); 2392 } 2393 2394 TEST(GuessCompletionPrefix, Filters) { 2395 for (llvm::StringRef Case : { 2396 "[[scope::]][[ident]]^", 2397 "[[]][[]]^", 2398 "\n[[]][[]]^", 2399 "[[]][[ab]]^", 2400 "x.[[]][[ab]]^", 2401 "x.[[]][[]]^", 2402 "[[x::]][[ab]]^", 2403 "[[x::]][[]]^", 2404 "[[::x::]][[ab]]^", 2405 "some text [[scope::more::]][[identif]]^ier", 2406 "some text [[scope::]][[mor]]^e::identifier", 2407 "weird case foo::[[::bar::]][[baz]]^", 2408 "/* [[]][[]]^ */", 2409 }) { 2410 Annotations F(Case); 2411 auto Offset = cantFail(positionToOffset(F.code(), F.point())); 2412 auto ToStringRef = [&](Range R) { 2413 return F.code().slice(cantFail(positionToOffset(F.code(), R.start)), 2414 cantFail(positionToOffset(F.code(), R.end))); 2415 }; 2416 auto WantQualifier = ToStringRef(F.ranges()[0]), 2417 WantName = ToStringRef(F.ranges()[1]); 2418 2419 auto Prefix = guessCompletionPrefix(F.code(), Offset); 2420 // Even when components are empty, check their offsets are correct. 2421 EXPECT_EQ(WantQualifier, Prefix.Qualifier) << Case; 2422 EXPECT_EQ(WantQualifier.begin(), Prefix.Qualifier.begin()) << Case; 2423 EXPECT_EQ(WantName, Prefix.Name) << Case; 2424 EXPECT_EQ(WantName.begin(), Prefix.Name.begin()) << Case; 2425 } 2426 } 2427 2428 TEST(CompletionTest, EnableSpeculativeIndexRequest) { 2429 MockFS FS; 2430 MockCompilationDatabase CDB; 2431 ClangdServer Server(CDB, FS, ClangdServer::optsForTest()); 2432 2433 auto File = testPath("foo.cpp"); 2434 Annotations Test(R"cpp( 2435 namespace ns1 { int abc; } 2436 namespace ns2 { int abc; } 2437 void f() { ns1::ab$1^; ns1::ab$2^; } 2438 void f2() { ns2::ab$3^; } 2439 )cpp"); 2440 runAddDocument(Server, File, Test.code()); 2441 clangd::CodeCompleteOptions Opts = {}; 2442 2443 IndexRequestCollector Requests; 2444 Opts.Index = &Requests; 2445 2446 auto CompleteAtPoint = [&](StringRef P) { 2447 cantFail(runCodeComplete(Server, File, Test.point(P), Opts)); 2448 }; 2449 2450 CompleteAtPoint("1"); 2451 auto Reqs1 = Requests.consumeRequests(1); 2452 ASSERT_EQ(Reqs1.size(), 1u); 2453 EXPECT_THAT(Reqs1[0].Scopes, UnorderedElementsAre("ns1::")); 2454 2455 CompleteAtPoint("2"); 2456 auto Reqs2 = Requests.consumeRequests(1); 2457 // Speculation succeeded. Used speculative index result. 2458 ASSERT_EQ(Reqs2.size(), 1u); 2459 EXPECT_EQ(Reqs2[0], Reqs1[0]); 2460 2461 CompleteAtPoint("3"); 2462 // Speculation failed. Sent speculative index request and the new index 2463 // request after sema. 2464 auto Reqs3 = Requests.consumeRequests(2); 2465 ASSERT_EQ(Reqs3.size(), 2u); 2466 } 2467 2468 TEST(CompletionTest, InsertTheMostPopularHeader) { 2469 std::string DeclFile = URI::create(testPath("foo")).toString(); 2470 Symbol Sym = func("Func"); 2471 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str(); 2472 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2); 2473 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000); 2474 2475 auto Results = completions("Fun^", {Sym}).Completions; 2476 assert(!Results.empty()); 2477 EXPECT_THAT(Results[0], AllOf(Named("Func"), InsertInclude("\"bar.h\""))); 2478 EXPECT_EQ(Results[0].Includes.size(), 2u); 2479 } 2480 2481 TEST(CompletionTest, NoInsertIncludeIfOnePresent) { 2482 Annotations Test(R"cpp( 2483 #include "foo.h" 2484 Fun^ 2485 )cpp"); 2486 auto TU = TestTU::withCode(Test.code()); 2487 TU.AdditionalFiles["foo.h"] = ""; 2488 2489 std::string DeclFile = URI::create(testPath("foo")).toString(); 2490 Symbol Sym = func("Func"); 2491 Sym.CanonicalDeclaration.FileURI = DeclFile.c_str(); 2492 Sym.IncludeHeaders.emplace_back("\"foo.h\"", 2); 2493 Sym.IncludeHeaders.emplace_back("\"bar.h\"", 1000); 2494 2495 EXPECT_THAT(completions(TU, Test.point(), {Sym}).Completions, 2496 UnorderedElementsAre(AllOf(Named("Func"), HasInclude("\"foo.h\""), 2497 Not(InsertInclude())))); 2498 } 2499 2500 TEST(CompletionTest, MergeMacrosFromIndexAndSema) { 2501 Symbol Sym; 2502 Sym.Name = "Clangd_Macro_Test"; 2503 Sym.ID = SymbolID("c:foo.cpp@8@macro@Clangd_Macro_Test"); 2504 Sym.SymInfo.Kind = index::SymbolKind::Macro; 2505 Sym.Flags |= Symbol::IndexedForCodeCompletion; 2506 EXPECT_THAT(completions("#define Clangd_Macro_Test\nClangd_Macro_T^", {Sym}) 2507 .Completions, 2508 UnorderedElementsAre(Named("Clangd_Macro_Test"))); 2509 } 2510 2511 TEST(CompletionTest, MacroFromPreamble) { 2512 Annotations Test(R"cpp(#define CLANGD_PREAMBLE_MAIN x 2513 2514 int x = 0; 2515 #define CLANGD_MAIN x 2516 void f() { CLANGD_^ } 2517 )cpp"); 2518 auto TU = TestTU::withCode(Test.code()); 2519 TU.HeaderCode = "#define CLANGD_PREAMBLE_HEADER x"; 2520 auto Results = completions(TU, Test.point(), {func("CLANGD_INDEX")}); 2521 // We should get results from the main file, including the preamble section. 2522 // However no results from included files (the index should cover them). 2523 EXPECT_THAT(Results.Completions, 2524 UnorderedElementsAre(Named("CLANGD_PREAMBLE_MAIN"), 2525 Named("CLANGD_MAIN"), 2526 Named("CLANGD_INDEX"))); 2527 } 2528 2529 TEST(CompletionTest, DeprecatedResults) { 2530 std::string Body = R"cpp( 2531 void TestClangd(); 2532 void TestClangc() __attribute__((deprecated("", ""))); 2533 )cpp"; 2534 2535 EXPECT_THAT( 2536 completions(Body + "int main() { TestClang^ }").Completions, 2537 UnorderedElementsAre(AllOf(Named("TestClangd"), Not(Deprecated())), 2538 AllOf(Named("TestClangc"), Deprecated()))); 2539 } 2540 2541 TEST(SignatureHelpTest, PartialSpec) { 2542 const auto Results = signatures(R"cpp( 2543 template <typename T> struct Foo {}; 2544 template <typename T> struct Foo<T*> { Foo(T); }; 2545 Foo<int*> F(^);)cpp"); 2546 EXPECT_THAT(Results.signatures, Contains(Sig("Foo([[T]])"))); 2547 EXPECT_EQ(0, Results.activeParameter); 2548 } 2549 2550 TEST(SignatureHelpTest, InsideArgument) { 2551 { 2552 const auto Results = signatures(R"cpp( 2553 void foo(int x); 2554 void foo(int x, int y); 2555 int main() { foo(1+^); } 2556 )cpp"); 2557 EXPECT_THAT(Results.signatures, 2558 ElementsAre(Sig("foo([[int x]]) -> void"), 2559 Sig("foo([[int x]], [[int y]]) -> void"))); 2560 EXPECT_EQ(0, Results.activeParameter); 2561 } 2562 { 2563 const auto Results = signatures(R"cpp( 2564 void foo(int x); 2565 void foo(int x, int y); 2566 int main() { foo(1^); } 2567 )cpp"); 2568 EXPECT_THAT(Results.signatures, 2569 ElementsAre(Sig("foo([[int x]]) -> void"), 2570 Sig("foo([[int x]], [[int y]]) -> void"))); 2571 EXPECT_EQ(0, Results.activeParameter); 2572 } 2573 { 2574 const auto Results = signatures(R"cpp( 2575 void foo(int x); 2576 void foo(int x, int y); 2577 int main() { foo(1^0); } 2578 )cpp"); 2579 EXPECT_THAT(Results.signatures, 2580 ElementsAre(Sig("foo([[int x]]) -> void"), 2581 Sig("foo([[int x]], [[int y]]) -> void"))); 2582 EXPECT_EQ(0, Results.activeParameter); 2583 } 2584 { 2585 const auto Results = signatures(R"cpp( 2586 void foo(int x); 2587 void foo(int x, int y); 2588 int bar(int x, int y); 2589 int main() { bar(foo(2, 3^)); } 2590 )cpp"); 2591 EXPECT_THAT(Results.signatures, 2592 ElementsAre(Sig("foo([[int x]], [[int y]]) -> void"))); 2593 EXPECT_EQ(1, Results.activeParameter); 2594 } 2595 } 2596 2597 TEST(SignatureHelpTest, ConstructorInitializeFields) { 2598 { 2599 const auto Results = signatures(R"cpp( 2600 struct A { 2601 A(int); 2602 }; 2603 struct B { 2604 B() : a_elem(^) {} 2605 A a_elem; 2606 }; 2607 )cpp"); 2608 EXPECT_THAT(Results.signatures, 2609 UnorderedElementsAre(Sig("A([[int]])"), Sig("A([[A &&]])"), 2610 Sig("A([[const A &]])"))); 2611 } 2612 { 2613 const auto Results = signatures(R"cpp( 2614 struct A { 2615 A(int); 2616 }; 2617 struct C { 2618 C(int); 2619 C(A); 2620 }; 2621 struct B { 2622 B() : c_elem(A(1^)) {} 2623 C c_elem; 2624 }; 2625 )cpp"); 2626 EXPECT_THAT(Results.signatures, 2627 UnorderedElementsAre(Sig("A([[int]])"), Sig("A([[A &&]])"), 2628 Sig("A([[const A &]])"))); 2629 } 2630 } 2631 2632 TEST(SignatureHelpTest, Variadic) { 2633 const std::string Header = R"cpp( 2634 void fun(int x, ...) {} 2635 void test() {)cpp"; 2636 const std::string ExpectedSig = "fun([[int x]], [[...]]) -> void"; 2637 2638 { 2639 const auto Result = signatures(Header + "fun(^);}"); 2640 EXPECT_EQ(0, Result.activeParameter); 2641 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2642 } 2643 { 2644 const auto Result = signatures(Header + "fun(1, ^);}"); 2645 EXPECT_EQ(1, Result.activeParameter); 2646 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2647 } 2648 { 2649 const auto Result = signatures(Header + "fun(1, 2, ^);}"); 2650 EXPECT_EQ(1, Result.activeParameter); 2651 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2652 } 2653 } 2654 2655 TEST(SignatureHelpTest, VariadicTemplate) { 2656 const std::string Header = R"cpp( 2657 template<typename T, typename ...Args> 2658 void fun(T t, Args ...args) {} 2659 void test() {)cpp"; 2660 const std::string ExpectedSig = "fun([[T t]], [[Args args...]]) -> void"; 2661 2662 { 2663 const auto Result = signatures(Header + "fun(^);}"); 2664 EXPECT_EQ(0, Result.activeParameter); 2665 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2666 } 2667 { 2668 const auto Result = signatures(Header + "fun(1, ^);}"); 2669 EXPECT_EQ(1, Result.activeParameter); 2670 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2671 } 2672 { 2673 const auto Result = signatures(Header + "fun(1, 2, ^);}"); 2674 EXPECT_EQ(1, Result.activeParameter); 2675 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2676 } 2677 } 2678 2679 TEST(SignatureHelpTest, VariadicMethod) { 2680 const std::string Header = R"cpp( 2681 class C { 2682 template<typename T, typename ...Args> 2683 void fun(T t, Args ...args) {} 2684 }; 2685 void test() {C c; )cpp"; 2686 const std::string ExpectedSig = "fun([[T t]], [[Args args...]]) -> void"; 2687 2688 { 2689 const auto Result = signatures(Header + "c.fun(^);}"); 2690 EXPECT_EQ(0, Result.activeParameter); 2691 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2692 } 2693 { 2694 const auto Result = signatures(Header + "c.fun(1, ^);}"); 2695 EXPECT_EQ(1, Result.activeParameter); 2696 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2697 } 2698 { 2699 const auto Result = signatures(Header + "c.fun(1, 2, ^);}"); 2700 EXPECT_EQ(1, Result.activeParameter); 2701 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2702 } 2703 } 2704 2705 TEST(SignatureHelpTest, VariadicType) { 2706 const std::string Header = R"cpp( 2707 void fun(int x, ...) {} 2708 auto get_fun() { return fun; } 2709 void test() { 2710 )cpp"; 2711 const std::string ExpectedSig = "([[int]], [[...]]) -> void"; 2712 2713 { 2714 const auto Result = signatures(Header + "get_fun()(^);}"); 2715 EXPECT_EQ(0, Result.activeParameter); 2716 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2717 } 2718 { 2719 const auto Result = signatures(Header + "get_fun()(1, ^);}"); 2720 EXPECT_EQ(1, Result.activeParameter); 2721 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2722 } 2723 { 2724 const auto Result = signatures(Header + "get_fun()(1, 2, ^);}"); 2725 EXPECT_EQ(1, Result.activeParameter); 2726 EXPECT_THAT(Result.signatures, UnorderedElementsAre(Sig(ExpectedSig))); 2727 } 2728 } 2729 2730 TEST(CompletionTest, IncludedCompletionKinds) { 2731 Annotations Test(R"cpp(#include "^)cpp"); 2732 auto TU = TestTU::withCode(Test.code()); 2733 TU.AdditionalFiles["sub/bar.h"] = ""; 2734 TU.ExtraArgs.push_back("-I" + testPath("sub")); 2735 2736 auto Results = completions(TU, Test.point()); 2737 EXPECT_THAT(Results.Completions, 2738 AllOf(Has("sub/", CompletionItemKind::Folder), 2739 Has("bar.h\"", CompletionItemKind::File))); 2740 } 2741 2742 TEST(CompletionTest, NoCrashAtNonAlphaIncludeHeader) { 2743 completions( 2744 R"cpp( 2745 #include "./^" 2746 )cpp"); 2747 } 2748 2749 TEST(CompletionTest, NoAllScopesCompletionWhenQualified) { 2750 clangd::CodeCompleteOptions Opts = {}; 2751 Opts.AllScopes = true; 2752 2753 auto Results = completions( 2754 R"cpp( 2755 void f() { na::Clangd^ } 2756 )cpp", 2757 {cls("na::ClangdA"), cls("nx::ClangdX"), cls("Clangd3")}, Opts); 2758 EXPECT_THAT(Results.Completions, 2759 UnorderedElementsAre( 2760 AllOf(Qualifier(""), Scope("na::"), Named("ClangdA")))); 2761 } 2762 2763 TEST(CompletionTest, AllScopesCompletion) { 2764 clangd::CodeCompleteOptions Opts = {}; 2765 Opts.AllScopes = true; 2766 2767 auto Results = completions( 2768 R"cpp( 2769 namespace na { 2770 void f() { Clangd^ } 2771 } 2772 )cpp", 2773 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"), 2774 cls("na::nb::Clangd4")}, 2775 Opts); 2776 EXPECT_THAT( 2777 Results.Completions, 2778 UnorderedElementsAre(AllOf(Qualifier("nx::"), Named("Clangd1")), 2779 AllOf(Qualifier("ny::"), Named("Clangd2")), 2780 AllOf(Qualifier(""), Scope(""), Named("Clangd3")), 2781 AllOf(Qualifier("nb::"), Named("Clangd4")))); 2782 } 2783 2784 TEST(CompletionTest, NoQualifierIfShadowed) { 2785 clangd::CodeCompleteOptions Opts = {}; 2786 Opts.AllScopes = true; 2787 2788 auto Results = completions(R"cpp( 2789 namespace nx { class Clangd1 {}; } 2790 using nx::Clangd1; 2791 void f() { Clangd^ } 2792 )cpp", 2793 {cls("nx::Clangd1"), cls("nx::Clangd2")}, Opts); 2794 // Although Clangd1 is from another namespace, Sema tells us it's in-scope and 2795 // needs no qualifier. 2796 EXPECT_THAT(Results.Completions, 2797 UnorderedElementsAre(AllOf(Qualifier(""), Named("Clangd1")), 2798 AllOf(Qualifier("nx::"), Named("Clangd2")))); 2799 } 2800 2801 TEST(CompletionTest, NoCompletionsForNewNames) { 2802 clangd::CodeCompleteOptions Opts; 2803 Opts.AllScopes = true; 2804 auto Results = completions(R"cpp( 2805 void f() { int n^ } 2806 )cpp", 2807 {cls("naber"), cls("nx::naber")}, Opts); 2808 EXPECT_THAT(Results.Completions, UnorderedElementsAre()); 2809 } 2810 2811 TEST(CompletionTest, Lambda) { 2812 clangd::CodeCompleteOptions Opts = {}; 2813 2814 auto Results = completions(R"cpp( 2815 void function() { 2816 auto Lambda = [](int a, const double &b) {return 1.f;}; 2817 Lam^ 2818 } 2819 )cpp", 2820 {}, Opts); 2821 2822 ASSERT_EQ(Results.Completions.size(), 1u); 2823 const auto &A = Results.Completions.front(); 2824 EXPECT_EQ(A.Name, "Lambda"); 2825 EXPECT_EQ(A.Signature, "(int a, const double &b) const"); 2826 EXPECT_EQ(A.Kind, CompletionItemKind::Variable); 2827 EXPECT_EQ(A.ReturnType, "float"); 2828 EXPECT_EQ(A.SnippetSuffix, "(${1:int a}, ${2:const double &b})"); 2829 } 2830 2831 TEST(CompletionTest, StructuredBinding) { 2832 clangd::CodeCompleteOptions Opts = {}; 2833 2834 auto Results = completions(R"cpp( 2835 struct S { 2836 using Float = float; 2837 int x; 2838 Float y; 2839 }; 2840 void function() { 2841 const auto &[xxx, yyy] = S{}; 2842 yyy^ 2843 } 2844 )cpp", 2845 {}, Opts); 2846 2847 ASSERT_EQ(Results.Completions.size(), 1u); 2848 const auto &A = Results.Completions.front(); 2849 EXPECT_EQ(A.Name, "yyy"); 2850 EXPECT_EQ(A.Kind, CompletionItemKind::Variable); 2851 EXPECT_EQ(A.ReturnType, "const Float"); 2852 } 2853 2854 TEST(CompletionTest, ObjectiveCMethodNoArguments) { 2855 auto Results = completions(R"objc( 2856 @interface Foo 2857 @property(nonatomic, setter=setXToIgnoreComplete:) int value; 2858 @end 2859 Foo *foo = [Foo new]; int y = [foo v^] 2860 )objc", 2861 /*IndexSymbols=*/{}, 2862 /*Opts=*/{}, "Foo.m"); 2863 2864 auto C = Results.Completions; 2865 EXPECT_THAT(C, ElementsAre(Named("value"))); 2866 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2867 EXPECT_THAT(C, ElementsAre(ReturnType("int"))); 2868 EXPECT_THAT(C, ElementsAre(Signature(""))); 2869 EXPECT_THAT(C, ElementsAre(SnippetSuffix(""))); 2870 } 2871 2872 TEST(CompletionTest, ObjectiveCMethodOneArgument) { 2873 auto Results = completions(R"objc( 2874 @interface Foo 2875 - (int)valueForCharacter:(char)c; 2876 @end 2877 Foo *foo = [Foo new]; int y = [foo v^] 2878 )objc", 2879 /*IndexSymbols=*/{}, 2880 /*Opts=*/{}, "Foo.m"); 2881 2882 auto C = Results.Completions; 2883 EXPECT_THAT(C, ElementsAre(Named("valueForCharacter:"))); 2884 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2885 EXPECT_THAT(C, ElementsAre(ReturnType("int"))); 2886 EXPECT_THAT(C, ElementsAre(Signature("(char)"))); 2887 EXPECT_THAT(C, ElementsAre(SnippetSuffix("${1:(char)}"))); 2888 } 2889 2890 TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromBeginning) { 2891 auto Results = completions(R"objc( 2892 @interface Foo 2893 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey; 2894 @end 2895 id val = [Foo foo^] 2896 )objc", 2897 /*IndexSymbols=*/{}, 2898 /*Opts=*/{}, "Foo.m"); 2899 2900 auto C = Results.Completions; 2901 EXPECT_THAT(C, ElementsAre(Named("fooWithValue:"))); 2902 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2903 EXPECT_THAT(C, ElementsAre(ReturnType("id"))); 2904 EXPECT_THAT(C, ElementsAre(Signature("(int) fooey:(unsigned int)"))); 2905 EXPECT_THAT( 2906 C, ElementsAre(SnippetSuffix("${1:(int)} fooey:${2:(unsigned int)}"))); 2907 } 2908 2909 TEST(CompletionTest, ObjectiveCMethodTwoArgumentsFromMiddle) { 2910 auto Results = completions(R"objc( 2911 @interface Foo 2912 + (id)fooWithValue:(int)value fooey:(unsigned int)fooey; 2913 @end 2914 id val = [Foo fooWithValue:10 f^] 2915 )objc", 2916 /*IndexSymbols=*/{}, 2917 /*Opts=*/{}, "Foo.m"); 2918 2919 auto C = Results.Completions; 2920 EXPECT_THAT(C, ElementsAre(Named("fooey:"))); 2921 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2922 EXPECT_THAT(C, ElementsAre(ReturnType("id"))); 2923 EXPECT_THAT(C, ElementsAre(Signature("(unsigned int)"))); 2924 EXPECT_THAT(C, ElementsAre(SnippetSuffix("${1:(unsigned int)}"))); 2925 } 2926 2927 TEST(CompletionTest, ObjectiveCSimpleMethodDeclaration) { 2928 auto Results = completions(R"objc( 2929 @interface Foo 2930 - (void)foo; 2931 @end 2932 @implementation Foo 2933 fo^ 2934 @end 2935 )objc", 2936 /*IndexSymbols=*/{}, 2937 /*Opts=*/{}, "Foo.m"); 2938 2939 auto C = Results.Completions; 2940 EXPECT_THAT(C, ElementsAre(Named("foo"))); 2941 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2942 EXPECT_THAT(C, ElementsAre(Qualifier("- (void)"))); 2943 } 2944 2945 TEST(CompletionTest, ObjectiveCMethodDeclaration) { 2946 auto Results = completions(R"objc( 2947 @interface Foo 2948 - (int)valueForCharacter:(char)c secondArgument:(id)object; 2949 @end 2950 @implementation Foo 2951 valueFor^ 2952 @end 2953 )objc", 2954 /*IndexSymbols=*/{}, 2955 /*Opts=*/{}, "Foo.m"); 2956 2957 auto C = Results.Completions; 2958 EXPECT_THAT(C, ElementsAre(Named("valueForCharacter:"))); 2959 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2960 EXPECT_THAT(C, ElementsAre(Qualifier("- (int)"))); 2961 EXPECT_THAT(C, ElementsAre(Signature("(char)c secondArgument:(id)object"))); 2962 } 2963 2964 TEST(CompletionTest, ObjectiveCMethodDeclarationPrefixTyped) { 2965 auto Results = completions(R"objc( 2966 @interface Foo 2967 - (int)valueForCharacter:(char)c; 2968 @end 2969 @implementation Foo 2970 - (int)valueFor^ 2971 @end 2972 )objc", 2973 /*IndexSymbols=*/{}, 2974 /*Opts=*/{}, "Foo.m"); 2975 2976 auto C = Results.Completions; 2977 EXPECT_THAT(C, ElementsAre(Named("valueForCharacter:"))); 2978 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2979 EXPECT_THAT(C, ElementsAre(Signature("(char)c"))); 2980 } 2981 2982 TEST(CompletionTest, ObjectiveCMethodDeclarationFromMiddle) { 2983 auto Results = completions(R"objc( 2984 @interface Foo 2985 - (int)valueForCharacter:(char)c secondArgument:(id)object; 2986 @end 2987 @implementation Foo 2988 - (int)valueForCharacter:(char)c second^ 2989 @end 2990 )objc", 2991 /*IndexSymbols=*/{}, 2992 /*Opts=*/{}, "Foo.m"); 2993 2994 auto C = Results.Completions; 2995 EXPECT_THAT(C, ElementsAre(Named("secondArgument:"))); 2996 EXPECT_THAT(C, ElementsAre(Kind(CompletionItemKind::Method))); 2997 EXPECT_THAT(C, ElementsAre(Signature("(id)object"))); 2998 } 2999 3000 TEST(CompletionTest, CursorInSnippets) { 3001 clangd::CodeCompleteOptions Options; 3002 Options.EnableSnippets = true; 3003 auto Results = completions( 3004 R"cpp( 3005 void while_foo(int a, int b); 3006 void test() { 3007 whil^ 3008 })cpp", 3009 /*IndexSymbols=*/{}, Options); 3010 3011 // Last placeholder in code patterns should be $0 to put the cursor there. 3012 EXPECT_THAT(Results.Completions, 3013 Contains(AllOf( 3014 Named("while"), 3015 SnippetSuffix(" (${1:condition}) {\n${0:statements}\n}")))); 3016 // However, snippets for functions must *not* end with $0. 3017 EXPECT_THAT(Results.Completions, 3018 Contains(AllOf(Named("while_foo"), 3019 SnippetSuffix("(${1:int a}, ${2:int b})")))); 3020 } 3021 3022 TEST(CompletionTest, WorksWithNullType) { 3023 auto R = completions(R"cpp( 3024 int main() { 3025 for (auto [loopVar] : y ) { // y has to be unresolved. 3026 int z = loopV^; 3027 } 3028 } 3029 )cpp"); 3030 EXPECT_THAT(R.Completions, ElementsAre(Named("loopVar"))); 3031 } 3032 3033 TEST(CompletionTest, UsingDecl) { 3034 const char *Header(R"cpp( 3035 void foo(int); 3036 namespace std { 3037 using ::foo; 3038 })cpp"); 3039 const char *Source(R"cpp( 3040 void bar() { 3041 std::^; 3042 })cpp"); 3043 auto Index = TestTU::withHeaderCode(Header).index(); 3044 clangd::CodeCompleteOptions Opts; 3045 Opts.Index = Index.get(); 3046 Opts.AllScopes = true; 3047 auto R = completions(Source, {}, Opts); 3048 EXPECT_THAT(R.Completions, 3049 ElementsAre(AllOf(Scope("std::"), Named("foo"), 3050 Kind(CompletionItemKind::Reference)))); 3051 } 3052 3053 TEST(CompletionTest, ScopeIsUnresolved) { 3054 clangd::CodeCompleteOptions Opts = {}; 3055 Opts.AllScopes = true; 3056 3057 auto Results = completions(R"cpp( 3058 namespace a { 3059 void f() { b::X^ } 3060 } 3061 )cpp", 3062 {cls("a::b::XYZ")}, Opts); 3063 EXPECT_THAT(Results.Completions, 3064 UnorderedElementsAre(AllOf(Qualifier(""), Named("XYZ")))); 3065 } 3066 3067 TEST(CompletionTest, NestedScopeIsUnresolved) { 3068 clangd::CodeCompleteOptions Opts = {}; 3069 Opts.AllScopes = true; 3070 3071 auto Results = completions(R"cpp( 3072 namespace a { 3073 namespace b {} 3074 void f() { b::c::X^ } 3075 } 3076 )cpp", 3077 {cls("a::b::c::XYZ")}, Opts); 3078 EXPECT_THAT(Results.Completions, 3079 UnorderedElementsAre(AllOf(Qualifier(""), Named("XYZ")))); 3080 } 3081 3082 // Clang parser gets confused here and doesn't report the ns:: prefix. 3083 // Naive behavior is to insert it again. We examine the source and recover. 3084 TEST(CompletionTest, NamespaceDoubleInsertion) { 3085 clangd::CodeCompleteOptions Opts = {}; 3086 3087 auto Results = completions(R"cpp( 3088 namespace foo { 3089 namespace ns {} 3090 #define M(X) < X 3091 M(ns::ABC^ 3092 } 3093 )cpp", 3094 {cls("foo::ns::ABCDE")}, Opts); 3095 EXPECT_THAT(Results.Completions, 3096 UnorderedElementsAre(AllOf(Qualifier(""), Named("ABCDE")))); 3097 } 3098 3099 TEST(CompletionTest, DerivedMethodsAreAlwaysVisible) { 3100 // Despite the fact that base method matches the ref-qualifier better, 3101 // completion results should only include the derived method. 3102 auto Completions = completions(R"cpp( 3103 struct deque_base { 3104 float size(); 3105 double size() const; 3106 }; 3107 struct deque : deque_base { 3108 int size() const; 3109 }; 3110 3111 auto x = deque().^ 3112 )cpp") 3113 .Completions; 3114 EXPECT_THAT(Completions, 3115 ElementsAre(AllOf(ReturnType("int"), Named("size")))); 3116 } 3117 3118 TEST(CompletionTest, NoCrashWithIncompleteLambda) { 3119 auto Completions = completions("auto&& x = []{^").Completions; 3120 // The completion of x itself can cause a problem: in the code completion 3121 // callback, its type is not known, which affects the linkage calculation. 3122 // A bad linkage value gets cached, and subsequently updated. 3123 EXPECT_THAT(Completions, Contains(Named("x"))); 3124 3125 auto Signatures = signatures("auto x() { x(^").signatures; 3126 EXPECT_THAT(Signatures, Contains(Sig("x() -> auto"))); 3127 } 3128 3129 TEST(CompletionTest, DelayedTemplateParsing) { 3130 Annotations Test(R"cpp( 3131 int xxx; 3132 template <typename T> int foo() { return xx^; } 3133 )cpp"); 3134 auto TU = TestTU::withCode(Test.code()); 3135 // Even though delayed-template-parsing is on, we will disable it to provide 3136 // completion in templates. 3137 TU.ExtraArgs.push_back("-fdelayed-template-parsing"); 3138 3139 EXPECT_THAT(completions(TU, Test.point()).Completions, 3140 Contains(Named("xxx"))); 3141 } 3142 3143 TEST(CompletionTest, CompletionRange) { 3144 const char *WithRange = "auto x = [[abc]]^"; 3145 auto Completions = completions(WithRange); 3146 EXPECT_EQ(Completions.CompletionRange, Annotations(WithRange).range()); 3147 Completions = completionsNoCompile(WithRange); 3148 EXPECT_EQ(Completions.CompletionRange, Annotations(WithRange).range()); 3149 3150 const char *EmptyRange = "auto x = [[]]^"; 3151 Completions = completions(EmptyRange); 3152 EXPECT_EQ(Completions.CompletionRange, Annotations(EmptyRange).range()); 3153 Completions = completionsNoCompile(EmptyRange); 3154 EXPECT_EQ(Completions.CompletionRange, Annotations(EmptyRange).range()); 3155 3156 // Sema doesn't trigger at all here, while the no-sema completion runs 3157 // heuristics as normal and reports a range. It'd be nice to be consistent. 3158 const char *NoCompletion = "/* foo [[]]^ */"; 3159 Completions = completions(NoCompletion); 3160 EXPECT_EQ(Completions.CompletionRange, llvm::None); 3161 Completions = completionsNoCompile(NoCompletion); 3162 EXPECT_EQ(Completions.CompletionRange, Annotations(NoCompletion).range()); 3163 } 3164 3165 TEST(NoCompileCompletionTest, Basic) { 3166 auto Results = completionsNoCompile(R"cpp( 3167 void func() { 3168 int xyz; 3169 int abc; 3170 ^ 3171 } 3172 )cpp"); 3173 EXPECT_FALSE(Results.RanParser); 3174 EXPECT_THAT(Results.Completions, 3175 UnorderedElementsAre(Named("void"), Named("func"), Named("int"), 3176 Named("xyz"), Named("abc"))); 3177 } 3178 3179 TEST(NoCompileCompletionTest, WithFilter) { 3180 auto Results = completionsNoCompile(R"cpp( 3181 void func() { 3182 int sym1; 3183 int sym2; 3184 int xyz1; 3185 int xyz2; 3186 sy^ 3187 } 3188 )cpp"); 3189 EXPECT_THAT(Results.Completions, 3190 UnorderedElementsAre(Named("sym1"), Named("sym2"))); 3191 } 3192 3193 TEST(NoCompileCompletionTest, WithIndex) { 3194 std::vector<Symbol> Syms = {func("xxx"), func("a::xxx"), func("ns::b::xxx"), 3195 func("c::xxx"), func("ns::d::xxx")}; 3196 auto Results = completionsNoCompile( 3197 R"cpp( 3198 // Current-scopes, unqualified completion. 3199 using namespace a; 3200 namespace ns { 3201 using namespace b; 3202 void foo() { 3203 xx^ 3204 } 3205 } 3206 )cpp", 3207 Syms); 3208 EXPECT_THAT(Results.Completions, 3209 UnorderedElementsAre(AllOf(Qualifier(""), Scope("")), 3210 AllOf(Qualifier(""), Scope("a::")), 3211 AllOf(Qualifier(""), Scope("ns::b::")))); 3212 CodeCompleteOptions Opts; 3213 Opts.AllScopes = true; 3214 Results = completionsNoCompile( 3215 R"cpp( 3216 // All-scopes unqualified completion. 3217 using namespace a; 3218 namespace ns { 3219 using namespace b; 3220 void foo() { 3221 xx^ 3222 } 3223 } 3224 )cpp", 3225 Syms, Opts); 3226 EXPECT_THAT(Results.Completions, 3227 UnorderedElementsAre(AllOf(Qualifier(""), Scope("")), 3228 AllOf(Qualifier(""), Scope("a::")), 3229 AllOf(Qualifier(""), Scope("ns::b::")), 3230 AllOf(Qualifier("c::"), Scope("c::")), 3231 AllOf(Qualifier("d::"), Scope("ns::d::")))); 3232 Results = completionsNoCompile( 3233 R"cpp( 3234 // Qualified completion. 3235 using namespace a; 3236 namespace ns { 3237 using namespace b; 3238 void foo() { 3239 b::xx^ 3240 } 3241 } 3242 )cpp", 3243 Syms, Opts); 3244 EXPECT_THAT(Results.Completions, 3245 ElementsAre(AllOf(Qualifier(""), Scope("ns::b::")))); 3246 Results = completionsNoCompile( 3247 R"cpp( 3248 // Absolutely qualified completion. 3249 using namespace a; 3250 namespace ns { 3251 using namespace b; 3252 void foo() { 3253 ::a::xx^ 3254 } 3255 } 3256 )cpp", 3257 Syms, Opts); 3258 EXPECT_THAT(Results.Completions, 3259 ElementsAre(AllOf(Qualifier(""), Scope("a::")))); 3260 } 3261 3262 TEST(AllowImplicitCompletion, All) { 3263 const char *Yes[] = { 3264 "foo.^bar", 3265 "foo->^bar", 3266 "foo::^bar", 3267 " # include <^foo.h>", 3268 "#import <foo/^bar.h>", 3269 "#include_next \"^", 3270 }; 3271 const char *No[] = { 3272 "foo>^bar", 3273 "foo:^bar", 3274 "foo\n^bar", 3275 "#include <foo.h> //^", 3276 "#include \"foo.h\"^", 3277 "#error <^", 3278 "#<^", 3279 }; 3280 for (const char *Test : Yes) { 3281 llvm::Annotations A(Test); 3282 EXPECT_TRUE(allowImplicitCompletion(A.code(), A.point())) << Test; 3283 } 3284 for (const char *Test : No) { 3285 llvm::Annotations A(Test); 3286 EXPECT_FALSE(allowImplicitCompletion(A.code(), A.point())) << Test; 3287 } 3288 } 3289 3290 TEST(CompletionTest, FunctionArgsExist) { 3291 clangd::CodeCompleteOptions Opts; 3292 Opts.EnableSnippets = true; 3293 std::string Context = R"cpp( 3294 #define MACRO(x) 3295 int foo(int A); 3296 int bar(); 3297 struct Object { 3298 Object(int B) {} 3299 }; 3300 template <typename T> 3301 struct Container { 3302 Container(int Size) {} 3303 }; 3304 )cpp"; 3305 EXPECT_THAT(completions(Context + "int y = fo^", {}, Opts).Completions, 3306 UnorderedElementsAre( 3307 AllOf(Labeled("foo(int A)"), SnippetSuffix("(${1:int A})")))); 3308 EXPECT_THAT( 3309 completions(Context + "int y = fo^(42)", {}, Opts).Completions, 3310 UnorderedElementsAre(AllOf(Labeled("foo(int A)"), SnippetSuffix("")))); 3311 // FIXME(kirillbobyrev): No snippet should be produced here. 3312 EXPECT_THAT(completions(Context + "int y = fo^o(42)", {}, Opts).Completions, 3313 UnorderedElementsAre( 3314 AllOf(Labeled("foo(int A)"), SnippetSuffix("(${1:int A})")))); 3315 EXPECT_THAT( 3316 completions(Context + "int y = ba^", {}, Opts).Completions, 3317 UnorderedElementsAre(AllOf(Labeled("bar()"), SnippetSuffix("()")))); 3318 EXPECT_THAT(completions(Context + "int y = ba^()", {}, Opts).Completions, 3319 UnorderedElementsAre(AllOf(Labeled("bar()"), SnippetSuffix("")))); 3320 EXPECT_THAT( 3321 completions(Context + "Object o = Obj^", {}, Opts).Completions, 3322 Contains(AllOf(Labeled("Object(int B)"), SnippetSuffix("(${1:int B})"), 3323 Kind(CompletionItemKind::Constructor)))); 3324 EXPECT_THAT(completions(Context + "Object o = Obj^()", {}, Opts).Completions, 3325 Contains(AllOf(Labeled("Object(int B)"), SnippetSuffix(""), 3326 Kind(CompletionItemKind::Constructor)))); 3327 EXPECT_THAT( 3328 completions(Context + "Container c = Cont^", {}, Opts).Completions, 3329 Contains(AllOf(Labeled("Container<typename T>(int Size)"), 3330 SnippetSuffix("<${1:typename T}>(${2:int Size})"), 3331 Kind(CompletionItemKind::Constructor)))); 3332 EXPECT_THAT( 3333 completions(Context + "Container c = Cont^()", {}, Opts).Completions, 3334 Contains(AllOf(Labeled("Container<typename T>(int Size)"), 3335 SnippetSuffix("<${1:typename T}>"), 3336 Kind(CompletionItemKind::Constructor)))); 3337 EXPECT_THAT( 3338 completions(Context + "Container c = Cont^<int>()", {}, Opts).Completions, 3339 Contains(AllOf(Labeled("Container<typename T>(int Size)"), 3340 SnippetSuffix(""), 3341 Kind(CompletionItemKind::Constructor)))); 3342 EXPECT_THAT(completions(Context + "MAC^(2)", {}, Opts).Completions, 3343 Contains(AllOf(Labeled("MACRO(x)"), SnippetSuffix(""), 3344 Kind(CompletionItemKind::Text)))); 3345 } 3346 3347 TEST(CompletionTest, NoCrashDueToMacroOrdering) { 3348 EXPECT_THAT(completions(R"cpp( 3349 #define ECHO(X) X 3350 #define ECHO2(X) ECHO(X) 3351 int finish_preamble = EC^HO(2);)cpp") 3352 .Completions, 3353 UnorderedElementsAre(Labeled("ECHO(X)"), Labeled("ECHO2(X)"))); 3354 } 3355 3356 TEST(CompletionTest, ObjCCategoryDecls) { 3357 TestTU TU; 3358 TU.ExtraArgs.push_back("-xobjective-c"); 3359 TU.HeaderCode = R"objc( 3360 @interface Foo 3361 @end 3362 3363 @interface Foo (FooExt1) 3364 @end 3365 3366 @interface Foo (FooExt2) 3367 @end 3368 3369 @interface Bar 3370 @end 3371 3372 @interface Bar (BarExt) 3373 @end)objc"; 3374 3375 { 3376 Annotations Test(R"objc( 3377 @implementation Foo (^) 3378 @end 3379 )objc"); 3380 TU.Code = Test.code().str(); 3381 auto Results = completions(TU, Test.point()); 3382 EXPECT_THAT(Results.Completions, 3383 UnorderedElementsAre(Labeled("FooExt1"), Labeled("FooExt2"))); 3384 } 3385 { 3386 Annotations Test(R"objc( 3387 @interface Foo (^) 3388 @end 3389 )objc"); 3390 TU.Code = Test.code().str(); 3391 auto Results = completions(TU, Test.point()); 3392 EXPECT_THAT(Results.Completions, UnorderedElementsAre(Labeled("BarExt"))); 3393 } 3394 } 3395 3396 TEST(CompletionTest, PreambleCodeComplete) { 3397 llvm::StringLiteral Baseline = "\n#define MACRO 12\nint num = MACRO;"; 3398 llvm::StringLiteral ModifiedCC = 3399 "#include \"header.h\"\n#define MACRO 12\nint num = MACRO; int num2 = M^"; 3400 3401 Annotations Test(ModifiedCC); 3402 auto BaselineTU = TestTU::withCode(Baseline); 3403 auto ModifiedTU = TestTU::withCode(Test.code()); 3404 3405 MockFS FS; 3406 auto Inputs = ModifiedTU.inputs(FS); 3407 auto Result = codeComplete(testPath(ModifiedTU.Filename), Test.point(), 3408 BaselineTU.preamble().get(), Inputs, {}); 3409 EXPECT_THAT(Result.Completions, Not(testing::IsEmpty())); 3410 } 3411 3412 TEST(CompletionTest, CommentParamName) { 3413 clangd::CodeCompleteOptions Opts; 3414 const std::string Code = R"cpp( 3415 void fun(int foo, int bar); 3416 void overloaded(int param_int); 3417 void overloaded(int param_int, int param_other); 3418 void overloaded(char param_char); 3419 int main() { 3420 )cpp"; 3421 3422 EXPECT_THAT(completions(Code + "fun(/*^", {}, Opts).Completions, 3423 UnorderedElementsAre(Labeled("foo="))); 3424 EXPECT_THAT(completions(Code + "fun(1, /*^", {}, Opts).Completions, 3425 UnorderedElementsAre(Labeled("bar="))); 3426 EXPECT_THAT(completions(Code + "/*^", {}, Opts).Completions, IsEmpty()); 3427 // Test de-duplication. 3428 EXPECT_THAT( 3429 completions(Code + "overloaded(/*^", {}, Opts).Completions, 3430 UnorderedElementsAre(Labeled("param_int="), Labeled("param_char="))); 3431 // Comment already has some text in it. 3432 EXPECT_THAT(completions(Code + "fun(/* ^", {}, Opts).Completions, 3433 UnorderedElementsAre(Labeled("foo="))); 3434 EXPECT_THAT(completions(Code + "fun(/* f^", {}, Opts).Completions, 3435 UnorderedElementsAre(Labeled("foo="))); 3436 EXPECT_THAT(completions(Code + "fun(/* x^", {}, Opts).Completions, IsEmpty()); 3437 EXPECT_THAT(completions(Code + "fun(/* f ^", {}, Opts).Completions, 3438 IsEmpty()); 3439 } 3440 3441 TEST(SignatureHelp, DocFormat) { 3442 Annotations Code(R"cpp( 3443 // Comment `with` markup. 3444 void foo(int); 3445 void bar() { foo(^); } 3446 )cpp"); 3447 for (auto DocumentationFormat : 3448 {MarkupKind::PlainText, MarkupKind::Markdown}) { 3449 auto Sigs = signatures(Code.code(), Code.point(), /*IndexSymbols=*/{}, 3450 DocumentationFormat); 3451 ASSERT_EQ(Sigs.signatures.size(), 1U); 3452 EXPECT_EQ(Sigs.signatures[0].documentation.kind, DocumentationFormat); 3453 } 3454 } 3455 3456 } // namespace 3457 } // namespace clangd 3458 } // namespace clang 3459