1 // SPDX-License-Identifier: GPL-2.0 2 /* 3 * KCSAN test with various race scenarious to test runtime behaviour. Since the 4 * interface with which KCSAN's reports are obtained is via the console, this is 5 * the output we should verify. For each test case checks the presence (or 6 * absence) of generated reports. Relies on 'console' tracepoint to capture 7 * reports as they appear in the kernel log. 8 * 9 * Makes use of KUnit for test organization, and the Torture framework for test 10 * thread control. 11 * 12 * Copyright (C) 2020, Google LLC. 13 * Author: Marco Elver <[email protected]> 14 */ 15 16 #define pr_fmt(fmt) "kcsan_test: " fmt 17 18 #include <kunit/test.h> 19 #include <linux/jiffies.h> 20 #include <linux/kcsan-checks.h> 21 #include <linux/kernel.h> 22 #include <linux/sched.h> 23 #include <linux/seqlock.h> 24 #include <linux/spinlock.h> 25 #include <linux/string.h> 26 #include <linux/timer.h> 27 #include <linux/torture.h> 28 #include <linux/tracepoint.h> 29 #include <linux/types.h> 30 #include <trace/events/printk.h> 31 32 #define KCSAN_TEST_REQUIRES(test, cond) do { \ 33 if (!(cond)) \ 34 kunit_skip((test), "Test requires: " #cond); \ 35 } while (0) 36 37 #ifdef CONFIG_CC_HAS_TSAN_COMPOUND_READ_BEFORE_WRITE 38 #define __KCSAN_ACCESS_RW(alt) (KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE) 39 #else 40 #define __KCSAN_ACCESS_RW(alt) (alt) 41 #endif 42 43 /* Points to current test-case memory access "kernels". */ 44 static void (*access_kernels[2])(void); 45 46 static struct task_struct **threads; /* Lists of threads. */ 47 static unsigned long end_time; /* End time of test. */ 48 49 /* Report as observed from console. */ 50 static struct { 51 spinlock_t lock; 52 int nlines; 53 char lines[3][512]; 54 } observed = { 55 .lock = __SPIN_LOCK_UNLOCKED(observed.lock), 56 }; 57 58 /* Setup test checking loop. */ 59 static __no_kcsan inline void 60 begin_test_checks(void (*func1)(void), void (*func2)(void)) 61 { 62 kcsan_disable_current(); 63 64 /* 65 * Require at least as long as KCSAN_REPORT_ONCE_IN_MS, to ensure at 66 * least one race is reported. 67 */ 68 end_time = jiffies + msecs_to_jiffies(CONFIG_KCSAN_REPORT_ONCE_IN_MS + 500); 69 70 /* Signal start; release potential initialization of shared data. */ 71 smp_store_release(&access_kernels[0], func1); 72 smp_store_release(&access_kernels[1], func2); 73 } 74 75 /* End test checking loop. */ 76 static __no_kcsan inline bool 77 end_test_checks(bool stop) 78 { 79 if (!stop && time_before(jiffies, end_time)) { 80 /* Continue checking */ 81 might_sleep(); 82 return false; 83 } 84 85 kcsan_enable_current(); 86 return true; 87 } 88 89 /* 90 * Probe for console output: checks if a race was reported, and obtains observed 91 * lines of interest. 92 */ 93 __no_kcsan 94 static void probe_console(void *ignore, const char *buf, size_t len) 95 { 96 unsigned long flags; 97 int nlines; 98 99 /* 100 * Note that KCSAN reports under a global lock, so we do not risk the 101 * possibility of having multiple reports interleaved. If that were the 102 * case, we'd expect tests to fail. 103 */ 104 105 spin_lock_irqsave(&observed.lock, flags); 106 nlines = observed.nlines; 107 108 if (strnstr(buf, "BUG: KCSAN: ", len) && strnstr(buf, "test_", len)) { 109 /* 110 * KCSAN report and related to the test. 111 * 112 * The provided @buf is not NUL-terminated; copy no more than 113 * @len bytes and let strscpy() add the missing NUL-terminator. 114 */ 115 strscpy(observed.lines[0], buf, min(len + 1, sizeof(observed.lines[0]))); 116 nlines = 1; 117 } else if ((nlines == 1 || nlines == 2) && strnstr(buf, "bytes by", len)) { 118 strscpy(observed.lines[nlines++], buf, min(len + 1, sizeof(observed.lines[0]))); 119 120 if (strnstr(buf, "race at unknown origin", len)) { 121 if (WARN_ON(nlines != 2)) 122 goto out; 123 124 /* No second line of interest. */ 125 strcpy(observed.lines[nlines++], "<none>"); 126 } 127 } 128 129 out: 130 WRITE_ONCE(observed.nlines, nlines); /* Publish new nlines. */ 131 spin_unlock_irqrestore(&observed.lock, flags); 132 } 133 134 /* Check if a report related to the test exists. */ 135 __no_kcsan 136 static bool report_available(void) 137 { 138 return READ_ONCE(observed.nlines) == ARRAY_SIZE(observed.lines); 139 } 140 141 /* Report information we expect in a report. */ 142 struct expect_report { 143 /* Access information of both accesses. */ 144 struct { 145 void *fn; /* Function pointer to expected function of top frame. */ 146 void *addr; /* Address of access; unchecked if NULL. */ 147 size_t size; /* Size of access; unchecked if @addr is NULL. */ 148 int type; /* Access type, see KCSAN_ACCESS definitions. */ 149 } access[2]; 150 }; 151 152 /* Check observed report matches information in @r. */ 153 __no_kcsan 154 static bool report_matches(const struct expect_report *r) 155 { 156 const bool is_assert = (r->access[0].type | r->access[1].type) & KCSAN_ACCESS_ASSERT; 157 bool ret = false; 158 unsigned long flags; 159 typeof(observed.lines) expect; 160 const char *end; 161 char *cur; 162 int i; 163 164 /* Doubled-checked locking. */ 165 if (!report_available()) 166 return false; 167 168 /* Generate expected report contents. */ 169 170 /* Title */ 171 cur = expect[0]; 172 end = &expect[0][sizeof(expect[0]) - 1]; 173 cur += scnprintf(cur, end - cur, "BUG: KCSAN: %s in ", 174 is_assert ? "assert: race" : "data-race"); 175 if (r->access[1].fn) { 176 char tmp[2][64]; 177 int cmp; 178 179 /* Expect lexographically sorted function names in title. */ 180 scnprintf(tmp[0], sizeof(tmp[0]), "%pS", r->access[0].fn); 181 scnprintf(tmp[1], sizeof(tmp[1]), "%pS", r->access[1].fn); 182 cmp = strcmp(tmp[0], tmp[1]); 183 cur += scnprintf(cur, end - cur, "%ps / %ps", 184 cmp < 0 ? r->access[0].fn : r->access[1].fn, 185 cmp < 0 ? r->access[1].fn : r->access[0].fn); 186 } else { 187 scnprintf(cur, end - cur, "%pS", r->access[0].fn); 188 /* The exact offset won't match, remove it. */ 189 cur = strchr(expect[0], '+'); 190 if (cur) 191 *cur = '\0'; 192 } 193 194 /* Access 1 */ 195 cur = expect[1]; 196 end = &expect[1][sizeof(expect[1]) - 1]; 197 if (!r->access[1].fn) 198 cur += scnprintf(cur, end - cur, "race at unknown origin, with "); 199 200 /* Access 1 & 2 */ 201 for (i = 0; i < 2; ++i) { 202 const int ty = r->access[i].type; 203 const char *const access_type = 204 (ty & KCSAN_ACCESS_ASSERT) ? 205 ((ty & KCSAN_ACCESS_WRITE) ? 206 "assert no accesses" : 207 "assert no writes") : 208 ((ty & KCSAN_ACCESS_WRITE) ? 209 ((ty & KCSAN_ACCESS_COMPOUND) ? 210 "read-write" : 211 "write") : 212 "read"); 213 const char *const access_type_aux = 214 (ty & KCSAN_ACCESS_ATOMIC) ? 215 " (marked)" : 216 ((ty & KCSAN_ACCESS_SCOPED) ? " (scoped)" : ""); 217 218 if (i == 1) { 219 /* Access 2 */ 220 cur = expect[2]; 221 end = &expect[2][sizeof(expect[2]) - 1]; 222 223 if (!r->access[1].fn) { 224 /* Dummy string if no second access is available. */ 225 strcpy(cur, "<none>"); 226 break; 227 } 228 } 229 230 cur += scnprintf(cur, end - cur, "%s%s to ", access_type, 231 access_type_aux); 232 233 if (r->access[i].addr) /* Address is optional. */ 234 cur += scnprintf(cur, end - cur, "0x%px of %zu bytes", 235 r->access[i].addr, r->access[i].size); 236 } 237 238 spin_lock_irqsave(&observed.lock, flags); 239 if (!report_available()) 240 goto out; /* A new report is being captured. */ 241 242 /* Finally match expected output to what we actually observed. */ 243 ret = strstr(observed.lines[0], expect[0]) && 244 /* Access info may appear in any order. */ 245 ((strstr(observed.lines[1], expect[1]) && 246 strstr(observed.lines[2], expect[2])) || 247 (strstr(observed.lines[1], expect[2]) && 248 strstr(observed.lines[2], expect[1]))); 249 out: 250 spin_unlock_irqrestore(&observed.lock, flags); 251 return ret; 252 } 253 254 /* ===== Test kernels ===== */ 255 256 static long test_sink; 257 static long test_var; 258 /* @test_array should be large enough to fall into multiple watchpoint slots. */ 259 static long test_array[3 * PAGE_SIZE / sizeof(long)]; 260 static struct { 261 long val[8]; 262 } test_struct; 263 static DEFINE_SEQLOCK(test_seqlock); 264 265 /* 266 * Helper to avoid compiler optimizing out reads, and to generate source values 267 * for writes. 268 */ 269 __no_kcsan 270 static noinline void sink_value(long v) { WRITE_ONCE(test_sink, v); } 271 272 static noinline void test_kernel_read(void) { sink_value(test_var); } 273 274 static noinline void test_kernel_write(void) 275 { 276 test_var = READ_ONCE_NOCHECK(test_sink) + 1; 277 } 278 279 static noinline void test_kernel_write_nochange(void) { test_var = 42; } 280 281 /* Suffixed by value-change exception filter. */ 282 static noinline void test_kernel_write_nochange_rcu(void) { test_var = 42; } 283 284 static noinline void test_kernel_read_atomic(void) 285 { 286 sink_value(READ_ONCE(test_var)); 287 } 288 289 static noinline void test_kernel_write_atomic(void) 290 { 291 WRITE_ONCE(test_var, READ_ONCE_NOCHECK(test_sink) + 1); 292 } 293 294 static noinline void test_kernel_atomic_rmw(void) 295 { 296 /* Use builtin, so we can set up the "bad" atomic/non-atomic scenario. */ 297 __atomic_fetch_add(&test_var, 1, __ATOMIC_RELAXED); 298 } 299 300 __no_kcsan 301 static noinline void test_kernel_write_uninstrumented(void) { test_var++; } 302 303 static noinline void test_kernel_data_race(void) { data_race(test_var++); } 304 305 static noinline void test_kernel_assert_writer(void) 306 { 307 ASSERT_EXCLUSIVE_WRITER(test_var); 308 } 309 310 static noinline void test_kernel_assert_access(void) 311 { 312 ASSERT_EXCLUSIVE_ACCESS(test_var); 313 } 314 315 #define TEST_CHANGE_BITS 0xff00ff00 316 317 static noinline void test_kernel_change_bits(void) 318 { 319 if (IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)) { 320 /* 321 * Avoid race of unknown origin for this test, just pretend they 322 * are atomic. 323 */ 324 kcsan_nestable_atomic_begin(); 325 test_var ^= TEST_CHANGE_BITS; 326 kcsan_nestable_atomic_end(); 327 } else 328 WRITE_ONCE(test_var, READ_ONCE(test_var) ^ TEST_CHANGE_BITS); 329 } 330 331 static noinline void test_kernel_assert_bits_change(void) 332 { 333 ASSERT_EXCLUSIVE_BITS(test_var, TEST_CHANGE_BITS); 334 } 335 336 static noinline void test_kernel_assert_bits_nochange(void) 337 { 338 ASSERT_EXCLUSIVE_BITS(test_var, ~TEST_CHANGE_BITS); 339 } 340 341 /* To check that scoped assertions do trigger anywhere in scope. */ 342 static noinline void test_enter_scope(void) 343 { 344 int x = 0; 345 346 /* Unrelated accesses to scoped assert. */ 347 READ_ONCE(test_sink); 348 kcsan_check_read(&x, sizeof(x)); 349 } 350 351 static noinline void test_kernel_assert_writer_scoped(void) 352 { 353 ASSERT_EXCLUSIVE_WRITER_SCOPED(test_var); 354 test_enter_scope(); 355 } 356 357 static noinline void test_kernel_assert_access_scoped(void) 358 { 359 ASSERT_EXCLUSIVE_ACCESS_SCOPED(test_var); 360 test_enter_scope(); 361 } 362 363 static noinline void test_kernel_rmw_array(void) 364 { 365 int i; 366 367 for (i = 0; i < ARRAY_SIZE(test_array); ++i) 368 test_array[i]++; 369 } 370 371 static noinline void test_kernel_write_struct(void) 372 { 373 kcsan_check_write(&test_struct, sizeof(test_struct)); 374 kcsan_disable_current(); 375 test_struct.val[3]++; /* induce value change */ 376 kcsan_enable_current(); 377 } 378 379 static noinline void test_kernel_write_struct_part(void) 380 { 381 test_struct.val[3] = 42; 382 } 383 384 static noinline void test_kernel_read_struct_zero_size(void) 385 { 386 kcsan_check_read(&test_struct.val[3], 0); 387 } 388 389 static noinline void test_kernel_jiffies_reader(void) 390 { 391 sink_value((long)jiffies); 392 } 393 394 static noinline void test_kernel_seqlock_reader(void) 395 { 396 unsigned int seq; 397 398 do { 399 seq = read_seqbegin(&test_seqlock); 400 sink_value(test_var); 401 } while (read_seqretry(&test_seqlock, seq)); 402 } 403 404 static noinline void test_kernel_seqlock_writer(void) 405 { 406 unsigned long flags; 407 408 write_seqlock_irqsave(&test_seqlock, flags); 409 test_var++; 410 write_sequnlock_irqrestore(&test_seqlock, flags); 411 } 412 413 static noinline void test_kernel_atomic_builtins(void) 414 { 415 /* 416 * Generate concurrent accesses, expecting no reports, ensuring KCSAN 417 * treats builtin atomics as actually atomic. 418 */ 419 __atomic_load_n(&test_var, __ATOMIC_RELAXED); 420 } 421 422 static noinline void test_kernel_xor_1bit(void) 423 { 424 /* Do not report data races between the read-writes. */ 425 kcsan_nestable_atomic_begin(); 426 test_var ^= 0x10000; 427 kcsan_nestable_atomic_end(); 428 } 429 430 /* ===== Test cases ===== */ 431 432 /* Simple test with normal data race. */ 433 __no_kcsan 434 static void test_basic(struct kunit *test) 435 { 436 const struct expect_report expect = { 437 .access = { 438 { test_kernel_write, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 439 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 440 }, 441 }; 442 static const struct expect_report never = { 443 .access = { 444 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 445 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 446 }, 447 }; 448 bool match_expect = false; 449 bool match_never = false; 450 451 begin_test_checks(test_kernel_write, test_kernel_read); 452 do { 453 match_expect |= report_matches(&expect); 454 match_never = report_matches(&never); 455 } while (!end_test_checks(match_never)); 456 KUNIT_EXPECT_TRUE(test, match_expect); 457 KUNIT_EXPECT_FALSE(test, match_never); 458 } 459 460 /* 461 * Stress KCSAN with lots of concurrent races on different addresses until 462 * timeout. 463 */ 464 __no_kcsan 465 static void test_concurrent_races(struct kunit *test) 466 { 467 const struct expect_report expect = { 468 .access = { 469 /* NULL will match any address. */ 470 { test_kernel_rmw_array, NULL, 0, __KCSAN_ACCESS_RW(KCSAN_ACCESS_WRITE) }, 471 { test_kernel_rmw_array, NULL, 0, __KCSAN_ACCESS_RW(0) }, 472 }, 473 }; 474 static const struct expect_report never = { 475 .access = { 476 { test_kernel_rmw_array, NULL, 0, 0 }, 477 { test_kernel_rmw_array, NULL, 0, 0 }, 478 }, 479 }; 480 bool match_expect = false; 481 bool match_never = false; 482 483 begin_test_checks(test_kernel_rmw_array, test_kernel_rmw_array); 484 do { 485 match_expect |= report_matches(&expect); 486 match_never |= report_matches(&never); 487 } while (!end_test_checks(false)); 488 KUNIT_EXPECT_TRUE(test, match_expect); /* Sanity check matches exist. */ 489 KUNIT_EXPECT_FALSE(test, match_never); 490 } 491 492 /* Test the KCSAN_REPORT_VALUE_CHANGE_ONLY option. */ 493 __no_kcsan 494 static void test_novalue_change(struct kunit *test) 495 { 496 const struct expect_report expect = { 497 .access = { 498 { test_kernel_write_nochange, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 499 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 500 }, 501 }; 502 bool match_expect = false; 503 504 begin_test_checks(test_kernel_write_nochange, test_kernel_read); 505 do { 506 match_expect = report_matches(&expect); 507 } while (!end_test_checks(match_expect)); 508 if (IS_ENABLED(CONFIG_KCSAN_REPORT_VALUE_CHANGE_ONLY)) 509 KUNIT_EXPECT_FALSE(test, match_expect); 510 else 511 KUNIT_EXPECT_TRUE(test, match_expect); 512 } 513 514 /* 515 * Test that the rules where the KCSAN_REPORT_VALUE_CHANGE_ONLY option should 516 * never apply work. 517 */ 518 __no_kcsan 519 static void test_novalue_change_exception(struct kunit *test) 520 { 521 const struct expect_report expect = { 522 .access = { 523 { test_kernel_write_nochange_rcu, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 524 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 525 }, 526 }; 527 bool match_expect = false; 528 529 begin_test_checks(test_kernel_write_nochange_rcu, test_kernel_read); 530 do { 531 match_expect = report_matches(&expect); 532 } while (!end_test_checks(match_expect)); 533 KUNIT_EXPECT_TRUE(test, match_expect); 534 } 535 536 /* Test that data races of unknown origin are reported. */ 537 __no_kcsan 538 static void test_unknown_origin(struct kunit *test) 539 { 540 const struct expect_report expect = { 541 .access = { 542 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 543 { NULL }, 544 }, 545 }; 546 bool match_expect = false; 547 548 begin_test_checks(test_kernel_write_uninstrumented, test_kernel_read); 549 do { 550 match_expect = report_matches(&expect); 551 } while (!end_test_checks(match_expect)); 552 if (IS_ENABLED(CONFIG_KCSAN_REPORT_RACE_UNKNOWN_ORIGIN)) 553 KUNIT_EXPECT_TRUE(test, match_expect); 554 else 555 KUNIT_EXPECT_FALSE(test, match_expect); 556 } 557 558 /* Test KCSAN_ASSUME_PLAIN_WRITES_ATOMIC if it is selected. */ 559 __no_kcsan 560 static void test_write_write_assume_atomic(struct kunit *test) 561 { 562 const struct expect_report expect = { 563 .access = { 564 { test_kernel_write, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 565 { test_kernel_write, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 566 }, 567 }; 568 bool match_expect = false; 569 570 begin_test_checks(test_kernel_write, test_kernel_write); 571 do { 572 sink_value(READ_ONCE(test_var)); /* induce value-change */ 573 match_expect = report_matches(&expect); 574 } while (!end_test_checks(match_expect)); 575 if (IS_ENABLED(CONFIG_KCSAN_ASSUME_PLAIN_WRITES_ATOMIC)) 576 KUNIT_EXPECT_FALSE(test, match_expect); 577 else 578 KUNIT_EXPECT_TRUE(test, match_expect); 579 } 580 581 /* 582 * Test that data races with writes larger than word-size are always reported, 583 * even if KCSAN_ASSUME_PLAIN_WRITES_ATOMIC is selected. 584 */ 585 __no_kcsan 586 static void test_write_write_struct(struct kunit *test) 587 { 588 const struct expect_report expect = { 589 .access = { 590 { test_kernel_write_struct, &test_struct, sizeof(test_struct), KCSAN_ACCESS_WRITE }, 591 { test_kernel_write_struct, &test_struct, sizeof(test_struct), KCSAN_ACCESS_WRITE }, 592 }, 593 }; 594 bool match_expect = false; 595 596 begin_test_checks(test_kernel_write_struct, test_kernel_write_struct); 597 do { 598 match_expect = report_matches(&expect); 599 } while (!end_test_checks(match_expect)); 600 KUNIT_EXPECT_TRUE(test, match_expect); 601 } 602 603 /* 604 * Test that data races where only one write is larger than word-size are always 605 * reported, even if KCSAN_ASSUME_PLAIN_WRITES_ATOMIC is selected. 606 */ 607 __no_kcsan 608 static void test_write_write_struct_part(struct kunit *test) 609 { 610 const struct expect_report expect = { 611 .access = { 612 { test_kernel_write_struct, &test_struct, sizeof(test_struct), KCSAN_ACCESS_WRITE }, 613 { test_kernel_write_struct_part, &test_struct.val[3], sizeof(test_struct.val[3]), KCSAN_ACCESS_WRITE }, 614 }, 615 }; 616 bool match_expect = false; 617 618 begin_test_checks(test_kernel_write_struct, test_kernel_write_struct_part); 619 do { 620 match_expect = report_matches(&expect); 621 } while (!end_test_checks(match_expect)); 622 KUNIT_EXPECT_TRUE(test, match_expect); 623 } 624 625 /* Test that races with atomic accesses never result in reports. */ 626 __no_kcsan 627 static void test_read_atomic_write_atomic(struct kunit *test) 628 { 629 bool match_never = false; 630 631 begin_test_checks(test_kernel_read_atomic, test_kernel_write_atomic); 632 do { 633 match_never = report_available(); 634 } while (!end_test_checks(match_never)); 635 KUNIT_EXPECT_FALSE(test, match_never); 636 } 637 638 /* Test that a race with an atomic and plain access result in reports. */ 639 __no_kcsan 640 static void test_read_plain_atomic_write(struct kunit *test) 641 { 642 const struct expect_report expect = { 643 .access = { 644 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 645 { test_kernel_write_atomic, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC }, 646 }, 647 }; 648 bool match_expect = false; 649 650 KCSAN_TEST_REQUIRES(test, !IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)); 651 652 begin_test_checks(test_kernel_read, test_kernel_write_atomic); 653 do { 654 match_expect = report_matches(&expect); 655 } while (!end_test_checks(match_expect)); 656 KUNIT_EXPECT_TRUE(test, match_expect); 657 } 658 659 /* Test that atomic RMWs generate correct report. */ 660 __no_kcsan 661 static void test_read_plain_atomic_rmw(struct kunit *test) 662 { 663 const struct expect_report expect = { 664 .access = { 665 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 666 { test_kernel_atomic_rmw, &test_var, sizeof(test_var), 667 KCSAN_ACCESS_COMPOUND | KCSAN_ACCESS_WRITE | KCSAN_ACCESS_ATOMIC }, 668 }, 669 }; 670 bool match_expect = false; 671 672 KCSAN_TEST_REQUIRES(test, !IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS)); 673 674 begin_test_checks(test_kernel_read, test_kernel_atomic_rmw); 675 do { 676 match_expect = report_matches(&expect); 677 } while (!end_test_checks(match_expect)); 678 KUNIT_EXPECT_TRUE(test, match_expect); 679 } 680 681 /* Zero-sized accesses should never cause data race reports. */ 682 __no_kcsan 683 static void test_zero_size_access(struct kunit *test) 684 { 685 const struct expect_report expect = { 686 .access = { 687 { test_kernel_write_struct, &test_struct, sizeof(test_struct), KCSAN_ACCESS_WRITE }, 688 { test_kernel_write_struct, &test_struct, sizeof(test_struct), KCSAN_ACCESS_WRITE }, 689 }, 690 }; 691 const struct expect_report never = { 692 .access = { 693 { test_kernel_write_struct, &test_struct, sizeof(test_struct), KCSAN_ACCESS_WRITE }, 694 { test_kernel_read_struct_zero_size, &test_struct.val[3], 0, 0 }, 695 }, 696 }; 697 bool match_expect = false; 698 bool match_never = false; 699 700 begin_test_checks(test_kernel_write_struct, test_kernel_read_struct_zero_size); 701 do { 702 match_expect |= report_matches(&expect); 703 match_never = report_matches(&never); 704 } while (!end_test_checks(match_never)); 705 KUNIT_EXPECT_TRUE(test, match_expect); /* Sanity check. */ 706 KUNIT_EXPECT_FALSE(test, match_never); 707 } 708 709 /* Test the data_race() macro. */ 710 __no_kcsan 711 static void test_data_race(struct kunit *test) 712 { 713 bool match_never = false; 714 715 begin_test_checks(test_kernel_data_race, test_kernel_data_race); 716 do { 717 match_never = report_available(); 718 } while (!end_test_checks(match_never)); 719 KUNIT_EXPECT_FALSE(test, match_never); 720 } 721 722 __no_kcsan 723 static void test_assert_exclusive_writer(struct kunit *test) 724 { 725 const struct expect_report expect = { 726 .access = { 727 { test_kernel_assert_writer, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT }, 728 { test_kernel_write_nochange, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 729 }, 730 }; 731 bool match_expect = false; 732 733 begin_test_checks(test_kernel_assert_writer, test_kernel_write_nochange); 734 do { 735 match_expect = report_matches(&expect); 736 } while (!end_test_checks(match_expect)); 737 KUNIT_EXPECT_TRUE(test, match_expect); 738 } 739 740 __no_kcsan 741 static void test_assert_exclusive_access(struct kunit *test) 742 { 743 const struct expect_report expect = { 744 .access = { 745 { test_kernel_assert_access, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE }, 746 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 747 }, 748 }; 749 bool match_expect = false; 750 751 begin_test_checks(test_kernel_assert_access, test_kernel_read); 752 do { 753 match_expect = report_matches(&expect); 754 } while (!end_test_checks(match_expect)); 755 KUNIT_EXPECT_TRUE(test, match_expect); 756 } 757 758 __no_kcsan 759 static void test_assert_exclusive_access_writer(struct kunit *test) 760 { 761 const struct expect_report expect_access_writer = { 762 .access = { 763 { test_kernel_assert_access, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE }, 764 { test_kernel_assert_writer, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT }, 765 }, 766 }; 767 const struct expect_report expect_access_access = { 768 .access = { 769 { test_kernel_assert_access, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE }, 770 { test_kernel_assert_access, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE }, 771 }, 772 }; 773 const struct expect_report never = { 774 .access = { 775 { test_kernel_assert_writer, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT }, 776 { test_kernel_assert_writer, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT }, 777 }, 778 }; 779 bool match_expect_access_writer = false; 780 bool match_expect_access_access = false; 781 bool match_never = false; 782 783 begin_test_checks(test_kernel_assert_access, test_kernel_assert_writer); 784 do { 785 match_expect_access_writer |= report_matches(&expect_access_writer); 786 match_expect_access_access |= report_matches(&expect_access_access); 787 match_never |= report_matches(&never); 788 } while (!end_test_checks(match_never)); 789 KUNIT_EXPECT_TRUE(test, match_expect_access_writer); 790 KUNIT_EXPECT_TRUE(test, match_expect_access_access); 791 KUNIT_EXPECT_FALSE(test, match_never); 792 } 793 794 __no_kcsan 795 static void test_assert_exclusive_bits_change(struct kunit *test) 796 { 797 const struct expect_report expect = { 798 .access = { 799 { test_kernel_assert_bits_change, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT }, 800 { test_kernel_change_bits, &test_var, sizeof(test_var), 801 KCSAN_ACCESS_WRITE | (IS_ENABLED(CONFIG_KCSAN_IGNORE_ATOMICS) ? 0 : KCSAN_ACCESS_ATOMIC) }, 802 }, 803 }; 804 bool match_expect = false; 805 806 begin_test_checks(test_kernel_assert_bits_change, test_kernel_change_bits); 807 do { 808 match_expect = report_matches(&expect); 809 } while (!end_test_checks(match_expect)); 810 KUNIT_EXPECT_TRUE(test, match_expect); 811 } 812 813 __no_kcsan 814 static void test_assert_exclusive_bits_nochange(struct kunit *test) 815 { 816 bool match_never = false; 817 818 begin_test_checks(test_kernel_assert_bits_nochange, test_kernel_change_bits); 819 do { 820 match_never = report_available(); 821 } while (!end_test_checks(match_never)); 822 KUNIT_EXPECT_FALSE(test, match_never); 823 } 824 825 __no_kcsan 826 static void test_assert_exclusive_writer_scoped(struct kunit *test) 827 { 828 const struct expect_report expect_start = { 829 .access = { 830 { test_kernel_assert_writer_scoped, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_SCOPED }, 831 { test_kernel_write_nochange, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 832 }, 833 }; 834 const struct expect_report expect_anywhere = { 835 .access = { 836 { test_enter_scope, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_SCOPED }, 837 { test_kernel_write_nochange, &test_var, sizeof(test_var), KCSAN_ACCESS_WRITE }, 838 }, 839 }; 840 bool match_expect_start = false; 841 bool match_expect_anywhere = false; 842 843 begin_test_checks(test_kernel_assert_writer_scoped, test_kernel_write_nochange); 844 do { 845 match_expect_start |= report_matches(&expect_start); 846 match_expect_anywhere |= report_matches(&expect_anywhere); 847 } while (!end_test_checks(match_expect_start && match_expect_anywhere)); 848 KUNIT_EXPECT_TRUE(test, match_expect_start); 849 KUNIT_EXPECT_TRUE(test, match_expect_anywhere); 850 } 851 852 __no_kcsan 853 static void test_assert_exclusive_access_scoped(struct kunit *test) 854 { 855 const struct expect_report expect_start1 = { 856 .access = { 857 { test_kernel_assert_access_scoped, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE | KCSAN_ACCESS_SCOPED }, 858 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 859 }, 860 }; 861 const struct expect_report expect_start2 = { 862 .access = { expect_start1.access[0], expect_start1.access[0] }, 863 }; 864 const struct expect_report expect_inscope = { 865 .access = { 866 { test_enter_scope, &test_var, sizeof(test_var), KCSAN_ACCESS_ASSERT | KCSAN_ACCESS_WRITE | KCSAN_ACCESS_SCOPED }, 867 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 868 }, 869 }; 870 bool match_expect_start = false; 871 bool match_expect_inscope = false; 872 873 begin_test_checks(test_kernel_assert_access_scoped, test_kernel_read); 874 end_time += msecs_to_jiffies(1000); /* This test requires a bit more time. */ 875 do { 876 match_expect_start |= report_matches(&expect_start1) || report_matches(&expect_start2); 877 match_expect_inscope |= report_matches(&expect_inscope); 878 } while (!end_test_checks(match_expect_start && match_expect_inscope)); 879 KUNIT_EXPECT_TRUE(test, match_expect_start); 880 KUNIT_EXPECT_TRUE(test, match_expect_inscope); 881 } 882 883 /* 884 * jiffies is special (declared to be volatile) and its accesses are typically 885 * not marked; this test ensures that the compiler nor KCSAN gets confused about 886 * jiffies's declaration on different architectures. 887 */ 888 __no_kcsan 889 static void test_jiffies_noreport(struct kunit *test) 890 { 891 bool match_never = false; 892 893 begin_test_checks(test_kernel_jiffies_reader, test_kernel_jiffies_reader); 894 do { 895 match_never = report_available(); 896 } while (!end_test_checks(match_never)); 897 KUNIT_EXPECT_FALSE(test, match_never); 898 } 899 900 /* Test that racing accesses in seqlock critical sections are not reported. */ 901 __no_kcsan 902 static void test_seqlock_noreport(struct kunit *test) 903 { 904 bool match_never = false; 905 906 begin_test_checks(test_kernel_seqlock_reader, test_kernel_seqlock_writer); 907 do { 908 match_never = report_available(); 909 } while (!end_test_checks(match_never)); 910 KUNIT_EXPECT_FALSE(test, match_never); 911 } 912 913 /* 914 * Test atomic builtins work and required instrumentation functions exist. We 915 * also test that KCSAN understands they're atomic by racing with them via 916 * test_kernel_atomic_builtins(), and expect no reports. 917 * 918 * The atomic builtins _SHOULD NOT_ be used in normal kernel code! 919 */ 920 static void test_atomic_builtins(struct kunit *test) 921 { 922 bool match_never = false; 923 924 begin_test_checks(test_kernel_atomic_builtins, test_kernel_atomic_builtins); 925 do { 926 long tmp; 927 928 kcsan_enable_current(); 929 930 __atomic_store_n(&test_var, 42L, __ATOMIC_RELAXED); 931 KUNIT_EXPECT_EQ(test, 42L, __atomic_load_n(&test_var, __ATOMIC_RELAXED)); 932 933 KUNIT_EXPECT_EQ(test, 42L, __atomic_exchange_n(&test_var, 20, __ATOMIC_RELAXED)); 934 KUNIT_EXPECT_EQ(test, 20L, test_var); 935 936 tmp = 20L; 937 KUNIT_EXPECT_TRUE(test, __atomic_compare_exchange_n(&test_var, &tmp, 30L, 938 0, __ATOMIC_RELAXED, 939 __ATOMIC_RELAXED)); 940 KUNIT_EXPECT_EQ(test, tmp, 20L); 941 KUNIT_EXPECT_EQ(test, test_var, 30L); 942 KUNIT_EXPECT_FALSE(test, __atomic_compare_exchange_n(&test_var, &tmp, 40L, 943 1, __ATOMIC_RELAXED, 944 __ATOMIC_RELAXED)); 945 KUNIT_EXPECT_EQ(test, tmp, 30L); 946 KUNIT_EXPECT_EQ(test, test_var, 30L); 947 948 KUNIT_EXPECT_EQ(test, 30L, __atomic_fetch_add(&test_var, 1, __ATOMIC_RELAXED)); 949 KUNIT_EXPECT_EQ(test, 31L, __atomic_fetch_sub(&test_var, 1, __ATOMIC_RELAXED)); 950 KUNIT_EXPECT_EQ(test, 30L, __atomic_fetch_and(&test_var, 0xf, __ATOMIC_RELAXED)); 951 KUNIT_EXPECT_EQ(test, 14L, __atomic_fetch_xor(&test_var, 0xf, __ATOMIC_RELAXED)); 952 KUNIT_EXPECT_EQ(test, 1L, __atomic_fetch_or(&test_var, 0xf0, __ATOMIC_RELAXED)); 953 KUNIT_EXPECT_EQ(test, 241L, __atomic_fetch_nand(&test_var, 0xf, __ATOMIC_RELAXED)); 954 KUNIT_EXPECT_EQ(test, -2L, test_var); 955 956 __atomic_thread_fence(__ATOMIC_SEQ_CST); 957 __atomic_signal_fence(__ATOMIC_SEQ_CST); 958 959 kcsan_disable_current(); 960 961 match_never = report_available(); 962 } while (!end_test_checks(match_never)); 963 KUNIT_EXPECT_FALSE(test, match_never); 964 } 965 966 __no_kcsan 967 static void test_1bit_value_change(struct kunit *test) 968 { 969 const struct expect_report expect = { 970 .access = { 971 { test_kernel_read, &test_var, sizeof(test_var), 0 }, 972 { test_kernel_xor_1bit, &test_var, sizeof(test_var), __KCSAN_ACCESS_RW(KCSAN_ACCESS_WRITE) }, 973 }, 974 }; 975 bool match = false; 976 977 begin_test_checks(test_kernel_read, test_kernel_xor_1bit); 978 do { 979 match = IS_ENABLED(CONFIG_KCSAN_PERMISSIVE) 980 ? report_available() 981 : report_matches(&expect); 982 } while (!end_test_checks(match)); 983 if (IS_ENABLED(CONFIG_KCSAN_PERMISSIVE)) 984 KUNIT_EXPECT_FALSE(test, match); 985 else 986 KUNIT_EXPECT_TRUE(test, match); 987 } 988 989 /* 990 * Generate thread counts for all test cases. Values generated are in interval 991 * [2, 5] followed by exponentially increasing thread counts from 8 to 32. 992 * 993 * The thread counts are chosen to cover potentially interesting boundaries and 994 * corner cases (2 to 5), and then stress the system with larger counts. 995 */ 996 static const void *nthreads_gen_params(const void *prev, char *desc) 997 { 998 long nthreads = (long)prev; 999 1000 if (nthreads < 0 || nthreads >= 32) 1001 nthreads = 0; /* stop */ 1002 else if (!nthreads) 1003 nthreads = 2; /* initial value */ 1004 else if (nthreads < 5) 1005 nthreads++; 1006 else if (nthreads == 5) 1007 nthreads = 8; 1008 else 1009 nthreads *= 2; 1010 1011 if (!IS_ENABLED(CONFIG_PREEMPT) || !IS_ENABLED(CONFIG_KCSAN_INTERRUPT_WATCHER)) { 1012 /* 1013 * Without any preemption, keep 2 CPUs free for other tasks, one 1014 * of which is the main test case function checking for 1015 * completion or failure. 1016 */ 1017 const long min_unused_cpus = IS_ENABLED(CONFIG_PREEMPT_NONE) ? 2 : 0; 1018 const long min_required_cpus = 2 + min_unused_cpus; 1019 1020 if (num_online_cpus() < min_required_cpus) { 1021 pr_err_once("Too few online CPUs (%u < %ld) for test\n", 1022 num_online_cpus(), min_required_cpus); 1023 nthreads = 0; 1024 } else if (nthreads >= num_online_cpus() - min_unused_cpus) { 1025 /* Use negative value to indicate last param. */ 1026 nthreads = -(num_online_cpus() - min_unused_cpus); 1027 pr_warn_once("Limiting number of threads to %ld (only %d online CPUs)\n", 1028 -nthreads, num_online_cpus()); 1029 } 1030 } 1031 1032 snprintf(desc, KUNIT_PARAM_DESC_SIZE, "threads=%ld", abs(nthreads)); 1033 return (void *)nthreads; 1034 } 1035 1036 #define KCSAN_KUNIT_CASE(test_name) KUNIT_CASE_PARAM(test_name, nthreads_gen_params) 1037 static struct kunit_case kcsan_test_cases[] = { 1038 KCSAN_KUNIT_CASE(test_basic), 1039 KCSAN_KUNIT_CASE(test_concurrent_races), 1040 KCSAN_KUNIT_CASE(test_novalue_change), 1041 KCSAN_KUNIT_CASE(test_novalue_change_exception), 1042 KCSAN_KUNIT_CASE(test_unknown_origin), 1043 KCSAN_KUNIT_CASE(test_write_write_assume_atomic), 1044 KCSAN_KUNIT_CASE(test_write_write_struct), 1045 KCSAN_KUNIT_CASE(test_write_write_struct_part), 1046 KCSAN_KUNIT_CASE(test_read_atomic_write_atomic), 1047 KCSAN_KUNIT_CASE(test_read_plain_atomic_write), 1048 KCSAN_KUNIT_CASE(test_read_plain_atomic_rmw), 1049 KCSAN_KUNIT_CASE(test_zero_size_access), 1050 KCSAN_KUNIT_CASE(test_data_race), 1051 KCSAN_KUNIT_CASE(test_assert_exclusive_writer), 1052 KCSAN_KUNIT_CASE(test_assert_exclusive_access), 1053 KCSAN_KUNIT_CASE(test_assert_exclusive_access_writer), 1054 KCSAN_KUNIT_CASE(test_assert_exclusive_bits_change), 1055 KCSAN_KUNIT_CASE(test_assert_exclusive_bits_nochange), 1056 KCSAN_KUNIT_CASE(test_assert_exclusive_writer_scoped), 1057 KCSAN_KUNIT_CASE(test_assert_exclusive_access_scoped), 1058 KCSAN_KUNIT_CASE(test_jiffies_noreport), 1059 KCSAN_KUNIT_CASE(test_seqlock_noreport), 1060 KCSAN_KUNIT_CASE(test_atomic_builtins), 1061 KCSAN_KUNIT_CASE(test_1bit_value_change), 1062 {}, 1063 }; 1064 1065 /* ===== End test cases ===== */ 1066 1067 /* Concurrent accesses from interrupts. */ 1068 __no_kcsan 1069 static void access_thread_timer(struct timer_list *timer) 1070 { 1071 static atomic_t cnt = ATOMIC_INIT(0); 1072 unsigned int idx; 1073 void (*func)(void); 1074 1075 idx = (unsigned int)atomic_inc_return(&cnt) % ARRAY_SIZE(access_kernels); 1076 /* Acquire potential initialization. */ 1077 func = smp_load_acquire(&access_kernels[idx]); 1078 if (func) 1079 func(); 1080 } 1081 1082 /* The main loop for each thread. */ 1083 __no_kcsan 1084 static int access_thread(void *arg) 1085 { 1086 struct timer_list timer; 1087 unsigned int cnt = 0; 1088 unsigned int idx; 1089 void (*func)(void); 1090 1091 timer_setup_on_stack(&timer, access_thread_timer, 0); 1092 do { 1093 might_sleep(); 1094 1095 if (!timer_pending(&timer)) 1096 mod_timer(&timer, jiffies + 1); 1097 else { 1098 /* Iterate through all kernels. */ 1099 idx = cnt++ % ARRAY_SIZE(access_kernels); 1100 /* Acquire potential initialization. */ 1101 func = smp_load_acquire(&access_kernels[idx]); 1102 if (func) 1103 func(); 1104 } 1105 } while (!torture_must_stop()); 1106 del_timer_sync(&timer); 1107 destroy_timer_on_stack(&timer); 1108 1109 torture_kthread_stopping("access_thread"); 1110 return 0; 1111 } 1112 1113 __no_kcsan 1114 static int test_init(struct kunit *test) 1115 { 1116 unsigned long flags; 1117 int nthreads; 1118 int i; 1119 1120 spin_lock_irqsave(&observed.lock, flags); 1121 for (i = 0; i < ARRAY_SIZE(observed.lines); ++i) 1122 observed.lines[i][0] = '\0'; 1123 observed.nlines = 0; 1124 spin_unlock_irqrestore(&observed.lock, flags); 1125 1126 if (!torture_init_begin((char *)test->name, 1)) 1127 return -EBUSY; 1128 1129 if (WARN_ON(threads)) 1130 goto err; 1131 1132 for (i = 0; i < ARRAY_SIZE(access_kernels); ++i) { 1133 if (WARN_ON(access_kernels[i])) 1134 goto err; 1135 } 1136 1137 nthreads = abs((long)test->param_value); 1138 if (WARN_ON(!nthreads)) 1139 goto err; 1140 1141 threads = kcalloc(nthreads + 1, sizeof(struct task_struct *), GFP_KERNEL); 1142 if (WARN_ON(!threads)) 1143 goto err; 1144 1145 threads[nthreads] = NULL; 1146 for (i = 0; i < nthreads; ++i) { 1147 if (torture_create_kthread(access_thread, NULL, threads[i])) 1148 goto err; 1149 } 1150 1151 torture_init_end(); 1152 1153 return 0; 1154 1155 err: 1156 kfree(threads); 1157 threads = NULL; 1158 torture_init_end(); 1159 return -EINVAL; 1160 } 1161 1162 __no_kcsan 1163 static void test_exit(struct kunit *test) 1164 { 1165 struct task_struct **stop_thread; 1166 int i; 1167 1168 if (torture_cleanup_begin()) 1169 return; 1170 1171 for (i = 0; i < ARRAY_SIZE(access_kernels); ++i) 1172 WRITE_ONCE(access_kernels[i], NULL); 1173 1174 if (threads) { 1175 for (stop_thread = threads; *stop_thread; stop_thread++) 1176 torture_stop_kthread(reader_thread, *stop_thread); 1177 1178 kfree(threads); 1179 threads = NULL; 1180 } 1181 1182 torture_cleanup_end(); 1183 } 1184 1185 static struct kunit_suite kcsan_test_suite = { 1186 .name = "kcsan", 1187 .test_cases = kcsan_test_cases, 1188 .init = test_init, 1189 .exit = test_exit, 1190 }; 1191 static struct kunit_suite *kcsan_test_suites[] = { &kcsan_test_suite, NULL }; 1192 1193 __no_kcsan 1194 static void register_tracepoints(struct tracepoint *tp, void *ignore) 1195 { 1196 check_trace_callback_type_console(probe_console); 1197 if (!strcmp(tp->name, "console")) 1198 WARN_ON(tracepoint_probe_register(tp, probe_console, NULL)); 1199 } 1200 1201 __no_kcsan 1202 static void unregister_tracepoints(struct tracepoint *tp, void *ignore) 1203 { 1204 if (!strcmp(tp->name, "console")) 1205 tracepoint_probe_unregister(tp, probe_console, NULL); 1206 } 1207 1208 /* 1209 * We only want to do tracepoints setup and teardown once, therefore we have to 1210 * customize the init and exit functions and cannot rely on kunit_test_suite(). 1211 */ 1212 static int __init kcsan_test_init(void) 1213 { 1214 /* 1215 * Because we want to be able to build the test as a module, we need to 1216 * iterate through all known tracepoints, since the static registration 1217 * won't work here. 1218 */ 1219 for_each_kernel_tracepoint(register_tracepoints, NULL); 1220 return __kunit_test_suites_init(kcsan_test_suites); 1221 } 1222 1223 static void kcsan_test_exit(void) 1224 { 1225 __kunit_test_suites_exit(kcsan_test_suites); 1226 for_each_kernel_tracepoint(unregister_tracepoints, NULL); 1227 tracepoint_synchronize_unregister(); 1228 } 1229 1230 late_initcall_sync(kcsan_test_init); 1231 module_exit(kcsan_test_exit); 1232 1233 MODULE_LICENSE("GPL v2"); 1234 MODULE_AUTHOR("Marco Elver <[email protected]>"); 1235