1 /* Broadcom NetXtreme-C/E network driver.
2  *
3  * Copyright (c) 2017 Broadcom Limited
4  *
5  * This program is free software; you can redistribute it and/or modify
6  * it under the terms of the GNU General Public License as published by
7  * the Free Software Foundation.
8  */
9 
10 #include <linux/pci.h>
11 #include <linux/netdevice.h>
12 #include <linux/vmalloc.h>
13 #include <net/devlink.h>
14 #include <net/netdev_lock.h>
15 #include "bnxt_hsi.h"
16 #include "bnxt.h"
17 #include "bnxt_hwrm.h"
18 #include "bnxt_vfr.h"
19 #include "bnxt_devlink.h"
20 #include "bnxt_ethtool.h"
21 #include "bnxt_ulp.h"
22 #include "bnxt_ptp.h"
23 #include "bnxt_coredump.h"
24 #include "bnxt_nvm_defs.h"
25 
26 static void __bnxt_fw_recover(struct bnxt *bp)
27 {
28 	if (test_bit(BNXT_STATE_FW_FATAL_COND, &bp->state) ||
29 	    test_bit(BNXT_STATE_FW_NON_FATAL_COND, &bp->state))
30 		bnxt_fw_reset(bp);
31 	else
32 		bnxt_fw_exception(bp);
33 }
34 
35 static int
36 bnxt_dl_flash_update(struct devlink *dl,
37 		     struct devlink_flash_update_params *params,
38 		     struct netlink_ext_ack *extack)
39 {
40 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
41 	int rc;
42 
43 	if (!BNXT_PF(bp)) {
44 		NL_SET_ERR_MSG_MOD(extack,
45 				   "flash update not supported from a VF");
46 		return -EPERM;
47 	}
48 
49 	devlink_flash_update_status_notify(dl, "Preparing to flash", NULL, 0, 0);
50 	rc = bnxt_flash_package_from_fw_obj(bp->dev, params->fw, 0, extack);
51 	if (!rc)
52 		devlink_flash_update_status_notify(dl, "Flashing done", NULL, 0, 0);
53 	else
54 		devlink_flash_update_status_notify(dl, "Flashing failed", NULL, 0, 0);
55 	return rc;
56 }
57 
58 static int bnxt_hwrm_remote_dev_reset_set(struct bnxt *bp, bool remote_reset)
59 {
60 	struct hwrm_func_cfg_input *req;
61 	int rc;
62 
63 	if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET_IF)
64 		return -EOPNOTSUPP;
65 
66 	rc = bnxt_hwrm_func_cfg_short_req_init(bp, &req);
67 	if (rc)
68 		return rc;
69 
70 	req->fid = cpu_to_le16(0xffff);
71 	req->enables = cpu_to_le32(FUNC_CFG_REQ_ENABLES_HOT_RESET_IF_SUPPORT);
72 	if (remote_reset)
73 		req->flags = cpu_to_le32(FUNC_CFG_REQ_FLAGS_HOT_RESET_IF_EN_DIS);
74 
75 	return hwrm_req_send(bp, req);
76 }
77 
78 static char *bnxt_health_severity_str(enum bnxt_health_severity severity)
79 {
80 	switch (severity) {
81 	case SEVERITY_NORMAL: return "normal";
82 	case SEVERITY_WARNING: return "warning";
83 	case SEVERITY_RECOVERABLE: return "recoverable";
84 	case SEVERITY_FATAL: return "fatal";
85 	default: return "unknown";
86 	}
87 }
88 
89 static char *bnxt_health_remedy_str(enum bnxt_health_remedy remedy)
90 {
91 	switch (remedy) {
92 	case REMEDY_DEVLINK_RECOVER: return "devlink recover";
93 	case REMEDY_POWER_CYCLE_DEVICE: return "device power cycle";
94 	case REMEDY_POWER_CYCLE_HOST: return "host power cycle";
95 	case REMEDY_FW_UPDATE: return "update firmware";
96 	case REMEDY_HW_REPLACE: return "replace hardware";
97 	default: return "unknown";
98 	}
99 }
100 
101 static int bnxt_fw_diagnose(struct devlink_health_reporter *reporter,
102 			    struct devlink_fmsg *fmsg,
103 			    struct netlink_ext_ack *extack)
104 {
105 	struct bnxt *bp = devlink_health_reporter_priv(reporter);
106 	struct bnxt_fw_health *h = bp->fw_health;
107 	u32 fw_status, fw_resets;
108 
109 	if (test_bit(BNXT_STATE_IN_FW_RESET, &bp->state)) {
110 		devlink_fmsg_string_pair_put(fmsg, "Status", "recovering");
111 		return 0;
112 	}
113 
114 	if (!h->status_reliable) {
115 		devlink_fmsg_string_pair_put(fmsg, "Status", "unknown");
116 		return 0;
117 	}
118 
119 	mutex_lock(&h->lock);
120 	fw_status = bnxt_fw_health_readl(bp, BNXT_FW_HEALTH_REG);
121 	if (BNXT_FW_IS_BOOTING(fw_status)) {
122 		devlink_fmsg_string_pair_put(fmsg, "Status", "initializing");
123 	} else if (h->severity || fw_status != BNXT_FW_STATUS_HEALTHY) {
124 		if (!h->severity) {
125 			h->severity = SEVERITY_FATAL;
126 			h->remedy = REMEDY_POWER_CYCLE_DEVICE;
127 			h->diagnoses++;
128 			devlink_health_report(h->fw_reporter,
129 					      "FW error diagnosed", h);
130 		}
131 		devlink_fmsg_string_pair_put(fmsg, "Status", "error");
132 		devlink_fmsg_u32_pair_put(fmsg, "Syndrome", fw_status);
133 	} else {
134 		devlink_fmsg_string_pair_put(fmsg, "Status", "healthy");
135 	}
136 
137 	devlink_fmsg_string_pair_put(fmsg, "Severity",
138 				     bnxt_health_severity_str(h->severity));
139 
140 	if (h->severity) {
141 		devlink_fmsg_string_pair_put(fmsg, "Remedy",
142 					     bnxt_health_remedy_str(h->remedy));
143 		if (h->remedy == REMEDY_DEVLINK_RECOVER)
144 			devlink_fmsg_string_pair_put(fmsg, "Impact",
145 						     "traffic+ntuple_cfg");
146 	}
147 
148 	mutex_unlock(&h->lock);
149 	if (!h->resets_reliable)
150 		return 0;
151 
152 	fw_resets = bnxt_fw_health_readl(bp, BNXT_FW_RESET_CNT_REG);
153 	devlink_fmsg_u32_pair_put(fmsg, "Resets", fw_resets);
154 	devlink_fmsg_u32_pair_put(fmsg, "Arrests", h->arrests);
155 	devlink_fmsg_u32_pair_put(fmsg, "Survivals", h->survivals);
156 	devlink_fmsg_u32_pair_put(fmsg, "Discoveries", h->discoveries);
157 	devlink_fmsg_u32_pair_put(fmsg, "Fatalities", h->fatalities);
158 	devlink_fmsg_u32_pair_put(fmsg, "Diagnoses", h->diagnoses);
159 	return 0;
160 }
161 
162 static int bnxt_fw_dump(struct devlink_health_reporter *reporter,
163 			struct devlink_fmsg *fmsg, void *priv_ctx,
164 			struct netlink_ext_ack *extack)
165 {
166 	struct bnxt *bp = devlink_health_reporter_priv(reporter);
167 	u32 dump_len;
168 	void *data;
169 	int rc;
170 
171 	/* TODO: no firmware dump support in devlink_health_report() context */
172 	if (priv_ctx)
173 		return -EOPNOTSUPP;
174 
175 	dump_len = bnxt_get_coredump_length(bp, BNXT_DUMP_LIVE);
176 	if (!dump_len)
177 		return -EIO;
178 
179 	data = vmalloc(dump_len);
180 	if (!data)
181 		return -ENOMEM;
182 
183 	rc = bnxt_get_coredump(bp, BNXT_DUMP_LIVE, data, &dump_len);
184 	if (!rc) {
185 		devlink_fmsg_pair_nest_start(fmsg, "core");
186 		devlink_fmsg_binary_pair_put(fmsg, "data", data, dump_len);
187 		devlink_fmsg_u32_pair_put(fmsg, "size", dump_len);
188 		devlink_fmsg_pair_nest_end(fmsg);
189 	}
190 
191 	vfree(data);
192 	return rc;
193 }
194 
195 static int bnxt_fw_recover(struct devlink_health_reporter *reporter,
196 			   void *priv_ctx,
197 			   struct netlink_ext_ack *extack)
198 {
199 	struct bnxt *bp = devlink_health_reporter_priv(reporter);
200 
201 	if (bp->fw_health->severity == SEVERITY_FATAL)
202 		return -ENODEV;
203 
204 	set_bit(BNXT_STATE_RECOVER, &bp->state);
205 	__bnxt_fw_recover(bp);
206 
207 	return -EINPROGRESS;
208 }
209 
210 static const struct devlink_health_reporter_ops bnxt_dl_fw_reporter_ops = {
211 	.name = "fw",
212 	.diagnose = bnxt_fw_diagnose,
213 	.dump = bnxt_fw_dump,
214 	.recover = bnxt_fw_recover,
215 };
216 
217 static struct devlink_health_reporter *
218 __bnxt_dl_reporter_create(struct bnxt *bp,
219 			  const struct devlink_health_reporter_ops *ops)
220 {
221 	struct devlink_health_reporter *reporter;
222 
223 	reporter = devlink_health_reporter_create(bp->dl, ops, 0, bp);
224 	if (IS_ERR(reporter)) {
225 		netdev_warn(bp->dev, "Failed to create %s health reporter, rc = %ld\n",
226 			    ops->name, PTR_ERR(reporter));
227 		return NULL;
228 	}
229 
230 	return reporter;
231 }
232 
233 void bnxt_dl_fw_reporters_create(struct bnxt *bp)
234 {
235 	struct bnxt_fw_health *fw_health = bp->fw_health;
236 
237 	if (fw_health && !fw_health->fw_reporter)
238 		fw_health->fw_reporter = __bnxt_dl_reporter_create(bp, &bnxt_dl_fw_reporter_ops);
239 }
240 
241 void bnxt_dl_fw_reporters_destroy(struct bnxt *bp)
242 {
243 	struct bnxt_fw_health *fw_health = bp->fw_health;
244 
245 	if (fw_health && fw_health->fw_reporter) {
246 		devlink_health_reporter_destroy(fw_health->fw_reporter);
247 		fw_health->fw_reporter = NULL;
248 	}
249 }
250 
251 void bnxt_devlink_health_fw_report(struct bnxt *bp)
252 {
253 	struct bnxt_fw_health *fw_health = bp->fw_health;
254 	int rc;
255 
256 	if (!fw_health)
257 		return;
258 
259 	if (!fw_health->fw_reporter) {
260 		__bnxt_fw_recover(bp);
261 		return;
262 	}
263 
264 	mutex_lock(&fw_health->lock);
265 	fw_health->severity = SEVERITY_RECOVERABLE;
266 	fw_health->remedy = REMEDY_DEVLINK_RECOVER;
267 	mutex_unlock(&fw_health->lock);
268 	rc = devlink_health_report(fw_health->fw_reporter, "FW error reported",
269 				   fw_health);
270 	if (rc == -ECANCELED)
271 		__bnxt_fw_recover(bp);
272 }
273 
274 void bnxt_dl_health_fw_status_update(struct bnxt *bp, bool healthy)
275 {
276 	struct bnxt_fw_health *fw_health = bp->fw_health;
277 	u8 state;
278 
279 	mutex_lock(&fw_health->lock);
280 	if (healthy) {
281 		fw_health->severity = SEVERITY_NORMAL;
282 		state = DEVLINK_HEALTH_REPORTER_STATE_HEALTHY;
283 	} else {
284 		fw_health->severity = SEVERITY_FATAL;
285 		fw_health->remedy = REMEDY_POWER_CYCLE_DEVICE;
286 		state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
287 	}
288 	mutex_unlock(&fw_health->lock);
289 	devlink_health_reporter_state_update(fw_health->fw_reporter, state);
290 }
291 
292 void bnxt_dl_health_fw_recovery_done(struct bnxt *bp)
293 {
294 	struct bnxt_dl *dl = devlink_priv(bp->dl);
295 
296 	devlink_health_reporter_recovery_done(bp->fw_health->fw_reporter);
297 	bnxt_hwrm_remote_dev_reset_set(bp, dl->remote_reset);
298 }
299 
300 static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
301 			    struct netlink_ext_ack *extack);
302 
303 static void
304 bnxt_dl_livepatch_report_err(struct bnxt *bp, struct netlink_ext_ack *extack,
305 			     struct hwrm_fw_livepatch_output *resp)
306 {
307 	int err = ((struct hwrm_err_output *)resp)->cmd_err;
308 
309 	switch (err) {
310 	case FW_LIVEPATCH_CMD_ERR_CODE_INVALID_OPCODE:
311 		netdev_err(bp->dev, "Illegal live patch opcode");
312 		NL_SET_ERR_MSG_MOD(extack, "Invalid opcode");
313 		break;
314 	case FW_LIVEPATCH_CMD_ERR_CODE_NOT_SUPPORTED:
315 		NL_SET_ERR_MSG_MOD(extack, "Live patch operation not supported");
316 		break;
317 	case FW_LIVEPATCH_CMD_ERR_CODE_NOT_INSTALLED:
318 		NL_SET_ERR_MSG_MOD(extack, "Live patch not found");
319 		break;
320 	case FW_LIVEPATCH_CMD_ERR_CODE_NOT_PATCHED:
321 		NL_SET_ERR_MSG_MOD(extack,
322 				   "Live patch deactivation failed. Firmware not patched.");
323 		break;
324 	case FW_LIVEPATCH_CMD_ERR_CODE_AUTH_FAIL:
325 		NL_SET_ERR_MSG_MOD(extack, "Live patch not authenticated");
326 		break;
327 	case FW_LIVEPATCH_CMD_ERR_CODE_INVALID_HEADER:
328 		NL_SET_ERR_MSG_MOD(extack, "Incompatible live patch");
329 		break;
330 	case FW_LIVEPATCH_CMD_ERR_CODE_INVALID_SIZE:
331 		NL_SET_ERR_MSG_MOD(extack, "Live patch has invalid size");
332 		break;
333 	case FW_LIVEPATCH_CMD_ERR_CODE_ALREADY_PATCHED:
334 		NL_SET_ERR_MSG_MOD(extack, "Live patch already applied");
335 		break;
336 	default:
337 		netdev_err(bp->dev, "Unexpected live patch error: %d\n", err);
338 		NL_SET_ERR_MSG_MOD(extack, "Failed to activate live patch");
339 		break;
340 	}
341 }
342 
343 /* Live patch status in NVM */
344 #define BNXT_LIVEPATCH_NOT_INSTALLED	0
345 #define BNXT_LIVEPATCH_INSTALLED	FW_LIVEPATCH_QUERY_RESP_STATUS_FLAGS_INSTALL
346 #define BNXT_LIVEPATCH_REMOVED		FW_LIVEPATCH_QUERY_RESP_STATUS_FLAGS_ACTIVE
347 #define BNXT_LIVEPATCH_MASK		(FW_LIVEPATCH_QUERY_RESP_STATUS_FLAGS_INSTALL | \
348 					 FW_LIVEPATCH_QUERY_RESP_STATUS_FLAGS_ACTIVE)
349 #define BNXT_LIVEPATCH_ACTIVATED	BNXT_LIVEPATCH_MASK
350 
351 #define BNXT_LIVEPATCH_STATE(flags)	((flags) & BNXT_LIVEPATCH_MASK)
352 
353 static int
354 bnxt_dl_livepatch_activate(struct bnxt *bp, struct netlink_ext_ack *extack)
355 {
356 	struct hwrm_fw_livepatch_query_output *query_resp;
357 	struct hwrm_fw_livepatch_query_input *query_req;
358 	struct hwrm_fw_livepatch_output *patch_resp;
359 	struct hwrm_fw_livepatch_input *patch_req;
360 	u16 flags, live_patch_state;
361 	bool activated = false;
362 	u32 installed = 0;
363 	u8 target;
364 	int rc;
365 
366 	if (~bp->fw_cap & BNXT_FW_CAP_LIVEPATCH) {
367 		NL_SET_ERR_MSG_MOD(extack, "Device does not support live patch");
368 		return -EOPNOTSUPP;
369 	}
370 
371 	rc = hwrm_req_init(bp, query_req, HWRM_FW_LIVEPATCH_QUERY);
372 	if (rc)
373 		return rc;
374 	query_resp = hwrm_req_hold(bp, query_req);
375 
376 	rc = hwrm_req_init(bp, patch_req, HWRM_FW_LIVEPATCH);
377 	if (rc) {
378 		hwrm_req_drop(bp, query_req);
379 		return rc;
380 	}
381 	patch_req->loadtype = FW_LIVEPATCH_REQ_LOADTYPE_NVM_INSTALL;
382 	patch_resp = hwrm_req_hold(bp, patch_req);
383 
384 	for (target = 1; target <= FW_LIVEPATCH_REQ_FW_TARGET_LAST; target++) {
385 		query_req->fw_target = target;
386 		rc = hwrm_req_send(bp, query_req);
387 		if (rc) {
388 			NL_SET_ERR_MSG_MOD(extack, "Failed to query packages");
389 			break;
390 		}
391 
392 		flags = le16_to_cpu(query_resp->status_flags);
393 		live_patch_state = BNXT_LIVEPATCH_STATE(flags);
394 
395 		if (live_patch_state == BNXT_LIVEPATCH_NOT_INSTALLED)
396 			continue;
397 
398 		if (live_patch_state == BNXT_LIVEPATCH_ACTIVATED) {
399 			activated = true;
400 			continue;
401 		}
402 
403 		if (live_patch_state == BNXT_LIVEPATCH_INSTALLED)
404 			patch_req->opcode = FW_LIVEPATCH_REQ_OPCODE_ACTIVATE;
405 		else if (live_patch_state == BNXT_LIVEPATCH_REMOVED)
406 			patch_req->opcode = FW_LIVEPATCH_REQ_OPCODE_DEACTIVATE;
407 
408 		patch_req->fw_target = target;
409 		rc = hwrm_req_send(bp, patch_req);
410 		if (rc) {
411 			bnxt_dl_livepatch_report_err(bp, extack, patch_resp);
412 			break;
413 		}
414 		installed++;
415 	}
416 
417 	if (!rc && !installed) {
418 		if (activated) {
419 			NL_SET_ERR_MSG_MOD(extack, "Live patch already activated");
420 			rc = -EEXIST;
421 		} else {
422 			NL_SET_ERR_MSG_MOD(extack, "No live patches found");
423 			rc = -ENOENT;
424 		}
425 	}
426 	hwrm_req_drop(bp, query_req);
427 	hwrm_req_drop(bp, patch_req);
428 	return rc;
429 }
430 
431 static int bnxt_dl_reload_down(struct devlink *dl, bool netns_change,
432 			       enum devlink_reload_action action,
433 			       enum devlink_reload_limit limit,
434 			       struct netlink_ext_ack *extack)
435 {
436 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
437 	int rc = 0;
438 
439 	switch (action) {
440 	case DEVLINK_RELOAD_ACTION_DRIVER_REINIT: {
441 		bnxt_ulp_stop(bp);
442 		rtnl_lock();
443 		netdev_lock(bp->dev);
444 		if (bnxt_sriov_cfg(bp)) {
445 			NL_SET_ERR_MSG_MOD(extack,
446 					   "reload is unsupported while VFs are allocated or being configured");
447 			netdev_unlock(bp->dev);
448 			rtnl_unlock();
449 			bnxt_ulp_start(bp, 0);
450 			return -EOPNOTSUPP;
451 		}
452 		if (bp->dev->reg_state == NETREG_UNREGISTERED) {
453 			netdev_unlock(bp->dev);
454 			rtnl_unlock();
455 			bnxt_ulp_start(bp, 0);
456 			return -ENODEV;
457 		}
458 		if (netif_running(bp->dev))
459 			bnxt_close_nic(bp, true, true);
460 		bnxt_vf_reps_free(bp);
461 		rc = bnxt_hwrm_func_drv_unrgtr(bp);
462 		if (rc) {
463 			NL_SET_ERR_MSG_MOD(extack, "Failed to deregister");
464 			if (netif_running(bp->dev))
465 				netif_close(bp->dev);
466 			netdev_unlock(bp->dev);
467 			rtnl_unlock();
468 			break;
469 		}
470 		bnxt_cancel_reservations(bp, false);
471 		bnxt_free_ctx_mem(bp, false);
472 		break;
473 	}
474 	case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: {
475 		if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
476 			return bnxt_dl_livepatch_activate(bp, extack);
477 		if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET) {
478 			NL_SET_ERR_MSG_MOD(extack, "Device not capable, requires reboot");
479 			return -EOPNOTSUPP;
480 		}
481 		if (!bnxt_hwrm_reset_permitted(bp)) {
482 			NL_SET_ERR_MSG_MOD(extack,
483 					   "Reset denied by firmware, it may be inhibited by remote driver");
484 			return -EPERM;
485 		}
486 		rtnl_lock();
487 		netdev_lock(bp->dev);
488 		if (bp->dev->reg_state == NETREG_UNREGISTERED) {
489 			netdev_unlock(bp->dev);
490 			rtnl_unlock();
491 			return -ENODEV;
492 		}
493 		if (netif_running(bp->dev))
494 			set_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
495 		rc = bnxt_hwrm_firmware_reset(bp->dev,
496 					      FW_RESET_REQ_EMBEDDED_PROC_TYPE_CHIP,
497 					      FW_RESET_REQ_SELFRST_STATUS_SELFRSTASAP,
498 					      FW_RESET_REQ_FLAGS_RESET_GRACEFUL |
499 					      FW_RESET_REQ_FLAGS_FW_ACTIVATION);
500 		if (rc) {
501 			NL_SET_ERR_MSG_MOD(extack, "Failed to activate firmware");
502 			clear_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
503 			netdev_unlock(bp->dev);
504 			rtnl_unlock();
505 		}
506 		break;
507 	}
508 	default:
509 		rc = -EOPNOTSUPP;
510 	}
511 
512 	return rc;
513 }
514 
515 static int bnxt_dl_reload_up(struct devlink *dl, enum devlink_reload_action action,
516 			     enum devlink_reload_limit limit, u32 *actions_performed,
517 			     struct netlink_ext_ack *extack)
518 {
519 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
520 	int rc = 0;
521 
522 	netdev_assert_locked(bp->dev);
523 
524 	*actions_performed = 0;
525 	switch (action) {
526 	case DEVLINK_RELOAD_ACTION_DRIVER_REINIT: {
527 		bnxt_fw_init_one(bp);
528 		bnxt_vf_reps_alloc(bp);
529 		if (netif_running(bp->dev))
530 			rc = bnxt_open_nic(bp, true, true);
531 		if (!rc) {
532 			bnxt_reenable_sriov(bp);
533 			bnxt_ptp_reapply_pps(bp);
534 		}
535 		break;
536 	}
537 	case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: {
538 		unsigned long start = jiffies;
539 		unsigned long timeout = start + BNXT_DFLT_FW_RST_MAX_DSECS * HZ / 10;
540 
541 		if (limit == DEVLINK_RELOAD_LIMIT_NO_RESET)
542 			break;
543 		if (bp->fw_cap & BNXT_FW_CAP_ERROR_RECOVERY)
544 			timeout = start + bp->fw_health->normal_func_wait_dsecs * HZ / 10;
545 		if (!netif_running(bp->dev))
546 			NL_SET_ERR_MSG_MOD(extack,
547 					   "Device is closed, not waiting for reset notice that will never come");
548 		netdev_unlock(bp->dev);
549 		rtnl_unlock();
550 		while (test_bit(BNXT_STATE_FW_ACTIVATE, &bp->state)) {
551 			if (time_after(jiffies, timeout)) {
552 				NL_SET_ERR_MSG_MOD(extack, "Activation incomplete");
553 				rc = -ETIMEDOUT;
554 				break;
555 			}
556 			if (test_bit(BNXT_STATE_ABORT_ERR, &bp->state)) {
557 				NL_SET_ERR_MSG_MOD(extack, "Activation aborted");
558 				rc = -ENODEV;
559 				break;
560 			}
561 			msleep(50);
562 		}
563 		rtnl_lock();
564 		netdev_lock(bp->dev);
565 		if (!rc)
566 			*actions_performed |= BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT);
567 		clear_bit(BNXT_STATE_FW_ACTIVATE, &bp->state);
568 		break;
569 	}
570 	default:
571 		return -EOPNOTSUPP;
572 	}
573 
574 	if (!rc) {
575 		bnxt_print_device_info(bp);
576 		if (netif_running(bp->dev)) {
577 			mutex_lock(&bp->link_lock);
578 			bnxt_report_link(bp);
579 			mutex_unlock(&bp->link_lock);
580 		}
581 		*actions_performed |= BIT(action);
582 	} else if (netif_running(bp->dev)) {
583 		netif_close(bp->dev);
584 	}
585 	netdev_unlock(bp->dev);
586 	rtnl_unlock();
587 	if (action == DEVLINK_RELOAD_ACTION_DRIVER_REINIT)
588 		bnxt_ulp_start(bp, rc);
589 	return rc;
590 }
591 
592 static bool bnxt_nvm_test(struct bnxt *bp, struct netlink_ext_ack *extack)
593 {
594 	bool rc = false;
595 	u32 datalen;
596 	u16 index;
597 	u8 *buf;
598 
599 	if (bnxt_find_nvram_item(bp->dev, BNX_DIR_TYPE_VPD,
600 				 BNX_DIR_ORDINAL_FIRST, BNX_DIR_EXT_NONE,
601 				 &index, NULL, &datalen) || !datalen) {
602 		NL_SET_ERR_MSG_MOD(extack, "nvm test vpd entry error");
603 		return false;
604 	}
605 
606 	buf = kzalloc(datalen, GFP_KERNEL);
607 	if (!buf) {
608 		NL_SET_ERR_MSG_MOD(extack, "insufficient memory for nvm test");
609 		return false;
610 	}
611 
612 	if (bnxt_get_nvram_item(bp->dev, index, 0, datalen, buf)) {
613 		NL_SET_ERR_MSG_MOD(extack, "nvm test vpd read error");
614 		goto done;
615 	}
616 
617 	if (bnxt_flash_nvram(bp->dev, BNX_DIR_TYPE_VPD, BNX_DIR_ORDINAL_FIRST,
618 			     BNX_DIR_EXT_NONE, 0, 0, buf, datalen)) {
619 		NL_SET_ERR_MSG_MOD(extack, "nvm test vpd write error");
620 		goto done;
621 	}
622 
623 	rc = true;
624 
625 done:
626 	kfree(buf);
627 	return rc;
628 }
629 
630 static bool bnxt_dl_selftest_check(struct devlink *dl, unsigned int id,
631 				   struct netlink_ext_ack *extack)
632 {
633 	return id == DEVLINK_ATTR_SELFTEST_ID_FLASH;
634 }
635 
636 static enum devlink_selftest_status bnxt_dl_selftest_run(struct devlink *dl,
637 							 unsigned int id,
638 							 struct netlink_ext_ack *extack)
639 {
640 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
641 
642 	if (id == DEVLINK_ATTR_SELFTEST_ID_FLASH)
643 		return bnxt_nvm_test(bp, extack) ?
644 				DEVLINK_SELFTEST_STATUS_PASS :
645 				DEVLINK_SELFTEST_STATUS_FAIL;
646 
647 	return DEVLINK_SELFTEST_STATUS_SKIP;
648 }
649 
650 static const struct devlink_ops bnxt_dl_ops = {
651 #ifdef CONFIG_BNXT_SRIOV
652 	.eswitch_mode_set = bnxt_dl_eswitch_mode_set,
653 	.eswitch_mode_get = bnxt_dl_eswitch_mode_get,
654 #endif /* CONFIG_BNXT_SRIOV */
655 	.info_get	  = bnxt_dl_info_get,
656 	.flash_update	  = bnxt_dl_flash_update,
657 	.reload_actions	  = BIT(DEVLINK_RELOAD_ACTION_DRIVER_REINIT) |
658 			    BIT(DEVLINK_RELOAD_ACTION_FW_ACTIVATE),
659 	.reload_limits	  = BIT(DEVLINK_RELOAD_LIMIT_NO_RESET),
660 	.reload_down	  = bnxt_dl_reload_down,
661 	.reload_up	  = bnxt_dl_reload_up,
662 	.selftest_check	  = bnxt_dl_selftest_check,
663 	.selftest_run	  = bnxt_dl_selftest_run,
664 };
665 
666 static const struct devlink_ops bnxt_vf_dl_ops;
667 
668 enum bnxt_dl_param_id {
669 	BNXT_DEVLINK_PARAM_ID_BASE = DEVLINK_PARAM_GENERIC_ID_MAX,
670 	BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK,
671 };
672 
673 static const struct bnxt_dl_nvm_param nvm_params[] = {
674 	{DEVLINK_PARAM_GENERIC_ID_ENABLE_SRIOV, NVM_OFF_ENABLE_SRIOV,
675 	 BNXT_NVM_SHARED_CFG, 1, 1},
676 	{DEVLINK_PARAM_GENERIC_ID_IGNORE_ARI, NVM_OFF_IGNORE_ARI,
677 	 BNXT_NVM_SHARED_CFG, 1, 1},
678 	{DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX,
679 	 NVM_OFF_MSIX_VEC_PER_PF_MAX, BNXT_NVM_SHARED_CFG, 10, 4},
680 	{DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN,
681 	 NVM_OFF_MSIX_VEC_PER_PF_MIN, BNXT_NVM_SHARED_CFG, 7, 4},
682 	{BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK, NVM_OFF_DIS_GRE_VER_CHECK,
683 	 BNXT_NVM_SHARED_CFG, 1, 1},
684 };
685 
686 union bnxt_nvm_data {
687 	u8	val8;
688 	__le32	val32;
689 };
690 
691 static void bnxt_copy_to_nvm_data(union bnxt_nvm_data *dst,
692 				  union devlink_param_value *src,
693 				  int nvm_num_bits, int dl_num_bytes)
694 {
695 	u32 val32 = 0;
696 
697 	if (nvm_num_bits == 1) {
698 		dst->val8 = src->vbool;
699 		return;
700 	}
701 	if (dl_num_bytes == 4)
702 		val32 = src->vu32;
703 	else if (dl_num_bytes == 2)
704 		val32 = (u32)src->vu16;
705 	else if (dl_num_bytes == 1)
706 		val32 = (u32)src->vu8;
707 	dst->val32 = cpu_to_le32(val32);
708 }
709 
710 static void bnxt_copy_from_nvm_data(union devlink_param_value *dst,
711 				    union bnxt_nvm_data *src,
712 				    int nvm_num_bits, int dl_num_bytes)
713 {
714 	u32 val32;
715 
716 	if (nvm_num_bits == 1) {
717 		dst->vbool = src->val8;
718 		return;
719 	}
720 	val32 = le32_to_cpu(src->val32);
721 	if (dl_num_bytes == 4)
722 		dst->vu32 = val32;
723 	else if (dl_num_bytes == 2)
724 		dst->vu16 = (u16)val32;
725 	else if (dl_num_bytes == 1)
726 		dst->vu8 = (u8)val32;
727 }
728 
729 static int bnxt_hwrm_get_nvm_cfg_ver(struct bnxt *bp, u32 *nvm_cfg_ver)
730 {
731 	struct hwrm_nvm_get_variable_input *req;
732 	u16 bytes = BNXT_NVM_CFG_VER_BYTES;
733 	u16 bits = BNXT_NVM_CFG_VER_BITS;
734 	union devlink_param_value ver;
735 	union bnxt_nvm_data *data;
736 	dma_addr_t data_dma_addr;
737 	int rc, i = 2;
738 	u16 dim = 1;
739 
740 	rc = hwrm_req_init(bp, req, HWRM_NVM_GET_VARIABLE);
741 	if (rc)
742 		return rc;
743 
744 	data = hwrm_req_dma_slice(bp, req, sizeof(*data), &data_dma_addr);
745 	if (!data) {
746 		rc = -ENOMEM;
747 		goto exit;
748 	}
749 
750 	/* earlier devices present as an array of raw bytes */
751 	if (!BNXT_CHIP_P5_PLUS(bp)) {
752 		dim = 0;
753 		i = 0;
754 		bits *= 3;  /* array of 3 version components */
755 		bytes *= 4; /* copy whole word */
756 	}
757 
758 	hwrm_req_hold(bp, req);
759 	req->dest_data_addr = cpu_to_le64(data_dma_addr);
760 	req->data_len = cpu_to_le16(bits);
761 	req->option_num = cpu_to_le16(NVM_OFF_NVM_CFG_VER);
762 	req->dimensions = cpu_to_le16(dim);
763 
764 	while (i >= 0) {
765 		req->index_0 = cpu_to_le16(i--);
766 		rc = hwrm_req_send_silent(bp, req);
767 		if (rc)
768 			goto exit;
769 		bnxt_copy_from_nvm_data(&ver, data, bits, bytes);
770 
771 		if (BNXT_CHIP_P5_PLUS(bp)) {
772 			*nvm_cfg_ver <<= 8;
773 			*nvm_cfg_ver |= ver.vu8;
774 		} else {
775 			*nvm_cfg_ver = ver.vu32;
776 		}
777 	}
778 
779 exit:
780 	hwrm_req_drop(bp, req);
781 	return rc;
782 }
783 
784 static int bnxt_dl_info_put(struct bnxt *bp, struct devlink_info_req *req,
785 			    enum bnxt_dl_version_type type, const char *key,
786 			    char *buf)
787 {
788 	if (!strlen(buf))
789 		return 0;
790 
791 	if ((bp->flags & BNXT_FLAG_CHIP_P5_PLUS) &&
792 	    (!strcmp(key, DEVLINK_INFO_VERSION_GENERIC_FW_NCSI) ||
793 	     !strcmp(key, DEVLINK_INFO_VERSION_GENERIC_FW_ROCE)))
794 		return 0;
795 
796 	switch (type) {
797 	case BNXT_VERSION_FIXED:
798 		return devlink_info_version_fixed_put(req, key, buf);
799 	case BNXT_VERSION_RUNNING:
800 		return devlink_info_version_running_put(req, key, buf);
801 	case BNXT_VERSION_STORED:
802 		return devlink_info_version_stored_put(req, key, buf);
803 	}
804 	return 0;
805 }
806 
807 #define BNXT_FW_SRT_PATCH	"fw.srt.patch"
808 #define BNXT_FW_CRT_PATCH	"fw.crt.patch"
809 
810 static int bnxt_dl_livepatch_info_put(struct bnxt *bp,
811 				      struct devlink_info_req *req,
812 				      const char *key)
813 {
814 	struct hwrm_fw_livepatch_query_input *query;
815 	struct hwrm_fw_livepatch_query_output *resp;
816 	u16 flags;
817 	int rc;
818 
819 	if (~bp->fw_cap & BNXT_FW_CAP_LIVEPATCH)
820 		return 0;
821 
822 	rc = hwrm_req_init(bp, query, HWRM_FW_LIVEPATCH_QUERY);
823 	if (rc)
824 		return rc;
825 
826 	if (!strcmp(key, BNXT_FW_SRT_PATCH))
827 		query->fw_target = FW_LIVEPATCH_QUERY_REQ_FW_TARGET_SECURE_FW;
828 	else if (!strcmp(key, BNXT_FW_CRT_PATCH))
829 		query->fw_target = FW_LIVEPATCH_QUERY_REQ_FW_TARGET_COMMON_FW;
830 	else
831 		goto exit;
832 
833 	resp = hwrm_req_hold(bp, query);
834 	rc = hwrm_req_send(bp, query);
835 	if (rc)
836 		goto exit;
837 
838 	flags = le16_to_cpu(resp->status_flags);
839 	if (flags & FW_LIVEPATCH_QUERY_RESP_STATUS_FLAGS_ACTIVE) {
840 		resp->active_ver[sizeof(resp->active_ver) - 1] = '\0';
841 		rc = devlink_info_version_running_put(req, key, resp->active_ver);
842 		if (rc)
843 			goto exit;
844 	}
845 
846 	if (flags & FW_LIVEPATCH_QUERY_RESP_STATUS_FLAGS_INSTALL) {
847 		resp->install_ver[sizeof(resp->install_ver) - 1] = '\0';
848 		rc = devlink_info_version_stored_put(req, key, resp->install_ver);
849 		if (rc)
850 			goto exit;
851 	}
852 
853 exit:
854 	hwrm_req_drop(bp, query);
855 	return rc;
856 }
857 
858 #define HWRM_FW_VER_STR_LEN	16
859 
860 static int bnxt_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
861 			    struct netlink_ext_ack *extack)
862 {
863 	struct hwrm_nvm_get_dev_info_output nvm_dev_info;
864 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
865 	struct hwrm_ver_get_output *ver_resp;
866 	char mgmt_ver[FW_VER_STR_LEN];
867 	char roce_ver[FW_VER_STR_LEN];
868 	char ncsi_ver[FW_VER_STR_LEN];
869 	char buf[32];
870 	u32 ver = 0;
871 	int rc;
872 
873 	if (BNXT_PF(bp) && (bp->flags & BNXT_FLAG_DSN_VALID)) {
874 		sprintf(buf, "%02X-%02X-%02X-%02X-%02X-%02X-%02X-%02X",
875 			bp->dsn[7], bp->dsn[6], bp->dsn[5], bp->dsn[4],
876 			bp->dsn[3], bp->dsn[2], bp->dsn[1], bp->dsn[0]);
877 		rc = devlink_info_serial_number_put(req, buf);
878 		if (rc)
879 			return rc;
880 	}
881 
882 	if (strlen(bp->board_serialno)) {
883 		rc = devlink_info_board_serial_number_put(req, bp->board_serialno);
884 		if (rc)
885 			return rc;
886 	}
887 
888 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_FIXED,
889 			      DEVLINK_INFO_VERSION_GENERIC_BOARD_ID,
890 			      bp->board_partno);
891 	if (rc)
892 		return rc;
893 
894 	sprintf(buf, "%X", bp->chip_num);
895 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_FIXED,
896 			      DEVLINK_INFO_VERSION_GENERIC_ASIC_ID, buf);
897 	if (rc)
898 		return rc;
899 
900 	ver_resp = &bp->ver_resp;
901 	sprintf(buf, "%c%d", 'A' + ver_resp->chip_rev, ver_resp->chip_metal);
902 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_FIXED,
903 			      DEVLINK_INFO_VERSION_GENERIC_ASIC_REV, buf);
904 	if (rc)
905 		return rc;
906 
907 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_RUNNING,
908 			      DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
909 			      bp->nvm_cfg_ver);
910 	if (rc)
911 		return rc;
912 
913 	buf[0] = 0;
914 	strncat(buf, ver_resp->active_pkg_name, HWRM_FW_VER_STR_LEN);
915 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_RUNNING,
916 			      DEVLINK_INFO_VERSION_GENERIC_FW, buf);
917 	if (rc)
918 		return rc;
919 
920 	if (BNXT_PF(bp) && !bnxt_hwrm_get_nvm_cfg_ver(bp, &ver)) {
921 		sprintf(buf, "%d.%d.%d", (ver >> 16) & 0xff, (ver >> 8) & 0xff,
922 			ver & 0xff);
923 		rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
924 				      DEVLINK_INFO_VERSION_GENERIC_FW_PSID,
925 				      buf);
926 		if (rc)
927 			return rc;
928 	}
929 
930 	if (ver_resp->flags & VER_GET_RESP_FLAGS_EXT_VER_AVAIL) {
931 		snprintf(mgmt_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
932 			 ver_resp->hwrm_fw_major, ver_resp->hwrm_fw_minor,
933 			 ver_resp->hwrm_fw_build, ver_resp->hwrm_fw_patch);
934 
935 		snprintf(ncsi_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
936 			 ver_resp->mgmt_fw_major, ver_resp->mgmt_fw_minor,
937 			 ver_resp->mgmt_fw_build, ver_resp->mgmt_fw_patch);
938 
939 		snprintf(roce_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
940 			 ver_resp->roce_fw_major, ver_resp->roce_fw_minor,
941 			 ver_resp->roce_fw_build, ver_resp->roce_fw_patch);
942 	} else {
943 		snprintf(mgmt_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
944 			 ver_resp->hwrm_fw_maj_8b, ver_resp->hwrm_fw_min_8b,
945 			 ver_resp->hwrm_fw_bld_8b, ver_resp->hwrm_fw_rsvd_8b);
946 
947 		snprintf(ncsi_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
948 			 ver_resp->mgmt_fw_maj_8b, ver_resp->mgmt_fw_min_8b,
949 			 ver_resp->mgmt_fw_bld_8b, ver_resp->mgmt_fw_rsvd_8b);
950 
951 		snprintf(roce_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
952 			 ver_resp->roce_fw_maj_8b, ver_resp->roce_fw_min_8b,
953 			 ver_resp->roce_fw_bld_8b, ver_resp->roce_fw_rsvd_8b);
954 	}
955 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_RUNNING,
956 			      DEVLINK_INFO_VERSION_GENERIC_FW_MGMT, mgmt_ver);
957 	if (rc)
958 		return rc;
959 
960 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_RUNNING,
961 			      DEVLINK_INFO_VERSION_GENERIC_FW_MGMT_API,
962 			      bp->hwrm_ver_supp);
963 	if (rc)
964 		return rc;
965 
966 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_RUNNING,
967 			      DEVLINK_INFO_VERSION_GENERIC_FW_NCSI, ncsi_ver);
968 	if (rc)
969 		return rc;
970 
971 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_RUNNING,
972 			      DEVLINK_INFO_VERSION_GENERIC_FW_ROCE, roce_ver);
973 	if (rc)
974 		return rc;
975 
976 	rc = bnxt_hwrm_nvm_get_dev_info(bp, &nvm_dev_info);
977 	if (rc ||
978 	    !(nvm_dev_info.flags & NVM_GET_DEV_INFO_RESP_FLAGS_FW_VER_VALID)) {
979 		if (!bnxt_get_pkginfo(bp->dev, buf, sizeof(buf)))
980 			return bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
981 						DEVLINK_INFO_VERSION_GENERIC_FW,
982 						buf);
983 		return 0;
984 	}
985 
986 	buf[0] = 0;
987 	strncat(buf, nvm_dev_info.pkg_name, HWRM_FW_VER_STR_LEN);
988 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
989 			      DEVLINK_INFO_VERSION_GENERIC_FW, buf);
990 	if (rc)
991 		return rc;
992 
993 	snprintf(mgmt_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
994 		 nvm_dev_info.hwrm_fw_major, nvm_dev_info.hwrm_fw_minor,
995 		 nvm_dev_info.hwrm_fw_build, nvm_dev_info.hwrm_fw_patch);
996 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
997 			      DEVLINK_INFO_VERSION_GENERIC_FW_MGMT, mgmt_ver);
998 	if (rc)
999 		return rc;
1000 
1001 	snprintf(ncsi_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
1002 		 nvm_dev_info.mgmt_fw_major, nvm_dev_info.mgmt_fw_minor,
1003 		 nvm_dev_info.mgmt_fw_build, nvm_dev_info.mgmt_fw_patch);
1004 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
1005 			      DEVLINK_INFO_VERSION_GENERIC_FW_NCSI, ncsi_ver);
1006 	if (rc)
1007 		return rc;
1008 
1009 	snprintf(roce_ver, FW_VER_STR_LEN, "%d.%d.%d.%d",
1010 		 nvm_dev_info.roce_fw_major, nvm_dev_info.roce_fw_minor,
1011 		 nvm_dev_info.roce_fw_build, nvm_dev_info.roce_fw_patch);
1012 	rc = bnxt_dl_info_put(bp, req, BNXT_VERSION_STORED,
1013 			      DEVLINK_INFO_VERSION_GENERIC_FW_ROCE, roce_ver);
1014 	if (rc)
1015 		return rc;
1016 
1017 	if (BNXT_CHIP_P5_PLUS(bp)) {
1018 		rc = bnxt_dl_livepatch_info_put(bp, req, BNXT_FW_SRT_PATCH);
1019 		if (rc)
1020 			return rc;
1021 	}
1022 	return bnxt_dl_livepatch_info_put(bp, req, BNXT_FW_CRT_PATCH);
1023 
1024 }
1025 
1026 static int bnxt_hwrm_nvm_req(struct bnxt *bp, u32 param_id, void *msg,
1027 			     union devlink_param_value *val)
1028 {
1029 	struct hwrm_nvm_get_variable_input *req = msg;
1030 	struct bnxt_dl_nvm_param nvm_param;
1031 	struct hwrm_err_output *resp;
1032 	union bnxt_nvm_data *data;
1033 	dma_addr_t data_dma_addr;
1034 	int idx = 0, rc, i;
1035 
1036 	/* Get/Set NVM CFG parameter is supported only on PFs */
1037 	if (BNXT_VF(bp)) {
1038 		hwrm_req_drop(bp, req);
1039 		return -EPERM;
1040 	}
1041 
1042 	for (i = 0; i < ARRAY_SIZE(nvm_params); i++) {
1043 		if (nvm_params[i].id == param_id) {
1044 			nvm_param = nvm_params[i];
1045 			break;
1046 		}
1047 	}
1048 
1049 	if (i == ARRAY_SIZE(nvm_params)) {
1050 		hwrm_req_drop(bp, req);
1051 		return -EOPNOTSUPP;
1052 	}
1053 
1054 	if (nvm_param.dir_type == BNXT_NVM_PORT_CFG)
1055 		idx = bp->pf.port_id;
1056 	else if (nvm_param.dir_type == BNXT_NVM_FUNC_CFG)
1057 		idx = bp->pf.fw_fid - BNXT_FIRST_PF_FID;
1058 
1059 	data = hwrm_req_dma_slice(bp, req, sizeof(*data), &data_dma_addr);
1060 
1061 	if (!data) {
1062 		hwrm_req_drop(bp, req);
1063 		return -ENOMEM;
1064 	}
1065 
1066 	req->dest_data_addr = cpu_to_le64(data_dma_addr);
1067 	req->data_len = cpu_to_le16(nvm_param.nvm_num_bits);
1068 	req->option_num = cpu_to_le16(nvm_param.offset);
1069 	req->index_0 = cpu_to_le16(idx);
1070 	if (idx)
1071 		req->dimensions = cpu_to_le16(1);
1072 
1073 	resp = hwrm_req_hold(bp, req);
1074 	if (req->req_type == cpu_to_le16(HWRM_NVM_SET_VARIABLE)) {
1075 		bnxt_copy_to_nvm_data(data, val, nvm_param.nvm_num_bits,
1076 				      nvm_param.dl_num_bytes);
1077 		rc = hwrm_req_send(bp, msg);
1078 	} else {
1079 		rc = hwrm_req_send_silent(bp, msg);
1080 		if (!rc) {
1081 			bnxt_copy_from_nvm_data(val, data,
1082 						nvm_param.nvm_num_bits,
1083 						nvm_param.dl_num_bytes);
1084 		} else {
1085 			if (resp->cmd_err ==
1086 				NVM_GET_VARIABLE_CMD_ERR_CODE_VAR_NOT_EXIST)
1087 				rc = -EOPNOTSUPP;
1088 		}
1089 	}
1090 	hwrm_req_drop(bp, req);
1091 	if (rc == -EACCES)
1092 		netdev_err(bp->dev, "PF does not have admin privileges to modify NVM config\n");
1093 	return rc;
1094 }
1095 
1096 static int bnxt_dl_nvm_param_get(struct devlink *dl, u32 id,
1097 				 struct devlink_param_gset_ctx *ctx)
1098 {
1099 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
1100 	struct hwrm_nvm_get_variable_input *req;
1101 	int rc;
1102 
1103 	rc = hwrm_req_init(bp, req, HWRM_NVM_GET_VARIABLE);
1104 	if (rc)
1105 		return rc;
1106 
1107 	rc = bnxt_hwrm_nvm_req(bp, id, req, &ctx->val);
1108 	if (!rc && id == BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK)
1109 		ctx->val.vbool = !ctx->val.vbool;
1110 
1111 	return rc;
1112 }
1113 
1114 static int bnxt_dl_nvm_param_set(struct devlink *dl, u32 id,
1115 				 struct devlink_param_gset_ctx *ctx,
1116 				 struct netlink_ext_ack *extack)
1117 {
1118 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
1119 	struct hwrm_nvm_set_variable_input *req;
1120 	int rc;
1121 
1122 	rc = hwrm_req_init(bp, req, HWRM_NVM_SET_VARIABLE);
1123 	if (rc)
1124 		return rc;
1125 
1126 	if (id == BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK)
1127 		ctx->val.vbool = !ctx->val.vbool;
1128 
1129 	return bnxt_hwrm_nvm_req(bp, id, req, &ctx->val);
1130 }
1131 
1132 static int bnxt_dl_msix_validate(struct devlink *dl, u32 id,
1133 				 union devlink_param_value val,
1134 				 struct netlink_ext_ack *extack)
1135 {
1136 	int max_val = -1;
1137 
1138 	if (id == DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MAX)
1139 		max_val = BNXT_MSIX_VEC_MAX;
1140 
1141 	if (id == DEVLINK_PARAM_GENERIC_ID_MSIX_VEC_PER_PF_MIN)
1142 		max_val = BNXT_MSIX_VEC_MIN_MAX;
1143 
1144 	if (val.vu32 > max_val) {
1145 		NL_SET_ERR_MSG_MOD(extack, "MSIX value is exceeding the range");
1146 		return -EINVAL;
1147 	}
1148 
1149 	return 0;
1150 }
1151 
1152 static int bnxt_remote_dev_reset_get(struct devlink *dl, u32 id,
1153 				     struct devlink_param_gset_ctx *ctx)
1154 {
1155 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
1156 
1157 	if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET_IF)
1158 		return -EOPNOTSUPP;
1159 
1160 	ctx->val.vbool = bnxt_dl_get_remote_reset(dl);
1161 	return 0;
1162 }
1163 
1164 static int bnxt_remote_dev_reset_set(struct devlink *dl, u32 id,
1165 				     struct devlink_param_gset_ctx *ctx,
1166 				     struct netlink_ext_ack *extack)
1167 {
1168 	struct bnxt *bp = bnxt_get_bp_from_dl(dl);
1169 	int rc;
1170 
1171 	rc = bnxt_hwrm_remote_dev_reset_set(bp, ctx->val.vbool);
1172 	if (rc)
1173 		return rc;
1174 
1175 	bnxt_dl_set_remote_reset(dl, ctx->val.vbool);
1176 	return rc;
1177 }
1178 
1179 static const struct devlink_param bnxt_dl_params[] = {
1180 	DEVLINK_PARAM_GENERIC(ENABLE_SRIOV,
1181 			      BIT(DEVLINK_PARAM_CMODE_PERMANENT),
1182 			      bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
1183 			      NULL),
1184 	DEVLINK_PARAM_GENERIC(IGNORE_ARI,
1185 			      BIT(DEVLINK_PARAM_CMODE_PERMANENT),
1186 			      bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
1187 			      NULL),
1188 	DEVLINK_PARAM_GENERIC(MSIX_VEC_PER_PF_MAX,
1189 			      BIT(DEVLINK_PARAM_CMODE_PERMANENT),
1190 			      bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
1191 			      bnxt_dl_msix_validate),
1192 	DEVLINK_PARAM_GENERIC(MSIX_VEC_PER_PF_MIN,
1193 			      BIT(DEVLINK_PARAM_CMODE_PERMANENT),
1194 			      bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
1195 			      bnxt_dl_msix_validate),
1196 	DEVLINK_PARAM_DRIVER(BNXT_DEVLINK_PARAM_ID_GRE_VER_CHECK,
1197 			     "gre_ver_check", DEVLINK_PARAM_TYPE_BOOL,
1198 			     BIT(DEVLINK_PARAM_CMODE_PERMANENT),
1199 			     bnxt_dl_nvm_param_get, bnxt_dl_nvm_param_set,
1200 			     NULL),
1201 	/* keep REMOTE_DEV_RESET last, it is excluded based on caps */
1202 	DEVLINK_PARAM_GENERIC(ENABLE_REMOTE_DEV_RESET,
1203 			      BIT(DEVLINK_PARAM_CMODE_RUNTIME),
1204 			      bnxt_remote_dev_reset_get,
1205 			      bnxt_remote_dev_reset_set, NULL),
1206 };
1207 
1208 static int bnxt_dl_params_register(struct bnxt *bp)
1209 {
1210 	int num_params = ARRAY_SIZE(bnxt_dl_params);
1211 	int rc;
1212 
1213 	if (bp->hwrm_spec_code < 0x10600)
1214 		return 0;
1215 
1216 	if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET_IF)
1217 		num_params--;
1218 
1219 	rc = devlink_params_register(bp->dl, bnxt_dl_params, num_params);
1220 	if (rc)
1221 		netdev_warn(bp->dev, "devlink_params_register failed. rc=%d\n",
1222 			    rc);
1223 	return rc;
1224 }
1225 
1226 static void bnxt_dl_params_unregister(struct bnxt *bp)
1227 {
1228 	int num_params = ARRAY_SIZE(bnxt_dl_params);
1229 
1230 	if (bp->hwrm_spec_code < 0x10600)
1231 		return;
1232 
1233 	if (~bp->fw_cap & BNXT_FW_CAP_HOT_RESET_IF)
1234 		num_params--;
1235 
1236 	devlink_params_unregister(bp->dl, bnxt_dl_params, num_params);
1237 }
1238 
1239 int bnxt_dl_register(struct bnxt *bp)
1240 {
1241 	const struct devlink_ops *devlink_ops;
1242 	struct devlink_port_attrs attrs = {};
1243 	struct bnxt_dl *bp_dl;
1244 	struct devlink *dl;
1245 	int rc;
1246 
1247 	if (BNXT_PF(bp))
1248 		devlink_ops = &bnxt_dl_ops;
1249 	else
1250 		devlink_ops = &bnxt_vf_dl_ops;
1251 
1252 	dl = devlink_alloc(devlink_ops, sizeof(struct bnxt_dl), &bp->pdev->dev);
1253 	if (!dl) {
1254 		netdev_warn(bp->dev, "devlink_alloc failed\n");
1255 		return -ENOMEM;
1256 	}
1257 
1258 	bp->dl = dl;
1259 	bp_dl = devlink_priv(dl);
1260 	bp_dl->bp = bp;
1261 	bnxt_dl_set_remote_reset(dl, true);
1262 
1263 	/* Add switchdev eswitch mode setting, if SRIOV supported */
1264 	if (pci_find_ext_capability(bp->pdev, PCI_EXT_CAP_ID_SRIOV) &&
1265 	    bp->hwrm_spec_code > 0x10803)
1266 		bp->eswitch_mode = DEVLINK_ESWITCH_MODE_LEGACY;
1267 
1268 	if (!BNXT_PF(bp))
1269 		goto out;
1270 
1271 	attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL;
1272 	attrs.phys.port_number = bp->pf.port_id;
1273 	memcpy(attrs.switch_id.id, bp->dsn, sizeof(bp->dsn));
1274 	attrs.switch_id.id_len = sizeof(bp->dsn);
1275 	devlink_port_attrs_set(&bp->dl_port, &attrs);
1276 	rc = devlink_port_register(dl, &bp->dl_port, bp->pf.port_id);
1277 	if (rc) {
1278 		netdev_err(bp->dev, "devlink_port_register failed\n");
1279 		goto err_dl_free;
1280 	}
1281 
1282 	rc = bnxt_dl_params_register(bp);
1283 	if (rc)
1284 		goto err_dl_port_unreg;
1285 
1286 out:
1287 	devlink_register(dl);
1288 	return 0;
1289 
1290 err_dl_port_unreg:
1291 	devlink_port_unregister(&bp->dl_port);
1292 err_dl_free:
1293 	devlink_free(dl);
1294 	return rc;
1295 }
1296 
1297 void bnxt_dl_unregister(struct bnxt *bp)
1298 {
1299 	struct devlink *dl = bp->dl;
1300 
1301 	devlink_unregister(dl);
1302 	if (BNXT_PF(bp)) {
1303 		bnxt_dl_params_unregister(bp);
1304 		devlink_port_unregister(&bp->dl_port);
1305 	}
1306 	devlink_free(dl);
1307 }
1308