xref: /linux-6.15/drivers/gpu/drm/v3d/v3d_submit.c (revision 6745f3e4)
1 // SPDX-License-Identifier: GPL-2.0+
2 /*
3  * Copyright (C) 2014-2018 Broadcom
4  * Copyright (C) 2023 Raspberry Pi
5  */
6 
7 #include <drm/drm_syncobj.h>
8 
9 #include "v3d_drv.h"
10 #include "v3d_regs.h"
11 #include "v3d_trace.h"
12 
13 /* Takes the reservation lock on all the BOs being referenced, so that
14  * at queue submit time we can update the reservations.
15  *
16  * We don't lock the RCL the tile alloc/state BOs, or overflow memory
17  * (all of which are on exec->unref_list).  They're entirely private
18  * to v3d, so we don't attach dma-buf fences to them.
19  */
20 static int
21 v3d_lock_bo_reservations(struct v3d_job *job,
22 			 struct ww_acquire_ctx *acquire_ctx)
23 {
24 	int i, ret;
25 
26 	ret = drm_gem_lock_reservations(job->bo, job->bo_count, acquire_ctx);
27 	if (ret)
28 		return ret;
29 
30 	for (i = 0; i < job->bo_count; i++) {
31 		ret = dma_resv_reserve_fences(job->bo[i]->resv, 1);
32 		if (ret)
33 			goto fail;
34 
35 		ret = drm_sched_job_add_implicit_dependencies(&job->base,
36 							      job->bo[i], true);
37 		if (ret)
38 			goto fail;
39 	}
40 
41 	return 0;
42 
43 fail:
44 	drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
45 	return ret;
46 }
47 
48 /**
49  * v3d_lookup_bos() - Sets up job->bo[] with the GEM objects
50  * referenced by the job.
51  * @dev: DRM device
52  * @file_priv: DRM file for this fd
53  * @job: V3D job being set up
54  * @bo_handles: GEM handles
55  * @bo_count: Number of GEM handles passed in
56  *
57  * The command validator needs to reference BOs by their index within
58  * the submitted job's BO list.  This does the validation of the job's
59  * BO list and reference counting for the lifetime of the job.
60  *
61  * Note that this function doesn't need to unreference the BOs on
62  * failure, because that will happen at v3d_exec_cleanup() time.
63  */
64 static int
65 v3d_lookup_bos(struct drm_device *dev,
66 	       struct drm_file *file_priv,
67 	       struct v3d_job *job,
68 	       u64 bo_handles,
69 	       u32 bo_count)
70 {
71 	job->bo_count = bo_count;
72 
73 	if (!job->bo_count) {
74 		/* See comment on bo_index for why we have to check
75 		 * this.
76 		 */
77 		DRM_DEBUG("Rendering requires BOs\n");
78 		return -EINVAL;
79 	}
80 
81 	return drm_gem_objects_lookup(file_priv,
82 				      (void __user *)(uintptr_t)bo_handles,
83 				      job->bo_count, &job->bo);
84 }
85 
86 static void
87 v3d_job_free(struct kref *ref)
88 {
89 	struct v3d_job *job = container_of(ref, struct v3d_job, refcount);
90 	int i;
91 
92 	if (job->bo) {
93 		for (i = 0; i < job->bo_count; i++)
94 			drm_gem_object_put(job->bo[i]);
95 		kvfree(job->bo);
96 	}
97 
98 	dma_fence_put(job->irq_fence);
99 	dma_fence_put(job->done_fence);
100 
101 	if (job->perfmon)
102 		v3d_perfmon_put(job->perfmon);
103 
104 	kfree(job);
105 }
106 
107 static void
108 v3d_render_job_free(struct kref *ref)
109 {
110 	struct v3d_render_job *job = container_of(ref, struct v3d_render_job,
111 						  base.refcount);
112 	struct v3d_bo *bo, *save;
113 
114 	list_for_each_entry_safe(bo, save, &job->unref_list, unref_head) {
115 		drm_gem_object_put(&bo->base.base);
116 	}
117 
118 	v3d_job_free(ref);
119 }
120 
121 void v3d_job_cleanup(struct v3d_job *job)
122 {
123 	if (!job)
124 		return;
125 
126 	drm_sched_job_cleanup(&job->base);
127 	v3d_job_put(job);
128 }
129 
130 void v3d_job_put(struct v3d_job *job)
131 {
132 	if (!job)
133 		return;
134 
135 	kref_put(&job->refcount, job->free);
136 }
137 
138 static int
139 v3d_job_allocate(void **container, size_t size)
140 {
141 	*container = kcalloc(1, size, GFP_KERNEL);
142 	if (!*container) {
143 		DRM_ERROR("Cannot allocate memory for V3D job.\n");
144 		return -ENOMEM;
145 	}
146 
147 	return 0;
148 }
149 
150 static int
151 v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv,
152 	     struct v3d_job *job, void (*free)(struct kref *ref),
153 	     u32 in_sync, struct v3d_submit_ext *se, enum v3d_queue queue)
154 {
155 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
156 	bool has_multisync = se && (se->flags & DRM_V3D_EXT_ID_MULTI_SYNC);
157 	int ret, i;
158 
159 	job->v3d = v3d;
160 	job->free = free;
161 	job->file = file_priv;
162 
163 	ret = drm_sched_job_init(&job->base, &v3d_priv->sched_entity[queue],
164 				 1, v3d_priv);
165 	if (ret)
166 		return ret;
167 
168 	if (has_multisync) {
169 		if (se->in_sync_count && se->wait_stage == queue) {
170 			struct drm_v3d_sem __user *handle = u64_to_user_ptr(se->in_syncs);
171 
172 			for (i = 0; i < se->in_sync_count; i++) {
173 				struct drm_v3d_sem in;
174 
175 				if (copy_from_user(&in, handle++, sizeof(in))) {
176 					ret = -EFAULT;
177 					DRM_DEBUG("Failed to copy wait dep handle.\n");
178 					goto fail_deps;
179 				}
180 				ret = drm_sched_job_add_syncobj_dependency(&job->base, file_priv, in.handle, 0);
181 
182 				// TODO: Investigate why this was filtered out for the IOCTL.
183 				if (ret && ret != -ENOENT)
184 					goto fail_deps;
185 			}
186 		}
187 	} else {
188 		ret = drm_sched_job_add_syncobj_dependency(&job->base, file_priv, in_sync, 0);
189 
190 		// TODO: Investigate why this was filtered out for the IOCTL.
191 		if (ret && ret != -ENOENT)
192 			goto fail_deps;
193 	}
194 
195 	kref_init(&job->refcount);
196 
197 	return 0;
198 
199 fail_deps:
200 	drm_sched_job_cleanup(&job->base);
201 	return ret;
202 }
203 
204 static void
205 v3d_push_job(struct v3d_job *job)
206 {
207 	drm_sched_job_arm(&job->base);
208 
209 	job->done_fence = dma_fence_get(&job->base.s_fence->finished);
210 
211 	/* put by scheduler job completion */
212 	kref_get(&job->refcount);
213 
214 	drm_sched_entity_push_job(&job->base);
215 }
216 
217 static void
218 v3d_attach_fences_and_unlock_reservation(struct drm_file *file_priv,
219 					 struct v3d_job *job,
220 					 struct ww_acquire_ctx *acquire_ctx,
221 					 u32 out_sync,
222 					 struct v3d_submit_ext *se,
223 					 struct dma_fence *done_fence)
224 {
225 	struct drm_syncobj *sync_out;
226 	bool has_multisync = se && (se->flags & DRM_V3D_EXT_ID_MULTI_SYNC);
227 	int i;
228 
229 	for (i = 0; i < job->bo_count; i++) {
230 		/* XXX: Use shared fences for read-only objects. */
231 		dma_resv_add_fence(job->bo[i]->resv, job->done_fence,
232 				   DMA_RESV_USAGE_WRITE);
233 	}
234 
235 	drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
236 
237 	/* Update the return sync object for the job */
238 	/* If it only supports a single signal semaphore*/
239 	if (!has_multisync) {
240 		sync_out = drm_syncobj_find(file_priv, out_sync);
241 		if (sync_out) {
242 			drm_syncobj_replace_fence(sync_out, done_fence);
243 			drm_syncobj_put(sync_out);
244 		}
245 		return;
246 	}
247 
248 	/* If multiple semaphores extension is supported */
249 	if (se->out_sync_count) {
250 		for (i = 0; i < se->out_sync_count; i++) {
251 			drm_syncobj_replace_fence(se->out_syncs[i].syncobj,
252 						  done_fence);
253 			drm_syncobj_put(se->out_syncs[i].syncobj);
254 		}
255 		kvfree(se->out_syncs);
256 	}
257 }
258 
259 static int
260 v3d_setup_csd_jobs_and_bos(struct drm_file *file_priv,
261 			   struct v3d_dev *v3d,
262 			   struct drm_v3d_submit_csd *args,
263 			   struct v3d_csd_job **job,
264 			   struct v3d_job **clean_job,
265 			   struct v3d_submit_ext *se,
266 			   struct ww_acquire_ctx *acquire_ctx)
267 {
268 	int ret;
269 
270 	ret = v3d_job_allocate((void *)job, sizeof(**job));
271 	if (ret)
272 		return ret;
273 
274 	ret = v3d_job_init(v3d, file_priv, &(*job)->base,
275 			   v3d_job_free, args->in_sync, se, V3D_CSD);
276 	if (ret)
277 		return ret;
278 
279 	ret = v3d_job_allocate((void *)clean_job, sizeof(**clean_job));
280 	if (ret)
281 		return ret;
282 
283 	ret = v3d_job_init(v3d, file_priv, *clean_job,
284 			   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
285 	if (ret)
286 		return ret;
287 
288 	(*job)->args = *args;
289 
290 	ret = v3d_lookup_bos(&v3d->drm, file_priv, *clean_job,
291 			     args->bo_handles, args->bo_handle_count);
292 	if (ret)
293 		return ret;
294 
295 	return v3d_lock_bo_reservations(*clean_job, acquire_ctx);
296 }
297 
298 static void
299 v3d_put_multisync_post_deps(struct v3d_submit_ext *se)
300 {
301 	unsigned int i;
302 
303 	if (!(se && se->out_sync_count))
304 		return;
305 
306 	for (i = 0; i < se->out_sync_count; i++)
307 		drm_syncobj_put(se->out_syncs[i].syncobj);
308 	kvfree(se->out_syncs);
309 }
310 
311 static int
312 v3d_get_multisync_post_deps(struct drm_file *file_priv,
313 			    struct v3d_submit_ext *se,
314 			    u32 count, u64 handles)
315 {
316 	struct drm_v3d_sem __user *post_deps;
317 	int i, ret;
318 
319 	if (!count)
320 		return 0;
321 
322 	se->out_syncs = (struct v3d_submit_outsync *)
323 			kvmalloc_array(count,
324 				       sizeof(struct v3d_submit_outsync),
325 				       GFP_KERNEL);
326 	if (!se->out_syncs)
327 		return -ENOMEM;
328 
329 	post_deps = u64_to_user_ptr(handles);
330 
331 	for (i = 0; i < count; i++) {
332 		struct drm_v3d_sem out;
333 
334 		if (copy_from_user(&out, post_deps++, sizeof(out))) {
335 			ret = -EFAULT;
336 			DRM_DEBUG("Failed to copy post dep handles\n");
337 			goto fail;
338 		}
339 
340 		se->out_syncs[i].syncobj = drm_syncobj_find(file_priv,
341 							    out.handle);
342 		if (!se->out_syncs[i].syncobj) {
343 			ret = -EINVAL;
344 			goto fail;
345 		}
346 	}
347 	se->out_sync_count = count;
348 
349 	return 0;
350 
351 fail:
352 	for (i--; i >= 0; i--)
353 		drm_syncobj_put(se->out_syncs[i].syncobj);
354 	kvfree(se->out_syncs);
355 
356 	return ret;
357 }
358 
359 /* Get data for multiple binary semaphores synchronization. Parse syncobj
360  * to be signaled when job completes (out_sync).
361  */
362 static int
363 v3d_get_multisync_submit_deps(struct drm_file *file_priv,
364 			      struct drm_v3d_extension __user *ext,
365 			      struct v3d_submit_ext *se)
366 {
367 	struct drm_v3d_multi_sync multisync;
368 	int ret;
369 
370 	if (se->in_sync_count || se->out_sync_count) {
371 		DRM_DEBUG("Two multisync extensions were added to the same job.");
372 		return -EINVAL;
373 	}
374 
375 	if (copy_from_user(&multisync, ext, sizeof(multisync)))
376 		return -EFAULT;
377 
378 	if (multisync.pad)
379 		return -EINVAL;
380 
381 	ret = v3d_get_multisync_post_deps(file_priv, se, multisync.out_sync_count,
382 					  multisync.out_syncs);
383 	if (ret)
384 		return ret;
385 
386 	se->in_sync_count = multisync.in_sync_count;
387 	se->in_syncs = multisync.in_syncs;
388 	se->flags |= DRM_V3D_EXT_ID_MULTI_SYNC;
389 	se->wait_stage = multisync.wait_stage;
390 
391 	return 0;
392 }
393 
394 /* Get data for the indirect CSD job submission. */
395 static int
396 v3d_get_cpu_indirect_csd_params(struct drm_file *file_priv,
397 				struct drm_v3d_extension __user *ext,
398 				struct v3d_cpu_job *job)
399 {
400 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
401 	struct v3d_dev *v3d = v3d_priv->v3d;
402 	struct drm_v3d_indirect_csd indirect_csd;
403 	struct v3d_indirect_csd_info *info = &job->indirect_csd;
404 
405 	if (!job) {
406 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
407 		return -EINVAL;
408 	}
409 
410 	if (job->job_type) {
411 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
412 		return -EINVAL;
413 	}
414 
415 	if (copy_from_user(&indirect_csd, ext, sizeof(indirect_csd)))
416 		return -EFAULT;
417 
418 	if (!v3d_has_csd(v3d)) {
419 		DRM_DEBUG("Attempting CSD submit on non-CSD hardware.\n");
420 		return -EINVAL;
421 	}
422 
423 	job->job_type = V3D_CPU_JOB_TYPE_INDIRECT_CSD;
424 	info->offset = indirect_csd.offset;
425 	info->wg_size = indirect_csd.wg_size;
426 	memcpy(&info->wg_uniform_offsets, &indirect_csd.wg_uniform_offsets,
427 	       sizeof(indirect_csd.wg_uniform_offsets));
428 
429 	info->indirect = drm_gem_object_lookup(file_priv, indirect_csd.indirect);
430 
431 	return v3d_setup_csd_jobs_and_bos(file_priv, v3d, &indirect_csd.submit,
432 					  &info->job, &info->clean_job,
433 					  NULL, &info->acquire_ctx);
434 }
435 
436 /* Get data for the query timestamp job submission. */
437 static int
438 v3d_get_cpu_timestamp_query_params(struct drm_file *file_priv,
439 				   struct drm_v3d_extension __user *ext,
440 				   struct v3d_cpu_job *job)
441 {
442 	u32 __user *offsets, *syncs;
443 	struct drm_v3d_timestamp_query timestamp;
444 
445 	if (!job) {
446 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
447 		return -EINVAL;
448 	}
449 
450 	if (job->job_type) {
451 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
452 		return -EINVAL;
453 	}
454 
455 	if (copy_from_user(&timestamp, ext, sizeof(timestamp)))
456 		return -EFAULT;
457 
458 	if (timestamp.pad)
459 		return -EINVAL;
460 
461 	job->job_type = V3D_CPU_JOB_TYPE_TIMESTAMP_QUERY;
462 
463 	job->timestamp_query.queries = kvmalloc_array(timestamp.count,
464 						      sizeof(struct v3d_timestamp_query),
465 						      GFP_KERNEL);
466 	if (!job->timestamp_query.queries)
467 		return -ENOMEM;
468 
469 	offsets = u64_to_user_ptr(timestamp.offsets);
470 	syncs = u64_to_user_ptr(timestamp.syncs);
471 
472 	for (int i = 0; i < timestamp.count; i++) {
473 		u32 offset, sync;
474 
475 		if (copy_from_user(&offset, offsets++, sizeof(offset))) {
476 			kvfree(job->timestamp_query.queries);
477 			return -EFAULT;
478 		}
479 
480 		job->timestamp_query.queries[i].offset = offset;
481 
482 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
483 			kvfree(job->timestamp_query.queries);
484 			return -EFAULT;
485 		}
486 
487 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
488 	}
489 	job->timestamp_query.count = timestamp.count;
490 
491 	return 0;
492 }
493 
494 static int
495 v3d_get_cpu_reset_timestamp_params(struct drm_file *file_priv,
496 				   struct drm_v3d_extension __user *ext,
497 				   struct v3d_cpu_job *job)
498 {
499 	u32 __user *syncs;
500 	struct drm_v3d_reset_timestamp_query reset;
501 
502 	if (!job) {
503 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
504 		return -EINVAL;
505 	}
506 
507 	if (job->job_type) {
508 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
509 		return -EINVAL;
510 	}
511 
512 	if (copy_from_user(&reset, ext, sizeof(reset)))
513 		return -EFAULT;
514 
515 	job->job_type = V3D_CPU_JOB_TYPE_RESET_TIMESTAMP_QUERY;
516 
517 	job->timestamp_query.queries = kvmalloc_array(reset.count,
518 						      sizeof(struct v3d_timestamp_query),
519 						      GFP_KERNEL);
520 	if (!job->timestamp_query.queries)
521 		return -ENOMEM;
522 
523 	syncs = u64_to_user_ptr(reset.syncs);
524 
525 	for (int i = 0; i < reset.count; i++) {
526 		u32 sync;
527 
528 		job->timestamp_query.queries[i].offset = reset.offset + 8 * i;
529 
530 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
531 			kvfree(job->timestamp_query.queries);
532 			return -EFAULT;
533 		}
534 
535 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
536 	}
537 	job->timestamp_query.count = reset.count;
538 
539 	return 0;
540 }
541 
542 /* Get data for the copy timestamp query results job submission. */
543 static int
544 v3d_get_cpu_copy_query_results_params(struct drm_file *file_priv,
545 				      struct drm_v3d_extension __user *ext,
546 				      struct v3d_cpu_job *job)
547 {
548 	u32 __user *offsets, *syncs;
549 	struct drm_v3d_copy_timestamp_query copy;
550 	int i;
551 
552 	if (!job) {
553 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
554 		return -EINVAL;
555 	}
556 
557 	if (job->job_type) {
558 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
559 		return -EINVAL;
560 	}
561 
562 	if (copy_from_user(&copy, ext, sizeof(copy)))
563 		return -EFAULT;
564 
565 	if (copy.pad)
566 		return -EINVAL;
567 
568 	job->job_type = V3D_CPU_JOB_TYPE_COPY_TIMESTAMP_QUERY;
569 
570 	job->timestamp_query.queries = kvmalloc_array(copy.count,
571 						      sizeof(struct v3d_timestamp_query),
572 						      GFP_KERNEL);
573 	if (!job->timestamp_query.queries)
574 		return -ENOMEM;
575 
576 	offsets = u64_to_user_ptr(copy.offsets);
577 	syncs = u64_to_user_ptr(copy.syncs);
578 
579 	for (i = 0; i < copy.count; i++) {
580 		u32 offset, sync;
581 
582 		if (copy_from_user(&offset, offsets++, sizeof(offset))) {
583 			kvfree(job->timestamp_query.queries);
584 			return -EFAULT;
585 		}
586 
587 		job->timestamp_query.queries[i].offset = offset;
588 
589 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
590 			kvfree(job->timestamp_query.queries);
591 			return -EFAULT;
592 		}
593 
594 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
595 	}
596 	job->timestamp_query.count = copy.count;
597 
598 	job->copy.do_64bit = copy.do_64bit;
599 	job->copy.do_partial = copy.do_partial;
600 	job->copy.availability_bit = copy.availability_bit;
601 	job->copy.offset = copy.offset;
602 	job->copy.stride = copy.stride;
603 
604 	return 0;
605 }
606 
607 /* Whenever userspace sets ioctl extensions, v3d_get_extensions parses data
608  * according to the extension id (name).
609  */
610 static int
611 v3d_get_extensions(struct drm_file *file_priv,
612 		   u64 ext_handles,
613 		   struct v3d_submit_ext *se,
614 		   struct v3d_cpu_job *job)
615 {
616 	struct drm_v3d_extension __user *user_ext;
617 	int ret;
618 
619 	user_ext = u64_to_user_ptr(ext_handles);
620 	while (user_ext) {
621 		struct drm_v3d_extension ext;
622 
623 		if (copy_from_user(&ext, user_ext, sizeof(ext))) {
624 			DRM_DEBUG("Failed to copy submit extension\n");
625 			return -EFAULT;
626 		}
627 
628 		switch (ext.id) {
629 		case DRM_V3D_EXT_ID_MULTI_SYNC:
630 			ret = v3d_get_multisync_submit_deps(file_priv, user_ext, se);
631 			break;
632 		case DRM_V3D_EXT_ID_CPU_INDIRECT_CSD:
633 			ret = v3d_get_cpu_indirect_csd_params(file_priv, user_ext, job);
634 			break;
635 		case DRM_V3D_EXT_ID_CPU_TIMESTAMP_QUERY:
636 			ret = v3d_get_cpu_timestamp_query_params(file_priv, user_ext, job);
637 			break;
638 		case DRM_V3D_EXT_ID_CPU_RESET_TIMESTAMP_QUERY:
639 			ret = v3d_get_cpu_reset_timestamp_params(file_priv, user_ext, job);
640 			break;
641 		case DRM_V3D_EXT_ID_CPU_COPY_TIMESTAMP_QUERY:
642 			ret = v3d_get_cpu_copy_query_results_params(file_priv, user_ext, job);
643 			break;
644 		default:
645 			DRM_DEBUG_DRIVER("Unknown extension id: %d\n", ext.id);
646 			return -EINVAL;
647 		}
648 
649 		if (ret)
650 			return ret;
651 
652 		user_ext = u64_to_user_ptr(ext.next);
653 	}
654 
655 	return 0;
656 }
657 
658 /**
659  * v3d_submit_cl_ioctl() - Submits a job (frame) to the V3D.
660  * @dev: DRM device
661  * @data: ioctl argument
662  * @file_priv: DRM file for this fd
663  *
664  * This is the main entrypoint for userspace to submit a 3D frame to
665  * the GPU.  Userspace provides the binner command list (if
666  * applicable), and the kernel sets up the render command list to draw
667  * to the framebuffer described in the ioctl, using the command lists
668  * that the 3D engine's binner will produce.
669  */
670 int
671 v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
672 		    struct drm_file *file_priv)
673 {
674 	struct v3d_dev *v3d = to_v3d_dev(dev);
675 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
676 	struct drm_v3d_submit_cl *args = data;
677 	struct v3d_submit_ext se = {0};
678 	struct v3d_bin_job *bin = NULL;
679 	struct v3d_render_job *render = NULL;
680 	struct v3d_job *clean_job = NULL;
681 	struct v3d_job *last_job;
682 	struct ww_acquire_ctx acquire_ctx;
683 	int ret = 0;
684 
685 	trace_v3d_submit_cl_ioctl(&v3d->drm, args->rcl_start, args->rcl_end);
686 
687 	if (args->pad)
688 		return -EINVAL;
689 
690 	if (args->flags &&
691 	    args->flags & ~(DRM_V3D_SUBMIT_CL_FLUSH_CACHE |
692 			    DRM_V3D_SUBMIT_EXTENSION)) {
693 		DRM_INFO("invalid flags: %d\n", args->flags);
694 		return -EINVAL;
695 	}
696 
697 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
698 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
699 		if (ret) {
700 			DRM_DEBUG("Failed to get extensions.\n");
701 			return ret;
702 		}
703 	}
704 
705 	ret = v3d_job_allocate((void *)&render, sizeof(*render));
706 	if (ret)
707 		return ret;
708 
709 	ret = v3d_job_init(v3d, file_priv, &render->base,
710 			   v3d_render_job_free, args->in_sync_rcl, &se, V3D_RENDER);
711 	if (ret)
712 		goto fail;
713 
714 	render->start = args->rcl_start;
715 	render->end = args->rcl_end;
716 	INIT_LIST_HEAD(&render->unref_list);
717 
718 	if (args->bcl_start != args->bcl_end) {
719 		ret = v3d_job_allocate((void *)&bin, sizeof(*bin));
720 		if (ret)
721 			goto fail;
722 
723 		ret = v3d_job_init(v3d, file_priv, &bin->base,
724 				   v3d_job_free, args->in_sync_bcl, &se, V3D_BIN);
725 		if (ret)
726 			goto fail;
727 
728 		bin->start = args->bcl_start;
729 		bin->end = args->bcl_end;
730 		bin->qma = args->qma;
731 		bin->qms = args->qms;
732 		bin->qts = args->qts;
733 		bin->render = render;
734 	}
735 
736 	if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
737 		ret = v3d_job_allocate((void *)&clean_job, sizeof(*clean_job));
738 		if (ret)
739 			goto fail;
740 
741 		ret = v3d_job_init(v3d, file_priv, clean_job,
742 				   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
743 		if (ret)
744 			goto fail;
745 
746 		last_job = clean_job;
747 	} else {
748 		last_job = &render->base;
749 	}
750 
751 	ret = v3d_lookup_bos(dev, file_priv, last_job,
752 			     args->bo_handles, args->bo_handle_count);
753 	if (ret)
754 		goto fail;
755 
756 	ret = v3d_lock_bo_reservations(last_job, &acquire_ctx);
757 	if (ret)
758 		goto fail;
759 
760 	if (args->perfmon_id) {
761 		render->base.perfmon = v3d_perfmon_find(v3d_priv,
762 							args->perfmon_id);
763 
764 		if (!render->base.perfmon) {
765 			ret = -ENOENT;
766 			goto fail_perfmon;
767 		}
768 	}
769 
770 	mutex_lock(&v3d->sched_lock);
771 	if (bin) {
772 		bin->base.perfmon = render->base.perfmon;
773 		v3d_perfmon_get(bin->base.perfmon);
774 		v3d_push_job(&bin->base);
775 
776 		ret = drm_sched_job_add_dependency(&render->base.base,
777 						   dma_fence_get(bin->base.done_fence));
778 		if (ret)
779 			goto fail_unreserve;
780 	}
781 
782 	v3d_push_job(&render->base);
783 
784 	if (clean_job) {
785 		struct dma_fence *render_fence =
786 			dma_fence_get(render->base.done_fence);
787 		ret = drm_sched_job_add_dependency(&clean_job->base,
788 						   render_fence);
789 		if (ret)
790 			goto fail_unreserve;
791 		clean_job->perfmon = render->base.perfmon;
792 		v3d_perfmon_get(clean_job->perfmon);
793 		v3d_push_job(clean_job);
794 	}
795 
796 	mutex_unlock(&v3d->sched_lock);
797 
798 	v3d_attach_fences_and_unlock_reservation(file_priv,
799 						 last_job,
800 						 &acquire_ctx,
801 						 args->out_sync,
802 						 &se,
803 						 last_job->done_fence);
804 
805 	v3d_job_put(&bin->base);
806 	v3d_job_put(&render->base);
807 	v3d_job_put(clean_job);
808 
809 	return 0;
810 
811 fail_unreserve:
812 	mutex_unlock(&v3d->sched_lock);
813 fail_perfmon:
814 	drm_gem_unlock_reservations(last_job->bo,
815 				    last_job->bo_count, &acquire_ctx);
816 fail:
817 	v3d_job_cleanup((void *)bin);
818 	v3d_job_cleanup((void *)render);
819 	v3d_job_cleanup(clean_job);
820 	v3d_put_multisync_post_deps(&se);
821 
822 	return ret;
823 }
824 
825 /**
826  * v3d_submit_tfu_ioctl() - Submits a TFU (texture formatting) job to the V3D.
827  * @dev: DRM device
828  * @data: ioctl argument
829  * @file_priv: DRM file for this fd
830  *
831  * Userspace provides the register setup for the TFU, which we don't
832  * need to validate since the TFU is behind the MMU.
833  */
834 int
835 v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
836 		     struct drm_file *file_priv)
837 {
838 	struct v3d_dev *v3d = to_v3d_dev(dev);
839 	struct drm_v3d_submit_tfu *args = data;
840 	struct v3d_submit_ext se = {0};
841 	struct v3d_tfu_job *job = NULL;
842 	struct ww_acquire_ctx acquire_ctx;
843 	int ret = 0;
844 
845 	trace_v3d_submit_tfu_ioctl(&v3d->drm, args->iia);
846 
847 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
848 		DRM_DEBUG("invalid flags: %d\n", args->flags);
849 		return -EINVAL;
850 	}
851 
852 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
853 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
854 		if (ret) {
855 			DRM_DEBUG("Failed to get extensions.\n");
856 			return ret;
857 		}
858 	}
859 
860 	ret = v3d_job_allocate((void *)&job, sizeof(*job));
861 	if (ret)
862 		return ret;
863 
864 	ret = v3d_job_init(v3d, file_priv, &job->base,
865 			   v3d_job_free, args->in_sync, &se, V3D_TFU);
866 	if (ret)
867 		goto fail;
868 
869 	job->base.bo = kcalloc(ARRAY_SIZE(args->bo_handles),
870 			       sizeof(*job->base.bo), GFP_KERNEL);
871 	if (!job->base.bo) {
872 		ret = -ENOMEM;
873 		goto fail;
874 	}
875 
876 	job->args = *args;
877 
878 	for (job->base.bo_count = 0;
879 	     job->base.bo_count < ARRAY_SIZE(args->bo_handles);
880 	     job->base.bo_count++) {
881 		struct drm_gem_object *bo;
882 
883 		if (!args->bo_handles[job->base.bo_count])
884 			break;
885 
886 		bo = drm_gem_object_lookup(file_priv, args->bo_handles[job->base.bo_count]);
887 		if (!bo) {
888 			DRM_DEBUG("Failed to look up GEM BO %d: %d\n",
889 				  job->base.bo_count,
890 				  args->bo_handles[job->base.bo_count]);
891 			ret = -ENOENT;
892 			goto fail;
893 		}
894 		job->base.bo[job->base.bo_count] = bo;
895 	}
896 
897 	ret = v3d_lock_bo_reservations(&job->base, &acquire_ctx);
898 	if (ret)
899 		goto fail;
900 
901 	mutex_lock(&v3d->sched_lock);
902 	v3d_push_job(&job->base);
903 	mutex_unlock(&v3d->sched_lock);
904 
905 	v3d_attach_fences_and_unlock_reservation(file_priv,
906 						 &job->base, &acquire_ctx,
907 						 args->out_sync,
908 						 &se,
909 						 job->base.done_fence);
910 
911 	v3d_job_put(&job->base);
912 
913 	return 0;
914 
915 fail:
916 	v3d_job_cleanup((void *)job);
917 	v3d_put_multisync_post_deps(&se);
918 
919 	return ret;
920 }
921 
922 /**
923  * v3d_submit_csd_ioctl() - Submits a CSD (compute shader) job to the V3D.
924  * @dev: DRM device
925  * @data: ioctl argument
926  * @file_priv: DRM file for this fd
927  *
928  * Userspace provides the register setup for the CSD, which we don't
929  * need to validate since the CSD is behind the MMU.
930  */
931 int
932 v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
933 		     struct drm_file *file_priv)
934 {
935 	struct v3d_dev *v3d = to_v3d_dev(dev);
936 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
937 	struct drm_v3d_submit_csd *args = data;
938 	struct v3d_submit_ext se = {0};
939 	struct v3d_csd_job *job = NULL;
940 	struct v3d_job *clean_job = NULL;
941 	struct ww_acquire_ctx acquire_ctx;
942 	int ret;
943 
944 	trace_v3d_submit_csd_ioctl(&v3d->drm, args->cfg[5], args->cfg[6]);
945 
946 	if (args->pad)
947 		return -EINVAL;
948 
949 	if (!v3d_has_csd(v3d)) {
950 		DRM_DEBUG("Attempting CSD submit on non-CSD hardware\n");
951 		return -EINVAL;
952 	}
953 
954 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
955 		DRM_INFO("invalid flags: %d\n", args->flags);
956 		return -EINVAL;
957 	}
958 
959 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
960 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
961 		if (ret) {
962 			DRM_DEBUG("Failed to get extensions.\n");
963 			return ret;
964 		}
965 	}
966 
967 	ret = v3d_setup_csd_jobs_and_bos(file_priv, v3d, args,
968 					 &job, &clean_job, &se,
969 					 &acquire_ctx);
970 	if (ret)
971 		goto fail;
972 
973 	if (args->perfmon_id) {
974 		job->base.perfmon = v3d_perfmon_find(v3d_priv,
975 						     args->perfmon_id);
976 		if (!job->base.perfmon) {
977 			ret = -ENOENT;
978 			goto fail_perfmon;
979 		}
980 	}
981 
982 	mutex_lock(&v3d->sched_lock);
983 	v3d_push_job(&job->base);
984 
985 	ret = drm_sched_job_add_dependency(&clean_job->base,
986 					   dma_fence_get(job->base.done_fence));
987 	if (ret)
988 		goto fail_unreserve;
989 
990 	v3d_push_job(clean_job);
991 	mutex_unlock(&v3d->sched_lock);
992 
993 	v3d_attach_fences_and_unlock_reservation(file_priv,
994 						 clean_job,
995 						 &acquire_ctx,
996 						 args->out_sync,
997 						 &se,
998 						 clean_job->done_fence);
999 
1000 	v3d_job_put(&job->base);
1001 	v3d_job_put(clean_job);
1002 
1003 	return 0;
1004 
1005 fail_unreserve:
1006 	mutex_unlock(&v3d->sched_lock);
1007 fail_perfmon:
1008 	drm_gem_unlock_reservations(clean_job->bo, clean_job->bo_count,
1009 				    &acquire_ctx);
1010 fail:
1011 	v3d_job_cleanup((void *)job);
1012 	v3d_job_cleanup(clean_job);
1013 	v3d_put_multisync_post_deps(&se);
1014 
1015 	return ret;
1016 }
1017 
1018 static const unsigned int cpu_job_bo_handle_count[] = {
1019 	[V3D_CPU_JOB_TYPE_INDIRECT_CSD] = 1,
1020 	[V3D_CPU_JOB_TYPE_TIMESTAMP_QUERY] = 1,
1021 	[V3D_CPU_JOB_TYPE_RESET_TIMESTAMP_QUERY] = 1,
1022 	[V3D_CPU_JOB_TYPE_COPY_TIMESTAMP_QUERY] = 2,
1023 };
1024 
1025 /**
1026  * v3d_submit_cpu_ioctl() - Submits a CPU job to the V3D.
1027  * @dev: DRM device
1028  * @data: ioctl argument
1029  * @file_priv: DRM file for this fd
1030  *
1031  * Userspace specifies the CPU job type and data required to perform its
1032  * operations through the drm_v3d_extension struct.
1033  */
1034 int
1035 v3d_submit_cpu_ioctl(struct drm_device *dev, void *data,
1036 		     struct drm_file *file_priv)
1037 {
1038 	struct v3d_dev *v3d = to_v3d_dev(dev);
1039 	struct drm_v3d_submit_cpu *args = data;
1040 	struct v3d_submit_ext se = {0};
1041 	struct v3d_submit_ext *out_se = NULL;
1042 	struct v3d_cpu_job *cpu_job = NULL;
1043 	struct v3d_csd_job *csd_job = NULL;
1044 	struct v3d_job *clean_job = NULL;
1045 	struct ww_acquire_ctx acquire_ctx;
1046 	int ret;
1047 
1048 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1049 		DRM_INFO("Invalid flags: %d\n", args->flags);
1050 		return -EINVAL;
1051 	}
1052 
1053 	ret = v3d_job_allocate((void *)&cpu_job, sizeof(*cpu_job));
1054 	if (ret)
1055 		return ret;
1056 
1057 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1058 		ret = v3d_get_extensions(file_priv, args->extensions, &se, cpu_job);
1059 		if (ret) {
1060 			DRM_DEBUG("Failed to get extensions.\n");
1061 			goto fail;
1062 		}
1063 	}
1064 
1065 	/* Every CPU job must have a CPU job user extension */
1066 	if (!cpu_job->job_type) {
1067 		DRM_DEBUG("CPU job must have a CPU job user extension.\n");
1068 		goto fail;
1069 	}
1070 
1071 	if (args->bo_handle_count != cpu_job_bo_handle_count[cpu_job->job_type]) {
1072 		DRM_DEBUG("This CPU job was not submitted with the proper number of BOs.\n");
1073 		goto fail;
1074 	}
1075 
1076 	trace_v3d_submit_cpu_ioctl(&v3d->drm, cpu_job->job_type);
1077 
1078 	ret = v3d_job_init(v3d, file_priv, &cpu_job->base,
1079 			   v3d_job_free, 0, &se, V3D_CPU);
1080 	if (ret)
1081 		goto fail;
1082 
1083 	clean_job = cpu_job->indirect_csd.clean_job;
1084 	csd_job = cpu_job->indirect_csd.job;
1085 
1086 	if (args->bo_handle_count) {
1087 		ret = v3d_lookup_bos(dev, file_priv, &cpu_job->base,
1088 				     args->bo_handles, args->bo_handle_count);
1089 		if (ret)
1090 			goto fail;
1091 
1092 		ret = v3d_lock_bo_reservations(&cpu_job->base, &acquire_ctx);
1093 		if (ret)
1094 			goto fail;
1095 	}
1096 
1097 	mutex_lock(&v3d->sched_lock);
1098 	v3d_push_job(&cpu_job->base);
1099 
1100 	switch (cpu_job->job_type) {
1101 	case V3D_CPU_JOB_TYPE_INDIRECT_CSD:
1102 		ret = drm_sched_job_add_dependency(&csd_job->base.base,
1103 						   dma_fence_get(cpu_job->base.done_fence));
1104 		if (ret)
1105 			goto fail_unreserve;
1106 
1107 		v3d_push_job(&csd_job->base);
1108 
1109 		ret = drm_sched_job_add_dependency(&clean_job->base,
1110 						   dma_fence_get(csd_job->base.done_fence));
1111 		if (ret)
1112 			goto fail_unreserve;
1113 
1114 		v3d_push_job(clean_job);
1115 
1116 		break;
1117 	default:
1118 		break;
1119 	}
1120 	mutex_unlock(&v3d->sched_lock);
1121 
1122 	out_se = (cpu_job->job_type == V3D_CPU_JOB_TYPE_INDIRECT_CSD) ? NULL : &se;
1123 
1124 	v3d_attach_fences_and_unlock_reservation(file_priv,
1125 						 &cpu_job->base,
1126 						 &acquire_ctx, 0,
1127 						 out_se, cpu_job->base.done_fence);
1128 
1129 	switch (cpu_job->job_type) {
1130 	case V3D_CPU_JOB_TYPE_INDIRECT_CSD:
1131 		v3d_attach_fences_and_unlock_reservation(file_priv,
1132 							 clean_job,
1133 							 &cpu_job->indirect_csd.acquire_ctx,
1134 							 0, &se, clean_job->done_fence);
1135 		break;
1136 	default:
1137 		break;
1138 	}
1139 
1140 	v3d_job_put(&cpu_job->base);
1141 	v3d_job_put(&csd_job->base);
1142 	v3d_job_put(clean_job);
1143 
1144 	return 0;
1145 
1146 fail_unreserve:
1147 	mutex_unlock(&v3d->sched_lock);
1148 
1149 	drm_gem_unlock_reservations(cpu_job->base.bo, cpu_job->base.bo_count,
1150 				    &acquire_ctx);
1151 
1152 	drm_gem_unlock_reservations(clean_job->bo, clean_job->bo_count,
1153 				    &cpu_job->indirect_csd.acquire_ctx);
1154 
1155 fail:
1156 	v3d_job_cleanup((void *)cpu_job);
1157 	v3d_job_cleanup((void *)csd_job);
1158 	v3d_job_cleanup(clean_job);
1159 	v3d_put_multisync_post_deps(&se);
1160 	kvfree(cpu_job->timestamp_query.queries);
1161 
1162 	return ret;
1163 }
1164