xref: /linux-6.15/drivers/gpu/drm/v3d/v3d_submit.c (revision 4bd75a81)
1 // SPDX-License-Identifier: GPL-2.0+
2 /*
3  * Copyright (C) 2014-2018 Broadcom
4  * Copyright (C) 2023 Raspberry Pi
5  */
6 
7 #include <drm/drm_syncobj.h>
8 
9 #include "v3d_drv.h"
10 #include "v3d_regs.h"
11 #include "v3d_trace.h"
12 
13 /* Takes the reservation lock on all the BOs being referenced, so that
14  * at queue submit time we can update the reservations.
15  *
16  * We don't lock the RCL the tile alloc/state BOs, or overflow memory
17  * (all of which are on exec->unref_list).  They're entirely private
18  * to v3d, so we don't attach dma-buf fences to them.
19  */
20 static int
21 v3d_lock_bo_reservations(struct v3d_job *job,
22 			 struct ww_acquire_ctx *acquire_ctx)
23 {
24 	int i, ret;
25 
26 	ret = drm_gem_lock_reservations(job->bo, job->bo_count, acquire_ctx);
27 	if (ret)
28 		return ret;
29 
30 	for (i = 0; i < job->bo_count; i++) {
31 		ret = dma_resv_reserve_fences(job->bo[i]->resv, 1);
32 		if (ret)
33 			goto fail;
34 
35 		ret = drm_sched_job_add_implicit_dependencies(&job->base,
36 							      job->bo[i], true);
37 		if (ret)
38 			goto fail;
39 	}
40 
41 	return 0;
42 
43 fail:
44 	drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
45 	return ret;
46 }
47 
48 /**
49  * v3d_lookup_bos() - Sets up job->bo[] with the GEM objects
50  * referenced by the job.
51  * @dev: DRM device
52  * @file_priv: DRM file for this fd
53  * @job: V3D job being set up
54  * @bo_handles: GEM handles
55  * @bo_count: Number of GEM handles passed in
56  *
57  * The command validator needs to reference BOs by their index within
58  * the submitted job's BO list.  This does the validation of the job's
59  * BO list and reference counting for the lifetime of the job.
60  *
61  * Note that this function doesn't need to unreference the BOs on
62  * failure, because that will happen at v3d_exec_cleanup() time.
63  */
64 static int
65 v3d_lookup_bos(struct drm_device *dev,
66 	       struct drm_file *file_priv,
67 	       struct v3d_job *job,
68 	       u64 bo_handles,
69 	       u32 bo_count)
70 {
71 	job->bo_count = bo_count;
72 
73 	if (!job->bo_count) {
74 		/* See comment on bo_index for why we have to check
75 		 * this.
76 		 */
77 		DRM_DEBUG("Rendering requires BOs\n");
78 		return -EINVAL;
79 	}
80 
81 	return drm_gem_objects_lookup(file_priv,
82 				      (void __user *)(uintptr_t)bo_handles,
83 				      job->bo_count, &job->bo);
84 }
85 
86 static void
87 v3d_job_free(struct kref *ref)
88 {
89 	struct v3d_job *job = container_of(ref, struct v3d_job, refcount);
90 	int i;
91 
92 	if (job->bo) {
93 		for (i = 0; i < job->bo_count; i++)
94 			drm_gem_object_put(job->bo[i]);
95 		kvfree(job->bo);
96 	}
97 
98 	dma_fence_put(job->irq_fence);
99 	dma_fence_put(job->done_fence);
100 
101 	if (job->perfmon)
102 		v3d_perfmon_put(job->perfmon);
103 
104 	kfree(job);
105 }
106 
107 static void
108 v3d_render_job_free(struct kref *ref)
109 {
110 	struct v3d_render_job *job = container_of(ref, struct v3d_render_job,
111 						  base.refcount);
112 	struct v3d_bo *bo, *save;
113 
114 	list_for_each_entry_safe(bo, save, &job->unref_list, unref_head) {
115 		drm_gem_object_put(&bo->base.base);
116 	}
117 
118 	v3d_job_free(ref);
119 }
120 
121 void v3d_job_cleanup(struct v3d_job *job)
122 {
123 	if (!job)
124 		return;
125 
126 	drm_sched_job_cleanup(&job->base);
127 	v3d_job_put(job);
128 }
129 
130 void v3d_job_put(struct v3d_job *job)
131 {
132 	if (!job)
133 		return;
134 
135 	kref_put(&job->refcount, job->free);
136 }
137 
138 static int
139 v3d_job_allocate(void **container, size_t size)
140 {
141 	*container = kcalloc(1, size, GFP_KERNEL);
142 	if (!*container) {
143 		DRM_ERROR("Cannot allocate memory for V3D job.\n");
144 		return -ENOMEM;
145 	}
146 
147 	return 0;
148 }
149 
150 static void
151 v3d_job_deallocate(void **container)
152 {
153 	kfree(*container);
154 	*container = NULL;
155 }
156 
157 static int
158 v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv,
159 	     struct v3d_job *job, void (*free)(struct kref *ref),
160 	     u32 in_sync, struct v3d_submit_ext *se, enum v3d_queue queue)
161 {
162 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
163 	bool has_multisync = se && (se->flags & DRM_V3D_EXT_ID_MULTI_SYNC);
164 	int ret, i;
165 
166 	job->v3d = v3d;
167 	job->free = free;
168 	job->file = file_priv;
169 
170 	ret = drm_sched_job_init(&job->base, &v3d_priv->sched_entity[queue],
171 				 1, v3d_priv);
172 	if (ret)
173 		return ret;
174 
175 	if (has_multisync) {
176 		if (se->in_sync_count && se->wait_stage == queue) {
177 			struct drm_v3d_sem __user *handle = u64_to_user_ptr(se->in_syncs);
178 
179 			for (i = 0; i < se->in_sync_count; i++) {
180 				struct drm_v3d_sem in;
181 
182 				if (copy_from_user(&in, handle++, sizeof(in))) {
183 					ret = -EFAULT;
184 					DRM_DEBUG("Failed to copy wait dep handle.\n");
185 					goto fail_deps;
186 				}
187 				ret = drm_sched_job_add_syncobj_dependency(&job->base, file_priv, in.handle, 0);
188 
189 				// TODO: Investigate why this was filtered out for the IOCTL.
190 				if (ret && ret != -ENOENT)
191 					goto fail_deps;
192 			}
193 		}
194 	} else {
195 		ret = drm_sched_job_add_syncobj_dependency(&job->base, file_priv, in_sync, 0);
196 
197 		// TODO: Investigate why this was filtered out for the IOCTL.
198 		if (ret && ret != -ENOENT)
199 			goto fail_deps;
200 	}
201 
202 	kref_init(&job->refcount);
203 
204 	return 0;
205 
206 fail_deps:
207 	drm_sched_job_cleanup(&job->base);
208 	return ret;
209 }
210 
211 static void
212 v3d_push_job(struct v3d_job *job)
213 {
214 	drm_sched_job_arm(&job->base);
215 
216 	job->done_fence = dma_fence_get(&job->base.s_fence->finished);
217 
218 	/* put by scheduler job completion */
219 	kref_get(&job->refcount);
220 
221 	drm_sched_entity_push_job(&job->base);
222 }
223 
224 static void
225 v3d_attach_fences_and_unlock_reservation(struct drm_file *file_priv,
226 					 struct v3d_job *job,
227 					 struct ww_acquire_ctx *acquire_ctx,
228 					 u32 out_sync,
229 					 struct v3d_submit_ext *se,
230 					 struct dma_fence *done_fence)
231 {
232 	struct drm_syncobj *sync_out;
233 	bool has_multisync = se && (se->flags & DRM_V3D_EXT_ID_MULTI_SYNC);
234 	int i;
235 
236 	for (i = 0; i < job->bo_count; i++) {
237 		/* XXX: Use shared fences for read-only objects. */
238 		dma_resv_add_fence(job->bo[i]->resv, job->done_fence,
239 				   DMA_RESV_USAGE_WRITE);
240 	}
241 
242 	drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
243 
244 	/* Update the return sync object for the job */
245 	/* If it only supports a single signal semaphore*/
246 	if (!has_multisync) {
247 		sync_out = drm_syncobj_find(file_priv, out_sync);
248 		if (sync_out) {
249 			drm_syncobj_replace_fence(sync_out, done_fence);
250 			drm_syncobj_put(sync_out);
251 		}
252 		return;
253 	}
254 
255 	/* If multiple semaphores extension is supported */
256 	if (se->out_sync_count) {
257 		for (i = 0; i < se->out_sync_count; i++) {
258 			drm_syncobj_replace_fence(se->out_syncs[i].syncobj,
259 						  done_fence);
260 			drm_syncobj_put(se->out_syncs[i].syncobj);
261 		}
262 		kvfree(se->out_syncs);
263 	}
264 }
265 
266 static int
267 v3d_setup_csd_jobs_and_bos(struct drm_file *file_priv,
268 			   struct v3d_dev *v3d,
269 			   struct drm_v3d_submit_csd *args,
270 			   struct v3d_csd_job **job,
271 			   struct v3d_job **clean_job,
272 			   struct v3d_submit_ext *se,
273 			   struct ww_acquire_ctx *acquire_ctx)
274 {
275 	int ret;
276 
277 	ret = v3d_job_allocate((void *)job, sizeof(**job));
278 	if (ret)
279 		return ret;
280 
281 	ret = v3d_job_init(v3d, file_priv, &(*job)->base,
282 			   v3d_job_free, args->in_sync, se, V3D_CSD);
283 	if (ret) {
284 		v3d_job_deallocate((void *)job);
285 		return ret;
286 	}
287 
288 	ret = v3d_job_allocate((void *)clean_job, sizeof(**clean_job));
289 	if (ret)
290 		return ret;
291 
292 	ret = v3d_job_init(v3d, file_priv, *clean_job,
293 			   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
294 	if (ret) {
295 		v3d_job_deallocate((void *)clean_job);
296 		return ret;
297 	}
298 
299 	(*job)->args = *args;
300 
301 	ret = v3d_lookup_bos(&v3d->drm, file_priv, *clean_job,
302 			     args->bo_handles, args->bo_handle_count);
303 	if (ret)
304 		return ret;
305 
306 	return v3d_lock_bo_reservations(*clean_job, acquire_ctx);
307 }
308 
309 static void
310 v3d_put_multisync_post_deps(struct v3d_submit_ext *se)
311 {
312 	unsigned int i;
313 
314 	if (!(se && se->out_sync_count))
315 		return;
316 
317 	for (i = 0; i < se->out_sync_count; i++)
318 		drm_syncobj_put(se->out_syncs[i].syncobj);
319 	kvfree(se->out_syncs);
320 }
321 
322 static int
323 v3d_get_multisync_post_deps(struct drm_file *file_priv,
324 			    struct v3d_submit_ext *se,
325 			    u32 count, u64 handles)
326 {
327 	struct drm_v3d_sem __user *post_deps;
328 	int i, ret;
329 
330 	if (!count)
331 		return 0;
332 
333 	se->out_syncs = (struct v3d_submit_outsync *)
334 			kvmalloc_array(count,
335 				       sizeof(struct v3d_submit_outsync),
336 				       GFP_KERNEL);
337 	if (!se->out_syncs)
338 		return -ENOMEM;
339 
340 	post_deps = u64_to_user_ptr(handles);
341 
342 	for (i = 0; i < count; i++) {
343 		struct drm_v3d_sem out;
344 
345 		if (copy_from_user(&out, post_deps++, sizeof(out))) {
346 			ret = -EFAULT;
347 			DRM_DEBUG("Failed to copy post dep handles\n");
348 			goto fail;
349 		}
350 
351 		se->out_syncs[i].syncobj = drm_syncobj_find(file_priv,
352 							    out.handle);
353 		if (!se->out_syncs[i].syncobj) {
354 			ret = -EINVAL;
355 			goto fail;
356 		}
357 	}
358 	se->out_sync_count = count;
359 
360 	return 0;
361 
362 fail:
363 	for (i--; i >= 0; i--)
364 		drm_syncobj_put(se->out_syncs[i].syncobj);
365 	kvfree(se->out_syncs);
366 
367 	return ret;
368 }
369 
370 /* Get data for multiple binary semaphores synchronization. Parse syncobj
371  * to be signaled when job completes (out_sync).
372  */
373 static int
374 v3d_get_multisync_submit_deps(struct drm_file *file_priv,
375 			      struct drm_v3d_extension __user *ext,
376 			      struct v3d_submit_ext *se)
377 {
378 	struct drm_v3d_multi_sync multisync;
379 	int ret;
380 
381 	if (se->in_sync_count || se->out_sync_count) {
382 		DRM_DEBUG("Two multisync extensions were added to the same job.");
383 		return -EINVAL;
384 	}
385 
386 	if (copy_from_user(&multisync, ext, sizeof(multisync)))
387 		return -EFAULT;
388 
389 	if (multisync.pad)
390 		return -EINVAL;
391 
392 	ret = v3d_get_multisync_post_deps(file_priv, se, multisync.out_sync_count,
393 					  multisync.out_syncs);
394 	if (ret)
395 		return ret;
396 
397 	se->in_sync_count = multisync.in_sync_count;
398 	se->in_syncs = multisync.in_syncs;
399 	se->flags |= DRM_V3D_EXT_ID_MULTI_SYNC;
400 	se->wait_stage = multisync.wait_stage;
401 
402 	return 0;
403 }
404 
405 /* Get data for the indirect CSD job submission. */
406 static int
407 v3d_get_cpu_indirect_csd_params(struct drm_file *file_priv,
408 				struct drm_v3d_extension __user *ext,
409 				struct v3d_cpu_job *job)
410 {
411 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
412 	struct v3d_dev *v3d = v3d_priv->v3d;
413 	struct drm_v3d_indirect_csd indirect_csd;
414 	struct v3d_indirect_csd_info *info = &job->indirect_csd;
415 
416 	if (!job) {
417 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
418 		return -EINVAL;
419 	}
420 
421 	if (job->job_type) {
422 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
423 		return -EINVAL;
424 	}
425 
426 	if (copy_from_user(&indirect_csd, ext, sizeof(indirect_csd)))
427 		return -EFAULT;
428 
429 	if (!v3d_has_csd(v3d)) {
430 		DRM_DEBUG("Attempting CSD submit on non-CSD hardware.\n");
431 		return -EINVAL;
432 	}
433 
434 	job->job_type = V3D_CPU_JOB_TYPE_INDIRECT_CSD;
435 	info->offset = indirect_csd.offset;
436 	info->wg_size = indirect_csd.wg_size;
437 	memcpy(&info->wg_uniform_offsets, &indirect_csd.wg_uniform_offsets,
438 	       sizeof(indirect_csd.wg_uniform_offsets));
439 
440 	info->indirect = drm_gem_object_lookup(file_priv, indirect_csd.indirect);
441 
442 	return v3d_setup_csd_jobs_and_bos(file_priv, v3d, &indirect_csd.submit,
443 					  &info->job, &info->clean_job,
444 					  NULL, &info->acquire_ctx);
445 }
446 
447 /* Get data for the query timestamp job submission. */
448 static int
449 v3d_get_cpu_timestamp_query_params(struct drm_file *file_priv,
450 				   struct drm_v3d_extension __user *ext,
451 				   struct v3d_cpu_job *job)
452 {
453 	u32 __user *offsets, *syncs;
454 	struct drm_v3d_timestamp_query timestamp;
455 	unsigned int i;
456 	int err;
457 
458 	if (!job) {
459 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
460 		return -EINVAL;
461 	}
462 
463 	if (job->job_type) {
464 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
465 		return -EINVAL;
466 	}
467 
468 	if (copy_from_user(&timestamp, ext, sizeof(timestamp)))
469 		return -EFAULT;
470 
471 	if (timestamp.pad)
472 		return -EINVAL;
473 
474 	job->job_type = V3D_CPU_JOB_TYPE_TIMESTAMP_QUERY;
475 
476 	job->timestamp_query.queries = kvmalloc_array(timestamp.count,
477 						      sizeof(struct v3d_timestamp_query),
478 						      GFP_KERNEL);
479 	if (!job->timestamp_query.queries)
480 		return -ENOMEM;
481 
482 	offsets = u64_to_user_ptr(timestamp.offsets);
483 	syncs = u64_to_user_ptr(timestamp.syncs);
484 
485 	for (i = 0; i < timestamp.count; i++) {
486 		u32 offset, sync;
487 
488 		if (copy_from_user(&offset, offsets++, sizeof(offset))) {
489 			err = -EFAULT;
490 			goto error;
491 		}
492 
493 		job->timestamp_query.queries[i].offset = offset;
494 
495 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
496 			err = -EFAULT;
497 			goto error;
498 		}
499 
500 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
501 		if (!job->timestamp_query.queries[i].syncobj) {
502 			err = -ENOENT;
503 			goto error;
504 		}
505 	}
506 	job->timestamp_query.count = timestamp.count;
507 
508 	return 0;
509 
510 error:
511 	v3d_timestamp_query_info_free(&job->timestamp_query, i);
512 	return err;
513 }
514 
515 static int
516 v3d_get_cpu_reset_timestamp_params(struct drm_file *file_priv,
517 				   struct drm_v3d_extension __user *ext,
518 				   struct v3d_cpu_job *job)
519 {
520 	u32 __user *syncs;
521 	struct drm_v3d_reset_timestamp_query reset;
522 	unsigned int i;
523 	int err;
524 
525 	if (!job) {
526 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
527 		return -EINVAL;
528 	}
529 
530 	if (job->job_type) {
531 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
532 		return -EINVAL;
533 	}
534 
535 	if (copy_from_user(&reset, ext, sizeof(reset)))
536 		return -EFAULT;
537 
538 	job->job_type = V3D_CPU_JOB_TYPE_RESET_TIMESTAMP_QUERY;
539 
540 	job->timestamp_query.queries = kvmalloc_array(reset.count,
541 						      sizeof(struct v3d_timestamp_query),
542 						      GFP_KERNEL);
543 	if (!job->timestamp_query.queries)
544 		return -ENOMEM;
545 
546 	syncs = u64_to_user_ptr(reset.syncs);
547 
548 	for (i = 0; i < reset.count; i++) {
549 		u32 sync;
550 
551 		job->timestamp_query.queries[i].offset = reset.offset + 8 * i;
552 
553 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
554 			err = -EFAULT;
555 			goto error;
556 		}
557 
558 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
559 		if (!job->timestamp_query.queries[i].syncobj) {
560 			err = -ENOENT;
561 			goto error;
562 		}
563 	}
564 	job->timestamp_query.count = reset.count;
565 
566 	return 0;
567 
568 error:
569 	v3d_timestamp_query_info_free(&job->timestamp_query, i);
570 	return err;
571 }
572 
573 /* Get data for the copy timestamp query results job submission. */
574 static int
575 v3d_get_cpu_copy_query_results_params(struct drm_file *file_priv,
576 				      struct drm_v3d_extension __user *ext,
577 				      struct v3d_cpu_job *job)
578 {
579 	u32 __user *offsets, *syncs;
580 	struct drm_v3d_copy_timestamp_query copy;
581 	unsigned int i;
582 	int err;
583 
584 	if (!job) {
585 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
586 		return -EINVAL;
587 	}
588 
589 	if (job->job_type) {
590 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
591 		return -EINVAL;
592 	}
593 
594 	if (copy_from_user(&copy, ext, sizeof(copy)))
595 		return -EFAULT;
596 
597 	if (copy.pad)
598 		return -EINVAL;
599 
600 	job->job_type = V3D_CPU_JOB_TYPE_COPY_TIMESTAMP_QUERY;
601 
602 	job->timestamp_query.queries = kvmalloc_array(copy.count,
603 						      sizeof(struct v3d_timestamp_query),
604 						      GFP_KERNEL);
605 	if (!job->timestamp_query.queries)
606 		return -ENOMEM;
607 
608 	offsets = u64_to_user_ptr(copy.offsets);
609 	syncs = u64_to_user_ptr(copy.syncs);
610 
611 	for (i = 0; i < copy.count; i++) {
612 		u32 offset, sync;
613 
614 		if (copy_from_user(&offset, offsets++, sizeof(offset))) {
615 			err = -EFAULT;
616 			goto error;
617 		}
618 
619 		job->timestamp_query.queries[i].offset = offset;
620 
621 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
622 			err = -EFAULT;
623 			goto error;
624 		}
625 
626 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
627 		if (!job->timestamp_query.queries[i].syncobj) {
628 			err = -ENOENT;
629 			goto error;
630 		}
631 	}
632 	job->timestamp_query.count = copy.count;
633 
634 	job->copy.do_64bit = copy.do_64bit;
635 	job->copy.do_partial = copy.do_partial;
636 	job->copy.availability_bit = copy.availability_bit;
637 	job->copy.offset = copy.offset;
638 	job->copy.stride = copy.stride;
639 
640 	return 0;
641 
642 error:
643 	v3d_timestamp_query_info_free(&job->timestamp_query, i);
644 	return err;
645 }
646 
647 static int
648 v3d_copy_query_info(struct v3d_performance_query_info *query_info,
649 		    unsigned int count,
650 		    unsigned int nperfmons,
651 		    u32 __user *syncs,
652 		    u64 __user *kperfmon_ids,
653 		    struct drm_file *file_priv)
654 {
655 	unsigned int i, j;
656 	int err;
657 
658 	for (i = 0; i < count; i++) {
659 		struct v3d_performance_query *query = &query_info->queries[i];
660 		u32 __user *ids_pointer;
661 		u32 sync, id;
662 		u64 ids;
663 
664 		if (get_user(sync, syncs++)) {
665 			err = -EFAULT;
666 			goto error;
667 		}
668 
669 		if (get_user(ids, kperfmon_ids++)) {
670 			err = -EFAULT;
671 			goto error;
672 		}
673 
674 		ids_pointer = u64_to_user_ptr(ids);
675 
676 		for (j = 0; j < nperfmons; j++) {
677 			if (get_user(id, ids_pointer++)) {
678 				err = -EFAULT;
679 				goto error;
680 			}
681 
682 			query->kperfmon_ids[j] = id;
683 		}
684 
685 		query->syncobj = drm_syncobj_find(file_priv, sync);
686 		if (!query->syncobj) {
687 			err = -ENOENT;
688 			goto error;
689 		}
690 	}
691 
692 	return 0;
693 
694 error:
695 	v3d_performance_query_info_free(query_info, i);
696 	return err;
697 }
698 
699 static int
700 v3d_get_cpu_reset_performance_params(struct drm_file *file_priv,
701 				     struct drm_v3d_extension __user *ext,
702 				     struct v3d_cpu_job *job)
703 {
704 	struct drm_v3d_reset_performance_query reset;
705 	int err;
706 
707 	if (!job) {
708 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
709 		return -EINVAL;
710 	}
711 
712 	if (job->job_type) {
713 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
714 		return -EINVAL;
715 	}
716 
717 	if (copy_from_user(&reset, ext, sizeof(reset)))
718 		return -EFAULT;
719 
720 	if (reset.nperfmons > V3D_MAX_PERFMONS)
721 		return -EINVAL;
722 
723 	job->job_type = V3D_CPU_JOB_TYPE_RESET_PERFORMANCE_QUERY;
724 
725 	job->performance_query.queries = kvmalloc_array(reset.count,
726 							sizeof(struct v3d_performance_query),
727 							GFP_KERNEL);
728 	if (!job->performance_query.queries)
729 		return -ENOMEM;
730 
731 	err = v3d_copy_query_info(&job->performance_query,
732 				  reset.count,
733 				  reset.nperfmons,
734 				  u64_to_user_ptr(reset.syncs),
735 				  u64_to_user_ptr(reset.kperfmon_ids),
736 				  file_priv);
737 	if (err)
738 		return err;
739 
740 	job->performance_query.count = reset.count;
741 	job->performance_query.nperfmons = reset.nperfmons;
742 
743 	return 0;
744 }
745 
746 static int
747 v3d_get_cpu_copy_performance_query_params(struct drm_file *file_priv,
748 					  struct drm_v3d_extension __user *ext,
749 					  struct v3d_cpu_job *job)
750 {
751 	struct drm_v3d_copy_performance_query copy;
752 	int err;
753 
754 	if (!job) {
755 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
756 		return -EINVAL;
757 	}
758 
759 	if (job->job_type) {
760 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
761 		return -EINVAL;
762 	}
763 
764 	if (copy_from_user(&copy, ext, sizeof(copy)))
765 		return -EFAULT;
766 
767 	if (copy.pad)
768 		return -EINVAL;
769 
770 	if (copy.nperfmons > V3D_MAX_PERFMONS)
771 		return -EINVAL;
772 
773 	job->job_type = V3D_CPU_JOB_TYPE_COPY_PERFORMANCE_QUERY;
774 
775 	job->performance_query.queries = kvmalloc_array(copy.count,
776 							sizeof(struct v3d_performance_query),
777 							GFP_KERNEL);
778 	if (!job->performance_query.queries)
779 		return -ENOMEM;
780 
781 	err = v3d_copy_query_info(&job->performance_query,
782 				  copy.count,
783 				  copy.nperfmons,
784 				  u64_to_user_ptr(copy.syncs),
785 				  u64_to_user_ptr(copy.kperfmon_ids),
786 				  file_priv);
787 	if (err)
788 		return err;
789 
790 	job->performance_query.count = copy.count;
791 	job->performance_query.nperfmons = copy.nperfmons;
792 	job->performance_query.ncounters = copy.ncounters;
793 
794 	job->copy.do_64bit = copy.do_64bit;
795 	job->copy.do_partial = copy.do_partial;
796 	job->copy.availability_bit = copy.availability_bit;
797 	job->copy.offset = copy.offset;
798 	job->copy.stride = copy.stride;
799 
800 	return 0;
801 }
802 
803 /* Whenever userspace sets ioctl extensions, v3d_get_extensions parses data
804  * according to the extension id (name).
805  */
806 static int
807 v3d_get_extensions(struct drm_file *file_priv,
808 		   u64 ext_handles,
809 		   struct v3d_submit_ext *se,
810 		   struct v3d_cpu_job *job)
811 {
812 	struct drm_v3d_extension __user *user_ext;
813 	int ret;
814 
815 	user_ext = u64_to_user_ptr(ext_handles);
816 	while (user_ext) {
817 		struct drm_v3d_extension ext;
818 
819 		if (copy_from_user(&ext, user_ext, sizeof(ext))) {
820 			DRM_DEBUG("Failed to copy submit extension\n");
821 			return -EFAULT;
822 		}
823 
824 		switch (ext.id) {
825 		case DRM_V3D_EXT_ID_MULTI_SYNC:
826 			ret = v3d_get_multisync_submit_deps(file_priv, user_ext, se);
827 			break;
828 		case DRM_V3D_EXT_ID_CPU_INDIRECT_CSD:
829 			ret = v3d_get_cpu_indirect_csd_params(file_priv, user_ext, job);
830 			break;
831 		case DRM_V3D_EXT_ID_CPU_TIMESTAMP_QUERY:
832 			ret = v3d_get_cpu_timestamp_query_params(file_priv, user_ext, job);
833 			break;
834 		case DRM_V3D_EXT_ID_CPU_RESET_TIMESTAMP_QUERY:
835 			ret = v3d_get_cpu_reset_timestamp_params(file_priv, user_ext, job);
836 			break;
837 		case DRM_V3D_EXT_ID_CPU_COPY_TIMESTAMP_QUERY:
838 			ret = v3d_get_cpu_copy_query_results_params(file_priv, user_ext, job);
839 			break;
840 		case DRM_V3D_EXT_ID_CPU_RESET_PERFORMANCE_QUERY:
841 			ret = v3d_get_cpu_reset_performance_params(file_priv, user_ext, job);
842 			break;
843 		case DRM_V3D_EXT_ID_CPU_COPY_PERFORMANCE_QUERY:
844 			ret = v3d_get_cpu_copy_performance_query_params(file_priv, user_ext, job);
845 			break;
846 		default:
847 			DRM_DEBUG_DRIVER("Unknown extension id: %d\n", ext.id);
848 			return -EINVAL;
849 		}
850 
851 		if (ret)
852 			return ret;
853 
854 		user_ext = u64_to_user_ptr(ext.next);
855 	}
856 
857 	return 0;
858 }
859 
860 /**
861  * v3d_submit_cl_ioctl() - Submits a job (frame) to the V3D.
862  * @dev: DRM device
863  * @data: ioctl argument
864  * @file_priv: DRM file for this fd
865  *
866  * This is the main entrypoint for userspace to submit a 3D frame to
867  * the GPU.  Userspace provides the binner command list (if
868  * applicable), and the kernel sets up the render command list to draw
869  * to the framebuffer described in the ioctl, using the command lists
870  * that the 3D engine's binner will produce.
871  */
872 int
873 v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
874 		    struct drm_file *file_priv)
875 {
876 	struct v3d_dev *v3d = to_v3d_dev(dev);
877 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
878 	struct drm_v3d_submit_cl *args = data;
879 	struct v3d_submit_ext se = {0};
880 	struct v3d_bin_job *bin = NULL;
881 	struct v3d_render_job *render = NULL;
882 	struct v3d_job *clean_job = NULL;
883 	struct v3d_job *last_job;
884 	struct ww_acquire_ctx acquire_ctx;
885 	int ret = 0;
886 
887 	trace_v3d_submit_cl_ioctl(&v3d->drm, args->rcl_start, args->rcl_end);
888 
889 	if (args->pad)
890 		return -EINVAL;
891 
892 	if (args->flags &&
893 	    args->flags & ~(DRM_V3D_SUBMIT_CL_FLUSH_CACHE |
894 			    DRM_V3D_SUBMIT_EXTENSION)) {
895 		DRM_INFO("invalid flags: %d\n", args->flags);
896 		return -EINVAL;
897 	}
898 
899 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
900 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
901 		if (ret) {
902 			DRM_DEBUG("Failed to get extensions.\n");
903 			return ret;
904 		}
905 	}
906 
907 	ret = v3d_job_allocate((void *)&render, sizeof(*render));
908 	if (ret)
909 		return ret;
910 
911 	ret = v3d_job_init(v3d, file_priv, &render->base,
912 			   v3d_render_job_free, args->in_sync_rcl, &se, V3D_RENDER);
913 	if (ret) {
914 		v3d_job_deallocate((void *)&render);
915 		goto fail;
916 	}
917 
918 	render->start = args->rcl_start;
919 	render->end = args->rcl_end;
920 	INIT_LIST_HEAD(&render->unref_list);
921 
922 	if (args->bcl_start != args->bcl_end) {
923 		ret = v3d_job_allocate((void *)&bin, sizeof(*bin));
924 		if (ret)
925 			goto fail;
926 
927 		ret = v3d_job_init(v3d, file_priv, &bin->base,
928 				   v3d_job_free, args->in_sync_bcl, &se, V3D_BIN);
929 		if (ret) {
930 			v3d_job_deallocate((void *)&bin);
931 			goto fail;
932 		}
933 
934 		bin->start = args->bcl_start;
935 		bin->end = args->bcl_end;
936 		bin->qma = args->qma;
937 		bin->qms = args->qms;
938 		bin->qts = args->qts;
939 		bin->render = render;
940 	}
941 
942 	if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
943 		ret = v3d_job_allocate((void *)&clean_job, sizeof(*clean_job));
944 		if (ret)
945 			goto fail;
946 
947 		ret = v3d_job_init(v3d, file_priv, clean_job,
948 				   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
949 		if (ret) {
950 			v3d_job_deallocate((void *)&clean_job);
951 			goto fail;
952 		}
953 
954 		last_job = clean_job;
955 	} else {
956 		last_job = &render->base;
957 	}
958 
959 	ret = v3d_lookup_bos(dev, file_priv, last_job,
960 			     args->bo_handles, args->bo_handle_count);
961 	if (ret)
962 		goto fail;
963 
964 	ret = v3d_lock_bo_reservations(last_job, &acquire_ctx);
965 	if (ret)
966 		goto fail;
967 
968 	if (args->perfmon_id) {
969 		render->base.perfmon = v3d_perfmon_find(v3d_priv,
970 							args->perfmon_id);
971 
972 		if (!render->base.perfmon) {
973 			ret = -ENOENT;
974 			goto fail_perfmon;
975 		}
976 	}
977 
978 	mutex_lock(&v3d->sched_lock);
979 	if (bin) {
980 		bin->base.perfmon = render->base.perfmon;
981 		v3d_perfmon_get(bin->base.perfmon);
982 		v3d_push_job(&bin->base);
983 
984 		ret = drm_sched_job_add_dependency(&render->base.base,
985 						   dma_fence_get(bin->base.done_fence));
986 		if (ret)
987 			goto fail_unreserve;
988 	}
989 
990 	v3d_push_job(&render->base);
991 
992 	if (clean_job) {
993 		struct dma_fence *render_fence =
994 			dma_fence_get(render->base.done_fence);
995 		ret = drm_sched_job_add_dependency(&clean_job->base,
996 						   render_fence);
997 		if (ret)
998 			goto fail_unreserve;
999 		clean_job->perfmon = render->base.perfmon;
1000 		v3d_perfmon_get(clean_job->perfmon);
1001 		v3d_push_job(clean_job);
1002 	}
1003 
1004 	mutex_unlock(&v3d->sched_lock);
1005 
1006 	v3d_attach_fences_and_unlock_reservation(file_priv,
1007 						 last_job,
1008 						 &acquire_ctx,
1009 						 args->out_sync,
1010 						 &se,
1011 						 last_job->done_fence);
1012 
1013 	v3d_job_put(&bin->base);
1014 	v3d_job_put(&render->base);
1015 	v3d_job_put(clean_job);
1016 
1017 	return 0;
1018 
1019 fail_unreserve:
1020 	mutex_unlock(&v3d->sched_lock);
1021 fail_perfmon:
1022 	drm_gem_unlock_reservations(last_job->bo,
1023 				    last_job->bo_count, &acquire_ctx);
1024 fail:
1025 	v3d_job_cleanup((void *)bin);
1026 	v3d_job_cleanup((void *)render);
1027 	v3d_job_cleanup(clean_job);
1028 	v3d_put_multisync_post_deps(&se);
1029 
1030 	return ret;
1031 }
1032 
1033 /**
1034  * v3d_submit_tfu_ioctl() - Submits a TFU (texture formatting) job to the V3D.
1035  * @dev: DRM device
1036  * @data: ioctl argument
1037  * @file_priv: DRM file for this fd
1038  *
1039  * Userspace provides the register setup for the TFU, which we don't
1040  * need to validate since the TFU is behind the MMU.
1041  */
1042 int
1043 v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
1044 		     struct drm_file *file_priv)
1045 {
1046 	struct v3d_dev *v3d = to_v3d_dev(dev);
1047 	struct drm_v3d_submit_tfu *args = data;
1048 	struct v3d_submit_ext se = {0};
1049 	struct v3d_tfu_job *job = NULL;
1050 	struct ww_acquire_ctx acquire_ctx;
1051 	int ret = 0;
1052 
1053 	trace_v3d_submit_tfu_ioctl(&v3d->drm, args->iia);
1054 
1055 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1056 		DRM_DEBUG("invalid flags: %d\n", args->flags);
1057 		return -EINVAL;
1058 	}
1059 
1060 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1061 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
1062 		if (ret) {
1063 			DRM_DEBUG("Failed to get extensions.\n");
1064 			return ret;
1065 		}
1066 	}
1067 
1068 	ret = v3d_job_allocate((void *)&job, sizeof(*job));
1069 	if (ret)
1070 		return ret;
1071 
1072 	ret = v3d_job_init(v3d, file_priv, &job->base,
1073 			   v3d_job_free, args->in_sync, &se, V3D_TFU);
1074 	if (ret) {
1075 		v3d_job_deallocate((void *)&job);
1076 		goto fail;
1077 	}
1078 
1079 	job->base.bo = kcalloc(ARRAY_SIZE(args->bo_handles),
1080 			       sizeof(*job->base.bo), GFP_KERNEL);
1081 	if (!job->base.bo) {
1082 		ret = -ENOMEM;
1083 		goto fail;
1084 	}
1085 
1086 	job->args = *args;
1087 
1088 	for (job->base.bo_count = 0;
1089 	     job->base.bo_count < ARRAY_SIZE(args->bo_handles);
1090 	     job->base.bo_count++) {
1091 		struct drm_gem_object *bo;
1092 
1093 		if (!args->bo_handles[job->base.bo_count])
1094 			break;
1095 
1096 		bo = drm_gem_object_lookup(file_priv, args->bo_handles[job->base.bo_count]);
1097 		if (!bo) {
1098 			DRM_DEBUG("Failed to look up GEM BO %d: %d\n",
1099 				  job->base.bo_count,
1100 				  args->bo_handles[job->base.bo_count]);
1101 			ret = -ENOENT;
1102 			goto fail;
1103 		}
1104 		job->base.bo[job->base.bo_count] = bo;
1105 	}
1106 
1107 	ret = v3d_lock_bo_reservations(&job->base, &acquire_ctx);
1108 	if (ret)
1109 		goto fail;
1110 
1111 	mutex_lock(&v3d->sched_lock);
1112 	v3d_push_job(&job->base);
1113 	mutex_unlock(&v3d->sched_lock);
1114 
1115 	v3d_attach_fences_and_unlock_reservation(file_priv,
1116 						 &job->base, &acquire_ctx,
1117 						 args->out_sync,
1118 						 &se,
1119 						 job->base.done_fence);
1120 
1121 	v3d_job_put(&job->base);
1122 
1123 	return 0;
1124 
1125 fail:
1126 	v3d_job_cleanup((void *)job);
1127 	v3d_put_multisync_post_deps(&se);
1128 
1129 	return ret;
1130 }
1131 
1132 /**
1133  * v3d_submit_csd_ioctl() - Submits a CSD (compute shader) job to the V3D.
1134  * @dev: DRM device
1135  * @data: ioctl argument
1136  * @file_priv: DRM file for this fd
1137  *
1138  * Userspace provides the register setup for the CSD, which we don't
1139  * need to validate since the CSD is behind the MMU.
1140  */
1141 int
1142 v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
1143 		     struct drm_file *file_priv)
1144 {
1145 	struct v3d_dev *v3d = to_v3d_dev(dev);
1146 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
1147 	struct drm_v3d_submit_csd *args = data;
1148 	struct v3d_submit_ext se = {0};
1149 	struct v3d_csd_job *job = NULL;
1150 	struct v3d_job *clean_job = NULL;
1151 	struct ww_acquire_ctx acquire_ctx;
1152 	int ret;
1153 
1154 	trace_v3d_submit_csd_ioctl(&v3d->drm, args->cfg[5], args->cfg[6]);
1155 
1156 	if (args->pad)
1157 		return -EINVAL;
1158 
1159 	if (!v3d_has_csd(v3d)) {
1160 		DRM_DEBUG("Attempting CSD submit on non-CSD hardware\n");
1161 		return -EINVAL;
1162 	}
1163 
1164 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1165 		DRM_INFO("invalid flags: %d\n", args->flags);
1166 		return -EINVAL;
1167 	}
1168 
1169 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1170 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
1171 		if (ret) {
1172 			DRM_DEBUG("Failed to get extensions.\n");
1173 			return ret;
1174 		}
1175 	}
1176 
1177 	ret = v3d_setup_csd_jobs_and_bos(file_priv, v3d, args,
1178 					 &job, &clean_job, &se,
1179 					 &acquire_ctx);
1180 	if (ret)
1181 		goto fail;
1182 
1183 	if (args->perfmon_id) {
1184 		job->base.perfmon = v3d_perfmon_find(v3d_priv,
1185 						     args->perfmon_id);
1186 		if (!job->base.perfmon) {
1187 			ret = -ENOENT;
1188 			goto fail_perfmon;
1189 		}
1190 	}
1191 
1192 	mutex_lock(&v3d->sched_lock);
1193 	v3d_push_job(&job->base);
1194 
1195 	ret = drm_sched_job_add_dependency(&clean_job->base,
1196 					   dma_fence_get(job->base.done_fence));
1197 	if (ret)
1198 		goto fail_unreserve;
1199 
1200 	v3d_push_job(clean_job);
1201 	mutex_unlock(&v3d->sched_lock);
1202 
1203 	v3d_attach_fences_and_unlock_reservation(file_priv,
1204 						 clean_job,
1205 						 &acquire_ctx,
1206 						 args->out_sync,
1207 						 &se,
1208 						 clean_job->done_fence);
1209 
1210 	v3d_job_put(&job->base);
1211 	v3d_job_put(clean_job);
1212 
1213 	return 0;
1214 
1215 fail_unreserve:
1216 	mutex_unlock(&v3d->sched_lock);
1217 fail_perfmon:
1218 	drm_gem_unlock_reservations(clean_job->bo, clean_job->bo_count,
1219 				    &acquire_ctx);
1220 fail:
1221 	v3d_job_cleanup((void *)job);
1222 	v3d_job_cleanup(clean_job);
1223 	v3d_put_multisync_post_deps(&se);
1224 
1225 	return ret;
1226 }
1227 
1228 static const unsigned int cpu_job_bo_handle_count[] = {
1229 	[V3D_CPU_JOB_TYPE_INDIRECT_CSD] = 1,
1230 	[V3D_CPU_JOB_TYPE_TIMESTAMP_QUERY] = 1,
1231 	[V3D_CPU_JOB_TYPE_RESET_TIMESTAMP_QUERY] = 1,
1232 	[V3D_CPU_JOB_TYPE_COPY_TIMESTAMP_QUERY] = 2,
1233 	[V3D_CPU_JOB_TYPE_RESET_PERFORMANCE_QUERY] = 0,
1234 	[V3D_CPU_JOB_TYPE_COPY_PERFORMANCE_QUERY] = 1,
1235 };
1236 
1237 /**
1238  * v3d_submit_cpu_ioctl() - Submits a CPU job to the V3D.
1239  * @dev: DRM device
1240  * @data: ioctl argument
1241  * @file_priv: DRM file for this fd
1242  *
1243  * Userspace specifies the CPU job type and data required to perform its
1244  * operations through the drm_v3d_extension struct.
1245  */
1246 int
1247 v3d_submit_cpu_ioctl(struct drm_device *dev, void *data,
1248 		     struct drm_file *file_priv)
1249 {
1250 	struct v3d_dev *v3d = to_v3d_dev(dev);
1251 	struct drm_v3d_submit_cpu *args = data;
1252 	struct v3d_submit_ext se = {0};
1253 	struct v3d_submit_ext *out_se = NULL;
1254 	struct v3d_cpu_job *cpu_job = NULL;
1255 	struct v3d_csd_job *csd_job = NULL;
1256 	struct v3d_job *clean_job = NULL;
1257 	struct ww_acquire_ctx acquire_ctx;
1258 	int ret;
1259 
1260 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1261 		DRM_INFO("Invalid flags: %d\n", args->flags);
1262 		return -EINVAL;
1263 	}
1264 
1265 	ret = v3d_job_allocate((void *)&cpu_job, sizeof(*cpu_job));
1266 	if (ret)
1267 		return ret;
1268 
1269 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1270 		ret = v3d_get_extensions(file_priv, args->extensions, &se, cpu_job);
1271 		if (ret) {
1272 			DRM_DEBUG("Failed to get extensions.\n");
1273 			goto fail;
1274 		}
1275 	}
1276 
1277 	/* Every CPU job must have a CPU job user extension */
1278 	if (!cpu_job->job_type) {
1279 		DRM_DEBUG("CPU job must have a CPU job user extension.\n");
1280 		ret = -EINVAL;
1281 		goto fail;
1282 	}
1283 
1284 	if (args->bo_handle_count != cpu_job_bo_handle_count[cpu_job->job_type]) {
1285 		DRM_DEBUG("This CPU job was not submitted with the proper number of BOs.\n");
1286 		ret = -EINVAL;
1287 		goto fail;
1288 	}
1289 
1290 	trace_v3d_submit_cpu_ioctl(&v3d->drm, cpu_job->job_type);
1291 
1292 	ret = v3d_job_init(v3d, file_priv, &cpu_job->base,
1293 			   v3d_job_free, 0, &se, V3D_CPU);
1294 	if (ret) {
1295 		v3d_job_deallocate((void *)&cpu_job);
1296 		goto fail;
1297 	}
1298 
1299 	clean_job = cpu_job->indirect_csd.clean_job;
1300 	csd_job = cpu_job->indirect_csd.job;
1301 
1302 	if (args->bo_handle_count) {
1303 		ret = v3d_lookup_bos(dev, file_priv, &cpu_job->base,
1304 				     args->bo_handles, args->bo_handle_count);
1305 		if (ret)
1306 			goto fail;
1307 
1308 		ret = v3d_lock_bo_reservations(&cpu_job->base, &acquire_ctx);
1309 		if (ret)
1310 			goto fail;
1311 	}
1312 
1313 	mutex_lock(&v3d->sched_lock);
1314 	v3d_push_job(&cpu_job->base);
1315 
1316 	switch (cpu_job->job_type) {
1317 	case V3D_CPU_JOB_TYPE_INDIRECT_CSD:
1318 		ret = drm_sched_job_add_dependency(&csd_job->base.base,
1319 						   dma_fence_get(cpu_job->base.done_fence));
1320 		if (ret)
1321 			goto fail_unreserve;
1322 
1323 		v3d_push_job(&csd_job->base);
1324 
1325 		ret = drm_sched_job_add_dependency(&clean_job->base,
1326 						   dma_fence_get(csd_job->base.done_fence));
1327 		if (ret)
1328 			goto fail_unreserve;
1329 
1330 		v3d_push_job(clean_job);
1331 
1332 		break;
1333 	default:
1334 		break;
1335 	}
1336 	mutex_unlock(&v3d->sched_lock);
1337 
1338 	out_se = (cpu_job->job_type == V3D_CPU_JOB_TYPE_INDIRECT_CSD) ? NULL : &se;
1339 
1340 	v3d_attach_fences_and_unlock_reservation(file_priv,
1341 						 &cpu_job->base,
1342 						 &acquire_ctx, 0,
1343 						 out_se, cpu_job->base.done_fence);
1344 
1345 	switch (cpu_job->job_type) {
1346 	case V3D_CPU_JOB_TYPE_INDIRECT_CSD:
1347 		v3d_attach_fences_and_unlock_reservation(file_priv,
1348 							 clean_job,
1349 							 &cpu_job->indirect_csd.acquire_ctx,
1350 							 0, &se, clean_job->done_fence);
1351 		break;
1352 	default:
1353 		break;
1354 	}
1355 
1356 	v3d_job_put(&cpu_job->base);
1357 	v3d_job_put(&csd_job->base);
1358 	v3d_job_put(clean_job);
1359 
1360 	return 0;
1361 
1362 fail_unreserve:
1363 	mutex_unlock(&v3d->sched_lock);
1364 
1365 	drm_gem_unlock_reservations(cpu_job->base.bo, cpu_job->base.bo_count,
1366 				    &acquire_ctx);
1367 
1368 	drm_gem_unlock_reservations(clean_job->bo, clean_job->bo_count,
1369 				    &cpu_job->indirect_csd.acquire_ctx);
1370 
1371 fail:
1372 	v3d_job_cleanup((void *)cpu_job);
1373 	v3d_job_cleanup((void *)csd_job);
1374 	v3d_job_cleanup(clean_job);
1375 	v3d_put_multisync_post_deps(&se);
1376 	kvfree(cpu_job->timestamp_query.queries);
1377 	kvfree(cpu_job->performance_query.queries);
1378 
1379 	return ret;
1380 }
1381