xref: /linux-6.15/drivers/gpu/drm/v3d/v3d_submit.c (revision 0e50fcc2)
1 // SPDX-License-Identifier: GPL-2.0+
2 /*
3  * Copyright (C) 2014-2018 Broadcom
4  * Copyright (C) 2023 Raspberry Pi
5  */
6 
7 #include <drm/drm_syncobj.h>
8 
9 #include "v3d_drv.h"
10 #include "v3d_regs.h"
11 #include "v3d_trace.h"
12 
13 /* Takes the reservation lock on all the BOs being referenced, so that
14  * at queue submit time we can update the reservations.
15  *
16  * We don't lock the RCL the tile alloc/state BOs, or overflow memory
17  * (all of which are on exec->unref_list).  They're entirely private
18  * to v3d, so we don't attach dma-buf fences to them.
19  */
20 static int
21 v3d_lock_bo_reservations(struct v3d_job *job,
22 			 struct ww_acquire_ctx *acquire_ctx)
23 {
24 	int i, ret;
25 
26 	ret = drm_gem_lock_reservations(job->bo, job->bo_count, acquire_ctx);
27 	if (ret)
28 		return ret;
29 
30 	for (i = 0; i < job->bo_count; i++) {
31 		ret = dma_resv_reserve_fences(job->bo[i]->resv, 1);
32 		if (ret)
33 			goto fail;
34 
35 		ret = drm_sched_job_add_implicit_dependencies(&job->base,
36 							      job->bo[i], true);
37 		if (ret)
38 			goto fail;
39 	}
40 
41 	return 0;
42 
43 fail:
44 	drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
45 	return ret;
46 }
47 
48 /**
49  * v3d_lookup_bos() - Sets up job->bo[] with the GEM objects
50  * referenced by the job.
51  * @dev: DRM device
52  * @file_priv: DRM file for this fd
53  * @job: V3D job being set up
54  * @bo_handles: GEM handles
55  * @bo_count: Number of GEM handles passed in
56  *
57  * The command validator needs to reference BOs by their index within
58  * the submitted job's BO list.  This does the validation of the job's
59  * BO list and reference counting for the lifetime of the job.
60  *
61  * Note that this function doesn't need to unreference the BOs on
62  * failure, because that will happen at v3d_exec_cleanup() time.
63  */
64 static int
65 v3d_lookup_bos(struct drm_device *dev,
66 	       struct drm_file *file_priv,
67 	       struct v3d_job *job,
68 	       u64 bo_handles,
69 	       u32 bo_count)
70 {
71 	job->bo_count = bo_count;
72 
73 	if (!job->bo_count) {
74 		/* See comment on bo_index for why we have to check
75 		 * this.
76 		 */
77 		DRM_DEBUG("Rendering requires BOs\n");
78 		return -EINVAL;
79 	}
80 
81 	return drm_gem_objects_lookup(file_priv,
82 				      (void __user *)(uintptr_t)bo_handles,
83 				      job->bo_count, &job->bo);
84 }
85 
86 static void
87 v3d_job_free(struct kref *ref)
88 {
89 	struct v3d_job *job = container_of(ref, struct v3d_job, refcount);
90 	int i;
91 
92 	if (job->bo) {
93 		for (i = 0; i < job->bo_count; i++)
94 			drm_gem_object_put(job->bo[i]);
95 		kvfree(job->bo);
96 	}
97 
98 	dma_fence_put(job->irq_fence);
99 	dma_fence_put(job->done_fence);
100 
101 	if (job->perfmon)
102 		v3d_perfmon_put(job->perfmon);
103 
104 	kfree(job);
105 }
106 
107 static void
108 v3d_render_job_free(struct kref *ref)
109 {
110 	struct v3d_render_job *job = container_of(ref, struct v3d_render_job,
111 						  base.refcount);
112 	struct v3d_bo *bo, *save;
113 
114 	list_for_each_entry_safe(bo, save, &job->unref_list, unref_head) {
115 		drm_gem_object_put(&bo->base.base);
116 	}
117 
118 	v3d_job_free(ref);
119 }
120 
121 void v3d_job_cleanup(struct v3d_job *job)
122 {
123 	if (!job)
124 		return;
125 
126 	drm_sched_job_cleanup(&job->base);
127 	v3d_job_put(job);
128 }
129 
130 void v3d_job_put(struct v3d_job *job)
131 {
132 	if (!job)
133 		return;
134 
135 	kref_put(&job->refcount, job->free);
136 }
137 
138 static int
139 v3d_job_allocate(void **container, size_t size)
140 {
141 	*container = kcalloc(1, size, GFP_KERNEL);
142 	if (!*container) {
143 		DRM_ERROR("Cannot allocate memory for V3D job.\n");
144 		return -ENOMEM;
145 	}
146 
147 	return 0;
148 }
149 
150 static void
151 v3d_job_deallocate(void **container)
152 {
153 	kfree(*container);
154 	*container = NULL;
155 }
156 
157 static int
158 v3d_job_init(struct v3d_dev *v3d, struct drm_file *file_priv,
159 	     struct v3d_job *job, void (*free)(struct kref *ref),
160 	     u32 in_sync, struct v3d_submit_ext *se, enum v3d_queue queue)
161 {
162 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
163 	bool has_multisync = se && (se->flags & DRM_V3D_EXT_ID_MULTI_SYNC);
164 	int ret, i;
165 
166 	job->v3d = v3d;
167 	job->free = free;
168 	job->file = file_priv;
169 
170 	ret = drm_sched_job_init(&job->base, &v3d_priv->sched_entity[queue],
171 				 1, v3d_priv);
172 	if (ret)
173 		return ret;
174 
175 	if (has_multisync) {
176 		if (se->in_sync_count && se->wait_stage == queue) {
177 			struct drm_v3d_sem __user *handle = u64_to_user_ptr(se->in_syncs);
178 
179 			for (i = 0; i < se->in_sync_count; i++) {
180 				struct drm_v3d_sem in;
181 
182 				if (copy_from_user(&in, handle++, sizeof(in))) {
183 					ret = -EFAULT;
184 					DRM_DEBUG("Failed to copy wait dep handle.\n");
185 					goto fail_deps;
186 				}
187 				ret = drm_sched_job_add_syncobj_dependency(&job->base, file_priv, in.handle, 0);
188 
189 				// TODO: Investigate why this was filtered out for the IOCTL.
190 				if (ret && ret != -ENOENT)
191 					goto fail_deps;
192 			}
193 		}
194 	} else {
195 		ret = drm_sched_job_add_syncobj_dependency(&job->base, file_priv, in_sync, 0);
196 
197 		// TODO: Investigate why this was filtered out for the IOCTL.
198 		if (ret && ret != -ENOENT)
199 			goto fail_deps;
200 	}
201 
202 	kref_init(&job->refcount);
203 
204 	return 0;
205 
206 fail_deps:
207 	drm_sched_job_cleanup(&job->base);
208 	return ret;
209 }
210 
211 static void
212 v3d_push_job(struct v3d_job *job)
213 {
214 	drm_sched_job_arm(&job->base);
215 
216 	job->done_fence = dma_fence_get(&job->base.s_fence->finished);
217 
218 	/* put by scheduler job completion */
219 	kref_get(&job->refcount);
220 
221 	drm_sched_entity_push_job(&job->base);
222 }
223 
224 static void
225 v3d_attach_fences_and_unlock_reservation(struct drm_file *file_priv,
226 					 struct v3d_job *job,
227 					 struct ww_acquire_ctx *acquire_ctx,
228 					 u32 out_sync,
229 					 struct v3d_submit_ext *se,
230 					 struct dma_fence *done_fence)
231 {
232 	struct drm_syncobj *sync_out;
233 	bool has_multisync = se && (se->flags & DRM_V3D_EXT_ID_MULTI_SYNC);
234 	int i;
235 
236 	for (i = 0; i < job->bo_count; i++) {
237 		/* XXX: Use shared fences for read-only objects. */
238 		dma_resv_add_fence(job->bo[i]->resv, job->done_fence,
239 				   DMA_RESV_USAGE_WRITE);
240 	}
241 
242 	drm_gem_unlock_reservations(job->bo, job->bo_count, acquire_ctx);
243 
244 	/* Update the return sync object for the job */
245 	/* If it only supports a single signal semaphore*/
246 	if (!has_multisync) {
247 		sync_out = drm_syncobj_find(file_priv, out_sync);
248 		if (sync_out) {
249 			drm_syncobj_replace_fence(sync_out, done_fence);
250 			drm_syncobj_put(sync_out);
251 		}
252 		return;
253 	}
254 
255 	/* If multiple semaphores extension is supported */
256 	if (se->out_sync_count) {
257 		for (i = 0; i < se->out_sync_count; i++) {
258 			drm_syncobj_replace_fence(se->out_syncs[i].syncobj,
259 						  done_fence);
260 			drm_syncobj_put(se->out_syncs[i].syncobj);
261 		}
262 		kvfree(se->out_syncs);
263 	}
264 }
265 
266 static int
267 v3d_setup_csd_jobs_and_bos(struct drm_file *file_priv,
268 			   struct v3d_dev *v3d,
269 			   struct drm_v3d_submit_csd *args,
270 			   struct v3d_csd_job **job,
271 			   struct v3d_job **clean_job,
272 			   struct v3d_submit_ext *se,
273 			   struct ww_acquire_ctx *acquire_ctx)
274 {
275 	int ret;
276 
277 	ret = v3d_job_allocate((void *)job, sizeof(**job));
278 	if (ret)
279 		return ret;
280 
281 	ret = v3d_job_init(v3d, file_priv, &(*job)->base,
282 			   v3d_job_free, args->in_sync, se, V3D_CSD);
283 	if (ret) {
284 		v3d_job_deallocate((void *)job);
285 		return ret;
286 	}
287 
288 	ret = v3d_job_allocate((void *)clean_job, sizeof(**clean_job));
289 	if (ret)
290 		return ret;
291 
292 	ret = v3d_job_init(v3d, file_priv, *clean_job,
293 			   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
294 	if (ret) {
295 		v3d_job_deallocate((void *)clean_job);
296 		return ret;
297 	}
298 
299 	(*job)->args = *args;
300 
301 	ret = v3d_lookup_bos(&v3d->drm, file_priv, *clean_job,
302 			     args->bo_handles, args->bo_handle_count);
303 	if (ret)
304 		return ret;
305 
306 	return v3d_lock_bo_reservations(*clean_job, acquire_ctx);
307 }
308 
309 static void
310 v3d_put_multisync_post_deps(struct v3d_submit_ext *se)
311 {
312 	unsigned int i;
313 
314 	if (!(se && se->out_sync_count))
315 		return;
316 
317 	for (i = 0; i < se->out_sync_count; i++)
318 		drm_syncobj_put(se->out_syncs[i].syncobj);
319 	kvfree(se->out_syncs);
320 }
321 
322 static int
323 v3d_get_multisync_post_deps(struct drm_file *file_priv,
324 			    struct v3d_submit_ext *se,
325 			    u32 count, u64 handles)
326 {
327 	struct drm_v3d_sem __user *post_deps;
328 	int i, ret;
329 
330 	if (!count)
331 		return 0;
332 
333 	se->out_syncs = (struct v3d_submit_outsync *)
334 			kvmalloc_array(count,
335 				       sizeof(struct v3d_submit_outsync),
336 				       GFP_KERNEL);
337 	if (!se->out_syncs)
338 		return -ENOMEM;
339 
340 	post_deps = u64_to_user_ptr(handles);
341 
342 	for (i = 0; i < count; i++) {
343 		struct drm_v3d_sem out;
344 
345 		if (copy_from_user(&out, post_deps++, sizeof(out))) {
346 			ret = -EFAULT;
347 			DRM_DEBUG("Failed to copy post dep handles\n");
348 			goto fail;
349 		}
350 
351 		se->out_syncs[i].syncobj = drm_syncobj_find(file_priv,
352 							    out.handle);
353 		if (!se->out_syncs[i].syncobj) {
354 			ret = -EINVAL;
355 			goto fail;
356 		}
357 	}
358 	se->out_sync_count = count;
359 
360 	return 0;
361 
362 fail:
363 	for (i--; i >= 0; i--)
364 		drm_syncobj_put(se->out_syncs[i].syncobj);
365 	kvfree(se->out_syncs);
366 
367 	return ret;
368 }
369 
370 /* Get data for multiple binary semaphores synchronization. Parse syncobj
371  * to be signaled when job completes (out_sync).
372  */
373 static int
374 v3d_get_multisync_submit_deps(struct drm_file *file_priv,
375 			      struct drm_v3d_extension __user *ext,
376 			      struct v3d_submit_ext *se)
377 {
378 	struct drm_v3d_multi_sync multisync;
379 	int ret;
380 
381 	if (se->in_sync_count || se->out_sync_count) {
382 		DRM_DEBUG("Two multisync extensions were added to the same job.");
383 		return -EINVAL;
384 	}
385 
386 	if (copy_from_user(&multisync, ext, sizeof(multisync)))
387 		return -EFAULT;
388 
389 	if (multisync.pad)
390 		return -EINVAL;
391 
392 	ret = v3d_get_multisync_post_deps(file_priv, se, multisync.out_sync_count,
393 					  multisync.out_syncs);
394 	if (ret)
395 		return ret;
396 
397 	se->in_sync_count = multisync.in_sync_count;
398 	se->in_syncs = multisync.in_syncs;
399 	se->flags |= DRM_V3D_EXT_ID_MULTI_SYNC;
400 	se->wait_stage = multisync.wait_stage;
401 
402 	return 0;
403 }
404 
405 /* Get data for the indirect CSD job submission. */
406 static int
407 v3d_get_cpu_indirect_csd_params(struct drm_file *file_priv,
408 				struct drm_v3d_extension __user *ext,
409 				struct v3d_cpu_job *job)
410 {
411 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
412 	struct v3d_dev *v3d = v3d_priv->v3d;
413 	struct drm_v3d_indirect_csd indirect_csd;
414 	struct v3d_indirect_csd_info *info = &job->indirect_csd;
415 
416 	if (!job) {
417 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
418 		return -EINVAL;
419 	}
420 
421 	if (job->job_type) {
422 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
423 		return -EINVAL;
424 	}
425 
426 	if (copy_from_user(&indirect_csd, ext, sizeof(indirect_csd)))
427 		return -EFAULT;
428 
429 	if (!v3d_has_csd(v3d)) {
430 		DRM_DEBUG("Attempting CSD submit on non-CSD hardware.\n");
431 		return -EINVAL;
432 	}
433 
434 	job->job_type = V3D_CPU_JOB_TYPE_INDIRECT_CSD;
435 	info->offset = indirect_csd.offset;
436 	info->wg_size = indirect_csd.wg_size;
437 	memcpy(&info->wg_uniform_offsets, &indirect_csd.wg_uniform_offsets,
438 	       sizeof(indirect_csd.wg_uniform_offsets));
439 
440 	info->indirect = drm_gem_object_lookup(file_priv, indirect_csd.indirect);
441 
442 	return v3d_setup_csd_jobs_and_bos(file_priv, v3d, &indirect_csd.submit,
443 					  &info->job, &info->clean_job,
444 					  NULL, &info->acquire_ctx);
445 }
446 
447 /* Get data for the query timestamp job submission. */
448 static int
449 v3d_get_cpu_timestamp_query_params(struct drm_file *file_priv,
450 				   struct drm_v3d_extension __user *ext,
451 				   struct v3d_cpu_job *job)
452 {
453 	u32 __user *offsets, *syncs;
454 	struct drm_v3d_timestamp_query timestamp;
455 	unsigned int i;
456 	int err;
457 
458 	if (!job) {
459 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
460 		return -EINVAL;
461 	}
462 
463 	if (job->job_type) {
464 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
465 		return -EINVAL;
466 	}
467 
468 	if (copy_from_user(&timestamp, ext, sizeof(timestamp)))
469 		return -EFAULT;
470 
471 	if (timestamp.pad)
472 		return -EINVAL;
473 
474 	job->job_type = V3D_CPU_JOB_TYPE_TIMESTAMP_QUERY;
475 
476 	job->timestamp_query.queries = kvmalloc_array(timestamp.count,
477 						      sizeof(struct v3d_timestamp_query),
478 						      GFP_KERNEL);
479 	if (!job->timestamp_query.queries)
480 		return -ENOMEM;
481 
482 	offsets = u64_to_user_ptr(timestamp.offsets);
483 	syncs = u64_to_user_ptr(timestamp.syncs);
484 
485 	for (i = 0; i < timestamp.count; i++) {
486 		u32 offset, sync;
487 
488 		if (copy_from_user(&offset, offsets++, sizeof(offset))) {
489 			err = -EFAULT;
490 			goto error;
491 		}
492 
493 		job->timestamp_query.queries[i].offset = offset;
494 
495 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
496 			err = -EFAULT;
497 			goto error;
498 		}
499 
500 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
501 	}
502 	job->timestamp_query.count = timestamp.count;
503 
504 	return 0;
505 
506 error:
507 	v3d_timestamp_query_info_free(&job->timestamp_query, i);
508 	return err;
509 }
510 
511 static int
512 v3d_get_cpu_reset_timestamp_params(struct drm_file *file_priv,
513 				   struct drm_v3d_extension __user *ext,
514 				   struct v3d_cpu_job *job)
515 {
516 	u32 __user *syncs;
517 	struct drm_v3d_reset_timestamp_query reset;
518 	unsigned int i;
519 	int err;
520 
521 	if (!job) {
522 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
523 		return -EINVAL;
524 	}
525 
526 	if (job->job_type) {
527 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
528 		return -EINVAL;
529 	}
530 
531 	if (copy_from_user(&reset, ext, sizeof(reset)))
532 		return -EFAULT;
533 
534 	job->job_type = V3D_CPU_JOB_TYPE_RESET_TIMESTAMP_QUERY;
535 
536 	job->timestamp_query.queries = kvmalloc_array(reset.count,
537 						      sizeof(struct v3d_timestamp_query),
538 						      GFP_KERNEL);
539 	if (!job->timestamp_query.queries)
540 		return -ENOMEM;
541 
542 	syncs = u64_to_user_ptr(reset.syncs);
543 
544 	for (i = 0; i < reset.count; i++) {
545 		u32 sync;
546 
547 		job->timestamp_query.queries[i].offset = reset.offset + 8 * i;
548 
549 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
550 			err = -EFAULT;
551 			goto error;
552 		}
553 
554 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
555 	}
556 	job->timestamp_query.count = reset.count;
557 
558 	return 0;
559 
560 error:
561 	v3d_timestamp_query_info_free(&job->timestamp_query, i);
562 	return err;
563 }
564 
565 /* Get data for the copy timestamp query results job submission. */
566 static int
567 v3d_get_cpu_copy_query_results_params(struct drm_file *file_priv,
568 				      struct drm_v3d_extension __user *ext,
569 				      struct v3d_cpu_job *job)
570 {
571 	u32 __user *offsets, *syncs;
572 	struct drm_v3d_copy_timestamp_query copy;
573 	unsigned int i;
574 	int err;
575 
576 	if (!job) {
577 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
578 		return -EINVAL;
579 	}
580 
581 	if (job->job_type) {
582 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
583 		return -EINVAL;
584 	}
585 
586 	if (copy_from_user(&copy, ext, sizeof(copy)))
587 		return -EFAULT;
588 
589 	if (copy.pad)
590 		return -EINVAL;
591 
592 	job->job_type = V3D_CPU_JOB_TYPE_COPY_TIMESTAMP_QUERY;
593 
594 	job->timestamp_query.queries = kvmalloc_array(copy.count,
595 						      sizeof(struct v3d_timestamp_query),
596 						      GFP_KERNEL);
597 	if (!job->timestamp_query.queries)
598 		return -ENOMEM;
599 
600 	offsets = u64_to_user_ptr(copy.offsets);
601 	syncs = u64_to_user_ptr(copy.syncs);
602 
603 	for (i = 0; i < copy.count; i++) {
604 		u32 offset, sync;
605 
606 		if (copy_from_user(&offset, offsets++, sizeof(offset))) {
607 			err = -EFAULT;
608 			goto error;
609 		}
610 
611 		job->timestamp_query.queries[i].offset = offset;
612 
613 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
614 			err = -EFAULT;
615 			goto error;
616 		}
617 
618 		job->timestamp_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
619 	}
620 	job->timestamp_query.count = copy.count;
621 
622 	job->copy.do_64bit = copy.do_64bit;
623 	job->copy.do_partial = copy.do_partial;
624 	job->copy.availability_bit = copy.availability_bit;
625 	job->copy.offset = copy.offset;
626 	job->copy.stride = copy.stride;
627 
628 	return 0;
629 
630 error:
631 	v3d_timestamp_query_info_free(&job->timestamp_query, i);
632 	return err;
633 }
634 
635 static int
636 v3d_get_cpu_reset_performance_params(struct drm_file *file_priv,
637 				     struct drm_v3d_extension __user *ext,
638 				     struct v3d_cpu_job *job)
639 {
640 	u32 __user *syncs;
641 	u64 __user *kperfmon_ids;
642 	struct drm_v3d_reset_performance_query reset;
643 
644 	if (!job) {
645 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
646 		return -EINVAL;
647 	}
648 
649 	if (job->job_type) {
650 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
651 		return -EINVAL;
652 	}
653 
654 	if (copy_from_user(&reset, ext, sizeof(reset)))
655 		return -EFAULT;
656 
657 	if (reset.nperfmons > V3D_MAX_PERFMONS)
658 		return -EINVAL;
659 
660 	job->job_type = V3D_CPU_JOB_TYPE_RESET_PERFORMANCE_QUERY;
661 
662 	job->performance_query.queries = kvmalloc_array(reset.count,
663 							sizeof(struct v3d_performance_query),
664 							GFP_KERNEL);
665 	if (!job->performance_query.queries)
666 		return -ENOMEM;
667 
668 	syncs = u64_to_user_ptr(reset.syncs);
669 	kperfmon_ids = u64_to_user_ptr(reset.kperfmon_ids);
670 
671 	for (int i = 0; i < reset.count; i++) {
672 		u32 sync;
673 		u64 ids;
674 		u32 __user *ids_pointer;
675 		u32 id;
676 
677 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
678 			kvfree(job->performance_query.queries);
679 			return -EFAULT;
680 		}
681 
682 		job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
683 
684 		if (copy_from_user(&ids, kperfmon_ids++, sizeof(ids))) {
685 			kvfree(job->performance_query.queries);
686 			return -EFAULT;
687 		}
688 
689 		ids_pointer = u64_to_user_ptr(ids);
690 
691 		for (int j = 0; j < reset.nperfmons; j++) {
692 			if (copy_from_user(&id, ids_pointer++, sizeof(id))) {
693 				kvfree(job->performance_query.queries);
694 				return -EFAULT;
695 			}
696 
697 			job->performance_query.queries[i].kperfmon_ids[j] = id;
698 		}
699 	}
700 	job->performance_query.count = reset.count;
701 	job->performance_query.nperfmons = reset.nperfmons;
702 
703 	return 0;
704 }
705 
706 static int
707 v3d_get_cpu_copy_performance_query_params(struct drm_file *file_priv,
708 					  struct drm_v3d_extension __user *ext,
709 					  struct v3d_cpu_job *job)
710 {
711 	u32 __user *syncs;
712 	u64 __user *kperfmon_ids;
713 	struct drm_v3d_copy_performance_query copy;
714 
715 	if (!job) {
716 		DRM_DEBUG("CPU job extension was attached to a GPU job.\n");
717 		return -EINVAL;
718 	}
719 
720 	if (job->job_type) {
721 		DRM_DEBUG("Two CPU job extensions were added to the same CPU job.\n");
722 		return -EINVAL;
723 	}
724 
725 	if (copy_from_user(&copy, ext, sizeof(copy)))
726 		return -EFAULT;
727 
728 	if (copy.pad)
729 		return -EINVAL;
730 
731 	if (copy.nperfmons > V3D_MAX_PERFMONS)
732 		return -EINVAL;
733 
734 	job->job_type = V3D_CPU_JOB_TYPE_COPY_PERFORMANCE_QUERY;
735 
736 	job->performance_query.queries = kvmalloc_array(copy.count,
737 							sizeof(struct v3d_performance_query),
738 							GFP_KERNEL);
739 	if (!job->performance_query.queries)
740 		return -ENOMEM;
741 
742 	syncs = u64_to_user_ptr(copy.syncs);
743 	kperfmon_ids = u64_to_user_ptr(copy.kperfmon_ids);
744 
745 	for (int i = 0; i < copy.count; i++) {
746 		u32 sync;
747 		u64 ids;
748 		u32 __user *ids_pointer;
749 		u32 id;
750 
751 		if (copy_from_user(&sync, syncs++, sizeof(sync))) {
752 			kvfree(job->performance_query.queries);
753 			return -EFAULT;
754 		}
755 
756 		job->performance_query.queries[i].syncobj = drm_syncobj_find(file_priv, sync);
757 
758 		if (copy_from_user(&ids, kperfmon_ids++, sizeof(ids))) {
759 			kvfree(job->performance_query.queries);
760 			return -EFAULT;
761 		}
762 
763 		ids_pointer = u64_to_user_ptr(ids);
764 
765 		for (int j = 0; j < copy.nperfmons; j++) {
766 			if (copy_from_user(&id, ids_pointer++, sizeof(id))) {
767 				kvfree(job->performance_query.queries);
768 				return -EFAULT;
769 			}
770 
771 			job->performance_query.queries[i].kperfmon_ids[j] = id;
772 		}
773 	}
774 	job->performance_query.count = copy.count;
775 	job->performance_query.nperfmons = copy.nperfmons;
776 	job->performance_query.ncounters = copy.ncounters;
777 
778 	job->copy.do_64bit = copy.do_64bit;
779 	job->copy.do_partial = copy.do_partial;
780 	job->copy.availability_bit = copy.availability_bit;
781 	job->copy.offset = copy.offset;
782 	job->copy.stride = copy.stride;
783 
784 	return 0;
785 }
786 
787 /* Whenever userspace sets ioctl extensions, v3d_get_extensions parses data
788  * according to the extension id (name).
789  */
790 static int
791 v3d_get_extensions(struct drm_file *file_priv,
792 		   u64 ext_handles,
793 		   struct v3d_submit_ext *se,
794 		   struct v3d_cpu_job *job)
795 {
796 	struct drm_v3d_extension __user *user_ext;
797 	int ret;
798 
799 	user_ext = u64_to_user_ptr(ext_handles);
800 	while (user_ext) {
801 		struct drm_v3d_extension ext;
802 
803 		if (copy_from_user(&ext, user_ext, sizeof(ext))) {
804 			DRM_DEBUG("Failed to copy submit extension\n");
805 			return -EFAULT;
806 		}
807 
808 		switch (ext.id) {
809 		case DRM_V3D_EXT_ID_MULTI_SYNC:
810 			ret = v3d_get_multisync_submit_deps(file_priv, user_ext, se);
811 			break;
812 		case DRM_V3D_EXT_ID_CPU_INDIRECT_CSD:
813 			ret = v3d_get_cpu_indirect_csd_params(file_priv, user_ext, job);
814 			break;
815 		case DRM_V3D_EXT_ID_CPU_TIMESTAMP_QUERY:
816 			ret = v3d_get_cpu_timestamp_query_params(file_priv, user_ext, job);
817 			break;
818 		case DRM_V3D_EXT_ID_CPU_RESET_TIMESTAMP_QUERY:
819 			ret = v3d_get_cpu_reset_timestamp_params(file_priv, user_ext, job);
820 			break;
821 		case DRM_V3D_EXT_ID_CPU_COPY_TIMESTAMP_QUERY:
822 			ret = v3d_get_cpu_copy_query_results_params(file_priv, user_ext, job);
823 			break;
824 		case DRM_V3D_EXT_ID_CPU_RESET_PERFORMANCE_QUERY:
825 			ret = v3d_get_cpu_reset_performance_params(file_priv, user_ext, job);
826 			break;
827 		case DRM_V3D_EXT_ID_CPU_COPY_PERFORMANCE_QUERY:
828 			ret = v3d_get_cpu_copy_performance_query_params(file_priv, user_ext, job);
829 			break;
830 		default:
831 			DRM_DEBUG_DRIVER("Unknown extension id: %d\n", ext.id);
832 			return -EINVAL;
833 		}
834 
835 		if (ret)
836 			return ret;
837 
838 		user_ext = u64_to_user_ptr(ext.next);
839 	}
840 
841 	return 0;
842 }
843 
844 /**
845  * v3d_submit_cl_ioctl() - Submits a job (frame) to the V3D.
846  * @dev: DRM device
847  * @data: ioctl argument
848  * @file_priv: DRM file for this fd
849  *
850  * This is the main entrypoint for userspace to submit a 3D frame to
851  * the GPU.  Userspace provides the binner command list (if
852  * applicable), and the kernel sets up the render command list to draw
853  * to the framebuffer described in the ioctl, using the command lists
854  * that the 3D engine's binner will produce.
855  */
856 int
857 v3d_submit_cl_ioctl(struct drm_device *dev, void *data,
858 		    struct drm_file *file_priv)
859 {
860 	struct v3d_dev *v3d = to_v3d_dev(dev);
861 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
862 	struct drm_v3d_submit_cl *args = data;
863 	struct v3d_submit_ext se = {0};
864 	struct v3d_bin_job *bin = NULL;
865 	struct v3d_render_job *render = NULL;
866 	struct v3d_job *clean_job = NULL;
867 	struct v3d_job *last_job;
868 	struct ww_acquire_ctx acquire_ctx;
869 	int ret = 0;
870 
871 	trace_v3d_submit_cl_ioctl(&v3d->drm, args->rcl_start, args->rcl_end);
872 
873 	if (args->pad)
874 		return -EINVAL;
875 
876 	if (args->flags &&
877 	    args->flags & ~(DRM_V3D_SUBMIT_CL_FLUSH_CACHE |
878 			    DRM_V3D_SUBMIT_EXTENSION)) {
879 		DRM_INFO("invalid flags: %d\n", args->flags);
880 		return -EINVAL;
881 	}
882 
883 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
884 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
885 		if (ret) {
886 			DRM_DEBUG("Failed to get extensions.\n");
887 			return ret;
888 		}
889 	}
890 
891 	ret = v3d_job_allocate((void *)&render, sizeof(*render));
892 	if (ret)
893 		return ret;
894 
895 	ret = v3d_job_init(v3d, file_priv, &render->base,
896 			   v3d_render_job_free, args->in_sync_rcl, &se, V3D_RENDER);
897 	if (ret) {
898 		v3d_job_deallocate((void *)&render);
899 		goto fail;
900 	}
901 
902 	render->start = args->rcl_start;
903 	render->end = args->rcl_end;
904 	INIT_LIST_HEAD(&render->unref_list);
905 
906 	if (args->bcl_start != args->bcl_end) {
907 		ret = v3d_job_allocate((void *)&bin, sizeof(*bin));
908 		if (ret)
909 			goto fail;
910 
911 		ret = v3d_job_init(v3d, file_priv, &bin->base,
912 				   v3d_job_free, args->in_sync_bcl, &se, V3D_BIN);
913 		if (ret) {
914 			v3d_job_deallocate((void *)&bin);
915 			goto fail;
916 		}
917 
918 		bin->start = args->bcl_start;
919 		bin->end = args->bcl_end;
920 		bin->qma = args->qma;
921 		bin->qms = args->qms;
922 		bin->qts = args->qts;
923 		bin->render = render;
924 	}
925 
926 	if (args->flags & DRM_V3D_SUBMIT_CL_FLUSH_CACHE) {
927 		ret = v3d_job_allocate((void *)&clean_job, sizeof(*clean_job));
928 		if (ret)
929 			goto fail;
930 
931 		ret = v3d_job_init(v3d, file_priv, clean_job,
932 				   v3d_job_free, 0, NULL, V3D_CACHE_CLEAN);
933 		if (ret) {
934 			v3d_job_deallocate((void *)&clean_job);
935 			goto fail;
936 		}
937 
938 		last_job = clean_job;
939 	} else {
940 		last_job = &render->base;
941 	}
942 
943 	ret = v3d_lookup_bos(dev, file_priv, last_job,
944 			     args->bo_handles, args->bo_handle_count);
945 	if (ret)
946 		goto fail;
947 
948 	ret = v3d_lock_bo_reservations(last_job, &acquire_ctx);
949 	if (ret)
950 		goto fail;
951 
952 	if (args->perfmon_id) {
953 		render->base.perfmon = v3d_perfmon_find(v3d_priv,
954 							args->perfmon_id);
955 
956 		if (!render->base.perfmon) {
957 			ret = -ENOENT;
958 			goto fail_perfmon;
959 		}
960 	}
961 
962 	mutex_lock(&v3d->sched_lock);
963 	if (bin) {
964 		bin->base.perfmon = render->base.perfmon;
965 		v3d_perfmon_get(bin->base.perfmon);
966 		v3d_push_job(&bin->base);
967 
968 		ret = drm_sched_job_add_dependency(&render->base.base,
969 						   dma_fence_get(bin->base.done_fence));
970 		if (ret)
971 			goto fail_unreserve;
972 	}
973 
974 	v3d_push_job(&render->base);
975 
976 	if (clean_job) {
977 		struct dma_fence *render_fence =
978 			dma_fence_get(render->base.done_fence);
979 		ret = drm_sched_job_add_dependency(&clean_job->base,
980 						   render_fence);
981 		if (ret)
982 			goto fail_unreserve;
983 		clean_job->perfmon = render->base.perfmon;
984 		v3d_perfmon_get(clean_job->perfmon);
985 		v3d_push_job(clean_job);
986 	}
987 
988 	mutex_unlock(&v3d->sched_lock);
989 
990 	v3d_attach_fences_and_unlock_reservation(file_priv,
991 						 last_job,
992 						 &acquire_ctx,
993 						 args->out_sync,
994 						 &se,
995 						 last_job->done_fence);
996 
997 	v3d_job_put(&bin->base);
998 	v3d_job_put(&render->base);
999 	v3d_job_put(clean_job);
1000 
1001 	return 0;
1002 
1003 fail_unreserve:
1004 	mutex_unlock(&v3d->sched_lock);
1005 fail_perfmon:
1006 	drm_gem_unlock_reservations(last_job->bo,
1007 				    last_job->bo_count, &acquire_ctx);
1008 fail:
1009 	v3d_job_cleanup((void *)bin);
1010 	v3d_job_cleanup((void *)render);
1011 	v3d_job_cleanup(clean_job);
1012 	v3d_put_multisync_post_deps(&se);
1013 
1014 	return ret;
1015 }
1016 
1017 /**
1018  * v3d_submit_tfu_ioctl() - Submits a TFU (texture formatting) job to the V3D.
1019  * @dev: DRM device
1020  * @data: ioctl argument
1021  * @file_priv: DRM file for this fd
1022  *
1023  * Userspace provides the register setup for the TFU, which we don't
1024  * need to validate since the TFU is behind the MMU.
1025  */
1026 int
1027 v3d_submit_tfu_ioctl(struct drm_device *dev, void *data,
1028 		     struct drm_file *file_priv)
1029 {
1030 	struct v3d_dev *v3d = to_v3d_dev(dev);
1031 	struct drm_v3d_submit_tfu *args = data;
1032 	struct v3d_submit_ext se = {0};
1033 	struct v3d_tfu_job *job = NULL;
1034 	struct ww_acquire_ctx acquire_ctx;
1035 	int ret = 0;
1036 
1037 	trace_v3d_submit_tfu_ioctl(&v3d->drm, args->iia);
1038 
1039 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1040 		DRM_DEBUG("invalid flags: %d\n", args->flags);
1041 		return -EINVAL;
1042 	}
1043 
1044 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1045 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
1046 		if (ret) {
1047 			DRM_DEBUG("Failed to get extensions.\n");
1048 			return ret;
1049 		}
1050 	}
1051 
1052 	ret = v3d_job_allocate((void *)&job, sizeof(*job));
1053 	if (ret)
1054 		return ret;
1055 
1056 	ret = v3d_job_init(v3d, file_priv, &job->base,
1057 			   v3d_job_free, args->in_sync, &se, V3D_TFU);
1058 	if (ret) {
1059 		v3d_job_deallocate((void *)&job);
1060 		goto fail;
1061 	}
1062 
1063 	job->base.bo = kcalloc(ARRAY_SIZE(args->bo_handles),
1064 			       sizeof(*job->base.bo), GFP_KERNEL);
1065 	if (!job->base.bo) {
1066 		ret = -ENOMEM;
1067 		goto fail;
1068 	}
1069 
1070 	job->args = *args;
1071 
1072 	for (job->base.bo_count = 0;
1073 	     job->base.bo_count < ARRAY_SIZE(args->bo_handles);
1074 	     job->base.bo_count++) {
1075 		struct drm_gem_object *bo;
1076 
1077 		if (!args->bo_handles[job->base.bo_count])
1078 			break;
1079 
1080 		bo = drm_gem_object_lookup(file_priv, args->bo_handles[job->base.bo_count]);
1081 		if (!bo) {
1082 			DRM_DEBUG("Failed to look up GEM BO %d: %d\n",
1083 				  job->base.bo_count,
1084 				  args->bo_handles[job->base.bo_count]);
1085 			ret = -ENOENT;
1086 			goto fail;
1087 		}
1088 		job->base.bo[job->base.bo_count] = bo;
1089 	}
1090 
1091 	ret = v3d_lock_bo_reservations(&job->base, &acquire_ctx);
1092 	if (ret)
1093 		goto fail;
1094 
1095 	mutex_lock(&v3d->sched_lock);
1096 	v3d_push_job(&job->base);
1097 	mutex_unlock(&v3d->sched_lock);
1098 
1099 	v3d_attach_fences_and_unlock_reservation(file_priv,
1100 						 &job->base, &acquire_ctx,
1101 						 args->out_sync,
1102 						 &se,
1103 						 job->base.done_fence);
1104 
1105 	v3d_job_put(&job->base);
1106 
1107 	return 0;
1108 
1109 fail:
1110 	v3d_job_cleanup((void *)job);
1111 	v3d_put_multisync_post_deps(&se);
1112 
1113 	return ret;
1114 }
1115 
1116 /**
1117  * v3d_submit_csd_ioctl() - Submits a CSD (compute shader) job to the V3D.
1118  * @dev: DRM device
1119  * @data: ioctl argument
1120  * @file_priv: DRM file for this fd
1121  *
1122  * Userspace provides the register setup for the CSD, which we don't
1123  * need to validate since the CSD is behind the MMU.
1124  */
1125 int
1126 v3d_submit_csd_ioctl(struct drm_device *dev, void *data,
1127 		     struct drm_file *file_priv)
1128 {
1129 	struct v3d_dev *v3d = to_v3d_dev(dev);
1130 	struct v3d_file_priv *v3d_priv = file_priv->driver_priv;
1131 	struct drm_v3d_submit_csd *args = data;
1132 	struct v3d_submit_ext se = {0};
1133 	struct v3d_csd_job *job = NULL;
1134 	struct v3d_job *clean_job = NULL;
1135 	struct ww_acquire_ctx acquire_ctx;
1136 	int ret;
1137 
1138 	trace_v3d_submit_csd_ioctl(&v3d->drm, args->cfg[5], args->cfg[6]);
1139 
1140 	if (args->pad)
1141 		return -EINVAL;
1142 
1143 	if (!v3d_has_csd(v3d)) {
1144 		DRM_DEBUG("Attempting CSD submit on non-CSD hardware\n");
1145 		return -EINVAL;
1146 	}
1147 
1148 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1149 		DRM_INFO("invalid flags: %d\n", args->flags);
1150 		return -EINVAL;
1151 	}
1152 
1153 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1154 		ret = v3d_get_extensions(file_priv, args->extensions, &se, NULL);
1155 		if (ret) {
1156 			DRM_DEBUG("Failed to get extensions.\n");
1157 			return ret;
1158 		}
1159 	}
1160 
1161 	ret = v3d_setup_csd_jobs_and_bos(file_priv, v3d, args,
1162 					 &job, &clean_job, &se,
1163 					 &acquire_ctx);
1164 	if (ret)
1165 		goto fail;
1166 
1167 	if (args->perfmon_id) {
1168 		job->base.perfmon = v3d_perfmon_find(v3d_priv,
1169 						     args->perfmon_id);
1170 		if (!job->base.perfmon) {
1171 			ret = -ENOENT;
1172 			goto fail_perfmon;
1173 		}
1174 	}
1175 
1176 	mutex_lock(&v3d->sched_lock);
1177 	v3d_push_job(&job->base);
1178 
1179 	ret = drm_sched_job_add_dependency(&clean_job->base,
1180 					   dma_fence_get(job->base.done_fence));
1181 	if (ret)
1182 		goto fail_unreserve;
1183 
1184 	v3d_push_job(clean_job);
1185 	mutex_unlock(&v3d->sched_lock);
1186 
1187 	v3d_attach_fences_and_unlock_reservation(file_priv,
1188 						 clean_job,
1189 						 &acquire_ctx,
1190 						 args->out_sync,
1191 						 &se,
1192 						 clean_job->done_fence);
1193 
1194 	v3d_job_put(&job->base);
1195 	v3d_job_put(clean_job);
1196 
1197 	return 0;
1198 
1199 fail_unreserve:
1200 	mutex_unlock(&v3d->sched_lock);
1201 fail_perfmon:
1202 	drm_gem_unlock_reservations(clean_job->bo, clean_job->bo_count,
1203 				    &acquire_ctx);
1204 fail:
1205 	v3d_job_cleanup((void *)job);
1206 	v3d_job_cleanup(clean_job);
1207 	v3d_put_multisync_post_deps(&se);
1208 
1209 	return ret;
1210 }
1211 
1212 static const unsigned int cpu_job_bo_handle_count[] = {
1213 	[V3D_CPU_JOB_TYPE_INDIRECT_CSD] = 1,
1214 	[V3D_CPU_JOB_TYPE_TIMESTAMP_QUERY] = 1,
1215 	[V3D_CPU_JOB_TYPE_RESET_TIMESTAMP_QUERY] = 1,
1216 	[V3D_CPU_JOB_TYPE_COPY_TIMESTAMP_QUERY] = 2,
1217 	[V3D_CPU_JOB_TYPE_RESET_PERFORMANCE_QUERY] = 0,
1218 	[V3D_CPU_JOB_TYPE_COPY_PERFORMANCE_QUERY] = 1,
1219 };
1220 
1221 /**
1222  * v3d_submit_cpu_ioctl() - Submits a CPU job to the V3D.
1223  * @dev: DRM device
1224  * @data: ioctl argument
1225  * @file_priv: DRM file for this fd
1226  *
1227  * Userspace specifies the CPU job type and data required to perform its
1228  * operations through the drm_v3d_extension struct.
1229  */
1230 int
1231 v3d_submit_cpu_ioctl(struct drm_device *dev, void *data,
1232 		     struct drm_file *file_priv)
1233 {
1234 	struct v3d_dev *v3d = to_v3d_dev(dev);
1235 	struct drm_v3d_submit_cpu *args = data;
1236 	struct v3d_submit_ext se = {0};
1237 	struct v3d_submit_ext *out_se = NULL;
1238 	struct v3d_cpu_job *cpu_job = NULL;
1239 	struct v3d_csd_job *csd_job = NULL;
1240 	struct v3d_job *clean_job = NULL;
1241 	struct ww_acquire_ctx acquire_ctx;
1242 	int ret;
1243 
1244 	if (args->flags && !(args->flags & DRM_V3D_SUBMIT_EXTENSION)) {
1245 		DRM_INFO("Invalid flags: %d\n", args->flags);
1246 		return -EINVAL;
1247 	}
1248 
1249 	ret = v3d_job_allocate((void *)&cpu_job, sizeof(*cpu_job));
1250 	if (ret)
1251 		return ret;
1252 
1253 	if (args->flags & DRM_V3D_SUBMIT_EXTENSION) {
1254 		ret = v3d_get_extensions(file_priv, args->extensions, &se, cpu_job);
1255 		if (ret) {
1256 			DRM_DEBUG("Failed to get extensions.\n");
1257 			goto fail;
1258 		}
1259 	}
1260 
1261 	/* Every CPU job must have a CPU job user extension */
1262 	if (!cpu_job->job_type) {
1263 		DRM_DEBUG("CPU job must have a CPU job user extension.\n");
1264 		ret = -EINVAL;
1265 		goto fail;
1266 	}
1267 
1268 	if (args->bo_handle_count != cpu_job_bo_handle_count[cpu_job->job_type]) {
1269 		DRM_DEBUG("This CPU job was not submitted with the proper number of BOs.\n");
1270 		ret = -EINVAL;
1271 		goto fail;
1272 	}
1273 
1274 	trace_v3d_submit_cpu_ioctl(&v3d->drm, cpu_job->job_type);
1275 
1276 	ret = v3d_job_init(v3d, file_priv, &cpu_job->base,
1277 			   v3d_job_free, 0, &se, V3D_CPU);
1278 	if (ret) {
1279 		v3d_job_deallocate((void *)&cpu_job);
1280 		goto fail;
1281 	}
1282 
1283 	clean_job = cpu_job->indirect_csd.clean_job;
1284 	csd_job = cpu_job->indirect_csd.job;
1285 
1286 	if (args->bo_handle_count) {
1287 		ret = v3d_lookup_bos(dev, file_priv, &cpu_job->base,
1288 				     args->bo_handles, args->bo_handle_count);
1289 		if (ret)
1290 			goto fail;
1291 
1292 		ret = v3d_lock_bo_reservations(&cpu_job->base, &acquire_ctx);
1293 		if (ret)
1294 			goto fail;
1295 	}
1296 
1297 	mutex_lock(&v3d->sched_lock);
1298 	v3d_push_job(&cpu_job->base);
1299 
1300 	switch (cpu_job->job_type) {
1301 	case V3D_CPU_JOB_TYPE_INDIRECT_CSD:
1302 		ret = drm_sched_job_add_dependency(&csd_job->base.base,
1303 						   dma_fence_get(cpu_job->base.done_fence));
1304 		if (ret)
1305 			goto fail_unreserve;
1306 
1307 		v3d_push_job(&csd_job->base);
1308 
1309 		ret = drm_sched_job_add_dependency(&clean_job->base,
1310 						   dma_fence_get(csd_job->base.done_fence));
1311 		if (ret)
1312 			goto fail_unreserve;
1313 
1314 		v3d_push_job(clean_job);
1315 
1316 		break;
1317 	default:
1318 		break;
1319 	}
1320 	mutex_unlock(&v3d->sched_lock);
1321 
1322 	out_se = (cpu_job->job_type == V3D_CPU_JOB_TYPE_INDIRECT_CSD) ? NULL : &se;
1323 
1324 	v3d_attach_fences_and_unlock_reservation(file_priv,
1325 						 &cpu_job->base,
1326 						 &acquire_ctx, 0,
1327 						 out_se, cpu_job->base.done_fence);
1328 
1329 	switch (cpu_job->job_type) {
1330 	case V3D_CPU_JOB_TYPE_INDIRECT_CSD:
1331 		v3d_attach_fences_and_unlock_reservation(file_priv,
1332 							 clean_job,
1333 							 &cpu_job->indirect_csd.acquire_ctx,
1334 							 0, &se, clean_job->done_fence);
1335 		break;
1336 	default:
1337 		break;
1338 	}
1339 
1340 	v3d_job_put(&cpu_job->base);
1341 	v3d_job_put(&csd_job->base);
1342 	v3d_job_put(clean_job);
1343 
1344 	return 0;
1345 
1346 fail_unreserve:
1347 	mutex_unlock(&v3d->sched_lock);
1348 
1349 	drm_gem_unlock_reservations(cpu_job->base.bo, cpu_job->base.bo_count,
1350 				    &acquire_ctx);
1351 
1352 	drm_gem_unlock_reservations(clean_job->bo, clean_job->bo_count,
1353 				    &cpu_job->indirect_csd.acquire_ctx);
1354 
1355 fail:
1356 	v3d_job_cleanup((void *)cpu_job);
1357 	v3d_job_cleanup((void *)csd_job);
1358 	v3d_job_cleanup(clean_job);
1359 	v3d_put_multisync_post_deps(&se);
1360 	kvfree(cpu_job->timestamp_query.queries);
1361 	kvfree(cpu_job->performance_query.queries);
1362 
1363 	return ret;
1364 }
1365