10b57cec5SDimitry Andric //===--- UndefinedAssignmentChecker.h ---------------------------*- C++ -*--==//
20b57cec5SDimitry Andric //
30b57cec5SDimitry Andric // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
40b57cec5SDimitry Andric // See https://llvm.org/LICENSE.txt for license information.
50b57cec5SDimitry Andric // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
60b57cec5SDimitry Andric //
70b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
80b57cec5SDimitry Andric //
90b57cec5SDimitry Andric // This defines UndefinedAssignmentChecker, a builtin check in ExprEngine that
100b57cec5SDimitry Andric // checks for assigning undefined values.
110b57cec5SDimitry Andric //
120b57cec5SDimitry Andric //===----------------------------------------------------------------------===//
130b57cec5SDimitry Andric 
140b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
150b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
160b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/Checker.h"
170b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/CheckerManager.h"
180b57cec5SDimitry Andric #include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
190b57cec5SDimitry Andric 
200b57cec5SDimitry Andric using namespace clang;
210b57cec5SDimitry Andric using namespace ento;
220b57cec5SDimitry Andric 
230b57cec5SDimitry Andric namespace {
240b57cec5SDimitry Andric class UndefinedAssignmentChecker
250b57cec5SDimitry Andric   : public Checker<check::Bind> {
26*de8261c4SDimitry Andric   const BugType BT{this, "Assigned value is garbage or undefined"};
270b57cec5SDimitry Andric 
280b57cec5SDimitry Andric public:
290b57cec5SDimitry Andric   void checkBind(SVal location, SVal val, const Stmt *S,
300b57cec5SDimitry Andric                  CheckerContext &C) const;
310b57cec5SDimitry Andric };
320b57cec5SDimitry Andric }
330b57cec5SDimitry Andric 
checkBind(SVal location,SVal val,const Stmt * StoreE,CheckerContext & C) const340b57cec5SDimitry Andric void UndefinedAssignmentChecker::checkBind(SVal location, SVal val,
350b57cec5SDimitry Andric                                            const Stmt *StoreE,
360b57cec5SDimitry Andric                                            CheckerContext &C) const {
370b57cec5SDimitry Andric   if (!val.isUndef())
380b57cec5SDimitry Andric     return;
390b57cec5SDimitry Andric 
400b57cec5SDimitry Andric   // Do not report assignments of uninitialized values inside swap functions.
410b57cec5SDimitry Andric   // This should allow to swap partially uninitialized structs
420b57cec5SDimitry Andric   if (const FunctionDecl *EnclosingFunctionDecl =
430b57cec5SDimitry Andric       dyn_cast<FunctionDecl>(C.getStackFrame()->getDecl()))
440b57cec5SDimitry Andric     if (C.getCalleeName(EnclosingFunctionDecl) == "swap")
450b57cec5SDimitry Andric       return;
460b57cec5SDimitry Andric 
470b57cec5SDimitry Andric   ExplodedNode *N = C.generateErrorNode();
480b57cec5SDimitry Andric 
490b57cec5SDimitry Andric   if (!N)
500b57cec5SDimitry Andric     return;
510b57cec5SDimitry Andric 
520b57cec5SDimitry Andric   // Generate a report for this bug.
530b57cec5SDimitry Andric   llvm::SmallString<128> Str;
540b57cec5SDimitry Andric   llvm::raw_svector_ostream OS(Str);
550b57cec5SDimitry Andric 
560b57cec5SDimitry Andric   const Expr *ex = nullptr;
570b57cec5SDimitry Andric 
580b57cec5SDimitry Andric   while (StoreE) {
590b57cec5SDimitry Andric     if (const UnaryOperator *U = dyn_cast<UnaryOperator>(StoreE)) {
600b57cec5SDimitry Andric       OS << "The expression is an uninitialized value. "
610b57cec5SDimitry Andric             "The computed value will also be garbage";
620b57cec5SDimitry Andric 
630b57cec5SDimitry Andric       ex = U->getSubExpr();
640b57cec5SDimitry Andric       break;
650b57cec5SDimitry Andric     }
660b57cec5SDimitry Andric 
670b57cec5SDimitry Andric     if (const BinaryOperator *B = dyn_cast<BinaryOperator>(StoreE)) {
680b57cec5SDimitry Andric       if (B->isCompoundAssignmentOp()) {
690b57cec5SDimitry Andric         if (C.getSVal(B->getLHS()).isUndef()) {
700b57cec5SDimitry Andric           OS << "The left expression of the compound assignment is an "
710b57cec5SDimitry Andric                 "uninitialized value. The computed value will also be garbage";
720b57cec5SDimitry Andric           ex = B->getLHS();
730b57cec5SDimitry Andric           break;
740b57cec5SDimitry Andric         }
750b57cec5SDimitry Andric       }
760b57cec5SDimitry Andric 
770b57cec5SDimitry Andric       ex = B->getRHS();
780b57cec5SDimitry Andric       break;
790b57cec5SDimitry Andric     }
800b57cec5SDimitry Andric 
810b57cec5SDimitry Andric     if (const DeclStmt *DS = dyn_cast<DeclStmt>(StoreE)) {
82a7dea167SDimitry Andric       const VarDecl *VD = cast<VarDecl>(DS->getSingleDecl());
830b57cec5SDimitry Andric       ex = VD->getInit();
840b57cec5SDimitry Andric     }
850b57cec5SDimitry Andric 
860b57cec5SDimitry Andric     if (const auto *CD =
870b57cec5SDimitry Andric             dyn_cast<CXXConstructorDecl>(C.getStackFrame()->getDecl())) {
880b57cec5SDimitry Andric       if (CD->isImplicit()) {
89bdd1243dSDimitry Andric         for (auto *I : CD->inits()) {
900b57cec5SDimitry Andric           if (I->getInit()->IgnoreImpCasts() == StoreE) {
910b57cec5SDimitry Andric             OS << "Value assigned to field '" << I->getMember()->getName()
920b57cec5SDimitry Andric                << "' in implicit constructor is garbage or undefined";
930b57cec5SDimitry Andric             break;
940b57cec5SDimitry Andric           }
950b57cec5SDimitry Andric         }
960b57cec5SDimitry Andric       }
970b57cec5SDimitry Andric     }
980b57cec5SDimitry Andric 
990b57cec5SDimitry Andric     break;
1000b57cec5SDimitry Andric   }
1010b57cec5SDimitry Andric 
1020b57cec5SDimitry Andric   if (OS.str().empty())
103*de8261c4SDimitry Andric     OS << BT.getDescription();
1040b57cec5SDimitry Andric 
105*de8261c4SDimitry Andric   auto R = std::make_unique<PathSensitiveBugReport>(BT, OS.str(), N);
1060b57cec5SDimitry Andric   if (ex) {
1070b57cec5SDimitry Andric     R->addRange(ex->getSourceRange());
1080b57cec5SDimitry Andric     bugreporter::trackExpressionValue(N, ex, *R);
1090b57cec5SDimitry Andric   }
1100b57cec5SDimitry Andric   C.emitReport(std::move(R));
1110b57cec5SDimitry Andric }
1120b57cec5SDimitry Andric 
registerUndefinedAssignmentChecker(CheckerManager & mgr)1130b57cec5SDimitry Andric void ento::registerUndefinedAssignmentChecker(CheckerManager &mgr) {
1140b57cec5SDimitry Andric   mgr.registerChecker<UndefinedAssignmentChecker>();
1150b57cec5SDimitry Andric }
1160b57cec5SDimitry Andric 
shouldRegisterUndefinedAssignmentChecker(const CheckerManager & mgr)1175ffd83dbSDimitry Andric bool ento::shouldRegisterUndefinedAssignmentChecker(const CheckerManager &mgr) {
1180b57cec5SDimitry Andric   return true;
1190b57cec5SDimitry Andric }
120