1 // The MIT License (MIT) 2 // 3 // Copyright (c) 2015 Sergey Makeev, Vadim Slyusarev 4 // 5 // Permission is hereby granted, free of charge, to any person obtaining a copy 6 // of this software and associated documentation files (the "Software"), to deal 7 // in the Software without restriction, including without limitation the rights 8 // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell 9 // copies of the Software, and to permit persons to whom the Software is 10 // furnished to do so, subject to the following conditions: 11 // 12 // The above copyright notice and this permission notice shall be included in 13 // all copies or substantial portions of the Software. 14 // 15 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 16 // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 17 // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE 18 // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER 19 // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, 20 // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN 21 // THE SOFTWARE. 22 23 #include <MTScheduler.h> 24 #include <string.h> // for memset 25 26 namespace MT 27 { 28 29 #ifdef MT_INSTRUMENTED_BUILD 30 TaskScheduler::TaskScheduler(uint32 workerThreadsCount, WorkerThreadParams* workerParameters, IProfilerEventListener* listener) 31 #else 32 TaskScheduler::TaskScheduler(uint32 workerThreadsCount, WorkerThreadParams* workerParameters) 33 #endif 34 : roundRobinThreadIndex(0) 35 , startedThreadsCount(0) 36 { 37 38 #ifdef MT_INSTRUMENTED_BUILD 39 profilerEventListener = listener; 40 #endif 41 42 if (workerThreadsCount != 0) 43 { 44 threadsCount.StoreRelaxed( MT::Clamp(workerThreadsCount, (uint32)1, (uint32)MT_MAX_THREAD_COUNT) ); 45 } else 46 { 47 //query number of processor 48 threadsCount.StoreRelaxed( (uint32)MT::Clamp(Thread::GetNumberOfHardwareThreads() - 1, 1, (int)MT_MAX_THREAD_COUNT) ); 49 } 50 51 // create fiber pool (fibers with standard stack size) 52 for (uint32 i = 0; i < MT_MAX_STANDART_FIBERS_COUNT; i++) 53 { 54 FiberContext& context = standartFiberContexts[i]; 55 context.fiber.Create(MT_STANDART_FIBER_STACK_SIZE, FiberMain, &context); 56 standartFibersAvailable.Push( &context ); 57 } 58 59 // create fiber pool (fibers with extended stack size) 60 for (uint32 i = 0; i < MT_MAX_EXTENDED_FIBERS_COUNT; i++) 61 { 62 FiberContext& context = extendedFiberContexts[i]; 63 context.fiber.Create(MT_EXTENDED_FIBER_STACK_SIZE, FiberMain, &context); 64 extendedFibersAvailable.Push( &context ); 65 } 66 67 68 for (int16 i = 0; i < TaskGroup::MT_MAX_GROUPS_COUNT; i++) 69 { 70 if (i != TaskGroup::DEFAULT) 71 { 72 availableGroups.Push( TaskGroup(i) ); 73 } 74 } 75 76 groupStats[TaskGroup::DEFAULT].SetDebugIsFree(false); 77 78 // create worker thread pool 79 int32 totalThreadsCount = GetWorkersCount(); 80 for (int32 i = 0; i < totalThreadsCount; i++) 81 { 82 threadContext[i].SetThreadIndex(i); 83 threadContext[i].taskScheduler = this; 84 85 uint32 threadCore = i; 86 ThreadPriority::Type priority = ThreadPriority::DEFAULT; 87 if (workerParameters != nullptr) 88 { 89 const WorkerThreadParams& params = workerParameters[i]; 90 91 threadCore = params.core; 92 priority = params.priority; 93 } 94 95 threadContext[i].thread.Start( MT_SCHEDULER_STACK_SIZE, WorkerThreadMain, &threadContext[i], threadCore, priority); 96 } 97 } 98 99 100 TaskScheduler::~TaskScheduler() 101 { 102 int32 totalThreadsCount = GetWorkersCount(); 103 for (int32 i = 0; i < totalThreadsCount; i++) 104 { 105 threadContext[i].state.Store(internal::ThreadState::EXIT); 106 threadContext[i].hasNewTasksEvent.Signal(); 107 } 108 109 for (int32 i = 0; i < totalThreadsCount; i++) 110 { 111 threadContext[i].thread.Join(); 112 } 113 } 114 115 ConcurrentQueueLIFO<FiberContext*>* TaskScheduler::GetFibersStorage(MT::StackRequirements::Type stackRequirements) 116 { 117 ConcurrentQueueLIFO<FiberContext*>* availableFibers = nullptr; 118 switch(stackRequirements) 119 { 120 case MT::StackRequirements::STANDARD: 121 availableFibers = &standartFibersAvailable; 122 break; 123 case MT::StackRequirements::EXTENDED: 124 availableFibers = &extendedFibersAvailable; 125 break; 126 default: 127 MT_REPORT_ASSERT("Unknown stack requrements"); 128 } 129 130 return availableFibers; 131 } 132 133 FiberContext* TaskScheduler::RequestFiberContext(internal::GroupedTask& task) 134 { 135 FiberContext *fiberContext = task.awaitingFiber; 136 if (fiberContext) 137 { 138 task.awaitingFiber = nullptr; 139 return fiberContext; 140 } 141 142 143 MT::StackRequirements::Type stackRequirements = task.desc.stackRequirements; 144 145 ConcurrentQueueLIFO<FiberContext*>* availableFibers = GetFibersStorage(stackRequirements); 146 MT_VERIFY(availableFibers != nullptr, "Can't find fiber storage", return nullptr;); 147 148 if (!availableFibers->TryPopBack(fiberContext)) 149 { 150 MT_REPORT_ASSERT("Fibers pool is empty. Too many fibers running simultaneously."); 151 } 152 153 fiberContext->currentTask = task.desc; 154 fiberContext->currentGroup = task.group; 155 fiberContext->parentFiber = task.parentFiber; 156 fiberContext->stackRequirements = stackRequirements; 157 return fiberContext; 158 } 159 160 void TaskScheduler::ReleaseFiberContext(FiberContext* fiberContext) 161 { 162 MT_ASSERT(fiberContext, "Can't release nullptr Fiber. fiberContext is nullptr"); 163 164 MT::StackRequirements::Type stackRequirements = fiberContext->stackRequirements; 165 fiberContext->Reset(); 166 167 ConcurrentQueueLIFO<FiberContext*>* availableFibers = GetFibersStorage(stackRequirements); 168 MT_VERIFY(availableFibers != nullptr, "Can't find fiber storage", return;); 169 170 availableFibers->Push(fiberContext); 171 } 172 173 FiberContext* TaskScheduler::ExecuteTask(internal::ThreadContext& threadContext, FiberContext* fiberContext) 174 { 175 MT_ASSERT(threadContext.thread.IsCurrentThread(), "Thread context sanity check failed"); 176 177 MT_ASSERT(fiberContext, "Invalid fiber context"); 178 MT_ASSERT(fiberContext->currentTask.IsValid(), "Invalid task"); 179 180 // Set actual thread context to fiber 181 fiberContext->SetThreadContext(&threadContext); 182 183 // Update task status 184 fiberContext->SetStatus(FiberTaskStatus::RUNNED); 185 186 MT_ASSERT(fiberContext->GetThreadContext()->thread.IsCurrentThread(), "Thread context sanity check failed"); 187 188 const void* poolUserData = fiberContext->currentTask.userData; 189 TPoolTaskDestroy poolDestroyFunc = fiberContext->currentTask.poolDestroyFunc; 190 191 // Run current task code 192 Fiber::SwitchTo(threadContext.schedulerFiber, fiberContext->fiber); 193 194 // If task was done 195 FiberTaskStatus::Type taskStatus = fiberContext->GetStatus(); 196 if (taskStatus == FiberTaskStatus::FINISHED) 197 { 198 //destroy task (call dtor) for "fire and forget" type of task from TaskPool 199 if (poolDestroyFunc != nullptr) 200 { 201 poolDestroyFunc(poolUserData); 202 } 203 204 TaskGroup taskGroup = fiberContext->currentGroup; 205 206 TaskScheduler::TaskGroupDescription & groupDesc = threadContext.taskScheduler->GetGroupDesc(taskGroup); 207 208 // Update group status 209 int groupTaskCount = groupDesc.Dec(); 210 MT_ASSERT(groupTaskCount >= 0, "Sanity check failed!"); 211 if (groupTaskCount == 0) 212 { 213 // Restore awaiting tasks 214 threadContext.RestoreAwaitingTasks(taskGroup); 215 216 // All restored tasks can be already finished on this line. 217 // That's why you can't release groups from worker threads, if worker thread release group, than you can't Signal to released group. 218 219 // Signal pending threads that group work is finished. Group can be destroyed after this call. 220 groupDesc.Signal(); 221 222 fiberContext->currentGroup = TaskGroup::INVALID; 223 } 224 225 // Update total task count 226 int allGroupTaskCount = threadContext.taskScheduler->allGroups.Dec(); 227 MT_ASSERT(allGroupTaskCount >= 0, "Sanity check failed!"); 228 if (allGroupTaskCount == 0) 229 { 230 // Notify all tasks in all group finished 231 threadContext.taskScheduler->allGroups.Signal(); 232 } 233 234 FiberContext* parentFiberContext = fiberContext->parentFiber; 235 if (parentFiberContext != nullptr) 236 { 237 int childrenFibersCount = parentFiberContext->childrenFibersCount.DecFetch(); 238 MT_ASSERT(childrenFibersCount >= 0, "Sanity check failed!"); 239 240 if (childrenFibersCount == 0) 241 { 242 // This is a last subtask. Restore parent task 243 MT_ASSERT(threadContext.thread.IsCurrentThread(), "Thread context sanity check failed"); 244 MT_ASSERT(parentFiberContext->GetThreadContext() == nullptr, "Inactive parent should not have a valid thread context"); 245 246 // WARNING!! Thread context can changed here! Set actual current thread context. 247 parentFiberContext->SetThreadContext(&threadContext); 248 249 MT_ASSERT(parentFiberContext->GetThreadContext()->thread.IsCurrentThread(), "Thread context sanity check failed"); 250 251 // All subtasks is done. 252 // Exiting and return parent fiber to scheduler 253 return parentFiberContext; 254 } else 255 { 256 // Other subtasks still exist 257 // Exiting 258 return nullptr; 259 } 260 } else 261 { 262 // Task is finished and no parent task 263 // Exiting 264 return nullptr; 265 } 266 } 267 268 MT_ASSERT(taskStatus != FiberTaskStatus::RUNNED, "Incorrect task status") 269 return nullptr; 270 } 271 272 273 void TaskScheduler::FiberMain(void* userData) 274 { 275 FiberContext& fiberContext = *(FiberContext*)(userData); 276 for(;;) 277 { 278 MT_ASSERT(fiberContext.currentTask.IsValid(), "Invalid task in fiber context"); 279 MT_ASSERT(fiberContext.GetThreadContext(), "Invalid thread context"); 280 MT_ASSERT(fiberContext.GetThreadContext()->thread.IsCurrentThread(), "Thread context sanity check failed"); 281 282 fiberContext.currentTask.taskFunc( fiberContext, fiberContext.currentTask.userData ); 283 284 fiberContext.SetStatus(FiberTaskStatus::FINISHED); 285 286 #ifdef MT_INSTRUMENTED_BUILD 287 fiberContext.fiber.SetName("_idle"); 288 fiberContext.GetThreadContext()->NotifyTaskFinished(fiberContext.currentTask); 289 #endif 290 291 Fiber::SwitchTo(fiberContext.fiber, fiberContext.GetThreadContext()->schedulerFiber); 292 } 293 294 } 295 296 297 bool TaskScheduler::TryStealTask(internal::ThreadContext& threadContext, internal::GroupedTask & task, uint32 workersCount) 298 { 299 if (workersCount <= 1) 300 { 301 return false; 302 } 303 304 uint32 victimIndex = threadContext.random.Get(); 305 306 for (uint32 attempt = 0; attempt < workersCount; attempt++) 307 { 308 uint32 index = victimIndex % workersCount; 309 if (index == threadContext.workerIndex) 310 { 311 victimIndex++; 312 index = victimIndex % workersCount; 313 } 314 315 internal::ThreadContext& victimContext = threadContext.taskScheduler->threadContext[index]; 316 if (victimContext.queue.TryPopNewest(task)) 317 { 318 return true; 319 } 320 321 victimIndex++; 322 } 323 return false; 324 } 325 326 327 void TaskScheduler::WorkerThreadMain( void* userData ) 328 { 329 internal::ThreadContext& context = *(internal::ThreadContext*)(userData); 330 MT_ASSERT(context.taskScheduler, "Task scheduler must be not null!"); 331 332 #ifdef MT_INSTRUMENTED_BUILD 333 const char* threadNames[] = {"worker0","worker1","worker2","worker3","worker4","worker5","worker6","worker7","worker8","worker9","worker10","worker11","worker12"}; 334 if (context.workerIndex < MT_ARRAY_SIZE(threadNames)) 335 { 336 Thread::SetThreadName(threadNames[context.workerIndex]); 337 } else 338 { 339 Thread::SetThreadName("worker_thread"); 340 } 341 #endif 342 343 context.schedulerFiber.CreateFromCurrentThreadAndRun(context.thread, SchedulerFiberMain, userData); 344 } 345 346 347 void TaskScheduler::SchedulerFiberMain( void* userData ) 348 { 349 internal::ThreadContext& context = *(internal::ThreadContext*)(userData); 350 MT_ASSERT(context.taskScheduler, "Task scheduler must be not null!"); 351 352 #ifdef MT_INSTRUMENTED_BUILD 353 context.NotifyThreadCreate(context.workerIndex); 354 #endif 355 356 uint32 workersCount = context.taskScheduler->GetWorkersCount(); 357 int32 totalThreadsCount = context.taskScheduler->threadsCount.LoadRelaxed(); 358 359 context.taskScheduler->startedThreadsCount.IncFetch(); 360 361 //Simple spinlock until all threads is started and initialized 362 for(;;) 363 { 364 int32 initializedThreadsCount = context.taskScheduler->startedThreadsCount.Load(); 365 if (initializedThreadsCount == totalThreadsCount) 366 { 367 break; 368 } 369 370 // sleep some time until all other thread initialized 371 Thread::Sleep(1); 372 } 373 374 HardwareFullMemoryBarrier(); 375 376 #ifdef MT_INSTRUMENTED_BUILD 377 context.NotifyThreadStart(context.workerIndex); 378 #endif 379 380 while(context.state.Load() != internal::ThreadState::EXIT) 381 { 382 internal::GroupedTask task; 383 if (context.queue.TryPopOldest(task) || TryStealTask(context, task, workersCount) ) 384 { 385 // There is a new task 386 FiberContext* fiberContext = context.taskScheduler->RequestFiberContext(task); 387 MT_ASSERT(fiberContext, "Can't get execution context from pool"); 388 MT_ASSERT(fiberContext->currentTask.IsValid(), "Sanity check failed"); 389 MT_ASSERT(fiberContext->stackRequirements == task.desc.stackRequirements, "Sanity check failed"); 390 391 #ifdef MT_INSTRUMENTED_BUILD 392 fiberContext->fiber.SetName(task.desc.debugID); 393 #endif 394 395 while(fiberContext) 396 { 397 #ifdef MT_INSTRUMENTED_BUILD 398 context.NotifyTaskResumed(fiberContext->currentTask); 399 #endif 400 // prevent invalid fiber resume from child tasks, before ExecuteTask is done 401 fiberContext->childrenFibersCount.IncFetch(); 402 403 FiberContext* parentFiber = ExecuteTask(context, fiberContext); 404 405 FiberTaskStatus::Type taskStatus = fiberContext->GetStatus(); 406 407 //release guard 408 int childrenFibersCount = fiberContext->childrenFibersCount.DecFetch(); 409 410 // Can drop fiber context - task is finished 411 if (taskStatus == FiberTaskStatus::FINISHED) 412 { 413 MT_ASSERT( childrenFibersCount == 0, "Sanity check failed"); 414 context.taskScheduler->ReleaseFiberContext(fiberContext); 415 416 // If parent fiber is exist transfer flow control to parent fiber, if parent fiber is null, exit 417 fiberContext = parentFiber; 418 } else 419 { 420 MT_ASSERT( childrenFibersCount >= 0, "Sanity check failed"); 421 422 // No subtasks here and status is not finished, this mean all subtasks already finished before parent return from ExecuteTask 423 if (childrenFibersCount == 0) 424 { 425 MT_ASSERT(parentFiber == nullptr, "Sanity check failed"); 426 } else 427 { 428 // If subtasks still exist, drop current task execution. task will be resumed when last subtask finished 429 break; 430 } 431 432 // If task is in await state drop execution. task will be resumed when RestoreAwaitingTasks called 433 if (taskStatus == FiberTaskStatus::AWAITING_GROUP) 434 { 435 break; 436 } 437 } 438 } //while(fiberContext) 439 440 } else 441 { 442 #ifdef MT_INSTRUMENTED_BUILD 443 context.NotifyThreadIdleBegin(context.workerIndex); 444 #endif 445 446 // Queue is empty and stealing attempt failed 447 // Wait new events 448 context.hasNewTasksEvent.Wait(2000); 449 450 #ifdef MT_INSTRUMENTED_BUILD 451 context.NotifyThreadIdleEnd(context.workerIndex); 452 #endif 453 454 } 455 456 } // main thread loop 457 458 #ifdef MT_INSTRUMENTED_BUILD 459 context.NotifyThreadStop(context.workerIndex); 460 #endif 461 462 } 463 464 void TaskScheduler::RunTasksImpl(ArrayView<internal::TaskBucket>& buckets, FiberContext * parentFiber, bool restoredFromAwaitState) 465 { 466 // This storage is necessary to calculate how many tasks we add to different groups 467 int newTaskCountInGroup[TaskGroup::MT_MAX_GROUPS_COUNT]; 468 469 // Default value is 0 470 memset(&newTaskCountInGroup[0], 0, sizeof(newTaskCountInGroup)); 471 472 // Set parent fiber pointer 473 // Calculate the number of tasks per group 474 // Calculate total number of tasks 475 size_t count = 0; 476 for (size_t i = 0; i < buckets.Size(); ++i) 477 { 478 internal::TaskBucket& bucket = buckets[i]; 479 for (size_t taskIndex = 0; taskIndex < bucket.count; taskIndex++) 480 { 481 internal::GroupedTask & task = bucket.tasks[taskIndex]; 482 483 task.parentFiber = parentFiber; 484 485 int idx = task.group.GetValidIndex(); 486 MT_ASSERT(idx >= 0 && idx < TaskGroup::MT_MAX_GROUPS_COUNT, "Invalid index"); 487 newTaskCountInGroup[idx]++; 488 } 489 490 count += bucket.count; 491 } 492 493 // Increments child fibers count on parent fiber 494 if (parentFiber) 495 { 496 parentFiber->childrenFibersCount.AddFetch((int)count); 497 } 498 499 if (restoredFromAwaitState == false) 500 { 501 // Increase the number of active tasks in the group using data from temporary storage 502 for (size_t i = 0; i < TaskGroup::MT_MAX_GROUPS_COUNT; i++) 503 { 504 int groupNewTaskCount = newTaskCountInGroup[i]; 505 if (groupNewTaskCount > 0) 506 { 507 groupStats[i].Reset(); 508 groupStats[i].Add((uint32)groupNewTaskCount); 509 } 510 } 511 512 // Increments all task in progress counter 513 allGroups.Reset(); 514 allGroups.Add((uint32)count); 515 } else 516 { 517 // If task's restored from await state, counters already in correct state 518 } 519 520 // Add to thread queue 521 for (size_t i = 0; i < buckets.Size(); ++i) 522 { 523 int bucketIndex = roundRobinThreadIndex.IncFetch() % threadsCount.LoadRelaxed(); 524 internal::ThreadContext & context = threadContext[bucketIndex]; 525 526 internal::TaskBucket& bucket = buckets[i]; 527 528 for(;;) 529 { 530 bool res = context.queue.Add(bucket.tasks, bucket.count); 531 if (res == true) 532 { 533 break; 534 } 535 536 //Can't add new tasks onto the queue. Look like the job system is overloaded. Wait some time and try again. 537 //TODO: implement waiting until workers done using events. 538 Thread::Sleep(10); 539 } 540 541 context.hasNewTasksEvent.Signal(); 542 } 543 } 544 545 void TaskScheduler::RunAsync(TaskGroup group, const TaskHandle* taskHandleArray, uint32 taskHandleCount) 546 { 547 MT_ASSERT(!IsWorkerThread(), "Can't use RunAsync inside Task. Use FiberContext.RunAsync() instead."); 548 549 ArrayView<internal::GroupedTask> buffer(MT_ALLOCATE_ON_STACK(sizeof(internal::GroupedTask) * taskHandleCount), taskHandleCount); 550 551 uint32 bucketCount = MT::Min((uint32)GetWorkersCount(), taskHandleCount); 552 ArrayView<internal::TaskBucket> buckets(MT_ALLOCATE_ON_STACK(sizeof(internal::TaskBucket) * bucketCount), bucketCount); 553 554 internal::DistibuteDescriptions(group, taskHandleArray, buffer, buckets); 555 RunTasksImpl(buckets, nullptr, false); 556 } 557 558 bool TaskScheduler::WaitGroup(TaskGroup group, uint32 milliseconds) 559 { 560 MT_VERIFY(IsWorkerThread() == false, "Can't use WaitGroup inside Task. Use FiberContext.WaitGroupAndYield() instead.", return false); 561 562 TaskScheduler::TaskGroupDescription & groupDesc = GetGroupDesc(group); 563 564 return groupDesc.Wait(milliseconds); 565 } 566 567 bool TaskScheduler::WaitAll(uint32 milliseconds) 568 { 569 MT_VERIFY(IsWorkerThread() == false, "Can't use WaitAll inside Task.", return false); 570 571 return allGroups.Wait(milliseconds); 572 } 573 574 bool TaskScheduler::IsEmpty() 575 { 576 for (uint32 i = 0; i < MT_MAX_THREAD_COUNT; i++) 577 { 578 if (!threadContext[i].queue.IsEmpty()) 579 { 580 return false; 581 } 582 } 583 return true; 584 } 585 586 int32 TaskScheduler::GetWorkersCount() const 587 { 588 return threadsCount.LoadRelaxed(); 589 } 590 591 bool TaskScheduler::IsWorkerThread() const 592 { 593 for (uint32 i = 0; i < MT_MAX_THREAD_COUNT; i++) 594 { 595 if (threadContext[i].thread.IsCurrentThread()) 596 { 597 return true; 598 } 599 } 600 return false; 601 } 602 603 TaskGroup TaskScheduler::CreateGroup() 604 { 605 MT_ASSERT(IsWorkerThread() == false, "Can't use CreateGroup inside Task."); 606 607 TaskGroup group; 608 if (!availableGroups.TryPopBack(group)) 609 { 610 MT_REPORT_ASSERT("Group pool is empty"); 611 } 612 613 int idx = group.GetValidIndex(); 614 615 MT_ASSERT(groupStats[idx].GetDebugIsFree() == true, "Bad logic!"); 616 groupStats[idx].SetDebugIsFree(false); 617 618 return group; 619 } 620 621 void TaskScheduler::ReleaseGroup(TaskGroup group) 622 { 623 MT_ASSERT(IsWorkerThread() == false, "Can't use ReleaseGroup inside Task."); 624 MT_ASSERT(group.IsValid(), "Invalid group ID"); 625 626 int idx = group.GetValidIndex(); 627 628 MT_ASSERT(groupStats[idx].GetDebugIsFree() == false, "Group already released"); 629 groupStats[idx].SetDebugIsFree(true); 630 631 availableGroups.Push(group); 632 } 633 634 TaskScheduler::TaskGroupDescription & TaskScheduler::GetGroupDesc(TaskGroup group) 635 { 636 MT_ASSERT(group.IsValid(), "Invalid group ID"); 637 638 int idx = group.GetValidIndex(); 639 TaskScheduler::TaskGroupDescription & groupDesc = groupStats[idx]; 640 641 MT_ASSERT(groupDesc.GetDebugIsFree() == false, "Invalid group"); 642 return groupDesc; 643 } 644 } 645 646 647