1 /*-
2 * Copyright (c) 2003-2007,2016 Tim Kientzle
3 * All rights reserved.
4 *
5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions
7 * are met:
8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution.
13 *
14 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR(S) ``AS IS'' AND ANY EXPRESS OR
15 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
16 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
17 * IN NO EVENT SHALL THE AUTHOR(S) BE LIABLE FOR ANY DIRECT, INDIRECT,
18 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
19 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
20 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
21 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
23 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */
25 #include "test.h"
26 __FBSDID("$FreeBSD$");
27
28 #define UMASK 022
29
30 /*
31 * Github Issue #746 describes a problem in which hardlink targets are
32 * not adequately checked and can be used to modify entries outside of
33 * the sandbox.
34 */
35
36 /*
37 * Verify that ARCHIVE_EXTRACT_SECURE_NODOTDOT disallows '..' in hardlink
38 * targets.
39 */
DEFINE_TEST(test_write_disk_secure746a)40 DEFINE_TEST(test_write_disk_secure746a)
41 {
42 struct archive *a;
43 struct archive_entry *ae;
44
45 /* Start with a known umask. */
46 assertUmask(UMASK);
47
48 /* The target directory we're going to try to affect. */
49 assertMakeDir("target", 0700);
50 assertMakeFile("target/foo", 0700, "unmodified");
51
52 /* The sandbox dir we're going to work within. */
53 assertMakeDir("sandbox", 0700);
54 assertChdir("sandbox");
55
56 /* Create an archive_write_disk object. */
57 assert((a = archive_write_disk_new()) != NULL);
58 archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_NODOTDOT);
59
60 /* Attempt to hardlink to the target directory. */
61 assert((ae = archive_entry_new()) != NULL);
62 archive_entry_copy_pathname(ae, "bar");
63 archive_entry_set_mode(ae, AE_IFREG | 0777);
64 archive_entry_set_size(ae, 8);
65 archive_entry_copy_hardlink(ae, "../target/foo");
66 assertEqualInt(ARCHIVE_FAILED, archive_write_header(a, ae));
67 assertEqualInt(ARCHIVE_FATAL, archive_write_data(a, "modified", 8));
68 archive_entry_free(ae);
69
70 /* Verify that target file contents are unchanged. */
71 assertTextFileContents("unmodified", "../target/foo");
72
73 assertEqualIntA(a, ARCHIVE_FATAL, archive_write_close(a));
74 archive_write_free(a);
75 }
76
77 /*
78 * Verify that ARCHIVE_EXTRACT_SECURE_NOSYMLINK disallows symlinks in hardlink
79 * targets.
80 */
DEFINE_TEST(test_write_disk_secure746b)81 DEFINE_TEST(test_write_disk_secure746b)
82 {
83 #if defined(_WIN32) && !defined(__CYGWIN__)
84 skipping("archive_write_disk security checks not supported on Windows");
85 #else
86 struct archive *a;
87 struct archive_entry *ae;
88
89 /* Start with a known umask. */
90 assertUmask(UMASK);
91
92 /* The target directory we're going to try to affect. */
93 assertMakeDir("target", 0700);
94 assertMakeFile("target/foo", 0700, "unmodified");
95
96 /* The sandbox dir we're going to work within. */
97 assertMakeDir("sandbox", 0700);
98 assertChdir("sandbox");
99
100 /* Create an archive_write_disk object. */
101 assert((a = archive_write_disk_new()) != NULL);
102 archive_write_disk_set_options(a, ARCHIVE_EXTRACT_SECURE_SYMLINKS);
103
104 /* Create a symlink to the target directory. */
105 assert((ae = archive_entry_new()) != NULL);
106 archive_entry_copy_pathname(ae, "symlink");
107 archive_entry_set_mode(ae, AE_IFLNK | 0777);
108 archive_entry_copy_symlink(ae, "../target");
109 assertEqualIntA(a, ARCHIVE_OK, archive_write_header(a, ae));
110 archive_entry_free(ae);
111
112 /* Attempt to hardlink to the target directory via the symlink. */
113 assert((ae = archive_entry_new()) != NULL);
114 archive_entry_copy_pathname(ae, "bar");
115 archive_entry_set_mode(ae, AE_IFREG | 0777);
116 archive_entry_set_size(ae, 8);
117 archive_entry_copy_hardlink(ae, "symlink/foo");
118 assertEqualIntA(a, ARCHIVE_FAILED, archive_write_header(a, ae));
119 assertEqualIntA(a, ARCHIVE_FATAL, archive_write_data(a, "modified", 8));
120 archive_entry_free(ae);
121
122 /* Verify that target file contents are unchanged. */
123 assertTextFileContents("unmodified", "../target/foo");
124
125 assertEqualIntA(a, ARCHIVE_FATAL, archive_write_close(a));
126 archive_write_free(a);
127 #endif
128 }
129