1 //===--- ThrowKeywordMissingCheck.cpp - clang-tidy-------------------------===//
2 //
3 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
4 // See https://llvm.org/LICENSE.txt for license information.
5 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
6 //
7 //===----------------------------------------------------------------------===//
8
9 #include "ThrowKeywordMissingCheck.h"
10 #include "clang/AST/ASTContext.h"
11 #include "clang/ASTMatchers/ASTMatchFinder.h"
12
13 using namespace clang::ast_matchers;
14
15 namespace clang {
16 namespace tidy {
17 namespace bugprone {
18
registerMatchers(MatchFinder * Finder)19 void ThrowKeywordMissingCheck::registerMatchers(MatchFinder *Finder) {
20 auto CtorInitializerList =
21 cxxConstructorDecl(hasAnyConstructorInitializer(anything()));
22
23 Finder->addMatcher(
24 cxxConstructExpr(
25 hasType(cxxRecordDecl(
26 isSameOrDerivedFrom(matchesName("[Ee]xception|EXCEPTION")))),
27 unless(anyOf(
28 hasAncestor(
29 stmt(anyOf(cxxThrowExpr(), callExpr(), returnStmt()))),
30 hasAncestor(decl(anyOf(varDecl(), fieldDecl()))),
31 hasAncestor(expr(cxxNewExpr(hasAnyPlacementArg(anything())))),
32 allOf(hasAncestor(CtorInitializerList),
33 unless(hasAncestor(cxxCatchStmt()))))))
34 .bind("temporary-exception-not-thrown"),
35 this);
36 }
37
check(const MatchFinder::MatchResult & Result)38 void ThrowKeywordMissingCheck::check(const MatchFinder::MatchResult &Result) {
39 const auto *TemporaryExpr =
40 Result.Nodes.getNodeAs<Expr>("temporary-exception-not-thrown");
41
42 diag(TemporaryExpr->getBeginLoc(), "suspicious exception object created but "
43 "not thrown; did you mean 'throw %0'?")
44 << TemporaryExpr->getType().getBaseTypeIdentifier()->getName();
45 }
46
47 } // namespace bugprone
48 } // namespace tidy
49 } // namespace clang
50