Changes in mod.rs

bac0e78f - aarch64: Disable csdb emission by default (#12932)

Wed, 01 Apr 2026 22:16:55 +0000

aarch64: Disable csdb emission by default (#12932)* aarch64: Disable csdb emission by defaultThis has a massive performance penalty on macOS, for example, and peercompilers are not emitting this as part of on-by-default mitigations.This commit preserves the option to emit it with an aarch64-specific`use_csdb` flag, but the default is now `false` meaning that this is notemitted by default.Closes #12789* Fix tests* Fix tests & review comments* Use ISLE rule introduced List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

b112bb85 - Migrate winch-codegen to `wasmtime_environ::error` (#12297)

Fri, 09 Jan 2026 19:20:48 +0000

Migrate winch-codegen to `wasmtime_environ::error` (#12297) List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

dacd33b0 - winch: Simplify constant handling, part 2/N (#10989)

Mon, 09 Jun 2025 22:54:51 +0000

winch: Simplify constant handling, part 2/N (#10989)* winch: Introduce register allocation for scratch registersThis commit introduces a register allocator for scratch registers. Theobjective of this change is to make it generally safer to work withscratch registers and prevent accidental clobbering of said registers.This approach also has the advantage that allows for a more naturalabstraction over ISA-dependent scratch register definitions, e.g., wecan easily encode that fact that in aarch64 x16 and x17 are consideredscratch registers, while in x64 Winch's ABI defines a single globalscratch register.* winch: Hook up the scratch allocator in each of the backendsThis commit makes use of the scratch register allocator in both thex64 and aarch64 backends for immediate value loading.Given that the MacroAssembler is the boundary between ISA-agnosticcode and ISA-dependent code, it seems to be the natural location forthis allocator to live.The allocator gives exclusive access to a scratch register of aparticular class, through the `Masm::with_scratch` method. Note thatthe semantics of this allocator don't involve spilling or any otherform of register availability resolution. If a register is requestedand it's not available, this method will panic.* Apply `cargo fmt`* Update disassembly testsEven though the entire change doens't contain major funcitonalchanges, a side effect of improving the constant handling in aarch64is that we perform better instruction selection for instructions thatdeal with immediattes, improving the generated code in some cases.* Review edits List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

90ac295e - Update Wasmtime to the 2024 Rust Edition (#10806)

Mon, 19 May 2025 16:40:55 +0000

Update Wasmtime to the 2024 Rust Edition (#10806)* Update Wasmtime to the 2024 Rust EditionNow that our MSRV supports the 2024 edition it's possible to make thisswitch. This commit moves Wasmtime to the 2024 Edition to keepup-to-date with Rust idioms and access many of the edition featuresexclusive to the 2024 edition.prtest:full* Reformat with the 2024 edition List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

3326ff9f - Update to wasm-tools 229 (#10601)

Thu, 17 Apr 2025 22:13:51 +0000

Update to wasm-tools 229 (#10601)* Update to wasm-tools 229A number of changes here:* New component model intrinsics (ignored for now, they're async-related)* Updated interface for reading binary operators, fixing a longstanding panic in Wasmtime.* Plumbing for error-context being a gated feature now in the component model.prtest:full* Update to crates.io List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

8bc01990 - winch: Gracefully handle unsupported Wasm types (#9949)

Mon, 13 Jan 2025 17:40:10 +0000

winch: Gracefully handle unsupported Wasm types (#9949)* winch: Gracefully handle unsuppported Wasm typesFollow-up to https://github.com/bytecodealliance/wasmtime/pull/9851Prior to this commit, Winch's ABI layer would panic on unsupported Wasmtypes, i.e., `v128`, `externref`.This commit ensures that a recoverable error is returned in case anunsupported type is found in a function signature.This change is particularly helpful to start running spec tests foraarch64.* Fix unit tests for x64/aarch64 abi List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

b93e1bc0 - winch: Gracefully handle compilation errors (#9851)

Wed, 01 Jan 2025 18:11:39 +0000

winch: Gracefully handle compilation errors (#9851)* winch: Gracefully handle compilation errorsCloses: https://github.com/bytecodealliance/wasmtime/issues/8096This commit threads `anyhow::Result` through most of Winch'scompilation process in order to gracefully handle compilation errorsgracefully instead of panicking.The error classification is intentionally very granular, to avoid stringallocation which could impact compilation performance.The errors are largely fit in two categories:* Unimplemented/Unsupported* InternalThe firs category signals partial or no support for Wasmtime featuresand or Wasm proposals. These errors are meant to be temporary whilesuch features or proposals are in development.The second category signals that a compilation invariant was not met.These errors are considered internal and their presence usually meansa bug in the compiler.* Include `Result` in the MacroAssemblerThis commit updates the MacroAssembler trait to require returning`Result` on every method in the interface, making it easier todetect partial support for Masm instructions. List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

f247a75b - Update to target-lexicon 0.13.0 (#9752)

Fri, 06 Dec 2024 17:45:40 +0000

Update to target-lexicon 0.13.0 (#9752)* Update to target-lexicon 0.13.0Pulling in bytecodealliance/target-lexicon#115 to lay the foundation forsome big-endian work in Pulley* Fix more compile errors List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

7ef8f2e2 - winch: Improve frame handling (#9708)

Wed, 04 Dec 2024 19:12:09 +0000

winch: Improve frame handling (#9708)This commit addresses issues identified while working on issue #8091. Itimproves the frame handling in Winch to prevent subtle bugs and enhancethe robustness of the code generation process.Previously, there was no clear mechanism to verify when the frame wasfully set up and safe to access the local slots allocated for registerarguments, including the special slots used for the `VMContext`. Asa result, it was possible to inadvertently read from uninitializedmemory if calls were made before the frame was properly set up andsealed.This commit introduces two main changes with the objective to helpreduce the risk of introducing bugs related to the above:* A `CodeGenPhase` trait, used via the type state pattern to clearly gate the operations allowed during each phase of the code generation process.* Improve the semantics of locals, by clearly separating the notion of Wasm locals and special locals used by the compiler. This specialization allows a more accurate representation of the semantics of Wasm locals and their index space. List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

194b4803 - Remove the use of `MemoryStyle` in Winch (#9581)

Thu, 07 Nov 2024 16:28:36 +0000

Remove the use of `MemoryStyle` in Winch (#9581)This applies a similar change as #9576 but to Winch. Similar to theprevious PR one case needed some reshuffling, but otherwise all currentbehavior is maintained and this should otherwise be a refactoring. List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

65181b36 - More refactoring to remove `MemoryStyle` (#9543)

Tue, 05 Nov 2024 20:35:52 +0000

More refactoring to remove `MemoryStyle` (#9543)* Remove tuple return value of `MemorysStyle::for_memory`The second option is always `tunables.memory_guard_size`, so propagatethis to the various locations reading it.* Remove `offset_guard_size` from compiler `Heap` structsPush reading `Tunables` down further into where it's needed instead ofhaving duplicate storage per-heap.* Plumb wasm memory types further down in WinchThis commit plumbs `wasmtime_environ::Memory` further down the stack inWinch to where heaps are processed. This avoids an extra layer ofindirection through a `Heap` type which peels apart a `Memory` to pickout a few fields. In the future this'll be used with more helpers on`Memory` to simplify the static/dynamic memory cases.* Plumb memory type further down in CraneliftThis commit removes the `HeapStyle` structure from Cranelift and insteadplumbs the `wasmtime_environ::Memory` type further down the stackthrough in `HeapData` (same as Winch before this commit). This removesredundant fields in `MemoryType` and continues to push down the`MemoryStyle` structure even further.This commit additionally and unconditionally defines a `GlobalValue` forthe heap limit of memory. This is unused most of the time for 32-bitwasm and is conditionally used depending on how bounds checks aregenerated. This is a small amount of bloat to each function sincepreviously functions that didn't need this `GlobalValue` elided it. Afuture refactoring, however, will make it a bit more clear how this isused even for "static" memories.* Update test expectations List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

2a7f0653 - Remove the `wasmtime_environ::MemoryPlan` type (#9532)

Thu, 31 Oct 2024 20:46:03 +0000

Remove the `wasmtime_environ::MemoryPlan` type (#9532)* Remove the `wasmtime_environ::MemoryPlan` typeThis is the equivalent of #9530 for memories. The goal of this commit isto eventually remove the abstraction layer of `MemoryPlan` and`MemoryStyle` in favor of directly reading the configuration of`Tunables`. The prediction is that it will be simpler to work directlywith configured values instead of a layer of abstraction between theconfiguration and the runtime which needs to be evolved independently tocapture how to interpret the configuration.Like with #9530 my plan is to eventually remove the `MemoryStyle` typeitself, but that'll be a larger change, so it's deferred to a futurePR.* Fix shared memory disabled build List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

2f684ba1 - winch: Implement Fuel-Based Interruption (#9472)

Tue, 22 Oct 2024 19:14:23 +0000

winch: Implement Fuel-Based Interruption (#9472)* winch: Implement Fuel-Based InterruptionCloses: https://github.com/bytecodealliance/wasmtime/issues/8090This commit introduces the initial implementation of fuel-basedinterruption in Winch.To maintain consistency with existing fuel semantics, thisimplementation closely follows the Wasmtime/Cranelift approach, with thefollowing exception:* Local Fuel Cache: Given Winch's emphasis on compilation speed, this implementation does not optimize for minimizing loads and stores. As a result, checking and incrementing fuel currently requires explicit loads and stores. Future optimizations may be considered to improve this aspect.This commit also includes a small refactoring in the visitor, whichintroduces more generic "visitor hook" which enable handling the invariants that needto happen before and after emitting machine code for each Wasm operator.* Use the vmruntime limits directly* Remove unsupported fuel warning List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

6a5a4f27 - winch: Remove some `#[allow(dead_code)]` directives (#9480)

Mon, 21 Oct 2024 09:32:53 +0000

winch: Remove some `#[allow(dead_code)]` directives (#9480)This commit simply removes some `#[allow(dead_code)]` which are nolonger needed as well as the the notion of callee-saved registers.The notion of callee-saved registers was primarily used in the earlydays when Winch generated its own trampolines, however, trampolines arenow emitted through Cranelift. List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

d36d4708 - winch(arm64): fpu arithmetics (add, sub, mul, div, min, max) and regalloc (#8365)

Mon, 15 Apr 2024 19:42:28 +0000

winch(arm64): fpu arithmetics (add, sub, mul, div, min, max) and regalloc (#8365)* winch(arm64): fpu arithmetics (add, sub, mul, div, min, max)Signed-off-by: Edoardo Vacchi * disas: add fpu test cases (add)Signed-off-by: Edoardo Vacchi * winch(arm64): regalloc for fpuSigned-off-by: Edoardo Vacchi * disas: add fpu test cases (add64)Signed-off-by: Edoardo Vacchi * disas: add fpu test casesSigned-off-by: Edoardo Vacchi * Apply suggestions from code reviewCo-authored-by: Saúl Cabrera * Apply suggestions from code reviewCo-authored-by: Saúl Cabrera * add todo for f32 movSigned-off-by: Edoardo Vacchi ---------Signed-off-by: Edoardo Vacchi Co-authored-by: Saúl Cabrera List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

65c04b90 - winch: Add support for address maps (#8295)

Thu, 04 Apr 2024 12:11:35 +0000

winch: Add support for address maps (#8295)* winch: Add support for address mapsCloses https://github.com/bytecodealliance/wasmtime/issues/8095This commit adds support for generating address maps for Winch. Give that source code locations and machine code offsets are machine independent, one objective of this change is introduce minimal methods to the MacroAssesmbler and Asssembler implementations and tries to accomodate the bulk of the work in the ISA independent `CodeGen` module.* Update method documentation to match implementation List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

70b076d3 - Migrate all Winch filetests to `tests/disas` (#8243)

Wed, 27 Mar 2024 14:44:46 +0000

Migrate all Winch filetests to `tests/disas` (#8243)* Switch Winch tests to ATT syntax* Update all test expectations* Move all winch tests to `disas` folder* Add `test = "winch"` to `disas`* Add `test = "winch"` to all winch test files* Stub out bits to get AArch64 Winch tests working* Update expectations for all aarch64 winch tests* Update flags in Winch testsUse CLI syntax as that's what `flags` was repurposes as in the new testsuite.* Update all test expectations for x64 winch* Omit more offsets by default* Delete now-dead code* Update an error message* Update non-winch test expectations List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

355990b4 - Exit through Cranelift-generated trampolines for builtins (#8152)

Fri, 22 Mar 2024 20:34:26 +0000

Exit through Cranelift-generated trampolines for builtins (#8152)* Exit through Cranelift-generated trampolines for builtinsThis commit changes how builtin functions in Wasmtime (think`memory.grow`) are implemented. These functions are required to exitthrough some manner of trampoline to handle runtime requirements forbacktracing right now. Currently this is done via inline assembly foreach architecture (or external assembly for s390x). This is a bitunfortunate as it's a lot of hand-coding and making sure everything isright, and it's not easy to update as it's multiple platforms to update.The change in this commit is to instead use Cranelift-generatedtrampolines for this purpose instead. The path for invoking a builtinfunction now looks like:* Wasm code calls a statically known symbol for each builtin.* The statically known symbol will perform exit trampoline duties (e.g. pc/fp/etc) and then load a function pointer to the host implementation.* The host implementation is invoked and then proceeds as usual.The main new piece for this PR is that all wasm modules and functionsare compiled in parallel but an output of this compilation phase is whatbuiltin functions are required. All builtin functions are then unionedtogether into one set and then anything required is generated justafterwards. That means that only one builtin-trampoline per-module isgenerated per-builtin.This work is inspired by #8135 and my own personal desire to have asmuch about our ABI details flowing through Cranelift as we can. This intheory makes it more flexible to deal with future improvements to ourABI.prtest:full* Fix some build issues* Update winch test expectations* Update Winch to use new builtin shims.This commit refactors the Winch compiler to use the new trampolines forall Wasmtime builtins created in the previous commits. This required afair bit of refactoring to handle plumbing through a new kind ofrelocation and function call.Winch's `FuncEnv` now contains a `PrimaryMap` from `UserExternalNameRef`to `UserExternalName`. This is because there's now more than one kind ofname than just wasm function relocations, so the raw index space of`UserExternalNameRef` is no longer applicable. This required threading`FuncEnv` to more locations along with some refactorings to ensure thatlifetimes work out ok.The `CompiledFunction` no longer stores a trait object of how to mapname refs to names and now directly has a `Primarymap`. This also meansthat Winch's return value from its `TargetIsa` is a `CompiledFunction`as opposed to the previous just-a-`MachBuffer` so it can also package upall the relocation information. This ends up having `winch-codegen`depend on `wasmtime-cranelift-shared` as a new dependency.* Review feedback List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

d69ba34e - winch: Switch to using cranelift for all trampolines (#8109)

Thu, 21 Mar 2024 17:59:43 +0000

winch: Switch to using cranelift for all trampolines (#8109)* Switch winch over to using cranelift for all trampolines* Fix unused code warnings* Fix unused code warningsprtest:full List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs

45d574ca - winch: Introduce `TypeConverter` in the function environment (#8052)

Tue, 12 Mar 2024 18:44:33 +0000

winch: Introduce `TypeConverter` in the function environment (#8052)This commit introduces the `TypeConverter` struct, used to enable partial borrowing of a `ModuleTranslation` and a `ModuleTypesBuilder`. This makes it easier to defer type conversions until they are actually needed, for example when resolving callee signatures. winch: Create converter until it's actually needed. List of files: /wasmtime-44.0.1/winch/codegen/src/isa/aarch64/mod.rs