b2369103 - Fix default architecture for winch (#6242)

Wed, 19 Apr 2023 19:45:48 +0000

Fix default architecture for winch (#6242)* Fix default architecture for winchThis updates the `winch/codegen/build.rs` script to default to thetarget architecture being compiled for as opposed to the hostarchitecture that's performing the compile.Closes #6241* Auto-enable other future architectures List of files: /wasmtime-44.0.1/winch/codegen/build.rs

013b35ff - winch: Refactoring wasmtime compiler integration pieces to share more between Cranelift and Winch (#5944)

Wed, 08 Mar 2023 15:07:13 +0000

winch: Refactoring wasmtime compiler integration pieces to share more between Cranelift and Winch (#5944)* Enable the native target by default in winchMatch cranelift-codegen's build script where if no architecture isexplicitly enabled then the host architecture is implicitly enabled.* Refactor Cranelift's ISA builder to share more with WinchThis commit refactors the `Builder` type to have a type parameterrepresenting the finished ISA with Cranelift and Winch having their owntypedefs for `Builder` to represent their own builders. The intention isto use this shared functionality to produce more shared code between thetwo codegen backends.* Moving compiler shared components to a separate crate* Restore native flag inference in compiler buildingThis fixes an oversight from the previous commits to use`cranelift-native` to infer flags for the native host when using defaultsettings with Wasmtime.* Move `Compiler::page_size_align` into wasmtime-environThe `cranelift-codegen` crate doesn't need this and winch wants the sameimplementation, so shuffle it around so everyone has access to it.* Fill out `Compiler::{flags, isa_flags}` for WinchThese are easy enough to plumb through with some shared code forWasmtime.* Plumb the `is_branch_protection_enabled` flag for WinchJust forwarding an isa-specific setting accessor.* Moving executable creation to shared compiler crate* Adding builder back in and removing from shared crate* Refactoring the shared pieces for the `CompilerBuilder`I decided to move a couple things around from Alex's initial changes.Instead of having the shared builder do everything, I went back tohaving each compiler have a distinct builder implementation. Irefactored most of the flag setting logic into a single shared location,so we can still reduce the amount of code duplication.With them being separate, we don't need to maintain things like`LinkOpts` which Winch doesn't currently use. We also have an avenue toerror when certain flags are sent to Winch if we don't support them. I'mhoping this will make things more maintainable as we build out Winch.I'm still unsure about keeping everything shared in a single crate(`cranelift_shared`). It's starting to feel like this crate is doing toomuch, which makes it difficult to name. There does seem to be a need fortwo distinct abstraction: creating the final executable and the handlingof shared/ISA flags when building the compiler. I could make them intotwo separate crates, but there doesn't seem to be enough there yet tojustify it.* Documentation updates, and renaming the finish method* Adding back in a default temporarily to pass tests, and removing some unused imports* Fixing winch tests with wrong method name* Removing unused imports from codegen shared crate* Apply documentation formatting updatesCo-authored-by: Saúl Cabrera * Adding back in cranelift_native flag inferring* Adding new shared crate to publish list* Adding write feature to pass cargo check---------Co-authored-by: Alex Crichton Co-authored-by: Saúl Cabrera List of files: /wasmtime-44.0.1/winch/codegen/build.rs

Changes in build.rs

b2369103 - Fix default architecture for winch (#6242)

013b35ff - winch: Refactoring wasmtime compiler integration pieces to share more between Cranelift and Winch (#5944)