en Copyright 2015 Java http://172.16.0.5:8080/history/wasmtime-44.0.1/tests/misc_testsuite/winch/fuel_stack_alignment.wat#b5627a86 winch: Sync registers and locals before fuel check (#9554)* winch: Sync registers and locals before fuel checkThis commit fixes a fuzz bug in which the stack was misaligned whencalling the out-of-fuel builtin function.The misalignment was introduced by a erroneous handling of the thecontrol flow merge introduced by the fuel check conditional. In general,prior to every branch emission, a spill to memory is needed to avoidissues at the control flow merge.Note that we don't have many cases like this one in Winch's codebase (3in total), however as a follow-up, it's probably worth consideringintroducing a stronger abstraction around branching to ensure that thiscase is handled whenever an arbitrary branch needs to be introduced.This change solely focuses on the fix and does not introduce anyrefactoring. I plan to follow-up with investigating a better branchingstrategy, since we would need to introduce a similar pattern for epochhandling.I used `wasm-tools shink` to shrink the original program, whichI decided to add as part of an integration test.* Move the test fixture List of files: /wasmtime-44.0.1/tests/misc_testsuite/winch/fuel_stack_alignment.wat Tue, 05 Nov 2024 18:03:32 +0000 Saúl Cabrera <saulecabrera@gmail.com>